Re: [PATCH v11 05/13] vfio/pci: Register an iommu fault handler
by kernel test robot
Hi Eric,
I love your patch! Perhaps something to improve:
[auto build test WARNING on v5.10-rc4]
[also build test WARNING on next-20201116]
[cannot apply to vfio/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Eric-Auger/SMMUv3-Nested-Stage-S...
base: 09162bc32c880a791c6c0668ce0745cf7958f576
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/747ef402696e1192684908ca99f06f3d6...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Eric-Auger/SMMUv3-Nested-Stage-Setup-VFIO-part/20201116-190742
git checkout 747ef402696e1192684908ca99f06f3d68466c04
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/vfio.h:16,
from drivers/vfio/pci/vfio_pci.c:26:
include/uapi/linux/vfio.h:1231:34: error: field 'config' has incomplete type
1231 | struct iommu_pasid_table_config config; /* used on SET */
| ^~~~~~
>> drivers/vfio/pci/vfio_pci.c:339:5: warning: no previous prototype for 'vfio_pci_iommu_dev_fault_handler' [-Wmissing-prototypes]
339 | int vfio_pci_iommu_dev_fault_handler(struct iommu_fault *fault, void *data)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/vfio_pci_iommu_dev_fault_handler +339 drivers/vfio/pci/vfio_pci.c
338
> 339 int vfio_pci_iommu_dev_fault_handler(struct iommu_fault *fault, void *data)
340 {
341 struct vfio_pci_device *vdev = (struct vfio_pci_device *)data;
342 struct vfio_region_dma_fault *reg =
343 (struct vfio_region_dma_fault *)vdev->fault_pages;
344 struct iommu_fault *new;
345 u32 head, tail, size;
346 int ret = -EINVAL;
347
348
349 if (WARN_ON(!reg))
350 return ret;
351
352 mutex_lock(&vdev->fault_queue_lock);
353
354 head = reg->head;
355 tail = reg->tail;
356 size = reg->nb_entries;
357
358 new = (struct iommu_fault *)(vdev->fault_pages + reg->offset +
359 head * reg->entry_size);
360
361 if (CIRC_SPACE(head, tail, size) < 1) {
362 ret = -ENOSPC;
363 goto unlock;
364 }
365
366 *new = *fault;
367 reg->head = (head + 1) % size;
368 ret = 0;
369 unlock:
370 mutex_unlock(&vdev->fault_queue_lock);
371 return ret;
372 }
373
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
Purchase Order Receipt
by QuickBooks Payments
Please find our purchase order attached to this email. Thank you for your business - we appreciate it very much.Sincerely,
------------------------ Purchase Order Summary --------------------------Sale # : 7510Sale Date: 11/16/2020Total: $3,525.00The complete version has been provided as an attachment to this email.---------------------------------------------------------------------
1 year, 10 months
drivers/mmc/host/tmio_mmc.c:177 tmio_mmc_probe() warn: argument 3 to %08lx specifier is cast from pointer
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1
commit: 54d8454436a205682bd89d66d8d9eedbc8452d15 mmc: host: Enable compile testing of multiple drivers
config: arm64-randconfig-m031-20201113 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/mmc/host/tmio_mmc.c:177 tmio_mmc_probe() warn: argument 3 to %08lx specifier is cast from pointer
vim +177 drivers/mmc/host/tmio_mmc.c
94b110aff8679b1 Kuninori Morimoto 2015-01-13 170
de501af98dfab9c Ian Molton 2015-04-27 171 ret = devm_request_irq(&pdev->dev, irq, tmio_mmc_irq,
de501af98dfab9c Ian Molton 2015-04-27 172 IRQF_TRIGGER_FALLING,
d9618e9f1a057ef Yong Zhang 2011-09-22 173 dev_name(&pdev->dev), host);
8e7bfdb37ac001c Magnus Damm 2011-05-06 174 if (ret)
8e7bfdb37ac001c Magnus Damm 2011-05-06 175 goto host_remove;
8e7bfdb37ac001c Magnus Damm 2011-05-06 176
311f3ac76826bfd Guennadi Liakhovetski 2010-05-19 @177 pr_info("%s at 0x%08lx irq %d\n", mmc_hostname(host->mmc),
^^^^^^^
These are supposed to be %p so that the kernel can hide them and avoid
showing kernel pointers to user space.
8e7bfdb37ac001c Magnus Damm 2011-05-06 178 (unsigned long)host->ctl, irq);
4a48998fa16121d Ian Molton 2008-07-15 179
4a48998fa16121d Ian Molton 2008-07-15 180 return 0;
4a48998fa16121d Ian Molton 2008-07-15 181
8e7bfdb37ac001c Magnus Damm 2011-05-06 182 host_remove:
8e7bfdb37ac001c Magnus Damm 2011-05-06 183 tmio_mmc_host_remove(host);
94b110aff8679b1 Kuninori Morimoto 2015-01-13 184 host_free:
94b110aff8679b1 Kuninori Morimoto 2015-01-13 185 tmio_mmc_host_free(host);
7ee422dc6e947fc Magnus Damm 2010-02-17 186 cell_disable:
7ee422dc6e947fc Magnus Damm 2010-02-17 187 if (cell->disable)
b6147490e6aac82 Guennadi Liakhovetski 2011-03-23 188 cell->disable(pdev);
4a48998fa16121d Ian Molton 2008-07-15 189 out:
4a48998fa16121d Ian Molton 2008-07-15 190 return ret;
4a48998fa16121d Ian Molton 2008-07-15 191 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
[omap-audio:peter/linux-next-wip 75/80] sound/soc/ti/omap-mcasp.c:603:7: warning: variable 'fclk_rate' set but not used
by kernel test robot
tree: https://github.com/omap-audio/linux-audio peter/linux-next-wip
head: f899206cc108ac21f28d9f41a74ca3e2f41cbe09
commit: 1cac23d930f92fb60a20e7e93675fc590514cc61 [75/80] omap: mcasp: add omap-mcasp.* and add to Kconfig, Makefile
config: nios2-randconfig-r011-20201116 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/omap-audio/linux-audio/commit/1cac23d930f92fb60a20e7e9...
git remote add omap-audio https://github.com/omap-audio/linux-audio
git fetch --no-tags omap-audio peter/linux-next-wip
git checkout 1cac23d930f92fb60a20e7e93675fc590514cc61
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
sound/soc/ti/omap-mcasp.c: In function 'asoc_mcasp_probe':
>> sound/soc/ti/omap-mcasp.c:603:7: warning: variable 'fclk_rate' set but not used [-Wunused-but-set-variable]
603 | long fclk_rate;
| ^~~~~~~~~
vim +/fclk_rate +603 sound/soc/ti/omap-mcasp.c
598
599 static int asoc_mcasp_probe(struct platform_device *pdev)
600 {
601 struct omap_mcasp *mcasp;
602 struct resource *res;
> 603 long fclk_rate;
604 int ret = 0;
605
606 mcasp = devm_kzalloc(&pdev->dev, sizeof(struct omap_mcasp), GFP_KERNEL);
607 if (!mcasp) {
608 dev_err(&pdev->dev, "cannot allocate memory\n");
609 return -ENOMEM;
610 }
611
612 spin_lock_init(&mcasp->lock);
613
614 omap_mcasp_dai_dma_params[0].filter_data = "axevt";
615
616 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
617 if (!res) {
618 dev_err(&pdev->dev, "no resource\n");
619 return -ENODEV;
620 }
621
622 mcasp->base = devm_ioremap_resource(&pdev->dev, res);
623 if (!mcasp->base) {
624 dev_err(&pdev->dev, "cannot remap\n");
625 return -ENOMEM;
626 }
627
628 mcasp->irq = platform_get_irq(pdev, 0);
629 if (mcasp->irq < 0) {
630 dev_err(&pdev->dev, "invalid IRQ number\n");
631 return mcasp->irq;
632 }
633
634 ret = devm_request_threaded_irq(&pdev->dev, mcasp->irq, NULL,
635 omap_mcasp_irq_handler,
636 IRQF_ONESHOT, "McASP", mcasp);
637 if (ret) {
638 dev_err(mcasp->dev, "IRQ request failed\n");
639 return ret;
640 }
641
642 mcasp->fclk = clk_get(&pdev->dev, "fck");
643 if (!mcasp->fclk) {
644 dev_err(mcasp->dev, "cant get fck\n");
645 return -ENODEV;
646 }
647
648 pm_runtime_enable(&pdev->dev);
649 pm_runtime_get_sync(&pdev->dev);
650
651 fclk_rate = clk_get_rate(mcasp->fclk);
652
653 platform_set_drvdata(pdev, mcasp);
654 mcasp->dev = &pdev->dev;
655
656 ret = snd_soc_register_component(&pdev->dev, &omap_mcasp_component,
657 &omap_mcasp_dai, 1);
658 if (ret < 0)
659 goto err_dai;
660
661 pm_runtime_put_sync(&pdev->dev);
662
663 return sdma_pcm_platform_register(&pdev->dev, "axevt", NULL);;
664
665 err_dai:
666 pm_runtime_put_sync(&pdev->dev);
667 pm_runtime_disable(&pdev->dev);
668 return ret;
669 }
670
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
Re: [PATCH v12 15/15] iommu/smmuv3: Add PASID cache invalidation per PASID
by kernel test robot
Hi Eric,
I love your patch! Perhaps something to improve:
[auto build test WARNING on iommu/next]
[also build test WARNING on linus/master v5.10-rc4 next-20201116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Eric-Auger/SMMUv3-Nested-Stage-S...
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: arm64-randconfig-r034-20201115 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c044709b8fbea2a9a375e4173a6bd735f6866c0c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/95e4ccc61b7a7c06e1e0c6c01f362d590...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Eric-Auger/SMMUv3-Nested-Stage-Setup-IOMMU-part/20201116-185039
git checkout 95e4ccc61b7a7c06e1e0c6c01f362d590136ad3c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3010:8: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
if (!info->flags & IOMMU_INV_PASID_FLAGS_PASID)
^ ~
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3010:8: note: add parentheses after the '!' to evaluate the bitwise operator first
if (!info->flags & IOMMU_INV_PASID_FLAGS_PASID)
^
( )
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3010:8: note: add parentheses around left hand side expression to silence this warning
if (!info->flags & IOMMU_INV_PASID_FLAGS_PASID)
^
( )
1 warning generated.
vim +3010 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
2960
2961 static int
2962 arm_smmu_cache_invalidate(struct iommu_domain *domain, struct device *dev,
2963 struct iommu_cache_invalidate_info *inv_info)
2964 {
2965 struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain);
2966 struct arm_smmu_device *smmu = smmu_domain->smmu;
2967
2968 if (smmu_domain->stage != ARM_SMMU_DOMAIN_NESTED)
2969 return -EINVAL;
2970
2971 if (!smmu)
2972 return -EINVAL;
2973
2974 if (inv_info->version != IOMMU_CACHE_INVALIDATE_INFO_VERSION_1)
2975 return -EINVAL;
2976
2977 if (inv_info->cache & IOMMU_CACHE_INV_TYPE_IOTLB) {
2978 if (inv_info->granularity == IOMMU_INV_GRANU_PASID) {
2979 struct iommu_inv_pasid_info *info =
2980 &inv_info->granu.pasid_info;
2981
2982 if (!(info->flags & IOMMU_INV_PASID_FLAGS_ARCHID) ||
2983 (info->flags & IOMMU_INV_PASID_FLAGS_PASID))
2984 return -EINVAL;
2985
2986 __arm_smmu_tlb_inv_context(smmu_domain, info->archid);
2987
2988 } else if (inv_info->granularity == IOMMU_INV_GRANU_ADDR) {
2989 struct iommu_inv_addr_info *info = &inv_info->granu.addr_info;
2990 size_t size = info->nb_granules * info->granule_size;
2991 bool leaf = info->flags & IOMMU_INV_ADDR_FLAGS_LEAF;
2992
2993 if (!(info->flags & IOMMU_INV_ADDR_FLAGS_ARCHID) ||
2994 (info->flags & IOMMU_INV_ADDR_FLAGS_PASID))
2995 return -EINVAL;
2996
2997 __arm_smmu_tlb_inv_range(info->addr, size,
2998 info->granule_size, leaf,
2999 smmu_domain, info->archid);
3000
3001 arm_smmu_cmdq_issue_sync(smmu);
3002 } else {
3003 return -EINVAL;
3004 }
3005 } else if (inv_info->cache & IOMMU_CACHE_INV_TYPE_PASID) {
3006 if (inv_info->granularity == IOMMU_INV_GRANU_PASID) {
3007 struct iommu_inv_pasid_info *info =
3008 &inv_info->granu.pasid_info;
3009
> 3010 if (!info->flags & IOMMU_INV_PASID_FLAGS_PASID)
3011 return -EINVAL;
3012
3013 arm_smmu_sync_cd(smmu_domain, info->pasid, true);
3014 } else {
3015 return -ENOENT;
3016 }
3017 } else { /* IOMMU_CACHE_INV_TYPE_DEV_IOTLB */
3018 return -ENOENT;
3019 }
3020 return 0;
3021 }
3022
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
Re: [PATCH v4 27/27] scripts: kernel-doc: validate kernel-doc markup with the actual names
by kernel test robot
Hi Mauro,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20201116]
[cannot apply to drm-intel/for-linux-next s390/features tip/timers/core tip/irq/core tip/sched/core linus/master hnaz-linux-mm/master v5.10-rc4 v5.10-rc3 v5.10-rc2 v5.10-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/net-phy-fi...
base: 034307507118f7e1b18f8403c85af2216da2dc94
config: x86_64-randconfig-r024-20201116 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c044709b8fbea2a9a375e4173a6bd735f6866c0c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/11cd9cdaab434fff7a5edbee8d8d4ce9e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mauro-Carvalho-Chehab/net-phy-fix-kernel-doc-markups/20201116-191847
git checkout 11cd9cdaab434fff7a5edbee8d8d4ce9ef11acf4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/staging/gasket/gasket_core.c:1556: warning: wrong kernel-doc identifier on line:
* Lookup a name by number in a num_name table.
drivers/staging/gasket/gasket_core.c:1655: warning: wrong kernel-doc identifier on line:
* Asynchronously waits on device.
--
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:46: warning: Enum value 'LOADER_CMD_XFER_QUERY' not described in enum 'ish_loader_commands'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:46: warning: Enum value 'LOADER_CMD_XFER_FRAGMENT' not described in enum 'ish_loader_commands'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:46: warning: Enum value 'LOADER_CMD_START' not described in enum 'ish_loader_commands'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:108: warning: Function parameter or member 'reserved' not described in 'loader_msg_hdr'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:196: warning: Function parameter or member 'data' not described in 'response_info'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:196: warning: Function parameter or member 'max_size' not described in 'response_info'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:196: warning: Function parameter or member 'size' not described in 'response_info'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:196: warning: Function parameter or member 'error' not described in 'response_info'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:196: warning: Function parameter or member 'received' not described in 'response_info'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:196: warning: Function parameter or member 'wait_queue' not described in 'response_info'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:233: warning: Function parameter or member 'loader_ishtp_cl' not described in 'ishtp_cl_data'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:233: warning: Function parameter or member 'cl_device' not described in 'ishtp_cl_data'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:233: warning: Function parameter or member 'response' not described in 'ishtp_cl_data'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:233: warning: Function parameter or member 'flag_retry' not described in 'ishtp_cl_data'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:233: warning: Function parameter or member 'retry_count' not described in 'ishtp_cl_data'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:252: warning: Function parameter or member 'client_data' not described in 'get_firmware_variant'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:252: warning: Function parameter or member 'filename' not described in 'get_firmware_variant'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:281: warning: Function parameter or member 'out_msg' not described in 'loader_cl_send'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:281: warning: Function parameter or member 'out_size' not described in 'loader_cl_send'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:281: warning: Function parameter or member 'in_msg' not described in 'loader_cl_send'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:281: warning: Function parameter or member 'in_size' not described in 'loader_cl_send'
>> drivers/hid/intel-ish-hid/ishtp-fw-loader.c:281: warning: expecting prototype for Send message from host to firmware(). Prototype was for loader_cl_send() instead
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:445: warning: Function parameter or member 'cl_device' not described in 'loader_cl_event_cb'
drivers/hid/intel-ish-hid/ishtp-fw-loader.c:445: warning: Excess function parameter 'device' description in 'loader_cl_event_cb'
>> drivers/hid/intel-ish-hid/ishtp-fw-loader.c:551: warning: expecting prototype for Loads ISH firmware using ishtp interface(). Prototype was for ish_fw_xfer_ishtp() instead
>> drivers/hid/intel-ish-hid/ishtp-fw-loader.c:745: warning: expecting prototype for Start executing ISH main firmware(). Prototype was for ish_fw_start() instead
>> drivers/hid/intel-ish-hid/ishtp-fw-loader.c:767: warning: expecting prototype for Loads ISH firmware from host(). Prototype was for load_fw_from_host() instead
--
>> drivers/gpu/drm/gma500/intel_gmbus.c:386: warning: expecting prototype for intel_gmbus_setup(). Prototype was for gma_intel_setup_gmbus() instead
--
drivers/gpu/drm/gma500/intel_bios.c:581: warning: Function parameter or member 'dev' not described in 'psb_intel_destroy_bios'
>> drivers/gpu/drm/gma500/intel_bios.c:581: warning: expecting prototype for Destroy and free VBT data(). Prototype was for psb_intel_destroy_bios() instead
--
drivers/gpu/drm/gma500/gma_display.c:27: warning: Function parameter or member 'crtc' not described in 'gma_pipe_has_type'
drivers/gpu/drm/gma500/gma_display.c:27: warning: Function parameter or member 'type' not described in 'gma_pipe_has_type'
>> drivers/gpu/drm/gma500/gma_display.c:27: warning: expecting prototype for Returns whether any output on the specified pipe is of the specified type(). Prototype was for gma_pipe_has_type() instead
>> drivers/gpu/drm/gma500/gma_display.c:184: warning: wrong kernel-doc identifier on line:
* Sets the power management mode of the pipe and plane.
drivers/gpu/drm/gma500/gma_display.c:573: warning: Function parameter or member 'crtc' not described in 'gma_crtc_save'
>> drivers/gpu/drm/gma500/gma_display.c:573: warning: expecting prototype for Save HW states of given crtc(). Prototype was for gma_crtc_save() instead
drivers/gpu/drm/gma500/gma_display.c:616: warning: Function parameter or member 'crtc' not described in 'gma_crtc_restore'
>> drivers/gpu/drm/gma500/gma_display.c:616: warning: expecting prototype for Restore HW states of given crtc(). Prototype was for gma_crtc_restore() instead
--
>> drivers/gpu/drm/gma500/psb_irq.c:130: warning: wrong kernel-doc identifier on line:
* Display controller interrupt handler for pipe event.
--
>> drivers/gpu/drm/gma500/psb_intel_display.c:75: warning: wrong kernel-doc identifier on line:
* Return the pipe currently connected to the panel fitter,
--
drivers/gpu/drm/gma500/psb_intel_sdvo.c:230: warning: Function parameter or member 'psb_intel_sdvo' not described in 'psb_intel_sdvo_write_sdvox'
drivers/gpu/drm/gma500/psb_intel_sdvo.c:230: warning: Function parameter or member 'val' not described in 'psb_intel_sdvo_write_sdvox'
>> drivers/gpu/drm/gma500/psb_intel_sdvo.c:230: warning: expecting prototype for but always writes both(). Prototype was for psb_intel_sdvo_write_sdvox() instead
>> drivers/gpu/drm/gma500/psb_intel_sdvo.c:592: warning: wrong kernel-doc identifier on line:
* Return whether each input is trained.
drivers/gpu/drm/gma500/psb_intel_sdvo.c:1831: warning: Function parameter or member 'dev_priv' not described in 'psb_intel_sdvo_select_ddc_bus'
drivers/gpu/drm/gma500/psb_intel_sdvo.c:1831: warning: Function parameter or member 'sdvo' not described in 'psb_intel_sdvo_select_ddc_bus'
drivers/gpu/drm/gma500/psb_intel_sdvo.c:1831: warning: Function parameter or member 'reg' not described in 'psb_intel_sdvo_select_ddc_bus'
>> drivers/gpu/drm/gma500/psb_intel_sdvo.c:1831: warning: expecting prototype for Choose the appropriate DDC bus for control bus switch command for this(). Prototype was for psb_intel_sdvo_select_ddc_bus() instead
--
drivers/gpu/drm/mga/mga_ioc32.c:2: warning: Cannot understand * \file mga_ioc32.c
on line 2 - I thought it was a doc line
drivers/gpu/drm/mga/mga_ioc32.c:171: warning: Function parameter or member 'filp' not described in 'mga_compat_ioctl'
drivers/gpu/drm/mga/mga_ioc32.c:171: warning: Function parameter or member 'cmd' not described in 'mga_compat_ioctl'
drivers/gpu/drm/mga/mga_ioc32.c:171: warning: Function parameter or member 'arg' not described in 'mga_compat_ioctl'
>> drivers/gpu/drm/mga/mga_ioc32.c:171: warning: expecting prototype for Called whenever a 32(). Prototype was for mga_compat_ioctl() instead
vim +1556 drivers/staging/gasket/gasket_core.c
80666096eb78f0e Todd Poynor 2018-07-31 1554
80666096eb78f0e Todd Poynor 2018-07-31 1555 /**
80666096eb78f0e Todd Poynor 2018-07-31 @1556 * Lookup a name by number in a num_name table.
80666096eb78f0e Todd Poynor 2018-07-31 1557 * @num: Number to lookup.
80666096eb78f0e Todd Poynor 2018-07-31 1558 * @table: Array of num_name structures, the table for the lookup.
80666096eb78f0e Todd Poynor 2018-07-31 1559 *
80666096eb78f0e Todd Poynor 2018-07-31 1560 * Description: Searches for num in the table. If found, the
80666096eb78f0e Todd Poynor 2018-07-31 1561 * corresponding name is returned; otherwise NULL
80666096eb78f0e Todd Poynor 2018-07-31 1562 * is returned.
80666096eb78f0e Todd Poynor 2018-07-31 1563 *
80666096eb78f0e Todd Poynor 2018-07-31 1564 * The table must have a NULL name pointer at the end.
80666096eb78f0e Todd Poynor 2018-07-31 1565 */
88c8a377c00ff3a Todd Poynor 2018-07-31 1566 const char *gasket_num_name_lookup(uint num,
88c8a377c00ff3a Todd Poynor 2018-07-31 1567 const struct gasket_num_name *table)
80666096eb78f0e Todd Poynor 2018-07-31 1568 {
80666096eb78f0e Todd Poynor 2018-07-31 1569 uint i = 0;
80666096eb78f0e Todd Poynor 2018-07-31 1570
80666096eb78f0e Todd Poynor 2018-07-31 1571 while (table[i].snn_name) {
80666096eb78f0e Todd Poynor 2018-07-31 1572 if (num == table[i].snn_num)
9a69f5087ccc20b Simon Que 2018-06-29 1573 break;
80666096eb78f0e Todd Poynor 2018-07-31 1574 ++i;
9a69f5087ccc20b Simon Que 2018-06-29 1575 }
9a69f5087ccc20b Simon Que 2018-06-29 1576
80666096eb78f0e Todd Poynor 2018-07-31 1577 return table[i].snn_name;
80666096eb78f0e Todd Poynor 2018-07-31 1578 }
80666096eb78f0e Todd Poynor 2018-07-31 1579 EXPORT_SYMBOL(gasket_num_name_lookup);
80666096eb78f0e Todd Poynor 2018-07-31 1580
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
Re: [PATCH v4 27/27] scripts: kernel-doc: validate kernel-doc markup with the actual names
by kernel test robot
Hi Mauro,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20201116]
[cannot apply to drm-intel/for-linux-next s390/features tip/timers/core tip/irq/core tip/sched/core linus/master hnaz-linux-mm/master v5.10-rc4 v5.10-rc3 v5.10-rc2 v5.10-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/net-phy-fi...
base: 034307507118f7e1b18f8403c85af2216da2dc94
config: arm-randconfig-r006-20201116 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c044709b8fbea2a9a375e4173a6bd735f6866c0c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/11cd9cdaab434fff7a5edbee8d8d4ce9e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mauro-Carvalho-Chehab/net-phy-fix-kernel-doc-markups/20201116-191847
git checkout 11cd9cdaab434fff7a5edbee8d8d4ce9ef11acf4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
arch/arm/common/locomo.c:369: warning: Function parameter or member 'me' not described in '__locomo_probe'
arch/arm/common/locomo.c:369: warning: Function parameter or member 'mem' not described in '__locomo_probe'
arch/arm/common/locomo.c:369: warning: Function parameter or member 'irq' not described in '__locomo_probe'
>> arch/arm/common/locomo.c:369: warning: expecting prototype for locomo_probe(). Prototype was for __locomo_probe() instead
vim +369 arch/arm/common/locomo.c
b38d950d3aedf90 John Lenz 2005-09-08 353
4ebf2d00260bac5 Pavel Machek 2006-03-15 354
^1da177e4c3f415 Linus Torvalds 2005-04-16 355 /**
^1da177e4c3f415 Linus Torvalds 2005-04-16 356 * locomo_probe - probe for a single LoCoMo chip.
^1da177e4c3f415 Linus Torvalds 2005-04-16 357 * @phys_addr: physical address of device.
^1da177e4c3f415 Linus Torvalds 2005-04-16 358 *
^1da177e4c3f415 Linus Torvalds 2005-04-16 359 * Probe for a LoCoMo chip. This must be called
^1da177e4c3f415 Linus Torvalds 2005-04-16 360 * before any other locomo-specific code.
^1da177e4c3f415 Linus Torvalds 2005-04-16 361 *
^1da177e4c3f415 Linus Torvalds 2005-04-16 362 * Returns:
^1da177e4c3f415 Linus Torvalds 2005-04-16 363 * %-ENODEV device not found.
^1da177e4c3f415 Linus Torvalds 2005-04-16 364 * %-EBUSY physical address already marked in-use.
^1da177e4c3f415 Linus Torvalds 2005-04-16 365 * %0 successful.
^1da177e4c3f415 Linus Torvalds 2005-04-16 366 */
^1da177e4c3f415 Linus Torvalds 2005-04-16 367 static int
^1da177e4c3f415 Linus Torvalds 2005-04-16 368 __locomo_probe(struct device *me, struct resource *mem, int irq)
^1da177e4c3f415 Linus Torvalds 2005-04-16 @369 {
ac609d266e4af4e Eric Miao 2010-02-04 370 struct locomo_platform_data *pdata = me->platform_data;
^1da177e4c3f415 Linus Torvalds 2005-04-16 371 struct locomo *lchip;
^1da177e4c3f415 Linus Torvalds 2005-04-16 372 unsigned long r;
^1da177e4c3f415 Linus Torvalds 2005-04-16 373 int i, ret = -ENODEV;
^1da177e4c3f415 Linus Torvalds 2005-04-16 374
d2a02b93cf78205 Russell King 2006-03-20 375 lchip = kzalloc(sizeof(struct locomo), GFP_KERNEL);
^1da177e4c3f415 Linus Torvalds 2005-04-16 376 if (!lchip)
^1da177e4c3f415 Linus Torvalds 2005-04-16 377 return -ENOMEM;
^1da177e4c3f415 Linus Torvalds 2005-04-16 378
^1da177e4c3f415 Linus Torvalds 2005-04-16 379 spin_lock_init(&lchip->lock);
^1da177e4c3f415 Linus Torvalds 2005-04-16 380
^1da177e4c3f415 Linus Torvalds 2005-04-16 381 lchip->dev = me;
^1da177e4c3f415 Linus Torvalds 2005-04-16 382 dev_set_drvdata(lchip->dev, lchip);
^1da177e4c3f415 Linus Torvalds 2005-04-16 383
^1da177e4c3f415 Linus Torvalds 2005-04-16 384 lchip->phys = mem->start;
^1da177e4c3f415 Linus Torvalds 2005-04-16 385 lchip->irq = irq;
ac609d266e4af4e Eric Miao 2010-02-04 386 lchip->irq_base = (pdata) ? pdata->irq_base : NO_IRQ;
^1da177e4c3f415 Linus Torvalds 2005-04-16 387
^1da177e4c3f415 Linus Torvalds 2005-04-16 388 /*
^1da177e4c3f415 Linus Torvalds 2005-04-16 389 * Map the whole region. This also maps the
^1da177e4c3f415 Linus Torvalds 2005-04-16 390 * registers for our children.
^1da177e4c3f415 Linus Torvalds 2005-04-16 391 */
^1da177e4c3f415 Linus Torvalds 2005-04-16 392 lchip->base = ioremap(mem->start, PAGE_SIZE);
^1da177e4c3f415 Linus Torvalds 2005-04-16 393 if (!lchip->base) {
^1da177e4c3f415 Linus Torvalds 2005-04-16 394 ret = -ENOMEM;
^1da177e4c3f415 Linus Torvalds 2005-04-16 395 goto out;
^1da177e4c3f415 Linus Torvalds 2005-04-16 396 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 397
^1da177e4c3f415 Linus Torvalds 2005-04-16 398 /* locomo initialize */
^1da177e4c3f415 Linus Torvalds 2005-04-16 399 locomo_writel(0, lchip->base + LOCOMO_ICR);
^1da177e4c3f415 Linus Torvalds 2005-04-16 400 /* KEYBOARD */
^1da177e4c3f415 Linus Torvalds 2005-04-16 401 locomo_writel(0, lchip->base + LOCOMO_KEYBOARD + LOCOMO_KIC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 402
^1da177e4c3f415 Linus Torvalds 2005-04-16 403 /* GPIO */
^1da177e4c3f415 Linus Torvalds 2005-04-16 404 locomo_writel(0, lchip->base + LOCOMO_GPO);
2a52efb2cecf782 Thomas Kunze 2008-04-29 405 locomo_writel((LOCOMO_GPIO(1) | LOCOMO_GPIO(2) | LOCOMO_GPIO(13) | LOCOMO_GPIO(14))
^1da177e4c3f415 Linus Torvalds 2005-04-16 406 , lchip->base + LOCOMO_GPE);
2a52efb2cecf782 Thomas Kunze 2008-04-29 407 locomo_writel((LOCOMO_GPIO(1) | LOCOMO_GPIO(2) | LOCOMO_GPIO(13) | LOCOMO_GPIO(14))
^1da177e4c3f415 Linus Torvalds 2005-04-16 408 , lchip->base + LOCOMO_GPD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 409 locomo_writel(0, lchip->base + LOCOMO_GIE);
^1da177e4c3f415 Linus Torvalds 2005-04-16 410
e44237818500257 Richard Purdie 2006-06-26 411 /* Frontlight */
^1da177e4c3f415 Linus Torvalds 2005-04-16 412 locomo_writel(0, lchip->base + LOCOMO_FRONTLIGHT + LOCOMO_ALS);
^1da177e4c3f415 Linus Torvalds 2005-04-16 413 locomo_writel(0, lchip->base + LOCOMO_FRONTLIGHT + LOCOMO_ALD);
4ebf2d00260bac5 Pavel Machek 2006-03-15 414
^1da177e4c3f415 Linus Torvalds 2005-04-16 415 /* Longtime timer */
^1da177e4c3f415 Linus Torvalds 2005-04-16 416 locomo_writel(0, lchip->base + LOCOMO_LTINT);
^1da177e4c3f415 Linus Torvalds 2005-04-16 417 /* SPI */
1b0d76cb9d5a655 H Hartley Sweeten 2010-03-22 418 locomo_writel(0, lchip->base + LOCOMO_SPI + LOCOMO_SPIIE);
^1da177e4c3f415 Linus Torvalds 2005-04-16 419
^1da177e4c3f415 Linus Torvalds 2005-04-16 420 locomo_writel(6 + 8 + 320 + 30 - 10, lchip->base + LOCOMO_ASD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 421 r = locomo_readl(lchip->base + LOCOMO_ASD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 422 r |= 0x8000;
^1da177e4c3f415 Linus Torvalds 2005-04-16 423 locomo_writel(r, lchip->base + LOCOMO_ASD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 424
^1da177e4c3f415 Linus Torvalds 2005-04-16 425 locomo_writel(6 + 8 + 320 + 30 - 10 - 128 + 4, lchip->base + LOCOMO_HSD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 426 r = locomo_readl(lchip->base + LOCOMO_HSD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 427 r |= 0x8000;
^1da177e4c3f415 Linus Torvalds 2005-04-16 428 locomo_writel(r, lchip->base + LOCOMO_HSD);
^1da177e4c3f415 Linus Torvalds 2005-04-16 429
^1da177e4c3f415 Linus Torvalds 2005-04-16 430 locomo_writel(128 / 8, lchip->base + LOCOMO_HSC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 431
^1da177e4c3f415 Linus Torvalds 2005-04-16 432 /* XON */
^1da177e4c3f415 Linus Torvalds 2005-04-16 433 locomo_writel(0x80, lchip->base + LOCOMO_TADC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 434 udelay(1000);
^1da177e4c3f415 Linus Torvalds 2005-04-16 435 /* CLK9MEN */
^1da177e4c3f415 Linus Torvalds 2005-04-16 436 r = locomo_readl(lchip->base + LOCOMO_TADC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 437 r |= 0x10;
^1da177e4c3f415 Linus Torvalds 2005-04-16 438 locomo_writel(r, lchip->base + LOCOMO_TADC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 439 udelay(100);
^1da177e4c3f415 Linus Torvalds 2005-04-16 440
^1da177e4c3f415 Linus Torvalds 2005-04-16 441 /* init DAC */
^1da177e4c3f415 Linus Torvalds 2005-04-16 442 r = locomo_readl(lchip->base + LOCOMO_DAC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 443 r |= LOCOMO_DAC_SCLOEB | LOCOMO_DAC_SDAOEB;
^1da177e4c3f415 Linus Torvalds 2005-04-16 444 locomo_writel(r, lchip->base + LOCOMO_DAC);
^1da177e4c3f415 Linus Torvalds 2005-04-16 445
^1da177e4c3f415 Linus Torvalds 2005-04-16 446 r = locomo_readl(lchip->base + LOCOMO_VER);
^1da177e4c3f415 Linus Torvalds 2005-04-16 447 printk(KERN_INFO "LoCoMo Chip: %lu%lu\n", (r >> 8), (r & 0xff));
^1da177e4c3f415 Linus Torvalds 2005-04-16 448
^1da177e4c3f415 Linus Torvalds 2005-04-16 449 /*
^1da177e4c3f415 Linus Torvalds 2005-04-16 450 * The interrupt controller must be initialised before any
^1da177e4c3f415 Linus Torvalds 2005-04-16 451 * other device to ensure that the interrupts are available.
^1da177e4c3f415 Linus Torvalds 2005-04-16 452 */
ac609d266e4af4e Eric Miao 2010-02-04 453 if (lchip->irq != NO_IRQ && lchip->irq_base != NO_IRQ)
^1da177e4c3f415 Linus Torvalds 2005-04-16 454 locomo_setup_irq(lchip);
^1da177e4c3f415 Linus Torvalds 2005-04-16 455
^1da177e4c3f415 Linus Torvalds 2005-04-16 456 for (i = 0; i < ARRAY_SIZE(locomo_devices); i++)
^1da177e4c3f415 Linus Torvalds 2005-04-16 457 locomo_init_one_child(lchip, &locomo_devices[i]);
^1da177e4c3f415 Linus Torvalds 2005-04-16 458 return 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 459
^1da177e4c3f415 Linus Torvalds 2005-04-16 460 out:
^1da177e4c3f415 Linus Torvalds 2005-04-16 461 kfree(lchip);
^1da177e4c3f415 Linus Torvalds 2005-04-16 462 return ret;
^1da177e4c3f415 Linus Torvalds 2005-04-16 463 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 464
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
[PATCH] net: phy: mscc: fix excluded_middle.cocci warnings
by Julia Lawall
From: kernel test robot <lkp(a)intel.com>
Condition !A || A && B is equivalent to !A || B.
Generated by: scripts/coccinelle/misc/excluded_middle.cocci
Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script")
CC: Denis Efremov <efremov(a)linux.com>
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: Julia Lawall <julia.lawall(a)inria.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e28c0d7c92c89016c12a677616668957351e7542
commit: b76f0ea013125358d1b4ca147a6f9b6883dd2493 coccinelle: misc: add excluded_middle.cocci script
:::::: branch date: 8 hours ago
:::::: commit date: 8 weeks ago
Please take the patch only if it's a positive warning. Thanks!
mscc_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/phy/mscc/mscc_ptp.c
+++ b/drivers/net/phy/mscc/mscc_ptp.c
@@ -136,7 +136,7 @@ static void vsc85xx_ts_write_csr(struct
phy_ts_base_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_1588);
- if (!cond || (cond && upper))
+ if (!cond || upper)
phy_ts_base_write(phydev, MSCC_PHY_TS_CSR_DATA_MSB, upper);
phy_ts_base_write(phydev, MSCC_PHY_TS_CSR_DATA_LSB, lower);
1 year, 10 months
Re: Error: invalid switch -me200
by Christophe Leroy
Le 14/11/2020 à 01:20, Segher Boessenkool a écrit :
> On Fri, Nov 13, 2020 at 12:14:18PM -0800, Nick Desaulniers wrote:
>>>>> Error: invalid switch -me200
>>>>> Error: unrecognized option -me200
>>>>
>>>> 251 cpu-as-$(CONFIG_E200) += -Wa,-me200
>>>>
>>>> Are those all broken configs, or is Kconfig messed up such that
>>>> randconfig can select these when it should not?
>>>
>>> Hmmm, looks like this flag does not exist in mainline binutils? There is
>>> a thread in 2010 about this that Segher commented on:
>>>
>>> https://lore.kernel.org/linuxppc-dev/9859E645-954D-4D07-8003-FFCD2391AB6E...
>>>
>>> Guess this config should be eliminated?
>
> The help text for this config options says that e200 is used in 55xx,
> and there *is* an -me5500 GAS flag (which probably does this same
> thing, too). But is any of this tested, or useful, or wanted?
>
> Maybe Christophe knows, cc:ed.
>
I don't have much clue on this.
But I see on wikipedia that e5500 is a 64 bits powerpc (https://en.wikipedia.org/wiki/PowerPC_e5500)
What I see is that NXP seems to provide a GCC version that includes aditionnal cpu (e200z0 e200z2
e200z3 e200z4 e200z6 e200z7):
valid arguments to '-mcpu=' are: 401 403 405 405fp 440 440fp 464 464fp 476 476fp 505 601 602 603
603e 604 604e 620 630 740 7400 7450 750 801 821 823 8540 8548 860 970 G3 G4 G5 a2 cell e200z0 e200z2
e200z3 e200z4 e200z6 e200z7 e300c2 e300c3 e500mc e500mc64 e5500 e6500 ec603e native power3 power4
power5 power5+ power6 power6x power7 power8 powerpc powerpc64 powerpc64le rs64 titan "
https://community.nxp.com/t5/MPC5xxx/GCC-generating-not-implemented-instr...
Apparently based on binutils 2.28
https://www.nxp.com/docs/en/release-note/S32DS-POWER-v1-2-RN.pdf
But that's not exactly -me200 though.
Now, I can't see any defconfig that selects CONFIG_E200, so is that worth keeping it in the kernel
at all ?
Christophe
1 year, 10 months
