Re: [PATCH v22 19/23] audit: add support for non-syscall auxiliary records
by kernel test robot
Hi Casey,
I love your patch! Yet something to improve:
[auto build test ERROR on nf-next/master]
[also build test ERROR on nf/master linus/master v5.10-rc3 next-20201113]
[cannot apply to security/next-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Casey-Schaufler/LSM-Module-stack...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: alpha-randconfig-r021-20201104 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/cf770098fb2f8114b0ac138baec96c989...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Casey-Schaufler/LSM-Module-stacking-for-AppArmor/20201105-091817
git checkout cf770098fb2f8114b0ac138baec96c9891bf56ba
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/fsnotify.h:16,
from fs/nfs/unlink.c:18:
>> include/linux/audit.h:563:1: error: expected identifier or '(' before '+' token
563 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
| ^
vim +563 include/linux/audit.h
559
560 extern int audit_n_rules;
561 extern int audit_signals;
562 #else /* CONFIG_AUDITSYSCALL */
> 563 +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
564 {
565 return NULL;
566 }
567 static inline void audit_free_context(struct audit_context *context)
568 { }
569 static inline int audit_alloc(struct task_struct *task)
570 {
571 return 0;
572 }
573 static inline void audit_free(struct task_struct *task)
574 { }
575 static inline void audit_syscall_entry(int major, unsigned long a0,
576 unsigned long a1, unsigned long a2,
577 unsigned long a3)
578 { }
579 static inline void audit_syscall_exit(void *pt_regs)
580 { }
581 static inline bool audit_dummy_context(void)
582 {
583 return true;
584 }
585 static inline void audit_set_context(struct task_struct *task, struct audit_context *ctx)
586 { }
587 static inline struct audit_context *audit_context(void)
588 {
589 return NULL;
590 }
591 static inline struct filename *audit_reusename(const __user char *name)
592 {
593 return NULL;
594 }
595 static inline void audit_getname(struct filename *name)
596 { }
597 static inline void audit_getcwd(void)
598 { }
599 static inline void audit_inode(struct filename *name,
600 const struct dentry *dentry,
601 unsigned int aflags)
602 { }
603 static inline void audit_file(struct file *file)
604 {
605 }
606 static inline void audit_inode_parent_hidden(struct filename *name,
607 const struct dentry *dentry)
608 { }
609 static inline void audit_inode_child(struct inode *parent,
610 const struct dentry *dentry,
611 const unsigned char type)
612 { }
613 static inline void audit_core_dumps(long signr)
614 { }
615 static inline void audit_seccomp(unsigned long syscall, long signr, int code)
616 { }
617 static inline void audit_seccomp_actions_logged(const char *names,
618 const char *old_names, int res)
619 { }
620 static inline void audit_ipc_obj(struct kern_ipc_perm *ipcp)
621 { }
622 static inline void audit_ipc_set_perm(unsigned long qbytes, uid_t uid,
623 gid_t gid, umode_t mode)
624 { }
625 static inline void audit_bprm(struct linux_binprm *bprm)
626 { }
627 static inline int audit_socketcall(int nargs, unsigned long *args)
628 {
629 return 0;
630 }
631
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
[monstr-microblaze:for-test 218/1134] drivers/media/i2c/adv7511-v4l2.c:2102:63: sparse: sparse: incorrect type in argument 1 (different base types)
by kernel test robot
tree: git://git.monstr.eu/linux-2.6-microblaze for-test
head: 21f70b89dfef52f69ce1413868950cf5baf3868d
commit: ec8cdd50aa613113bb1480b0b103f42eea3f25d9 [218/1134] drivers: media: Customized adv7511 for Xylon LogiCVC (deprecated)
config: i386-randconfig-s002-20201115 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-107-gaf3512a6-dirty
git remote add monstr-microblaze git://git.monstr.eu/linux-2.6-microblaze
git fetch --no-tags monstr-microblaze for-test
git checkout ec8cdd50aa613113bb1480b0b103f42eea3f25d9
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
"sparse warnings: (new ones prefixed by >>)"
drivers/media/i2c/adv7511-v4l2.c:427:16: sparse: sparse: return expression in void function
>> drivers/media/i2c/adv7511-v4l2.c:2102:63: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
>> drivers/media/i2c/adv7511-v4l2.c:2102:63: sparse: expected restricted __be32 const [usertype] *p
>> drivers/media/i2c/adv7511-v4l2.c:2102:63: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2106:65: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2106:65: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2106:65: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2110:62: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2110:62: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2110:62: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2117:55: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2117:55: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2117:55: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2121:55: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2121:55: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2121:55: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2125:55: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2125:55: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2125:55: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2129:55: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2129:55: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2129:55: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2133:55: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2133:55: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2133:55: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2137:55: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2137:55: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2137:55: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2141:55: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2141:55: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2141:55: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2151:42: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2151:42: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2151:42: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2157:55: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2157:55: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2157:55: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2161:55: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2161:55: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2161:55: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2165:55: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2165:55: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2165:55: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2169:55: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2169:55: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2169:55: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2174:63: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2174:63: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2174:63: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2181:72: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2181:72: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2181:72: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2186:72: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2186:72: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2186:72: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2191:72: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2191:72: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2191:72: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2196:72: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2196:72: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2196:72: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2201:72: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2201:72: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2201:72: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2206:72: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2206:72: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2206:72: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2211:72: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2211:72: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2211:72: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2216:72: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2216:72: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2216:72: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2221:72: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2221:72: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2221:72: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2226:72: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2226:72: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2226:72: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2231:72: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2231:72: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2231:72: sparse: got unsigned int const [usertype] *[assigned] prop
drivers/media/i2c/adv7511-v4l2.c:2236:72: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] prop @@
drivers/media/i2c/adv7511-v4l2.c:2236:72: sparse: expected restricted __be32 const [usertype] *p
drivers/media/i2c/adv7511-v4l2.c:2236:72: sparse: got unsigned int const [usertype] *[assigned] prop
vim +2102 drivers/media/i2c/adv7511-v4l2.c
2086
2087
2088 static void adv7511_get_ofdt_config(struct i2c_client *client,
2089 struct adv7511_state *state)
2090 {
2091 struct device_node *dn = client->dev.of_node;
2092 struct device_node *np;
2093 struct adv7511_config *config = &state->cfg;
2094 u32 const *prop;
2095 int size;
2096 bool vin_loaded, vout_loaded;
2097
2098 vin_loaded = vout_loaded = false;
2099
2100 prop = of_get_property(dn, "edid-addr", &size);
2101 if (prop)
> 2102 state->pdata.i2c_edid = (uint8_t)be32_to_cpup(prop);
2103
2104 prop = of_get_property(dn, "pktmem-addr", &size);
2105 if (prop)
2106 state->pdata.i2c_pktmem = (uint8_t)be32_to_cpup(prop);
2107
2108 prop = of_get_property(dn, "cec-addr", &size);
2109 if (prop)
2110 state->pdata.i2c_cec = (uint8_t)be32_to_cpup(prop);
2111
2112 np = of_find_node_by_name(dn, "video-input");
2113 if (np) {
2114 prop = of_get_property(np, "input-id", &size);
2115 if (prop)
2116 config->in_params.input_id =
2117 (uint8_t)be32_to_cpup(prop);
2118 prop = of_get_property(np, "input-style", &size);
2119 if (prop)
2120 config->in_params.input_style =
2121 (uint8_t)be32_to_cpup(prop);
2122 prop = of_get_property(np, "input-color-depth", &size);
2123 if (prop)
2124 config->in_params.input_color_depth =
2125 (uint8_t)be32_to_cpup(prop);
2126 prop = of_get_property(np, "bit-justification", &size);
2127 if (prop)
2128 config->in_params.bit_justification =
2129 (uint8_t)be32_to_cpup(prop);
2130 prop = of_get_property(np, "hsync-polarity", &size);
2131 if (prop)
2132 config->in_params.hsync_polarity =
2133 (uint8_t)be32_to_cpup(prop);
2134 prop = of_get_property(np, "vsync-polarity", &size);
2135 if (prop)
2136 config->in_params.vsync_polarity =
2137 (uint8_t)be32_to_cpup(prop);
2138 prop = of_get_property(np, "clock-delay", &size);
2139 if (prop)
2140 config->in_params.clock_delay =
2141 (uint8_t)be32_to_cpup(prop);
2142 vin_loaded = true;
2143 } else {
2144 pr_info("No video input configuration, using device default\n");
2145 }
2146
2147 np = of_find_node_by_name(dn, "video-output");
2148 if (np) {
2149 prop = of_get_property(np, "hdmi-mode", &size);
2150 if (prop) {
2151 if (be32_to_cpup(prop) == 1)
2152 config->out_params.hdmi_mode = true;
2153 }
2154 prop = of_get_property(np, "output-format", &size);
2155 if (prop)
2156 config->out_params.output_format =
2157 (uint8_t)be32_to_cpup(prop);
2158 prop = of_get_property(np, "output-color-space", &size);
2159 if (prop)
2160 config->out_params.output_color_space =
2161 (uint8_t)be32_to_cpup(prop);
2162 prop = of_get_property(np, "up-conversion", &size);
2163 if (prop)
2164 config->out_params.up_conversion =
2165 (uint8_t)be32_to_cpup(prop);
2166 prop = of_get_property(np, "csc-enable", &size);
2167 if (prop)
2168 config->out_params.csc_enable =
2169 (uint8_t)be32_to_cpup(prop);
2170 if (config->out_params.csc_enable) {
2171 prop = of_get_property(np, "csc-scaling-factor", &size);
2172 if (prop) {
2173 config->out_params.csc_scaling_factor =
2174 (uint8_t)be32_to_cpup(prop);
2175 }
2176 np = of_find_node_by_name(dn, "csc-coefficients");
2177 if (np) {
2178 prop = of_get_property(np, "a1", &size);
2179 if (prop) {
2180 config->out_params.csc_coeff.a1 =
2181 (uint16_t)be32_to_cpup(prop);
2182 }
2183 prop = of_get_property(np, "a2", &size);
2184 if (prop) {
2185 config->out_params.csc_coeff.a2 =
2186 (uint16_t)be32_to_cpup(prop);
2187 }
2188 prop = of_get_property(np, "a3", &size);
2189 if (prop) {
2190 config->out_params.csc_coeff.a3 =
2191 (uint16_t)be32_to_cpup(prop);
2192 }
2193 prop = of_get_property(np, "a4", &size);
2194 if (prop) {
2195 config->out_params.csc_coeff.a4 =
2196 (uint16_t)be32_to_cpup(prop);
2197 }
2198 prop = of_get_property(np, "b1", &size);
2199 if (prop) {
2200 config->out_params.csc_coeff.b1 =
2201 (uint16_t)be32_to_cpup(prop);
2202 }
2203 prop = of_get_property(np, "b2", &size);
2204 if (prop) {
2205 config->out_params.csc_coeff.b2 =
2206 (uint16_t)be32_to_cpup(prop);
2207 }
2208 prop = of_get_property(np, "b3", &size);
2209 if (prop) {
2210 config->out_params.csc_coeff.b3 =
2211 (uint16_t)be32_to_cpup(prop);
2212 }
2213 prop = of_get_property(np, "b4", &size);
2214 if (prop) {
2215 config->out_params.csc_coeff.b4 =
2216 (uint16_t)be32_to_cpup(prop);
2217 }
2218 prop = of_get_property(np, "c1", &size);
2219 if (prop) {
2220 config->out_params.csc_coeff.c1 =
2221 (uint16_t)be32_to_cpup(prop);
2222 }
2223 prop = of_get_property(np, "c2", &size);
2224 if (prop) {
2225 config->out_params.csc_coeff.c2 =
2226 (uint16_t)be32_to_cpup(prop);
2227 }
2228 prop = of_get_property(np, "c3", &size);
2229 if (prop) {
2230 config->out_params.csc_coeff.c3 =
2231 (uint16_t)be32_to_cpup(prop);
2232 }
2233 prop = of_get_property(np, "c4", &size);
2234 if (prop) {
2235 config->out_params.csc_coeff.c4 =
2236 (uint16_t)be32_to_cpup(prop);
2237 }
2238 } else {
2239 pr_info("No CSC coefficients, using default\n");
2240 }
2241 }
2242 vout_loaded = true;
2243 } else {
2244 pr_info("No video output configuration, using device default\n");
2245 }
2246
2247 if (vin_loaded && vout_loaded)
2248 config->loaded = true;
2249 }
2250
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c:932:2: warning: 'strncpy' specified bound 128 equals destination size
by kernel test robot
Hi Jacopo,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9cfd9c45994b409c7103efc2f265e0af7634cf75
commit: b18ee53ad297264a79cf4ea566663f20786b6455 staging: bcm2835: Break MMAL support out from camera
date: 5 months ago
config: openrisc-randconfig-r034-20201113 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout b18ee53ad297264a79cf4ea566663f20786b6455
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c: In function 'create_component':
>> drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c:932:2: warning: 'strncpy' specified bound 128 equals destination size [-Wstringop-truncation]
932 | strncpy(m.u.component_create.name, name,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
933 | sizeof(m.u.component_create.name));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/strncpy +932 drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 918
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 919 /* create comonent on vc */
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 920 static int create_component(struct vchiq_mmal_instance *instance,
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 921 struct vchiq_mmal_component *component,
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 922 const char *name)
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 923 {
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 924 int ret;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 925 struct mmal_msg m;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 926 struct mmal_msg *rmsg;
9d4d3ac473912a drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c Dominic Braun 2018-12-14 927 struct vchi_held_msg rmsg_handle;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 928
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 929 /* build component create message */
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 930 m.h.type = MMAL_MSG_TYPE_COMPONENT_CREATE;
4fe08093094e5f drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c Michael Zoran 2017-03-09 931 m.u.component_create.client_component = (u32)(unsigned long)component;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 @932 strncpy(m.u.component_create.name, name,
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 933 sizeof(m.u.component_create.name));
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 934
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 935 ret = send_synchronous_mmal_msg(instance, &m,
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 936 sizeof(m.u.component_create),
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 937 &rmsg, &rmsg_handle);
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 938 if (ret)
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 939 return ret;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 940
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 941 if (rmsg->h.type != m.h.type) {
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 942 /* got an unexpected message type in reply */
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 943 ret = -EINVAL;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 944 goto release_msg;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 945 }
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 946
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 947 ret = -rmsg->u.component_create_reply.status;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 948 if (ret != MMAL_MSG_STATUS_SUCCESS)
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 949 goto release_msg;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 950
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 951 /* a valid component response received */
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 952 component->handle = rmsg->u.component_create_reply.component_handle;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 953 component->inputs = rmsg->u.component_create_reply.input_num;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 954 component->outputs = rmsg->u.component_create_reply.output_num;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 955 component->clocks = rmsg->u.component_create_reply.clock_num;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 956
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 957 pr_debug("Component handle:0x%x in:%d out:%d clock:%d\n",
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 958 component->handle,
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 959 component->inputs, component->outputs, component->clocks);
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 960
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 961 release_msg:
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 962 vchi_held_msg_release(&rmsg_handle);
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 963
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 964 return ret;
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 965 }
7b3ad5abf027b7 drivers/staging/media/platform/bcm2835/mmal-vchiq.c Eric Anholt 2017-01-27 966
:::::: The code at line 932 was first introduced by commit
:::::: 7b3ad5abf027b7643b38c4006d7f4ce47a86dd3a staging: Import the BCM2835 MMAL-based V4L2 camera driver.
:::::: TO: Eric Anholt <eric(a)anholt.net>
:::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
Re: [RFC][PATCH 05/24] x86/entry: Implement ret_from_fork body with C code
by kernel test robot
Hi Alexandre,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on tip/x86/mm]
[also build test WARNING on v5.10-rc3 next-20201113]
[cannot apply to tip/x86/core tip/x86/asm]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alexandre-Chartre/x86-pti-Defer-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 1fcd009102ee02e217f2e7635ab65517d785da8e
config: i386-randconfig-r014-20201109 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/63533707f1058d9d8eccb278eb735d9f8...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alexandre-Chartre/x86-pti-Defer-CR3-switch-to-C-code/20201109-225007
git checkout 63533707f1058d9d8eccb278eb735d9f88fdd222
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/entry/common.c:38:24: warning: no previous prototype for 'return_from_fork' [-Wmissing-prototypes]
38 | __visible noinstr void return_from_fork(struct pt_regs *regs,
| ^~~~~~~~~~~~~~~~
arch/x86/entry/common.c:112:24: warning: no previous prototype for 'do_int80_syscall_32' [-Wmissing-prototypes]
112 | __visible noinstr void do_int80_syscall_32(struct pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~~
arch/x86/entry/common.c:171:24: warning: no previous prototype for 'do_fast_syscall_32' [-Wmissing-prototypes]
171 | __visible noinstr long do_fast_syscall_32(struct pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~
arch/x86/entry/common.c:223:24: warning: no previous prototype for 'do_SYSENTER_32' [-Wmissing-prototypes]
223 | __visible noinstr long do_SYSENTER_32(struct pt_regs *regs)
| ^~~~~~~~~~~~~~
vim +/return_from_fork +38 arch/x86/entry/common.c
37
> 38 __visible noinstr void return_from_fork(struct pt_regs *regs,
39 struct task_struct *prev,
40 void (*kfunc)(void *), void *kargs)
41 {
42 schedule_tail(prev);
43 if (kfunc) {
44 /* kernel thread */
45 kfunc(kargs);
46 /*
47 * A kernel thread is allowed to return here after
48 * successfully calling kernel_execve(). Exit to
49 * userspace to complete the execve() syscall.
50 */
51 regs->ax = 0;
52 }
53 syscall_exit_to_user_mode(regs);
54 }
55
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
Re: [RFC][PATCH 05/24] x86/entry: Implement ret_from_fork body with C code
by kernel test robot
Hi Alexandre,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on tip/x86/mm]
[also build test WARNING on v5.10-rc3 next-20201113]
[cannot apply to tip/x86/core tip/x86/asm]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alexandre-Chartre/x86-pti-Defer-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 1fcd009102ee02e217f2e7635ab65517d785da8e
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/63533707f1058d9d8eccb278eb735d9f8...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alexandre-Chartre/x86-pti-Defer-CR3-switch-to-C-code/20201109-225007
git checkout 63533707f1058d9d8eccb278eb735d9f88fdd222
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/entry/common.c:38:24: warning: no previous prototype for 'return_from_fork' [-Wmissing-prototypes]
38 | __visible noinstr void return_from_fork(struct pt_regs *regs,
| ^~~~~~~~~~~~~~~~
arch/x86/entry/common.c:223:24: warning: no previous prototype for 'do_SYSENTER_32' [-Wmissing-prototypes]
223 | __visible noinstr long do_SYSENTER_32(struct pt_regs *regs)
| ^~~~~~~~~~~~~~
arch/x86/entry/common.c:320:24: warning: no previous prototype for 'xen_pv_evtchn_do_upcall' [-Wmissing-prototypes]
320 | __visible noinstr void xen_pv_evtchn_do_upcall(struct pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/return_from_fork +38 arch/x86/entry/common.c
37
> 38 __visible noinstr void return_from_fork(struct pt_regs *regs,
39 struct task_struct *prev,
40 void (*kfunc)(void *), void *kargs)
41 {
42 schedule_tail(prev);
43 if (kfunc) {
44 /* kernel thread */
45 kfunc(kargs);
46 /*
47 * A kernel thread is allowed to return here after
48 * successfully calling kernel_execve(). Exit to
49 * userspace to complete the execve() syscall.
50 */
51 regs->ax = 0;
52 }
53 syscall_exit_to_user_mode(regs);
54 }
55
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
Re: [Intel-gfx] [PATCH 18/27] drm/i915/pxp: Implement funcs to create the TEE channel (fwd)
by Julia Lawall
See line 81.
julia
---------- Forwarded message ----------
Date: Sun, 15 Nov 2020 06:48:16 +0800
From: kernel test robot <lkp(a)intel.com>
To: kbuild(a)lists.01.org
Cc: lkp(a)intel.com, Julia Lawall <julia.lawall(a)lip6.fr>
Subject: Re: [Intel-gfx] [PATCH 18/27] drm/i915/pxp: Implement funcs to create
the TEE channel
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201114014537.25495-18-sean.z.huang(a)intel.com>
References: <20201114014537.25495-18-sean.z.huang(a)intel.com>
TO: Sean Z Huang <sean.z.huang(a)intel.com>
TO: Intel-gfx(a)lists.freedesktop.org
CC: "Huang, Sean Z" <sean.z.huang(a)intel.com>
Hi Sean,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20201113]
[also build test WARNING on v5.10-rc3]
[cannot apply to drm-intel/for-linux-next char-misc/char-misc-testing v5.10-rc3 v5.10-rc2 v5.10-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sean-Z-Huang/drm-i915-pxp-Introd...
base: 92edc4aef86780a8ad01b092c6d6630bb3cb423d
:::::: branch date: 21 hours ago
:::::: commit date: 21 hours ago
config: i386-randconfig-c001-20201113 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Julia Lawall <julia.lawall(a)lip6.fr>
"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/gpu/drm/i915/pxp/intel_pxp_tee.c:81:17-20: ERROR: i915 is NULL but dereferenced.
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c:101:17-20: ERROR: i915 is NULL but dereferenced.
vim +81 drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 62
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 63 /**
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 64 * i915_pxp_tee_component_bind - bind funciton to pass the function pointers to pxp_tee
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 65 * @i915_kdev: pointer to i915 kernel device
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 66 * @tee_kdev: pointer to tee kernel device
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 67 * @data: pointer to pxp_tee_master containing the function pointers
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 68 *
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 69 * This bind function is called during the system boot or resume from system sleep.
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 70 *
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 71 * Return: return 0 if successful.
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 72 */
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 73 static int i915_pxp_tee_component_bind(struct device *i915_kdev,
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 74 struct device *tee_kdev, void *data)
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 75 {
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 76 struct drm_i915_private *i915 = kdev_to_i915(i915_kdev);
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 77
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 78 drm_dbg(&i915->drm, "i915 PXP TEE component bind\n");
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 79
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 80 if (!i915 || !tee_kdev || !data) {
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 @81 drm_dbg(&i915->drm, "Failed to bind for i915 PXP TEE component, invalid params\n");
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 82 return -EPERM;
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 83 }
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 84
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 85 mutex_lock(&i915->pxp_tee_comp_mutex);
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 86 i915->pxp_tee_master = (struct i915_pxp_comp_master *)data;
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 87 i915->pxp_tee_master->tee_dev = tee_kdev;
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 88 mutex_unlock(&i915->pxp_tee_comp_mutex);
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 89
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 90 return 0;
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 91 }
8f42c11ed5aac66 Huang, Sean Z 2020-11-13 92
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
Re: [PATCH v8 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature
by kernel test robot
Hi Arpitha,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on ext4/dev]
[also build test WARNING on linus/master v5.10-rc3 next-20201113]
[cannot apply to tytso-fscrypt/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Arpitha-Raghunandan/kunit-Suppor...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: microblaze-randconfig-r031-20201115 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/002a7d4700bd033cceff2f2ab10bcc4a4...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Arpitha-Raghunandan/kunit-Support-for-Parameterized-Testing/20201116-030137
git checkout 002a7d4700bd033cceff2f2ab10bcc4a440f1377
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In function 'timestamp_expectation_to_desc',
inlined from 'ext4_inode_gen_params' at fs/ext4/inode-test.c:223:1:
>> fs/ext4/inode-test.c:219:2: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
219 | strncpy(desc, t->test_case_name, desc_length);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fs/ext4/inode-test.c: In function 'ext4_inode_gen_params':
fs/ext4/inode-test.c:217:20: note: length computed here
217 | int desc_length = strlen(t->test_case_name);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/strncpy +219 fs/ext4/inode-test.c
213
214 static void timestamp_expectation_to_desc(const struct timestamp_expectation *t,
215 char *desc)
216 {
217 int desc_length = strlen(t->test_case_name);
218
> 219 strncpy(desc, t->test_case_name, desc_length);
220 desc[desc_length] = '\0';
221 }
222
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
[l1k:spi_fixes_part2 8/16] drivers/spi/spi-mt7621.c:354:6: warning: variable 'rs' is used uninitialized whenever 'if' condition is true
by kernel test robot
tree: https://github.com/l1k/linux spi_fixes_part2
head: 1124444e1890c011ce93035cc73c8df8a206103d
commit: 99e9a80eb65b1787cd055025129a45e24f2fc6ae [8/16] spi: mt7621: Don't leak SPI master in probe error path
config: riscv-randconfig-r006-20201115 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 9a85643cd357e412cff69067bb5c4840e228c2ab)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/l1k/linux/commit/99e9a80eb65b1787cd055025129a45e24f2fc6ae
git remote add l1k https://github.com/l1k/linux
git fetch --no-tags l1k spi_fixes_part2
git checkout 99e9a80eb65b1787cd055025129a45e24f2fc6ae
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/spi/spi-mt7621.c:354:6: warning: variable 'rs' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (!master) {
^~~~~~~
drivers/spi/spi-mt7621.c:391:24: note: uninitialized use occurs here
clk_disable_unprepare(rs->clk);
^~
drivers/spi/spi-mt7621.c:354:2: note: remove the 'if' if its condition is always false
if (!master) {
^~~~~~~~~~~~~~
drivers/spi/spi-mt7621.c:328:23: note: initialize the variable 'rs' to silence this warning
struct mt7621_spi *rs;
^
= NULL
1 warning generated.
vim +354 drivers/spi/spi-mt7621.c
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 323
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 324 static int mt7621_spi_probe(struct platform_device *pdev)
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 325 {
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 326 const struct of_device_id *match;
cbd66c626e1674 drivers/spi/spi-mt7621.c Stefan Roese 2019-03-25 327 struct spi_controller *master;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 328 struct mt7621_spi *rs;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 329 void __iomem *base;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 330 int status = 0;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 331 struct clk *clk;
46c337872f34bc drivers/staging/mt7621-spi/spi-mt7621.c Stefan Roese 2019-02-01 332 int ret;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 333
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 334 match = of_match_device(mt7621_spi_match, &pdev->dev);
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 335 if (!match)
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 336 return -EINVAL;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 337
f88771ca7104e4 drivers/spi/spi-mt7621.c YueHaibing 2019-09-04 338 base = devm_platform_ioremap_resource(pdev, 0);
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 339 if (IS_ERR(base))
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 340 return PTR_ERR(base);
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 341
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 342 clk = devm_clk_get(&pdev->dev, NULL);
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 343 if (IS_ERR(clk)) {
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 344 dev_err(&pdev->dev, "unable to get SYS clock, err=%d\n",
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 345 status);
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 346 return PTR_ERR(clk);
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 347 }
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 348
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 349 status = clk_prepare_enable(clk);
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 350 if (status)
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 351 return status;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 352
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 353 master = devm_spi_alloc_master(&pdev->dev, sizeof(*rs));
5ccbce3a0b0e10 drivers/staging/mt7621-spi/spi-mt7621.c Jasminko Dedic 2019-02-04 @354 if (!master) {
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 355 dev_info(&pdev->dev, "master allocation failed\n");
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 356 ret = -ENOMEM;
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 357 goto err_clk_disable;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 358 }
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 359
354ea2ee6d2bc0 drivers/staging/mt7621-spi/spi-mt7621.c Chuanhong Guo 2018-12-06 360 master->mode_bits = SPI_LSB_FIRST;
cbd66c626e1674 drivers/spi/spi-mt7621.c Stefan Roese 2019-03-25 361 master->flags = SPI_CONTROLLER_HALF_DUPLEX;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 362 master->setup = mt7621_spi_setup;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 363 master->transfer_one_message = mt7621_spi_transfer_one_message;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 364 master->bits_per_word_mask = SPI_BPW_MASK(8);
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 365 master->dev.of_node = pdev->dev.of_node;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 366 master->num_chipselect = 2;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 367
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 368 dev_set_drvdata(&pdev->dev, master);
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 369
cbd66c626e1674 drivers/spi/spi-mt7621.c Stefan Roese 2019-03-25 370 rs = spi_controller_get_devdata(master);
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 371 rs->base = base;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 372 rs->clk = clk;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 373 rs->master = master;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 374 rs->sys_freq = clk_get_rate(rs->clk);
bf732c6bff5b57 drivers/staging/mt7621-spi/spi-mt7621.c NeilBrown 2018-06-07 375 rs->pending_write = 0;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 376 dev_info(&pdev->dev, "sys_freq: %u\n", rs->sys_freq);
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 377
46c337872f34bc drivers/staging/mt7621-spi/spi-mt7621.c Stefan Roese 2019-02-01 378 ret = device_reset(&pdev->dev);
46c337872f34bc drivers/staging/mt7621-spi/spi-mt7621.c Stefan Roese 2019-02-01 379 if (ret) {
46c337872f34bc drivers/staging/mt7621-spi/spi-mt7621.c Stefan Roese 2019-02-01 380 dev_err(&pdev->dev, "SPI reset failed!\n");
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 381 goto err_clk_disable;
46c337872f34bc drivers/staging/mt7621-spi/spi-mt7621.c Stefan Roese 2019-02-01 382 }
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 383
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 384 ret = spi_register_controller(master);
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 385 if (ret)
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 386 goto err_clk_disable;
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 387
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 388 return 0;
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 389
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 390 err_clk_disable:
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 391 clk_disable_unprepare(rs->clk);
99e9a80eb65b17 drivers/spi/spi-mt7621.c Lukas Wunner 2020-11-05 392 return ret;
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 393 }
1ab7f2a43558b3 drivers/staging/mt7621-spi/spi-mt7621.c John Crispin 2018-03-15 394
:::::: The code at line 354 was first introduced by commit
:::::: 5ccbce3a0b0e10694f1a62e8b1ce9b46d1809eea staging: mt7621-spi: Clean up comparison to NULL
:::::: TO: Jasminko Dedic <betelge(a)gmail.com>
:::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months