Re: [PATCH] input: touchscreen: ad7877: Use new structure for SPI transfer delays
by kbuild test robot
Hi Sergiu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on input/next]
[also build test ERROR on linux/master linus/master v5.6-rc3 next-20200227]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Sergiu-Cuciurean/input-touchscre...
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (git://gitmirror/llvm_project 949134e2fefd34a38ed71de90dffe2300e2e1139)
reproduce:
# FIXME the reproduce steps for clang is not ready yet
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/input/touchscreen/ad7877.c:721:6: error: no member named 'vref_delay' in 'struct ad7877'
ts->vref_delay.value = pdata->vref_delay_usecs ? : 100;
~~ ^
drivers/input/touchscreen/ad7877.c:722:6: error: no member named 'vref_delay' in 'struct ad7877'
ts->vref_delay.unit = SPI_DELAY_UNIT_USECS;
~~ ^
2 errors generated.
vim +721 drivers/input/touchscreen/ad7877.c
668
669 static int ad7877_probe(struct spi_device *spi)
670 {
671 struct ad7877 *ts;
672 struct input_dev *input_dev;
673 struct ad7877_platform_data *pdata = dev_get_platdata(&spi->dev);
674 int err;
675 u16 verify;
676
677 if (!spi->irq) {
678 dev_dbg(&spi->dev, "no IRQ?\n");
679 return -ENODEV;
680 }
681
682 if (!pdata) {
683 dev_dbg(&spi->dev, "no platform data?\n");
684 return -ENODEV;
685 }
686
687 /* don't exceed max specified SPI CLK frequency */
688 if (spi->max_speed_hz > MAX_SPI_FREQ_HZ) {
689 dev_dbg(&spi->dev, "SPI CLK %d Hz?\n",spi->max_speed_hz);
690 return -EINVAL;
691 }
692
693 spi->bits_per_word = 16;
694 err = spi_setup(spi);
695 if (err) {
696 dev_dbg(&spi->dev, "spi master doesn't support 16 bits/word\n");
697 return err;
698 }
699
700 ts = devm_kzalloc(&spi->dev, sizeof(struct ad7877), GFP_KERNEL);
701 if (!ts)
702 return -ENOMEM;
703
704 input_dev = devm_input_allocate_device(&spi->dev);
705 if (!input_dev)
706 return -ENOMEM;
707
708 err = devm_add_action_or_reset(&spi->dev, ad7877_disable, ts);
709 if (err)
710 return err;
711
712 spi_set_drvdata(spi, ts);
713 ts->spi = spi;
714 ts->input = input_dev;
715
716 timer_setup(&ts->timer, ad7877_timer, 0);
717 mutex_init(&ts->mutex);
718 spin_lock_init(&ts->lock);
719
720 ts->model = pdata->model ? : 7877;
> 721 ts->vref_delay.value = pdata->vref_delay_usecs ? : 100;
722 ts->vref_delay.unit = SPI_DELAY_UNIT_USECS;
723 ts->x_plate_ohms = pdata->x_plate_ohms ? : 400;
724 ts->pressure_max = pdata->pressure_max ? : ~0;
725
726 ts->stopacq_polarity = pdata->stopacq_polarity;
727 ts->first_conversion_delay = pdata->first_conversion_delay;
728 ts->acquisition_time = pdata->acquisition_time;
729 ts->averaging = pdata->averaging;
730 ts->pen_down_acc_interval = pdata->pen_down_acc_interval;
731
732 snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(&spi->dev));
733
734 input_dev->name = "AD7877 Touchscreen";
735 input_dev->phys = ts->phys;
736 input_dev->dev.parent = &spi->dev;
737
738 __set_bit(EV_KEY, input_dev->evbit);
739 __set_bit(BTN_TOUCH, input_dev->keybit);
740 __set_bit(EV_ABS, input_dev->evbit);
741 __set_bit(ABS_X, input_dev->absbit);
742 __set_bit(ABS_Y, input_dev->absbit);
743 __set_bit(ABS_PRESSURE, input_dev->absbit);
744
745 input_set_abs_params(input_dev, ABS_X,
746 pdata->x_min ? : 0,
747 pdata->x_max ? : MAX_12BIT,
748 0, 0);
749 input_set_abs_params(input_dev, ABS_Y,
750 pdata->y_min ? : 0,
751 pdata->y_max ? : MAX_12BIT,
752 0, 0);
753 input_set_abs_params(input_dev, ABS_PRESSURE,
754 pdata->pressure_min, pdata->pressure_max, 0, 0);
755
756 ad7877_write(spi, AD7877_REG_SEQ1, AD7877_MM_SEQUENCE);
757
758 verify = ad7877_read(spi, AD7877_REG_SEQ1);
759
760 if (verify != AD7877_MM_SEQUENCE) {
761 dev_err(&spi->dev, "%s: Failed to probe %s\n",
762 dev_name(&spi->dev), input_dev->name);
763 return -ENODEV;
764 }
765
766 if (gpio3)
767 ad7877_write(spi, AD7877_REG_EXTWRITE, AD7877_EXTW_GPIO_3_CONF);
768
769 ad7877_setup_ts_def_msg(spi, ts);
770
771 /* Request AD7877 /DAV GPIO interrupt */
772
773 err = devm_request_threaded_irq(&spi->dev, spi->irq, NULL, ad7877_irq,
774 IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
775 spi->dev.driver->name, ts);
776 if (err) {
777 dev_dbg(&spi->dev, "irq %d busy?\n", spi->irq);
778 return err;
779 }
780
781 err = devm_device_add_group(&spi->dev, &ad7877_attr_group);
782 if (err)
783 return err;
784
785 err = input_register_device(input_dev);
786 if (err)
787 return err;
788
789 return 0;
790 }
791
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
[sschmidt-wpan-next:master 4/7] net/ipv4/fib_semantics.c:594:31: error: passing argument 6 of 'lwtunnel_build_state' from incompatible pointer type
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sschmidt/wpan-next.git master
head: 73e85701921be77cb16a4879d6af4f79462f9eb7
commit: c0037234c69e275990fbb4e8c006869b53220e84 [4/7] net: add net available in build_state
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
git checkout c0037234c69e275990fbb4e8c006869b53220e84
# save the attached .config to linux build tree
make ARCH=um SUBARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
net/ipv4/fib_semantics.c: In function 'fib_nh_common_init':
net/ipv4/fib_semantics.c:593:30: warning: passing argument 1 of 'lwtunnel_build_state' makes integer from pointer without a cast [-Wint-conversion]
err = lwtunnel_build_state(net, encap_type, encap,
^~~
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: expected 'u16 {aka short unsigned int}' but argument is of type 'struct net *'
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
net/ipv4/fib_semantics.c:593:35: warning: passing argument 2 of 'lwtunnel_build_state' makes pointer from integer without a cast [-Wint-conversion]
err = lwtunnel_build_state(net, encap_type, encap,
^~~~~~~~~~
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: expected 'struct nlattr *' but argument is of type 'u16 {aka short unsigned int}'
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
net/ipv4/fib_semantics.c:593:47: warning: passing argument 3 of 'lwtunnel_build_state' makes integer from pointer without a cast [-Wint-conversion]
err = lwtunnel_build_state(net, encap_type, encap,
^~~~~
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: expected 'unsigned int' but argument is of type 'struct nlattr *'
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
net/ipv4/fib_semantics.c:594:9: warning: passing argument 4 of 'lwtunnel_build_state' makes pointer from integer without a cast [-Wint-conversion]
nhc->nhc_family, cfg, &lwtstate,
^~~
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: expected 'const void *' but argument is of type 'u8 {aka unsigned char}'
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
>> net/ipv4/fib_semantics.c:594:31: error: passing argument 6 of 'lwtunnel_build_state' from incompatible pointer type [-Werror=incompatible-pointer-types]
nhc->nhc_family, cfg, &lwtstate,
^
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: expected 'struct netlink_ext_ack *' but argument is of type 'struct lwtunnel_state **'
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
>> net/ipv4/fib_semantics.c:593:9: error: too many arguments to function 'lwtunnel_build_state'
err = lwtunnel_build_state(net, encap_type, encap,
^~~~~~~~~~~~~~~~~~~~
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: declared here
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
net/ipv4/fib_semantics.c: In function 'fib_encap_match':
net/ipv4/fib_semantics.c:831:29: warning: passing argument 1 of 'lwtunnel_build_state' makes integer from pointer without a cast [-Wint-conversion]
ret = lwtunnel_build_state(net, encap_type, encap, AF_INET,
^~~
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: expected 'u16 {aka short unsigned int}' but argument is of type 'struct net *'
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
net/ipv4/fib_semantics.c:831:34: warning: passing argument 2 of 'lwtunnel_build_state' makes pointer from integer without a cast [-Wint-conversion]
ret = lwtunnel_build_state(net, encap_type, encap, AF_INET,
^~~~~~~~~~
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: expected 'struct nlattr *' but argument is of type 'u16 {aka short unsigned int}'
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
net/ipv4/fib_semantics.c:831:46: warning: passing argument 3 of 'lwtunnel_build_state' makes integer from pointer without a cast [-Wint-conversion]
ret = lwtunnel_build_state(net, encap_type, encap, AF_INET,
^~~~~
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: expected 'unsigned int' but argument is of type 'struct nlattr *'
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
In file included from net/ipv4/fib_semantics.c:19:0:
include/linux/socket.h:165:18: warning: passing argument 4 of 'lwtunnel_build_state' makes pointer from integer without a cast [-Wint-conversion]
#define AF_INET 2 /* Internet IP Protocol */
^
net/ipv4/fib_semantics.c:831:53: note: in expansion of macro 'AF_INET'
ret = lwtunnel_build_state(net, encap_type, encap, AF_INET,
^~~~~~~
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: expected 'const void *' but argument is of type 'int'
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
net/ipv4/fib_semantics.c:832:8: error: passing argument 5 of 'lwtunnel_build_state' from incompatible pointer type [-Werror=incompatible-pointer-types]
cfg, &lwtstate, extack);
^~~
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: expected 'struct lwtunnel_state **' but argument is of type 'const struct fib_config *'
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
net/ipv4/fib_semantics.c:832:13: error: passing argument 6 of 'lwtunnel_build_state' from incompatible pointer type [-Werror=incompatible-pointer-types]
cfg, &lwtstate, extack);
^
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: expected 'struct netlink_ext_ack *' but argument is of type 'struct lwtunnel_state **'
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
net/ipv4/fib_semantics.c:831:8: error: too many arguments to function 'lwtunnel_build_state'
ret = lwtunnel_build_state(net, encap_type, encap, AF_INET,
^~~~~~~~~~~~~~~~~~~~
In file included from net/ipv4/fib_semantics.c:44:0:
include/net/lwtunnel.h:212:19: note: declared here
static inline int lwtunnel_build_state(u16 encap_type,
^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/lwtunnel_build_state +594 net/ipv4/fib_semantics.c
572
573 int fib_nh_common_init(struct net *net, struct fib_nh_common *nhc,
574 struct nlattr *encap, u16 encap_type,
575 void *cfg, gfp_t gfp_flags,
576 struct netlink_ext_ack *extack)
577 {
578 int err;
579
580 nhc->nhc_pcpu_rth_output = alloc_percpu_gfp(struct rtable __rcu *,
581 gfp_flags);
582 if (!nhc->nhc_pcpu_rth_output)
583 return -ENOMEM;
584
585 if (encap) {
586 struct lwtunnel_state *lwtstate;
587
588 if (encap_type == LWTUNNEL_ENCAP_NONE) {
589 NL_SET_ERR_MSG(extack, "LWT encap type not specified");
590 err = -EINVAL;
591 goto lwt_failure;
592 }
> 593 err = lwtunnel_build_state(net, encap_type, encap,
> 594 nhc->nhc_family, cfg, &lwtstate,
595 extack);
596 if (err)
597 goto lwt_failure;
598
599 nhc->nhc_lwtstate = lwtstate_get(lwtstate);
600 }
601
602 return 0;
603
604 lwt_failure:
605 rt_fibinfo_free_cpus(nhc->nhc_pcpu_rth_output);
606 nhc->nhc_pcpu_rth_output = NULL;
607 return err;
608 }
609 EXPORT_SYMBOL_GPL(fib_nh_common_init);
610
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
[riscv:for-next 5/7] arch/riscv/kernel/stacktrace.c:78:8: error: 'sp_in_global' undeclared; did you mean 'spin_lock'?
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git for-next
head: 4aa8ab7e6967b7dc92ca78f4c9ab026abfa1f3ea
commit: 133f73bb8319d6683c924dabddb25b953878cbc2 [5/7] RISC-V: Stop relying on GCC's register allocator's hueristics
config: riscv-allnoconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 133f73bb8319d6683c924dabddb25b953878cbc2
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/riscv/kernel/stacktrace.c: In function 'walk_stackframe':
>> arch/riscv/kernel/stacktrace.c:78:8: error: 'sp_in_global' undeclared (first use in this function); did you mean 'spin_lock'?
sp = sp_in_global;
^~~~~~~~~~~~
spin_lock
arch/riscv/kernel/stacktrace.c:78:8: note: each undeclared identifier is reported only once for each function it appears in
vim +78 arch/riscv/kernel/stacktrace.c
67
68 static void notrace walk_stackframe(struct task_struct *task,
69 struct pt_regs *regs, bool (*fn)(unsigned long, void *), void *arg)
70 {
71 unsigned long sp, pc;
72 unsigned long *ksp;
73
74 if (regs) {
75 sp = user_stack_pointer(regs);
76 pc = instruction_pointer(regs);
77 } else if (task == NULL || task == current) {
> 78 sp = sp_in_global;
79 pc = (unsigned long)walk_stackframe;
80 } else {
81 /* task blocked in __switch_to */
82 sp = task->thread.sp;
83 pc = task->thread.ra;
84 }
85
86 if (unlikely(sp & 0x7))
87 return;
88
89 ksp = (unsigned long *)sp;
90 while (!kstack_end(ksp)) {
91 if (__kernel_text_address(pc) && unlikely(fn(pc, arg)))
92 break;
93 pc = (*ksp++) - 0x4;
94 }
95 }
96
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [RFC PATCH v3 5/7] mm/asi: Switch ASI on task switch
by kbuild test robot
Hi Alexandre,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on tip/x86/core]
[also build test ERROR on tip/x86/asm tip/x86/mm v5.6-rc3]
[cannot apply to next-20200227]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Alexandre-Chartre/Kernel-Address...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 248ed51048c40d36728e70914e38bffd7821da57
config: arm64-defconfig (attached as .config)
compiler: clang version 11.0.0 (git://gitmirror/llvm_project 949134e2fefd34a38ed71de90dffe2300e2e1139)
reproduce:
# FIXME the reproduce steps for clang is not ready yet
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/arm64/kernel/asm-offsets.c:10:
In file included from include/linux/arm_sdei.h:8:
In file included from include/acpi/ghes.h:5:
In file included from include/acpi/apei.h:9:
In file included from include/linux/acpi.h:13:
In file included from include/linux/irqdomain.h:35:
In file included from include/linux/of.h:17:
In file included from include/linux/kobject.h:20:
In file included from include/linux/sysfs.h:22:
In file included from include/linux/stat.h:6:
In file included from arch/arm64/include/asm/stat.h:13:
In file included from arch/arm64/include/asm/compat.h:13:
>> include/linux/sched.h:13:10: fatal error: 'asm/asi_session.h' file not found
#include <asm/asi_session.h>
^~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [scripts/Makefile.build:99: arch/arm64/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1113: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:179: sub-make] Error 2
348 real 47 user 100 sys 42.47% cpu make prepare
vim +13 include/linux/sched.h
11
12 #include <asm/current.h>
> 13 #include <asm/asi_session.h>
14
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH] input: touchscreen: ad7877: Use new structure for SPI transfer delays
by kbuild test robot
Hi Sergiu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on input/next]
[also build test ERROR on linux/master linus/master v5.6-rc3 next-20200227]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Sergiu-Cuciurean/input-touchscre...
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: x86_64-randconfig-s1-20200228 (attached as .config)
compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/input/touchscreen/ad7877.c: In function 'ad7877_probe':
>> drivers/input/touchscreen/ad7877.c:721:4: error: 'struct ad7877' has no member named 'vref_delay'
ts->vref_delay.value = pdata->vref_delay_usecs ? : 100;
^
drivers/input/touchscreen/ad7877.c:722:4: error: 'struct ad7877' has no member named 'vref_delay'
ts->vref_delay.unit = SPI_DELAY_UNIT_USECS;
^
vim +721 drivers/input/touchscreen/ad7877.c
668
669 static int ad7877_probe(struct spi_device *spi)
670 {
671 struct ad7877 *ts;
672 struct input_dev *input_dev;
673 struct ad7877_platform_data *pdata = dev_get_platdata(&spi->dev);
674 int err;
675 u16 verify;
676
677 if (!spi->irq) {
678 dev_dbg(&spi->dev, "no IRQ?\n");
679 return -ENODEV;
680 }
681
682 if (!pdata) {
683 dev_dbg(&spi->dev, "no platform data?\n");
684 return -ENODEV;
685 }
686
687 /* don't exceed max specified SPI CLK frequency */
688 if (spi->max_speed_hz > MAX_SPI_FREQ_HZ) {
689 dev_dbg(&spi->dev, "SPI CLK %d Hz?\n",spi->max_speed_hz);
690 return -EINVAL;
691 }
692
693 spi->bits_per_word = 16;
694 err = spi_setup(spi);
695 if (err) {
696 dev_dbg(&spi->dev, "spi master doesn't support 16 bits/word\n");
697 return err;
698 }
699
700 ts = devm_kzalloc(&spi->dev, sizeof(struct ad7877), GFP_KERNEL);
701 if (!ts)
702 return -ENOMEM;
703
704 input_dev = devm_input_allocate_device(&spi->dev);
705 if (!input_dev)
706 return -ENOMEM;
707
708 err = devm_add_action_or_reset(&spi->dev, ad7877_disable, ts);
709 if (err)
710 return err;
711
712 spi_set_drvdata(spi, ts);
713 ts->spi = spi;
714 ts->input = input_dev;
715
716 timer_setup(&ts->timer, ad7877_timer, 0);
717 mutex_init(&ts->mutex);
718 spin_lock_init(&ts->lock);
719
720 ts->model = pdata->model ? : 7877;
> 721 ts->vref_delay.value = pdata->vref_delay_usecs ? : 100;
722 ts->vref_delay.unit = SPI_DELAY_UNIT_USECS;
723 ts->x_plate_ohms = pdata->x_plate_ohms ? : 400;
724 ts->pressure_max = pdata->pressure_max ? : ~0;
725
726 ts->stopacq_polarity = pdata->stopacq_polarity;
727 ts->first_conversion_delay = pdata->first_conversion_delay;
728 ts->acquisition_time = pdata->acquisition_time;
729 ts->averaging = pdata->averaging;
730 ts->pen_down_acc_interval = pdata->pen_down_acc_interval;
731
732 snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(&spi->dev));
733
734 input_dev->name = "AD7877 Touchscreen";
735 input_dev->phys = ts->phys;
736 input_dev->dev.parent = &spi->dev;
737
738 __set_bit(EV_KEY, input_dev->evbit);
739 __set_bit(BTN_TOUCH, input_dev->keybit);
740 __set_bit(EV_ABS, input_dev->evbit);
741 __set_bit(ABS_X, input_dev->absbit);
742 __set_bit(ABS_Y, input_dev->absbit);
743 __set_bit(ABS_PRESSURE, input_dev->absbit);
744
745 input_set_abs_params(input_dev, ABS_X,
746 pdata->x_min ? : 0,
747 pdata->x_max ? : MAX_12BIT,
748 0, 0);
749 input_set_abs_params(input_dev, ABS_Y,
750 pdata->y_min ? : 0,
751 pdata->y_max ? : MAX_12BIT,
752 0, 0);
753 input_set_abs_params(input_dev, ABS_PRESSURE,
754 pdata->pressure_min, pdata->pressure_max, 0, 0);
755
756 ad7877_write(spi, AD7877_REG_SEQ1, AD7877_MM_SEQUENCE);
757
758 verify = ad7877_read(spi, AD7877_REG_SEQ1);
759
760 if (verify != AD7877_MM_SEQUENCE) {
761 dev_err(&spi->dev, "%s: Failed to probe %s\n",
762 dev_name(&spi->dev), input_dev->name);
763 return -ENODEV;
764 }
765
766 if (gpio3)
767 ad7877_write(spi, AD7877_REG_EXTWRITE, AD7877_EXTW_GPIO_3_CONF);
768
769 ad7877_setup_ts_def_msg(spi, ts);
770
771 /* Request AD7877 /DAV GPIO interrupt */
772
773 err = devm_request_threaded_irq(&spi->dev, spi->irq, NULL, ad7877_irq,
774 IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
775 spi->dev.driver->name, ts);
776 if (err) {
777 dev_dbg(&spi->dev, "irq %d busy?\n", spi->irq);
778 return err;
779 }
780
781 err = devm_device_add_group(&spi->dev, &ad7877_attr_group);
782 if (err)
783 return err;
784
785 err = input_register_device(input_dev);
786 if (err)
787 return err;
788
789 return 0;
790 }
791
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH] input: touchscreen: ad7877: Use new structure for SPI transfer delays
by kbuild test robot
Hi Sergiu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on input/next]
[also build test ERROR on linux/master linus/master v5.6-rc3 next-20200227]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Sergiu-Cuciurean/input-touchscre...
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/input/touchscreen/ad7877.c: In function 'ad7877_probe':
>> drivers/input/touchscreen/ad7877.c:721:6: error: 'struct ad7877' has no member named 'vref_delay'; did you mean 'vref_delay_usecs'?
ts->vref_delay.value = pdata->vref_delay_usecs ? : 100;
^~~~~~~~~~
vref_delay_usecs
drivers/input/touchscreen/ad7877.c:722:6: error: 'struct ad7877' has no member named 'vref_delay'; did you mean 'vref_delay_usecs'?
ts->vref_delay.unit = SPI_DELAY_UNIT_USECS;
^~~~~~~~~~
vref_delay_usecs
vim +721 drivers/input/touchscreen/ad7877.c
668
669 static int ad7877_probe(struct spi_device *spi)
670 {
671 struct ad7877 *ts;
672 struct input_dev *input_dev;
673 struct ad7877_platform_data *pdata = dev_get_platdata(&spi->dev);
674 int err;
675 u16 verify;
676
677 if (!spi->irq) {
678 dev_dbg(&spi->dev, "no IRQ?\n");
679 return -ENODEV;
680 }
681
682 if (!pdata) {
683 dev_dbg(&spi->dev, "no platform data?\n");
684 return -ENODEV;
685 }
686
687 /* don't exceed max specified SPI CLK frequency */
688 if (spi->max_speed_hz > MAX_SPI_FREQ_HZ) {
689 dev_dbg(&spi->dev, "SPI CLK %d Hz?\n",spi->max_speed_hz);
690 return -EINVAL;
691 }
692
693 spi->bits_per_word = 16;
694 err = spi_setup(spi);
695 if (err) {
696 dev_dbg(&spi->dev, "spi master doesn't support 16 bits/word\n");
697 return err;
698 }
699
700 ts = devm_kzalloc(&spi->dev, sizeof(struct ad7877), GFP_KERNEL);
701 if (!ts)
702 return -ENOMEM;
703
704 input_dev = devm_input_allocate_device(&spi->dev);
705 if (!input_dev)
706 return -ENOMEM;
707
708 err = devm_add_action_or_reset(&spi->dev, ad7877_disable, ts);
709 if (err)
710 return err;
711
712 spi_set_drvdata(spi, ts);
713 ts->spi = spi;
714 ts->input = input_dev;
715
716 timer_setup(&ts->timer, ad7877_timer, 0);
717 mutex_init(&ts->mutex);
718 spin_lock_init(&ts->lock);
719
720 ts->model = pdata->model ? : 7877;
> 721 ts->vref_delay.value = pdata->vref_delay_usecs ? : 100;
722 ts->vref_delay.unit = SPI_DELAY_UNIT_USECS;
723 ts->x_plate_ohms = pdata->x_plate_ohms ? : 400;
724 ts->pressure_max = pdata->pressure_max ? : ~0;
725
726 ts->stopacq_polarity = pdata->stopacq_polarity;
727 ts->first_conversion_delay = pdata->first_conversion_delay;
728 ts->acquisition_time = pdata->acquisition_time;
729 ts->averaging = pdata->averaging;
730 ts->pen_down_acc_interval = pdata->pen_down_acc_interval;
731
732 snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(&spi->dev));
733
734 input_dev->name = "AD7877 Touchscreen";
735 input_dev->phys = ts->phys;
736 input_dev->dev.parent = &spi->dev;
737
738 __set_bit(EV_KEY, input_dev->evbit);
739 __set_bit(BTN_TOUCH, input_dev->keybit);
740 __set_bit(EV_ABS, input_dev->evbit);
741 __set_bit(ABS_X, input_dev->absbit);
742 __set_bit(ABS_Y, input_dev->absbit);
743 __set_bit(ABS_PRESSURE, input_dev->absbit);
744
745 input_set_abs_params(input_dev, ABS_X,
746 pdata->x_min ? : 0,
747 pdata->x_max ? : MAX_12BIT,
748 0, 0);
749 input_set_abs_params(input_dev, ABS_Y,
750 pdata->y_min ? : 0,
751 pdata->y_max ? : MAX_12BIT,
752 0, 0);
753 input_set_abs_params(input_dev, ABS_PRESSURE,
754 pdata->pressure_min, pdata->pressure_max, 0, 0);
755
756 ad7877_write(spi, AD7877_REG_SEQ1, AD7877_MM_SEQUENCE);
757
758 verify = ad7877_read(spi, AD7877_REG_SEQ1);
759
760 if (verify != AD7877_MM_SEQUENCE) {
761 dev_err(&spi->dev, "%s: Failed to probe %s\n",
762 dev_name(&spi->dev), input_dev->name);
763 return -ENODEV;
764 }
765
766 if (gpio3)
767 ad7877_write(spi, AD7877_REG_EXTWRITE, AD7877_EXTW_GPIO_3_CONF);
768
769 ad7877_setup_ts_def_msg(spi, ts);
770
771 /* Request AD7877 /DAV GPIO interrupt */
772
773 err = devm_request_threaded_irq(&spi->dev, spi->irq, NULL, ad7877_irq,
774 IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
775 spi->dev.driver->name, ts);
776 if (err) {
777 dev_dbg(&spi->dev, "irq %d busy?\n", spi->irq);
778 return err;
779 }
780
781 err = devm_device_add_group(&spi->dev, &ad7877_attr_group);
782 if (err)
783 return err;
784
785 err = input_register_device(input_dev);
786 if (err)
787 return err;
788
789 return 0;
790 }
791
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH 12/21] drm/msm: remove checks for return value of drm_debugfs functions.
by kbuild test robot
Hi Wambui,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on linus/master v5.6-rc3 next-20200227]
[cannot apply to tegra/for-next anholt/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Wambui-Karuga/drm-subsytem-wide-...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1437:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.debugfs_init = a5xx_debugfs_init,
^~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1437:19: note: (near initialization for 'funcs.base.debugfs_init')
cc1: some warnings being treated as errors
--
>> drivers/gpu/drm/msm/adreno/a5xx_debugfs.c:151:6: error: conflicting types for 'a5xx_debugfs_init'
void a5xx_debugfs_init(struct msm_gpu *gpu, struct drm_minor *minor)
^~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/msm/adreno/a5xx_debugfs.c:12:0:
drivers/gpu/drm/msm/adreno/a5xx_gpu.h:44:5: note: previous declaration of 'a5xx_debugfs_init' was here
int a5xx_debugfs_init(struct msm_gpu *gpu, struct drm_minor *minor);
^~~~~~~~~~~~~~~~~
vim +/a5xx_debugfs_init +151 drivers/gpu/drm/msm/adreno/a5xx_debugfs.c
149
150
> 151 void a5xx_debugfs_init(struct msm_gpu *gpu, struct drm_minor *minor)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
[mptcp:for-review 107/11316] net//mptcp/crypto.c:150:1: note: in expansion of macro 'late_initcall'
by kbuild test robot
tree: https://github.com/multipath-tcp/mptcp_net-next.git for-review
head: d473c29c70bb95e1175a47e4707299f5556e03be
commit: 54e7ef56974e94d571ea173ace9f5582d54ea430 [107/11316] mptcp: move from sha1 (v0) to sha256 (v1)
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 54e7ef56974e94d571ea173ace9f5582d54ea430
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Note: the mptcp/for-review HEAD d473c29c70bb95e1175a47e4707299f5556e03be builds fine.
It only hurts bisectibility.
All error/warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:6:0,
from include/linux/kernel.h:15,
from net//mptcp/crypto.c:23:
>> net//mptcp/crypto.c:150:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
late_initcall(crypto_test);
^
include/linux/init.h:197:50: note: in definition of macro '___define_initcall'
__attribute__((__section__(#__sec ".init"))) = fn;
^~
include/linux/init.h:231:28: note: in expansion of macro '__define_initcall'
#define late_initcall(fn) __define_initcall(fn, 7)
^~~~~~~~~~~~~~~~~
>> net//mptcp/crypto.c:150:1: note: in expansion of macro 'late_initcall'
late_initcall(crypto_test);
^~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/late_initcall +150 net//mptcp/crypto.c
149
> 150 late_initcall(crypto_test);
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months
Re: [PATCH net-next 2/2] net: datagram: drop 'destructor' argument from several helpers
by kbuild test robot
Hi Paolo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on net/master linus/master v5.6-rc3 next-20200227]
[cannot apply to ipvs/master sparc-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Paolo-Abeni/net-cleanup-datagram...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 2b99e54b30ed56201dedd91e6049ed83aa9d2302
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (git://gitmirror/llvm_project 949134e2fefd34a38ed71de90dffe2300e2e1139)
reproduce:
# FIXME the reproduce steps for clang is not ready yet
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> net/xfrm/espintcp.c:103:68: error: too many arguments to function call, expected 5, have 6
skb = __skb_recv_datagram(sk, &ctx->ike_queue, flags, NULL, &off, &err);
~~~~~~~~~~~~~~~~~~~ ^~~~
include/linux/skbuff.h:3523:17: note: '__skb_recv_datagram' declared here
struct sk_buff *__skb_recv_datagram(struct sock *sk,
^
1 error generated.
vim +103 net/xfrm/espintcp.c
e27cca96cd68fa Sabrina Dubroca 2019-11-25 91
e27cca96cd68fa Sabrina Dubroca 2019-11-25 92 static int espintcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
e27cca96cd68fa Sabrina Dubroca 2019-11-25 93 int nonblock, int flags, int *addr_len)
e27cca96cd68fa Sabrina Dubroca 2019-11-25 94 {
e27cca96cd68fa Sabrina Dubroca 2019-11-25 95 struct espintcp_ctx *ctx = espintcp_getctx(sk);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 96 struct sk_buff *skb;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 97 int err = 0;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 98 int copied;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 99 int off = 0;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 100
e27cca96cd68fa Sabrina Dubroca 2019-11-25 101 flags |= nonblock ? MSG_DONTWAIT : 0;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 102
e27cca96cd68fa Sabrina Dubroca 2019-11-25 @103 skb = __skb_recv_datagram(sk, &ctx->ike_queue, flags, NULL, &off, &err);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 104 if (!skb)
e27cca96cd68fa Sabrina Dubroca 2019-11-25 105 return err;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 106
e27cca96cd68fa Sabrina Dubroca 2019-11-25 107 copied = len;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 108 if (copied > skb->len)
e27cca96cd68fa Sabrina Dubroca 2019-11-25 109 copied = skb->len;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 110 else if (copied < skb->len)
e27cca96cd68fa Sabrina Dubroca 2019-11-25 111 msg->msg_flags |= MSG_TRUNC;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 112
e27cca96cd68fa Sabrina Dubroca 2019-11-25 113 err = skb_copy_datagram_msg(skb, 0, msg, copied);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 114 if (unlikely(err)) {
e27cca96cd68fa Sabrina Dubroca 2019-11-25 115 kfree_skb(skb);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 116 return err;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 117 }
e27cca96cd68fa Sabrina Dubroca 2019-11-25 118
e27cca96cd68fa Sabrina Dubroca 2019-11-25 119 if (flags & MSG_TRUNC)
e27cca96cd68fa Sabrina Dubroca 2019-11-25 120 copied = skb->len;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 121 kfree_skb(skb);
e27cca96cd68fa Sabrina Dubroca 2019-11-25 122 return copied;
e27cca96cd68fa Sabrina Dubroca 2019-11-25 123 }
e27cca96cd68fa Sabrina Dubroca 2019-11-25 124
:::::: The code at line 103 was first introduced by commit
:::::: e27cca96cd68fa2c6814c90f9a1cfd36bb68c593 xfrm: add espintcp (RFC 8229)
:::::: TO: Sabrina Dubroca <sd(a)queasysnail.net>
:::::: CC: Steffen Klassert <steffen.klassert(a)secunet.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 11 months