Re: [PATCH v1 1/7] mdio_bus: Introduce fwnode MDIO helpers
by kbuild test robot
Hi Calvin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.5]
[cannot apply to driver-core/driver-core-testing net-next/master net/master linus/master sparc-next/master next-20200203]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Calvin-Johnson/ACPI-support-for-...
base: d5226fa6dbae0569ee43ecfc08bdcd6770fc4755
reproduce: make htmldocs
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
Warning: The Sphinx 'sphinx_rtd_theme' HTML theme was not found. Make sure you have the theme installed to produce pretty HTML output. Falling back to the default theme.
WARNING: dot(1) not found, for better output quality install graphviz from http://www.graphviz.org
WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org)
include/linux/spi/spi.h:207: warning: Function parameter or member 'driver_override' not described in 'spi_device'
include/linux/spi/spi.h:650: warning: Function parameter or member 'irq_flags' not described in 'spi_controller'
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c:1: warning: no structured comments found
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1: warning: no structured comments found
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:254: warning: Function parameter or member 'hdcp_workqueue' not described in 'amdgpu_display_manager'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'quotactl' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'quota_on' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'sb_free_mnt_opts' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'sb_eat_lsm_opts' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'sb_kern_mount' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'sb_show_options' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'sb_add_mnt_opt' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'd_instantiate' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'getprocattr' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'setprocattr' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'locked_down' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_open' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_alloc' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_free' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_read' not described in 'security_list_options'
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_write' not described in 'security_list_options'
drivers/usb/typec/bus.c:1: warning: 'typec_altmode_unregister_driver' not found
drivers/usb/typec/bus.c:1: warning: 'typec_altmode_register_driver' not found
drivers/usb/typec/class.c:1: warning: 'typec_altmode_register_notifier' not found
drivers/usb/typec/class.c:1: warning: 'typec_altmode_unregister_notifier' not found
sound/soc/soc-core.c:2522: warning: Function parameter or member 'legacy_dai_naming' not described in 'snd_soc_register_dai'
include/linux/regulator/machine.h:196: warning: Function parameter or member 'max_uV_step' not described in 'regulation_constraints'
include/linux/regulator/driver.h:223: warning: Function parameter or member 'resume' not described in 'regulator_ops'
include/linux/skbuff.h:888: warning: Function parameter or member 'dev_scratch' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'list' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'ip_defrag_offset' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'skb_mstamp_ns' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member '__cloned_offset' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'head_frag' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member '__pkt_type_offset' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'encapsulation' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'encap_hdr_csum' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'csum_valid' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member '__pkt_vlan_present_offset' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'vlan_present' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'csum_complete_sw' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'csum_level' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'inner_protocol_type' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'remcsum_offload' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'sender_cpu' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'reserved_tailroom' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'inner_ipproto' not described in 'sk_buff'
include/net/sock.h:232: warning: Function parameter or member 'skc_addrpair' not described in 'sock_common'
include/net/sock.h:232: warning: Function parameter or member 'skc_portpair' not described in 'sock_common'
include/net/sock.h:232: warning: Function parameter or member 'skc_ipv6only' not described in 'sock_common'
include/net/sock.h:232: warning: Function parameter or member 'skc_net_refcnt' not described in 'sock_common'
include/net/sock.h:232: warning: Function parameter or member 'skc_v6_daddr' not described in 'sock_common'
include/net/sock.h:232: warning: Function parameter or member 'skc_v6_rcv_saddr' not described in 'sock_common'
include/net/sock.h:232: warning: Function parameter or member 'skc_cookie' not described in 'sock_common'
include/net/sock.h:232: warning: Function parameter or member 'skc_listener' not described in 'sock_common'
include/net/sock.h:232: warning: Function parameter or member 'skc_tw_dr' not described in 'sock_common'
include/net/sock.h:232: warning: Function parameter or member 'skc_rcv_wnd' not described in 'sock_common'
include/net/sock.h:232: warning: Function parameter or member 'skc_tw_rcv_nxt' not described in 'sock_common'
include/net/sock.h:514: warning: Function parameter or member 'sk_rx_skb_cache' not described in 'sock'
include/net/sock.h:514: warning: Function parameter or member 'sk_wq_raw' not described in 'sock'
include/net/sock.h:514: warning: Function parameter or member 'tcp_rtx_queue' not described in 'sock'
include/net/sock.h:514: warning: Function parameter or member 'sk_tx_skb_cache' not described in 'sock'
include/net/sock.h:514: warning: Function parameter or member 'sk_route_forced_caps' not described in 'sock'
include/net/sock.h:514: warning: Function parameter or member 'sk_txtime_report_errors' not described in 'sock'
include/net/sock.h:514: warning: Function parameter or member 'sk_validate_xmit_skb' not described in 'sock'
include/net/sock.h:514: warning: Function parameter or member 'sk_bpf_storage' not described in 'sock'
include/net/sock.h:2459: warning: Function parameter or member 'tcp_rx_skb_cache_key' not described in 'DECLARE_STATIC_KEY_FALSE'
include/net/sock.h:2459: warning: Excess function parameter 'sk' description in 'DECLARE_STATIC_KEY_FALSE'
include/net/sock.h:2459: warning: Excess function parameter 'skb' description in 'DECLARE_STATIC_KEY_FALSE'
net/core/skbuff.c:5489: warning: Function parameter or member 'ethernet' not described in 'skb_mpls_push'
include/linux/netdevice.h:2082: warning: Function parameter or member 'gso_partial_features' not described in 'net_device'
include/linux/netdevice.h:2082: warning: Function parameter or member 'l3mdev_ops' not described in 'net_device'
include/linux/netdevice.h:2082: warning: Function parameter or member 'xfrmdev_ops' not described in 'net_device'
include/linux/netdevice.h:2082: warning: Function parameter or member 'tlsdev_ops' not described in 'net_device'
include/linux/netdevice.h:2082: warning: Function parameter or member 'name_assign_type' not described in 'net_device'
include/linux/netdevice.h:2082: warning: Function parameter or member 'ieee802154_ptr' not described in 'net_device'
include/linux/netdevice.h:2082: warning: Function parameter or member 'mpls_ptr' not described in 'net_device'
include/linux/netdevice.h:2082: warning: Function parameter or member 'xdp_prog' not described in 'net_device'
include/linux/netdevice.h:2082: warning: Function parameter or member 'gro_flush_timeout' not described in 'net_device'
include/linux/netdevice.h:2082: warning: Function parameter or member 'nf_hooks_ingress' not described in 'net_device'
include/linux/netdevice.h:2082: warning: Function parameter or member 'qdisc_hash' not described in 'net_device'
include/linux/netdevice.h:2082: warning: Function parameter or member 'xps_cpus_map' not described in 'net_device'
include/linux/netdevice.h:2082: warning: Function parameter or member 'xps_rxqs_map' not described in 'net_device'
>> drivers/net/phy/mdio_bus.c:837: warning: Function parameter or member 'child' not described in 'fwnode_mdiobus_child_is_phy'
include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(advertising' not described in 'phylink_link_state'
include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(lp_advertising' not described in 'phylink_link_state'
drivers/infiniband/core/umem_odp.c:167: warning: Function parameter or member 'ops' not described in 'ib_umem_odp_alloc_child'
drivers/infiniband/core/umem_odp.c:217: warning: Function parameter or member 'ops' not described in 'ib_umem_odp_get'
drivers/infiniband/ulp/iser/iscsi_iser.h:401: warning: Function parameter or member 'all_list' not described in 'iser_fr_desc'
drivers/infiniband/ulp/iser/iscsi_iser.h:415: warning: Function parameter or member 'all_list' not described in 'iser_fr_pool'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd0' not described in 'opa_vesw_info'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd1' not described in 'opa_vesw_info'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd2' not described in 'opa_vesw_info'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd3' not described in 'opa_vesw_info'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd4' not described in 'opa_vesw_info'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:205: warning: Function parameter or member 'rsvd0' not described in 'opa_per_veswport_info'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:205: warning: Function parameter or member 'rsvd1' not described in 'opa_per_veswport_info'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:205: warning: Function parameter or member 'rsvd2' not described in 'opa_per_veswport_info'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:205: warning: Function parameter or member 'rsvd3' not described in 'opa_per_veswport_info'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:263: warning: Function parameter or member 'tbl_entries' not described in 'opa_veswport_mactable'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:342: warning: Function parameter or member 'reserved' not described in 'opa_veswport_summary_counters'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd0' not described in 'opa_veswport_error_counters'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd1' not described in 'opa_veswport_error_counters'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd2' not described in 'opa_veswport_error_counters'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd3' not described in 'opa_veswport_error_counters'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd4' not described in 'opa_veswport_error_counters'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd5' not described in 'opa_veswport_error_counters'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd6' not described in 'opa_veswport_error_counters'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd7' not described in 'opa_veswport_error_counters'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd8' not described in 'opa_veswport_error_counters'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd9' not described in 'opa_veswport_error_counters'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:460: warning: Function parameter or member 'reserved' not described in 'opa_vnic_vema_mad'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:485: warning: Function parameter or member 'reserved' not described in 'opa_vnic_notice_attr'
drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:500: warning: Function parameter or member 'reserved' not described in 'opa_vnic_vema_mad_trap'
include/linux/input/sparse-keymap.h:43: warning: Function parameter or member 'sw' not described in 'key_entry'
include/drm/drm_modeset_helper_vtables.h:1052: warning: Function parameter or member 'prepare_writeback_job' not described in 'drm_connector_helper_funcs'
include/drm/drm_modeset_helper_vtables.h:1052: warning: Function parameter or member 'cleanup_writeback_job' not described in 'drm_connector_helper_funcs'
include/net/cfg80211.h:1189: warning: Function parameter or member 'txpwr' not described in 'station_parameters'
include/net/mac80211.h:4081: warning: Function parameter or member 'sta_set_txpwr' not described in 'ieee80211_ops'
include/net/mac80211.h:2036: warning: Function parameter or member 'txpwr' not described in 'ieee80211_sta'
include/linux/devfreq.h:187: warning: Function parameter or member 'last_status' not described in 'devfreq'
drivers/devfreq/devfreq.c:1818: warning: bad line: - Resource-managed devfreq_register_notifier()
drivers/devfreq/devfreq.c:1854: warning: bad line: - Resource-managed devfreq_unregister_notifier()
drivers/devfreq/devfreq-event.c:355: warning: Function parameter or member 'edev' not described in 'devfreq_event_remove_edev'
drivers/devfreq/devfreq-event.c:355: warning: Excess function parameter 'dev' description in 'devfreq_event_remove_edev'
Documentation/admin-guide/hw-vuln/tsx_async_abort.rst:142: WARNING: duplicate label virt_mechanism, other instance in Documentation/admin-guide/hw-vuln/mds.rst
Documentation/admin-guide/ras.rst:358: WARNING: Definition list ends without a blank line; unexpected unindent.
Documentation/admin-guide/ras.rst:358: WARNING: Definition list ends without a blank line; unexpected unindent.
Documentation/admin-guide/ras.rst:363: WARNING: Definition list ends without a blank line; unexpected unindent.
Documentation/admin-guide/ras.rst:363: WARNING: Definition list ends without a blank line; unexpected unindent.
Documentation/driver-api/driver-model/driver.rst:215: WARNING: Inline emphasis start-string without end-string.
Documentation/driver-api/driver-model/driver.rst:215: WARNING: Inline emphasis start-string without end-string.
include/uapi/linux/firewire-cdev.h:312: WARNING: Inline literal start-string without end-string.
drivers/firewire/core-transaction.c:606: WARNING: Inline strong start-string without end-string.
Documentation/usb/index.rst:5: WARNING: toctree contains reference to nonexisting document 'usb/rio'
Documentation/usb/index.rst:5: WARNING: toctree contains reference to nonexisting document 'usb/wusb-design-overview'
Documentation/x86/boot.rst:72: WARNING: Malformed table.
Text in column margin in table line 57.
vim +837 drivers/net/phy/mdio_bus.c
827
828 /**
829 * fwnode_mdiobus_child_is_phy - Return true if the child is a PHY node.
830 * It must either:
831 * o Compatible string of "ethernet-phy-ieee802.3-c45"
832 * o Compatible string of "ethernet-phy-ieee802.3-c22"
833 * Checking "compatible" property is done, in order to follow the DT binding.
834 */
835 static bool fwnode_mdiobus_child_is_phy(struct fwnode_handle *child)
836 {
> 837 int ret;
838
839 ret = fwnode_property_match_string(child, "compatible",
840 "ethernet-phy-ieee802.3-c45");
841 if (!ret)
842 return true;
843
844 ret = fwnode_property_match_string(child, "compatible",
845 "ethernet-phy-ieee802.3-c22");
846 if (!ret)
847 return true;
848
849 if (!fwnode_property_present(child, "compatible"))
850 return true;
851
852 return false;
853 }
854
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 3 months
[linux-sof-driver:pr/1748 9/15] sound/soc/sof/sof-audio.h:102:26: error: field 'comp_dai' has incomplete type
by kbuild test robot
tree: https://github.com/thesofproject/linux pr/1748
head: 142a0a337956be9301c8b331ad19221182bce4d2
commit: f3965cc33d636deea35a2e87b277895f408730a1 [9/15] ASoC: SOF: Add descriptor for snd_sof_client
config: x86_64-sof-customedconfig-sof-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
git checkout f3965cc33d636deea35a2e87b277895f408730a1
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Note: the linux-sof-driver/pr/1748 HEAD 142a0a337956be9301c8b331ad19221182bce4d2 builds fine.
It only hurts bisectibility.
All error/warnings (new ones prefixed by >>):
In file included from sound/soc/sof/core.c:16:0:
>> sound/soc/sof/sof-audio.h:102:26: error: field 'comp_dai' has incomplete type
struct sof_ipc_comp_dai comp_dai;
^~~~~~~~
>> sound/soc/sof/sof-audio.h:175:13: warning: 'struct sof_ipc_comp_reply' declared inside parameter list will not be visible outside of this definition or declaration
struct sof_ipc_comp_reply *r);
^~~~~~~~~~~~~~~~~~
>> sound/soc/sof/sof-audio.h:174:13: warning: 'struct sof_ipc_pipe_new' declared inside parameter list will not be visible outside of this definition or declaration
struct sof_ipc_pipe_new *pipeline,
^~~~~~~~~~~~~~~~
--
In file included from sound/soc/sof/pcm.c:17:0:
>> sound/soc/sof/sof-audio.h:102:26: error: field 'comp_dai' has incomplete type
struct sof_ipc_comp_dai comp_dai;
^~~~~~~~
>> sound/soc/sof/sof-audio.h:175:13: warning: 'struct sof_ipc_comp_reply' declared inside parameter list will not be visible outside of this definition or declaration
struct sof_ipc_comp_reply *r);
^~~~~~~~~~~~~~~~~~
>> sound/soc/sof/sof-audio.h:174:13: warning: 'struct sof_ipc_pipe_new' declared inside parameter list will not be visible outside of this definition or declaration
struct sof_ipc_pipe_new *pipeline,
^~~~~~~~~~~~~~~~
sound/soc/sof/pcm.c: In function 'create_page_table':
>> sound/soc/sof/pcm.c:34:9: error: implicit declaration of function 'sof_client_create_page_table'; did you mean 'create_page_table'? [-Werror=implicit-function-declaration]
return sof_client_create_page_table(component->dev, dmab,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
create_page_table
sound/soc/sof/pcm.c: In function 'sof_pcm_pointer':
sound/soc/sof/pcm.c:424:22: warning: unused variable 'sdev' [-Wunused-variable]
struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(component);
^~~~
sound/soc/sof/pcm.c: In function 'sof_pcm_dai_link_fixup':
>> sound/soc/sof/pcm.c:682:25: error: dereferencing pointer to incomplete type 'struct sof_ipc_dai_config'
switch (dai->dai_config->type) {
^~
>> sound/soc/sof/pcm.c:683:7: error: 'SOF_DAI_INTEL_SSP' undeclared (first use in this function); did you mean 'SOF_DAI_STREAM'?
case SOF_DAI_INTEL_SSP:
^~~~~~~~~~~~~~~~~
SOF_DAI_STREAM
sound/soc/sof/pcm.c:683:7: note: each undeclared identifier is reported only once for each function it appears in
>> sound/soc/sof/pcm.c:696:7: error: 'SOF_DAI_INTEL_DMIC' undeclared (first use in this function); did you mean 'SOF_DAI_INTEL_SSP'?
case SOF_DAI_INTEL_DMIC:
^~~~~~~~~~~~~~~~~~
SOF_DAI_INTEL_SSP
>> sound/soc/sof/pcm.c:705:7: error: 'SOF_DAI_INTEL_HDA' undeclared (first use in this function); did you mean 'SOF_DAI_INTEL_SSP'?
case SOF_DAI_INTEL_HDA:
^~~~~~~~~~~~~~~~~
SOF_DAI_INTEL_SSP
>> sound/soc/sof/pcm.c:708:7: error: 'SOF_DAI_INTEL_ALH' undeclared (first use in this function); did you mean 'SOF_DAI_INTEL_HDA'?
case SOF_DAI_INTEL_ALH:
^~~~~~~~~~~~~~~~~
SOF_DAI_INTEL_HDA
>> sound/soc/sof/pcm.c:711:7: error: 'SOF_DAI_IMX_ESAI' undeclared (first use in this function); did you mean 'SOF_DAI_STREAM'?
case SOF_DAI_IMX_ESAI:
^~~~~~~~~~~~~~~~
SOF_DAI_STREAM
>> sound/soc/sof/pcm.c:719:7: error: 'SOF_DAI_IMX_SAI' undeclared (first use in this function); did you mean 'SOF_DAI_IMX_ESAI'?
case SOF_DAI_IMX_SAI:
^~~~~~~~~~~~~~~
SOF_DAI_IMX_ESAI
cc1: some warnings being treated as errors
--
In file included from sound/soc/sof/topology.c:16:0:
>> sound/soc/sof/sof-audio.h:102:26: error: field 'comp_dai' has incomplete type
struct sof_ipc_comp_dai comp_dai;
^~~~~~~~
>> sound/soc/sof/sof-audio.h:175:13: warning: 'struct sof_ipc_comp_reply' declared inside parameter list will not be visible outside of this definition or declaration
struct sof_ipc_comp_reply *r);
^~~~~~~~~~~~~~~~~~
>> sound/soc/sof/sof-audio.h:174:13: warning: 'struct sof_ipc_pipe_new' declared inside parameter list will not be visible outside of this definition or declaration
struct sof_ipc_pipe_new *pipeline,
^~~~~~~~~~~~~~~~
>> sound/soc/sof/topology.c:215:3: error: 'SOF_KEYWORD_DETECT_DAPM_EVENT' undeclared here (not in a function)
{SOF_KEYWORD_DETECT_DAPM_EVENT, sof_keyword_dapm_event},
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> sound/soc/sof/topology.c:365:24: error: field 'type' has incomplete type
enum sof_ipc_dai_type type;
^~~~
>> sound/soc/sof/topology.c:369:10: error: 'SOF_DAI_INTEL_SSP' undeclared here (not in a function); did you mean 'SOF_DAI_STREAM'?
{"SSP", SOF_DAI_INTEL_SSP},
^~~~~~~~~~~~~~~~~
SOF_DAI_STREAM
>> sound/soc/sof/topology.c:370:10: error: 'SOF_DAI_INTEL_HDA' undeclared here (not in a function); did you mean 'SOF_DAI_INTEL_SSP'?
{"HDA", SOF_DAI_INTEL_HDA},
^~~~~~~~~~~~~~~~~
SOF_DAI_INTEL_SSP
>> sound/soc/sof/topology.c:371:11: error: 'SOF_DAI_INTEL_DMIC' undeclared here (not in a function); did you mean 'SOF_DAI_INTEL_HDA'?
{"DMIC", SOF_DAI_INTEL_DMIC},
^~~~~~~~~~~~~~~~~~
SOF_DAI_INTEL_HDA
>> sound/soc/sof/topology.c:372:10: error: 'SOF_DAI_INTEL_ALH' undeclared here (not in a function); did you mean 'SOF_DAI_INTEL_HDA'?
{"ALH", SOF_DAI_INTEL_ALH},
^~~~~~~~~~~~~~~~~
SOF_DAI_INTEL_HDA
>> sound/soc/sof/topology.c:373:10: error: 'SOF_DAI_IMX_SAI' undeclared here (not in a function); did you mean 'SOF_DAI_INTEL_SSP'?
{"SAI", SOF_DAI_IMX_SAI},
^~~~~~~~~~~~~~~
SOF_DAI_INTEL_SSP
>> sound/soc/sof/topology.c:374:11: error: 'SOF_DAI_IMX_ESAI' undeclared here (not in a function); did you mean 'SOF_DAI_IMX_SAI'?
{"ESAI", SOF_DAI_IMX_ESAI},
^~~~~~~~~~~~~~~~
SOF_DAI_IMX_SAI
>> sound/soc/sof/topology.c:377:30: error: return type is an incomplete type
static enum sof_ipc_dai_type find_dai(const char *name)
^~~~~~~~
sound/soc/sof/topology.c: In function 'find_dai':
>> sound/soc/sof/topology.c:383:11: warning: 'return' with a value, in function returning void
return sof_dais[i].type;
^~~~~~~~
sound/soc/sof/topology.c:377:30: note: declared here
static enum sof_ipc_dai_type find_dai(const char *name)
^~~~~~~~
>> sound/soc/sof/topology.c:386:9: error: 'SOF_DAI_INTEL_NONE' undeclared (first use in this function); did you mean 'SOF_DAI_INTEL_ALH'?
return SOF_DAI_INTEL_NONE;
^~~~~~~~~~~~~~~~~~
SOF_DAI_INTEL_ALH
sound/soc/sof/topology.c:386:9: note: each undeclared identifier is reported only once for each function it appears in
sound/soc/sof/topology.c:386:9: warning: 'return' with a value, in function returning void
sound/soc/sof/topology.c:377:30: note: declared here
static enum sof_ipc_dai_type find_dai(const char *name)
^~~~~~~~
sound/soc/sof/topology.c: At top level:
sound/soc/sof/topology.c:420:28: error: field 'type' has incomplete type
enum sof_ipc_process_type type;
^~~~
>> sound/soc/sof/topology.c:421:21: error: field 'comp_type' has incomplete type
enum sof_comp_type comp_type;
^~~~~~~~~
>> sound/soc/sof/topology.c:425:12: error: 'SOF_PROCESS_EQFIR' undeclared here (not in a function); did you mean 'MP_PROCESSOR'?
{"EQFIR", SOF_PROCESS_EQFIR, SOF_COMP_EQ_FIR},
^~~~~~~~~~~~~~~~~
MP_PROCESSOR
>> sound/soc/sof/topology.c:425:31: error: 'SOF_COMP_EQ_FIR' undeclared here (not in a function); did you mean 'SOF_CHMAP_TFR'?
{"EQFIR", SOF_PROCESS_EQFIR, SOF_COMP_EQ_FIR},
^~~~~~~~~~~~~~~
SOF_CHMAP_TFR
>> sound/soc/sof/topology.c:426:12: error: 'SOF_PROCESS_EQIIR' undeclared here (not in a function); did you mean 'SOF_PROCESS_EQFIR'?
{"EQIIR", SOF_PROCESS_EQIIR, SOF_COMP_EQ_IIR},
^~~~~~~~~~~~~~~~~
SOF_PROCESS_EQFIR
>> sound/soc/sof/topology.c:426:31: error: 'SOF_COMP_EQ_IIR' undeclared here (not in a function); did you mean 'SOF_COMP_EQ_FIR'?
{"EQIIR", SOF_PROCESS_EQIIR, SOF_COMP_EQ_IIR},
^~~~~~~~~~~~~~~
SOF_COMP_EQ_FIR
>> sound/soc/sof/topology.c:427:21: error: 'SOF_PROCESS_KEYWORD_DETECT' undeclared here (not in a function); did you mean 'SOF_PROCESS_EQIIR'?
{"KEYWORD_DETECT", SOF_PROCESS_KEYWORD_DETECT, SOF_COMP_KEYWORD_DETECT},
^~~~~~~~~~~~~~~~~~~~~~~~~~
SOF_PROCESS_EQIIR
--
In file included from sound/soc/sof/sof-audio.c:11:0:
>> sound/soc/sof/sof-audio.h:102:26: error: field 'comp_dai' has incomplete type
struct sof_ipc_comp_dai comp_dai;
^~~~~~~~
>> sound/soc/sof/sof-audio.h:175:13: warning: 'struct sof_ipc_comp_reply' declared inside parameter list will not be visible outside of this definition or declaration
struct sof_ipc_comp_reply *r);
^~~~~~~~~~~~~~~~~~
>> sound/soc/sof/sof-audio.h:174:13: warning: 'struct sof_ipc_pipe_new' declared inside parameter list will not be visible outside of this definition or declaration
struct sof_ipc_pipe_new *pipeline,
^~~~~~~~~~~~~~~~
sound/soc/sof/sof-audio.c: In function 'sof_restore_pipelines':
>> sound/soc/sof/sof-audio.c:261:29: error: storage size of 'r' isn't known
struct sof_ipc_comp_reply r;
^
>> sound/soc/sof/sof-audio.c:273:16: error: dereferencing pointer to incomplete type 'struct sof_ipc_comp_dai'
comp_dai->comp.hdr.cmd,
^~
>> sound/soc/sof/sof-audio.c:286:37: error: passing argument 2 of 'sof_load_pipeline_ipc' from incompatible pointer type [-Werror=incompatible-pointer-types]
ret = sof_load_pipeline_ipc(dev, pipeline, &r);
^~~~~~~~
In file included from sound/soc/sof/sof-audio.c:11:0:
sound/soc/sof/sof-audio.h:173:5: note: expected 'struct sof_ipc_pipe_new *' but argument is of type 'struct sof_ipc_pipe_new *'
int sof_load_pipeline_ipc(struct device *dev,
^~~~~~~~~~~~~~~~~~~~~
sound/soc/sof/sof-audio.c:261:29: warning: unused variable 'r' [-Wunused-variable]
struct sof_ipc_comp_reply r;
^
>> sound/soc/sof/sof-audio.c:317:14: error: dereferencing pointer to incomplete type 'struct sof_ipc_pipe_comp_connect'
connect->hdr.cmd,
^~
>> sound/soc/sof/sof-audio.c:349:13: error: dereferencing pointer to incomplete type 'struct sof_ipc_dai_config'
if (config->type == SOF_DAI_INTEL_HDA)
^~
>> sound/soc/sof/sof-audio.c:349:23: error: 'SOF_DAI_INTEL_HDA' undeclared (first use in this function); did you mean 'SOF_DAI_STREAM'?
if (config->type == SOF_DAI_INTEL_HDA)
^~~~~~~~~~~~~~~~~
SOF_DAI_STREAM
sound/soc/sof/sof-audio.c:349:23: note: each undeclared identifier is reported only once for each function it appears in
cc1: some warnings being treated as errors
--
In file included from sound/soc/sof/intel/hda.c:28:0:
>> sound/soc/sof/intel/../sof-audio.h:102:26: error: field 'comp_dai' has incomplete type
struct sof_ipc_comp_dai comp_dai;
^~~~~~~~
>> sound/soc/sof/intel/../sof-audio.h:175:13: warning: 'struct sof_ipc_comp_reply' declared inside parameter list will not be visible outside of this definition or declaration
struct sof_ipc_comp_reply *r);
^~~~~~~~~~~~~~~~~~
>> sound/soc/sof/intel/../sof-audio.h:174:13: warning: 'struct sof_ipc_pipe_new' declared inside parameter list will not be visible outside of this definition or declaration
struct sof_ipc_pipe_new *pipeline,
^~~~~~~~~~~~~~~~
vim +/comp_dai +102 sound/soc/sof/sof-audio.h
172dfd1a153473 Ranjani Sridharan 2019-11-12 95
172dfd1a153473 Ranjani Sridharan 2019-11-12 96 /* ASoC DAI device */
172dfd1a153473 Ranjani Sridharan 2019-11-12 97 struct snd_sof_dai {
172dfd1a153473 Ranjani Sridharan 2019-11-12 98 struct snd_soc_component *scomp;
172dfd1a153473 Ranjani Sridharan 2019-11-12 99 const char *name;
172dfd1a153473 Ranjani Sridharan 2019-11-12 100 const char *cpu_dai_name;
172dfd1a153473 Ranjani Sridharan 2019-11-12 101
172dfd1a153473 Ranjani Sridharan 2019-11-12 @102 struct sof_ipc_comp_dai comp_dai;
172dfd1a153473 Ranjani Sridharan 2019-11-12 103 struct sof_ipc_dai_config *dai_config;
172dfd1a153473 Ranjani Sridharan 2019-11-12 104 struct list_head list; /* list in sdev dai list */
172dfd1a153473 Ranjani Sridharan 2019-11-12 105 };
172dfd1a153473 Ranjani Sridharan 2019-11-12 106
24d65282a3584f Ranjani Sridharan 2020-01-17 107 /* SOF audio client data */
24d65282a3584f Ranjani Sridharan 2020-01-17 108 struct snd_sof_audio_data {
24d65282a3584f Ranjani Sridharan 2020-01-17 109 struct device *dev;
24d65282a3584f Ranjani Sridharan 2020-01-17 110 struct device *dma_dev;
24d65282a3584f Ranjani Sridharan 2020-01-17 111
24d65282a3584f Ranjani Sridharan 2020-01-17 112 /* topology info */
24d65282a3584f Ranjani Sridharan 2020-01-17 113 const char *tplg_filename_prefix;
24d65282a3584f Ranjani Sridharan 2020-01-17 114 const char *tplg_filename;
24d65282a3584f Ranjani Sridharan 2020-01-17 115
24d65282a3584f Ranjani Sridharan 2020-01-17 116 /* machine info */
24d65282a3584f Ranjani Sridharan 2020-01-17 117 struct platform_device *pdev_mach;
24d65282a3584f Ranjani Sridharan 2020-01-17 118 const struct snd_soc_acpi_mach *machine;
24d65282a3584f Ranjani Sridharan 2020-01-17 119
24d65282a3584f Ranjani Sridharan 2020-01-17 120 /*
24d65282a3584f Ranjani Sridharan 2020-01-17 121 * ASoC components. plat_drv fields are set dynamically so
24d65282a3584f Ranjani Sridharan 2020-01-17 122 * can't use const
24d65282a3584f Ranjani Sridharan 2020-01-17 123 */
24d65282a3584f Ranjani Sridharan 2020-01-17 124 struct snd_soc_component_driver plat_drv;
24d65282a3584f Ranjani Sridharan 2020-01-17 125
24d65282a3584f Ranjani Sridharan 2020-01-17 126 /* topology */
24d65282a3584f Ranjani Sridharan 2020-01-17 127 struct list_head pcm_list;
24d65282a3584f Ranjani Sridharan 2020-01-17 128 struct list_head kcontrol_list;
24d65282a3584f Ranjani Sridharan 2020-01-17 129 struct list_head widget_list;
24d65282a3584f Ranjani Sridharan 2020-01-17 130 struct list_head dai_list;
24d65282a3584f Ranjani Sridharan 2020-01-17 131 struct list_head route_list;
24d65282a3584f Ranjani Sridharan 2020-01-17 132 struct snd_soc_component *component;
24d65282a3584f Ranjani Sridharan 2020-01-17 133
24d65282a3584f Ranjani Sridharan 2020-01-17 134 void *private;
24d65282a3584f Ranjani Sridharan 2020-01-17 135 };
24d65282a3584f Ranjani Sridharan 2020-01-17 136
172dfd1a153473 Ranjani Sridharan 2019-11-12 137 /*
172dfd1a153473 Ranjani Sridharan 2019-11-12 138 * Kcontrols.
172dfd1a153473 Ranjani Sridharan 2019-11-12 139 */
172dfd1a153473 Ranjani Sridharan 2019-11-12 140
172dfd1a153473 Ranjani Sridharan 2019-11-12 141 int snd_sof_volume_get(struct snd_kcontrol *kcontrol,
172dfd1a153473 Ranjani Sridharan 2019-11-12 142 struct snd_ctl_elem_value *ucontrol);
172dfd1a153473 Ranjani Sridharan 2019-11-12 143 int snd_sof_volume_put(struct snd_kcontrol *kcontrol,
172dfd1a153473 Ranjani Sridharan 2019-11-12 144 struct snd_ctl_elem_value *ucontrol);
172dfd1a153473 Ranjani Sridharan 2019-11-12 145 int snd_sof_switch_get(struct snd_kcontrol *kcontrol,
172dfd1a153473 Ranjani Sridharan 2019-11-12 146 struct snd_ctl_elem_value *ucontrol);
172dfd1a153473 Ranjani Sridharan 2019-11-12 147 int snd_sof_switch_put(struct snd_kcontrol *kcontrol,
172dfd1a153473 Ranjani Sridharan 2019-11-12 148 struct snd_ctl_elem_value *ucontrol);
172dfd1a153473 Ranjani Sridharan 2019-11-12 149 int snd_sof_enum_get(struct snd_kcontrol *kcontrol,
172dfd1a153473 Ranjani Sridharan 2019-11-12 150 struct snd_ctl_elem_value *ucontrol);
172dfd1a153473 Ranjani Sridharan 2019-11-12 151 int snd_sof_enum_put(struct snd_kcontrol *kcontrol,
172dfd1a153473 Ranjani Sridharan 2019-11-12 152 struct snd_ctl_elem_value *ucontrol);
172dfd1a153473 Ranjani Sridharan 2019-11-12 153 int snd_sof_bytes_get(struct snd_kcontrol *kcontrol,
172dfd1a153473 Ranjani Sridharan 2019-11-12 154 struct snd_ctl_elem_value *ucontrol);
172dfd1a153473 Ranjani Sridharan 2019-11-12 155 int snd_sof_bytes_put(struct snd_kcontrol *kcontrol,
172dfd1a153473 Ranjani Sridharan 2019-11-12 156 struct snd_ctl_elem_value *ucontrol);
172dfd1a153473 Ranjani Sridharan 2019-11-12 157 int snd_sof_bytes_ext_put(struct snd_kcontrol *kcontrol,
172dfd1a153473 Ranjani Sridharan 2019-11-12 158 const unsigned int __user *binary_data,
172dfd1a153473 Ranjani Sridharan 2019-11-12 159 unsigned int size);
172dfd1a153473 Ranjani Sridharan 2019-11-12 160 int snd_sof_bytes_ext_get(struct snd_kcontrol *kcontrol,
172dfd1a153473 Ranjani Sridharan 2019-11-12 161 unsigned int __user *binary_data,
172dfd1a153473 Ranjani Sridharan 2019-11-12 162 unsigned int size);
172dfd1a153473 Ranjani Sridharan 2019-11-12 163
172dfd1a153473 Ranjani Sridharan 2019-11-12 164 /*
172dfd1a153473 Ranjani Sridharan 2019-11-12 165 * Topology.
172dfd1a153473 Ranjani Sridharan 2019-11-12 166 * There is no snd_sof_free_topology since topology components will
172dfd1a153473 Ranjani Sridharan 2019-11-12 167 * be freed by snd_soc_unregister_component,
172dfd1a153473 Ranjani Sridharan 2019-11-12 168 */
172dfd1a153473 Ranjani Sridharan 2019-11-12 169 int snd_sof_load_topology(struct snd_soc_component *scomp, const char *file);
172dfd1a153473 Ranjani Sridharan 2019-11-12 170 int snd_sof_complete_pipeline(struct device *dev,
172dfd1a153473 Ranjani Sridharan 2019-11-12 171 struct snd_sof_widget *swidget);
172dfd1a153473 Ranjani Sridharan 2019-11-12 172
172dfd1a153473 Ranjani Sridharan 2019-11-12 173 int sof_load_pipeline_ipc(struct device *dev,
172dfd1a153473 Ranjani Sridharan 2019-11-12 @174 struct sof_ipc_pipe_new *pipeline,
172dfd1a153473 Ranjani Sridharan 2019-11-12 @175 struct sof_ipc_comp_reply *r);
172dfd1a153473 Ranjani Sridharan 2019-11-12 176
:::::: The code at line 102 was first introduced by commit
:::::: 172dfd1a1534736094e659d355cc1f40fee1d295 ASoC: SOF: partition audio-related parts from SOF core
:::::: TO: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com>
:::::: CC: Pierre Bossart <pierre-louis.bossart(a)linux.intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 3 months
Re: [Intel-gfx] [v3] drm/i915/tgl: Add Wa_1606054188:tgl
by kbuild test robot
Hi Matt,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.5 next-20200131]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Matt-Atwood/drm-i915-tgl-Add-Wa_...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-s2-20200203 (attached as .config)
compiler: gcc-6 (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/display/intel_sprite.c:42:0:
drivers/gpu/drm/i915/display/intel_sprite.c: In function 'skl_plane_check_nv12_rotation':
>> drivers/gpu/drm/i915/display/intel_sprite.c:2181:13: error: 'dev_priv' undeclared (first use in this function)
if (IS_GEN(dev_priv, 12) &&
^
drivers/gpu/drm/i915/i915_drv.h:1372:33: note: in definition of macro 'INTEL_INFO'
#define INTEL_INFO(dev_priv) (&(dev_priv)->__info)
^~~~~~~~
drivers/gpu/drm/i915/display/intel_sprite.c:2181:6: note: in expansion of macro 'IS_GEN'
if (IS_GEN(dev_priv, 12) &&
^~~~~~
drivers/gpu/drm/i915/display/intel_sprite.c:2181:13: note: each undeclared identifier is reported only once for each function it appears in
if (IS_GEN(dev_priv, 12) &&
^
drivers/gpu/drm/i915/i915_drv.h:1372:33: note: in definition of macro 'INTEL_INFO'
#define INTEL_INFO(dev_priv) (&(dev_priv)->__info)
^~~~~~~~
drivers/gpu/drm/i915/display/intel_sprite.c:2181:6: note: in expansion of macro 'IS_GEN'
if (IS_GEN(dev_priv, 12) &&
^~~~~~
vim +/dev_priv +2181 drivers/gpu/drm/i915/display/intel_sprite.c
2160
2161 static int skl_plane_check_nv12_rotation(const struct intel_plane_state *plane_state)
2162 {
2163 const struct drm_framebuffer *fb = plane_state->hw.fb;
2164 unsigned int rotation = plane_state->hw.rotation;
2165 int src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
2166
2167 /* Display WA #1106 */
2168 if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier) &&
2169 src_w & 3 &&
2170 (rotation == DRM_MODE_ROTATE_270 ||
2171 rotation == (DRM_MODE_REFLECT_X | DRM_MODE_ROTATE_90))) {
2172 DRM_DEBUG_KMS("src width must be multiple of 4 for rotated planar YUV\n");
2173 return -EINVAL;
2174 }
2175
2176 /* Wa_1606054188:tgl
2177 *
2178 * TODO: Add format RGB64i when implemented.
2179 *
2180 */
> 2181 if (IS_GEN(dev_priv, 12) &&
2182 plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE &&
2183 intel_format_is_p01x(fb->format->format))
2184 DRM_DEBUG_KMS("Source color keying not supported with P01x formats\n");
2185
2186 return 0;
2187 }
2188
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 3 months
[chrome-os:chromeos-4.19 5/5] drivers/gpu/drm/i915/intel_modes.c:168 intel_attach_privacy_screen_property() error: uninitialized symbol 'prop'.
by Dan Carpenter
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.19
head: 6e9ad418e3e56843809b2de0e833818fd9fe72eb
commit: 6e9ad418e3e56843809b2de0e833818fd9fe72eb [5/5] BACKPORT: FROMLIST: drm/i915: Add support for integrated privacy screens
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/gpu/drm/i915/intel_modes.c:168 intel_attach_privacy_screen_property() error: uninitialized symbol 'prop'.
git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel
git remote update chrome-os
git checkout 6e9ad418e3e56843809b2de0e833818fd9fe72eb
vim +/prop +168 drivers/gpu/drm/i915/intel_modes.c
6e9ad418e3e568 Rajat Jain 2019-12-18 141
6e9ad418e3e568 Rajat Jain 2019-12-18 142 /**
6e9ad418e3e568 Rajat Jain 2019-12-18 143 * intel_attach_privacy_screen_property -
6e9ad418e3e568 Rajat Jain 2019-12-18 144 * create and attach the connecter's privacy-screen property. *
6e9ad418e3e568 Rajat Jain 2019-12-18 145 * @connector: connector for which to init the privacy-screen property
6e9ad418e3e568 Rajat Jain 2019-12-18 146 *
6e9ad418e3e568 Rajat Jain 2019-12-18 147 * This function creates and attaches the "privacy-screen" property to the
6e9ad418e3e568 Rajat Jain 2019-12-18 148 * connector. Initial state of privacy-screen is set to disabled.
6e9ad418e3e568 Rajat Jain 2019-12-18 149 */
6e9ad418e3e568 Rajat Jain 2019-12-18 150 void
6e9ad418e3e568 Rajat Jain 2019-12-18 151 intel_attach_privacy_screen_property(struct drm_connector *connector)
6e9ad418e3e568 Rajat Jain 2019-12-18 152 {
6e9ad418e3e568 Rajat Jain 2019-12-18 153 struct intel_connector *intel_connector = to_intel_connector(connector);
6e9ad418e3e568 Rajat Jain 2019-12-18 154 struct drm_property *prop;
^^^^
6e9ad418e3e568 Rajat Jain 2019-12-18 155
6e9ad418e3e568 Rajat Jain 2019-12-18 156 if (!intel_connector->privacy_screen_property) {
6e9ad418e3e568 Rajat Jain 2019-12-18 157 prop = drm_property_create_enum(connector->dev,
6e9ad418e3e568 Rajat Jain 2019-12-18 158 DRM_MODE_PROP_ENUM,
6e9ad418e3e568 Rajat Jain 2019-12-18 159 "privacy-screen",
6e9ad418e3e568 Rajat Jain 2019-12-18 160 privacy_screen_enum,
6e9ad418e3e568 Rajat Jain 2019-12-18 161 ARRAY_SIZE(privacy_screen_enum));
6e9ad418e3e568 Rajat Jain 2019-12-18 162 if (!prop)
6e9ad418e3e568 Rajat Jain 2019-12-18 163 return;
6e9ad418e3e568 Rajat Jain 2019-12-18 164
6e9ad418e3e568 Rajat Jain 2019-12-18 165 intel_connector->privacy_screen_property = prop;
6e9ad418e3e568 Rajat Jain 2019-12-18 166 }
6e9ad418e3e568 Rajat Jain 2019-12-18 167
6e9ad418e3e568 Rajat Jain 2019-12-18 @168 drm_object_attach_property(&connector->base, prop,
^^^^
Move this into the if condition?
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 3 months
[hwmon:hwmon-playground 6/16] drivers/hwmon/pmbus/pmbus_core.c:174 pmbus_set_page() warn: this array is probably non-NULL. 'data->info->phases'
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-playground
head: b6b911a2f7d675c768f19e75ba2e8ed216fce65a
commit: 17e064db5aa2cfbfd254c0951544f88b2b1258ee [6/16] hwmon: (pmbus) Implement multi-phase support
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/hwmon/pmbus/pmbus_core.c:174 pmbus_set_page() warn: this array is non-NULL. 'data->info->phases'
# https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/...
git remote add hwmon https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
git remote update hwmon
git checkout 17e064db5aa2cfbfd254c0951544f88b2b1258ee
vim +174 drivers/hwmon/pmbus/pmbus_core.c
ce603b18f30aea drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2013-01-26 150
6db8d5dba444f2 drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-14 151 int pmbus_set_page(struct i2c_client *client, int page, int phase)
442aba78728e77 drivers/hwmon/pmbus_core.c Guenter Roeck 2011-01-26 152 {
442aba78728e77 drivers/hwmon/pmbus_core.c Guenter Roeck 2011-01-26 153 struct pmbus_data *data = i2c_get_clientdata(client);
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 154 int rv;
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 155
17e064db5aa2cf drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-13 156 if (page < 0)
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 157 return 0;
442aba78728e77 drivers/hwmon/pmbus_core.c Guenter Roeck 2011-01-26 158
17e064db5aa2cf drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-13 159 if (!(data->info->func[page] & PMBUS_PAGE_VIRTUAL) &&
17e064db5aa2cf drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-13 160 data->info->pages > 1 && page != data->currpage) {
442aba78728e77 drivers/hwmon/pmbus_core.c Guenter Roeck 2011-01-26 161 rv = i2c_smbus_write_byte_data(client, PMBUS_PAGE, page);
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 162 if (rv < 0)
442aba78728e77 drivers/hwmon/pmbus_core.c Guenter Roeck 2011-01-26 163 return rv;
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 164
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 165 rv = i2c_smbus_read_byte_data(client, PMBUS_PAGE);
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 166 if (rv < 0)
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 167 return rv;
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 168
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 169 if (rv != page)
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 170 return -EIO;
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 171 }
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 172 data->currpage = page;
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 173
17e064db5aa2cf drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-13 @174 if (data->info->phases && data->currphase != phase &&
^^^^^^^^^^^^^^^^^^
Delete this condition?
17e064db5aa2cf drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-13 175 !(data->info->func[page] & PMBUS_PHASE_VIRTUAL)) {
17e064db5aa2cf drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-13 176 rv = i2c_smbus_write_byte_data(client, PMBUS_PHASE,
17e064db5aa2cf drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-13 177 phase);
17e064db5aa2cf drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-13 178 if (rv)
17e064db5aa2cf drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-13 179 return rv;
17e064db5aa2cf drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-13 180 }
17e064db5aa2cf drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-13 181 data->currphase = phase;
17e064db5aa2cf drivers/hwmon/pmbus/pmbus_core.c Guenter Roeck 2020-01-13 182
464df6fa376678 drivers/hwmon/pmbus/pmbus_core.c Andrew Jeffery 2017-11-20 183 return 0;
442aba78728e77 drivers/hwmon/pmbus_core.c Guenter Roeck 2011-01-26 184 }
442aba78728e77 drivers/hwmon/pmbus_core.c Guenter Roeck 2011-01-26 185 EXPORT_SYMBOL_GPL(pmbus_set_page);
442aba78728e77 drivers/hwmon/pmbus_core.c Guenter Roeck 2011-01-26 186
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 3 months
Re: [PATCH v1 4/7] device property: fwnode_get_phy_mode: Change API to solve int/unit warnings
by kbuild test robot
Hi Calvin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v5.5]
[cannot apply to driver-core/driver-core-testing net-next/master net/master linus/master sparc-next/master next-20200203]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Calvin-Johnson/ACPI-support-for-...
base: d5226fa6dbae0569ee43ecfc08bdcd6770fc4755
config: sparc64-randconfig-a001-20200203 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
include/linux/phy.h: In function 'phy_ethtool_get_stats':
include/linux/phy.h:1260:22: error: 'struct phy_device' has no member named 'lock'; did you mean 'link'?
mutex_lock(&phydev->lock);
^
include/linux/mutex.h:153:44: note: in definition of macro 'mutex_lock'
#define mutex_lock(lock) mutex_lock_nested(lock, 0)
^~~~
In file included from include/linux/property.h:16:0,
from include/linux/of.h:22,
from arch/sparc/include/asm/openprom.h:15,
from arch/sparc/include/asm/device.h:8,
from include/linux/device.h:29,
from include/linux/dma-mapping.h:7,
from include/linux/skbuff.h:31,
from include/linux/if_ether.h:19,
from include/uapi/linux/ethtool.h:19,
from include/linux/ethtool.h:18,
from net/core/ethtool.c:14:
include/linux/phy.h:1261:33: error: passing argument 2 of 'phydev->drv->get_stats' from incompatible pointer type [-Werror=incompatible-pointer-types]
phydev->drv->get_stats(phydev, stats, data);
^~~~~
include/linux/phy.h:1261:33: note: expected 'struct ethtool_stats *' but argument is of type 'struct ethtool_stats *'
include/linux/phy.h:1262:24: error: 'struct phy_device' has no member named 'lock'; did you mean 'link'?
mutex_unlock(&phydev->lock);
^~~~
link
In file included from include/linux/dma-mapping.h:7:0,
from include/linux/skbuff.h:31,
from include/linux/if_ether.h:19,
from include/uapi/linux/ethtool.h:19,
from include/linux/ethtool.h:18,
from net/core/ethtool.c:14:
include/linux/device.h: At top level:
include/linux/device.h:1370:27: error: conflicting types for 'dev_name'
static inline const char *dev_name(const struct device *dev)
^~~~~~~~
In file included from include/linux/property.h:16:0,
from include/linux/of.h:22,
from arch/sparc/include/asm/openprom.h:15,
from arch/sparc/include/asm/device.h:8,
from include/linux/device.h:29,
from include/linux/dma-mapping.h:7,
from include/linux/skbuff.h:31,
from include/linux/if_ether.h:19,
from include/uapi/linux/ethtool.h:19,
from include/linux/ethtool.h:18,
from net/core/ethtool.c:14:
include/linux/phy.h:1076:9: note: previous implicit declaration of 'dev_name' was here
return dev_name(&phydev->mdio.dev);
^~~~~~~~
In file included from include/linux/dma-mapping.h:7:0,
from include/linux/skbuff.h:31,
from include/linux/if_ether.h:19,
from include/uapi/linux/ethtool.h:19,
from include/linux/ethtool.h:18,
from net/core/ethtool.c:14:
include/linux/device.h:1417:21: error: conflicting types for 'dev_get_drvdata'
static inline void *dev_get_drvdata(const struct device *dev)
^~~~~~~~~~~~~~~
In file included from include/linux/phy.h:18:0,
from include/linux/property.h:16,
from include/linux/of.h:22,
from arch/sparc/include/asm/openprom.h:15,
from arch/sparc/include/asm/device.h:8,
from include/linux/device.h:29,
from include/linux/dma-mapping.h:7,
from include/linux/skbuff.h:31,
from include/linux/if_ether.h:19,
from include/uapi/linux/ethtool.h:19,
from include/linux/ethtool.h:18,
from net/core/ethtool.c:14:
include/linux/mdio.h:79:9: note: previous implicit declaration of 'dev_get_drvdata' was here
return dev_get_drvdata(&mdio->dev);
^~~~~~~~~~~~~~~
In file included from include/linux/dma-mapping.h:7:0,
from include/linux/skbuff.h:31,
from include/linux/if_ether.h:19,
from include/uapi/linux/ethtool.h:19,
from include/linux/ethtool.h:18,
from net/core/ethtool.c:14:
include/linux/device.h:1422:20: warning: conflicting types for 'dev_set_drvdata'
static inline void dev_set_drvdata(struct device *dev, void *data)
^~~~~~~~~~~~~~~
include/linux/device.h:1422:20: error: static declaration of 'dev_set_drvdata' follows non-static declaration
In file included from include/linux/phy.h:18:0,
from include/linux/property.h:16,
from include/linux/of.h:22,
from arch/sparc/include/asm/openprom.h:15,
from arch/sparc/include/asm/device.h:8,
from include/linux/device.h:29,
from include/linux/dma-mapping.h:7,
from include/linux/skbuff.h:31,
from include/linux/if_ether.h:19,
from include/uapi/linux/ethtool.h:19,
from include/linux/ethtool.h:18,
from net/core/ethtool.c:14:
include/linux/mdio.h:74:2: note: previous implicit declaration of 'dev_set_drvdata' was here
dev_set_drvdata(&mdio->dev, data);
^~~~~~~~~~~~~~~
net/core/ethtool.c: In function 'ethtool_get_phy_stats':
>> net/core/ethtool.c:1963:45: error: passing argument 2 of 'phy_ethtool_get_stats' from incompatible pointer type [-Werror=incompatible-pointer-types]
ret = phy_ethtool_get_stats(dev->phydev, &stats, data);
^
In file included from include/linux/property.h:16:0,
from include/linux/of.h:22,
from arch/sparc/include/asm/openprom.h:15,
from arch/sparc/include/asm/device.h:8,
from include/linux/device.h:29,
from include/linux/dma-mapping.h:7,
from include/linux/skbuff.h:31,
from include/linux/if_ether.h:19,
from include/uapi/linux/ethtool.h:19,
from include/linux/ethtool.h:18,
from net/core/ethtool.c:14:
include/linux/phy.h:1254:19: note: expected 'struct ethtool_stats *' but argument is of type 'struct ethtool_stats *'
static inline int phy_ethtool_get_stats(struct phy_device *phydev,
^~~~~~~~~~~~~~~~~~~~~
net/core/ethtool.c: In function 'ethtool_get_ts_info':
>> net/core/ethtool.c:2174:38: error: passing argument 2 of 'phydev->drv->ts_info' from incompatible pointer type [-Werror=incompatible-pointer-types]
err = phydev->drv->ts_info(phydev, &info);
^
net/core/ethtool.c:2174:38: note: expected 'struct ethtool_ts_info *' but argument is of type 'struct ethtool_ts_info *'
net/core/ethtool.c: In function '__ethtool_get_module_info':
>> net/core/ethtool.c:2203:43: error: passing argument 2 of 'phydev->drv->module_info' from incompatible pointer type [-Werror=incompatible-pointer-types]
return phydev->drv->module_info(phydev, modinfo);
^~~~~~~
net/core/ethtool.c:2203:43: note: expected 'struct ethtool_modinfo *' but argument is of type 'struct ethtool_modinfo *'
net/core/ethtool.c: In function '__ethtool_get_module_eeprom':
>> net/core/ethtool.c:2240:45: error: passing argument 2 of 'phydev->drv->module_eeprom' from incompatible pointer type [-Werror=incompatible-pointer-types]
return phydev->drv->module_eeprom(phydev, ee, data);
^~
net/core/ethtool.c:2240:45: note: expected 'struct ethtool_eeprom *' but argument is of type 'struct ethtool_eeprom *'
In file included from include/linux/notifier.h:14:0,
from include/linux/memory_hotplug.h:7,
from include/linux/mmzone.h:823,
from include/linux/gfp.h:6,
from include/linux/umh.h:4,
from include/linux/kmod.h:9,
from include/linux/module.h:16,
from net/core/ethtool.c:10:
net/core/ethtool.c: In function 'get_phy_tunable':
>> net/core/ethtool.c:2487:22: error: 'struct phy_device' has no member named 'lock'; did you mean 'link'?
mutex_lock(&phydev->lock);
^
include/linux/mutex.h:153:44: note: in definition of macro 'mutex_lock'
#define mutex_lock(lock) mutex_lock_nested(lock, 0)
^~~~
>> net/core/ethtool.c:2488:41: error: passing argument 2 of 'phydev->drv->get_tunable' from incompatible pointer type [-Werror=incompatible-pointer-types]
ret = phydev->drv->get_tunable(phydev, &tuna, data);
^
net/core/ethtool.c:2488:41: note: expected 'struct ethtool_tunable *' but argument is of type 'struct ethtool_tunable *'
net/core/ethtool.c:2489:24: error: 'struct phy_device' has no member named 'lock'; did you mean 'link'?
mutex_unlock(&phydev->lock);
^~~~
link
In file included from include/linux/notifier.h:14:0,
from include/linux/memory_hotplug.h:7,
from include/linux/mmzone.h:823,
from include/linux/gfp.h:6,
from include/linux/umh.h:4,
from include/linux/kmod.h:9,
from include/linux/module.h:16,
from net/core/ethtool.c:10:
net/core/ethtool.c: In function 'set_phy_tunable':
net/core/ethtool.c:2521:22: error: 'struct phy_device' has no member named 'lock'; did you mean 'link'?
mutex_lock(&phydev->lock);
^
include/linux/mutex.h:153:44: note: in definition of macro 'mutex_lock'
#define mutex_lock(lock) mutex_lock_nested(lock, 0)
^~~~
>> net/core/ethtool.c:2522:41: error: passing argument 2 of 'phydev->drv->set_tunable' from incompatible pointer type [-Werror=incompatible-pointer-types]
ret = phydev->drv->set_tunable(phydev, &tuna, data);
^
net/core/ethtool.c:2522:41: note: expected 'struct ethtool_tunable *' but argument is of type 'struct ethtool_tunable *'
net/core/ethtool.c:2523:24: error: 'struct phy_device' has no member named 'lock'; did you mean 'link'?
mutex_unlock(&phydev->lock);
^~~~
link
cc1: some warnings being treated as errors
vim +/phy_ethtool_get_stats +1963 net/core/ethtool.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1930
f3a4094558ddf8 Andrew Lunn 2015-12-30 1931 static int ethtool_get_phy_stats(struct net_device *dev, void __user *useraddr)
f3a4094558ddf8 Andrew Lunn 2015-12-30 1932 {
9994338227179e Florian Fainelli 2018-04-25 1933 const struct ethtool_ops *ops = dev->ethtool_ops;
f3a4094558ddf8 Andrew Lunn 2015-12-30 1934 struct phy_device *phydev = dev->phydev;
9994338227179e Florian Fainelli 2018-04-25 1935 struct ethtool_stats stats;
f3a4094558ddf8 Andrew Lunn 2015-12-30 1936 u64 *data;
f3a4094558ddf8 Andrew Lunn 2015-12-30 1937 int ret, n_stats;
f3a4094558ddf8 Andrew Lunn 2015-12-30 1938
9994338227179e Florian Fainelli 2018-04-25 1939 if (!phydev && (!ops->get_ethtool_phy_stats || !ops->get_sset_count))
f3a4094558ddf8 Andrew Lunn 2015-12-30 1940 return -EOPNOTSUPP;
f3a4094558ddf8 Andrew Lunn 2015-12-30 1941
9994338227179e Florian Fainelli 2018-04-25 1942 if (dev->phydev && !ops->get_ethtool_phy_stats)
c59530d0d5dccc Florian Fainelli 2018-04-25 1943 n_stats = phy_ethtool_get_sset_count(dev->phydev);
9994338227179e Florian Fainelli 2018-04-25 1944 else
9994338227179e Florian Fainelli 2018-04-25 1945 n_stats = ops->get_sset_count(dev, ETH_SS_PHY_STATS);
f3a4094558ddf8 Andrew Lunn 2015-12-30 1946 if (n_stats < 0)
f3a4094558ddf8 Andrew Lunn 2015-12-30 1947 return n_stats;
4d1ceea8516cd6 Alexei Starovoitov 2017-01-30 1948 if (n_stats > S32_MAX / sizeof(u64))
4d1ceea8516cd6 Alexei Starovoitov 2017-01-30 1949 return -ENOMEM;
4d1ceea8516cd6 Alexei Starovoitov 2017-01-30 1950 WARN_ON_ONCE(!n_stats);
f3a4094558ddf8 Andrew Lunn 2015-12-30 1951
f3a4094558ddf8 Andrew Lunn 2015-12-30 1952 if (copy_from_user(&stats, useraddr, sizeof(stats)))
f3a4094558ddf8 Andrew Lunn 2015-12-30 1953 return -EFAULT;
f3a4094558ddf8 Andrew Lunn 2015-12-30 1954
f3a4094558ddf8 Andrew Lunn 2015-12-30 1955 stats.n_stats = n_stats;
3d8830266ffc28 Li RongQing 2019-03-29 1956
3d8830266ffc28 Li RongQing 2019-03-29 1957 if (n_stats) {
fad953ce0b22cf Kees Cook 2018-06-12 1958 data = vzalloc(array_size(n_stats, sizeof(u64)));
3d8830266ffc28 Li RongQing 2019-03-29 1959 if (!data)
f3a4094558ddf8 Andrew Lunn 2015-12-30 1960 return -ENOMEM;
f3a4094558ddf8 Andrew Lunn 2015-12-30 1961
9994338227179e Florian Fainelli 2018-04-25 1962 if (dev->phydev && !ops->get_ethtool_phy_stats) {
c59530d0d5dccc Florian Fainelli 2018-04-25 @1963 ret = phy_ethtool_get_stats(dev->phydev, &stats, data);
c59530d0d5dccc Florian Fainelli 2018-04-25 1964 if (ret < 0)
3d8830266ffc28 Li RongQing 2019-03-29 1965 goto out;
9994338227179e Florian Fainelli 2018-04-25 1966 } else {
9994338227179e Florian Fainelli 2018-04-25 1967 ops->get_ethtool_phy_stats(dev, &stats, data);
9994338227179e Florian Fainelli 2018-04-25 1968 }
3d8830266ffc28 Li RongQing 2019-03-29 1969 } else {
3d8830266ffc28 Li RongQing 2019-03-29 1970 data = NULL;
3d8830266ffc28 Li RongQing 2019-03-29 1971 }
f3a4094558ddf8 Andrew Lunn 2015-12-30 1972
f3a4094558ddf8 Andrew Lunn 2015-12-30 1973 ret = -EFAULT;
f3a4094558ddf8 Andrew Lunn 2015-12-30 1974 if (copy_to_user(useraddr, &stats, sizeof(stats)))
f3a4094558ddf8 Andrew Lunn 2015-12-30 1975 goto out;
f3a4094558ddf8 Andrew Lunn 2015-12-30 1976 useraddr += sizeof(stats);
4d1ceea8516cd6 Alexei Starovoitov 2017-01-30 1977 if (n_stats && copy_to_user(useraddr, data, n_stats * sizeof(u64)))
f3a4094558ddf8 Andrew Lunn 2015-12-30 1978 goto out;
f3a4094558ddf8 Andrew Lunn 2015-12-30 1979 ret = 0;
f3a4094558ddf8 Andrew Lunn 2015-12-30 1980
f3a4094558ddf8 Andrew Lunn 2015-12-30 1981 out:
4d1ceea8516cd6 Alexei Starovoitov 2017-01-30 1982 vfree(data);
f3a4094558ddf8 Andrew Lunn 2015-12-30 1983 return ret;
f3a4094558ddf8 Andrew Lunn 2015-12-30 1984 }
f3a4094558ddf8 Andrew Lunn 2015-12-30 1985
:::::: The code at line 1963 was first introduced by commit
:::::: c59530d0d5dccc96795af12c139f618182cf98db net: Move PHY statistics code into PHY library helpers
:::::: TO: Florian Fainelli <f.fainelli(a)gmail.com>
:::::: CC: David S. Miller <davem(a)davemloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 3 months
[zen-kernel-zen-kernel:5.5/muqss 1/23] kernel//sched/MuQSS.c:138:36: error: 'CONFIG_SHARERQ' undeclared here (not in a function); did you mean 'CONFIG_SHMEM'?
by kbuild test robot
tree: https://github.com/zen-kernel/zen-kernel 5.5/muqss
head: a900fd1c6593b6025618e767fb7f19551fb3cb8f
commit: c58e2d61f83d40ac72e858d41b3b277b345b9387 [1/23] MultiQueue Skiplist Scheduler v0.196.
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout c58e2d61f83d40ac72e858d41b3b277b345b9387
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> kernel//sched/MuQSS.c:138:36: error: 'CONFIG_SHARERQ' undeclared here (not in a function); did you mean 'CONFIG_SHMEM'?
static int rqshare __read_mostly = CONFIG_SHARERQ; /* Default RQSHARE_MC */
^~~~~~~~~~~~~~
CONFIG_SHMEM
kernel//sched/MuQSS.c: In function 'unlock_rq':
kernel//sched/MuQSS.c:463:46: error: macro "spin_release" passed 3 arguments, but takes just 2
spin_release(&rq->lock->dep_map, 1, _RET_IP_);
^
kernel//sched/MuQSS.c:463:2: error: 'spin_release' undeclared (first use in this function); did you mean 'seq_release'?
spin_release(&rq->lock->dep_map, 1, _RET_IP_);
^~~~~~~~~~~~
seq_release
kernel//sched/MuQSS.c:463:2: note: each undeclared identifier is reported only once for each function it appears in
kernel//sched/MuQSS.c: In function 'prepare_lock_switch':
kernel//sched/MuQSS.c:2583:47: error: macro "spin_release" passed 3 arguments, but takes just 2
spin_release(&rq->lock->dep_map, 1, _THIS_IP_);
^
kernel//sched/MuQSS.c:2583:2: error: 'spin_release' undeclared (first use in this function); did you mean 'seq_release'?
spin_release(&rq->lock->dep_map, 1, _THIS_IP_);
^~~~~~~~~~~~
seq_release
--
kernel//time/hrtimer.c: In function 'hrtimer_switch_to_hres':
>> kernel//time/hrtimer.c:731:6: error: implicit declaration of function 'tick_init_highres'; did you mean 'tick_init'? [-Werror=implicit-function-declaration]
if (tick_init_highres()) {
^~~~~~~~~~~~~~~~~
tick_init
kernel//time/hrtimer.c: In function 'hrtimer_interrupt':
>> kernel//time/hrtimer.c:1620:5: error: dereferencing pointer to incomplete type 'struct clock_event_device'
dev->next_event = KTIME_MAX;
^~
cc1: some warnings being treated as errors
vim +138 kernel//sched/MuQSS.c
133
134 /*
135 * This determines what level of runqueue sharing will be done and is
136 * configurable at boot time with the bootparam rqshare =
137 */
> 138 static int rqshare __read_mostly = CONFIG_SHARERQ; /* Default RQSHARE_MC */
139
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 3 months
[zen-kernel-zen-kernel:5.4/muqss 1/21] kernel/sched/MuQSS.c:138:36: error: 'CONFIG_SHARERQ' undeclared here (not in a function); did you mean 'CONFIG_SPARSE_IRQ'?
by kbuild test robot
Hi Con,
FYI, the error/warning still remains.
tree: https://github.com/zen-kernel/zen-kernel 5.4/muqss
head: 45589d24eea4cdfe59e87a65389fd72d91f43bf0
commit: 7acac2e4000e75f3349106a8847cf1021651446b [1/21] MultiQueue Skiplist Scheduler v0.196.
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 7acac2e4000e75f3349106a8847cf1021651446b
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> kernel/sched/MuQSS.c:138:36: error: 'CONFIG_SHARERQ' undeclared here (not in a function); did you mean 'CONFIG_SPARSE_IRQ'?
static int rqshare __read_mostly = CONFIG_SHARERQ; /* Default RQSHARE_MC */
^~~~~~~~~~~~~~
CONFIG_SPARSE_IRQ
--
In file included from include/asm-generic/percpu.h:7:0,
from ./arch/c6x/include/generated/asm/percpu.h:1,
from include/linux/percpu.h:13,
from include/linux/hrtimer.h:19,
from include/linux/sched.h:20,
from include/linux/sched/signal.h:7,
from include/linux/sched/cputime.h:5,
from kernel/sched/MuQSS.h:7,
from kernel/sched/sched.h:6,
from kernel/sched/membarrier.c:7:
kernel/sched/membarrier.c: In function 'ipi_sync_rq_state':
>> kernel/sched/membarrier.c:39:17: error: 'runqueues' undeclared (first use in this function); did you mean 'sigqueue'?
this_cpu_write(runqueues.membarrier_state,
^
include/linux/percpu-defs.h:220:47: note: in definition of macro '__verify_pcpu_ptr'
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
^~~
include/linux/percpu-defs.h:509:34: note: in expansion of macro '__pcpu_size_call'
#define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
^~~~~~~~~~~~~~~~
kernel/sched/membarrier.c:39:2: note: in expansion of macro 'this_cpu_write'
this_cpu_write(runqueues.membarrier_state,
^~~~~~~~~~~~~~
kernel/sched/membarrier.c:39:17: note: each undeclared identifier is reported only once for each function it appears in
this_cpu_write(runqueues.membarrier_state,
^
include/linux/percpu-defs.h:220:47: note: in definition of macro '__verify_pcpu_ptr'
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
^~~
include/linux/percpu-defs.h:509:34: note: in expansion of macro '__pcpu_size_call'
#define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
^~~~~~~~~~~~~~~~
kernel/sched/membarrier.c:39:2: note: in expansion of macro 'this_cpu_write'
this_cpu_write(runqueues.membarrier_state,
^~~~~~~~~~~~~~
kernel/sched/membarrier.c: In function 'membarrier_exec_mmap':
kernel/sched/membarrier.c:63:17: error: 'runqueues' undeclared (first use in this function); did you mean 'sigqueue'?
this_cpu_write(runqueues.membarrier_state, 0);
^
include/linux/percpu-defs.h:220:47: note: in definition of macro '__verify_pcpu_ptr'
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
^~~
include/linux/percpu-defs.h:509:34: note: in expansion of macro '__pcpu_size_call'
#define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
^~~~~~~~~~~~~~~~
kernel/sched/membarrier.c:63:2: note: in expansion of macro 'this_cpu_write'
this_cpu_write(runqueues.membarrier_state, 0);
^~~~~~~~~~~~~~
kernel/sched/membarrier.c: In function 'sync_runqueues_membarrier_state':
kernel/sched/membarrier.c:207:18: error: 'runqueues' undeclared (first use in this function); did you mean 'sigqueue'?
this_cpu_write(runqueues.membarrier_state, membarrier_state);
^
include/linux/percpu-defs.h:220:47: note: in definition of macro '__verify_pcpu_ptr'
const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
^~~
include/linux/percpu-defs.h:509:34: note: in expansion of macro '__pcpu_size_call'
#define this_cpu_write(pcp, val) __pcpu_size_call(this_cpu_write_, pcp, val)
^~~~~~~~~~~~~~~~
kernel/sched/membarrier.c:207:3: note: in expansion of macro 'this_cpu_write'
this_cpu_write(runqueues.membarrier_state, membarrier_state);
^~~~~~~~~~~~~~
vim +138 kernel/sched/MuQSS.c
133
134 /*
135 * This determines what level of runqueue sharing will be done and is
136 * configurable at boot time with the bootparam rqshare =
137 */
> 138 static int rqshare __read_mostly = CONFIG_SHARERQ; /* Default RQSHARE_MC */
139
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 3 months
Re: [RFC v2] Bluetooth: Add debugfs option to enable runtime debug statements
by kbuild test robot
Hi Marcel,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on next-20200203]
[cannot apply to bluetooth/master v5.5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Marcel-Holtmann/Bluetooth-Add-de...
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: microblaze-randconfig-a001-20200203 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/kernel.h:11:0,
from include/linux/list.h:9,
from include/linux/wait.h:7,
from include/linux/wait_bit.h:8,
from include/linux/fs.h:6,
from include/linux/debugfs.h:15,
from net/bluetooth/lib.c:30:
net/bluetooth/lib.c: In function 'bt_dbg':
net/bluetooth/lib.c:243:14: error: 'debug_enable' undeclared (first use in this function); did you mean 'napi_enable'?
if (likely(!debug_enable))
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
>> net/bluetooth/lib.c:243:2: note: in expansion of macro 'if'
if (likely(!debug_enable))
^~
include/linux/compiler.h:45:22: note: in expansion of macro '__branch_check__'
# define likely(x) (__branch_check__(x, 1, __builtin_constant_p(x)))
^~~~~~~~~~~~~~~~
>> net/bluetooth/lib.c:243:6: note: in expansion of macro 'likely'
if (likely(!debug_enable))
^~~~~~
net/bluetooth/lib.c:243:14: note: each undeclared identifier is reported only once for each function it appears in
if (likely(!debug_enable))
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
>> net/bluetooth/lib.c:243:2: note: in expansion of macro 'if'
if (likely(!debug_enable))
^~
include/linux/compiler.h:45:22: note: in expansion of macro '__branch_check__'
# define likely(x) (__branch_check__(x, 1, __builtin_constant_p(x)))
^~~~~~~~~~~~~~~~
>> net/bluetooth/lib.c:243:6: note: in expansion of macro 'likely'
if (likely(!debug_enable))
^~~~~~
vim +/if +243 net/bluetooth/lib.c
237
238 void bt_dbg(const char *format, ...)
239 {
240 struct va_format vaf;
241 va_list args;
242
> 243 if (likely(!debug_enable))
244 return;
245
246 va_start(args, format);
247
248 vaf.fmt = format;
249 vaf.va = &args;
250
251 printk(KERN_DEBUG pr_fmt("%pV"), &vaf);
252
253 va_end(args);
254 }
255 EXPORT_SYMBOL(bt_dbg);
256
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 3 months