drivers/gpu/drm/i915/display/intel_color.c:1840 ilk_read_lut_8() error: potential null dereference 'blob'. (drm_property_create_blob returns null)
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: caffb99b6929f41a69edbb5aef3a359bf45f3315
commit: 100882673ab83b55ea0e9ed3ad301125d36039a3 drm/i915: Split i9xx_read_lut_8() to gmch vs. ilk variants
date: 3 months ago
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
git checkout 100882673ab83b55ea0e9ed3ad301125d36039a3
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
New smatch warnings:
drivers/gpu/drm/i915/display/intel_color.c:1840 ilk_read_lut_8() error: potential null dereference 'blob'. (drm_property_create_blob returns null)
Old smatch warnings:
drivers/gpu/drm/i915/display/intel_color.c:1706 i9xx_read_lut_8() error: potential null dereference 'blob'. (drm_property_create_blob returns null)
drivers/gpu/drm/i915/display/intel_color.c:1747 i965_read_lut_10p6() error: potential null dereference 'blob'. (drm_property_create_blob returns null)
drivers/gpu/drm/i915/display/intel_color.c:1799 chv_read_cgm_lut() error: potential null dereference 'blob'. (drm_property_create_blob returns null)
drivers/gpu/drm/i915/display/intel_color.c:1873 ilk_read_lut_10() error: potential null dereference 'blob'. (drm_property_create_blob returns null)
drivers/gpu/drm/i915/display/intel_color.c:1920 glk_read_lut_10() error: potential null dereference 'blob'. (drm_property_create_blob returns null)
vim +/blob +1840 drivers/gpu/drm/i915/display/intel_color.c
1823
1824 static struct drm_property_blob *
1825 ilk_read_lut_8(const struct intel_crtc_state *crtc_state)
1826 {
1827 struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
1828 struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
1829 enum pipe pipe = crtc->pipe;
1830 struct drm_property_blob *blob;
1831 struct drm_color_lut *blob_data;
1832 u32 i, val;
1833
1834 blob = drm_property_create_blob(&dev_priv->drm,
1835 sizeof(struct drm_color_lut) * LEGACY_LUT_LENGTH,
1836 NULL);
1837 if (IS_ERR(blob))
1838 return NULL;
1839
> 1840 blob_data = blob->data;
1841
1842 for (i = 0; i < LEGACY_LUT_LENGTH; i++) {
1843 val = intel_de_read(dev_priv, LGC_PALETTE(pipe, i));
1844
1845 blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(
1846 LGC_PALETTE_RED_MASK, val), 8);
1847 blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(
1848 LGC_PALETTE_GREEN_MASK, val), 8);
1849 blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(
1850 LGC_PALETTE_BLUE_MASK, val), 8);
1851 }
1852
1853 return blob;
1854 }
1855
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
kernel/livepatch/../sched/sched.h:1619:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0cfc8a8d70dcd51db783e8e87917e02149c71458
commit: 4104a562e0ca62e971089db9d3c47794a0d7d4eb sched/core: Annotate curr pointer in rq with __rcu
date: 3 months ago
config: x86_64-randconfig-s002-20200524 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-193-gb8fad4bc-dirty
git checkout 4104a562e0ca62e971089db9d3c47794a0d7d4eb
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> kernel/livepatch/../sched/sched.h:1619:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
>> kernel/livepatch/../sched/sched.h:1619:25: sparse: struct task_struct [noderef] <asn:4> *
>> kernel/livepatch/../sched/sched.h:1619:25: sparse: struct task_struct *
vim +1619 kernel/livepatch/../sched/sched.h
029632fbb7b7c9 kernel/sched.h Peter Zijlstra 2011-10-25 1616
029632fbb7b7c9 kernel/sched.h Peter Zijlstra 2011-10-25 1617 static inline int task_current(struct rq *rq, struct task_struct *p)
029632fbb7b7c9 kernel/sched.h Peter Zijlstra 2011-10-25 1618 {
029632fbb7b7c9 kernel/sched.h Peter Zijlstra 2011-10-25 @1619 return rq->curr == p;
029632fbb7b7c9 kernel/sched.h Peter Zijlstra 2011-10-25 1620 }
029632fbb7b7c9 kernel/sched.h Peter Zijlstra 2011-10-25 1621
:::::: The code at line 1619 was first introduced by commit
:::::: 029632fbb7b7c9d85063cc9eb470de6c54873df3 sched: Make separate sched*.c translation units
:::::: TO: Peter Zijlstra <a.p.zijlstra(a)chello.nl>
:::::: CC: Ingo Molnar <mingo(a)elte.hu>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[rdma:wip/jgg-for-next 151/171] drivers/infiniband/hw/hfi1/ipoib_rx.o: warning: objtool: __llvm_gcov_writeout()+0x0: call without frame pointer save/setup
by kbuild test robot
CC: Doug Ledford <dledford(a)redhat.com>
CC: Jason Gunthorpe <jgg+lists(a)ziepe.ca>
CC: linux-rdma(a)vger.kernel.org
TO: Kaike Wan <kaike.wan(a)intel.com>
CC: Jason Gunthorpe <jgg(a)ziepe.ca>
CC: Mike Marciniszyn <mike.marciniszyn(a)intel.com>
CC: Dennis Dalessandro <dennis.dalessandro(a)intel.com>
CC: Sadanand Warrier <sadanand.warrier(a)intel.com>
CC: Grzegorz Andrejczuk <grzegorz.andrejczuk(a)intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git wip/jgg-for-next
head: a94dae867c5663f36c950b82832e146a6c2f0e42
commit: 6991abcb993cf6c0711237b9d393d4f0a2008f1f [151/171] IB/hfi1: Add functions to receive accelerated ipoib packets
config: x86_64-randconfig-a015-20200521 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 6991abcb993cf6c0711237b9d393d4f0a2008f1f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/infiniband/hw/hfi1/ipoib_rx.o: warning: objtool: __llvm_gcov_writeout()+0x0: call without frame pointer save/setup
>> drivers/infiniband/hw/hfi1/ipoib_rx.o: warning: objtool: __llvm_gcov_reset()+0x0: call without frame pointer save/setup
>> drivers/infiniband/hw/hfi1/ipoib_rx.o: warning: objtool: __llvm_gcov_flush()+0x0: call without frame pointer save/setup
>> drivers/infiniband/hw/hfi1/ipoib_rx.o: warning: objtool: __llvm_gcov_init()+0x0: call without frame pointer save/setup
--
>> drivers/infiniband/hw/hfi1/netdev_rx.o: warning: objtool: __llvm_gcov_writeout()+0x0: call without frame pointer save/setup
>> drivers/infiniband/hw/hfi1/netdev_rx.o: warning: objtool: __llvm_gcov_reset()+0x0: call without frame pointer save/setup
>> drivers/infiniband/hw/hfi1/netdev_rx.o: warning: objtool: __llvm_gcov_flush()+0x0: call without frame pointer save/setup
>> drivers/infiniband/hw/hfi1/netdev_rx.o: warning: objtool: __llvm_gcov_init()+0x0: call without frame pointer save/setup
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [PATCH v4] i2c: Add i2c-pseudo driver for userspace I2C adapters.
by kbuild test robot
Hi Matthew,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on wsa/i2c/for-next]
[also build test WARNING on v5.7-rc6 next-20200522]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Matthew-Blecker/i2c-Add-i2c-pseu...
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: x86_64-randconfig-r012-20200524 (attached as .config)
compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/i2c/i2c-pseudo.c: In function 'vanprintf':
>> drivers/i2c/i2c-pseudo.c:767:2: warning: function might be possible candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
ret = vsnprintf(NULL, 0, fmt, ap);
^
drivers/i2c/i2c-pseudo.c:782:2: warning: function might be possible candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
ret = vsnprintf(buf, buf_size, fmt, args1);
^
drivers/i2c/i2c-pseudo.c: In function 'i2cp_cmd_set_timeout_cmd_completer':
drivers/i2c/i2c-pseudo.c:1838:27: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if (cmd_data->timeout_ms < I2CP_TIMEOUT_MS_MIN ||
^
drivers/i2c/i2c-pseudo.c: In function 'i2cp_init':
drivers/i2c/i2c-pseudo.c:3130:17: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if (i2cp_limit < I2CP_ADAPTERS_MIN || i2cp_limit > I2CP_ADAPTERS_MAX) {
^
vim +/gnu_printf +767 drivers/i2c/i2c-pseudo.c
756
757 /* vanprintf - See anprintf() documentation. */
758 static ssize_t vanprintf(char **out, ssize_t max_size, gfp_t gfp,
759 const char *fmt, va_list ap)
760 {
761 int ret;
762 ssize_t buf_size;
763 char *buf = NULL;
764 va_list args1;
765
766 va_copy(args1, ap);
> 767 ret = vsnprintf(NULL, 0, fmt, ap);
768 if (ret < 0)
769 goto fail_before_args1;
770 if (max_size >= 0 && ret > max_size) {
771 ret = -ERANGE;
772 goto fail_before_args1;
773 }
774
775 buf_size = ret + 1;
776 buf = kmalloc_track_caller(buf_size, gfp);
777 if (buf == NULL) {
778 ret = -ENOMEM;
779 goto fail_before_args1;
780 }
781
782 ret = vsnprintf(buf, buf_size, fmt, args1);
783 va_end(args1);
784 if (ret < 0)
785 goto fail_after_args1;
786 if (ret + 1 != buf_size) {
787 ret = -ENOTRECOVERABLE;
788 goto fail_after_args1;
789 }
790
791 *out = buf;
792 return ret;
793
794 fail_before_args1:
795 va_end(args1);
796 fail_after_args1:
797 kfree(buf);
798 if (ret >= 0)
799 ret = -ENOTRECOVERABLE;
800 return ret;
801 }
802
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
arch/powerpc/kexec/ima.c:156:21: sparse: sparse: incorrect type in assignment (different base types)
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 423b8baf18a8c03f2d6fa99aa447ed0da189bb95
commit: 793b08e2efff3ec020c5c5861d00ed394fcdd488 powerpc/kexec: Move kexec files into a dedicated subdir.
date: 6 months ago
config: powerpc-randconfig-s001-20200524 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-193-gb8fad4bc-dirty
git checkout 793b08e2efff3ec020c5c5861d00ed394fcdd488
# save the attached .config to linux build tree
make W=1 C=1 ARCH=powerpc CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> arch/powerpc/kexec/ima.c:156:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] tmp @@ got restrunsigned int [usertype] tmp @@
>> arch/powerpc/kexec/ima.c:156:21: sparse: expected unsigned int [usertype] tmp
>> arch/powerpc/kexec/ima.c:156:21: sparse: got restricted __be32 [usertype]
>> arch/powerpc/kexec/ima.c:161:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] tmp @@ got nsigned long long [usertype] tmp @@
>> arch/powerpc/kexec/ima.c:161:21: sparse: expected unsigned long long [usertype] tmp
>> arch/powerpc/kexec/ima.c:161:21: sparse: got restricted __be64 [usertype]
vim +156 arch/powerpc/kexec/ima.c
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 147
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 148 static int write_number(void *p, u64 value, int cells)
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 149 {
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 150 if (cells == 1) {
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 151 u32 tmp;
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 152
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 153 if (value > U32_MAX)
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 154 return -EINVAL;
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 155
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 @156 tmp = cpu_to_be32(value);
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 157 memcpy(p, &tmp, sizeof(tmp));
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 158 } else if (cells == 2) {
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 159 u64 tmp;
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 160
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 @161 tmp = cpu_to_be64(value);
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 162 memcpy(p, &tmp, sizeof(tmp));
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 163 } else
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 164 return -EINVAL;
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 165
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 166 return 0;
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 167 }
ab6b1d1fc4aae6 arch/powerpc/kernel/ima_kexec.c Thiago Jung Bauermann 2016-12-19 168
:::::: The code at line 156 was first introduced by commit
:::::: ab6b1d1fc4aae6b8bd6fb1422405568094c9b40f powerpc: ima: send the kexec buffer to the next kernel
:::::: TO: Thiago Jung Bauermann <bauerman(a)linux.vnet.ibm.com>
:::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[rdma:wip/jgg-for-next 145/171] drivers/infiniband/hw/hfi1/ipoib_main.o: warning: objtool: __llvm_gcov_writeout()+0x7: call without frame pointer save/setup
by kbuild test robot
CC: Doug Ledford <dledford(a)redhat.com>
CC: Jason Gunthorpe <jgg+lists(a)ziepe.ca>
CC: linux-rdma(a)vger.kernel.org
TO: Gary Leshner <Gary.S.Leshner(a)intel.com>
CC: Jason Gunthorpe <jgg(a)ziepe.ca>
CC: Mike Marciniszyn <mike.marciniszyn(a)intel.com>
CC: Dennis Dalessandro <dennis.dalessandro(a)intel.com>
CC: Kaike Wan <kaike.wan(a)intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git wip/jgg-for-next
head: a94dae867c5663f36c950b82832e146a6c2f0e42
commit: 438d7dda9841ec42ef7d9024dc45347f9526016a [145/171] IB/hfi1: Add the transmit side of a datagram ipoib RDMA netdev
config: x86_64-randconfig-a015-20200521 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 438d7dda9841ec42ef7d9024dc45347f9526016a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/infiniband/hw/hfi1/ipoib_main.o: warning: objtool: __llvm_gcov_writeout()+0x7: call without frame pointer save/setup
>> drivers/infiniband/hw/hfi1/ipoib_main.o: warning: objtool: __llvm_gcov_reset()+0x0: call without frame pointer save/setup
>> drivers/infiniband/hw/hfi1/ipoib_main.o: warning: objtool: __llvm_gcov_flush()+0x0: call without frame pointer save/setup
>> drivers/infiniband/hw/hfi1/ipoib_main.o: warning: objtool: __llvm_gcov_init()+0x0: call without frame pointer save/setup
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
net/core/skbuff.c:3673 skb_segment_list() warn: inconsistent indenting
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e644645abf4788e919beeb97925fb6bf43e890a2
commit: 3a1296a38d0cf62bffb9a03c585cbd5dbf15d596 net: Support GRO/GSO fraglist chaining.
date: 4 months ago
config: h8300-randconfig-m001-20200521 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 3a1296a38d0cf62bffb9a03c585cbd5dbf15d596
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
New smatch warnings:
net/core/skbuff.c:3673 skb_segment_list() warn: inconsistent indenting
Old smatch warnings:
net/core/skbuff.c:105 skb_panic() warn: argument 8 to %#lx specifier is cast from pointer
net/core/skbuff.c:105 skb_panic() warn: argument 9 to %#lx specifier is cast from pointer
net/core/skbuff.c:3845 skb_segment() error: we previously assumed 'list_skb' could be null (see line 3765)
vim +3673 net/core/skbuff.c
3641
3642 struct sk_buff *skb_segment_list(struct sk_buff *skb,
3643 netdev_features_t features,
3644 unsigned int offset)
3645 {
3646 struct sk_buff *list_skb = skb_shinfo(skb)->frag_list;
3647 unsigned int tnl_hlen = skb_tnl_header_len(skb);
3648 unsigned int delta_truesize = 0;
3649 unsigned int delta_len = 0;
3650 struct sk_buff *tail = NULL;
3651 struct sk_buff *nskb;
3652
3653 skb_push(skb, -skb_network_offset(skb) + offset);
3654
3655 skb_shinfo(skb)->frag_list = NULL;
3656
3657 do {
3658 nskb = list_skb;
3659 list_skb = list_skb->next;
3660
3661 if (!tail)
3662 skb->next = nskb;
3663 else
3664 tail->next = nskb;
3665
3666 tail = nskb;
3667
3668 delta_len += nskb->len;
3669 delta_truesize += nskb->truesize;
3670
3671 skb_push(nskb, -skb_network_offset(nskb) + offset);
3672
> 3673 __copy_skb_header(nskb, skb);
3674
3675 skb_headers_offset_update(nskb, skb_headroom(nskb) - skb_headroom(skb));
3676 skb_copy_from_linear_data_offset(skb, -tnl_hlen,
3677 nskb->data - tnl_hlen,
3678 offset + tnl_hlen);
3679
3680 if (skb_needs_linearize(nskb, features) &&
3681 __skb_linearize(nskb))
3682 goto err_linearize;
3683
3684 } while (list_skb);
3685
3686 skb->truesize = skb->truesize - delta_truesize;
3687 skb->data_len = skb->data_len - delta_len;
3688 skb->len = skb->len - delta_len;
3689
3690 skb_gso_reset(skb);
3691
3692 skb->prev = tail;
3693
3694 if (skb_needs_linearize(skb, features) &&
3695 __skb_linearize(skb))
3696 goto err_linearize;
3697
3698 skb_get(skb);
3699
3700 return skb;
3701
3702 err_linearize:
3703 kfree_skb_list(skb->next);
3704 skb->next = NULL;
3705 return ERR_PTR(-ENOMEM);
3706 }
3707 EXPORT_SYMBOL_GPL(skb_segment_list);
3708
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [PATCH 1/2] ext4: mballoc - prefetching for bitmaps
by kbuild test robot
Hi Alex,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on ext4/dev]
[also build test WARNING on v5.7-rc6 next-20200522]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Alex-Zhuravlev/ext4-mballoc-pref...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: x86_64-lkp (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from include/linux/export.h:43:0,
from include/linux/linkage.h:7,
from include/linux/fs.h:5,
from fs/ext4/ext4_jbd2.h:15,
from fs/ext4/mballoc.c:12:
fs/ext4/mballoc.c: In function 'ext4_mb_prefetch':
>> fs/ext4/mballoc.c:2137:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
BUG_ON(nr < 0);
^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
# define unlikely(x) __builtin_expect(!!(x), 0)
^
fs/ext4/mballoc.c:2137:2: note: in expansion of macro 'BUG_ON'
BUG_ON(nr < 0);
^~~~~~
vim +2137 fs/ext4/mballoc.c
2106
2107 /*
2108 * each allocation context (i.e. a thread doing allocation) has own
2109 * sliding prefetch window of @s_mb_prefetch size which starts at the
2110 * very first goal and moves ahead of scaning.
2111 * a side effect is that subsequent allocations will likely find
2112 * the bitmaps in cache or at least in-flight.
2113 */
2114 static void
2115 ext4_mb_prefetch(struct ext4_allocation_context *ac,
2116 ext4_group_t start)
2117 {
2118 struct super_block *sb = ac->ac_sb;
2119 ext4_group_t ngroups = ext4_get_groups_count(sb);
2120 struct ext4_sb_info *sbi = EXT4_SB(sb);
2121 struct ext4_group_info *grp;
2122 ext4_group_t nr, group = start;
2123 struct buffer_head *bh;
2124
2125 /* limit prefetching at cr=0, otherwise mballoc can
2126 * spend a lot of time loading imperfect groups */
2127 if (ac->ac_criteria < 2 && ac->ac_prefetch_ios >= sbi->s_mb_prefetch_limit)
2128 return;
2129
2130 /* batch prefetching to get few READs in flight */
2131 nr = ac->ac_prefetch - group;
2132 if (ac->ac_prefetch < group)
2133 /* wrapped to the first groups */
2134 nr += ngroups;
2135 if (nr > 0)
2136 return;
> 2137 BUG_ON(nr < 0);
2138
2139 nr = sbi->s_mb_prefetch;
2140 if (ext4_has_feature_flex_bg(sb)) {
2141 /* align to flex_bg to get more bitmas with a single IO */
2142 nr = (group / sbi->s_mb_prefetch) * sbi->s_mb_prefetch;
2143 nr = nr + sbi->s_mb_prefetch - group;
2144 }
2145 while (nr-- > 0) {
2146 grp = ext4_get_group_info(sb, group);
2147
2148 /* prevent expensive getblk() on groups w/ IO in progress */
2149 if (EXT4_MB_GRP_TEST_AND_SET_READ(grp))
2150 goto next;
2151
2152 /* ignore empty groups - those will be skipped
2153 * during the scanning as well */
2154 if (grp->bb_free > 0 && EXT4_MB_GRP_NEED_INIT(grp)) {
2155 bh = ext4_read_block_bitmap_nowait(sb, group, true);
2156 if (bh && !IS_ERR(bh)) {
2157 if (!buffer_uptodate(bh))
2158 ac->ac_prefetch_ios++;
2159 brelse(bh);
2160 }
2161 }
2162 next:
2163 if (++group >= ngroups)
2164 group = 0;
2165 }
2166 ac->ac_prefetch = group;
2167 }
2168
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[linux-next:master 8559/12102] drivers/net/ethernet/qlogic/qed/qed_hw.c:850:3: warning: function 'qed_hw_err_notify' might be a candidate for 'gnu_printf' format attribute
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: c11d28ab4a691736e30b49813fb801847bd44e83
commit: d639836ab3363f935a9a4336cb4ea3828d0437dd [8559/12102] net: qed: adding hw_err states and handling
config: x86_64-fedora-25 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
git checkout d639836ab3363f935a9a4336cb4ea3828d0437dd
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/net/ethernet/qlogic/qed/qed_hw.c: In function 'qed_hw_err_notify':
<< from drivers/net/ethernet/qlogic/qed/qed_hw.c:46:
>> drivers/net/ethernet/qlogic/qed/qed_hw.c:850:3: warning: function 'qed_hw_err_notify' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
len = vsnprintf(buf, QED_HW_ERR_MAX_STR_SIZE, fmt, vl);
^~~
In file included from drivers/net/ethernet/qlogic/qed/qed.h:51:0,
from drivers/net/ethernet/qlogic/qed/qed_hw.c:46:
At top level:
drivers/net/ethernet/qlogic/qed/qed_hsi.h:4421:18: warning: 'iro_arr' defined but not used [-Wunused-const-variable=]
static const u32 iro_arr[] = {
^~~~~~~
vim +850 drivers/net/ethernet/qlogic/qed/qed_hw.c
839
840 void qed_hw_err_notify(struct qed_hwfn *p_hwfn,
841 struct qed_ptt *p_ptt,
842 enum qed_hw_err_type err_type, char *fmt, ...)
843 {
844 char buf[QED_HW_ERR_MAX_STR_SIZE];
845 va_list vl;
846 int len;
847
848 if (fmt) {
849 va_start(vl, fmt);
> 850 len = vsnprintf(buf, QED_HW_ERR_MAX_STR_SIZE, fmt, vl);
851 va_end(vl);
852
853 if (len > QED_HW_ERR_MAX_STR_SIZE - 1)
854 len = QED_HW_ERR_MAX_STR_SIZE - 1;
855
856 DP_NOTICE(p_hwfn, "%s", buf);
857 }
858
859 /* Fan failure cannot be masked by handling of another HW error */
860 if (p_hwfn->cdev->recov_in_prog &&
861 err_type != QED_HW_ERR_FAN_FAIL) {
862 DP_VERBOSE(p_hwfn,
863 NETIF_MSG_DRV,
864 "Recovery is in progress. Avoid notifying about HW error %d.\n",
865 err_type);
866 return;
867 }
868
869 qed_hw_error_occurred(p_hwfn, err_type);
870 }
871
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[rdma:wip/jgg-for-next 144/171] drivers/infiniband/hw/hfi1/ipoib_tx.o: warning: objtool: __llvm_gcov_writeout()+0x7: call without frame pointer save/setup
by kbuild test robot
CC: Doug Ledford <dledford(a)redhat.com>
CC: Jason Gunthorpe <jgg+lists(a)ziepe.ca>
CC: linux-rdma(a)vger.kernel.org
TO: Gary Leshner <Gary.S.Leshner(a)intel.com>
CC: Jason Gunthorpe <jgg(a)ziepe.ca>
CC: Mike Marciniszyn <mike.marciniszyn(a)intel.com>
CC: Dennis Dalessandro <dennis.dalessandro(a)intel.com>
CC: Kaike Wan <kaike.wan(a)intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git wip/jgg-for-next
head: a94dae867c5663f36c950b82832e146a6c2f0e42
commit: d99dc602e2a55a99940ba9506a7126dfa54d54ea [144/171] IB/hfi1: Add functions to transmit datagram ipoib packets
config: x86_64-randconfig-a015-20200521 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout d99dc602e2a55a99940ba9506a7126dfa54d54ea
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/infiniband/hw/hfi1/ipoib_tx.o: warning: objtool: __llvm_gcov_writeout()+0x7: call without frame pointer save/setup
>> drivers/infiniband/hw/hfi1/ipoib_tx.o: warning: objtool: __llvm_gcov_reset()+0x0: call without frame pointer save/setup
drivers/infiniband/hw/hfi1/ipoib_tx.o: warning: objtool: __llvm_gcov_reset()+0x1d00: call without frame pointer save/setup
>> drivers/infiniband/hw/hfi1/ipoib_tx.o: warning: objtool: __llvm_gcov_init()+0x0: call without frame pointer save/setup
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months