Re: [PATCH v4 5/8] powerpc/pmem/of_pmem: Update of_pmem to use the new barrier instruction.
by kbuild test robot
Hi "Aneesh,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on linux-nvdimm/libnvdimm-for-next scottwood/next v5.7-rc7]
[cannot apply to next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Aneesh-Kumar-K-V/Support-new-pme...
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-ppc6xx_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/powerpc/include/asm/asm-prototypes.h:12,
from arch/powerpc/kernel/early_32.c:11:
arch/powerpc/include/asm/cacheflush.h: In function 'arch_pmem_flush_barrier':
arch/powerpc/include/asm/cacheflush.h:126:6: error: implicit declaration of function 'cpu_has_feature'; did you mean 'mmu_has_feature'? [-Werror=implicit-function-declaration]
126 | if (cpu_has_feature(CPU_FTR_ARCH_207S))
| ^~~~~~~~~~~~~~~
| mmu_has_feature
In file included from arch/powerpc/include/asm/cputhreads.h:7,
from arch/powerpc/include/asm/mmu_context.h:12,
from arch/powerpc/include/asm/asm-prototypes.h:17,
from arch/powerpc/kernel/early_32.c:11:
arch/powerpc/include/asm/cpu_has_feature.h: At top level:
>> arch/powerpc/include/asm/cpu_has_feature.h:49:20: error: conflicting types for 'cpu_has_feature'
49 | static inline bool cpu_has_feature(unsigned long feature)
| ^~~~~~~~~~~~~~~
In file included from arch/powerpc/include/asm/asm-prototypes.h:12,
from arch/powerpc/kernel/early_32.c:11:
arch/powerpc/include/asm/cacheflush.h:126:6: note: previous implicit declaration of 'cpu_has_feature' was here
126 | if (cpu_has_feature(CPU_FTR_ARCH_207S))
| ^~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/cpu_has_feature +49 arch/powerpc/include/asm/cpu_has_feature.h
c812c7d8f1470a Aneesh Kumar K.V 2016-07-23 38
4db7327194dba0 Kevin Hao 2016-07-23 39 if (CPU_FTRS_ALWAYS & feature)
4db7327194dba0 Kevin Hao 2016-07-23 40 return true;
4db7327194dba0 Kevin Hao 2016-07-23 41
4db7327194dba0 Kevin Hao 2016-07-23 42 if (!(CPU_FTRS_POSSIBLE & feature))
4db7327194dba0 Kevin Hao 2016-07-23 43 return false;
4db7327194dba0 Kevin Hao 2016-07-23 44
4db7327194dba0 Kevin Hao 2016-07-23 45 i = __builtin_ctzl(feature);
4db7327194dba0 Kevin Hao 2016-07-23 46 return static_branch_likely(&cpu_feature_keys[i]);
4db7327194dba0 Kevin Hao 2016-07-23 47 }
4db7327194dba0 Kevin Hao 2016-07-23 48 #else
b92a226e528423 Kevin Hao 2016-07-23 @49 static inline bool cpu_has_feature(unsigned long feature)
b92a226e528423 Kevin Hao 2016-07-23 50 {
b92a226e528423 Kevin Hao 2016-07-23 51 return early_cpu_has_feature(feature);
b92a226e528423 Kevin Hao 2016-07-23 52 }
4db7327194dba0 Kevin Hao 2016-07-23 53 #endif
b92a226e528423 Kevin Hao 2016-07-23 54
:::::: The code at line 49 was first introduced by commit
:::::: b92a226e528423b8d249dd09bb450d53361fbfcb powerpc: Move cpu_has_feature() to a separate file
:::::: TO: Kevin Hao <haokexin(a)gmail.com>
:::::: CC: Michael Ellerman <mpe(a)ellerman.id.au>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 2 months
Re: [Intel-wired-lan] [PATCH 14/14] ASoC: SOF: ops: Add new op for client registration
by kbuild test robot
Hi Ranjani,
I love your patch! Yet something to improve:
[auto build test ERROR on asoc/for-next]
[also build test ERROR on next-20200529]
[cannot apply to kbuild/for-next linus/master v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Ranjani-Sridharan/Virtual-bus-im...
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: riscv-allmodconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
sound/soc/sof/intel/apl.c:161:1: warning: data definition has no type or storage class
161 | MODULE_IMPORT_NS(SND_SOC_SOF_CLIENT);
| ^~~~~~~~~~~~~~~~
>> sound/soc/sof/intel/apl.c:161:1: error: type defaults to 'int' in declaration of 'MODULE_IMPORT_NS' [-Werror=implicit-int]
sound/soc/sof/intel/apl.c:161:1: warning: parameter names (without types) in function declaration
cc1: some warnings being treated as errors
--
sound/soc/sof/intel/cnl.c:438:1: warning: data definition has no type or storage class
438 | MODULE_IMPORT_NS(SND_SOC_SOF_CLIENT);
| ^~~~~~~~~~~~~~~~
>> sound/soc/sof/intel/cnl.c:438:1: error: type defaults to 'int' in declaration of 'MODULE_IMPORT_NS' [-Werror=implicit-int]
sound/soc/sof/intel/cnl.c:438:1: warning: parameter names (without types) in function declaration
cc1: some warnings being treated as errors
vim +161 sound/soc/sof/intel/apl.c
145
146 const struct sof_intel_dsp_desc apl_chip_info = {
147 /* Apollolake */
148 .cores_num = 2,
149 .init_core_mask = 1,
150 .cores_mask = HDA_DSP_CORE_MASK(0) | HDA_DSP_CORE_MASK(1),
151 .ipc_req = HDA_DSP_REG_HIPCI,
152 .ipc_req_mask = HDA_DSP_REG_HIPCI_BUSY,
153 .ipc_ack = HDA_DSP_REG_HIPCIE,
154 .ipc_ack_mask = HDA_DSP_REG_HIPCIE_DONE,
155 .ipc_ctl = HDA_DSP_REG_HIPCCTL,
156 .rom_init_timeout = 150,
157 .ssp_count = APL_SSP_COUNT,
158 .ssp_base_offset = APL_SSP_BASE_OFFSET,
159 };
160 EXPORT_SYMBOL_NS(apl_chip_info, SND_SOC_SOF_INTEL_HDA_COMMON);
> 161 MODULE_IMPORT_NS(SND_SOC_SOF_CLIENT);
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 2 months
Re: [PATCH v3 4/6] bus: Add Baikal-T1 AXI-bus driver
by kbuild test robot
Hi Serge,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on char-misc/char-misc-testing staging/staging-testing linus/master v5.7-rc7]
[cannot apply to next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Serge-Semin/bus-memory-Add-Baika...
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
cppcheck warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/netronome/nfp/flower/offload.c:1129:44: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
size = key_layer & NFP_FLOWER_LAYER_IPV4 ?
^
--
>> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:3555:2: warning: Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? [uselessAssignmentPtrArg]
data = qlcnic_83xx_fill_stats(adapter, &cmd, data,
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic.h:1836:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return adapter->ahw->extra_capability[0] &
^
>> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:3858:9: warning: Identical condition 'err', second condition is always false [identicalConditionAfterEarlyExit]
return err;
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:3853:6: note: first condition
if (err)
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:3858:9: note: second condition
return err;
^
>> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:485:12: warning: Variable 'intr_val' is reassigned a value before the old one has been used. [redundantAssignment]
intr_val = readl(adapter->tgt_status_reg);
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:483:11: note: Variable 'intr_val' is reassigned a value before the old one has been used.
intr_val = readl(adapter->isr_int_vec);
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:485:12: note: Variable 'intr_val' is reassigned a value before the old one has been used.
intr_val = readl(adapter->tgt_status_reg);
^
>> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2385:6: warning: Variable 'err' is reassigned a value before the old one has been used. [redundantAssignment]
err = qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_SET_NIC_INFO);
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2375:0: note: Variable 'err' is reassigned a value before the old one has been used.
int i, err = -EIO;
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2385:6: note: Variable 'err' is reassigned a value before the old one has been used.
err = qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_SET_NIC_INFO);
^
>> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2825:6: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment]
ret = qlcnic_83xx_poll_flash_status_reg(adapter);
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2809:0: note: Variable 'ret' is reassigned a value before the old one has been used.
int ret = -EIO;
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2825:6: note: Variable 'ret' is reassigned a value before the old one has been used.
ret = qlcnic_83xx_poll_flash_status_reg(adapter);
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2881:6: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment]
ret = qlcnic_83xx_poll_flash_status_reg(adapter);
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2874:0: note: Variable 'ret' is reassigned a value before the old one has been used.
int ret = -EIO;
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2881:6: note: Variable 'ret' is reassigned a value before the old one has been used.
ret = qlcnic_83xx_poll_flash_status_reg(adapter);
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2917:6: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment]
ret = qlcnic_83xx_poll_flash_status_reg(adapter);
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2895:0: note: Variable 'ret' is reassigned a value before the old one has been used.
int ret = -EIO, err = 0;
^
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2917:6: note: Variable 'ret' is reassigned a value before the old one has been used.
ret = qlcnic_83xx_poll_flash_status_reg(adapter);
^
>> drivers/net/macvlan.c:83:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return port->flags & MACVLAN_F_ADDRCHANGE;
^
>> drivers/net/macvlan.c:763:57: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
dev_set_allmulti(lowerdev, dev->flags & IFF_ALLMULTI ? 1 : -1);
^
drivers/net/macvlan.c:766:35: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
dev->flags & IFF_PROMISC ? 1 : -1);
^
>> drivers/net/macvlan.c:1092:6: warning: Variable 'err' is reassigned a value before the old one has been used. [redundantAssignment]
err = __netpoll_setup(netpoll, real_dev);
^
drivers/net/macvlan.c:1088:6: note: Variable 'err' is reassigned a value before the old one has been used.
err = -ENOMEM;
^
drivers/net/macvlan.c:1092:6: note: Variable 'err' is reassigned a value before the old one has been used.
err = __netpoll_setup(netpoll, real_dev);
^
--
>> drivers/net/ethernet/realtek/r8169_main.c:800:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return RTL_R32(tp, GPHY_OCP) & OCPAR_FLAG;
^
drivers/net/ethernet/realtek/r8169_main.c:893:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return RTL_R32(tp, PHYAR) & 0x80000000;
^
drivers/net/ethernet/realtek/r8169_main.c:928:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return RTL_R32(tp, OCPAR) & OCPAR_FLAG;
^
drivers/net/ethernet/realtek/r8169_main.c:1032:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return RTL_R32(tp, EPHYAR) & EPHYAR_FLAG;
^
drivers/net/ethernet/realtek/r8169_main.c:1055:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return RTL_R32(tp, ERIAR) & ERIAR_FLAG;
^
drivers/net/ethernet/realtek/r8169_main.c:1157:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return r8168dp_ocp_read(tp, 0x0f, reg) & 0x00000800;
^
drivers/net/ethernet/realtek/r8169_main.c:1167:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return RTL_R8(tp, IBISR0) & 0x20;
^
drivers/net/ethernet/realtek/r8169_main.c:1275:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return RTL_R32(tp, EFUSEAR) & EFUSEAR_FLAG;
^
drivers/net/ethernet/realtek/r8169_main.c:2694:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return RTL_R32(tp, CSIAR) & CSIAR_FLAG;
^
>> drivers/net/ethernet/realtek/r8169_main.c:4740:9: warning: Variable 'retval' is reassigned a value before the old one has been used. [redundantAssignment]
retval = rtl8169_init_ring(tp);
^
drivers/net/ethernet/realtek/r8169_main.c:4722:0: note: Variable 'retval' is reassigned a value before the old one has been used.
int retval = -ENOMEM;
^
drivers/net/ethernet/realtek/r8169_main.c:4740:9: note: Variable 'retval' is reassigned a value before the old one has been used.
retval = rtl8169_init_ring(tp);
^
>> drivers/net/ethernet/realtek/r8169_main.c:474:16: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
DescOwn = (1 << 31), /* Descriptor is owned by NIC */
^
drivers/net/ethernet/realtek/r8169_main.c:514:18: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
TD1_UDP_CS = (1 << 31), /* Calculate UDP/IP checksum */
^
--
In file included from drivers/net/ethernet/sfc/ef10.c:
>> drivers/net/ethernet/sfc/ef10.c:308:21: warning: Either the condition 'rc<0' is redundant or there is division by zero at line 308. [zerodivcond]
quantum = 1536000 / rc; /* 1536 cycles */
^
drivers/net/ethernet/sfc/ef10.c:305:10: note: Assuming that condition 'rc<0' is not redundant
if (rc < 0)
^
drivers/net/ethernet/sfc/ef10.c:308:21: note: Division by zero
quantum = 1536000 / rc; /* 1536 cycles */
^
>> drivers/net/ethernet/sfc/ef10.c:2718:29: warning: Local variable nic_data shadows outer variable [shadowVar]
struct efx_ef10_nic_data *nic_data = efx->nic_data;
^
drivers/net/ethernet/sfc/ef10.c:2682:28: note: Shadowed declaration
struct efx_ef10_nic_data *nic_data = efx->nic_data;
^
drivers/net/ethernet/sfc/ef10.c:2718:29: note: Shadow variable
struct efx_ef10_nic_data *nic_data = efx->nic_data;
^
>> drivers/net/ethernet/sfc/ef10.c:2700:7: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
(1 << MC_CMD_GET_CAPABILITIES_OUT_VXLAN_NVGRE_LBN) ?
^
drivers/net/ethernet/sfc/ef10.c:3721:9: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
(1 << MC_CMD_GET_CAPABILITIES_OUT_VXLAN_NVGRE_LBN))) {
^
drivers/net/ethernet/sfc/ef10.c:3842:11: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
(1 << MC_CMD_GET_CAPABILITIES_OUT_VXLAN_NVGRE_LBN)))
^
drivers/net/ethernet/sfc/ef10.c:3903:11: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
(1 << MC_CMD_GET_CAPABILITIES_OUT_VXLAN_NVGRE_LBN)))
^
drivers/net/ethernet/sfc/ef10.c:3924:11: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
(1 << MC_CMD_GET_CAPABILITIES_OUT_VXLAN_NVGRE_LBN)))
^
>> drivers/net/ethernet/sfc/ef10.c:2700:55: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
(1 << MC_CMD_GET_CAPABILITIES_OUT_VXLAN_NVGRE_LBN) ?
^
drivers/net/ethernet/sfc/ef10.c:3255:30: warning: Local variable nic_data shadows outer variable [shadowVar]
struct efx_ef10_nic_data *nic_data = efx_pf->nic_data;
^
drivers/net/ethernet/sfc/ef10.c:3214:28: note: Shadowed declaration
struct efx_ef10_nic_data *nic_data = efx->nic_data;
^
drivers/net/ethernet/sfc/ef10.c:3255:30: note: Shadow variable
struct efx_ef10_nic_data *nic_data = efx_pf->nic_data;
^
>> drivers/net/ethernet/qlogic/qed/qed_roce.c:809:5: warning: Variable 'rc' is reassigned a value before the old one has been used. [redundantAssignment]
rc = qed_sp_init_request(p_hwfn, &p_ent, ROCE_RAMROD_DESTROY_QP,
^
drivers/net/ethernet/qlogic/qed/qed_roce.c:786:0: note: Variable 'rc' is reassigned a value before the old one has been used.
int rc = -ENOMEM;
^
drivers/net/ethernet/qlogic/qed/qed_roce.c:809:5: note: Variable 'rc' is reassigned a value before the old one has been used.
rc = qed_sp_init_request(p_hwfn, &p_ent, ROCE_RAMROD_DESTROY_QP,
^
drivers/net/ethernet/qlogic/qed/qed_roce.c:890:5: warning: Variable 'rc' is reassigned a value before the old one has been used. [redundantAssignment]
rc = qed_sp_init_request(p_hwfn, &p_ent, ROCE_RAMROD_QUERY_QP,
^
drivers/net/ethernet/qlogic/qed/qed_roce.c:853:0: note: Variable 'rc' is reassigned a value before the old one has been used.
int rc = -ENOMEM;
^
drivers/net/ethernet/qlogic/qed/qed_roce.c:890:5: note: Variable 'rc' is reassigned a value before the old one has been used.
rc = qed_sp_init_request(p_hwfn, &p_ent, ROCE_RAMROD_QUERY_QP,
^
>> drivers/net/ethernet/qlogic/qed/qed_rdma.c:1692:9: warning: Identical condition 'rc', second condition is always false [identicalConditionAfterEarlyExit]
return rc;
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1686:6: note: first condition
if (rc)
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1692:9: note: second condition
return rc;
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1735:9: warning: Identical condition 'rc', second condition is always false [identicalConditionAfterEarlyExit]
return rc;
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1723:6: note: first condition
if (rc)
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1735:9: note: second condition
return rc;
^
>> drivers/net/ethernet/qlogic/qed/qed_rdma.c:206:5: warning: Variable 'rc' is reassigned a value before the old one has been used. [redundantAssignment]
rc = qed_rdma_bmap_alloc(p_hwfn, &p_rdma_info->pd_map, RDMA_MAX_PDS,
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:167:0: note: Variable 'rc' is reassigned a value before the old one has been used.
int rc = -ENOMEM;
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:206:5: note: Variable 'rc' is reassigned a value before the old one has been used.
rc = qed_rdma_bmap_alloc(p_hwfn, &p_rdma_info->pd_map, RDMA_MAX_PDS,
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:761:5: warning: Variable 'rc' is reassigned a value before the old one has been used. [redundantAssignment]
rc = qed_sp_init_request(p_hwfn, &p_ent, RDMA_RAMROD_FUNC_CLOSE,
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:722:0: note: Variable 'rc' is reassigned a value before the old one has been used.
int rc = -EBUSY;
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:761:5: note: Variable 'rc' is reassigned a value before the old one has been used.
rc = qed_sp_init_request(p_hwfn, &p_ent, RDMA_RAMROD_FUNC_CLOSE,
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1131:5: warning: Variable 'rc' is reassigned a value before the old one has been used. [redundantAssignment]
rc = qed_sp_init_request(p_hwfn, &p_ent,
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1109:0: note: Variable 'rc' is reassigned a value before the old one has been used.
int rc = -ENOMEM;
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1131:5: note: Variable 'rc' is reassigned a value before the old one has been used.
rc = qed_sp_init_request(p_hwfn, &p_ent,
^
>> drivers/net/ethernet/qlogic/qed/qed_rdma.c:1771:13: warning: Variable 'opaque_fid' is reassigned a value before the old one has been used. [redundantAssignment]
opaque_fid = p_hwfn->hw_info.opaque_fid;
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1769:13: note: Variable 'opaque_fid' is reassigned a value before the old one has been used.
opaque_fid = p_hwfn->hw_info.opaque_fid;
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1771:13: note: Variable 'opaque_fid' is reassigned a value before the old one has been used.
opaque_fid = p_hwfn->hw_info.opaque_fid;
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1860:5: warning: Variable 'rc' is reassigned a value before the old one has been used. [redundantAssignment]
rc = qed_rdma_alloc(p_hwfn);
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1851:0: note: Variable 'rc' is reassigned a value before the old one has been used.
int rc = -EBUSY;
^
drivers/net/ethernet/qlogic/qed/qed_rdma.c:1860:5: note: Variable 'rc' is reassigned a value before the old one has been used.
rc = qed_rdma_alloc(p_hwfn);
^
>> drivers/bus/bt1-axi.c:67:29: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
high & BT1_AXI_WERRH_TYPE ? "no slave" : "slave protocol error",
^
--
>> drivers/clk/ingenic/cgu.c:39:3: warning: Boolean result is used in bitwise operation. Clarify expression with parentheses. [clarifyCondition]
^ info->clear_to_gate;
^
>> drivers/clk/ingenic/cgu.c:729:6: warning: Variable 'err' is reassigned a value before the old one has been used. [redundantAssignment]
err = clk_register_clkdev(clk, clk_info->name, NULL);
^
drivers/clk/ingenic/cgu.c:604:0: note: Variable 'err' is reassigned a value before the old one has been used.
int err = -EINVAL;
^
drivers/clk/ingenic/cgu.c:729:6: note: Variable 'err' is reassigned a value before the old one has been used.
err = clk_register_clkdev(clk, clk_info->name, NULL);
^
>> drivers/clk/ingenic/jz4780-cgu.c:220:22: warning: Local variable cgu shadows outer variable [shadowVar]
struct ingenic_cgu *cgu = ingenic_clk->cgu;
^
drivers/clk/ingenic/jz4780-cgu.c:100:28: note: Shadowed declaration
static struct ingenic_cgu *cgu;
^
drivers/clk/ingenic/jz4780-cgu.c:220:22: note: Shadow variable
struct ingenic_cgu *cgu = ingenic_clk->cgu;
^
--
>> fs/ceph/inode.c:1042:6: warning: Variable 'err' is reassigned a value before the old one has been used. 'break;' missing? [redundantAssignInSwitch]
err = 0;
^
fs/ceph/inode.c:950:8: note: Variable 'err' is reassigned a value before the old one has been used. 'break;' missing?
err = -ENOMEM;
^
fs/ceph/inode.c:1042:6: note: Variable 'err' is reassigned a value before the old one has been used. 'break;' missing?
err = 0;
^
>> fs/ceph/dir.c:966:6: warning: Variable 'err' is reassigned a value before the old one has been used. [redundantAssignment]
err = ceph_pre_init_acls(dir, &mode, &as_ctx);
^
fs/ceph/dir.c:944:0: note: Variable 'err' is reassigned a value before the old one has been used.
int err = -EROFS;
^
fs/ceph/dir.c:966:6: note: Variable 'err' is reassigned a value before the old one has been used.
err = ceph_pre_init_acls(dir, &mode, &as_ctx);
^
fs/ceph/dir.c:1161:7: warning: Variable 'err' is reassigned a value before the old one has been used. [redundantAssignment]
err = ceph_mdsc_submit_request(mdsc, dir, req);
^
fs/ceph/dir.c:1125:0: note: Variable 'err' is reassigned a value before the old one has been used.
int err = -EROFS;
^
fs/ceph/dir.c:1161:7: note: Variable 'err' is reassigned a value before the old one has been used.
err = ceph_mdsc_submit_request(mdsc, dir, req);
^
>> fs/ceph/file.c:2324:6: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment]
ret = file_write_and_wait_range(src_file, src_off, (src_off + len));
^
fs/ceph/file.c:2271:0: note: Variable 'ret' is reassigned a value before the old one has been used.
ssize_t ret = -EIO, bytes;
^
fs/ceph/file.c:2324:6: note: Variable 'ret' is reassigned a value before the old one has been used.
ret = file_write_and_wait_range(src_file, src_off, (src_off + len));
^
>> fs/ceph/file.c:938:12: warning: Local variable len shadows outer variable [shadowVar]
size_t len, copied;
^
fs/ceph/file.c:840:6: note: Shadowed declaration
u64 len = iov_iter_count(to);
^
fs/ceph/file.c:938:12: note: Shadow variable
size_t len, copied;
^
fs/ceph/file.c:612:70: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
in.gid = cpu_to_le32(from_kgid(&init_user_ns, dir->i_mode & S_ISGID ?
^
--
>> fs/ceph/export.c:79:6: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment]
ret = FILEID_BTRFS_WITH_PARENT;
^
fs/ceph/export.c:51:6: note: Variable 'ret' is reassigned a value before the old one has been used.
ret = -EINVAL;
^
fs/ceph/export.c:79:6: note: Variable 'ret' is reassigned a value before the old one has been used.
ret = FILEID_BTRFS_WITH_PARENT;
^
>> fs/ceph/export.c:494:6: warning: Variable 'err' is reassigned a value before the old one has been used. [redundantAssignment]
err = -ENOENT;
^
fs/ceph/export.c:416:0: note: Variable 'err' is reassigned a value before the old one has been used.
int err = -EINVAL;
^
fs/ceph/export.c:494:6: note: Variable 'err' is reassigned a value before the old one has been used.
err = -ENOENT;
^
>> fs/ceph/caps.c:2253:6: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment]
ret = ceph_wait_on_async_create(inode);
^
fs/ceph/caps.c:2249:6: note: Variable 'ret' is reassigned a value before the old one has been used.
ret = file_write_and_wait_range(file, start, end);
^
fs/ceph/caps.c:2253:6: note: Variable 'ret' is reassigned a value before the old one has been used.
ret = ceph_wait_on_async_create(inode);
^
fs/ceph/caps.c:2752:38: warning: Same expression on both sides of '||'. [duplicateExpression]
if (ret == -EAGAIN || ret == -EFBIG || ret == -EAGAIN)
^
fs/ceph/caps.c:609:33: warning: Function 'ceph_add_cap' argument order different: declaration 'inode, session, cap_id, issued, wanted, cap, seq, realmino, flags, new_cap' definition 'inode, session, cap_id, issued, wanted, seq, mseq, realmino, flags, new_cap' [funcArgOrderDifferent]
void ceph_add_cap(struct inode *inode,
^
fs/ceph/super.h:1051:40: note: Function 'ceph_add_cap' argument order different: declaration 'inode, session, cap_id, issued, wanted, cap, seq, realmino, flags, new_cap' definition 'inode, session, cap_id, issued, wanted, seq, mseq, realmino, flags, new_cap'
extern void ceph_add_cap(struct inode *inode,
^
fs/ceph/caps.c:609:33: note: Function 'ceph_add_cap' argument order different: declaration 'inode, session, cap_id, issued, wanted, cap, seq, realmino, flags, new_cap' definition 'inode, session, cap_id, issued, wanted, seq, mseq, realmino, flags, new_cap'
void ceph_add_cap(struct inode *inode,
^
>> drivers/hwmon/nct7904.c:208:18: warning: Either the condition 'ret<0' is redundant or there is division by zero at line 208. [zerodivcond]
rpm = 1350000 / cnt;
^
drivers/hwmon/nct7904.c:202:11: note: Assuming that condition 'ret<0' is not redundant
if (ret < 0)
^
drivers/hwmon/nct7904.c:204:31: note: Assignment 'cnt=((ret&65280)>>3)|(ret&31)', assigned value is 0
cnt = ((ret & 0xff00) >> 3) | (ret & 0x1f);
^
drivers/hwmon/nct7904.c:208:18: note: Division by zero
rpm = 1350000 / cnt;
^
drivers/hwmon/nct7904.c:220:18: warning: Either the condition 'ret<0' is redundant or there is division by zero at line 220. [zerodivcond]
rpm = 1350000 / cnt;
^
drivers/hwmon/nct7904.c:214:11: note: Assuming that condition 'ret<0' is not redundant
if (ret < 0)
^
drivers/hwmon/nct7904.c:216:31: note: Assignment 'cnt=((ret&65280)>>3)|(ret&31)', assigned value is 0
cnt = ((ret & 0xff00) >> 3) | (ret & 0x1f);
^
drivers/hwmon/nct7904.c:220:18: note: Division by zero
rpm = 1350000 / cnt;
^
>> drivers/hwmon/nct7904.c:398:29: warning: Shifting a negative value is technically undefined behaviour [shiftNegativeLHS]
((channel - 5) >> 3));
^
--
In file included from drivers/md/raid5.c:
drivers/md/md.h:617:9: warning: Identical condition 'sd', second condition is always false [identicalConditionAfterEarlyExit]
return sd;
^
drivers/md/md.h:615:6: note: first condition
if (sd)
^
drivers/md/md.h:617:9: note: second condition
return sd;
^
>> drivers/md/raid5.c:179:26: warning: Local variable group shadows outer variable [shadowVar]
struct r5worker_group *group;
^
drivers/md/raid5.c:169:25: note: Shadowed declaration
struct r5worker_group *group;
^
drivers/md/raid5.c:179:26: note: Shadow variable
struct r5worker_group *group;
^
>> drivers/md/raid5.c:3181:7: warning: Local variable qd_idx shadows outer variable [shadowVar]
int qd_idx = sh->qd_idx;
^
drivers/md/raid5.c:3095:30: note: Shadowed declaration
int i, pd_idx = sh->pd_idx, qd_idx = sh->qd_idx, disks = sh->disks;
^
drivers/md/raid5.c:3181:7: note: Shadow variable
int qd_idx = sh->qd_idx;
^
>> drivers/md/raid5.c:1508:9: warning: Uninitialized variable: target [uninitvar]
BUG_ON(target < 0);
^
--
>> drivers/net/ethernet/freescale/fec_main.c:2097:6: warning: Variable 'err' is reassigned a value before the old one has been used. [redundantAssignment]
err = of_mdiobus_register(fep->mii_bus, node);
^
drivers/net/ethernet/freescale/fec_main.c:2016:0: note: Variable 'err' is reassigned a value before the old one has been used.
int err = -ENXIO;
^
drivers/net/ethernet/freescale/fec_main.c:2097:6: note: Variable 'err' is reassigned a value before the old one has been used.
err = of_mdiobus_register(fep->mii_bus, node);
^
>> drivers/net/ethernet/freescale/fec_main.c:868:34: warning: Same value in both branches of ternary operator. [duplicateValueTernary]
writel(rxq->bd.dma, fep->hwp + FEC_R_DES_START(i));
^
drivers/net/ethernet/freescale/fec_main.c:869:38: warning: Same value in both branches of ternary operator. [duplicateValueTernary]
writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_R_BUFF_SIZE(i));
^
drivers/net/ethernet/freescale/fec_main.c:874:22: warning: Same value in both branches of ternary operator. [duplicateValueTernary]
fep->hwp + FEC_RCMR(i));
^
drivers/net/ethernet/freescale/fec_main.c:879:34: warning: Same value in both branches of ternary operator. [duplicateValueTernary]
writel(txq->bd.dma, fep->hwp + FEC_X_DES_START(i));
^
drivers/net/ethernet/freescale/fec_main.c:883:26: warning: Same value in both branches of ternary operator. [duplicateValueTernary]
writel(DMA_CLASS_EN | IDLE_SLOPE(i),
^
drivers/net/ethernet/freescale/fec_main.c:884:22: warning: Same value in both branches of ternary operator. [duplicateValueTernary]
fep->hwp + FEC_DMA_CFG(i));
^
>> drivers/net/ethernet/freescale/fec_main.c:1524:23: warning: Local variable ebdp shadows outer variable [shadowVar]
struct bufdesc_ex *ebdp = (struct bufdesc_ex *)bdp;
^
drivers/net/ethernet/freescale/fec_main.c:1370:21: note: Shadowed declaration
struct bufdesc_ex *ebdp = NULL;
^
drivers/net/ethernet/freescale/fec_main.c:1524:23: note: Shadow variable
struct bufdesc_ex *ebdp = (struct bufdesc_ex *)bdp;
^
>> drivers/net/ethernet/freescale/fec_main.c:1074:11: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
writel(0 << 31, fep->hwp + FEC_MIB_CTRLSTAT);
^
drivers/net/ethernet/freescale/fec_main.c:2481:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
rx_itr |= FEC_ITR_EN;
^
drivers/net/ethernet/freescale/fec_main.c:2482:12: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
tx_itr |= FEC_ITR_EN;
^
>> drivers/net/ethernet/freescale/fec_main.c:3050:18: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour. See condition at line 3047. [shiftTooManyBitsSigned]
hash_low |= 1 << hash;
^
drivers/net/ethernet/freescale/fec_main.c:3047:12: note: Assuming that condition 'hash>31' is not redundant
if (hash > 31)
^
drivers/net/ethernet/freescale/fec_main.c:3050:18: note: Shift
hash_low |= 1 << hash;
^
>> drivers/net/ethernet/freescale/fec_main.c:2612:54: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
wol->wolopts = fep->wol_flag & FEC_WOL_FLAG_ENABLE ? WAKE_MAGIC : 0;
^
>> drivers/net/ethernet/freescale/fec_main.c:915:6: warning: Unused variable: val [unusedVariable]
u32 val;
^
>> drivers/net/ethernet/8390/ne2k-pci.c:185:18: warning: struct member 'ne2k_pci_card::pci_dev' is never used. [unusedStructMember]
struct pci_dev *pci_dev;
^
>> drivers/net/ethernet/8390/ne2k-pci.c:346:35: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
stop_page = flags & STOP_PG_0x60 ? 0x60 : NESM_STOP_PG;
^
--
>> drivers/pci/pcie/aer.c:673:1: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
aer_stats_dev_attr(aer_dev_correctable, dev_cor_errs,
^
drivers/pci/pcie/aer.c:676:1: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
aer_stats_dev_attr(aer_dev_fatal, dev_fatal_errs,
^
drivers/pci/pcie/aer.c:679:1: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
aer_stats_dev_attr(aer_dev_nonfatal, dev_nonfatal_errs,
^
>> drivers/pci/quirks.c:3208:54: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
pci_write_config_dword(dev, VTUNCERRMSK_REG, word | VTD_MSK_SPEC_ERRORS);
^
vim +67 drivers/bus/bt1-axi.c
55
56 static irqreturn_t bt1_axi_isr(int irq, void *data)
57 {
58 struct bt1_axi *axi = data;
59 u32 low = 0, high = 0;
60
61 regmap_read(axi->sys_regs, BT1_AXI_WERRL, &low);
62 regmap_read(axi->sys_regs, BT1_AXI_WERRH, &high);
63
64 dev_crit_ratelimited(axi->dev,
65 "AXI-bus fault %d: %s at 0x%x%08x\n",
66 atomic_inc_return(&axi->count),
> 67 high & BT1_AXI_WERRH_TYPE ? "no slave" : "slave protocol error",
68 high, low);
69
70 /*
71 * Print backtrace on each CPU. This might be pointless if the fault
72 * has happened on the same CPU as the IRQ handler is executed or
73 * the other core proceeded further execution despite the error.
74 * But if it's not, by looking at the trace we would get straight to
75 * the cause of the problem.
76 */
77 trigger_all_cpu_backtrace();
78
79 return IRQ_HANDLED;
80 }
81
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 2 months
Re: [PATCH] usb: dwc2: Postponed gadget registration to the udc class driver
by kbuild test robot
Hi Minas,
I love your patch! Yet something to improve:
[auto build test ERROR on balbi-usb/testing/next]
[also build test ERROR on usb/usb-testing peter.chen-usb/ci-for-usb-next v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Minas-Harutyunyan/usb-dwc2-Postp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
config: c6x-randconfig-c022-20200531 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/usb/dwc2/platform.c: In function 'dwc2_driver_probe':
>> drivers/usb/dwc2/platform.c:580:49: error: 'struct dwc2_hsotg' has no member named 'gadget'
580 | retval = usb_add_gadget_udc(hsotg->dev, &hsotg->gadget);
| ^~
vim +580 drivers/usb/dwc2/platform.c
395
396 /**
397 * dwc2_driver_probe() - Called when the DWC_otg core is bound to the DWC_otg
398 * driver
399 *
400 * @dev: Platform device
401 *
402 * This routine creates the driver components required to control the device
403 * (core, HCD, and PCD) and initializes the device. The driver components are
404 * stored in a dwc2_hsotg structure. A reference to the dwc2_hsotg is saved
405 * in the device private data. This allows the driver to access the dwc2_hsotg
406 * structure on subsequent calls to driver methods for this device.
407 */
408 static int dwc2_driver_probe(struct platform_device *dev)
409 {
410 struct dwc2_hsotg *hsotg;
411 struct resource *res;
412 int retval;
413
414 hsotg = devm_kzalloc(&dev->dev, sizeof(*hsotg), GFP_KERNEL);
415 if (!hsotg)
416 return -ENOMEM;
417
418 hsotg->dev = &dev->dev;
419
420 /*
421 * Use reasonable defaults so platforms don't have to provide these.
422 */
423 if (!dev->dev.dma_mask)
424 dev->dev.dma_mask = &dev->dev.coherent_dma_mask;
425 retval = dma_set_coherent_mask(&dev->dev, DMA_BIT_MASK(32));
426 if (retval) {
427 dev_err(&dev->dev, "can't set coherent DMA mask: %d\n", retval);
428 return retval;
429 }
430
431 hsotg->regs = devm_platform_get_and_ioremap_resource(dev, 0, &res);
432 if (IS_ERR(hsotg->regs))
433 return PTR_ERR(hsotg->regs);
434
435 dev_dbg(&dev->dev, "mapped PA %08lx to VA %p\n",
436 (unsigned long)res->start, hsotg->regs);
437
438 retval = dwc2_lowlevel_hw_init(hsotg);
439 if (retval)
440 return retval;
441
442 spin_lock_init(&hsotg->lock);
443
444 hsotg->irq = platform_get_irq(dev, 0);
445 if (hsotg->irq < 0)
446 return hsotg->irq;
447
448 dev_dbg(hsotg->dev, "registering common handler for irq%d\n",
449 hsotg->irq);
450 retval = devm_request_irq(hsotg->dev, hsotg->irq,
451 dwc2_handle_common_intr, IRQF_SHARED,
452 dev_name(hsotg->dev), hsotg);
453 if (retval)
454 return retval;
455
456 hsotg->vbus_supply = devm_regulator_get_optional(hsotg->dev, "vbus");
457 if (IS_ERR(hsotg->vbus_supply)) {
458 retval = PTR_ERR(hsotg->vbus_supply);
459 hsotg->vbus_supply = NULL;
460 if (retval != -ENODEV)
461 return retval;
462 }
463
464 retval = dwc2_lowlevel_hw_enable(hsotg);
465 if (retval)
466 return retval;
467
468 hsotg->needs_byte_swap = dwc2_check_core_endianness(hsotg);
469
470 retval = dwc2_get_dr_mode(hsotg);
471 if (retval)
472 goto error;
473
474 hsotg->need_phy_for_wake =
475 of_property_read_bool(dev->dev.of_node,
476 "snps,need-phy-for-wake");
477
478 /*
479 * Before performing any core related operations
480 * check core version.
481 */
482 retval = dwc2_check_core_version(hsotg);
483 if (retval)
484 goto error;
485
486 /*
487 * Reset before dwc2_get_hwparams() then it could get power-on real
488 * reset value form registers.
489 */
490 retval = dwc2_core_reset(hsotg, false);
491 if (retval)
492 goto error;
493
494 /* Detect config values from hardware */
495 retval = dwc2_get_hwparams(hsotg);
496 if (retval)
497 goto error;
498
499 /*
500 * For OTG cores, set the force mode bits to reflect the value
501 * of dr_mode. Force mode bits should not be touched at any
502 * other time after this.
503 */
504 dwc2_force_dr_mode(hsotg);
505
506 retval = dwc2_init_params(hsotg);
507 if (retval)
508 goto error;
509
510 if (hsotg->params.activate_stm_id_vb_detection) {
511 u32 ggpio;
512
513 hsotg->usb33d = devm_regulator_get(hsotg->dev, "usb33d");
514 if (IS_ERR(hsotg->usb33d)) {
515 retval = PTR_ERR(hsotg->usb33d);
516 if (retval != -EPROBE_DEFER)
517 dev_err(hsotg->dev,
518 "failed to request usb33d supply: %d\n",
519 retval);
520 goto error;
521 }
522 retval = regulator_enable(hsotg->usb33d);
523 if (retval) {
524 dev_err(hsotg->dev,
525 "failed to enable usb33d supply: %d\n", retval);
526 goto error;
527 }
528
529 ggpio = dwc2_readl(hsotg, GGPIO);
530 ggpio |= GGPIO_STM32_OTG_GCCFG_IDEN;
531 ggpio |= GGPIO_STM32_OTG_GCCFG_VBDEN;
532 dwc2_writel(hsotg, ggpio, GGPIO);
533 }
534
535 if (hsotg->dr_mode != USB_DR_MODE_HOST) {
536 retval = dwc2_gadget_init(hsotg);
537 if (retval)
538 goto error_init;
539 hsotg->gadget_enabled = 1;
540 }
541
542 /*
543 * If we need PHY for wakeup we must be wakeup capable.
544 * When we have a device that can wake without the PHY we
545 * can adjust this condition.
546 */
547 if (hsotg->need_phy_for_wake)
548 device_set_wakeup_capable(&dev->dev, true);
549
550 hsotg->reset_phy_on_wake =
551 of_property_read_bool(dev->dev.of_node,
552 "snps,reset-phy-on-wake");
553 if (hsotg->reset_phy_on_wake && !hsotg->phy) {
554 dev_warn(hsotg->dev,
555 "Quirk reset-phy-on-wake only supports generic PHYs\n");
556 hsotg->reset_phy_on_wake = false;
557 }
558
559 if (hsotg->dr_mode != USB_DR_MODE_PERIPHERAL) {
560 retval = dwc2_hcd_init(hsotg);
561 if (retval) {
562 if (hsotg->gadget_enabled)
563 dwc2_hsotg_remove(hsotg);
564 goto error_init;
565 }
566 hsotg->hcd_enabled = 1;
567 }
568
569 platform_set_drvdata(dev, hsotg);
570 hsotg->hibernated = 0;
571
572 dwc2_debugfs_init(hsotg);
573
574 /* Gadget code manages lowlevel hw on its own */
575 if (hsotg->dr_mode == USB_DR_MODE_PERIPHERAL)
576 dwc2_lowlevel_hw_disable(hsotg);
577
578 /* Postponed adding a new gadget to the udc class driver list */
579 if (hsotg->gadget_enabled) {
> 580 retval = usb_add_gadget_udc(hsotg->dev, &hsotg->gadget);
581 if (retval) {
582 dwc2_hsotg_remove(hsotg);
583 goto error_init;
584 }
585 }
586
587 return 0;
588
589 error_init:
590 if (hsotg->params.activate_stm_id_vb_detection)
591 regulator_disable(hsotg->usb33d);
592 error:
593 dwc2_lowlevel_hw_disable(hsotg);
594 return retval;
595 }
596
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 2 months
[kbuild] [jlayton:ceph-fscache-iter 76/77] fs/ceph/addr.c:225 ceph_fsreq_issue_op() error: uninitialized symbol 'err'.
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git ceph-fscache-iter
head: ce11bedb85675dee88f70d28fc09cb5bca59c73e
commit: abd9e1c4c6c6d86ef46c1782a886b52f09d87ebb [76/77] ceph: convert writepage over to new helper
config: x86_64-randconfig-m001-20200529 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
fs/ceph/addr.c:225 ceph_fsreq_issue_op() error: uninitialized symbol 'err'.
fs/ceph/addr.c:1356 writeback_older_snapc() error: potentially dereferencing uninitialized 'oldest'.
Old smatch warnings:
fs/ceph/addr.c:432 start_read() warn: should 'nr_pages << 12' be a 64 bit type?
fs/ceph/addr.c:468 start_read() warn: should 'nr_pages << 12' be a 64 bit type?
fs/ceph/addr.c:2044 __ceph_pool_perm_get() error: we previously assumed 'pool_ns' could be null (see line 2033)
include/linux/ceph/string_table.h:46 ceph_compare_string() error: we previously assumed 'cs' could be null (see line 41)
# https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git/commit/...
git remote add jlayton https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git
git remote update jlayton
git checkout abd9e1c4c6c6d86ef46c1782a886b52f09d87ebb
vim +/err +225 fs/ceph/addr.c
e4de9a35b08dcf Jeff Layton 2020-05-21 188 static void ceph_fsreq_issue_op(struct fscache_io_request *fsreq)
e4de9a35b08dcf Jeff Layton 2020-05-21 189 {
e4de9a35b08dcf Jeff Layton 2020-05-21 190 struct ceph_fsc_request *cfreq = container_of(fsreq,
e4de9a35b08dcf Jeff Layton 2020-05-21 191 struct ceph_fsc_request,
e4de9a35b08dcf Jeff Layton 2020-05-21 192 fsc_req);
e4de9a35b08dcf Jeff Layton 2020-05-21 193 struct ceph_osd_request *req = &cfreq->osd_req;
e4de9a35b08dcf Jeff Layton 2020-05-21 194 struct ceph_fs_client *fsc = req->r_priv;
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 195 struct ceph_inode_info *ci = ceph_inode(fsreq->mapping->host);
e4de9a35b08dcf Jeff Layton 2020-05-21 196 int err;
e4de9a35b08dcf Jeff Layton 2020-05-21 197
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 198 if (ci->i_inline_version != CEPH_INLINE_NONE) {
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 199 /*
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 200 * Uptodate inline data should have been added
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 201 * into page cache while getting Fcr caps.
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 202 */
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 203 if (fsreq->pos == 0)
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 204 err = -EINVAL;
err not set if ->pos != 0
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 205 goto out;
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 206 }
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 207
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 208 /* FIXME: in read-for-write case, don't issue a read if the write will
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 209 * cover the whole page.
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 210 */
e4de9a35b08dcf Jeff Layton 2020-05-21 211 err = ceph_osdc_start_request(req->r_osdc, req, false);
e4de9a35b08dcf Jeff Layton 2020-05-21 212 if (!err)
e4de9a35b08dcf Jeff Layton 2020-05-21 213 err = ceph_osdc_wait_request(req->r_osdc, req);
e4de9a35b08dcf Jeff Layton 2020-05-21 214
e4de9a35b08dcf Jeff Layton 2020-05-21 215 ceph_update_read_latency(&fsc->mdsc->metric, req->r_start_latency,
e4de9a35b08dcf Jeff Layton 2020-05-21 216 req->r_end_latency, err);
e4de9a35b08dcf Jeff Layton 2020-05-21 217
e4de9a35b08dcf Jeff Layton 2020-05-21 218 /* no object means success but no data */
e4de9a35b08dcf Jeff Layton 2020-05-21 219 if (err == -ENOENT)
e4de9a35b08dcf Jeff Layton 2020-05-21 220 err = 0;
e4de9a35b08dcf Jeff Layton 2020-05-21 221 else if (err == -EBLACKLISTED)
e4de9a35b08dcf Jeff Layton 2020-05-21 222 fsc->blacklisted = true;
abd9e1c4c6c6d8 Jeff Layton 2020-05-26 223 out:
e4de9a35b08dcf Jeff Layton 2020-05-21 224 dout("readpage result %d\n", err);
e4de9a35b08dcf Jeff Layton 2020-05-21 @225 fsreq->error = err;
e4de9a35b08dcf Jeff Layton 2020-05-21 226 if (fsreq->io_done)
e4de9a35b08dcf Jeff Layton 2020-05-21 227 fsreq->io_done(fsreq);
e4de9a35b08dcf Jeff Layton 2020-05-21 228 }
e4de9a35b08dcf Jeff Layton 2020-05-21 229
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
2 years, 2 months
Re: [PATCH v2 2/3] media: rockchip: Introduce driver for Rockhip's camera interface
by kbuild test robot
Hi Maxime,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on rockchip/for-next robh/for-next v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Maxime-Chevallier/media-rockchip...
base: git://linuxtv.org/media_tree.git master
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2388a096e7865c043e83ece4e26654bd3d1a20d5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from drivers/media/platform/rockchip/cif/dev.c:22:
>> drivers/media/platform/rockchip/cif/regs.h:113:9: warning: 'FRAME_END' macro redefined [-Wmacro-redefined]
#define FRAME_END (0x01 << 0)
^
arch/x86/include/asm/frame.h:89:9: note: previous definition is here
#define FRAME_END
^
>> drivers/media/platform/rockchip/cif/dev.c:253:13: warning: variable 'v4l2_dev' is uninitialized when used here [-Wuninitialized]
v4l2_info(v4l2_dev, "No reserved memory region assign to CIFn");
^~~~~~~~
include/media/v4l2-common.h:67:25: note: expanded from macro 'v4l2_info'
v4l2_printk(KERN_INFO, dev, fmt , ## arg)
^~~
include/media/v4l2-common.h:58:28: note: expanded from macro 'v4l2_printk'
printk(level "%s: " fmt, (dev)->name , ## arg)
^~~
drivers/media/platform/rockchip/cif/dev.c:216:30: note: initialize the variable 'v4l2_dev' to silence this warning
struct v4l2_device *v4l2_dev;
^
= NULL
2 warnings generated.
--
In file included from drivers/media/platform/rockchip/cif/capture.c:22:
>> drivers/media/platform/rockchip/cif/regs.h:113:9: warning: 'FRAME_END' macro redefined [-Wmacro-redefined]
#define FRAME_END (0x01 << 0)
^
arch/x86/include/asm/frame.h:89:9: note: previous definition is here
#define FRAME_END
^
1 warning generated.
vim +/FRAME_END +113 drivers/media/platform/rockchip/cif/regs.h
110
111 /* CIF INTSTAT */
112 #define INTSTAT_CLS (0x3FF)
> 113 #define FRAME_END (0x01 << 0)
114 #define LINE_ERR (0x01 << 2)
115 #define PST_INF_FRAME_END (0x01 << 9)
116 #define FRAME_END_CLR (0x01 << 0)
117 #define LINE_ERR_CLR (0x01 << 2)
118 #define PST_INF_FRAME_END_CLR (0x01 << 9)
119 #define INTSTAT_ERR (0xFC)
120
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 2 months
[tip:x86/entry 2/19] include/xen/interface/hvm/hvm_op.h:33:28: error: a parameter list without types is only allowed in a function definition
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/entry
head: 5980d208e5ef28455e9e8b08f6250b443a2f0893
commit: 28447ea4154239025044381144f849ff749ee9ef [2/19] xen: Move xen_setup_callback_vector() definition to include/xen/hvm.h
config: x86_64-randconfig-r036-20200531 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2388a096e7865c043e83ece4e26654bd3d1a20d5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 28447ea4154239025044381144f849ff749ee9ef
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/x86/xen/suspend_hvm.c:5:
In file included from include/xen/hvm.h:6:
In file included from include/xen/interface/hvm/params.h:24:
include/xen/interface/hvm/hvm_op.h:29:5: error: unknown type name 'domid_t'
domid_t domid; /* IN */
^
>> include/xen/interface/hvm/hvm_op.h:33:1: warning: declaration specifier missing, defaulting to 'int'
DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_param);
^
int
>> include/xen/interface/hvm/hvm_op.h:33:28: error: a parameter list without types is only allowed in a function definition
DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_param);
^
include/xen/interface/hvm/hvm_op.h:39:5: error: unknown type name 'domid_t'
domid_t domid;
^
include/xen/interface/hvm/hvm_op.h:44:1: warning: declaration specifier missing, defaulting to 'int'
DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_pagetable_dying_t);
^
int
include/xen/interface/hvm/hvm_op.h:56:5: error: unknown type name 'domid_t'
domid_t domid;
^
include/xen/interface/hvm/hvm_op.h:63:1: warning: declaration specifier missing, defaulting to 'int'
DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_get_mem_type);
^
int
include/xen/interface/hvm/hvm_op.h:63:28: error: a parameter list without types is only allowed in a function definition
DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_get_mem_type);
^
3 warnings and 5 errors generated.
vim +33 include/xen/interface/hvm/hvm_op.h
18f19aa62a267f Jeremy Fitzhardinge 2010-05-14 23
18f19aa62a267f Jeremy Fitzhardinge 2010-05-14 24 /* Get/set subcommands: the second argument of the hypercall is a
18f19aa62a267f Jeremy Fitzhardinge 2010-05-14 25 * pointer to a xen_hvm_param struct. */
18f19aa62a267f Jeremy Fitzhardinge 2010-05-14 26 #define HVMOP_set_param 0
18f19aa62a267f Jeremy Fitzhardinge 2010-05-14 27 #define HVMOP_get_param 1
18f19aa62a267f Jeremy Fitzhardinge 2010-05-14 28 struct xen_hvm_param {
18f19aa62a267f Jeremy Fitzhardinge 2010-05-14 29 domid_t domid; /* IN */
18f19aa62a267f Jeremy Fitzhardinge 2010-05-14 30 uint32_t index; /* IN */
18f19aa62a267f Jeremy Fitzhardinge 2010-05-14 31 uint64_t value; /* IN/OUT */
18f19aa62a267f Jeremy Fitzhardinge 2010-05-14 32 };
18f19aa62a267f Jeremy Fitzhardinge 2010-05-14 @33 DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_param);
18f19aa62a267f Jeremy Fitzhardinge 2010-05-14 34
:::::: The code at line 33 was first introduced by commit
:::::: 18f19aa62a267f2f759e278018f1032adf4c3774 xen: Add support for HVM hypercalls.
:::::: TO: Jeremy Fitzhardinge <jeremy.fitzhardinge(a)citrix.com>
:::::: CC: Jeremy Fitzhardinge <jeremy.fitzhardinge(a)citrix.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 2 months
Re: [PATCH v4 3/3] drm/virtio: Support virtgpu exported resources
by kbuild test robot
Hi David,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20200525]
[cannot apply to linus/master v5.7-rc7 v5.7-rc6 v5.7-rc5 v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/David-Stevens/Support-virtio-cro...
base: 7b4cb0a48db03a67d1ce21c4f97b1508a241a2e7
config: x86_64-randconfig-s022-20200531 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/virtio/virtgpu_prime.c:46:33: sparse: sparse: symbol 'virtgpu_dmabuf_ops' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 2 months
Re: [PATCH Kernel v24 5/8] vfio iommu: Implementation of ioctl for dirty pages tracking
by kbuild test robot
Hi Kirti,
I love your patch! Yet something to improve:
[auto build test ERROR on v5.7-rc7]
[also build test ERROR on next-20200529]
[cannot apply to vfio/next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Kirti-Wankhede/Add-UAPIs-to-supp...
base: 9cb1fd0efd195590b828b9b865421ad345a4a145
config: i386-randconfig-s031-20200531 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-243-gc100a7ab-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
ld: drivers/vfio/vfio_iommu_type1.o: in function `vfio_dma_populate_bitmap':
>> vfio_iommu_type1.c:(.text+0x666): undefined reference to `__udivdi3'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 2 months