[RFC PATCH shawnguo] clk: imx: imx8m_clk_composite_mux_ops can be static
by kbuild test robot
Fixes: 3f0365dafe32 ("clk: imx: add mux ops for i.MX8M composite clk")
Signed-off-by: kbuild test robot <lkp(a)intel.com>
---
clk-composite-8m.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-composite-8m.c b/drivers/clk/imx/clk-composite-8m.c
index 8fa60f22d377f..2d9562ebddc3f 100644
--- a/drivers/clk/imx/clk-composite-8m.c
+++ b/drivers/clk/imx/clk-composite-8m.c
@@ -164,7 +164,7 @@ imx8m_clk_composite_mux_determine_rate(struct clk_hw *hw,
}
-const struct clk_ops imx8m_clk_composite_mux_ops = {
+static const struct clk_ops imx8m_clk_composite_mux_ops = {
.get_parent = imx8m_clk_composite_mux_get_parent,
.set_parent = imx8m_clk_composite_mux_set_parent,
.determine_rate = imx8m_clk_composite_mux_determine_rate,
2 years, 4 months
Re: [PATCH v6 2/3] arm64: Move fault address and fault code into kernel_siginfo
by kbuild test robot
Hi Peter,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on arm-perf/for-next/perf]
[also build test WARNING on linus/master v5.7-rc6]
[cannot apply to arm64/for-next/core next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Peter-Collingbourne/arm64-Expose...
base: https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git for-next/perf
config: arm64-randconfig-r005-20200520 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> arch/arm64/kernel/traps.c:283:55: warning: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Wformat]
WARN(1, "ESR 0x%x is not DABT or IABT from EL0n", esr);
~~ ^~~
%lx
include/asm-generic/bug.h:124:29: note: expanded from macro 'WARN'
__WARN_printf(TAINT_WARN, format); ^~~~~~
include/asm-generic/bug.h:92:17: note: expanded from macro '__WARN_printf'
__warn_printk(arg); ^~~
arch/arm64/kernel/traps.c:826:26: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_UNKNOWN] = "Unknown/Uncategorized",
^~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:827:22: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_WFx] = "WFI/WFE",
^~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:828:26: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_CP15_32] = "CP15 MCR/MRC",
^~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:829:26: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_CP15_64] = "CP15 MCRR/MRRC",
^~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:830:26: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_CP14_MR] = "CP14 MCR/MRC",
^~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:831:26: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_CP14_LS] = "CP14 LDC/STC",
^~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:832:27: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_FP_ASIMD] = "ASIMD",
^~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:833:26: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_CP10_ID] = "CP10 MRC/VMRS",
^~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:834:22: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_PAC] = "PAC",
^~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:835:26: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_CP14_64] = "CP14 MCRR/MRRC",
^~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:836:22: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_ILL] = "PSTATE.IL",
^~~~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:837:24: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_SVC32] = "SVC (AArch32)",
^~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:838:24: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_HVC32] = "HVC (AArch32)",
^~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:839:24: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_SMC32] = "SMC (AArch32)",
^~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:840:24: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
[ESR_ELx_EC_SVC64] = "SVC (AArch64)",
^~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:825:28: note: previous initialization is here
[0 ... ESR_ELx_EC_MAX] = "UNRECOGNIZED EC",
^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:841:24: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
vim +283 arch/arm64/kernel/traps.c
236
237 static unsigned long esr_to_error_code(unsigned long esr, unsigned long far)
238 {
239 /*
240 * If the faulting address is in the kernel, we must sanitize the ESR.
241 * From userspace's point of view, kernel-only mappings don't exist
242 * at all, so we report them as level 0 translation faults.
243 * (This is not quite the way that "no mapping there at all" behaves:
244 * an alignment fault not caused by the memory type would take
245 * precedence over translation fault for a real access to empty
246 * space. Unfortunately we can't easily distinguish "alignment fault
247 * not caused by memory type" from "alignment fault caused by memory
248 * type", so we ignore this wrinkle and just return the translation
249 * fault.)
250 */
251 if (!is_ttbr0_addr(untagged_addr(far))) {
252 switch (ESR_ELx_EC(esr)) {
253 case ESR_ELx_EC_DABT_LOW:
254 /*
255 * These bits provide only information about the
256 * faulting instruction, which userspace knows already.
257 * We explicitly clear bits which are architecturally
258 * RES0 in case they are given meanings in future.
259 * We always report the ESR as if the fault was taken
260 * to EL1 and so ISV and the bits in ISS[23:14] are
261 * clear. (In fact it always will be a fault to EL1.)
262 */
263 esr &= ESR_ELx_EC_MASK | ESR_ELx_IL |
264 ESR_ELx_CM | ESR_ELx_WNR;
265 esr |= ESR_ELx_FSC_FAULT;
266 break;
267 case ESR_ELx_EC_IABT_LOW:
268 /*
269 * Claim a level 0 translation fault.
270 * All other bits are architecturally RES0 for faults
271 * reported with that DFSC value, so we clear them.
272 */
273 esr &= ESR_ELx_EC_MASK | ESR_ELx_IL;
274 esr |= ESR_ELx_FSC_FAULT;
275 break;
276 default:
277 /*
278 * This should never happen (entry.S only brings us
279 * into this code for insn and data aborts from a lower
280 * exception level). Fail safe by not providing an ESR
281 * context record at all.
282 */
> 283 WARN(1, "ESR 0x%x is not DABT or IABT from EL0\n", esr);
284 esr = 0;
285 break;
286 }
287 }
288
289 if (is_compat_task()) {
290 /* Use the compat FSR WnR */
291 return !!(esr & ESR_ELx_WNR) << FSR_WRITE_SHIFT;
292 }
293
294 return esr;
295 }
296
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[android-common:android-3.18 15013/15049] net/ipv6/tcp_ipv6.c:137:19: warning: variable 'rt' set but not used
by kbuild test robot
tree: https://android.googlesource.com/kernel/common android-3.18
head: 2a0e8c1b4148e6622822a5eecc71db8641093f16
commit: 5d83c05d2723a77c287d6d536ab6c47d9ac03408 [15013/15049] ipv6: Remove external dependency on rt6i_dst and rt6i_src
config: x86_64-defconfig (attached as .config)
compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010
reproduce:
git checkout 5d83c05d2723a77c287d6d536ab6c47d9ac03408
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/x86/include/asm/compat.h:8:0,
from include/linux/compat.h:19,
from include/linux/ethtool.h:15,
from include/linux/netdevice.h:43,
from net/ipv6/tcp_ipv6.c:36:
include/linux/sched.h:1067:42: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
const struct sched_group_energy * const(*sched_domain_energy_f)(int cpu);
^
net/ipv6/tcp_ipv6.c: In function 'tcp_v6_connect':
>> net/ipv6/tcp_ipv6.c:137:19: warning: variable 'rt' set but not used [-Wunused-but-set-variable]
struct rt6_info *rt;
^
vim +/rt +137 net/ipv6/tcp_ipv6.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 126
^1da177e4c3f41 Linus Torvalds 2005-04-16 127 static int tcp_v6_connect(struct sock *sk, struct sockaddr *uaddr,
^1da177e4c3f41 Linus Torvalds 2005-04-16 128 int addr_len)
^1da177e4c3f41 Linus Torvalds 2005-04-16 129 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 130 struct sockaddr_in6 *usin = (struct sockaddr_in6 *) uaddr;
^1da177e4c3f41 Linus Torvalds 2005-04-16 131 struct inet_sock *inet = inet_sk(sk);
d83d8461f902c6 Arnaldo Carvalho de Melo 2005-12-13 132 struct inet_connection_sock *icsk = inet_csk(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 133 struct ipv6_pinfo *np = inet6_sk(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 134 struct tcp_sock *tp = tcp_sk(sk);
20c59de2e6b6bc Arnaud Ebalard 2010-06-01 135 struct in6_addr *saddr = NULL, *final_p, final;
aa498f1e3fa305 Eric Dumazet 2015-11-29 136 struct ipv6_txoptions *opt;
493f377d6dd56f David S. Miller 2010-12-02 @137 struct rt6_info *rt;
4c9483b2fb5d25 David S. Miller 2011-03-12 138 struct flowi6 fl6;
^1da177e4c3f41 Linus Torvalds 2005-04-16 139 struct dst_entry *dst;
^1da177e4c3f41 Linus Torvalds 2005-04-16 140 int addr_type;
^1da177e4c3f41 Linus Torvalds 2005-04-16 141 int err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 142
^1da177e4c3f41 Linus Torvalds 2005-04-16 143 if (addr_len < SIN6_LEN_RFC2133)
^1da177e4c3f41 Linus Torvalds 2005-04-16 144 return -EINVAL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 145
^1da177e4c3f41 Linus Torvalds 2005-04-16 146 if (usin->sin6_family != AF_INET6)
a02cec2155fbea Eric Dumazet 2010-09-22 147 return -EAFNOSUPPORT;
^1da177e4c3f41 Linus Torvalds 2005-04-16 148
4c9483b2fb5d25 David S. Miller 2011-03-12 149 memset(&fl6, 0, sizeof(fl6));
^1da177e4c3f41 Linus Torvalds 2005-04-16 150
^1da177e4c3f41 Linus Torvalds 2005-04-16 151 if (np->sndflow) {
4c9483b2fb5d25 David S. Miller 2011-03-12 152 fl6.flowlabel = usin->sin6_flowinfo&IPV6_FLOWINFO_MASK;
4c9483b2fb5d25 David S. Miller 2011-03-12 153 IP6_ECN_flow_init(fl6.flowlabel);
4c9483b2fb5d25 David S. Miller 2011-03-12 154 if (fl6.flowlabel&IPV6_FLOWLABEL_MASK) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 155 struct ip6_flowlabel *flowlabel;
4c9483b2fb5d25 David S. Miller 2011-03-12 156 flowlabel = fl6_sock_lookup(sk, fl6.flowlabel);
^1da177e4c3f41 Linus Torvalds 2005-04-16 157 if (flowlabel == NULL)
^1da177e4c3f41 Linus Torvalds 2005-04-16 158 return -EINVAL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 159 fl6_sock_release(flowlabel);
^1da177e4c3f41 Linus Torvalds 2005-04-16 160 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 161 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 162
^1da177e4c3f41 Linus Torvalds 2005-04-16 163 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 164 * connect() to INADDR_ANY means loopback (BSD'ism).
^1da177e4c3f41 Linus Torvalds 2005-04-16 165 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 166
a360eb6f74b999 Jonathan T. Leighton 2017-05-23 167 if (ipv6_addr_any(&usin->sin6_addr)) {
a360eb6f74b999 Jonathan T. Leighton 2017-05-23 168 if (ipv6_addr_v4mapped(&sk->sk_v6_rcv_saddr))
a360eb6f74b999 Jonathan T. Leighton 2017-05-23 169 ipv6_addr_set_v4mapped(htonl(INADDR_LOOPBACK),
a360eb6f74b999 Jonathan T. Leighton 2017-05-23 170 &usin->sin6_addr);
a360eb6f74b999 Jonathan T. Leighton 2017-05-23 171 else
a360eb6f74b999 Jonathan T. Leighton 2017-05-23 172 usin->sin6_addr = in6addr_loopback;
a360eb6f74b999 Jonathan T. Leighton 2017-05-23 173 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 174
^1da177e4c3f41 Linus Torvalds 2005-04-16 175 addr_type = ipv6_addr_type(&usin->sin6_addr);
^1da177e4c3f41 Linus Torvalds 2005-04-16 176
^1da177e4c3f41 Linus Torvalds 2005-04-16 177 if (addr_type & IPV6_ADDR_MULTICAST)
^1da177e4c3f41 Linus Torvalds 2005-04-16 178 return -ENETUNREACH;
^1da177e4c3f41 Linus Torvalds 2005-04-16 179
^1da177e4c3f41 Linus Torvalds 2005-04-16 180 if (addr_type&IPV6_ADDR_LINKLOCAL) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 181 if (addr_len >= sizeof(struct sockaddr_in6) &&
^1da177e4c3f41 Linus Torvalds 2005-04-16 182 usin->sin6_scope_id) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 183 /* If interface is set while binding, indices
^1da177e4c3f41 Linus Torvalds 2005-04-16 184 * must coincide.
^1da177e4c3f41 Linus Torvalds 2005-04-16 185 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 186 if (sk->sk_bound_dev_if &&
^1da177e4c3f41 Linus Torvalds 2005-04-16 187 sk->sk_bound_dev_if != usin->sin6_scope_id)
^1da177e4c3f41 Linus Torvalds 2005-04-16 188 return -EINVAL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 189
^1da177e4c3f41 Linus Torvalds 2005-04-16 190 sk->sk_bound_dev_if = usin->sin6_scope_id;
^1da177e4c3f41 Linus Torvalds 2005-04-16 191 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 192
^1da177e4c3f41 Linus Torvalds 2005-04-16 193 /* Connect to link-local address requires an interface */
^1da177e4c3f41 Linus Torvalds 2005-04-16 194 if (!sk->sk_bound_dev_if)
^1da177e4c3f41 Linus Torvalds 2005-04-16 195 return -EINVAL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 196 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 197
^1da177e4c3f41 Linus Torvalds 2005-04-16 198 if (tp->rx_opt.ts_recent_stamp &&
efe4208f47f907 Eric Dumazet 2013-10-03 199 !ipv6_addr_equal(&sk->sk_v6_daddr, &usin->sin6_addr)) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 200 tp->rx_opt.ts_recent = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 201 tp->rx_opt.ts_recent_stamp = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 202 tp->write_seq = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 203 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 204
efe4208f47f907 Eric Dumazet 2013-10-03 205 sk->sk_v6_daddr = usin->sin6_addr;
4c9483b2fb5d25 David S. Miller 2011-03-12 206 np->flow_label = fl6.flowlabel;
^1da177e4c3f41 Linus Torvalds 2005-04-16 207
^1da177e4c3f41 Linus Torvalds 2005-04-16 208 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 209 * TCP over IPv4
^1da177e4c3f41 Linus Torvalds 2005-04-16 210 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 211
a360eb6f74b999 Jonathan T. Leighton 2017-05-23 212 if (addr_type & IPV6_ADDR_MAPPED) {
d83d8461f902c6 Arnaldo Carvalho de Melo 2005-12-13 213 u32 exthdrlen = icsk->icsk_ext_hdr_len;
^1da177e4c3f41 Linus Torvalds 2005-04-16 214 struct sockaddr_in sin;
^1da177e4c3f41 Linus Torvalds 2005-04-16 215
^1da177e4c3f41 Linus Torvalds 2005-04-16 216 SOCK_DEBUG(sk, "connect: ipv4 mapped\n");
^1da177e4c3f41 Linus Torvalds 2005-04-16 217
^1da177e4c3f41 Linus Torvalds 2005-04-16 218 if (__ipv6_only_sock(sk))
^1da177e4c3f41 Linus Torvalds 2005-04-16 219 return -ENETUNREACH;
^1da177e4c3f41 Linus Torvalds 2005-04-16 220
^1da177e4c3f41 Linus Torvalds 2005-04-16 221 sin.sin_family = AF_INET;
^1da177e4c3f41 Linus Torvalds 2005-04-16 222 sin.sin_port = usin->sin6_port;
^1da177e4c3f41 Linus Torvalds 2005-04-16 223 sin.sin_addr.s_addr = usin->sin6_addr.s6_addr32[3];
^1da177e4c3f41 Linus Torvalds 2005-04-16 224
d83d8461f902c6 Arnaldo Carvalho de Melo 2005-12-13 225 icsk->icsk_af_ops = &ipv6_mapped;
^1da177e4c3f41 Linus Torvalds 2005-04-16 226 sk->sk_backlog_rcv = tcp_v4_do_rcv;
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 227 #ifdef CONFIG_TCP_MD5SIG
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 228 tp->af_specific = &tcp_sock_ipv6_mapped_specific;
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 229 #endif
^1da177e4c3f41 Linus Torvalds 2005-04-16 230
^1da177e4c3f41 Linus Torvalds 2005-04-16 231 err = tcp_v4_connect(sk, (struct sockaddr *)&sin, sizeof(sin));
^1da177e4c3f41 Linus Torvalds 2005-04-16 232
^1da177e4c3f41 Linus Torvalds 2005-04-16 233 if (err) {
d83d8461f902c6 Arnaldo Carvalho de Melo 2005-12-13 234 icsk->icsk_ext_hdr_len = exthdrlen;
d83d8461f902c6 Arnaldo Carvalho de Melo 2005-12-13 235 icsk->icsk_af_ops = &ipv6_specific;
^1da177e4c3f41 Linus Torvalds 2005-04-16 236 sk->sk_backlog_rcv = tcp_v6_do_rcv;
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 237 #ifdef CONFIG_TCP_MD5SIG
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 238 tp->af_specific = &tcp_sock_ipv6_specific;
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 239 #endif
^1da177e4c3f41 Linus Torvalds 2005-04-16 240 goto failure;
^1da177e4c3f41 Linus Torvalds 2005-04-16 241 } else {
c720c7e8383aff Eric Dumazet 2009-10-15 242 ipv6_addr_set_v4mapped(inet->inet_saddr, &np->saddr);
c720c7e8383aff Eric Dumazet 2009-10-15 243 ipv6_addr_set_v4mapped(inet->inet_rcv_saddr,
efe4208f47f907 Eric Dumazet 2013-10-03 244 &sk->sk_v6_rcv_saddr);
^1da177e4c3f41 Linus Torvalds 2005-04-16 245 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 246
^1da177e4c3f41 Linus Torvalds 2005-04-16 247 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 248 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 249
efe4208f47f907 Eric Dumazet 2013-10-03 250 if (!ipv6_addr_any(&sk->sk_v6_rcv_saddr))
efe4208f47f907 Eric Dumazet 2013-10-03 251 saddr = &sk->sk_v6_rcv_saddr;
^1da177e4c3f41 Linus Torvalds 2005-04-16 252
4c9483b2fb5d25 David S. Miller 2011-03-12 253 fl6.flowi6_proto = IPPROTO_TCP;
efe4208f47f907 Eric Dumazet 2013-10-03 254 fl6.daddr = sk->sk_v6_daddr;
4e3fd7a06dc20b Alexey Dobriyan 2011-11-21 255 fl6.saddr = saddr ? *saddr : np->saddr;
4c9483b2fb5d25 David S. Miller 2011-03-12 256 fl6.flowi6_oif = sk->sk_bound_dev_if;
4c9483b2fb5d25 David S. Miller 2011-03-12 257 fl6.flowi6_mark = sk->sk_mark;
1958b856c1a59c David S. Miller 2011-03-12 258 fl6.fl6_dport = usin->sin6_port;
1958b856c1a59c David S. Miller 2011-03-12 259 fl6.fl6_sport = inet->inet_sport;
04c0eace816f2b Lorenzo Colitti 2016-11-04 260 fl6.flowi6_uid = sk->sk_uid;
^1da177e4c3f41 Linus Torvalds 2005-04-16 261
aa498f1e3fa305 Eric Dumazet 2015-11-29 262 opt = rcu_dereference_protected(np->opt, sock_owned_by_user(sk));
aa498f1e3fa305 Eric Dumazet 2015-11-29 263 final_p = fl6_update_dst(&fl6, opt, &final);
^1da177e4c3f41 Linus Torvalds 2005-04-16 264
4c9483b2fb5d25 David S. Miller 2011-03-12 265 security_sk_classify_flow(sk, flowi6_to_flowi(&fl6));
beb8d13bed80f8 Venkat Yekkirala 2006-08-04 266
0e0d44ab427554 Steffen Klassert 2013-08-28 267 dst = ip6_dst_lookup_flow(sk, &fl6, final_p);
68d0c6d34d586a David S. Miller 2011-03-01 268 if (IS_ERR(dst)) {
68d0c6d34d586a David S. Miller 2011-03-01 269 err = PTR_ERR(dst);
^1da177e4c3f41 Linus Torvalds 2005-04-16 270 goto failure;
14e50e57aedb2a David S. Miller 2007-05-24 271 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 272
^1da177e4c3f41 Linus Torvalds 2005-04-16 273 if (saddr == NULL) {
4c9483b2fb5d25 David S. Miller 2011-03-12 274 saddr = &fl6.saddr;
efe4208f47f907 Eric Dumazet 2013-10-03 275 sk->sk_v6_rcv_saddr = *saddr;
^1da177e4c3f41 Linus Torvalds 2005-04-16 276 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 277
^1da177e4c3f41 Linus Torvalds 2005-04-16 278 /* set the source address */
4e3fd7a06dc20b Alexey Dobriyan 2011-11-21 279 np->saddr = *saddr;
c720c7e8383aff Eric Dumazet 2009-10-15 280 inet->inet_rcv_saddr = LOOPBACK4_IPV6;
^1da177e4c3f41 Linus Torvalds 2005-04-16 281
f83ef8c0b58dac Herbert Xu 2006-06-30 282 sk->sk_gso_type = SKB_GSO_TCPV6;
8e1ef0a95b87e8 YOSHIFUJI Hideaki 2006-08-29 283 __ip6_dst_store(sk, dst, NULL, NULL);
^1da177e4c3f41 Linus Torvalds 2005-04-16 284
493f377d6dd56f David S. Miller 2010-12-02 285 rt = (struct rt6_info *) dst;
493f377d6dd56f David S. Miller 2010-12-02 286 if (tcp_death_row.sysctl_tw_recycle &&
493f377d6dd56f David S. Miller 2010-12-02 287 !tp->rx_opt.ts_recent_stamp &&
5d83c05d2723a7 Martin KaFai Lau 2015-05-22 288 ipv6_addr_equal(&fl6.daddr, &sk->sk_v6_daddr))
81166dd6fa8eb7 David S. Miller 2012-07-10 289 tcp_fetch_timewait_stamp(sk, dst);
493f377d6dd56f David S. Miller 2010-12-02 290
d83d8461f902c6 Arnaldo Carvalho de Melo 2005-12-13 291 icsk->icsk_ext_hdr_len = 0;
aa498f1e3fa305 Eric Dumazet 2015-11-29 292 if (opt)
aa498f1e3fa305 Eric Dumazet 2015-11-29 293 icsk->icsk_ext_hdr_len = opt->opt_flen +
aa498f1e3fa305 Eric Dumazet 2015-11-29 294 opt->opt_nflen;
^1da177e4c3f41 Linus Torvalds 2005-04-16 295
^1da177e4c3f41 Linus Torvalds 2005-04-16 296 tp->rx_opt.mss_clamp = IPV6_MIN_MTU - sizeof(struct tcphdr) - sizeof(struct ipv6hdr);
^1da177e4c3f41 Linus Torvalds 2005-04-16 297
c720c7e8383aff Eric Dumazet 2009-10-15 298 inet->inet_dport = usin->sin6_port;
^1da177e4c3f41 Linus Torvalds 2005-04-16 299
^1da177e4c3f41 Linus Torvalds 2005-04-16 300 tcp_set_state(sk, TCP_SYN_SENT);
d8313f5ca2b1f8 Arnaldo Carvalho de Melo 2005-12-13 301 err = inet6_hash_connect(&tcp_death_row, sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 302 if (err)
^1da177e4c3f41 Linus Torvalds 2005-04-16 303 goto late_failure;
^1da177e4c3f41 Linus Torvalds 2005-04-16 304
9e7ceb060754f1 Sathya Perla 2014-10-22 305 ip6_set_txhash(sk);
9e7ceb060754f1 Sathya Perla 2014-10-22 306
2b9164771efe19 Andrey Vagin 2012-11-22 307 if (!tp->write_seq && likely(!tp->repair))
^1da177e4c3f41 Linus Torvalds 2005-04-16 308 tp->write_seq = secure_tcpv6_sequence_number(np->saddr.s6_addr32,
efe4208f47f907 Eric Dumazet 2013-10-03 309 sk->sk_v6_daddr.s6_addr32,
c720c7e8383aff Eric Dumazet 2009-10-15 310 inet->inet_sport,
c720c7e8383aff Eric Dumazet 2009-10-15 311 inet->inet_dport);
^1da177e4c3f41 Linus Torvalds 2005-04-16 312
^1da177e4c3f41 Linus Torvalds 2005-04-16 313 err = tcp_connect(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 314 if (err)
^1da177e4c3f41 Linus Torvalds 2005-04-16 315 goto late_failure;
^1da177e4c3f41 Linus Torvalds 2005-04-16 316
^1da177e4c3f41 Linus Torvalds 2005-04-16 317 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 318
^1da177e4c3f41 Linus Torvalds 2005-04-16 319 late_failure:
^1da177e4c3f41 Linus Torvalds 2005-04-16 320 tcp_set_state(sk, TCP_CLOSE);
^1da177e4c3f41 Linus Torvalds 2005-04-16 321 __sk_dst_reset(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 322 failure:
c720c7e8383aff Eric Dumazet 2009-10-15 323 inet->inet_dport = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 324 sk->sk_route_caps = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 325 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 326 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 327
:::::: The code at line 137 was first introduced by commit
:::::: 493f377d6dd56f4e98b198d637fe714ab124681b tcp: Add timewait recycling bits to ipv6 connect code.
:::::: TO: David S. Miller <davem(a)davemloft.net>
:::::: CC: David S. Miller <davem(a)davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[lkp] [+2050 bytes kernel size regression] [i386-tinyconfig] [04b63697eb] vfs: introduce new file extent swap ioctl
by kbuild test robot
FYI, we noticed a +2050 bytes kernel size regression due to commit:
commit: 04b63697eb47c544e55c73d906148160ebff2042 (vfs: introduce new file extent swap ioctl)
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git repair-metadata-atomically
Details as below (size data is obtained by `nm --size-sort vmlinux`):
650947bb: xfs: fix xfs_reflink_remap_prep calling conventions
04b63697: vfs: introduce new file extent swap ioctl
+------------------------------------------+----------+----------+-------+
| symbol | 650947bb | 04b63697 | delta |
+------------------------------------------+----------+----------+-------+
| bzImage | 439648 | 440736 | 1088 |
| nm.T.generic_swap_file_range_checks | 0 | 739 | 739 |
| nm.T.generic_swap_file_range_prep | 0 | 572 | 572 |
| nm.T.do_swap_file_range | 0 | 190 | 190 |
| nm.T.generic_swap_file_range_check_fresh | 0 | 156 | 156 |
| nm.t.ioctl_file_swap_range | 0 | 139 | 139 |
| nm.t.swap_range_verify_area | 0 | 93 | 93 |
| nm.T.vfs_swap_file_range | 0 | 44 | 44 |
| nm.T.ksys_ioctl | 1427 | 1457 | 30 |
| nm.r.bad_file_ops | 128 | 132 | 4 |
| nm.R.def_blk_fops | 128 | 132 | 4 |
| nm.R.def_chr_fops | 128 | 132 | 4 |
| nm.r.empty_dir_operations | 128 | 132 | 4 |
| nm.r.empty_fops | 128 | 132 | 4 |
| nm.R.fscontext_fops | 128 | 132 | 4 |
| nm.r.full_fops | 128 | 132 | 4 |
| nm.R.generic_ro_fops | 128 | 132 | 4 |
| nm.r.memory_fops | 128 | 132 | 4 |
| nm.r.misc_fops | 128 | 132 | 4 |
| nm.r.no_open_fops | 128 | 132 | 4 |
| nm.r.ns_file_operations | 128 | 132 | 4 |
| nm.r.null_fops | 128 | 132 | 4 |
| nm.r.perf_fops | 128 | 132 | 4 |
| nm.R.pidfd_fops | 128 | 132 | 4 |
| nm.R.pipefifo_fops | 128 | 132 | 4 |
| nm.R.ramfs_file_operations | 128 | 132 | 4 |
| nm.R.random_fops | 128 | 132 | 4 |
| nm.R.simple_dir_operations | 128 | 132 | 4 |
| nm.R.urandom_fops | 128 | 132 | 4 |
| nm.r.zero_fops | 128 | 132 | 4 |
| nm.T.vfs_fadvise | 48 | 51 | 3 |
+------------------------------------------+----------+----------+-------+
Thanks,
Kbuild test robot
2 years, 4 months
[sashal-linux-stable:queue-5.4 50/53] check.c:80:9: error: 'func_for_each_insn' macro redefined
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-5.4
head: 0619813532a0bed495354f3b5621a6c16c1f5c1c
commit: 5d17569c4b792bc67cf56ff43d0cbbbb5c58effb [50/53] objtool: Rename func_for_each_insn_all()
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 5d17569c4b792bc67cf56ff43d0cbbbb5c58effb
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> check.c:80:9: error: 'func_for_each_insn' macro redefined [-Werror,-Wmacro-redefined]
#define func_for_each_insn(file, func, insn) ^
check.c:75:9: note: previous definition is here
#define func_for_each_insn(file, func, insn) ^
1 error generated.
mv: cannot stat 'tools/objtool/.check.o.tmp': No such file or directory
make[4]: *** [tools/build/Makefile.build:96: tools/objtool/check.o] Error 1
make[4]: Target '__build' not remade because of errors.
make[3]: *** [Makefile:46: tools/objtool/objtool-in.o] Error 2
make[3]: Target 'all' not remade because of errors.
make[2]: *** [Makefile:67: objtool] Error 2
make[1]: *** [Makefile:1807: tools/objtool] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:179: sub-make] Error 2
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [PATCH v2 5/7] ASoC: soc-link: add snd_soc_link_compr_startup()
by kbuild test robot
Hi Kuninori,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on next-20200519]
[cannot apply to sound/for-next v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Kuninori-Morimoto/ASoC-add-soc-l...
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: parisc-randconfig-r011-20200521 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/parisc/include/asm/io.h:6,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from arch/parisc/include/asm/hardirq.h:13,
from include/linux/hardirq.h:9,
from include/linux/interrupt.h:11,
from include/sound/soc.h:18,
from sound/soc/soc-link.c:8:
include/asm-generic/pgtable.h: In function 'pte_clear_not_present_full':
arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
96 | pte_t old_pte; | ^~~~~~~
arch/parisc/include/asm/pgtable.h:322:34: note: in expansion of macro 'set_pte_at'
322 | #define pte_clear(mm, addr, xp) set_pte_at(mm, addr, xp, __pte(0))
| ^~~~~~~~~~
include/asm-generic/pgtable.h:202:2: note: in expansion of macro 'pte_clear'
202 | pte_clear(mm, address, ptep);
| ^~~~~~~~~
include/asm-generic/pgtable.h: In function '__ptep_modify_prot_commit':
arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
96 | pte_t old_pte; | ^~~~~~~
include/asm-generic/pgtable.h:641:2: note: in expansion of macro 'set_pte_at'
641 | set_pte_at(vma->vm_mm, addr, ptep, pte);
| ^~~~~~~~~~
sound/soc/soc-link.c: At top level:
sound/soc/soc-link.c:28:5: warning: no previous prototype for 'snd_soc_link_init' [-Wmissing-prototypes]
28 | int snd_soc_link_init(struct snd_soc_pcm_runtime *rtd)
| ^~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:38:5: warning: no previous prototype for 'snd_soc_link_be_hw_params_fixup' [-Wmissing-prototypes]
38 | int snd_soc_link_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:49:5: warning: no previous prototype for 'snd_soc_link_startup' [-Wmissing-prototypes]
49 | int snd_soc_link_startup(struct snd_pcm_substream *substream)
| ^~~~~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:61:6: warning: no previous prototype for 'snd_soc_link_shutdown' [-Wmissing-prototypes]
61 | void snd_soc_link_shutdown(struct snd_pcm_substream *substream)
| ^~~~~~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:70:5: warning: no previous prototype for 'snd_soc_link_prepare' [-Wmissing-prototypes]
70 | int snd_soc_link_prepare(struct snd_pcm_substream *substream)
| ^~~~~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:82:5: warning: no previous prototype for 'snd_soc_link_hw_params' [-Wmissing-prototypes]
82 | int snd_soc_link_hw_params(struct snd_pcm_substream *substream,
| ^~~~~~~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:95:6: warning: no previous prototype for 'snd_soc_link_hw_free' [-Wmissing-prototypes]
95 | void snd_soc_link_hw_free(struct snd_pcm_substream *substream)
| ^~~~~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:104:5: warning: no previous prototype for 'snd_soc_link_trigger' [-Wmissing-prototypes]
104 | int snd_soc_link_trigger(struct snd_pcm_substream *substream, int cmd)
| ^~~~~~~~~~~~~~~~~~~~
<< from sound/soc/soc-link.c:8:
>> sound/soc/soc-link.c:116:5: warning: no previous prototype for 'snd_soc_link_compr_startup' [-Wmissing-prototypes]
116 | int snd_soc_link_compr_startup(struct snd_compr_stream *cstream)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/snd_soc_link_compr_startup +116 sound/soc/soc-link.c
115
> 116 int snd_soc_link_compr_startup(struct snd_compr_stream *cstream)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[dsahern-linux:xdp/devmap-prog 2/4] net/core/dev.c:5420:8: error: implicit declaration of function 'dev_map_can_have_prog'
by kbuild test robot
tree: https://github.com/dsahern/linux xdp/devmap-prog
head: b29da7596f8eaf356dea9b80b5271d50a2492cb7
commit: b3250f63529680518242eeaf9b12f3f97d134cdc [2/4] bpf: Add support to attach bpf program to a devmap
config: x86_64-defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout b3250f63529680518242eeaf9b12f3f97d134cdc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> net/core/dev.c:5420:8: error: implicit declaration of function 'dev_map_can_have_prog' [-Werror,-Wimplicit-function-declaration]
if (dev_map_can_have_prog(new->aux->used_maps[i]))
^
1 error generated.
vim +/dev_map_can_have_prog +5420 net/core/dev.c
5406
5407 static int generic_xdp_install(struct net_device *dev, struct netdev_bpf *xdp)
5408 {
5409 struct bpf_prog *old = rtnl_dereference(dev->xdp_prog);
5410 struct bpf_prog *new = xdp->prog;
5411 int ret = 0;
5412
5413 if (new) {
5414 u32 i;
5415
5416 /* generic XDP does not work with DEVMAPs that can
5417 * have a bpf_prog installed
5418 */
5419 for (i = 0; i < new->aux->used_map_cnt; i++) {
> 5420 if (dev_map_can_have_prog(new->aux->used_maps[i]))
5421 return -EINVAL;
5422 }
5423 }
5424
5425 switch (xdp->command) {
5426 case XDP_SETUP_PROG:
5427 rcu_assign_pointer(dev->xdp_prog, new);
5428 if (old)
5429 bpf_prog_put(old);
5430
5431 if (old && !new) {
5432 static_branch_dec(&generic_xdp_needed_key);
5433 } else if (new && !old) {
5434 static_branch_inc(&generic_xdp_needed_key);
5435 dev_disable_lro(dev);
5436 dev_disable_gro_hw(dev);
5437 }
5438 break;
5439
5440 case XDP_QUERY_PROG:
5441 xdp->prog_id = old ? old->aux->id : 0;
5442 break;
5443
5444 default:
5445 ret = -EINVAL;
5446 break;
5447 }
5448
5449 return ret;
5450 }
5451
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [PATCH net-next 1/2] flow_dissector: Parse multiple MPLS Label Stack Entries
by kbuild test robot
Hi Guillaume,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master sparc-next/master linus/master v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Guillaume-Nault/flow_dissector-c...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4f65e2f483b6f764c15094d14dd53dda048a4048
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-193-gb8fad4bc-dirty
# save the attached .config to linux build tree
make C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/net/ethernet/netronome/nfp/flower/match.c:100:26: sparse: sparse: no member 'mpls_label' in struct flow_dissector_key_mpls
drivers/net/ethernet/netronome/nfp/flower/match.c:100:26: sparse: sparse: no member 'mpls_label' in struct flow_dissector_key_mpls
>> drivers/net/ethernet/netronome/nfp/flower/match.c:100:26: sparse: sparse: cast from unknown type
drivers/net/ethernet/netronome/nfp/flower/match.c:101:26: sparse: sparse: no member 'mpls_tc' in struct flow_dissector_key_mpls
drivers/net/ethernet/netronome/nfp/flower/match.c:101:26: sparse: sparse: no member 'mpls_tc' in struct flow_dissector_key_mpls
drivers/net/ethernet/netronome/nfp/flower/match.c:101:26: sparse: sparse: cast from unknown type
>> drivers/net/ethernet/netronome/nfp/flower/match.c:100:85: sparse: sparse: incompatible types for operation (|):
>> drivers/net/ethernet/netronome/nfp/flower/match.c:100:85: sparse: void
>> drivers/net/ethernet/netronome/nfp/flower/match.c:100:85: sparse: void
drivers/net/ethernet/netronome/nfp/flower/match.c:102:26: sparse: sparse: no member 'mpls_bos' in struct flow_dissector_key_mpls
drivers/net/ethernet/netronome/nfp/flower/match.c:102:26: sparse: sparse: no member 'mpls_bos' in struct flow_dissector_key_mpls
drivers/net/ethernet/netronome/nfp/flower/match.c:102:26: sparse: sparse: cast from unknown type
drivers/net/ethernet/netronome/nfp/flower/match.c:105:26: sparse: sparse: no member 'mpls_label' in struct flow_dissector_key_mpls
drivers/net/ethernet/netronome/nfp/flower/match.c:105:26: sparse: sparse: no member 'mpls_label' in struct flow_dissector_key_mpls
drivers/net/ethernet/netronome/nfp/flower/match.c:105:26: sparse: sparse: cast from unknown type
drivers/net/ethernet/netronome/nfp/flower/match.c:106:26: sparse: sparse: no member 'mpls_tc' in struct flow_dissector_key_mpls
drivers/net/ethernet/netronome/nfp/flower/match.c:106:26: sparse: sparse: no member 'mpls_tc' in struct flow_dissector_key_mpls
drivers/net/ethernet/netronome/nfp/flower/match.c:106:26: sparse: sparse: cast from unknown type
drivers/net/ethernet/netronome/nfp/flower/match.c:105:86: sparse: sparse: incompatible types for operation (|):
drivers/net/ethernet/netronome/nfp/flower/match.c:105:86: sparse: void
drivers/net/ethernet/netronome/nfp/flower/match.c:105:86: sparse: void
drivers/net/ethernet/netronome/nfp/flower/match.c:107:26: sparse: sparse: no member 'mpls_bos' in struct flow_dissector_key_mpls
drivers/net/ethernet/netronome/nfp/flower/match.c:107:26: sparse: sparse: no member 'mpls_bos' in struct flow_dissector_key_mpls
drivers/net/ethernet/netronome/nfp/flower/match.c:107:26: sparse: sparse: cast from unknown type
--
net/core/flow_dissector.c:256:43: sparse: sparse: restricted __be16 degrades to integer
>> net/core/flow_dissector.c:514:34: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] keyid @@ got unsignrestricted __be32 [usertype] keyid @@
>> net/core/flow_dissector.c:514:34: sparse: expected restricted __be32 [usertype] keyid
>> net/core/flow_dissector.c:514:34: sparse: got unsigned int [assigned] [usertype] label
vim +514 net/core/flow_dissector.c
463
464 static enum flow_dissect_ret
465 __skb_flow_dissect_mpls(const struct sk_buff *skb,
466 struct flow_dissector *flow_dissector,
467 void *target_container, void *data, int nhoff, int hlen,
468 int lse_index, bool *entropy_label)
469 {
470 struct mpls_label *hdr, _hdr;
471 u32 entry, label, bos;
472
473 if (!dissector_uses_key(flow_dissector,
474 FLOW_DISSECTOR_KEY_MPLS_ENTROPY) &&
475 !dissector_uses_key(flow_dissector, FLOW_DISSECTOR_KEY_MPLS))
476 return FLOW_DISSECT_RET_OUT_GOOD;
477
478 if (lse_index >= FLOW_DIS_MPLS_MAX)
479 return FLOW_DISSECT_RET_OUT_GOOD;
480
481 hdr = __skb_header_pointer(skb, nhoff, sizeof(_hdr), data,
482 hlen, &_hdr);
483 if (!hdr)
484 return FLOW_DISSECT_RET_OUT_BAD;
485
486 entry = ntohl(hdr->entry);
487 label = (entry & MPLS_LS_LABEL_MASK) >> MPLS_LS_LABEL_SHIFT;
488 bos = (entry & MPLS_LS_S_MASK) >> MPLS_LS_S_SHIFT;
489
490 if (dissector_uses_key(flow_dissector, FLOW_DISSECTOR_KEY_MPLS)) {
491 struct flow_dissector_key_mpls *key_mpls;
492 struct flow_dissector_mpls_lse *lse;
493
494 key_mpls = skb_flow_dissector_target(flow_dissector,
495 FLOW_DISSECTOR_KEY_MPLS,
496 target_container);
497 lse = &key_mpls->ls[lse_index];
498
499 lse->mpls_ttl = (entry & MPLS_LS_TTL_MASK) >> MPLS_LS_TTL_SHIFT;
500 lse->mpls_bos = bos;
501 lse->mpls_tc = (entry & MPLS_LS_TC_MASK) >> MPLS_LS_TC_SHIFT;
502 lse->mpls_label = label;
503 dissector_set_mpls_lse(key_mpls, lse_index);
504 }
505
506 if (*entropy_label &&
507 dissector_uses_key(flow_dissector,
508 FLOW_DISSECTOR_KEY_MPLS_ENTROPY)) {
509 struct flow_dissector_key_keyid *key_keyid;
510
511 key_keyid = skb_flow_dissector_target(flow_dissector,
512 FLOW_DISSECTOR_KEY_MPLS_ENTROPY,
513 target_container);
> 514 key_keyid->keyid = label;
515 }
516
517 *entropy_label = label == MPLS_LABEL_ENTROPY;
518
519 return bos ? FLOW_DISSECT_RET_OUT_GOOD : FLOW_DISSECT_RET_PROTO_AGAIN;
520 }
521
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[sashal-linux-stable:queue-5.4 50/53] check.c:55:28: error: 'next_insn_same_func' defined but not used
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-5.4
head: 0619813532a0bed495354f3b5621a6c16c1f5c1c
commit: 5d17569c4b792bc67cf56ff43d0cbbbb5c58effb [50/53] objtool: Rename func_for_each_insn_all()
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
git checkout 5d17569c4b792bc67cf56ff43d0cbbbb5c58effb
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
check.c:80:0: error: "func_for_each_insn" redefined [-Werror]
#define func_for_each_insn(file, func, insn)
check.c:75:0: note: this is the location of the previous definition
#define func_for_each_insn(file, func, insn)
>> check.c:55:28: error: 'next_insn_same_func' defined but not used [-Werror=unused-function]
static struct instruction *next_insn_same_func(struct objtool_file *file,
^~~~~~~~~~~~~~~~~~~
scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
cc1: all warnings being treated as errors
mv: cannot stat 'tools/objtool/.check.o.tmp': No such file or directory
make[4]: *** [tools/build/Makefile.build:96: tools/objtool/check.o] Error 1
make[4]: Target '__build' not remade because of errors.
make[3]: *** [Makefile:46: tools/objtool/objtool-in.o] Error 2
make[3]: Target 'all' not remade because of errors.
make[2]: *** [Makefile:67: objtool] Error 2
make[1]: *** [Makefile:1807: tools/objtool] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:179: sub-make] Error 2
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months