Re: [PATCH v2 4/7] ASoC: soc-link: add snd_soc_link_be_hw_params_fixup()
by kbuild test robot
Hi Kuninori,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on next-20200519]
[cannot apply to sound/for-next v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Kuninori-Morimoto/ASoC-add-soc-l...
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: parisc-randconfig-r011-20200521 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/parisc/include/asm/io.h:6,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from arch/parisc/include/asm/hardirq.h:13,
from include/linux/hardirq.h:9,
from include/linux/interrupt.h:11,
from include/sound/soc.h:18,
from sound/soc/soc-link.c:8:
include/asm-generic/pgtable.h: In function 'pte_clear_not_present_full':
arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
96 | pte_t old_pte; | ^~~~~~~
arch/parisc/include/asm/pgtable.h:322:34: note: in expansion of macro 'set_pte_at'
322 | #define pte_clear(mm, addr, xp) set_pte_at(mm, addr, xp, __pte(0))
| ^~~~~~~~~~
include/asm-generic/pgtable.h:202:2: note: in expansion of macro 'pte_clear'
202 | pte_clear(mm, address, ptep);
| ^~~~~~~~~
include/asm-generic/pgtable.h: In function '__ptep_modify_prot_commit':
arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
96 | pte_t old_pte; | ^~~~~~~
include/asm-generic/pgtable.h:641:2: note: in expansion of macro 'set_pte_at'
641 | set_pte_at(vma->vm_mm, addr, ptep, pte);
| ^~~~~~~~~~
sound/soc/soc-link.c: At top level:
sound/soc/soc-link.c:28:5: warning: no previous prototype for 'snd_soc_link_init' [-Wmissing-prototypes]
28 | int snd_soc_link_init(struct snd_soc_pcm_runtime *rtd)
| ^~~~~~~~~~~~~~~~~
<< from sound/soc/soc-link.c:8:
>> sound/soc/soc-link.c:38:5: warning: no previous prototype for 'snd_soc_link_be_hw_params_fixup' [-Wmissing-prototypes]
38 | int snd_soc_link_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:49:5: warning: no previous prototype for 'snd_soc_link_startup' [-Wmissing-prototypes]
49 | int snd_soc_link_startup(struct snd_pcm_substream *substream)
| ^~~~~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:61:6: warning: no previous prototype for 'snd_soc_link_shutdown' [-Wmissing-prototypes]
61 | void snd_soc_link_shutdown(struct snd_pcm_substream *substream)
| ^~~~~~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:70:5: warning: no previous prototype for 'snd_soc_link_prepare' [-Wmissing-prototypes]
70 | int snd_soc_link_prepare(struct snd_pcm_substream *substream)
| ^~~~~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:82:5: warning: no previous prototype for 'snd_soc_link_hw_params' [-Wmissing-prototypes]
82 | int snd_soc_link_hw_params(struct snd_pcm_substream *substream,
| ^~~~~~~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:95:6: warning: no previous prototype for 'snd_soc_link_hw_free' [-Wmissing-prototypes]
95 | void snd_soc_link_hw_free(struct snd_pcm_substream *substream)
| ^~~~~~~~~~~~~~~~~~~~
sound/soc/soc-link.c:104:5: warning: no previous prototype for 'snd_soc_link_trigger' [-Wmissing-prototypes]
104 | int snd_soc_link_trigger(struct snd_pcm_substream *substream, int cmd)
| ^~~~~~~~~~~~~~~~~~~~
vim +/snd_soc_link_be_hw_params_fixup +38 sound/soc/soc-link.c
27
> 28 int snd_soc_link_init(struct snd_soc_pcm_runtime *rtd)
29 {
30 int ret = 0;
31
32 if (rtd->dai_link->init)
33 ret = rtd->dai_link->init(rtd);
34
35 return soc_link_ret(rtd, ret);
36 }
37
> 38 int snd_soc_link_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
39 struct snd_pcm_hw_params *params)
40 {
41 int ret = 0;
42
43 if (rtd->dai_link->be_hw_params_fixup)
44 ret = rtd->dai_link->be_hw_params_fixup(rtd, params);
45
46 return soc_link_ret(rtd, ret);
47 }
48
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[linux-next:master 10679/10701] arch/x86/mm/pgtable.c:427:2: warning: ISO C90 forbids variable length array 'u_pmds'
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
commit: 0e19fc1c40bd7516d5a30a459db4f49d48910847 [10679/10701] mm: consolidate pgd_index() and pgd_offset{_k}() definitions
config: i386-randconfig-r013-20200521 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
git checkout 0e19fc1c40bd7516d5a30a459db4f49d48910847
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
arch/x86/mm/pgtable.c: In function 'pgd_alloc':
>> arch/x86/mm/pgtable.c:427:2: warning: ISO C90 forbids variable length array 'u_pmds' [-Wvla]
pmd_t *u_pmds[MAX_PREALLOCATED_USER_PMDS];
^~~~~
>> arch/x86/mm/pgtable.c:428:2: warning: ISO C90 forbids variable length array 'pmds' [-Wvla]
pmd_t *pmds[MAX_PREALLOCATED_PMDS];
^~~~~
vim +/u_pmds +427 arch/x86/mm/pgtable.c
1db491f77b6ed0 Fenghua Yu 2015-01-15 423
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 424 pgd_t *pgd_alloc(struct mm_struct *mm)
1ec1fe73dfb711 Ingo Molnar 2008-03-19 425 {
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 426 pgd_t *pgd;
184d47f0fd3651 Kees Cook 2018-10-08 @427 pmd_t *u_pmds[MAX_PREALLOCATED_USER_PMDS];
184d47f0fd3651 Kees Cook 2018-10-08 @428 pmd_t *pmds[MAX_PREALLOCATED_PMDS];
1ec1fe73dfb711 Ingo Molnar 2008-03-19 429
1db491f77b6ed0 Fenghua Yu 2015-01-15 430 pgd = _pgd_alloc();
1ec1fe73dfb711 Ingo Molnar 2008-03-19 431
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 432 if (pgd == NULL)
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 433 goto out;
4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 434
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 435 mm->pgd = pgd;
4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 436
f59dbe9ca6707e Joerg Roedel 2018-07-18 437 if (preallocate_pmds(mm, pmds, PREALLOCATED_PMDS) != 0)
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 438 goto out_free_pgd;
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 439
f59dbe9ca6707e Joerg Roedel 2018-07-18 440 if (preallocate_pmds(mm, u_pmds, PREALLOCATED_USER_PMDS) != 0)
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 441 goto out_free_pmds;
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 442
f59dbe9ca6707e Joerg Roedel 2018-07-18 443 if (paravirt_pgd_alloc(mm) != 0)
f59dbe9ca6707e Joerg Roedel 2018-07-18 444 goto out_free_user_pmds;
f59dbe9ca6707e Joerg Roedel 2018-07-18 445
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 446 /*
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 447 * Make sure that pre-populating the pmds is atomic with
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 448 * respect to anything walking the pgd_list, so that they
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 449 * never see a partially populated pgd.
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 450 */
a79e53d85683c6 Andrea Arcangeli 2011-02-16 451 spin_lock(&pgd_lock);
4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 452
617d34d9e5d832 Jeremy Fitzhardinge 2010-09-21 453 pgd_ctor(mm, pgd);
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 454 pgd_prepopulate_pmd(mm, pgd, pmds);
f59dbe9ca6707e Joerg Roedel 2018-07-18 455 pgd_prepopulate_user_pmd(mm, pgd, u_pmds);
4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 456
a79e53d85683c6 Andrea Arcangeli 2011-02-16 457 spin_unlock(&pgd_lock);
4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 458
4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 459 return pgd;
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 460
f59dbe9ca6707e Joerg Roedel 2018-07-18 461 out_free_user_pmds:
f59dbe9ca6707e Joerg Roedel 2018-07-18 462 free_pmds(mm, u_pmds, PREALLOCATED_USER_PMDS);
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 463 out_free_pmds:
f59dbe9ca6707e Joerg Roedel 2018-07-18 464 free_pmds(mm, pmds, PREALLOCATED_PMDS);
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 465 out_free_pgd:
1db491f77b6ed0 Fenghua Yu 2015-01-15 466 _pgd_free(pgd);
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 467 out:
d8d5900ef8afc5 Jeremy Fitzhardinge 2008-06-25 468 return NULL;
4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 469 }
4f76cd382213b2 Jeremy Fitzhardinge 2008-03-17 470
:::::: The code at line 427 was first introduced by commit
:::::: 184d47f0fd365108bd06ab26cdb3450b716269fd x86/mm: Avoid VLA in pgd_alloc()
:::::: TO: Kees Cook <keescook(a)chromium.org>
:::::: CC: Ingo Molnar <mingo(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [PATCH v2 5/7] ASoC: soc-link: add snd_soc_link_compr_startup()
by kbuild test robot
Hi Kuninori,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on next-20200519]
[cannot apply to sound/for-next v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Kuninori-Morimoto/ASoC-add-soc-l...
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: x86_64-randconfig-r016-20200521 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
sound/soc/soc-link.c:28:5: warning: no previous prototype for function 'snd_soc_link_init' [-Wmissing-prototypes]
int snd_soc_link_init(struct snd_soc_pcm_runtime *rtd)
^
sound/soc/soc-link.c:28:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_init(struct snd_soc_pcm_runtime *rtd)
^
static
sound/soc/soc-link.c:38:5: warning: no previous prototype for function 'snd_soc_link_be_hw_params_fixup' [-Wmissing-prototypes]
int snd_soc_link_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
^
sound/soc/soc-link.c:38:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
^
static
sound/soc/soc-link.c:49:5: warning: no previous prototype for function 'snd_soc_link_startup' [-Wmissing-prototypes]
int snd_soc_link_startup(struct snd_pcm_substream *substream)
^
sound/soc/soc-link.c:49:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_startup(struct snd_pcm_substream *substream)
^
static
sound/soc/soc-link.c:61:6: warning: no previous prototype for function 'snd_soc_link_shutdown' [-Wmissing-prototypes]
void snd_soc_link_shutdown(struct snd_pcm_substream *substream)
^
sound/soc/soc-link.c:61:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void snd_soc_link_shutdown(struct snd_pcm_substream *substream)
^
static
sound/soc/soc-link.c:70:5: warning: no previous prototype for function 'snd_soc_link_prepare' [-Wmissing-prototypes]
int snd_soc_link_prepare(struct snd_pcm_substream *substream)
^
sound/soc/soc-link.c:70:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_prepare(struct snd_pcm_substream *substream)
^
static
sound/soc/soc-link.c:82:5: warning: no previous prototype for function 'snd_soc_link_hw_params' [-Wmissing-prototypes]
int snd_soc_link_hw_params(struct snd_pcm_substream *substream,
^
sound/soc/soc-link.c:82:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_hw_params(struct snd_pcm_substream *substream,
^
static
sound/soc/soc-link.c:95:6: warning: no previous prototype for function 'snd_soc_link_hw_free' [-Wmissing-prototypes]
void snd_soc_link_hw_free(struct snd_pcm_substream *substream)
^
sound/soc/soc-link.c:95:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void snd_soc_link_hw_free(struct snd_pcm_substream *substream)
^
static
sound/soc/soc-link.c:104:5: warning: no previous prototype for function 'snd_soc_link_trigger' [-Wmissing-prototypes]
int snd_soc_link_trigger(struct snd_pcm_substream *substream, int cmd)
^
sound/soc/soc-link.c:104:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_trigger(struct snd_pcm_substream *substream, int cmd)
^
static
>> sound/soc/soc-link.c:116:5: warning: no previous prototype for function 'snd_soc_link_compr_startup' [-Wmissing-prototypes]
int snd_soc_link_compr_startup(struct snd_compr_stream *cstream)
^
sound/soc/soc-link.c:116:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_compr_startup(struct snd_compr_stream *cstream)
^
static
9 warnings generated.
vim +/snd_soc_link_compr_startup +116 sound/soc/soc-link.c
115
> 116 int snd_soc_link_compr_startup(struct snd_compr_stream *cstream)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [PATCH v2 2/7] ASoC: soc-link: move soc_rtd_xxx()
by kbuild test robot
Hi Kuninori,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on next-20200519]
[cannot apply to sound/for-next v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Kuninori-Morimoto/ASoC-add-soc-l...
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: parisc-randconfig-r011-20200521 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/parisc/include/asm/io.h:6,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from arch/parisc/include/asm/hardirq.h:13,
from include/linux/hardirq.h:9,
from include/linux/interrupt.h:11,
from include/sound/soc.h:18,
from sound/soc/soc-link.c:8:
include/asm-generic/pgtable.h: In function 'pte_clear_not_present_full':
arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
96 | pte_t old_pte; | ^~~~~~~
arch/parisc/include/asm/pgtable.h:322:34: note: in expansion of macro 'set_pte_at'
322 | #define pte_clear(mm, addr, xp) set_pte_at(mm, addr, xp, __pte(0))
| ^~~~~~~~~~
include/asm-generic/pgtable.h:202:2: note: in expansion of macro 'pte_clear'
202 | pte_clear(mm, address, ptep);
| ^~~~~~~~~
include/asm-generic/pgtable.h: In function '__ptep_modify_prot_commit':
arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
96 | pte_t old_pte; | ^~~~~~~
include/asm-generic/pgtable.h:641:2: note: in expansion of macro 'set_pte_at'
641 | set_pte_at(vma->vm_mm, addr, ptep, pte);
| ^~~~~~~~~~
sound/soc/soc-link.c: At top level:
sound/soc/soc-link.c:28:5: warning: no previous prototype for 'snd_soc_link_init' [-Wmissing-prototypes]
28 | int snd_soc_link_init(struct snd_soc_pcm_runtime *rtd)
| ^~~~~~~~~~~~~~~~~
<< from sound/soc/soc-link.c:8:
>> sound/soc/soc-link.c:38:5: warning: no previous prototype for 'snd_soc_link_startup' [-Wmissing-prototypes]
38 | int snd_soc_link_startup(struct snd_soc_pcm_runtime *rtd,
| ^~~~~~~~~~~~~~~~~~~~
<< from sound/soc/soc-link.c:8:
>> sound/soc/soc-link.c:50:6: warning: no previous prototype for 'snd_soc_link_shutdown' [-Wmissing-prototypes]
50 | void snd_soc_link_shutdown(struct snd_soc_pcm_runtime *rtd,
| ^~~~~~~~~~~~~~~~~~~~~
<< from sound/soc/soc-link.c:8:
>> sound/soc/soc-link.c:58:5: warning: no previous prototype for 'snd_soc_link_prepare' [-Wmissing-prototypes]
58 | int snd_soc_link_prepare(struct snd_soc_pcm_runtime *rtd,
| ^~~~~~~~~~~~~~~~~~~~
<< from sound/soc/soc-link.c:8:
>> sound/soc/soc-link.c:70:5: warning: no previous prototype for 'snd_soc_link_hw_params' [-Wmissing-prototypes]
70 | int snd_soc_link_hw_params(struct snd_soc_pcm_runtime *rtd,
| ^~~~~~~~~~~~~~~~~~~~~~
<< from sound/soc/soc-link.c:8:
>> sound/soc/soc-link.c:83:6: warning: no previous prototype for 'snd_soc_link_hw_free' [-Wmissing-prototypes]
83 | void snd_soc_link_hw_free(struct snd_soc_pcm_runtime *rtd,
| ^~~~~~~~~~~~~~~~~~~~
<< from sound/soc/soc-link.c:8:
>> sound/soc/soc-link.c:91:5: warning: no previous prototype for 'snd_soc_link_trigger' [-Wmissing-prototypes]
91 | int snd_soc_link_trigger(struct snd_soc_pcm_runtime *rtd,
| ^~~~~~~~~~~~~~~~~~~~
vim +/snd_soc_link_startup +38 sound/soc/soc-link.c
37
> 38 int snd_soc_link_startup(struct snd_soc_pcm_runtime *rtd,
39 struct snd_pcm_substream *substream)
40 {
41 int ret = 0;
42
43 if (rtd->dai_link->ops &&
44 rtd->dai_link->ops->startup)
45 ret = rtd->dai_link->ops->startup(substream);
46
47 return soc_link_ret(rtd, ret);
48 }
49
> 50 void snd_soc_link_shutdown(struct snd_soc_pcm_runtime *rtd,
51 struct snd_pcm_substream *substream)
52 {
53 if (rtd->dai_link->ops &&
54 rtd->dai_link->ops->shutdown)
55 rtd->dai_link->ops->shutdown(substream);
56 }
57
> 58 int snd_soc_link_prepare(struct snd_soc_pcm_runtime *rtd,
59 struct snd_pcm_substream *substream)
60 {
61 int ret = 0;
62
63 if (rtd->dai_link->ops &&
64 rtd->dai_link->ops->prepare)
65 ret = rtd->dai_link->ops->prepare(substream);
66
67 return soc_link_ret(rtd, ret);
68 }
69
> 70 int snd_soc_link_hw_params(struct snd_soc_pcm_runtime *rtd,
71 struct snd_pcm_substream *substream,
72 struct snd_pcm_hw_params *params)
73 {
74 int ret = 0;
75
76 if (rtd->dai_link->ops &&
77 rtd->dai_link->ops->hw_params)
78 ret = rtd->dai_link->ops->hw_params(substream, params);
79
80 return soc_link_ret(rtd, ret);
81 }
82
> 83 void snd_soc_link_hw_free(struct snd_soc_pcm_runtime *rtd,
84 struct snd_pcm_substream *substream)
85 {
86 if (rtd->dai_link->ops &&
87 rtd->dai_link->ops->hw_free)
88 rtd->dai_link->ops->hw_free(substream);
89 }
90
> 91 int snd_soc_link_trigger(struct snd_soc_pcm_runtime *rtd,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [PATCH] smp: generic ipi_raise tracepoint
by kbuild test robot
Hi Wojciech,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Wojciech-Kudla/smp-generic-ipi_r...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 115a54162a6c0d0ef2aef25ebd0b61fc5e179ebe
config: arm64-randconfig-r002-20200520 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> aarch64-linux-gnu-ld: kernel/smp.o:include/trace/events/ipi.h:19: multiple definition of `__tracepoint_ipi_raise'; arch/arm64/kernel/smp.o:include/trace/events/ipi.h:19: first defined here
>> aarch64-linux-gnu-ld: kernel/smp.o:include/trace/events/ipi.h:64: multiple definition of `__tracepoint_ipi_entry'; arch/arm64/kernel/smp.o:include/trace/events/ipi.h:64: first defined here
>> aarch64-linux-gnu-ld: kernel/smp.o:include/trace/events/ipi.h:80: multiple definition of `__tracepoint_ipi_exit'; arch/arm64/kernel/smp.o:include/trace/events/ipi.h:80: first defined here
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[zen-kernel-zen-kernel:5.6/zen-sauce 4/26] arch/x86/kvm/mmu/mmu.c:2382:39: error: array subscript is above array bounds
by kbuild test robot
tree: https://github.com/zen-kernel/zen-kernel 5.6/zen-sauce
head: 28b9700a330bb5957c6ad7263095d148d5c35242
commit: 651fb09094936c829a4d430908c7e523e357cfbd [4/26] ZEN: Unrestrict CONFIG_OPTIMIZE_FOR_PERFORMANCE_O3
config: i386-randconfig-a005-20200521 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
git checkout 651fb09094936c829a4d430908c7e523e357cfbd
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
arch/x86/kvm/mmu/mmu.c: In function 'mmu_zap_unsync_children':
>> arch/x86/kvm/mmu/mmu.c:2382:39: error: array subscript is above array bounds [-Werror=array-bounds]
struct kvm_mmu_page *sp = pvec->page[n].sp;
~~~~~~~~~~^~~
arch/x86/kvm/mmu/mmu.c:2383:28: error: array subscript is above array bounds [-Werror=array-bounds]
unsigned idx = pvec->page[n].idx;
~~~~~~~~~~^~~
arch/x86/kvm/mmu/mmu.c: In function 'mmu_sync_children':
>> arch/x86/kvm/mmu/mmu.c:2382:39: error: array subscript is above array bounds [-Werror=array-bounds]
struct kvm_mmu_page *sp = pvec->page[n].sp;
~~~~~~~~~~^~~
arch/x86/kvm/mmu/mmu.c:2383:28: error: array subscript is above array bounds [-Werror=array-bounds]
unsigned idx = pvec->page[n].idx;
~~~~~~~~~~^~~
>> arch/x86/kvm/mmu/mmu.c:2382:39: error: array subscript is above array bounds [-Werror=array-bounds]
struct kvm_mmu_page *sp = pvec->page[n].sp;
~~~~~~~~~~^~~
arch/x86/kvm/mmu/mmu.c:2383:28: error: array subscript is above array bounds [-Werror=array-bounds]
unsigned idx = pvec->page[n].idx;
~~~~~~~~~~^~~
cc1: all warnings being treated as errors
--
drivers/base/devcon.c: In function 'device_connection_find':
>> drivers/base/devcon.c:180:9: warning: array subscript is below array bounds [-Warray-bounds]
dev = bus_find_device_by_name(bus, NULL, con->endpoint[ep]);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/base/devcon.c:180:9: warning: array subscript is below array bounds [-Warray-bounds]
dev = bus_find_device_by_name(bus, NULL, con->endpoint[ep]);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +2382 arch/x86/kvm/mmu/mmu.c
4731d4c7a07769c arch/x86/kvm/mmu.c Marcelo Tosatti 2008-09-23 2369
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2370 #define for_each_sp(pvec, sp, parents, i) \
0a47cd85833e565 arch/x86/kvm/mmu.c Paolo Bonzini 2016-02-23 2371 for (i = mmu_pages_first(&pvec, &parents); \
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2372 i < pvec.nr && ({ sp = pvec.page[i].sp; 1;}); \
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2373 i = mmu_pages_next(&pvec, &parents, i))
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2374
cded19f396bc3c9 arch/x86/kvm/mmu.c Hannes Eder 2009-02-21 2375 static int mmu_pages_next(struct kvm_mmu_pages *pvec,
cded19f396bc3c9 arch/x86/kvm/mmu.c Hannes Eder 2009-02-21 2376 struct mmu_page_path *parents,
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2377 int i)
4731d4c7a07769c arch/x86/kvm/mmu.c Marcelo Tosatti 2008-09-23 2378 {
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2379 int n;
4731d4c7a07769c arch/x86/kvm/mmu.c Marcelo Tosatti 2008-09-23 2380
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2381 for (n = i+1; n < pvec->nr; n++) {
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 @2382 struct kvm_mmu_page *sp = pvec->page[n].sp;
0a47cd85833e565 arch/x86/kvm/mmu.c Paolo Bonzini 2016-02-23 2383 unsigned idx = pvec->page[n].idx;
0a47cd85833e565 arch/x86/kvm/mmu.c Paolo Bonzini 2016-02-23 2384 int level = sp->role.level;
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2385
0a47cd85833e565 arch/x86/kvm/mmu.c Paolo Bonzini 2016-02-23 2386 parents->idx[level-1] = idx;
0a47cd85833e565 arch/x86/kvm/mmu.c Paolo Bonzini 2016-02-23 2387 if (level == PT_PAGE_TABLE_LEVEL)
0a47cd85833e565 arch/x86/kvm/mmu.c Paolo Bonzini 2016-02-23 2388 break;
4731d4c7a07769c arch/x86/kvm/mmu.c Marcelo Tosatti 2008-09-23 2389
0a47cd85833e565 arch/x86/kvm/mmu.c Paolo Bonzini 2016-02-23 2390 parents->parent[level-2] = sp;
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2391 }
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2392
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2393 return n;
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2394 }
60c8aec6e2c9923 arch/x86/kvm/mmu.c Marcelo Tosatti 2008-12-01 2395
:::::: The code at line 2382 was first introduced by commit
:::::: 60c8aec6e2c9923492dabbd6b67e34692bd26c20 KVM: MMU: use page array in unsync walk
:::::: TO: Marcelo Tosatti <mtosatti(a)redhat.com>
:::::: CC: Avi Kivity <avi(a)redhat.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [PATCH] xhci: Fix runtime PM imbalance on error
by kbuild test robot
Hi Dinghao,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Dinghao-Liu/xhci-Fix-runtime-PM-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/usb/host/xhci-histb.c: In function 'xhci_histb_probe':
>> drivers/usb/host/xhci-histb.c:243:18: error: expected ';' before 'hcd'
243 | goto disable_pm
| ^
| ;
244 |
245 | hcd = usb_create_hcd(driver, dev, dev_name(dev));
| ~~~
vim +243 drivers/usb/host/xhci-histb.c
195
196 static struct hc_driver __read_mostly xhci_histb_hc_driver;
197 static int xhci_histb_probe(struct platform_device *pdev)
198 {
199 struct device *dev = &pdev->dev;
200 struct xhci_hcd_histb *histb;
201 const struct hc_driver *driver;
202 struct usb_hcd *hcd;
203 struct xhci_hcd *xhci;
204 struct resource *res;
205 int irq;
206 int ret = -ENODEV;
207
208 if (usb_disabled())
209 return -ENODEV;
210
211 driver = &xhci_histb_hc_driver;
212 histb = devm_kzalloc(dev, sizeof(*histb), GFP_KERNEL);
213 if (!histb)
214 return -ENOMEM;
215
216 histb->dev = dev;
217
218 irq = platform_get_irq(pdev, 0);
219 if (irq < 0)
220 return irq;
221
222 histb->ctrl = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
223 if (IS_ERR(histb->ctrl))
224 return PTR_ERR(histb->ctrl);
225
226 ret = xhci_histb_clks_get(histb);
227 if (ret)
228 return ret;
229
230 histb->soft_reset = devm_reset_control_get(dev, "soft");
231 if (IS_ERR(histb->soft_reset)) {
232 dev_err(dev, "failed to get soft reset\n");
233 return PTR_ERR(histb->soft_reset);
234 }
235
236 pm_runtime_enable(dev);
237 pm_runtime_get_sync(dev);
238 device_enable_async_suspend(dev);
239
240 /* Initialize dma_mask and coherent_dma_mask to 32-bits */
241 ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32));
242 if (ret)
> 243 goto disable_pm
244
245 hcd = usb_create_hcd(driver, dev, dev_name(dev));
246 if (!hcd) {
247 ret = -ENOMEM;
248 goto disable_pm;
249 }
250
251 hcd->regs = histb->ctrl;
252 hcd->rsrc_start = res->start;
253 hcd->rsrc_len = resource_size(res);
254
255 histb->hcd = hcd;
256 dev_set_drvdata(hcd->self.controller, histb);
257
258 ret = xhci_histb_host_enable(histb);
259 if (ret)
260 goto put_hcd;
261
262 xhci = hcd_to_xhci(hcd);
263
264 device_wakeup_enable(hcd->self.controller);
265
266 xhci->main_hcd = hcd;
267 xhci->shared_hcd = usb_create_shared_hcd(driver, dev, dev_name(dev),
268 hcd);
269 if (!xhci->shared_hcd) {
270 ret = -ENOMEM;
271 goto disable_host;
272 }
273
274 if (device_property_read_bool(dev, "usb2-lpm-disable"))
275 xhci->quirks |= XHCI_HW_LPM_DISABLE;
276
277 if (device_property_read_bool(dev, "usb3-lpm-capable"))
278 xhci->quirks |= XHCI_LPM_SUPPORT;
279
280 /* imod_interval is the interrupt moderation value in nanoseconds. */
281 xhci->imod_interval = 40000;
282 device_property_read_u32(dev, "imod-interval-ns",
283 &xhci->imod_interval);
284
285 ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
286 if (ret)
287 goto put_usb3_hcd;
288
289 if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
290 xhci->shared_hcd->can_do_streams = 1;
291
292 ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED);
293 if (ret)
294 goto dealloc_usb2_hcd;
295
296 device_enable_async_suspend(dev);
297 pm_runtime_put_noidle(dev);
298
299 /*
300 * Prevent runtime pm from being on as default, users should enable
301 * runtime pm using power/control in sysfs.
302 */
303 pm_runtime_forbid(dev);
304
305 return 0;
306
307 dealloc_usb2_hcd:
308 usb_remove_hcd(hcd);
309 put_usb3_hcd:
310 usb_put_hcd(xhci->shared_hcd);
311 disable_host:
312 xhci_histb_host_disable(histb);
313 put_hcd:
314 usb_put_hcd(hcd);
315 disable_pm:
316 pm_runtime_put_sync(dev);
317 pm_runtime_disable(dev);
318
319 return ret;
320 }
321
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [PATCH v1 2/6] bus: mhi: core: Mark device inactive soon after host issues a shutdown
by kbuild test robot
Hi Bhaumik,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20200519]
[cannot apply to linus/master v5.7-rc6 v5.7-rc5 v5.7-rc4 v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Bhaumik-Bhatt/Bug-fixes-and-boot...
base: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
config: xtensa-randconfig-r036-20200520 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from include/linux/dev_printk.h:14,
from include/linux/device.h:15,
from drivers/bus/mhi/core/main.c:7:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/xtensa/include/asm/page.h:193:9: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
193 | ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr)
| ^~
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
include/linux/dma-mapping.h:352:2: note: in expansion of macro 'if'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~
include/linux/dma-mapping.h:352:6: note: in expansion of macro 'WARN_ON_ONCE'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
arch/xtensa/include/asm/page.h:193:9: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
193 | ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr)
| ^~
include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
include/linux/dma-mapping.h:352:2: note: in expansion of macro 'if'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~
include/linux/dma-mapping.h:352:6: note: in expansion of macro 'WARN_ON_ONCE'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
arch/xtensa/include/asm/page.h:193:9: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
193 | ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr)
| ^~
include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value'
69 | (cond) ? | ^~~~
include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/dma-mapping.h:352:2: note: in expansion of macro 'if'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~
include/linux/dma-mapping.h:352:6: note: in expansion of macro 'WARN_ON_ONCE'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
drivers/bus/mhi/core/main.c: In function 'mhi_intvec_threaded_handler':
drivers/bus/mhi/core/main.c:397:8: error: implicit declaration of function 'mhi_is_active' [-Werror=implicit-function-declaration]
397 | if (!mhi_is_active(mhi_cntrl)) {
| ^~~~~~~~~~~~~
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
>> drivers/bus/mhi/core/main.c:397:3: note: in expansion of macro 'if'
397 | if (!mhi_is_active(mhi_cntrl)) {
| ^~
cc1: some warnings being treated as errors
vim +/if +397 drivers/bus/mhi/core/main.c
371
372 irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv)
373 {
374 struct mhi_controller *mhi_cntrl = priv;
375 struct device *dev = &mhi_cntrl->mhi_dev->dev;
376 enum mhi_state state = MHI_STATE_MAX;
377 enum mhi_pm_state pm_state = 0;
378 enum mhi_ee_type ee = 0;
379 bool handle_rddm = false;
380
381 write_lock_irq(&mhi_cntrl->pm_lock);
382 if (!MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) {
383 write_unlock_irq(&mhi_cntrl->pm_lock);
384 goto exit_intvec;
385 }
386
387 state = mhi_get_mhi_state(mhi_cntrl);
388 ee = mhi_cntrl->ee;
389 mhi_cntrl->ee = mhi_get_exec_env(mhi_cntrl);
390 dev_dbg(dev, "local ee:%s device ee:%s dev_state:%s\n",
391 TO_MHI_EXEC_STR(mhi_cntrl->ee), TO_MHI_EXEC_STR(ee),
392 TO_MHI_STATE_STR(state));
393
394 /* If device supports RDDM don't bother processing SYS error */
395 if (mhi_cntrl->rddm_image) {
396 /* host may be performing a device power down already */
> 397 if (!mhi_is_active(mhi_cntrl)) {
398 write_unlock_irq(&mhi_cntrl->pm_lock);
399 goto exit_intvec;
400 }
401
402 if (mhi_cntrl->ee == MHI_EE_RDDM && mhi_cntrl->ee != ee) {
403 /* prevent clients from queueing any more packets */
404 pm_state = mhi_tryset_pm_state(mhi_cntrl,
405 MHI_PM_SYS_ERR_DETECT);
406 if (pm_state == MHI_PM_SYS_ERR_DETECT)
407 handle_rddm = true;
408 }
409
410 write_unlock_irq(&mhi_cntrl->pm_lock);
411
412 if (handle_rddm) {
413 dev_err(dev, "RDDM event occurred!\n");
414 mhi_cntrl->status_cb(mhi_cntrl, MHI_CB_EE_RDDM);
415 wake_up_all(&mhi_cntrl->state_event);
416 }
417 goto exit_intvec;
418 }
419
420 if (state == MHI_STATE_SYS_ERR) {
421 dev_dbg(dev, "System error detected\n");
422 pm_state = mhi_tryset_pm_state(mhi_cntrl,
423 MHI_PM_SYS_ERR_DETECT);
424 }
425
426 write_unlock_irq(&mhi_cntrl->pm_lock);
427
428 if (pm_state == MHI_PM_SYS_ERR_DETECT) {
429 wake_up_all(&mhi_cntrl->state_event);
430
431 /* For fatal errors, we let controller decide next step */
432 if (MHI_IN_PBL(ee))
433 mhi_cntrl->status_cb(mhi_cntrl, MHI_CB_FATAL_ERROR);
434 else
435 mhi_pm_sys_err_handler(mhi_cntrl);
436 }
437
438 exit_intvec:
439
440 return IRQ_HANDLED;
441 }
442
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [PATCH v2 4/7] ASoC: soc-link: add snd_soc_link_be_hw_params_fixup()
by kbuild test robot
Hi Kuninori,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on next-20200519]
[cannot apply to sound/for-next v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Kuninori-Morimoto/ASoC-add-soc-l...
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: x86_64-randconfig-r016-20200521 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
sound/soc/soc-link.c:28:5: warning: no previous prototype for function 'snd_soc_link_init' [-Wmissing-prototypes]
int snd_soc_link_init(struct snd_soc_pcm_runtime *rtd)
^
sound/soc/soc-link.c:28:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_init(struct snd_soc_pcm_runtime *rtd)
^
static
>> sound/soc/soc-link.c:38:5: warning: no previous prototype for function 'snd_soc_link_be_hw_params_fixup' [-Wmissing-prototypes]
int snd_soc_link_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
^
sound/soc/soc-link.c:38:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
^
static
sound/soc/soc-link.c:49:5: warning: no previous prototype for function 'snd_soc_link_startup' [-Wmissing-prototypes]
int snd_soc_link_startup(struct snd_pcm_substream *substream)
^
sound/soc/soc-link.c:49:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_startup(struct snd_pcm_substream *substream)
^
static
sound/soc/soc-link.c:61:6: warning: no previous prototype for function 'snd_soc_link_shutdown' [-Wmissing-prototypes]
void snd_soc_link_shutdown(struct snd_pcm_substream *substream)
^
sound/soc/soc-link.c:61:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void snd_soc_link_shutdown(struct snd_pcm_substream *substream)
^
static
sound/soc/soc-link.c:70:5: warning: no previous prototype for function 'snd_soc_link_prepare' [-Wmissing-prototypes]
int snd_soc_link_prepare(struct snd_pcm_substream *substream)
^
sound/soc/soc-link.c:70:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_prepare(struct snd_pcm_substream *substream)
^
static
sound/soc/soc-link.c:82:5: warning: no previous prototype for function 'snd_soc_link_hw_params' [-Wmissing-prototypes]
int snd_soc_link_hw_params(struct snd_pcm_substream *substream,
^
sound/soc/soc-link.c:82:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_hw_params(struct snd_pcm_substream *substream,
^
static
sound/soc/soc-link.c:95:6: warning: no previous prototype for function 'snd_soc_link_hw_free' [-Wmissing-prototypes]
void snd_soc_link_hw_free(struct snd_pcm_substream *substream)
^
sound/soc/soc-link.c:95:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void snd_soc_link_hw_free(struct snd_pcm_substream *substream)
^
static
sound/soc/soc-link.c:104:5: warning: no previous prototype for function 'snd_soc_link_trigger' [-Wmissing-prototypes]
int snd_soc_link_trigger(struct snd_pcm_substream *substream, int cmd)
^
sound/soc/soc-link.c:104:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int snd_soc_link_trigger(struct snd_pcm_substream *substream, int cmd)
^
static
8 warnings generated.
vim +/snd_soc_link_be_hw_params_fixup +38 sound/soc/soc-link.c
27
> 28 int snd_soc_link_init(struct snd_soc_pcm_runtime *rtd)
29 {
30 int ret = 0;
31
32 if (rtd->dai_link->init)
33 ret = rtd->dai_link->init(rtd);
34
35 return soc_link_ret(rtd, ret);
36 }
37
> 38 int snd_soc_link_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
39 struct snd_pcm_hw_params *params)
40 {
41 int ret = 0;
42
43 if (rtd->dai_link->be_hw_params_fixup)
44 ret = rtd->dai_link->be_hw_params_fixup(rtd, params);
45
46 return soc_link_ret(rtd, ret);
47 }
48
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [PATCH v2 1/7] ASoC: add soc-link.c
by kbuild test robot
Hi Kuninori,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on sound/for-next v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Kuninori-Morimoto/ASoC-add-soc-l...
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: parisc-randconfig-r011-20200521 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/parisc/include/asm/io.h:6,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from arch/parisc/include/asm/hardirq.h:13,
from include/linux/hardirq.h:9,
from include/linux/interrupt.h:11,
from include/sound/soc.h:18,
from sound/soc/soc-link.c:8:
include/asm-generic/pgtable.h: In function 'pte_clear_not_present_full':
arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
96 | pte_t old_pte; | ^~~~~~~
arch/parisc/include/asm/pgtable.h:322:34: note: in expansion of macro 'set_pte_at'
322 | #define pte_clear(mm, addr, xp) set_pte_at(mm, addr, xp, __pte(0))
| ^~~~~~~~~~
include/asm-generic/pgtable.h:202:2: note: in expansion of macro 'pte_clear'
202 | pte_clear(mm, address, ptep);
| ^~~~~~~~~
include/asm-generic/pgtable.h: In function '__ptep_modify_prot_commit':
arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
96 | pte_t old_pte; | ^~~~~~~
include/asm-generic/pgtable.h:641:2: note: in expansion of macro 'set_pte_at'
641 | set_pte_at(vma->vm_mm, addr, ptep, pte);
| ^~~~~~~~~~
sound/soc/soc-link.c: At top level:
>> sound/soc/soc-link.c:28:5: warning: no previous prototype for 'snd_soc_link_init' [-Wmissing-prototypes]
28 | int snd_soc_link_init(struct snd_soc_pcm_runtime *rtd)
| ^~~~~~~~~~~~~~~~~
vim +/snd_soc_link_init +28 sound/soc/soc-link.c
27
> 28 int snd_soc_link_init(struct snd_soc_pcm_runtime *rtd)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months