Re: [PATCH] usb: dwc2: Update Core Reset programming flow.
by kbuild test robot
Hi Minas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on balbi-usb/testing/next]
[also build test WARNING on usb/usb-testing v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Minas-Harutyunyan/usb-dwc2-Updat...
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e6658079aca6d971b4e9d7137a3a2ecbc9c34aec)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/usb/dwc2/platform.c:371:5: warning: no previous prototype for function 'dwc2_check_core_version' [-Wmissing-prototypes]
int dwc2_check_core_version(struct dwc2_hsotg *hsotg)
^
drivers/usb/dwc2/platform.c:371:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int dwc2_check_core_version(struct dwc2_hsotg *hsotg)
^
static
1 warning generated.
vim +/dwc2_check_core_version +371 drivers/usb/dwc2/platform.c
364
365 /**
366 * Check core version
367 *
368 * @hsotg: Programming view of the DWC_otg controller
369 *
370 */
> 371 int dwc2_check_core_version(struct dwc2_hsotg *hsotg)
372 {
373 struct dwc2_hw_params *hw = &hsotg->hw_params;
374
375 /*
376 * Attempt to ensure this device is really a DWC_otg Controller.
377 * Read and verify the GSNPSID register contents. The value should be
378 * 0x45f4xxxx, 0x5531xxxx or 0x5532xxxx
379 */
380
381 hw->snpsid = dwc2_readl(hsotg, GSNPSID);
382 if ((hw->snpsid & GSNPSID_ID_MASK) != DWC2_OTG_ID &&
383 (hw->snpsid & GSNPSID_ID_MASK) != DWC2_FS_IOT_ID &&
384 (hw->snpsid & GSNPSID_ID_MASK) != DWC2_HS_IOT_ID) {
385 dev_err(hsotg->dev, "Bad value for GSNPSID: 0x%08x\n",
386 hw->snpsid);
387 return -ENODEV;
388 }
389
390 dev_dbg(hsotg->dev, "Core Release: %1x.%1x%1x%1x (snpsid=%x)\n",
391 hw->snpsid >> 12 & 0xf, hw->snpsid >> 8 & 0xf,
392 hw->snpsid >> 4 & 0xf, hw->snpsid & 0xf, hw->snpsid);
393 return 0;
394 }
395
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[linux-review:UPDATE-20200520-041207/Zhou-Yanjie/Introduce-SMP-support-for-CI20-based-on-JZ4780/20200519-224059 1/6] arch/mips/kernel/idle.c:97:6: warning: no previous prototype for function 'jz4780_smp_wait_irqoff'
by kbuild test robot
tree: https://github.com/0day-ci/linux/commits/UPDATE-20200520-041207/Zhou-Yanj...
head: 4fff52cd90c9406079cc6395408c8a56e7e4312d
commit: ad29da9806feb410651e7428a8ac27ab8f9104ff [1/6] MIPS: JZ4780: Introduce SMP support.
config: mips-randconfig-r023-20200520 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e6658079aca6d971b4e9d7137a3a2ecbc9c34aec)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
git checkout ad29da9806feb410651e7428a8ac27ab8f9104ff
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> arch/mips/kernel/idle.c:97:6: warning: no previous prototype for function 'jz4780_smp_wait_irqoff' [-Wmissing-prototypes]
void jz4780_smp_wait_irqoff(void)
^
arch/mips/kernel/idle.c:97:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void jz4780_smp_wait_irqoff(void)
^
static
arch/mips/kernel/idle.c:155:13: warning: no previous prototype for function 'check_wait' [-Wmissing-prototypes]
void __init check_wait(void)
^
arch/mips/kernel/idle.c:155:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void __init check_wait(void)
^
static
2 warnings generated.
vim +/jz4780_smp_wait_irqoff +97 arch/mips/kernel/idle.c
90
91 /*
92 * The Ingenic jz4780 SMP variant has to write back dirty cache lines before
93 * executing wait. The CPU & cache clock will be gated until we return from
94 * the wait, and if another core attempts to access data from our data cache
95 * during this time then it will lock up.
96 */
> 97 void jz4780_smp_wait_irqoff(void)
98 {
99 unsigned long pending = read_c0_cause() & read_c0_status() & CAUSEF_IP;
100
101 /*
102 * Going to idle has a significant overhead due to the cache flush so
103 * try to avoid it if we'll immediately be woken again due to an IRQ.
104 */
105 if (!need_resched() && !pending) {
106 r4k_blast_dcache();
107
108 __asm__(
109 " .set push \n"
110 " .set mips3 \n"
111 " sync \n"
112 " wait \n"
113 " .set pop \n");
114 }
115
116 local_irq_enable();
117 }
118
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [PATCH 03/12] OPP: Improve required-opps linking
by kbuild test robot
Hi "Andrew-sh.Cheng",
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pm/linux-next]
[also build test ERROR on robh/for-next linus/master v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Andrew-sh-Cheng/Add-cpufreq-and-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: parisc-randconfig-r013-20200520 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
hppa64-linux-ld: drivers/opp/cpu.o: in function `_of_lazy_link_required_tables':
>> drivers/opp/cpu.c:226: multiple definition of `_of_lazy_link_required_tables'; drivers/opp/core.o:include/linux/refcount.h:206: first defined here
hppa64-linux-ld: drivers/opp/debugfs.o: in function `_of_lazy_link_required_tables':
drivers/opp/debugfs.c:126: multiple definition of `_of_lazy_link_required_tables'; drivers/opp/core.o:include/linux/refcount.h:206: first defined here
vim +226 drivers/opp/cpu.c
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 194
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 195 /**
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 196 * dev_pm_opp_get_sharing_cpus() - Get cpumask of CPUs sharing OPPs with @cpu_dev
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 197 * @cpu_dev: CPU device for which we do this operation
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 198 * @cpumask: cpumask to update with information of sharing CPUs
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 199 *
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 200 * This updates the @cpumask with CPUs that are sharing OPPs with @cpu_dev.
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 201 *
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar 2016-06-16 202 * Returns -ENODEV if OPP table isn't already present and -EINVAL if the OPP
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar 2016-06-16 203 * table's status is access-unknown.
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 204 */
ddbb74bc70c0db drivers/base/power/opp/cpu.c Arnd Bergmann 2016-04-30 205 int dev_pm_opp_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask)
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 206 {
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 207 struct opp_device *opp_dev;
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 208 struct opp_table *opp_table;
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 209 int ret = 0;
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 210
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 211 opp_table = _find_opp_table(cpu_dev);
5b650b388844f2 drivers/base/power/opp/cpu.c Viresh Kumar 2017-01-23 212 if (IS_ERR(opp_table))
5b650b388844f2 drivers/base/power/opp/cpu.c Viresh Kumar 2017-01-23 213 return PTR_ERR(opp_table);
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 214
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar 2016-06-16 215 if (opp_table->shared_opp == OPP_TABLE_ACCESS_UNKNOWN) {
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar 2016-06-16 216 ret = -EINVAL;
5b650b388844f2 drivers/base/power/opp/cpu.c Viresh Kumar 2017-01-23 217 goto put_opp_table;
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar 2016-06-16 218 }
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar 2016-06-16 219
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 220 cpumask_clear(cpumask);
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 221
79ee2e8f730411 drivers/base/power/opp/cpu.c Viresh Kumar 2016-06-16 222 if (opp_table->shared_opp == OPP_TABLE_ACCESS_SHARED) {
3d2556992a878a drivers/opp/cpu.c Viresh Kumar 2018-08-03 223 mutex_lock(&opp_table->lock);
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 224 list_for_each_entry(opp_dev, &opp_table->dev_list, node)
6f707daa383376 drivers/base/power/opp/cpu.c Viresh Kumar 2016-04-27 225 cpumask_set_cpu(opp_dev->dev->id, cpumask);
3d2556992a878a drivers/opp/cpu.c Viresh Kumar 2018-08-03 @226 mutex_unlock(&opp_table->lock);
:::::: The code at line 226 was first introduced by commit
:::::: 3d2556992a878a2210d3be498416aee39e0c32aa OPP: Protect dev_list with opp_table lock
:::::: TO: Viresh Kumar <viresh.kumar(a)linaro.org>
:::::: CC: Viresh Kumar <viresh.kumar(a)linaro.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [Intel-gfx] [PATCH 23/23] drm/i915: Ensure we hold the pin mutex
by kbuild test robot
Hi Maarten,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/Revert-drm-i91...
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/x86/include/asm/bug.h:83:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/rcupdate.h:27,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from include/linux/pm_runtime.h:11,
from drivers/gpu/drm/i915/gt/intel_rc6.c:7:
drivers/gpu/drm/i915/i915_vma.h: In function 'i915_vma_pin':
>> include/linux/dma-resv.h:80:28: error: implicit declaration of function 'lockdep_is_held'; did you mean 'lockdep_assert_held'? [-Werror=implicit-function-declaration]
#define dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
^
include/asm-generic/bug.h:151:27: note: in definition of macro 'WARN_ONCE'
int __ret_warn_once = !!(condition); ^~~~~~~~~
>> drivers/gpu/drm/i915/i915_vma.h:245:2: note: in expansion of macro 'WARN_ON_ONCE'
WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
^~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_vma.h:245:28: note: in expansion of macro 'dma_resv_held'
WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
^~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from arch/x86/include/asm/bug.h:83:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/rcupdate.h:27,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/sched/mm.h:7,
from drivers/gpu/drm/i915/gem/i915_gem_object.c:25:
drivers/gpu/drm/i915/i915_vma.h: In function 'i915_vma_pin':
include/linux/dma-resv.h:80:28: error: implicit declaration of function 'lockdep_is_held'; did you mean 'lockdep_is_held_type'? [-Werror=implicit-function-declaration]
#define dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
^
include/asm-generic/bug.h:151:27: note: in definition of macro 'WARN_ONCE'
int __ret_warn_once = !!(condition); ^~~~~~~~~
>> drivers/gpu/drm/i915/i915_vma.h:245:2: note: in expansion of macro 'WARN_ON_ONCE'
WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
^~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_vma.h:245:28: note: in expansion of macro 'dma_resv_held'
WARN_ON_ONCE(vma->resv && dma_resv_held(vma->resv));
^~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +80 include/linux/dma-resv.h
786d7257e537da include/linux/reservation.h Maarten Lankhorst 2013-06-27 79
52791eeec1d9f4 include/linux/dma-resv.h Christian König 2019-08-11 @80 #define dma_resv_held(obj) lockdep_is_held(&(obj)->lock.base)
52791eeec1d9f4 include/linux/dma-resv.h Christian König 2019-08-11 81 #define dma_resv_assert_held(obj) lockdep_assert_held(&(obj)->lock.base)
04a5faa8cbe5a8 include/linux/reservation.h Maarten Lankhorst 2014-07-01 82
:::::: The code at line 80 was first introduced by commit
:::::: 52791eeec1d9f4a7e7fe08aaba0b1553149d93bc dma-buf: rename reservation_object to dma_resv
:::::: TO: Christian König <christian.koenig(a)amd.com>
:::::: CC: Christian König <christian.koenig(a)amd.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [hnaz-linux-mm:master 380/523] arch/riscv/kernel/kgdb.c:47:5: warning: no previous prototype for 'decode_register_index'
by Rong Chen
On 5/20/20 5:00 PM, Vincent Chen wrote:
> On Wed, May 20, 2020 at 10:05 AM Andrew Morton
> <akpm(a)linux-foundation.org> wrote:
>> On Tue, 19 May 2020 16:44:22 +0800 kbuild test robot <lkp(a)intel.com> wrote:
>>
>>> Hi Andrew,
>>>
>>> First bad commit (maybe != root cause):
>>>
>>> tree: https://github.com/hnaz/linux-mm master
>>> head: 2bbf0589bfeb27800c730b76eacf34528eee5418
>>> commit: 91cd0b1b65c463042fdeb4ab5ffcb64ae43179cf [380/523] linux-next-rejects
>>> config: riscv-allyesconfig (attached as .config)
>>> compiler: riscv64-linux-gcc (GCC) 9.3.0
>>> reproduce:
>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> git checkout 91cd0b1b65c463042fdeb4ab5ffcb64ae43179cf
>>> # save the attached .config to linux build tree
>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kbuild test robot <lkp(a)intel.com>
>>>
>>> All warnings (new ones prefixed by >>, old ones prefixed by <<):
>>>
>>>>> arch/riscv/kernel/kgdb.c:47:5: warning: no previous prototype for 'decode_register_index' [-Wmissing-prototypes]
>>> 47 | int decode_register_index(unsigned long opcode, int offset)
>>> | ^~~~~~~~~~~~~~~~~~~~~
>>>>> arch/riscv/kernel/kgdb.c:52:5: warning: no previous prototype for 'decode_register_index_short' [-Wmissing-prototypes]
>>> 52 | int decode_register_index_short(unsigned long opcode, int offset)
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>>> arch/riscv/kernel/kgdb.c:58:5: warning: no previous prototype for 'get_step_address' [-Wmissing-prototypes]
>>> 58 | int get_step_address(struct pt_regs *regs, unsigned long *next_addr)
>>> | ^~~~~~~~~~~~~~~~
>>>>> arch/riscv/kernel/kgdb.c:139:5: warning: no previous prototype for 'do_single_step' [-Wmissing-prototypes]
>>> 139 | int do_single_step(struct pt_regs *regs)
>>> | ^~~~~~~~~~~~~~
>>>>> arch/riscv/kernel/kgdb.c:276:6: warning: no previous prototype for 'kgdb_arch_handle_qxfer_pkt' [-Wmissing-prototypes]
>>> 276 | void kgdb_arch_handle_qxfer_pkt(char *remcom_in_buffer,
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>>>> arch/riscv/kernel/kgdb.c:323:5: warning: no previous prototype for 'kgdb_riscv_kgdbbreak' [-Wmissing-prototypes]
>>> 323 | int kgdb_riscv_kgdbbreak(unsigned long addr)
>>> | ^~~~~~~~~~~~~~~~~~~~
>>> In file included from arch/riscv/include/asm/kgdb.h:109,
>>> from include/linux/kgdb.h:20,
>>> from arch/riscv/kernel/kgdb.c:9:
>>> arch/riscv/include/asm/gdb_xml.h:7:19: warning: 'riscv_gdb_stub_feature' defined but not used [-Wunused-const-variable=]
>>> 7 | static const char riscv_gdb_stub_feature[64] =
>>> | ^~~~~~~~~~~~~~~~~~~~~~
>> I doubt if linux-next-rejects caused this error - all that patch does
>> is fix up a reject between linux-next patches and
>> https://ozlabs.org/~akpm/mmotm/broken-out/riscv-support-debug_wx.patch
>>
>> I'm more suspecting that this error is due Vincent's e4f2aa5808fc9
>> ("riscv: Add KGDB support") or 899dc734805df ("riscv: Use the XML
>> target descriptions to report 3 system registers").
>>
>>
> I tried to use the following commands to reproduce the above warning
> messages, but I failed.
> 1. git clone https://github.com/hnaz/linux-mm
> 2. wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> 3. chmod +x ~/bin/make.cross
> 4. cd linux-mm
> 5. git checkout 91cd0b1b65c463042fdeb4ab5ffcb64ae43179cf
> 6. make ARCH=riscv allyesconfig
> 7. COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
>
> Could you help me correct the reproduce steps?
Hi Vincent,
Sorry for the inconvenience, it's a W=1 build, please download the new
make.cross
and it could be reproduce.
Best Regards,
Rong Chen
2 years, 4 months
[linuxtv-media:master 440/495] drivers/staging/media/atomisp/pci/atomisp_cmd.c:4278:17: warning: address of 'config->info' will always evaluate to 'true'
by kbuild test robot
Hi Mauro,
First bad commit (maybe != root cause):
tree: git://linuxtv.org/media_tree.git master
head: 960b2dee908b0fc51cf670841de13b40b44aaaae
commit: 9d4fa1a16b28b1d12b0378993d2d48f572a045d9 [440/495] media: atomisp: cleanup directory hierarchy
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e6658079aca6d971b4e9d7137a3a2ecbc9c34aec)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 9d4fa1a16b28b1d12b0378993d2d48f572a045d9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/staging/media/atomisp/pci/atomisp_cmd.c:4278:17: warning: address of 'config->info' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (!&config->info) {
~ ~~~~~~~~^~~~
1 warning generated.
--
>> drivers/staging/media/atomisp/pci/sh_css.c:8621:14: warning: address of 'pipe->output_stage' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (&pipe->output_stage)
~~ ~~~~~~^~~~~~~~~~~~
>> drivers/staging/media/atomisp/pci/sh_css.c:8629:14: warning: address of 'pipe->vf_stage' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (&pipe->vf_stage)
~~ ~~~~~~^~~~~~~~
>> drivers/staging/media/atomisp/pci/sh_css.c:2460:1: warning: stack frame size of 27088 bytes in function 'create_pipe' [-Wframe-larger-than=]
create_pipe(enum ia_css_pipe_mode mode,
^
3 warnings generated.
--
>> drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c:148:35: warning: implicit conversion from 'unsigned long' to 'int32_t' (aka 'int') changes value from 18446744073709543424 to -8192 [-Wconstant-conversion]
return MAX(MIN(isp_strength, 0), -XNR_BLENDING_SCALE_FACTOR);
~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/media/atomisp//pci/hive_isp_css_include/math_support.h:35:52: note: expanded from macro 'MAX'
#define MAX(a, b) (((a) > (b)) ? (a) : (b))
^
1 warning generated.
vim +4278 drivers/staging/media/atomisp/pci/atomisp_cmd.c
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4260
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4261 /*
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4262 * Function to set/get isp parameters to isp
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4263 */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4264 int atomisp_param(struct atomisp_sub_device *asd, int flag,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4265 struct atomisp_parm *config)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4266 {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4267 struct atomisp_device *isp = asd->isp;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4268 struct ia_css_pipe_config *vp_cfg =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4269 &asd->stream_env[ATOMISP_INPUT_STREAM_GENERAL].
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4270 pipe_configs[IA_CSS_PIPE_ID_VIDEO];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4271
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4272 /* Read parameter for 3A binary info */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4273 if (flag == 0) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4274 struct atomisp_css_dvs_grid_info *dvs_grid_info =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4275 atomisp_css_get_dvs_grid_info(
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4276 &asd->params.curr_grid_info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4277
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 @4278 if (!&config->info) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4279 dev_err(isp->dev, "ERROR: NULL pointer in grid_info\n");
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4280 return -EINVAL;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4281 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4282 atomisp_curr_user_grid_info(asd, &config->info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4283
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4284 /* We always return the resolution and stride even if there is
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4285 * no valid metadata. This allows the caller to get the
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4286 * information needed to allocate user-space buffers. */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4287 config->metadata_config.metadata_height = asd->
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4288 stream_env[ATOMISP_INPUT_STREAM_GENERAL].stream_info.
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4289 metadata_info.resolution.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4290 config->metadata_config.metadata_stride = asd->
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4291 stream_env[ATOMISP_INPUT_STREAM_GENERAL].stream_info.
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4292 metadata_info.stride;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4293
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4294 /* update dvs grid info */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4295 if (dvs_grid_info)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4296 memcpy(&config->dvs_grid,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4297 dvs_grid_info,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4298 sizeof(struct atomisp_css_dvs_grid_info));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4299
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4300 if (asd->run_mode->val != ATOMISP_RUN_MODE_VIDEO) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4301 config->dvs_envelop.width = 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4302 config->dvs_envelop.height = 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4303 return 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4304 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4305
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4306 /* update dvs envelop info */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4307 if (!asd->continuous_mode->val) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4308 config->dvs_envelop.width = vp_cfg->dvs_envelope.width;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4309 config->dvs_envelop.height =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4310 vp_cfg->dvs_envelope.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4311 } else {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4312 unsigned int dvs_w, dvs_h, dvs_w_max, dvs_h_max;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4313
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4314 dvs_w = vp_cfg->bayer_ds_out_res.width -
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4315 vp_cfg->output_info[0].res.width;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4316 dvs_h = vp_cfg->bayer_ds_out_res.height -
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4317 vp_cfg->output_info[0].res.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4318 dvs_w_max = rounddown(
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4319 vp_cfg->output_info[0].res.width / 5,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4320 ATOM_ISP_STEP_WIDTH);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4321 dvs_h_max = rounddown(
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4322 vp_cfg->output_info[0].res.height / 5,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4323 ATOM_ISP_STEP_HEIGHT);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4324
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4325 config->dvs_envelop.width = min(dvs_w, dvs_w_max);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4326 config->dvs_envelop.height = min(dvs_h, dvs_h_max);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4327 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4328
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4329 return 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4330 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4331
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4332 memcpy(&asd->params.css_param.wb_config, &config->wb_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4333 sizeof(struct atomisp_css_wb_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4334 memcpy(&asd->params.css_param.ob_config, &config->ob_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4335 sizeof(struct atomisp_css_ob_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4336 memcpy(&asd->params.css_param.dp_config, &config->dp_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4337 sizeof(struct atomisp_css_dp_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4338 memcpy(&asd->params.css_param.de_config, &config->de_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4339 sizeof(struct atomisp_css_de_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4340 memcpy(&asd->params.css_param.dz_config, &config->dz_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4341 sizeof(struct atomisp_css_dz_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4342 memcpy(&asd->params.css_param.ce_config, &config->ce_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4343 sizeof(struct atomisp_css_ce_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4344 memcpy(&asd->params.css_param.nr_config, &config->nr_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4345 sizeof(struct atomisp_css_nr_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4346 memcpy(&asd->params.css_param.ee_config, &config->ee_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4347 sizeof(struct atomisp_css_ee_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4348 memcpy(&asd->params.css_param.tnr_config, &config->tnr_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4349 sizeof(struct atomisp_css_tnr_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4350
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4351 if (asd->params.color_effect == V4L2_COLORFX_NEGATIVE) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4352 asd->params.css_param.cc_config.matrix[3] = -config->cc_config.matrix[3];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4353 asd->params.css_param.cc_config.matrix[4] = -config->cc_config.matrix[4];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4354 asd->params.css_param.cc_config.matrix[5] = -config->cc_config.matrix[5];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4355 asd->params.css_param.cc_config.matrix[6] = -config->cc_config.matrix[6];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4356 asd->params.css_param.cc_config.matrix[7] = -config->cc_config.matrix[7];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4357 asd->params.css_param.cc_config.matrix[8] = -config->cc_config.matrix[8];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4358 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4359
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4360 if (asd->params.color_effect != V4L2_COLORFX_SEPIA &&
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4361 asd->params.color_effect != V4L2_COLORFX_BW) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4362 memcpy(&asd->params.css_param.cc_config, &config->cc_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4363 sizeof(struct atomisp_css_cc_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4364 atomisp_css_set_cc_config(asd, &asd->params.css_param.cc_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4365 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4366
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4367 atomisp_css_set_wb_config(asd, &asd->params.css_param.wb_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4368 atomisp_css_set_ob_config(asd, &asd->params.css_param.ob_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4369 atomisp_css_set_de_config(asd, &asd->params.css_param.de_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4370 atomisp_css_set_dz_config(asd, &asd->params.css_param.dz_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4371 atomisp_css_set_ce_config(asd, &asd->params.css_param.ce_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4372 atomisp_css_set_dp_config(asd, &asd->params.css_param.dp_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4373 atomisp_css_set_nr_config(asd, &asd->params.css_param.nr_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4374 atomisp_css_set_ee_config(asd, &asd->params.css_param.ee_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4375 atomisp_css_set_tnr_config(asd, &asd->params.css_param.tnr_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4376 asd->params.css_update_params_needed = true;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4377
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4378 return 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4379 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4380
:::::: The code at line 4278 was first introduced by commit
:::::: bdfe0beb95eebc864f341fd0c5e903672b90b1a2 media: atomisp: fix several coding style issues
:::::: TO: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild-all mailing list -- kbuild-all(a)lists.01.org
To unsubscribe send an email to kbuild-all-leave(a)lists.01.org
2 years, 4 months
[linuxtv-media:master 440/495] drivers/staging/media/atomisp/pci/atomisp_cmd.c:4278:17: warning: address of 'config->info' will always evaluate to 'true'
by kbuild test robot
CC: linux-media(a)vger.kernel.org
TO: Mauro Carvalho Chehab <mchehab(a)kernel.org>
CC: linux-media(a)vger.kernel.org
Hi Mauro,
First bad commit (maybe != root cause):
tree: git://linuxtv.org/media_tree.git master
head: 960b2dee908b0fc51cf670841de13b40b44aaaae
commit: 9d4fa1a16b28b1d12b0378993d2d48f572a045d9 [440/495] media: atomisp: cleanup directory hierarchy
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e6658079aca6d971b4e9d7137a3a2ecbc9c34aec)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 9d4fa1a16b28b1d12b0378993d2d48f572a045d9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/staging/media/atomisp/pci/atomisp_cmd.c:4278:17: warning: address of 'config->info' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (!&config->info) {
~ ~~~~~~~~^~~~
1 warning generated.
--
>> drivers/staging/media/atomisp/pci/sh_css.c:8621:14: warning: address of 'pipe->output_stage' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (&pipe->output_stage)
~~ ~~~~~~^~~~~~~~~~~~
>> drivers/staging/media/atomisp/pci/sh_css.c:8629:14: warning: address of 'pipe->vf_stage' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (&pipe->vf_stage)
~~ ~~~~~~^~~~~~~~
>> drivers/staging/media/atomisp/pci/sh_css.c:2460:1: warning: stack frame size of 27088 bytes in function 'create_pipe' [-Wframe-larger-than=]
create_pipe(enum ia_css_pipe_mode mode,
^
3 warnings generated.
--
>> drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c:148:35: warning: implicit conversion from 'unsigned long' to 'int32_t' (aka 'int') changes value from 18446744073709543424 to -8192 [-Wconstant-conversion]
return MAX(MIN(isp_strength, 0), -XNR_BLENDING_SCALE_FACTOR);
~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/media/atomisp//pci/hive_isp_css_include/math_support.h:35:52: note: expanded from macro 'MAX'
#define MAX(a, b) (((a) > (b)) ? (a) : (b))
^
1 warning generated.
vim +4278 drivers/staging/media/atomisp/pci/atomisp_cmd.c
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4260
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4261 /*
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4262 * Function to set/get isp parameters to isp
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4263 */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4264 int atomisp_param(struct atomisp_sub_device *asd, int flag,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4265 struct atomisp_parm *config)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4266 {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4267 struct atomisp_device *isp = asd->isp;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4268 struct ia_css_pipe_config *vp_cfg =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4269 &asd->stream_env[ATOMISP_INPUT_STREAM_GENERAL].
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4270 pipe_configs[IA_CSS_PIPE_ID_VIDEO];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4271
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4272 /* Read parameter for 3A binary info */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4273 if (flag == 0) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4274 struct atomisp_css_dvs_grid_info *dvs_grid_info =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4275 atomisp_css_get_dvs_grid_info(
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4276 &asd->params.curr_grid_info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4277
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 @4278 if (!&config->info) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4279 dev_err(isp->dev, "ERROR: NULL pointer in grid_info\n");
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4280 return -EINVAL;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4281 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4282 atomisp_curr_user_grid_info(asd, &config->info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4283
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4284 /* We always return the resolution and stride even if there is
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4285 * no valid metadata. This allows the caller to get the
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4286 * information needed to allocate user-space buffers. */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4287 config->metadata_config.metadata_height = asd->
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4288 stream_env[ATOMISP_INPUT_STREAM_GENERAL].stream_info.
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4289 metadata_info.resolution.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4290 config->metadata_config.metadata_stride = asd->
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4291 stream_env[ATOMISP_INPUT_STREAM_GENERAL].stream_info.
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4292 metadata_info.stride;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4293
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4294 /* update dvs grid info */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4295 if (dvs_grid_info)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4296 memcpy(&config->dvs_grid,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4297 dvs_grid_info,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4298 sizeof(struct atomisp_css_dvs_grid_info));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4299
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4300 if (asd->run_mode->val != ATOMISP_RUN_MODE_VIDEO) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4301 config->dvs_envelop.width = 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4302 config->dvs_envelop.height = 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4303 return 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4304 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4305
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4306 /* update dvs envelop info */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4307 if (!asd->continuous_mode->val) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4308 config->dvs_envelop.width = vp_cfg->dvs_envelope.width;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4309 config->dvs_envelop.height =
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4310 vp_cfg->dvs_envelope.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4311 } else {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4312 unsigned int dvs_w, dvs_h, dvs_w_max, dvs_h_max;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4313
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4314 dvs_w = vp_cfg->bayer_ds_out_res.width -
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4315 vp_cfg->output_info[0].res.width;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4316 dvs_h = vp_cfg->bayer_ds_out_res.height -
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4317 vp_cfg->output_info[0].res.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4318 dvs_w_max = rounddown(
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4319 vp_cfg->output_info[0].res.width / 5,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4320 ATOM_ISP_STEP_WIDTH);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4321 dvs_h_max = rounddown(
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4322 vp_cfg->output_info[0].res.height / 5,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4323 ATOM_ISP_STEP_HEIGHT);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4324
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4325 config->dvs_envelop.width = min(dvs_w, dvs_w_max);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4326 config->dvs_envelop.height = min(dvs_h, dvs_h_max);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4327 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4328
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4329 return 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4330 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4331
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4332 memcpy(&asd->params.css_param.wb_config, &config->wb_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4333 sizeof(struct atomisp_css_wb_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4334 memcpy(&asd->params.css_param.ob_config, &config->ob_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4335 sizeof(struct atomisp_css_ob_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4336 memcpy(&asd->params.css_param.dp_config, &config->dp_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4337 sizeof(struct atomisp_css_dp_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4338 memcpy(&asd->params.css_param.de_config, &config->de_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4339 sizeof(struct atomisp_css_de_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4340 memcpy(&asd->params.css_param.dz_config, &config->dz_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4341 sizeof(struct atomisp_css_dz_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4342 memcpy(&asd->params.css_param.ce_config, &config->ce_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4343 sizeof(struct atomisp_css_ce_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4344 memcpy(&asd->params.css_param.nr_config, &config->nr_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4345 sizeof(struct atomisp_css_nr_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4346 memcpy(&asd->params.css_param.ee_config, &config->ee_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4347 sizeof(struct atomisp_css_ee_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4348 memcpy(&asd->params.css_param.tnr_config, &config->tnr_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4349 sizeof(struct atomisp_css_tnr_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4350
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4351 if (asd->params.color_effect == V4L2_COLORFX_NEGATIVE) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4352 asd->params.css_param.cc_config.matrix[3] = -config->cc_config.matrix[3];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4353 asd->params.css_param.cc_config.matrix[4] = -config->cc_config.matrix[4];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4354 asd->params.css_param.cc_config.matrix[5] = -config->cc_config.matrix[5];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4355 asd->params.css_param.cc_config.matrix[6] = -config->cc_config.matrix[6];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4356 asd->params.css_param.cc_config.matrix[7] = -config->cc_config.matrix[7];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4357 asd->params.css_param.cc_config.matrix[8] = -config->cc_config.matrix[8];
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4358 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4359
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4360 if (asd->params.color_effect != V4L2_COLORFX_SEPIA &&
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4361 asd->params.color_effect != V4L2_COLORFX_BW) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4362 memcpy(&asd->params.css_param.cc_config, &config->cc_config,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4363 sizeof(struct atomisp_css_cc_config));
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4364 atomisp_css_set_cc_config(asd, &asd->params.css_param.cc_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4365 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4366
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4367 atomisp_css_set_wb_config(asd, &asd->params.css_param.wb_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4368 atomisp_css_set_ob_config(asd, &asd->params.css_param.ob_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4369 atomisp_css_set_de_config(asd, &asd->params.css_param.de_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4370 atomisp_css_set_dz_config(asd, &asd->params.css_param.dz_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4371 atomisp_css_set_ce_config(asd, &asd->params.css_param.ce_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4372 atomisp_css_set_dp_config(asd, &asd->params.css_param.dp_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4373 atomisp_css_set_nr_config(asd, &asd->params.css_param.nr_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4374 atomisp_css_set_ee_config(asd, &asd->params.css_param.ee_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4375 atomisp_css_set_tnr_config(asd, &asd->params.css_param.tnr_config);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4376 asd->params.css_update_params_needed = true;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4377
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4378 return 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4379 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c Mauro Carvalho Chehab 2020-04-19 4380
:::::: The code at line 4278 was first introduced by commit
:::::: bdfe0beb95eebc864f341fd0c5e903672b90b1a2 media: atomisp: fix several coding style issues
:::::: TO: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[omap-audio:peter/linux-next-wip 37/89] ERROR: switch and case should be at the same indent
by kbuild test robot
tree: https://github.com/omap-audio/linux-audio peter/linux-next-wip
head: 1352930850986516f555d53639f2b6a5c4f308cf
commit: dcca0275f838f287fbbfef48909d0beec92e998e [37/89] ASoC: Initial driver for TAS2555 Smart Amplifier
reproduce: scripts/checkpatch.pl
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
# many are suggestions rather than must-fix
WARNING: DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.txt
WARNING: please write a paragraph that describes the config symbol fully
#145: sound/soc/codecs/Kconfig:1262:
+config SND_SOC_TAS2555
ERROR: that open brace { should be on the previous line
#397: sound/soc/codecs/tas2555.c:219:
+static const struct snd_soc_dapm_widget tas2555_dapm_widgets[] =
+{
ERROR: switch and case should be at the same indent
#545: sound/soc/codecs/tas2555.c:367:
+ switch (dai->id) {
+ case 0: /* ASI1 */
[...]
+ case 1: /* ASI2 */
[...]
+ case 2: /* ASI3/ASIM */
[...]
+ default:
ERROR: switch and case should be at the same indent
#594: sound/soc/codecs/tas2555.c:416:
+ switch (dai->id) {
+ case 0: /* ASI1 */
[...]
+ case 1: /* ASI2 */
[...]
+ case 2: /* ASI3/ASIM */
[...]
+ default:
ERROR: switch and case should be at the same indent
#709: sound/soc/codecs/tas2555.c:531:
+ switch (dai->id) {
+ case 0: /* ASI1 */
[...]
+ case 1: /* ASI2 */
[...]
+ case 2: /* ASI3/ASIM */
[...]
+ default:
ERROR: space required before the open parenthesis '('
#777: sound/soc/codecs/tas2555.c:599:
+ } while(count < fw->size);
WARNING: please, no space before tabs
#1000: sound/soc/codecs/tas2555.c:822:
+// ^I^Iif (i == 0)$
WARNING: please, no space before tabs
#1001: sound/soc/codecs/tas2555.c:823:
+// ^I^I^Itas2555->supplies[i].optional = true;$
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#1060: sound/soc/codecs/tas2555.h:1:
+/*
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [RFC, WIP, v6 10/10] media: vidtv: Add a MPEG Transport Stream Multiplexer
by kbuild test robot
Hi "Daniel,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on next-20200519]
[cannot apply to linus/master linux/master v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Daniel-W-S-Almeida/media-vidtv-i...
base: git://linuxtv.org/media_tree.git master
config: h8300-allyesconfig (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
h8300-linux-ld: drivers/media/test-drivers/vidtv/vidtv_ts.o: in function `vidtv_ts_pcr_write_into':
vidtv_ts.c:(.text+0x23d): undefined reference to `__umoddi3'
>> h8300-linux-ld: vidtv_ts.c:(.text+0x273): undefined reference to `__udivdi3'
h8300-linux-ld: drivers/media/test-drivers/vidtv/vidtv_s302m.o: in function `.L108':
vidtv_s302m.c:(.text+0x7f9): undefined reference to `__udivdi3'
h8300-linux-ld: drivers/media/test-drivers/vidtv/vidtv_mux.o: in function `.L55':
vidtv_mux.c:(.text+0x8c5): undefined reference to `__udivdi3'
>> h8300-linux-ld: vidtv_mux.c:(.text+0x8f1): undefined reference to `__udivdi3'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
