[linuxtv-media:master 465/495] drivers/staging/media/atomisp/pci/atomisp_v4l2.c:1193:3: warning: variable 'count' is incremented both in the loop header and in the loop body
by kbuild test robot
tree: git://linuxtv.org/media_tree.git master
head: 960b2dee908b0fc51cf670841de13b40b44aaaae
commit: 09d87466655d00526cf818b3f3b267884c591702 [465/495] media: atomisp: reduce the risk of a race condition
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e6658079aca6d971b4e9d7137a3a2ecbc9c34aec)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 09d87466655d00526cf818b3f3b267884c591702
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/staging/media/atomisp/pci/atomisp_v4l2.c:1193:3: warning: variable 'count' is incremented both in the loop header and in the loop body [-Wfor-loop-analysis]
count++;
^
drivers/staging/media/atomisp/pci/atomisp_v4l2.c:1189:57: note: incremented here
for (count = 0; count < SUBDEV_WAIT_TIMEOUT_MAX_COUNT; count++) {
^
1 warning generated.
vim +/count +1193 drivers/staging/media/atomisp/pci/atomisp_v4l2.c
1084
1085 static int atomisp_subdev_probe(struct atomisp_device *isp)
1086 {
1087 const struct atomisp_platform_data *pdata;
1088 struct intel_v4l2_subdev_table *subdevs;
1089 int ret, raw_index = -1, count;
1090
1091 pdata = atomisp_get_platform_data();
1092 if (!pdata) {
1093 dev_err(isp->dev, "no platform data available\n");
1094 return 0;
1095 }
1096
1097 /* FIXME: should, instead, use I2C probe */
1098
1099 for (subdevs = pdata->subdevs; subdevs->type; ++subdevs) {
1100 struct v4l2_subdev *subdev;
1101 struct i2c_board_info *board_info =
1102 &subdevs->v4l2_subdev.board_info;
1103 struct i2c_adapter *adapter =
1104 i2c_get_adapter(subdevs->v4l2_subdev.i2c_adapter_id);
1105 int sensor_num, i;
1106
1107 dev_info(isp->dev, "Probing Subdev %s\n", board_info->type);
1108
1109 if (!adapter) {
1110 dev_err(isp->dev,
1111 "Failed to find i2c adapter for subdev %s\n",
1112 board_info->type);
1113 break;
1114 }
1115
1116 /* In G-Min, the sensor devices will already be probed
1117 * (via ACPI) and registered, do not create new
1118 * ones */
1119 subdev = atomisp_gmin_find_subdev(adapter, board_info);
1120 ret = v4l2_device_register_subdev(&isp->v4l2_dev, subdev);
1121 if (ret) {
1122 dev_warn(isp->dev, "Subdev %s detection fail\n",
1123 board_info->type);
1124 continue;
1125 }
1126
1127 if (!subdev) {
1128 dev_warn(isp->dev, "Subdev %s detection fail\n",
1129 board_info->type);
1130 continue;
1131 }
1132
1133 dev_info(isp->dev, "Subdev %s successfully register\n",
1134 board_info->type);
1135
1136 switch (subdevs->type) {
1137 case RAW_CAMERA:
1138 raw_index = isp->input_cnt;
1139 dev_dbg(isp->dev, "raw_index: %d\n", raw_index);
1140 case SOC_CAMERA:
1141 dev_dbg(isp->dev, "SOC_INDEX: %d\n", isp->input_cnt);
1142 if (isp->input_cnt >= ATOM_ISP_MAX_INPUTS) {
1143 dev_warn(isp->dev,
1144 "too many atomisp inputs, ignored\n");
1145 break;
1146 }
1147
1148 isp->inputs[isp->input_cnt].type = subdevs->type;
1149 isp->inputs[isp->input_cnt].port = subdevs->port;
1150 isp->inputs[isp->input_cnt].camera = subdev;
1151 isp->inputs[isp->input_cnt].sensor_index = 0;
1152 /*
1153 * initialize the subdev frame size, then next we can
1154 * judge whether frame_size store effective value via
1155 * pixel_format.
1156 */
1157 isp->inputs[isp->input_cnt].frame_size.pixel_format = 0;
1158 isp->inputs[isp->input_cnt].camera_caps =
1159 atomisp_get_default_camera_caps();
1160 sensor_num = isp->inputs[isp->input_cnt]
1161 .camera_caps->sensor_num;
1162 isp->input_cnt++;
1163 for (i = 1; i < sensor_num; i++) {
1164 if (isp->input_cnt >= ATOM_ISP_MAX_INPUTS) {
1165 dev_warn(isp->dev,
1166 "atomisp inputs out of range\n");
1167 break;
1168 }
1169 isp->inputs[isp->input_cnt] =
1170 isp->inputs[isp->input_cnt - 1];
1171 isp->inputs[isp->input_cnt].sensor_index = i;
1172 isp->input_cnt++;
1173 }
1174 break;
1175 case CAMERA_MOTOR:
1176 isp->motor = subdev;
1177 break;
1178 case LED_FLASH:
1179 case XENON_FLASH:
1180 isp->flash = subdev;
1181 break;
1182 default:
1183 dev_dbg(isp->dev, "unknown subdev probed\n");
1184 break;
1185 }
1186 }
1187
1188 /* FIXME: should return -EPROBE_DEFER if not all subdevs were probed */
1189 for (count = 0; count < SUBDEV_WAIT_TIMEOUT_MAX_COUNT; count++) {
1190 if (isp->input_cnt)
1191 break;
1192 msleep(SUBDEV_WAIT_TIMEOUT);
> 1193 count++;
1194 }
1195 /* Wait more time to give more time for subdev init code */
1196 msleep(5 * SUBDEV_WAIT_TIMEOUT);
1197
1198 /*
1199 * HACK: Currently VCM belongs to primary sensor only, but correct
1200 * approach must be to acquire from platform code which sensor
1201 * owns it.
1202 */
1203 if (isp->motor && raw_index >= 0)
1204 isp->inputs[raw_index].motor = isp->motor;
1205
1206 /* Proceed even if no modules detected. For COS mode and no modules. */
1207 if (!isp->input_cnt)
1208 dev_warn(isp->dev, "no camera attached or fail to detect\n");
1209 else
1210 dev_info(isp->dev, "detected %d camera sensors\n",
1211 isp->input_cnt);
1212
1213 return atomisp_csi_lane_config(isp);
1214 }
1215
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[jpirko-mlxsw:petrm_wip4 5/5] net/sched/cls_api.c:3886:20: warning: variable 'fl' set but not used
by kbuild test robot
tree: https://github.com/jpirko/linux_mlxsw petrm_wip4
head: 762771d39235289a988465b66509744f59996c66
commit: 762771d39235289a988465b66509744f59996c66 [5/5] wip
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 762771d39235289a988465b66509744f59996c66
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
net/sched/cls_api.c: In function 'tcf_qevent_handle':
>> net/sched/cls_api.c:3886:20: warning: variable 'fl' set but not used [-Wunused-but-set-variable]
3886 | struct tcf_proto *fl;
| ^~
vim +/fl +3886 net/sched/cls_api.c
3880
3881 struct sk_buff *tcf_qevent_handle(struct tcf_qevent *qe, struct Qdisc *sch,
3882 struct sk_buff *skb, struct sk_buff **to_free,
3883 int *ret)
3884 {
3885 struct tcf_result cl_res;
> 3886 struct tcf_proto *fl;
3887
3888 if (!qe->info.block_index)
3889 return skb;
3890
3891 fl = rcu_dereference_bh(qe->filter_chain);
3892
3893 printk(KERN_WARNING "qevent\n");
3894 switch (tcf_classify(skb, qe->filter_chain, &cl_res, false)) {
3895 case TC_ACT_SHOT:
3896 qdisc_qstats_drop(sch);
3897 __qdisc_drop(skb, to_free);
3898 *ret = __NET_XMIT_BYPASS;
3899 return NULL;
3900 case TC_ACT_STOLEN:
3901 case TC_ACT_QUEUED:
3902 case TC_ACT_TRAP:
3903 __qdisc_drop(skb, to_free);
3904 *ret = __NET_XMIT_STOLEN;
3905 return NULL;
3906 case TC_ACT_REDIRECT:
3907 skb_do_redirect(skb);
3908 *ret = __NET_XMIT_STOLEN;
3909 return NULL;
3910 }
3911
3912 return skb;
3913 }
3914 EXPORT_SYMBOL(tcf_qevent_handle);
3915
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[linux-next:master 8920/10701] drivers/md/dm-zoned-metadata.c:2468:6: warning: no previous prototype for function 'dmz_print_dev'
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
commit: 5990119677a94b79da19c01770d3fe0ceda77229 [8920/10701] dm zoned: add metadata logging functions
config: arm64-randconfig-r005-20200520 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e6658079aca6d971b4e9d7137a3a2ecbc9c34aec)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
git checkout 5990119677a94b79da19c01770d3fe0ceda77229
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/md/dm-zoned-metadata.c:2468:6: warning: no previous prototype for function 'dmz_print_dev' [-Wmissing-prototypes]
void dmz_print_dev(struct dmz_metadata *zmd, int num)
^
drivers/md/dm-zoned-metadata.c:2468:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void dmz_print_dev(struct dmz_metadata *zmd, int num)
^
static
1 warning generated.
vim +/dmz_print_dev +2468 drivers/md/dm-zoned-metadata.c
2467
> 2468 void dmz_print_dev(struct dmz_metadata *zmd, int num)
2469 {
2470 struct dmz_dev *dev = &zmd->dev[num];
2471
2472 dmz_dev_info(dev, "Host-%s zoned block device",
2473 bdev_zoned_model(dev->bdev) == BLK_ZONED_HA ?
2474 "aware" : "managed");
2475 dmz_dev_info(dev, " %llu 512-byte logical sectors",
2476 (u64)dev->capacity);
2477 dmz_dev_info(dev, " %u zones of %llu 512-byte logical sectors",
2478 dev->nr_zones, (u64)zmd->zone_nr_sectors);
2479 }
2480 /*
2481 * Initialize the zoned metadata.
2482 */
2483 int dmz_ctr_metadata(struct dmz_dev *dev, struct dmz_metadata **metadata,
2484 const char *devname)
2485 {
2486 struct dmz_metadata *zmd;
2487 unsigned int i;
2488 struct dm_zone *zone;
2489 int ret;
2490
2491 zmd = kzalloc(sizeof(struct dmz_metadata), GFP_KERNEL);
2492 if (!zmd)
2493 return -ENOMEM;
2494
2495 strcpy(zmd->devname, devname);
2496 zmd->dev = dev;
2497 zmd->mblk_rbtree = RB_ROOT;
2498 init_rwsem(&zmd->mblk_sem);
2499 mutex_init(&zmd->mblk_flush_lock);
2500 spin_lock_init(&zmd->mblk_lock);
2501 INIT_LIST_HEAD(&zmd->mblk_lru_list);
2502 INIT_LIST_HEAD(&zmd->mblk_dirty_list);
2503
2504 mutex_init(&zmd->map_lock);
2505 atomic_set(&zmd->unmap_nr_rnd, 0);
2506 INIT_LIST_HEAD(&zmd->unmap_rnd_list);
2507 INIT_LIST_HEAD(&zmd->map_rnd_list);
2508
2509 atomic_set(&zmd->unmap_nr_seq, 0);
2510 INIT_LIST_HEAD(&zmd->unmap_seq_list);
2511 INIT_LIST_HEAD(&zmd->map_seq_list);
2512
2513 atomic_set(&zmd->nr_reserved_seq_zones, 0);
2514 INIT_LIST_HEAD(&zmd->reserved_seq_zones_list);
2515
2516 init_waitqueue_head(&zmd->free_wq);
2517
2518 /* Initialize zone descriptors */
2519 ret = dmz_init_zones(zmd);
2520 if (ret)
2521 goto err;
2522
2523 /* Get super block */
2524 ret = dmz_load_sb(zmd);
2525 if (ret)
2526 goto err;
2527
2528 /* Set metadata zones starting from sb_zone */
2529 for (i = 0; i < zmd->nr_meta_zones << 1; i++) {
2530 zone = dmz_get(zmd, zmd->sb[0].zone->id + i);
2531 if (!dmz_is_rnd(zone))
2532 goto err;
2533 set_bit(DMZ_META, &zone->flags);
2534 }
2535
2536 /* Load mapping table */
2537 ret = dmz_load_mapping(zmd);
2538 if (ret)
2539 goto err;
2540
2541 /*
2542 * Cache size boundaries: allow at least 2 super blocks, the chunk map
2543 * blocks and enough blocks to be able to cache the bitmap blocks of
2544 * up to 16 zones when idle (min_nr_mblks). Otherwise, if busy, allow
2545 * the cache to add 512 more metadata blocks.
2546 */
2547 zmd->min_nr_mblks = 2 + zmd->nr_map_blocks + zmd->zone_nr_bitmap_blocks * 16;
2548 zmd->max_nr_mblks = zmd->min_nr_mblks + 512;
2549 zmd->mblk_shrinker.count_objects = dmz_mblock_shrinker_count;
2550 zmd->mblk_shrinker.scan_objects = dmz_mblock_shrinker_scan;
2551 zmd->mblk_shrinker.seeks = DEFAULT_SEEKS;
2552
2553 /* Metadata cache shrinker */
2554 ret = register_shrinker(&zmd->mblk_shrinker);
2555 if (ret) {
2556 dmz_zmd_err(zmd, "Register metadata cache shrinker failed");
2557 goto err;
2558 }
2559
2560 dmz_zmd_info(zmd, "DM-Zoned metadata version %d", DMZ_META_VER);
2561 dmz_print_dev(zmd, 0);
2562
2563 dmz_zmd_info(zmd, " %u zones of %llu 512-byte logical sectors",
2564 zmd->nr_zones, (u64)zmd->zone_nr_sectors);
2565 dmz_zmd_info(zmd, " %u metadata zones",
2566 zmd->nr_meta_zones * 2);
2567 dmz_zmd_info(zmd, " %u data zones for %u chunks",
2568 zmd->nr_data_zones, zmd->nr_chunks);
2569 dmz_zmd_info(zmd, " %u random zones (%u unmapped)",
2570 zmd->nr_rnd, atomic_read(&zmd->unmap_nr_rnd));
2571 dmz_zmd_info(zmd, " %u sequential zones (%u unmapped)",
2572 zmd->nr_seq, atomic_read(&zmd->unmap_nr_seq));
2573 dmz_zmd_info(zmd, " %u reserved sequential data zones",
2574 zmd->nr_reserved_seq);
2575 dmz_zmd_debug(zmd, "Format:");
2576 dmz_zmd_debug(zmd, "%u metadata blocks per set (%u max cache)",
2577 zmd->nr_meta_blocks, zmd->max_nr_mblks);
2578 dmz_zmd_debug(zmd, " %u data zone mapping blocks",
2579 zmd->nr_map_blocks);
2580 dmz_zmd_debug(zmd, " %u bitmap blocks",
2581 zmd->nr_bitmap_blocks);
2582
2583 *metadata = zmd;
2584
2585 return 0;
2586 err:
2587 dmz_cleanup_metadata(zmd);
2588 kfree(zmd);
2589 *metadata = NULL;
2590
2591 return ret;
2592 }
2593
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[linuxtv-media:master 443/495] drivers/staging/media/atomisp/pci/sh_css_sp.c:1039:23: warning: address of 'binary->in_frame_info' will always evaluate to 'true'
by kbuild test robot
tree: git://linuxtv.org/media_tree.git master
head: 960b2dee908b0fc51cf670841de13b40b44aaaae
commit: 085093606320ac76a062c99cf12e33c010417b4b [443/495] media: atomisp: allow building for isp2401
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e6658079aca6d971b4e9d7137a3a2ecbc9c34aec)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 085093606320ac76a062c99cf12e33c010417b4b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/staging/media/atomisp/pci/sh_css_sp.c:1039:23: warning: address of 'binary->in_frame_info' will always evaluate to 'true' [-Wpointer-bool-conversion]
} else if (&binary->in_frame_info) {
~~ ~~~~~~~~^~~~~~~~~~~~~
1 warning generated.
vim +1039 drivers/staging/media/atomisp/pci/sh_css_sp.c
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 937
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 938 initialize_stage_frames(&sh_css_sp_stage.frames);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 939 /*
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 940 * TODO: Make the Host dynamically determine
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 941 * the stage type.
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 942 */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 943 sh_css_sp_stage.stage_type = SH_CSS_ISP_STAGE_TYPE;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 944 sh_css_sp_stage.num = (uint8_t)stage;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 945 sh_css_sp_stage.isp_online = (uint8_t)binary->online;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 946 sh_css_sp_stage.isp_copy_vf = (uint8_t)args->copy_vf;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 947 sh_css_sp_stage.isp_copy_output = (uint8_t)args->copy_output;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 948 sh_css_sp_stage.enable.vf_output = (args->out_vf_frame != NULL);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 949
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 950 /* Copy the frame infos first, to be overwritten by the frames,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 951 if these are present.
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 952 */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 953 sh_css_sp_stage.frames.effective_in_res.width = binary->effective_in_frame_res.width;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 954 sh_css_sp_stage.frames.effective_in_res.height = binary->effective_in_frame_res.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 955
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 956 ia_css_frame_info_to_frame_sp_info(&sh_css_sp_stage.frames.in.info,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 957 &binary->in_frame_info);
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 958 for (i = 0; i < IA_CSS_BINARY_MAX_OUTPUT_PORTS; i++)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 959 {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 960 ia_css_frame_info_to_frame_sp_info(&sh_css_sp_stage.frames.out[i].info,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 961 &binary->out_frame_info[i]);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 962 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 963 ia_css_frame_info_to_frame_sp_info(&sh_css_sp_stage.frames.internal_frame_info,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 964 &binary->internal_frame_info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 965 sh_css_sp_stage.dvs_envelope.width = binary->dvs_envelope.width;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 966 sh_css_sp_stage.dvs_envelope.height = binary->dvs_envelope.height;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 967 sh_css_sp_stage.isp_pipe_version = (uint8_t)info->pipeline.isp_pipe_version;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 968 sh_css_sp_stage.isp_deci_log_factor = (uint8_t)binary->deci_factor_log2;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 969 sh_css_sp_stage.isp_vf_downscale_bits = (uint8_t)binary->vf_downscale_log2;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 970
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 971 sh_css_sp_stage.if_config_index = (uint8_t)if_config_index;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 972
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 973 sh_css_sp_stage.sp_enable_xnr = (uint8_t)xnr;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 974 sh_css_sp_stage.xmem_bin_addr = xinfo->xmem_addr;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 975 sh_css_sp_stage.xmem_map_addr = sh_css_params_ddr_address_map();
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 976 sh_css_isp_stage.blob_info = *blob_info;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 977 sh_css_stage_write_binary_info((struct ia_css_binary_info *)info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 978
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 979 /* Make sure binary name is smaller than allowed string size */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 980 assert(strlen(binary_name) < SH_CSS_MAX_BINARY_NAME - 1);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 981 strncpy(sh_css_isp_stage.binary_name, binary_name, SH_CSS_MAX_BINARY_NAME - 1);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 982 sh_css_isp_stage.binary_name[SH_CSS_MAX_BINARY_NAME - 1] = 0;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 983 sh_css_isp_stage.mem_initializers = *isp_mem_if;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 984
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 985 /*
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 986 * Even when a stage does not need uds and does not params,
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 987 * ia_css_uds_sp_scale_params() seems to be called (needs
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 988 * further investigation). This function can not deal with
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 989 * dx, dy = {0, 0}
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 990 */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 991
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 992 err = sh_css_sp_write_frame_pointers(args);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 993 /* TODO: move it to a better place */
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 994 if (binary->info->sp.enable.s3a)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 995 {
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 996 ia_css_query_internal_queue_id(IA_CSS_BUFFER_TYPE_3A_STATISTICS, thread_id,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 997 &queue_id);
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 998 sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.s3a_buf, queue_id,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 999 mmgr_EXCEPTION,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1000 IA_CSS_BUFFER_TYPE_3A_STATISTICS);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1001 }
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1002 if (binary->info->sp.enable.dis)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1003 {
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1004 ia_css_query_internal_queue_id(IA_CSS_BUFFER_TYPE_DIS_STATISTICS, thread_id,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1005 &queue_id);
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1006 sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.dvs_buf, queue_id,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1007 mmgr_EXCEPTION,
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1008 IA_CSS_BUFFER_TYPE_DIS_STATISTICS);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1009 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1010 #if defined SH_CSS_ENABLE_METADATA
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1011 ia_css_query_internal_queue_id(IA_CSS_BUFFER_TYPE_METADATA, thread_id, &queue_id);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1012 sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.metadata_buf, queue_id, mmgr_EXCEPTION, IA_CSS_BUFFER_TYPE_METADATA);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1013 #endif
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1014 if (err != IA_CSS_SUCCESS)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1015 return err;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1016
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1017 #ifdef USE_INPUT_SYSTEM_VERSION_2401
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1018 #ifndef ISP2401
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1019 if (args->in_frame)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1020 {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1021 pipe = find_pipe_by_num(sh_css_sp_group.pipe[thread_id].pipe_num);
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1022 if (!pipe)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1023 return IA_CSS_ERR_INTERNAL_ERROR;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1024 ia_css_get_crop_offsets(pipe, &args->in_frame->info);
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1025 } else if (&binary->in_frame_info)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1026 {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1027 pipe = find_pipe_by_num(sh_css_sp_group.pipe[thread_id].pipe_num);
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1028 if (!pipe)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1029 return IA_CSS_ERR_INTERNAL_ERROR;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1030 ia_css_get_crop_offsets(pipe, &binary->in_frame_info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1031 #else
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1032 if (stage == 0)
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1033 {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1034 if (args->in_frame) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1035 pipe = find_pipe_by_num(sh_css_sp_group.pipe[thread_id].pipe_num);
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1036 if (!pipe)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1037 return IA_CSS_ERR_INTERNAL_ERROR;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1038 ia_css_get_crop_offsets(pipe, &args->in_frame->info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 @1039 } else if (&binary->in_frame_info) {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1040 pipe = find_pipe_by_num(sh_css_sp_group.pipe[thread_id].pipe_num);
bdfe0beb95eebc drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1041 if (!pipe)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1042 return IA_CSS_ERR_INTERNAL_ERROR;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1043 ia_css_get_crop_offsets(pipe, &binary->in_frame_info);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1044 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1045 #endif
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1046 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1047 #else
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1048 (void)pipe; /*avoid build warning*/
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1049 #endif
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1050
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1051 err = configure_isp_from_args(&sh_css_sp_group.pipe[thread_id],
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1052 binary, args, two_ppc, sh_css_sp_stage.deinterleaved);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1053 if (err != IA_CSS_SUCCESS)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1054 return err;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1055
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1056 initialize_isp_states(binary);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1057
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1058 /* we do this only for preview pipe because in fill_binary_info function
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1059 * we assign vf_out res to out res, but for ISP internal processing, we need
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1060 * the original out res. for video pipe, it has two output pins --- out and
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1061 * vf_out, so it can keep these two resolutions already. */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1062 if (binary->info->sp.pipeline.mode == IA_CSS_BINARY_MODE_PREVIEW &&
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1063 (binary->vf_downscale_log2 > 0))
eaa399eb542cdf drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1064 {
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1065 /* TODO: Remove this after preview output decimation is fixed
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1066 * by configuring out&vf info fiels properly */
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1067 sh_css_sp_stage.frames.out[0].info.padded_width
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1068 <<= binary->vf_downscale_log2;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1069 sh_css_sp_stage.frames.out[0].info.res.width
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1070 <<= binary->vf_downscale_log2;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1071 sh_css_sp_stage.frames.out[0].info.res.height
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1072 <<= binary->vf_downscale_log2;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1073 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1074 err = copy_isp_mem_if_to_ddr(binary);
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1075 if (err != IA_CSS_SUCCESS)
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1076 return err;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1077
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1078 return IA_CSS_SUCCESS;
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1079 }
ad85094b293e40 drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c Mauro Carvalho Chehab 2020-04-19 1080
:::::: The code at line 1039 was first introduced by commit
:::::: ad85094b293e40e7a2f831b0311a389d952ebd5e Revert "media: staging: atomisp: Remove driver"
:::::: TO: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [RFC, WIP, v6 04/10] media: vidtv: add a bridge driver
by kbuild test robot
Hi "Daniel,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20200519]
[cannot apply to linus/master linux/master v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Daniel-W-S-Almeida/media-vidtv-i...
base: git://linuxtv.org/media_tree.git master
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> arch/x86/mm/init_64.c:1264:6: warning: no previous prototype for 'mark_rodata_ro' [-Wmissing-prototypes]
void mark_rodata_ro(void)
^~~~~~~~~~~~~~
vim +/mark_rodata_ro +1264 arch/x86/mm/init_64.c
16239630974516a arch/x86/mm/init_64.c Steven Rostedt 2009-02-17 1263
67df197b1a07944 arch/x86_64/mm/init.c Arjan van de Ven 2006-01-06 @1264 void mark_rodata_ro(void)
67df197b1a07944 arch/x86_64/mm/init.c Arjan van de Ven 2006-01-06 1265 {
74e081797bd9d2a arch/x86/mm/init_64.c Suresh Siddha 2009-10-14 1266 unsigned long start = PFN_ALIGN(_text);
fc8d782677f163d arch/x86/mm/init_64.c Alexander Duyck 2012-11-16 1267 unsigned long rodata_start = PFN_ALIGN(__start_rodata);
2d0004d19829c84 arch/x86/mm/init_64.c Kees Cook 2019-10-29 1268 unsigned long end = (unsigned long)__end_rodata_hpage_align;
2d0004d19829c84 arch/x86/mm/init_64.c Kees Cook 2019-10-29 1269 unsigned long text_end = PFN_ALIGN(_etext);
2d0004d19829c84 arch/x86/mm/init_64.c Kees Cook 2019-10-29 1270 unsigned long rodata_end = PFN_ALIGN(__end_rodata);
45e2a9d4701d8c6 arch/x86/mm/init_64.c Kees Cook 2014-11-14 1271 unsigned long all_end;
8f0f996e80b980f arch/x86/mm/init_64.c Steven Rostedt 2008-05-12 1272
6fb14755a676282 arch/x86_64/mm/init.c Jan Beulich 2007-05-02 1273 printk(KERN_INFO "Write protecting the kernel read-only data: %luk\n",
e3ebadd95cb621e arch/x86_64/mm/init.c Linus Torvalds 2007-05-07 1274 (end - start) >> 10);
984bb80d94d8915 arch/x86/mm/init_64.c Arjan van de Ven 2008-02-06 1275 set_memory_ro(start, (end - start) >> PAGE_SHIFT);
984bb80d94d8915 arch/x86/mm/init_64.c Arjan van de Ven 2008-02-06 1276
16239630974516a arch/x86/mm/init_64.c Steven Rostedt 2009-02-17 1277 kernel_set_to_readonly = 1;
16239630974516a arch/x86/mm/init_64.c Steven Rostedt 2009-02-17 1278
984bb80d94d8915 arch/x86/mm/init_64.c Arjan van de Ven 2008-02-06 1279 /*
72212675d1c96f5 arch/x86/mm/init_64.c Yinghai Lu 2013-01-24 1280 * The rodata/data/bss/brk section (but not the kernel text!)
72212675d1c96f5 arch/x86/mm/init_64.c Yinghai Lu 2013-01-24 1281 * should also be not-executable.
45e2a9d4701d8c6 arch/x86/mm/init_64.c Kees Cook 2014-11-14 1282 *
45e2a9d4701d8c6 arch/x86/mm/init_64.c Kees Cook 2014-11-14 1283 * We align all_end to PMD_SIZE because the existing mapping
45e2a9d4701d8c6 arch/x86/mm/init_64.c Kees Cook 2014-11-14 1284 * is a full PMD. If we would align _brk_end to PAGE_SIZE we
45e2a9d4701d8c6 arch/x86/mm/init_64.c Kees Cook 2014-11-14 1285 * split the PMD and the reminder between _brk_end and the end
45e2a9d4701d8c6 arch/x86/mm/init_64.c Kees Cook 2014-11-14 1286 * of the PMD will remain mapped executable.
45e2a9d4701d8c6 arch/x86/mm/init_64.c Kees Cook 2014-11-14 1287 *
45e2a9d4701d8c6 arch/x86/mm/init_64.c Kees Cook 2014-11-14 1288 * Any PMD which was setup after the one which covers _brk_end
45e2a9d4701d8c6 arch/x86/mm/init_64.c Kees Cook 2014-11-14 1289 * has been zapped already via cleanup_highmem().
984bb80d94d8915 arch/x86/mm/init_64.c Arjan van de Ven 2008-02-06 1290 */
45e2a9d4701d8c6 arch/x86/mm/init_64.c Kees Cook 2014-11-14 1291 all_end = roundup((unsigned long)_brk_end, PMD_SIZE);
ab76f7b4ab2397f arch/x86/mm/init_64.c Stephen Smalley 2015-10-01 1292 set_memory_nx(text_end, (all_end - text_end) >> PAGE_SHIFT);
67df197b1a07944 arch/x86_64/mm/init.c Arjan van de Ven 2006-01-06 1293
:::::: The code at line 1264 was first introduced by commit
:::::: 67df197b1a07944c2e0e40ded3d4fd07d108e110 [PATCH] x86/x86_64: mark rodata section read-only: x86-64 support
:::::: TO: Arjan van de Ven <arjan(a)infradead.org>
:::::: CC: Linus Torvalds <torvalds(a)g5.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[linuxtv-media:master 454/495] drivers/staging/media/atomisp/pci/sh_css_firmware.h:41:38: warning: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration
by kbuild test robot
tree: git://linuxtv.org/media_tree.git master
head: 960b2dee908b0fc51cf670841de13b40b44aaaae
commit: 8568fe630066a733456fb1ffc8e1402191d7e27c [454/495] media: atomisp: print a better message when fw version is wrong
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
git checkout 8568fe630066a733456fb1ffc8e1402191d7e27c
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from drivers/staging/media/atomisp/pci/sh_css_version.c:19:0:
>> drivers/staging/media/atomisp/pci/sh_css_firmware.h:41:38: warning: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration
sh_css_check_firmware_version(struct device *dev, const char *fw_data);
^~~~~~
drivers/staging/media/atomisp/pci/sh_css_firmware.h:44:29: warning: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration
sh_css_load_firmware(struct device *dev, const char *fw_data,
^~~~~~
vim +41 drivers/staging/media/atomisp/pci/sh_css_firmware.h
39
40 bool
> 41 sh_css_check_firmware_version(struct device *dev, const char *fw_data);
42
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[linux-next:master 8596/10701] drivers/net/ethernet/qlogic/qed/qed_hw.c:850:3: warning: function might be possible candidate for 'gnu_printf' format attribute
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
commit: d639836ab3363f935a9a4336cb4ea3828d0437dd [8596/10701] net: qed: adding hw_err states and handling
config: i386-randconfig-a006-20200520 (attached as .config)
compiler: gcc-6 (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
reproduce:
git checkout d639836ab3363f935a9a4336cb4ea3828d0437dd
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/net/ethernet/qlogic/qed/qed_hw.c: In function 'qed_hw_err_notify':
<< from drivers/net/ethernet/qlogic/qed/qed_hw.c:46:
>> drivers/net/ethernet/qlogic/qed/qed_hw.c:850:3: warning: function might be possible candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
len = vsnprintf(buf, QED_HW_ERR_MAX_STR_SIZE, fmt, vl);
^~~
In file included from drivers/net/ethernet/qlogic/qed/qed.h:51:0,
from drivers/net/ethernet/qlogic/qed/qed_hw.c:46:
At top level:
drivers/net/ethernet/qlogic/qed/qed_hsi.h:4421:18: warning: 'iro_arr' defined but not used [-Wunused-const-variable=]
static const u32 iro_arr[] = {
^~~~~~~
vim +/gnu_printf +850 drivers/net/ethernet/qlogic/qed/qed_hw.c
839
840 void qed_hw_err_notify(struct qed_hwfn *p_hwfn,
841 struct qed_ptt *p_ptt,
842 enum qed_hw_err_type err_type, char *fmt, ...)
843 {
844 char buf[QED_HW_ERR_MAX_STR_SIZE];
845 va_list vl;
846 int len;
847
848 if (fmt) {
849 va_start(vl, fmt);
> 850 len = vsnprintf(buf, QED_HW_ERR_MAX_STR_SIZE, fmt, vl);
851 va_end(vl);
852
853 if (len > QED_HW_ERR_MAX_STR_SIZE - 1)
854 len = QED_HW_ERR_MAX_STR_SIZE - 1;
855
856 DP_NOTICE(p_hwfn, "%s", buf);
857 }
858
859 /* Fan failure cannot be masked by handling of another HW error */
860 if (p_hwfn->cdev->recov_in_prog &&
861 err_type != QED_HW_ERR_FAN_FAIL) {
862 DP_VERBOSE(p_hwfn,
863 NETIF_MSG_DRV,
864 "Recovery is in progress. Avoid notifying about HW error %d.\n",
865 err_type);
866 return;
867 }
868
869 qed_hw_error_occurred(p_hwfn, err_type);
870 }
871
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 115a54162a6c0d0ef2aef25ebd0b61fc5e179ebe
commit: 6f09eae3b5d974ef845e56690d6bc2b8f2a70acd ata: expose ncq_enable_prio sysfs attribute only on NCQ capable hosts
date: 8 weeks ago
config: i386-randconfig-a005-20200520 (attached as .config)
compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
reproduce:
git checkout 6f09eae3b5d974ef845e56690d6bc2b8f2a70acd
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from include/linux/linkage.h:7:0,
from include/linux/kernel.h:8,
from drivers/ata/ahci_platform.c:11:
include/linux/export.h:19:30: warning: initialized field overwritten [-Woverride-init]
#define THIS_MODULE ((struct module *)0)
^
include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
.module = THIS_MODULE, ^
>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
__ATA_BASE_SHT(drv_name), ^
drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
ATA_NCQ_SHT(drv_name), ^
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro 'AHCI_SHT'
AHCI_SHT(DRV_NAME),
^
include/linux/export.h:19:30: warning: (near initialization for 'ahci_platform_sht.can_queue') [-Woverride-init]
#define THIS_MODULE ((struct module *)0)
^
include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
.module = THIS_MODULE, ^
>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
__ATA_BASE_SHT(drv_name), ^
drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
ATA_NCQ_SHT(drv_name), ^
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro 'AHCI_SHT'
AHCI_SHT(DRV_NAME),
^
include/linux/export.h:19:30: warning: initialized field overwritten [-Woverride-init]
#define THIS_MODULE ((struct module *)0)
^
include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
.module = THIS_MODULE, ^
>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
__ATA_BASE_SHT(drv_name), ^
drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
ATA_NCQ_SHT(drv_name), ^
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro 'AHCI_SHT'
AHCI_SHT(DRV_NAME),
^
include/linux/export.h:19:30: warning: (near initialization for 'ahci_platform_sht.sdev_attrs') [-Woverride-init]
#define THIS_MODULE ((struct module *)0)
^
include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
.module = THIS_MODULE, ^
>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
__ATA_BASE_SHT(drv_name), ^
drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
ATA_NCQ_SHT(drv_name), ^
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro 'AHCI_SHT'
AHCI_SHT(DRV_NAME),
^
vim +/__ATA_BASE_SHT +1366 include/linux/libata.h
1338
1339 /*
1340 * All sht initializers (BASE, PIO, BMDMA, NCQ) must be instantiated
1341 * by the edge drivers. Because the 'module' field of sht must be the
1342 * edge driver's module reference, otherwise the driver can be unloaded
1343 * even if the scsi_device is being accessed.
1344 */
1345 #define __ATA_BASE_SHT(drv_name) \
1346 .module = THIS_MODULE, \
1347 .name = drv_name, \
1348 .ioctl = ata_scsi_ioctl, \
1349 ATA_SCSI_COMPAT_IOCTL \
1350 .queuecommand = ata_scsi_queuecmd, \
1351 .can_queue = ATA_DEF_QUEUE, \
1352 .tag_alloc_policy = BLK_TAG_ALLOC_RR, \
1353 .this_id = ATA_SHT_THIS_ID, \
1354 .emulated = ATA_SHT_EMULATED, \
1355 .proc_name = drv_name, \
1356 .slave_configure = ata_scsi_slave_config, \
1357 .slave_destroy = ata_scsi_slave_destroy, \
1358 .bios_param = ata_std_bios_param, \
1359 .unlock_native_capacity = ata_scsi_unlock_native_capacity
1360
1361 #define ATA_BASE_SHT(drv_name) \
1362 __ATA_BASE_SHT(drv_name), \
1363 .sdev_attrs = ata_common_sdev_attrs
1364
1365 #define ATA_NCQ_SHT(drv_name) \
> 1366 __ATA_BASE_SHT(drv_name), \
1367 .sdev_attrs = ata_ncq_sdev_attrs, \
1368 .change_queue_depth = ata_scsi_change_queue_depth
1369
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [efi:next 22/40] ld.lld: warning: vsprintf.c:(.discard.unreachable+0x0): has non-ABS relocation R_X86_64_PC32 against symbol ''
by Fangrui Song
On 2020-05-20, Arvind Sankar wrote:
>On Wed, May 20, 2020 at 10:34:25AM -0700, Fangrui Song wrote:
>> On 2020-05-20, Ard Biesheuvel wrote:
>> >On Wed, 20 May 2020 at 17:53, Arvind Sankar <nivedita(a)alum.mit.edu> wrote:
>> >>
>> >> On Wed, May 20, 2020 at 10:28:13AM +0800, kbuild test robot wrote:
>> >> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
>> >> > head: e5fbadd1179cdadeaa44d71a9ec068c5bc100524
>> >> > commit: ce5e3f909fc0ed67e58367b9c56a54c20a51080b [22/40] efi/printf: Add 64-bit and 8-bit integer support
>> >> > config: x86_64-defconfig (attached as .config)
>> >> > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
>> >> > reproduce:
>> >> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> >> > chmod +x ~/bin/make.cross
>> >> > # install x86_64 cross compiling tool for clang build
>> >> > # apt-get install binutils-x86-64-linux-gnu
>> >> > git checkout ce5e3f909fc0ed67e58367b9c56a54c20a51080b
>> >> > # save the attached .config to linux build tree
>> >> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>> >> >
>> >> > If you fix the issue, kindly add following tag as appropriate
>> >> > Reported-by: kbuild test robot <lkp(a)intel.com>
>> >> >
>> >> > All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> >> >
>> >> > >> ld.lld: warning: vsprintf.c:(.discard.unreachable+0x0): has non-ABS relocation R_X86_64_PC32 against symbol ''
>> >> >
>> >> > ---
>> >> > 0-DAY CI Kernel Test Service, Intel Corporation
>> >> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>> >>
>> >> Clang folk, is anything actually wrong here? This seems to result from
>> >> use of unreachable() annotation, which generates these
>> >> .discard.unreachable sections apparently to help objtool.
>> >>
>> >
>> >This came up before, and IIRC, it has already been fixed, only this
>> >branch is based on v5.7-rc2.
>>
>> LLD reports the diagnostic because a PC-relative relocation referencing a
>> SHF_ALLOC section from a non-SHF_ALLOC section (.discard.unreachable) cannot be
>> reasonably represented. A non-SHF_ALLOC section is not part of the memory image, thus conceptually
>> the distance between a non-SHF_ALLOC and a SHF_ALLOC is not a constant which can be resolved at linktime.
>> This is actually a nice diagnostic which has caught a number of issues.
>>
>> % readelf -Wr drivers/firmware/efi/libstub/vsprintf.stub.o
>> ..
>> Relocation section '.rela.discard.unreachable' at offset 0xe38 contains 1 entry:
>> Offset Info Type Symbol's Value Symbol's Name + Addend
>> 0000000000000000 0000000600000002 R_X86_64_PC32 0000000000000000 .text + ac0
>>
>> ---
>>
>> The linker command line is:
>>
>> % ld.lld -m elf_x86_64 -T arch/x86/boot/compressed/vmlinux.lds arch/x86/boot/compressed/kernel_info.o arch/x86/boot/compressed/head_64.o arch/x86/boot/compressed/misc.o arch/x86/boot/compressed/string.o arch/x86/boot/compressed/cmdline.o arch/x86/boot/compressed/error.o arch/x86/boot/compressed/piggy.o arch/x86/boot/compressed/cpuflags.o arch/x86/boot/compressed/early_serial_console.o arch/x86/boot/compressed/kaslr.o arch/x86/boot/compressed/kaslr_64.o arch/x86/boot/compressed/mem_encrypt.o arch/x86/boot/compressed/pgtable_64.o arch/x86/boot/compressed/acpi.o drivers/firmware/efi/libstub/lib.a arch/x86/boot/compressed/efi_thunk_64.o -o arch/x86/boot/compressed/vmlinux
>> ld.lld: warning: vsprintf.c:(.discard.unreachable+0x0): has non-ABS relocation R_X86_64_PC32 against symbol ''
>>
>> arch/x86/boot/compressed/vmlinux has an output section .discard.unreachable , which is likely desired.
>
>You mean /not/ desired, right?
You are right:) I meant "undesired"
>
>>
>> Note that arch/x86/kernel/vmlinux.lds.S has an output section description /DISCARD/ : { ... *(.discard.*) ... },
>> but arch/x86/boot/compressed/vmlinux doesn't.
>>
>> We can let arch/x86/boot/compressed/vmlinux reuse the /DISCARD/ to fix the issue.
>
>Yep.
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git HEAD
does not have the warning.
https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git HEAD has the
warning.
Sent http://lore.kernel.org/r/20200520182010.242489-1-maskray@google.com
"[PATCH] x86/boot: Discard .discard.unreachable for arch/x86/boot/compressed/vmlinux"
which should fix the problem.
I am still a kernel newbie. I set To: to you and both x86(a)kernel.org and
linux-efi(a)vger.kernel.org
Hope that is correct.
2 years, 4 months
Re: [PATCH] usb: typec: Ensure USB_ROLE_SWITCH is a dependency for tps6598x
by kbuild test robot
Hi Bryan,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on balbi-usb/testing/next peter.chen-usb/ci-for-usb-next v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/usb-typec-Ensur...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: i386-tinyconfig
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
make ARCH=i386 tinyconfig
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/of/Kconfig:69:error: recursive dependency detected!
drivers/of/Kconfig:69: symbol OF_IRQ depends on IRQ_DOMAIN
kernel/irq/Kconfig:68: symbol IRQ_DOMAIN is selected by REGMAP
drivers/base/regmap/Kconfig:7: symbol REGMAP default is visible depending on REGMAP_I2C
drivers/base/regmap/Kconfig:19: symbol REGMAP_I2C is selected by TYPEC_TPS6598X
drivers/usb/typec/Kconfig:64: symbol TYPEC_TPS6598X depends on USB_ROLE_SWITCH
drivers/usb/roles/Kconfig:3: symbol USB_ROLE_SWITCH is selected by USB_MUSB_MEDIATEK
drivers/usb/musb/Kconfig:119: symbol USB_MUSB_MEDIATEK depends on GENERIC_PHY
drivers/phy/Kconfig:8: symbol GENERIC_PHY is selected by PHY_BCM_NS_USB3
drivers/phy/broadcom/Kconfig:41: symbol PHY_BCM_NS_USB3 depends on MDIO_BUS
drivers/net/phy/Kconfig:13: symbol MDIO_BUS depends on MDIO_DEVICE
drivers/net/phy/Kconfig:6: symbol MDIO_DEVICE is selected by PHYLIB
drivers/net/phy/Kconfig:243: symbol PHYLIB is selected by ARC_EMAC_CORE
drivers/net/ethernet/arc/Kconfig:19: symbol ARC_EMAC_CORE is selected by ARC_EMAC
drivers/net/ethernet/arc/Kconfig:25: symbol ARC_EMAC depends on OF_IRQ
For a resolution refer to Documentation/kbuild/kconfig-language.rst
subsection "Kconfig recursive dependency limitations"
vim +69 drivers/of/Kconfig
5ab5fc7e35705c Grant Likely 2010-07-05 14
19fd74879a32fb Grant Likely 2014-11-04 15 config OF_UNITTEST
19fd74879a32fb Grant Likely 2014-11-04 16 bool "Device Tree runtime unit tests"
6019a3d07d7258 Rob Herring 2017-07-25 17 depends on !SPARC
6019a3d07d7258 Rob Herring 2017-07-25 18 select IRQ_DOMAIN
649e0a77e28a77 Rob Herring 2015-05-28 19 select OF_EARLY_FLATTREE
2eb46da2a760e5 Grant Likely 2014-10-02 20 select OF_RESOLVE
53a42093d96ef5 Grant Likely 2011-12-12 21 help
53a42093d96ef5 Grant Likely 2011-12-12 22 This option builds in test cases for the device tree infrastructure
5d9270869b6cd3 Geert Uytterhoeven 2013-12-24 23 that are executed once at boot time, and the results dumped to the
53a42093d96ef5 Grant Likely 2011-12-12 24 console.
53a42093d96ef5 Grant Likely 2011-12-12 25
53a42093d96ef5 Grant Likely 2011-12-12 26 If unsure, say N here, but this option is safe to enable.
53a42093d96ef5 Grant Likely 2011-12-12 27
1b7c501b51a8c8 Rob Herring 2015-10-06 28 config OF_ALL_DTBS
1b7c501b51a8c8 Rob Herring 2015-10-06 29 bool "Build all Device Tree Blobs"
1b7c501b51a8c8 Rob Herring 2015-10-06 30 depends on COMPILE_TEST
1b7c501b51a8c8 Rob Herring 2015-10-06 31 select DTC
1b7c501b51a8c8 Rob Herring 2015-10-06 32 help
1b7c501b51a8c8 Rob Herring 2015-10-06 33 This option builds all possible Device Tree Blobs (DTBs) for the
1b7c501b51a8c8 Rob Herring 2015-10-06 34 current architecture.
1b7c501b51a8c8 Rob Herring 2015-10-06 35
1b7c501b51a8c8 Rob Herring 2015-10-06 36 If unsure, say N here, but this option is safe to enable.
1b7c501b51a8c8 Rob Herring 2015-10-06 37
e169cfbef46d62 Grant Likely 2009-11-23 38 config OF_FLATTREE
e169cfbef46d62 Grant Likely 2009-11-23 39 bool
5ab5fc7e35705c Grant Likely 2010-07-05 40 select DTC
e6a6928c3ea1d0 Rob Herring 2014-04-02 41 select LIBFDT
08d53aa58cb162 Ard Biesheuvel 2014-11-14 42 select CRC32
e169cfbef46d62 Grant Likely 2009-11-23 43
e6ce1324e4f08b Stephen Neuendorffer 2010-11-18 44 config OF_EARLY_FLATTREE
e6ce1324e4f08b Stephen Neuendorffer 2010-11-18 45 bool
ff4c25f26a71b7 Christoph Hellwig 2019-02-03 46 select DMA_DECLARE_COHERENT if HAS_DMA
e6ce1324e4f08b Stephen Neuendorffer 2010-11-18 47 select OF_FLATTREE
e6ce1324e4f08b Stephen Neuendorffer 2010-11-18 48
3cfc535c5df812 Andres Salomon 2010-10-10 49 config OF_PROMTREE
3cfc535c5df812 Andres Salomon 2010-10-10 50 bool
3cfc535c5df812 Andres Salomon 2010-10-10 51
b56b5528f5b3c3 Rob Herring 2017-10-04 52 config OF_KOBJ
b56b5528f5b3c3 Rob Herring 2017-10-04 53 def_bool SYSFS
b56b5528f5b3c3 Rob Herring 2017-10-04 54
0f22dd395fc473 Grant Likely 2012-02-15 55 # Hardly any platforms need this. It is safe to select, but only do so if you
0f22dd395fc473 Grant Likely 2012-02-15 56 # need it.
fcdeb7fedf89f4 Grant Likely 2010-01-29 57 config OF_DYNAMIC
121c92cad33db2 Geert Uytterhoeven 2015-01-23 58 bool "Support for dynamic device trees" if OF_UNITTEST
b56b5528f5b3c3 Rob Herring 2017-10-04 59 select OF_KOBJ
121c92cad33db2 Geert Uytterhoeven 2015-01-23 60 help
121c92cad33db2 Geert Uytterhoeven 2015-01-23 61 On some platforms, the device tree can be manipulated at runtime.
121c92cad33db2 Geert Uytterhoeven 2015-01-23 62 While this option is selected automatically on such platforms, you
121c92cad33db2 Geert Uytterhoeven 2015-01-23 63 can enable it manually to improve device tree unit test coverage.
fcdeb7fedf89f4 Grant Likely 2010-01-29 64
6b884a8d50a6ee Grant Likely 2010-06-08 65 config OF_ADDRESS
6b884a8d50a6ee Grant Likely 2010-06-08 66 def_bool y
6019a3d07d7258 Rob Herring 2017-07-25 67 depends on !SPARC && (HAS_IOMEM || UML)
6b884a8d50a6ee Grant Likely 2010-06-08 68
e3873444990dd6 Grant Likely 2010-06-18 @69 config OF_IRQ
e3873444990dd6 Grant Likely 2010-06-18 70 def_bool y
63c60e3a6dc3ec Geert Uytterhoeven 2015-04-05 71 depends on !SPARC && IRQ_DOMAIN
e3873444990dd6 Grant Likely 2010-06-18 72
:::::: The code at line 69 was first introduced by commit
:::::: e3873444990dd6f8a095d1f72b5ad45192f8c506 of/irq: Move irq_of_parse_and_map() to common code
:::::: TO: Grant Likely <grant.likely(a)secretlab.ca>
:::::: CC: Grant Likely <grant.likely(a)secretlab.ca>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months