Re: [efi:next 39/40] drivers/firmware/efi/libstub/efi-stub-helper.c:265 efi_convert_cmdline() warn: qualifier 'l' ignored for %s specifier
by Dan Carpenter
On Wed, May 20, 2020 at 02:00:08PM -0400, Arvind Sankar wrote:
> On Wed, May 20, 2020 at 08:54:49PM +0300, Dan Carpenter wrote:
> > On Wed, May 20, 2020 at 11:43:08AM -0400, Arvind Sankar wrote:
> > > On Wed, May 20, 2020 at 05:09:03PM +0300, Dan Carpenter wrote:
> > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
> > > > head: e5fbadd1179cdadeaa44d71a9ec068c5bc100524
> > > > commit: 85f5afd4322d294a7eca0d304744a1646113fbd9 [39/40] efi/libstub: Use snprintf with %ls to convert the command line
> > > > config: x86_64-defconfig (attached as .config)
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kbuild test robot <lkp(a)intel.com>
> > > > Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
> > > >
> > > > New smatch warnings:
> > > > drivers/firmware/efi/libstub/efi-stub-helper.c:265 efi_convert_cmdline() warn: qualifier 'l' ignored for %s specifier
> > > >
> > > > # https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/commit/?id=85...
> > > > git remote add efi https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git
> > > > git remote update efi
> > > > git checkout 85f5afd4322d294a7eca0d304744a1646113fbd9
> > > > vim +/l +265 drivers/firmware/efi/libstub/efi-stub-helper.c
> > > >
> > > > c625d1c203941f drivers/firmware/efi/efi-stub-helper.c H. Peter Anvin 2013-09-20 258 options_bytes++; /* NUL termination */
> > > > 9403e462fb5ffa drivers/firmware/efi/efi-stub-helper.c Leif Lindholm 2014-04-04 259
> > > > 1e45bf7372c48c drivers/firmware/efi/libstub/efi-stub-helper.c Ard Biesheuvel 2020-02-10 260 status = efi_allocate_pages(options_bytes, &cmdline_addr, max_addr);
> > > > 5fef3870c572a3 drivers/firmware/efi/efi-stub-helper.c Roy Franz 2013-09-22 261 if (status != EFI_SUCCESS)
> > > > 5fef3870c572a3 drivers/firmware/efi/efi-stub-helper.c Roy Franz 2013-09-22 262 return NULL;
> > > > 5fef3870c572a3 drivers/firmware/efi/efi-stub-helper.c Roy Franz 2013-09-22 263
> > > > 85f5afd4322d29 drivers/firmware/efi/libstub/efi-stub-helper.c Arvind Sankar 2020-05-18 264 snprintf((char *)cmdline_addr, options_bytes, "%.*ls",
> > > > ^
> > > > The "l" doesn't make sense here?
> > >
> > > The previous patches add support for wide strings to the version of
> > > snprintf used here.
> >
> > Ah. Thanks. I will update the Smatch check.
> >
> > regards,
> > dan carpenter
> >
> Note that the main kernel's printf still doesn't support it. It's only
> been added to the version in drivers/firmware/efi/libstub/vsprintf.c
> (added as part of this series).
Ah... I looked and looked at lib/vsprintf.c and wondered if I was going
mad. :P Thanks.
regards,
dan carpenter
2 years, 4 months
Re: [efi:next 39/40] drivers/firmware/efi/libstub/efi-stub-helper.c:265 efi_convert_cmdline() warn: qualifier 'l' ignored for %s specifier
by Ard Biesheuvel
On Wed, 20 May 2020 at 20:00, Arvind Sankar <nivedita(a)alum.mit.edu> wrote:
>
> On Wed, May 20, 2020 at 08:54:49PM +0300, Dan Carpenter wrote:
> > On Wed, May 20, 2020 at 11:43:08AM -0400, Arvind Sankar wrote:
> > > On Wed, May 20, 2020 at 05:09:03PM +0300, Dan Carpenter wrote:
> > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
> > > > head: e5fbadd1179cdadeaa44d71a9ec068c5bc100524
> > > > commit: 85f5afd4322d294a7eca0d304744a1646113fbd9 [39/40] efi/libstub: Use snprintf with %ls to convert the command line
> > > > config: x86_64-defconfig (attached as .config)
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kbuild test robot <lkp(a)intel.com>
> > > > Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
> > > >
> > > > New smatch warnings:
> > > > drivers/firmware/efi/libstub/efi-stub-helper.c:265 efi_convert_cmdline() warn: qualifier 'l' ignored for %s specifier
> > > >
> > > > # https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/commit/?id=85...
> > > > git remote add efi https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git
> > > > git remote update efi
> > > > git checkout 85f5afd4322d294a7eca0d304744a1646113fbd9
> > > > vim +/l +265 drivers/firmware/efi/libstub/efi-stub-helper.c
> > > >
> > > > c625d1c203941f drivers/firmware/efi/efi-stub-helper.c H. Peter Anvin 2013-09-20 258 options_bytes++; /* NUL termination */
> > > > 9403e462fb5ffa drivers/firmware/efi/efi-stub-helper.c Leif Lindholm 2014-04-04 259
> > > > 1e45bf7372c48c drivers/firmware/efi/libstub/efi-stub-helper.c Ard Biesheuvel 2020-02-10 260 status = efi_allocate_pages(options_bytes, &cmdline_addr, max_addr);
> > > > 5fef3870c572a3 drivers/firmware/efi/efi-stub-helper.c Roy Franz 2013-09-22 261 if (status != EFI_SUCCESS)
> > > > 5fef3870c572a3 drivers/firmware/efi/efi-stub-helper.c Roy Franz 2013-09-22 262 return NULL;
> > > > 5fef3870c572a3 drivers/firmware/efi/efi-stub-helper.c Roy Franz 2013-09-22 263
> > > > 85f5afd4322d29 drivers/firmware/efi/libstub/efi-stub-helper.c Arvind Sankar 2020-05-18 264 snprintf((char *)cmdline_addr, options_bytes, "%.*ls",
> > > > ^
> > > > The "l" doesn't make sense here?
> > >
> > > The previous patches add support for wide strings to the version of
> > > snprintf used here.
> >
> > Ah. Thanks. I will update the Smatch check.
> >
> > regards,
> > dan carpenter
> >
> Note that the main kernel's printf still doesn't support it. It's only
> been added to the version in drivers/firmware/efi/libstub/vsprintf.c
> (added as part of this series).
... which is justified, given how heavily EFI depends on UTF-16 support.
2 years, 4 months
Re: [efi:next 39/40] drivers/firmware/efi/libstub/efi-stub-helper.c:265 efi_convert_cmdline() warn: qualifier 'l' ignored for %s specifier
by Dan Carpenter
On Wed, May 20, 2020 at 11:43:08AM -0400, Arvind Sankar wrote:
> On Wed, May 20, 2020 at 05:09:03PM +0300, Dan Carpenter wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
> > head: e5fbadd1179cdadeaa44d71a9ec068c5bc100524
> > commit: 85f5afd4322d294a7eca0d304744a1646113fbd9 [39/40] efi/libstub: Use snprintf with %ls to convert the command line
> > config: x86_64-defconfig (attached as .config)
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp(a)intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
> >
> > New smatch warnings:
> > drivers/firmware/efi/libstub/efi-stub-helper.c:265 efi_convert_cmdline() warn: qualifier 'l' ignored for %s specifier
> >
> > # https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/commit/?id=85...
> > git remote add efi https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git
> > git remote update efi
> > git checkout 85f5afd4322d294a7eca0d304744a1646113fbd9
> > vim +/l +265 drivers/firmware/efi/libstub/efi-stub-helper.c
> >
> > c625d1c203941f drivers/firmware/efi/efi-stub-helper.c H. Peter Anvin 2013-09-20 258 options_bytes++; /* NUL termination */
> > 9403e462fb5ffa drivers/firmware/efi/efi-stub-helper.c Leif Lindholm 2014-04-04 259
> > 1e45bf7372c48c drivers/firmware/efi/libstub/efi-stub-helper.c Ard Biesheuvel 2020-02-10 260 status = efi_allocate_pages(options_bytes, &cmdline_addr, max_addr);
> > 5fef3870c572a3 drivers/firmware/efi/efi-stub-helper.c Roy Franz 2013-09-22 261 if (status != EFI_SUCCESS)
> > 5fef3870c572a3 drivers/firmware/efi/efi-stub-helper.c Roy Franz 2013-09-22 262 return NULL;
> > 5fef3870c572a3 drivers/firmware/efi/efi-stub-helper.c Roy Franz 2013-09-22 263
> > 85f5afd4322d29 drivers/firmware/efi/libstub/efi-stub-helper.c Arvind Sankar 2020-05-18 264 snprintf((char *)cmdline_addr, options_bytes, "%.*ls",
> > ^
> > The "l" doesn't make sense here?
>
> The previous patches add support for wide strings to the version of
> snprintf used here.
Ah. Thanks. I will update the Smatch check.
regards,
dan carpenter
2 years, 4 months
[hnaz-linux-mm:master 548/598] include/linux/highmem.h:302:20: error: passing argument 1 of 'flush_dcache_page' from incompatible pointer type
by kbuild test robot
tree: https://github.com/hnaz/linux-mm master
head: 4de4e4acf3af9fd196651696c657fc870168aed7
commit: 49588d0abed53aad206bd1c969a9d3205c1b3bd0 [548/598] asm-generic: don't include <linux/mm.h> in cacheflush.h
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 49588d0abed53aad206bd1c969a9d3205c1b3bd0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
In file included from ./arch/s390/include/generated/asm/cacheflush.h:1,
from drivers/media/platform/omap3isp/ispvideo.c:13:
include/asm-generic/cacheflush.h:18:42: warning: 'struct mm_struct' declared inside parameter list will not be visible outside of this definition or declaration
18 | static inline void flush_cache_mm(struct mm_struct *mm)
| ^~~~~~~~~
include/asm-generic/cacheflush.h:24:46: warning: 'struct mm_struct' declared inside parameter list will not be visible outside of this definition or declaration
24 | static inline void flush_cache_dup_mm(struct mm_struct *mm)
| ^~~~~~~~~
include/asm-generic/cacheflush.h:30:45: warning: 'struct vm_area_struct' declared inside parameter list will not be visible outside of this definition or declaration
30 | static inline void flush_cache_range(struct vm_area_struct *vma,
| ^~~~~~~~~~~~~~
include/asm-generic/cacheflush.h:38:44: warning: 'struct vm_area_struct' declared inside parameter list will not be visible outside of this definition or declaration
38 | static inline void flush_cache_page(struct vm_area_struct *vma,
| ^~~~~~~~~~~~~~
include/asm-generic/cacheflush.h:46:45: warning: 'struct page' declared inside parameter list will not be visible outside of this definition or declaration
46 | static inline void flush_dcache_page(struct page *page)
| ^~~~
include/asm-generic/cacheflush.h:52:50: warning: 'struct address_space' declared inside parameter list will not be visible outside of this definition or declaration
52 | static inline void flush_dcache_mmap_lock(struct address_space *mapping)
| ^~~~~~~~~~~~~
include/asm-generic/cacheflush.h:58:52: warning: 'struct address_space' declared inside parameter list will not be visible outside of this definition or declaration
58 | static inline void flush_dcache_mmap_unlock(struct address_space *mapping)
| ^~~~~~~~~~~~~
include/asm-generic/cacheflush.h:71:17: warning: 'struct page' declared inside parameter list will not be visible outside of this definition or declaration
71 | struct page *page)
| ^~~~
include/asm-generic/cacheflush.h:70:45: warning: 'struct vm_area_struct' declared inside parameter list will not be visible outside of this definition or declaration
70 | static inline void flush_icache_page(struct vm_area_struct *vma,
| ^~~~~~~~~~~~~~
include/asm-generic/cacheflush.h:78:16: warning: 'struct page' declared inside parameter list will not be visible outside of this definition or declaration
78 | struct page *page,
| ^~~~
include/asm-generic/cacheflush.h:77:51: warning: 'struct vm_area_struct' declared inside parameter list will not be visible outside of this definition or declaration
77 | static inline void flush_icache_user_range(struct vm_area_struct *vma,
| ^~~~~~~~~~~~~~
In file included from include/linux/pagemap.h:11,
from drivers/media/platform/omap3isp/ispvideo.c:17:
include/linux/highmem.h: In function 'zero_user_segments':
>> include/linux/highmem.h:302:20: error: passing argument 1 of 'flush_dcache_page' from incompatible pointer type [-Werror=incompatible-pointer-types]
302 | flush_dcache_page(page);
| ^~~~
| |
| struct page *
In file included from ./arch/s390/include/generated/asm/cacheflush.h:1,
from drivers/media/platform/omap3isp/ispvideo.c:13:
include/asm-generic/cacheflush.h:46:51: note: expected 'struct page *' but argument is of type 'struct page *'
46 | static inline void flush_dcache_page(struct page *page)
| ~~~~~~~~~~~~~^~~~
cc1: some warnings being treated as errors
vim +/flush_dcache_page +302 include/linux/highmem.h
^1da177e4c3f415 Linus Torvalds 2005-04-16 286
eebd2aa355692af Christoph Lameter 2008-02-04 287 static inline void zero_user_segments(struct page *page,
eebd2aa355692af Christoph Lameter 2008-02-04 288 unsigned start1, unsigned end1,
eebd2aa355692af Christoph Lameter 2008-02-04 289 unsigned start2, unsigned end2)
eebd2aa355692af Christoph Lameter 2008-02-04 290 {
1ec9c5ddc17aa39 Cong Wang 2011-11-25 291 void *kaddr = kmap_atomic(page);
eebd2aa355692af Christoph Lameter 2008-02-04 292
eebd2aa355692af Christoph Lameter 2008-02-04 293 BUG_ON(end1 > PAGE_SIZE || end2 > PAGE_SIZE);
eebd2aa355692af Christoph Lameter 2008-02-04 294
eebd2aa355692af Christoph Lameter 2008-02-04 295 if (end1 > start1)
eebd2aa355692af Christoph Lameter 2008-02-04 296 memset(kaddr + start1, 0, end1 - start1);
eebd2aa355692af Christoph Lameter 2008-02-04 297
eebd2aa355692af Christoph Lameter 2008-02-04 298 if (end2 > start2)
eebd2aa355692af Christoph Lameter 2008-02-04 299 memset(kaddr + start2, 0, end2 - start2);
eebd2aa355692af Christoph Lameter 2008-02-04 300
1ec9c5ddc17aa39 Cong Wang 2011-11-25 301 kunmap_atomic(kaddr);
eebd2aa355692af Christoph Lameter 2008-02-04 @302 flush_dcache_page(page);
eebd2aa355692af Christoph Lameter 2008-02-04 303 }
eebd2aa355692af Christoph Lameter 2008-02-04 304
:::::: The code at line 302 was first introduced by commit
:::::: eebd2aa355692afaf9906f62118620f1a1c19dbb Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user
:::::: TO: Christoph Lameter <clameter(a)sgi.com>
:::::: CC: Linus Torvalds <torvalds(a)woody.linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [efi:next 22/40] ld.lld: warning: vsprintf.c:(.discard.unreachable+0x0): has non-ABS relocation R_X86_64_PC32 against symbol ''
by Ard Biesheuvel
On Wed, 20 May 2020 at 17:53, Arvind Sankar <nivedita(a)alum.mit.edu> wrote:
>
> On Wed, May 20, 2020 at 10:28:13AM +0800, kbuild test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
> > head: e5fbadd1179cdadeaa44d71a9ec068c5bc100524
> > commit: ce5e3f909fc0ed67e58367b9c56a54c20a51080b [22/40] efi/printf: Add 64-bit and 8-bit integer support
> > config: x86_64-defconfig (attached as .config)
> > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
> > reproduce:
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # install x86_64 cross compiling tool for clang build
> > # apt-get install binutils-x86-64-linux-gnu
> > git checkout ce5e3f909fc0ed67e58367b9c56a54c20a51080b
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp(a)intel.com>
> >
> > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> >
> > >> ld.lld: warning: vsprintf.c:(.discard.unreachable+0x0): has non-ABS relocation R_X86_64_PC32 against symbol ''
> >
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
> Clang folk, is anything actually wrong here? This seems to result from
> use of unreachable() annotation, which generates these
> .discard.unreachable sections apparently to help objtool.
>
This came up before, and IIRC, it has already been fixed, only this
branch is based on v5.7-rc2.
2 years, 4 months
Re: [tip:x86/mm 1/23] arch/x86/mm/init.c:75:6: warning: no previous prototype for function 'x86_has_pat_wp'
by Nick Desaulniers
Masahiro and Philip,
We're seeing a bunch of -Wmissing-prototypes warnings from 0day bot
suddenly today. Did something change on the Kbuild or 0day bot side?
On Tue, May 19, 2020 at 2:25 PM Nathan Chancellor
<natechancellor(a)gmail.com> wrote:
>
> On Tue, May 19, 2020 at 10:55:05PM +0200, Borislav Petkov wrote:
> > On Wed, May 20, 2020 at 01:51:25AM +0800, kbuild test robot wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/mm
> > > head: bd1de2a7aace4d1d312fb1be264b8fafdb706208
> > > commit: 1f6f655e01adebf5bd5e6c3da2e843c104ded051 [1/23] x86/mm: Add a x86_has_pat_wp() helper
> > > config: x86_64-randconfig-r012-20200519 (attached as .config)
> > > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
> > > reproduce:
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # install x86_64 cross compiling tool for clang build
> > > # apt-get install binutils-x86-64-linux-gnu
> > > git checkout 1f6f655e01adebf5bd5e6c3da2e843c104ded051
> > > # save the attached .config to linux build tree
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kbuild test robot <lkp(a)intel.com>
> > >
> > > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> > >
> > > >> arch/x86/mm/init.c:75:6: warning: no previous prototype for function 'x86_has_pat_wp' [-Wmissing-prototypes]
> > > bool x86_has_pat_wp(void)
> > > ^
> >
> > Triggers with gcc too:
> >
> > make W=1 arch/x86/mm/init.o
> >
> > ...
> >
> > arch/x86/mm/init.c:81:6: warning: no previous prototype for ‘x86_has_pat_wp’ [-Wmissing-prototypes]
> > 81 | bool x86_has_pat_wp(void)
> > | ^~~~~~~~~~~~~~
> >
> >
> > -Wmissing-prototypes is default off, though, dunno why clang 11 has it
> > on.
>
> It doesn't: https://godbolt.org/z/rU5_5H
>
> I assume this is caused by some sort of internal change to the 0day
> infrastructure (testing W=1?)
>
> I cannot see this without adding W=1 to make at the listed commit with
> the provided config.
>
> Cheers,
> Nathan
>
> > Anyway, something for Benni to fix. CCed and leaving the rest for him as
> > reference.
> >
> > > arch/x86/mm/init.c:75:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > > bool x86_has_pat_wp(void)
> > > ^
> > > static
> > > arch/x86/mm/init.c:866:13: warning: no previous prototype for function 'mem_encrypt_free_decrypted_mem' [-Wmissing-prototypes]
> > > void __weak mem_encrypt_free_decrypted_mem(void) { }
> > > ^
> > > arch/x86/mm/init.c:866:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > > void __weak mem_encrypt_free_decrypted_mem(void) { }
> > > ^
> > > static
> > > 2 warnings generated.
> > >
> > > vim +/x86_has_pat_wp +75 arch/x86/mm/init.c
> > >
> > > 73
> > > 74 /* Check that the write-protect PAT entry is set for write-protect */
> > > > 75 bool x86_has_pat_wp(void)
> > > 76 {
> > > 77 return __pte2cachemode_tbl[_PAGE_CACHE_MODE_WP] == _PAGE_CACHE_MODE_WP;
> > > 78 }
> > > 79
> > >
> > > ---
> > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> >
> >
> >
> > --
> > Regards/Gruss,
> > Boris.
> >
> > https://people.kernel.org/tglx/notes-about-netiquette
> >
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe(a)googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200519212541.GA3580....
--
Thanks,
~Nick Desaulniers
2 years, 4 months
[balbi-usb:next 69/89] drivers/usb/dwc3/gadget.c:1885:7: note: in expansion of macro 'DWC3_VER_IS_WITHIN'
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
head: a65a1ec70639afa5ff7990cf33213dd41f3c7176
commit: edecc785996030331a83dddaeee960ab9302c608 [69/89] usb: dwc3: Add support for DWC_usb32 IP
config: microblaze-randconfig-s002-20200520 (attached as .config)
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-193-gb8fad4bc-dirty
git checkout edecc785996030331a83dddaeee960ab9302c608
# save the attached .config to linux build tree
make C=1 ARCH=microblaze CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from drivers/usb/dwc3/debug.h:14,
from drivers/usb/dwc3/gadget.c:25:
drivers/usb/dwc3/gadget.c: In function 'dwc3_gadget_run_stop':
drivers/usb/dwc3/core.h:1413:17: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1413 | dwc->revision >= _ip##_REVISION_##_from && | ^~
>> drivers/usb/dwc3/gadget.c:1885:7: note: in expansion of macro 'DWC3_VER_IS_WITHIN'
1885 | if (DWC3_VER_IS_WITHIN(DWC3, ANY, 187A)) {
| ^~~~~~~~~~~~~~~~~~
drivers/usb/dwc3/gadget.c: In function 'dwc3_gadget_conndone_interrupt':
drivers/usb/dwc3/core.h:1413:17: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1413 | dwc->revision >= _ip##_REVISION_##_from && | ^~
drivers/usb/dwc3/gadget.c:3025:7: note: in expansion of macro 'DWC3_VER_IS_WITHIN'
3025 | if (!DWC3_VER_IS_WITHIN(DWC3, ANY, 194A) &&
| ^~~~~~~~~~~~~~~~~~
vim +/DWC3_VER_IS_WITHIN +1885 drivers/usb/dwc3/gadget.c
1874
1875 static int dwc3_gadget_run_stop(struct dwc3 *dwc, int is_on, int suspend)
1876 {
1877 u32 reg;
1878 u32 timeout = 500;
1879
1880 if (pm_runtime_suspended(dwc->dev))
1881 return 0;
1882
1883 reg = dwc3_readl(dwc->regs, DWC3_DCTL);
1884 if (is_on) {
> 1885 if (DWC3_VER_IS_WITHIN(DWC3, ANY, 187A)) {
1886 reg &= ~DWC3_DCTL_TRGTULST_MASK;
1887 reg |= DWC3_DCTL_TRGTULST_RX_DET;
1888 }
1889
1890 if (!DWC3_VER_IS_PRIOR(DWC3, 194A))
1891 reg &= ~DWC3_DCTL_KEEP_CONNECT;
1892 reg |= DWC3_DCTL_RUN_STOP;
1893
1894 if (dwc->has_hibernation)
1895 reg |= DWC3_DCTL_KEEP_CONNECT;
1896
1897 dwc->pullups_connected = true;
1898 } else {
1899 reg &= ~DWC3_DCTL_RUN_STOP;
1900
1901 if (dwc->has_hibernation && !suspend)
1902 reg &= ~DWC3_DCTL_KEEP_CONNECT;
1903
1904 dwc->pullups_connected = false;
1905 }
1906
1907 dwc3_gadget_dctl_write_safe(dwc, reg);
1908
1909 do {
1910 reg = dwc3_readl(dwc->regs, DWC3_DSTS);
1911 reg &= DWC3_DSTS_DEVCTRLHLT;
1912 } while (--timeout && !(!is_on ^ !reg));
1913
1914 if (!timeout)
1915 return -ETIMEDOUT;
1916
1917 return 0;
1918 }
1919
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [RFC, WIP, v6 04/10] media: vidtv: add a bridge driver
by kbuild test robot
Hi "Daniel,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20200519]
[cannot apply to linus/master linux/master v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Daniel-W-S-Almeida/media-vidtv-i...
base: git://linuxtv.org/media_tree.git master
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> arch/x86/mm/init_32.c:872:6: warning: no previous prototype for 'mark_rodata_ro' [-Wmissing-prototypes]
void mark_rodata_ro(void)
^~~~~~~~~~~~~~
vim +/mark_rodata_ro +872 arch/x86/mm/init_32.c
5bd5a452662bc37 arch/x86/mm/init_32.c Matthieu CASTET 2010-11-16 871
63aaf3086baea7b arch/i386/mm/init.c Arjan van de Ven 2006-01-06 @872 void mark_rodata_ro(void)
63aaf3086baea7b arch/i386/mm/init.c Arjan van de Ven 2006-01-06 873 {
6fb14755a676282 arch/i386/mm/init.c Jan Beulich 2007-05-02 874 unsigned long start = PFN_ALIGN(_text);
2a25dc7c79c92c6 arch/x86/mm/init_32.c Thomas Gleixner 2018-09-17 875 unsigned long size = (unsigned long)__end_rodata - start;
63aaf3086baea7b arch/i386/mm/init.c Arjan van de Ven 2006-01-06 876
6d238cc4dc8a36a arch/x86/mm/init_32.c Arjan van de Ven 2008-01-30 877 set_pages_ro(virt_to_page(start), size >> PAGE_SHIFT);
2a25dc7c79c92c6 arch/x86/mm/init_32.c Thomas Gleixner 2018-09-17 878 pr_info("Write protecting kernel text and read-only data: %luk\n",
d7d119d777d7ed2 arch/x86/mm/init_32.c Ingo Molnar 2008-01-30 879 size >> 10);
0c42f392767d359 arch/x86/mm/init_32.c Andi Kleen 2008-01-30 880
16239630974516a arch/x86/mm/init_32.c Steven Rostedt 2009-02-17 881 kernel_set_to_readonly = 1;
16239630974516a arch/x86/mm/init_32.c Steven Rostedt 2009-02-17 882
:::::: The code at line 872 was first introduced by commit
:::::: 63aaf3086baea7b94c218053af8237f9dbac5d05 [PATCH] x86/x86_64: mark rodata section read only: x86 parts
:::::: TO: Arjan van de Ven <arjan(a)infradead.org>
:::::: CC: Linus Torvalds <torvalds(a)g5.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[linux-next:master 1487/10701] drivers/firmware/arm_scmi/smc.c:109:2: error: write to reserved register 'R7'
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
commit: 1dc6558062dadfabd2fb3bd885fa6e92ec7196f2 [1487/10701] firmware: arm_scmi: Add smc/hvc transport
config: arm-randconfig-r005-20200519 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
git checkout 1dc6558062dadfabd2fb3bd885fa6e92ec7196f2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/firmware/arm_scmi/smc.c:109:2: error: write to reserved register 'R7'
arm_smccc_1_1_invoke(scmi_info->func_id, 0, 0, 0, 0, 0, 0, 0, &res);
^
include/linux/arm-smccc.h:357:4: note: expanded from macro 'arm_smccc_1_1_invoke'
arm_smccc_1_1_smc(__VA_ARGS__); ^
include/linux/arm-smccc.h:299:48: note: expanded from macro 'arm_smccc_1_1_smc'
#define arm_smccc_1_1_smc(...) __arm_smccc_1_1(SMCCC_SMC_INST, __VA_ARGS__)
^
include/linux/arm-smccc.h:176:24: note: expanded from macro 'SMCCC_SMC_INST'
#define SMCCC_SMC_INST __SMC(0)
^
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
arch/arm/include/asm/opcodes.h:210:2: note: expanded from macro '__inst_arm_thumb32'
__inst_thumb32(thumb_opcode)
^
arch/arm/include/asm/opcodes.h:200:27: note: expanded from macro '__inst_thumb32'
#define __inst_thumb32(x) ___inst_thumb32( ^
arch/arm/include/asm/opcodes.h:225:2: note: expanded from macro '___inst_thumb32'
".short " __stringify(first) ", " __stringify(second) "nt"
^
>> drivers/firmware/arm_scmi/smc.c:109:2: error: write to reserved register 'R7'
include/linux/arm-smccc.h:354:4: note: expanded from macro 'arm_smccc_1_1_invoke'
arm_smccc_1_1_hvc(__VA_ARGS__); ^
include/linux/arm-smccc.h:315:48: note: expanded from macro 'arm_smccc_1_1_hvc'
#define arm_smccc_1_1_hvc(...) __arm_smccc_1_1(SMCCC_HVC_INST, __VA_ARGS__)
^
include/linux/arm-smccc.h:177:24: note: expanded from macro 'SMCCC_HVC_INST'
#define SMCCC_HVC_INST __HVC(0)
^
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
arch/arm/include/asm/opcodes.h:210:2: note: expanded from macro '__inst_arm_thumb32'
__inst_thumb32(thumb_opcode)
^
arch/arm/include/asm/opcodes.h:200:27: note: expanded from macro '__inst_thumb32'
#define __inst_thumb32(x) ___inst_thumb32( ^
arch/arm/include/asm/opcodes.h:225:2: note: expanded from macro '___inst_thumb32'
".short " __stringify(first) ", " __stringify(second) "nt"
^
>> drivers/firmware/arm_scmi/smc.c:109:2: error: write to reserved register 'R7'
include/linux/arm-smccc.h:360:4: note: expanded from macro 'arm_smccc_1_1_invoke'
__fail_smccc_1_1(__VA_ARGS__); ^
include/linux/arm-smccc.h:330:8: note: expanded from macro '__fail_smccc_1_1'
asm ("" __constraints(__count_args(__VA_ARGS__))); ^
3 errors generated.
vim +/R7 +109 drivers/firmware/arm_scmi/smc.c
98
99 static int smc_send_message(struct scmi_chan_info *cinfo,
100 struct scmi_xfer *xfer)
101 {
102 struct scmi_smc *scmi_info = cinfo->transport_info;
103 struct arm_smccc_res res;
104
105 mutex_lock(&smc_mutex);
106
107 shmem_tx_prepare(scmi_info->shmem, xfer);
108
> 109 arm_smccc_1_1_invoke(scmi_info->func_id, 0, 0, 0, 0, 0, 0, 0, &res);
110 scmi_rx_callback(scmi_info->cinfo, shmem_read_header(scmi_info->shmem));
111
112 mutex_unlock(&smc_mutex);
113
114 return res.a0;
115 }
116
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[tip:x86/entry 4/80] drivers/xen/events/events_base.c:1664:6: warning: no previous prototype for function 'xen_setup_callback_vector'
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/entry
head: 095b7a3e7745e6fb7cf0a1c09967c4f43e76f8f4
commit: fad1940a6a856f59b073e8650e02052ce531154c [4/80] x86/xen: Split HVM vector callback setup and interrupt gate allocation
config: arm64-randconfig-r026-20200519 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
git checkout fad1940a6a856f59b073e8650e02052ce531154c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/xen/events/events_base.c:1664:6: warning: no previous prototype for function 'xen_setup_callback_vector' [-Wmissing-prototypes]
void xen_setup_callback_vector(void) {}
^
drivers/xen/events/events_base.c:1664:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void xen_setup_callback_vector(void) {}
^
static
drivers/xen/events/events_base.c:1665:20: warning: unused function 'xen_alloc_callback_vector' [-Wunused-function]
static inline void xen_alloc_callback_vector(void) {}
^
2 warnings generated.
vim +/xen_setup_callback_vector +1664 drivers/xen/events/events_base.c
1654
1655 static __init void xen_alloc_callback_vector(void)
1656 {
1657 if (!xen_have_vector_callback)
1658 return;
1659
1660 pr_info("Xen HVM callback vector for event delivery is enabled\n");
1661 alloc_intr_gate(HYPERVISOR_CALLBACK_VECTOR, xen_hvm_callback_vector);
1662 }
1663 #else
> 1664 void xen_setup_callback_vector(void) {}
1665 static inline void xen_alloc_callback_vector(void) {}
1666 #endif
1667
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months