[m68k:m68k-queue 3/8] drivers/usb/host/isp116x.h:370:87: note: in expansion of macro 'isa_rom_writew_raw'
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git m68k-queue
head: 4684d38e4d478644c6c5c9cc484d45fe747bfced
commit: 8cee9aeb5f09293c2e2a5e75f2f54186cb04c65e [3/8] m68k: atari: usb: Add ISP1160 USB host controller support
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 8cee9aeb5f09293c2e2a5e75f2f54186cb04c65e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/m68k/include/asm/io_mm.h:25,
from arch/m68k/include/asm/io.h:8,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:13,
from ./arch/m68k/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:9,
from include/linux/interrupt.h:11,
from include/linux/usb.h:16,
from drivers/usb/host/isp116x-hcd.c:66:
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb':
arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable]
83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8'
430 | rom_out_8(port, *buf++);
| ^~~~~~~~~
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw':
arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16'
448 | rom_out_be16(port, *buf++);
| ^~~~~~~~~~~~
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw':
arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16'
466 | rom_out_le16(port, *buf++);
| ^~~~~~~~~~~~
drivers/usb/host/isp116x.h: In function 'isp116x_write_addr':
arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/io_mm.h:246:37: note: in expansion of macro 'rom_out_be16'
246 | #define isa_rom_writew_raw(val, p) rom_out_be16(isa_mtw((unsigned long)(p)), (val))
| ^~~~~~~~~~~~
>> drivers/usb/host/isp116x.h:370:87: note: in expansion of macro 'isa_rom_writew_raw'
370 | #define isp_writew(v, p) ((((unsigned long)(__pa(p)) & 0x00000F00) == 0x00000300UL) ? isa_rom_writew_raw((v), __pa(p)) : __raw_writew((v), (p)))
| ^~~~~~~~~~~~~~~~~~
>> drivers/usb/host/isp116x.h:391:2: note: in expansion of macro 'isp_writew'
391 | isp_writew(reg & 0xff, isp116x->addr_reg);
| ^~~~~~~~~~
drivers/usb/host/isp116x.h: In function 'isp116x_write_data16':
arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/io_mm.h:246:37: note: in expansion of macro 'rom_out_be16'
246 | #define isa_rom_writew_raw(val, p) rom_out_be16(isa_mtw((unsigned long)(p)), (val))
| ^~~~~~~~~~~~
>> drivers/usb/host/isp116x.h:370:87: note: in expansion of macro 'isa_rom_writew_raw'
370 | #define isp_writew(v, p) ((((unsigned long)(__pa(p)) & 0x00000F00) == 0x00000300UL) ? isa_rom_writew_raw((v), __pa(p)) : __raw_writew((v), (p)))
| ^~~~~~~~~~~~~~~~~~
drivers/usb/host/isp116x.h:397:2: note: in expansion of macro 'isp_writew'
397 | isp_writew(val, isp116x->data_reg);
| ^~~~~~~~~~
drivers/usb/host/isp116x.h: In function 'isp116x_raw_write_data16':
arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/io_mm.h:241:13: note: in expansion of macro 'rom_out_be16'
241 | (ISA_SEX ? rom_out_be16(isa_mtw((unsigned long)(p)), (val)) | ^~~~~~~~~~~~
>> drivers/usb/host/isp116x.h:372:91: note: in expansion of macro 'isa_rom_writew'
372 | #define isp_raw_writew(v, p) ((((unsigned long)(__pa(p)) & 0x00000F00) == 0x00000300UL) ? isa_rom_writew((v), __pa(p)) : writew((v), (p)))
| ^~~~~~~~~~~~~~
>> drivers/usb/host/isp116x.h:403:2: note: in expansion of macro 'isp_raw_writew'
403 | isp_raw_writew(val, isp116x->data_reg);
| ^~~~~~~~~~~~~~
arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/io_mm.h:242:6: note: in expansion of macro 'rom_out_le16'
242 | : rom_out_le16(isa_mtw((unsigned long)(p)), (val)))
| ^~~~~~~~~~~~
>> drivers/usb/host/isp116x.h:372:91: note: in expansion of macro 'isa_rom_writew'
372 | #define isp_raw_writew(v, p) ((((unsigned long)(__pa(p)) & 0x00000F00) == 0x00000300UL) ? isa_rom_writew((v), __pa(p)) : writew((v), (p)))
| ^~~~~~~~~~~~~~
>> drivers/usb/host/isp116x.h:403:2: note: in expansion of macro 'isp_raw_writew'
403 | isp_raw_writew(val, isp116x->data_reg);
| ^~~~~~~~~~~~~~
drivers/usb/host/isp116x.h: In function 'isp116x_write_data32':
arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/io_mm.h:246:37: note: in expansion of macro 'rom_out_be16'
246 | #define isa_rom_writew_raw(val, p) rom_out_be16(isa_mtw((unsigned long)(p)), (val))
| ^~~~~~~~~~~~
>> drivers/usb/host/isp116x.h:370:87: note: in expansion of macro 'isa_rom_writew_raw'
370 | #define isp_writew(v, p) ((((unsigned long)(__pa(p)) & 0x00000F00) == 0x00000300UL) ? isa_rom_writew_raw((v), __pa(p)) : __raw_writew((v), (p)))
| ^~~~~~~~~~~~~~~~~~
drivers/usb/host/isp116x.h:427:2: note: in expansion of macro 'isp_writew'
427 | isp_writew(val & 0xffff, isp116x->data_reg);
| ^~~~~~~~~~
arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable]
86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); | ^~~
arch/m68k/include/asm/io_mm.h:246:37: note: in expansion of macro 'rom_out_be16'
246 | #define isa_rom_writew_raw(val, p) rom_out_be16(isa_mtw((unsigned long)(p)), (val))
| ^~~~~~~~~~~~
>> drivers/usb/host/isp116x.h:370:87: note: in expansion of macro 'isa_rom_writew_raw'
370 | #define isp_writew(v, p) ((((unsigned long)(__pa(p)) & 0x00000F00) == 0x00000300UL) ? isa_rom_writew_raw((v), __pa(p)) : __raw_writew((v), (p)))
| ^~~~~~~~~~~~~~~~~~
drivers/usb/host/isp116x.h:429:2: note: in expansion of macro 'isp_writew'
429 | isp_writew(val >> 16, isp116x->data_reg);
| ^~~~~~~~~~
vim +/isa_rom_writew_raw +370 drivers/usb/host/isp116x.h
357
358
359 #ifdef CONFIG_ATARI_ROM_ISA
360 /*
361 * 16 bit data bus byte swapped in hardware on both Atari variants.
362 * EtherNAT variant of ISP1160 integration is memory mapped at 0x800000XX,
363 * and uses regular readw/__raw_readw (but semantics swapped).
364 * NetUSBee variant is hooked up through ROM port and uses ROM port
365 * IO access, with fake IO address of 0x3XX.
366 * Selection of the appropriate accessors relies on ioremapped addresses still
367 * retaining the 0x3XX bit.
368 */
369 #define isp_readw(p) ((((unsigned long)(__pa(p)) & 0x00000F00) == 0x00000300UL) ? isa_rom_readw_raw(__pa(p)) : __raw_readw((p)))
> 370 #define isp_writew(v, p) ((((unsigned long)(__pa(p)) & 0x00000F00) == 0x00000300UL) ? isa_rom_writew_raw((v), __pa(p)) : __raw_writew((v), (p)))
371 #define isp_raw_readw(p) ((((unsigned long)(__pa(p)) & 0x00000F00) == 0x00000300UL) ? isa_rom_readw(__pa(p)) : readw((p)))
> 372 #define isp_raw_writew(v, p) ((((unsigned long)(__pa(p)) & 0x00000F00) == 0x00000300UL) ? isa_rom_writew((v), __pa(p)) : writew((v), (p)))
373 #elif defined(CONFIG_ATARI)
374 /*
375 * 16 bit data bus byte swapped in hardware on EtherNAT only.
376 */
377 #define isp_readw __raw_readw
378 #define isp_writew __raw_writew
379 #define isp_raw_readw readw
380 #define isp_raw_writew writew
381 #else
382 /* sane hardware */
383 #define isp_readw readw
384 #define isp_writew writew
385 #define isp_raw_readw __raw_readw
386 #define isp_raw_writew __raw_writew
387 #endif
388
389 static inline void isp116x_write_addr(struct isp116x *isp116x, unsigned reg)
390 {
> 391 isp_writew(reg & 0xff, isp116x->addr_reg);
392 isp116x_delay(isp116x, 300);
393 }
394
395 static inline void isp116x_write_data16(struct isp116x *isp116x, u16 val)
396 {
397 isp_writew(val, isp116x->data_reg);
398 isp116x_delay(isp116x, 150);
399 }
400
401 static inline void isp116x_raw_write_data16(struct isp116x *isp116x, u16 val)
402 {
> 403 isp_raw_writew(val, isp116x->data_reg);
404 isp116x_delay(isp116x, 150);
405 }
406
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [RFC v2 PATCH 4/8] qaic: Implement control path
by kbuild test robot
Hi Jeffrey,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on soc/for-next linus/master v5.7-rc6 next-20200519]
[cannot apply to linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Jeffrey-Hugo/Qualcomm-Cloud-AI-1...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 57c76221d5af648c8355a55c09b050c5d8d38189
config: x86_64-allmodconfig (attached as .config)
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-193-gb8fad4bc-dirty
# save the attached .config to linux build tree
make C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/misc/qaic/qaic_control.c:207:70: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:209:21: sparse: sparse: restricted __le32 degrades to integer
>> drivers/misc/qaic/qaic_control.c:213:22: sparse: sparse: bad assignment (+=) to restricted __le32
>> drivers/misc/qaic/qaic_control.c:216:30: sparse: sparse: cast from restricted __le32
drivers/misc/qaic/qaic_control.c:225:67: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:305:21: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:311:22: sparse: sparse: bad assignment (+=) to restricted __le32
drivers/misc/qaic/qaic_control.c:369:74: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:375:21: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:405:22: sparse: sparse: bad assignment (+=) to restricted __le32
drivers/misc/qaic/qaic_control.c:432:72: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:434:21: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:439:22: sparse: sparse: bad assignment (+=) to restricted __le32
>> drivers/misc/qaic/qaic_control.c:454:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] len @@ got 2 [usertype] len @@
>> drivers/misc/qaic/qaic_control.c:454:22: sparse: expected restricted __le32 [usertype] len
>> drivers/misc/qaic/qaic_control.c:454:22: sparse: got unsigned long
>> drivers/misc/qaic/qaic_control.c:505:24: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] count @@ got icted __le32 [usertype] count @@
>> drivers/misc/qaic/qaic_control.c:505:24: sparse: expected restricted __le32 [usertype] count
>> drivers/misc/qaic/qaic_control.c:505:24: sparse: got unsigned int [usertype] count
>> drivers/misc/qaic/qaic_control.c:525:31: sparse: sparse: cast to restricted __le32
drivers/misc/qaic/qaic_control.c:609:31: sparse: sparse: cast to restricted __le32
drivers/misc/qaic/qaic_control.c:611:28: sparse: sparse: cast to restricted __le32
>> drivers/misc/qaic/qaic_control.c:611:28: sparse: sparse: cast from restricted __le16
drivers/misc/qaic/qaic_control.c:612:28: sparse: sparse: cast to restricted __le32
drivers/misc/qaic/qaic_control.c:612:28: sparse: sparse: cast from restricted __le16
drivers/misc/qaic/qaic_control.c:629:21: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:637:40: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:637:56: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:640:34: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:640:34: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:640:34: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:640:34: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:664:33: sparse: sparse: restricted __le32 degrades to integer
>> drivers/misc/qaic/qaic_control.c:786:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] magic_number @@ got e] magic_number @@
>> drivers/misc/qaic/qaic_control.c:786:31: sparse: expected restricted __le32 [usertype] magic_number
>> drivers/misc/qaic/qaic_control.c:786:31: sparse: got int
drivers/misc/qaic/qaic_control.c:788:24: sparse: sparse: cast from restricted __le32
drivers/misc/qaic/qaic_control.c:789:26: sparse: sparse: cast from restricted __le32
drivers/misc/qaic/qaic_control.c:887:21: sparse: sparse: restricted __le32 degrades to integer
drivers/misc/qaic/qaic_control.c:981:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] magic_number @@ got e] magic_number @@
drivers/misc/qaic/qaic_control.c:981:31: sparse: expected restricted __le32 [usertype] magic_number
drivers/misc/qaic/qaic_control.c:981:31: sparse: got int
vim +207 drivers/misc/qaic/qaic_control.c
202
203 static int encode_passthrough(struct qaic_device *qdev, void *trans,
204 struct _msg *msg, u32 *user_len)
205 {
206 struct qaic_manage_trans_passthrough *in_trans = trans;
> 207 struct _trans_passthrough *out_trans = (void *)msg + msg->hdr.len;
208
209 if (msg->hdr.len + in_trans->hdr.len > sizeof(*msg))
210 return -ENOSPC;
211
212 memcpy(out_trans, in_trans, in_trans->hdr.len);
> 213 msg->hdr.len += in_trans->hdr.len;
214 *user_len += in_trans->hdr.len;
215 out_trans->hdr.type = cpu_to_le32(TRANS_PASSTHROUGH_TO_DEV);
> 216 out_trans->hdr.len = cpu_to_le32(out_trans->hdr.len);
217
218 return 0;
219 }
220
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[linux-next:master 4055/10701] kernel/rcu/tree_stall.h:208:19: warning: variable 'rnp' set but not used
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
commit: 5bef8da66a9c45d3c371d74463894f1fc31dfdda [4055/10701] rcu: Add per-task state to RCU CPU stall warnings
config: nios2-randconfig-r021-20200519 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 5bef8da66a9c45d3c371d74463894f1fc31dfdda
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from kernel/rcu/tree.c:4075:
kernel/rcu/tree_stall.h: In function 'check_slow_task':
>> kernel/rcu/tree_stall.h:208:19: warning: variable 'rnp' set but not used [-Wunused-but-set-variable]
208 | struct rcu_node *rnp;
| ^~~
vim +/rnp +208 kernel/rcu/tree_stall.h
201
202 /*
203 * Report out the state of a not-running task that is stalling the
204 * current RCU grace period.
205 */
206 static bool check_slow_task(struct task_struct *t, void *arg)
207 {
> 208 struct rcu_node *rnp;
209 struct rcu_stall_chk_rdr *rscrp = arg;
210
211 if (task_curr(t))
212 return false; // It is running, so decline to inspect it.
213 rscrp->nesting = t->rcu_read_lock_nesting;
214 rscrp->rs = t->rcu_read_unlock_special;
215 rnp = t->rcu_blocked_node;
216 rscrp->on_blkd_list = !list_empty(&t->rcu_node_entry);
217 return true;
218 }
219
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [RFC v2 PATCH 2/8] qaic: Add and init a basic mhi controller
by kbuild test robot
Hi Jeffrey,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on soc/for-next linus/master v5.7-rc6 next-20200519]
[cannot apply to linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Jeffrey-Hugo/Qualcomm-Cloud-AI-1...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 57c76221d5af648c8355a55c09b050c5d8d38189
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/misc/qaic/mhi_controller.c: In function 'qaic_mhi_register_controller':
>> drivers/misc/qaic/mhi_controller.c:457:10: error: 'struct mhi_controller' has no member named 'link_status'
457 | mhi_cntl->link_status = mhi_link_status;
| ^~
vim +457 drivers/misc/qaic/mhi_controller.c
430
431 struct mhi_controller *qaic_mhi_register_controller(struct pci_dev *pci_dev,
432 void __iomem *mhi_bar,
433 int mhi_irq)
434 {
435 struct mhi_controller *mhi_cntl;
436 int ret;
437
438 pci_dbg(pci_dev, "%s\n", __func__);
439
440 mhi_cntl = kzalloc(sizeof(*mhi_cntl), GFP_KERNEL);
441 if (!mhi_cntl)
442 return ERR_PTR(-ENOMEM);
443
444 mhi_cntl->cntrl_dev = &pci_dev->dev;
445
446 /*
447 * Covers the entire possible physical ram region. Remote side is
448 * going to calculate a size of this range, so subtract 1 to prevent
449 * rollover.
450 */
451 mhi_cntl->iova_start = 0;
452 mhi_cntl->iova_stop = PHYS_ADDR_MAX - 1;
453
454 mhi_cntl->status_cb = mhi_status_cb;
455 mhi_cntl->runtime_get = mhi_runtime_get;
456 mhi_cntl->runtime_put = mhi_runtime_put;
> 457 mhi_cntl->link_status = mhi_link_status;
458 mhi_cntl->regs = mhi_bar;
459 mhi_cntl->nr_irqs = 1;
460 mhi_cntl->irq = kmalloc(sizeof(*mhi_cntl->irq), GFP_KERNEL);
461
462 if (!mhi_cntl->irq)
463 return ERR_PTR(-ENOMEM);
464
465 mhi_cntl->irq[0] = mhi_irq;
466
467 mhi_cntl->fw_image = "qcom/aic100/sbl.bin";
468
469 /* use latest configured timeout */
470 aic100_config.timeout_ms = mhi_timeout;
471 ret = mhi_register_controller(mhi_cntl, &aic100_config);
472 if (ret) {
473 pci_err(pci_dev, "register_mhi_controller failed %d\n", ret);
474 kfree(mhi_cntl->irq);
475 kfree(mhi_cntl);
476 return ERR_PTR(ret);
477 }
478
479 ret = mhi_async_power_up(mhi_cntl);
480 if (ret) {
481 pci_err(pci_dev, "mhi_async_power_up failed %d\n", ret);
482 mhi_unregister_controller(mhi_cntl);
483 kfree(mhi_cntl->irq);
484 kfree(mhi_cntl);
485 return ERR_PTR(ret);
486 }
487
488 return mhi_cntl;
489 }
490
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[linux-next:master 7901/10701] drivers/net/wireless/mediatek/mt76/mt7603/mac.c:476:10: warning: comparison is always false due to limited range of data type
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
commit: 49e649c3e0a6ec8a12976e331a2c1f29dc7dd3a9 [7901/10701] mt76: adjust wcid size to support new 802.11ax generation
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 49e649c3e0a6ec8a12976e331a2c1f29dc7dd3a9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/net/wireless/mediatek/mt76/mt7603/mac.c: In function 'mt7603_rx_get_wcid':
>> drivers/net/wireless/mediatek/mt76/mt7603/mac.c:476:10: warning: comparison is always false due to limited range of data type [-Wtype-limits]
476 | if (idx >= ARRAY_SIZE(dev->mt76.wcid))
| ^~
drivers/net/wireless/mediatek/mt76/mt7603/mac.c: In function 'mt7603_mac_add_txs':
drivers/net/wireless/mediatek/mt76/mt7603/mac.c:1241:12: warning: comparison is always false due to limited range of data type [-Wtype-limits]
1241 | if (wcidx >= ARRAY_SIZE(dev->mt76.wcid))
| ^~
--
In file included from drivers/net/wireless/mediatek/mt76/mt76x02_util.c:8:
drivers/net/wireless/mediatek/mt76/mt76x02.h: In function 'mt76x02_rx_get_sta':
>> drivers/net/wireless/mediatek/mt76/mt76x02.h:249:10: warning: comparison is always false due to limited range of data type [-Wtype-limits]
249 | if (idx >= ARRAY_SIZE(dev->wcid))
| ^~
--
In file included from drivers/net/wireless/mediatek/mt76/mt76x02_mac.c:7:
drivers/net/wireless/mediatek/mt76/mt76x02.h: In function 'mt76x02_rx_get_sta':
>> drivers/net/wireless/mediatek/mt76/mt76x02.h:249:10: warning: comparison is always false due to limited range of data type [-Wtype-limits]
249 | if (idx >= ARRAY_SIZE(dev->wcid))
| ^~
drivers/net/wireless/mediatek/mt76/mt76x02_mac.c: In function 'mt76x02_send_tx_status':
>> drivers/net/wireless/mediatek/mt76/mt76x02_mac.c:564:17: warning: comparison is always true due to limited range of data type [-Wtype-limits]
564 | if (stat->wcid < ARRAY_SIZE(dev->mt76.wcid))
| ^
--
In file included from drivers/net/wireless/mediatek/mt76/mt76x02_trace.h:10,
from drivers/net/wireless/mediatek/mt76/mt76x02_trace.c:10:
drivers/net/wireless/mediatek/mt76/mt76x02.h: In function 'mt76x02_rx_get_sta':
>> drivers/net/wireless/mediatek/mt76/mt76x02.h:249:10: warning: comparison is always false due to limited range of data type [-Wtype-limits]
249 | if (idx >= ARRAY_SIZE(dev->wcid))
| ^~
In file included from drivers/net/wireless/mediatek/mt76/mt76x02_trace.h:87,
from drivers/net/wireless/mediatek/mt76/mt76x02_trace.c:10:
include/trace/define_trace.h: At top level:
include/trace/define_trace.h:95:42: fatal error: ./mt76x02_trace.h: No such file or directory
95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
| ^
compilation terminated.
--
drivers/net/wireless/mediatek/mt76/mt7615/mac.c: In function 'mt7615_rx_get_wcid':
>> drivers/net/wireless/mediatek/mt76/mt7615/mac.c:64:10: warning: comparison is always false due to limited range of data type [-Wtype-limits]
64 | if (idx >= ARRAY_SIZE(dev->mt76.wcid))
| ^~
drivers/net/wireless/mediatek/mt76/mt7615/mac.c: In function 'mt7615_mac_add_txs':
drivers/net/wireless/mediatek/mt76/mt7615/mac.c:1305:12: warning: comparison is always false due to limited range of data type [-Wtype-limits]
1305 | if (wcidx >= ARRAY_SIZE(dev->mt76.wcid))
| ^~
--
In file included from drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h:20,
from drivers/net/wireless/mediatek/mt76/mt76x0/usb.c:10:
drivers/net/wireless/mediatek/mt76/mt76x0/../mt76x02.h: In function 'mt76x02_rx_get_sta':
>> drivers/net/wireless/mediatek/mt76/mt76x0/../mt76x02.h:249:10: warning: comparison is always false due to limited range of data type [-Wtype-limits]
249 | if (idx >= ARRAY_SIZE(dev->wcid))
| ^~
--
In file included from drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h:20,
from drivers/net/wireless/mediatek/mt76/mt76x0/phy.c:12:
drivers/net/wireless/mediatek/mt76/mt76x0/../mt76x02.h: In function 'mt76x02_rx_get_sta':
>> drivers/net/wireless/mediatek/mt76/mt76x0/../mt76x02.h:249:10: warning: comparison is always false due to limited range of data type [-Wtype-limits]
249 | if (idx >= ARRAY_SIZE(dev->wcid))
| ^~
In file included from drivers/net/wireless/mediatek/mt76/mt76x0/phy.c:16:
At top level:
drivers/net/wireless/mediatek/mt76/mt76x0/initvals.h:218:35: warning: 'mt76x0_dcoc_tab' defined but not used [-Wunused-const-variable=]
218 | static const struct mt76_reg_pair mt76x0_dcoc_tab[] = {
| ^~~~~~~~~~~~~~~
drivers/net/wireless/mediatek/mt76/mt76x0/initvals.h:86:35: warning: 'mt76x0_bbp_init_tab' defined but not used [-Wunused-const-variable=]
86 | static const struct mt76_reg_pair mt76x0_bbp_init_tab[] = {
| ^~~~~~~~~~~~~~~~~~~
drivers/net/wireless/mediatek/mt76/mt76x0/initvals.h:48:35: warning: 'mt76x0_mac_reg_table' defined but not used [-Wunused-const-variable=]
48 | static const struct mt76_reg_pair mt76x0_mac_reg_table[] = {
| ^~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/mediatek/mt76/mt76x0/initvals.h:14:35: warning: 'common_mac_reg_table' defined but not used [-Wunused-const-variable=]
14 | static const struct mt76_reg_pair common_mac_reg_table[] = {
| ^~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/net/wireless/mediatek/mt76/mt76x2/mt76x2.h:23,
from drivers/net/wireless/mediatek/mt76/mt76x2/eeprom.c:9:
drivers/net/wireless/mediatek/mt76/mt76x2/../mt76x02.h: In function 'mt76x02_rx_get_sta':
>> drivers/net/wireless/mediatek/mt76/mt76x2/../mt76x02.h:249:10: warning: comparison is always false due to limited range of data type [-Wtype-limits]
249 | if (idx >= ARRAY_SIZE(dev->wcid))
| ^~
vim +476 drivers/net/wireless/mediatek/mt76/mt7603/mac.c
ea565833fd7848 Felix Fietkau 2019-09-04 469
c8846e1015022d Felix Fietkau 2018-11-06 470 static struct mt76_wcid *
c8846e1015022d Felix Fietkau 2018-11-06 471 mt7603_rx_get_wcid(struct mt7603_dev *dev, u8 idx, bool unicast)
c8846e1015022d Felix Fietkau 2018-11-06 472 {
c8846e1015022d Felix Fietkau 2018-11-06 473 struct mt7603_sta *sta;
c8846e1015022d Felix Fietkau 2018-11-06 474 struct mt76_wcid *wcid;
c8846e1015022d Felix Fietkau 2018-11-06 475
c8846e1015022d Felix Fietkau 2018-11-06 @476 if (idx >= ARRAY_SIZE(dev->mt76.wcid))
c8846e1015022d Felix Fietkau 2018-11-06 477 return NULL;
c8846e1015022d Felix Fietkau 2018-11-06 478
c8846e1015022d Felix Fietkau 2018-11-06 479 wcid = rcu_dereference(dev->mt76.wcid[idx]);
c8846e1015022d Felix Fietkau 2018-11-06 480 if (unicast || !wcid)
c8846e1015022d Felix Fietkau 2018-11-06 481 return wcid;
c8846e1015022d Felix Fietkau 2018-11-06 482
c8846e1015022d Felix Fietkau 2018-11-06 483 if (!wcid->sta)
c8846e1015022d Felix Fietkau 2018-11-06 484 return NULL;
c8846e1015022d Felix Fietkau 2018-11-06 485
c8846e1015022d Felix Fietkau 2018-11-06 486 sta = container_of(wcid, struct mt7603_sta, wcid);
c8846e1015022d Felix Fietkau 2018-11-06 487 if (!sta->vif)
c8846e1015022d Felix Fietkau 2018-11-06 488 return NULL;
c8846e1015022d Felix Fietkau 2018-11-06 489
c8846e1015022d Felix Fietkau 2018-11-06 490 return &sta->vif->sta.wcid;
c8846e1015022d Felix Fietkau 2018-11-06 491 }
c8846e1015022d Felix Fietkau 2018-11-06 492
:::::: The code at line 476 was first introduced by commit
:::::: c8846e1015022d2531ac4c895783e400b3e5babe mt76: add driver for MT7603E and MT7628/7688
:::::: TO: Felix Fietkau <nbd(a)nbd.name>
:::::: CC: Felix Fietkau <nbd(a)nbd.name>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[lpieralisi:for-review/acpi-iort-id-rework 8/12] include/linux/of_irq.h:87:34: error: 'of_msi_map_get_device_domain' declared 'static' but never defined
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/linux.git for-review/acpi-iort-id-rework
head: b2a8809a420d6d12a92d54c343c360ead32af752
commit: 6b448905a263276e5f0b1f6c677425049c729270 [8/12] of/irq: make of_msi_map_get_device_domain() bus agnostic
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 6b448905a263276e5f0b1f6c677425049c729270
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
In file included from arch/sparc/kernel/of_device_common.c:12:
include/linux/of_irq.h:89:1: error: expected identifier or '(' before '{' token
89 | {
| ^
>> include/linux/of_irq.h:87:34: error: 'of_msi_map_get_device_domain' declared 'static' but never defined [-Werror=unused-function]
87 | static inline struct irq_domain *of_msi_map_get_device_domain(struct device *dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +87 include/linux/of_irq.h
4c3141e09cfa64 Carlo Caione 2015-12-01 80
48ae34fb39b0c0 Marc Zyngier 2015-09-18 81 static inline struct irq_domain *of_msi_get_domain(struct device *dev,
48ae34fb39b0c0 Marc Zyngier 2015-09-18 82 struct device_node *np,
48ae34fb39b0c0 Marc Zyngier 2015-09-18 83 enum irq_domain_bus_token token)
48ae34fb39b0c0 Marc Zyngier 2015-09-18 84 {
48ae34fb39b0c0 Marc Zyngier 2015-09-18 85 return NULL;
48ae34fb39b0c0 Marc Zyngier 2015-09-18 86 }
82b9b4243c6d99 Marc Zyngier 2015-10-02 @87 static inline struct irq_domain *of_msi_map_get_device_domain(struct device *dev,
6b448905a26327 Diana Craciun 2020-04-29 88 u32 id, u32 bus_token);
82b9b4243c6d99 Marc Zyngier 2015-10-02 89 {
82b9b4243c6d99 Marc Zyngier 2015-10-02 90 return NULL;
82b9b4243c6d99 Marc Zyngier 2015-10-02 91 }
f9f9f11dcf0f3b Jonas Gorski 2015-10-12 92 static inline void of_msi_configure(struct device *dev, struct device_node *np)
f9f9f11dcf0f3b Jonas Gorski 2015-10-12 93 {
f9f9f11dcf0f3b Jonas Gorski 2015-10-12 94 }
eaddb5725357e9 Rob Herring 2015-12-09 95 static inline u32 of_msi_map_rid(struct device *dev,
eaddb5725357e9 Rob Herring 2015-12-09 96 struct device_node *msi_np, u32 rid_in)
eaddb5725357e9 Rob Herring 2015-12-09 97 {
eaddb5725357e9 Rob Herring 2015-12-09 98 return rid_in;
eaddb5725357e9 Rob Herring 2015-12-09 99 }
a8d3f362f52b65 Rob Herring 2013-11-07 100 #endif
a8d3f362f52b65 Rob Herring 2013-11-07 101
:::::: The code at line 87 was first introduced by commit
:::::: 82b9b4243c6d99d9e38087fa89183aa7479185e9 of/irq: Use the msi-map property to provide device-specific MSI domain
:::::: TO: Marc Zyngier <marc.zyngier(a)arm.com>
:::::: CC: Marc Zyngier <marc.zyngier(a)arm.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [PATCH V1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.
by kbuild test robot
Hi Vaibhav,
I love your patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Vaibhav-Agarwal/Enable-Greybus-A...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git cef077e6aa4c7dbe2f23e1201cf705f9540ec467
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/staging/greybus/audio_helper.c:59:5: warning: no previous prototype for function 'gbaudio_dapm_link_component_dai_widgets' [-Wmissing-prototypes]
int gbaudio_dapm_link_component_dai_widgets(struct snd_soc_card *card,
^
drivers/staging/greybus/audio_helper.c:59:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int gbaudio_dapm_link_component_dai_widgets(struct snd_soc_card *card,
^
static
>> drivers/staging/greybus/audio_helper.c:112:5: warning: no previous prototype for function 'gbaudio_dapm_free_controls' [-Wmissing-prototypes]
int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
^
drivers/staging/greybus/audio_helper.c:112:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
^
static
>> drivers/staging/greybus/audio_helper.c:189:5: warning: no previous prototype for function 'gbaudio_remove_component_controls' [-Wmissing-prototypes]
int gbaudio_remove_component_controls(struct snd_soc_component *component,
^
drivers/staging/greybus/audio_helper.c:189:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int gbaudio_remove_component_controls(struct snd_soc_component *component,
^
static
3 warnings generated.
vim +/gbaudio_dapm_link_component_dai_widgets +59 drivers/staging/greybus/audio_helper.c
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 58
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 @59 int gbaudio_dapm_link_component_dai_widgets(struct snd_soc_card *card,
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 60 struct snd_soc_dapm_context *dapm)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 61 {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 62 struct snd_soc_dapm_widget *dai_w;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 63
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 64 /* For each DAI widget... */
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 65 list_for_each_entry(dai_w, &card->widgets, list) {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 66 if (dai_w->dapm != dapm)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 67 continue;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 68 switch (dai_w->id) {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 69 case snd_soc_dapm_dai_in:
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 70 case snd_soc_dapm_dai_out:
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 71 break;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 72 default:
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 73 continue;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 74 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 75 gbaudio_dapm_link_dai_widget(dai_w, card);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 76 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 77
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 78 return 0;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 79 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 80
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 81 static void gbaudio_dapm_free_path(struct snd_soc_dapm_path *path)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 82 {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 83 list_del(&path->list_node[SND_SOC_DAPM_DIR_IN]);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 84 list_del(&path->list_node[SND_SOC_DAPM_DIR_OUT]);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 85 list_del(&path->list_kcontrol);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 86 list_del(&path->list);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 87 kfree(path);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 88 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 89
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 90 static void gbaudio_dapm_free_widget(struct snd_soc_dapm_widget *w)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 91 {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 92 struct snd_soc_dapm_path *p, *next_p;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 93 enum snd_soc_dapm_direction dir;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 94
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 95 list_del(&w->list);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 96 /*
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 97 * remove source and sink paths associated to this widget.
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 98 * While removing the path, remove reference to it from both
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 99 * source and sink widgets so that path is removed only once.
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 100 */
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 101 gbaudio_dapm_for_each_direction(dir) {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 102 snd_soc_dapm_widget_for_each_path_safe(w, dir, p, next_p)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 103 gbaudio_dapm_free_path(p);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 104 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 105
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 106 kfree(w->kcontrols);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 107 kfree_const(w->name);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 108 kfree_const(w->sname);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 109 kfree(w);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 110 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 111
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 @112 int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 113 const struct snd_soc_dapm_widget *widget,
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 114 int num)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 115 {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 116 int i;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 117 struct snd_soc_dapm_widget *w, *next_w;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 118 #ifdef CONFIG_DEBUG_FS
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 119 struct dentry *parent = dapm->debugfs_dapm;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 120 struct dentry *debugfs_w = NULL;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 121 #endif
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 122
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 123 mutex_lock(&dapm->card->dapm_mutex);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 124 for (i = 0; i < num; i++) {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 125 /* below logic can be optimized to identify widget pointer */
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 126 list_for_each_entry_safe(w, next_w, &dapm->card->widgets,
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 127 list) {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 128 if (w->dapm != dapm)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 129 continue;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 130 if (!strcmp(w->name, widget->name))
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 131 break;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 132 w = NULL;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 133 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 134 if (!w) {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 135 dev_err(dapm->dev, "%s: widget not found\n",
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 136 widget->name);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 137 return -EINVAL;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 138 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 139 widget++;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 140 #ifdef CONFIG_DEBUG_FS
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 141 if (!parent)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 142 debugfs_w = debugfs_lookup(w->name, parent);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 143 debugfs_remove(debugfs_w);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 144 debugfs_w = NULL;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 145 #endif
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 146 gbaudio_dapm_free_widget(w);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 147 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 148 mutex_unlock(&dapm->card->dapm_mutex);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 149 return 0;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 150 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 151
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 152 static int gbaudio_remove_controls(struct snd_card *card, struct device *dev,
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 153 const struct snd_kcontrol_new *controls,
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 154 int num_controls, const char *prefix)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 155 {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 156 int i, err;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 157
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 158 for (i = 0; i < num_controls; i++) {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 159 const struct snd_kcontrol_new *control = &controls[i];
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 160 struct snd_ctl_elem_id id;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 161 struct snd_kcontrol *kctl;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 162
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 163 if (prefix)
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 164 snprintf(id.name, sizeof(id.name), "%s %s", prefix,
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 165 control->name);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 166 else
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 167 strlcpy(id.name, control->name, sizeof(id.name));
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 168 id.numid = 0;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 169 id.iface = control->iface;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 170 id.device = control->device;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 171 id.subdevice = control->subdevice;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 172 id.index = control->index;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 173 kctl = snd_ctl_find_id(card, &id);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 174 if (!kctl) {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 175 dev_err(dev, "%d: Failed to find %s\n", err,
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 176 control->name);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 177 return -ENOENT;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 178 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 179 err = snd_ctl_remove(card, kctl);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 180 if (err < 0) {
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 181 dev_err(dev, "%d: Failed to remove %s\n", err,
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 182 control->name);
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 183 return err;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 184 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 185 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 186 return 0;
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 187 }
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 188
94b08a33fd1bca Vaibhav Agarwal 2020-05-17 @189 int gbaudio_remove_component_controls(struct snd_soc_component *component,
:::::: The code at line 59 was first introduced by commit
:::::: 94b08a33fd1bcaa8660430f8107b5c7bbfbca3b4 staging: greybus: audio: Add helper APIs for dynamic audio modules
:::::: TO: Vaibhav Agarwal <vaibhav.sr(a)gmail.com>
:::::: CC: 0day robot <lkp(a)intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[linux-next:master 5896/10701] drivers/iommu/mtk_iommu_v1.c:467:25: warning: variable 'data' set but not used
by kbuild test robot
Hi Joerg,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
commit: 57dbf81f50c82a0ad895a57828ad1ab539785a25 [5896/10701] iommu/mediatek-v1 Convert to probe/release_device() call-backs
config: arm-randconfig-r013-20200519 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 57dbf81f50c82a0ad895a57828ad1ab539785a25
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_release_device':
>> drivers/iommu/mtk_iommu_v1.c:467:25: warning: variable 'data' set but not used [-Wunused-but-set-variable]
467 | struct mtk_iommu_data *data;
| ^~~~
vim +/data +467 drivers/iommu/mtk_iommu_v1.c
b17336c55d8928 Honghui Zhang 2016-06-08 463
57dbf81f50c82a Joerg Roedel 2020-04-29 464 static void mtk_iommu_release_device(struct device *dev)
b17336c55d8928 Honghui Zhang 2016-06-08 465 {
a9bf2eec5a6fc0 Joerg Roedel 2018-11-29 466 struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
6f66ea099fc2f3 Joerg Roedel 2017-03-31 @467 struct mtk_iommu_data *data;
6f66ea099fc2f3 Joerg Roedel 2017-03-31 468
a9bf2eec5a6fc0 Joerg Roedel 2018-11-29 469 if (!fwspec || fwspec->ops != &mtk_iommu_ops)
b17336c55d8928 Honghui Zhang 2016-06-08 470 return;
b17336c55d8928 Honghui Zhang 2016-06-08 471
3524b5592cad63 Joerg Roedel 2020-03-26 472 data = dev_iommu_priv_get(dev);
84672f192671e6 Robin Murphy 2016-10-17 473 iommu_fwspec_free(dev);
b17336c55d8928 Honghui Zhang 2016-06-08 474 }
b17336c55d8928 Honghui Zhang 2016-06-08 475
:::::: The code at line 467 was first introduced by commit
:::::: 6f66ea099fc2f31d31d6cd39f3b13b23bdeb6196 iommu/mediatek: Teach MTK-IOMMUv1 about 'struct iommu_device'
:::::: TO: Joerg Roedel <jroedel(a)suse.de>
:::::: CC: Joerg Roedel <jroedel(a)suse.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
Re: [RFC PATCH] clk: rework clk_register to use the clk_hw API
by kbuild test robot
Hi Jerome,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on clk/clk-next]
[also build test WARNING on v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Jerome-Brunet/clk-rework-clk_reg...
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: x86_64-defconfig (attached as .config)
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/clk/clk.c: In function 'clk_register':
drivers/clk/clk.c:3868:8: error: implicit declaration of function 'clk_hw_get_clk'; did you mean '__clk_hw_set_clk'? [-Werror=implicit-function-declaration]
clk = clk_hw_get_clk(hw);
^~~~~~~~~~~~~~
__clk_hw_set_clk
>> drivers/clk/clk.c:3868:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
clk = clk_hw_get_clk(hw);
^
cc1: some warnings being treated as errors
vim +3868 drivers/clk/clk.c
3846
3847 /**
3848 * clk_register - allocate a new clock, register it and return an opaque cookie
3849 * @dev: device that is registering this clock
3850 * @hw: link to hardware-specific clock data
3851 *
3852 * clk_register is the *deprecated* interface for populating the clock tree with
3853 * new clock nodes. Use clk_hw_register() instead.
3854 *
3855 * Returns: a pointer to the newly allocated struct clk which
3856 * cannot be dereferenced by driver code but may be used in conjunction with the
3857 * rest of the clock API. In the event of an error clk_register will return an
3858 * error code; drivers must test for an error code after calling clk_register.
3859 */
3860 struct clk *clk_register(struct device *dev, struct clk_hw *hw)
3861 {
3862 struct clk *clk;
3863 int ret = clk_hw_register(dev, hw);
3864
3865 if (ret < 0)
3866 return ERR_PTR(ret);
3867
> 3868 clk = clk_hw_get_clk(hw);
3869 if (IS_ERR_OR_NULL(clk))
3870 clk_hw_unregister(hw);
3871
3872 return clk;
3873 }
3874 EXPORT_SYMBOL_GPL(clk_register);
3875
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months
[tip:x86/mm 1/23] arch/x86/mm/init.c:75:6: warning: no previous prototype for function 'x86_has_pat_wp'
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/mm
head: bd1de2a7aace4d1d312fb1be264b8fafdb706208
commit: 1f6f655e01adebf5bd5e6c3da2e843c104ded051 [1/23] x86/mm: Add a x86_has_pat_wp() helper
config: x86_64-randconfig-r012-20200519 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 1f6f655e01adebf5bd5e6c3da2e843c104ded051
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> arch/x86/mm/init.c:75:6: warning: no previous prototype for function 'x86_has_pat_wp' [-Wmissing-prototypes]
bool x86_has_pat_wp(void)
^
arch/x86/mm/init.c:75:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
bool x86_has_pat_wp(void)
^
static
arch/x86/mm/init.c:866:13: warning: no previous prototype for function 'mem_encrypt_free_decrypted_mem' [-Wmissing-prototypes]
void __weak mem_encrypt_free_decrypted_mem(void) { }
^
arch/x86/mm/init.c:866:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void __weak mem_encrypt_free_decrypted_mem(void) { }
^
static
2 warnings generated.
vim +/x86_has_pat_wp +75 arch/x86/mm/init.c
73
74 /* Check that the write-protect PAT entry is set for write-protect */
> 75 bool x86_has_pat_wp(void)
76 {
77 return __pte2cachemode_tbl[_PAGE_CACHE_MODE_WP] == _PAGE_CACHE_MODE_WP;
78 }
79
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 4 months