drivers/pci/controller/pci-mvebu.c:368:17: sparse: sparse: restricted __le16 degrades to integer
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f82e7b57b5fc48199e2f26ffafe2f96f7338ad3d
commit: e0d9d30b73548fbfe5c024ed630169bdc9a08aee PCI: pci-bridge-emul: Fix big-endian support
date: 8 months ago
:::::: branch date: 2 hours ago
:::::: commit date: 8 months ago
config: arm-randconfig-s032-20200613 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-250-g42323db3-dirty
git checkout e0d9d30b73548fbfe5c024ed630169bdc9a08aee
# save the attached .config to linux build tree
make W=1 C=1 ARCH=arm CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/pci/controller/pci-mvebu.c:368:17: sparse: sparse: restricted __le16 degrades to integer
drivers/pci/controller/pci-mvebu.c:368:38: sparse: sparse: restricted __le16 degrades to integer
drivers/pci/controller/pci-mvebu.c:369:19: sparse: sparse: restricted __le16 degrades to integer
drivers/pci/controller/pci-mvebu.c:389:30: sparse: sparse: restricted __le16 degrades to integer
drivers/pci/controller/pci-mvebu.c:392:31: sparse: sparse: restricted __le16 degrades to integer
drivers/pci/controller/pci-mvebu.c:406:17: sparse: sparse: restricted __le16 degrades to integer
drivers/pci/controller/pci-mvebu.c:406:34: sparse: sparse: restricted __le16 degrades to integer
drivers/pci/controller/pci-mvebu.c:407:19: sparse: sparse: restricted __le16 degrades to integer
drivers/pci/controller/pci-mvebu.c:419:30: sparse: sparse: restricted __le16 degrades to integer
drivers/pci/controller/pci-mvebu.c:420:31: sparse: sparse: restricted __le16 degrades to integer
>> drivers/pci/controller/pci-mvebu.c:483:39: sparse: sparse: invalid assignment: &=
>> drivers/pci/controller/pci-mvebu.c:483:39: sparse: left side has type restricted __le16
>> drivers/pci/controller/pci-mvebu.c:483:39: sparse: right side has type int
drivers/pci/controller/pci-mvebu.c:557:28: sparse: sparse: symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?
>> drivers/pci/controller/pci-mvebu.c:571:29: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [usertype] vendor @@ got int @@
>> drivers/pci/controller/pci-mvebu.c:571:29: sparse: expected restricted __le16 [usertype] vendor
>> drivers/pci/controller/pci-mvebu.c:571:29: sparse: got int
>> drivers/pci/controller/pci-mvebu.c:572:29: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [usertype] device @@ got unsigned int @@
>> drivers/pci/controller/pci-mvebu.c:572:29: sparse: expected restricted __le16 [usertype] device
>> drivers/pci/controller/pci-mvebu.c:572:29: sparse: got unsigned int
>> drivers/pci/controller/pci-mvebu.c:573:37: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] class_revision @@ got unsigned int @@
>> drivers/pci/controller/pci-mvebu.c:573:37: sparse: expected restricted __le32 [usertype] class_revision
drivers/pci/controller/pci-mvebu.c:573:37: sparse: got unsigned int
drivers/pci/controller/pci-mvebu.c:716:31: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected void [noderef] <asn:2> * @@ got void * @@
drivers/pci/controller/pci-mvebu.c:716:31: sparse: expected void [noderef] <asn:2> *
drivers/pci/controller/pci-mvebu.c:716:31: sparse: got void *
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout e0d9d30b73548fbfe5c024ed630169bdc9a08aee
vim +368 drivers/pci/controller/pci-mvebu.c
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 360
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 361 static void mvebu_pcie_handle_iobase_change(struct mvebu_pcie_port *port)
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 362 {
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 363 struct mvebu_pcie_window desired = {};
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 364 struct pci_bridge_emul_conf *conf = &port->bridge.conf;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 365
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 366 /* Are the new iobase/iolimit values invalid? */
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 367 if (conf->iolimit < conf->iobase ||
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 @368 conf->iolimitupper < conf->iobaseupper ||
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 369 !(conf->command & PCI_COMMAND_IO)) {
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 370 mvebu_pcie_set_window(port, port->io_target, port->io_attr,
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 371 &desired, &port->iowin);
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 372 return;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 373 }
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 374
641e674d6c0f97 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2013-11-26 375 if (!mvebu_has_ioport(port)) {
641e674d6c0f97 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2013-11-26 376 dev_WARN(&port->pcie->pdev->dev,
641e674d6c0f97 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2013-11-26 377 "Attempt to set IO when IO is disabled\n");
641e674d6c0f97 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2013-11-26 378 return;
641e674d6c0f97 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2013-11-26 379 }
641e674d6c0f97 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2013-11-26 380
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 381 /*
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 382 * We read the PCI-to-PCI bridge emulated registers, and
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 383 * calculate the base address and size of the address decoding
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 384 * window to setup, according to the PCI-to-PCI bridge
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 385 * specifications. iobase is the bus address, port->iowin_base
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 386 * is the CPU address.
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 387 */
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 388 desired.remap = ((conf->iobase & 0xF0) << 8) |
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 389 (conf->iobaseupper << 16);
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 390 desired.base = port->pcie->io.start + desired.remap;
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 391 desired.size = ((0xFFF | ((conf->iolimit & 0xF0) << 8) |
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 392 (conf->iolimitupper << 16)) -
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 393 desired.remap) +
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 394 1;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 395
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 396 mvebu_pcie_set_window(port, port->io_target, port->io_attr, &desired,
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 397 &port->iowin);
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 398 }
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 399
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 400 static void mvebu_pcie_handle_membase_change(struct mvebu_pcie_port *port)
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 401 {
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 402 struct mvebu_pcie_window desired = {.remap = MVEBU_MBUS_NO_REMAP};
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 403 struct pci_bridge_emul_conf *conf = &port->bridge.conf;
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 404
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 405 /* Are the new membase/memlimit values invalid? */
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 406 if (conf->memlimit < conf->membase ||
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 407 !(conf->command & PCI_COMMAND_MEMORY)) {
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 408 mvebu_pcie_set_window(port, port->mem_target, port->mem_attr,
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 409 &desired, &port->memwin);
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 410 return;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 411 }
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 412
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 413 /*
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 414 * We read the PCI-to-PCI bridge emulated registers, and
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 415 * calculate the base address and size of the address decoding
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 416 * window to setup, according to the PCI-to-PCI bridge
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 417 * specifications.
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 418 */
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 419 desired.base = ((conf->membase & 0xFFF0) << 16);
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 420 desired.size = (((conf->memlimit & 0xFFF0) << 16) | 0xFFFFF) -
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 421 desired.base + 1;
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 422
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 423 mvebu_pcie_set_window(port, port->mem_target, port->mem_attr, &desired,
d9bf28e2650fe3 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2016-12-12 424 &port->memwin);
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 425 }
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 426
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 427 static pci_bridge_emul_read_status_t
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 428 mvebu_pci_bridge_emul_pcie_conf_read(struct pci_bridge_emul *bridge,
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 429 int reg, u32 *value)
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 430 {
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 431 struct mvebu_pcie_port *port = bridge->data;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 432
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 433 switch (reg) {
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 434 case PCI_EXP_DEVCAP:
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 435 *value = mvebu_readl(port, PCIE_CAP_PCIEXP + PCI_EXP_DEVCAP);
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 436 break;
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 437
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 438 case PCI_EXP_DEVCTL:
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 439 *value = mvebu_readl(port, PCIE_CAP_PCIEXP + PCI_EXP_DEVCTL) &
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 440 ~(PCI_EXP_DEVCTL_URRE | PCI_EXP_DEVCTL_FERE |
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 441 PCI_EXP_DEVCTL_NFERE | PCI_EXP_DEVCTL_CERE);
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 442 break;
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 443
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 444 case PCI_EXP_LNKCAP:
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 445 /*
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 446 * PCIe requires the clock power management capability to be
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 447 * hard-wired to zero for downstream ports
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 448 */
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 449 *value = mvebu_readl(port, PCIE_CAP_PCIEXP + PCI_EXP_LNKCAP) &
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 450 ~PCI_EXP_LNKCAP_CLKPM;
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 451 break;
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 452
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 453 case PCI_EXP_LNKCTL:
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 454 *value = mvebu_readl(port, PCIE_CAP_PCIEXP + PCI_EXP_LNKCTL);
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 455 break;
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 456
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 457 case PCI_EXP_SLTCTL:
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 458 *value = PCI_EXP_SLTSTA_PDS << 16;
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 459 break;
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 460
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 461 case PCI_EXP_RTSTA:
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 462 *value = mvebu_readl(port, PCIE_RC_RTSTA);
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 463 break;
dc0352ab0b2a0c drivers/pci/host/pci-mvebu.c Russell King 2015-10-03 464
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 465 default:
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 466 return PCI_BRIDGE_EMUL_NOT_HANDLED;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 467 }
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 468
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 469 return PCI_BRIDGE_EMUL_HANDLED;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 470 }
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 471
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 472 static void
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 473 mvebu_pci_bridge_emul_base_conf_write(struct pci_bridge_emul *bridge,
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 474 int reg, u32 old, u32 new, u32 mask)
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 475 {
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 476 struct mvebu_pcie_port *port = bridge->data;
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 477 struct pci_bridge_emul_conf *conf = &bridge->conf;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 478
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 479 switch (reg) {
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 480 case PCI_COMMAND:
43a16f94445310 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2013-11-26 481 {
641e674d6c0f97 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2013-11-26 482 if (!mvebu_has_ioport(port))
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 @483 conf->command &= ~PCI_COMMAND_IO;
641e674d6c0f97 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2013-11-26 484
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 485 if ((old ^ new) & PCI_COMMAND_IO)
43a16f94445310 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2013-11-26 486 mvebu_pcie_handle_iobase_change(port);
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 487 if ((old ^ new) & PCI_COMMAND_MEMORY)
43a16f94445310 drivers/pci/host/pci-mvebu.c Jason Gunthorpe 2013-11-26 488 mvebu_pcie_handle_membase_change(port);
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 489
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 490 break;
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 491 }
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 492
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 493 case PCI_IO_BASE:
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 494 /*
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 495 * We keep bit 1 set, it is a read-only bit that
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 496 * indicates we support 32 bits addressing for the
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 497 * I/O
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 498 */
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 499 conf->iobase |= PCI_IO_RANGE_TYPE_32;
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 500 conf->iolimit |= PCI_IO_RANGE_TYPE_32;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 501 mvebu_pcie_handle_iobase_change(port);
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 502 break;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 503
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 504 case PCI_MEMORY_BASE:
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 505 mvebu_pcie_handle_membase_change(port);
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 506 break;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 507
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 508 case PCI_IO_BASE_UPPER16:
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 509 mvebu_pcie_handle_iobase_change(port);
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 510 break;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 511
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 512 case PCI_PRIMARY_BUS:
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 513 mvebu_pcie_set_local_bus_nr(port, conf->secondary_bus);
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 514 break;
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 515
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 516 default:
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 517 break;
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 518 }
1f08673eef1236 drivers/pci/controller/pci-mvebu.c Thomas Petazzoni 2018-10-18 519 }
45361a4fe44641 drivers/pci/host/pci-mvebu.c Thomas Petazzoni 2013-05-16 520
:::::: The code at line 368 was first introduced by commit
:::::: 1f08673eef1236f7d02d93fcf596bb8531ef0d12 PCI: mvebu: Convert to PCI emulated bridge config space
:::::: TO: Thomas Petazzoni <thomas.petazzoni(a)bootlin.com>
:::::: CC: Lorenzo Pieralisi <lorenzo.pieralisi(a)arm.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [PATCH] staging: android: ashmem.c: Cleanup
by kernel test robot
Hi Dio,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[cannot apply to aa5af974127d317071d6225a0f3678c5f520e7ce]
url: https://github.com/0day-ci/linux/commits/Dio-Putra/staging-android-ashmem...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git af7b4801030c07637840191c69eb666917e4135d
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
config: i386-randconfig-s002-20200614 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-250-g42323db3-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/staging/android/ashmem.c:418:25: sparse: sparse: assignment to const expression
drivers/staging/android/ashmem.c:419:36: sparse: sparse: assignment to const expression
drivers/staging/android/ashmem.c:420:36: sparse: sparse: assignment to const expression
# https://github.com/0day-ci/linux/commit/7fe32ab69ec805d9e6b68fc7871f9de38...
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 7fe32ab69ec805d9e6b68fc7871f9de384429a48
vim +418 drivers/staging/android/ashmem.c
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 367
11980c2ac4ccfa Robert Love 2011-12-20 368 static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
11980c2ac4ccfa Robert Love 2011-12-20 369 {
7fe32ab69ec805 Dio Putra 2020-06-14 370 static const struct file_operations vmfile_fops;
11980c2ac4ccfa Robert Love 2011-12-20 371 struct ashmem_area *asma = file->private_data;
11980c2ac4ccfa Robert Love 2011-12-20 372 int ret = 0;
11980c2ac4ccfa Robert Love 2011-12-20 373
11980c2ac4ccfa Robert Love 2011-12-20 374 mutex_lock(&ashmem_mutex);
11980c2ac4ccfa Robert Love 2011-12-20 375
11980c2ac4ccfa Robert Love 2011-12-20 376 /* user needs to SET_SIZE before mapping */
59848d6aded59a Alistair Strachan 2018-06-19 377 if (!asma->size) {
11980c2ac4ccfa Robert Love 2011-12-20 378 ret = -EINVAL;
11980c2ac4ccfa Robert Love 2011-12-20 379 goto out;
11980c2ac4ccfa Robert Love 2011-12-20 380 }
11980c2ac4ccfa Robert Love 2011-12-20 381
8632c614565d0c Alistair Strachan 2018-06-19 382 /* requested mapping size larger than object size */
8632c614565d0c Alistair Strachan 2018-06-19 383 if (vma->vm_end - vma->vm_start > PAGE_ALIGN(asma->size)) {
11980c2ac4ccfa Robert Love 2011-12-20 384 ret = -EINVAL;
11980c2ac4ccfa Robert Love 2011-12-20 385 goto out;
11980c2ac4ccfa Robert Love 2011-12-20 386 }
11980c2ac4ccfa Robert Love 2011-12-20 387
11980c2ac4ccfa Robert Love 2011-12-20 388 /* requested protection bits must match our allowed protection mask */
59848d6aded59a Alistair Strachan 2018-06-19 389 if ((vma->vm_flags & ~calc_vm_prot_bits(asma->prot_mask, 0)) &
59848d6aded59a Alistair Strachan 2018-06-19 390 calc_vm_prot_bits(PROT_MASK, 0)) {
11980c2ac4ccfa Robert Love 2011-12-20 391 ret = -EPERM;
11980c2ac4ccfa Robert Love 2011-12-20 392 goto out;
11980c2ac4ccfa Robert Love 2011-12-20 393 }
56f76fc68492af Arve Hjønnevåg 2011-12-20 394 vma->vm_flags &= ~calc_vm_may_flags(~asma->prot_mask);
11980c2ac4ccfa Robert Love 2011-12-20 395
11980c2ac4ccfa Robert Love 2011-12-20 396 if (!asma->file) {
11980c2ac4ccfa Robert Love 2011-12-20 397 char *name = ASHMEM_NAME_DEF;
11980c2ac4ccfa Robert Love 2011-12-20 398 struct file *vmfile;
11980c2ac4ccfa Robert Love 2011-12-20 399
11980c2ac4ccfa Robert Love 2011-12-20 400 if (asma->name[ASHMEM_NAME_PREFIX_LEN] != '\0')
11980c2ac4ccfa Robert Love 2011-12-20 401 name = asma->name;
11980c2ac4ccfa Robert Love 2011-12-20 402
11980c2ac4ccfa Robert Love 2011-12-20 403 /* ... and allocate the backing shmem file */
11980c2ac4ccfa Robert Love 2011-12-20 404 vmfile = shmem_file_setup(name, asma->size, vma->vm_flags);
7f44cb0ba88b40 Viresh Kumar 2015-07-31 405 if (IS_ERR(vmfile)) {
11980c2ac4ccfa Robert Love 2011-12-20 406 ret = PTR_ERR(vmfile);
11980c2ac4ccfa Robert Love 2011-12-20 407 goto out;
11980c2ac4ccfa Robert Love 2011-12-20 408 }
97fbfef6bd5978 Shuxiao Zhang 2017-04-06 409 vmfile->f_mode |= FMODE_LSEEK;
11980c2ac4ccfa Robert Love 2011-12-20 410 asma->file = vmfile;
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 411 /*
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 412 * override mmap operation of the vmfile so that it can't be
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 413 * remapped which would lead to creation of a new vma with no
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 414 * asma permission checks. Have to override get_unmapped_area
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 415 * as well to prevent VM_BUG_ON check for f_ops modification.
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 416 */
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 417 if (!vmfile_fops.mmap) {
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 @418 vmfile_fops = *vmfile->f_op;
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 419 vmfile_fops.mmap = ashmem_vmfile_mmap;
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 420 vmfile_fops.get_unmapped_area =
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 421 ashmem_vmfile_get_unmapped_area;
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 422 }
6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 423 vmfile->f_op = &vmfile_fops;
11980c2ac4ccfa Robert Love 2011-12-20 424 }
11980c2ac4ccfa Robert Love 2011-12-20 425 get_file(asma->file);
11980c2ac4ccfa Robert Love 2011-12-20 426
11980c2ac4ccfa Robert Love 2011-12-20 427 /*
11980c2ac4ccfa Robert Love 2011-12-20 428 * XXX - Reworked to use shmem_zero_setup() instead of
11980c2ac4ccfa Robert Love 2011-12-20 429 * shmem_set_file while we're in staging. -jstultz
11980c2ac4ccfa Robert Love 2011-12-20 430 */
11980c2ac4ccfa Robert Love 2011-12-20 431 if (vma->vm_flags & VM_SHARED) {
11980c2ac4ccfa Robert Love 2011-12-20 432 ret = shmem_zero_setup(vma);
11980c2ac4ccfa Robert Love 2011-12-20 433 if (ret) {
11980c2ac4ccfa Robert Love 2011-12-20 434 fput(asma->file);
11980c2ac4ccfa Robert Love 2011-12-20 435 goto out;
11980c2ac4ccfa Robert Love 2011-12-20 436 }
44960f2a7b63e2 John Stultz 2018-07-31 437 } else {
44960f2a7b63e2 John Stultz 2018-07-31 438 vma_set_anonymous(vma);
11980c2ac4ccfa Robert Love 2011-12-20 439 }
11980c2ac4ccfa Robert Love 2011-12-20 440
11980c2ac4ccfa Robert Love 2011-12-20 441 if (vma->vm_file)
11980c2ac4ccfa Robert Love 2011-12-20 442 fput(vma->vm_file);
11980c2ac4ccfa Robert Love 2011-12-20 443 vma->vm_file = asma->file;
11980c2ac4ccfa Robert Love 2011-12-20 444
11980c2ac4ccfa Robert Love 2011-12-20 445 out:
11980c2ac4ccfa Robert Love 2011-12-20 446 mutex_unlock(&ashmem_mutex);
11980c2ac4ccfa Robert Love 2011-12-20 447 return ret;
11980c2ac4ccfa Robert Love 2011-12-20 448 }
11980c2ac4ccfa Robert Love 2011-12-20 449
:::::: The code at line 418 was first introduced by commit
:::::: 6d67b0290b4b84c477e6a2fc6e005e174d3c7786 staging: android: ashmem: Disallow ashmem memory from being remapped
:::::: TO: Suren Baghdasaryan <surenb(a)google.com>
:::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
arch/mips/kvm/mips.c:70:25: error: 'struct kvm_vcpu_stat' has no member named 'vz_cpucfg_exits'; did you mean
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: df2fbf5bfa0e7fff8b4784507e4d68f200454318
commit: 7f2a83f1c2a941ebfee53f504ed5fdbc61cfb333 KVM: MIPS: Add CPUCFG emulation for Loongson-3
date: 9 days ago
:::::: branch date: 16 hours ago
:::::: commit date: 9 days ago
config: mips-randconfig-c022-20200613 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from <command-line>:
>> arch/mips/kvm/mips.c:70:25: error: 'struct kvm_vcpu_stat' has no member named 'vz_cpucfg_exits'; did you mean 'vz_gpsi_exits'?
70 | VCPU_STAT("vz_cpucfg", vz_cpucfg_exits),
| ^~~~~~~~~~~~~~~
include/linux/compiler_types.h:133:57: note: in definition of macro '__compiler_offsetof'
133 | #define __compiler_offsetof(a, b) __builtin_offsetof(a, b)
| ^
>> include/linux/kvm_host.h:1142:7: note: in expansion of macro 'offsetof'
1142 | { n, offsetof(struct kvm_vcpu, stat.x), KVM_STAT_VCPU, ## __VA_ARGS__ }
| ^~~~~~~~
>> arch/mips/kvm/mips.c:70:2: note: in expansion of macro 'VCPU_STAT'
70 | VCPU_STAT("vz_cpucfg", vz_cpucfg_exits),
| ^~~~~~~~~
arch/mips/kvm/mips.c:161:6: warning: no previous prototype for 'kvm_mips_free_vcpus' [-Wmissing-prototypes]
161 | void kvm_mips_free_vcpus(struct kvm *kvm)
| ^~~~~~~~~~~~~~~~~~~
--
>> arch/mips/kvm/vz.c:32:10: fatal error: loongson_regs.h: No such file or directory
32 | #include "loongson_regs.h"
| ^~~~~~~~~~~~~~~~~
compilation terminated.
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 7f2a83f1c2a941ebfee53f504ed5fdbc61cfb333
vim +70 arch/mips/kvm/mips.c
669e846e6c4e13 arch/mips/kvm/kvm_mips.c Sanjay Lal 2012-11-21 41
669e846e6c4e13 arch/mips/kvm/kvm_mips.c Sanjay Lal 2012-11-21 42 struct kvm_stats_debugfs_item debugfs_entries[] = {
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 43 VCPU_STAT("wait", wait_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 44 VCPU_STAT("cache", cache_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 45 VCPU_STAT("signal", signal_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 46 VCPU_STAT("interrupt", int_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 47 VCPU_STAT("cop_unusable", cop_unusable_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 48 VCPU_STAT("tlbmod", tlbmod_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 49 VCPU_STAT("tlbmiss_ld", tlbmiss_ld_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 50 VCPU_STAT("tlbmiss_st", tlbmiss_st_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 51 VCPU_STAT("addrerr_st", addrerr_st_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 52 VCPU_STAT("addrerr_ld", addrerr_ld_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 53 VCPU_STAT("syscall", syscall_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 54 VCPU_STAT("resvd_inst", resvd_inst_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 55 VCPU_STAT("break_inst", break_inst_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 56 VCPU_STAT("trap_inst", trap_inst_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 57 VCPU_STAT("msa_fpe", msa_fpe_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 58 VCPU_STAT("fpe", fpe_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 59 VCPU_STAT("msa_disabled", msa_disabled_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 60 VCPU_STAT("flush_dcache", flush_dcache_exits),
a7244920d1096c arch/mips/kvm/mips.c James Hogan 2017-03-14 61 #ifdef CONFIG_KVM_MIPS_VZ
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 62 VCPU_STAT("vz_gpsi", vz_gpsi_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 63 VCPU_STAT("vz_gsfc", vz_gsfc_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 64 VCPU_STAT("vz_hc", vz_hc_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 65 VCPU_STAT("vz_grr", vz_grr_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 66 VCPU_STAT("vz_gva", vz_gva_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 67 VCPU_STAT("vz_ghfc", vz_ghfc_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 68 VCPU_STAT("vz_gpa", vz_gpa_exits),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 69 VCPU_STAT("vz_resvd", vz_resvd_exits),
7f2a83f1c2a941 arch/mips/kvm/mips.c Huacai Chen 2020-05-23 @70 VCPU_STAT("vz_cpucfg", vz_cpucfg_exits),
a7244920d1096c arch/mips/kvm/mips.c James Hogan 2017-03-14 71 #endif
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 72 VCPU_STAT("halt_successful_poll", halt_successful_poll),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 73 VCPU_STAT("halt_attempted_poll", halt_attempted_poll),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 74 VCPU_STAT("halt_poll_invalid", halt_poll_invalid),
812756a82ea51e arch/mips/kvm/mips.c Emanuele Giuseppe Esposito 2020-04-14 75 VCPU_STAT("halt_wakeup", halt_wakeup),
cb953129bfe5c0 arch/mips/kvm/mips.c David Matlack 2020-05-08 76 VCPU_STAT("halt_poll_success_ns", halt_poll_success_ns),
cb953129bfe5c0 arch/mips/kvm/mips.c David Matlack 2020-05-08 77 VCPU_STAT("halt_poll_fail_ns", halt_poll_fail_ns),
669e846e6c4e13 arch/mips/kvm/kvm_mips.c Sanjay Lal 2012-11-21 78 {NULL}
669e846e6c4e13 arch/mips/kvm/kvm_mips.c Sanjay Lal 2012-11-21 79 };
669e846e6c4e13 arch/mips/kvm/kvm_mips.c Sanjay Lal 2012-11-21 80
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [PATCH 1/5] Huawei BMA: Adding Huawei BMA driver: host_edma_drv
by kernel test robot
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.8-rc1 next-20200615]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/yunaixin03610-163-com/Adding-Hua...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a5dc8300df75e8b8384b4c82225f1e4a0b4d9b55
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:21,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:21:
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.h:246:2: error: unknown type name '__kernel_time_t'
246 | __kernel_time_t init_time;
| ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:67:5: warning: no previous prototype for 'edma_param_get_statics' [-Wmissing-prototypes]
67 | int edma_param_get_statics(char *buf, const struct kernel_param *kp)
| ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:142:5: warning: no previous prototype for '__atu_config_H' [-Wmissing-prototypes]
142 | s32 __atu_config_H(struct pci_dev *pdev, unsigned int region,
| ^~~~~~~~~~~~~~
In file included from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:20,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:21:
drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c: In function 'ioremap_pme_bar1_mem':
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:80:17: error: implicit declaration of function 'ioremap_nocache'; did you mean 'ioremap_cache'? [-Werror=implicit-function-declaration]
80 | #define IOREMAP ioremap_nocache
| ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:246:7: note: in expansion of macro 'IOREMAP'
246 | IOREMAP(bma_pci_dev->bma_base_phy_addr,
| ^~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:245:30: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
245 | bma_pci_dev->bma_base_addr =
| ^
drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c: In function 'ioremap_bar_mem':
drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:310:31: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
310 | bma_pci_dev->kbox_base_addr =
| ^
drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c: At top level:
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:328:5: warning: no previous prototype for 'pme_pci_enable_msi' [-Wmissing-prototypes]
328 | int pme_pci_enable_msi(struct pci_dev *pdev)
| ^~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:354:5: warning: no previous prototype for 'pci_device_init' [-Wmissing-prototypes]
354 | int pci_device_init(struct pci_dev *pdev, struct bma_pci_dev_s *bma_pci_dev)
| ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:383:5: warning: no previous prototype for 'pci_device_config' [-Wmissing-prototypes]
383 | int pci_device_config(struct pci_dev *pdev)
| ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:505:12: warning: no previous prototype for 'bma_pci_init' [-Wmissing-prototypes]
505 | int __init bma_pci_init(void)
| ^~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.c:518:13: warning: no previous prototype for 'bma_pci_cleanup' [-Wmissing-prototypes]
518 | void __exit bma_pci_cleanup(void)
| ^~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:21,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.c:26:
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.h:246:2: error: unknown type name '__kernel_time_t'
246 | __kernel_time_t init_time;
| ^~~~~~~~~~~~~~~
In file included from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:20,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.c:26:
drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.c: In function 'bma_cdev_add_msg':
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:88:20: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
88 | netdev_alert(0, "edma: %s, %d, " fmt, | ^~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.c:500:3: note: in expansion of macro 'BMA_LOG'
500 | BMA_LOG(DLOG_DEBUG, "msg_len is %ldn", msg_len);
| ^~~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.c:500:37: note: format string is defined here
500 | BMA_LOG(DLOG_DEBUG, "msg_len is %ldn", msg_len);
| ~~^
| |
| long int
| %d
--
In file included from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:21,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:19,
from drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:22:
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.h:246:2: error: unknown type name '__kernel_time_t'
246 | __kernel_time_t init_time;
| ^~~~~~~~~~~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c: In function 'edmainfo_show':
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:35:2: error: unknown type name '__kernel_time_t'; did you mean '__kernel_timer_t'?
35 | __kernel_time_t running_time = 0;
| ^~~~~~~~~~~~~~~
| __kernel_timer_t
In file included from drivers/net/ethernet/huawei/bma/edma_drv/edma_host.h:19,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:21,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:19,
from drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:22:
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_include.h:109:19: error: storage size of 'uptime' isn't known
109 | struct timespec uptime; | ^~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:49:2: note: in expansion of macro 'GET_SYS_SECONDS'
49 | GET_SYS_SECONDS(running_time);
| ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_include.h:110:3: error: implicit declaration of function 'get_monotonic_boottime' [-Werror=implicit-function-declaration]
110 | get_monotonic_boottime(&uptime); | ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:49:2: note: in expansion of macro 'GET_SYS_SECONDS'
49 | GET_SYS_SECONDS(running_time);
| ^~~~~~~~~~~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/bma_include.h:109:19: warning: unused variable 'uptime' [-Wunused-variable]
109 | struct timespec uptime; | ^~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:49:2: note: in expansion of macro 'GET_SYS_SECONDS'
49 | GET_SYS_SECONDS(running_time);
| ^~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:55:45: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Wformat=]
55 | len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lun",
| ~~^
| |
| long unsigned int
| %u
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:55:52: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'int' [-Wformat=]
55 | len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lun",
| ~~~~^
| |
| long unsigned int
| %02u
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:55:58: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'int' [-Wformat=]
55 | len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lun",
| ~~~~^
| |
| long unsigned int
| %02u
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:55:64: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'int' [-Wformat=]
55 | len += sprintf(buf + len, "running_time :%luD %02lu:%02lu:%02lun",
| ~~~~^
| |
| long unsigned int
| %02u
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c: At top level:
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:581:6: warning: no previous prototype for 'host_dma_transfer_without_list' [-Wmissing-prototypes]
581 | void host_dma_transfer_without_list(struct edma_host_s *edma_host,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:608:6: warning: no previous prototype for 'host_dma_transfer_withlist' [-Wmissing-prototypes]
608 | void host_dma_transfer_withlist(struct edma_host_s *edma_host,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:22:
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c: In function 'edma_host_send_msg':
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:88:20: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'unsigned int' [-Wformat=]
88 | netdev_alert(0, "edma: %s, %d, " fmt, | ^~~~~~~~~~~~~~~~
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:791:3: note: in expansion of macro 'BMA_LOG'
791 | BMA_LOG(DLOG_ERROR,
| ^~~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:792:48: note: format string is defined here
792 | "Length of send message %u is larger than %lun",
| ~~^
| |
| long unsigned int
| %u
In file included from drivers/net/ethernet/huawei/bma/edma_drv/edma_host.h:19,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_devintf.h:21,
from drivers/net/ethernet/huawei/bma/edma_drv/bma_pci.h:19,
from drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:22:
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c: In function 'edma_host_init':
>> drivers/net/ethernet/huawei/bma/edma_drv/bma_include.h:109:19: error: storage size of 'uptime' isn't known
109 | struct timespec uptime; | ^~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:1410:2: note: in expansion of macro 'GET_SYS_SECONDS'
1410 | GET_SYS_SECONDS(edma_host->statistics.init_time);
| ^~~~~~~~~~~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/bma_include.h:109:19: warning: unused variable 'uptime' [-Wunused-variable]
109 | struct timespec uptime; | ^~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:1410:2: note: in expansion of macro 'GET_SYS_SECONDS'
1410 | GET_SYS_SECONDS(edma_host->statistics.init_time);
| ^~~~~~~~~~~~~~~
drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c: In function 'edma_host_cleanup':
>> drivers/net/ethernet/huawei/bma/edma_drv/edma_host.c:1434:20: warning: variable 'bma_dev' set but not used [-Wunused-but-set-variable]
1434 | struct bma_dev_s *bma_dev = NULL;
| ^~~~~~~
cc1: some warnings being treated as errors
vim +/__kernel_time_t +246 drivers/net/ethernet/huawei/bma/edma_drv/edma_host.h
243
244 struct edma_statistics_s {
245 unsigned int remote_status;
> 246 __kernel_time_t init_time;
247 unsigned int h2b_int;
248 unsigned int b2h_int;
249 unsigned int recv_bytes;
250 unsigned int send_bytes;
251 unsigned int send_pkgs;
252 unsigned int recv_pkgs;
253 unsigned int failed_count;
254 unsigned int drop_pkgs;
255 unsigned int dma_count;
256 unsigned int lost_count;
257 };
258
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[linux-next:pending-fixes 86/168] drivers/gpu/drm/i915/gt/selftest_lrc.c:1333:3: error: too few arguments to function 'engine_heartbeat_disable'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git pending-fixes
head: d1a574997c4e461b39d3c8162b5fcf1a402888b7
commit: 04dc41776145f539ab6da442cb633e45539bed9a [86/168] drm/i915/gt: Prevent timeslicing into unpreemptable requests
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the linux-next/pending-fixes HEAD d1a574997c4e461b39d3c8162b5fcf1a402888b7 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>, old ones prefixed by <<):
In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:5953:
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_timeslice_nopreempt':
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:1333:3: error: too few arguments to function 'engine_heartbeat_disable'
1333 | engine_heartbeat_disable(engine);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c:54:13: note: declared here
54 | static void engine_heartbeat_disable(struct intel_engine_cs *engine,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c:1402:3: error: too few arguments to function 'engine_heartbeat_enable'
1402 | engine_heartbeat_enable(engine);
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c:64:13: note: declared here
64 | static void engine_heartbeat_enable(struct intel_engine_cs *engine,
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/engine_heartbeat_disable +1333 drivers/gpu/drm/i915/gt/selftest_lrc.c
1300
1301 static int live_timeslice_nopreempt(void *arg)
1302 {
1303 struct intel_gt *gt = arg;
1304 struct intel_engine_cs *engine;
1305 enum intel_engine_id id;
1306 struct igt_spinner spin;
1307 int err = 0;
1308
1309 /*
1310 * We should not timeslice into a request that is marked with
1311 * I915_REQUEST_NOPREEMPT.
1312 */
1313 if (!IS_ACTIVE(CONFIG_DRM_I915_TIMESLICE_DURATION))
1314 return 0;
1315
1316 if (igt_spinner_init(&spin, gt))
1317 return -ENOMEM;
1318
1319 for_each_engine(engine, gt, id) {
1320 struct intel_context *ce;
1321 struct i915_request *rq;
1322 unsigned long timeslice;
1323
1324 if (!intel_engine_has_preemption(engine))
1325 continue;
1326
1327 ce = intel_context_create(engine);
1328 if (IS_ERR(ce)) {
1329 err = PTR_ERR(ce);
1330 break;
1331 }
1332
> 1333 engine_heartbeat_disable(engine);
1334 timeslice = xchg(&engine->props.timeslice_duration_ms, 1);
1335
1336 /* Create an unpreemptible spinner */
1337
1338 rq = igt_spinner_create_request(&spin, ce, MI_ARB_CHECK);
1339 intel_context_put(ce);
1340 if (IS_ERR(rq)) {
1341 err = PTR_ERR(rq);
1342 goto out_heartbeat;
1343 }
1344
1345 i915_request_get(rq);
1346 i915_request_add(rq);
1347
1348 if (!igt_wait_for_spinner(&spin, rq)) {
1349 i915_request_put(rq);
1350 err = -ETIME;
1351 goto out_spin;
1352 }
1353
1354 set_bit(I915_FENCE_FLAG_NOPREEMPT, &rq->fence.flags);
1355 i915_request_put(rq);
1356
1357 /* Followed by a maximum priority barrier (heartbeat) */
1358
1359 ce = intel_context_create(engine);
1360 if (IS_ERR(ce)) {
1361 err = PTR_ERR(rq);
1362 goto out_spin;
1363 }
1364
1365 rq = intel_context_create_request(ce);
1366 intel_context_put(ce);
1367 if (IS_ERR(rq)) {
1368 err = PTR_ERR(rq);
1369 goto out_spin;
1370 }
1371
1372 rq->sched.attr.priority = I915_PRIORITY_BARRIER;
1373 i915_request_get(rq);
1374 i915_request_add(rq);
1375
1376 /*
1377 * Wait until the barrier is in ELSP, and we know timeslicing
1378 * will have been activated.
1379 */
1380 if (wait_for_submit(engine, rq, HZ / 2)) {
1381 i915_request_put(rq);
1382 err = -ETIME;
1383 goto out_spin;
1384 }
1385
1386 /*
1387 * Since the ELSP[0] request is unpreemptible, it should not
1388 * allow the maximum priority barrier through. Wait long
1389 * enough to see if it is timesliced in by mistake.
1390 */
1391 if (i915_request_wait(rq, 0, timeslice_threshold(engine)) >= 0) {
1392 pr_err("%s: I915_PRIORITY_BARRIER request completed, bypassing no-preempt request\n",
1393 engine->name);
1394 err = -EINVAL;
1395 }
1396 i915_request_put(rq);
1397
1398 out_spin:
1399 igt_spinner_end(&spin);
1400 out_heartbeat:
1401 xchg(&engine->props.timeslice_duration_ms, timeslice);
1402 engine_heartbeat_enable(engine);
1403 if (err)
1404 break;
1405
1406 if (igt_flush_test(gt->i915)) {
1407 err = -EIO;
1408 break;
1409 }
1410 }
1411
1412 igt_spinner_fini(&spin);
1413 return err;
1414 }
1415
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[drm-intel:for-linux-next-fixes 4/16] drivers/gpu/drm/i915/gt/selftest_lrc.c:1402:3: error: too few arguments to function 'engine_heartbeat_enable'
by kernel test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next-fixes
head: add78d27d388520cbed6a7bf01d1e0afa183314d
commit: 04dc41776145f539ab6da442cb633e45539bed9a [4/16] drm/i915/gt: Prevent timeslicing into unpreemptable requests
config: i386-allmodconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:5953:
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_timeslice_nopreempt':
drivers/gpu/drm/i915/gt/selftest_lrc.c:1333:3: error: too few arguments to function 'engine_heartbeat_disable'
1333 | engine_heartbeat_disable(engine);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c:54:13: note: declared here
54 | static void engine_heartbeat_disable(struct intel_engine_cs *engine,
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/gt/selftest_lrc.c:1402:3: error: too few arguments to function 'engine_heartbeat_enable'
1402 | engine_heartbeat_enable(engine);
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/gt/selftest_lrc.c:64:13: note: declared here
64 | static void engine_heartbeat_enable(struct intel_engine_cs *engine,
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/engine_heartbeat_enable +1402 drivers/gpu/drm/i915/gt/selftest_lrc.c
1300
1301 static int live_timeslice_nopreempt(void *arg)
1302 {
1303 struct intel_gt *gt = arg;
1304 struct intel_engine_cs *engine;
1305 enum intel_engine_id id;
1306 struct igt_spinner spin;
1307 int err = 0;
1308
1309 /*
1310 * We should not timeslice into a request that is marked with
1311 * I915_REQUEST_NOPREEMPT.
1312 */
1313 if (!IS_ACTIVE(CONFIG_DRM_I915_TIMESLICE_DURATION))
1314 return 0;
1315
1316 if (igt_spinner_init(&spin, gt))
1317 return -ENOMEM;
1318
1319 for_each_engine(engine, gt, id) {
1320 struct intel_context *ce;
1321 struct i915_request *rq;
1322 unsigned long timeslice;
1323
1324 if (!intel_engine_has_preemption(engine))
1325 continue;
1326
1327 ce = intel_context_create(engine);
1328 if (IS_ERR(ce)) {
1329 err = PTR_ERR(ce);
1330 break;
1331 }
1332
1333 engine_heartbeat_disable(engine);
1334 timeslice = xchg(&engine->props.timeslice_duration_ms, 1);
1335
1336 /* Create an unpreemptible spinner */
1337
1338 rq = igt_spinner_create_request(&spin, ce, MI_ARB_CHECK);
1339 intel_context_put(ce);
1340 if (IS_ERR(rq)) {
1341 err = PTR_ERR(rq);
1342 goto out_heartbeat;
1343 }
1344
1345 i915_request_get(rq);
1346 i915_request_add(rq);
1347
1348 if (!igt_wait_for_spinner(&spin, rq)) {
1349 i915_request_put(rq);
1350 err = -ETIME;
1351 goto out_spin;
1352 }
1353
1354 set_bit(I915_FENCE_FLAG_NOPREEMPT, &rq->fence.flags);
1355 i915_request_put(rq);
1356
1357 /* Followed by a maximum priority barrier (heartbeat) */
1358
1359 ce = intel_context_create(engine);
1360 if (IS_ERR(ce)) {
1361 err = PTR_ERR(rq);
1362 goto out_spin;
1363 }
1364
1365 rq = intel_context_create_request(ce);
1366 intel_context_put(ce);
1367 if (IS_ERR(rq)) {
1368 err = PTR_ERR(rq);
1369 goto out_spin;
1370 }
1371
1372 rq->sched.attr.priority = I915_PRIORITY_BARRIER;
1373 i915_request_get(rq);
1374 i915_request_add(rq);
1375
1376 /*
1377 * Wait until the barrier is in ELSP, and we know timeslicing
1378 * will have been activated.
1379 */
1380 if (wait_for_submit(engine, rq, HZ / 2)) {
1381 i915_request_put(rq);
1382 err = -ETIME;
1383 goto out_spin;
1384 }
1385
1386 /*
1387 * Since the ELSP[0] request is unpreemptible, it should not
1388 * allow the maximum priority barrier through. Wait long
1389 * enough to see if it is timesliced in by mistake.
1390 */
1391 if (i915_request_wait(rq, 0, timeslice_threshold(engine)) >= 0) {
1392 pr_err("%s: I915_PRIORITY_BARRIER request completed, bypassing no-preempt request\n",
1393 engine->name);
1394 err = -EINVAL;
1395 }
1396 i915_request_put(rq);
1397
1398 out_spin:
1399 igt_spinner_end(&spin);
1400 out_heartbeat:
1401 xchg(&engine->props.timeslice_duration_ms, timeslice);
> 1402 engine_heartbeat_enable(engine);
1403 if (err)
1404 break;
1405
1406 if (igt_flush_test(gt->i915)) {
1407 err = -EIO;
1408 break;
1409 }
1410 }
1411
1412 igt_spinner_fini(&spin);
1413 return err;
1414 }
1415
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[dhowells-fs:afs-fixes 13/13] fs/afs/dir.c:699:39: warning: unused variable 'afs_lookup_fetch_status_operation'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git afs-fixes
head: e5602e1b930f79764f0039494de744168c67938a
commit: e5602e1b930f79764f0039494de744168c67938a [13/13] afs: Fix silly rename
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 487ca07fcc75d52755c9fe2ee05bcb3b6eeeec44)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout e5602e1b930f79764f0039494de744168c67938a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
fs/afs/dir.c:135:11: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
ntohs(dbuf->blocks[tmp].hdr.magic));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/byteorder/generic.h:142:18: note: expanded from macro 'ntohs'
#define ntohs(x) ___ntohs(x)
^~~~~~~~~~~
include/linux/byteorder/generic.h:137:21: note: expanded from macro '___ntohs'
#define ___ntohs(x) __be16_to_cpu(x)
^~~~~~~~~~~~~~~~
include/uapi/linux/byteorder/little_endian.h:42:26: note: expanded from macro '__be16_to_cpu'
#define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/uapi/linux/swab.h:105:2: note: expanded from macro '__swab16'
(__builtin_constant_p((__u16)(x)) ? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> fs/afs/dir.c:699:39: warning: unused variable 'afs_lookup_fetch_status_operation' [-Wunused-const-variable]
static const struct afs_operation_ops afs_lookup_fetch_status_operation = {
^
2 warnings generated.
vim +/afs_lookup_fetch_status_operation +699 fs/afs/dir.c
698
> 699 static const struct afs_operation_ops afs_lookup_fetch_status_operation = {
700 .issue_afs_rpc = afs_fs_fetch_status,
701 .issue_yfs_rpc = yfs_fs_fetch_status,
702 .success = afs_do_lookup_success,
703 .aborted = afs_check_for_remote_deletion,
704 };
705
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [PATCH v3 2/3] pinctrl: lynxpoint: Make use of for_each_requested_gpio()
by kernel test robot
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on pinctrl/devel]
[also build test ERROR on v5.8-rc1 next-20200615]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/pinctrl-intel-Re...
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 487ca07fcc75d52755c9fe2ee05bcb3b6eeeec44)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/pinctrl/intel/pinctrl-lynxpoint.c:928:2: error: implicit declaration of function 'for_each_requested_gpio' [-Werror,-Wimplicit-function-declaration]
for_each_requested_gpio(chip, i, dummy) {
^
>> drivers/pinctrl/intel/pinctrl-lynxpoint.c:928:41: error: expected ';' after expression
for_each_requested_gpio(chip, i, dummy) {
^
;
2 errors generated.
vim +/for_each_requested_gpio +928 drivers/pinctrl/intel/pinctrl-lynxpoint.c
918
919 static int lp_gpio_resume(struct device *dev)
920 {
921 struct intel_pinctrl *lg = dev_get_drvdata(dev);
922 struct gpio_chip *chip = &lg->chip;
923 const char *dummy;
924 void __iomem *reg;
925 int i;
926
927 /* on some hardware suspend clears input sensing, re-enable it here */
> 928 for_each_requested_gpio(chip, i, dummy) {
929 reg = lp_gpio_reg(chip, i, LP_CONFIG2);
930 iowrite32(ioread32(reg) & ~GPINDIS_BIT, reg);
931 }
932
933 return 0;
934 }
935
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[sashal-linux-stable:queue-5.7 23/32] imx8.c:(.text.imx8x_run+0x40): undefined reference to `.imx_sc_misc_set_control'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-5.7
head: 390c6a3c9da56f899f8f21f283ab84dd5f05e378
commit: dead36a88435abfde8c64da87d4c50afa7e7ba3a [23/32] ASoC: SOF: imx: fix undefined reference issue
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout dead36a88435abfde8c64da87d4c50afa7e7ba3a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
powerpc64-linux-ld: sound/soc/sof/imx/imx8.o: in function `.imx8_run':
imx8.c:(.text.imx8_run+0x40): undefined reference to `.imx_sc_misc_set_control'
powerpc64-linux-ld: imx8.c:(.text.imx8_run+0xac): undefined reference to `.imx_sc_pm_cpu_start'
powerpc64-linux-ld: sound/soc/sof/imx/imx8.o: in function `.imx8x_run':
>> imx8.c:(.text.imx8x_run+0x40): undefined reference to `.imx_sc_misc_set_control'
>> powerpc64-linux-ld: imx8.c:(.text.imx8x_run+0xa8): undefined reference to `.imx_sc_misc_set_control'
powerpc64-linux-ld: imx8.c:(.text.imx8x_run+0x108): undefined reference to `.imx_sc_misc_set_control'
powerpc64-linux-ld: imx8.c:(.text.imx8x_run+0x168): undefined reference to `.imx_sc_misc_set_control'
>> powerpc64-linux-ld: imx8.c:(.text.imx8x_run+0x1cc): undefined reference to `.imx_sc_pm_cpu_start'
powerpc64-linux-ld: sound/soc/sof/imx/imx8.o: in function `.imx8_probe':
imx8.c:(.text.imx8_probe+0x2d8): undefined reference to `.imx_scu_get_handle'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months