include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
by kernel test robot
Hi Bartlomiej,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b791d1bdf9212d944d749a5c7ff6febdba241771
commit: 6f09eae3b5d974ef845e56690d6bc2b8f2a70acd ata: expose ncq_enable_prio sysfs attribute only on NCQ capable hosts
date: 3 months ago
config: i386-randconfig-r011-20200612 (attached as .config)
compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
reproduce (this is a W=1 build):
git checkout 6f09eae3b5d974ef845e56690d6bc2b8f2a70acd
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from include/linux/linkage.h:7:0,
from include/linux/kernel.h:8,
from drivers/ata/ahci_platform.c:11:
include/linux/export.h:19:30: warning: initialized field overwritten [-Woverride-init]
#define THIS_MODULE ((struct module *)0)
^
include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
.module = THIS_MODULE, ^
>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
__ATA_BASE_SHT(drv_name), ^
drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
ATA_NCQ_SHT(drv_name), ^
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro 'AHCI_SHT'
AHCI_SHT(DRV_NAME),
^
include/linux/export.h:19:30: warning: (near initialization for 'ahci_platform_sht.can_queue') [-Woverride-init]
#define THIS_MODULE ((struct module *)0)
^
include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
.module = THIS_MODULE, ^
>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
__ATA_BASE_SHT(drv_name), ^
drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
ATA_NCQ_SHT(drv_name), ^
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro 'AHCI_SHT'
AHCI_SHT(DRV_NAME),
^
include/linux/export.h:19:30: warning: initialized field overwritten [-Woverride-init]
#define THIS_MODULE ((struct module *)0)
^
include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
.module = THIS_MODULE, ^
>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
__ATA_BASE_SHT(drv_name), ^
drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
ATA_NCQ_SHT(drv_name), ^
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro 'AHCI_SHT'
AHCI_SHT(DRV_NAME),
^
include/linux/export.h:19:30: warning: (near initialization for 'ahci_platform_sht.sdev_attrs') [-Woverride-init]
#define THIS_MODULE ((struct module *)0)
^
include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
.module = THIS_MODULE, ^
>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
__ATA_BASE_SHT(drv_name), ^
drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
ATA_NCQ_SHT(drv_name), ^
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro 'AHCI_SHT'
AHCI_SHT(DRV_NAME),
^
--
In file included from include/linux/linkage.h:7:0,
from include/linux/kernel.h:8,
from drivers/ata/ahci_ceva.c:10:
include/linux/export.h:19:30: warning: initialized field overwritten [-Woverride-init]
#define THIS_MODULE ((struct module *)0)
^
include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
.module = THIS_MODULE, ^
>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
__ATA_BASE_SHT(drv_name), ^
drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
ATA_NCQ_SHT(drv_name), ^
drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro 'AHCI_SHT'
AHCI_SHT(DRV_NAME),
^
include/linux/export.h:19:30: warning: (near initialization for 'ahci_platform_sht.can_queue') [-Woverride-init]
#define THIS_MODULE ((struct module *)0)
^
include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
.module = THIS_MODULE, ^
>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
__ATA_BASE_SHT(drv_name), ^
drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
ATA_NCQ_SHT(drv_name), ^
drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro 'AHCI_SHT'
AHCI_SHT(DRV_NAME),
^
include/linux/export.h:19:30: warning: initialized field overwritten [-Woverride-init]
#define THIS_MODULE ((struct module *)0)
^
include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
.module = THIS_MODULE, ^
>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
__ATA_BASE_SHT(drv_name), ^
drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
ATA_NCQ_SHT(drv_name), ^
drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro 'AHCI_SHT'
AHCI_SHT(DRV_NAME),
^
include/linux/export.h:19:30: warning: (near initialization for 'ahci_platform_sht.sdev_attrs') [-Woverride-init]
#define THIS_MODULE ((struct module *)0)
^
include/linux/libata.h:1346:14: note: in expansion of macro 'THIS_MODULE'
.module = THIS_MODULE, ^
>> include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'
__ATA_BASE_SHT(drv_name), ^
drivers/ata/ahci.h:383:2: note: in expansion of macro 'ATA_NCQ_SHT'
ATA_NCQ_SHT(drv_name), ^
drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro 'AHCI_SHT'
AHCI_SHT(DRV_NAME),
^
vim +/__ATA_BASE_SHT +1366 include/linux/libata.h
1338
1339 /*
1340 * All sht initializers (BASE, PIO, BMDMA, NCQ) must be instantiated
1341 * by the edge drivers. Because the 'module' field of sht must be the
1342 * edge driver's module reference, otherwise the driver can be unloaded
1343 * even if the scsi_device is being accessed.
1344 */
1345 #define __ATA_BASE_SHT(drv_name) \
> 1346 .module = THIS_MODULE, \
1347 .name = drv_name, \
1348 .ioctl = ata_scsi_ioctl, \
1349 ATA_SCSI_COMPAT_IOCTL \
1350 .queuecommand = ata_scsi_queuecmd, \
1351 .can_queue = ATA_DEF_QUEUE, \
1352 .tag_alloc_policy = BLK_TAG_ALLOC_RR, \
1353 .this_id = ATA_SHT_THIS_ID, \
1354 .emulated = ATA_SHT_EMULATED, \
1355 .proc_name = drv_name, \
1356 .slave_configure = ata_scsi_slave_config, \
1357 .slave_destroy = ata_scsi_slave_destroy, \
1358 .bios_param = ata_std_bios_param, \
1359 .unlock_native_capacity = ata_scsi_unlock_native_capacity
1360
1361 #define ATA_BASE_SHT(drv_name) \
1362 __ATA_BASE_SHT(drv_name), \
1363 .sdev_attrs = ata_common_sdev_attrs
1364
1365 #define ATA_NCQ_SHT(drv_name) \
> 1366 __ATA_BASE_SHT(drv_name), \
1367 .sdev_attrs = ata_ncq_sdev_attrs, \
1368 .change_queue_depth = ata_scsi_change_queue_depth
1369
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[kbuild] drivers/soc/ti/k3-ringacc.c:562 k3_ringacc_ring_cfg() warn: variable dereferenced before check 'ring' (see line 559)
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b791d1bdf9212d944d749a5c7ff6febdba241771
commit: 3277e8aa2504d97e022ecb9777d784ac1a439d36 soc: ti: k3: add navss ringacc driver
config: arm64-randconfig-m031-20200612 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/soc/ti/k3-ringacc.c:562 k3_ringacc_ring_cfg() warn: variable dereferenced before check 'ring' (see line 559)
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 3277e8aa2504d97e022ecb9777d784ac1a439d36
vim +/ring +562 drivers/soc/ti/k3-ringacc.c
3277e8aa2504d97 Grygorii Strashko 2020-01-15 557 int k3_ringacc_ring_cfg(struct k3_ring *ring, struct k3_ring_cfg *cfg)
3277e8aa2504d97 Grygorii Strashko 2020-01-15 558 {
3277e8aa2504d97 Grygorii Strashko 2020-01-15 @559 struct k3_ringacc *ringacc = ring->parent;
^^^^^^^^^^^^
Dereference.
3277e8aa2504d97 Grygorii Strashko 2020-01-15 560 int ret = 0;
3277e8aa2504d97 Grygorii Strashko 2020-01-15 561
3277e8aa2504d97 Grygorii Strashko 2020-01-15 @562 if (!ring || !cfg)
^^^^
Check too late. Delete it?
3277e8aa2504d97 Grygorii Strashko 2020-01-15 563 return -EINVAL;
3277e8aa2504d97 Grygorii Strashko 2020-01-15 564 if (cfg->elm_size > K3_RINGACC_RING_ELSIZE_256 ||
3277e8aa2504d97 Grygorii Strashko 2020-01-15 565 cfg->mode >= K3_RINGACC_RING_MODE_INVALID ||
3277e8aa2504d97 Grygorii Strashko 2020-01-15 566 cfg->size & ~K3_RINGACC_CFG_RING_SIZE_ELCNT_MASK ||
3277e8aa2504d97 Grygorii Strashko 2020-01-15 567 !test_bit(ring->ring_id, ringacc->rings_inuse))
3277e8aa2504d97 Grygorii Strashko 2020-01-15 568 return -EINVAL;
3277e8aa2504d97 Grygorii Strashko 2020-01-15 569
3277e8aa2504d97 Grygorii Strashko 2020-01-15 570 if (cfg->mode == K3_RINGACC_RING_MODE_MESSAGE &&
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
2 years, 3 months
Re: [PATCH] arm64: smp call when task currently running on other cpu
by kernel test robot
Hi Wang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20200611]
[cannot apply to arm64/for-next/core arm-perf/for-next/perf soc/for-next arm/for-next xlnx/master kvmarm/next v5.7 v5.7-rc7 v5.7-rc6 v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Wang-Qing/arm64-smp-call-when-ta...
base: 192e08e14e37b78e83cc2f5b9eb5a15a7d71c4e2
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
arch/arm64/kernel/traps.c: In function 'dump_backtrace':
>> arch/arm64/kernel/traps.c:119:38: error: 'dump_backtrace_fun' undeclared (first use in this function); did you mean 'dump_backtrace_smp_fun'?
119 | smp_call_function_single(tsk->cpu, dump_backtrace_fun, tsk, 0);
| ^~~~~~~~~~~~~~~~~~
| dump_backtrace_smp_fun
arch/arm64/kernel/traps.c:119:38: note: each undeclared identifier is reported only once for each function it appears in
arch/arm64/kernel/traps.c: At top level:
arch/arm64/kernel/traps.c:768:26: warning: initialized field overwritten [-Woverride-init]
768 | [ESR_ELx_EC_UNKNOWN] = "Unknown/Uncategorized",
| ^~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:768:26: note: (near initialization for 'esr_class_str[0]')
arch/arm64/kernel/traps.c:769:22: warning: initialized field overwritten [-Woverride-init]
769 | [ESR_ELx_EC_WFx] = "WFI/WFE",
| ^~~~~~~~~
arch/arm64/kernel/traps.c:769:22: note: (near initialization for 'esr_class_str[1]')
arch/arm64/kernel/traps.c:770:26: warning: initialized field overwritten [-Woverride-init]
770 | [ESR_ELx_EC_CP15_32] = "CP15 MCR/MRC",
| ^~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:770:26: note: (near initialization for 'esr_class_str[3]')
arch/arm64/kernel/traps.c:771:26: warning: initialized field overwritten [-Woverride-init]
771 | [ESR_ELx_EC_CP15_64] = "CP15 MCRR/MRRC",
| ^~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:771:26: note: (near initialization for 'esr_class_str[4]')
arch/arm64/kernel/traps.c:772:26: warning: initialized field overwritten [-Woverride-init]
772 | [ESR_ELx_EC_CP14_MR] = "CP14 MCR/MRC",
| ^~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:772:26: note: (near initialization for 'esr_class_str[5]')
arch/arm64/kernel/traps.c:773:26: warning: initialized field overwritten [-Woverride-init]
773 | [ESR_ELx_EC_CP14_LS] = "CP14 LDC/STC",
| ^~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:773:26: note: (near initialization for 'esr_class_str[6]')
arch/arm64/kernel/traps.c:774:27: warning: initialized field overwritten [-Woverride-init]
774 | [ESR_ELx_EC_FP_ASIMD] = "ASIMD",
| ^~~~~~~
arch/arm64/kernel/traps.c:774:27: note: (near initialization for 'esr_class_str[7]')
arch/arm64/kernel/traps.c:775:26: warning: initialized field overwritten [-Woverride-init]
775 | [ESR_ELx_EC_CP10_ID] = "CP10 MRC/VMRS",
| ^~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:775:26: note: (near initialization for 'esr_class_str[8]')
arch/arm64/kernel/traps.c:776:22: warning: initialized field overwritten [-Woverride-init]
776 | [ESR_ELx_EC_PAC] = "PAC",
| ^~~~~
arch/arm64/kernel/traps.c:776:22: note: (near initialization for 'esr_class_str[9]')
arch/arm64/kernel/traps.c:777:26: warning: initialized field overwritten [-Woverride-init]
777 | [ESR_ELx_EC_CP14_64] = "CP14 MCRR/MRRC",
| ^~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:777:26: note: (near initialization for 'esr_class_str[12]')
arch/arm64/kernel/traps.c:778:22: warning: initialized field overwritten [-Woverride-init]
778 | [ESR_ELx_EC_BTI] = "BTI",
| ^~~~~
arch/arm64/kernel/traps.c:778:22: note: (near initialization for 'esr_class_str[13]')
arch/arm64/kernel/traps.c:779:22: warning: initialized field overwritten [-Woverride-init]
779 | [ESR_ELx_EC_ILL] = "PSTATE.IL",
| ^~~~~~~~~~~
arch/arm64/kernel/traps.c:779:22: note: (near initialization for 'esr_class_str[14]')
arch/arm64/kernel/traps.c:780:24: warning: initialized field overwritten [-Woverride-init]
780 | [ESR_ELx_EC_SVC32] = "SVC (AArch32)",
| ^~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:780:24: note: (near initialization for 'esr_class_str[17]')
arch/arm64/kernel/traps.c:781:24: warning: initialized field overwritten [-Woverride-init]
781 | [ESR_ELx_EC_HVC32] = "HVC (AArch32)",
| ^~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:781:24: note: (near initialization for 'esr_class_str[18]')
arch/arm64/kernel/traps.c:782:24: warning: initialized field overwritten [-Woverride-init]
782 | [ESR_ELx_EC_SMC32] = "SMC (AArch32)",
| ^~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:782:24: note: (near initialization for 'esr_class_str[19]')
arch/arm64/kernel/traps.c:783:24: warning: initialized field overwritten [-Woverride-init]
783 | [ESR_ELx_EC_SVC64] = "SVC (AArch64)",
| ^~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:783:24: note: (near initialization for 'esr_class_str[21]')
arch/arm64/kernel/traps.c:784:24: warning: initialized field overwritten [-Woverride-init]
784 | [ESR_ELx_EC_HVC64] = "HVC (AArch64)",
| ^~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:784:24: note: (near initialization for 'esr_class_str[22]')
arch/arm64/kernel/traps.c:785:24: warning: initialized field overwritten [-Woverride-init]
785 | [ESR_ELx_EC_SMC64] = "SMC (AArch64)",
| ^~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:785:24: note: (near initialization for 'esr_class_str[23]')
arch/arm64/kernel/traps.c:786:24: warning: initialized field overwritten [-Woverride-init]
786 | [ESR_ELx_EC_SYS64] = "MSR/MRS (AArch64)",
| ^~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:786:24: note: (near initialization for 'esr_class_str[24]')
arch/arm64/kernel/traps.c:787:22: warning: initialized field overwritten [-Woverride-init]
787 | [ESR_ELx_EC_SVE] = "SVE",
| ^~~~~
arch/arm64/kernel/traps.c:787:22: note: (near initialization for 'esr_class_str[25]')
arch/arm64/kernel/traps.c:788:23: warning: initialized field overwritten [-Woverride-init]
788 | [ESR_ELx_EC_ERET] = "ERET/ERETAA/ERETAB",
| ^~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:788:23: note: (near initialization for 'esr_class_str[26]')
arch/arm64/kernel/traps.c:789:26: warning: initialized field overwritten [-Woverride-init]
789 | [ESR_ELx_EC_IMP_DEF] = "EL3 IMP DEF",
| ^~~~~~~~~~~~~
arch/arm64/kernel/traps.c:789:26: note: (near initialization for 'esr_class_str[31]')
arch/arm64/kernel/traps.c:790:27: warning: initialized field overwritten [-Woverride-init]
790 | [ESR_ELx_EC_IABT_LOW] = "IABT (lower EL)",
| ^~~~~~~~~~~~~~~~~
arch/arm64/kernel/traps.c:790:27: note: (near initialization for 'esr_class_str[32]')
arch/arm64/kernel/traps.c:791:27: warning: initialized field overwritten [-Woverride-init]
791 | [ESR_ELx_EC_IABT_CUR] = "IABT (current EL)",
| ^~~~~~~~~~~~~~~~~~~
vim +119 arch/arm64/kernel/traps.c
90
91 void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk,
92 const char *loglvl)
93 {
94 struct stackframe frame;
95 int skip = 0;
96
97 pr_debug("%s(regs = %p tsk = %p)\n", __func__, regs, tsk);
98
99 if (regs) {
100 if (user_mode(regs))
101 return;
102 skip = 1;
103 }
104
105 if (!tsk)
106 tsk = current;
107
108 if (!try_get_task_stack(tsk))
109 return;
110
111 if (tsk == current) {
112 start_backtrace(&frame,
113 (unsigned long)__builtin_frame_address(0),
114 (unsigned long)dump_backtrace);
115 } else if (task_curr(tsk)) {
116 /*
117 * The task is currently running on other cpu
118 */
> 119 smp_call_function_single(tsk->cpu, dump_backtrace_fun, tsk, 0);
120 return;
121 } else {
122 /*
123 * task blocked in __switch_to
124 */
125 start_backtrace(&frame,
126 thread_saved_fp(tsk),
127 thread_saved_pc(tsk));
128 }
129
130 printk("%sCall trace:\n", loglvl);
131 do {
132 /* skip until specified stack frame */
133 if (!skip) {
134 dump_backtrace_entry(frame.pc, loglvl);
135 } else if (frame.fp == regs->regs[29]) {
136 skip = 0;
137 /*
138 * Mostly, this is the case where this function is
139 * called in panic/abort. As exception handler's
140 * stack frame does not contain the corresponding pc
141 * at which an exception has taken place, use regs->pc
142 * instead.
143 */
144 dump_backtrace_entry(regs->pc, loglvl);
145 }
146 } while (!unwind_frame(tsk, &frame));
147
148 put_task_stack(tsk);
149 }
150
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[stable:linux-5.4.y 953/5583] atmel-aes.c:undefined reference to `atmel_sha_authenc_get_reqsize'
by kernel test robot
Hi Greg,
It's probably a bug fix that unveils the link errors.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.4.y
head: 5e3c511539228fa03c8d00d61b5b5f32333ed0b0
commit: ffe485232df06b3cbb933d02aeb8965fd1ddca61 [953/5583] Revert "MIPS: futex: Emit Loongson3 sync workarounds within asm"
config: mips-randconfig-c024-20200612 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_authenc_init_tfm':
>> atmel-aes.c:(.text+0x7a8): undefined reference to `atmel_sha_authenc_get_reqsize'
>> mipsel-linux-ld: atmel-aes.c:(.text+0x7b4): undefined reference to `atmel_sha_authenc_spawn'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_authenc_start':
>> atmel-aes.c:(.text+0x868): undefined reference to `atmel_sha_authenc_schedule'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_authenc_digest':
>> atmel-aes.c:(.text+0x8a0): undefined reference to `atmel_sha_authenc_final'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_authenc_exit_tfm':
>> atmel-aes.c:(.text+0x8b4): undefined reference to `atmel_sha_authenc_free'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_authenc_setkey':
>> atmel-aes.c:(.text+0x904): undefined reference to `atmel_sha_authenc_setkey'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_probe':
>> atmel-aes.c:(.text+0x1394): undefined reference to `atmel_sha_authenc_is_ready'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_authenc_final':
>> atmel-aes.c:(.text+0x1cf8): undefined reference to `atmel_sha_authenc_abort'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_dma_start':
atmel-aes.c:(.text+0x2140): undefined reference to `atmel_sha_authenc_abort'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_gcm_finalize':
atmel-aes.c:(.text+0x2390): undefined reference to `atmel_sha_authenc_abort'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_authenc_init':
atmel-aes.c:(.text+0x26f0): undefined reference to `atmel_sha_authenc_abort'
>> mipsel-linux-ld: atmel-aes.c:(.text+0x27c8): undefined reference to `atmel_sha_authenc_init'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_authenc_transfer':
atmel-aes.c:(.text+0x2840): undefined reference to `atmel_sha_authenc_abort'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_cpu_transfer':
atmel-aes.c:(.text+0x2ad0): undefined reference to `atmel_sha_authenc_abort'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_gcm_length':
atmel-aes.c:(.text+0x353c): undefined reference to `atmel_sha_authenc_abort'
mipsel-linux-ld: drivers/crypto/atmel-aes.o: in function `atmel_aes_gcm_start':
atmel-aes.c:(.text+0x380c): undefined reference to `atmel_sha_authenc_abort'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
drivers/soc/fsl/dpio/qbman-portal.c:661:11: warning: variable 'addr_cena' set but not used
by kernel test robot
Hi Youri,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b791d1bdf9212d944d749a5c7ff6febdba241771
commit: 3b2abda7d28c69f564c1157b9b9c21ef40092ee9 soc: fsl: dpio: Replace QMAN array mode with ring mode enqueue
date: 4 months ago
config: i386-randconfig-r011-20200612 (attached as .config)
compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
reproduce (this is a W=1 build):
git checkout 3b2abda7d28c69f564c1157b9b9c21ef40092ee9
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/soc/fsl/dpio/qbman-portal.c: In function 'qbman_swp_enqueue_multiple_direct':
>> drivers/soc/fsl/dpio/qbman-portal.c:661:11: warning: variable 'addr_cena' set but not used [-Wunused-but-set-variable]
uint64_t addr_cena;
^
drivers/soc/fsl/dpio/qbman-portal.c: In function 'qbman_swp_enqueue_multiple_desc_direct':
drivers/soc/fsl/dpio/qbman-portal.c:869:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
addr_cena = (uint64_t)s->addr_cena;
^
drivers/soc/fsl/dpio/qbman-portal.c:825:11: warning: variable 'addr_cena' set but not used [-Wunused-but-set-variable]
uint64_t addr_cena;
^
vim +/addr_cena +661 drivers/soc/fsl/dpio/qbman-portal.c
638
639 /**
640 * qbman_swp_enqueue_multiple_direct() - Issue a multi enqueue command
641 * using one enqueue descriptor
642 * @s: the software portal used for enqueue
643 * @d: the enqueue descriptor
644 * @fd: table pointer of frame descriptor table to be enqueued
645 * @flags: table pointer of QBMAN_ENQUEUE_FLAG_DCA flags, not used if NULL
646 * @num_frames: number of fd to be enqueued
647 *
648 * Return the number of fd enqueued, or a negative error number.
649 */
650 static
651 int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s,
652 const struct qbman_eq_desc *d,
653 const struct dpaa2_fd *fd,
654 uint32_t *flags,
655 int num_frames)
656 {
657 uint32_t *p = NULL;
658 const uint32_t *cl = (uint32_t *)d;
659 uint32_t eqcr_ci, eqcr_pi, half_mask, full_mask;
660 int i, num_enqueued = 0;
> 661 uint64_t addr_cena;
662
663 spin_lock(&s->access_spinlock);
664 half_mask = (s->eqcr.pi_ci_mask>>1);
665 full_mask = s->eqcr.pi_ci_mask;
666
667 if (!s->eqcr.available) {
668 eqcr_ci = s->eqcr.ci;
669 p = s->addr_cena + QBMAN_CENA_SWP_EQCR_CI;
670 s->eqcr.ci = qbman_read_register(s, QBMAN_CINH_SWP_EQCR_CI);
671
672 s->eqcr.available = qm_cyc_diff(s->eqcr.pi_ring_size,
673 eqcr_ci, s->eqcr.ci);
674 if (!s->eqcr.available) {
675 spin_unlock(&s->access_spinlock);
676 return 0;
677 }
678 }
679
680 eqcr_pi = s->eqcr.pi;
681 num_enqueued = (s->eqcr.available < num_frames) ?
682 s->eqcr.available : num_frames;
683 s->eqcr.available -= num_enqueued;
684 /* Fill in the EQCR ring */
685 for (i = 0; i < num_enqueued; i++) {
686 p = (s->addr_cena + QBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask));
687 /* Skip copying the verb */
688 memcpy(&p[1], &cl[1], EQ_DESC_SIZE_WITHOUT_FD - 1);
689 memcpy(&p[EQ_DESC_SIZE_FD_START/sizeof(uint32_t)],
690 &fd[i], sizeof(*fd));
691 eqcr_pi++;
692 }
693
694 dma_wmb();
695
696 /* Set the verb byte, have to substitute in the valid-bit */
697 eqcr_pi = s->eqcr.pi;
698 for (i = 0; i < num_enqueued; i++) {
699 p = (s->addr_cena + QBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask));
700 p[0] = cl[0] | s->eqcr.pi_vb;
701 if (flags && (flags[i] & QBMAN_ENQUEUE_FLAG_DCA)) {
702 struct qbman_eq_desc *d = (struct qbman_eq_desc *)p;
703
704 d->dca = (1 << QB_ENQUEUE_CMD_DCA_EN_SHIFT) |
705 ((flags[i]) & QBMAN_EQCR_DCA_IDXMASK);
706 }
707 eqcr_pi++;
708 if (!(eqcr_pi & half_mask))
709 s->eqcr.pi_vb ^= QB_VALID_BIT;
710 }
711
712 /* Flush all the cacheline without load/store in between */
713 eqcr_pi = s->eqcr.pi;
714 addr_cena = (size_t)s->addr_cena;
715 for (i = 0; i < num_enqueued; i++)
716 eqcr_pi++;
717 s->eqcr.pi = eqcr_pi & full_mask;
718 spin_unlock(&s->access_spinlock);
719
720 return num_enqueued;
721 }
722
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [PATCH 4/4] Bluetooth: btintel: Add helper function to help controller type
by kernel test robot
Hi Kiran,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on next-20200611]
[cannot apply to bluetooth/master v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Kiran-K/Add-support-for-new-gene...
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: nds32-randconfig-r014-20200612 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from ./arch/nds32/include/generated/asm/bug.h:1,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/nds32/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/stat.h:19,
from include/linux/module.h:13,
from drivers/bluetooth/btintel.c:9:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/nds32/include/asm/memory.h:82:32: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
82 | #define pfn_valid(pfn) ((pfn) >= PHYS_PFN_OFFSET && (pfn) < (PHYS_PFN_OFFSET + max_mapnr))
| ^~
include/asm-generic/bug.h:139:27: note: in definition of macro 'WARN_ON_ONCE'
139 | int __ret_warn_once = !!(condition); | ^~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
drivers/bluetooth/btintel.c: At top level:
drivers/bluetooth/btintel.c:229:6: warning: no previous prototype for 'btintel_boot_info' [-Wmissing-prototypes]
229 | void btintel_boot_info(struct hci_dev *hdev,
| ^~~~~~~~~~~~~~~~~
drivers/bluetooth/btintel.c:252:6: warning: no previous prototype for 'btintel_boot_info_tlv' [-Wmissing-prototypes]
252 | void btintel_boot_info_tlv(struct hci_dev *hdev,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btintel.c:385:6: warning: no previous prototype for 'btintel_get_fw_name' [-Wmissing-prototypes]
385 | bool btintel_get_fw_name(struct intel_version *ver,
| ^~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btintel.c:439:6: warning: no previous prototype for 'btintel_get_fw_name_tlv' [-Wmissing-prototypes]
439 | void btintel_get_fw_name_tlv(struct intel_version_tlv *ver,
| ^~~~~~~~~~~~~~~~~~~~~~~
<< from drivers/bluetooth/btintel.c:9:
>> drivers/bluetooth/btintel.c:485:5: warning: no previous prototype for 'btintel_read_version_tlv' [-Wmissing-prototypes]
485 | int btintel_read_version_tlv(struct hci_dev *hdev, bool *is_tlv_format,
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/btintel_read_version_tlv +485 drivers/bluetooth/btintel.c
484
> 485 int btintel_read_version_tlv(struct hci_dev *hdev, bool *is_tlv_format,
486 struct sk_buff **skb_out)
487 {
488 u8 param;
489 u8 status;
490 u8 tlv_check_octet;
491 u8 *data;
492 struct sk_buff *skb;
493
494 param = 0xFF;
495 skb_out = NULL;
496
497 skb = __hci_cmd_sync(hdev, 0xfc05, 1, ¶m, HCI_CMD_TIMEOUT);
498 if (IS_ERR(skb)) {
499 bt_dev_err(hdev, "Intel read version command failed (%ld)",
500 PTR_ERR(skb));
501 return PTR_ERR(skb);
502 }
503
504 /* Check status */
505 data = skb->data;
506 status = *data;
507 if (status) {
508 bt_dev_err(hdev, "Intel Read Version failed (%02x)",
509 status);
510 kfree_skb(skb);
511 return -bt_to_errno(status);
512 }
513
514 /* There are two variants of HCI_Intel_Read_Version_Command_Complete
515 * depending on SKU type (legacy and TLV format).If the skb->len
516 * parameter is equal to INTEL_VERSION_LEN and the first octet
517 * after the status parameter is 0x37 then it's the legacy format,
518 * otherwise it's TLV format
519 */
520
521 /* Fetch the octet after status */
522 tlv_check_octet = *(data + 1);
523
524 if (skb->len == INTEL_VERSION_LEN && tlv_check_octet == 0x37) {
525 bt_dev_dbg(hdev, "Using Legacy Intel Version command");
526 *is_tlv_format = false;
527 } else {
528 bt_dev_dbg(hdev, "Using TLV format Version command");
529 *is_tlv_format = true;
530 }
531 *skb_out = skb;
532 return 0;
533 }
534 EXPORT_SYMBOL_GPL(btintel_read_version_tlv);
535
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
drivers/media/platform/atmel/atmel-sama5d2-isc.c:323:34: warning: unused variable 'atmel_isc_of_match'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b791d1bdf9212d944d749a5c7ff6febdba241771
commit: 0a0e265515db7619d0da9331d74245d02c741f07 media: atmel: atmel-isc: split driver into driver base and isc
date: 12 months ago
config: x86_64-randconfig-a012-20200612 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3b43f006294971b8049d4807110032169780e5b8)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 0a0e265515db7619d0da9331d74245d02c741f07
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/media/platform/atmel/atmel-sama5d2-isc.c:323:34: warning: unused variable 'atmel_isc_of_match' [-Wunused-const-variable]
static const struct of_device_id atmel_isc_of_match[] = {
^
1 warning generated.
vim +/atmel_isc_of_match +323 drivers/media/platform/atmel/atmel-sama5d2-isc.c
322
> 323 static const struct of_device_id atmel_isc_of_match[] = {
324 { .compatible = "atmel,sama5d2-isc" },
325 { }
326 };
327 MODULE_DEVICE_TABLE(of, atmel_isc_of_match);
328
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [PATCH v3 4/7] Bluetooth: Add handler of MGMT_OP_REMOVE_ADV_MONITOR
by kernel test robot
Hi Miao-chen,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on net-next/master sparc-next/master net/master next-20200611]
[cannot apply to bluetooth/master v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Miao-chen-Chou/Bluetooth-Add-def...
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: m68k-randconfig-s031-20200612 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-250-g42323db3-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=m68k CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
net/bluetooth/mgmt.c:3599:29: sparse: sparse: restricted __le16 degrades to integer
>> net/bluetooth/mgmt.c:4009:46: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned short [usertype] handle @@ got restricted __le16 [usertype] monitor_handle @@
>> net/bluetooth/mgmt.c:4009:46: sparse: expected unsigned short [usertype] handle
>> net/bluetooth/mgmt.c:4009:46: sparse: got restricted __le16 [usertype] monitor_handle
>> net/bluetooth/mgmt.c:4018:29: sparse: sparse: cast from restricted __le16
>> net/bluetooth/mgmt.c:4018:29: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned short [usertype] val @@ got restricted __le16 [usertype] monitor_handle @@
>> net/bluetooth/mgmt.c:4018:29: sparse: expected unsigned short [usertype] val
net/bluetooth/mgmt.c:4018:29: sparse: got restricted __le16 [usertype] monitor_handle
>> net/bluetooth/mgmt.c:4018:29: sparse: sparse: cast from restricted __le16
>> net/bluetooth/mgmt.c:4018:29: sparse: sparse: cast from restricted __le16
vim +4009 net/bluetooth/mgmt.c
3997
3998 static int remove_adv_monitor(struct sock *sk, struct hci_dev *hdev,
3999 void *data, u16 len)
4000 {
4001 struct mgmt_cp_remove_adv_monitor *cp = data;
4002 struct mgmt_rp_remove_adv_monitor rp;
4003 int err;
4004
4005 BT_DBG("request for %s", hdev->name);
4006
4007 hci_dev_lock(hdev);
4008
> 4009 err = hci_remove_adv_monitor(hdev, cp->monitor_handle);
4010 if (err == -ENOENT) {
4011 err = mgmt_cmd_status(sk, hdev->id, MGMT_OP_REMOVE_ADV_MONITOR,
4012 MGMT_STATUS_INVALID_INDEX);
4013 goto unlock;
4014 }
4015
4016 hci_dev_unlock(hdev);
4017
> 4018 rp.monitor_handle = cpu_to_le16(cp->monitor_handle);
4019
4020 return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_REMOVE_ADV_MONITOR,
4021 MGMT_STATUS_SUCCESS, &rp, sizeof(rp));
4022
4023 unlock:
4024 hci_dev_unlock(hdev);
4025 return err;
4026 }
4027
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[sashal-linux-stable:queue-5.4 18/32] h8300-linux-ld: imx8.c:undefined reference to `imx_sc_misc_set_control'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-5.4
head: c0bc3e8f3559cf70743526c4064179946b54438a
commit: 94ee421f03f02b57be81ab8bf490957c06ede44d [18/32] ASoC: SOF: imx: fix undefined reference issue
config: h8300-allyesconfig (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 94ee421f03f02b57be81ab8bf490957c06ede44d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
h8300-linux-ld: sound/soc/sof/imx/imx8.o: in function `imx8_run':
imx8.c:(.text+0x24f): undefined reference to `imx_sc_misc_set_control'
>> h8300-linux-ld: imx8.c:(.text+0x27b): undefined reference to `imx_sc_misc_set_control'
h8300-linux-ld: imx8.c:(.text+0x2c9): undefined reference to `imx_sc_misc_set_control'
h8300-linux-ld: imx8.c:(.text+0x31b): undefined reference to `imx_sc_misc_set_control'
>> h8300-linux-ld: imx8.c:(.text+0x357): undefined reference to `imx_sc_pm_cpu_start'
h8300-linux-ld: sound/soc/sof/imx/imx8.o: in function `.L49':
imx8.c:(.text+0x5bb): undefined reference to `imx_scu_get_handle'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[kbuild] drivers/s390/crypto/zcrypt_cex4.c:251 ep11_card_op_modes_show() warn: should '(1 << be a 64 bit
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b29482fde649c72441d5478a4ea2c52c56d97a5e
commit: a17becc112535b912f2165f80a98c21b59655119 s390/zcrypt: extend EP11 card and queue sysfs attributes
config: s390-randconfig-m031-20200611 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/s390/crypto/zcrypt_cex4.c:251 ep11_card_op_modes_show() warn: should '(1 << ep11_op_modes[i]->mode_bit)' be a 64 bit type?
drivers/s390/crypto/zcrypt_cex4.c:346 ep11_queue_op_modes_show() warn: should '(1 << ep11_op_modes[i]->mode_bit)' be a 64 bit type?
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout a17becc112535b912f2165f80a98c21b59655119
vim +251 drivers/s390/crypto/zcrypt_cex4.c
a17becc112535b Harald Freudenberger 2019-08-30 237 static ssize_t ep11_card_op_modes_show(struct device *dev,
a17becc112535b Harald Freudenberger 2019-08-30 238 struct device_attribute *attr,
a17becc112535b Harald Freudenberger 2019-08-30 239 char *buf)
a17becc112535b Harald Freudenberger 2019-08-30 240 {
a17becc112535b Harald Freudenberger 2019-08-30 241 int i, n = 0;
a17becc112535b Harald Freudenberger 2019-08-30 242 struct ep11_card_info ci;
a17becc112535b Harald Freudenberger 2019-08-30 243 struct ap_card *ac = to_ap_card(dev);
a17becc112535b Harald Freudenberger 2019-08-30 244 struct zcrypt_card *zc = ac->private;
a17becc112535b Harald Freudenberger 2019-08-30 245
a17becc112535b Harald Freudenberger 2019-08-30 246 memset(&ci, 0, sizeof(ci));
a17becc112535b Harald Freudenberger 2019-08-30 247
a17becc112535b Harald Freudenberger 2019-08-30 248 ep11_get_card_info(ac->id, &ci, zc->online);
a17becc112535b Harald Freudenberger 2019-08-30 249
a17becc112535b Harald Freudenberger 2019-08-30 250 for (i = 0; ep11_op_modes[i].mode_txt; i++) {
a17becc112535b Harald Freudenberger 2019-08-30 @251 if (ci.op_mode & (1 << ep11_op_modes[i].mode_bit)) {
^^^^^^^^^^
This is a u64 type, which suggests that it should be "1ULL << ep11_op_modes[i].mode_bit".
a17becc112535b Harald Freudenberger 2019-08-30 252 if (n > 0)
a17becc112535b Harald Freudenberger 2019-08-30 253 buf[n++] = ' ';
a17becc112535b Harald Freudenberger 2019-08-30 254 n += snprintf(buf + n, PAGE_SIZE - n,
a17becc112535b Harald Freudenberger 2019-08-30 255 "%s", ep11_op_modes[i].mode_txt);
a17becc112535b Harald Freudenberger 2019-08-30 256 }
a17becc112535b Harald Freudenberger 2019-08-30 257 }
a17becc112535b Harald Freudenberger 2019-08-30 258 n += snprintf(buf + n, PAGE_SIZE - n, "\n");
a17becc112535b Harald Freudenberger 2019-08-30 259
a17becc112535b Harald Freudenberger 2019-08-30 260 return n;
a17becc112535b Harald Freudenberger 2019-08-30 261 }
a17becc112535b Harald Freudenberger 2019-08-30 262
a17becc112535b Harald Freudenberger 2019-08-30 263 static struct device_attribute dev_attr_ep11_card_op_modes =
a17becc112535b Harald Freudenberger 2019-08-30 264 __ATTR(op_modes, 0444, ep11_card_op_modes_show, NULL);
a17becc112535b Harald Freudenberger 2019-08-30 265
a17becc112535b Harald Freudenberger 2019-08-30 266 static struct attribute *ep11_card_attrs[] = {
a17becc112535b Harald Freudenberger 2019-08-30 267 &dev_attr_ep11_api_ordinalnr.attr,
a17becc112535b Harald Freudenberger 2019-08-30 268 &dev_attr_ep11_fw_version.attr,
a17becc112535b Harald Freudenberger 2019-08-30 269 &dev_attr_ep11_serialnr.attr,
a17becc112535b Harald Freudenberger 2019-08-30 270 &dev_attr_ep11_card_op_modes.attr,
a17becc112535b Harald Freudenberger 2019-08-30 271 NULL,
a17becc112535b Harald Freudenberger 2019-08-30 272 };
a17becc112535b Harald Freudenberger 2019-08-30 273
a17becc112535b Harald Freudenberger 2019-08-30 274 static const struct attribute_group ep11_card_attr_grp = {
a17becc112535b Harald Freudenberger 2019-08-30 275 .attrs = ep11_card_attrs,
a17becc112535b Harald Freudenberger 2019-08-30 276 };
a17becc112535b Harald Freudenberger 2019-08-30 277
a17becc112535b Harald Freudenberger 2019-08-30 278 /*
a17becc112535b Harald Freudenberger 2019-08-30 279 * EP11 queue additional device attributes
a17becc112535b Harald Freudenberger 2019-08-30 280 */
a17becc112535b Harald Freudenberger 2019-08-30 281
a17becc112535b Harald Freudenberger 2019-08-30 282 static ssize_t ep11_mkvps_show(struct device *dev,
a17becc112535b Harald Freudenberger 2019-08-30 283 struct device_attribute *attr,
a17becc112535b Harald Freudenberger 2019-08-30 284 char *buf)
a17becc112535b Harald Freudenberger 2019-08-30 285 {
a17becc112535b Harald Freudenberger 2019-08-30 286 int n = 0;
a17becc112535b Harald Freudenberger 2019-08-30 287 struct ep11_domain_info di;
a17becc112535b Harald Freudenberger 2019-08-30 288 struct zcrypt_queue *zq = to_ap_queue(dev)->private;
a17becc112535b Harald Freudenberger 2019-08-30 289 static const char * const cwk_state[] = { "invalid", "valid" };
a17becc112535b Harald Freudenberger 2019-08-30 290 static const char * const nwk_state[] = { "empty", "uncommitted",
a17becc112535b Harald Freudenberger 2019-08-30 291 "committed" };
a17becc112535b Harald Freudenberger 2019-08-30 292
a17becc112535b Harald Freudenberger 2019-08-30 293 memset(&di, 0, sizeof(di));
a17becc112535b Harald Freudenberger 2019-08-30 294
a17becc112535b Harald Freudenberger 2019-08-30 295 if (zq->online)
a17becc112535b Harald Freudenberger 2019-08-30 296 ep11_get_domain_info(AP_QID_CARD(zq->queue->qid),
a17becc112535b Harald Freudenberger 2019-08-30 297 AP_QID_QUEUE(zq->queue->qid),
a17becc112535b Harald Freudenberger 2019-08-30 298 &di);
a17becc112535b Harald Freudenberger 2019-08-30 299
a17becc112535b Harald Freudenberger 2019-08-30 300 if (di.cur_wk_state == '0') {
a17becc112535b Harald Freudenberger 2019-08-30 301 n = snprintf(buf, PAGE_SIZE, "WK CUR: %s -\n",
a17becc112535b Harald Freudenberger 2019-08-30 302 cwk_state[di.cur_wk_state - '0']);
a17becc112535b Harald Freudenberger 2019-08-30 303 } else if (di.cur_wk_state == '1') {
a17becc112535b Harald Freudenberger 2019-08-30 304 n = snprintf(buf, PAGE_SIZE, "WK CUR: %s 0x",
a17becc112535b Harald Freudenberger 2019-08-30 305 cwk_state[di.cur_wk_state - '0']);
a17becc112535b Harald Freudenberger 2019-08-30 306 bin2hex(buf + n, di.cur_wkvp, sizeof(di.cur_wkvp));
a17becc112535b Harald Freudenberger 2019-08-30 307 n += 2 * sizeof(di.cur_wkvp);
a17becc112535b Harald Freudenberger 2019-08-30 308 n += snprintf(buf + n, PAGE_SIZE - n, "\n");
a17becc112535b Harald Freudenberger 2019-08-30 309 } else
a17becc112535b Harald Freudenberger 2019-08-30 310 n = snprintf(buf, PAGE_SIZE, "WK CUR: - -\n");
a17becc112535b Harald Freudenberger 2019-08-30 311
a17becc112535b Harald Freudenberger 2019-08-30 312 if (di.new_wk_state == '0') {
a17becc112535b Harald Freudenberger 2019-08-30 313 n += snprintf(buf + n, PAGE_SIZE - n, "WK NEW: %s -\n",
a17becc112535b Harald Freudenberger 2019-08-30 314 nwk_state[di.new_wk_state - '0']);
a17becc112535b Harald Freudenberger 2019-08-30 315 } else if (di.new_wk_state >= '1' && di.new_wk_state <= '2') {
a17becc112535b Harald Freudenberger 2019-08-30 316 n += snprintf(buf + n, PAGE_SIZE - n, "WK NEW: %s 0x",
a17becc112535b Harald Freudenberger 2019-08-30 317 nwk_state[di.new_wk_state - '0']);
a17becc112535b Harald Freudenberger 2019-08-30 318 bin2hex(buf + n, di.new_wkvp, sizeof(di.new_wkvp));
a17becc112535b Harald Freudenberger 2019-08-30 319 n += 2 * sizeof(di.new_wkvp);
a17becc112535b Harald Freudenberger 2019-08-30 320 n += snprintf(buf + n, PAGE_SIZE - n, "\n");
a17becc112535b Harald Freudenberger 2019-08-30 321 } else
a17becc112535b Harald Freudenberger 2019-08-30 322 n += snprintf(buf + n, PAGE_SIZE - n, "WK NEW: - -\n");
a17becc112535b Harald Freudenberger 2019-08-30 323
a17becc112535b Harald Freudenberger 2019-08-30 324 return n;
a17becc112535b Harald Freudenberger 2019-08-30 325 }
a17becc112535b Harald Freudenberger 2019-08-30 326
a17becc112535b Harald Freudenberger 2019-08-30 327 static struct device_attribute dev_attr_ep11_mkvps =
a17becc112535b Harald Freudenberger 2019-08-30 328 __ATTR(mkvps, 0444, ep11_mkvps_show, NULL);
a17becc112535b Harald Freudenberger 2019-08-30 329
a17becc112535b Harald Freudenberger 2019-08-30 330 static ssize_t ep11_queue_op_modes_show(struct device *dev,
a17becc112535b Harald Freudenberger 2019-08-30 331 struct device_attribute *attr,
a17becc112535b Harald Freudenberger 2019-08-30 332 char *buf)
a17becc112535b Harald Freudenberger 2019-08-30 333 {
a17becc112535b Harald Freudenberger 2019-08-30 334 int i, n = 0;
a17becc112535b Harald Freudenberger 2019-08-30 335 struct ep11_domain_info di;
a17becc112535b Harald Freudenberger 2019-08-30 336 struct zcrypt_queue *zq = to_ap_queue(dev)->private;
a17becc112535b Harald Freudenberger 2019-08-30 337
a17becc112535b Harald Freudenberger 2019-08-30 338 memset(&di, 0, sizeof(di));
a17becc112535b Harald Freudenberger 2019-08-30 339
a17becc112535b Harald Freudenberger 2019-08-30 340 if (zq->online)
a17becc112535b Harald Freudenberger 2019-08-30 341 ep11_get_domain_info(AP_QID_CARD(zq->queue->qid),
a17becc112535b Harald Freudenberger 2019-08-30 342 AP_QID_QUEUE(zq->queue->qid),
a17becc112535b Harald Freudenberger 2019-08-30 343 &di);
a17becc112535b Harald Freudenberger 2019-08-30 344
a17becc112535b Harald Freudenberger 2019-08-30 345 for (i = 0; ep11_op_modes[i].mode_txt; i++) {
a17becc112535b Harald Freudenberger 2019-08-30 @346 if (di.op_mode & (1 << ep11_op_modes[i].mode_bit)) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Same.
a17becc112535b Harald Freudenberger 2019-08-30 347 if (n > 0)
a17becc112535b Harald Freudenberger 2019-08-30 348 buf[n++] = ' ';
a17becc112535b Harald Freudenberger 2019-08-30 349 n += snprintf(buf + n, PAGE_SIZE - n,
a17becc112535b Harald Freudenberger 2019-08-30 350 "%s", ep11_op_modes[i].mode_txt);
a17becc112535b Harald Freudenberger 2019-08-30 351 }
a17becc112535b Harald Freudenberger 2019-08-30 352 }
a17becc112535b Harald Freudenberger 2019-08-30 353 n += snprintf(buf + n, PAGE_SIZE - n, "\n");
a17becc112535b Harald Freudenberger 2019-08-30 354
a17becc112535b Harald Freudenberger 2019-08-30 355 return n;
a17becc112535b Harald Freudenberger 2019-08-30 356 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
2 years, 3 months