[mcgrof:20200605-blktrace-fixes-v4 8/8] include/linux/compiler.h:302:44: error: initializer element is not constant
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git 20200605-blktrace-fixes-v4
head: 5198fc554bd362e6b4800af7fddd577e0558ed50
commit: 5198fc554bd362e6b4800af7fddd577e0558ed50 [8/8] blktrace: fix debugfs use after free
config: i386-randconfig-s002-20200608 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-247-gcadbd124-dirty
git checkout 5198fc554bd362e6b4800af7fddd577e0558ed50
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
1540 | [__BLK_TA_REQUEUE] = {{ "R", "requeue" }, blk_log_with_error },
| ^~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1540:48: note: (near initialization for 'what2act[6].print')
kernel/trace/blktrace.c:1541:44: error: initializer element is not constant
1541 | [__BLK_TA_ISSUE] = {{ "D", "issue" }, blk_log_generic },
| ^~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1541:44: note: (near initialization for 'what2act[7].print')
kernel/trace/blktrace.c:1542:49: error: initializer element is not constant
1542 | [__BLK_TA_COMPLETE] = {{ "C", "complete" }, blk_log_with_error },
| ^~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1542:49: note: (near initialization for 'what2act[8].print')
kernel/trace/blktrace.c:1543:43: error: initializer element is not constant
1543 | [__BLK_TA_PLUG] = {{ "P", "plug" }, blk_log_plug },
| ^~~~~~~~~~~~
kernel/trace/blktrace.c:1543:43: note: (near initialization for 'what2act[9].print')
kernel/trace/blktrace.c:1544:50: error: initializer element is not constant
1544 | [__BLK_TA_UNPLUG_IO] = {{ "U", "unplug_io" }, blk_log_unplug },
| ^~~~~~~~~~~~~~
kernel/trace/blktrace.c:1544:50: note: (near initialization for 'what2act[10].print')
kernel/trace/blktrace.c:1545:55: error: initializer element is not constant
1545 | [__BLK_TA_UNPLUG_TIMER] = {{ "UT", "unplug_timer" }, blk_log_unplug },
| ^~~~~~~~~~~~~~
kernel/trace/blktrace.c:1545:55: note: (near initialization for 'what2act[11].print')
kernel/trace/blktrace.c:1546:46: error: initializer element is not constant
1546 | [__BLK_TA_INSERT] = {{ "I", "insert" }, blk_log_generic },
| ^~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1546:46: note: (near initialization for 'what2act[12].print')
kernel/trace/blktrace.c:1547:44: error: initializer element is not constant
1547 | [__BLK_TA_SPLIT] = {{ "X", "split" }, blk_log_split },
| ^~~~~~~~~~~~~
kernel/trace/blktrace.c:1547:44: note: (near initialization for 'what2act[13].print')
kernel/trace/blktrace.c:1548:46: error: initializer element is not constant
1548 | [__BLK_TA_BOUNCE] = {{ "B", "bounce" }, blk_log_generic },
| ^~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1548:46: note: (near initialization for 'what2act[14].print')
kernel/trace/blktrace.c:1549:44: error: initializer element is not constant
1549 | [__BLK_TA_REMAP] = {{ "A", "remap" }, blk_log_remap },
| ^~~~~~~~~~~~~
kernel/trace/blktrace.c:1549:44: note: (near initialization for 'what2act[15].print')
kernel/trace/blktrace.c:1552:26: error: invalid storage class for function 'print_one_line'
1552 | static enum print_line_t print_one_line(struct trace_iterator *iter,
| ^~~~~~~~~~~~~~
kernel/trace/blktrace.c:1585:26: error: invalid storage class for function 'blk_trace_event_print'
1585 | static enum print_line_t blk_trace_event_print(struct trace_iterator *iter,
| ^~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1591:13: error: invalid storage class for function 'blk_trace_synthesize_old_trace'
1591 | static void blk_trace_synthesize_old_trace(struct trace_iterator *iter)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1607:1: error: invalid storage class for function 'blk_trace_event_print_binary'
1607 | blk_trace_event_print_binary(struct trace_iterator *iter, int flags,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1615:26: error: invalid storage class for function 'blk_tracer_print_line'
1615 | static enum print_line_t blk_tracer_print_line(struct trace_iterator *iter)
| ^~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1624:1: error: invalid storage class for function 'blk_tracer_set_flag'
1624 | blk_tracer_set_flag(struct trace_array *tr, u32 old_flags, u32 bit, int set)
| ^~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1638:11: error: initializer element is not constant
1638 | .init = blk_tracer_init,
| ^~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1638:11: note: (near initialization for 'blk_tracer.init')
kernel/trace/blktrace.c:1639:12: error: initializer element is not constant
1639 | .reset = blk_tracer_reset,
| ^~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1639:12: note: (near initialization for 'blk_tracer.reset')
kernel/trace/blktrace.c:1640:12: error: initializer element is not constant
1640 | .start = blk_tracer_start,
| ^~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1640:12: note: (near initialization for 'blk_tracer.start')
kernel/trace/blktrace.c:1641:11: error: initializer element is not constant
1641 | .stop = blk_tracer_stop,
| ^~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1641:11: note: (near initialization for 'blk_tracer.stop')
kernel/trace/blktrace.c:1642:18: error: initializer element is not constant
1642 | .print_header = blk_tracer_print_header,
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1642:18: note: (near initialization for 'blk_tracer.print_header')
kernel/trace/blktrace.c:1643:16: error: initializer element is not constant
1643 | .print_line = blk_tracer_print_line,
| ^~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1643:16: note: (near initialization for 'blk_tracer.print_line')
kernel/trace/blktrace.c:1645:14: error: initializer element is not constant
1645 | .set_flag = blk_tracer_set_flag,
| ^~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1645:14: note: (near initialization for 'blk_tracer.set_flag')
kernel/trace/blktrace.c:1649:12: error: initializer element is not constant
1649 | .trace = blk_trace_event_print,
| ^~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1649:12: note: (near initialization for 'trace_blk_event_funcs.trace')
kernel/trace/blktrace.c:1650:13: error: initializer element is not constant
1650 | .binary = blk_trace_event_print_binary,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1650:13: note: (near initialization for 'trace_blk_event_funcs.binary')
kernel/trace/blktrace.c:1658:19: error: invalid storage class for function 'init_blk_tracer'
1658 | static int __init init_blk_tracer(void)
| ^~~~~~~~~~~~~~~
In file included from include/linux/export.h:43,
from include/linux/linkage.h:7,
from include/linux/kernel.h:8,
from kernel/trace/blktrace.c:9:
>> include/linux/compiler.h:302:44: error: initializer element is not constant
302 | __PASTE(__addressable_##sym, __LINE__) = (void *)&sym;
| ^
include/linux/init.h:189:2: note: in expansion of macro '__ADDRESSABLE'
189 | __ADDRESSABLE(fn) | ^~~~~~~~~~~~~
include/linux/init.h:200:35: note: in expansion of macro '___define_initcall'
200 | #define __define_initcall(fn, id) ___define_initcall(fn, id, .initcall##id)
| ^~~~~~~~~~~~~~~~~~
include/linux/init.h:229:30: note: in expansion of macro '__define_initcall'
229 | #define device_initcall(fn) __define_initcall(fn, 6)
| ^~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1674:1: note: in expansion of macro 'device_initcall'
1674 | device_initcall(init_blk_tracer);
| ^~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1676:12: error: invalid storage class for function 'blk_trace_remove_queue'
1676 | static int blk_trace_remove_queue(struct request_queue *q)
| ^~~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1676:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
1676 | static int blk_trace_remove_queue(struct request_queue *q)
| ^~~~~~
kernel/trace/blktrace.c:1694:12: error: invalid storage class for function 'blk_trace_setup_queue'
1694 | static int blk_trace_setup_queue(struct request_queue *q,
| ^~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1726:16: error: invalid storage class for function 'sysfs_blk_trace_attr_show'
1726 | static ssize_t sysfs_blk_trace_attr_show(struct device *dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1729:16: error: invalid storage class for function 'sysfs_blk_trace_attr_store'
1729 | static ssize_t sysfs_blk_trace_attr_store(struct device *dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/kobject.h:20,
from include/linux/device.h:17,
from include/linux/genhd.h:36,
from include/linux/blkdev.h:11,
from kernel/trace/blktrace.c:10:
kernel/trace/blktrace.c:1734:7: error: 'sysfs_blk_trace_attr_show' undeclared (first use in this function)
1734 | sysfs_blk_trace_attr_show, | ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR'
104 | .show = _show, | ^~~~~
kernel/trace/blktrace.c:1733:2: note: in expansion of macro 'DEVICE_ATTR'
1733 | DEVICE_ATTR(_name, S_IRUGO | S_IWUSR, | ^~~~~~~~~~~
kernel/trace/blktrace.c:1737:8: note: in expansion of macro 'BLK_TRACE_DEVICE_ATTR'
1737 | static BLK_TRACE_DEVICE_ATTR(enable);
| ^~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1734:7: note: each undeclared identifier is reported only once for each function it appears in
1734 | sysfs_blk_trace_attr_show, | ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR'
104 | .show = _show, | ^~~~~
kernel/trace/blktrace.c:1733:2: note: in expansion of macro 'DEVICE_ATTR'
1733 | DEVICE_ATTR(_name, S_IRUGO | S_IWUSR, | ^~~~~~~~~~~
kernel/trace/blktrace.c:1737:8: note: in expansion of macro 'BLK_TRACE_DEVICE_ATTR'
1737 | static BLK_TRACE_DEVICE_ATTR(enable);
| ^~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1734:7: error: initialization of 'ssize_t (*)(struct device *, struct device_attribute *, char *)' {aka 'int (*)(struct device *, struct device_attribute *, char *)'} from incompatible pointer type 'const struct <anonymous> *' [-Werror=incompatible-pointer-types]
1734 | sysfs_blk_trace_attr_show, | ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR'
104 | .show = _show, | ^~~~~
kernel/trace/blktrace.c:1733:2: note: in expansion of macro 'DEVICE_ATTR'
1733 | DEVICE_ATTR(_name, S_IRUGO | S_IWUSR, | ^~~~~~~~~~~
kernel/trace/blktrace.c:1737:8: note: in expansion of macro 'BLK_TRACE_DEVICE_ATTR'
1737 | static BLK_TRACE_DEVICE_ATTR(enable);
| ^~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1734:7: note: (near initialization for 'dev_attr_enable.show')
1734 | sysfs_blk_trace_attr_show, | ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR'
104 | .show = _show, | ^~~~~
kernel/trace/blktrace.c:1733:2: note: in expansion of macro 'DEVICE_ATTR'
1733 | DEVICE_ATTR(_name, S_IRUGO | S_IWUSR, | ^~~~~~~~~~~
kernel/trace/blktrace.c:1737:8: note: in expansion of macro 'BLK_TRACE_DEVICE_ATTR'
1737 | static BLK_TRACE_DEVICE_ATTR(enable);
| ^~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1734:7: error: initializer element is not constant
1734 | sysfs_blk_trace_attr_show, | ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR'
104 | .show = _show, | ^~~~~
kernel/trace/blktrace.c:1733:2: note: in expansion of macro 'DEVICE_ATTR'
1733 | DEVICE_ATTR(_name, S_IRUGO | S_IWUSR, | ^~~~~~~~~~~
kernel/trace/blktrace.c:1737:8: note: in expansion of macro 'BLK_TRACE_DEVICE_ATTR'
1737 | static BLK_TRACE_DEVICE_ATTR(enable);
| ^~~~~~~~~~~~~~~~~~~~~
kernel/trace/blktrace.c:1734:7: note: (near initialization for 'dev_attr_enable.show')
1734 | sysfs_blk_trace_attr_show, | ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR'
104 | .show = _show, | ^~~~~
vim +302 include/linux/compiler.h
^1da177e4c3f41 Linus Torvalds 2005-04-16 293
7290d58095712a Ard Biesheuvel 2018-08-21 294 /*
7290d58095712a Ard Biesheuvel 2018-08-21 295 * Force the compiler to emit 'sym' as a symbol, so that we can reference
7290d58095712a Ard Biesheuvel 2018-08-21 296 * it from inline assembler. Necessary in case 'sym' could be inlined
7290d58095712a Ard Biesheuvel 2018-08-21 297 * otherwise, or eliminated entirely due to lack of references that are
7290d58095712a Ard Biesheuvel 2018-08-21 298 * visible to the compiler.
7290d58095712a Ard Biesheuvel 2018-08-21 299 */
7290d58095712a Ard Biesheuvel 2018-08-21 300 #define __ADDRESSABLE(sym) \
bfafddd8de426d Nick Desaulniers 2019-08-28 301 static void * __section(.discard.addressable) __used \
7290d58095712a Ard Biesheuvel 2018-08-21 @302 __PASTE(__addressable_##sym, __LINE__) = (void *)&sym;
7290d58095712a Ard Biesheuvel 2018-08-21 303
:::::: The code at line 302 was first introduced by commit
:::::: 7290d58095712a89f845e1bca05334796dd49ed2 module: use relative references for __ksymtab entries
:::::: TO: Ard Biesheuvel <ard.biesheuvel(a)linaro.org>
:::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [PATCH v6 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others
by kernel test robot
Hi Yifeng,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on rockchip/for-next]
[also build test WARNING on robh/for-next linus/master v5.7]
[cannot apply to next-20200608]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Yifeng-Zhao/Add-Rockchip-NFC-dri...
base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from include/linux/mm.h:95,
from include/linux/scatterlist.h:8,
from include/linux/dma-mapping.h:11,
from drivers/mtd/nand/raw/rockchip-nand-controller.c:10:
include/asm-generic/pgtable.h: In function 'pte_clear_not_present_full':
arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
96 | pte_t old_pte; | ^~~~~~~
arch/parisc/include/asm/pgtable.h:322:34: note: in expansion of macro 'set_pte_at'
322 | #define pte_clear(mm, addr, xp) set_pte_at(mm, addr, xp, __pte(0))
| ^~~~~~~~~~
include/asm-generic/pgtable.h:202:2: note: in expansion of macro 'pte_clear'
202 | pte_clear(mm, address, ptep);
| ^~~~~~~~~
include/asm-generic/pgtable.h: In function '__ptep_modify_prot_commit':
arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
96 | pte_t old_pte; | ^~~~~~~
include/asm-generic/pgtable.h:641:2: note: in expansion of macro 'set_pte_at'
641 | set_pte_at(vma->vm_mm, addr, ptep, pte);
| ^~~~~~~~~~
drivers/mtd/nand/raw/rockchip-nand-controller.c: At top level:
>> drivers/mtd/nand/raw/rockchip-nand-controller.c:1180:18: warning: initialized field overwritten [-Woverride-init]
1180 | .bch_st_off = 0x20,
| ^~~~
drivers/mtd/nand/raw/rockchip-nand-controller.c:1180:18: note: (near initialization for 'nfc_v8_cfg.bch_st_off')
vim +1180 drivers/mtd/nand/raw/rockchip-nand-controller.c
1166
1167 static struct nfc_cfg nfc_v8_cfg = {
1168 .type = NFC_V8,
1169 .ecc_strengths = {16, 16, 16, 16},
1170 .ecc_cfgs = {
1171 0x00000001, 0x00000001, 0x00000001, 0x00000001,
1172 },
1173 .flctl_off = 0x08,
1174 .bchctl_off = 0x0C,
1175 .dma_cfg_off = 0x10,
1176 .dma_data_buf_off = 0x14,
1177 .dma_oob_buf_off = 0x18,
1178 .dma_st_off = 0x1C,
1179 .bch_st_off = 0x20,
> 1180 .bch_st_off = 0x20,
1181 .randmz_off = 0x150,
1182 .int_en_off = 0x16C,
1183 .int_clr_off = 0x170,
1184 .int_st_off = 0x174,
1185 .oob0_off = 0x200,
1186 .oob1_off = 0x230,
1187 .ecc0 = {
1188 .err_flag_bit = 2,
1189 .low = 3,
1190 .low_mask = 0x1F,
1191 .low_bn = 5,
1192 .high = 27,
1193 .high_mask = 0x1,
1194 },
1195 .ecc1 = {
1196 .err_flag_bit = 15,
1197 .low = 16,
1198 .low_mask = 0x1F,
1199 .low_bn = 5,
1200 .high = 29,
1201 .high_mask = 0x1,
1202 },
1203 };
1204
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
drivers/staging/wfx/hif_tx.c:53:2-8: preceding lock on line 38 (fwd)
by Julia Lawall
Hello,
Does the lock taken on line 38 need to be released on line 53?
julia
---------- Forwarded message ----------
Date: Tue, 9 Jun 2020 16:19:41 +0800
From: kernel test robot <lkp(a)intel.com>
To: kbuild(a)lists.01.org
Cc: lkp(a)intel.com, Julia Lawall <julia.lawall(a)lip6.fr>
Subject: drivers/staging/wfx/hif_tx.c:53:2-8: preceding lock on line 38
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: "Jérôme Pouiller" <jerome.pouiller(a)silabs.com>
CC: "Greg Kroah-Hartman" <gregkh(a)linuxfoundation.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: abfbb29297c27e3f101f348dc9e467b0fe70f919
commit: 4f8b7fabb15df3658564a98971fc67029be1815d staging: wfx: allow to send commands to chip
date: 8 months ago
:::::: branch date: 12 hours ago
:::::: commit date: 8 months ago
config: i386-randconfig-c024-20200607 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Julia Lawall <julia.lawall(a)lip6.fr>
coccinelle warnings: (new ones prefixed by >>)
>> drivers/staging/wfx/hif_tx.c:53:2-8: preceding lock on line 38
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 4f8b7fabb15df3658564a98971fc67029be1815d
vim +53 drivers/staging/wfx/hif_tx.c
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 23
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 24 int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request, void *reply, size_t reply_len, bool async)
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 25 {
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 26 const char *mib_name = "";
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 27 const char *mib_sep = "";
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 28 int cmd = request->id;
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 29 int vif = request->interface;
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 30 int ret;
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 31
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 32 WARN(wdev->hif_cmd.buf_recv && wdev->hif_cmd.async, "API usage error");
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 33
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 34 // Do not wait for any reply if chip is frozen
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 35 if (wdev->chip_frozen)
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 36 return -ETIMEDOUT;
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 37
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 @38 mutex_lock(&wdev->hif_cmd.lock);
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 39 WARN(wdev->hif_cmd.buf_send, "data locking error");
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 40
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 41 // Note: call to complete() below has an implicit memory barrier that
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 42 // hopefully protect buf_send
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 43 wdev->hif_cmd.buf_send = request;
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 44 wdev->hif_cmd.buf_recv = reply;
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 45 wdev->hif_cmd.len_recv = reply_len;
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 46 wdev->hif_cmd.async = async;
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 47 complete(&wdev->hif_cmd.ready);
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 48
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 49 wfx_bh_request_tx(wdev);
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 50
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 51 // NOTE: no timeout is catched async is enabled
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 52 if (async)
4f8b7fabb15df3 Jérôme Pouiller 2019-09-19 @53 return 0;
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [PATCH AUTOSEL 5.7 161/274] powerpc/spufs: fix copy_to_user while atomic
by kernel test robot
Hi Sasha,
I love your patch! Yet something to improve:
[auto build test ERROR on v5.7]
[cannot apply to wireless-drivers-next/master wireless-drivers/master bpf-next/master bpf/master linus/master next-20200608]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Sasha-Levin/drm-amdgpu-fix-and-c...
base: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
arch/powerpc/platforms/cell/spufs/file.c: In function '__spufs_wbox_info_read':
>> arch/powerpc/platforms/cell/spufs/file.c:2066:6: error: variable 'wbox_stat' set but not used [-Werror=unused-but-set-variable]
2066 | u32 wbox_stat;
| ^~~~~~~~~
cc1: all warnings being treated as errors
vim +/wbox_stat +2066 arch/powerpc/platforms/cell/spufs/file.c
6b21b82a42d58a Jeremy Kerr 2020-06-08 2060
bf1ab978be2318 Dwayne Grant McConnell 2006-11-23 2061 static ssize_t __spufs_wbox_info_read(struct spu_context *ctx,
bf1ab978be2318 Dwayne Grant McConnell 2006-11-23 2062 char __user *buf, size_t len, loff_t *pos)
69a2f00ce5d3a1 Dwayne Grant McConnell 2006-11-20 2063 {
69a2f00ce5d3a1 Dwayne Grant McConnell 2006-11-20 2064 int i, cnt;
69a2f00ce5d3a1 Dwayne Grant McConnell 2006-11-20 2065 u32 data[4];
69a2f00ce5d3a1 Dwayne Grant McConnell 2006-11-20 @2066 u32 wbox_stat;
69a2f00ce5d3a1 Dwayne Grant McConnell 2006-11-20 2067
bf1ab978be2318 Dwayne Grant McConnell 2006-11-23 2068 wbox_stat = ctx->csa.prob.mb_stat_R;
6b21b82a42d58a Jeremy Kerr 2020-06-08 2069 cnt = spufs_wbox_info_cnt(ctx);
bf1ab978be2318 Dwayne Grant McConnell 2006-11-23 2070 for (i = 0; i < cnt; i++) {
bf1ab978be2318 Dwayne Grant McConnell 2006-11-23 2071 data[i] = ctx->csa.spu_mailbox_data[i];
bf1ab978be2318 Dwayne Grant McConnell 2006-11-23 2072 }
bf1ab978be2318 Dwayne Grant McConnell 2006-11-23 2073
bf1ab978be2318 Dwayne Grant McConnell 2006-11-23 2074 return simple_read_from_buffer(buf, len, pos, &data,
bf1ab978be2318 Dwayne Grant McConnell 2006-11-23 2075 cnt * sizeof(u32));
bf1ab978be2318 Dwayne Grant McConnell 2006-11-23 2076 }
bf1ab978be2318 Dwayne Grant McConnell 2006-11-23 2077
:::::: The code at line 2066 was first introduced by commit
:::::: 69a2f00ce5d3a19a70b36f08eaf9049677277710 [POWERPC] spufs: Implement /mbox_info, /ibox_info, and /wbox_info.
:::::: TO: Dwayne Grant McConnell <decimal(a)us.ibm.com>
:::::: CC: Paul Mackerras <paulus(a)samba.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [PATCH V7 RESEND 2/7] soc: qcom-geni-se: Add interconnect support to fix earlycon crash
by kernel test robot
Hi Akash,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on usb/usb-testing linus/master next-20200608]
[cannot apply to tty/tty-testing spi/for-next wsa/i2c/for-next v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Akash-Asthana/Add-interconnect-s...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git af7b4801030c07637840191c69eb666917e4135d
config: i386-randconfig-s001-20200608 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-247-gcadbd124-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/soc/qcom/qcom-geni-se.c: In function 'geni_remove_earlycon_icc_vote':
>> drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
819 | parent = of_get_next_parent(wrapper->dev->of_node);
| ^~~~~~~~~~~~~~~~~~
| of_get_parent
>> drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment to 'struct device_node *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
819 | parent = of_get_next_parent(wrapper->dev->of_node);
| ^
cc1: some warnings being treated as errors
vim +819 drivers/soc/qcom/qcom-geni-se.c
808
809 void geni_remove_earlycon_icc_vote(void)
810 {
811 struct geni_wrapper *wrapper;
812 struct device_node *parent;
813 struct device_node *child;
814
815 if (!earlycon_wrapper)
816 return;
817
818 wrapper = earlycon_wrapper;
> 819 parent = of_get_next_parent(wrapper->dev->of_node);
820 for_each_child_of_node(parent, child) {
821 if (!of_device_is_compatible(child, "qcom,geni-se-qup"))
822 continue;
823 wrapper = platform_get_drvdata(of_find_device_by_node(child));
824 icc_put(wrapper->to_core.path);
825 wrapper->to_core.path = NULL;
826
827 }
828 of_node_put(parent);
829
830 earlycon_wrapper = NULL;
831 }
832 EXPORT_SYMBOL(geni_remove_earlycon_icc_vote);
833
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[linux-review:Chuhong-Yuan/mmc-sdhci-of-arasan-Add-missed-checks-for-devm_clk_register/20200609-002445 9682/10032] drivers/net/ethernet/cadence/macb_main.c:4546:58: sparse: sparse: incorrect type in argument 1 (different base types)
by kernel test robot
tree: https://github.com/0day-ci/linux/commits/Chuhong-Yuan/mmc-sdhci-of-arasan...
head: efd2c03ae8ab44634467ae99e9acd90d43d50f89
commit: 60a21c686f7e4e50489ae04b9bb1980b145e52ef [9682/10032] net: macb: Use WOL via ARP
config: arm64-randconfig-s032-20200607 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-247-gcadbd124-dirty
git checkout 60a21c686f7e4e50489ae04b9bb1980b145e52ef
# save the attached .config to linux build tree
make W=1 C=1 ARCH=arm64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/net/ethernet/cadence/macb_main.c:275:16: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] bottom @@ got restricted __le32 [usertype] @@
drivers/net/ethernet/cadence/macb_main.c:275:16: sparse: expected unsigned int [usertype] bottom
drivers/net/ethernet/cadence/macb_main.c:275:16: sparse: got restricted __le32 [usertype]
drivers/net/ethernet/cadence/macb_main.c:277:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] top @@ got restricted __le16 [usertype] @@
drivers/net/ethernet/cadence/macb_main.c:277:13: sparse: expected unsigned short [usertype] top
drivers/net/ethernet/cadence/macb_main.c:277:13: sparse: got restricted __le16 [usertype]
drivers/net/ethernet/cadence/macb_main.c:2952:39: sparse: sparse: restricted __be32 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:2957:39: sparse: sparse: restricted __be32 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:2962:40: sparse: sparse: restricted __be16 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:2962:69: sparse: sparse: restricted __be16 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:2984:20: sparse: sparse: restricted __be32 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:2988:20: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [assigned] [usertype] w0 @@ got restricted __be32 [usertype] ip4src @@
drivers/net/ethernet/cadence/macb_main.c:2988:20: sparse: expected unsigned int [assigned] [usertype] w0
drivers/net/ethernet/cadence/macb_main.c:2988:20: sparse: got restricted __be32 [usertype] ip4src
drivers/net/ethernet/cadence/macb_main.c:2998:20: sparse: sparse: restricted __be32 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:3002:20: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [assigned] [usertype] w0 @@ got restricted __be32 [usertype] ip4dst @@
drivers/net/ethernet/cadence/macb_main.c:3002:20: sparse: expected unsigned int [assigned] [usertype] w0
drivers/net/ethernet/cadence/macb_main.c:3002:20: sparse: got restricted __be32 [usertype] ip4dst
drivers/net/ethernet/cadence/macb_main.c:3012:21: sparse: sparse: restricted __be16 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:3012:50: sparse: sparse: restricted __be16 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:3018:30: sparse: sparse: restricted __be16 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:3019:30: sparse: sparse: restricted __be16 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:3026:36: sparse: sparse: restricted __be16 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:3027:38: sparse: sparse: restricted __be16 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:3030:38: sparse: sparse: restricted __be16 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:3066:9: sparse: sparse: cast from restricted __be32
drivers/net/ethernet/cadence/macb_main.c:3066:9: sparse: sparse: cast from restricted __be32
drivers/net/ethernet/cadence/macb_main.c:3066:9: sparse: sparse: cast from restricted __be16
drivers/net/ethernet/cadence/macb_main.c:3066:9: sparse: sparse: cast from restricted __be16
drivers/net/ethernet/cadence/macb_main.c:3119:25: sparse: sparse: cast from restricted __be32
drivers/net/ethernet/cadence/macb_main.c:3119:25: sparse: sparse: cast from restricted __be32
drivers/net/ethernet/cadence/macb_main.c:3119:25: sparse: sparse: cast from restricted __be16
drivers/net/ethernet/cadence/macb_main.c:3119:25: sparse: sparse: cast from restricted __be16
>> drivers/net/ethernet/cadence/macb_main.c:4546:58: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned int const [usertype] *p @@ got restricted __be32 [noderef] <asn:4> * @@
drivers/net/ethernet/cadence/macb_main.c:4546:58: sparse: expected unsigned int const [usertype] *p
>> drivers/net/ethernet/cadence/macb_main.c:4546:58: sparse: got restricted __be32 [noderef] <asn:4> *
drivers/net/ethernet/cadence/macb_main.c:4546:41: sparse: sparse: restricted __be32 degrades to integer
drivers/net/ethernet/cadence/macb_main.c:4546:50: sparse: sparse: dereference of noderef expression
drivers/net/ethernet/cadence/macb_main.c:4546:50: sparse: sparse: dereference of noderef expression
vim +4546 drivers/net/ethernet/cadence/macb_main.c
4503
4504 static int __maybe_unused macb_suspend(struct device *dev)
4505 {
4506 struct net_device *netdev = dev_get_drvdata(dev);
4507 struct macb *bp = netdev_priv(netdev);
4508 struct macb_queue *queue = bp->queues;
4509 unsigned long flags;
4510 unsigned int q;
4511 u32 ctrl, arpipmask;
4512
4513 if (!netif_running(netdev))
4514 return 0;
4515
4516 if (device_may_wakeup(&bp->dev->dev)) {
4517 spin_lock_irqsave(&bp->lock, flags);
4518 ctrl = macb_readl(bp, NCR);
4519 ctrl &= ~(MACB_BIT(TE) | MACB_BIT(RE));
4520 macb_writel(bp, NCR, ctrl);
4521 /* Tie off RX queues */
4522 for (q = 0, queue = bp->queues; q < bp->num_queues;
4523 ++q, ++queue) {
4524 queue_writel(queue, RBQP,
4525 lower_32_bits(bp->rx_ring_tieoff_dma));
4526 }
4527 ctrl = macb_readl(bp, NCR);
4528 ctrl |= MACB_BIT(RE);
4529 macb_writel(bp, NCR, ctrl);
4530 gem_writel(bp, NCFGR, gem_readl(bp, NCFGR) & ~MACB_BIT(NBC));
4531 macb_writel(bp, TSR, -1);
4532 macb_writel(bp, RSR, -1);
4533 macb_readl(bp, ISR);
4534 if (bp->caps & MACB_CAPS_ISR_CLEAR_ON_WRITE)
4535 macb_writel(bp, ISR, -1);
4536
4537 /* Enable WOL (Q0 only) and disable all other interrupts */
4538 macb_writel(bp, IER, MACB_BIT(WOL));
4539 for (q = 1, queue = bp->queues; q < bp->num_queues;
4540 ++q, ++queue) {
4541 queue_writel(queue, IDR, bp->rx_intr_mask |
4542 MACB_TX_INT_FLAGS |
4543 MACB_BIT(HRESP));
4544 }
4545
> 4546 arpipmask = cpu_to_be32p(&bp->dev->ip_ptr->ifa_list->ifa_local)
4547 & 0xFFFF;
4548 gem_writel(bp, WOL, MACB_BIT(ARP) | arpipmask);
4549 spin_unlock_irqrestore(&bp->lock, flags);
4550 enable_irq_wake(bp->queues[0].irq);
4551 netif_device_detach(netdev);
4552 for (q = 0, queue = bp->queues; q < bp->num_queues;
4553 ++q, ++queue)
4554 napi_disable(&queue->napi);
4555 } else {
4556 netif_device_detach(netdev);
4557 for (q = 0, queue = bp->queues; q < bp->num_queues;
4558 ++q, ++queue)
4559 napi_disable(&queue->napi);
4560 phy_stop(netdev->phydev);
4561 phy_suspend(netdev->phydev);
4562 spin_lock_irqsave(&bp->lock, flags);
4563 macb_reset_hw(bp);
4564 spin_unlock_irqrestore(&bp->lock, flags);
4565
4566 if (!(bp->caps & MACB_CAPS_USRIO_DISABLED))
4567 bp->pm_data.usrio = macb_or_gem_readl(bp, USRIO);
4568
4569 if (netdev->hw_features & NETIF_F_NTUPLE)
4570 bp->pm_data.scrt2 = gem_readl_n(bp, ETHT, SCRT2_ETHT);
4571 }
4572
4573 if (bp->ptp_info)
4574 bp->ptp_info->ptp_remove(netdev);
4575 pm_runtime_force_suspend(dev);
4576
4577 return 0;
4578 }
4579
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [RESEND PATCH] sys_personality: Add optional arch hook arch_check_personality
by kernel test robot
Hi Wang,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on arm64/for-next/core]
[also build test WARNING on linux/master v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Wang-ShaoBo/sys_personality-Add-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-randconfig-c021-20200608 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> arch/arm64/kernel/sys.c:31:5: warning: no previous prototype for 'arch_check_personality' [-Wmissing-prototypes]
31 | int arch_check_personality(unsigned int personality)
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/sys.c:42:17: warning: no previous prototype for '__arm64_sys_ni_syscall' [-Wmissing-prototypes]
42 | asmlinkage long __arm64_sys_ni_syscall(const struct pt_regs *__unused)
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:29:37: note: in expansion of macro '__SYSCALL'
29 | #define __SC_COMP(_nr, _sys, _comp) __SYSCALL(_nr, _sys)
| ^~~~~~~~~
include/uapi/asm-generic/unistd.h:34:1: note: in expansion of macro '__SC_COMP'
34 | __SC_COMP(__NR_io_setup, sys_io_setup, compat_sys_io_setup)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: note: (near initialization for 'sys_call_table[0]')
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:29:37: note: in expansion of macro '__SYSCALL'
29 | #define __SC_COMP(_nr, _sys, _comp) __SYSCALL(_nr, _sys)
| ^~~~~~~~~
include/uapi/asm-generic/unistd.h:34:1: note: in expansion of macro '__SC_COMP'
34 | __SC_COMP(__NR_io_setup, sys_io_setup, compat_sys_io_setup)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:36:1: note: in expansion of macro '__SYSCALL'
36 | __SYSCALL(__NR_io_destroy, sys_io_destroy)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: note: (near initialization for 'sys_call_table[1]')
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:36:1: note: in expansion of macro '__SYSCALL'
36 | __SYSCALL(__NR_io_destroy, sys_io_destroy)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:29:37: note: in expansion of macro '__SYSCALL'
29 | #define __SC_COMP(_nr, _sys, _comp) __SYSCALL(_nr, _sys)
| ^~~~~~~~~
include/uapi/asm-generic/unistd.h:38:1: note: in expansion of macro '__SC_COMP'
38 | __SC_COMP(__NR_io_submit, sys_io_submit, compat_sys_io_submit)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: note: (near initialization for 'sys_call_table[2]')
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:29:37: note: in expansion of macro '__SYSCALL'
29 | #define __SC_COMP(_nr, _sys, _comp) __SYSCALL(_nr, _sys)
| ^~~~~~~~~
include/uapi/asm-generic/unistd.h:38:1: note: in expansion of macro '__SC_COMP'
38 | __SC_COMP(__NR_io_submit, sys_io_submit, compat_sys_io_submit)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:40:1: note: in expansion of macro '__SYSCALL'
40 | __SYSCALL(__NR_io_cancel, sys_io_cancel)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: note: (near initialization for 'sys_call_table[3]')
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:40:1: note: in expansion of macro '__SYSCALL'
40 | __SYSCALL(__NR_io_cancel, sys_io_cancel)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:22:34: note: in expansion of macro '__SYSCALL'
22 | #define __SC_3264(_nr, _32, _64) __SYSCALL(_nr, _64)
| ^~~~~~~~~
include/uapi/asm-generic/unistd.h:43:1: note: in expansion of macro '__SC_3264'
43 | __SC_3264(__NR_io_getevents, sys_io_getevents_time32, sys_io_getevents)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: note: (near initialization for 'sys_call_table[4]')
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:22:34: note: in expansion of macro '__SYSCALL'
22 | #define __SC_3264(_nr, _32, _64) __SYSCALL(_nr, _64)
| ^~~~~~~~~
include/uapi/asm-generic/unistd.h:43:1: note: in expansion of macro '__SC_3264'
43 | __SC_3264(__NR_io_getevents, sys_io_getevents_time32, sys_io_getevents)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:48:1: note: in expansion of macro '__SYSCALL'
48 | __SYSCALL(__NR_setxattr, sys_setxattr)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: note: (near initialization for 'sys_call_table[5]')
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:48:1: note: in expansion of macro '__SYSCALL'
48 | __SYSCALL(__NR_setxattr, sys_setxattr)
| ^~~~~~~~~
arch/arm64/kernel/sys.c:55:35: warning: initialized field overwritten [-Woverride-init]
55 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
include/uapi/asm-generic/unistd.h:50:1: note: in expansion of macro '__SYSCALL'
50 | __SYSCALL(__NR_lsetxattr, sys_lsetxattr)
vim +/arch_check_personality +31 arch/arm64/kernel/sys.c
30
> 31 int arch_check_personality(unsigned int personality)
32 {
33 if (personality(personality) == PER_LINUX32 &&
34 !system_supports_32bit_el0())
35 return -EINVAL;
36
37 return 0;
38 }
39
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[android-common:android-4.19-stable 15309/16378] sound/soc/soc-dapm.c:3678:12: warning: stack frame size of 2088 bytes in function 'snd_soc_dai_link_event'
by kernel test robot
tree: https://android.googlesource.com/kernel/common android-4.19-stable
head: 77d75fe936e0bb518fe31ec6a12ae30e9c1866f7
commit: 8c62976a01249b4da610adc1d4d2ead9185a6131 [15309/16378] ANDROID: GKI: ALSA: pcm: add locks for accessing runtime resource
config: x86_64-randconfig-r024-20200607 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e429cffd4f228f70c1d9df0e5d77c08590dd9766)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 8c62976a01249b4da610adc1d4d2ead9185a6131
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> sound/soc/soc-dapm.c:3678:12: warning: stack frame size of 2088 bytes in function 'snd_soc_dai_link_event' [-Wframe-larger-than=]
static int snd_soc_dai_link_event(struct snd_soc_dapm_widget *w,
^
1 warning generated.
--
>> sound/soc/intel/skylake/skl-messages.c:108:12: warning: stack frame size of 2064 bytes in function 'skl_dsp_prepare' [-Wframe-larger-than=]
static int skl_dsp_prepare(struct device *dev, unsigned int format,
^
1 warning generated.
vim +/snd_soc_dai_link_event +3678 sound/soc/soc-dapm.c
4ba1327ab8ce17 Mark Brown 2008-05-13 3677
c74184ed30ecce Mark Brown 2012-04-04 @3678 static int snd_soc_dai_link_event(struct snd_soc_dapm_widget *w,
c74184ed30ecce Mark Brown 2012-04-04 3679 struct snd_kcontrol *kcontrol, int event)
c74184ed30ecce Mark Brown 2012-04-04 3680 {
c74184ed30ecce Mark Brown 2012-04-04 3681 struct snd_soc_dapm_path *source_p, *sink_p;
c74184ed30ecce Mark Brown 2012-04-04 3682 struct snd_soc_dai *source, *sink;
249dc49576fc95 Charles Keepax 2018-08-15 3683 struct snd_soc_pcm_runtime *rtd = w->priv;
c66150824b8a80 Nikesh Oswal 2015-02-02 3684 const struct snd_soc_pcm_stream *config = w->params + w->params_select;
c74184ed30ecce Mark Brown 2012-04-04 3685 struct snd_pcm_substream substream;
9747cec21e2d55 Mark Brown 2012-04-26 3686 struct snd_pcm_hw_params *params = NULL;
8053f21675b073 Nicolin Chen 2016-07-26 3687 struct snd_pcm_runtime *runtime = NULL;
3ba66feb59810e Takashi Iwai 2018-07-25 3688 unsigned int fmt;
0376916b7b2cff Charles Keepax 2018-09-06 3689 int ret = 0;
c74184ed30ecce Mark Brown 2012-04-04 3690
bf4edea863c435 Takashi Iwai 2013-11-07 3691 if (WARN_ON(!config) ||
a3423b02cf745c Lars-Peter Clausen 2015-08-11 3692 WARN_ON(list_empty(&w->edges[SND_SOC_DAPM_DIR_OUT]) ||
a3423b02cf745c Lars-Peter Clausen 2015-08-11 3693 list_empty(&w->edges[SND_SOC_DAPM_DIR_IN])))
bf4edea863c435 Takashi Iwai 2013-11-07 3694 return -EINVAL;
c74184ed30ecce Mark Brown 2012-04-04 3695
c74184ed30ecce Mark Brown 2012-04-04 3696 /* We only support a single source and sink, pick the first */
a3423b02cf745c Lars-Peter Clausen 2015-08-11 3697 source_p = list_first_entry(&w->edges[SND_SOC_DAPM_DIR_OUT],
a3423b02cf745c Lars-Peter Clausen 2015-08-11 3698 struct snd_soc_dapm_path,
a3423b02cf745c Lars-Peter Clausen 2015-08-11 3699 list_node[SND_SOC_DAPM_DIR_OUT]);
a3423b02cf745c Lars-Peter Clausen 2015-08-11 3700 sink_p = list_first_entry(&w->edges[SND_SOC_DAPM_DIR_IN],
a3423b02cf745c Lars-Peter Clausen 2015-08-11 3701 struct snd_soc_dapm_path,
a3423b02cf745c Lars-Peter Clausen 2015-08-11 3702 list_node[SND_SOC_DAPM_DIR_IN]);
c74184ed30ecce Mark Brown 2012-04-04 3703
c74184ed30ecce Mark Brown 2012-04-04 3704 source = source_p->source->priv;
c74184ed30ecce Mark Brown 2012-04-04 3705 sink = sink_p->sink->priv;
c74184ed30ecce Mark Brown 2012-04-04 3706
c74184ed30ecce Mark Brown 2012-04-04 3707 /* Be a little careful as we don't want to overflow the mask array */
c74184ed30ecce Mark Brown 2012-04-04 3708 if (config->formats) {
c74184ed30ecce Mark Brown 2012-04-04 3709 fmt = ffs(config->formats) - 1;
c74184ed30ecce Mark Brown 2012-04-04 3710 } else {
30a6a1a4eed170 Liam Girdwood 2012-11-19 3711 dev_warn(w->dapm->dev, "ASoC: Invalid format %llx specified\n",
c74184ed30ecce Mark Brown 2012-04-04 3712 config->formats);
c74184ed30ecce Mark Brown 2012-04-04 3713 fmt = 0;
c74184ed30ecce Mark Brown 2012-04-04 3714 }
c74184ed30ecce Mark Brown 2012-04-04 3715
c74184ed30ecce Mark Brown 2012-04-04 3716 /* Currently very limited parameter selection */
9747cec21e2d55 Mark Brown 2012-04-26 3717 params = kzalloc(sizeof(*params), GFP_KERNEL);
9747cec21e2d55 Mark Brown 2012-04-26 3718 if (!params) {
9747cec21e2d55 Mark Brown 2012-04-26 3719 ret = -ENOMEM;
9747cec21e2d55 Mark Brown 2012-04-26 3720 goto out;
9747cec21e2d55 Mark Brown 2012-04-26 3721 }
9747cec21e2d55 Mark Brown 2012-04-26 3722 snd_mask_set(hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT), fmt);
c74184ed30ecce Mark Brown 2012-04-04 3723
9747cec21e2d55 Mark Brown 2012-04-26 3724 hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE)->min =
c74184ed30ecce Mark Brown 2012-04-04 3725 config->rate_min;
9747cec21e2d55 Mark Brown 2012-04-26 3726 hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE)->max =
c74184ed30ecce Mark Brown 2012-04-04 3727 config->rate_max;
c74184ed30ecce Mark Brown 2012-04-04 3728
9747cec21e2d55 Mark Brown 2012-04-26 3729 hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS)->min
c74184ed30ecce Mark Brown 2012-04-04 3730 = config->channels_min;
9747cec21e2d55 Mark Brown 2012-04-26 3731 hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS)->max
c74184ed30ecce Mark Brown 2012-04-04 3732 = config->channels_max;
c74184ed30ecce Mark Brown 2012-04-04 3733
c74184ed30ecce Mark Brown 2012-04-04 3734 memset(&substream, 0, sizeof(substream));
c74184ed30ecce Mark Brown 2012-04-04 3735
8053f21675b073 Nicolin Chen 2016-07-26 3736 /* Allocate a dummy snd_pcm_runtime for startup() and other ops() */
8053f21675b073 Nicolin Chen 2016-07-26 3737 runtime = kzalloc(sizeof(*runtime), GFP_KERNEL);
8053f21675b073 Nicolin Chen 2016-07-26 3738 if (!runtime) {
8053f21675b073 Nicolin Chen 2016-07-26 3739 ret = -ENOMEM;
8053f21675b073 Nicolin Chen 2016-07-26 3740 goto out;
8053f21675b073 Nicolin Chen 2016-07-26 3741 }
8053f21675b073 Nicolin Chen 2016-07-26 3742 substream.runtime = runtime;
249dc49576fc95 Charles Keepax 2018-08-15 3743 substream.private_data = rtd;
8053f21675b073 Nicolin Chen 2016-07-26 3744
c74184ed30ecce Mark Brown 2012-04-04 3745 switch (event) {
c74184ed30ecce Mark Brown 2012-04-04 3746 case SND_SOC_DAPM_PRE_PMU:
c74184ed30ecce Mark Brown 2012-04-04 3747 substream.stream = SNDRV_PCM_STREAM_CAPTURE;
9900a4226c785d Kuninori Morimoto 2017-09-25 3748 if (source->driver->ops->startup) {
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3749 ret = source->driver->ops->startup(&substream, source);
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3750 if (ret < 0) {
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3751 dev_err(source->dev,
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3752 "ASoC: startup() failed: %d\n", ret);
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3753 goto out;
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3754 }
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3755 source->active++;
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3756 }
93e6958a3674d2 Benoit Cousson 2014-07-08 3757 ret = soc_dai_hw_params(&substream, params, source);
93e6958a3674d2 Benoit Cousson 2014-07-08 3758 if (ret < 0)
9747cec21e2d55 Mark Brown 2012-04-26 3759 goto out;
c74184ed30ecce Mark Brown 2012-04-04 3760
c74184ed30ecce Mark Brown 2012-04-04 3761 substream.stream = SNDRV_PCM_STREAM_PLAYBACK;
9900a4226c785d Kuninori Morimoto 2017-09-25 3762 if (sink->driver->ops->startup) {
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3763 ret = sink->driver->ops->startup(&substream, sink);
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3764 if (ret < 0) {
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3765 dev_err(sink->dev,
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3766 "ASoC: startup() failed: %d\n", ret);
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3767 goto out;
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3768 }
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3769 sink->active++;
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3770 }
93e6958a3674d2 Benoit Cousson 2014-07-08 3771 ret = soc_dai_hw_params(&substream, params, sink);
93e6958a3674d2 Benoit Cousson 2014-07-08 3772 if (ret < 0)
9747cec21e2d55 Mark Brown 2012-04-26 3773 goto out;
c74184ed30ecce Mark Brown 2012-04-04 3774 break;
c74184ed30ecce Mark Brown 2012-04-04 3775
c74184ed30ecce Mark Brown 2012-04-04 3776 case SND_SOC_DAPM_POST_PMU:
da18396f949eca Mark Brown 2013-02-06 3777 ret = snd_soc_dai_digital_mute(sink, 0,
da18396f949eca Mark Brown 2013-02-06 3778 SNDRV_PCM_STREAM_PLAYBACK);
c74184ed30ecce Mark Brown 2012-04-04 3779 if (ret != 0 && ret != -ENOTSUPP)
30a6a1a4eed170 Liam Girdwood 2012-11-19 3780 dev_warn(sink->dev, "ASoC: Failed to unmute: %d\n", ret);
9747cec21e2d55 Mark Brown 2012-04-26 3781 ret = 0;
c74184ed30ecce Mark Brown 2012-04-04 3782 break;
c74184ed30ecce Mark Brown 2012-04-04 3783
c74184ed30ecce Mark Brown 2012-04-04 3784 case SND_SOC_DAPM_PRE_PMD:
da18396f949eca Mark Brown 2013-02-06 3785 ret = snd_soc_dai_digital_mute(sink, 1,
da18396f949eca Mark Brown 2013-02-06 3786 SNDRV_PCM_STREAM_PLAYBACK);
c74184ed30ecce Mark Brown 2012-04-04 3787 if (ret != 0 && ret != -ENOTSUPP)
30a6a1a4eed170 Liam Girdwood 2012-11-19 3788 dev_warn(sink->dev, "ASoC: Failed to mute: %d\n", ret);
9747cec21e2d55 Mark Brown 2012-04-26 3789 ret = 0;
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3790
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3791 source->active--;
9900a4226c785d Kuninori Morimoto 2017-09-25 3792 if (source->driver->ops->shutdown) {
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3793 substream.stream = SNDRV_PCM_STREAM_CAPTURE;
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3794 source->driver->ops->shutdown(&substream, source);
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3795 }
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3796
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3797 sink->active--;
9900a4226c785d Kuninori Morimoto 2017-09-25 3798 if (sink->driver->ops->shutdown) {
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3799 substream.stream = SNDRV_PCM_STREAM_PLAYBACK;
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3800 sink->driver->ops->shutdown(&substream, sink);
9b8ef9f6b3fccc Jeeja KP 2015-10-20 3801 }
c74184ed30ecce Mark Brown 2012-04-04 3802 break;
c74184ed30ecce Mark Brown 2012-04-04 3803
c74184ed30ecce Mark Brown 2012-04-04 3804 default:
a6ed0608bd289b Takashi Iwai 2013-11-06 3805 WARN(1, "Unknown event %d\n", event);
75881df3fd7708 Sudip Mukherjee 2015-09-10 3806 ret = -EINVAL;
c74184ed30ecce Mark Brown 2012-04-04 3807 }
c74184ed30ecce Mark Brown 2012-04-04 3808
9747cec21e2d55 Mark Brown 2012-04-26 3809 out:
8053f21675b073 Nicolin Chen 2016-07-26 3810 kfree(runtime);
9747cec21e2d55 Mark Brown 2012-04-26 3811 kfree(params);
9747cec21e2d55 Mark Brown 2012-04-26 3812 return ret;
c74184ed30ecce Mark Brown 2012-04-04 3813 }
c74184ed30ecce Mark Brown 2012-04-04 3814
:::::: The code at line 3678 was first introduced by commit
:::::: c74184ed30ecce2a5e9ae9aa22cb5e3942e0c7c7 ASoC: core: Support transparent CODEC<->CODEC DAI links
:::::: TO: Mark Brown <broonie(a)opensource.wolfsonmicro.com>
:::::: CC: Mark Brown <broonie(a)opensource.wolfsonmicro.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [PATCH v6 3/5] drm/msm/dp: add displayPort driver support
by kernel test robot
Hi Tanmay,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on drm-intel/for-linux-next linus/master v5.7 next-20200608]
[cannot apply to robclark/msm-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Tanmay-Shah/dt-bindings-msm-dp-a...
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/gpu/drm/msm/dp/dp_aux.c:35:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
35 | static const char * const dp_aux_get_error(u32 aux_error)
| ^~~~~
--
>> drivers/gpu/drm/msm/dp/dp_catalog.c:352:6: warning: no previous prototype for 'dump_regs' [-Wmissing-prototypes]
352 | void dump_regs(void * __iomem *base, int len)
| ^~~~~~~~~
In file included from include/linux/printk.h:7,
from include/linux/kernel.h:15,
from include/linux/delay.h:22,
from drivers/gpu/drm/msm/dp/dp_catalog.c:8:
drivers/gpu/drm/msm/dp/dp_catalog.c: In function 'dump_regs':
>> include/linux/kern_levels.h:5:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'void **' [-Wformat=]
5 | #define KERN_SOH "001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
14 | #define KERN_INFO KERN_SOH "6" /* informational */
| ^~~~~~~~
include/linux/printk.h:305:9: note: in expansion of macro 'KERN_INFO'
305 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~
>> drivers/gpu/drm/msm/dp/dp_catalog.c:364:3: note: in expansion of macro 'pr_info'
364 | pr_info("%08x: %08x %08x %08x %08x", base, x0, x4, x8, xc);
| ^~~~~~~
drivers/gpu/drm/msm/dp/dp_catalog.c:364:15: note: format string is defined here
364 | pr_info("%08x: %08x %08x %08x %08x", base, x0, x4, x8, xc);
| ~~~^
| |
| unsigned int
At top level:
drivers/gpu/drm/msm/dp/dp_catalog.c:76:17: warning: 'vm_voltage_swing_hbr3_hbr2' defined but not used [-Wunused-const-variable=]
76 | static u8 const vm_voltage_swing_hbr3_hbr2[4][4] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_catalog.c:69:17: warning: 'vm_pre_emphasis_hbr3_hbr2' defined but not used [-Wunused-const-variable=]
69 | static u8 const vm_pre_emphasis_hbr3_hbr2[4][4] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_catalog.c:62:17: warning: 'vm_voltage_swing' defined but not used [-Wunused-const-variable=]
62 | static u8 const vm_voltage_swing[4][4] = {
| ^~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_catalog.c:54:17: warning: 'vm_pre_emphasis' defined but not used [-Wunused-const-variable=]
54 | static u8 const vm_pre_emphasis[4][4] = {
| ^~~~~~~~~~~~~~~
--
drivers/gpu/drm/msm/dp/dp_ctrl.c: In function '_tu_param_compare':
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:254:13: warning: variable 'b_frac' set but not used [-Wunused-but-set-variable]
254 | u32 b_int, b_frac, b_sign;
| ^~~~~~
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:254:6: warning: variable 'b_int' set but not used [-Wunused-but-set-variable]
254 | u32 b_int, b_frac, b_sign;
| ^~~~~
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:253:13: warning: variable 'a_frac' set but not used [-Wunused-but-set-variable]
253 | u32 a_int, a_frac, a_sign;
| ^~~~~~
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:253:6: warning: variable 'a_int' set but not used [-Wunused-but-set-variable]
253 | u32 a_int, a_frac, a_sign;
| ^~~~~
drivers/gpu/drm/msm/dp/dp_ctrl.c: In function 'dp_panel_update_tu_timings':
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:301:6: warning: variable 'overhead_dsc' set but not used [-Wunused-but-set-variable]
301 | s64 overhead_dsc;
| ^~~~~~~~~~~~
--
drivers/gpu/drm/msm/dp/dp_link.c: In function 'dp_link_parse_phy_test_params':
drivers/gpu/drm/msm/dp/dp_link.c:576:47: error: 'DP_PHY_TEST_PATTERN' undeclared (first use in this function); did you mean 'DP_NO_TEST_PATTERN'?
576 | rlen = drm_dp_dpcd_readb(link->aux->drm_aux, DP_PHY_TEST_PATTERN,
| ^~~~~~~~~~~~~~~~~~~
| DP_NO_TEST_PATTERN
drivers/gpu/drm/msm/dp/dp_link.c:576:47: note: each undeclared identifier is reported only once for each function it appears in
drivers/gpu/drm/msm/dp/dp_link.c: In function 'dp_link_adjust_levels':
>> drivers/gpu/drm/msm/dp/dp_link.c:1106:26: warning: variable 'link' set but not used [-Wunused-but-set-variable]
1106 | struct dp_link_private *link;
| ^~~~
--
drivers/gpu/drm/msm/dp/dp_panel.c: In function 'dp_panel_read_dpcd':
>> drivers/gpu/drm/msm/dp/dp_panel.c:39:11: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
39 | if (rlen < 0) {
| ^
drivers/gpu/drm/msm/dp/dp_panel.c: At top level:
>> drivers/gpu/drm/msm/dp/dp_panel.c:283:4: warning: no previous prototype for 'dp_panel_get_edid_checksum' [-Wmissing-prototypes]
283 | u8 dp_panel_get_edid_checksum(struct edid *edid)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_panel.c: In function 'dp_panel_put':
>> drivers/gpu/drm/msm/dp/dp_panel.c:482:27: warning: variable 'panel' set but not used [-Wunused-but-set-variable]
482 | struct dp_panel_private *panel;
| ^~~~~
--
drivers/gpu/drm/msm/dp/dp_parser.c: In function 'dp_parser_init_clk_data':
>> drivers/gpu/drm/msm/dp/dp_parser.c:251:26: warning: variable 'rc' set but not used [-Wunused-but-set-variable]
251 | int num_clk = 0, i = 0, rc = 0;
| ^~
--
drivers/gpu/drm/msm/dp/dp_power.c: In function 'dp_power_clk_enable':
>> drivers/gpu/drm/msm/dp/dp_power.c:172:27: warning: variable 'mp' set but not used [-Wunused-but-set-variable]
172 | struct dss_module_power *mp;
| ^~
vim +35 drivers/gpu/drm/msm/dp/dp_aux.c
34
> 35 static const char * const dp_aux_get_error(u32 aux_error)
36 {
37 switch (aux_error) {
38 case DP_AUX_ERR_NONE:
39 return DP_AUX_ENUM_STR(DP_AUX_ERR_NONE);
40 case DP_AUX_ERR_ADDR:
41 return DP_AUX_ENUM_STR(DP_AUX_ERR_ADDR);
42 case DP_AUX_ERR_TOUT:
43 return DP_AUX_ENUM_STR(DP_AUX_ERR_TOUT);
44 case DP_AUX_ERR_NACK:
45 return DP_AUX_ENUM_STR(DP_AUX_ERR_NACK);
46 case DP_AUX_ERR_DEFER:
47 return DP_AUX_ENUM_STR(DP_AUX_ERR_DEFER);
48 case DP_AUX_ERR_NACK_DEFER:
49 return DP_AUX_ENUM_STR(DP_AUX_ERR_NACK_DEFER);
50 default:
51 return "unknown";
52 }
53 }
54
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
Re: [PATCH] mdraid: fix read/write bytes accounting
by kernel test robot
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on next-20200608]
[cannot apply to v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/jeffm-suse-com/mdraid-fix-read-w...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b170290c2836c40ab565736ba37681eb3dfd79b8
config: m68k-randconfig-r011-20200607 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/md/md.c: In function 'md_make_request':
>> drivers/md/md.c:485:15: warning: variable 'sectors' set but not used [-Wunused-but-set-variable]
485 | unsigned int sectors;
| ^~~~~~~
drivers/md/md.c: In function 'bind_rdev_to_array':
drivers/md/md.c:2454:27: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
2454 | /* failure here is OK */;
| ^
drivers/md/md.c: In function 'slot_store':
drivers/md/md.c:3215:28: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
3215 | /* failure here is OK */;
| ^
drivers/md/md.c: In function 'remove_and_add_spares':
drivers/md/md.c:9073:29: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
9073 | /* failure here is OK */;
| ^
vim +/sectors +485 drivers/md/md.c
eb17e42dfd959c Jeff Mahoney 2020-06-05 480
dece16353ef47d Jens Axboe 2015-11-05 481 static blk_qc_t md_make_request(struct request_queue *q, struct bio *bio)
^1da177e4c3f41 Linus Torvalds 2005-04-16 482 {
490773268cf64f NeilBrown 2010-03-25 483 const int rw = bio_data_dir(bio);
e4fc5a74293fbe Christoph Hellwig 2020-05-08 484 struct mddev *mddev = bio->bi_disk->private_data;
e91ece5590b3c7 Chris Mason 2011-02-07 @485 unsigned int sectors;
490773268cf64f NeilBrown 2010-03-25 486
62f7b1989c02fe Guilherme G. Piccoli 2019-09-03 487 if (unlikely(test_bit(MD_BROKEN, &mddev->flags)) && (rw == WRITE)) {
62f7b1989c02fe Guilherme G. Piccoli 2019-09-03 488 bio_io_error(bio);
62f7b1989c02fe Guilherme G. Piccoli 2019-09-03 489 return BLK_QC_T_NONE;
62f7b1989c02fe Guilherme G. Piccoli 2019-09-03 490 }
62f7b1989c02fe Guilherme G. Piccoli 2019-09-03 491
af67c31fba3b87 NeilBrown 2017-06-18 492 blk_queue_split(q, &bio);
54efd50bfd873e Kent Overstreet 2015-04-23 493
274d8cbde1bc3b NeilBrown 2016-01-04 494 if (mddev == NULL || mddev->pers == NULL) {
6712ecf8f64811 NeilBrown 2007-09-27 495 bio_io_error(bio);
dece16353ef47d Jens Axboe 2015-11-05 496 return BLK_QC_T_NONE;
^1da177e4c3f41 Linus Torvalds 2005-04-16 497 }
bbfa57c0f2243a Sebastian Riemer 2013-02-21 498 if (mddev->ro == 1 && unlikely(rw == WRITE)) {
4246a0b63bd8f5 Christoph Hellwig 2015-07-20 499 if (bio_sectors(bio) != 0)
4e4cbee93d5613 Christoph Hellwig 2017-06-03 500 bio->bi_status = BLK_STS_IOERR;
4246a0b63bd8f5 Christoph Hellwig 2015-07-20 501 bio_endio(bio);
dece16353ef47d Jens Axboe 2015-11-05 502 return BLK_QC_T_NONE;
bbfa57c0f2243a Sebastian Riemer 2013-02-21 503 }
490773268cf64f NeilBrown 2010-03-25 504
e91ece5590b3c7 Chris Mason 2011-02-07 505 /*
e91ece5590b3c7 Chris Mason 2011-02-07 506 * save the sectors now since our bio can
e91ece5590b3c7 Chris Mason 2011-02-07 507 * go away inside make_request
e91ece5590b3c7 Chris Mason 2011-02-07 508 */
e91ece5590b3c7 Chris Mason 2011-02-07 509 sectors = bio_sectors(bio);
9c573de3283af0 Shaohua Li 2016-04-25 510 /* bio could be mergeable after passing to underlayer */
1eff9d322a4442 Jens Axboe 2016-08-05 511 bio->bi_opf &= ~REQ_NOMERGE;
393debc23c7820 Shaohua Li 2017-09-21 512
393debc23c7820 Shaohua Li 2017-09-21 513 md_handle_request(mddev, bio);
490773268cf64f NeilBrown 2010-03-25 514
dece16353ef47d Jens Axboe 2015-11-05 515 return BLK_QC_T_NONE;
409c57f3801701 NeilBrown 2009-03-31 516 }
409c57f3801701 NeilBrown 2009-03-31 517
:::::: The code at line 485 was first introduced by commit
:::::: e91ece5590b3c728624ab57043fc7a05069c604a md_make_request: don't touch the bio after calling make_request
:::::: TO: Chris Mason <chris.mason(a)oracle.com>
:::::: CC: NeilBrown <neilb(a)suse.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months