[xlnx:master 10/20] drivers/misc/xilinx-ai-engine/ai-engine-dev.c:165:2: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx master
head: 319e5bc767fe351a63744daa9cdd69b1915956d0
commit: b4164ed1bbab5999a8b30dc25eaaa3200ff1fe59 [10/20] misc: ai-engine: Move AI engine reg access to kernel
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout b4164ed1bbab5999a8b30dc25eaaa3200ff1fe59
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/misc/xilinx-ai-engine/ai-engine-dev.c: In function 'aie_request_partition_from_id':
>> drivers/misc/xilinx-ai-engine/ai-engine-dev.c:165:2: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result [-Wunused-result]
165 | mutex_lock_interruptible(&adev->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-dev.c:175:2: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result [-Wunused-result]
175 | mutex_lock_interruptible(&apart->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-dev.c: In function 'aie_enquire_partitions':
drivers/misc/xilinx-ai-engine/ai-engine-dev.c:97:2: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result [-Wunused-result]
97 | mutex_lock_interruptible(&adev->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_release':
>> drivers/misc/xilinx-ai-engine/ai-engine-part.c:253:2: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result [-Wunused-result]
253 | mutex_lock_interruptible(&apart->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_ioctl':
drivers/misc/xilinx-ai-engine/ai-engine-part.c:366:3: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result [-Wunused-result]
366 | mutex_lock_interruptible(&apart->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_write_iter':
drivers/misc/xilinx-ai-engine/ai-engine-part.c:276:2: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result [-Wunused-result]
276 | mutex_lock_interruptible(&apart->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_read_iter':
drivers/misc/xilinx-ai-engine/ai-engine-part.c:296:2: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result [-Wunused-result]
296 | mutex_lock_interruptible(&apart->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'of_aie_part_probe':
drivers/misc/xilinx-ai-engine/ai-engine-part.c:514:2: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result [-Wunused-result]
514 | mutex_lock_interruptible(&adev->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_create_partition':
drivers/misc/xilinx-ai-engine/ai-engine-part.c:429:2: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result [-Wunused-result]
429 | mutex_lock_interruptible(&adev->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:476:2: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result [-Wunused-result]
476 | mutex_lock_interruptible(&adev->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_release_device':
drivers/misc/xilinx-ai-engine/ai-engine-part.c:401:2: warning: ignoring return value of 'mutex_lock_interruptible', declared with attribute warn_unused_result [-Wunused-result]
401 | mutex_lock_interruptible(&adev->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/mutex_lock_interruptible +165 drivers/misc/xilinx-ai-engine/ai-engine-dev.c
150
151 /**
152 * aie_request_partition_from_id() - request AI engine partition from id
153 * @adev: AI engine device
154 * @partition_id: partition id
155 * @return: partition pointer if partition exists, otherwise, NULL.
156 *
157 * This function finds a defined partition which matches the specified
158 * partition id, request it by increasing the refcount, and returns it.
159 */
160 struct aie_partition *aie_request_partition_from_id(struct aie_device *adev,
161 u32 partition_id)
162 {
163 struct aie_partition *apart;
164
> 165 mutex_lock_interruptible(&adev->mlock);
166 apart = aie_get_partition_from_id(adev, partition_id);
167 if (!apart) {
168 dev_err(&adev->dev,
169 "request partition %u failed, not exist.\n",
170 partition_id);
171 mutex_unlock(&adev->mlock);
172 return ERR_PTR(-EINVAL);
173 }
174
175 mutex_lock_interruptible(&apart->mlock);
176 if (apart->status & XAIE_PART_STATUS_INUSE) {
177 mutex_unlock(&apart->mlock);
178 dev_err(&adev->dev,
179 "request partition %u failed, partition in use.\n",
180 partition_id);
181 apart = ERR_PTR(-EBUSY);
182 } else {
183 /*
184 * TBD:
185 * 1. setup NOC AXI MM config to only generate error events
186 * for slave error and decode error.
187 * 2. scan to see which tiles have been clock gated.
188 *
189 * This needs to be done before the AI engine partition is
190 * exported for user to access.
191 */
192 apart->status = XAIE_PART_STATUS_INUSE;
193 mutex_unlock(&apart->mlock);
194 }
195 mutex_unlock(&adev->mlock);
196
197 return apart;
198 }
199
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[xlnx:master 16/20] include/media/hdr-ctrls.h:59:2: error: unknown type name '__u8'
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx master
head: 319e5bc767fe351a63744daa9cdd69b1915956d0
commit: 5591db926877ecdf1f61a995a5938f06d59c3588 [16/20] media: v4l: Add HDR support through compound controls
config: um-allmodconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
git checkout 5591db926877ecdf1f61a995a5938f06d59c3588
# save the attached .config to linux build tree
make W=1 ARCH=um
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
cc1: warning: arch/um/include/uapi: No such file or directory [-Wmissing-include-dirs]
In file included from <command-line>:
>> include/media/hdr-ctrls.h:59:2: error: unknown type name '__u8'
59 | __u8 eotf;
| ^~~~
include/media/hdr-ctrls.h:60:2: error: unknown type name '__u8'
60 | __u8 metadata_type;
| ^~~~
>> include/media/hdr-ctrls.h:62:3: error: unknown type name '__u16'
62 | __u16 x;
| ^~~~~
include/media/hdr-ctrls.h:63:3: error: unknown type name '__u16'
63 | __u16 y;
| ^~~~~
include/media/hdr-ctrls.h:66:3: error: unknown type name '__u16'
66 | __u16 x;
| ^~~~~
include/media/hdr-ctrls.h:67:3: error: unknown type name '__u16'
67 | __u16 y;
| ^~~~~
include/media/hdr-ctrls.h:69:2: error: unknown type name '__u16'
69 | __u16 max_mdl;
| ^~~~~
include/media/hdr-ctrls.h:70:2: error: unknown type name '__u16'
70 | __u16 min_mdl;
| ^~~~~
include/media/hdr-ctrls.h:71:2: error: unknown type name '__u16'
71 | __u16 max_cll;
| ^~~~~
include/media/hdr-ctrls.h:72:2: error: unknown type name '__u16'
72 | __u16 max_fall;
| ^~~~~
include/media/hdr-ctrls.h:83:2: error: unknown type name '__u16'
83 | __u16 metadata_type;
| ^~~~~
include/media/hdr-ctrls.h:84:2: error: unknown type name '__u16'
84 | __u16 size;
| ^~~~~
include/media/hdr-ctrls.h:86:2: error: unknown type name '__u8'
86 | __u8 payload[4000];
| ^~~~
vim +/__u8 +59 include/media/hdr-ctrls.h
45
46 /**
47 * struct v4l2_hdr10_payload - HDR Metadata Payload which matches CTA 861.G spec
48 *
49 * @eotf: Electro-Optical Transfer Function (EOTF)
50 * @metadata_type: Static_Metadata_Descriptor_ID
51 * @display_primaries: Color Primaries of the Data
52 * @white_point: White Point of Colorspace Data
53 * @max_mdl: Max Mastering Display Luminance
54 * @min_mdl: Min Mastering Display Luminance
55 * @max_cll: Max Content Light Level
56 * @max_fall: Max Frame Average Light Level
57 */
58 struct v4l2_hdr10_payload {
> 59 __u8 eotf;
60 __u8 metadata_type;
61 struct {
> 62 __u16 x;
63 __u16 y;
64 } display_primaries[3];
65 struct {
66 __u16 x;
67 __u16 y;
68 } white_point;
69 __u16 max_mdl;
70 __u16 min_mdl;
71 __u16 max_cll;
72 __u16 max_fall;
73 };
74
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[xlnx:master 12/20] drivers/misc/xilinx-ai-engine/ai-engine-fpga.c:21:2: note: in expansion of macro 'mutex_lock_interruptible'
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx master
head: 319e5bc767fe351a63744daa9cdd69b1915956d0
commit: e24d5dbb603552c4cb9c9e946c78055a60f83d85 [12/20] misc: ai-engine: Add FPGA bridge to AI engine partition
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
git checkout e24d5dbb603552c4cb9c9e946c78055a60f83d85
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from include/linux/kernfs.h:12,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/cdev.h:5,
from drivers/misc/xilinx-ai-engine/ai-engine-internal.h:12,
from drivers/misc/xilinx-ai-engine/ai-engine-fpga.c:8:
drivers/misc/xilinx-ai-engine/ai-engine-fpga.c: In function 'aie_fpga_bridge_enable_set':
include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/misc/xilinx-ai-engine/ai-engine-fpga.c:21:2: note: in expansion of macro 'mutex_lock_interruptible'
21 | mutex_lock_interruptible(&apart->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-fpga.c: In function 'aie_fpga_bridge_enable_show':
include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-fpga.c:35:2: note: in expansion of macro 'mutex_lock_interruptible'
35 | mutex_lock_interruptible(&apart->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/mutex_lock_interruptible +21 drivers/misc/xilinx-ai-engine/ai-engine-fpga.c
9
10 static int aie_fpga_bridge_enable_set(struct fpga_bridge *bridge, bool enable)
11 {
12 struct aie_partition *apart = bridge->priv;
13
14 /*
15 * TBD:
16 * "Enable" should enable the SHIM tile configuration.
17 * "Disable" should should disable SHIM DMAs, and wait
18 * until SHIM DMA stops, and disable SHIM
19 * to PL streams within partition.
20 */
> 21 mutex_lock_interruptible(&apart->mlock);
22 if (enable)
23 apart->status |= XAIE_PART_STATUS_BRIDGE_ENABLED;
24 else
25 apart->status &= ~XAIE_PART_STATUS_BRIDGE_ENABLED;
26 mutex_unlock(&apart->mlock);
27 return 0;
28 }
29
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[xlnx:master 10/20] include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx master
head: 319e5bc767fe351a63744daa9cdd69b1915956d0
commit: b4164ed1bbab5999a8b30dc25eaaa3200ff1fe59 [10/20] misc: ai-engine: Move AI engine reg access to kernel
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
git checkout b4164ed1bbab5999a8b30dc25eaaa3200ff1fe59
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from include/linux/kernfs.h:12,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/cdev.h:5,
from drivers/misc/xilinx-ai-engine/ai-engine-dev.c:9:
drivers/misc/xilinx-ai-engine/ai-engine-dev.c: In function 'aie_request_partition_from_id':
>> include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/misc/xilinx-ai-engine/ai-engine-dev.c:165:2: note: in expansion of macro 'mutex_lock_interruptible'
165 | mutex_lock_interruptible(&adev->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-dev.c:175:2: note: in expansion of macro 'mutex_lock_interruptible'
175 | mutex_lock_interruptible(&apart->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-dev.c: In function 'aie_enquire_partitions':
>> include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-dev.c:97:2: note: in expansion of macro 'mutex_lock_interruptible'
97 | mutex_lock_interruptible(&adev->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from include/linux/cdev.h:8,
from drivers/misc/xilinx-ai-engine/ai-engine-part.c:8:
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_reg_validation':
>> drivers/misc/xilinx-ai-engine/ai-engine-part.c:68:4: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
68 | "Invalid reg off(0x%lx), not 32bit aligned.n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1658:22: note: in definition of macro 'dev_fmt'
1658 | #define dev_fmt(fmt) fmt
| ^~~
>> drivers/misc/xilinx-ai-engine/ai-engine-part.c:67:3: note: in expansion of macro 'dev_err'
67 | dev_err(&apart->dev,
| ^~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:68:25: note: format string is defined here
68 | "Invalid reg off(0x%lx), not 32bit aligned.n",
| ~~^
| |
| long unsigned int
| %x
In file included from include/linux/cdev.h:8,
from drivers/misc/xilinx-ai-engine/ai-engine-part.c:8:
>> drivers/misc/xilinx-ai-engine/ai-engine-part.c:74:24: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
74 | dev_err(&apart->dev, "Invalid reg operation len %lu.n", len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1658:22: note: in definition of macro 'dev_fmt'
1658 | #define dev_fmt(fmt) fmt
| ^~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:74:3: note: in expansion of macro 'dev_err'
74 | dev_err(&apart->dev, "Invalid reg operation len %lu.n", len);
| ^~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:74:53: note: format string is defined here
74 | dev_err(&apart->dev, "Invalid reg operation len %lu.n", len);
| ~~^
| |
| long unsigned int
| %u
In file included from include/linux/cdev.h:8,
from drivers/misc/xilinx-ai-engine/ai-engine-part.c:8:
drivers/misc/xilinx-ai-engine/ai-engine-part.c:82:4: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
82 | "Invalid reg operation len %lu.n", len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1658:22: note: in definition of macro 'dev_fmt'
1658 | #define dev_fmt(fmt) fmt
| ^~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:81:3: note: in expansion of macro 'dev_err'
81 | dev_err(&apart->dev,
| ^~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:82:33: note: format string is defined here
82 | "Invalid reg operation len %lu.n", len);
| ~~^
| |
| long unsigned int
| %u
In file included from include/linux/cdev.h:8,
from drivers/misc/xilinx-ai-engine/ai-engine-part.c:8:
drivers/misc/xilinx-ai-engine/ai-engine-part.c:116:6: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
116 | "reg 0x%lx,0x%lx not writable.n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1658:22: note: in definition of macro 'dev_fmt'
1658 | #define dev_fmt(fmt) fmt
| ^~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:115:5: note: in expansion of macro 'dev_err'
115 | dev_err(&apart->dev,
| ^~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:116:15: note: format string is defined here
116 | "reg 0x%lx,0x%lx not writable.n",
| ~~^
| |
| long unsigned int
| %x
In file included from include/linux/cdev.h:8,
from drivers/misc/xilinx-ai-engine/ai-engine-part.c:8:
drivers/misc/xilinx-ai-engine/ai-engine-part.c:116:6: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
116 | "reg 0x%lx,0x%lx not writable.n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1658:22: note: in definition of macro 'dev_fmt'
1658 | #define dev_fmt(fmt) fmt
| ^~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:115:5: note: in expansion of macro 'dev_err'
115 | dev_err(&apart->dev,
| ^~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:116:21: note: format string is defined here
116 | "reg 0x%lx,0x%lx not writable.n",
| ~~^
| |
| long unsigned int
| %x
In file included from include/linux/cdev.h:8,
from drivers/misc/xilinx-ai-engine/ai-engine-part.c:8:
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_write_register':
drivers/misc/xilinx-ai-engine/ai-engine-part.c:153:24: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
153 | dev_err(&apart->dev, "failed to write to 0x%lx,0x%lx.n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1658:22: note: in definition of macro 'dev_fmt'
1658 | #define dev_fmt(fmt) fmt
| ^~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:153:3: note: in expansion of macro 'dev_err'
153 | dev_err(&apart->dev, "failed to write to 0x%lx,0x%lx.n",
| ^~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:153:48: note: format string is defined here
153 | dev_err(&apart->dev, "failed to write to 0x%lx,0x%lx.n",
| ~~^
| |
| long unsigned int
| %x
In file included from include/linux/cdev.h:8,
from drivers/misc/xilinx-ai-engine/ai-engine-part.c:8:
drivers/misc/xilinx-ai-engine/ai-engine-part.c:153:24: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
153 | dev_err(&apart->dev, "failed to write to 0x%lx,0x%lx.n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1658:22: note: in definition of macro 'dev_fmt'
1658 | #define dev_fmt(fmt) fmt
| ^~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:153:3: note: in expansion of macro 'dev_err'
153 | dev_err(&apart->dev, "failed to write to 0x%lx,0x%lx.n",
| ^~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:153:54: note: format string is defined here
153 | dev_err(&apart->dev, "failed to write to 0x%lx,0x%lx.n",
| ~~^
| |
| long unsigned int
| %x
In file included from include/linux/cdev.h:8,
from drivers/misc/xilinx-ai-engine/ai-engine-part.c:8:
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_read_register':
drivers/misc/xilinx-ai-engine/ai-engine-part.c:193:24: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
193 | dev_err(&apart->dev, "Invalid read request 0x%lx,0x%lx.n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1658:22: note: in definition of macro 'dev_fmt'
1658 | #define dev_fmt(fmt) fmt
| ^~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:193:3: note: in expansion of macro 'dev_err'
193 | dev_err(&apart->dev, "Invalid read request 0x%lx,0x%lx.n",
| ^~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:193:50: note: format string is defined here
193 | dev_err(&apart->dev, "Invalid read request 0x%lx,0x%lx.n",
| ~~^
| |
| long unsigned int
| %x
In file included from include/linux/cdev.h:8,
from drivers/misc/xilinx-ai-engine/ai-engine-part.c:8:
drivers/misc/xilinx-ai-engine/ai-engine-part.c:193:24: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
193 | dev_err(&apart->dev, "Invalid read request 0x%lx,0x%lx.n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:1658:22: note: in definition of macro 'dev_fmt'
1658 | #define dev_fmt(fmt) fmt
| ^~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:193:3: note: in expansion of macro 'dev_err'
193 | dev_err(&apart->dev, "Invalid read request 0x%lx,0x%lx.n",
| ^~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:193:56: note: format string is defined here
193 | dev_err(&apart->dev, "Invalid read request 0x%lx,0x%lx.n",
| ~~^
| |
| long unsigned int
| %x
In file included from include/linux/kernfs.h:12,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/cdev.h:5,
from drivers/misc/xilinx-ai-engine/ai-engine-part.c:8:
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_release':
>> include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/misc/xilinx-ai-engine/ai-engine-part.c:253:2: note: in expansion of macro 'mutex_lock_interruptible'
253 | mutex_lock_interruptible(&apart->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_ioctl':
>> include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:366:3: note: in expansion of macro 'mutex_lock_interruptible'
366 | mutex_lock_interruptible(&apart->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_write_iter':
>> include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:276:2: note: in expansion of macro 'mutex_lock_interruptible'
276 | mutex_lock_interruptible(&apart->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_read_iter':
>> include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:296:2: note: in expansion of macro 'mutex_lock_interruptible'
296 | mutex_lock_interruptible(&apart->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'of_aie_part_probe':
>> include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:514:2: note: in expansion of macro 'mutex_lock_interruptible'
514 | mutex_lock_interruptible(&adev->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_create_partition':
>> include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:429:2: note: in expansion of macro 'mutex_lock_interruptible'
429 | mutex_lock_interruptible(&adev->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:476:2: note: in expansion of macro 'mutex_lock_interruptible'
476 | mutex_lock_interruptible(&adev->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c: In function 'aie_part_release_device':
>> include/linux/mutex.h:154:40: warning: ignoring return value of 'mutex_lock_interruptible_nested', declared with attribute warn_unused_result [-Wunused-result]
154 | #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/xilinx-ai-engine/ai-engine-part.c:401:2: note: in expansion of macro 'mutex_lock_interruptible'
401 | mutex_lock_interruptible(&adev->mlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/mutex_lock_interruptible_nested +154 include/linux/mutex.h
e4564f79d4b692 Peter Zijlstra 2007-10-11 152
e4564f79d4b692 Peter Zijlstra 2007-10-11 153 #define mutex_lock(lock) mutex_lock_nested(lock, 0)
e4564f79d4b692 Peter Zijlstra 2007-10-11 @154 #define mutex_lock_interruptible(lock) mutex_lock_interruptible_nested(lock, 0)
ad776537cc6b4b Liam R. Howlett 2007-12-06 155 #define mutex_lock_killable(lock) mutex_lock_killable_nested(lock, 0)
1460cb65a10f6c Tejun Heo 2016-10-28 156 #define mutex_lock_io(lock) mutex_lock_io_nested(lock, 0)
e4c70a6629f9c7 Peter Zijlstra 2011-05-24 157
:::::: The code at line 154 was first introduced by commit
:::::: e4564f79d4b6923da7360df4b24a48cc2d4160de lockdep: fixup mutex annotations
:::::: TO: Peter Zijlstra <a.p.zijlstra(a)chello.nl>
:::::: CC: Peter Zijlstra <a.p.zijlstra(a)chello.nl>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:1884:21: sparse: sparse: incorrect type in argument 1 (different address spaces)
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1b5044021070efa3259f3e9548dc35d1eb6aa844
commit: 57430471e2fa60a412e220fa3014567e792aaa6f drm/amdgpu: Add support for USBC PD FW download
date: 4 months ago
config: riscv-randconfig-s032-20200618 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-rc1-10-gc17b1b06-dirty
git checkout 57430471e2fa60a412e220fa3014567e792aaa6f
# save the attached .config to linux build tree
make W=1 C=1 ARCH=riscv CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:160:9: sparse: sparse: incompatible types in conditional expression (different base types):
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:160:9: sparse: void
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:160:9: sparse: int
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:525:5: sparse: sparse: symbol 'psp_ta_invoke' was not declared. Should it be static?
>> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:1884:21: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void volatile [noderef] <asn:2> *addr @@ got void *[assigned] cpu_addr @@
>> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:1884:21: sparse: expected void volatile [noderef] <asn:2> *addr
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:1884:21: sparse: got void *[assigned] cpu_addr
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c:1887:9: sparse: sparse: undefined identifier 'clflush_cache_range'
vim +1884 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
1857
1858 static ssize_t psp_usbc_pd_fw_sysfs_write(struct device *dev,
1859 struct device_attribute *attr,
1860 const char *buf,
1861 size_t count)
1862 {
1863 struct drm_device *ddev = dev_get_drvdata(dev);
1864 struct amdgpu_device *adev = ddev->dev_private;
1865 void *cpu_addr;
1866 dma_addr_t dma_addr;
1867 int ret;
1868 char fw_name[100];
1869 const struct firmware *usbc_pd_fw;
1870
1871
1872 snprintf(fw_name, sizeof(fw_name), "amdgpu/%s", buf);
1873 ret = request_firmware(&usbc_pd_fw, fw_name, adev->dev);
1874 if (ret)
1875 goto fail;
1876
1877 /* We need contiguous physical mem to place the FW for psp to access */
1878 cpu_addr = dma_alloc_coherent(adev->dev, usbc_pd_fw->size, &dma_addr, GFP_KERNEL);
1879
1880 ret = dma_mapping_error(adev->dev, dma_addr);
1881 if (ret)
1882 goto rel_buf;
1883
> 1884 memcpy_toio(cpu_addr, usbc_pd_fw->data, usbc_pd_fw->size);
1885
1886 /*TODO Remove once PSP starts snooping CPU cache */
1887 clflush_cache_range(cpu_addr, (usbc_pd_fw->size & ~(L1_CACHE_BYTES - 1)));
1888
1889 mutex_lock(&adev->psp.mutex);
1890 ret = psp_load_usbc_pd_fw(&adev->psp, dma_addr);
1891 mutex_unlock(&adev->psp.mutex);
1892
1893 rel_buf:
1894 dma_free_coherent(adev->dev, usbc_pd_fw->size, cpu_addr, dma_addr);
1895 release_firmware(usbc_pd_fw);
1896
1897 fail:
1898 if (ret) {
1899 DRM_ERROR("Failed to load USBC PD FW, err = %d", ret);
1900 return ret;
1901 }
1902
1903 return count;
1904 }
1905
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
[bluetooth-next:master 5/14] net/bluetooth/mgmt.c:3932:9: sparse: sparse: cast to restricted __le32
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
head: 46605a271114f1243c807a55c607271c81e662d2
commit: 4c54bf2b093bb2ae95e756342646d868e8101cb4 [5/14] Bluetooth: Add get/set device flags mgmt op
config: c6x-randconfig-s032-20200618 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-rc1-10-gc17b1b06-dirty
git checkout 4c54bf2b093bb2ae95e756342646d868e8101cb4
# save the attached .config to linux build tree
make W=1 C=1 ARCH=c6x CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
net/bluetooth/mgmt.c:3605:29: sparse: sparse: restricted __le16 degrades to integer
>> net/bluetooth/mgmt.c:3932:9: sparse: sparse: cast to restricted __le32
vim +3932 net/bluetooth/mgmt.c
3921
3922 static int set_device_flags(struct sock *sk, struct hci_dev *hdev, void *data,
3923 u16 len)
3924 {
3925 struct mgmt_cp_set_device_flags *cp = data;
3926 struct bdaddr_list_with_flags *br_params;
3927 struct hci_conn_params *params;
3928 u8 status = MGMT_STATUS_INVALID_PARAMS;
3929 u32 supported_flags = SUPPORTED_DEVICE_FLAGS();
3930 u32 current_flags = __le32_to_cpu(cp->current_flags);
3931
> 3932 bt_dev_dbg(hdev, "Set device flags %pMR (type 0x%x) = 0x%x",
3933 &cp->addr.bdaddr, cp->addr.type,
3934 __le32_to_cpu(current_flags));
3935
3936 if ((supported_flags | current_flags) != supported_flags) {
3937 bt_dev_warn(hdev, "Bad flag given (0x%x) vs supported (0x%0x)",
3938 current_flags, supported_flags);
3939 goto done;
3940 }
3941
3942 if (cp->addr.type == BDADDR_BREDR) {
3943 br_params = hci_bdaddr_list_lookup_with_flags(&hdev->whitelist,
3944 &cp->addr.bdaddr,
3945 cp->addr.type);
3946
3947 if (br_params) {
3948 br_params->current_flags = current_flags;
3949 status = MGMT_STATUS_SUCCESS;
3950 } else {
3951 bt_dev_warn(hdev, "No such BR/EDR device %pMR (0x%x)",
3952 &cp->addr.bdaddr, cp->addr.type);
3953 }
3954 } else {
3955 params = hci_conn_params_lookup(hdev, &cp->addr.bdaddr,
3956 le_addr_type(cp->addr.type));
3957 if (params) {
3958 params->current_flags = current_flags;
3959 status = MGMT_STATUS_SUCCESS;
3960 } else {
3961 bt_dev_warn(hdev, "No such LE device %pMR (0x%x)",
3962 &cp->addr.bdaddr,
3963 le_addr_type(cp->addr.type));
3964 }
3965 }
3966
3967 done:
3968 if (status == MGMT_STATUS_SUCCESS)
3969 device_flags_changed(sk, hdev, &cp->addr.bdaddr, cp->addr.type,
3970 supported_flags, current_flags);
3971
3972 return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_SET_DEVICE_FLAGS, status,
3973 &cp->addr, sizeof(cp->addr));
3974 }
3975
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months