sound/soc/codecs/zl38060.c:614:34: warning: unused variable 'zl38_dt_ids'
by kernel test robot
Hi Sven,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 69119673bd50b176ded34032fadd41530fb5af21
commit: 52e8a94baf9026276fcdc9ff21a50dc2ca0bc94b ASoC: Add initial ZL38060 driver
date: 8 weeks ago
config: x86_64-randconfig-r003-20200617 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 487ca07fcc75d52755c9fe2ee05bcb3b6eeeec44)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 52e8a94baf9026276fcdc9ff21a50dc2ca0bc94b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> sound/soc/codecs/zl38060.c:614:34: warning: unused variable 'zl38_dt_ids' [-Wunused-const-variable]
static const struct of_device_id zl38_dt_ids[] = {
^
1 warning generated.
vim +/zl38_dt_ids +614 sound/soc/codecs/zl38060.c
613
> 614 static const struct of_device_id zl38_dt_ids[] = {
615 { .compatible = "mscc,zl38060", },
616 { /* sentinel */ }
617 };
618 MODULE_DEVICE_TABLE(of, zl38_dt_ids);
619
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
- 1
- 0
[linux-next:master 649/2089] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:1297:7: warning: variable 'viewport_changed' set but not used
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 5fcb9628fd1227a5f11d87171cb1b8b5c414d9d9
commit: 429b9db8e10eef6cdfbf2ecf27415bc79e2bee01 [649/2089] drm/amd/display: Remove nv12 work around
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
git checkout 429b9db8e10eef6cdfbf2ecf27415bc79e2bee01
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:1022:6: warning: no previous prototype for 'dcn20_enable_plane' [-Wmissing-prototypes]
1022 | void dcn20_enable_plane(
| ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c: In function 'dcn20_update_dchubp_dpp':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:1297:7: warning: variable 'viewport_changed' set but not used [-Wunused-but-set-variable]
1297 | bool viewport_changed = false;
| ^~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c: At top level:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:2097:6: warning: no previous prototype for 'dcn20_get_mpctree_visual_confirm_color' [-Wmissing-prototypes]
2097 | void dcn20_get_mpctree_visual_confirm_color(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:86,
from drivers/gpu/drm/amd/amdgpu/../display/dc/basics/dc_common.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:28:
drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw/dpp.h:50:42: warning: 'dpp_input_csc_matrix' defined but not used [-Wunused-const-variable=]
50 | static const struct dpp_input_csc_matrix dpp_input_csc_matrix[] = {
| ^~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:32,
from drivers/gpu/drm/amd/amdgpu/../display/dc/basics/dc_common.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:28:
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:124:22: warning: 'DP_DVI_CONVERTER_ID_4' defined but not used [-Wunused-const-variable=]
124 | static const uint8_t DP_DVI_CONVERTER_ID_4[] = "m2DVIa";
| ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:122:22: warning: 'DP_VGA_LVDS_CONVERTER_ID_3' defined but not used [-Wunused-const-variable=]
122 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_3[] = "dnomlA";
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:120:22: warning: 'DP_VGA_LVDS_CONVERTER_ID_2' defined but not used [-Wunused-const-variable=]
120 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_2[] = "sivarT";
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:33,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:37,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c:27:
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:76:32: warning: 'dc_fixpt_ln2_div_2' defined but not used [-Wunused-const-variable=]
76 | static const struct fixed31_32 dc_fixpt_ln2_div_2 = { 1488522236LL };
| ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:75:32: warning: 'dc_fixpt_ln2' defined but not used [-Wunused-const-variable=]
75 | static const struct fixed31_32 dc_fixpt_ln2 = { 2977044471LL };
| ^~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:74:32: warning: 'dc_fixpt_e' defined but not used [-Wunused-const-variable=]
74 | static const struct fixed31_32 dc_fixpt_e = { 11674931555LL };
| ^~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:73:32: warning: 'dc_fixpt_two_pi' defined but not used [-Wunused-const-variable=]
73 | static const struct fixed31_32 dc_fixpt_two_pi = { 26986075409LL };
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:72:32: warning: 'dc_fixpt_pi' defined but not used [-Wunused-const-variable=]
72 | static const struct fixed31_32 dc_fixpt_pi = { 13493037705LL };
| ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:67:32: warning: 'dc_fixpt_zero' defined but not used [-Wunused-const-variable=]
67 | static const struct fixed31_32 dc_fixpt_zero = { 0 };
| ^~~~~~~~~~~~~
vim +/viewport_changed +1297 drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1287
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1288 static void dcn20_update_dchubp_dpp(
7ed4e6352c16fe Harry Wentland 2019-02-22 1289 struct dc *dc,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1290 struct pipe_ctx *pipe_ctx,
7ed4e6352c16fe Harry Wentland 2019-02-22 1291 struct dc_state *context)
7ed4e6352c16fe Harry Wentland 2019-02-22 1292 {
f42ea55be11147 Anthony Koo 2019-11-05 1293 struct dce_hwseq *hws = dc->hwseq;
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1294 struct hubp *hubp = pipe_ctx->plane_res.hubp;
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1295 struct dpp *dpp = pipe_ctx->plane_res.dpp;
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1296 struct dc_plane_state *plane_state = pipe_ctx->plane_state;
cf27a6d15d950e Eric Yang 2019-11-18 @1297 bool viewport_changed = false;
7ed4e6352c16fe Harry Wentland 2019-02-22 1298
1ea8751bd28d1e Noah Abradjian 2019-09-27 1299 if (pipe_ctx->update_flags.bits.dppclk)
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1300 dpp->funcs->dpp_dppclk_control(dpp, false, true);
7ed4e6352c16fe Harry Wentland 2019-02-22 1301
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1302 /* TODO: Need input parameter to tell current DCHUB pipe tie to which OTG
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1303 * VTG is within DCHUBBUB which is commond block share by each pipe HUBP.
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1304 * VTG is 1:1 mapping with OTG. Each pipe HUBP will select which VTG
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1305 */
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1306 if (pipe_ctx->update_flags.bits.hubp_rq_dlg_ttu) {
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1307 hubp->funcs->hubp_vtg_sel(hubp, pipe_ctx->stream_res.tg->inst);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1308
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1309 hubp->funcs->hubp_setup(
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1310 hubp,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1311 &pipe_ctx->dlg_regs,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1312 &pipe_ctx->ttu_regs,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1313 &pipe_ctx->rq_regs,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1314 &pipe_ctx->pipe_dlg_param);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1315 }
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1316 if (pipe_ctx->update_flags.bits.hubp_interdependent)
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1317 hubp->funcs->hubp_setup_interdependent(
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1318 hubp,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1319 &pipe_ctx->dlg_regs,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1320 &pipe_ctx->ttu_regs);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1321
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1322 if (pipe_ctx->update_flags.bits.enable ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1323 plane_state->update_flags.bits.bpp_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1324 plane_state->update_flags.bits.input_csc_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1325 plane_state->update_flags.bits.color_space_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1326 plane_state->update_flags.bits.coeff_reduction_change) {
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1327 struct dc_bias_and_scale bns_params = {0};
21ffcc94d5b3dc Nicholas Kazlauskas 2019-07-11 1328
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1329 // program the input csc
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1330 dpp->funcs->dpp_setup(dpp,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1331 plane_state->format,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1332 EXPANSION_MODE_ZERO,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1333 plane_state->input_csc_color_matrix,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1334 plane_state->color_space,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1335 NULL);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1336
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1337 if (dpp->funcs->dpp_program_bias_and_scale) {
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1338 //TODO :for CNVC set scale and bias registers if necessary
78c7738211e027 Anthony Koo 2019-10-29 1339 build_prescale_params(&bns_params, plane_state);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1340 dpp->funcs->dpp_program_bias_and_scale(dpp, &bns_params);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1341 }
21ffcc94d5b3dc Nicholas Kazlauskas 2019-07-11 1342 }
21ffcc94d5b3dc Nicholas Kazlauskas 2019-07-11 1343
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1344 if (pipe_ctx->update_flags.bits.mpcc
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1345 || plane_state->update_flags.bits.global_alpha_change
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1346 || plane_state->update_flags.bits.per_pixel_alpha_change) {
8b0fbb368c96df Noah Abradjian 2019-11-13 1347 // MPCC inst is equal to pipe index in practice
1380c1bf5b9c31 Noah Abradjian 2019-11-29 1348 int mpcc_inst = hubp->inst;
8b0fbb368c96df Noah Abradjian 2019-11-13 1349 int opp_inst;
0120e8b8451c6a Noah Abradjian 2019-11-22 1350 int opp_count = dc->res_pool->pipe_count;
8b0fbb368c96df Noah Abradjian 2019-11-13 1351
8b0fbb368c96df Noah Abradjian 2019-11-13 1352 for (opp_inst = 0; opp_inst < opp_count; opp_inst++) {
8b0fbb368c96df Noah Abradjian 2019-11-13 1353 if (dc->res_pool->opps[opp_inst]->mpcc_disconnect_pending[mpcc_inst]) {
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1354 dc->res_pool->mpc->funcs->wait_for_idle(dc->res_pool->mpc, mpcc_inst);
8b0fbb368c96df Noah Abradjian 2019-11-13 1355 dc->res_pool->opps[opp_inst]->mpcc_disconnect_pending[mpcc_inst] = false;
8b0fbb368c96df Noah Abradjian 2019-11-13 1356 break;
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1357 }
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1358 }
f42ea55be11147 Anthony Koo 2019-11-05 1359 hws->funcs.update_mpcc(dc, pipe_ctx);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1360 }
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1361
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1362 if (pipe_ctx->update_flags.bits.scaler ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1363 plane_state->update_flags.bits.scaling_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1364 plane_state->update_flags.bits.position_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1365 plane_state->update_flags.bits.per_pixel_alpha_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1366 pipe_ctx->stream->update_flags.bits.scaling) {
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1367 pipe_ctx->plane_res.scl_data.lb_params.alpha_en = pipe_ctx->plane_state->per_pixel_alpha;
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1368 ASSERT(pipe_ctx->plane_res.scl_data.lb_params.depth == LB_PIXEL_DEPTH_30BPP);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1369 /* scaler configuration */
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1370 pipe_ctx->plane_res.dpp->funcs->dpp_set_scaler(
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1371 pipe_ctx->plane_res.dpp, &pipe_ctx->plane_res.scl_data);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1372 }
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1373
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1374 if (pipe_ctx->update_flags.bits.viewport ||
b34659deb66bfe Nicholas Kazlauskas 2020-04-05 1375 (context == dc->current_state && plane_state->update_flags.bits.position_change) ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1376 (context == dc->current_state && plane_state->update_flags.bits.scaling_change) ||
cf27a6d15d950e Eric Yang 2019-11-18 1377 (context == dc->current_state && pipe_ctx->stream->update_flags.bits.scaling)) {
cf27a6d15d950e Eric Yang 2019-11-18 1378
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1379 hubp->funcs->mem_program_viewport(
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1380 hubp,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1381 &pipe_ctx->plane_res.scl_data.viewport,
cf27a6d15d950e Eric Yang 2019-11-18 1382 &pipe_ctx->plane_res.scl_data.viewport_c);
cf27a6d15d950e Eric Yang 2019-11-18 1383 viewport_changed = true;
cf27a6d15d950e Eric Yang 2019-11-18 1384 }
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1385
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1386 /* Any updates are handled in dc interface, just need to apply existing for plane enable */
74cc5f02eb67c1 Aric Cyr 2019-11-23 1387 if ((pipe_ctx->update_flags.bits.enable || pipe_ctx->update_flags.bits.opp_changed ||
74cc5f02eb67c1 Aric Cyr 2019-11-23 1388 pipe_ctx->update_flags.bits.scaler || pipe_ctx->update_flags.bits.viewport)
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1389 && pipe_ctx->stream->cursor_attributes.address.quad_part != 0) {
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1390 dc->hwss.set_cursor_position(pipe_ctx);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1391 dc->hwss.set_cursor_attribute(pipe_ctx);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1392
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1393 if (dc->hwss.set_cursor_sdr_white_level)
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1394 dc->hwss.set_cursor_sdr_white_level(pipe_ctx);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1395 }
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1396
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1397 /* Any updates are handled in dc interface, just need
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1398 * to apply existing for plane enable / opp change */
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1399 if (pipe_ctx->update_flags.bits.enable || pipe_ctx->update_flags.bits.opp_changed
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1400 || pipe_ctx->stream->update_flags.bits.gamut_remap
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1401 || pipe_ctx->stream->update_flags.bits.out_csc) {
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1402 /* dpp/cm gamut remap*/
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1403 dc->hwss.program_gamut_remap(pipe_ctx);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1404
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1405 /*call the dcn2 method which uses mpc csc*/
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1406 dc->hwss.program_output_csc(dc,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1407 pipe_ctx,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1408 pipe_ctx->stream->output_color_space,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1409 pipe_ctx->stream->csc_color_matrix.matrix,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1410 hubp->opp_id);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1411 }
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1412
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1413 if (pipe_ctx->update_flags.bits.enable ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1414 pipe_ctx->update_flags.bits.opp_changed ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1415 plane_state->update_flags.bits.pixel_format_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1416 plane_state->update_flags.bits.horizontal_mirror_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1417 plane_state->update_flags.bits.rotation_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1418 plane_state->update_flags.bits.swizzle_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1419 plane_state->update_flags.bits.dcc_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1420 plane_state->update_flags.bits.bpp_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1421 plane_state->update_flags.bits.scaling_change ||
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1422 plane_state->update_flags.bits.plane_size_change) {
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1423 struct plane_size size = plane_state->plane_size;
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1424
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1425 size.surface_size = pipe_ctx->plane_res.scl_data.viewport;
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1426 hubp->funcs->hubp_program_surface_config(
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1427 hubp,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1428 plane_state->format,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1429 &plane_state->tiling_info,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1430 &size,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1431 plane_state->rotation,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1432 &plane_state->dcc,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1433 plane_state->horizontal_mirror,
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1434 0);
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1435 hubp->power_gated = false;
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1436 }
4e0cbbbfbc37fd Leo Li 2019-03-20 1437
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1438 if (pipe_ctx->update_flags.bits.enable || plane_state->update_flags.bits.addr_update)
f42ea55be11147 Anthony Koo 2019-11-05 1439 hws->funcs.update_plane_addr(dc, pipe_ctx);
7ed4e6352c16fe Harry Wentland 2019-02-22 1440
cf27a6d15d950e Eric Yang 2019-11-18 1441
cf27a6d15d950e Eric Yang 2019-11-18 1442
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1443 if (pipe_ctx->update_flags.bits.enable)
b6e881c947417e Dmytro Laktyushkin 2019-09-13 1444 hubp->funcs->set_blank(hubp, false);
7ed4e6352c16fe Harry Wentland 2019-02-22 1445 }
7ed4e6352c16fe Harry Wentland 2019-02-22 1446
:::::: The code at line 1297 was first introduced by commit
:::::: cf27a6d15d950ed1beb3926469c9eaa6907bbf88 drm/amd/display: update chroma viewport wa
:::::: TO: Eric Yang <Eric.Yang2(a)amd.com>
:::::: CC: Alex Deucher <alexander.deucher(a)amd.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
- 1
- 0
fs/ntfs/file.c:1730:16: warning: stack frame size of 1040 bytes in function 'ntfs_perform_write'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 69119673bd50b176ded34032fadd41530fb5af21
commit: abca2500c0c1b20c3e552f259da4c4a99db3b4d1 arch/kunmap_atomic: consolidate duplicate code
date: 12 days ago
config: mips-randconfig-r013-20200617 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 487ca07fcc75d52755c9fe2ee05bcb3b6eeeec44)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
git checkout abca2500c0c1b20c3e552f259da4c4a99db3b4d1
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> fs/ntfs/file.c:1730:16: warning: stack frame size of 1040 bytes in function 'ntfs_perform_write' [-Wframe-larger-than=]
static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i,
^
1 warning generated.
vim +/ntfs_perform_write +1730 fs/ntfs/file.c
9014da7525dffe Marco Stornelli 2012-12-15 1723
98b270362bb9ea Anton Altaparmakov 2005-10-11 1724 /**
a632f559304130 Anton Altaparmakov 2015-03-11 1725 * ntfs_perform_write - perform buffered write to a file
a632f559304130 Anton Altaparmakov 2015-03-11 1726 * @file: file to write to
a632f559304130 Anton Altaparmakov 2015-03-11 1727 * @i: iov_iter with data to write
a632f559304130 Anton Altaparmakov 2015-03-11 1728 * @pos: byte offset in file at which to begin writing to
98b270362bb9ea Anton Altaparmakov 2005-10-11 1729 */
a632f559304130 Anton Altaparmakov 2015-03-11 @1730 static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i,
a632f559304130 Anton Altaparmakov 2015-03-11 1731 loff_t pos)
98b270362bb9ea Anton Altaparmakov 2005-10-11 1732 {
98b270362bb9ea Anton Altaparmakov 2005-10-11 1733 struct address_space *mapping = file->f_mapping;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1734 struct inode *vi = mapping->host;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1735 ntfs_inode *ni = NTFS_I(vi);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1736 ntfs_volume *vol = ni->vol;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1737 struct page *pages[NTFS_MAX_PAGES_PER_CLUSTER];
98b270362bb9ea Anton Altaparmakov 2005-10-11 1738 struct page *cached_page = NULL;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1739 VCN last_vcn;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1740 LCN lcn;
a632f559304130 Anton Altaparmakov 2015-03-11 1741 size_t bytes;
a632f559304130 Anton Altaparmakov 2015-03-11 1742 ssize_t status, written = 0;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1743 unsigned nr_pages;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1744
a632f559304130 Anton Altaparmakov 2015-03-11 1745 ntfs_debug("Entering for i_ino 0x%lx, attribute type 0x%x, pos "
a632f559304130 Anton Altaparmakov 2015-03-11 1746 "0x%llx, count 0x%lx.", vi->i_ino,
a632f559304130 Anton Altaparmakov 2015-03-11 1747 (unsigned)le32_to_cpu(ni->type),
a632f559304130 Anton Altaparmakov 2015-03-11 1748 (unsigned long long)pos,
a632f559304130 Anton Altaparmakov 2015-03-11 1749 (unsigned long)iov_iter_count(i));
98b270362bb9ea Anton Altaparmakov 2005-10-11 1750 /*
98b270362bb9ea Anton Altaparmakov 2005-10-11 1751 * If a previous ntfs_truncate() failed, repeat it and abort if it
98b270362bb9ea Anton Altaparmakov 2005-10-11 1752 * fails again.
98b270362bb9ea Anton Altaparmakov 2005-10-11 1753 */
98b270362bb9ea Anton Altaparmakov 2005-10-11 1754 if (unlikely(NInoTruncateFailed(ni))) {
a632f559304130 Anton Altaparmakov 2015-03-11 1755 int err;
a632f559304130 Anton Altaparmakov 2015-03-11 1756
bd5fe6c5eb9c54 Christoph Hellwig 2011-06-24 1757 inode_dio_wait(vi);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1758 err = ntfs_truncate(vi);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1759 if (err || NInoTruncateFailed(ni)) {
98b270362bb9ea Anton Altaparmakov 2005-10-11 1760 if (!err)
98b270362bb9ea Anton Altaparmakov 2005-10-11 1761 err = -EIO;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1762 ntfs_error(vol->sb, "Cannot perform write to inode "
98b270362bb9ea Anton Altaparmakov 2005-10-11 1763 "0x%lx, attribute type 0x%x, because "
98b270362bb9ea Anton Altaparmakov 2005-10-11 1764 "ntfs_truncate() failed (error code "
98b270362bb9ea Anton Altaparmakov 2005-10-11 1765 "%i).", vi->i_ino,
98b270362bb9ea Anton Altaparmakov 2005-10-11 1766 (unsigned)le32_to_cpu(ni->type), err);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1767 return err;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1768 }
98b270362bb9ea Anton Altaparmakov 2005-10-11 1769 }
98b270362bb9ea Anton Altaparmakov 2005-10-11 1770 /*
98b270362bb9ea Anton Altaparmakov 2005-10-11 1771 * Determine the number of pages per cluster for non-resident
98b270362bb9ea Anton Altaparmakov 2005-10-11 1772 * attributes.
98b270362bb9ea Anton Altaparmakov 2005-10-11 1773 */
98b270362bb9ea Anton Altaparmakov 2005-10-11 1774 nr_pages = 1;
09cbfeaf1a5a67 Kirill A. Shutemov 2016-04-01 1775 if (vol->cluster_size > PAGE_SIZE && NInoNonResident(ni))
09cbfeaf1a5a67 Kirill A. Shutemov 2016-04-01 1776 nr_pages = vol->cluster_size >> PAGE_SHIFT;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1777 last_vcn = -1;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1778 do {
98b270362bb9ea Anton Altaparmakov 2005-10-11 1779 VCN vcn;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1780 pgoff_t idx, start_idx;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1781 unsigned ofs, do_pages, u;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1782 size_t copied;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1783
09cbfeaf1a5a67 Kirill A. Shutemov 2016-04-01 1784 start_idx = idx = pos >> PAGE_SHIFT;
09cbfeaf1a5a67 Kirill A. Shutemov 2016-04-01 1785 ofs = pos & ~PAGE_MASK;
09cbfeaf1a5a67 Kirill A. Shutemov 2016-04-01 1786 bytes = PAGE_SIZE - ofs;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1787 do_pages = 1;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1788 if (nr_pages > 1) {
98b270362bb9ea Anton Altaparmakov 2005-10-11 1789 vcn = pos >> vol->cluster_size_bits;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1790 if (vcn != last_vcn) {
98b270362bb9ea Anton Altaparmakov 2005-10-11 1791 last_vcn = vcn;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1792 /*
98b270362bb9ea Anton Altaparmakov 2005-10-11 1793 * Get the lcn of the vcn the write is in. If
98b270362bb9ea Anton Altaparmakov 2005-10-11 1794 * it is a hole, need to lock down all pages in
98b270362bb9ea Anton Altaparmakov 2005-10-11 1795 * the cluster.
98b270362bb9ea Anton Altaparmakov 2005-10-11 1796 */
98b270362bb9ea Anton Altaparmakov 2005-10-11 1797 down_read(&ni->runlist.lock);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1798 lcn = ntfs_attr_vcn_to_lcn_nolock(ni, pos >>
c49c31115067bc Richard Knutsson 2006-09-30 1799 vol->cluster_size_bits, false);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1800 up_read(&ni->runlist.lock);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1801 if (unlikely(lcn < LCN_HOLE)) {
98b270362bb9ea Anton Altaparmakov 2005-10-11 1802 if (lcn == LCN_ENOMEM)
98b270362bb9ea Anton Altaparmakov 2005-10-11 1803 status = -ENOMEM;
a632f559304130 Anton Altaparmakov 2015-03-11 1804 else {
a632f559304130 Anton Altaparmakov 2015-03-11 1805 status = -EIO;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1806 ntfs_error(vol->sb, "Cannot "
98b270362bb9ea Anton Altaparmakov 2005-10-11 1807 "perform write to "
98b270362bb9ea Anton Altaparmakov 2005-10-11 1808 "inode 0x%lx, "
98b270362bb9ea Anton Altaparmakov 2005-10-11 1809 "attribute type 0x%x, "
98b270362bb9ea Anton Altaparmakov 2005-10-11 1810 "because the attribute "
98b270362bb9ea Anton Altaparmakov 2005-10-11 1811 "is corrupt.",
98b270362bb9ea Anton Altaparmakov 2005-10-11 1812 vi->i_ino, (unsigned)
98b270362bb9ea Anton Altaparmakov 2005-10-11 1813 le32_to_cpu(ni->type));
a632f559304130 Anton Altaparmakov 2015-03-11 1814 }
98b270362bb9ea Anton Altaparmakov 2005-10-11 1815 break;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1816 }
98b270362bb9ea Anton Altaparmakov 2005-10-11 1817 if (lcn == LCN_HOLE) {
98b270362bb9ea Anton Altaparmakov 2005-10-11 1818 start_idx = (pos & ~(s64)
98b270362bb9ea Anton Altaparmakov 2005-10-11 1819 vol->cluster_size_mask)
09cbfeaf1a5a67 Kirill A. Shutemov 2016-04-01 1820 >> PAGE_SHIFT;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1821 bytes = vol->cluster_size - (pos &
98b270362bb9ea Anton Altaparmakov 2005-10-11 1822 vol->cluster_size_mask);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1823 do_pages = nr_pages;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1824 }
98b270362bb9ea Anton Altaparmakov 2005-10-11 1825 }
98b270362bb9ea Anton Altaparmakov 2005-10-11 1826 }
a632f559304130 Anton Altaparmakov 2015-03-11 1827 if (bytes > iov_iter_count(i))
a632f559304130 Anton Altaparmakov 2015-03-11 1828 bytes = iov_iter_count(i);
a632f559304130 Anton Altaparmakov 2015-03-11 1829 again:
98b270362bb9ea Anton Altaparmakov 2005-10-11 1830 /*
98b270362bb9ea Anton Altaparmakov 2005-10-11 1831 * Bring in the user page(s) that we will copy from _first_.
98b270362bb9ea Anton Altaparmakov 2005-10-11 1832 * Otherwise there is a nasty deadlock on copying from the same
98b270362bb9ea Anton Altaparmakov 2005-10-11 1833 * page(s) as we are writing to, without it/them being marked
98b270362bb9ea Anton Altaparmakov 2005-10-11 1834 * up-to-date. Note, at present there is nothing to stop the
98b270362bb9ea Anton Altaparmakov 2005-10-11 1835 * pages being swapped out between us bringing them into memory
98b270362bb9ea Anton Altaparmakov 2005-10-11 1836 * and doing the actual copying.
98b270362bb9ea Anton Altaparmakov 2005-10-11 1837 */
4bce9f6ee8f84f Al Viro 2016-09-17 1838 if (unlikely(iov_iter_fault_in_readable(i, bytes))) {
a632f559304130 Anton Altaparmakov 2015-03-11 1839 status = -EFAULT;
a632f559304130 Anton Altaparmakov 2015-03-11 1840 break;
a632f559304130 Anton Altaparmakov 2015-03-11 1841 }
98b270362bb9ea Anton Altaparmakov 2005-10-11 1842 /* Get and lock @do_pages starting at index @start_idx. */
98b270362bb9ea Anton Altaparmakov 2005-10-11 1843 status = __ntfs_grab_cache_pages(mapping, start_idx, do_pages,
4c99000ac47cbd Minchan Kim 2010-05-24 1844 pages, &cached_page);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1845 if (unlikely(status))
98b270362bb9ea Anton Altaparmakov 2005-10-11 1846 break;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1847 /*
98b270362bb9ea Anton Altaparmakov 2005-10-11 1848 * For non-resident attributes, we need to fill any holes with
98b270362bb9ea Anton Altaparmakov 2005-10-11 1849 * actual clusters and ensure all bufferes are mapped. We also
98b270362bb9ea Anton Altaparmakov 2005-10-11 1850 * need to bring uptodate any buffers that are only partially
98b270362bb9ea Anton Altaparmakov 2005-10-11 1851 * being written to.
98b270362bb9ea Anton Altaparmakov 2005-10-11 1852 */
98b270362bb9ea Anton Altaparmakov 2005-10-11 1853 if (NInoNonResident(ni)) {
98b270362bb9ea Anton Altaparmakov 2005-10-11 1854 status = ntfs_prepare_pages_for_non_resident_write(
98b270362bb9ea Anton Altaparmakov 2005-10-11 1855 pages, do_pages, pos, bytes);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1856 if (unlikely(status)) {
98b270362bb9ea Anton Altaparmakov 2005-10-11 1857 do {
98b270362bb9ea Anton Altaparmakov 2005-10-11 1858 unlock_page(pages[--do_pages]);
09cbfeaf1a5a67 Kirill A. Shutemov 2016-04-01 1859 put_page(pages[do_pages]);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1860 } while (do_pages);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1861 break;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1862 }
98b270362bb9ea Anton Altaparmakov 2005-10-11 1863 }
09cbfeaf1a5a67 Kirill A. Shutemov 2016-04-01 1864 u = (pos >> PAGE_SHIFT) - pages[0]->index;
a632f559304130 Anton Altaparmakov 2015-03-11 1865 copied = ntfs_copy_from_user_iter(pages + u, do_pages - u, ofs,
a632f559304130 Anton Altaparmakov 2015-03-11 1866 i, bytes);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1867 ntfs_flush_dcache_pages(pages + u, do_pages - u);
a632f559304130 Anton Altaparmakov 2015-03-11 1868 status = 0;
a632f559304130 Anton Altaparmakov 2015-03-11 1869 if (likely(copied == bytes)) {
a632f559304130 Anton Altaparmakov 2015-03-11 1870 status = ntfs_commit_pages_after_write(pages, do_pages,
a632f559304130 Anton Altaparmakov 2015-03-11 1871 pos, bytes);
a632f559304130 Anton Altaparmakov 2015-03-11 1872 if (!status)
a632f559304130 Anton Altaparmakov 2015-03-11 1873 status = bytes;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1874 }
98b270362bb9ea Anton Altaparmakov 2005-10-11 1875 do {
98b270362bb9ea Anton Altaparmakov 2005-10-11 1876 unlock_page(pages[--do_pages]);
09cbfeaf1a5a67 Kirill A. Shutemov 2016-04-01 1877 put_page(pages[do_pages]);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1878 } while (do_pages);
a632f559304130 Anton Altaparmakov 2015-03-11 1879 if (unlikely(status < 0))
98b270362bb9ea Anton Altaparmakov 2005-10-11 1880 break;
a632f559304130 Anton Altaparmakov 2015-03-11 1881 copied = status;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1882 cond_resched();
a632f559304130 Anton Altaparmakov 2015-03-11 1883 if (unlikely(!copied)) {
a632f559304130 Anton Altaparmakov 2015-03-11 1884 size_t sc;
a632f559304130 Anton Altaparmakov 2015-03-11 1885
a632f559304130 Anton Altaparmakov 2015-03-11 1886 /*
a632f559304130 Anton Altaparmakov 2015-03-11 1887 * We failed to copy anything. Fall back to single
a632f559304130 Anton Altaparmakov 2015-03-11 1888 * segment length write.
a632f559304130 Anton Altaparmakov 2015-03-11 1889 *
a632f559304130 Anton Altaparmakov 2015-03-11 1890 * This is needed to avoid possible livelock in the
a632f559304130 Anton Altaparmakov 2015-03-11 1891 * case that all segments in the iov cannot be copied
a632f559304130 Anton Altaparmakov 2015-03-11 1892 * at once without a pagefault.
a632f559304130 Anton Altaparmakov 2015-03-11 1893 */
a632f559304130 Anton Altaparmakov 2015-03-11 1894 sc = iov_iter_single_seg_count(i);
a632f559304130 Anton Altaparmakov 2015-03-11 1895 if (bytes > sc)
a632f559304130 Anton Altaparmakov 2015-03-11 1896 bytes = sc;
a632f559304130 Anton Altaparmakov 2015-03-11 1897 goto again;
a632f559304130 Anton Altaparmakov 2015-03-11 1898 }
a632f559304130 Anton Altaparmakov 2015-03-11 1899 iov_iter_advance(i, copied);
a632f559304130 Anton Altaparmakov 2015-03-11 1900 pos += copied;
a632f559304130 Anton Altaparmakov 2015-03-11 1901 written += copied;
a632f559304130 Anton Altaparmakov 2015-03-11 1902 balance_dirty_pages_ratelimited(mapping);
a632f559304130 Anton Altaparmakov 2015-03-11 1903 if (fatal_signal_pending(current)) {
a632f559304130 Anton Altaparmakov 2015-03-11 1904 status = -EINTR;
a632f559304130 Anton Altaparmakov 2015-03-11 1905 break;
a632f559304130 Anton Altaparmakov 2015-03-11 1906 }
a632f559304130 Anton Altaparmakov 2015-03-11 1907 } while (iov_iter_count(i));
98b270362bb9ea Anton Altaparmakov 2005-10-11 1908 if (cached_page)
09cbfeaf1a5a67 Kirill A. Shutemov 2016-04-01 1909 put_page(cached_page);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1910 ntfs_debug("Done. Returning %s (written 0x%lx, status %li).",
98b270362bb9ea Anton Altaparmakov 2005-10-11 1911 written ? "written" : "status", (unsigned long)written,
98b270362bb9ea Anton Altaparmakov 2005-10-11 1912 (long)status);
98b270362bb9ea Anton Altaparmakov 2005-10-11 1913 return written ? written : status;
98b270362bb9ea Anton Altaparmakov 2005-10-11 1914 }
98b270362bb9ea Anton Altaparmakov 2005-10-11 1915
:::::: The code at line 1730 was first introduced by commit
:::::: a632f5593041305c8adbf4727bc1ccdf0b45178b NTFS: Version 2.1.32 - Update file write from aio_write to write_iter.
:::::: TO: Anton Altaparmakov <anton(a)tuxera.com>
:::::: CC: Al Viro <viro(a)zeniv.linux.org.uk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
- 1
- 0
[peterz-queue:x86/entry 5/8] include/linux/compiler-gcc.h:153:5: note: in expansion of macro '__has_attribute'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git x86/entry
head: 8e8bb06d199a5aa7a534aa3b3fc0abbbc11ca438
commit: 5144f8a8dfd7b3681f0a2b5bf599a210b2315018 [5/8] compiler_types.h: Add __no_sanitize_{address,undefined} to noinstr
config: i386-randconfig-a006-20200615 (attached as .config)
compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
reproduce (this is a W=1 build):
git checkout 5144f8a8dfd7b3681f0a2b5bf599a210b2315018
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from include/linux/compiler_types.h:59:0,
from <command-line>:0:
>> include/linux/compiler_attributes.h:35:29: warning: "__GCC4_has_attribute___no_sanitize_undefined__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
>> include/linux/compiler-gcc.h:153:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__no_sanitize_undefined__)
^
--
In file included from include/linux/compiler_types.h:59:0,
from <command-line>:0:
>> include/linux/compiler_attributes.h:35:29: warning: "__GCC4_has_attribute___no_sanitize_undefined__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
>> include/linux/compiler-gcc.h:153:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__no_sanitize_undefined__)
^
drivers/xen/xenbus/xenbus_client.c: In function 'xenbus_va_dev_error':
drivers/xen/xenbus/xenbus_client.c:276:2: warning: function might be possible candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
vsnprintf(printf_buffer + len, PRINTF_BUFFER_SIZE - len, fmt, ap);
^
--
In file included from include/linux/compiler_types.h:59:0,
from <command-line>:0:
>> include/linux/compiler_attributes.h:35:29: warning: "__GCC4_has_attribute___no_sanitize_undefined__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
>> include/linux/compiler-gcc.h:153:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__no_sanitize_undefined__)
^
lib/math/div64.c:29:32: warning: no previous prototype for '__div64_32' [-Wmissing-prototypes]
uint32_t __attribute__((weak)) __div64_32(uint64_t *n, uint32_t base)
^
--
In file included from include/linux/compiler_types.h:59:0,
from <command-line>:0:
>> include/linux/compiler_attributes.h:35:29: warning: "__GCC4_has_attribute___no_sanitize_undefined__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
>> include/linux/compiler-gcc.h:153:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__no_sanitize_undefined__)
^
drivers/regulator/core.c:3805:5: warning: no previous prototype for 'regulator_suspend_enable' [-Wmissing-prototypes]
int regulator_suspend_enable(struct regulator_dev *rdev,
^
drivers/regulator/core.c:3812:5: warning: no previous prototype for 'regulator_suspend_disable' [-Wmissing-prototypes]
int regulator_suspend_disable(struct regulator_dev *rdev,
^
drivers/regulator/core.c:3851:5: warning: no previous prototype for 'regulator_set_suspend_voltage' [-Wmissing-prototypes]
int regulator_set_suspend_voltage(struct regulator *regulator, int min_uV,
^
--
In file included from include/linux/compiler_types.h:59:0,
from <command-line>:0:
>> include/linux/compiler_attributes.h:35:29: warning: "__GCC4_has_attribute___no_sanitize_undefined__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
>> include/linux/compiler-gcc.h:153:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__no_sanitize_undefined__)
^
drivers/regulator/da9063-regulator.c:515:3: warning: initialized field overwritten [-Woverride-init]
.suspend = BFIELD(DA9063_REG_LDO9_CONT, DA9063_VLDO9_SEL),
^
drivers/regulator/da9063-regulator.c:515:3: warning: (near initialization for 'da9063_regulator_info[11].suspend') [-Woverride-init]
--
In file included from include/linux/compiler_types.h:59:0,
from <command-line>:0:
>> include/linux/compiler_attributes.h:35:29: warning: "__GCC4_has_attribute___no_sanitize_undefined__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
>> include/linux/compiler-gcc.h:153:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__no_sanitize_undefined__)
^
drivers/regulator/tps65218-regulator.c: In function 'tps65218_pmic_set_suspend_enable':
drivers/regulator/tps65218-regulator.c:131:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1)
^
drivers/regulator/tps65218-regulator.c: In function 'tps65218_pmic_set_suspend_disable':
drivers/regulator/tps65218-regulator.c:144:10: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1)
^
--
In file included from include/linux/compiler_types.h:59:0,
from <command-line>:0:
>> include/linux/compiler_attributes.h:35:29: warning: "__GCC4_has_attribute___no_sanitize_undefined__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
>> include/linux/compiler-gcc.h:153:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__no_sanitize_undefined__)
^
arch/x86/lib/cmdline.c:204:5: warning: no previous prototype for 'cmdline_find_option_bool' [-Wmissing-prototypes]
int cmdline_find_option_bool(const char *cmdline, const char *option)
^
arch/x86/lib/cmdline.c:209:5: warning: no previous prototype for 'cmdline_find_option' [-Wmissing-prototypes]
int cmdline_find_option(const char *cmdline, const char *option, char *buffer,
^
--
In file included from include/linux/compiler_types.h:59:0,
from <command-line>:0:
>> include/linux/compiler_attributes.h:35:29: warning: "__GCC4_has_attribute___no_sanitize_undefined__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
>> include/linux/compiler-gcc.h:153:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__no_sanitize_undefined__)
^
arch/x86/lib/misc.c:7:5: warning: no previous prototype for 'num_digits' [-Wmissing-prototypes]
int num_digits(int val)
^
--
In file included from include/linux/compiler_types.h:59:0,
from <command-line>:0:
>> include/linux/compiler_attributes.h:35:29: warning: "__GCC4_has_attribute___no_sanitize_undefined__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
>> include/linux/compiler-gcc.h:153:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__no_sanitize_undefined__)
^
arch/x86/lib/msr.c:39:5: warning: no previous prototype for 'msr_read' [-Wmissing-prototypes]
int msr_read(u32 msr, struct msr *m)
^
arch/x86/lib/msr.c:57:5: warning: no previous prototype for 'msr_write' [-Wmissing-prototypes]
int msr_write(u32 msr, struct msr *m)
^
--
In file included from include/linux/compiler_types.h:59:0,
from <command-line>:0:
>> include/linux/compiler_attributes.h:35:29: warning: "__GCC4_has_attribute___no_sanitize_undefined__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
>> include/linux/compiler-gcc.h:153:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__no_sanitize_undefined__)
^
fs/ext4/super.c: In function 'ext4_remount':
fs/ext4/super.c:5384:6: warning: variable 'enable_quota' set but not used [-Wunused-but-set-variable]
int enable_quota = 0;
^
--
In file included from include/linux/compiler_types.h:59:0,
from <command-line>:0:
>> include/linux/compiler_attributes.h:35:29: warning: "__GCC4_has_attribute___no_sanitize_undefined__" is not defined [-Wundef]
# define __has_attribute(x) __GCC4_has_attribute_##x
^
>> include/linux/compiler-gcc.h:153:5: note: in expansion of macro '__has_attribute'
#if __has_attribute(__no_sanitize_undefined__)
^
drivers/tty/tty_ldisc.c:884:6: warning: no previous prototype for 'tty_sysctl_init' [-Wmissing-prototypes]
void tty_sysctl_init(void)
^
..
vim +/__has_attribute +153 include/linux/compiler-gcc.h
152
> 153 #if __has_attribute(__no_sanitize_undefined__)
154 #define __no_sanitize_undefined __attribute__((no_sanitize_undefined))
155 #else
156 #define __no_sanitize_undefined
157 #endif
158
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
- 4
- 4
Re: [PATCH v8 1/4] bitops: Introduce the for_each_set_clump macro
by kernel test robot
Hi Syed,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on 444fc5cde64330661bf59944c43844e7d4c2ccd8]
url: https://github.com/0day-ci/linux/commits/Syed-Nayyar-Waris/Introduce-the-...
base: 444fc5cde64330661bf59944c43844e7d4c2ccd8
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
In file included from include/linux/bits.h:23,
from include/linux/bitops.h:5,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/preempt.h:11,
from include/linux/hardirq.h:5,
from include/linux/kvm_host.h:7,
from arch/x86/kvm/../../../virt/kvm/kvm_main.c:18:
include/linux/bitmap.h: In function 'bitmap_get_value':
>> include/linux/bits.h:26:28: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:590:35: note: in expansion of macro 'GENMASK'
590 | return (map[index] >> offset) & GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bits.h:26:40: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:590:35: note: in expansion of macro 'GENMASK'
590 | return (map[index] >> offset) & GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bitmap.h: In function 'bitmap_set_value':
>> include/linux/bits.h:26:28: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:630:11: note: in expansion of macro 'GENMASK'
630 | value &= GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bits.h:26:40: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:630:11: note: in expansion of macro 'GENMASK'
630 | value &= GENMASK(nbits - 1, 0);
| ^~~~~~~
cc1: all warnings being treated as errors
--
In file included from include/linux/bits.h:23,
from include/linux/bitops.h:5,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/preempt.h:11,
from include/linux/hardirq.h:5,
from include/linux/kvm_host.h:7,
from arch/x86/kvm/../../../virt/kvm/irqchip.c:15:
include/linux/bitmap.h: In function 'bitmap_get_value':
>> include/linux/bits.h:26:28: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:590:35: note: in expansion of macro 'GENMASK'
590 | return (map[index] >> offset) & GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bits.h:26:40: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:590:35: note: in expansion of macro 'GENMASK'
590 | return (map[index] >> offset) & GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bitmap.h: In function 'bitmap_set_value':
>> include/linux/bits.h:26:28: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:630:11: note: in expansion of macro 'GENMASK'
630 | value &= GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bits.h:26:40: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:630:11: note: in expansion of macro 'GENMASK'
630 | value &= GENMASK(nbits - 1, 0);
| ^~~~~~~
arch/x86/kvm/../../../virt/kvm/irqchip.c: At top level:
arch/x86/kvm/../../../virt/kvm/irqchip.c:20:10: fatal error: irq.h: No such file or directory
20 | #include "irq.h"
| ^~~~~~~
cc1: all warnings being treated as errors
compilation terminated.
--
In file included from include/linux/bits.h:23,
from include/linux/bitops.h:5,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/preempt.h:11,
from include/linux/hardirq.h:5,
from include/linux/kvm_host.h:7,
from arch/x86/kvm/mmu/page_track.c:14:
include/linux/bitmap.h: In function 'bitmap_get_value':
>> include/linux/bits.h:26:28: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:590:35: note: in expansion of macro 'GENMASK'
590 | return (map[index] >> offset) & GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bits.h:26:40: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:590:35: note: in expansion of macro 'GENMASK'
590 | return (map[index] >> offset) & GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bitmap.h: In function 'bitmap_set_value':
>> include/linux/bits.h:26:28: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:630:11: note: in expansion of macro 'GENMASK'
630 | value &= GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bits.h:26:40: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:630:11: note: in expansion of macro 'GENMASK'
630 | value &= GENMASK(nbits - 1, 0);
| ^~~~~~~
arch/x86/kvm/mmu/page_track.c: At top level:
arch/x86/kvm/mmu/page_track.c:19:10: fatal error: mmu.h: No such file or directory
19 | #include "mmu.h"
| ^~~~~~~
cc1: all warnings being treated as errors
compilation terminated.
--
In file included from include/linux/bits.h:23,
from include/linux/bitops.h:5,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/wait.h:7,
from include/linux/wait_bit.h:8,
from include/linux/fs.h:6,
from include/linux/highmem.h:5,
from arch/x86/kvm/vmx/vmx.c:17:
include/linux/bitmap.h: In function 'bitmap_get_value':
>> include/linux/bits.h:26:28: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:590:35: note: in expansion of macro 'GENMASK'
590 | return (map[index] >> offset) & GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bits.h:26:40: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:590:35: note: in expansion of macro 'GENMASK'
590 | return (map[index] >> offset) & GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bitmap.h: In function 'bitmap_set_value':
>> include/linux/bits.h:26:28: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:630:11: note: in expansion of macro 'GENMASK'
630 | value &= GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bits.h:26:40: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:630:11: note: in expansion of macro 'GENMASK'
630 | value &= GENMASK(nbits - 1, 0);
| ^~~~~~~
In file included from arch/x86/kvm/vmx/vmx.c:50:
arch/x86/kvm/vmx/capabilities.h: At top level:
arch/x86/kvm/vmx/capabilities.h:7:10: fatal error: lapic.h: No such file or directory
7 | #include "lapic.h"
| ^~~~~~~~~
cc1: all warnings being treated as errors
compilation terminated.
--
In file included from include/linux/bits.h:23,
from include/linux/bitops.h:5,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/preempt.h:11,
from include/linux/hardirq.h:5,
from include/linux/kvm_host.h:7,
from arch/x86/kvm/vmx/pmu_intel.c:12:
include/linux/bitmap.h: In function 'bitmap_get_value':
>> include/linux/bits.h:26:28: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:590:35: note: in expansion of macro 'GENMASK'
590 | return (map[index] >> offset) & GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bits.h:26:40: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:590:35: note: in expansion of macro 'GENMASK'
590 | return (map[index] >> offset) & GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bitmap.h: In function 'bitmap_set_value':
>> include/linux/bits.h:26:28: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:630:11: note: in expansion of macro 'GENMASK'
630 | value &= GENMASK(nbits - 1, 0);
| ^~~~~~~
include/linux/bits.h:26:40: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
| ^
include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG_ON_ZERO'
16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
| ^
include/linux/bits.h:39:3: note: in expansion of macro 'GENMASK_INPUT_CHECK'
39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
| ^~~~~~~~~~~~~~~~~~~
include/linux/bitmap.h:630:11: note: in expansion of macro 'GENMASK'
630 | value &= GENMASK(nbits - 1, 0);
| ^~~~~~~
arch/x86/kvm/vmx/pmu_intel.c: At top level:
arch/x86/kvm/vmx/pmu_intel.c:15:10: fatal error: x86.h: No such file or directory
15 | #include "x86.h"
| ^~~~~~~
cc1: all warnings being treated as errors
compilation terminated.
..
vim +26 include/linux/bits.h
8bd9cb51daac89 Will Deacon 2018-06-19 15
8bd9cb51daac89 Will Deacon 2018-06-19 16 /*
8bd9cb51daac89 Will Deacon 2018-06-19 17 * Create a contiguous bitmask starting at bit position @l and ending at
8bd9cb51daac89 Will Deacon 2018-06-19 18 * position @h. For example
8bd9cb51daac89 Will Deacon 2018-06-19 19 * GENMASK_ULL(39, 21) gives us the 64bit vector 0x000000ffffe00000.
8bd9cb51daac89 Will Deacon 2018-06-19 20 */
295bcca84916cb Rikard Falkeborn 2020-04-06 21 #if !defined(__ASSEMBLY__) && \
295bcca84916cb Rikard Falkeborn 2020-04-06 22 (!defined(CONFIG_CC_IS_GCC) || CONFIG_GCC_VERSION >= 49000)
295bcca84916cb Rikard Falkeborn 2020-04-06 23 #include <linux/build_bug.h>
295bcca84916cb Rikard Falkeborn 2020-04-06 24 #define GENMASK_INPUT_CHECK(h, l) \
295bcca84916cb Rikard Falkeborn 2020-04-06 25 (BUILD_BUG_ON_ZERO(__builtin_choose_expr( \
295bcca84916cb Rikard Falkeborn 2020-04-06 @26 __builtin_constant_p((l) > (h)), (l) > (h), 0)))
295bcca84916cb Rikard Falkeborn 2020-04-06 27 #else
295bcca84916cb Rikard Falkeborn 2020-04-06 28 /*
295bcca84916cb Rikard Falkeborn 2020-04-06 29 * BUILD_BUG_ON_ZERO is not available in h files included from asm files,
295bcca84916cb Rikard Falkeborn 2020-04-06 30 * disable the input check if that is the case.
295bcca84916cb Rikard Falkeborn 2020-04-06 31 */
295bcca84916cb Rikard Falkeborn 2020-04-06 32 #define GENMASK_INPUT_CHECK(h, l) 0
295bcca84916cb Rikard Falkeborn 2020-04-06 33 #endif
295bcca84916cb Rikard Falkeborn 2020-04-06 34
:::::: The code at line 26 was first introduced by commit
:::::: 295bcca84916cb5079140a89fccb472bb8d1f6e2 linux/bits.h: add compile time sanity check of GENMASK inputs
:::::: TO: Rikard Falkeborn <rikard.falkeborn(a)gmail.com>
:::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
- 1
- 0
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dpp.c:350:11: warning: variable 'pixel_width' set but not used
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 69119673bd50b176ded34032fadd41530fb5af21
commit: 476e955dd679673c81c35f383ffff8f7dbd70d97 drm/amd/display: Hook DCN2 into amdgpu_dm and expose as config (v2)
date: 12 months ago
config: i386-randconfig-m021-20200617 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dpp.c:233:6: warning: no previous prototype for 'dpp2_cnv_set_bias_scale' [-Wmissing-prototypes]
233 | void dpp2_cnv_set_bias_scale(
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dpp.c: In function 'dpp2_get_optimal_number_of_taps':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dpp.c:350:11: warning: variable 'pixel_width' set but not used [-Wunused-but-set-variable]
350 | uint32_t pixel_width;
| ^~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:32,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dpp.c:28:
At top level:
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:120:22: warning: 'DP_DVI_CONVERTER_ID_4' defined but not used [-Wunused-const-variable=]
120 | static const uint8_t DP_DVI_CONVERTER_ID_4[] = "m2DVIa";
| ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:118:22: warning: 'DP_VGA_LVDS_CONVERTER_ID_3' defined but not used [-Wunused-const-variable=]
118 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_3[] = "dnomlA";
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:116:22: warning: 'DP_VGA_LVDS_CONVERTER_ID_2' defined but not used [-Wunused-const-variable=]
116 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_2[] = "sivarT";
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:37,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dpp.c:26:
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:76:32: warning: 'dc_fixpt_ln2_div_2' defined but not used [-Wunused-const-variable=]
76 | static const struct fixed31_32 dc_fixpt_ln2_div_2 = { 1488522236LL };
| ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:75:32: warning: 'dc_fixpt_ln2' defined but not used [-Wunused-const-variable=]
75 | static const struct fixed31_32 dc_fixpt_ln2 = { 2977044471LL };
| ^~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:74:32: warning: 'dc_fixpt_e' defined but not used [-Wunused-const-variable=]
74 | static const struct fixed31_32 dc_fixpt_e = { 11674931555LL };
| ^~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:73:32: warning: 'dc_fixpt_two_pi' defined but not used [-Wunused-const-variable=]
73 | static const struct fixed31_32 dc_fixpt_two_pi = { 26986075409LL };
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:72:32: warning: 'dc_fixpt_pi' defined but not used [-Wunused-const-variable=]
72 | static const struct fixed31_32 dc_fixpt_pi = { 13493037705LL };
| ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:67:32: warning: 'dc_fixpt_zero' defined but not used [-Wunused-const-variable=]
67 | static const struct fixed31_32 dc_fixpt_zero = { 0 };
| ^~~~~~~~~~~~~
--
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dwb_scl.c:530:17: warning: no previous prototype for 'wbscl_get_filter_3tap_16p' [-Wmissing-prototypes]
530 | const uint16_t *wbscl_get_filter_3tap_16p(struct fixed31_32 ratio)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dwb_scl.c:542:17: warning: no previous prototype for 'wbscl_get_filter_4tap_16p' [-Wmissing-prototypes]
542 | const uint16_t *wbscl_get_filter_4tap_16p(struct fixed31_32 ratio)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dwb_scl.c: In function 'dwb_program_horz_scalar':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dwb_scl.c:725:11: warning: variable 'h_ratio_chroma' set but not used [-Wunused-but-set-variable]
725 | uint32_t h_ratio_chroma = 1;
| ^~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dwb_scl.c: In function 'dwb_program_vert_scalar':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dwb_scl.c:806:11: warning: variable 'v_ratio_chroma' set but not used [-Wunused-but-set-variable]
806 | uint32_t v_ratio_chroma = 1;
| ^~~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:32,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/resource.h:28,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dwb_scl.c:28:
At top level:
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:120:22: warning: 'DP_DVI_CONVERTER_ID_4' defined but not used [-Wunused-const-variable=]
120 | static const uint8_t DP_DVI_CONVERTER_ID_4[] = "m2DVIa";
| ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:118:22: warning: 'DP_VGA_LVDS_CONVERTER_ID_3' defined but not used [-Wunused-const-variable=]
118 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_3[] = "dnomlA";
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:116:22: warning: 'DP_VGA_LVDS_CONVERTER_ID_2' defined but not used [-Wunused-const-variable=]
116 | static const uint8_t DP_VGA_LVDS_CONVERTER_ID_2[] = "sivarT";
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_types.h:29,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:30,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services.h:37,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/reg_helper.h:28,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dwb_scl.c:26:
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:76:32: warning: 'dc_fixpt_ln2_div_2' defined but not used [-Wunused-const-variable=]
76 | static const struct fixed31_32 dc_fixpt_ln2_div_2 = { 1488522236LL };
| ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:75:32: warning: 'dc_fixpt_ln2' defined but not used [-Wunused-const-variable=]
75 | static const struct fixed31_32 dc_fixpt_ln2 = { 2977044471LL };
| ^~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:74:32: warning: 'dc_fixpt_e' defined but not used [-Wunused-const-variable=]
74 | static const struct fixed31_32 dc_fixpt_e = { 11674931555LL };
| ^~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:73:32: warning: 'dc_fixpt_two_pi' defined but not used [-Wunused-const-variable=]
73 | static const struct fixed31_32 dc_fixpt_two_pi = { 26986075409LL };
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:72:32: warning: 'dc_fixpt_pi' defined but not used [-Wunused-const-variable=]
72 | static const struct fixed31_32 dc_fixpt_pi = { 13493037705LL };
| ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:67:32: warning: 'dc_fixpt_zero' defined but not used [-Wunused-const-variable=]
67 | static const struct fixed31_32 dc_fixpt_zero = { 0 };
| ^~~~~~~~~~~~~
vim +/pixel_width +350 drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dpp.c
f7de96ee8b5f4d Harry Wentland 2019-02-22 232
f7de96ee8b5f4d Harry Wentland 2019-02-22 @233 void dpp2_cnv_set_bias_scale(
f7de96ee8b5f4d Harry Wentland 2019-02-22 234 struct dpp *dpp_base,
f7de96ee8b5f4d Harry Wentland 2019-02-22 235 struct dc_bias_and_scale *bias_and_scale)
f7de96ee8b5f4d Harry Wentland 2019-02-22 236 {
f7de96ee8b5f4d Harry Wentland 2019-02-22 237 struct dcn20_dpp *dpp = TO_DCN20_DPP(dpp_base);
f7de96ee8b5f4d Harry Wentland 2019-02-22 238
f7de96ee8b5f4d Harry Wentland 2019-02-22 239 REG_UPDATE(FCNV_FP_BIAS_R, FCNV_FP_BIAS_R, bias_and_scale->bias_red);
f7de96ee8b5f4d Harry Wentland 2019-02-22 240 REG_UPDATE(FCNV_FP_BIAS_G, FCNV_FP_BIAS_G, bias_and_scale->bias_green);
f7de96ee8b5f4d Harry Wentland 2019-02-22 241 REG_UPDATE(FCNV_FP_BIAS_B, FCNV_FP_BIAS_B, bias_and_scale->bias_blue);
f7de96ee8b5f4d Harry Wentland 2019-02-22 242 REG_UPDATE(FCNV_FP_SCALE_R, FCNV_FP_SCALE_R, bias_and_scale->scale_red);
f7de96ee8b5f4d Harry Wentland 2019-02-22 243 REG_UPDATE(FCNV_FP_SCALE_G, FCNV_FP_SCALE_G, bias_and_scale->scale_green);
f7de96ee8b5f4d Harry Wentland 2019-02-22 244 REG_UPDATE(FCNV_FP_SCALE_B, FCNV_FP_SCALE_B, bias_and_scale->scale_blue);
f7de96ee8b5f4d Harry Wentland 2019-02-22 245 }
f7de96ee8b5f4d Harry Wentland 2019-02-22 246
f7de96ee8b5f4d Harry Wentland 2019-02-22 247 /*compute the maximum number of lines that we can fit in the line buffer*/
f7de96ee8b5f4d Harry Wentland 2019-02-22 248 void dscl2_calc_lb_num_partitions(
f7de96ee8b5f4d Harry Wentland 2019-02-22 249 const struct scaler_data *scl_data,
f7de96ee8b5f4d Harry Wentland 2019-02-22 250 enum lb_memory_config lb_config,
f7de96ee8b5f4d Harry Wentland 2019-02-22 251 int *num_part_y,
f7de96ee8b5f4d Harry Wentland 2019-02-22 252 int *num_part_c)
f7de96ee8b5f4d Harry Wentland 2019-02-22 253 {
f7de96ee8b5f4d Harry Wentland 2019-02-22 254 int line_size = scl_data->viewport.width < scl_data->recout.width ?
f7de96ee8b5f4d Harry Wentland 2019-02-22 255 scl_data->viewport.width : scl_data->recout.width;
f7de96ee8b5f4d Harry Wentland 2019-02-22 256 int line_size_c = scl_data->viewport_c.width < scl_data->recout.width ?
f7de96ee8b5f4d Harry Wentland 2019-02-22 257 scl_data->viewport_c.width : scl_data->recout.width;
f7de96ee8b5f4d Harry Wentland 2019-02-22 258 int memory_line_size_y = (line_size + 5) / 6; /* +5 to ceil */
f7de96ee8b5f4d Harry Wentland 2019-02-22 259 int memory_line_size_c = (line_size_c + 5) / 6; /* +5 to ceil */
f7de96ee8b5f4d Harry Wentland 2019-02-22 260 int memory_line_size_a = (line_size + 5) / 6; /* +5 to ceil */
f7de96ee8b5f4d Harry Wentland 2019-02-22 261 int lb_memory_size, lb_memory_size_c, lb_memory_size_a, num_partitions_a;
f7de96ee8b5f4d Harry Wentland 2019-02-22 262
f7de96ee8b5f4d Harry Wentland 2019-02-22 263 if (lb_config == LB_MEMORY_CONFIG_1) {
f7de96ee8b5f4d Harry Wentland 2019-02-22 264 lb_memory_size = 970;
f7de96ee8b5f4d Harry Wentland 2019-02-22 265 lb_memory_size_c = 970;
f7de96ee8b5f4d Harry Wentland 2019-02-22 266 lb_memory_size_a = 970;
f7de96ee8b5f4d Harry Wentland 2019-02-22 267 } else if (lb_config == LB_MEMORY_CONFIG_2) {
f7de96ee8b5f4d Harry Wentland 2019-02-22 268 lb_memory_size = 1290;
f7de96ee8b5f4d Harry Wentland 2019-02-22 269 lb_memory_size_c = 1290;
f7de96ee8b5f4d Harry Wentland 2019-02-22 270 lb_memory_size_a = 1290;
f7de96ee8b5f4d Harry Wentland 2019-02-22 271 } else if (lb_config == LB_MEMORY_CONFIG_3) {
f7de96ee8b5f4d Harry Wentland 2019-02-22 272 /* 420 mode: using 3rd mem from Y, Cr and Cb */
f7de96ee8b5f4d Harry Wentland 2019-02-22 273 lb_memory_size = 970 + 1290 + 484 + 484 + 484;
f7de96ee8b5f4d Harry Wentland 2019-02-22 274 lb_memory_size_c = 970 + 1290;
f7de96ee8b5f4d Harry Wentland 2019-02-22 275 lb_memory_size_a = 970 + 1290 + 484;
f7de96ee8b5f4d Harry Wentland 2019-02-22 276 } else {
f7de96ee8b5f4d Harry Wentland 2019-02-22 277 lb_memory_size = 970 + 1290 + 484;
f7de96ee8b5f4d Harry Wentland 2019-02-22 278 lb_memory_size_c = 970 + 1290 + 484;
f7de96ee8b5f4d Harry Wentland 2019-02-22 279 lb_memory_size_a = 970 + 1290 + 484;
f7de96ee8b5f4d Harry Wentland 2019-02-22 280 }
f7de96ee8b5f4d Harry Wentland 2019-02-22 281 *num_part_y = lb_memory_size / memory_line_size_y;
f7de96ee8b5f4d Harry Wentland 2019-02-22 282 *num_part_c = lb_memory_size_c / memory_line_size_c;
f7de96ee8b5f4d Harry Wentland 2019-02-22 283 num_partitions_a = lb_memory_size_a / memory_line_size_a;
f7de96ee8b5f4d Harry Wentland 2019-02-22 284
f7de96ee8b5f4d Harry Wentland 2019-02-22 285 if (scl_data->lb_params.alpha_en
f7de96ee8b5f4d Harry Wentland 2019-02-22 286 && (num_partitions_a < *num_part_y))
f7de96ee8b5f4d Harry Wentland 2019-02-22 287 *num_part_y = num_partitions_a;
f7de96ee8b5f4d Harry Wentland 2019-02-22 288
f7de96ee8b5f4d Harry Wentland 2019-02-22 289 if (*num_part_y > 64)
f7de96ee8b5f4d Harry Wentland 2019-02-22 290 *num_part_y = 64;
f7de96ee8b5f4d Harry Wentland 2019-02-22 291 if (*num_part_c > 64)
f7de96ee8b5f4d Harry Wentland 2019-02-22 292 *num_part_c = 64;
f7de96ee8b5f4d Harry Wentland 2019-02-22 293 }
f7de96ee8b5f4d Harry Wentland 2019-02-22 294
f7de96ee8b5f4d Harry Wentland 2019-02-22 295 void dpp2_cnv_set_alpha_keyer(
f7de96ee8b5f4d Harry Wentland 2019-02-22 296 struct dpp *dpp_base,
f7de96ee8b5f4d Harry Wentland 2019-02-22 297 struct cnv_color_keyer_params *color_keyer)
f7de96ee8b5f4d Harry Wentland 2019-02-22 298 {
f7de96ee8b5f4d Harry Wentland 2019-02-22 299 struct dcn20_dpp *dpp = TO_DCN20_DPP(dpp_base);
f7de96ee8b5f4d Harry Wentland 2019-02-22 300
f7de96ee8b5f4d Harry Wentland 2019-02-22 301 REG_UPDATE(COLOR_KEYER_CONTROL, COLOR_KEYER_EN, color_keyer->color_keyer_en);
f7de96ee8b5f4d Harry Wentland 2019-02-22 302
f7de96ee8b5f4d Harry Wentland 2019-02-22 303 REG_UPDATE(COLOR_KEYER_CONTROL, COLOR_KEYER_MODE, color_keyer->color_keyer_mode);
f7de96ee8b5f4d Harry Wentland 2019-02-22 304
f7de96ee8b5f4d Harry Wentland 2019-02-22 305 REG_UPDATE(COLOR_KEYER_ALPHA, COLOR_KEYER_ALPHA_LOW, color_keyer->color_keyer_alpha_low);
f7de96ee8b5f4d Harry Wentland 2019-02-22 306 REG_UPDATE(COLOR_KEYER_ALPHA, COLOR_KEYER_ALPHA_HIGH, color_keyer->color_keyer_alpha_high);
f7de96ee8b5f4d Harry Wentland 2019-02-22 307
f7de96ee8b5f4d Harry Wentland 2019-02-22 308 REG_UPDATE(COLOR_KEYER_RED, COLOR_KEYER_RED_LOW, color_keyer->color_keyer_red_low);
f7de96ee8b5f4d Harry Wentland 2019-02-22 309 REG_UPDATE(COLOR_KEYER_RED, COLOR_KEYER_RED_HIGH, color_keyer->color_keyer_red_high);
f7de96ee8b5f4d Harry Wentland 2019-02-22 310
f7de96ee8b5f4d Harry Wentland 2019-02-22 311 REG_UPDATE(COLOR_KEYER_GREEN, COLOR_KEYER_GREEN_LOW, color_keyer->color_keyer_green_low);
f7de96ee8b5f4d Harry Wentland 2019-02-22 312 REG_UPDATE(COLOR_KEYER_GREEN, COLOR_KEYER_GREEN_HIGH, color_keyer->color_keyer_green_high);
f7de96ee8b5f4d Harry Wentland 2019-02-22 313
f7de96ee8b5f4d Harry Wentland 2019-02-22 314 REG_UPDATE(COLOR_KEYER_BLUE, COLOR_KEYER_BLUE_LOW, color_keyer->color_keyer_blue_low);
f7de96ee8b5f4d Harry Wentland 2019-02-22 315 REG_UPDATE(COLOR_KEYER_BLUE, COLOR_KEYER_BLUE_HIGH, color_keyer->color_keyer_blue_high);
f7de96ee8b5f4d Harry Wentland 2019-02-22 316 }
f7de96ee8b5f4d Harry Wentland 2019-02-22 317
f7de96ee8b5f4d Harry Wentland 2019-02-22 318 void dpp2_set_cursor_attributes(
f7de96ee8b5f4d Harry Wentland 2019-02-22 319 struct dpp *dpp_base,
f7de96ee8b5f4d Harry Wentland 2019-02-22 320 enum dc_cursor_color_format color_format)
f7de96ee8b5f4d Harry Wentland 2019-02-22 321 {
f7de96ee8b5f4d Harry Wentland 2019-02-22 322 struct dcn20_dpp *dpp = TO_DCN20_DPP(dpp_base);
f7de96ee8b5f4d Harry Wentland 2019-02-22 323 int cur_rom_en = 0;
f7de96ee8b5f4d Harry Wentland 2019-02-22 324
f7de96ee8b5f4d Harry Wentland 2019-02-22 325 if (color_format == CURSOR_MODE_COLOR_PRE_MULTIPLIED_ALPHA ||
f7de96ee8b5f4d Harry Wentland 2019-02-22 326 color_format == CURSOR_MODE_COLOR_UN_PRE_MULTIPLIED_ALPHA)
f7de96ee8b5f4d Harry Wentland 2019-02-22 327 cur_rom_en = 1;
f7de96ee8b5f4d Harry Wentland 2019-02-22 328
f7de96ee8b5f4d Harry Wentland 2019-02-22 329 REG_UPDATE_3(CURSOR0_CONTROL,
f7de96ee8b5f4d Harry Wentland 2019-02-22 330 CUR0_MODE, color_format,
f7de96ee8b5f4d Harry Wentland 2019-02-22 331 CUR0_EXPANSION_MODE, 0,
f7de96ee8b5f4d Harry Wentland 2019-02-22 332 CUR0_ROM_EN, cur_rom_en);
f7de96ee8b5f4d Harry Wentland 2019-02-22 333
f7de96ee8b5f4d Harry Wentland 2019-02-22 334 if (color_format == CURSOR_MODE_MONO) {
f7de96ee8b5f4d Harry Wentland 2019-02-22 335 /* todo: clarify what to program these to */
f7de96ee8b5f4d Harry Wentland 2019-02-22 336 REG_UPDATE(CURSOR0_COLOR0,
f7de96ee8b5f4d Harry Wentland 2019-02-22 337 CUR0_COLOR0, 0x00000000);
f7de96ee8b5f4d Harry Wentland 2019-02-22 338 REG_UPDATE(CURSOR0_COLOR1,
f7de96ee8b5f4d Harry Wentland 2019-02-22 339 CUR0_COLOR1, 0xFFFFFFFF);
f7de96ee8b5f4d Harry Wentland 2019-02-22 340 }
f7de96ee8b5f4d Harry Wentland 2019-02-22 341 }
f7de96ee8b5f4d Harry Wentland 2019-02-22 342
f7de96ee8b5f4d Harry Wentland 2019-02-22 343 #define IDENTITY_RATIO(ratio) (dc_fixpt_u3d19(ratio) == (1 << 19))
f7de96ee8b5f4d Harry Wentland 2019-02-22 344
f7de96ee8b5f4d Harry Wentland 2019-02-22 345 bool dpp2_get_optimal_number_of_taps(
f7de96ee8b5f4d Harry Wentland 2019-02-22 346 struct dpp *dpp,
f7de96ee8b5f4d Harry Wentland 2019-02-22 347 struct scaler_data *scl_data,
f7de96ee8b5f4d Harry Wentland 2019-02-22 348 const struct scaling_taps *in_taps)
f7de96ee8b5f4d Harry Wentland 2019-02-22 349 {
f7de96ee8b5f4d Harry Wentland 2019-02-22 @350 uint32_t pixel_width;
f7de96ee8b5f4d Harry Wentland 2019-02-22 351
f7de96ee8b5f4d Harry Wentland 2019-02-22 352 if (scl_data->viewport.width > scl_data->recout.width)
f7de96ee8b5f4d Harry Wentland 2019-02-22 353 pixel_width = scl_data->recout.width;
f7de96ee8b5f4d Harry Wentland 2019-02-22 354 else
f7de96ee8b5f4d Harry Wentland 2019-02-22 355 pixel_width = scl_data->viewport.width;
f7de96ee8b5f4d Harry Wentland 2019-02-22 356
f7de96ee8b5f4d Harry Wentland 2019-02-22 357 /* Some ASICs does not support FP16 scaling, so we reject modes require this*/
f7de96ee8b5f4d Harry Wentland 2019-02-22 358 if (scl_data->viewport.width != scl_data->h_active &&
f7de96ee8b5f4d Harry Wentland 2019-02-22 359 scl_data->viewport.height != scl_data->v_active &&
f7de96ee8b5f4d Harry Wentland 2019-02-22 360 dpp->caps->dscl_data_proc_format == DSCL_DATA_PRCESSING_FIXED_FORMAT &&
f7de96ee8b5f4d Harry Wentland 2019-02-22 361 scl_data->format == PIXEL_FORMAT_FP16)
f7de96ee8b5f4d Harry Wentland 2019-02-22 362 return false;
f7de96ee8b5f4d Harry Wentland 2019-02-22 363
f7de96ee8b5f4d Harry Wentland 2019-02-22 364 if (scl_data->viewport.width > scl_data->h_active &&
f7de96ee8b5f4d Harry Wentland 2019-02-22 365 dpp->ctx->dc->debug.max_downscale_src_width != 0 &&
f7de96ee8b5f4d Harry Wentland 2019-02-22 366 scl_data->viewport.width > dpp->ctx->dc->debug.max_downscale_src_width)
f7de96ee8b5f4d Harry Wentland 2019-02-22 367 return false;
f7de96ee8b5f4d Harry Wentland 2019-02-22 368
f7de96ee8b5f4d Harry Wentland 2019-02-22 369 /* TODO: add lb check */
f7de96ee8b5f4d Harry Wentland 2019-02-22 370
f7de96ee8b5f4d Harry Wentland 2019-02-22 371 /* No support for programming ratio of 8, drop to 7.99999.. */
f7de96ee8b5f4d Harry Wentland 2019-02-22 372 if (scl_data->ratios.horz.value == (8ll << 32))
f7de96ee8b5f4d Harry Wentland 2019-02-22 373 scl_data->ratios.horz.value--;
f7de96ee8b5f4d Harry Wentland 2019-02-22 374 if (scl_data->ratios.vert.value == (8ll << 32))
f7de96ee8b5f4d Harry Wentland 2019-02-22 375 scl_data->ratios.vert.value--;
f7de96ee8b5f4d Harry Wentland 2019-02-22 376 if (scl_data->ratios.horz_c.value == (8ll << 32))
f7de96ee8b5f4d Harry Wentland 2019-02-22 377 scl_data->ratios.horz_c.value--;
f7de96ee8b5f4d Harry Wentland 2019-02-22 378 if (scl_data->ratios.vert_c.value == (8ll << 32))
f7de96ee8b5f4d Harry Wentland 2019-02-22 379 scl_data->ratios.vert_c.value--;
f7de96ee8b5f4d Harry Wentland 2019-02-22 380
f7de96ee8b5f4d Harry Wentland 2019-02-22 381 /* Set default taps if none are provided */
f7de96ee8b5f4d Harry Wentland 2019-02-22 382 if (in_taps->h_taps == 0) {
f7de96ee8b5f4d Harry Wentland 2019-02-22 383 if (dc_fixpt_ceil(scl_data->ratios.horz) > 4)
f7de96ee8b5f4d Harry Wentland 2019-02-22 384 scl_data->taps.h_taps = 8;
f7de96ee8b5f4d Harry Wentland 2019-02-22 385 else
f7de96ee8b5f4d Harry Wentland 2019-02-22 386 scl_data->taps.h_taps = 4;
f7de96ee8b5f4d Harry Wentland 2019-02-22 387 } else
f7de96ee8b5f4d Harry Wentland 2019-02-22 388 scl_data->taps.h_taps = in_taps->h_taps;
f7de96ee8b5f4d Harry Wentland 2019-02-22 389 if (in_taps->v_taps == 0) {
f7de96ee8b5f4d Harry Wentland 2019-02-22 390 if (dc_fixpt_ceil(scl_data->ratios.vert) > 4)
f7de96ee8b5f4d Harry Wentland 2019-02-22 391 scl_data->taps.v_taps = 8;
f7de96ee8b5f4d Harry Wentland 2019-02-22 392 else
f7de96ee8b5f4d Harry Wentland 2019-02-22 393 scl_data->taps.v_taps = 4;
f7de96ee8b5f4d Harry Wentland 2019-02-22 394 } else
f7de96ee8b5f4d Harry Wentland 2019-02-22 395 scl_data->taps.v_taps = in_taps->v_taps;
f7de96ee8b5f4d Harry Wentland 2019-02-22 396 if (in_taps->v_taps_c == 0) {
f7de96ee8b5f4d Harry Wentland 2019-02-22 397 if (dc_fixpt_ceil(scl_data->ratios.vert_c) > 4)
f7de96ee8b5f4d Harry Wentland 2019-02-22 398 scl_data->taps.v_taps_c = 4;
f7de96ee8b5f4d Harry Wentland 2019-02-22 399 else
f7de96ee8b5f4d Harry Wentland 2019-02-22 400 scl_data->taps.v_taps_c = 2;
f7de96ee8b5f4d Harry Wentland 2019-02-22 401 } else
f7de96ee8b5f4d Harry Wentland 2019-02-22 402 scl_data->taps.v_taps_c = in_taps->v_taps_c;
f7de96ee8b5f4d Harry Wentland 2019-02-22 403 if (in_taps->h_taps_c == 0) {
f7de96ee8b5f4d Harry Wentland 2019-02-22 404 if (dc_fixpt_ceil(scl_data->ratios.horz_c) > 4)
f7de96ee8b5f4d Harry Wentland 2019-02-22 405 scl_data->taps.h_taps_c = 4;
f7de96ee8b5f4d Harry Wentland 2019-02-22 406 else
f7de96ee8b5f4d Harry Wentland 2019-02-22 407 scl_data->taps.h_taps_c = 2;
f7de96ee8b5f4d Harry Wentland 2019-02-22 408 } else if ((in_taps->h_taps_c % 2) != 0 && in_taps->h_taps_c != 1)
f7de96ee8b5f4d Harry Wentland 2019-02-22 409 /* Only 1 and even h_taps_c are supported by hw */
f7de96ee8b5f4d Harry Wentland 2019-02-22 410 scl_data->taps.h_taps_c = in_taps->h_taps_c - 1;
f7de96ee8b5f4d Harry Wentland 2019-02-22 411 else
f7de96ee8b5f4d Harry Wentland 2019-02-22 412 scl_data->taps.h_taps_c = in_taps->h_taps_c;
f7de96ee8b5f4d Harry Wentland 2019-02-22 413
f7de96ee8b5f4d Harry Wentland 2019-02-22 414 if (!dpp->ctx->dc->debug.always_scale) {
f7de96ee8b5f4d Harry Wentland 2019-02-22 415 if (IDENTITY_RATIO(scl_data->ratios.horz))
f7de96ee8b5f4d Harry Wentland 2019-02-22 416 scl_data->taps.h_taps = 1;
f7de96ee8b5f4d Harry Wentland 2019-02-22 417 if (IDENTITY_RATIO(scl_data->ratios.vert))
f7de96ee8b5f4d Harry Wentland 2019-02-22 418 scl_data->taps.v_taps = 1;
f7de96ee8b5f4d Harry Wentland 2019-02-22 419 if (IDENTITY_RATIO(scl_data->ratios.horz_c))
f7de96ee8b5f4d Harry Wentland 2019-02-22 420 scl_data->taps.h_taps_c = 1;
f7de96ee8b5f4d Harry Wentland 2019-02-22 421 if (IDENTITY_RATIO(scl_data->ratios.vert_c))
f7de96ee8b5f4d Harry Wentland 2019-02-22 422 scl_data->taps.v_taps_c = 1;
f7de96ee8b5f4d Harry Wentland 2019-02-22 423 }
f7de96ee8b5f4d Harry Wentland 2019-02-22 424
f7de96ee8b5f4d Harry Wentland 2019-02-22 425 return true;
f7de96ee8b5f4d Harry Wentland 2019-02-22 426 }
f7de96ee8b5f4d Harry Wentland 2019-02-22 427
:::::: The code at line 350 was first introduced by commit
:::::: f7de96ee8b5f4d0d4ef7b00b8868049a6869a10f drm/amd/display: Add DCN2 DPP
:::::: TO: Harry Wentland <harry.wentland(a)amd.com>
:::::: CC: Alex Deucher <alexander.deucher(a)amd.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
- 1
- 0
drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c:587:2: warning: 'strncpy' specified bound 8 equals destination size
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 69119673bd50b176ded34032fadd41530fb5af21
commit: 8ad8b72721d0f07fa02dbe71f901743f9c71c8e6 riscv: Add KASAN support
date: 5 months ago
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 8ad8b72721d0f07fa02dbe71f901743f9c71c8e6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.h:24,
from drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c:26:
drivers/net/wireless/broadcom/brcm80211/brcmsmac/d11.h:786:1: warning: alignment 1 of 'struct d11txh' is less than 2 [-Wpacked-not-aligned]
786 | } __packed;
| ^
drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c: In function 'dma_attach':
<< from drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c:26:
>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c:587:2: warning: 'strncpy' specified bound 8 equals destination size [-Wstringop-truncation]
587 | strncpy(di->name, name, MAXNAMEL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/strncpy +587 drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 547
e041f65d5f0001 drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 548 struct dma_pub *dma_attach(char *name, struct brcms_c_info *wlc,
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 549 uint txregbase, uint rxregbase, uint ntxd, uint nrxd,
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 550 uint rxbufsize, int rxextheadroom,
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 551 uint nrxpost, uint rxoffset)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 552 {
e041f65d5f0001 drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 553 struct si_pub *sih = wlc->hw->sih;
e041f65d5f0001 drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 554 struct bcma_device *core = wlc->hw->d11core;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 555 struct dma_info *di;
3b758a68402fc5 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-12 556 u8 rev = core->id.rev;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 557 uint size;
ec5ab1dd73a4b2 drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 558 struct si_info *sii = container_of(sih, struct si_info, pub);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 559
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 560 /* allocate private info structure */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 561 di = kzalloc(sizeof(struct dma_info), GFP_ATOMIC);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 562 if (di == NULL)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 563 return NULL;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 564
a8779e4a8e7f0f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 565 di->dma64 =
3b758a68402fc5 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-12 566 ((bcma_aread32(core, BCMA_IOST) & SISF_DMA64) == SISF_DMA64);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 567
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 568 /* init dma reg info */
3b758a68402fc5 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-12 569 di->core = core;
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 570 di->d64txregbase = txregbase;
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 571 di->d64rxregbase = rxregbase;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 572
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 573 /*
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 574 * Default flags (which can be changed by the driver calling
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 575 * dma_ctrlflags before enable): For backwards compatibility
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 576 * both Rx Overflow Continue and Parity are DISABLED.
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 577 */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 578 _dma_ctrlflags(di, DMA_CTRL_ROC | DMA_CTRL_PEN, 0);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 579
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 580 brcms_dbg_dma(di->core, "%s: %s flags 0x%x ntxd %d nrxd %d "
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 581 "rxbufsize %d rxextheadroom %d nrxpost %d rxoffset %d "
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 582 "txregbase %u rxregbase %u\n", name, "DMA64",
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 583 di->dma.dmactrlflags, ntxd, nrxd, rxbufsize,
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 584 rxextheadroom, nrxpost, rxoffset, txregbase, rxregbase);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 585
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 586 /* make a private copy of our callers name */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 @587 strncpy(di->name, name, MAXNAMEL);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 588 di->name[MAXNAMEL - 1] = '\0';
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 589
3b758a68402fc5 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-12 590 di->dmadev = core->dma_dev;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 591
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 592 /* save tunables */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 593 di->ntxd = (u16) ntxd;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 594 di->nrxd = (u16) nrxd;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 595
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 596 /* the actual dma size doesn't include the extra headroom */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 597 di->rxextrahdrroom =
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 598 (rxextheadroom == -1) ? BCMEXTRAHDROOM : rxextheadroom;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 599 if (rxbufsize > BCMEXTRAHDROOM)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 600 di->rxbufsize = (u16) (rxbufsize - di->rxextrahdrroom);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 601 else
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 602 di->rxbufsize = (u16) rxbufsize;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 603
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 604 di->nrxpost = (u16) nrxpost;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 605 di->rxoffset = (u8) rxoffset;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 606
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 607 /*
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 608 * figure out the DMA physical address offset for dd and data
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 609 * PCI/PCIE: they map silicon backplace address to zero
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 610 * based memory, need offset
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 611 * Other bus: use zero SI_BUS BIGENDIAN kludge: use sdram
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 612 * swapped region for data buffer, not descriptor
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 613 */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 614 di->ddoffsetlow = 0;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 615 di->dataoffsetlow = 0;
ec5ab1dd73a4b2 drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 616 /* for pci bus, add offset */
ec5ab1dd73a4b2 drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 617 if (sii->icbus->hosttype == BCMA_HOSTTYPE_PCI) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 618 /* add offset for pcie with DMA64 bus */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 619 di->ddoffsetlow = 0;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 620 di->ddoffsethigh = SI_PCIE_DMA_H32;
ec5ab1dd73a4b2 drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 621 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 622 di->dataoffsetlow = di->ddoffsetlow;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 623 di->dataoffsethigh = di->ddoffsethigh;
ec5ab1dd73a4b2 drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 624
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 625 /* WAR64450 : DMACtl.Addr ext fields are not supported in SDIOD core. */
780b9c4644616f drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 626 if ((core->id.id == BCMA_CORE_SDIO_DEV)
3b758a68402fc5 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-12 627 && ((rev > 0) && (rev <= 2)))
3db1cd5c05f35f drivers/net/wireless/brcm80211/brcmsmac/dma.c Rusty Russell 2011-12-19 628 di->addrext = false;
780b9c4644616f drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 629 else if ((core->id.id == BCMA_CORE_I2S) &&
3b758a68402fc5 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-12 630 ((rev == 0) || (rev == 1)))
3db1cd5c05f35f drivers/net/wireless/brcm80211/brcmsmac/dma.c Rusty Russell 2011-12-19 631 di->addrext = false;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 632 else
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 633 di->addrext = _dma_isaddrext(di);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 634
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 635 /* does the descriptor need to be aligned and if yes, on 4K/8K or not */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 636 di->aligndesc_4k = _dma_descriptor_align(di);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 637 if (di->aligndesc_4k) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 638 di->dmadesc_align = D64RINGALIGN_BITS;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 639 if ((ntxd < D64MAXDD / 2) && (nrxd < D64MAXDD / 2))
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 640 /* for smaller dd table, HW relax alignment reqmnt */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 641 di->dmadesc_align = D64RINGALIGN_BITS - 1;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 642 } else {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 643 di->dmadesc_align = 4; /* 16 byte alignment */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 644 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 645
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 646 brcms_dbg_dma(di->core, "DMA descriptor align_needed %d, align %d\n",
8505a7e652c8a3 drivers/net/wireless/brcm80211/brcmsmac/dma.c Joe Perches 2011-11-13 647 di->aligndesc_4k, di->dmadesc_align);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 648
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 649 /* allocate tx packet pointer vector */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 650 if (ntxd) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 651 size = ntxd * sizeof(void *);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 652 di->txp = kzalloc(size, GFP_ATOMIC);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 653 if (di->txp == NULL)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 654 goto fail;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 655 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 656
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 657 /* allocate rx packet pointer vector */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 658 if (nrxd) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 659 size = nrxd * sizeof(void *);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 660 di->rxp = kzalloc(size, GFP_ATOMIC);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 661 if (di->rxp == NULL)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 662 goto fail;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 663 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 664
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 665 /*
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 666 * allocate transmit descriptor ring, only need ntxd descriptors
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 667 * but it must be aligned
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 668 */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 669 if (ntxd) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 670 if (!_dma_alloc(di, DMA_TX))
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 671 goto fail;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 672 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 673
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 674 /*
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 675 * allocate receive descriptor ring, only need nrxd descriptors
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 676 * but it must be aligned
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 677 */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 678 if (nrxd) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 679 if (!_dma_alloc(di, DMA_RX))
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 680 goto fail;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 681 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 682
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 683 if ((di->ddoffsetlow != 0) && !di->addrext) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 684 if (di->txdpa > SI_PCI_DMA_SZ) {
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 685 brcms_dbg_dma(di->core,
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 686 "%s: txdpa 0x%x: addrext not supported\n",
8505a7e652c8a3 drivers/net/wireless/brcm80211/brcmsmac/dma.c Joe Perches 2011-11-13 687 di->name, (u32)di->txdpa);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 688 goto fail;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 689 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 690 if (di->rxdpa > SI_PCI_DMA_SZ) {
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 691 brcms_dbg_dma(di->core,
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 692 "%s: rxdpa 0x%x: addrext not supported\n",
8505a7e652c8a3 drivers/net/wireless/brcm80211/brcmsmac/dma.c Joe Perches 2011-11-13 693 di->name, (u32)di->rxdpa);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 694 goto fail;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 695 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 696 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 697
e041f65d5f0001 drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 698 /* Initialize AMPDU session */
e041f65d5f0001 drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 699 brcms_c_ampdu_reset_session(&di->ampdu_session, wlc);
e041f65d5f0001 drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 700
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 701 brcms_dbg_dma(di->core,
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 702 "ddoffsetlow 0x%x ddoffsethigh 0x%x dataoffsetlow 0x%x dataoffsethigh 0x%x addrext %d\n",
8505a7e652c8a3 drivers/net/wireless/brcm80211/brcmsmac/dma.c Joe Perches 2011-11-13 703 di->ddoffsetlow, di->ddoffsethigh,
8505a7e652c8a3 drivers/net/wireless/brcm80211/brcmsmac/dma.c Joe Perches 2011-11-13 704 di->dataoffsetlow, di->dataoffsethigh,
8505a7e652c8a3 drivers/net/wireless/brcm80211/brcmsmac/dma.c Joe Perches 2011-11-13 705 di->addrext);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 706
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 707 return (struct dma_pub *) di;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 708
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 709 fail:
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 710 dma_detach((struct dma_pub *)di);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 711 return NULL;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 712 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 713
:::::: The code at line 587 was first introduced by commit
:::::: 5b435de0d786869c95d1962121af0d7df2542009 net: wireless: add brcm80211 drivers
:::::: TO: Arend van Spriel <arend(a)broadcom.com>
:::::: CC: John W. Linville <linville(a)tuxdriver.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
- 1
- 0
drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c:587:2: warning: 'strncpy' specified bound 8 equals destination size
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 69119673bd50b176ded34032fadd41530fb5af21
commit: 8ad8b72721d0f07fa02dbe71f901743f9c71c8e6 riscv: Add KASAN support
date: 5 months ago
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 8ad8b72721d0f07fa02dbe71f901743f9c71c8e6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.h:24,
from drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c:26:
drivers/net/wireless/broadcom/brcm80211/brcmsmac/d11.h:786:1: warning: alignment 1 of 'struct d11txh' is less than 2 [-Wpacked-not-aligned]
786 | } __packed;
| ^
drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c: In function 'dma_attach':
>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c:587:2: warning: 'strncpy' specified bound 8 equals destination size [-Wstringop-truncation]
587 | strncpy(di->name, name, MAXNAMEL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/strncpy +587 drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 547
e041f65d5f0001 drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 548 struct dma_pub *dma_attach(char *name, struct brcms_c_info *wlc,
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 549 uint txregbase, uint rxregbase, uint ntxd, uint nrxd,
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 550 uint rxbufsize, int rxextheadroom,
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 551 uint nrxpost, uint rxoffset)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 552 {
e041f65d5f0001 drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 553 struct si_pub *sih = wlc->hw->sih;
e041f65d5f0001 drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 554 struct bcma_device *core = wlc->hw->d11core;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 555 struct dma_info *di;
3b758a68402fc5 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-12 556 u8 rev = core->id.rev;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 557 uint size;
ec5ab1dd73a4b2 drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 558 struct si_info *sii = container_of(sih, struct si_info, pub);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 559
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 560 /* allocate private info structure */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 561 di = kzalloc(sizeof(struct dma_info), GFP_ATOMIC);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 562 if (di == NULL)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 563 return NULL;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 564
a8779e4a8e7f0f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 565 di->dma64 =
3b758a68402fc5 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-12 566 ((bcma_aread32(core, BCMA_IOST) & SISF_DMA64) == SISF_DMA64);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 567
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 568 /* init dma reg info */
3b758a68402fc5 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-12 569 di->core = core;
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 570 di->d64txregbase = txregbase;
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 571 di->d64rxregbase = rxregbase;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 572
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 573 /*
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 574 * Default flags (which can be changed by the driver calling
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 575 * dma_ctrlflags before enable): For backwards compatibility
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 576 * both Rx Overflow Continue and Parity are DISABLED.
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 577 */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 578 _dma_ctrlflags(di, DMA_CTRL_ROC | DMA_CTRL_PEN, 0);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 579
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 580 brcms_dbg_dma(di->core, "%s: %s flags 0x%x ntxd %d nrxd %d "
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 581 "rxbufsize %d rxextheadroom %d nrxpost %d rxoffset %d "
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 582 "txregbase %u rxregbase %u\n", name, "DMA64",
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 583 di->dma.dmactrlflags, ntxd, nrxd, rxbufsize,
e81da6501b433f drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-08 584 rxextheadroom, nrxpost, rxoffset, txregbase, rxregbase);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 585
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 586 /* make a private copy of our callers name */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 @587 strncpy(di->name, name, MAXNAMEL);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 588 di->name[MAXNAMEL - 1] = '\0';
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 589
3b758a68402fc5 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-12 590 di->dmadev = core->dma_dev;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 591
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 592 /* save tunables */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 593 di->ntxd = (u16) ntxd;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 594 di->nrxd = (u16) nrxd;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 595
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 596 /* the actual dma size doesn't include the extra headroom */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 597 di->rxextrahdrroom =
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 598 (rxextheadroom == -1) ? BCMEXTRAHDROOM : rxextheadroom;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 599 if (rxbufsize > BCMEXTRAHDROOM)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 600 di->rxbufsize = (u16) (rxbufsize - di->rxextrahdrroom);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 601 else
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 602 di->rxbufsize = (u16) rxbufsize;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 603
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 604 di->nrxpost = (u16) nrxpost;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 605 di->rxoffset = (u8) rxoffset;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 606
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 607 /*
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 608 * figure out the DMA physical address offset for dd and data
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 609 * PCI/PCIE: they map silicon backplace address to zero
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 610 * based memory, need offset
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 611 * Other bus: use zero SI_BUS BIGENDIAN kludge: use sdram
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 612 * swapped region for data buffer, not descriptor
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 613 */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 614 di->ddoffsetlow = 0;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 615 di->dataoffsetlow = 0;
ec5ab1dd73a4b2 drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 616 /* for pci bus, add offset */
ec5ab1dd73a4b2 drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 617 if (sii->icbus->hosttype == BCMA_HOSTTYPE_PCI) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 618 /* add offset for pcie with DMA64 bus */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 619 di->ddoffsetlow = 0;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 620 di->ddoffsethigh = SI_PCIE_DMA_H32;
ec5ab1dd73a4b2 drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 621 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 622 di->dataoffsetlow = di->ddoffsetlow;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 623 di->dataoffsethigh = di->ddoffsethigh;
ec5ab1dd73a4b2 drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 624
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 625 /* WAR64450 : DMACtl.Addr ext fields are not supported in SDIOD core. */
780b9c4644616f drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 626 if ((core->id.id == BCMA_CORE_SDIO_DEV)
3b758a68402fc5 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-12 627 && ((rev > 0) && (rev <= 2)))
3db1cd5c05f35f drivers/net/wireless/brcm80211/brcmsmac/dma.c Rusty Russell 2011-12-19 628 di->addrext = false;
780b9c4644616f drivers/net/wireless/brcm80211/brcmsmac/dma.c Hauke Mehrtens 2012-06-30 629 else if ((core->id.id == BCMA_CORE_I2S) &&
3b758a68402fc5 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-12-12 630 ((rev == 0) || (rev == 1)))
3db1cd5c05f35f drivers/net/wireless/brcm80211/brcmsmac/dma.c Rusty Russell 2011-12-19 631 di->addrext = false;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 632 else
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 633 di->addrext = _dma_isaddrext(di);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 634
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 635 /* does the descriptor need to be aligned and if yes, on 4K/8K or not */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 636 di->aligndesc_4k = _dma_descriptor_align(di);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 637 if (di->aligndesc_4k) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 638 di->dmadesc_align = D64RINGALIGN_BITS;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 639 if ((ntxd < D64MAXDD / 2) && (nrxd < D64MAXDD / 2))
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 640 /* for smaller dd table, HW relax alignment reqmnt */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 641 di->dmadesc_align = D64RINGALIGN_BITS - 1;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 642 } else {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 643 di->dmadesc_align = 4; /* 16 byte alignment */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 644 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 645
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 646 brcms_dbg_dma(di->core, "DMA descriptor align_needed %d, align %d\n",
8505a7e652c8a3 drivers/net/wireless/brcm80211/brcmsmac/dma.c Joe Perches 2011-11-13 647 di->aligndesc_4k, di->dmadesc_align);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 648
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 649 /* allocate tx packet pointer vector */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 650 if (ntxd) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 651 size = ntxd * sizeof(void *);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 652 di->txp = kzalloc(size, GFP_ATOMIC);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 653 if (di->txp == NULL)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 654 goto fail;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 655 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 656
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 657 /* allocate rx packet pointer vector */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 658 if (nrxd) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 659 size = nrxd * sizeof(void *);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 660 di->rxp = kzalloc(size, GFP_ATOMIC);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 661 if (di->rxp == NULL)
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 662 goto fail;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 663 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 664
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 665 /*
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 666 * allocate transmit descriptor ring, only need ntxd descriptors
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 667 * but it must be aligned
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 668 */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 669 if (ntxd) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 670 if (!_dma_alloc(di, DMA_TX))
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 671 goto fail;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 672 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 673
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 674 /*
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 675 * allocate receive descriptor ring, only need nrxd descriptors
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 676 * but it must be aligned
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 677 */
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 678 if (nrxd) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 679 if (!_dma_alloc(di, DMA_RX))
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 680 goto fail;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 681 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 682
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 683 if ((di->ddoffsetlow != 0) && !di->addrext) {
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 684 if (di->txdpa > SI_PCI_DMA_SZ) {
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 685 brcms_dbg_dma(di->core,
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 686 "%s: txdpa 0x%x: addrext not supported\n",
8505a7e652c8a3 drivers/net/wireless/brcm80211/brcmsmac/dma.c Joe Perches 2011-11-13 687 di->name, (u32)di->txdpa);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 688 goto fail;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 689 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 690 if (di->rxdpa > SI_PCI_DMA_SZ) {
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 691 brcms_dbg_dma(di->core,
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 692 "%s: rxdpa 0x%x: addrext not supported\n",
8505a7e652c8a3 drivers/net/wireless/brcm80211/brcmsmac/dma.c Joe Perches 2011-11-13 693 di->name, (u32)di->rxdpa);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 694 goto fail;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 695 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 696 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 697
e041f65d5f0001 drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 698 /* Initialize AMPDU session */
e041f65d5f0001 drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 699 brcms_c_ampdu_reset_session(&di->ampdu_session, wlc);
e041f65d5f0001 drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 700
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 701 brcms_dbg_dma(di->core,
90123e045cac4c drivers/net/wireless/brcm80211/brcmsmac/dma.c Seth Forshee 2012-11-15 702 "ddoffsetlow 0x%x ddoffsethigh 0x%x dataoffsetlow 0x%x dataoffsethigh 0x%x addrext %d\n",
8505a7e652c8a3 drivers/net/wireless/brcm80211/brcmsmac/dma.c Joe Perches 2011-11-13 703 di->ddoffsetlow, di->ddoffsethigh,
8505a7e652c8a3 drivers/net/wireless/brcm80211/brcmsmac/dma.c Joe Perches 2011-11-13 704 di->dataoffsetlow, di->dataoffsethigh,
8505a7e652c8a3 drivers/net/wireless/brcm80211/brcmsmac/dma.c Joe Perches 2011-11-13 705 di->addrext);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 706
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 707 return (struct dma_pub *) di;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 708
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 709 fail:
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 710 dma_detach((struct dma_pub *)di);
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 711 return NULL;
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 712 }
5b435de0d78686 drivers/net/wireless/brcm80211/brcmsmac/dma.c Arend van Spriel 2011-10-05 713
:::::: The code at line 587 was first introduced by commit
:::::: 5b435de0d786869c95d1962121af0d7df2542009 net: wireless: add brcm80211 drivers
:::::: TO: Arend van Spriel <arend(a)broadcom.com>
:::::: CC: John W. Linville <linville(a)tuxdriver.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
- 1
- 0
[rhvgoyal:asyncpf-error-v1 7/7] arch/s390/kvm/kvm-s390.c:3982:7: error: too few arguments to function 'kvm_setup_async_pf'
by kernel test robot
tree: https://github.com/rhvgoyal/linux asyncpf-error-v1
head: 94f54bb2e6f969aa7ceb778bb15ac986f3c9cecf
commit: 94f54bb2e6f969aa7ceb778bb15ac986f3c9cecf [7/7] kvm, async_pf: Use FOLL_WRITE only for write faults
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 94f54bb2e6f969aa7ceb778bb15ac986f3c9cecf
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
arch/s390/kvm/kvm-s390.c: In function 'kvm_arch_setup_async_pf':
>> arch/s390/kvm/kvm-s390.c:3982:7: error: too few arguments to function 'kvm_setup_async_pf'
3982 | rc = kvm_setup_async_pf(vcpu, current->thread.gmap_addr, hva, &arch);
| ^~~~~~~~~~~~~~~~~~
In file included from arch/s390/kvm/kvm-s390.c:23:
include/linux/kvm_host.h:216:5: note: declared here
216 | int kvm_setup_async_pf(struct kvm_vcpu *vcpu, gpa_t cr2_or_gpa,
| ^~~~~~~~~~~~~~~~~~
vim +/kvm_setup_async_pf +3982 arch/s390/kvm/kvm-s390.c
3c038e6be0e299 Dominik Dingel 2013-10-07 3956
3c038e6be0e299 Dominik Dingel 2013-10-07 3957 static int kvm_arch_setup_async_pf(struct kvm_vcpu *vcpu)
3c038e6be0e299 Dominik Dingel 2013-10-07 3958 {
3c038e6be0e299 Dominik Dingel 2013-10-07 3959 hva_t hva;
3c038e6be0e299 Dominik Dingel 2013-10-07 3960 struct kvm_arch_async_pf arch;
3c038e6be0e299 Dominik Dingel 2013-10-07 3961 int rc;
3c038e6be0e299 Dominik Dingel 2013-10-07 3962
3c038e6be0e299 Dominik Dingel 2013-10-07 3963 if (vcpu->arch.pfault_token == KVM_S390_PFAULT_TOKEN_INVALID)
3c038e6be0e299 Dominik Dingel 2013-10-07 3964 return 0;
3c038e6be0e299 Dominik Dingel 2013-10-07 3965 if ((vcpu->arch.sie_block->gpsw.mask & vcpu->arch.pfault_select) !=
3c038e6be0e299 Dominik Dingel 2013-10-07 3966 vcpu->arch.pfault_compare)
3c038e6be0e299 Dominik Dingel 2013-10-07 3967 return 0;
3c038e6be0e299 Dominik Dingel 2013-10-07 3968 if (psw_extint_disabled(vcpu))
3c038e6be0e299 Dominik Dingel 2013-10-07 3969 return 0;
9a022067ad75b1 David Hildenbrand 2014-08-05 3970 if (kvm_s390_vcpu_has_irq(vcpu, 0))
3c038e6be0e299 Dominik Dingel 2013-10-07 3971 return 0;
b9224cd7381aea David Hildenbrand 2018-04-30 3972 if (!(vcpu->arch.sie_block->gcr[0] & CR0_SERVICE_SIGNAL_SUBMASK))
3c038e6be0e299 Dominik Dingel 2013-10-07 3973 return 0;
3c038e6be0e299 Dominik Dingel 2013-10-07 3974 if (!vcpu->arch.gmap->pfault_enabled)
3c038e6be0e299 Dominik Dingel 2013-10-07 3975 return 0;
3c038e6be0e299 Dominik Dingel 2013-10-07 3976
81480cc19c56ef Heiko Carstens 2014-01-01 3977 hva = gfn_to_hva(vcpu->kvm, gpa_to_gfn(current->thread.gmap_addr));
81480cc19c56ef Heiko Carstens 2014-01-01 3978 hva += current->thread.gmap_addr & ~PAGE_MASK;
81480cc19c56ef Heiko Carstens 2014-01-01 3979 if (read_guest_real(vcpu, vcpu->arch.pfault_token, &arch.pfault_token, 8))
3c038e6be0e299 Dominik Dingel 2013-10-07 3980 return 0;
3c038e6be0e299 Dominik Dingel 2013-10-07 3981
3c038e6be0e299 Dominik Dingel 2013-10-07 @3982 rc = kvm_setup_async_pf(vcpu, current->thread.gmap_addr, hva, &arch);
3c038e6be0e299 Dominik Dingel 2013-10-07 3983 return rc;
3c038e6be0e299 Dominik Dingel 2013-10-07 3984 }
3c038e6be0e299 Dominik Dingel 2013-10-07 3985
:::::: The code at line 3982 was first introduced by commit
:::::: 3c038e6be0e299d4d3762d0a9a29f02de6e04991 KVM: async_pf: Async page fault support on s390
:::::: TO: Dominik Dingel <dingel(a)linux.vnet.ibm.com>
:::::: CC: Christian Borntraeger <borntraeger(a)de.ibm.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
- 1
- 0
[lkundrak-linux-mmp:lr/ariel 5/41] drivers/gpu/drm/i2c/hx8837.c:471:9: error: too few arguments to function 'priv->panel->funcs->get_modes'
by kernel test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/lkundrak/linux-mmp.git lr/ariel
head: 551dcc39c19e9fe56fe48a92ae52f31367ed8dd0
commit: 3e76766cc78ce69dce80dba27d3aca54e68bdf45 [5/41] Merge remote-tracking branch 'xo/lr/olpc-xo175-fixes5-drm' into merged
config: arc-allyesconfig (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 3e76766cc78ce69dce80dba27d3aca54e68bdf45
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the lkundrak-linux-mmp/lr/ariel HEAD 551dcc39c19e9fe56fe48a92ae52f31367ed8dd0 builds fine.
It only hurts bisectibility.
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/gpu/drm/i2c/hx8837.c: In function 'hx8837_connector_get_modes':
>> drivers/gpu/drm/i2c/hx8837.c:471:9: error: too few arguments to function 'priv->panel->funcs->get_modes'
471 | return priv->panel->funcs->get_modes(priv->panel);
| ^~~~
>> drivers/gpu/drm/i2c/hx8837.c:472:1: warning: control reaches end of non-void function [-Wreturn-type]
472 | }
| ^
At top level:
drivers/gpu/drm/i2c/hx8837.c:739:12: warning: 'hx8837_resume' defined but not used [-Wunused-function]
739 | static int hx8837_resume(struct device *dev)
| ^~~~~~~~~~~~~
drivers/gpu/drm/i2c/hx8837.c:729:12: warning: 'hx8837_suspend' defined but not used [-Wunused-function]
729 | static int hx8837_suspend(struct device *dev)
| ^~~~~~~~~~~~~~
vim +471 drivers/gpu/drm/i2c/hx8837.c
7343a41fc803d40 Lubomir Rintel 2018-09-11 466
7343a41fc803d40 Lubomir Rintel 2018-09-11 467 static int hx8837_connector_get_modes(struct drm_connector *connector)
7343a41fc803d40 Lubomir Rintel 2018-09-11 468 {
7343a41fc803d40 Lubomir Rintel 2018-09-11 469 struct hx8837_priv *priv = container_of(connector, struct hx8837_priv, connector);
7343a41fc803d40 Lubomir Rintel 2018-09-11 470
7343a41fc803d40 Lubomir Rintel 2018-09-11 @471 return priv->panel->funcs->get_modes(priv->panel);
7343a41fc803d40 Lubomir Rintel 2018-09-11 @472 }
7343a41fc803d40 Lubomir Rintel 2018-09-11 473
:::::: The code at line 471 was first introduced by commit
:::::: 7343a41fc803d403df5baf0743061bed74efedc8 drm/i2c: hx8837: add a Himax HX8837 display controller driver
:::::: TO: Lubomir Rintel <lkundrak(a)v3.sk>
:::::: CC: Lubomir Rintel <lkundrak(a)v3.sk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 3 months
- 1
- 0