[broonie-misc:arm64-vdso 4/5] arch/arm64/kernel/vdso/vgetcpu.c:33:5: warning: no previous prototype for '__kernel_getcpu'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git arm64-vdso
head: 6b510319fdb2cc4136a47319f6c5e88195b4bcf0
commit: fdf2f42836c8f11889209ddd41450f6d7d0944e3 [4/5] arm64: vdso: Add getcpu() implementation
config: arm64-randconfig-r006-20200819 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout fdf2f42836c8f11889209ddd41450f6d7d0944e3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/arm64/kernel/vdso/vgetcpu.c:33:5: warning: no previous prototype for '__kernel_getcpu' [-Wmissing-prototypes]
33 | int __kernel_getcpu(unsigned int *cpu, unsigned int *node,
| ^~~~~~~~~~~~~~~
--
arch/arm64/kernel/vdso/vgettimeofday.c:9:5: warning: no previous prototype for '__kernel_clock_gettime' [-Wmissing-prototypes]
9 | int __kernel_clock_gettime(clockid_t clock,
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/vdso/vgettimeofday.c:15:5: warning: no previous prototype for '__kernel_gettimeofday' [-Wmissing-prototypes]
15 | int __kernel_gettimeofday(struct __kernel_old_timeval *tv,
| ^~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/vdso/vgettimeofday.c:21:5: warning: no previous prototype for '__kernel_clock_getres' [-Wmissing-prototypes]
21 | int __kernel_clock_getres(clockid_t clock_id,
| ^~~~~~~~~~~~~~~~~~~~~
>> arch/arm64/kernel/vdso/vgetcpu.c:33:5: warning: no previous prototype for '__kernel_getcpu' [-Wmissing-prototypes]
33 | int __kernel_getcpu(unsigned int *cpu, unsigned int *node,
| ^~~~~~~~~~~~~~~
# https://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git/commit/?...
git remote add broonie-misc https://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git
git fetch --no-tags broonie-misc arm64-vdso
git checkout fdf2f42836c8f11889209ddd41450f6d7d0944e3
vim +/__kernel_getcpu +33 arch/arm64/kernel/vdso/vgetcpu.c
32
> 33 int __kernel_getcpu(unsigned int *cpu, unsigned int *node,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month
Re: [PATCH v2 2/2] Show /proc/self/net only for CAP_NET_ADMIN
by kernel test robot
Hi Alexey,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on kees/for-next/pstore linus/master v5.9-rc1 next-20200819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alexey-Gladkov/proc-Relax-check-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bcf876870b95592b52519ed4aafcf9d95999bc9c
config: s390-randconfig-r034-20200818 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b34b1e38381fa4d1b1d9751a6b5233b68e734cfe)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> fs/proc/root.c:187:24: error: assigning to 'struct cred *' from 'const struct cred *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
fs_info->mounter_cred = get_cred(fc->cred);
^ ~~~~~~~~~~~~~~~~~~
fs/proc/root.c:229:24: error: assigning to 'struct cred *' from 'const struct cred *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
fs_info->mounter_cred = get_cred(fc->cred);
^ ~~~~~~~~~~~~~~~~~~
2 errors generated.
# https://github.com/0day-ci/linux/commit/9c2a0eea7f38b1a4e201b8f2da0c5fd7b...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alexey-Gladkov/proc-Relax-check-of-mount-visibility/20200820-031542
git checkout 9c2a0eea7f38b1a4e201b8f2da0c5fd7b423daf9
vim +187 fs/proc/root.c
164
165 static int proc_fill_super(struct super_block *s, struct fs_context *fc)
166 {
167 struct proc_fs_context *ctx = fc->fs_private;
168 struct inode *root_inode;
169 struct proc_fs_info *fs_info;
170 int ret;
171
172 fs_info = kzalloc(sizeof(*fs_info), GFP_KERNEL);
173 if (!fs_info)
174 return -ENOMEM;
175
176 /* User space would break if executables or devices appear on proc */
177 s->s_iflags |= SB_I_USERNS_VISIBLE | SB_I_NOEXEC | SB_I_NODEV;
178 s->s_flags |= SB_NODIRATIME | SB_NOSUID | SB_NOEXEC;
179 s->s_blocksize = 1024;
180 s->s_blocksize_bits = 10;
181 s->s_magic = PROC_SUPER_MAGIC;
182 s->s_op = &proc_sops;
183 s->s_time_gran = 1;
184 s->s_fs_info = fs_info;
185
186 fs_info->pid_ns = get_pid_ns(ctx->pid_ns);
> 187 fs_info->mounter_cred = get_cred(fc->cred);
188
189 proc_apply_options(s, fc, current_user_ns());
190
191 /*
192 * procfs isn't actually a stacking filesystem; however, there is
193 * too much magic going on inside it to permit stacking things on
194 * top of it
195 */
196 s->s_stack_depth = FILESYSTEM_MAX_STACK_DEPTH;
197
198 /* procfs dentries and inodes don't require IO to create */
199 s->s_shrink.seeks = 0;
200
201 pde_get(&proc_root);
202 root_inode = proc_get_inode(s, &proc_root);
203 if (!root_inode) {
204 pr_err("proc_fill_super: get root inode failed\n");
205 return -ENOMEM;
206 }
207
208 s->s_root = d_make_root(root_inode);
209 if (!s->s_root) {
210 pr_err("proc_fill_super: allocate dentry failed\n");
211 return -ENOMEM;
212 }
213
214 ret = proc_setup_self(s);
215 if (ret) {
216 return ret;
217 }
218 return proc_setup_thread_self(s);
219 }
220
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month
[lee-linaro:tb-fix-w1-warnings 86/106] drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:648:12: warning: variable 'plcp3' set but not used
by kernel test robot
tree: https://git.linaro.org/people/lee.jones/linux.git tb-fix-w1-warnings
head: 31f8a18cb18ed697485d9feb2715719b80a367bc
commit: e4f3b9c321d490413fde83389c8815709eead5ea [86/106] wireless: broadcom: brcm80211: brcmsmac: ampdu: Remove a bunch of unused variables
config: sh-randconfig-r031-20200818 (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout e4f3b9c321d490413fde83389c8815709eead5ea
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/net/wireless/broadcom/brcm80211/brcmsmac/rate.h:21,
from drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:18:
drivers/net/wireless/broadcom/brcm80211/brcmsmac/d11.h:786:1: warning: alignment 1 of 'struct d11txh' is less than 2 [-Wpacked-not-aligned]
786 | } __packed;
| ^
drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In function 'brcms_c_ampdu_finalize':
>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:648:12: warning: variable 'plcp3' set but not used [-Wunused-but-set-variable]
648 | u8 plcp0, plcp3, is40, mcs;
| ^~~~~
drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In function 'brcms_c_ampdu_dotxstatus_complete':
drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:852:7: warning: variable 'update_rate' set but not used [-Wunused-but-set-variable]
852 | bool update_rate = true, retry = true;
| ^~~~~~~~~~~
drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c: In function 'brcms_c_ampdu_dotxstatus':
>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c:1029:20: warning: variable 'scb_ampdu' set but not used [-Wunused-but-set-variable]
1029 | struct scb_ampdu *scb_ampdu;
| ^~~~~~~~~
git remote add lee-linaro https://git.linaro.org/people/lee.jones/linux.git
git fetch --no-tags lee-linaro tb-fix-w1-warnings
git checkout e4f3b9c321d490413fde83389c8815709eead5ea
vim +/plcp3 +648 drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c
625
626 void brcms_c_ampdu_finalize(struct brcms_ampdu_session *session)
627 {
628 struct brcms_c_info *wlc = session->wlc;
629 struct ampdu_info *ampdu = wlc->ampdu;
630 struct sk_buff *first, *last;
631 struct d11txh *txh;
632 struct ieee80211_tx_info *tx_info;
633 struct ieee80211_tx_rate *txrate;
634 u8 ndelim;
635 u8 *plcp;
636 uint len;
637 uint fifo;
638 struct brcms_fifo_info *f;
639 u16 mcl;
640 bool fbr;
641 bool fbr_iscck;
642 struct ieee80211_rts *rts;
643 bool use_rts = false, use_cts = false;
644 u16 dma_len = session->dma_len;
645 u16 mimo_ctlchbw = PHY_TXC1_BW_20MHZ;
646 u32 rspec = 0, rspec_fallback = 0;
647 u32 rts_rspec = 0, rts_rspec_fallback = 0;
> 648 u8 plcp0, plcp3, is40, mcs;
649 u16 mch;
650 u8 preamble_type = BRCMS_GF_PREAMBLE;
651 u8 fbr_preamble_type = BRCMS_GF_PREAMBLE;
652 u8 rts_preamble_type = BRCMS_LONG_PREAMBLE;
653 u8 rts_fbr_preamble_type = BRCMS_LONG_PREAMBLE;
654
655 if (skb_queue_empty(&session->skb_list))
656 return;
657
658 first = skb_peek(&session->skb_list);
659 last = skb_peek_tail(&session->skb_list);
660
661 /* Need to fix up last MPDU first to adjust AMPDU length */
662 txh = (struct d11txh *)last->data;
663 fifo = le16_to_cpu(txh->TxFrameID) & TXFID_QUEUE_MASK;
664 f = &du->fifo_tb[fifo];
665
666 mcl = le16_to_cpu(txh->MacTxControlLow);
667 mcl &= ~TXC_AMPDU_MASK;
668 mcl |= (TXC_AMPDU_LAST << TXC_AMPDU_SHIFT);
669 txh->MacTxControlLow = cpu_to_le16(mcl);
670
671 /* remove the null delimiter after last mpdu */
672 ndelim = txh->RTSPLCPFallback[AMPDU_FBR_NULL_DELIM];
673 txh->RTSPLCPFallback[AMPDU_FBR_NULL_DELIM] = 0;
674 session->ampdu_len -= ndelim * AMPDU_DELIMITER_LEN;
675
676 /* remove the pad len from last mpdu */
677 fbr_iscck = ((le16_to_cpu(txh->XtraFrameTypes) & 0x3) == 0);
678 len = fbr_iscck ? BRCMS_GET_CCK_PLCP_LEN(txh->FragPLCPFallback) :
679 BRCMS_GET_MIMO_PLCP_LEN(txh->FragPLCPFallback);
680 session->ampdu_len -= roundup(len, 4) - len;
681
682 /* Now fix up the first MPDU */
683 tx_info = IEEE80211_SKB_CB(first);
684 txrate = tx_info->status.rates;
685 txh = (struct d11txh *)first->data;
686 plcp = (u8 *)(txh + 1);
687 rts = (struct ieee80211_rts *)&txh->rts_frame;
688
689 mcl = le16_to_cpu(txh->MacTxControlLow);
690 /* If only one MPDU leave it marked as last */
691 if (first != last) {
692 mcl &= ~TXC_AMPDU_MASK;
693 mcl |= (TXC_AMPDU_FIRST << TXC_AMPDU_SHIFT);
694 }
695 mcl |= TXC_STARTMSDU;
696 if (ieee80211_is_rts(rts->frame_control)) {
697 mcl |= TXC_SENDRTS;
698 use_rts = true;
699 }
700 if (ieee80211_is_cts(rts->frame_control)) {
701 mcl |= TXC_SENDCTS;
702 use_cts = true;
703 }
704 txh->MacTxControlLow = cpu_to_le16(mcl);
705
706 fbr = txrate[1].count > 0;
707 if (!fbr) {
708 plcp0 = plcp[0];
709 plcp3 = plcp[3];
710 } else {
711 plcp0 = txh->FragPLCPFallback[0];
712 plcp3 = txh->FragPLCPFallback[3];
713 }
714 is40 = (plcp0 & MIMO_PLCP_40MHZ) ? 1 : 0;
715 mcs = plcp0 & ~MIMO_PLCP_40MHZ;
716
717 if (is40) {
718 if (CHSPEC_SB_UPPER(wlc_phy_chanspec_get(wlc->band->pi)))
719 mimo_ctlchbw = PHY_TXC1_BW_20MHZ_UP;
720 else
721 mimo_ctlchbw = PHY_TXC1_BW_20MHZ;
722 }
723
724 /* rebuild the rspec and rspec_fallback */
725 rspec = RSPEC_MIMORATE;
726 rspec |= plcp[0] & ~MIMO_PLCP_40MHZ;
727 if (plcp[0] & MIMO_PLCP_40MHZ)
728 rspec |= (PHY_TXC1_BW_40MHZ << RSPEC_BW_SHIFT);
729
730 fbr_iscck = !(le16_to_cpu(txh->XtraFrameTypes) & 0x03);
731 if (fbr_iscck) {
732 rspec_fallback =
733 cck_rspec(cck_phy2mac_rate(txh->FragPLCPFallback[0]));
734 } else {
735 rspec_fallback = RSPEC_MIMORATE;
736 rspec_fallback |= txh->FragPLCPFallback[0] & ~MIMO_PLCP_40MHZ;
737 if (txh->FragPLCPFallback[0] & MIMO_PLCP_40MHZ)
738 rspec_fallback |= PHY_TXC1_BW_40MHZ << RSPEC_BW_SHIFT;
739 }
740
741 if (use_rts || use_cts) {
742 rts_rspec =
743 brcms_c_rspec_to_rts_rspec(wlc, rspec,
744 false, mimo_ctlchbw);
745 rts_rspec_fallback =
746 brcms_c_rspec_to_rts_rspec(wlc, rspec_fallback,
747 false, mimo_ctlchbw);
748 }
749
750 BRCMS_SET_MIMO_PLCP_LEN(plcp, session->ampdu_len);
751 /* mark plcp to indicate ampdu */
752 BRCMS_SET_MIMO_PLCP_AMPDU(plcp);
753
754 /* reset the mixed mode header durations */
755 if (txh->MModeLen) {
756 u16 mmodelen = brcms_c_calc_lsig_len(wlc, rspec,
757 session->ampdu_len);
758 txh->MModeLen = cpu_to_le16(mmodelen);
759 preamble_type = BRCMS_MM_PREAMBLE;
760 }
761 if (txh->MModeFbrLen) {
762 u16 mmfbrlen = brcms_c_calc_lsig_len(wlc, rspec_fallback,
763 session->ampdu_len);
764 txh->MModeFbrLen = cpu_to_le16(mmfbrlen);
765 fbr_preamble_type = BRCMS_MM_PREAMBLE;
766 }
767
768 /* set the preload length */
769 if (mcs_2_rate(mcs, true, false) >= f->dmaxferrate) {
770 dma_len = min(dma_len, f->ampdu_pld_size);
771 txh->PreloadSize = cpu_to_le16(dma_len);
772 } else {
773 txh->PreloadSize = 0;
774 }
775
776 mch = le16_to_cpu(txh->MacTxControlHigh);
777
778 /* update RTS dur fields */
779 if (use_rts || use_cts) {
780 u16 durid;
781 if ((mch & TXC_PREAMBLE_RTS_MAIN_SHORT) ==
782 TXC_PREAMBLE_RTS_MAIN_SHORT)
783 rts_preamble_type = BRCMS_SHORT_PREAMBLE;
784
785 if ((mch & TXC_PREAMBLE_RTS_FB_SHORT) ==
786 TXC_PREAMBLE_RTS_FB_SHORT)
787 rts_fbr_preamble_type = BRCMS_SHORT_PREAMBLE;
788
789 durid = brcms_c_compute_rtscts_dur(wlc, use_cts, rts_rspec,
790 rspec, rts_preamble_type,
791 preamble_type,
792 session->ampdu_len, true);
793 rts->duration = cpu_to_le16(durid);
794 durid = brcms_c_compute_rtscts_dur(wlc, use_cts,
795 rts_rspec_fallback,
796 rspec_fallback,
797 rts_fbr_preamble_type,
798 fbr_preamble_type,
799 session->ampdu_len, true);
800 txh->RTSDurFallback = cpu_to_le16(durid);
801 /* set TxFesTimeNormal */
802 txh->TxFesTimeNormal = rts->duration;
803 /* set fallback rate version of TxFesTimeNormal */
804 txh->TxFesTimeFallback = txh->RTSDurFallback;
805 }
806
807 /* set flag and plcp for fallback rate */
808 if (fbr) {
809 mch |= TXC_AMPDU_FBR;
810 txh->MacTxControlHigh = cpu_to_le16(mch);
811 BRCMS_SET_MIMO_PLCP_AMPDU(plcp);
812 BRCMS_SET_MIMO_PLCP_AMPDU(txh->FragPLCPFallback);
813 }
814
815 brcms_dbg_ht(wlc->hw->d11core, "wl%d: count %d ampdu_len %d\n",
816 wlc->pub->unit, skb_queue_len(&session->skb_list),
817 session->ampdu_len);
818 }
819
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month
[jpirko-mlxsw:petrm_8021qaz 18/18] drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c:1238:22: warning: excess elements in struct initializer
by kernel test robot
tree: https://github.com/jpirko/linux_mlxsw petrm_8021qaz
head: 9695d59b85070316a2336212a26addeff39f3c56
commit: 9695d59b85070316a2336212a26addeff39f3c56 [18/18] more wip
config: riscv-allmodconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 9695d59b85070316a2336212a26addeff39f3c56
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c:1238:3: error: 'const struct mlxsw_sp_port_type_speed_ops' has no member named 'ptys_max_speed'
1238 | .ptys_max_speed = mlxsw_sp1_ptys_max_speed,
| ^~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c:1238:22: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
1238 | .ptys_max_speed = mlxsw_sp1_ptys_max_speed,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c:1238:22: note: (near initialization for 'mlxsw_sp1_port_type_speed_ops')
>> drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c:1238:22: warning: excess elements in struct initializer
drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c:1238:22: note: (near initialization for 'mlxsw_sp1_port_type_speed_ops')
drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c:1660:3: error: 'const struct mlxsw_sp_port_type_speed_ops' has no member named 'ptys_max_speed'
1660 | .ptys_max_speed = mlxsw_sp2_ptys_max_speed,
| ^~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c:1660:22: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
1660 | .ptys_max_speed = mlxsw_sp2_ptys_max_speed,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c:1660:22: note: (near initialization for 'mlxsw_sp2_port_type_speed_ops')
drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c:1660:22: warning: excess elements in struct initializer
drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c:1660:22: note: (near initialization for 'mlxsw_sp2_port_type_speed_ops')
cc1: some warnings being treated as errors
# https://github.com/jpirko/linux_mlxsw/commit/9695d59b85070316a2336212a26a...
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw petrm_8021qaz
git checkout 9695d59b85070316a2336212a26addeff39f3c56
vim +1238 drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c
1232
1233 const struct mlxsw_sp_port_type_speed_ops mlxsw_sp1_port_type_speed_ops = {
1234 .from_ptys_supported_port = mlxsw_sp1_from_ptys_supported_port,
1235 .from_ptys_link = mlxsw_sp1_from_ptys_link,
1236 .from_ptys_speed = mlxsw_sp1_from_ptys_speed,
1237 .from_ptys_speed_duplex = mlxsw_sp1_from_ptys_speed_duplex,
> 1238 .ptys_max_speed = mlxsw_sp1_ptys_max_speed,
1239 .to_ptys_advert_link = mlxsw_sp1_to_ptys_advert_link,
1240 .to_ptys_speed = mlxsw_sp1_to_ptys_speed,
1241 .reg_ptys_eth_pack = mlxsw_sp1_reg_ptys_eth_pack,
1242 .reg_ptys_eth_unpack = mlxsw_sp1_reg_ptys_eth_unpack,
1243 };
1244
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month
Re: [PATCH] add support for battery charging threshold, mute. correctly save ac/dc brightness to hardware registers
by kernel test robot
Hi Kenneth,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.9-rc1 next-20200819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kenneth-Chan/add-support-for-bat...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bcf876870b95592b52519ed4aafcf9d95999bc9c
config: x86_64-randconfig-a014-20200819 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b34b1e38381fa4d1b1d9751a6b5233b68e734cfe)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/platform/x86/panasonic-laptop.c:667:15: warning: overlapping comparisons always evaluate to true [-Wtautological-overlap-compare]
if (val >= 0 || val <= 255) {
~~~~~~~~~^~~~~~~~~~~~~
drivers/platform/x86/panasonic-laptop.c:697:15: warning: overlapping comparisons always evaluate to true [-Wtautological-overlap-compare]
if (val >= 0 || val <= 255) {
~~~~~~~~~^~~~~~~~~~~~~
drivers/platform/x86/panasonic-laptop.c:728:15: warning: overlapping comparisons always evaluate to true [-Wtautological-overlap-compare]
if (val >= 0 || val <= 255) {
~~~~~~~~~^~~~~~~~~~~~~
3 warnings generated.
# https://github.com/0day-ci/linux/commit/1f9eb2351cf22424f1ca39f5068c51fe7...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kenneth-Chan/add-support-for-battery-charging-threshold-mute-correctly-save-ac-dc-brightness-to-hardware-registers/20200819-020600
git checkout 1f9eb2351cf22424f1ca39f5068c51fe74189aba
vim +667 drivers/platform/x86/panasonic-laptop.c
656
657 static ssize_t ac_brightness_store(struct device *dev, struct device_attribute *attr,
658 const char *buf, size_t count)
659 {
660 struct acpi_device *acpi = to_acpi_device(dev);
661 struct pcc_acpi *pcc = acpi_driver_data(acpi);
662 int err, val;
663
664 err = kstrtoint(buf, 0, &val);
665 if (err)
666 return err;
> 667 if (val >= 0 || val <= 255) {
668 acpi_pcc_write_sset(pcc, SINF_AC_CUR_BRIGHT, val);
669 pcc->ac_brightness = val;
670 }
671
672 return count;
673 }
674
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month
[RFC PATCH] hv_utils: HOST_TIMESYNC_DELAY_THRESH can be static
by kernel test robot
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
hv_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
index 1357861fd8aee8..35d126e6f012db 100644
--- a/drivers/hv/hv_util.c
+++ b/drivers/hv/hv_util.c
@@ -290,7 +290,7 @@ static inline u64 reftime_to_ns(u64 reftime)
/*
* Hard coded threshold for host timesync delay: 600 seconds
*/
-const u64 HOST_TIMESYNC_DELAY_THRESH = 600 * NSEC_PER_SEC;
+static const u64 HOST_TIMESYNC_DELAY_THRESH = 600 * NSEC_PER_SEC;
static int hv_get_adj_host_time(struct timespec64 *ts)
{
2 years, 1 month
[peterz-queue:locking/wip 6/7] include/linux/spinlock.h:404:9: sparse: sparse: context imbalance in '_qla1280_wait_for_single_command' - unexpected unlock
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git locking/wip
head: a76254f60dc69826643c45a19418b3e4c67d68f4
commit: 8e0c3933252fff31aaf97b37f660b1a3107debd2 [6/7] lockdep: Only trace IRQ edges
config: i386-randconfig-s001-20200819 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-183-gaa6ede3b-dirty
git checkout 8e0c3933252fff31aaf97b37f660b1a3107debd2
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/scsi/qla1280.c:3060:52: sparse: sparse: Using plain integer as NULL pointer
drivers/scsi/qla1280.c:2326:16: sparse: sparse: cast to restricted __le16
drivers/scsi/qla1280.c:645:27: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] isp_parameter @@ got restricted __le16 [usertype] @@
drivers/scsi/qla1280.c:645:27: sparse: expected unsigned short [usertype] isp_parameter
drivers/scsi/qla1280.c:645:27: sparse: got restricted __le16 [usertype]
drivers/scsi/qla1280.c:646:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] w @@ got restricted __le16 [usertype] @@
drivers/scsi/qla1280.c:646:32: sparse: expected unsigned short [usertype] w
drivers/scsi/qla1280.c:646:32: sparse: got restricted __le16 [usertype]
drivers/scsi/qla1280.c:648:46: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] selection_timeout @@ got restricted __le16 [usertype] @@
drivers/scsi/qla1280.c:648:46: sparse: expected unsigned short [usertype] selection_timeout
drivers/scsi/qla1280.c:648:46: sparse: got restricted __le16 [usertype]
drivers/scsi/qla1280.c:649:44: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] max_queue_depth @@ got restricted __le16 [usertype] @@
drivers/scsi/qla1280.c:649:44: sparse: expected unsigned short [usertype] max_queue_depth
drivers/scsi/qla1280.c:649:44: sparse: got restricted __le16 [usertype]
drivers/scsi/qla1280.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/umh.h, include/linux/kmod.h, ...):
>> include/linux/spinlock.h:404:9: sparse: sparse: context imbalance in '_qla1280_wait_for_single_command' - unexpected unlock
include/linux/spinlock.h:404:9: sparse: sparse: context imbalance in 'qla1280_request_firmware' - unexpected unlock
>> include/linux/spinlock.h:404:9: sparse: sparse: context imbalance in 'qla1280_mailbox_command' - unexpected unlock
>> include/linux/spinlock.h:404:9: sparse: sparse: context imbalance in 'qla1280_bus_reset' - unexpected unlock
--
kernel/sched/wait.c: note: in included file (through include/linux/wait.h, include/linux/pid.h, include/linux/sched.h, kernel/sched/sched.h):
>> include/linux/spinlock.h:404:9: sparse: sparse: context imbalance in 'do_wait_intr_irq' - unexpected unlock
--
kernel/locking/rtmutex.c:788:9: sparse: sparse: context imbalance in 'rt_mutex_adjust_prio_chain' - different lock contexts for basic block
>> kernel/locking/rtmutex.c:999:9: sparse: sparse: context imbalance in 'task_blocks_on_rt_mutex' - unexpected unlock
>> kernel/locking/rtmutex.c:1110:9: sparse: sparse: context imbalance in 'remove_waiter' - unexpected unlock
kernel/locking/rtmutex.c:1190:17: sparse: sparse: context imbalance in '__rt_mutex_slowlock' - unexpected unlock
--
>> kernel/time/timer.c:1457:25: sparse: sparse: context imbalance in 'expire_timers' - unexpected unlock
--
drivers/base/power/runtime.c: note: in included file (through include/linux/wait.h, include/linux/pid.h, include/linux/sched.h, ...):
>> include/linux/spinlock.h:404:9: sparse: sparse: context imbalance in '__pm_runtime_barrier' - unexpected unlock
--
drivers/mfd/ti_am335x_tscadc.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/umh.h, include/linux/kmod.h, ...):
>> include/linux/spinlock.h:404:9: sparse: sparse: context imbalance in 'am335x_tscadc_need_adc' - unexpected unlock
# https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?...
git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
git fetch --no-tags peterz-queue locking/wip
git checkout 8e0c3933252fff31aaf97b37f660b1a3107debd2
vim +/_qla1280_wait_for_single_command +404 include/linux/spinlock.h
c2f21ce2e31286 Thomas Gleixner 2009-12-02 401
3490565b633c70 Denys Vlasenko 2015-07-13 402 static __always_inline void spin_unlock_irq(spinlock_t *lock)
c2f21ce2e31286 Thomas Gleixner 2009-12-02 403 {
c2f21ce2e31286 Thomas Gleixner 2009-12-02 @404 raw_spin_unlock_irq(&lock->rlock);
c2f21ce2e31286 Thomas Gleixner 2009-12-02 405 }
c2f21ce2e31286 Thomas Gleixner 2009-12-02 406
:::::: The code at line 404 was first introduced by commit
:::::: c2f21ce2e31286a0a32f8da0a7856e9ca1122ef3 locking: Implement new raw_spinlock
:::::: TO: Thomas Gleixner <tglx(a)linutronix.de>
:::::: CC: Thomas Gleixner <tglx(a)linutronix.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month