drivers/net/ethernet/amd/amd8111e.c:107 amd8111e_read_phy() warn: this loop depends on readl() succeeding
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 990f227371a400c0fbcb98b75c91a7dbd65f6132
commit: 05933aac7b11911955de307a329dc2a7a14b7bd0 ia64: remove now unused machvec indirections
date: 12 months ago
config: ia64-randconfig-m031-20200811 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
New smatch warnings:
drivers/net/ethernet/amd/amd8111e.c:107 amd8111e_read_phy() warn: this loop depends on readl() succeeding
drivers/net/ethernet/amd/amd8111e.c:136 amd8111e_write_phy() warn: this loop depends on readl() succeeding
drivers/scsi/megaraid.c:1224 issue_scb_block() warn: this loop depends on readl() succeeding
drivers/scsi/megaraid.c:1382 megaraid_isr_memmapped() warn: this loop depends on readl() succeeding
drivers/scsi/arcmsr/arcmsr_hba.c:2289 arcmsr_hbaA_doorbell_isr() warn: this loop depends on readl() succeeding
drivers/scsi/arcmsr/arcmsr_hba.c:2315 arcmsr_hbaC_doorbell_isr() warn: this loop depends on readl() succeeding
drivers/scsi/arcmsr/arcmsr_hba.c:2335 arcmsr_hbaD_doorbell_isr() warn: this loop depends on readl() succeeding
drivers/scsi/arcmsr/arcmsr_hba.c:2654 arcmsr_hbaC_handle_isr() warn: this loop depends on readl() succeeding
drivers/scsi/arcmsr/arcmsr_hba.c:2679 arcmsr_hbaD_handle_isr() warn: this loop depends on readl() succeeding
drivers/scsi/arcmsr/arcmsr_hba.c:2704 arcmsr_hbaE_handle_isr() warn: this loop depends on readl() succeeding
drivers/scsi/arcmsr/arcmsr_hba.c:3492 arcmsr_hbaC_polling_ccbdone() warn: this loop depends on readl() succeeding
Old smatch warnings:
drivers/scsi/megaraid.c:3106 megadev_ioctl() error: buffer overflow 'hba_soft_state' 32 <= 27904
drivers/scsi/megaraid.c:3318 megadev_ioctl() error: uninitialized symbol 'data_dma_hndl'.
drivers/scsi/arcmsr/arcmsr_hba.c:1403 arcmsr_drain_donequeue() warn: inconsistent indenting
drivers/scsi/arcmsr/arcmsr_hba.c:3479 arcmsr_hbaC_polling_ccbdone() warn: inconsistent indenting
vim +107 drivers/net/ethernet/amd/amd8111e.c
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 97
13a4fa43bff03b7 drivers/net/ethernet/amd/amd8111e.c Varka Bhadram 2014-07-14 98 /* This function will read the PHY registers. */
46c73ecc6168586 drivers/net/ethernet/amd/amd8111e.c Varka Bhadram 2014-07-14 99 static int amd8111e_read_phy(struct amd8111e_priv *lp,
46c73ecc6168586 drivers/net/ethernet/amd/amd8111e.c Varka Bhadram 2014-07-14 100 int phy_id, int reg, u32 *val)
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 101 {
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 102 void __iomem *mmio = lp->mmio;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 103 unsigned int reg_val;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 104 unsigned int repeat= REPEAT_CNT;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 105
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 106 reg_val = readl(mmio + PHY_ACCESS);
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 @107 while (reg_val & PHY_CMD_ACTIVE)
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 108 reg_val = readl( mmio + PHY_ACCESS );
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 109
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 110 writel( PHY_RD_CMD | ((phy_id & 0x1f) << 21) |
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 111 ((reg & 0x1f) << 16), mmio +PHY_ACCESS);
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 112 do{
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 113 reg_val = readl(mmio + PHY_ACCESS);
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 114 udelay(30); /* It takes 30 us to read/write data */
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 115 } while (--repeat && (reg_val & PHY_CMD_ACTIVE));
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 116 if(reg_val & PHY_RD_ERR)
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 117 goto err_phy_read;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 118
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 119 *val = reg_val & 0xffff;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 120 return 0;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 121 err_phy_read:
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 122 *val = 0;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 123 return -EINVAL;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 124
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 125 }
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 126
13a4fa43bff03b7 drivers/net/ethernet/amd/amd8111e.c Varka Bhadram 2014-07-14 127 /* This function will write into PHY registers. */
46c73ecc6168586 drivers/net/ethernet/amd/amd8111e.c Varka Bhadram 2014-07-14 128 static int amd8111e_write_phy(struct amd8111e_priv *lp,
46c73ecc6168586 drivers/net/ethernet/amd/amd8111e.c Varka Bhadram 2014-07-14 129 int phy_id, int reg, u32 val)
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 130 {
632155e65944968 drivers/net/amd8111e.c Yoann Padioleau 2007-06-01 131 unsigned int repeat = REPEAT_CNT;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 132 void __iomem *mmio = lp->mmio;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 133 unsigned int reg_val;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 134
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 135 reg_val = readl(mmio + PHY_ACCESS);
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 @136 while (reg_val & PHY_CMD_ACTIVE)
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 137 reg_val = readl( mmio + PHY_ACCESS );
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 138
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 139 writel( PHY_WR_CMD | ((phy_id & 0x1f) << 21) |
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 140 ((reg & 0x1f) << 16)|val, mmio + PHY_ACCESS);
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 141
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 142 do{
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 143 reg_val = readl(mmio + PHY_ACCESS);
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 144 udelay(30); /* It takes 30 us to read/write the data */
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 145 } while (--repeat && (reg_val & PHY_CMD_ACTIVE));
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 146
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 147 if(reg_val & PHY_RD_ERR)
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 148 goto err_phy_write;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 149
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 150 return 0;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 151
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 152 err_phy_write:
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 153 return -EINVAL;
^1da177e4c3f415 drivers/net/amd8111e.c Linus Torvalds 2005-04-16 154
:::::: The code at line 107 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds(a)ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds(a)ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month
[intel-linux-intel-lts:5.4/yocto 9244/9293] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:5760:5: sparse: sparse: symbol 'stmmac_all_queue_pairs_enable' was not declared. Should it be
by kernel test robot
tree: https://github.com/intel/linux-intel-lts.git 5.4/yocto
head: 19c99348fd624a151932ed1f9c51390f08d1e293
commit: af5c107dbadcf3645c6ddfe092f522914dcaca12 [9244/9293] net: stmmac: add stmmac_all_queue_pairs_enable|disable() for XDP setup
config: i386-randconfig-s001-20200813 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-168-g9554805c-dirty
git checkout af5c107dbadcf3645c6ddfe092f522914dcaca12
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1462:6: sparse: sparse: symbol 'stmmac_alloc_rx_buffers' was not declared. Should it be static?
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2820:27: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] etdes4 @@ got unsigned long @@
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2820:27: sparse: expected restricted __le32 [usertype] etdes4
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2820:27: sparse: got unsigned long
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2821:27: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] etdes5 @@ got unsigned long @@
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2821:27: sparse: expected restricted __le32 [usertype] etdes5
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2821:27: sparse: got unsigned long
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2822:27: sparse: sparse: invalid assignment: |=
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2822:27: sparse: left side has type restricted __le32
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2822:27: sparse: right side has type unsigned long
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:5760:5: sparse: sparse: symbol 'stmmac_all_queue_pairs_enable' was not declared. Should it be static?
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:5814:5: sparse: sparse: symbol 'stmmac_all_queue_pairs_disable' was not declared. Should it be static?
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:5837:5: sparse: sparse: symbol 'stmmac_xdp_xmit' was not declared. Should it be static?
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:6552:6: sparse: sparse: symbol 'stmmac_clean_all_tx_rings' was not declared. Should it be static?
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:2394:57: sparse: sparse: context imbalance in 'stmmac_tx_clean' - unexpected unlock
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month
Re: [RFC 2/4] kvm: arm64: emulate the ID registers
by kernel test robot
Hi Peng,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on kvm/linux-next]
[also build test ERROR on arm64/for-next/core v5.8 next-20200813]
[cannot apply to kvmarm/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Peng-Liang/kvm-arm64-emulate-ID-...
base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from <command-line>:32:
>> ./usr/include/linux/kvm.h:1277:2: error: unknown type name 'uint64_t'
1277 | uint64_t sys_id;
| ^~~~~~~~
./usr/include/linux/kvm.h:1278:2: error: unknown type name 'uint64_t'
1278 | uint64_t sys_val;
| ^~~~~~~~
./usr/include/linux/kvm.h:1283:2: error: unknown type name 'uint64_t'
1283 | uint64_t num;
| ^~~~~~~~
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month
[frank-w-bpi-r2-4.14:5.8-main 17/66] cc1: error: arch/arm/mach-mt7623//dct/dct: No such file or directory
by kernel test robot
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-main
head: dc60239f8898805845cb00f933859666e4509cc9
commit: 47ca5358d0035b974a89981e97432d30817566a8 [17/66] mt6625l: set MTK_PLATFORM in Makefile if none is set via *config
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 47ca5358d0035b974a89981e97432d30817566a8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
cc1: error: drivers/misc/mediatek/include/mt-plat/mt7623/include: No such file or directory [-Werror=missing-include-dirs]
>> cc1: error: arch/arm/mach-mt7623//dct/dct: No such file or directory [-Werror=missing-include-dirs]
In file included from drivers/misc/mediatek/connectivity/common/common_detect/wmt_gpio.c:15:
drivers/misc/mediatek/connectivity/common/common_detect/wmt_gpio.h:24:10: fatal error: osal.h: No such file or directory
24 | #include "osal.h"
| ^~~~~~~~
cc1: all warnings being treated as errors
compilation terminated.
--
cc1: error: drivers/misc/mediatek/include/mt-plat/mt7623/include: No such file or directory [-Werror=missing-include-dirs]
>> cc1: error: arch/arm/mach-mt7623//dct/dct: No such file or directory [-Werror=missing-include-dirs]
cc1: all warnings being treated as errors
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month
drivers/crypto/chelsio/chcr_ktls.c:391:15: warning: variable 'sk' set but not used
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: dddcbc139e96bd18d8c65ef7b7e440f0d32457c2
commit: 76d7728db724466490c2c3dd4f84c3357f550615 crypto/chcr: IPV6 code needs to be in CONFIG_IPV6
date: 2 months ago
config: ia64-randconfig-r033-20200814 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 76d7728db724466490c2c3dd4f84c3357f550615
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from arch/ia64/include/asm/pgtable.h:154,
from arch/ia64/include/asm/uaccess.h:40,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:34,
from include/linux/highmem.h:5,
from drivers/crypto/chelsio/chcr_ktls.c:5:
arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
arch/ia64/include/asm/mmu_context.h:137:41: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
137 | unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
| ^~~~~~~
drivers/crypto/chelsio/chcr_ktls.c: In function 'chcr_ktls_dev_del':
>> drivers/crypto/chelsio/chcr_ktls.c:391:15: warning: variable 'sk' set but not used [-Wunused-but-set-variable]
391 | struct sock *sk;
| ^~
vim +/sk +391 drivers/crypto/chelsio/chcr_ktls.c
34aba2c45024a08 Rohit Maheshwari 2020-03-07 375
34aba2c45024a08 Rohit Maheshwari 2020-03-07 376 /*
34aba2c45024a08 Rohit Maheshwari 2020-03-07 377 * chcr_ktls_dev_del: call back for tls_dev_del.
34aba2c45024a08 Rohit Maheshwari 2020-03-07 378 * Remove the tid and l2t entry and close the connection.
34aba2c45024a08 Rohit Maheshwari 2020-03-07 379 * it per connection basis.
34aba2c45024a08 Rohit Maheshwari 2020-03-07 380 * @netdev - net device.
34aba2c45024a08 Rohit Maheshwari 2020-03-07 381 * @tls_cts - tls context.
34aba2c45024a08 Rohit Maheshwari 2020-03-07 382 * @direction - TX/RX crypto direction
34aba2c45024a08 Rohit Maheshwari 2020-03-07 383 */
a3ac249a1ab5755 Rohit Maheshwari 2020-06-01 384 void chcr_ktls_dev_del(struct net_device *netdev,
34aba2c45024a08 Rohit Maheshwari 2020-03-07 385 struct tls_context *tls_ctx,
34aba2c45024a08 Rohit Maheshwari 2020-03-07 386 enum tls_offload_ctx_dir direction)
34aba2c45024a08 Rohit Maheshwari 2020-03-07 387 {
34aba2c45024a08 Rohit Maheshwari 2020-03-07 388 struct chcr_ktls_ofld_ctx_tx *tx_ctx =
34aba2c45024a08 Rohit Maheshwari 2020-03-07 389 chcr_get_ktls_tx_context(tls_ctx);
34aba2c45024a08 Rohit Maheshwari 2020-03-07 390 struct chcr_ktls_info *tx_info = tx_ctx->chcr_info;
62370a4f346dda9 Rohit Maheshwari 2020-03-07 @391 struct sock *sk;
34aba2c45024a08 Rohit Maheshwari 2020-03-07 392
34aba2c45024a08 Rohit Maheshwari 2020-03-07 393 if (!tx_info)
34aba2c45024a08 Rohit Maheshwari 2020-03-07 394 return;
62370a4f346dda9 Rohit Maheshwari 2020-03-07 395 sk = tx_info->sk;
34aba2c45024a08 Rohit Maheshwari 2020-03-07 396
34aba2c45024a08 Rohit Maheshwari 2020-03-07 397 spin_lock(&tx_info->lock);
34aba2c45024a08 Rohit Maheshwari 2020-03-07 398 tx_info->connection_state = KTLS_CONN_CLOSED;
34aba2c45024a08 Rohit Maheshwari 2020-03-07 399 spin_unlock(&tx_info->lock);
34aba2c45024a08 Rohit Maheshwari 2020-03-07 400
62370a4f346dda9 Rohit Maheshwari 2020-03-07 401 /* clear l2t entry */
34aba2c45024a08 Rohit Maheshwari 2020-03-07 402 if (tx_info->l2te)
34aba2c45024a08 Rohit Maheshwari 2020-03-07 403 cxgb4_l2t_release(tx_info->l2te);
34aba2c45024a08 Rohit Maheshwari 2020-03-07 404
:::::: The code at line 391 was first introduced by commit
:::::: 62370a4f346dda9a7026445016db5f8eddd533a5 cxgb4/chcr: Add ipv6 support and statistics
:::::: TO: Rohit Maheshwari <rohitm(a)chelsio.com>
:::::: CC: David S. Miller <davem(a)davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month
drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c:354:9: warning: Identical condition 'ret', second condition is always false
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: dc06fe51d26efc100ac74121607c01a454867c91
commit: dfd57dbf44ddc70c90c76f83b2deb46e5dd40ce3 drm/amdgpu: add JPEG3.0 support for Sienna_Cichlid
date: 6 weeks ago
compiler: alpha-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
cppcheck warnings: (new ones prefixed by >>)
In file included from drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/ci_smumgr.c:
>> drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c:416:9: warning: Variable 'result' is reassigned a value before the old one has been used. [redundantAssignment]
result = ci_get_dependency_volt_by_clk(hwmgr,
^
drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c:413:9: note: Variable 'result' is reassigned a value before the old one has been used.
result = ci_calculate_sclk_params(hwmgr, clock, level);
^
drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c:416:9: note: Variable 'result' is reassigned a value before the old one has been used.
result = ci_get_dependency_volt_by_clk(hwmgr,
^
drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c:2235:9: warning: Variable 'result' is reassigned a value before the old one has been used. [redundantAssignment]
result = ci_update_and_upload_mc_reg_table(hwmgr);
^
drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c:2225:10: note: Variable 'result' is reassigned a value before the old one has been used.
result = ci_copy_bytes_to_smc(
^
drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c:2235:9: note: Variable 'result' is reassigned a value before the old one has been used.
result = ci_update_and_upload_mc_reg_table(hwmgr);
^
>> drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:2125:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:2116:6: note: first condition
if (ret)
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:2125:9: note: second condition
return ret;
^
>> drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3216:10: warning: %llx in format string (no. 1) requires 'unsigned long long' but the argument type is 'unsigned long'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "Current ppfeatures: 0x%016llxn", features_enabled);
^
>> drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3296:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "0: %uMhz * (DPM disabled)n",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3314:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "0: %uMhz * (DPM disabled)n",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3332:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "0: %uMhz * (DPM disabled)n",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3362:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "0: %uMhz * (DPM disabled)n",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3452:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "SCLK: %7uMhz %10uMhzn",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3452:12: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "SCLK: %7uMhz %10uMhzn",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3458:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "MCLK: %7uMhz %10uMhzn",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3458:12: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "MCLK: %7uMhz %10uMhzn",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3469:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "VDDC_CURVE_SCLK[0]: %7uMhz %10uMhzn",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3469:12: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "VDDC_CURVE_SCLK[0]: %7uMhz %10uMhzn",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3475:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "VDDC_CURVE_SCLK[1]: %7uMhz %10uMhzn",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3475:12: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "VDDC_CURVE_SCLK[1]: %7uMhz %10uMhzn",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3481:12: warning: %u in format string (no. 1) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "VDDC_CURVE_SCLK[2]: %7uMhz %10uMhzn",
^
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3481:12: warning: %u in format string (no. 2) requires 'unsigned int' but the argument type is 'signed int'. [invalidPrintfArgType_uint]
size += sprintf(buf + size, "VDDC_CURVE_SCLK[2]: %7uMhz %10uMhzn",
^
>> drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c:3946:11: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
size += sprintf(buf + size, "%2d %14s%s:n",
^
>> drivers/gpu/drm/amd/powerplay/smu_v11_0.c:719:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/gpu/drm/amd/powerplay/smu_v11_0.c:716:6: note: first condition
if (ret)
^
drivers/gpu/drm/amd/powerplay/smu_v11_0.c:719:9: note: second condition
return ret;
^
drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1689:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1686:6: note: first condition
if (ret)
^
drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1689:9: note: second condition
return ret;
^
drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1833:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1828:6: note: first condition
if (ret)
^
drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1833:9: note: second condition
return ret;
^
drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1844:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1841:6: note: first condition
if (ret)
^
drivers/gpu/drm/amd/powerplay/smu_v11_0.c:1844:9: note: second condition
return ret;
^
>> drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:1053:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:1048:6: note: first condition
if (ret)
^
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:1053:9: note: second condition
return ret;
^
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:1073:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:1067:6: note: first condition
if (ret)
^
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:1073:9: note: second condition
return ret;
^
>> drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:1402:11: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
size += sprintf(buf + size, "%2d %14s%sn",
^
>> drivers/gpu/drm/amd/powerplay/arcturus_ppt.c:2292:9: warning: %llx in format string (no. 1) requires 'unsigned long long' but the argument type is 'unsigned long'. [invalidPrintfArgType_uint]
size = sprintf(sn, "%llx", id);
^
>> drivers/gpu/drm/amd/powerplay/renoir_ppt.c:411:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/gpu/drm/amd/powerplay/renoir_ppt.c:402:6: note: first condition
if (ret)
^
drivers/gpu/drm/amd/powerplay/renoir_ppt.c:411:9: note: second condition
return ret;
^
drivers/gpu/drm/amd/powerplay/renoir_ppt.c:726:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/gpu/drm/amd/powerplay/renoir_ppt.c:723:6: note: first condition
if (ret)
^
drivers/gpu/drm/amd/powerplay/renoir_ppt.c:726:9: note: second condition
return ret;
^
>> drivers/gpu/drm/amd/powerplay/renoir_ppt.c:864:11: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint]
size += sprintf(buf + size, "%2d %14s%sn",
^
>> drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:184:12: warning: Variable 'object_id' is reassigned a value before the old one has been used. [redundantAssignment]
object_id = object_id_from_bios_object_id(id);
^
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:162:0: note: Variable 'object_id' is reassigned a value before the old one has been used.
struct graphics_object_id object_id = dal_graphics_object_id_init(
^
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:184:12: note: Variable 'object_id' is reassigned a value before the old one has been used.
object_id = object_id_from_bios_object_id(id);
^
>> drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:1064:10: warning: Variable 'result' is reassigned a value before the old one has been used. [redundantAssignment]
result = BP_RESULT_OK;
^
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:1043:10: note: Variable 'result' is reassigned a value before the old one has been used.
result = BP_RESULT_NORECORD;
^
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c:1064:10: note: Variable 'result' is reassigned a value before the old one has been used.
result = BP_RESULT_OK;
^
>> drivers/gpu/drm/amd/display/dc/core/dc_link.c:400:10: warning: Variable 'present' is reassigned a value before the old one has been used. [redundantAssignment]
present = (gpio_result == GPIO_RESULT_OK) && !clock_pin;
^
drivers/gpu/drm/amd/display/dc/core/dc_link.c:359:0: note: Variable 'present' is reassigned a value before the old one has been used.
bool present =
^
drivers/gpu/drm/amd/display/dc/core/dc_link.c:400:10: note: Variable 'present' is reassigned a value before the old one has been used.
present = (gpio_result == GPIO_RESULT_OK) && !clock_pin;
^
>> drivers/gpu/drm/amd/display/dc/core/dc_link.c:3486:6: warning: Uninitialized variable: link_stream [uninitvar]
if (link_stream->dpms_off)
^
>> drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c:354:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c:351:6: note: first condition
if (ret)
^
drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c:354:9: note: second condition
return ret;
^
vim +/ret +354 drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c
342
343 static int jpeg_v3_0_wait_for_idle(void *handle)
344 {
345 struct amdgpu_device *adev = (struct amdgpu_device *)handle;
346 int ret = 0;
347
348 SOC15_WAIT_ON_RREG(JPEG, 0, mmUVD_JRBC_STATUS,
349 UVD_JRBC_STATUS__RB_JOB_DONE_MASK,
350 UVD_JRBC_STATUS__RB_JOB_DONE_MASK, ret);
351 if (ret)
352 return ret;
353
> 354 return ret;
355 }
356
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month
[PATCH] tree-wide: fix memdup_user.cocci warnings
by kernel test robot
From: kernel test robot <lkp(a)intel.com>
mm/util.c:198:5-13: WARNING opportunity for vmemdup_user
Use memdup_user rather than duplicating its implementation
This is a little bit restricted to reduce false positives
Generated by: scripts/coccinelle/api/memdup_user.cocci
CC: Josef Bacik <josef(a)toxicpanda.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
url: https://github.com/0day-ci/linux/commits/Josef-Bacik/proc-use-vmalloc-for...
base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
Please take the patch only if it's a positive warning. Thanks!
util.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
--- a/mm/util.c
+++ b/mm/util.c
@@ -195,14 +195,9 @@ void *kvmemdup_user(const void __user *s
{
void *p;
- p = kvmalloc(len, GFP_USER);
- if (!p)
- return ERR_PTR(-ENOMEM);
-
- if (copy_from_user(p, src, len)) {
- kvfree(p);
- return ERR_PTR(-EFAULT);
- }
+ p = vmemdup_user(src, len);
+ if (IS_ERR(p))
+ return ERR_PTR(PTR_ERR(p));
return p;
}
2 years, 1 month
Re: [PATCH] dmaengine: dw-edma: Fix linked list physical address calculation on non-64 bits architectures
by kernel test robot
Hi Gustavo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on v5.8 next-20200813]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Gustavo-Pimentel/dmaengine-dw-ed...
base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
config: x86_64-randconfig-m001-20200811 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
smatch warnings:
drivers/dma/dw-edma/dw-edma-v0-core.c:233 dw_edma_v0_core_write_chunk() warn: inconsistent indenting
drivers/dma/dw-edma/dw-edma-v0-core.c:266 dw_edma_v0_core_start() warn: inconsistent indenting
vim +233 drivers/dma/dw-edma/dw-edma-v0-core.c
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 191
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 192 static void dw_edma_v0_core_write_chunk(struct dw_edma_chunk *chunk)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 193 {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 194 struct dw_edma_burst *child;
756c3ef93492af Arnd Bergmann 2019-07-22 195 struct dw_edma_v0_lli __iomem *lli;
756c3ef93492af Arnd Bergmann 2019-07-22 196 struct dw_edma_v0_llp __iomem *llp;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 197 u32 control = 0, i = 0;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 198 int j;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 199
756c3ef93492af Arnd Bergmann 2019-07-22 200 lli = chunk->ll_region.vaddr;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 201
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 202 if (chunk->cb)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 203 control = DW_EDMA_V0_CB;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 204
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 205 j = chunk->bursts_alloc;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 206 list_for_each_entry(child, &chunk->burst->list, list) {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 207 j--;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 208 if (!j)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 209 control |= (DW_EDMA_V0_LIE | DW_EDMA_V0_RIE);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 210
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 211 /* Channel control */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 212 SET_LL(&lli[i].control, control);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 213 /* Transfer size */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 214 SET_LL(&lli[i].transfer_size, child->sz);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 215 /* SAR - low, high */
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 216 SET_LL(&lli[i].sar_low, lower_32_bits(child->sar));
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 217 SET_LL(&lli[i].sar_high, upper_32_bits(child->sar));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 218 /* DAR - low, high */
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 219 SET_LL(&lli[i].dar_low, lower_32_bits(child->dar));
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 220 SET_LL(&lli[i].dar_high, upper_32_bits(child->dar));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 221 i++;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 222 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 223
756c3ef93492af Arnd Bergmann 2019-07-22 224 llp = (void __iomem *)&lli[i];
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 225 control = DW_EDMA_V0_LLP | DW_EDMA_V0_TCB;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 226 if (!chunk->cb)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 227 control |= DW_EDMA_V0_CB;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 228
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 229 /* Channel control */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 230 SET_LL(&llp->control, control);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 231 /* Linked list - low, high */
c6442f1a5db52e Gustavo Pimentel 2020-08-13 232 #ifdef CONFIG_PHYS_ADDR_T_64BIT
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 @233 SET_LL(&llp->llp_low, lower_32_bits(chunk->ll_region.paddr));
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 234 SET_LL(&llp->llp_high, upper_32_bits(chunk->ll_region.paddr));
c6442f1a5db52e Gustavo Pimentel 2020-08-13 235 #else /* CONFIG_PHYS_ADDR_T_64BIT */
c6442f1a5db52e Gustavo Pimentel 2020-08-13 236 SET_LL(&llp->llp_low, chunk->ll_region.paddr);
c6442f1a5db52e Gustavo Pimentel 2020-08-13 237 SET_LL(&llp->llp_high, 0x0);
c6442f1a5db52e Gustavo Pimentel 2020-08-13 238 #endif /* CONFIG_PHYS_ADDR_T_64BIT */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 239 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 240
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 241 void dw_edma_v0_core_start(struct dw_edma_chunk *chunk, bool first)
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 242 {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 243 struct dw_edma_chan *chan = chunk->chan;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 244 struct dw_edma *dw = chan->chip->dw;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 245 u32 tmp;
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 246
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 247 dw_edma_v0_core_write_chunk(chunk);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 248
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 249 if (first) {
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 250 /* Enable engine */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 251 SET_RW(dw, chan->dir, engine_en, BIT(0));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 252 /* Interrupt unmask - done, abort */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 253 tmp = GET_RW(dw, chan->dir, int_mask);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 254 tmp &= ~FIELD_PREP(EDMA_V0_DONE_INT_MASK, BIT(chan->id));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 255 tmp &= ~FIELD_PREP(EDMA_V0_ABORT_INT_MASK, BIT(chan->id));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 256 SET_RW(dw, chan->dir, int_mask, tmp);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 257 /* Linked list error */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 258 tmp = GET_RW(dw, chan->dir, linked_list_err_en);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 259 tmp |= FIELD_PREP(EDMA_V0_LINKED_LIST_ERR_MASK, BIT(chan->id));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 260 SET_RW(dw, chan->dir, linked_list_err_en, tmp);
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 261 /* Channel control */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 262 SET_CH(dw, chan->dir, chan->id, ch_control1,
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 263 (DW_EDMA_V0_CCS | DW_EDMA_V0_LLE));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 264 /* Linked list - low, high */
c6442f1a5db52e Gustavo Pimentel 2020-08-13 265 #ifdef CONFIG_PHYS_ADDR_T_64BIT
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 @266 SET_CH(dw, chan->dir, chan->id, llp_low,
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 267 lower_32_bits(chunk->ll_region.paddr));
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 268 SET_CH(dw, chan->dir, chan->id, llp_high,
6f4722b1d1ebf2 Arnd Bergmann 2019-07-22 269 upper_32_bits(chunk->ll_region.paddr));
c6442f1a5db52e Gustavo Pimentel 2020-08-13 270 #else /* CONFIG_PHYS_ADDR_T_64BIT */
c6442f1a5db52e Gustavo Pimentel 2020-08-13 271 SET_CH(dw, chan->dir, chan->id, llp_low,
c6442f1a5db52e Gustavo Pimentel 2020-08-13 272 chunk->ll_region.paddr);
c6442f1a5db52e Gustavo Pimentel 2020-08-13 273 SET_CH(dw, chan->dir, chan->id, llp_high, 0x0);
c6442f1a5db52e Gustavo Pimentel 2020-08-13 274 #endif /* CONFIG_PHYS_ADDR_T_64BIT*/
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 275 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 276 /* Doorbell */
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 277 SET_RW(dw, chan->dir, doorbell,
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 278 FIELD_PREP(EDMA_V0_DOORBELL_CH_MASK, chan->id));
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 279 }
7e4b8a4fbe2cec Gustavo Pimentel 2019-06-04 280
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month
[rcu:dev.2020.08.11a 110/112] ERROR: modpost: "rcu_read_unlock_strict" undefined!
by kernel test robot
Hi Paul,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.08.11a
head: 9030fc13639a71b15466520f09ca07b80fc30ed1
commit: 601cd69fa4bb0127bb774cc852203fd9fdf5e269 [110/112] rcuperf: Change rcuperf to rcuscale
config: riscv-allmodconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 601cd69fa4bb0127bb774cc852203fd9fdf5e269
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/wireless/intel/iwlegacy/iwl4965.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/wireless/intel/iwlegacy/iwlegacy.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/wireless/ath/ath11k/ath11k.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/wireless/ath/ath10k/ath10k_core.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/wireless/ath/carl9170/carl9170.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/wireless/ath/ath9k/ath9k_htc.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/wireless/ath/ath9k/ath9k_hw.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/wireless/ath/ath9k/ath9k.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/wan/lapbether.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/wan/hdlc_cisco.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/hamradio/bpqether.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/via/via-velocity.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/ti/ti_cpsw_new.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/ti/ti_cpsw.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/socionext/netsec.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/sfc/sfc.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/qlogic/qede/qede.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/qlogic/netxen/netxen_nic.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/qlogic/qlcnic/qlcnic.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/netronome/nfp/nfp.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/mscc/mscc_ocelot_common.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/mellanox/mlxsw/mlxsw_spectrum.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/mellanox/mlxsw/mlxsw_core.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/mellanox/mlx4/mlx4_en.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/mellanox/mlx4/mlx4_core.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/marvell/mvneta.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/intel/ice/ice.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/intel/fm10k/fm10k.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/intel/iavf/iavf.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/intel/ixgbevf/ixgbevf.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/intel/ixgbe/ixgbe.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/intel/igc/igc.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/intel/igb/igb.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/chelsio/cxgb4/cxgb4.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/chelsio/cxgb3/cxgb3.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/cavium/thunder/nicvf.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/broadcom/bnxt/bnxt_en.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/broadcom/bnx2x/bnx2x.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/broadcom/cnic.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/broadcom/bnx2.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/net/ethernet/amazon/ena/ena.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/nvme/target/nvmet.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/scsi/cxgbi/cxgb3i/cxgb3i.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/scsi/cxgbi/libcxgbi.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/scsi/qedf/qedf.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/scsi/bnx2fc/bnx2fc.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/scsi/fcoe/fcoe.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/scsi/libfc/libfc.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/scsi/scsi_mod.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/scsi/device_handler/scsi_dh_alua.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/scsi/device_handler/scsi_dh_rdac.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/dma-buf/dmabuf_selftests.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/mfd/dln2.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/block/drbd/drbd.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/block/loop.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/block/brd.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/block/rnbd/rnbd-server.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/gpu/drm/panfrost/panfrost.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/gpu/drm/etnaviv/etnaviv.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/gpu/drm/qxl/qxl.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/gpu/drm/ttm/ttm.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/gpu/drm/drm.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/gpu/drm/drm_kms_helper.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/dma/plx_dma.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/dma/sh/shdma.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [drivers/char/ipmi/ipmi_msghandler.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [lib/objagg.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [lib/crc-t10dif.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [lib/test_lockup.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [lib/test_meminit.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [lib/test_xarray.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [lib/test_rhashtable.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [lib/math/prime_numbers.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [block/bfq.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [crypto/af_alg.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/erofs/erofs.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/ceph/ceph.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/gfs2/gfs2.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/btrfs/btrfs.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/afs/kafs.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/xfs/xfs.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/fuse/fuse.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/autofs/autofs4.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/cifs/cifs.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/lockd/lockd.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/nfsd/nfsd.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/nfs/flexfilelayout/nfs_layout_flexfiles.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/nfs/blocklayout/blocklayoutdriver.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/nfs/nfsv4.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/nfs/nfs.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/jbd2/jbd2.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/ext4/ext4.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/fscache/fscache.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [fs/nfs_common/grace.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [kernel/rcu/refscale.ko] undefined!
>> ERROR: modpost: "rcu_read_unlock_strict" [kernel/rcu/rcuscale.ko] undefined!
ERROR: modpost: "rcu_read_unlock_strict" [kernel/rcu/rcutorture.ko] undefined!
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years, 1 month