Re: [PATCH v4] nl80211/cfg80211: support 6 GHz scanning
by kernel test robot
Hi Johannes,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mac80211-next/master]
[also build test ERROR on mac80211/master v5.9-rc5 next-20200916]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Johannes-Berg/nl80211-cfg80211-s...
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/kernel.h:11,
from net/wireless/scan.c:10:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
net/wireless/scan.c: In function 'cfg80211_scan_6ghz':
>> net/wireless/scan.c:839:7: error: implicit declaration of function 'cfg80211_is_psc'; did you mean 'cfg80211_scan'? [-Werror=implicit-function-declaration]
839 | if (cfg80211_is_psc(chan) && !need_scan_psc)
| ^~~~~~~~~~~~~~~
| cfg80211_scan
cc1: some warnings being treated as errors
# https://github.com/0day-ci/linux/commit/6c8ef71e4783e7524ee2a59e264dd6767...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Johannes-Berg/nl80211-cfg80211-support-6-GHz-scanning/20200917-170112
git checkout 6c8ef71e4783e7524ee2a59e264dd67676a5f532
vim +839 net/wireless/scan.c
720
721 static int cfg80211_scan_6ghz(struct cfg80211_registered_device *rdev)
722 {
723 u8 i;
724 struct cfg80211_colocated_ap *ap;
725 int n_channels, count = 0, err;
726 struct cfg80211_scan_request *request, *rdev_req = rdev->scan_req;
727 LIST_HEAD(coloc_ap_list);
728 bool need_scan_psc;
729 const struct ieee80211_sband_iftype_data *iftd;
730
731 rdev_req->scan_6ghz = true;
732
733 if (!rdev->wiphy.bands[NL80211_BAND_6GHZ])
734 return -EOPNOTSUPP;
735
736 iftd = ieee80211_get_sband_iftype_data(rdev->wiphy.bands[NL80211_BAND_6GHZ],
737 rdev_req->wdev->iftype);
738 if (!iftd || !iftd->he_cap.has_he)
739 return -EOPNOTSUPP;
740
741 n_channels = rdev->wiphy.bands[NL80211_BAND_6GHZ]->n_channels;
742
743 if (rdev_req->flags & NL80211_SCAN_FLAG_COLOCATED_6GHZ) {
744 struct cfg80211_internal_bss *intbss;
745
746 spin_lock_bh(&rdev->bss_lock);
747 list_for_each_entry(intbss, &rdev->bss_list, list) {
748 struct cfg80211_bss *res = &intbss->pub;
749
750 count += cfg80211_parse_colocated_ap(res->ies,
751 &coloc_ap_list);
752 }
753 spin_unlock_bh(&rdev->bss_lock);
754 }
755
756 request = kzalloc(struct_size(request, channels, n_channels) +
757 sizeof(*request->scan_6ghz_params) * count,
758 GFP_KERNEL);
759 if (!request) {
760 cfg80211_free_coloc_ap_list(&coloc_ap_list);
761 return -ENOMEM;
762 }
763
764 *request = *rdev_req;
765 request->n_channels = 0;
766 request->scan_6ghz_params =
767 (void *)&request->channels[n_channels];
768
769 /*
770 * PSC channels should not be scanned if all the reported co-located APs
771 * are indicating that all APs in the same ESS are co-located
772 */
773 if (count) {
774 need_scan_psc = false;
775
776 list_for_each_entry(ap, &coloc_ap_list, list) {
777 if (!ap->colocated_ess) {
778 need_scan_psc = true;
779 break;
780 }
781 }
782 } else {
783 need_scan_psc = true;
784 }
785
786 /*
787 * add to the scan request the channels that need to be scanned
788 * regardless of the collocated APs (PSC channels or all channels
789 * in case that NL80211_SCAN_FLAG_COLOCATED_6GHZ is not set)
790 */
791 for (i = 0; i < rdev_req->n_channels; i++) {
792 if (rdev_req->channels[i]->band == NL80211_BAND_6GHZ &&
793 ((need_scan_psc &&
794 cfg80211_channel_is_psc(rdev_req->channels[i])) ||
795 !(rdev_req->flags & NL80211_SCAN_FLAG_COLOCATED_6GHZ))) {
796 cfg80211_scan_req_add_chan(request,
797 rdev_req->channels[i],
798 false);
799 }
800 }
801
802 if (!(rdev_req->flags & NL80211_SCAN_FLAG_COLOCATED_6GHZ))
803 goto skip;
804
805 list_for_each_entry(ap, &coloc_ap_list, list) {
806 bool found = false;
807 struct cfg80211_scan_6ghz_params *scan_6ghz_params =
808 &request->scan_6ghz_params[request->n_6ghz_params];
809 struct ieee80211_channel *chan =
810 ieee80211_get_channel(&rdev->wiphy, ap->center_freq);
811
812 if (!chan || chan->flags & IEEE80211_CHAN_DISABLED)
813 continue;
814
815 for (i = 0; i < rdev_req->n_channels; i++) {
816 if (rdev_req->channels[i] == chan)
817 found = true;
818 }
819
820 if (!found)
821 continue;
822
823 if (request->n_ssids > 0 &&
824 !cfg80211_find_ssid_match(ap, request))
825 continue;
826
827 cfg80211_scan_req_add_chan(request, chan, true);
828 memcpy(scan_6ghz_params->bssid, ap->bssid, ETH_ALEN);
829 scan_6ghz_params->short_ssid = ap->short_ssid;
830 scan_6ghz_params->short_ssid_valid = ap->short_ssid_valid;
831 scan_6ghz_params->unsolicited_probe = ap->unsolicited_probe;
832
833 /*
834 * If a PSC channel is added to the scan and 'need_scan_psc' is
835 * set to false, then all the APs that the scan logic is
836 * interested with on the channel are collocated and thus there
837 * is no need to perform the initial PSC channel listen.
838 */
> 839 if (cfg80211_is_psc(chan) && !need_scan_psc)
840 scan_6ghz_params->psc_no_listen = true;
841
842 request->n_6ghz_params++;
843 }
844
845 skip:
846 cfg80211_free_coloc_ap_list(&coloc_ap_list);
847
848 if (request->n_channels) {
849 struct cfg80211_scan_request *old = rdev->int_scan_req;
850
851 rdev->int_scan_req = request;
852
853 /*
854 * If this scan follows a previous scan, save the scan start
855 * info from the first part of the scan
856 */
857 if (old)
858 rdev->int_scan_req->info = old->info;
859
860 err = rdev_scan(rdev, request);
861 if (err) {
862 rdev->int_scan_req = old;
863 kfree(request);
864 } else {
865 kfree(old);
866 }
867
868 return err;
869 }
870
871 kfree(request);
872 return -EINVAL;
873 }
874
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
Re: [PATCH RFC 4/8] thermal:core:Add genetlink notifications for monitoring falling temperature
by Dan Carpenter
Hi Thara,
url: https://github.com/0day-ci/linux/commits/Thara-Gopinath/Introduce-warming...
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-randconfig-m001-20200917 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/thermal/thermal_core.c:436 handle_thermal_trip() error: uninitialized symbol 'mon_type'.
# https://github.com/0day-ci/linux/commit/602ffc327f610db12c9657821c144d359...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
git checkout 602ffc327f610db12c9657821c144d359c9d1f7f
vim +/mon_type +436 drivers/thermal/thermal_core.c
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 417 static void handle_thermal_trip(struct thermal_zone_device *tz, int trip)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 418 {
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 419 enum thermal_trip_type type;
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 420 enum thermal_trip_monitor_type mon_type;
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 421 int trip_temp, hyst = 0;
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 422
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui 2016-03-18 423 /* Ignore disabled trip points */
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui 2016-03-18 424 if (test_bit(trip, &tz->trips_disabled))
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui 2016-03-18 425 return;
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui 2016-03-18 426
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 427 tz->ops->get_trip_temp(tz, trip, &trip_temp);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 428 tz->ops->get_trip_type(tz, trip, &type);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 429 if (tz->ops->get_trip_hyst)
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 430 tz->ops->get_trip_hyst(tz, trip, &hyst);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 431
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 432 if (tz->ops->get_trip_mon_type)
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 433 tz->ops->get_trip_mon_type(tz, trip, &mon_type);
^^^^^^^^^
Unintialized on else path
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 434
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 435 if (tz->last_temperature != THERMAL_TEMP_INVALID) {
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 @436 if (mon_type == THERMAL_TRIP_MONITOR_FALLING) {
^^^^^^^^
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 437 if (tz->last_temperature > trip_temp &&
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 438 tz->temperature <= trip_temp)
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 439 thermal_notify_tz_trip_down(tz->id, trip);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 440 if (tz->last_temperature <= trip_temp &&
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 441 tz->temperature > (trip_temp + hyst))
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 442 thermal_notify_tz_trip_up(tz->id, trip);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 443 } else {
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 444 if (tz->last_temperature < trip_temp &&
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 445 tz->temperature >= trip_temp)
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 446 thermal_notify_tz_trip_up(tz->id, trip);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 447 if (tz->last_temperature >= trip_temp &&
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 448 tz->temperature < (trip_temp - hyst))
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 449 thermal_notify_tz_trip_down(tz->id, trip);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 450 }
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 451 }
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 452
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 453 if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 454 handle_critical_trips(tz, trip, type);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 455 else
5be52fccaf3d218 drivers/thermal/thermal_core.c Lukasz Luba 2018-10-15 456 handle_non_critical_trips(tz, trip);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 457 /*
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 458 * Alright, we handled this trip successfully.
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 459 * So, start monitoring again.
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 460 */
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 461 monitor_thermal_zone(tz);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 462 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
Re: [PATCH v3] Introduce support for Systems Management Driver over WMI for Dell Systems
by kernel test robot
Hi Divya,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.9-rc5 next-20200916]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Divya-Bharathi/Introduce-support...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bcf876870b95592b52519ed4aafcf9d95999bc9c
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/platform/x86/dell-wmi-enum-attributes.c:9:
>> drivers/platform/x86/dell-wmi-sysman-attributes.h:53:5: warning: no previous prototype for 'get_enumeration_instance_id' [-Wmissing-prototypes]
53 | int get_##type##_instance_id(struct kobject *kobj) \
| ^~~~
drivers/platform/x86/dell-wmi-enum-attributes.c:28:1: note: in expansion of macro 'get_instance_id'
28 | get_instance_id(enumeration);
| ^~~~~~~~~~~~~~~
>> drivers/platform/x86/dell-wmi-enum-attributes.c:57:5: warning: no previous prototype for 'validate_enumeration_input' [-Wmissing-prototypes]
57 | int validate_enumeration_input(int instance_id, const char *buf)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/platform/x86/dell-wmi-int-attributes.c:9:
>> drivers/platform/x86/dell-wmi-sysman-attributes.h:53:5: warning: no previous prototype for 'get_integer_instance_id' [-Wmissing-prototypes]
53 | int get_##type##_instance_id(struct kobject *kobj) \
| ^~~~
drivers/platform/x86/dell-wmi-int-attributes.c:29:1: note: in expansion of macro 'get_instance_id'
29 | get_instance_id(integer);
| ^~~~~~~~~~~~~~~
>> drivers/platform/x86/dell-wmi-int-attributes.c:58:5: warning: no previous prototype for 'validate_integer_input' [-Wmissing-prototypes]
58 | int validate_integer_input(int instance_id, const char *buf)
| ^~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/platform/x86/dell-wmi-string-attributes.c:9:
>> drivers/platform/x86/dell-wmi-sysman-attributes.h:53:5: warning: no previous prototype for 'get_str_instance_id' [-Wmissing-prototypes]
53 | int get_##type##_instance_id(struct kobject *kobj) \
| ^~~~
drivers/platform/x86/dell-wmi-string-attributes.c:28:1: note: in expansion of macro 'get_instance_id'
28 | get_instance_id(str);
| ^~~~~~~~~~~~~~~
>> drivers/platform/x86/dell-wmi-string-attributes.c:57:5: warning: no previous prototype for 'validate_str_input' [-Wmissing-prototypes]
57 | int validate_str_input(int instance_id, const char *buf)
| ^~~~~~~~~~~~~~~~~~
--
In file included from drivers/platform/x86/dell-wmi-passobj-attributes.c:9:
>> drivers/platform/x86/dell-wmi-sysman-attributes.h:53:5: warning: no previous prototype for 'get_po_instance_id' [-Wmissing-prototypes]
53 | int get_##type##_instance_id(struct kobject *kobj) \
| ^~~~
drivers/platform/x86/dell-wmi-passobj-attributes.c:24:1: note: in expansion of macro 'get_instance_id'
24 | get_instance_id(po);
| ^~~~~~~~~~~~~~~
# https://github.com/0day-ci/linux/commit/4809f4528720c1aa027b717b66960848b...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Divya-Bharathi/Introduce-support-for-Systems-Management-Driver-over-WMI-for-Dell-Systems/20200917-145838
git checkout 4809f4528720c1aa027b717b66960848bdae7b58
vim +/get_enumeration_instance_id +53 drivers/platform/x86/dell-wmi-sysman-attributes.h
51
52 #define get_instance_id(type) \
> 53 int get_##type##_instance_id(struct kobject *kobj) \
54 { \
55 int i; \
56 for (i = 0; i <= type##_instances_count; i++) { \
57 if (!(strcmp(kobj->name, type##_data[i].attribute_name))) \
58 return i; \
59 } \
60 return -EIO; \
61 }
62
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[linux-next:master 7459/8629] drivers/clk/samsung/clk-exynos5420.c:1628:4: warning: variable 'hws' is uninitialized when used here
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 860461e4fcaa76200d2d1a53523e0ff7be92e6e8
commit: fec38565411f968a8d8ef207412da65857f2a636 [7459/8629] clk: samsung: Use cached clk_hws instead of __clk_lookup() calls
config: arm-randconfig-r013-20200917 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1321160a26e7e489baf9b10d6de90a342f898960)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
git checkout fec38565411f968a8d8ef207412da65857f2a636
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/clk/samsung/clk-exynos5420.c:1628:4: warning: variable 'hws' is uninitialized when used here [-Wuninitialized]
hws[CLK_MOUT_APLL], hws[CLK_MOUT_MSPLL_CPU], 0x200,
^~~
drivers/clk/samsung/clk-exynos5420.c:1564:21: note: initialize the variable 'hws' to silence this warning
struct clk_hw **hws;
^
= NULL
1 warning generated.
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout fec38565411f968a8d8ef207412da65857f2a636
vim +/hws +1628 drivers/clk/samsung/clk-exynos5420.c
1558
1559 /* register exynos5420 clocks */
1560 static void __init exynos5x_clk_init(struct device_node *np,
1561 enum exynos5x_soc soc)
1562 {
1563 struct samsung_clk_provider *ctx;
1564 struct clk_hw **hws;
1565
1566 if (np) {
1567 reg_base = of_iomap(np, 0);
1568 if (!reg_base)
1569 panic("%s: failed to map registers\n", __func__);
1570 } else {
1571 panic("%s: unable to determine soc\n", __func__);
1572 }
1573
1574 exynos5x_soc = soc;
1575
1576 ctx = samsung_clk_init(np, reg_base, CLK_NR_CLKS);
1577
1578 samsung_clk_of_register_fixed_ext(ctx, exynos5x_fixed_rate_ext_clks,
1579 ARRAY_SIZE(exynos5x_fixed_rate_ext_clks),
1580 ext_clk_match);
1581
1582 if (_get_rate("fin_pll") == 24 * MHZ) {
1583 exynos5x_plls[apll].rate_table = exynos5420_pll2550x_24mhz_tbl;
1584 exynos5x_plls[epll].rate_table = exynos5420_epll_24mhz_tbl;
1585 exynos5x_plls[kpll].rate_table = exynos5420_pll2550x_24mhz_tbl;
1586 exynos5x_plls[vpll].rate_table = exynos5420_vpll_24mhz_tbl;
1587 }
1588
1589 if (soc == EXYNOS5420)
1590 exynos5x_plls[bpll].rate_table = exynos5420_pll2550x_24mhz_tbl;
1591 else
1592 exynos5x_plls[bpll].rate_table = exynos5422_bpll_rate_table;
1593
1594 samsung_clk_register_pll(ctx, exynos5x_plls, ARRAY_SIZE(exynos5x_plls),
1595 reg_base);
1596 samsung_clk_register_fixed_rate(ctx, exynos5x_fixed_rate_clks,
1597 ARRAY_SIZE(exynos5x_fixed_rate_clks));
1598 samsung_clk_register_fixed_factor(ctx, exynos5x_fixed_factor_clks,
1599 ARRAY_SIZE(exynos5x_fixed_factor_clks));
1600 samsung_clk_register_mux(ctx, exynos5x_mux_clks,
1601 ARRAY_SIZE(exynos5x_mux_clks));
1602 samsung_clk_register_div(ctx, exynos5x_div_clks,
1603 ARRAY_SIZE(exynos5x_div_clks));
1604 samsung_clk_register_gate(ctx, exynos5x_gate_clks,
1605 ARRAY_SIZE(exynos5x_gate_clks));
1606
1607 if (soc == EXYNOS5420) {
1608 samsung_clk_register_mux(ctx, exynos5420_mux_clks,
1609 ARRAY_SIZE(exynos5420_mux_clks));
1610 samsung_clk_register_div(ctx, exynos5420_div_clks,
1611 ARRAY_SIZE(exynos5420_div_clks));
1612 samsung_clk_register_gate(ctx, exynos5420_gate_clks,
1613 ARRAY_SIZE(exynos5420_gate_clks));
1614 } else {
1615 samsung_clk_register_fixed_factor(
1616 ctx, exynos5800_fixed_factor_clks,
1617 ARRAY_SIZE(exynos5800_fixed_factor_clks));
1618 samsung_clk_register_mux(ctx, exynos5800_mux_clks,
1619 ARRAY_SIZE(exynos5800_mux_clks));
1620 samsung_clk_register_div(ctx, exynos5800_div_clks,
1621 ARRAY_SIZE(exynos5800_div_clks));
1622 samsung_clk_register_gate(ctx, exynos5800_gate_clks,
1623 ARRAY_SIZE(exynos5800_gate_clks));
1624 }
1625
1626 if (soc == EXYNOS5420) {
1627 exynos_register_cpu_clock(ctx, CLK_ARM_CLK, "armclk",
> 1628 hws[CLK_MOUT_APLL], hws[CLK_MOUT_MSPLL_CPU], 0x200,
1629 exynos5420_eglclk_d, ARRAY_SIZE(exynos5420_eglclk_d), 0);
1630 } else {
1631 exynos_register_cpu_clock(ctx, CLK_ARM_CLK, "armclk",
1632 hws[CLK_MOUT_APLL], hws[CLK_MOUT_MSPLL_CPU], 0x200,
1633 exynos5800_eglclk_d, ARRAY_SIZE(exynos5800_eglclk_d), 0);
1634 }
1635 exynos_register_cpu_clock(ctx, CLK_KFC_CLK, "kfcclk",
1636 hws[CLK_MOUT_KPLL], hws[CLK_MOUT_MSPLL_KFC], 0x28200,
1637 exynos5420_kfcclk_d, ARRAY_SIZE(exynos5420_kfcclk_d), 0);
1638
1639 samsung_clk_extended_sleep_init(reg_base,
1640 exynos5x_clk_regs, ARRAY_SIZE(exynos5x_clk_regs),
1641 exynos5420_set_clksrc, ARRAY_SIZE(exynos5420_set_clksrc));
1642
1643 if (soc == EXYNOS5800) {
1644 samsung_clk_sleep_init(reg_base, exynos5800_clk_regs,
1645 ARRAY_SIZE(exynos5800_clk_regs));
1646
1647 exynos5_subcmus_init(ctx, ARRAY_SIZE(exynos5800_subcmus),
1648 exynos5800_subcmus);
1649 } else {
1650 exynos5_subcmus_init(ctx, ARRAY_SIZE(exynos5x_subcmus),
1651 exynos5x_subcmus);
1652 }
1653
1654 hws = ctx->clk_data.hws;
1655 /*
1656 * Keep top part of G3D clock path enabled permanently to ensure
1657 * that the internal busses get their clock regardless of the
1658 * main G3D clock enablement status.
1659 */
1660 clk_prepare_enable(hws[CLK_MOUT_SW_ACLK_G3D]->clk);
1661 /*
1662 * Keep top BPLL mux enabled permanently to ensure that DRAM operates
1663 * properly.
1664 */
1665 clk_prepare_enable(hws[CLK_MOUT_BPLL]->clk);
1666
1667 samsung_clk_of_add_provider(np, ctx);
1668 }
1669
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[hch-misc:alloc_vm_area 4/7] i915_gem_pages.c:undefined reference to `vmap_pfn'
by kernel test robot
tree: git://git.infradead.org/users/hch/misc.git alloc_vm_area
head: d574728eedb41cee38600f7f2199852e9018a50a
commit: 22728ce0908b9495312398ae96bf901e6b31f664 [4/7] drm/i915: use vmap in i915_gem_object_map
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
git checkout 22728ce0908b9495312398ae96bf901e6b31f664
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
ld: drivers/gpu/drm/i915/gem/i915_gem_pages.o: in function `i915_gem_object_map_nopage':
>> i915_gem_pages.c:(.text+0x140): undefined reference to `vmap_pfn'
>> ld: i915_gem_pages.c:(.text+0x196): undefined reference to `vmap_pfn'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[linux-next:master 6537/8629] drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 860461e4fcaa76200d2d1a53523e0ff7be92e6e8
commit: 8f6b6d0606023c8403ac04ba42177ecbb55769f6 [6537/8629] dmaengine: sf-pdma: Fix an error that calls callback twice
config: mips-randconfig-r014-20200917 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1321160a26e7e489baf9b10d6de90a342f898960)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
git checkout 8f6b6d0606023c8403ac04ba42177ecbb55769f6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc'
struct sf_pdma_desc = chan->desc;
^
fatal error: error in backend: Nested variants found in inline asm string: '.if ( 0x00 ) != -1)) 0x00 ) != -1)) : ($( static struct ftrace_branch_data __attribute__((__aligned__(4))) __attribute__((__section__("_ftrace_branch"))) __if_trace = $( .func = __func__, .file = "arch/mips/include/asm/barrier.h", .line = 16, $); 0x00 ) != -1)) : $))) ) && ( (1 << 0) ); .set push; .set mips64r2; .rept 1; sync 0x00; .endr; .set pop; .else; ; .endif'
clang-12: error: clang frontend command failed with exit code 70 (use -v to see invocation)
clang version 12.0.0 (git://gitmirror/llvm_project 1321160a26e7e489baf9b10d6de90a342f898960)
Target: mips-unknown-linux-gnu
Thread model: posix
InstalledDir: /opt/cross/clang-1321160a26/bin
clang-12: note: diagnostic msg:
Makefile arch drivers include kernel scripts source usr
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 8f6b6d0606023c8403ac04ba42177ecbb55769f6
vim +/desc +287 drivers/dma/sf-pdma/sf-pdma.c
6973886ad58e6b4 Green Wan 2019-11-07 283
6973886ad58e6b4 Green Wan 2019-11-07 284 static void sf_pdma_donebh_tasklet(unsigned long arg)
6973886ad58e6b4 Green Wan 2019-11-07 285 {
6973886ad58e6b4 Green Wan 2019-11-07 286 struct sf_pdma_chan *chan = (struct sf_pdma_chan *)arg;
6973886ad58e6b4 Green Wan 2019-11-07 @287 struct sf_pdma_desc *desc = chan->desc;
6973886ad58e6b4 Green Wan 2019-11-07 288 unsigned long flags;
6973886ad58e6b4 Green Wan 2019-11-07 289
6973886ad58e6b4 Green Wan 2019-11-07 290 spin_lock_irqsave(&chan->lock, flags);
6973886ad58e6b4 Green Wan 2019-11-07 291 if (chan->xfer_err) {
6973886ad58e6b4 Green Wan 2019-11-07 292 chan->retries = MAX_RETRY;
6973886ad58e6b4 Green Wan 2019-11-07 293 chan->status = DMA_COMPLETE;
6973886ad58e6b4 Green Wan 2019-11-07 294 chan->xfer_err = false;
6973886ad58e6b4 Green Wan 2019-11-07 295 }
6973886ad58e6b4 Green Wan 2019-11-07 296 spin_unlock_irqrestore(&chan->lock, flags);
6973886ad58e6b4 Green Wan 2019-11-07 297
8f6b6d0606023c8 Brad Kim 2020-09-03 298 spin_lock_irqsave(&chan->vchan.lock, flags);
8f6b6d0606023c8 Brad Kim 2020-09-03 299 list_del(&chan->desc->vdesc.node);
8f6b6d0606023c8 Brad Kim 2020-09-03 300 vchan_cookie_complete(&chan->desc->vdesc);
8f6b6d0606023c8 Brad Kim 2020-09-03 301 spin_unlock_irqrestore(&chan->vchan.lock, flags);
6973886ad58e6b4 Green Wan 2019-11-07 302 }
6973886ad58e6b4 Green Wan 2019-11-07 303
:::::: The code at line 287 was first introduced by commit
:::::: 6973886ad58e6b4988813331abb76ae0b364a9c2 dmaengine: sf-pdma: add platform DMA support for HiFive Unleashed A00
:::::: TO: Green Wan <green.wan(a)sifive.com>
:::::: CC: Vinod Koul <vkoul(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[PATCH] netdevsim: fix semicolon.cocci warnings
by kernel test robot
From: kernel test robot <lkp(a)intel.com>
drivers/net/netdevsim/port_function.c:122:2-3: Unneeded semicolon
drivers/net/netdevsim/port_function.c:140:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Parav Pandit <parav(a)nvidia.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
url: https://github.com/0day-ci/linux/commits/Parav-Pandit/devlink-Add-SF-add-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git b948577b984a01d24d401d2264efbccc7f0146c1
port_function.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/net/netdevsim/port_function.c
+++ b/drivers/net/netdevsim/port_function.c
@@ -119,7 +119,7 @@ nsim_devlink_port_function_alloc(struct
break;
default:
break;
- };
+ }
return port;
fn_ida_err:
@@ -137,7 +137,7 @@ static void nsim_devlink_port_function_f
break;
default:
break;
- };
+ }
ida_simple_remove(&dev->port_functions.ida, port->port_index);
free_netdev(port->netdev);
}
2 years
[arnd-playground:arm-kill-set_fs-4 31/37] drivers/media/v4l2-core/v4l2-compat-ioctl32.c:898:13: sparse: sparse: incorrect type in argument 1 (different address spaces)
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git arm-kill-set_fs-4
head: 134f7ea9688d79375ef1358d83bbafb8097ca965
commit: ee5be38e6bb994ddeaaab8d7762919f78736a565 [31/37] v4l2: remaining compat handlers
config: x86_64-randconfig-s021-20200917 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-201-g24bdaac6-dirty
git checkout ee5be38e6bb994ddeaaab8d7762919f78736a565
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:1379:9: sparse: sparse: switch with no cases
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:1405:9: sparse: sparse: switch with no cases
>> drivers/media/v4l2-core/v4l2-compat-ioctl32.c:898:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got unsigned int * @@
>> drivers/media/v4l2-core/v4l2-compat-ioctl32.c:898:13: sparse: expected void const volatile [noderef] __user *
>> drivers/media/v4l2-core/v4l2-compat-ioctl32.c:898:13: sparse: got unsigned int *
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:913:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got unsigned int * @@
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:913:13: sparse: expected void const volatile [noderef] __user *
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:913:13: sparse: got unsigned int *
# https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/commi...
git remote add arnd-playground https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git
git fetch --no-tags arnd-playground arm-kill-set_fs-4
git checkout ee5be38e6bb994ddeaaab8d7762919f78736a565
vim +898 drivers/media/v4l2-core/v4l2-compat-ioctl32.c
888
889 static int put_v4l2_event32(struct v4l2_event *p64,
890 struct v4l2_event32 __user *p32)
891 {
892 if (put_user(p64->type, &p32->type) ||
893 copy_to_user(&p32->u, &p64->u, sizeof(p64->u)) ||
894 put_user(p64->pending, &p32->pending) ||
895 put_user(p64->sequence, &p32->sequence) ||
896 put_user(p64->timestamp.tv_sec, &p32->timestamp.tv_sec) ||
897 put_user(p64->timestamp.tv_nsec, &p32->timestamp.tv_nsec) ||
> 898 put_user(p64->id, &p64->id) ||
899 copy_to_user(p32->reserved, p64->reserved, sizeof(p32->reserved)))
900 return -EFAULT;
901 return 0;
902 }
903
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
Re: [PATCH 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver
by Dan Carpenter
Hi "Viorel,
url: https://github.com/0day-ci/linux/commits/Viorel-Suman-OSS/DAI-driver-for-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-randconfig-m021-20200917 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
sound/soc/fsl/fsl_xcvr.c:381 fsl_xcvr_en_aud_pll() warn: 'xcvr->phy_clk' not released on lines: 361.
# https://github.com/0day-ci/linux/commit/87299d2c9ad1b82091b3c273c7b393595...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Viorel-Suman-OSS/DAI-driver-for-new-XCVR-IP/20200916-171921
git checkout 87299d2c9ad1b82091b3c273c7b393595a3325ab
vim +381 sound/soc/fsl/fsl_xcvr.c
87299d2c9ad1b82 Viorel Suman 2020-09-16 339 static int fsl_xcvr_en_aud_pll(struct fsl_xcvr *xcvr, u32 freq)
87299d2c9ad1b82 Viorel Suman 2020-09-16 340 {
87299d2c9ad1b82 Viorel Suman 2020-09-16 341 struct device *dev = &xcvr->pdev->dev;
87299d2c9ad1b82 Viorel Suman 2020-09-16 342 int ret;
87299d2c9ad1b82 Viorel Suman 2020-09-16 343
87299d2c9ad1b82 Viorel Suman 2020-09-16 344 clk_disable_unprepare(xcvr->phy_clk);
We disable clk_disable_unprepare() at the start... I sure hope these
new warnings are correct because I've been sending a lot recently and
I'm not sure I understand the rules.
87299d2c9ad1b82 Viorel Suman 2020-09-16 345 ret = clk_set_rate(xcvr->phy_clk, freq);
87299d2c9ad1b82 Viorel Suman 2020-09-16 346 if (ret < 0) {
87299d2c9ad1b82 Viorel Suman 2020-09-16 347 dev_err(dev, "Error while setting AUD PLL rate: %d\n", ret);
87299d2c9ad1b82 Viorel Suman 2020-09-16 348 return ret;
87299d2c9ad1b82 Viorel Suman 2020-09-16 349 }
87299d2c9ad1b82 Viorel Suman 2020-09-16 350 ret = clk_prepare_enable(xcvr->phy_clk);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Enable
87299d2c9ad1b82 Viorel Suman 2020-09-16 351 if (ret) {
87299d2c9ad1b82 Viorel Suman 2020-09-16 352 dev_err(dev, "failed to start PHY clock: %d\n", ret);
87299d2c9ad1b82 Viorel Suman 2020-09-16 353 return ret;
87299d2c9ad1b82 Viorel Suman 2020-09-16 354 }
87299d2c9ad1b82 Viorel Suman 2020-09-16 355
87299d2c9ad1b82 Viorel Suman 2020-09-16 356 /* Release AI interface from reset */
87299d2c9ad1b82 Viorel Suman 2020-09-16 357 ret = regmap_write(xcvr->regmap, FSL_XCVR_PHY_AI_CTRL_SET,
87299d2c9ad1b82 Viorel Suman 2020-09-16 358 FSL_XCVR_PHY_AI_CTRL_AI_RESETN);
87299d2c9ad1b82 Viorel Suman 2020-09-16 359 if (ret < 0) {
87299d2c9ad1b82 Viorel Suman 2020-09-16 360 dev_err(dev, "Error while setting IER0: %d\n", ret);
87299d2c9ad1b82 Viorel Suman 2020-09-16 361 return ret;
clk_disable_unprepare(xcvr->phy_clk); before returning?
87299d2c9ad1b82 Viorel Suman 2020-09-16 362 }
87299d2c9ad1b82 Viorel Suman 2020-09-16 363
87299d2c9ad1b82 Viorel Suman 2020-09-16 364 if (xcvr->mode == FSL_XCVR_MODE_EARC) { /* eARC mode */
87299d2c9ad1b82 Viorel Suman 2020-09-16 365 /* PHY: CTRL_SET: TX_DIFF_OE, PHY_EN */
87299d2c9ad1b82 Viorel Suman 2020-09-16 366 fsl_xcvr_ai_write(xcvr, FSL_XCVR_PHY_CTRL_SET,
87299d2c9ad1b82 Viorel Suman 2020-09-16 367 FSL_XCVR_PHY_CTRL_TSDIFF_OE |
87299d2c9ad1b82 Viorel Suman 2020-09-16 368 FSL_XCVR_PHY_CTRL_PHY_EN, 1);
87299d2c9ad1b82 Viorel Suman 2020-09-16 369 /* PHY: CTRL2_SET: EARC_TX_MODE */
87299d2c9ad1b82 Viorel Suman 2020-09-16 370 fsl_xcvr_ai_write(xcvr, FSL_XCVR_PHY_CTRL2_SET,
87299d2c9ad1b82 Viorel Suman 2020-09-16 371 FSL_XCVR_PHY_CTRL2_EARC_TXMS, 1);
87299d2c9ad1b82 Viorel Suman 2020-09-16 372 } else { /* SPDIF mode */
87299d2c9ad1b82 Viorel Suman 2020-09-16 373 /* PHY: CTRL_SET: TX_CLK_AUD_SS | SPDIF_EN */
87299d2c9ad1b82 Viorel Suman 2020-09-16 374 fsl_xcvr_ai_write(xcvr, FSL_XCVR_PHY_CTRL_SET,
87299d2c9ad1b82 Viorel Suman 2020-09-16 375 FSL_XCVR_PHY_CTRL_TX_CLK_AUD_SS |
87299d2c9ad1b82 Viorel Suman 2020-09-16 376 FSL_XCVR_PHY_CTRL_SPDIF_EN, 1);
87299d2c9ad1b82 Viorel Suman 2020-09-16 377 }
87299d2c9ad1b82 Viorel Suman 2020-09-16 378
87299d2c9ad1b82 Viorel Suman 2020-09-16 379 dev_dbg(dev, "PLL Fexp: %u\n", freq);
87299d2c9ad1b82 Viorel Suman 2020-09-16 380
87299d2c9ad1b82 Viorel Suman 2020-09-16 @381 return 0;
87299d2c9ad1b82 Viorel Suman 2020-09-16 382 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years