drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for function 'rtw_pci_probe'
by kernel test robot
Hi Zong-Zhe,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 729e3d091984487f7aa1ebfabfe594e5b317ed0f
commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract: export symbols about pci interface
date: 4 months ago
config: x86_64-randconfig-a014-20200912 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 45d0343900d3005d1d00cbb1a87c419c085dec71)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for function 'rtw_pci_probe' [-Wmissing-prototypes]
int rtw_pci_probe(struct pci_dev *pdev,
^
drivers/net/wireless/realtek/rtw88/pci.c:1477:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int rtw_pci_probe(struct pci_dev *pdev,
^
static
>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no previous prototype for function 'rtw_pci_remove' [-Wmissing-prototypes]
void rtw_pci_remove(struct pci_dev *pdev)
^
drivers/net/wireless/realtek/rtw88/pci.c:1557:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void rtw_pci_remove(struct pci_dev *pdev)
^
static
>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous prototype for function 'rtw_pci_shutdown' [-Wmissing-prototypes]
void rtw_pci_shutdown(struct pci_dev *pdev)
^
drivers/net/wireless/realtek/rtw88/pci.c:1579:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void rtw_pci_shutdown(struct pci_dev *pdev)
^
static
drivers/net/wireless/realtek/rtw88/pci.c:88:21: warning: unused function 'rtw_pci_get_tx_desc' [-Wunused-function]
static inline void *rtw_pci_get_tx_desc(struct rtw_pci_tx_ring *tx_ring, u8 idx)
^
4 warnings generated.
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36
vim +/rtw_pci_probe +1477 drivers/net/wireless/realtek/rtw88/pci.c
1476
> 1477 int rtw_pci_probe(struct pci_dev *pdev,
1478 const struct pci_device_id *id)
1479 {
1480 struct ieee80211_hw *hw;
1481 struct rtw_dev *rtwdev;
1482 int drv_data_size;
1483 int ret;
1484
1485 drv_data_size = sizeof(struct rtw_dev) + sizeof(struct rtw_pci);
1486 hw = ieee80211_alloc_hw(drv_data_size, &rtw_ops);
1487 if (!hw) {
1488 dev_err(&pdev->dev, "failed to allocate hw\n");
1489 return -ENOMEM;
1490 }
1491
1492 rtwdev = hw->priv;
1493 rtwdev->hw = hw;
1494 rtwdev->dev = &pdev->dev;
1495 rtwdev->chip = (struct rtw_chip_info *)id->driver_data;
1496 rtwdev->hci.ops = &rtw_pci_ops;
1497 rtwdev->hci.type = RTW_HCI_TYPE_PCIE;
1498
1499 ret = rtw_core_init(rtwdev);
1500 if (ret)
1501 goto err_release_hw;
1502
1503 rtw_dbg(rtwdev, RTW_DBG_PCI,
1504 "rtw88 pci probe: vendor=0x%4.04X device=0x%4.04X rev=%d\n",
1505 pdev->vendor, pdev->device, pdev->revision);
1506
1507 ret = rtw_pci_claim(rtwdev, pdev);
1508 if (ret) {
1509 rtw_err(rtwdev, "failed to claim pci device\n");
1510 goto err_deinit_core;
1511 }
1512
1513 ret = rtw_pci_setup_resource(rtwdev, pdev);
1514 if (ret) {
1515 rtw_err(rtwdev, "failed to setup pci resources\n");
1516 goto err_pci_declaim;
1517 }
1518
1519 ret = rtw_chip_info_setup(rtwdev);
1520 if (ret) {
1521 rtw_err(rtwdev, "failed to setup chip information\n");
1522 goto err_destroy_pci;
1523 }
1524
1525 rtw_pci_phy_cfg(rtwdev);
1526
1527 ret = rtw_register_hw(rtwdev, hw);
1528 if (ret) {
1529 rtw_err(rtwdev, "failed to register hw\n");
1530 goto err_destroy_pci;
1531 }
1532
1533 ret = rtw_pci_request_irq(rtwdev, pdev);
1534 if (ret) {
1535 ieee80211_unregister_hw(hw);
1536 goto err_destroy_pci;
1537 }
1538
1539 return 0;
1540
1541 err_destroy_pci:
1542 rtw_pci_destroy(rtwdev, pdev);
1543
1544 err_pci_declaim:
1545 rtw_pci_declaim(rtwdev, pdev);
1546
1547 err_deinit_core:
1548 rtw_core_deinit(rtwdev);
1549
1550 err_release_hw:
1551 ieee80211_free_hw(hw);
1552
1553 return ret;
1554 }
1555 EXPORT_SYMBOL(rtw_pci_probe);
1556
> 1557 void rtw_pci_remove(struct pci_dev *pdev)
1558 {
1559 struct ieee80211_hw *hw = pci_get_drvdata(pdev);
1560 struct rtw_dev *rtwdev;
1561 struct rtw_pci *rtwpci;
1562
1563 if (!hw)
1564 return;
1565
1566 rtwdev = hw->priv;
1567 rtwpci = (struct rtw_pci *)rtwdev->priv;
1568
1569 rtw_unregister_hw(rtwdev, hw);
1570 rtw_pci_disable_interrupt(rtwdev, rtwpci);
1571 rtw_pci_destroy(rtwdev, pdev);
1572 rtw_pci_declaim(rtwdev, pdev);
1573 rtw_pci_free_irq(rtwdev, pdev);
1574 rtw_core_deinit(rtwdev);
1575 ieee80211_free_hw(hw);
1576 }
1577 EXPORT_SYMBOL(rtw_pci_remove);
1578
> 1579 void rtw_pci_shutdown(struct pci_dev *pdev)
1580 {
1581 struct ieee80211_hw *hw = pci_get_drvdata(pdev);
1582 struct rtw_dev *rtwdev;
1583 struct rtw_chip_info *chip;
1584
1585 if (!hw)
1586 return;
1587
1588 rtwdev = hw->priv;
1589 chip = rtwdev->chip;
1590
1591 if (chip->ops->shutdown)
1592 chip->ops->shutdown(rtwdev);
1593 }
1594 EXPORT_SYMBOL(rtw_pci_shutdown);
1595
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
drivers/net/ethernet/netronome/nfp/crypto/tls.c:477:18: warning: variable 'ipv6h' set but not used
by kernel test robot
Hi Jakub,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 729e3d091984487f7aa1ebfabfe594e5b317ed0f
commit: 6a35ddc5445a8291ced6247a67977e110275acde nfp: tls: implement the stream sync RX resync
date: 9 months ago
config: ia64-randconfig-r005-20200911 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 6a35ddc5445a8291ced6247a67977e110275acde
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_rx_resync_req':
>> drivers/net/ethernet/netronome/nfp/crypto/tls.c:477:18: warning: variable 'ipv6h' set but not used [-Wunused-but-set-variable]
477 | struct ipv6hdr *ipv6h;
| ^~~~~
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 6a35ddc5445a8291ced6247a67977e110275acde
vim +/ipv6h +477 drivers/net/ethernet/netronome/nfp/crypto/tls.c
470
471 int nfp_net_tls_rx_resync_req(struct net_device *netdev,
472 struct nfp_net_tls_resync_req *req,
473 void *pkt, unsigned int pkt_len)
474 {
475 struct nfp_net *nn = netdev_priv(netdev);
476 struct nfp_net_tls_offload_ctx *ntls;
> 477 struct ipv6hdr *ipv6h;
478 struct tcphdr *th;
479 struct iphdr *iph;
480 struct sock *sk;
481 __be32 tcp_seq;
482 int err;
483
484 iph = pkt + req->l3_offset;
485 ipv6h = pkt + req->l3_offset;
486 th = pkt + req->l4_offset;
487
488 if ((u8 *)&th[1] > (u8 *)pkt + pkt_len) {
489 netdev_warn_once(netdev, "invalid TLS RX resync request (l3_off: %hhu l4_off: %hhu pkt_len: %u)\n",
490 req->l3_offset, req->l4_offset, pkt_len);
491 err = -EINVAL;
492 goto err_cnt_ign;
493 }
494
495 switch (iph->version) {
496 case 4:
497 sk = inet_lookup_established(dev_net(netdev), &tcp_hashinfo,
498 iph->saddr, th->source, iph->daddr,
499 th->dest, netdev->ifindex);
500 break;
501 #if IS_ENABLED(CONFIG_IPV6)
502 case 6:
503 sk = __inet6_lookup_established(dev_net(netdev), &tcp_hashinfo,
504 &ipv6h->saddr, th->source,
505 &ipv6h->daddr, ntohs(th->dest),
506 netdev->ifindex, 0);
507 break;
508 #endif
509 default:
510 netdev_warn_once(netdev, "invalid TLS RX resync request (l3_off: %hhu l4_off: %hhu ipver: %u)\n",
511 req->l3_offset, req->l4_offset, iph->version);
512 err = -EINVAL;
513 goto err_cnt_ign;
514 }
515
516 err = 0;
517 if (!sk)
518 goto err_cnt_ign;
519 if (!tls_is_sk_rx_device_offloaded(sk) ||
520 sk->sk_shutdown & RCV_SHUTDOWN)
521 goto err_put_sock;
522
523 ntls = tls_driver_ctx(sk, TLS_OFFLOAD_CTX_DIR_RX);
524 /* some FW versions can't report the handle and report 0s */
525 if (memchr_inv(&req->fw_handle, 0, sizeof(req->fw_handle)) &&
526 memcmp(&req->fw_handle, &ntls->fw_handle, sizeof(ntls->fw_handle)))
527 goto err_put_sock;
528
529 /* copy to ensure alignment */
530 memcpy(&tcp_seq, &req->tcp_seq, sizeof(tcp_seq));
531 tls_offload_rx_resync_request(sk, tcp_seq);
532 atomic_inc(&nn->ktls_rx_resync_req);
533
534 sock_gen_put(sk);
535 return 0;
536
537 err_put_sock:
538 sock_gen_put(sk);
539 err_cnt_ign:
540 atomic_inc(&nn->ktls_rx_resync_ign);
541 return err;
542 }
543
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[rcu:dev.2020.09.07a 23/23] kernel/rcu/rcuscale.c:514 rcu_scale_cleanup() warn: inconsistent indenting
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.09.07a
head: cccf684a1da846c3ff830d553bc4cf97bf779f48
commit: cccf684a1da846c3ff830d553bc4cf97bf779f48 [23/23] rcu-tasks: Mass of debug and fixes
config: x86_64-randconfig-m001-20200911 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
smatch warnings:
kernel/rcu/rcuscale.c:514 rcu_scale_cleanup() warn: inconsistent indenting
kernel/rcu/tasks.h:1245 show_rcu_tasks_trace_gp_kthread() warn: inconsistent indenting
# https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/com...
git remote add rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
git fetch --no-tags rcu dev.2020.09.07a
git checkout cccf684a1da846c3ff830d553bc4cf97bf779f48
vim +514 kernel/rcu/rcuscale.c
504
505 static void
506 rcu_scale_cleanup(void)
507 {
508 int i;
509 int j;
510 int ngps = 0;
511 u64 *wdp;
512 u64 *wdpp;
513
> 514 /*@@@@*/show_rcu_tasks_gp_kthreads();
515
516 /*
517 * Would like warning at start, but everything is expedited
518 * during the mid-boot phase, so have to wait till the end.
519 */
520 if (rcu_gp_is_expedited() && !rcu_gp_is_normal() && !gp_exp)
521 VERBOSE_SCALEOUT_ERRSTRING("All grace periods expedited, no normal ones to measure!");
522 if (rcu_gp_is_normal() && gp_exp)
523 VERBOSE_SCALEOUT_ERRSTRING("All grace periods normal, no expedited ones to measure!");
524 if (gp_exp && gp_async)
525 VERBOSE_SCALEOUT_ERRSTRING("No expedited async GPs, so went with async!");
526
527 if (torture_cleanup_begin())
528 return;
529 if (!cur_ops) {
530 torture_cleanup_end();
531 return;
532 }
533
534 if (reader_tasks) {
535 for (i = 0; i < nrealreaders; i++)
536 torture_stop_kthread(rcu_scale_reader,
537 reader_tasks[i]);
538 kfree(reader_tasks);
539 }
540
541 if (writer_tasks) {
542 for (i = 0; i < nrealwriters; i++) {
543 torture_stop_kthread(rcu_scale_writer,
544 writer_tasks[i]);
545 if (!writer_n_durations)
546 continue;
547 j = writer_n_durations[i];
548 pr_alert("%s%s writer %d gps: %d\n",
549 scale_type, SCALE_FLAG, i, j);
550 ngps += j;
551 }
552 pr_alert("%s%s start: %llu end: %llu duration: %llu gps: %d batches: %ld\n",
553 scale_type, SCALE_FLAG,
554 t_rcu_scale_writer_started, t_rcu_scale_writer_finished,
555 t_rcu_scale_writer_finished -
556 t_rcu_scale_writer_started,
557 ngps,
558 rcuscale_seq_diff(b_rcu_gp_test_finished,
559 b_rcu_gp_test_started));
560 for (i = 0; i < nrealwriters; i++) {
561 if (!writer_durations)
562 break;
563 if (!writer_n_durations)
564 continue;
565 wdpp = writer_durations[i];
566 if (!wdpp)
567 continue;
568 for (j = 0; j <= writer_n_durations[i]; j++) {
569 wdp = &wdpp[j];
570 pr_alert("%s%s %4d writer-duration: %5d %llu\n",
571 scale_type, SCALE_FLAG,
572 i, j, *wdp);
573 if (j % 100 == 0)
574 schedule_timeout_uninterruptible(1);
575 }
576 kfree(writer_durations[i]);
577 }
578 kfree(writer_tasks);
579 kfree(writer_durations);
580 kfree(writer_n_durations);
581 }
582
583 /* Do torture-type-specific cleanup operations. */
584 if (cur_ops->cleanup != NULL)
585 cur_ops->cleanup();
586
587 torture_cleanup_end();
588 }
589
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
Re: [Intel-wired-lan] [next-queue v4] i40e: add support for PTP external synchronization clock
by kernel test robot
Hi Tony,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.9-rc4]
[also build test WARNING on next-20200911]
[cannot apply to jkirsher-next-queue/dev-queue]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Tony-Nguyen/i40e-add-support-for...
base: f4d51dffc6c01a9e94650d95ce0104964f8ae822
config: x86_64-randconfig-s022-20200911 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-191-g10164920-dirty
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/intel/i40e/i40e_ptp.c:1021:50: sparse: sparse: mixing different enum types:
>> drivers/net/ethernet/intel/i40e/i40e_ptp.c:1021:50: sparse: int enum i40e_ptp_led_pin_state
>> drivers/net/ethernet/intel/i40e/i40e_ptp.c:1021:50: sparse: int enum i40e_ptp_gpio_pin_state
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1022:50: sparse: sparse: mixing different enum types:
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1022:50: sparse: int enum i40e_ptp_led_pin_state
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1022:50: sparse: int enum i40e_ptp_gpio_pin_state
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1023:50: sparse: sparse: mixing different enum types:
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1023:50: sparse: int enum i40e_ptp_led_pin_state
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1023:50: sparse: int enum i40e_ptp_gpio_pin_state
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1024:50: sparse: sparse: mixing different enum types:
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1024:50: sparse: int enum i40e_ptp_led_pin_state
drivers/net/ethernet/intel/i40e/i40e_ptp.c:1024:50: sparse: int enum i40e_ptp_gpio_pin_state
# https://github.com/0day-ci/linux/commit/4e1948e563d6b25eca54bd9d4d23c4693...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tony-Nguyen/i40e-add-support-for-PTP-external-synchronization-clock/20200912-081754
git checkout 4e1948e563d6b25eca54bd9d4d23c46936515ba4
vim +1021 drivers/net/ethernet/intel/i40e/i40e_ptp.c
1000
1001 /**
1002 * i40e_ptp_set_pins_hw - Set HW GPIO pins
1003 * @pf: Board private structure
1004 *
1005 * This function sets GPIO pins for PTP
1006 **/
1007 static void i40e_ptp_set_pins_hw(struct i40e_pf *pf)
1008 {
1009 const struct i40e_ptp_pins_settings *pins = pf->ptp_pins;
1010 struct i40e_hw *hw = &pf->hw;
1011
1012 /* pin must be disabled before it may be used */
1013 i40e_ptp_set_pin_hw(hw, I40E_SDP3_2, off);
1014 i40e_ptp_set_pin_hw(hw, I40E_SDP3_3, off);
1015 i40e_ptp_set_pin_hw(hw, I40E_GPIO_4, off);
1016
1017 i40e_ptp_set_pin_hw(hw, I40E_SDP3_2, pins->sdp3_2);
1018 i40e_ptp_set_pin_hw(hw, I40E_SDP3_3, pins->sdp3_3);
1019 i40e_ptp_set_pin_hw(hw, I40E_GPIO_4, pins->gpio_4);
1020
> 1021 i40e_ptp_set_led_hw(hw, I40E_LED2_0, pins->led2_0);
1022 i40e_ptp_set_led_hw(hw, I40E_LED2_1, pins->led2_1);
1023 i40e_ptp_set_led_hw(hw, I40E_LED3_0, pins->led3_0);
1024 i40e_ptp_set_led_hw(hw, I40E_LED3_1, pins->led3_1);
1025
1026 dev_info(&pf->pdev->dev,
1027 "PTP configuration set to: SDP3_2: %s, SDP3_3: %s, GPIO_4: %s.\n",
1028 i40e_ptp_gpio_pin_state2str[pins->sdp3_2],
1029 i40e_ptp_gpio_pin_state2str[pins->sdp3_3],
1030 i40e_ptp_gpio_pin_state2str[pins->gpio_4]);
1031 }
1032
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[hch-misc:dma-ranges.3 8/11] arch/arm/include/asm/dma-direct.h:51:9: error: implicit declaration of function '__arch_dma_to_virt'
by kernel test robot
tree: git://git.infradead.org/users/hch/misc.git dma-ranges.3
head: 96f925f4d8ede34f7b66ae28c768c0e3a9aa2fd4
commit: 4b50a2c3f5f615d625bfef69c53a10fbfefdc315 [8/11] ARM/dma-mapping: move various helpers from dma-mapping.h to dma-direct.h
config: arm-omap1_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 4b50a2c3f5f615d625bfef69c53a10fbfefdc315
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
In file included from include/linux/dma-direct.h:18,
from kernel/dma/mapping.c:10:
arch/arm/include/asm/dma-direct.h: In function 'dma_to_virt':
>> arch/arm/include/asm/dma-direct.h:51:9: error: implicit declaration of function '__arch_dma_to_virt' [-Werror=implicit-function-declaration]
51 | return __arch_dma_to_virt(dev, addr);
| ^~~~~~~~~~~~~~~~~~
>> arch/arm/include/asm/dma-direct.h:51:9: warning: returning 'int' from a function with return type 'void *' makes pointer from integer without a cast [-Wint-conversion]
51 | return __arch_dma_to_virt(dev, addr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
git remote add hch-misc git://git.infradead.org/users/hch/misc.git
git fetch --no-tags hch-misc dma-ranges.3
git checkout 4b50a2c3f5f615d625bfef69c53a10fbfefdc315
vim +/__arch_dma_to_virt +51 arch/arm/include/asm/dma-direct.h
48
49 static inline void *dma_to_virt(struct device *dev, dma_addr_t addr)
50 {
> 51 return __arch_dma_to_virt(dev, addr);
52 }
53
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[cschaufler:next 3/3] security/smack/smack_lsm.c:3866:6: warning: variable 'rc' set but not used
by kernel test robot
tree: https://github.com/cschaufler/smack-next next
head: 322dd63c7f98315b5794653bc582d109841219ae
commit: 322dd63c7f98315b5794653bc582d109841219ae [3/3] Smack: Use the netlabel cache
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 322dd63c7f98315b5794653bc582d109841219ae
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
security/smack/smack_lsm.c: In function 'smack_from_netlbl':
>> security/smack/smack_lsm.c:3866:6: warning: variable 'rc' set but not used [-Wunused-but-set-variable]
3866 | int rc = 0;
| ^~
# https://github.com/cschaufler/smack-next/commit/322dd63c7f98315b5794653bc...
git remote add cschaufler https://github.com/cschaufler/smack-next
git fetch --no-tags cschaufler next
git checkout 322dd63c7f98315b5794653bc582d109841219ae
vim +/rc +3866 security/smack/smack_lsm.c
3848
3849 /**
3850 * smack_from_netlbl - Smack data from the IP options in an skb
3851 * @sk: socket data came in on
3852 * @family: address family
3853 * @skb: packet
3854 *
3855 * Find the Smack label in the IP options. If it hasn't been
3856 * added to the netlabel cache, add it here.
3857 *
3858 * Returns smack_known of the IP options or NULL if that won't work.
3859 */
3860 static struct smack_known *smack_from_netlbl(struct sock *sk, u16 family,
3861 struct sk_buff *skb)
3862 {
3863 struct netlbl_lsm_secattr secattr;
3864 struct socket_smack *ssp = NULL;
3865 struct smack_known *skp = NULL;
> 3866 int rc = 0;
3867
3868 netlbl_secattr_init(&secattr);
3869
3870 if (sk)
3871 ssp = sk->sk_security;
3872
3873 if (netlbl_skbuff_getattr(skb, family, &secattr) == 0) {
3874 skp = smack_from_secattr(&secattr, ssp);
3875 if (secattr.flags & NETLBL_SECATTR_CACHEABLE)
3876 rc = netlbl_cache_add(skb, family, &skp->smk_netlabel);
3877 }
3878
3879 netlbl_secattr_destroy(&secattr);
3880
3881 return skp;
3882 }
3883
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
Re: [RFC PATCH 5/6] security/fbfam: Detect a fork brute force attack
by kernel test robot
Hi Kees,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on tip/sched/core]
[also build test ERROR on kees/for-next/pstore linus/master v5.9-rc4]
[cannot apply to security/next-testing next-20200911]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kees-Cook/Fork-brute-force-attac...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 848785df48835eefebe0c4eb5da7690690b0a8b7
config: microblaze-randconfig-r033-20200911 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
microblaze-linux-ld: security/fbfam/fbfam.o: in function `fbfam_handle_attack':
>> security/fbfam/fbfam.c:206: undefined reference to `__udivdi3'
# https://github.com/0day-ci/linux/commit/2a9c0b8f7327cdab5ef73c9a9a4447d25...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kees-Cook/Fork-brute-force-attack-mitigation-fbfam/20200911-042512
git checkout 2a9c0b8f7327cdab5ef73c9a9a4447d25c084bca
vim +206 security/fbfam/fbfam.c
176
177 /**
178 * fbfam_handle_attack() - Fork brute force attack detection.
179 * @signal: Signal number that causes the core dump.
180 *
181 * The crashing rate of an application is computed in milliseconds per fault in
182 * each crash. So, if this rate goes under a certain threshold there is a clear
183 * signal that the application is crashing quickly. At this moment, a fork brute
184 * force attack is happening.
185 *
186 * Return: -EFAULT if the current task doesn't have statistical data. Zero
187 * otherwise.
188 */
189 int fbfam_handle_attack(int signal)
190 {
191 struct fbfam_stats *stats = current->fbfam_stats;
192 u64 delta_jiffies, delta_time;
193 u64 crashing_rate;
194
195 if (!stats)
196 return -EFAULT;
197
198 if (!(signal == SIGILL || signal == SIGBUS || signal == SIGKILL ||
199 signal == SIGSEGV || signal == SIGSYS))
200 return 0;
201
202 stats->faults += 1;
203
204 delta_jiffies = get_jiffies_64() - stats->jiffies;
205 delta_time = jiffies64_to_msecs(delta_jiffies);
> 206 crashing_rate = delta_time / (u64)stats->faults;
207
208 if (crashing_rate < (u64)sysctl_crashing_rate_threshold)
209 pr_warn("fbfam: Fork brute force attack detected\n");
210
211 return 0;
212 }
213
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
Re: [PATCH net-next 11/13] mptcp: allow picking different xmit subflows
by kernel test robot
Hi Paolo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Paolo-Abeni/mptcp-introduce-supp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9984c0bb22dcae688ef8588e2621133850ff49bc
config: arm-randconfig-c003-20200911 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arm-linux-gnueabi-ld: net/mptcp/protocol.o: in function `mptcp_subflow_get_send':
>> net/mptcp/protocol.c:1109: undefined reference to `__aeabi_ldivmod'
# https://github.com/0day-ci/linux/commit/d7f1745bcd6815d03c0fcf621b9881183...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Paolo-Abeni/mptcp-introduce-support-for-real-multipath-xmit/20200912-005157
git checkout d7f1745bcd6815d03c0fcf621b988118301bc269
vim +1109 net/mptcp/protocol.c
1056
1057 static struct sock *mptcp_subflow_get_send(struct mptcp_sock *msk,
1058 u32 *sndbuf)
1059 {
1060 struct subflow_send_info send_info[2];
1061 struct mptcp_subflow_context *subflow;
1062 int i, nr_active = 0;
1063 int64_t ratio, pace;
1064 struct sock *ssk;
1065
1066 sock_owned_by_me((struct sock *)msk);
1067
1068 *sndbuf = 0;
1069 if (!mptcp_ext_cache_refill(msk))
1070 return NULL;
1071
1072 if (__mptcp_check_fallback(msk)) {
1073 if (!msk->first)
1074 return NULL;
1075 *sndbuf = msk->first->sk_sndbuf;
1076 return sk_stream_memory_free(msk->first) ? msk->first : NULL;
1077 }
1078
1079 /* re-use last subflow, if the burst allow that */
1080 if (msk->last_snd && msk->snd_burst > 0 &&
1081 sk_stream_memory_free(msk->last_snd) &&
1082 mptcp_subflow_active(mptcp_subflow_ctx(msk->last_snd))) {
1083 mptcp_for_each_subflow(msk, subflow) {
1084 ssk = mptcp_subflow_tcp_sock(subflow);
1085 *sndbuf = max(tcp_sk(ssk)->snd_wnd, *sndbuf);
1086 }
1087 return msk->last_snd;
1088 }
1089
1090 /* pick the subflow with the lower wmem/wspace ratio */
1091 for (i = 0; i < 2; ++i) {
1092 send_info[i].ssk = NULL;
1093 send_info[i].ratio = -1;
1094 }
1095 mptcp_for_each_subflow(msk, subflow) {
1096 ssk = mptcp_subflow_tcp_sock(subflow);
1097 if (!mptcp_subflow_active(subflow))
1098 continue;
1099
1100 nr_active += !subflow->backup;
1101 *sndbuf = max(tcp_sk(ssk)->snd_wnd, *sndbuf);
1102 if (!sk_stream_memory_free(subflow->tcp_sock))
1103 continue;
1104
1105 pace = READ_ONCE(ssk->sk_pacing_rate);
1106 if (!pace)
1107 continue;
1108
> 1109 ratio = (int64_t)READ_ONCE(ssk->sk_wmem_queued) << 32 / pace;
1110 if (ratio < send_info[subflow->backup].ratio) {
1111 send_info[subflow->backup].ssk = ssk;
1112 send_info[subflow->backup].ratio = ratio;
1113 }
1114 }
1115
1116 pr_debug("msk=%p nr_active=%d ssk=%p:%lld backup=%p:%lld",
1117 msk, nr_active, send_info[0].ssk, send_info[0].ratio,
1118 send_info[1].ssk, send_info[1].ratio);
1119
1120 /* pick the best backup if no other subflow is active */
1121 if (!nr_active)
1122 send_info[0].ssk = send_info[1].ssk;
1123
1124 if (send_info[0].ssk) {
1125 msk->last_snd = send_info[0].ssk;
1126 msk->snd_burst = min_t(int, MPTCP_SEND_BURST_SIZE,
1127 sk_stream_wspace(msk->last_snd));
1128 return msk->last_snd;
1129 }
1130 return NULL;
1131 }
1132
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
Re: [PATCH] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT flag
by kernel test robot
Hi Sergey,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.9-rc4 next-20200911]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sergey-Senozhatsky/media-v4l2-re...
base: git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-a004-20200911 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 0448d11a06b451a63a8f60408fec613ad24801ba)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/media/dvb-core/dvb_vb2.c:345:57: error: too many arguments to function call, expected 3, have 4
ret = vb2_core_reqbufs(&ctx->vb_q, VB2_MEMORY_MMAP, 0, &req->count);
~~~~~~~~~~~~~~~~ ^~~~~~~~~~~
include/media/videobuf2-core.h:770:5: note: 'vb2_core_reqbufs' declared here
int vb2_core_reqbufs(struct vb2_queue *q, enum vb2_memory memory,
^
1 error generated.
# https://github.com/0day-ci/linux/commit/ef3d23bb3087aac00acdc21e175566608...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sergey-Senozhatsky/media-v4l2-remove-V4L2-FLAG-MEMORY-NON-CONSISTENT-flag/20200911-110822
git checkout ef3d23bb3087aac00acdc21e175566608466f139
vim +345 drivers/media/dvb-core/dvb_vb2.c
57868acc369ab73 Satendra Singh Thakur 2017-12-18 332
57868acc369ab73 Satendra Singh Thakur 2017-12-18 333 int dvb_vb2_reqbufs(struct dvb_vb2_ctx *ctx, struct dmx_requestbuffers *req)
57868acc369ab73 Satendra Singh Thakur 2017-12-18 334 {
57868acc369ab73 Satendra Singh Thakur 2017-12-18 335 int ret;
57868acc369ab73 Satendra Singh Thakur 2017-12-18 336
2c06aa7c31cfad2 Mauro Carvalho Chehab 2017-12-28 337 /* Adjust size to a sane value */
2c06aa7c31cfad2 Mauro Carvalho Chehab 2017-12-28 338 if (req->size > DVB_V2_MAX_SIZE)
2c06aa7c31cfad2 Mauro Carvalho Chehab 2017-12-28 339 req->size = DVB_V2_MAX_SIZE;
2c06aa7c31cfad2 Mauro Carvalho Chehab 2017-12-28 340
2c06aa7c31cfad2 Mauro Carvalho Chehab 2017-12-28 341 /* FIXME: round req->size to a 188 or 204 multiple */
2c06aa7c31cfad2 Mauro Carvalho Chehab 2017-12-28 342
57868acc369ab73 Satendra Singh Thakur 2017-12-18 343 ctx->buf_siz = req->size;
57868acc369ab73 Satendra Singh Thakur 2017-12-18 344 ctx->buf_cnt = req->count;
7b4b45555c79db0 Sergey Senozhatsky 2020-05-14 @345 ret = vb2_core_reqbufs(&ctx->vb_q, VB2_MEMORY_MMAP, 0, &req->count);
57868acc369ab73 Satendra Singh Thakur 2017-12-18 346 if (ret) {
57868acc369ab73 Satendra Singh Thakur 2017-12-18 347 ctx->state = DVB_VB2_STATE_NONE;
57868acc369ab73 Satendra Singh Thakur 2017-12-18 348 dprintk(1, "[%s] count=%d size=%d errno=%d\n", ctx->name,
57868acc369ab73 Satendra Singh Thakur 2017-12-18 349 ctx->buf_cnt, ctx->buf_siz, ret);
57868acc369ab73 Satendra Singh Thakur 2017-12-18 350 return ret;
57868acc369ab73 Satendra Singh Thakur 2017-12-18 351 }
57868acc369ab73 Satendra Singh Thakur 2017-12-18 352 ctx->state |= DVB_VB2_STATE_REQBUFS;
57868acc369ab73 Satendra Singh Thakur 2017-12-18 353 dprintk(3, "[%s] count=%d size=%d\n", ctx->name,
57868acc369ab73 Satendra Singh Thakur 2017-12-18 354 ctx->buf_cnt, ctx->buf_siz);
57868acc369ab73 Satendra Singh Thakur 2017-12-18 355
57868acc369ab73 Satendra Singh Thakur 2017-12-18 356 return 0;
57868acc369ab73 Satendra Singh Thakur 2017-12-18 357 }
57868acc369ab73 Satendra Singh Thakur 2017-12-18 358
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years