Re: [PATCH V8 1/3] fuse: Definitions and ioctl() for passthrough
by kernel test robot
Hi Alessio,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.9-rc4]
[cannot apply to fuse/for-next next-20200911]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alessio-Balsini/fuse-Add-support...
base: f4d51dffc6c01a9e94650d95ce0104964f8ae822
config: arm-randconfig-r025-20200911 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 0448d11a06b451a63a8f60408fec613ad24801ba)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> fs/fuse/dev.c:2222:5: warning: no previous prototype for function 'fuse_passthrough_open' [-Wmissing-prototypes]
int fuse_passthrough_open(struct fuse_dev *fud,
^
fs/fuse/dev.c:2222:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int fuse_passthrough_open(struct fuse_dev *fud,
^
static
1 warning generated.
# https://github.com/0day-ci/linux/commit/c8c14de554673fa450ce2cadee8957f5f...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alessio-Balsini/fuse-Add-support-for-passthrough-read-write/20200912-003643
git checkout c8c14de554673fa450ce2cadee8957f5f8c021e3
vim +/fuse_passthrough_open +2222 fs/fuse/dev.c
2221
> 2222 int fuse_passthrough_open(struct fuse_dev *fud,
2223 struct fuse_passthrough_out *pto)
2224 {
2225 int ret;
2226 struct fuse_req *req;
2227 struct fuse_pqueue *fpq = &fud->pq;
2228 struct fuse_conn *fc = fud->fc;
2229
2230 if (!fc->passthrough)
2231 return -EPERM;
2232
2233 /* This field is reserved for future use */
2234 if (pto->len != 0)
2235 return -EINVAL;
2236
2237 spin_lock(&fpq->lock);
2238 req = request_find(fpq, pto->unique & ~FUSE_INT_REQ_BIT);
2239 if (!req) {
2240 spin_unlock(&fpq->lock);
2241 return -ENOENT;
2242 }
2243 __fuse_get_request(req);
2244 spin_unlock(&fpq->lock);
2245
2246 ret = fuse_passthrough_setup(req, pto->fd);
2247
2248 __fuse_put_request(req);
2249 return ret;
2250 }
2251
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
{standard input}:344: Error: found '(', expected: ')'
by kernel test robot
Hi Paul,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 581cb3a26baf846ee9636214afaa5333919875b1
commit: 21e3134b3ec09e722cbcda69788f206adc8db1f4 MIPS: barrier: Clean up rmb() & wmb() definitions
date: 11 months ago
config: mips-randconfig-r032-20200911 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 21e3134b3ec09e722cbcda69788f206adc8db1f4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
{standard input}: Assembler messages:
>> {standard input}:344: Error: found '(', expected: ')'
>> {standard input}:344: Error: found '(', expected: ')'
>> {standard input}:344: Error: non-constant expression in ".if" statement
>> {standard input}:344: Error: junk at end of line, first unrecognized character is `('
{standard input}:465: Error: found '(', expected: ')'
{standard input}:465: Error: found '(', expected: ')'
{standard input}:465: Error: non-constant expression in ".if" statement
{standard input}:465: Error: junk at end of line, first unrecognized character is `('
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[RFC PATCH] fuse: fuse_passthrough_open() can be static
by kernel test robot
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index b0fbdbfd4fbd0..f17d2f45acbb9 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -2219,8 +2219,8 @@ static int fuse_device_clone(struct fuse_conn *fc, struct file *new)
return 0;
}
-int fuse_passthrough_open(struct fuse_dev *fud,
- struct fuse_passthrough_out *pto)
+static int fuse_passthrough_open(struct fuse_dev *fud,
+ struct fuse_passthrough_out *pto)
{
int ret;
struct fuse_req *req;
2 years
Re: [PATCH V8 1/3] fuse: Definitions and ioctl() for passthrough
by kernel test robot
Hi Alessio,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.9-rc4]
[cannot apply to fuse/for-next next-20200911]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alessio-Balsini/fuse-Add-support...
base: f4d51dffc6c01a9e94650d95ce0104964f8ae822
config: x86_64-randconfig-s021-20200911 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-191-g10164920-dirty
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> fs/fuse/dev.c:2222:5: sparse: sparse: symbol 'fuse_passthrough_open' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[ti:ti-rt-linux-5.4.y 10177/10184] drivers/net/ethernet/ti/icss_iep.c:511:13: warning: no previous prototype for 'icss_iep_cap_cmp_handler'
by kernel test robot
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.4.y
head: e76cd2a01c4f01c314e5e1518ca6f1addb014e2b
commit: 41e5c46849b596ecedd275262201da72658bfe2d [10177/10184] net: ethernet: ti: icss-iep: Add support for generating perout/PPS signal for am57xx variant
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 41e5c46849b596ecedd275262201da72658bfe2d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/ti/icss_iep.c:511:13: warning: no previous prototype for 'icss_iep_cap_cmp_handler' [-Wmissing-prototypes]
511 | irqreturn_t icss_iep_cap_cmp_handler(int irq, void *dev_id)
| ^~~~~~~~~~~~~~~~~~~~~~~~
git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
git fetch --no-tags ti ti-rt-linux-5.4.y
git checkout 41e5c46849b596ecedd275262201da72658bfe2d
vim +/icss_iep_cap_cmp_handler +511 drivers/net/ethernet/ti/icss_iep.c
510
> 511 irqreturn_t icss_iep_cap_cmp_handler(int irq, void *dev_id)
512 {
513 struct icss_iep *iep = (struct icss_iep *)dev_id;
514 struct ptp_clock_event pevent;
515 unsigned int val, index = 0;
516 u64 ns;
517
518 regmap_read(iep->map, ICSS_IEP_CMP_STAT_REG, &val);
519 if (val & BIT(CMP_INDEX(index))) {
520 regmap_write(iep->map, ICSS_IEP_CMP_STAT_REG, BIT(CMP_INDEX(index)));
521 regmap_read(iep->map, ICSS_IEP_CMP1_REG0, &val);
522 ns = val;
523 regmap_read(iep->map, ICSS_IEP_CMP1_REG1, &val);
524 ns |= (u64)val << 32;
525 icss_iep_update_to_next_boundary(iep);
526
527 pevent.pps_times.ts_real = ns_to_timespec64(ns);
528 pevent.type = PTP_CLOCK_PPSUSR;
529 pevent.index = index;
530 ptp_clock_event(iep->ptp_clock, &pevent);
531 dev_dbg(iep->dev, "IEP:pps ts: %llu\n", ns);
532 }
533
534 return IRQ_HANDLED;
535 }
536
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[hch-misc:dma-header-cleanups 23/31] drivers/pci/xen-pcifront.c:695:15: error: implicit declaration of function 'swiotlb_nr_tbl'
by kernel test robot
tree: git://git.infradead.org/users/hch/misc.git dma-header-cleanups
head: 5093be553444b2cc6c459d6e9f5a4692ac0b4125
commit: 66216ba208594466fc57ef598198a7821a995ea0 [23/31] dma-mapping: split <linux/dma-mapping.h>
config: x86_64-randconfig-a016-20200911 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
git checkout 66216ba208594466fc57ef598198a7821a995ea0
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/pci/xen-pcifront.c: In function 'pcifront_connect_and_init_dma':
>> drivers/pci/xen-pcifront.c:695:15: error: implicit declaration of function 'swiotlb_nr_tbl' [-Werror=implicit-function-declaration]
695 | if (!err && !swiotlb_nr_tbl()) {
| ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
git remote add hch-misc git://git.infradead.org/users/hch/misc.git
git fetch --no-tags hch-misc dma-header-cleanups
git checkout 66216ba208594466fc57ef598198a7821a995ea0
vim +/swiotlb_nr_tbl +695 drivers/pci/xen-pcifront.c
956a9202cd1220 Ryan Wilson 2010-08-02 674
956a9202cd1220 Ryan Wilson 2010-08-02 675 static irqreturn_t pcifront_handler_aer(int irq, void *dev)
956a9202cd1220 Ryan Wilson 2010-08-02 676 {
956a9202cd1220 Ryan Wilson 2010-08-02 677 struct pcifront_device *pdev = dev;
956a9202cd1220 Ryan Wilson 2010-08-02 678 schedule_pcifront_aer_op(pdev);
956a9202cd1220 Ryan Wilson 2010-08-02 679 return IRQ_HANDLED;
956a9202cd1220 Ryan Wilson 2010-08-02 680 }
3d925320e9e2de Konrad Rzeszutek Wilk 2012-07-31 681 static int pcifront_connect_and_init_dma(struct pcifront_device *pdev)
956a9202cd1220 Ryan Wilson 2010-08-02 682 {
956a9202cd1220 Ryan Wilson 2010-08-02 683 int err = 0;
956a9202cd1220 Ryan Wilson 2010-08-02 684
956a9202cd1220 Ryan Wilson 2010-08-02 685 spin_lock(&pcifront_dev_lock);
956a9202cd1220 Ryan Wilson 2010-08-02 686
956a9202cd1220 Ryan Wilson 2010-08-02 687 if (!pcifront_dev) {
956a9202cd1220 Ryan Wilson 2010-08-02 688 dev_info(&pdev->xdev->dev, "Installing PCI frontend\n");
956a9202cd1220 Ryan Wilson 2010-08-02 689 pcifront_dev = pdev;
098b1aeaf4d614 Konrad Rzeszutek Wilk 2013-06-10 690 } else
956a9202cd1220 Ryan Wilson 2010-08-02 691 err = -EEXIST;
098b1aeaf4d614 Konrad Rzeszutek Wilk 2013-06-10 692
956a9202cd1220 Ryan Wilson 2010-08-02 693 spin_unlock(&pcifront_dev_lock);
956a9202cd1220 Ryan Wilson 2010-08-02 694
3d925320e9e2de Konrad Rzeszutek Wilk 2012-07-31 @695 if (!err && !swiotlb_nr_tbl()) {
3d925320e9e2de Konrad Rzeszutek Wilk 2012-07-31 696 err = pci_xen_swiotlb_init_late();
3d925320e9e2de Konrad Rzeszutek Wilk 2012-07-31 697 if (err)
3d925320e9e2de Konrad Rzeszutek Wilk 2012-07-31 698 dev_err(&pdev->xdev->dev, "Could not setup SWIOTLB!\n");
3d925320e9e2de Konrad Rzeszutek Wilk 2012-07-31 699 }
956a9202cd1220 Ryan Wilson 2010-08-02 700 return err;
956a9202cd1220 Ryan Wilson 2010-08-02 701 }
956a9202cd1220 Ryan Wilson 2010-08-02 702
:::::: The code at line 695 was first introduced by commit
:::::: 3d925320e9e2de162bd138bf97816bda8c3f71be xen/pcifront: Use Xen-SWIOTLB when initting if required.
:::::: TO: Konrad Rzeszutek Wilk <konrad.wilk(a)oracle.com>
:::::: CC: Konrad Rzeszutek Wilk <konrad.wilk(a)oracle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[hch-misc:dma-header-cleanups 23/31] arch/x86/xen/pci-swiotlb-xen.c:63:3: error: 'dma_ops' undeclared; did you mean
by kernel test robot
tree: git://git.infradead.org/users/hch/misc.git dma-header-cleanups
head: 5093be553444b2cc6c459d6e9f5a4692ac0b4125
commit: 66216ba208594466fc57ef598198a7821a995ea0 [23/31] dma-mapping: split <linux/dma-mapping.h>
config: x86_64-randconfig-s022-20200911 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-191-g10164920-dirty
git checkout 66216ba208594466fc57ef598198a7821a995ea0
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/x86/xen/pci-swiotlb-xen.c: In function 'pci_xen_swiotlb_init':
>> arch/x86/xen/pci-swiotlb-xen.c:63:3: error: 'dma_ops' undeclared (first use in this function); did you mean 'smp_ops'?
63 | dma_ops = &xen_swiotlb_dma_ops;
| ^~~~~~~
| smp_ops
arch/x86/xen/pci-swiotlb-xen.c:63:3: note: each undeclared identifier is reported only once for each function it appears in
arch/x86/xen/pci-swiotlb-xen.c: In function 'pci_xen_swiotlb_init_late':
arch/x86/xen/pci-swiotlb-xen.c:83:2: error: 'dma_ops' undeclared (first use in this function); did you mean 'smp_ops'?
83 | dma_ops = &xen_swiotlb_dma_ops;
| ^~~~~~~
| smp_ops
git remote add hch-misc git://git.infradead.org/users/hch/misc.git
git fetch --no-tags hch-misc dma-header-cleanups
git checkout 66216ba208594466fc57ef598198a7821a995ea0
vim +63 arch/x86/xen/pci-swiotlb-xen.c
bbbe57386e857e Konrad Rzeszutek Wilk 2010-02-09 58
bbbe57386e857e Konrad Rzeszutek Wilk 2010-02-09 59 void __init pci_xen_swiotlb_init(void)
bbbe57386e857e Konrad Rzeszutek Wilk 2010-02-09 60 {
bbbe57386e857e Konrad Rzeszutek Wilk 2010-02-09 61 if (xen_swiotlb) {
b8277600536989 Konrad Rzeszutek Wilk 2012-08-23 62 xen_swiotlb_init(1, true /* early */);
bbbe57386e857e Konrad Rzeszutek Wilk 2010-02-09 @63 dma_ops = &xen_swiotlb_dma_ops;
74226b8c8a0b10 Konrad Rzeszutek Wilk 2010-08-19 64
:::::: The code at line 63 was first introduced by commit
:::::: bbbe57386e857eb2a8d4abcae71063c819c06ff1 pci-swiotlb-xen: Add glue code to setup dma_ops utilizing xen_swiotlb_* functions.
:::::: TO: Konrad Rzeszutek Wilk <konrad.wilk(a)oracle.com>
:::::: CC: Konrad Rzeszutek Wilk <konrad.wilk(a)oracle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[hch-misc:dma-header-cleanups 29/31] kernel/dma/debug.c:403:6: warning: no previous prototype for 'debug_dma_dump_mappings'
by kernel test robot
tree: git://git.infradead.org/users/hch/misc.git dma-header-cleanups
head: 5093be553444b2cc6c459d6e9f5a4692ac0b4125
commit: 6f0e3350579b304d60868c94322cfb8c9e9bc54c [29/31] dma-mapping: move dma-debug.h to kernel/dma/
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 6f0e3350579b304d60868c94322cfb8c9e9bc54c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> kernel/dma/debug.c:403:6: warning: no previous prototype for 'debug_dma_dump_mappings' [-Wmissing-prototypes]
403 | void debug_dma_dump_mappings(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~
>> kernel/dma/debug.c:862:6: warning: no previous prototype for 'dma_debug_add_bus' [-Wmissing-prototypes]
862 | void dma_debug_add_bus(struct bus_type *bus)
| ^~~~~~~~~~~~~~~~~
git remote add hch-misc git://git.infradead.org/users/hch/misc.git
git fetch --no-tags hch-misc dma-header-cleanups
git checkout 6f0e3350579b304d60868c94322cfb8c9e9bc54c
vim +/debug_dma_dump_mappings +403 kernel/dma/debug.c
0abdd7a81b7e3f lib/dma-debug.c Dan Williams 2014-01-21 399
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 400 /*
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 401 * Dump mapping entries for debugging purposes
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 402 */
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 @403 void debug_dma_dump_mappings(struct device *dev)
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 404 {
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 405 int idx;
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 406
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 407 for (idx = 0; idx < HASH_SIZE; idx++) {
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 408 struct hash_bucket *bucket = &dma_entry_hash[idx];
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 409 struct dma_debug_entry *entry;
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 410 unsigned long flags;
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 411
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 412 spin_lock_irqsave(&bucket->lock, flags);
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 413
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 414 list_for_each_entry(entry, &bucket->list, list) {
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 415 if (!dev || dev == entry->dev) {
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 416 dev_info(entry->dev,
0abdd7a81b7e3f lib/dma-debug.c Dan Williams 2014-01-21 417 "%s idx %d P=%Lx N=%lx D=%Lx L=%Lx %s %s\n",
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 418 type2name[entry->type], idx,
0abdd7a81b7e3f lib/dma-debug.c Dan Williams 2014-01-21 419 phys_addr(entry), entry->pfn,
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 420 entry->dev_addr, entry->size,
6c9c6d6301287e lib/dma-debug.c Shuah Khan 2012-10-08 421 dir2name[entry->direction],
6c9c6d6301287e lib/dma-debug.c Shuah Khan 2012-10-08 422 maperr2str[entry->map_err_type]);
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 423 }
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 424 }
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 425
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 426 spin_unlock_irqrestore(&bucket->lock, flags);
9ff6aa027dbb98 kernel/dma/debug.c Eric Dumazet 2019-10-28 427 cond_resched();
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 428 }
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 429 }
ac26c18bd35d98 lib/dma-debug.c David Woodhouse 2009-02-12 430
:::::: The code at line 403 was first introduced by commit
:::::: ac26c18bd35d982d1ba06020a992b1085fefc3e2 dma-debug: add function to dump dma mappings
:::::: TO: David Woodhouse <dwmw2(a)infradead.org>
:::::: CC: Joerg Roedel <joerg.roedel(a)amd.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
drivers/net/ethernet/mellanox/mlx5/core/en/port.c:453 mlx5e_fec_in_caps() warn: signedness bug returning '(-95)'
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 581cb3a26baf846ee9636214afaa5333919875b1
commit: 2132b71f78d207b63974fc7d6eced9c5e886c405 net/mlx5e: Advertise globaly supported FEC modes
config: powerpc-randconfig-m031-20200911 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
drivers/net/ethernet/mellanox/mlx5/core/en/port.c:453 mlx5e_fec_in_caps() warn: signedness bug returning '(-95)'
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 2132b71f78d207b63974fc7d6eced9c5e886c405
vim +453 drivers/net/ethernet/mellanox/mlx5/core/en/port.c
2132b71f78d207 Aya Levin 2020-02-11 444 bool mlx5e_fec_in_caps(struct mlx5_core_dev *dev, int fec_policy)
^^^^
2095b264147753 Shay Agroskin 2018-10-10 445 {
2095b264147753 Shay Agroskin 2018-10-10 446 u32 out[MLX5_ST_SZ_DW(pplm_reg)] = {};
2095b264147753 Shay Agroskin 2018-10-10 447 u32 in[MLX5_ST_SZ_DW(pplm_reg)] = {};
2095b264147753 Shay Agroskin 2018-10-10 448 int sz = MLX5_ST_SZ_BYTES(pplm_reg);
2095b264147753 Shay Agroskin 2018-10-10 449 int err;
2132b71f78d207 Aya Levin 2020-02-11 450 int i;
2095b264147753 Shay Agroskin 2018-10-10 451
2095b264147753 Shay Agroskin 2018-10-10 452 if (!MLX5_CAP_GEN(dev, pcam_reg))
2095b264147753 Shay Agroskin 2018-10-10 @453 return -EOPNOTSUPP;
^^^^^^^^^^^^^^^^^^
2095b264147753 Shay Agroskin 2018-10-10 454
2095b264147753 Shay Agroskin 2018-10-10 455 if (!MLX5_CAP_PCAM_REG(dev, pplm))
2095b264147753 Shay Agroskin 2018-10-10 456 return -EOPNOTSUPP;
^^^^^^^^^^^^^^^^^^
These become "return true;"
2095b264147753 Shay Agroskin 2018-10-10 457
2095b264147753 Shay Agroskin 2018-10-10 458 MLX5_SET(pplm_reg, in, local_port, 1);
2095b264147753 Shay Agroskin 2018-10-10 459 err = mlx5_core_access_reg(dev, in, sz, out, sz, MLX5_REG_PPLM, 0, 0);
2095b264147753 Shay Agroskin 2018-10-10 460 if (err)
2132b71f78d207 Aya Levin 2020-02-11 461 return false;
2095b264147753 Shay Agroskin 2018-10-10 462
2132b71f78d207 Aya Levin 2020-02-11 463 for (i = 0; i < MLX5E_FEC_SUPPORTED_SPEEDS; i++) {
2132b71f78d207 Aya Levin 2020-02-11 464 u8 fec_caps;
2095b264147753 Shay Agroskin 2018-10-10 465
2132b71f78d207 Aya Levin 2020-02-11 466 mlx5e_get_fec_cap_field(out, &fec_caps, fec_supported_speeds[i]);
2132b71f78d207 Aya Levin 2020-02-11 467 if (fec_caps & fec_policy)
2132b71f78d207 Aya Levin 2020-02-11 468 return true;
2132b71f78d207 Aya Levin 2020-02-11 469 }
2132b71f78d207 Aya Levin 2020-02-11 470 return false;
2095b264147753 Shay Agroskin 2018-10-10 471 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years
[mptcp:export 653/660] net/mptcp/protocol.c:1109: undefined reference to `__divdi3'
by kernel test robot
tree: https://github.com/multipath-tcp/mptcp_net-next.git export
head: 38c882ee9a77d857355a8dd2a220156ba7df73bc
commit: 6ad4fb22474e4f8d3c0aae6b68d4c4de49deeae5 [653/660] mptcp: allow picking different xmit subflows
config: m68k-randconfig-r025-20200911 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 6ad4fb22474e4f8d3c0aae6b68d4c4de49deeae5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
m68k-linux-ld: net/mptcp/protocol.o: in function `mptcp_subflow_get_send':
>> net/mptcp/protocol.c:1109: undefined reference to `__divdi3'
# https://github.com/multipath-tcp/mptcp_net-next/commit/6ad4fb22474e4f8d3c...
git remote add mptcp https://github.com/multipath-tcp/mptcp_net-next.git
git fetch --no-tags mptcp export
git checkout 6ad4fb22474e4f8d3c0aae6b68d4c4de49deeae5
vim +1109 net/mptcp/protocol.c
1056
1057 static struct sock *mptcp_subflow_get_send(struct mptcp_sock *msk,
1058 u32 *sndbuf)
1059 {
1060 struct subflow_send_info send_info[2];
1061 struct mptcp_subflow_context *subflow;
1062 int i, nr_active = 0;
1063 int64_t ratio, pace;
1064 struct sock *ssk;
1065
1066 sock_owned_by_me((struct sock *)msk);
1067
1068 *sndbuf = 0;
1069 if (!mptcp_ext_cache_refill(msk))
1070 return NULL;
1071
1072 if (__mptcp_check_fallback(msk)) {
1073 if (!msk->first)
1074 return NULL;
1075 *sndbuf = msk->first->sk_sndbuf;
1076 return sk_stream_memory_free(msk->first) ? msk->first : NULL;
1077 }
1078
1079 /* re-use last subflow, if the burst allow that */
1080 if (msk->last_snd && msk->snd_burst > 0 &&
1081 sk_stream_memory_free(msk->last_snd) &&
1082 mptcp_subflow_active(mptcp_subflow_ctx(msk->last_snd))) {
1083 mptcp_for_each_subflow(msk, subflow) {
1084 ssk = mptcp_subflow_tcp_sock(subflow);
1085 *sndbuf = max(tcp_sk(ssk)->snd_wnd, *sndbuf);
1086 }
1087 return msk->last_snd;
1088 }
1089
1090 /* pick the subflow with the lower wmem/wspace ratio */
1091 for (i = 0; i < 2; ++i) {
1092 send_info[i].ssk = NULL;
1093 send_info[i].ratio = -1;
1094 }
1095 mptcp_for_each_subflow(msk, subflow) {
1096 ssk = mptcp_subflow_tcp_sock(subflow);
1097 if (!mptcp_subflow_active(subflow))
1098 continue;
1099
1100 nr_active += !subflow->backup;
1101 *sndbuf = max(tcp_sk(ssk)->snd_wnd, *sndbuf);
1102 if (!sk_stream_memory_free(subflow->tcp_sock))
1103 continue;
1104
1105 pace = READ_ONCE(ssk->sk_pacing_rate);
1106 if (!pace)
1107 continue;
1108
> 1109 ratio = (int64_t)READ_ONCE(ssk->sk_wmem_queued) << 32 / pace;
1110 if (ratio < send_info[subflow->backup].ratio) {
1111 send_info[subflow->backup].ssk = ssk;
1112 send_info[subflow->backup].ratio = ratio;
1113 }
1114 }
1115
1116 pr_debug("msk=%p nr_active=%d ssk=%p:%lld backup=%p:%lld",
1117 msk, nr_active, send_info[0].ssk, send_info[0].ratio,
1118 send_info[1].ssk, send_info[1].ratio);
1119
1120 /* pick the best backup if no other subflow is active */
1121 if (!nr_active)
1122 send_info[0].ssk = send_info[1].ssk;
1123
1124 if (send_info[0].ssk) {
1125 msk->last_snd = send_info[0].ssk;
1126 msk->snd_burst = min_t(int, MPTCP_SEND_BURST_SIZE,
1127 sk_stream_wspace(msk->last_snd));
1128 return msk->last_snd;
1129 }
1130 return NULL;
1131 }
1132
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 years