Re: [RFC PATCH v3 2/8] Add a reference to ucounts for each cred
by kernel test robot
Hi Alexey,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on kselftest/next]
[also build test WARNING on linux/master linus/master hnaz-linux-mm/master v5.11-rc3 next-20210115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alexey-Gladkov/Count-rlimits-in-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
config: arm64-randconfig-r023-20210115 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5b42fd8dd4e7e29125a09a41a33af7c9cb57d144)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/14c3c8a27f70d6d6b7c1d64a9af899eb8...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alexey-Gladkov/Count-rlimits-in-each-user-namespace/20210115-230051
git checkout 14c3c8a27f70d6d6b7c1d64a9af899eb80169495
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> kernel/cred.c:149:20: warning: if statement has empty body [-Wempty-body]
if (cred->ucounts);
^
kernel/cred.c:149:20: note: put the semicolon on a separate line to silence this warning
1 warning generated.
vim +149 kernel/cred.c
127
128 /**
129 * __put_cred - Destroy a set of credentials
130 * @cred: The record to release
131 *
132 * Destroy a set of credentials on which no references remain.
133 */
134 void __put_cred(struct cred *cred)
135 {
136 kdebug("__put_cred(%p{%d,%d})", cred,
137 atomic_read(&cred->usage),
138 read_cred_subscribers(cred));
139
140 BUG_ON(atomic_read(&cred->usage) != 0);
141 #ifdef CONFIG_DEBUG_CREDENTIALS
142 BUG_ON(read_cred_subscribers(cred) != 0);
143 cred->magic = CRED_MAGIC_DEAD;
144 cred->put_addr = __builtin_return_address(0);
145 #endif
146 BUG_ON(cred == current->cred);
147 BUG_ON(cred == current->real_cred);
148
> 149 if (cred->ucounts);
150 BUG_ON(cred->ucounts->ns != cred->user_ns);
151
152 if (cred->non_rcu)
153 put_cred_rcu(&cred->rcu);
154 else
155 call_rcu(&cred->rcu, put_cred_rcu);
156 }
157 EXPORT_SYMBOL(__put_cred);
158
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 8 months
[mac80211-next:rtnl 3/4] drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2444:14: error: passing argument 1 of 'wiphy_lock' from incompatible pointer type
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git rtnl
head: 24431371abdbc37e228fb7041e3b6e0d7e9be359
commit: fd7ee4407f4ffbf7c318f8d87cce7f4a151cbe13 [3/4] rtnl-fixes
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/c...
git remote add mac80211-next https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
git fetch --no-tags mac80211-next rtnl
git checkout fd7ee4407f4ffbf7c318f8d87cce7f4a151cbe13
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c: In function 'brcmf_p2p_ifp_removed':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2444:14: error: passing argument 1 of 'wiphy_lock' from incompatible pointer type [-Werror=incompatible-pointer-types]
2444 | wiphy_lock(&cfg->wiphy);
| ^~~~~~~~~~~
| |
| struct wiphy **
In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:9:
include/net/cfg80211.h:5259:45: note: expected 'struct wiphy *' but argument is of type 'struct wiphy **'
5259 | static inline void wiphy_lock(struct wiphy *wiphy)
| ~~~~~~~~~~~~~~^~~~~
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2446:16: error: passing argument 1 of 'wiphy_unlock' from incompatible pointer type [-Werror=incompatible-pointer-types]
2446 | wiphy_unlock(&cfg->wiphy);
| ^~~~~~~~~~~
| |
| struct wiphy **
In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:9:
include/net/cfg80211.h:5268:47: note: expected 'struct wiphy *' but argument is of type 'struct wiphy **'
5268 | static inline void wiphy_unlock(struct wiphy *wiphy)
| ~~~~~~~~~~~~~~^~~~~
cc1: some warnings being treated as errors
vim +/wiphy_lock +2444 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
2432
2433 void brcmf_p2p_ifp_removed(struct brcmf_if *ifp, bool locked)
2434 {
2435 struct brcmf_cfg80211_info *cfg;
2436 struct brcmf_cfg80211_vif *vif;
2437
2438 brcmf_dbg(INFO, "P2P: device interface removed\n");
2439 vif = ifp->vif;
2440 cfg = wdev_to_cfg(&vif->wdev);
2441 cfg->p2p.bss_idx[P2PAPI_BSSCFG_DEVICE].vif = NULL;
2442 if (locked) {
2443 rtnl_lock();
> 2444 wiphy_lock(&cfg->wiphy);
2445 cfg80211_unregister_wdev(&vif->wdev);
> 2446 wiphy_unlock(&cfg->wiphy);
2447 rtnl_unlock();
2448 } else {
2449 cfg80211_unregister_wdev(&vif->wdev);
2450 }
2451 brcmf_free_vif(vif);
2452 }
2453
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 8 months
Re: [PATCH 1/9] hugetlb: Pass vma into huge_pte_alloc()
by kernel test robot
Hi Axel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on powerpc/next s390/features tip/perf/core linus/master v5.11-rc3 next-20210115]
[cannot apply to hp-parisc/for-next hnaz-linux-mm/master ia64/next sparc-next/master sparc/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Axel-Rasmussen/userfaultfd-add-m...
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: mips-cavium_octeon_defconfig (attached as .config)
compiler: mips64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4af095177515048cbeff41653579e2243...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Axel-Rasmussen/userfaultfd-add-minor-fault-handling/20210116-030900
git checkout 4af095177515048cbeff41653579e2243fef2295
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> arch/mips/mm/hugetlbpage.c:24:45: error: unknown type name 'structt'; did you mean 'struct'?
24 | pte_t *huge_pte_alloc(struct mm_struct *mm, structt vm_area_struct *vma,
| ^~~~~~~
| struct
vim +24 arch/mips/mm/hugetlbpage.c
23
> 24 pte_t *huge_pte_alloc(struct mm_struct *mm, structt vm_area_struct *vma,
25 unsigned long addr, unsigned long sz)
26 {
27 pgd_t *pgd;
28 p4d_t *p4d;
29 pud_t *pud;
30 pte_t *pte = NULL;
31
32 pgd = pgd_offset(mm, addr);
33 p4d = p4d_alloc(mm, pgd, addr);
34 pud = pud_alloc(mm, p4d, addr);
35 if (pud)
36 pte = (pte_t *)pmd_alloc(mm, pud, addr);
37
38 return pte;
39 }
40
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 8 months
Re: [PATCH RFC 3/4] kernel/resource: Make ioport_resource.start configurable
by kernel test robot
Hi John,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on asm-generic/master soc/for-next linus/master v5.11-rc3 next-20210115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/John-Garry/Fix-arm64-crash-for-a...
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: parisc-randconfig-r022-20210115 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/48d619e4d6beb0d7a086cbe60a0b24355...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review John-Garry/Fix-arm64-crash-for-accessing-unmapped-IO-port-regions-reboot/20210116-010800
git checkout 48d619e4d6beb0d7a086cbe60a0b24355d3ddd52
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> kernel/resource.c:32:11: error: 'IO_SPACE_BASE' undeclared here (not in a function); did you mean 'QIF_SPACE_B'?
32 | .start = IO_SPACE_BASE,
| ^~~~~~~~~~~~~
| QIF_SPACE_B
vim +32 kernel/resource.c
28
29
30 struct resource ioport_resource = {
31 .name = "PCI IO",
> 32 .start = IO_SPACE_BASE,
33 .end = IO_SPACE_LIMIT,
34 .flags = IORESOURCE_IO,
35 };
36 EXPORT_SYMBOL(ioport_resource);
37
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 8 months
Re: [PATCH v1] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default
by kernel test robot
Hi Saravana,
I love your patch! Yet something to improve:
[auto build test ERROR on gpio/for-next]
[also build test ERROR on v5.11-rc3 next-20210115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Saravana-Kannan/gpiolib-Bind-gpi...
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: arm64-randconfig-r023-20210115 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5b42fd8dd4e7e29125a09a41a33af7c9cb57d144)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/8c370ef8f557575cb23e5e288c861d944...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Saravana-Kannan/gpiolib-Bind-gpio_device-to-a-driver-to-enable-fw_devlink-on-by-default/20210116-050450
git checkout 8c370ef8f557575cb23e5e288c861d9447db0b3e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpio/gpiolib.c:614:69: error: too few arguments to function call, expected 3, have 2
if (!fwnode_dev && of_find_property(gdev->dev.of_node, "compatible")) {
~~~~~~~~~~~~~~~~ ^
include/linux/compiler.h:56:47: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^~~~
include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
include/linux/of.h:304:25: note: 'of_find_property' declared here
extern struct property *of_find_property(const struct device_node *np,
^
>> drivers/gpio/gpiolib.c:614:69: error: too few arguments to function call, expected 3, have 2
if (!fwnode_dev && of_find_property(gdev->dev.of_node, "compatible")) {
~~~~~~~~~~~~~~~~ ^
include/linux/compiler.h:56:47: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^~~~
include/linux/compiler.h:58:61: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
include/linux/of.h:304:25: note: 'of_find_property' declared here
extern struct property *of_find_property(const struct device_node *np,
^
>> drivers/gpio/gpiolib.c:614:69: error: too few arguments to function call, expected 3, have 2
if (!fwnode_dev && of_find_property(gdev->dev.of_node, "compatible")) {
~~~~~~~~~~~~~~~~ ^
include/linux/compiler.h:56:47: note: expanded from macro 'if'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^~~~
include/linux/compiler.h:58:86: note: expanded from macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
^~~~
include/linux/compiler.h:69:3: note: expanded from macro '__trace_if_value'
(cond) ? \
^~~~
include/linux/of.h:304:25: note: 'of_find_property' declared here
extern struct property *of_find_property(const struct device_node *np,
^
>> drivers/gpio/gpiolib.c:615:51: error: expected ')'
chip_warn(gc, "Create a real device for %pOF\n" of_node);
^
drivers/gpio/gpiolib.c:615:3: note: to match this '('
chip_warn(gc, "Create a real device for %pOF\n" of_node);
^
drivers/gpio/gpiolib.h:182:2: note: expanded from macro 'chip_warn'
dev_warn(&gc->gpiodev->dev, "(%s): " fmt, gc->label, ##__VA_ARGS__)
^
include/linux/dev_printk.h:114:11: note: expanded from macro 'dev_warn'
_dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
^
4 errors generated.
vim +614 drivers/gpio/gpiolib.c
567
568 int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
569 struct lock_class_key *lock_key,
570 struct lock_class_key *request_key)
571 {
572 unsigned long flags;
573 int ret = 0;
574 unsigned i;
575 int base = gc->base;
576 struct gpio_device *gdev;
577 struct device_node *of_node;
578 struct fwnode_handle *fwnode;
579 struct device *fwnode_dev;
580
581 /*
582 * First: allocate and populate the internal stat container, and
583 * set up the struct device.
584 */
585 gdev = kzalloc(sizeof(*gdev), GFP_KERNEL);
586 if (!gdev)
587 return -ENOMEM;
588 gdev->dev.bus = &gpio_bus_type;
589 gdev->chip = gc;
590 gc->gpiodev = gdev;
591 if (gc->parent) {
592 gdev->dev.parent = gc->parent;
593 gdev->dev.of_node = gc->parent->of_node;
594 }
595
596 #ifdef CONFIG_OF_GPIO
597 /* If the gpiochip has an assigned OF node this takes precedence */
598 if (gc->of_node)
599 gdev->dev.of_node = gc->of_node;
600 else
601 gc->of_node = gdev->dev.of_node;
602
603 of_node = gdev->dev.of_node;
604 fwnode = of_fwnode_handle(of_node);
605 fwnode_dev = get_dev_from_fwnode(fwnode);
606
607 /*
608 * If your driver hits this warning, it's because you are directly
609 * parsing a device tree node with "compatible" property and
610 * initializing it instead of using the standard DT + device driver
611 * model of creating a struct device and then initializing it in the
612 * probe function. Please refactor your driver.
613 */
> 614 if (!fwnode_dev && of_find_property(gdev->dev.of_node, "compatible")) {
> 615 chip_warn(gc, "Create a real device for %pOF\n" of_node);
616 gdev->dev.fwnode = fwnode;
617 }
618 #endif
619
620 gdev->id = ida_alloc(&gpio_ida, GFP_KERNEL);
621 if (gdev->id < 0) {
622 ret = gdev->id;
623 goto err_free_gdev;
624 }
625 dev_set_name(&gdev->dev, GPIOCHIP_NAME "%d", gdev->id);
626 device_initialize(&gdev->dev);
627 dev_set_drvdata(&gdev->dev, gdev);
628 if (gc->parent && gc->parent->driver)
629 gdev->owner = gc->parent->driver->owner;
630 else if (gc->owner)
631 /* TODO: remove chip->owner */
632 gdev->owner = gc->owner;
633 else
634 gdev->owner = THIS_MODULE;
635
636 gdev->descs = kcalloc(gc->ngpio, sizeof(gdev->descs[0]), GFP_KERNEL);
637 if (!gdev->descs) {
638 ret = -ENOMEM;
639 goto err_free_ida;
640 }
641
642 if (gc->ngpio == 0) {
643 chip_err(gc, "tried to insert a GPIO chip with zero lines\n");
644 ret = -EINVAL;
645 goto err_free_descs;
646 }
647
648 if (gc->ngpio > FASTPATH_NGPIO)
649 chip_warn(gc, "line cnt %u is greater than fast path cnt %u\n",
650 gc->ngpio, FASTPATH_NGPIO);
651
652 gdev->label = kstrdup_const(gc->label ?: "unknown", GFP_KERNEL);
653 if (!gdev->label) {
654 ret = -ENOMEM;
655 goto err_free_descs;
656 }
657
658 gdev->ngpio = gc->ngpio;
659 gdev->data = data;
660
661 spin_lock_irqsave(&gpio_lock, flags);
662
663 /*
664 * TODO: this allocates a Linux GPIO number base in the global
665 * GPIO numberspace for this chip. In the long run we want to
666 * get *rid* of this numberspace and use only descriptors, but
667 * it may be a pipe dream. It will not happen before we get rid
668 * of the sysfs interface anyways.
669 */
670 if (base < 0) {
671 base = gpiochip_find_base(gc->ngpio);
672 if (base < 0) {
673 ret = base;
674 spin_unlock_irqrestore(&gpio_lock, flags);
675 goto err_free_label;
676 }
677 /*
678 * TODO: it should not be necessary to reflect the assigned
679 * base outside of the GPIO subsystem. Go over drivers and
680 * see if anyone makes use of this, else drop this and assign
681 * a poison instead.
682 */
683 gc->base = base;
684 }
685 gdev->base = base;
686
687 ret = gpiodev_add_to_list(gdev);
688 if (ret) {
689 spin_unlock_irqrestore(&gpio_lock, flags);
690 goto err_free_label;
691 }
692
693 for (i = 0; i < gc->ngpio; i++)
694 gdev->descs[i].gdev = gdev;
695
696 spin_unlock_irqrestore(&gpio_lock, flags);
697
698 BLOCKING_INIT_NOTIFIER_HEAD(&gdev->notifier);
699
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 8 months
[mac80211-next:rtnl 3/4] drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2444:14: error: incompatible pointer types passing 'struct wiphy to parameter of type 'struct wiphy remove &
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git rtnl
head: 24431371abdbc37e228fb7041e3b6e0d7e9be359
commit: fd7ee4407f4ffbf7c318f8d87cce7f4a151cbe13 [3/4] rtnl-fixes
config: arm-randconfig-r033-20210115 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5b42fd8dd4e7e29125a09a41a33af7c9cb57d144)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/c...
git remote add mac80211-next https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git
git fetch --no-tags mac80211-next rtnl
git checkout fd7ee4407f4ffbf7c318f8d87cce7f4a151cbe13
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2444:14: error: incompatible pointer types passing 'struct wiphy **' to parameter of type 'struct wiphy *'; remove & [-Werror,-Wincompatible-pointer-types]
wiphy_lock(&cfg->wiphy);
^~~~~~~~~~~
include/net/cfg80211.h:5259:45: note: passing argument to parameter 'wiphy' here
static inline void wiphy_lock(struct wiphy *wiphy)
^
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:2446:16: error: incompatible pointer types passing 'struct wiphy **' to parameter of type 'struct wiphy *'; remove & [-Werror,-Wincompatible-pointer-types]
wiphy_unlock(&cfg->wiphy);
^~~~~~~~~~~
include/net/cfg80211.h:5268:47: note: passing argument to parameter 'wiphy' here
static inline void wiphy_unlock(struct wiphy *wiphy)
^
2 errors generated.
vim +2444 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
2432
2433 void brcmf_p2p_ifp_removed(struct brcmf_if *ifp, bool locked)
2434 {
2435 struct brcmf_cfg80211_info *cfg;
2436 struct brcmf_cfg80211_vif *vif;
2437
2438 brcmf_dbg(INFO, "P2P: device interface removed\n");
2439 vif = ifp->vif;
2440 cfg = wdev_to_cfg(&vif->wdev);
2441 cfg->p2p.bss_idx[P2PAPI_BSSCFG_DEVICE].vif = NULL;
2442 if (locked) {
2443 rtnl_lock();
> 2444 wiphy_lock(&cfg->wiphy);
2445 cfg80211_unregister_wdev(&vif->wdev);
2446 wiphy_unlock(&cfg->wiphy);
2447 rtnl_unlock();
2448 } else {
2449 cfg80211_unregister_wdev(&vif->wdev);
2450 }
2451 brcmf_free_vif(vif);
2452 }
2453
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 8 months
Re: [PATCH 2/9] hugetlb/userfaultfd: Forbid huge pmd sharing when uffd enabled
by kernel test robot
Hi Axel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on powerpc/next s390/features tip/perf/core linus/master v5.11-rc3 next-20210115]
[cannot apply to hp-parisc/for-next hnaz-linux-mm/master ia64/next sparc/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Axel-Rasmussen/userfaultfd-add-m...
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: i386-randconfig-r013-20210115 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/97d3dcca13a550a56e5afe40abcc8db92...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Axel-Rasmussen/userfaultfd-add-minor-fault-handling/20210116-030900
git checkout 97d3dcca13a550a56e5afe40abcc8db929bd3916
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/migrate.h:8,
from fs/f2fs/data.c:3857:
include/linux/hugetlb.h: In function 'want_pmd_share':
>> include/linux/hugetlb.h:954:6: error: implicit declaration of function 'uffd_disable_huge_pmd_share' [-Werror=implicit-function-declaration]
954 | if (uffd_disable_huge_pmd_share(vma))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from mm/filemap.c:36:
include/linux/hugetlb.h: In function 'want_pmd_share':
>> include/linux/hugetlb.h:954:6: error: implicit declaration of function 'uffd_disable_huge_pmd_share' [-Werror=implicit-function-declaration]
954 | if (uffd_disable_huge_pmd_share(vma))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/filemap.c: At top level:
mm/filemap.c:830:14: warning: no previous prototype for '__add_to_page_cache_locked' [-Wmissing-prototypes]
830 | noinline int __add_to_page_cache_locked(struct page *page,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from mm/util.c:16:
include/linux/hugetlb.h: In function 'want_pmd_share':
>> include/linux/hugetlb.h:954:6: error: implicit declaration of function 'uffd_disable_huge_pmd_share' [-Werror=implicit-function-declaration]
954 | if (uffd_disable_huge_pmd_share(vma))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/util.c: In function 'page_mapping':
mm/util.c:700:15: warning: variable 'entry' set but not used [-Wunused-but-set-variable]
700 | swp_entry_t entry;
| ^~~~~
cc1: some warnings being treated as errors
--
In file included from include/linux/migrate.h:8,
from mm/page_alloc.c:61:
include/linux/hugetlb.h: In function 'want_pmd_share':
>> include/linux/hugetlb.h:954:6: error: implicit declaration of function 'uffd_disable_huge_pmd_share' [-Werror=implicit-function-declaration]
954 | if (uffd_disable_huge_pmd_share(vma))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/page_alloc.c: At top level:
mm/page_alloc.c:3594:15: warning: no previous prototype for 'should_fail_alloc_page' [-Wmissing-prototypes]
3594 | noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
| ^~~~~~~~~~~~~~~~~~~~~~
mm/page_alloc.c:6255:23: warning: no previous prototype for 'memmap_init' [-Wmissing-prototypes]
6255 | void __meminit __weak memmap_init(unsigned long size, int nid,
| ^~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from kernel/events/core.c:31:
include/linux/hugetlb.h: In function 'want_pmd_share':
>> include/linux/hugetlb.h:954:6: error: implicit declaration of function 'uffd_disable_huge_pmd_share' [-Werror=implicit-function-declaration]
954 | if (uffd_disable_huge_pmd_share(vma))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/events/core.c: At top level:
kernel/events/core.c:6535:6: warning: no previous prototype for 'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
6535 | long perf_pmu_snapshot_aux(struct perf_buffer *rb,
| ^~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from include/linux/migrate.h:8,
from kernel/sched/sched.h:53,
from kernel/sched/core.c:13:
include/linux/hugetlb.h: In function 'want_pmd_share':
>> include/linux/hugetlb.h:954:6: error: implicit declaration of function 'uffd_disable_huge_pmd_share' [-Werror=implicit-function-declaration]
954 | if (uffd_disable_huge_pmd_share(vma))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/core.c: In function 'schedule_tail':
kernel/sched/core.c:4238:13: warning: variable 'rq' set but not used [-Wunused-but-set-variable]
4238 | struct rq *rq;
| ^~
cc1: some warnings being treated as errors
--
In file included from include/linux/migrate.h:8,
from kernel/sched/sched.h:53,
from kernel/sched/rt.c:6:
include/linux/hugetlb.h: In function 'want_pmd_share':
>> include/linux/hugetlb.h:954:6: error: implicit declaration of function 'uffd_disable_huge_pmd_share' [-Werror=implicit-function-declaration]
954 | if (uffd_disable_huge_pmd_share(vma))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c: At top level:
kernel/sched/rt.c:669:6: warning: no previous prototype for 'sched_rt_bandwidth_account' [-Wmissing-prototypes]
669 | bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/uffd_disable_huge_pmd_share +954 include/linux/hugetlb.h
950
951 static inline bool want_pmd_share(struct vm_area_struct *vma)
952 {
953 #ifdef CONFIG_ARCH_WANT_HUGE_PMD_SHARE
> 954 if (uffd_disable_huge_pmd_share(vma))
955 return false;
956 return true;
957 #else
958 return false;
959 #endif
960 }
961
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 8 months