Re: [PATCH] fs: inode: use queue_rcu_work() instead of call_rcu()
by kernel test robot
Hi Zqiang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.15-rc5 next-20211015]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zqiang/fs-inode-use-queue_rcu_wo...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git ec681c53f8d2d0ee362ff67f5b98dd8263c15002
config: arc-randconfig-r043-20211014 (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2294caaec521b45bdc9db96423fe51762...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zqiang/fs-inode-use-queue_rcu_work-instead-of-call_rcu/20211015-160455
git checkout 2294caaec521b45bdc9db96423fe51762e47afd0
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash fs/ntfs3/ fs/xfs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from <command-line>:
fs/ntfs3/super.c: In function 'ntfs_i_callback':
>> include/linux/kernel.h:495:58: error: 'struct inode' has no member named 'i_rcu'
495 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
| ^~
include/linux/compiler_types.h:302:23: note: in definition of macro '__compiletime_assert'
302 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:322:9: note: in expansion of macro '_compiletime_assert'
322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/kernel.h:495:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
495 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
| ^~~~~~~~~~~~~~~~
include/linux/kernel.h:495:27: note: in expansion of macro '__same_type'
495 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
| ^~~~~~~~~~~
fs/ntfs3/super.c:458:31: note: in expansion of macro 'container_of'
458 | struct inode *inode = container_of(head, struct inode, i_rcu);
| ^~~~~~~~~~~~
>> include/linux/compiler_types.h:140:41: error: 'struct inode' has no member named 'i_rcu'
140 | #define __compiler_offsetof(a, b) __builtin_offsetof(a, b)
| ^~~~~~~~~~~~~~~~~~
include/linux/stddef.h:17:33: note: in expansion of macro '__compiler_offsetof'
17 | #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER)
| ^~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:498:28: note: in expansion of macro 'offsetof'
498 | ((type *)(__mptr - offsetof(type, member))); })
| ^~~~~~~~
fs/ntfs3/super.c:458:31: note: in expansion of macro 'container_of'
458 | struct inode *inode = container_of(head, struct inode, i_rcu);
| ^~~~~~~~~~~~
fs/ntfs3/super.c: In function 'ntfs_destroy_inode':
>> fs/ntfs3/super.c:468:24: error: 'struct inode' has no member named 'i_rcu'
468 | call_rcu(&inode->i_rcu, ntfs_i_callback);
| ^~
--
In file included from <command-line>:
fs/xfs/xfs_icache.c: In function 'xfs_inode_free_callback':
>> include/linux/kernel.h:495:58: error: 'struct inode' has no member named 'i_rcu'
495 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
| ^~
include/linux/compiler_types.h:302:23: note: in definition of macro '__compiletime_assert'
302 | if (!(condition)) \
| ^~~~~~~~~
include/linux/compiler_types.h:322:9: note: in expansion of macro '_compiletime_assert'
322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/kernel.h:495:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
495 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
| ^~~~~~~~~~~~~~~~
include/linux/kernel.h:495:27: note: in expansion of macro '__same_type'
495 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
| ^~~~~~~~~~~
fs/xfs/xfs_icache.c:120:42: note: in expansion of macro 'container_of'
120 | struct inode *inode = container_of(head, struct inode, i_rcu);
| ^~~~~~~~~~~~
>> include/linux/compiler_types.h:140:41: error: 'struct inode' has no member named 'i_rcu'
140 | #define __compiler_offsetof(a, b) __builtin_offsetof(a, b)
| ^~~~~~~~~~~~~~~~~~
include/linux/stddef.h:17:33: note: in expansion of macro '__compiler_offsetof'
17 | #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER)
| ^~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:498:28: note: in expansion of macro 'offsetof'
498 | ((type *)(__mptr - offsetof(type, member))); })
| ^~~~~~~~
fs/xfs/xfs_icache.c:120:42: note: in expansion of macro 'container_of'
120 | struct inode *inode = container_of(head, struct inode, i_rcu);
| ^~~~~~~~~~~~
fs/xfs/xfs_icache.c: In function '__xfs_inode_free':
>> fs/xfs/xfs_icache.c:158:28: error: 'struct inode' has no member named 'i_rcu'
158 | call_rcu(&VFS_I(ip)->i_rcu, xfs_inode_free_callback);
| ^~
vim +495 include/linux/kernel.h
cf14f27f82af78 Alexei Starovoitov 2018-03-28 485
^1da177e4c3f41 Linus Torvalds 2005-04-16 486 /**
^1da177e4c3f41 Linus Torvalds 2005-04-16 487 * container_of - cast a member of a structure out to the containing structure
^1da177e4c3f41 Linus Torvalds 2005-04-16 488 * @ptr: the pointer to the member.
^1da177e4c3f41 Linus Torvalds 2005-04-16 489 * @type: the type of the container struct this is embedded in.
^1da177e4c3f41 Linus Torvalds 2005-04-16 490 * @member: the name of the member within the struct.
^1da177e4c3f41 Linus Torvalds 2005-04-16 491 *
^1da177e4c3f41 Linus Torvalds 2005-04-16 492 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 493 #define container_of(ptr, type, member) ({ \
c7acec713d14c6 Ian Abbott 2017-07-12 494 void *__mptr = (void *)(ptr); \
c7acec713d14c6 Ian Abbott 2017-07-12 @495 BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
c7acec713d14c6 Ian Abbott 2017-07-12 496 !__same_type(*(ptr), void), \
c7acec713d14c6 Ian Abbott 2017-07-12 497 "pointer type mismatch in container_of()"); \
c7acec713d14c6 Ian Abbott 2017-07-12 498 ((type *)(__mptr - offsetof(type, member))); })
^1da177e4c3f41 Linus Torvalds 2005-04-16 499
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[tglx-devel:x86/fpu-kvm 88/88] arch/x86/kernel/fpu/core.c:281:6: warning: variable 'ret' set but not used
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git x86/fpu-kvm
head: dc3cd5721cdb0d3116a2feb84755427d1522477a
commit: dc3cd5721cdb0d3116a2feb84755427d1522477a [88/88] x86/fpu: Add reallocation mechanims for KVM
config: x86_64-randconfig-r031-20211017 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 746dd6a700931988dd9021d3d04718f1929885a5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/commit/?id...
git remote add tglx-devel https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git
git fetch --no-tags tglx-devel x86/fpu-kvm
git checkout dc3cd5721cdb0d3116a2feb84755427d1522477a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/kernel/fpu/core.c:281:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
int ret;
^
1 warning generated.
vim +/ret +281 arch/x86/kernel/fpu/core.c
275
276 int fpu_swap_kvm_fpstate(struct fpu_guest *guest_fpu, bool enter_guest,
277 u64 restore_mask)
278 {
279 struct fpstate *guest_fps, *cur_fps;
280 struct fpu *fpu = ¤t->thread.fpu;
> 281 int ret;
282
283 if (unlikely(guest_fpu->realloc_request))
284 ret = fpu_guest_realloc_fpstate(guest_fpu, enter_guest);
285
286 guest_fps = guest_fpu->fpstate;
287 cur_fps = fpu->fpstate;
288
289 fpregs_lock();
290 if (!cur_fps->is_confidential && !test_thread_flag(TIF_NEED_FPU_LOAD))
291 save_fpregs_to_fpstate(fpu);
292
293 /* Swap fpstate */
294 if (enter_guest) {
295 fpu->__task_fpstate = cur_fps;
296 fpu->fpstate = guest_fps;
297 guest_fps->in_use = true;
298 } else {
299 guest_fps->in_use = false;
300 fpu->fpstate = fpu->__task_fpstate;
301 fpu->__task_fpstate = NULL;
302 }
303
304 cur_fps = fpu->fpstate;
305
306 if (!cur_fps->is_confidential) {
307 restore_mask &= XFEATURE_MASK_FPSTATE;
308 /* Includes XFD update */
309 restore_fpregs_from_fpstate(cur_fps, restore_mask);
310 } else {
311 /*
312 * XSTATE is restored by firmware from encrypted
313 * memory. Make sure XFD state is correct while
314 * running with guest fpstate
315 */
316 xfd_update_state(cur_fps);
317 }
318
319 fpregs_mark_activate();
320 fpregs_unlock();
321 return 0;
322 }
323 EXPORT_SYMBOL_GPL(fpu_swap_kvm_fpstate);
324
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[frank-w-bpi-r2-4.14:5.15-bpi-r2-pro-drm 86/101] drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1589:44: error: no member named 'data' in 'struct vop_win'
by kernel test robot
tree: https://github.com/frank-w/BPI-R2-4.14 5.15-bpi-r2-pro-drm
head: 16da2cf02e8cf795a7c5334a73478075c1448889
commit: 8d1ae5e7a36e4a9c9a38506d3611f7171eb45772 [86/101] add missing includes dt-bindings/soc/rockchip-system-status.h and soc/rockchip/rockchip-system-status.h
config: i386-randconfig-c001-20211017 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 746dd6a700931988dd9021d3d04718f1929885a5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/frank-w/BPI-R2-4.14/commit/8d1ae5e7a36e4a9c9a38506d361...
git remote add frank-w-bpi-r2-4.14 https://github.com/frank-w/BPI-R2-4.14
git fetch --no-tags frank-w-bpi-r2-4.14 5.15-bpi-r2-pro-drm
git checkout 8d1ae5e7a36e4a9c9a38506d3611f7171eb45772
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the frank-w-bpi-r2-4.14/5.15-bpi-r2-pro-drm HEAD 16da2cf02e8cf795a7c5334a73478075c1448889 builds fine.
It only hurts bisectability.
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1589:44: error: no member named 'data' in 'struct vop_win'
const struct vop_win_data *win = vop_win->data;
~~~~~~~ ^
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1617:19: error: no member named 'src_x' in 'struct drm_atomic_state'
src->x1 = state->src_x;
~~~~~ ^
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1618:19: error: no member named 'src_y' in 'struct drm_atomic_state'
src->y1 = state->src_y;
~~~~~ ^
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1619:19: error: no member named 'src_x' in 'struct drm_atomic_state'
src->x2 = state->src_x + state->src_w;
~~~~~ ^
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1619:34: error: no member named 'src_w' in 'struct drm_atomic_state'
src->x2 = state->src_x + state->src_w;
~~~~~ ^
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1620:19: error: no member named 'src_y' in 'struct drm_atomic_state'
src->y2 = state->src_y + state->src_h;
~~~~~ ^
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1620:34: error: no member named 'src_h' in 'struct drm_atomic_state'
src->y2 = state->src_y + state->src_h;
~~~~~ ^
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1621:20: error: no member named 'crtc_x' in 'struct drm_atomic_state'; did you mean 'crtcs'?
dest->x1 = state->crtc_x;
^~~~~~
crtcs
include/drm/drm_atomic.h:383:28: note: 'crtcs' declared here
struct __drm_crtcs_state *crtcs;
^
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1622:20: error: no member named 'crtc_y' in 'struct drm_atomic_state'; did you mean 'crtcs'?
dest->y1 = state->crtc_y;
^~~~~~
crtcs
include/drm/drm_atomic.h:383:28: note: 'crtcs' declared here
struct __drm_crtcs_state *crtcs;
^
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1623:20: error: no member named 'crtc_x' in 'struct drm_atomic_state'
dest->x2 = state->crtc_x + state->crtc_w;
~~~~~ ^
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1623:36: error: no member named 'crtc_w' in 'struct drm_atomic_state'
dest->x2 = state->crtc_x + state->crtc_w;
~~~~~ ^
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1624:20: error: no member named 'crtc_y' in 'struct drm_atomic_state'
dest->y2 = state->crtc_y + state->crtc_h;
~~~~~ ^
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1624:36: error: no member named 'crtc_h' in 'struct drm_atomic_state'
dest->y2 = state->crtc_y + state->crtc_h;
~~~~~ ^
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1642:13: error: no member named 'src_w' in 'struct drm_atomic_state'
if (state->src_w >> 16 < 4 || state->src_h >> 16 < 4 ||
~~~~~ ^
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1642:39: error: no member named 'src_h' in 'struct drm_atomic_state'
if (state->src_w >> 16 < 4 || state->src_h >> 16 < 4 ||
~~~~~ ^
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1643:13: error: no member named 'crtc_w' in 'struct drm_atomic_state'; did you mean 'crtcs'?
state->crtc_w < 4 || state->crtc_h < 4) {
^~~~~~
crtcs
include/drm/drm_atomic.h:383:28: note: 'crtcs' declared here
struct __drm_crtcs_state *crtcs;
^
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1643:34: error: no member named 'crtc_h' in 'struct drm_atomic_state'; did you mean 'crtcs'?
state->crtc_w < 4 || state->crtc_h < 4) {
^~~~~~
crtcs
include/drm/drm_atomic.h:383:28: note: 'crtcs' declared here
struct __drm_crtcs_state *crtcs;
^
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1645:13: error: no member named 'src_w' in 'struct drm_atomic_state'
state->src_w >> 16, state->src_h >> 16,
~~~~~ ^
include/drm/drm_print.h:498:19: note: expanded from macro 'DRM_ERROR'
__drm_err(fmt, ##__VA_ARGS__)
^~~~~~~~~~~
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1645:33: error: no member named 'src_h' in 'struct drm_atomic_state'
state->src_w >> 16, state->src_h >> 16,
~~~~~ ^
include/drm/drm_print.h:498:19: note: expanded from macro 'DRM_ERROR'
__drm_err(fmt, ##__VA_ARGS__)
^~~~~~~~~~~
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
vim +1589 drivers/gpu/drm/rockchip/rockchip_drm_vop.c
7707f7227f0961 Andrzej Pietrasiewicz 2020-03-11 1579
63ebb9fa7ff06d Mark Yao 2015-11-30 1580 static int vop_plane_atomic_check(struct drm_plane *plane,
7c11b99a8e58c0 Maxime Ripard 2021-02-19 1581 struct drm_atomic_state *state)
2048e3286f347d Mark Yao 2014-08-22 1582 {
7c11b99a8e58c0 Maxime Ripard 2021-02-19 1583 struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
7c11b99a8e58c0 Maxime Ripard 2021-02-19 1584 plane);
ba5c1649465d40 Maxime Ripard 2021-02-19 1585 struct drm_crtc *crtc = new_plane_state->crtc;
92915da647be83 John Keeping 2016-03-04 1586 struct drm_crtc_state *crtc_state;
ba5c1649465d40 Maxime Ripard 2021-02-19 1587 struct drm_framebuffer *fb = new_plane_state->fb;
2048e3286f347d Mark Yao 2014-08-22 1588 struct vop_win *vop_win = to_vop_win(plane);
2048e3286f347d Mark Yao 2014-08-22 @1589 const struct vop_win_data *win = vop_win->data;
671b538f2b304c Benjamin Gaignard 2021-05-17 1590 struct vop_plane_state *vop_plane_state = to_vop_plane_state(state);
671b538f2b304c Benjamin Gaignard 2021-05-17 1591 const struct vop_data *vop_data;
671b538f2b304c Benjamin Gaignard 2021-05-17 1592 struct vop *vop;
2048e3286f347d Mark Yao 2014-08-22 1593 int ret;
671b538f2b304c Benjamin Gaignard 2021-05-17 1594 struct drm_rect *dest = &vop_plane_state->dest;
671b538f2b304c Benjamin Gaignard 2021-05-17 1595 struct drm_rect *src = &vop_plane_state->src;
4c156c21c7948a Mark Yao 2015-06-26 1596 int min_scale = win->phy->scl ? FRAC_16_16(1, 8) :
4c156c21c7948a Mark Yao 2015-06-26 1597 DRM_PLANE_HELPER_NO_SCALING;
4c156c21c7948a Mark Yao 2015-06-26 1598 int max_scale = win->phy->scl ? FRAC_16_16(8, 1) :
4c156c21c7948a Mark Yao 2015-06-26 1599 DRM_PLANE_HELPER_NO_SCALING;
671b538f2b304c Benjamin Gaignard 2021-05-17 1600 unsigned long offset;
671b538f2b304c Benjamin Gaignard 2021-05-17 1601 struct drm_gem_object *obj;
671b538f2b304c Benjamin Gaignard 2021-05-17 1602 struct rockchip_gem_object *rk_obj;
671b538f2b304c Benjamin Gaignard 2021-05-17 1603 dma_addr_t dma_addr;
671b538f2b304c Benjamin Gaignard 2021-05-17 1604 void *kvaddr;
2048e3286f347d Mark Yao 2014-08-22 1605
671b538f2b304c Benjamin Gaignard 2021-05-17 1606 crtc = crtc ? crtc : plane->state->crtc;
671b538f2b304c Benjamin Gaignard 2021-05-17 1607 if (!crtc || !fb) {
671b538f2b304c Benjamin Gaignard 2021-05-17 1608 plane->state->visible = false;
d47a7246bb5f2a Tomasz Figa 2016-09-14 1609 return 0;
671b538f2b304c Benjamin Gaignard 2021-05-17 1610 }
92915da647be83 John Keeping 2016-03-04 1611
dec92020671c48 Maxime Ripard 2021-02-19 1612 crtc_state = drm_atomic_get_existing_crtc_state(state,
ba5c1649465d40 Maxime Ripard 2021-02-19 1613 crtc);
92915da647be83 John Keeping 2016-03-04 1614 if (WARN_ON(!crtc_state))
92915da647be83 John Keeping 2016-03-04 1615 return -EINVAL;
92915da647be83 John Keeping 2016-03-04 1616
671b538f2b304c Benjamin Gaignard 2021-05-17 @1617 src->x1 = state->src_x;
671b538f2b304c Benjamin Gaignard 2021-05-17 @1618 src->y1 = state->src_y;
671b538f2b304c Benjamin Gaignard 2021-05-17 @1619 src->x2 = state->src_x + state->src_w;
671b538f2b304c Benjamin Gaignard 2021-05-17 @1620 src->y2 = state->src_y + state->src_h;
671b538f2b304c Benjamin Gaignard 2021-05-17 @1621 dest->x1 = state->crtc_x;
671b538f2b304c Benjamin Gaignard 2021-05-17 @1622 dest->y1 = state->crtc_y;
671b538f2b304c Benjamin Gaignard 2021-05-17 @1623 dest->x2 = state->crtc_x + state->crtc_w;
671b538f2b304c Benjamin Gaignard 2021-05-17 @1624 dest->y2 = state->crtc_y + state->crtc_h;
671b538f2b304c Benjamin Gaignard 2021-05-17 1625
ba5c1649465d40 Maxime Ripard 2021-02-19 1626 ret = drm_atomic_helper_check_plane_state(new_plane_state, crtc_state,
f9b96be0ecb349 Ville Syrjälä 2016-07-26 1627 min_scale, max_scale,
f9b96be0ecb349 Ville Syrjälä 2016-07-26 1628 true, true);
2048e3286f347d Mark Yao 2014-08-22 1629 if (ret)
2048e3286f347d Mark Yao 2014-08-22 1630 return ret;
2048e3286f347d Mark Yao 2014-08-22 1631
ba5c1649465d40 Maxime Ripard 2021-02-19 1632 if (!new_plane_state->visible)
d47a7246bb5f2a Tomasz Figa 2016-09-14 1633 return 0;
84c7f8ca43000e Mark Yao 2015-07-20 1634
671b538f2b304c Benjamin Gaignard 2021-05-17 1635 vop_plane_state->format = vop_convert_format(fb->format->format);
671b538f2b304c Benjamin Gaignard 2021-05-17 1636 if (vop_plane_state->format < 0)
671b538f2b304c Benjamin Gaignard 2021-05-17 1637 return vop_plane_state->format;
671b538f2b304c Benjamin Gaignard 2021-05-17 1638
671b538f2b304c Benjamin Gaignard 2021-05-17 1639 vop = to_vop(crtc);
671b538f2b304c Benjamin Gaignard 2021-05-17 1640 vop_data = vop->data;
671b538f2b304c Benjamin Gaignard 2021-05-17 1641
671b538f2b304c Benjamin Gaignard 2021-05-17 1642 if (state->src_w >> 16 < 4 || state->src_h >> 16 < 4 ||
671b538f2b304c Benjamin Gaignard 2021-05-17 1643 state->crtc_w < 4 || state->crtc_h < 4) {
671b538f2b304c Benjamin Gaignard 2021-05-17 1644 DRM_ERROR("Invalid size: %dx%d->%dx%d, min size is 4x4\n",
671b538f2b304c Benjamin Gaignard 2021-05-17 1645 state->src_w >> 16, state->src_h >> 16,
671b538f2b304c Benjamin Gaignard 2021-05-17 1646 state->crtc_w, state->crtc_h);
671b538f2b304c Benjamin Gaignard 2021-05-17 1647 return -EINVAL;
671b538f2b304c Benjamin Gaignard 2021-05-17 1648 }
671b538f2b304c Benjamin Gaignard 2021-05-17 1649
671b538f2b304c Benjamin Gaignard 2021-05-17 1650 if (drm_rect_width(src) >> 16 > vop_data->max_input.width ||
671b538f2b304c Benjamin Gaignard 2021-05-17 1651 drm_rect_height(src) >> 16 > vop_data->max_input.height) {
671b538f2b304c Benjamin Gaignard 2021-05-17 1652 DRM_ERROR("Invalid source: %dx%d. max input: %dx%d\n",
671b538f2b304c Benjamin Gaignard 2021-05-17 1653 drm_rect_width(src) >> 16,
671b538f2b304c Benjamin Gaignard 2021-05-17 1654 drm_rect_height(src) >> 16,
671b538f2b304c Benjamin Gaignard 2021-05-17 1655 vop_data->max_input.width,
671b538f2b304c Benjamin Gaignard 2021-05-17 1656 vop_data->max_input.height);
671b538f2b304c Benjamin Gaignard 2021-05-17 1657 return -EINVAL;
671b538f2b304c Benjamin Gaignard 2021-05-17 1658 }
2048e3286f347d Mark Yao 2014-08-22 1659
84c7f8ca43000e Mark Yao 2015-07-20 1660 /*
84c7f8ca43000e Mark Yao 2015-07-20 1661 * Src.x1 can be odd when do clip, but yuv plane start point
84c7f8ca43000e Mark Yao 2015-07-20 1662 * need align with 2 pixel.
84c7f8ca43000e Mark Yao 2015-07-20 1663 */
ba5c1649465d40 Maxime Ripard 2021-02-19 1664 if (fb->format->is_yuv && ((new_plane_state->src.x1 >> 16) % 2)) {
d415fb87aa0051 Mark Yao 2017-07-31 1665 DRM_ERROR("Invalid Source: Yuv format not support odd xpos\n");
63ebb9fa7ff06d Mark Yao 2015-11-30 1666 return -EINVAL;
d415fb87aa0051 Mark Yao 2017-07-31 1667 }
84c7f8ca43000e Mark Yao 2015-07-20 1668
ba5c1649465d40 Maxime Ripard 2021-02-19 1669 if (fb->format->is_yuv && new_plane_state->rotation & DRM_MODE_REFLECT_Y) {
677e8bbc0e5a9f Daniele Castagna 2019-01-09 1670 DRM_ERROR("Invalid Source: Yuv format does not support this rotation\n");
677e8bbc0e5a9f Daniele Castagna 2019-01-09 1671 return -EINVAL;
677e8bbc0e5a9f Daniele Castagna 2019-01-09 1672 }
677e8bbc0e5a9f Daniele Castagna 2019-01-09 1673
671b538f2b304c Benjamin Gaignard 2021-05-17 1674 offset = (src->x1 >> 16) * fb->format->cpp[0] / 8;
671b538f2b304c Benjamin Gaignard 2021-05-17 1675 vop_plane_state->offset = offset + fb->offsets[0];
671b538f2b304c Benjamin Gaignard 2021-05-17 1676 if (state->rotation & DRM_MODE_REFLECT_Y)
671b538f2b304c Benjamin Gaignard 2021-05-17 1677 offset += ((src->y2 >> 16) - 1) * fb->pitches[0];
671b538f2b304c Benjamin Gaignard 2021-05-17 1678 else
671b538f2b304c Benjamin Gaignard 2021-05-17 1679 offset += (src->y1 >> 16) * fb->pitches[0];
7707f7227f0961 Andrzej Pietrasiewicz 2020-03-11 1680
671b538f2b304c Benjamin Gaignard 2021-05-17 1681 obj = fb->obj[0];
671b538f2b304c Benjamin Gaignard 2021-05-17 1682 rk_obj = to_rockchip_obj(obj);
671b538f2b304c Benjamin Gaignard 2021-05-17 1683 dma_addr = rk_obj->dma_addr;
671b538f2b304c Benjamin Gaignard 2021-05-17 1684 kvaddr = rk_obj->kvaddr;
671b538f2b304c Benjamin Gaignard 2021-05-17 1685 vop_plane_state->yrgb_mst = dma_addr + offset + fb->offsets[0];
671b538f2b304c Benjamin Gaignard 2021-05-17 1686 vop_plane_state->yrgb_kvaddr = kvaddr + offset + fb->offsets[0];
671b538f2b304c Benjamin Gaignard 2021-05-17 1687 if (fb->format->is_yuv) {
671b538f2b304c Benjamin Gaignard 2021-05-17 1688 int hsub = fb->format->hsub;
671b538f2b304c Benjamin Gaignard 2021-05-17 1689 int vsub = fb->format->vsub;
7707f7227f0961 Andrzej Pietrasiewicz 2020-03-11 1690
ba5c1649465d40 Maxime Ripard 2021-02-19 1691 if (new_plane_state->src.x1 || new_plane_state->src.y1) {
ba5c1649465d40 Maxime Ripard 2021-02-19 1692 DRM_ERROR("AFBC does not support offset display, xpos=%d, ypos=%d, offset=%d\n",
ba5c1649465d40 Maxime Ripard 2021-02-19 1693 new_plane_state->src.x1,
ba5c1649465d40 Maxime Ripard 2021-02-19 1694 new_plane_state->src.y1, fb->offsets[0]);
7707f7227f0961 Andrzej Pietrasiewicz 2020-03-11 1695 return -EINVAL;
7707f7227f0961 Andrzej Pietrasiewicz 2020-03-11 1696 }
7707f7227f0961 Andrzej Pietrasiewicz 2020-03-11 1697
ba5c1649465d40 Maxime Ripard 2021-02-19 1698 if (new_plane_state->rotation && new_plane_state->rotation != DRM_MODE_ROTATE_0) {
7707f7227f0961 Andrzej Pietrasiewicz 2020-03-11 1699 DRM_ERROR("No rotation support in AFBC, rotation=%d\n",
ba5c1649465d40 Maxime Ripard 2021-02-19 1700 new_plane_state->rotation);
7707f7227f0961 Andrzej Pietrasiewicz 2020-03-11 1701 return -EINVAL;
7707f7227f0961 Andrzej Pietrasiewicz 2020-03-11 1702 }
671b538f2b304c Benjamin Gaignard 2021-05-17 1703
671b538f2b304c Benjamin Gaignard 2021-05-17 1704 offset = (src->x1 >> 16) * fb->format->cpp[1] / hsub / 8;
671b538f2b304c Benjamin Gaignard 2021-05-17 1705 offset += (src->y1 >> 16) * fb->pitches[1] / vsub;
671b538f2b304c Benjamin Gaignard 2021-05-17 1706
671b538f2b304c Benjamin Gaignard 2021-05-17 1707 obj = fb->obj[1];
671b538f2b304c Benjamin Gaignard 2021-05-17 1708 rk_obj = to_rockchip_obj(obj);
671b538f2b304c Benjamin Gaignard 2021-05-17 1709 dma_addr = rk_obj->dma_addr;
671b538f2b304c Benjamin Gaignard 2021-05-17 1710 dma_addr += offset + fb->offsets[1];
671b538f2b304c Benjamin Gaignard 2021-05-17 1711 vop_plane_state->uv_mst = dma_addr;
7707f7227f0961 Andrzej Pietrasiewicz 2020-03-11 1712 }
7707f7227f0961 Andrzej Pietrasiewicz 2020-03-11 1713
63ebb9fa7ff06d Mark Yao 2015-11-30 1714 return 0;
63ebb9fa7ff06d Mark Yao 2015-11-30 1715 }
2048e3286f347d Mark Yao 2014-08-22 1716
:::::: The code at line 1589 was first introduced by commit
:::::: 2048e3286f347db5667708e47448176b5329e8d8 drm: rockchip: Add basic drm driver
:::::: TO: Mark Yao <mark.yao(a)rock-chips.com>
:::::: CC: yzq <yzq(a)rock-chips.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[tglx-devel:x86/fpu-kvm 69/88] arch/x86/kernel/fpu/xstate.c:1450:33: error: too few arguments to function call, expected 2, have 1
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git x86/fpu-kvm
head: dc3cd5721cdb0d3116a2feb84755427d1522477a
commit: cdf2ff477461d9bfdeb7eac39d61ffbe1e323322 [69/88] x86/arch_prctl: Add controls for dynamic XSTATE components
config: i386-randconfig-r032-20211017 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 746dd6a700931988dd9021d3d04718f1929885a5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/commit/?id...
git remote add tglx-devel https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git
git fetch --no-tags tglx-devel x86/fpu-kvm
git checkout cdf2ff477461d9bfdeb7eac39d61ffbe1e323322
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the tglx-devel/x86/fpu-kvm HEAD dc3cd5721cdb0d3116a2feb84755427d1522477a builds fine.
It only hurts bisectability.
All errors (new ones prefixed by >>):
>> arch/x86/kernel/fpu/xstate.c:1450:33: error: too few arguments to function call, expected 2, have 1
return xstate_request_perm(idx);
~~~~~~~~~~~~~~~~~~~ ^
arch/x86/kernel/fpu/xstate.c:1399:19: note: 'xstate_request_perm' declared here
static inline int xstate_request_perm(u64 permitted, u64 requested)
^
1 error generated.
vim +1450 arch/x86/kernel/fpu/xstate.c
1404
1405 /**
1406 * fpu_xstate_prctl - xstate permission operations
1407 * @tsk: Redundant pointer to current
1408 * @option: A subfunction of arch_prctl()
1409 * @arg2: option argument
1410 * Return: 0 if successful; otherwise, an error code
1411 *
1412 * Option arguments:
1413 *
1414 * ARCH_GET_XCOMP_SUPP: Pointer to user space u64 to store the info
1415 * ARCH_GET_XCOMP_PERM: Pointer to user space u64 to store the info
1416 * ARCH_REQ_XCOMP_PERM: Facility number requested
1417 *
1418 * For facilities which require more than one XSTATE component, the request
1419 * must be the highest state component number related to that facility,
1420 * e.g. for AMX which requires XFEATURE_XTILE_CFG(17) and
1421 * XFEATURE_XTILE_DATA(18) this would be XFEATURE_XTILE_DATA(18).
1422 */
1423 long fpu_xstate_prctl(struct task_struct *tsk, int option, unsigned long arg2)
1424 {
1425 u64 __user *uptr = (u64 __user *)arg2;
1426 u64 permitted, supported;
1427 unsigned long idx = arg2;
1428
1429 if (tsk != current)
1430 return -EPERM;
1431
1432 switch (option) {
1433 case ARCH_GET_XCOMP_SUPP:
1434 supported = fpu_user_cfg.max_features | fpu_user_cfg.legacy_features;
1435 return put_user(supported , uptr);
1436
1437 case ARCH_GET_XCOMP_PERM:
1438 /*
1439 * Lockless snapshot as it can also change right after the
1440 * dropping the lock.
1441 */
1442 permitted = xstate_get_host_group_perm();
1443 permitted &= XFEATURE_MASK_USER_SUPPORTED;
1444 return put_user(permitted, uptr);
1445
1446 case ARCH_REQ_XCOMP_PERM:
1447 if (!IS_ENABLED(CONFIG_X86_64))
1448 return -ENOTSUPP;
1449
> 1450 return xstate_request_perm(idx);
1451
1452 default:
1453 return -EINVAL;
1454 }
1455 }
1456
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
Re: [PATCH] staging: rts5208: ms.c: Remove two udelay calls and use usleep_range instead
by kernel test robot
In-Reply-To: <YWwWoB3+4HQTD4/t@Mononoke>
References: <YWwWoB3+4HQTD4/t@Mononoke>
TO: Sebastian Luchetti <luchetti.linux(a)gmail.com>
TO: gregkh(a)linuxfoundation.org
CC: linux-staging(a)lists.linux.dev
CC: linux-kernel(a)vger.kernel.org
Hi Sebastian,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Sebastian-Luchetti/staging-rts52...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 502408a61f4b7eb4713f44bd77f4a48e6cb1b59a
config: riscv-randconfig-r006-20211017 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 746dd6a700931988dd9021d3d04718f1929885a5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/b242c37ce924b13b53c953fd40aa8d67e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sebastian-Luchetti/staging-rts5208-ms-c-Remove-two-udelay-calls-and-use-usleep_range-instead/20211017-202851
git checkout b242c37ce924b13b53c953fd40aa8d67e95ec38b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> ld.lld: error: do_mounts.c:(function name_to_dev_t: .text+0x18): relocation R_RISCV_HI20 out of range: 529548 is not in [-524288, 524287]
ld.lld: error: do_mounts.c:(function name_to_dev_t: .text+0x30): relocation R_RISCV_HI20 out of range: 529491 is not in [-524288, 524287]
ld.lld: error: do_mounts.c:(function name_to_dev_t: .text+0x48): relocation R_RISCV_HI20 out of range: 529701 is not in [-524288, 524287]
ld.lld: error: do_mounts.c:(function name_to_dev_t: .text+0x74): relocation R_RISCV_HI20 out of range: 529515 is not in [-524288, 524287]
ld.lld: error: do_mounts.c:(function name_to_dev_t: .text+0x9C): relocation R_RISCV_HI20 out of range: 529661 is not in [-524288, 524287]
ld.lld: error: cpu.c:(function riscv_of_processor_hartid: .text+0x20): relocation R_RISCV_HI20 out of range: 529661 is not in [-524288, 524287]
ld.lld: error: cpu.c:(function riscv_of_processor_hartid: .text+0x38): relocation R_RISCV_HI20 out of range: 529653 is not in [-524288, 524287]
ld.lld: error: cpu.c:(function riscv_of_processor_hartid: .text+0x6C): relocation R_RISCV_HI20 out of range: 529457 is not in [-524288, 524287]
ld.lld: error: cpu.c:(function riscv_of_processor_hartid: .text+0xC4): relocation R_RISCV_HI20 out of range: 529701 is not in [-524288, 524287]
ld.lld: error: cpu.c:(function riscv_of_processor_hartid: .text+0xDC): relocation R_RISCV_HI20 out of range: 529474 is not in [-524288, 524287]
ld.lld: error: cpu.c:(function riscv_of_processor_hartid: .text+0xE8): relocation R_RISCV_HI20 out of range: 529474 is not in [-524288, 524287]
ld.lld: error: cpu.c:(function riscv_of_processor_hartid: .text+0x104): relocation R_RISCV_HI20 out of range: 529621 is not in [-524288, 524287]
ld.lld: error: cpu.c:(function riscv_of_processor_hartid: .text+0x114): relocation R_RISCV_HI20 out of range: 529474 is not in [-524288, 524287]
ld.lld: error: cpu.c:(function riscv_of_parent_hartid: .text+0x154): relocation R_RISCV_HI20 out of range: 529661 is not in [-524288, 524287]
ld.lld: error: cpu.c:(function c_start: .text+0x1CC): relocation R_RISCV_HI20 out of range: 530232 is not in [-524288, 524287]; references __cpu_online_mask
>>> defined in kernel/built-in.a(cpu.o)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[frank-w-bpi-r2-4.14:5.15-bpi-r2-pro-drm 98/101] drivers/gpu/drm/rockchip/rockchip_drm_vop.c:306:46: warning: unused variable 'drm_bus_format_enum_list'
by kernel test robot
tree: https://github.com/frank-w/BPI-R2-4.14 5.15-bpi-r2-pro-drm
head: 16da2cf02e8cf795a7c5334a73478075c1448889
commit: ba6fb3823ee2cd11ea95cec9db41fc0053fe06b5 [98/101] fix vop_crtc_atomic_{enable,flush}
config: x86_64-randconfig-a003-20211017 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 746dd6a700931988dd9021d3d04718f1929885a5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/frank-w/BPI-R2-4.14/commit/ba6fb3823ee2cd11ea95cec9db4...
git remote add frank-w-bpi-r2-4.14 https://github.com/frank-w/BPI-R2-4.14
git fetch --no-tags frank-w-bpi-r2-4.14 5.15-bpi-r2-pro-drm
git checkout ba6fb3823ee2cd11ea95cec9db41fc0053fe06b5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:306:46: warning: unused variable 'drm_bus_format_enum_list' [-Wunused-const-variable]
static const struct drm_bus_format_enum_list drm_bus_format_enum_list[] = {
^
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:546:24: warning: unused function 'vop_read_lut' [-Wunused-function]
static inline uint32_t vop_read_lut(struct vop *vop, uint32_t offset)
^
2 warnings generated.
vim +/drm_bus_format_enum_list +306 drivers/gpu/drm/rockchip/rockchip_drm_vop.c
671b538f2b304c Benjamin Gaignard 2021-05-17 305
671b538f2b304c Benjamin Gaignard 2021-05-17 @306 static const struct drm_bus_format_enum_list drm_bus_format_enum_list[] = {
671b538f2b304c Benjamin Gaignard 2021-05-17 307 { DRM_MODE_CONNECTOR_Unknown, "Unknown" },
671b538f2b304c Benjamin Gaignard 2021-05-17 308 { MEDIA_BUS_FMT_RGB565_1X16, "RGB565_1X16" },
671b538f2b304c Benjamin Gaignard 2021-05-17 309 { MEDIA_BUS_FMT_RGB666_1X18, "RGB666_1X18" },
671b538f2b304c Benjamin Gaignard 2021-05-17 310 { MEDIA_BUS_FMT_RGB666_1X24_CPADHI, "RGB666_1X24_CPADHI" },
671b538f2b304c Benjamin Gaignard 2021-05-17 311 { MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, "RGB666_1X7X3_SPWG" },
671b538f2b304c Benjamin Gaignard 2021-05-17 312 { MEDIA_BUS_FMT_YUV8_1X24, "YUV8_1X24" },
671b538f2b304c Benjamin Gaignard 2021-05-17 313 { MEDIA_BUS_FMT_UYYVYY8_0_5X24, "UYYVYY8_0_5X24" },
671b538f2b304c Benjamin Gaignard 2021-05-17 314 { MEDIA_BUS_FMT_YUV10_1X30, "YUV10_1X30" },
671b538f2b304c Benjamin Gaignard 2021-05-17 315 { MEDIA_BUS_FMT_UYYVYY10_0_5X30, "UYYVYY10_0_5X30" },
671b538f2b304c Benjamin Gaignard 2021-05-17 316 { MEDIA_BUS_FMT_RGB888_1X24, "RGB888_1X24" },
671b538f2b304c Benjamin Gaignard 2021-05-17 317 { MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, "RGB888_1X7X4_SPWG" },
671b538f2b304c Benjamin Gaignard 2021-05-17 318 { MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA, "RGB888_1X7X4_JEIDA" },
671b538f2b304c Benjamin Gaignard 2021-05-17 319 };
671b538f2b304c Benjamin Gaignard 2021-05-17 320
:::::: The code at line 306 was first introduced by commit
:::::: 671b538f2b304cf24dbbbe25615bef2e86fef84d drm: forward port of VOP2 driver
:::::: TO: Benjamin Gaignard <benjamin.gaignard(a)collabora.com>
:::::: CC: Frank Wunderlich <frank-w(a)public-files.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[frank-w-bpi-r2-4.14:5.15-bpi-r2-pro-drm 93/101] drivers/gpu/drm/rockchip/rockchip_vop_reg.c:1762:34: warning: unused variable 'vop_driver_dt_match'
by kernel test robot
tree: https://github.com/frank-w/BPI-R2-4.14 5.15-bpi-r2-pro-drm
head: 16da2cf02e8cf795a7c5334a73478075c1448889
commit: e84067c6d3f46b8ebf5c80dec567909c8e3874ee [93/101] fix redefinitions
config: x86_64-randconfig-a003-20211017 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 746dd6a700931988dd9021d3d04718f1929885a5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/frank-w/BPI-R2-4.14/commit/e84067c6d3f46b8ebf5c80dec56...
git remote add frank-w-bpi-r2-4.14 https://github.com/frank-w/BPI-R2-4.14
git fetch --no-tags frank-w-bpi-r2-4.14 5.15-bpi-r2-pro-drm
git checkout e84067c6d3f46b8ebf5c80dec567909c8e3874ee
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/rockchip/rockchip_vop_reg.c:1762:34: warning: unused variable 'vop_driver_dt_match' [-Wunused-const-variable]
static const struct of_device_id vop_driver_dt_match[] = {
^
1 warning generated.
vim +/vop_driver_dt_match +1762 drivers/gpu/drm/rockchip/rockchip_vop_reg.c
eb5cb6aa9a72a7 Mark Yao 2017-07-26 1761
a67719d182291b Mark Yao 2015-12-15 @1762 static const struct of_device_id vop_driver_dt_match[] = {
f7673453506035 Mark Yao 2015-12-15 1763 { .compatible = "rockchip,rk3036-vop",
f7673453506035 Mark Yao 2015-12-15 1764 .data = &rk3036_vop },
671b538f2b304c Benjamin Gaignard 2021-05-17 1765 { .compatible = "rockchip,rk3066-vop",
671b538f2b304c Benjamin Gaignard 2021-05-17 1766 .data = &rk3066_vop },
460c3b0029923a Sandy Huang 2017-11-14 1767 { .compatible = "rockchip,rk3126-vop",
460c3b0029923a Sandy Huang 2017-11-14 1768 .data = &rk3126_vop },
570913e0b1bebe Sandy Huang 2018-06-26 1769 { .compatible = "rockchip,px30-vop-lit",
570913e0b1bebe Sandy Huang 2018-06-26 1770 .data = &px30_vop_lit },
671b538f2b304c Benjamin Gaignard 2021-05-17 1771 { .compatible = "rockchip,px30-vop-big",
671b538f2b304c Benjamin Gaignard 2021-05-17 1772 .data = &px30_vop_big },
671b538f2b304c Benjamin Gaignard 2021-05-17 1773 { .compatible = "rockchip,rk3308-vop",
671b538f2b304c Benjamin Gaignard 2021-05-17 1774 .data = &rk3308_vop },
671b538f2b304c Benjamin Gaignard 2021-05-17 1775 { .compatible = "rockchip,rv1126-vop",
671b538f2b304c Benjamin Gaignard 2021-05-17 1776 .data = &rv1126_vop },
671b538f2b304c Benjamin Gaignard 2021-05-17 1777 { .compatible = "rockchip,rk3288-vop-big",
671b538f2b304c Benjamin Gaignard 2021-05-17 1778 .data = &rk3288_vop_big },
671b538f2b304c Benjamin Gaignard 2021-05-17 1779 { .compatible = "rockchip,rk3288-vop-lit",
671b538f2b304c Benjamin Gaignard 2021-05-17 1780 .data = &rk3288_vop_lit },
eb5cb6aa9a72a7 Mark Yao 2017-07-26 1781 { .compatible = "rockchip,rk3368-vop",
eb5cb6aa9a72a7 Mark Yao 2017-07-26 1782 .data = &rk3368_vop },
eb5cb6aa9a72a7 Mark Yao 2017-07-26 1783 { .compatible = "rockchip,rk3366-vop",
eb5cb6aa9a72a7 Mark Yao 2017-07-26 1784 .data = &rk3366_vop },
0a63bfd046bbc8 Mark Yao 2016-04-20 1785 { .compatible = "rockchip,rk3399-vop-big",
0a63bfd046bbc8 Mark Yao 2016-04-20 1786 .data = &rk3399_vop_big },
0a63bfd046bbc8 Mark Yao 2016-04-20 1787 { .compatible = "rockchip,rk3399-vop-lit",
0a63bfd046bbc8 Mark Yao 2016-04-20 1788 .data = &rk3399_vop_lit },
eb5cb6aa9a72a7 Mark Yao 2017-07-26 1789 { .compatible = "rockchip,rk3228-vop",
eb5cb6aa9a72a7 Mark Yao 2017-07-26 1790 .data = &rk3228_vop },
eb5cb6aa9a72a7 Mark Yao 2017-07-26 1791 { .compatible = "rockchip,rk3328-vop",
eb5cb6aa9a72a7 Mark Yao 2017-07-26 1792 .data = &rk3328_vop },
a67719d182291b Mark Yao 2015-12-15 1793 {},
a67719d182291b Mark Yao 2015-12-15 1794 };
a67719d182291b Mark Yao 2015-12-15 1795 MODULE_DEVICE_TABLE(of, vop_driver_dt_match);
a67719d182291b Mark Yao 2015-12-15 1796
:::::: The code at line 1762 was first introduced by commit
:::::: a67719d182291bf62c6093545b9af27f0431cbeb drm/rockchip: vop: spilt register related into rockchip_reg_vop.c
:::::: TO: Mark Yao <mark.yao(a)rock-chips.com>
:::::: CC: Mark Yao <mark.yao(a)rock-chips.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[saeed:mlx5-queue 6/13] kernel/bpf/verifier.c:3552:11: error: implicit declaration of function 'bpf_ct_is_valid_access'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git mlx5-queue
head: 46fb2d6328c851496c3bcc5e50a1e58786c83acb
commit: 66d7b124a88b85fab8335567dd9c69450a9648dc [6/13] bpf: Expose struct nf_conn to BPF
config: riscv-randconfig-r006-20211017 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 746dd6a700931988dd9021d3d04718f1929885a5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git/commit/?i...
git remote add saeed https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git
git fetch --no-tags saeed mlx5-queue
git checkout 66d7b124a88b85fab8335567dd9c69450a9648dc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from kernel/bpf/verifier.c:12:
In file included from include/linux/bpf_verifier.h:9:
In file included from include/linux/filter.h:11:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:10:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/riscv/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/riscv/include/asm/io.h:136:
include/asm-generic/io.h:464:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __raw_readb(PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:477:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:36:51: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
^
In file included from kernel/bpf/verifier.c:12:
In file included from include/linux/bpf_verifier.h:9:
In file included from include/linux/filter.h:11:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:10:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/riscv/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/riscv/include/asm/io.h:136:
include/asm-generic/io.h:490:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:34:51: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
^
In file included from kernel/bpf/verifier.c:12:
In file included from include/linux/bpf_verifier.h:9:
In file included from include/linux/filter.h:11:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:10:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/riscv/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/riscv/include/asm/io.h:136:
include/asm-generic/io.h:501:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writeb(value, PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:511:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:521:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:1024:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
~~~~~~~~~~ ^
>> kernel/bpf/verifier.c:3552:11: error: implicit declaration of function 'bpf_ct_is_valid_access' [-Werror,-Wimplicit-function-declaration]
valid = bpf_ct_is_valid_access(off, size, t, &info);
^
kernel/bpf/verifier.c:3552:11: note: did you mean 'bpf_sock_is_valid_access'?
include/linux/bpf.h:2165:20: note: 'bpf_sock_is_valid_access' declared here
static inline bool bpf_sock_is_valid_access(int off, int size,
^
>> kernel/bpf/verifier.c:12388:25: error: use of undeclared identifier 'bpf_ct_convert_ctx_access'; did you mean 'bpf_sock_convert_ctx_access'?
convert_ctx_access = bpf_ct_convert_ctx_access;
^~~~~~~~~~~~~~~~~~~~~~~~~
bpf_sock_convert_ctx_access
include/linux/bpf.h:2171:19: note: 'bpf_sock_convert_ctx_access' declared here
static inline u32 bpf_sock_convert_ctx_access(enum bpf_access_type type,
^
7 warnings and 2 errors generated.
vim +/bpf_ct_is_valid_access +3552 kernel/bpf/verifier.c
3535
3536 static int check_ct_access(struct bpf_verifier_env *env, int insn_idx,
3537 u32 regno, int off, int size, enum bpf_access_type t)
3538 {
3539 struct bpf_reg_state *regs = cur_regs(env);
3540 struct bpf_reg_state *reg = ®s[regno];
3541 struct bpf_insn_access_aux info = {};
3542 bool valid;
3543
3544 if (reg->smin_value < 0) {
3545 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
3546 regno);
3547 return -EACCES;
3548 }
3549
3550 switch (reg->type) {
3551 case PTR_TO_NF_CONN:
> 3552 valid = bpf_ct_is_valid_access(off, size, t, &info);
3553 break;
3554 default:
3555 valid = false;
3556 }
3557
3558 if (valid) {
3559 env->insn_aux_data[insn_idx].ctx_field_size =
3560 info.ctx_field_size;
3561 return 0;
3562 }
3563
3564 verbose(env, "R%d invalid %s access off=%d size=%d\n",
3565 regno, reg_type_str[reg->type], off, size);
3566
3567 return -EACCES;
3568 }
3569
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[saeed:mlx5-queue 9/13] net/core/filter.c:7426:1: warning: unused label 'err_out'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git mlx5-queue
head: 46fb2d6328c851496c3bcc5e50a1e58786c83acb
commit: 1a0dafe601fbde2b5de8bfd64bfbdd0cd173d229 [9/13] bpf: Add a helper to issue timestamp cookies in XDP
config: i386-randconfig-a003-20211017 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 746dd6a700931988dd9021d3d04718f1929885a5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git/commit/?i...
git remote add saeed https://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git
git fetch --no-tags saeed mlx5-queue
git checkout 1a0dafe601fbde2b5de8bfd64bfbdd0cd173d229
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> net/core/filter.c:7426:1: warning: unused label 'err_out' [-Wunused-label]
err_out:
^~~~~~~~
1 warning generated.
vim +/err_out +7426 net/core/filter.c
7405
7406 BPF_CALL_4(bpf_tcp_raw_gen_tscookie, struct tcphdr *, th, u32, th_len,
7407 __be32 *, tsopt, u32, tsopt_len)
7408 {
7409 int err;
7410
7411 #ifdef CONFIG_SYN_COOKIES
7412 if (tsopt_len != sizeof(u64)) {
7413 err = -EINVAL;
7414 goto err_out;
7415 }
7416
7417 if (!cookie_init_timestamp_raw(th, &tsopt[0], &tsopt[1])) {
7418 err = -ENOENT;
7419 goto err_out;
7420 }
7421
7422 return 0;
7423 #else
7424 err = -EOPNOTSUPP;
7425 #endif
> 7426 err_out:
7427 memset(tsopt, 0, tsopt_len);
7428 return err;
7429 }
7430
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week