[skeggsb:03.00-disp 56/65] drivers/gpu/drm/nouveau/include/nvif/printf.h:10:25: error: format '%ld' expects argument of type 'long int', but argument 7 has type 'u32' {aka 'unsigned int'}
by kernel test robot
tree: https://github.com/skeggsb/linux 03.00-disp
head: 9d141f4c5d74118aa6e66daa9fde389857627d89
commit: ee9e44a497d467c04908c8329a305e8cd0e692e5 [56/65] drm/nouveau/nvkm: add a replacement for nvkm_notify
config: arc-buildonly-randconfig-r002-20211014 (attached as .config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/skeggsb/linux/commit/ee9e44a497d467c04908c8329a305e8cd...
git remote add skeggsb https://github.com/skeggsb/linux
git fetch --no-tags skeggsb 03.00-disp
git checkout ee9e44a497d467c04908c8329a305e8cd0e692e5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/nouveau/nvif/event.c:23:
drivers/gpu/drm/nouveau/nvif/event.c: In function 'nvif_event_ctor':
>> drivers/gpu/drm/nouveau/include/nvif/printf.h:10:25: error: format '%ld' expects argument of type 'long int', but argument 7 has type 'u32' {aka 'unsigned int'} [-Werror=format=]
10 | _p->func->l(_o, "[%s/%08x:%s] "f"\n", _o->client->object.name, _o->handle, _o->name, ##a); \
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/nouveau/include/nvif/printf.h:19:30: note: in expansion of macro 'NVIF_PRINT'
19 | #define NVIF_ERROR(o,f,a...) NVIF_PRINT(errorf, (o), f, ##a)
| ^~~~~~~~~~
drivers/gpu/drm/nouveau/include/nvif/printf.h:24:17: note: in expansion of macro 'NVIF_ERROR'
24 | NVIF_ERROR(_object, f" (ret:%d)", ##a, _cond); \
| ^~~~~~~~~~
drivers/gpu/drm/nouveau/nvif/event.c:73:9: note: in expansion of macro 'NVIF_ERRON'
73 | NVIF_ERRON(ret, parent, "[NEW EVENT wait:%d size:%ld]", args->wait, argc - sizeof(*args));
| ^~~~~~~~~~
>> drivers/gpu/drm/nouveau/include/nvif/printf.h:10:25: error: format '%ld' expects argument of type 'long int', but argument 7 has type 'u32' {aka 'unsigned int'} [-Werror=format=]
10 | _p->func->l(_o, "[%s/%08x:%s] "f"\n", _o->client->object.name, _o->handle, _o->name, ##a); \
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/nouveau/include/nvif/printf.h:14:30: note: in expansion of macro 'NVIF_PRINT'
14 | #define NVIF_DEBUG(o,f,a...) NVIF_PRINT(debugf, (o), f, ##a)
| ^~~~~~~~~~
drivers/gpu/drm/nouveau/include/nvif/printf.h:26:17: note: in expansion of macro 'NVIF_DEBUG'
26 | NVIF_DEBUG(_object, f, ##a); \
| ^~~~~~~~~~
drivers/gpu/drm/nouveau/nvif/event.c:73:9: note: in expansion of macro 'NVIF_ERRON'
73 | NVIF_ERRON(ret, parent, "[NEW EVENT wait:%d size:%ld]", args->wait, argc - sizeof(*args));
| ^~~~~~~~~~
cc1: all warnings being treated as errors
vim +10 drivers/gpu/drm/nouveau/include/nvif/printf.h
3e176fd0600439 Ben Skeggs 2020-06-29 6
3e176fd0600439 Ben Skeggs 2020-06-29 7 #define NVIF_PRINT(l,o,f,a...) do { \
3e176fd0600439 Ben Skeggs 2020-06-29 8 struct nvif_object *_o = (o); \
3e176fd0600439 Ben Skeggs 2020-06-29 9 struct nvif_parent *_p = _o->parent; \
3e176fd0600439 Ben Skeggs 2020-06-29 @10 _p->func->l(_o, "[%s/%08x:%s] "f"\n", _o->client->object.name, _o->handle, _o->name, ##a); \
3e176fd0600439 Ben Skeggs 2020-06-29 11 } while(0)
3e176fd0600439 Ben Skeggs 2020-06-29 12
:::::: The code at line 10 was first introduced by commit
:::::: 3e176fd0600439a8a1e0b3e95e2f0545660ab59c drm/nouveau/nvif: add support for object-level debug output
:::::: TO: Ben Skeggs <bskeggs(a)redhat.com>
:::::: CC: Ben Skeggs <bskeggs(a)redhat.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[hch-misc:dax-block-cleanup 3/3] readahead.c:(.text+0x8a0): multiple definition of `dax_remove_host'; mm/filemap.o:filemap.c:(.text+0x47f0): first defined here
by kernel test robot
tree: git://git.infradead.org/users/hch/misc.git dax-block-cleanup
head: f95e4c72e7784a68edcdb95f4211b9636880ff29
commit: f95e4c72e7784a68edcdb95f4211b9636880ff29 [3/3] dax: rework the dax_device <-> gendisk association
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add hch-misc git://git.infradead.org/users/hch/misc.git
git fetch --no-tags hch-misc dax-block-cleanup
git checkout f95e4c72e7784a68edcdb95f4211b9636880ff29
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=um SUBARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
ld: mm/readahead.o: in function `dax_remove_host':
>> readahead.c:(.text+0x8a0): multiple definition of `dax_remove_host'; mm/filemap.o:filemap.c:(.text+0x47f0): first defined here
ld: mm/truncate.o: in function `dax_remove_host':
truncate.c:(.text+0x1210): multiple definition of `dax_remove_host'; mm/filemap.o:filemap.c:(.text+0x47f0): first defined here
ld: mm/vmscan.o: in function `dax_remove_host':
vmscan.c:(.text+0x24c0): multiple definition of `dax_remove_host'; mm/filemap.o:filemap.c:(.text+0x47f0): first defined here
ld: mm/workingset.o: in function `dax_remove_host':
workingset.c:(.text+0x3a0): multiple definition of `dax_remove_host'; mm/filemap.o:filemap.c:(.text+0x47f0): first defined here
ld: mm/memory.o: in function `dax_remove_host':
memory.c:(.text+0xc70): multiple definition of `dax_remove_host'; mm/filemap.o:filemap.c:(.text+0x47f0): first defined here
ld: fs/binfmt_elf.o: in function `dax_remove_host':
binfmt_elf.c:(.text+0x3160): multiple definition of `dax_remove_host'; mm/filemap.o:filemap.c:(.text+0x47f0): first defined here
ld: fs/iomap/buffered-io.o: in function `dax_remove_host':
buffered-io.c:(.text+0x3720): multiple definition of `dax_remove_host'; mm/filemap.o:filemap.c:(.text+0x47f0): first defined here
ld: fs/ext4/file.o: in function `dax_remove_host':
file.c:(.text+0x1600): multiple definition of `dax_remove_host'; mm/filemap.o:filemap.c:(.text+0x47f0): first defined here
ld: fs/ext4/indirect.o: in function `dax_remove_host':
indirect.c:(.text+0xd20): multiple definition of `dax_remove_host'; mm/filemap.o:filemap.c:(.text+0x47f0): first defined here
ld: fs/ext4/inode.o: in function `dax_remove_host':
inode.c:(.text+0x1ed0): multiple definition of `dax_remove_host'; mm/filemap.o:filemap.c:(.text+0x47f0): first defined here
ld: fs/ext4/super.o: in function `dax_remove_host':
super.c:(.text+0x2680): multiple definition of `dax_remove_host'; mm/filemap.o:filemap.c:(.text+0x47f0): first defined here
--
In file included from mm/filemap.c:15:
>> include/linux/dax.h:133:67: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
133 | static inline int dax_add_host(struct dax_device *dax_dev, struct gendisk *disk)
| ^~~~~~~
include/linux/dax.h:137:29: warning: 'struct gendisk' declared inside parameter list will not be visible outside of this definition or declaration
137 | void dax_remove_host(struct gendisk *disk)
| ^~~~~~~
>> include/linux/dax.h:137:6: warning: no previous prototype for 'dax_remove_host' [-Wmissing-prototypes]
137 | void dax_remove_host(struct gendisk *disk)
| ^~~~~~~~~~~~~~~
--
In file included from mm/truncate.c:13:
>> include/linux/dax.h:137:6: warning: no previous prototype for 'dax_remove_host' [-Wmissing-prototypes]
137 | void dax_remove_host(struct gendisk *disk)
| ^~~~~~~~~~~~~~~
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
Re: [PATCH net-next 1/2] of: net: move nvmem_get_mac_address() into of_get_mac_addr_nvmem()
by kernel test robot
Hi Yajun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Yajun-Deng/of-net-move-nvmem_get...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d1f24712a86abd04d82cf4b00fb4ab8ff2d23c8a
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/10748c5429eced2d22c6cf10e8dcdef8a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yajun-Deng/of-net-move-nvmem_get_mac_address-into-of_get_mac_addr_nvmem/20211013-162802
git checkout 10748c5429eced2d22c6cf10e8dcdef8a1a5c38d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
net/core/of_net.c: In function 'of_get_mac_addr_nvmem':
>> net/core/of_net.c:66:13: error: unused variable 'ret' [-Werror=unused-variable]
66 | int ret;
| ^~~
cc1: all warnings being treated as errors
vim +/ret +66 net/core/of_net.c
3eb46a1da78dff drivers/of/of_net.c Sergei Shtylyov 2015-03-18 59
83216e3988cd19 drivers/of/of_net.c Michael Walle 2021-04-12 60 static int of_get_mac_addr_nvmem(struct device_node *np, u8 *addr)
d01f449c008a3f drivers/of/of_net.c Petr Štetiar 2019-05-03 61 {
d01f449c008a3f drivers/of/of_net.c Petr Štetiar 2019-05-03 62 struct platform_device *pdev = of_find_device_by_node(np);
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 63 struct nvmem_cell *cell;
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 64 const void *mac;
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 65 size_t len;
83216e3988cd19 drivers/of/of_net.c Michael Walle 2021-04-12 @66 int ret;
d01f449c008a3f drivers/of/of_net.c Petr Štetiar 2019-05-03 67
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 68 /* Try lookup by device first, there might be a nvmem_cell_lookup
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 69 * associated with a given device.
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 70 */
10748c5429eced net/core/of_net.c Yajun Deng 2021-10-13 71 if (pdev)
10748c5429eced net/core/of_net.c Yajun Deng 2021-10-13 72 cell = nvmem_cell_get(&pdev->dev, "mac-address");
10748c5429eced net/core/of_net.c Yajun Deng 2021-10-13 73 else
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 74 cell = of_nvmem_cell_get(np, "mac-address");
10748c5429eced net/core/of_net.c Yajun Deng 2021-10-13 75
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 76 if (IS_ERR(cell))
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 77 return PTR_ERR(cell);
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 78
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 79 mac = nvmem_cell_read(cell, &len);
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 80 nvmem_cell_put(cell);
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 81
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 82 if (IS_ERR(mac))
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 83 return PTR_ERR(mac);
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 84
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 85 if (len != ETH_ALEN || !is_valid_ether_addr(mac)) {
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 86 kfree(mac);
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 87 return -EINVAL;
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 88 }
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 89
10748c5429eced net/core/of_net.c Yajun Deng 2021-10-13 90 ether_addr_copy(addr, mac);
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 91 kfree(mac);
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 92
10748c5429eced net/core/of_net.c Yajun Deng 2021-10-13 93 if (pdev)
10748c5429eced net/core/of_net.c Yajun Deng 2021-10-13 94 put_device(&pdev->dev);
10748c5429eced net/core/of_net.c Yajun Deng 2021-10-13 95
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 96 return 0;
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 97 }
f10843e04a0752 drivers/of/of_net.c Michael Walle 2021-04-12 98
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
block/partitions/ldm.c:134:9: warning: 'strncpy' specified bound 16 equals destination size
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ec681c53f8d2d0ee362ff67f5b98dd8263c15002
commit: 334ef6ed06fa1a54e35296b77b693bcf6d63ee9e init/Kconfig: make COMPILE_TEST depend on !S390
date: 11 months ago
config: s390-randconfig-r044-20211015 (attached as .config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 334ef6ed06fa1a54e35296b77b693bcf6d63ee9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In function 'ldm_parse_tocblock',
inlined from 'ldm_validate_tocblocks' at block/partitions/ldm.c:386:7:
>> block/partitions/ldm.c:134:9: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation]
134 | strncpy (toc->bitmap1_name, data + 0x24, sizeof (toc->bitmap1_name));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
block/partitions/ldm.c:145:9: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation]
145 | strncpy (toc->bitmap2_name, data + 0x46, sizeof (toc->bitmap2_name));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
kernel/trace/blktrace.c: In function '__trace_note_message':
kernel/trace/blktrace.c:148:63: warning: parameter 'blkcg' set but not used [-Wunused-but-set-parameter]
148 | void __trace_note_message(struct blk_trace *bt, struct blkcg *blkcg,
| ~~~~~~~~~~~~~~^~~~~
kernel/trace/blktrace.c: In function 'do_blk_trace_setup':
>> kernel/trace/blktrace.c:491:9: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
491 | strncpy(buts->name, name, BLKTRACE_BDEV_SIZE);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/strncpy +134 block/partitions/ldm.c
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 111
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 112 /**
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 113 * ldm_parse_tocblock - Read the LDM Database TOCBLOCK structure
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 114 * @data: Raw database TOCBLOCK structure loaded from the device
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 115 * @toc: In-memory toc structure in which to return parsed information
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 116 *
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 117 * This parses the LDM Database TOCBLOCK (table of contents) structure supplied
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 118 * in @data and sets up the in-memory tocblock structure @toc with the obtained
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 119 * information.
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 120 *
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 121 * N.B. The *_start and *_size values returned in @toc are not range-checked.
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 122 *
130c6b98984a05 fs/partitions/ldm.c Richard Knutsson 2006-09-30 123 * Return: 'true' @toc contains the TOCBLOCK data
130c6b98984a05 fs/partitions/ldm.c Richard Knutsson 2006-09-30 124 * 'false' @toc contents are undefined
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 125 */
130c6b98984a05 fs/partitions/ldm.c Richard Knutsson 2006-09-30 126 static bool ldm_parse_tocblock (const u8 *data, struct tocblock *toc)
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 127 {
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 128 BUG_ON (!data || !toc);
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 129
b7bbf8fa6ba329 fs/partitions/ldm.c Harvey Harrison 2008-07-25 130 if (MAGIC_TOCBLOCK != get_unaligned_be64(data)) {
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 131 ldm_crit ("Cannot find TOCBLOCK, database may be corrupt.");
130c6b98984a05 fs/partitions/ldm.c Richard Knutsson 2006-09-30 132 return false;
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 133 }
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 @134 strncpy (toc->bitmap1_name, data + 0x24, sizeof (toc->bitmap1_name));
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 135 toc->bitmap1_name[sizeof (toc->bitmap1_name) - 1] = 0;
b7bbf8fa6ba329 fs/partitions/ldm.c Harvey Harrison 2008-07-25 136 toc->bitmap1_start = get_unaligned_be64(data + 0x2E);
b7bbf8fa6ba329 fs/partitions/ldm.c Harvey Harrison 2008-07-25 137 toc->bitmap1_size = get_unaligned_be64(data + 0x36);
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 138
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 139 if (strncmp (toc->bitmap1_name, TOC_BITMAP1,
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 140 sizeof (toc->bitmap1_name)) != 0) {
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 141 ldm_crit ("TOCBLOCK's first bitmap is '%s', should be '%s'.",
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 142 TOC_BITMAP1, toc->bitmap1_name);
130c6b98984a05 fs/partitions/ldm.c Richard Knutsson 2006-09-30 143 return false;
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 144 }
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 145 strncpy (toc->bitmap2_name, data + 0x46, sizeof (toc->bitmap2_name));
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 146 toc->bitmap2_name[sizeof (toc->bitmap2_name) - 1] = 0;
b7bbf8fa6ba329 fs/partitions/ldm.c Harvey Harrison 2008-07-25 147 toc->bitmap2_start = get_unaligned_be64(data + 0x50);
b7bbf8fa6ba329 fs/partitions/ldm.c Harvey Harrison 2008-07-25 148 toc->bitmap2_size = get_unaligned_be64(data + 0x58);
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 149 if (strncmp (toc->bitmap2_name, TOC_BITMAP2,
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 150 sizeof (toc->bitmap2_name)) != 0) {
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 151 ldm_crit ("TOCBLOCK's second bitmap is '%s', should be '%s'.",
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 152 TOC_BITMAP2, toc->bitmap2_name);
130c6b98984a05 fs/partitions/ldm.c Richard Knutsson 2006-09-30 153 return false;
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 154 }
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 155 ldm_debug ("Parsed TOCBLOCK successfully.");
130c6b98984a05 fs/partitions/ldm.c Richard Knutsson 2006-09-30 156 return true;
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 157 }
^1da177e4c3f41 fs/partitions/ldm.c Linus Torvalds 2005-04-16 158
:::::: The code at line 134 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds(a)ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds(a)ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
Re: [PATCH] media: imx258: add vblank control to support wide frame rate range
by kernel test robot
Hi Bingbu,
I love your patch! Yet something to improve:
[auto build test ERROR on media-tree/master]
[also build test ERROR on v5.15-rc5 next-20211013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Bingbu-Cao/media-imx258-add-vbla...
base: git://linuxtv.org/media_tree.git master
config: alpha-randconfig-r014-20211014 (attached as .config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8775f7beb99fa27ed3d3f64b289d97279...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bingbu-Cao/media-imx258-add-vblank-control-to-support-wide-frame-rate-range/20211015-150254
git checkout 8775f7beb99fa27ed3d3f64b289d9727963ca0c3
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/media/i2c/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/media/i2c/imx258.c: In function 'imx258_set_ctrl':
>> drivers/media/i2c/imx258.c:766:17: error: break statement not within loop or switch
766 | break;
| ^~~~~
vim +766 drivers/media/i2c/imx258.c
751
752 static int imx258_set_ctrl(struct v4l2_ctrl *ctrl)
753 {
754 struct imx258 *imx258 =
755 container_of(ctrl->handler, struct imx258, ctrl_handler);
756 struct i2c_client *client = v4l2_get_subdevdata(&imx258->sd);
757 s64 max;
758 int ret = 0;
759
760 if (ctrl->id == V4L2_CID_VBLANK) {
761 /* Update max exposure to meet expected vblanking */
762 max = imx258->cur_mode->height + ctrl->val - 10;
763 __v4l2_ctrl_modify_range(imx258->exposure,
764 imx258->exposure->minimum,
765 max, imx258->exposure->step, max);
> 766 break;
767 }
768
769 /*
770 * Applying V4L2 control value only happens
771 * when power is up for streaming
772 */
773 if (pm_runtime_get_if_in_use(&client->dev) == 0)
774 return 0;
775
776 switch (ctrl->id) {
777 case V4L2_CID_ANALOGUE_GAIN:
778 ret = imx258_write_reg(imx258, IMX258_REG_ANALOG_GAIN,
779 IMX258_REG_VALUE_16BIT,
780 ctrl->val);
781 break;
782 case V4L2_CID_EXPOSURE:
783 ret = imx258_write_reg(imx258, IMX258_REG_EXPOSURE,
784 IMX258_REG_VALUE_16BIT,
785 ctrl->val);
786 break;
787 case V4L2_CID_VBLANK:
788 ret = imx258_write_reg(imx258, IMX258_REG_FLL, 2,
789 imx258->cur_mode->height + ctrl->val);
790 break;
791 case V4L2_CID_DIGITAL_GAIN:
792 ret = imx258_update_digital_gain(imx258, IMX258_REG_VALUE_16BIT,
793 ctrl->val);
794 break;
795 case V4L2_CID_TEST_PATTERN:
796 ret = imx258_write_reg(imx258, IMX258_REG_TEST_PATTERN,
797 IMX258_REG_VALUE_16BIT,
798 ctrl->val);
799 ret = imx258_write_reg(imx258, REG_MIRROR_FLIP_CONTROL,
800 IMX258_REG_VALUE_08BIT,
801 !ctrl->val ? REG_CONFIG_MIRROR_FLIP :
802 REG_CONFIG_FLIP_TEST_PATTERN);
803 break;
804 case V4L2_CID_WIDE_DYNAMIC_RANGE:
805 if (!ctrl->val) {
806 ret = imx258_write_reg(imx258, IMX258_REG_HDR,
807 IMX258_REG_VALUE_08BIT,
808 IMX258_HDR_RATIO_MIN);
809 } else {
810 ret = imx258_write_reg(imx258, IMX258_REG_HDR,
811 IMX258_REG_VALUE_08BIT,
812 IMX258_HDR_ON);
813 if (ret)
814 break;
815 ret = imx258_write_reg(imx258, IMX258_REG_HDR_RATIO,
816 IMX258_REG_VALUE_08BIT,
817 BIT(IMX258_HDR_RATIO_MAX));
818 }
819 break;
820 default:
821 dev_info(&client->dev,
822 "ctrl(id:0x%x,val:0x%x) is not handled\n",
823 ctrl->id, ctrl->val);
824 ret = -EINVAL;
825 break;
826 }
827
828 pm_runtime_put(&client->dev);
829
830 return ret;
831 }
832
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[shawnguo:imx/drivers 11/12] drivers/soc/imx/imx8m-blk-ctrl.c:460:3: error: use of undeclared identifier 'IMX8MM_DISPBLK_PD_CSI_BRIDGE'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git imx/drivers
head: 72949f76565c9ea9f4231c977774a31d4713c386
commit: 926e57c065dfcf5a824b206760330f32e786dd8c [11/12] soc: imx: imx8m-blk-ctrl: add DISP blk-ctrl
config: hexagon-randconfig-r045-20211014 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project acb3b187c4c88650a6a717a1bcb234d27d0d7f54)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit...
git remote add shawnguo https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
git fetch --no-tags shawnguo imx/drivers
git checkout 926e57c065dfcf5a824b206760330f32e786dd8c
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/soc/imx/imx8m-blk-ctrl.c:401:3: error: use of undeclared identifier 'IMX8MM_VPUBLK_PD_G1'
[IMX8MM_VPUBLK_PD_G1] = {
^
drivers/soc/imx/imx8m-blk-ctrl.c:409:3: error: use of undeclared identifier 'IMX8MM_VPUBLK_PD_G2'
[IMX8MM_VPUBLK_PD_G2] = {
^
drivers/soc/imx/imx8m-blk-ctrl.c:417:3: error: use of undeclared identifier 'IMX8MM_VPUBLK_PD_H1'
[IMX8MM_VPUBLK_PD_H1] = {
^
drivers/soc/imx/imx8m-blk-ctrl.c:431:17: error: invalid application of 'sizeof' to an incomplete type 'const struct imx8m_blk_ctrl_domain_data []'
.num_domains = ARRAY_SIZE(imx8mm_vpu_blk_ctl_domain_data),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:44:32: note: expanded from macro 'ARRAY_SIZE'
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
^~~~~
>> drivers/soc/imx/imx8m-blk-ctrl.c:460:3: error: use of undeclared identifier 'IMX8MM_DISPBLK_PD_CSI_BRIDGE'
[IMX8MM_DISPBLK_PD_CSI_BRIDGE] = {
^
>> drivers/soc/imx/imx8m-blk-ctrl.c:469:3: error: use of undeclared identifier 'IMX8MM_DISPBLK_PD_LCDIF'
[IMX8MM_DISPBLK_PD_LCDIF] = {
^
>> drivers/soc/imx/imx8m-blk-ctrl.c:476:3: error: use of undeclared identifier 'IMX8MM_DISPBLK_PD_MIPI_DSI'
[IMX8MM_DISPBLK_PD_MIPI_DSI] = {
^
>> drivers/soc/imx/imx8m-blk-ctrl.c:484:3: error: use of undeclared identifier 'IMX8MM_DISPBLK_PD_MIPI_CSI'
[IMX8MM_DISPBLK_PD_MIPI_CSI] = {
^
drivers/soc/imx/imx8m-blk-ctrl.c:498:17: error: invalid application of 'sizeof' to an incomplete type 'const struct imx8m_blk_ctrl_domain_data []'
.num_domains = ARRAY_SIZE(imx8mm_disp_blk_ctl_domain_data),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:44:32: note: expanded from macro 'ARRAY_SIZE'
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
^~~~~
9 errors generated.
vim +/IMX8MM_DISPBLK_PD_CSI_BRIDGE +460 drivers/soc/imx/imx8m-blk-ctrl.c
458
459 static const struct imx8m_blk_ctrl_domain_data imx8mm_disp_blk_ctl_domain_data[] = {
> 460 [IMX8MM_DISPBLK_PD_CSI_BRIDGE] = {
461 .name = "dispblk-csi-bridge",
462 .clk_names = (const char *[]){ "csi-bridge-axi", "csi-bridge-apb",
463 "csi-bridge-core", },
464 .num_clks = 3,
465 .gpc_name = "csi-bridge",
466 .rst_mask = BIT(0) | BIT(1) | BIT(2),
467 .clk_mask = BIT(0) | BIT(1) | BIT(2) | BIT(3) | BIT(4) | BIT(5),
468 },
> 469 [IMX8MM_DISPBLK_PD_LCDIF] = {
470 .name = "dispblk-lcdif",
471 .clk_names = (const char *[]){ "lcdif-axi", "lcdif-apb", "lcdif-pix", },
472 .num_clks = 3,
473 .gpc_name = "lcdif",
474 .clk_mask = BIT(6) | BIT(7),
475 },
> 476 [IMX8MM_DISPBLK_PD_MIPI_DSI] = {
477 .name = "dispblk-mipi-dsi",
478 .clk_names = (const char *[]){ "dsi-pclk", "dsi-ref", },
479 .num_clks = 2,
480 .gpc_name = "mipi-dsi",
481 .rst_mask = BIT(5),
482 .clk_mask = BIT(8) | BIT(9),
483 },
> 484 [IMX8MM_DISPBLK_PD_MIPI_CSI] = {
485 .name = "dispblk-mipi-csi",
486 .clk_names = (const char *[]){ "csi-aclk", "csi-pclk" },
487 .num_clks = 2,
488 .gpc_name = "mipi-csi",
489 .rst_mask = BIT(3) | BIT(4),
490 .clk_mask = BIT(10) | BIT(11),
491 },
492 };
493
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
Re: [PATCH] media: imx258: add vblank control to support wide frame rate range
by kernel test robot
Hi Bingbu,
I love your patch! Yet something to improve:
[auto build test ERROR on media-tree/master]
[also build test ERROR on v5.15-rc5 next-20211013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Bingbu-Cao/media-imx258-add-vbla...
base: git://linuxtv.org/media_tree.git master
config: riscv-randconfig-r042-20211014 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project acb3b187c4c88650a6a717a1bcb234d27d0d7f54)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/8775f7beb99fa27ed3d3f64b289d97279...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bingbu-Cao/media-imx258-add-vblank-control-to-support-wide-frame-rate-range/20211015-150254
git checkout 8775f7beb99fa27ed3d3f64b289d9727963ca0c3
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/media/i2c/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/media/i2c/imx258.c:766:3: error: 'break' statement not in loop or switch statement
break;
^
1 error generated.
vim +/break +766 drivers/media/i2c/imx258.c
751
752 static int imx258_set_ctrl(struct v4l2_ctrl *ctrl)
753 {
754 struct imx258 *imx258 =
755 container_of(ctrl->handler, struct imx258, ctrl_handler);
756 struct i2c_client *client = v4l2_get_subdevdata(&imx258->sd);
757 s64 max;
758 int ret = 0;
759
760 if (ctrl->id == V4L2_CID_VBLANK) {
761 /* Update max exposure to meet expected vblanking */
762 max = imx258->cur_mode->height + ctrl->val - 10;
763 __v4l2_ctrl_modify_range(imx258->exposure,
764 imx258->exposure->minimum,
765 max, imx258->exposure->step, max);
> 766 break;
767 }
768
769 /*
770 * Applying V4L2 control value only happens
771 * when power is up for streaming
772 */
773 if (pm_runtime_get_if_in_use(&client->dev) == 0)
774 return 0;
775
776 switch (ctrl->id) {
777 case V4L2_CID_ANALOGUE_GAIN:
778 ret = imx258_write_reg(imx258, IMX258_REG_ANALOG_GAIN,
779 IMX258_REG_VALUE_16BIT,
780 ctrl->val);
781 break;
782 case V4L2_CID_EXPOSURE:
783 ret = imx258_write_reg(imx258, IMX258_REG_EXPOSURE,
784 IMX258_REG_VALUE_16BIT,
785 ctrl->val);
786 break;
787 case V4L2_CID_VBLANK:
788 ret = imx258_write_reg(imx258, IMX258_REG_FLL, 2,
789 imx258->cur_mode->height + ctrl->val);
790 break;
791 case V4L2_CID_DIGITAL_GAIN:
792 ret = imx258_update_digital_gain(imx258, IMX258_REG_VALUE_16BIT,
793 ctrl->val);
794 break;
795 case V4L2_CID_TEST_PATTERN:
796 ret = imx258_write_reg(imx258, IMX258_REG_TEST_PATTERN,
797 IMX258_REG_VALUE_16BIT,
798 ctrl->val);
799 ret = imx258_write_reg(imx258, REG_MIRROR_FLIP_CONTROL,
800 IMX258_REG_VALUE_08BIT,
801 !ctrl->val ? REG_CONFIG_MIRROR_FLIP :
802 REG_CONFIG_FLIP_TEST_PATTERN);
803 break;
804 case V4L2_CID_WIDE_DYNAMIC_RANGE:
805 if (!ctrl->val) {
806 ret = imx258_write_reg(imx258, IMX258_REG_HDR,
807 IMX258_REG_VALUE_08BIT,
808 IMX258_HDR_RATIO_MIN);
809 } else {
810 ret = imx258_write_reg(imx258, IMX258_REG_HDR,
811 IMX258_REG_VALUE_08BIT,
812 IMX258_HDR_ON);
813 if (ret)
814 break;
815 ret = imx258_write_reg(imx258, IMX258_REG_HDR_RATIO,
816 IMX258_REG_VALUE_08BIT,
817 BIT(IMX258_HDR_RATIO_MAX));
818 }
819 break;
820 default:
821 dev_info(&client->dev,
822 "ctrl(id:0x%x,val:0x%x) is not handled\n",
823 ctrl->id, ctrl->val);
824 ret = -EINVAL;
825 break;
826 }
827
828 pm_runtime_put(&client->dev);
829
830 return ret;
831 }
832
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
