Re: [PATCH v7 18/21] auxdisplay: ht16k33: Add support for segment displays
by Dan Carpenter
Hi Geert,
url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/auxdisplay-ht...
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: i386-randconfig-m031-20211012 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
include/uapi/linux/map_to_14segment.h:87 map_to_seg14() error: buffer overflow 'map->table' 128 <= 255
include/uapi/linux/map_to_14segment.h:87 map_to_seg14() error: buffer overflow 'map->table' 128 <= 255
include/uapi/linux/map_to_14segment.h:87 map_to_seg14() error: buffer overflow 'map->table' 128 <= 255
vim +87 include/uapi/linux/map_to_14segment.h
d26423994040a7 Geert Uytterhoeven 2021-10-12 85 static __inline__ int map_to_seg14(struct seg14_conversion_map *map, int c)
d26423994040a7 Geert Uytterhoeven 2021-10-12 86 {
d26423994040a7 Geert Uytterhoeven 2021-10-12 @87 return c >= 0 && c < sizeof(map->table) ? __be16_to_cpu(map->table[c])
^^^^^^^^^^^^^^^^^^^^^^
This needs to be c < ARRAY_SIZE(map->table) instead of sizeof().
d26423994040a7 Geert Uytterhoeven 2021-10-12 88 : -EINVAL;
d26423994040a7 Geert Uytterhoeven 2021-10-12 89 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[dhowells-fs:fscache-rewrite-indexing 72/75] fs/9p/vfs_addr.c:365: undefined reference to `fscache_set_page_dirty'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git fscache-rewrite-indexing
head: 96d4e1af98c26988d3c1b3cf688974c24de90fa9
commit: cf8fa20c911971b0aba604031f1cd488d3a5583b [72/75] 9p: Copy local writes to the cache when writing to the server
config: i386-debian-10.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/com...
git remote add dhowells-fs https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git fetch --no-tags dhowells-fs fscache-rewrite-indexing
git checkout cf8fa20c911971b0aba604031f1cd488d3a5583b
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
ld: fs/9p/vfs_super.o: in function `fscache_unuse_cookie':
include/linux/fscache.h:286: undefined reference to `__fscache_unuse_cookie'
ld: include/linux/fscache.h:286: undefined reference to `__fscache_unuse_cookie'
ld: fs/9p/vfs_inode.o: in function `fscache_resize_cookie':
include/linux/fscache.h:386: undefined reference to `__fscache_resize_cookie'
ld: fs/9p/vfs_inode.o: in function `fscache_unuse_cookie':
include/linux/fscache.h:286: undefined reference to `__fscache_unuse_cookie'
ld: fs/9p/vfs_inode.o: in function `fscache_relinquish_cookie':
include/linux/fscache.h:305: undefined reference to `__fscache_relinquish_cookie'
ld: fs/9p/vfs_inode.o: in function `fscache_use_cookie':
include/linux/fscache.h:269: undefined reference to `__fscache_use_cookie'
ld: fs/9p/vfs_inode_dotl.o: in function `fscache_use_cookie':
include/linux/fscache.h:269: undefined reference to `__fscache_use_cookie'
ld: fs/9p/vfs_addr.o: in function `fscache_write_to_cache':
include/linux/fscache.h:596: undefined reference to `__fscache_write_to_cache'
ld: fs/9p/vfs_addr.o: in function `fscache_begin_read_operation':
include/linux/fscache.h:483: undefined reference to `__fscache_begin_read_operation'
ld: fs/9p/vfs_addr.o: in function `v9fs_set_page_dirty':
>> fs/9p/vfs_addr.c:365: undefined reference to `fscache_set_page_dirty'
ld: fs/9p/vfs_addr.o: in function `fscache_invalidate':
>> include/linux/fscache.h:444: undefined reference to `__fscache_invalidate'
ld: fs/9p/vfs_addr.o: in function `arch_atomic_inc':
>> arch/x86/include/asm/atomic.h:95: undefined reference to `fscache_n_updates'
ld: fs/9p/vfs_file.o: in function `fscache_use_cookie':
include/linux/fscache.h:269: undefined reference to `__fscache_use_cookie'
ld: fs/9p/vfs_dir.o: in function `fscache_unuse_cookie':
include/linux/fscache.h:286: undefined reference to `__fscache_unuse_cookie'
ld: include/linux/fscache.h:286: undefined reference to `__fscache_unuse_cookie'
ld: fs/9p/v9fs.o: in function `fscache_relinquish_volume':
include/linux/fscache.h:221: undefined reference to `__fscache_relinquish_volume'
ld: fs/9p/cache.o: in function `fscache_acquire_volume':
include/linux/fscache.h:202: undefined reference to `__fscache_acquire_volume'
ld: fs/9p/cache.o: in function `fscache_acquire_cookie':
include/linux/fscache.h:250: undefined reference to `__fscache_acquire_cookie'
vim +365 fs/9p/vfs_addr.c
355
356 #ifdef CONFIG_9P_FSCACHE
357 /*
358 * Mark a page as having been made dirty and thus needing writeback. We also
359 * need to pin the cache object to write back to.
360 */
361 static int v9fs_set_page_dirty(struct page *page)
362 {
363 struct v9fs_inode *v9inode = V9FS_I(page->mapping->host);
364
> 365 return fscache_set_page_dirty(page, v9fs_inode_cookie(v9inode));
366 }
367 #else
368 #define v9fs_set_page_dirty __set_page_dirty_nobuffers
369 #endif
370
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[tglx-devel:x86/fpu 74/82] arch/x86/kernel/fpu/xstate.c:1314:14: warning: comparison between pointer and integer
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git x86/fpu
head: fbeb78415a1b32f890fa49e4355faa02bb0c0602
commit: 14b0c6c4efcd1654d291d501cca977f3476a5c10 [74/82] x86/fpu: Add sanity checks for XFD
config: x86_64-randconfig-a006-20211014 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/commit/?id...
git remote add tglx-devel https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git
git fetch --no-tags tglx-devel x86/fpu
git checkout 14b0c6c4efcd1654d291d501cca977f3476a5c10
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/kernel/fpu/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
arch/x86/kernel/fpu/xstate.c: In function 'xfd_valid':
>> arch/x86/kernel/fpu/xstate.c:1314:14: warning: comparison between pointer and integer
1314 | if (fpstate == current->thread.fpu.fpstate->xfd)
| ^~
vim +1314 arch/x86/kernel/fpu/xstate.c
1304
1305 #ifdef CONFIG_X86_DEBUG_FPU
1306 static inline bool xfd_valid(struct fpstate *fpstate, u64 mask, bool rstor)
1307 {
1308 u64 xfd = __this_cpu_read(xfd_state);
1309
1310 if (fpstate->xfd == xfd)
1311 return true;
1312
1313 /* For current's fpstate the XFD state must be correct. */
> 1314 if (fpstate == current->thread.fpu.fpstate->xfd)
1315 return false;
1316
1317 /*
1318 * XRSTOR(S) from init_fpstate are always correct as it will just
1319 * bring all components into init state and not read from the
1320 * buffer. XSAVE(S) raises #PF after init.
1321 */
1322 if (fpstate == &init_fpstate)
1323 return rstor;
1324
1325 /*
1326 * XSAVE(S): clone(), fpu_swap_kvm_fpu()
1327 * XRSTORS(S): fpu_swap_kvm_fpu()
1328 */
1329
1330 /* Remove XFD disabled states from the mask. */
1331 mask &= ~xfd;
1332 /* Remove features which are valid in fpstate. */
1333 mask &= ~fpstate->xfeatures;
1334
1335 /*
1336 * Mask should be zero now which means no loads/stores
1337 * past the end of the register state buffer.
1338 */
1339 return !mask;
1340 }
1341
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[skeggsb:03.00-disp 48/65] drivers/gpu/drm/nouveau/nouveau_display.c:755:29: error: unused variable 'drm'
by kernel test robot
tree: https://github.com/skeggsb/linux 03.00-disp
head: 9d141f4c5d74118aa6e66daa9fde389857627d89
commit: 9ab6dbfd169dd7c2329b2d8aeee09926c49d3280 [48/65] drm/nouveau/kms: switch hpd_lock from mutex to spinlock
config: arc-buildonly-randconfig-r002-20211014 (attached as .config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/skeggsb/linux/commit/9ab6dbfd169dd7c2329b2d8aeee09926c...
git remote add skeggsb https://github.com/skeggsb/linux
git fetch --no-tags skeggsb 03.00-disp
git checkout 9ab6dbfd169dd7c2329b2d8aeee09926c49d3280
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/nouveau/nouveau_display.c: In function 'nouveau_display_destroy':
>> drivers/gpu/drm/nouveau/nouveau_display.c:755:29: error: unused variable 'drm' [-Werror=unused-variable]
755 | struct nouveau_drm *drm = nouveau_drm(dev);
| ^~~
cc1: all warnings being treated as errors
vim +/drm +755 drivers/gpu/drm/nouveau/nouveau_display.c
27d5030a235d89 Ben Skeggs 2011-10-06 750
27d5030a235d89 Ben Skeggs 2011-10-06 751 void
27d5030a235d89 Ben Skeggs 2011-10-06 752 nouveau_display_destroy(struct drm_device *dev)
27d5030a235d89 Ben Skeggs 2011-10-06 753 {
77145f1cbdf8d2 Ben Skeggs 2012-07-31 754 struct nouveau_display *disp = nouveau_display(dev);
d297ce4b5d490e Lyude Paul 2020-08-26 @755 struct nouveau_drm *drm = nouveau_drm(dev);
27d5030a235d89 Ben Skeggs 2011-10-06 756
:::::: The code at line 755 was first introduced by commit
:::::: d297ce4b5d490eab60bede36bfd5da6fbcd416cf drm/nouveau/kms: Only use hpd_work for reprobing in HPD paths
:::::: TO: Lyude Paul <lyude(a)redhat.com>
:::::: CC: Lyude Paul <lyude(a)redhat.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
Re: [PATCH v8 10/11] KVM: arm64: Trap access to pVM restricted features
by kernel test robot
Hi Fuad,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 1da38549dd64c7f5dd22427f12dfa8db3d8a722b]
url: https://github.com/0day-ci/linux/commits/Fuad-Tabba/KVM-arm64-Fixed-featu...
base: 1da38549dd64c7f5dd22427f12dfa8db3d8a722b
config: arm64-randconfig-r016-20211014 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project acb3b187c4c88650a6a717a1bcb234d27d0d7f54)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/6d9b1ae6b6b20f6f4300e46a17bb9d42e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Fuad-Tabba/KVM-arm64-Fixed-features-for-protected-VMs/20211010-225842
git checkout 6d9b1ae6b6b20f6f4300e46a17bb9d42eadd3a79
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
arch/arm64/kvm/hyp/nvhe/switch.c:126: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Disable host events, enable guest events
arch/arm64/kvm/hyp/nvhe/switch.c:146: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Disable guest events, enable host events
arch/arm64/kvm/hyp/nvhe/switch.c:164: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Handler for protected VM restricted exceptions.
arch/arm64/kvm/hyp/nvhe/switch.c:176: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Handler for protected VM MSR, MRS or System instruction execution in AArch64.
arch/arm64/kvm/hyp/nvhe/switch.c:196: warning: Function parameter or member 'vcpu' not described in 'kvm_handle_pvm_fpsimd'
arch/arm64/kvm/hyp/nvhe/switch.c:196: warning: Function parameter or member 'exit_code' not described in 'kvm_handle_pvm_fpsimd'
>> arch/arm64/kvm/hyp/nvhe/switch.c:196: warning: expecting prototype for Handler for protected floating(). Prototype was for kvm_handle_pvm_fpsimd() instead
vim +196 arch/arm64/kvm/hyp/nvhe/switch.c
188
189 /**
190 * Handler for protected floating-point and Advanced SIMD accesses.
191 *
192 * Returns true if the hypervisor has handled the exit, and control should go
193 * back to the guest, or false if it hasn't.
194 */
195 static bool kvm_handle_pvm_fpsimd(struct kvm_vcpu *vcpu, u64 *exit_code)
> 196 {
197 /* Linux guests assume support for floating-point and Advanced SIMD. */
198 BUILD_BUG_ON(!FIELD_GET(ARM64_FEATURE_MASK(ID_AA64PFR0_FP),
199 PVM_ID_AA64PFR0_ALLOW));
200 BUILD_BUG_ON(!FIELD_GET(ARM64_FEATURE_MASK(ID_AA64PFR0_ASIMD),
201 PVM_ID_AA64PFR0_ALLOW));
202
203 return kvm_hyp_handle_fpsimd(vcpu, exit_code);
204 }
205
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
[tglx-devel:x86/fpu 74/82] arch/x86/kernel/fpu/xstate.c:1314:14: warning: comparison between pointer and integer ('struct fpstate *' and 'u64' (aka 'unsigned long long'))
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git x86/fpu
head: fbeb78415a1b32f890fa49e4355faa02bb0c0602
commit: 14b0c6c4efcd1654d291d501cca977f3476a5c10 [74/82] x86/fpu: Add sanity checks for XFD
config: x86_64-randconfig-a012-20211014 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project acb3b187c4c88650a6a717a1bcb234d27d0d7f54)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/commit/?id...
git remote add tglx-devel https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git
git fetch --no-tags tglx-devel x86/fpu
git checkout 14b0c6c4efcd1654d291d501cca977f3476a5c10
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/kernel/fpu/xstate.c:1314:14: warning: comparison between pointer and integer ('struct fpstate *' and 'u64' (aka 'unsigned long long')) [-Wpointer-integer-compare]
if (fpstate == current->thread.fpu.fpstate->xfd)
~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
vim +1314 arch/x86/kernel/fpu/xstate.c
1304
1305 #ifdef CONFIG_X86_DEBUG_FPU
1306 static inline bool xfd_valid(struct fpstate *fpstate, u64 mask, bool rstor)
1307 {
1308 u64 xfd = __this_cpu_read(xfd_state);
1309
1310 if (fpstate->xfd == xfd)
1311 return true;
1312
1313 /* For current's fpstate the XFD state must be correct. */
> 1314 if (fpstate == current->thread.fpu.fpstate->xfd)
1315 return false;
1316
1317 /*
1318 * XRSTOR(S) from init_fpstate are always correct as it will just
1319 * bring all components into init state and not read from the
1320 * buffer. XSAVE(S) raises #PF after init.
1321 */
1322 if (fpstate == &init_fpstate)
1323 return rstor;
1324
1325 /*
1326 * XSAVE(S): clone(), fpu_swap_kvm_fpu()
1327 * XRSTORS(S): fpu_swap_kvm_fpu()
1328 */
1329
1330 /* Remove XFD disabled states from the mask. */
1331 mask &= ~xfd;
1332 /* Remove features which are valid in fpstate. */
1333 mask &= ~fpstate->xfeatures;
1334
1335 /*
1336 * Mask should be zero now which means no loads/stores
1337 * past the end of the register state buffer.
1338 */
1339 return !mask;
1340 }
1341
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11 months, 1 week
