Re: [PATCH v4 06/10] hwmon: (tmp421) really disable channels
by kernel test robot
Hi Krzysztof,
Thanks for your patch! Perhaps something to improve:
[auto build test WARNING on groeck-staging/hwmon-next]
[cannot apply to robh/for-next v5.16-rc1 next-20211115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Krzysztof-Adamski/Add-per-channe...
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: arm-randconfig-c002-20211013 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a8c695542b2987eb9a203d5663a0740cb4725f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/4a0f8262fe071b0b27c6fba7455627f3c...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Krzysztof-Adamski/Add-per-channel-properies-support-in-tmp421/20211012-173142
git checkout 4a0f8262fe071b0b27c6fba7455627f3c5a5209e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm clang-analyzer
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
clang-analyzer warnings: (new ones prefixed by >>)
>> drivers/hwmon/tmp421.c:178:3: warning: Undefined or garbage value returned to caller [clang-analyzer-core.uninitialized.UndefReturn]
return err;
^
vim +178 drivers/hwmon/tmp421.c
9410700b881f867 Andre Prendel 2009-09-15 167
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 168 static int tmp421_enable_channels(struct tmp421_data *data)
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 169 {
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 170 int err;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 171 struct i2c_client *client = data->client;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 172 struct device *dev = &client->dev;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 173 int cfg = i2c_smbus_read_byte_data(client, TMP421_CONFIG_REG_2);
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 174 int i;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 175
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 176 if (cfg < 0) {
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 177 dev_err(dev, "error reading register, can't disable channels\n");
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 @178 return err;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 179 }
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 180
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 181 cfg &= ~TMP421_CONFIG_REG_REN_MASK;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 182 for (i = 0; i < data->channels; i++)
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 183 if (data->channel[i].enabled)
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 184 cfg |= TMP421_CONFIG_REG_REN(i);
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 185
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 186 err = i2c_smbus_write_byte_data(client, TMP421_CONFIG_REG_2, cfg);
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 187 if (err < 0)
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 188 dev_err(dev, "error writing register, can't disable channels\n");
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 189
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 190 return err;
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 191 }
4a0f8262fe071b0 Krzysztof Adamski 2021-10-12 192
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
arch/x86/net/bpf_jit_comp.c:2188:5: warning: no previous prototype for 'arch_prepare_bpf_dispatcher'
by kernel test robot
Hi Daniel,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8ab774587903771821b59471cc723bba6d893942
commit: b24abcff918a5cbf44b0c982bd3477a93e8e4911 bpf, kconfig: Add consolidated menu entry for bpf with core options
date: 6 months ago
config: x86_64-buildonly-randconfig-r006-20211012 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout b24abcff918a5cbf44b0c982bd3477a93e8e4911
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/net/bpf_jit_comp.c:2188:5: warning: no previous prototype for 'arch_prepare_bpf_dispatcher' [-Wmissing-prototypes]
2188 | int arch_prepare_bpf_dispatcher(void *image, s64 *funcs, int num_funcs)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/arch_prepare_bpf_dispatcher +2188 arch/x86/net/bpf_jit_comp.c
75ccbef6369e94 Björn Töpel 2019-12-13 2187
75ccbef6369e94 Björn Töpel 2019-12-13 @2188 int arch_prepare_bpf_dispatcher(void *image, s64 *funcs, int num_funcs)
75ccbef6369e94 Björn Töpel 2019-12-13 2189 {
75ccbef6369e94 Björn Töpel 2019-12-13 2190 u8 *prog = image;
75ccbef6369e94 Björn Töpel 2019-12-13 2191
75ccbef6369e94 Björn Töpel 2019-12-13 2192 sort(funcs, num_funcs, sizeof(funcs[0]), cmp_ips, NULL);
75ccbef6369e94 Björn Töpel 2019-12-13 2193 return emit_bpf_dispatcher(&prog, 0, num_funcs - 1, funcs);
75ccbef6369e94 Björn Töpel 2019-12-13 2194 }
75ccbef6369e94 Björn Töpel 2019-12-13 2195
:::::: The code at line 2188 was first introduced by commit
:::::: 75ccbef6369e94ecac696a152a998a978d41376b bpf: Introduce BPF dispatcher
:::::: TO: Björn Töpel <bjorn.topel(a)intel.com>
:::::: CC: Alexei Starovoitov <ast(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
Re: [PATCH 1/7] serial: core: Add support of runtime PM
by kernel test robot
Hi Tony,
I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v5.16-rc1 next-20211116]
[cannot apply to tty/tty-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Tony-Lindgren/Serial-port-generi...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: hexagon-randconfig-r045-20211115 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project fbe72e41b99dc7994daac300d208a955be3e4a0a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/d9568fa846ba1319eacfd03d39b48c3af...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tony-Lindgren/Serial-port-generic-PM-to-fix-8250-PM/20211115-164354
git checkout d9568fa846ba1319eacfd03d39b48c3af05fe9f9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=hexagon
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/tty/serial/serial_core.c:2353:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (tty_port_suspended(port)) {
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/tty/serial/serial_core.c:2401:9: note: uninitialized use occurs here
return ret;
^~~
drivers/tty/serial/serial_core.c:2353:2: note: remove the 'if' if its condition is always true
if (tty_port_suspended(port)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/tty/serial/serial_core.c:2310:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
1 warning generated.
vim +2353 drivers/tty/serial/serial_core.c
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2302
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2303 int uart_resume_port(struct uart_driver *drv, struct uart_port *uport)
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2304 {
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2305 struct uart_state *state = drv->state + uport->line;
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2306 struct tty_port *port = &state->port;
03a74dcc7eebe6 drivers/serial/serial_core.c Arjan van de Ven 2008-05-23 2307 struct device *tty_dev;
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2308 struct uart_match match = {uport, drv};
ba15ab0e8de0d4 drivers/serial/serial_core.c Deepak Saxena 2009-09-19 2309 struct ktermios termios;
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2310 int ret;
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2311
a2bceae065ed8c drivers/serial/serial_core.c Alan Cox 2009-09-19 2312 mutex_lock(&port->mutex);
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2313
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2314 tty_dev = device_find_child(uport->dev, &match, serial_match_port);
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2315 if (!uport->suspended && device_may_wakeup(tty_dev)) {
aef3ad103a686f drivers/tty/serial/serial_core.c Andy Shevchenko 2017-08-13 2316 if (irqd_is_wakeup_set(irq_get_irq_data((uport->irq))))
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2317 disable_irq_wake(uport->irq);
5a65dcc04cda41 drivers/tty/serial/serial_core.c Federico Vaga 2013-04-15 2318 put_device(tty_dev);
a2bceae065ed8c drivers/serial/serial_core.c Alan Cox 2009-09-19 2319 mutex_unlock(&port->mutex);
b3b708fa2780cd drivers/serial/serial_core.c Guennadi Liakhovetski 2007-10-16 2320 return 0;
b3b708fa2780cd drivers/serial/serial_core.c Guennadi Liakhovetski 2007-10-16 2321 }
5a65dcc04cda41 drivers/tty/serial/serial_core.c Federico Vaga 2013-04-15 2322 put_device(tty_dev);
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2323 uport->suspended = 0;
b3b708fa2780cd drivers/serial/serial_core.c Guennadi Liakhovetski 2007-10-16 2324
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2325 /*
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2326 * Re-enable the console device after suspending.
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2327 */
5933a161abcb8d drivers/tty/serial/serial_core.c Yin Kangkai 2011-01-30 2328 if (uart_console(uport)) {
891b9dd1076435 drivers/serial/serial_core.c Jason Wang 2010-08-21 2329 /*
891b9dd1076435 drivers/serial/serial_core.c Jason Wang 2010-08-21 2330 * First try to use the console cflag setting.
891b9dd1076435 drivers/serial/serial_core.c Jason Wang 2010-08-21 2331 */
891b9dd1076435 drivers/serial/serial_core.c Jason Wang 2010-08-21 2332 memset(&termios, 0, sizeof(struct ktermios));
891b9dd1076435 drivers/serial/serial_core.c Jason Wang 2010-08-21 2333 termios.c_cflag = uport->cons->cflag;
891b9dd1076435 drivers/serial/serial_core.c Jason Wang 2010-08-21 2334
891b9dd1076435 drivers/serial/serial_core.c Jason Wang 2010-08-21 2335 /*
891b9dd1076435 drivers/serial/serial_core.c Jason Wang 2010-08-21 2336 * If that's unset, use the tty termios setting.
891b9dd1076435 drivers/serial/serial_core.c Jason Wang 2010-08-21 2337 */
adc8d746caa67f drivers/tty/serial/serial_core.c Alan Cox 2012-07-14 2338 if (port->tty && termios.c_cflag == 0)
adc8d746caa67f drivers/tty/serial/serial_core.c Alan Cox 2012-07-14 2339 termios = port->tty->termios;
891b9dd1076435 drivers/serial/serial_core.c Jason Wang 2010-08-21 2340
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2341 ret = serial_pm_resume_and_get(uport->dev);
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2342 if (ret < 0)
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2343 goto unlock;
94abc56f4d90f2 drivers/tty/serial/serial_core.c Ning Jiang 2011-09-05 2344 if (console_suspend_enabled)
6f538fe31c1d45 drivers/tty/serial/serial_core.c Linus Walleij 2012-12-07 2345 uart_change_pm(state, UART_PM_STATE_ON);
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2346 uport->ops->set_termios(uport, &termios, NULL);
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2347 serial_pm_autosuspend(uport->dev);
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2348
5933a161abcb8d drivers/tty/serial/serial_core.c Yin Kangkai 2011-01-30 2349 if (console_suspend_enabled)
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2350 console_start(uport->cons);
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2351 }
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2352
80f02d5424301b drivers/tty/serial/serial_core.c Peter Hurley 2016-04-09 @2353 if (tty_port_suspended(port)) {
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2354 const struct uart_ops *ops = uport->ops;
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2355
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2356 ret = serial_pm_resume_and_get(uport->dev);
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2357 if (ret < 0)
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2358 goto unlock;
6f538fe31c1d45 drivers/tty/serial/serial_core.c Linus Walleij 2012-12-07 2359 uart_change_pm(state, UART_PM_STATE_ON);
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2360 spin_lock_irq(&uport->lock);
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2361 ops->set_mctrl(uport, 0);
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2362 spin_unlock_irq(&uport->lock);
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2363 serial_pm_autosuspend(uport->dev);
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2364
4547be7809a3b7 drivers/serial/serial_core.c Stanislav Brabec 2009-12-02 2365 if (console_suspend_enabled || !uart_console(uport)) {
192251352f912b drivers/serial/serial_core.c Alan Cox 2010-06-01 2366 /* Protected by port mutex for now */
192251352f912b drivers/serial/serial_core.c Alan Cox 2010-06-01 2367 struct tty_struct *tty = port->tty;
4ed71addf51a62 drivers/tty/serial/serial_core.c Tamseel Shams 2020-07-16 2368
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2369 ret = serial_pm_resume_and_get(uport->dev);
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2370 if (ret < 0)
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2371 goto unlock;
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2372 ret = ops->startup(uport);
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2373 serial_pm_autosuspend(uport->dev);
ee31b337852ca8 drivers/serial/serial_core.c Russell King 2005-11-13 2374 if (ret == 0) {
192251352f912b drivers/serial/serial_core.c Alan Cox 2010-06-01 2375 if (tty)
192251352f912b drivers/serial/serial_core.c Alan Cox 2010-06-01 2376 uart_change_speed(tty, state, NULL);
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2377 ret = serial_pm_resume_and_get(uport->dev);
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2378 if (ret < 0)
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2379 goto unlock;
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2380 spin_lock_irq(&uport->lock);
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2381 ops->set_mctrl(uport, uport->mctrl);
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2382 ops->start_tx(uport);
ccce6debb62d94 drivers/serial/serial_core.c Alan Cox 2009-09-19 2383 spin_unlock_irq(&uport->lock);
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2384 serial_pm_autosuspend(uport->dev);
d41861ca19c9e9 drivers/tty/serial/serial_core.c Peter Hurley 2016-04-09 2385 tty_port_set_initialized(port, 1);
ee31b337852ca8 drivers/serial/serial_core.c Russell King 2005-11-13 2386 } else {
ee31b337852ca8 drivers/serial/serial_core.c Russell King 2005-11-13 2387 /*
ee31b337852ca8 drivers/serial/serial_core.c Russell King 2005-11-13 2388 * Failed to resume - maybe hardware went away?
ee31b337852ca8 drivers/serial/serial_core.c Russell King 2005-11-13 2389 * Clear the "initialized" flag so we won't try
ee31b337852ca8 drivers/serial/serial_core.c Russell King 2005-11-13 2390 * to call the low level drivers shutdown method.
ee31b337852ca8 drivers/serial/serial_core.c Russell King 2005-11-13 2391 */
192251352f912b drivers/serial/serial_core.c Alan Cox 2010-06-01 2392 uart_shutdown(tty, state);
ee31b337852ca8 drivers/serial/serial_core.c Russell King 2005-11-13 2393 }
4547be7809a3b7 drivers/serial/serial_core.c Stanislav Brabec 2009-12-02 2394 }
a6b93a90850881 drivers/serial/serial_core.c Russell King 2006-10-01 2395
80f02d5424301b drivers/tty/serial/serial_core.c Peter Hurley 2016-04-09 2396 tty_port_set_suspended(port, 0);
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2397 }
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2398 unlock:
a2bceae065ed8c drivers/serial/serial_core.c Alan Cox 2009-09-19 2399 mutex_unlock(&port->mutex);
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2400
d9568fa846ba13 drivers/tty/serial/serial_core.c Andy Shevchenko 2021-11-15 2401 return ret;
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2402 }
^1da177e4c3f41 drivers/serial/serial_core.c Linus Torvalds 2005-04-16 2403
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
Re: [PATCH v2 05/14] NFS: Remove the label from the nfs4_lookup_res struct
by Dan Carpenter
Hi,
url: https://github.com/0day-ci/linux/commits/schumaker-anna-gmail-com/NFS-Cle...
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: i386-randconfig-m021-20211025 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
fs/nfs/dir.c:1802 nfs_lookup() error: uninitialized symbol 'error'.
vim +/error +1802 fs/nfs/dir.c
597d92891b8859 Bryan Schumaker 2012-07-16 1748 struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, unsigned int flags)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1749 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1750 struct dentry *res;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1751 struct inode *inode = NULL;
e1fb4d05d5a326 Trond Myklebust 2010-04-16 1752 struct nfs_fh *fhandle = NULL;
e1fb4d05d5a326 Trond Myklebust 2010-04-16 1753 struct nfs_fattr *fattr = NULL;
a1147b8281bda9 Trond Myklebust 2020-02-05 1754 unsigned long dir_verifier;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1755 int error;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1756
6de1472f1a4a3b Al Viro 2013-09-16 1757 dfprintk(VFS, "NFS: lookup(%pd2)\n", dentry);
91d5b47023b608 Chuck Lever 2006-03-20 1758 nfs_inc_stats(dir, NFSIOS_VFSLOOKUP);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1759
130f9ab75dc3af Al Viro 2016-03-07 1760 if (unlikely(dentry->d_name.len > NFS_SERVER(dir)->namelen))
130f9ab75dc3af Al Viro 2016-03-07 1761 return ERR_PTR(-ENAMETOOLONG);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1762
fd6840714d9cf6 Trond Myklebust 2006-09-05 1763 /*
fd6840714d9cf6 Trond Myklebust 2006-09-05 1764 * If we're doing an exclusive create, optimize away the lookup
fd6840714d9cf6 Trond Myklebust 2006-09-05 1765 * but don't hash the dentry.
fd6840714d9cf6 Trond Myklebust 2006-09-05 1766 */
9f6d44d418b1f4 Trond Myklebust 2018-05-10 1767 if (nfs_is_exclusive_create(dir, flags) || flags & LOOKUP_RENAME_TARGET)
130f9ab75dc3af Al Viro 2016-03-07 1768 return NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1769
e1fb4d05d5a326 Trond Myklebust 2010-04-16 1770 res = ERR_PTR(-ENOMEM);
e1fb4d05d5a326 Trond Myklebust 2010-04-16 1771 fhandle = nfs_alloc_fhandle();
ca3c213e9f9273 Anna Schumaker 2021-10-22 1772 fattr = nfs_alloc_fattr_with_label(NFS_SERVER(dir));
e1fb4d05d5a326 Trond Myklebust 2010-04-16 1773 if (fhandle == NULL || fattr == NULL)
e1fb4d05d5a326 Trond Myklebust 2010-04-16 1774 goto out;
"error" uninitialized.
e1fb4d05d5a326 Trond Myklebust 2010-04-16 1775
a1147b8281bda9 Trond Myklebust 2020-02-05 1776 dir_verifier = nfs_save_change_attribute(dir);
6e0d0be715fe04 Trond Myklebust 2013-08-20 1777 trace_nfs_lookup_enter(dir, dentry, flags);
ca3c213e9f9273 Anna Schumaker 2021-10-22 1778 error = NFS_PROTO(dir)->lookup(dir, dentry, fhandle, fattr);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1779 if (error == -ENOENT)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1780 goto no_entry;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1781 if (error < 0) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1782 res = ERR_PTR(error);
ca3c213e9f9273 Anna Schumaker 2021-10-22 1783 goto out;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1784 }
ca3c213e9f9273 Anna Schumaker 2021-10-22 1785 inode = nfs_fhget(dentry->d_sb, fhandle, fattr, fattr->label);
bf0c84f1614bff Namhyung Kim 2010-12-28 1786 res = ERR_CAST(inode);
03f28e3a2059fc Trond Myklebust 2006-03-20 1787 if (IS_ERR(res))
ca3c213e9f9273 Anna Schumaker 2021-10-22 1788 goto out;
54ceac45159860 David Howells 2006-08-22 1789
63519fbc67d0d9 Trond Myklebust 2016-11-19 1790 /* Notify readdir to use READDIRPLUS */
63519fbc67d0d9 Trond Myklebust 2016-11-19 1791 nfs_force_use_readdirplus(dir);
d69ee9b85541a6 Trond Myklebust 2012-05-01 1792
^1da177e4c3f41 Linus Torvalds 2005-04-16 1793 no_entry:
41d28bca2da4bd Al Viro 2014-10-12 1794 res = d_splice_alias(inode, dentry);
9eaef27b36a6b7 Trond Myklebust 2006-10-21 1795 if (res != NULL) {
9eaef27b36a6b7 Trond Myklebust 2006-10-21 1796 if (IS_ERR(res))
ca3c213e9f9273 Anna Schumaker 2021-10-22 1797 goto out;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1798 dentry = res;
9eaef27b36a6b7 Trond Myklebust 2006-10-21 1799 }
a1147b8281bda9 Trond Myklebust 2020-02-05 1800 nfs_set_verifier(dentry, dir_verifier);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1801 out:
ca3c213e9f9273 Anna Schumaker 2021-10-22 @1802 trace_nfs_lookup_exit(dir, dentry, flags, error);
^^^^^
e1fb4d05d5a326 Trond Myklebust 2010-04-16 1803 nfs_free_fattr(fattr);
e1fb4d05d5a326 Trond Myklebust 2010-04-16 1804 nfs_free_fhandle(fhandle);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1805 return res;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1806 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
ld.lld: error: undefined symbol: __devm_regmap_init_spi
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d4439a1189f93d0ac1eaf0197db8e6b3e197d5c7
commit: 96792fdd77cd19fcf2368e7c19bb8b78557ae425 ASoC: amd: enable vangogh platform machine driver build
date: 3 weeks ago
config: x86_64-randconfig-r002-20211103 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 264d3b6d4e08401c5b50a85bd76e80b3461d77e6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 96792fdd77cd19fcf2368e7c19bb8b78557ae425
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> ld.lld: error: undefined symbol: __devm_regmap_init_spi
>>> referenced by cs35l41-spi.c:85 (sound/soc/codecs/cs35l41-spi.c:85)
>>> soc/codecs/cs35l41-spi.o:(cs35l41_spi_probe) in archive sound/built-in.a
--
>> ld.lld: error: undefined symbol: spi_setup
>>> referenced by cs35l41-spi.c:62 (sound/soc/codecs/cs35l41-spi.c:62)
>>> soc/codecs/cs35l41-spi.o:(cs35l41_spi_otp_setup) in archive sound/built-in.a
>>> referenced by cs35l41-spi.c:68 (sound/soc/codecs/cs35l41-spi.c:68)
>>> soc/codecs/cs35l41-spi.o:(cs35l41_spi_otp_setup) in archive sound/built-in.a
--
>> ld.lld: error: undefined symbol: __spi_register_driver
>>> referenced by cs35l41-spi.c:134 (sound/soc/codecs/cs35l41-spi.c:134)
>>> soc/codecs/cs35l41-spi.o:(cs35l41_spi_driver_init) in archive sound/built-in.a
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_SOC_CS35L41_SPI
Depends on SOUND && !UML && SND && SND_SOC && SPI_MASTER
Selected by
- SND_SOC_AMD_VANGOGH_MACH && SOUND && !UML && SND && SND_SOC && SND_SOC_AMD_ACP5x && I2C
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
sound/soc/amd/yc/pci-acp6x.c:251 snd_acp6x_probe() error: uninitialized symbol 'index'.
by Dan Carpenter
Hi Vijendar,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 66f4beaa6c1d28161f534471484b2daa2de1dce0
commit: 89728d97db3f078aceb967ebe5ed2d0797b6a117 ASoC: amd: enable Yellow carp acp6x drivers build
config: x86_64-randconfig-m001-20211028 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
sound/soc/amd/yc/pci-acp6x.c:251 snd_acp6x_probe() error: uninitialized symbol 'index'.
vim +/index +251 sound/soc/amd/yc/pci-acp6x.c
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 144 static int snd_acp6x_probe(struct pci_dev *pci,
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 145 const struct pci_device_id *pci_id)
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 146 {
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 147 struct acp6x_dev_data *adata;
fc329c1de49825 Vijendar Mukunda 2021-10-18 148 struct platform_device_info pdevinfo[ACP6x_DEVS];
fc329c1de49825 Vijendar Mukunda 2021-10-18 149 int ret, index;
fc329c1de49825 Vijendar Mukunda 2021-10-18 150 int val = 0x00;
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 151 u32 addr;
cc0deaa2dc7300 Vijendar Mukunda 2021-10-18 152 unsigned int irqflags;
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 153
cc0deaa2dc7300 Vijendar Mukunda 2021-10-18 154 irqflags = IRQF_SHARED;
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 155 /* Yellow Carp device check */
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 156 if (pci->revision != 0x60)
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 157 return -ENODEV;
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 158
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 159 if (pci_enable_device(pci)) {
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 160 dev_err(&pci->dev, "pci_enable_device failed\n");
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 161 return -ENODEV;
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 162 }
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 163
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 164 ret = pci_request_regions(pci, "AMD ACP3x audio");
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 165 if (ret < 0) {
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 166 dev_err(&pci->dev, "pci_request_regions failed\n");
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 167 goto disable_pci;
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 168 }
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 169
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 170 adata = devm_kzalloc(&pci->dev, sizeof(struct acp6x_dev_data),
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 171 GFP_KERNEL);
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 172 if (!adata) {
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 173 ret = -ENOMEM;
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 174 goto release_regions;
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 175 }
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 176
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 177 addr = pci_resource_start(pci, 0);
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 178 adata->acp6x_base = devm_ioremap(&pci->dev, addr,
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 179 pci_resource_len(pci, 0));
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 180 if (!adata->acp6x_base) {
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 181 ret = -ENOMEM;
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 182 goto release_regions;
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 183 }
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 184 pci_set_master(pci);
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 185 pci_set_drvdata(pci, adata);
8c7161f2c97b2d Vijendar Mukunda 2021-10-18 186 ret = acp6x_init(adata->acp6x_base);
8c7161f2c97b2d Vijendar Mukunda 2021-10-18 187 if (ret)
8c7161f2c97b2d Vijendar Mukunda 2021-10-18 188 goto release_regions;
fc329c1de49825 Vijendar Mukunda 2021-10-18 189 val = acp6x_readl(adata->acp6x_base + ACP_PIN_CONFIG);
fc329c1de49825 Vijendar Mukunda 2021-10-18 190 switch (val) {
fc329c1de49825 Vijendar Mukunda 2021-10-18 191 case ACP_CONFIG_0:
fc329c1de49825 Vijendar Mukunda 2021-10-18 192 case ACP_CONFIG_1:
fc329c1de49825 Vijendar Mukunda 2021-10-18 193 case ACP_CONFIG_2:
fc329c1de49825 Vijendar Mukunda 2021-10-18 194 case ACP_CONFIG_3:
fc329c1de49825 Vijendar Mukunda 2021-10-18 195 case ACP_CONFIG_9:
fc329c1de49825 Vijendar Mukunda 2021-10-18 196 case ACP_CONFIG_15:
fc329c1de49825 Vijendar Mukunda 2021-10-18 197 dev_info(&pci->dev, "Audio Mode %d\n", val);
fc329c1de49825 Vijendar Mukunda 2021-10-18 198 break;
"index" is not set for these cases.
fc329c1de49825 Vijendar Mukunda 2021-10-18 199 default:
fc329c1de49825 Vijendar Mukunda 2021-10-18 200 adata->res = devm_kzalloc(&pci->dev,
fc329c1de49825 Vijendar Mukunda 2021-10-18 201 sizeof(struct resource),
fc329c1de49825 Vijendar Mukunda 2021-10-18 202 GFP_KERNEL);
fc329c1de49825 Vijendar Mukunda 2021-10-18 203 if (!adata->res) {
fc329c1de49825 Vijendar Mukunda 2021-10-18 204 ret = -ENOMEM;
fc329c1de49825 Vijendar Mukunda 2021-10-18 205 goto de_init;
fc329c1de49825 Vijendar Mukunda 2021-10-18 206 }
fc329c1de49825 Vijendar Mukunda 2021-10-18 207
fc329c1de49825 Vijendar Mukunda 2021-10-18 208 adata->res->name = "acp_iomem";
fc329c1de49825 Vijendar Mukunda 2021-10-18 209 adata->res->flags = IORESOURCE_MEM;
fc329c1de49825 Vijendar Mukunda 2021-10-18 210 adata->res->start = addr;
fc329c1de49825 Vijendar Mukunda 2021-10-18 211 adata->res->end = addr + (ACP6x_REG_END - ACP6x_REG_START);
fc329c1de49825 Vijendar Mukunda 2021-10-18 212
fc329c1de49825 Vijendar Mukunda 2021-10-18 213 adata->acp6x_audio_mode = ACP6x_PDM_MODE;
fc329c1de49825 Vijendar Mukunda 2021-10-18 214
fc329c1de49825 Vijendar Mukunda 2021-10-18 215 memset(&pdevinfo, 0, sizeof(pdevinfo));
fc329c1de49825 Vijendar Mukunda 2021-10-18 216 pdevinfo[0].name = "acp_yc_pdm_dma";
fc329c1de49825 Vijendar Mukunda 2021-10-18 217 pdevinfo[0].id = 0;
fc329c1de49825 Vijendar Mukunda 2021-10-18 218 pdevinfo[0].parent = &pci->dev;
fc329c1de49825 Vijendar Mukunda 2021-10-18 219 pdevinfo[0].num_res = 1;
fc329c1de49825 Vijendar Mukunda 2021-10-18 220 pdevinfo[0].res = adata->res;
8c7161f2c97b2d Vijendar Mukunda 2021-10-18 221
fc329c1de49825 Vijendar Mukunda 2021-10-18 222 pdevinfo[1].name = "dmic-codec";
fc329c1de49825 Vijendar Mukunda 2021-10-18 223 pdevinfo[1].id = 0;
fc329c1de49825 Vijendar Mukunda 2021-10-18 224 pdevinfo[1].parent = &pci->dev;
fc329c1de49825 Vijendar Mukunda 2021-10-18 225
fc329c1de49825 Vijendar Mukunda 2021-10-18 226 for (index = 0; index < ACP6x_DEVS; index++) {
fc329c1de49825 Vijendar Mukunda 2021-10-18 227 adata->pdev[index] =
fc329c1de49825 Vijendar Mukunda 2021-10-18 228 platform_device_register_full(&pdevinfo[index]);
fc329c1de49825 Vijendar Mukunda 2021-10-18 229 if (IS_ERR(adata->pdev[index])) {
fc329c1de49825 Vijendar Mukunda 2021-10-18 230 dev_err(&pci->dev, "cannot register %s device\n",
fc329c1de49825 Vijendar Mukunda 2021-10-18 231 pdevinfo[index].name);
fc329c1de49825 Vijendar Mukunda 2021-10-18 232 ret = PTR_ERR(adata->pdev[index]);
fc329c1de49825 Vijendar Mukunda 2021-10-18 233 goto unregister_devs;
fc329c1de49825 Vijendar Mukunda 2021-10-18 234 }
fc329c1de49825 Vijendar Mukunda 2021-10-18 235 }
fc329c1de49825 Vijendar Mukunda 2021-10-18 236 break;
fc329c1de49825 Vijendar Mukunda 2021-10-18 237 }
cc0deaa2dc7300 Vijendar Mukunda 2021-10-18 238 ret = devm_request_irq(&pci->dev, pci->irq, acp6x_irq_handler,
cc0deaa2dc7300 Vijendar Mukunda 2021-10-18 239 irqflags, "ACP_PCI_IRQ", adata);
cc0deaa2dc7300 Vijendar Mukunda 2021-10-18 240 if (ret) {
cc0deaa2dc7300 Vijendar Mukunda 2021-10-18 241 dev_err(&pci->dev, "ACP PCI IRQ request failed\n");
cc0deaa2dc7300 Vijendar Mukunda 2021-10-18 242 goto unregister_devs;
cc0deaa2dc7300 Vijendar Mukunda 2021-10-18 243 }
c8212df7bc0f2e Vijendar Mukunda 2021-10-18 244 pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
c8212df7bc0f2e Vijendar Mukunda 2021-10-18 245 pm_runtime_use_autosuspend(&pci->dev);
c8212df7bc0f2e Vijendar Mukunda 2021-10-18 246 pm_runtime_put_noidle(&pci->dev);
c8212df7bc0f2e Vijendar Mukunda 2021-10-18 247 pm_runtime_allow(&pci->dev);
c8212df7bc0f2e Vijendar Mukunda 2021-10-18 248
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 249 return 0;
fc329c1de49825 Vijendar Mukunda 2021-10-18 250 unregister_devs:
fc329c1de49825 Vijendar Mukunda 2021-10-18 @251 for (--index; index >= 0; index--)
Uninitialized variable "index".
fc329c1de49825 Vijendar Mukunda 2021-10-18 252 platform_device_unregister(adata->pdev[index]);
fc329c1de49825 Vijendar Mukunda 2021-10-18 253 de_init:
fc329c1de49825 Vijendar Mukunda 2021-10-18 254 if (acp6x_deinit(adata->acp6x_base))
fc329c1de49825 Vijendar Mukunda 2021-10-18 255 dev_err(&pci->dev, "ACP de-init failed\n");
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 256 release_regions:
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 257 pci_release_regions(pci);
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 258 disable_pci:
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 259 pci_disable_device(pci);
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 260
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 261 return ret;
c62442bd5d9f86 Vijendar Mukunda 2021-10-18 262 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
[freescale-fslc:5.10-2.1.x-imx 9404/15264] sound/soc/sof/ipc-stream.c:42:7: warning: variable 'pstream' is used uninitialized whenever 'if' condition is false
by kernel test robot
Hi Daniel,
FYI, the error/warning still remains.
tree: https://github.com/Freescale/linux-fslc 5.10-2.1.x-imx
head: cdf10f101ab7e0112a285ab86e1a62d80e7d2104
commit: 153af17b6a39176b294835304ae46e5234951a91 [9404/15264] LF-3774-3 ASoC: SOF: Fix sof_ipc_msg_data for compress streams
config: x86_64-randconfig-a015-20211115 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project fbe72e41b99dc7994daac300d208a955be3e4a0a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Freescale/linux-fslc/commit/153af17b6a39176b294835304a...
git remote add freescale-fslc https://github.com/Freescale/linux-fslc
git fetch --no-tags freescale-fslc 5.10-2.1.x-imx
git checkout 153af17b6a39176b294835304ae46e5234951a91
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> sound/soc/sof/ipc-stream.c:42:7: warning: variable 'pstream' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (substream) {
^~~~~~~~~
sound/soc/sof/ipc-stream.c:50:7: note: uninitialized use occurs here
if (pstream || sstream)
^~~~~~~
sound/soc/sof/ipc-stream.c:42:3: note: remove the 'if' if its condition is always true
if (substream) {
^~~~~~~~~~~~~~~
sound/soc/sof/ipc-stream.c:38:33: note: initialize the variable 'pstream' to silence this warning
struct sof_pcm_stream *pstream;
^
= NULL
1 warning generated.
vim +42 sound/soc/sof/ipc-stream.c
27
28 /* Mailbox-based Intel IPC implementation */
29 void sof_ipc_msg_data(struct snd_sof_dev *sdev,
30 struct snd_sof_pcm_stream *sps,
31 void *p, size_t sz)
32 {
33 if (!sps || !sdev->stream_box.size) {
34 sof_mailbox_read(sdev, sdev->dsp_box.offset, p, sz);
35 } else {
36 struct snd_pcm_substream *substream = sps->substream;
37 struct snd_compr_stream *cstream = sps->cstream;
38 struct sof_pcm_stream *pstream;
39 struct sof_compr_stream *sstream;
40 size_t posn_offset;
41
> 42 if (substream) {
43 pstream = substream->runtime->private_data;
44 posn_offset = pstream->posn_offset;
45 } else {
46 sstream = cstream->runtime->private_data;
47 posn_offset = sstream->posn_offset;
48 }
49 /* The stream might already be closed */
50 if (pstream || sstream)
51 sof_mailbox_read(sdev, posn_offset, p, sz);
52 }
53 }
54 EXPORT_SYMBOL(sof_ipc_msg_data);
55
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
[freescale-fslc:5.10-2.1.x-imx 8417/15264] drivers/pci/controller/dwc/pci-imx6.c:2938:29: warning: use of logical '&&' with constant operand
by kernel test robot
tree: https://github.com/Freescale/linux-fslc 5.10-2.1.x-imx
head: cdf10f101ab7e0112a285ab86e1a62d80e7d2104
commit: 1713c6ce909c5b8b54df3e9daa12d0e36eda86b7 [8417/15264] MLK-25283-4 PCI: imx: adjust the l1ss support to proper place
config: i386-randconfig-a015-20211115 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project fbe72e41b99dc7994daac300d208a955be3e4a0a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Freescale/linux-fslc/commit/1713c6ce909c5b8b54df3e9daa...
git remote add freescale-fslc https://github.com/Freescale/linux-fslc
git fetch --no-tags freescale-fslc 5.10-2.1.x-imx
git checkout 1713c6ce909c5b8b54df3e9daa12d0e36eda86b7
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/pci/controller/dwc/pci-imx6.c:2370:6: warning: unused variable 'reg' [-Wunused-variable]
u32 reg;
^
>> drivers/pci/controller/dwc/pci-imx6.c:2938:29: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
if ((rc_l1sub && ep_l1sub) && PCI_L1SS_CAP_L1_PM_SS) {
^ ~~~~~~~~~~~~~~~~~~~~~
drivers/pci/controller/dwc/pci-imx6.c:2938:29: note: use '&' for a bitwise operation
if ((rc_l1sub && ep_l1sub) && PCI_L1SS_CAP_L1_PM_SS) {
^~
&
drivers/pci/controller/dwc/pci-imx6.c:2938:29: note: remove constant to silence this warning
if ((rc_l1sub && ep_l1sub) && PCI_L1SS_CAP_L1_PM_SS) {
~^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pci/controller/dwc/pci-imx6.c:2902:11: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
int ttl, ret;
^
3 warnings generated.
vim +2938 drivers/pci/controller/dwc/pci-imx6.c
2867
2868 static void imx6_pcie_quirk(struct pci_dev *dev)
2869 {
2870 struct pci_bus *bus = dev->bus;
2871 struct pcie_port *pp = bus->sysdata;
2872
2873 /* Bus parent is the PCI bridge, its parent is this platform driver */
2874 if (!bus->dev.parent || !bus->dev.parent->parent)
2875 return;
2876
2877 /* Make sure we only quirk devices associated with this driver */
2878 if (bus->dev.parent->parent->driver != &imx6_pcie_driver.driver)
2879 return;
2880
2881 if (pci_is_root_bus(bus)) {
2882 struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
2883 struct imx6_pcie *imx6_pcie = to_imx6_pcie(pci);
2884
2885 /*
2886 * Limit config length to avoid the kernel reading beyond
2887 * the register set and causing an abort on i.MX 6Quad
2888 */
2889 if (imx6_pcie->drvdata->dbi_length) {
2890 dev->cfg_size = imx6_pcie->drvdata->dbi_length;
2891 dev_info(&dev->dev, "Limiting cfg_size to %d\n",
2892 dev->cfg_size);
2893 }
2894 }
2895 }
2896 DECLARE_PCI_FIXUP_CLASS_HEADER(PCI_VENDOR_ID_SYNOPSYS, 0xabcd,
2897 PCI_CLASS_BRIDGE_PCI, 8, imx6_pcie_quirk);
2898
2899 static void imx6_pcie_l1ss_quirk(struct pci_dev *dev)
2900 {
2901 u32 reg, rc_l1sub, ep_l1sub, header;
> 2902 int ttl, ret;
2903 int pos = PCI_CFG_SPACE_SIZE;
2904 struct pci_bus *bus = dev->bus;
2905 struct pcie_port *pp = bus->sysdata;
2906 struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
2907 struct imx6_pcie *imx6_pcie = to_imx6_pcie(pci);
2908
2909 /* Return directly, if the L1SS is not supported by RC */
2910 if (!(imx6_pcie->drvdata->flags & IMX6_PCIE_FLAG_SUPPORTS_L1SS))
2911 return;
2912
2913 reg = dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_L1SS);
2914 rc_l1sub = dw_pcie_readl_dbi(pci, reg + PCI_L1SS_CAP);
2915
2916 /* minimum 8 bytes per capability */
2917 ttl = (PCI_CFG_SPACE_EXP_SIZE - PCI_CFG_SPACE_SIZE) / 8;
2918 ret = dw_pcie_read(pp->va_cfg0_base + pos, 4, &header);
2919 /*
2920 * If we have no capabilities, this is indicated by cap ID,
2921 * cap version and next pointer all being 0.
2922 */
2923 if (header == 0)
2924 return;
2925
2926 while (ttl-- > 0) {
2927 if (PCI_EXT_CAP_ID(header) == PCI_EXT_CAP_ID_L1SS && pos != 0)
2928 break;
2929
2930 pos = PCI_EXT_CAP_NEXT(header);
2931 if (pos < PCI_CFG_SPACE_SIZE)
2932 break;
2933
2934 ret = dw_pcie_read(pp->va_cfg0_base + pos, 4, &header);
2935 }
2936 ret = dw_pcie_read(pp->va_cfg0_base + pos + PCI_L1SS_CAP, 4, &ep_l1sub);
2937
> 2938 if ((rc_l1sub && ep_l1sub) && PCI_L1SS_CAP_L1_PM_SS) {
2939 imx6_pcie->l1ss_clkreq = 1;
2940 imx6_pcie_clkreq_enable(imx6_pcie);
2941 } else {
2942 imx6_pcie->l1ss_clkreq = 0;
2943 }
2944 }
2945 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SYNOPSYS, 0xabcd, imx6_pcie_l1ss_quirk);
2946
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
ld.lld: error: undefined symbol: irq_generic_chip_ops
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8ab774587903771821b59471cc723bba6d893942
commit: 936ee2675eee1faca0dcdfa79165c7990422e0fc gpio/rockchip: add driver for rockchip gpio
date: 3 months ago
config: hexagon-randconfig-r025-20211109 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f3798ad5fa845771846599f3c088016e3aef800c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 936ee2675eee1faca0dcdfa79165c7990422e0fc
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> ld.lld: error: undefined symbol: irq_generic_chip_ops
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
--
>> ld.lld: error: undefined symbol: __irq_alloc_domain_generic_chips
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
--
>> ld.lld: error: undefined symbol: irq_get_domain_generic_chip
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
--
>> ld.lld: error: undefined symbol: irq_gc_ack_set_bit
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
--
>> ld.lld: error: undefined symbol: irq_gc_mask_set_bit
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_irq_disable) in archive drivers/built-in.a
>>> referenced 1 more times
--
>> ld.lld: error: undefined symbol: irq_gc_mask_clr_bit
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_irq_enable) in archive drivers/built-in.a
>>> referenced 1 more times
--
>> ld.lld: error: undefined symbol: irq_gc_set_wake
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
>>> referenced by gpio-rockchip.c
>>> gpio/gpio-rockchip.o:(rockchip_gpio_probe) in archive drivers/built-in.a
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week