[hare-scsi-devel:scsi-private.v2 18/21] drivers/scsi/aacraid/aachba.c:342:29: error: 'FIB_CONTEXT_INTERNAL_CMD' undeclared; did you mean 'FIB_CONTEXT_FLAG_INTERNAL_CMD'?
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git scsi-private.v2
head: 915b986531e666d840f72752c597fb6b4ea69d35
commit: 62ef655cc63719b6556a5233e305edc9ffc644bc [18/21] aacraid: sanitize container callbacks
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commi...
git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
git fetch --no-tags hare-scsi-devel scsi-private.v2
git checkout 62ef655cc63719b6556a5233e305edc9ffc644bc
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/scsi/aacraid/aachba.c: In function 'aac_valid_context':
>> drivers/scsi/aacraid/aachba.c:342:29: error: 'FIB_CONTEXT_INTERNAL_CMD' undeclared (first use in this function); did you mean 'FIB_CONTEXT_FLAG_INTERNAL_CMD'?
342 | if (fibptr->flags & FIB_CONTEXT_INTERNAL_CMD)
| ^~~~~~~~~~~~~~~~~~~~~~~~
| FIB_CONTEXT_FLAG_INTERNAL_CMD
drivers/scsi/aacraid/aachba.c:342:29: note: each undeclared identifier is reported only once for each function it appears in
drivers/scsi/aacraid/aachba.c: In function '_aac_probe_container2':
drivers/scsi/aacraid/aachba.c:650:31: error: 'FIB_CONTEXT_INTERNAL_CMD' undeclared (first use in this function); did you mean 'FIB_CONTEXT_FLAG_INTERNAL_CMD'?
650 | if (!(fibptr->flags & FIB_CONTEXT_INTERNAL_CMD))
| ^~~~~~~~~~~~~~~~~~~~~~~~
| FIB_CONTEXT_FLAG_INTERNAL_CMD
drivers/scsi/aacraid/aachba.c: In function '_aac_probe_container1':
drivers/scsi/aacraid/aachba.c:720:30: error: 'FIB_CONTEXT_INTERNAL_CMD' undeclared (first use in this function); did you mean 'FIB_CONTEXT_FLAG_INTERNAL_CMD'?
720 | if ((fibptr->flags & FIB_CONTEXT_INTERNAL_CMD) &&
| ^~~~~~~~~~~~~~~~~~~~~~~~
| FIB_CONTEXT_FLAG_INTERNAL_CMD
drivers/scsi/aacraid/aachba.c: In function 'aac_probe_container':
drivers/scsi/aacraid/aachba.c:848:16: error: 'struct scsi_cmnd' has no member named 'scsi_done'
848 | scsicmd->scsi_done = aac_probe_container_scsi_done;
| ^~
vim +342 drivers/scsi/aacraid/aachba.c
323
324 static int aac_wwn = 1;
325 module_param_named(wwn, aac_wwn, int, S_IRUGO|S_IWUSR);
326 MODULE_PARM_DESC(wwn, "Select a WWN type for the arrays:\n"
327 "\t0 - Disable\n"
328 "\t1 - Array Meta Data Signature (default)\n"
329 "\t2 - Adapter Serial Number");
330
331
332 static inline int aac_valid_context(struct scsi_cmnd *scsicmd,
333 struct fib *fibptr) {
334 struct scsi_device *device;
335
336 if (unlikely(!scsicmd)) {
337 dprintk((KERN_WARNING "aac_valid_context: scsi command corrupt\n"));
338 aac_fib_complete(fibptr);
339 return 0;
340 }
341 fibptr->owner = AAC_OWNER_MIDLEVEL;
> 342 if (fibptr->flags & FIB_CONTEXT_INTERNAL_CMD)
343 return 1;
344 device = scsicmd->device;
345 if (unlikely(!device)) {
346 dprintk((KERN_WARNING "aac_valid_context: scsi device corrupt\n"));
347 aac_fib_complete(fibptr);
348 return 0;
349 }
350 return 1;
351 }
352
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
[morse:mpam/snapshot/v5.15 9/139] arch/x86/kernel/cpu/resctrl/core.c:400:6: warning: no previous prototype for function 'setup_default_ctrlval'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/snapshot/v5.15
head: ce3629841262f725a5f3a327403fcaf0e604a85e
commit: c40ac46dd98eac3ed1ab60d72d54344a4ead0e92 [9/139] x86/resctrl: Remove architecture copy of mbps_val
config: x86_64-buildonly-randconfig-r001-20211112 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c3dddeeafb529e769cde87bd29ef6271ac6bfa5c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/commit/?i...
git remote add morse https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git
git fetch --no-tags morse mpam/snapshot/v5.15
git checkout c40ac46dd98eac3ed1ab60d72d54344a4ead0e92
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/kernel/cpu/resctrl/core.c:400:6: warning: no previous prototype for function 'setup_default_ctrlval' [-Wmissing-prototypes]
void setup_default_ctrlval(struct rdt_resource *r, u32 *dc)
^
arch/x86/kernel/cpu/resctrl/core.c:400:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void setup_default_ctrlval(struct rdt_resource *r, u32 *dc)
^
static
arch/x86/kernel/cpu/resctrl/core.c:414:6: warning: no previous prototype for function 'domain_free' [-Wmissing-prototypes]
void domain_free(struct rdt_hw_domain *hw_dom)
^
arch/x86/kernel/cpu/resctrl/core.c:414:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void domain_free(struct rdt_hw_domain *hw_dom)
^
static
2 warnings generated.
vim +/setup_default_ctrlval +400 arch/x86/kernel/cpu/resctrl/core.c
399
> 400 void setup_default_ctrlval(struct rdt_resource *r, u32 *dc)
401 {
402 struct rdt_hw_resource *hw_res = resctrl_to_arch_res(r);
403 int i;
404
405 /*
406 * Initialize the Control MSRs to having no control.
407 * For Cache Allocation: Set all bits in cbm
408 * For Memory Allocation: Set b/w requested to 100%
409 */
410 for (i = 0; i < hw_res->num_closid; i++, dc++)
411 *dc = r->default_ctrl;
412 }
413
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
[android-common:android13-5.15 6/8] kernel/sched/core.c:2308:12: warning: no previous prototype for function '__migrate_task'
by kernel test robot
tree: https://android.googlesource.com/kernel/common android13-5.15
head: 81a0b5826138b3314eea90bcec18f5822b0a3575
commit: ca2177d4a03ddc4e6b64e54e0e7a176e282b4e18 [6/8] ANDROID: sched: allow access to critical common code for CPU Pause
config: i386-buildonly-randconfig-r004-20211110 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 63ef0e17e28827eae53133b3467bdac7d9729318)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add android-common https://android.googlesource.com/kernel/common
git fetch --no-tags android-common android13-5.15
git checkout ca2177d4a03ddc4e6b64e54e0e7a176e282b4e18
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> kernel/sched/core.c:2308:12: warning: no previous prototype for function '__migrate_task' [-Wmissing-prototypes]
struct rq *__migrate_task(struct rq *rq, struct rq_flags *rf,
^
kernel/sched/core.c:2308:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct rq *__migrate_task(struct rq *rq, struct rq_flags *rf,
^
static
kernel/sched/core.c:3459:6: warning: no previous prototype for function 'sched_set_stop_task' [-Wmissing-prototypes]
void sched_set_stop_task(int cpu, struct task_struct *stop)
^
kernel/sched/core.c:3459:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void sched_set_stop_task(int cpu, struct task_struct *stop)
^
static
2 warnings generated.
vim +/__migrate_task +2308 kernel/sched/core.c
2298
2299 /*
2300 * Move (not current) task off this CPU, onto the destination CPU. We're doing
2301 * this because either it can't run here any more (set_cpus_allowed()
2302 * away from this CPU, or CPU going down), or because we're
2303 * attempting to rebalance this task on exec (sched_exec).
2304 *
2305 * So we race with normal scheduler movements, but that's OK, as long
2306 * as the task is no longer on this CPU.
2307 */
> 2308 struct rq *__migrate_task(struct rq *rq, struct rq_flags *rf,
2309 struct task_struct *p, int dest_cpu)
2310 {
2311 /* Affinity changed (again). */
2312 if (!is_cpu_allowed(p, dest_cpu))
2313 return rq;
2314
2315 update_rq_clock(rq);
2316 rq = move_queued_task(rq, rf, p, dest_cpu);
2317
2318 return rq;
2319 }
2320 EXPORT_SYMBOL_GPL(__migrate_task);
2321
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
[morse:mpam/snapshot/v5.15 90/139] include/linux/cacheinfo.h:115:24: error: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '18446744073709551615' to '4294967295'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/snapshot/v5.15
head: ce3629841262f725a5f3a327403fcaf0e604a85e
commit: 7cfc8ff4c2167d8b7da45a3a5f7f7f98de31bcde [90/139] cacheinfo: Allow for >32-bit cache 'id'
config: m68k-allyesconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/commit/?i...
git remote add morse https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git
git fetch --no-tags morse mpam/snapshot/v5.15
git checkout 7cfc8ff4c2167d8b7da45a3a5f7f7f98de31bcde
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/base/cacheinfo.c:12:
include/linux/cacheinfo.h: In function 'get_cpu_cacheinfo_id':
>> include/linux/cacheinfo.h:115:24: error: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '18446744073709551615' to '4294967295' [-Werror=overflow]
115 | return ~0ULL;
| ^
include/linux/cacheinfo.h:121:32: error: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '18446744073709551615' to '4294967295' [-Werror=overflow]
121 | return ~0ULL;
| ^
include/linux/cacheinfo.h:125:16: error: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '18446744073709551615' to '4294967295' [-Werror=overflow]
125 | return ~0ULL;
| ^
cc1: all warnings being treated as errors
vim +115 include/linux/cacheinfo.h
104
105 /*
106 * Get the id of the cache associated with @cpu at level @level.
107 * cpuhp lock must be held.
108 */
109 static inline unsigned long get_cpu_cacheinfo_id(int cpu, int level)
110 {
111 struct cpu_cacheinfo *ci = get_cpu_cacheinfo(cpu);
112 int i;
113
114 if (!ci->info_list)
> 115 return ~0ULL;
116
117 for (i = 0; i < ci->num_leaves; i++) {
118 if (ci->info_list[i].level == level) {
119 if (ci->info_list[i].attributes & CACHE_ID)
120 return ci->info_list[i].id;
121 return ~0ULL;
122 }
123 }
124
125 return ~0ULL;
126 }
127
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
[xilinx-xlnx:release-2020.2.2_k26 128/241] include/linux/typecheck.h:12:18: warning: comparison of distinct pointer types lacks a cast
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx release-2020.2.2_k26
head: 4731ff5042ce76fc145bc2797faa2d91b090675e
commit: e966fbb13383eec0f1d1ab444b248bd0653d2c05 [128/241] net: xilinx: axiethernet: Add check for transmit data FIFO vacancy
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/Xilinx/linux-xlnx/commit/e966fbb13383eec0f1d1ab444b248...
git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xilinx-xlnx release-2020.2.2_k26
git checkout e966fbb13383eec0f1d1ab444b248bd0653d2c05
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/block/ drivers/infiniband/hw/qib/ drivers/infiniband/ulp/opa_vnic/ drivers/net/ drivers/staging/gasket/ drivers/xen/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/kernel.h:14,
from include/linux/clk.h:13,
from drivers/net/ethernet/xilinx/xilinx_axienet_main.c:25:
drivers/net/ethernet/xilinx/xilinx_axienet_main.c: In function 'axienet_create_tsheader':
>> include/linux/typecheck.h:12:18: warning: comparison of distinct pointer types lacks a cast
12 | (void)(&__dummy == &__dummy2); \
| ^~
include/linux/spinlock.h:249:3: note: in expansion of macro 'typecheck'
249 | typecheck(unsigned long, flags); \
| ^~~~~~~~~
include/linux/spinlock.h:368:2: note: in expansion of macro 'raw_spin_lock_irqsave'
368 | raw_spin_lock_irqsave(spinlock_check(lock), flags); \
| ^~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1058:3: note: in expansion of macro 'spin_lock_irqsave'
1058 | spin_lock_irqsave(&lp->ptp_tx_lock, flags);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/xilinx/xilinx_axienet_main.c: In function 'axienet_queue_xmit':
drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1253:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
1253 | const struct ethhdr *eth;
| ^~~~~
vim +12 include/linux/typecheck.h
e0deaff470900a Andrew Morton 2008-07-25 4
e0deaff470900a Andrew Morton 2008-07-25 5 /*
e0deaff470900a Andrew Morton 2008-07-25 6 * Check at compile time that something is of a particular type.
e0deaff470900a Andrew Morton 2008-07-25 7 * Always evaluates to 1 so you may use it easily in comparisons.
e0deaff470900a Andrew Morton 2008-07-25 8 */
e0deaff470900a Andrew Morton 2008-07-25 9 #define typecheck(type,x) \
e0deaff470900a Andrew Morton 2008-07-25 10 ({ type __dummy; \
e0deaff470900a Andrew Morton 2008-07-25 11 typeof(x) __dummy2; \
e0deaff470900a Andrew Morton 2008-07-25 @12 (void)(&__dummy == &__dummy2); \
e0deaff470900a Andrew Morton 2008-07-25 13 1; \
e0deaff470900a Andrew Morton 2008-07-25 14 })
e0deaff470900a Andrew Morton 2008-07-25 15
:::::: The code at line 12 was first introduced by commit
:::::: e0deaff470900a4c3222ca7139f6c9639e26a2f5 split the typecheck macros out of include/linux/kernel.h
:::::: TO: Andrew Morton <akpm(a)linux-foundation.org>
:::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
Re: [PATCH memcg v4] memcg: prohibit unconditional exceeding the limit of dying tasks
by kernel test robot
Hi Vasily,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.15-rc6]
[cannot apply to hnaz-mm/master next-20211112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vasily-Averin/memcg-prohibit-unc...
base: DEBUG invalid remote for branch v5.15-rc6 519d81956ee277b4419c723adfb154603c2565ba
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/fd30aeb6287dfe68bcf02c4d9634e342d...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vasily-Averin/memcg-prohibit-unconditional-exceeding-the-limit-of-dying-tasks/20211020-160835
git checkout fd30aeb6287dfe68bcf02c4d9634e342d6743d90
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
mm/memcontrol.c:4088:21: sparse: sparse: incompatible types in comparison expression (different address spaces):
mm/memcontrol.c:4088:21: sparse: struct mem_cgroup_threshold_ary [noderef] __rcu *
mm/memcontrol.c:4088:21: sparse: struct mem_cgroup_threshold_ary *
mm/memcontrol.c:4090:21: sparse: sparse: incompatible types in comparison expression (different address spaces):
mm/memcontrol.c:4090:21: sparse: struct mem_cgroup_threshold_ary [noderef] __rcu *
mm/memcontrol.c:4090:21: sparse: struct mem_cgroup_threshold_ary *
mm/memcontrol.c:4246:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
mm/memcontrol.c:4246:9: sparse: struct mem_cgroup_threshold_ary [noderef] __rcu *
mm/memcontrol.c:4246:9: sparse: struct mem_cgroup_threshold_ary *
mm/memcontrol.c:4340:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
mm/memcontrol.c:4340:9: sparse: struct mem_cgroup_threshold_ary [noderef] __rcu *
mm/memcontrol.c:4340:9: sparse: struct mem_cgroup_threshold_ary *
mm/memcontrol.c:5966:23: sparse: sparse: incompatible types in comparison expression (different address spaces):
mm/memcontrol.c:5966:23: sparse: struct task_struct [noderef] __rcu *
mm/memcontrol.c:5966:23: sparse: struct task_struct *
mm/memcontrol.c: note: in included file:
include/linux/memcontrol.h:752:9: sparse: sparse: context imbalance in 'lock_page_lruvec' - wrong count at exit
include/linux/memcontrol.h:752:9: sparse: sparse: context imbalance in 'lock_page_lruvec_irq' - wrong count at exit
include/linux/memcontrol.h:752:9: sparse: sparse: context imbalance in 'lock_page_lruvec_irqsave' - wrong count at exit
>> mm/memcontrol.c:1826:70: sparse: sparse: non size-preserving integer to pointer cast
mm/memcontrol.c:1987:6: sparse: sparse: context imbalance in 'lock_page_memcg' - wrong count at exit
mm/memcontrol.c:2036:17: sparse: sparse: context imbalance in '__unlock_page_memcg' - unexpected unlock
mm/memcontrol.c:5817:28: sparse: sparse: context imbalance in 'mem_cgroup_count_precharge_pte_range' - unexpected unlock
mm/memcontrol.c:6011:36: sparse: sparse: context imbalance in 'mem_cgroup_move_charge_pte_range' - unexpected unlock
vim +1826 mm/memcontrol.c
1765
1766 static enum oom_status mem_cgroup_oom(struct mem_cgroup *memcg, gfp_t mask, int order)
1767 {
1768 enum oom_status ret;
1769 bool locked;
1770
1771 if (order > PAGE_ALLOC_COSTLY_ORDER)
1772 return OOM_SKIPPED;
1773
1774 memcg_memory_event(memcg, MEMCG_OOM);
1775
1776 /*
1777 * We are in the middle of the charge context here, so we
1778 * don't want to block when potentially sitting on a callstack
1779 * that holds all kinds of filesystem and mm locks.
1780 *
1781 * cgroup1 allows disabling the OOM killer and waiting for outside
1782 * handling until the charge can succeed; remember the context and put
1783 * the task to sleep at the end of the page fault when all locks are
1784 * released.
1785 *
1786 * On the other hand, in-kernel OOM killer allows for an async victim
1787 * memory reclaim (oom_reaper) and that means that we are not solely
1788 * relying on the oom victim to make a forward progress and we can
1789 * invoke the oom killer here.
1790 *
1791 * Please note that mem_cgroup_out_of_memory might fail to find a
1792 * victim and then we have to bail out from the charge path.
1793 */
1794 if (memcg->oom_kill_disable) {
1795 if (!current->in_user_fault)
1796 return OOM_SKIPPED;
1797 css_get(&memcg->css);
1798 current->memcg_in_oom = memcg;
1799 current->memcg_oom_gfp_mask = mask;
1800 current->memcg_oom_order = order;
1801
1802 return OOM_ASYNC;
1803 }
1804
1805 mem_cgroup_mark_under_oom(memcg);
1806
1807 locked = mem_cgroup_oom_trylock(memcg);
1808
1809 if (locked)
1810 mem_cgroup_oom_notify(memcg);
1811
1812 mem_cgroup_unmark_under_oom(memcg);
1813 if (mem_cgroup_out_of_memory(memcg, mask, order)) {
1814 ret = OOM_SUCCESS;
1815 } else {
1816 ret = OOM_FAILED;
1817 /*
1818 * In some rare cases mem_cgroup_out_of_memory() can return false.
1819 * If it was called from #PF it forces handle_mm_fault()
1820 * return VM_FAULT_OOM and executes pagefault_out_of_memory().
1821 * memcg_in_oom is set here to notify pagefault_out_of_memory()
1822 * that it was a memcg-related failure and not allow to run
1823 * global OOM.
1824 */
1825 if (current->in_user_fault)
> 1826 current->memcg_in_oom = (struct mem_cgroup *)ret;
1827 }
1828 if (locked)
1829 mem_cgroup_oom_unlock(memcg);
1830
1831 return ret;
1832 }
1833
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
Re: [PATCH] mac80211: fix throughput LED trigger
by kernel test robot
Hi Felix,
I love your patch! Yet something to improve:
[auto build test ERROR on jberg-mac80211-next/master]
[also build test ERROR on jberg-mac80211/master v5.15 next-20211112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Felix-Fietkau/mac80211-fix-throu...
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/e7c97026e87b3302843d614f414335bef...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Felix-Fietkau/mac80211-fix-throughput-LED-trigger/20211112-185656
git checkout e7c97026e87b3302843d614f414335befbeab31e
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
net/mac80211/tx.c: In function '__ieee80211_tx':
>> net/mac80211/tx.c:1732:9: error: variable 'fc' set but not used [-Werror=unused-but-set-variable]
1732 | __le16 fc;
| ^~
cc1: all warnings being treated as errors
vim +/fc +1732 net/mac80211/tx.c
11127e9121d4dd9 Johannes Berg 2011-11-16 1719
11127e9121d4dd9 Johannes Berg 2011-11-16 1720 /*
11127e9121d4dd9 Johannes Berg 2011-11-16 1721 * Returns false if the frame couldn't be transmitted but was queued instead.
11127e9121d4dd9 Johannes Berg 2011-11-16 1722 */
11127e9121d4dd9 Johannes Berg 2011-11-16 1723 static bool __ieee80211_tx(struct ieee80211_local *local,
e7c97026e87b330 Felix Fietkau 2021-11-12 1724 struct sk_buff_head *skbs, struct sta_info *sta,
e7c97026e87b330 Felix Fietkau 2021-11-12 1725 bool txpending)
11127e9121d4dd9 Johannes Berg 2011-11-16 1726 {
11127e9121d4dd9 Johannes Berg 2011-11-16 1727 struct ieee80211_tx_info *info;
11127e9121d4dd9 Johannes Berg 2011-11-16 1728 struct ieee80211_sub_if_data *sdata;
11127e9121d4dd9 Johannes Berg 2011-11-16 1729 struct ieee80211_vif *vif;
11127e9121d4dd9 Johannes Berg 2011-11-16 1730 struct sk_buff *skb;
958574cbcc3ae31 Colin Ian King 2021-03-28 1731 bool result;
11127e9121d4dd9 Johannes Berg 2011-11-16 @1732 __le16 fc;
11127e9121d4dd9 Johannes Berg 2011-11-16 1733
11127e9121d4dd9 Johannes Berg 2011-11-16 1734 if (WARN_ON(skb_queue_empty(skbs)))
11127e9121d4dd9 Johannes Berg 2011-11-16 1735 return true;
11127e9121d4dd9 Johannes Berg 2011-11-16 1736
11127e9121d4dd9 Johannes Berg 2011-11-16 1737 skb = skb_peek(skbs);
11127e9121d4dd9 Johannes Berg 2011-11-16 1738 fc = ((struct ieee80211_hdr *)skb->data)->frame_control;
11127e9121d4dd9 Johannes Berg 2011-11-16 1739 info = IEEE80211_SKB_CB(skb);
5061b0c2b9066de Johannes Berg 2009-07-14 1740 sdata = vif_to_sdata(info->control.vif);
11127e9121d4dd9 Johannes Berg 2011-11-16 1741 if (sta && !sta->uploaded)
11127e9121d4dd9 Johannes Berg 2011-11-16 1742 sta = NULL;
11127e9121d4dd9 Johannes Berg 2011-11-16 1743
5061b0c2b9066de Johannes Berg 2009-07-14 1744 switch (sdata->vif.type) {
5061b0c2b9066de Johannes Berg 2009-07-14 1745 case NL80211_IFTYPE_MONITOR:
d82121845d44334 Aviya Erenfeld 2016-08-29 1746 if (sdata->u.mntr.flags & MONITOR_FLAG_ACTIVE) {
c82b5a74cc73938 Johannes Berg 2013-07-14 1747 vif = &sdata->vif;
c82b5a74cc73938 Johannes Berg 2013-07-14 1748 break;
c82b5a74cc73938 Johannes Berg 2013-07-14 1749 }
4b6f1dd6a6faf4e Johannes Berg 2012-04-03 1750 sdata = rcu_dereference(local->monitor_sdata);
3a25a8c8b75b430 Johannes Berg 2012-04-03 1751 if (sdata) {
4b6f1dd6a6faf4e Johannes Berg 2012-04-03 1752 vif = &sdata->vif;
3a25a8c8b75b430 Johannes Berg 2012-04-03 1753 info->hw_queue =
3a25a8c8b75b430 Johannes Berg 2012-04-03 1754 vif->hw_queue[skb_get_queue_mapping(skb)];
30686bf7f5b3c30 Johannes Berg 2015-06-02 1755 } else if (ieee80211_hw_check(&local->hw, QUEUE_CONTROL)) {
63b4d8b3736b831 Johannes Berg 2015-11-24 1756 ieee80211_purge_tx_queue(&local->hw, skbs);
3a25a8c8b75b430 Johannes Berg 2012-04-03 1757 return true;
3a25a8c8b75b430 Johannes Berg 2012-04-03 1758 } else
11127e9121d4dd9 Johannes Berg 2011-11-16 1759 vif = NULL;
5061b0c2b9066de Johannes Berg 2009-07-14 1760 break;
5061b0c2b9066de Johannes Berg 2009-07-14 1761 case NL80211_IFTYPE_AP_VLAN:
11127e9121d4dd9 Johannes Berg 2011-11-16 1762 sdata = container_of(sdata->bss,
11127e9121d4dd9 Johannes Berg 2011-11-16 1763 struct ieee80211_sub_if_data, u.ap);
fc0561dc6a9c616 Gustavo A. R. Silva 2020-07-07 1764 fallthrough;
5061b0c2b9066de Johannes Berg 2009-07-14 1765 default:
11127e9121d4dd9 Johannes Berg 2011-11-16 1766 vif = &sdata->vif;
5061b0c2b9066de Johannes Berg 2009-07-14 1767 break;
5061b0c2b9066de Johannes Berg 2009-07-14 1768 }
5061b0c2b9066de Johannes Berg 2009-07-14 1769
4fd0328d2f6314a Johannes Berg 2019-10-01 1770 result = ieee80211_tx_frags(local, vif, sta, skbs, txpending);
21f5fc75deca63b Luis R. Rodriguez 2009-07-24 1771
4db4e0a17fb0e7b Johannes Berg 2011-11-24 1772 WARN_ON_ONCE(!skb_queue_empty(skbs));
252b86c43225d06 Johannes Berg 2011-11-16 1773
11127e9121d4dd9 Johannes Berg 2011-11-16 1774 return result;
e2ebc74d7e3d716 Johannes Berg 2007-07-27 1775 }
e2ebc74d7e3d716 Johannes Berg 2007-07-27 1776
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
[omap-audio:peter/linux-next-wip 5558/6167] fs/io_uring.c:2335:40: error: variable 'prev' set but not used
by kernel test robot
tree: https://github.com/omap-audio/linux-audio peter/linux-next-wip
head: d08c31cfb65e8197b0ab607484d26fc48366dcee
commit: 593365467b869247ed6ee30c1ba92b553b4d5a3c [5558/6167] io_uring: use slist for completion batching
config: m68k-buildonly-randconfig-r003-20211002 (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/omap-audio/linux-audio/commit/593365467b869247ed6ee30c...
git remote add omap-audio https://github.com/omap-audio/linux-audio
git fetch --no-tags omap-audio peter/linux-next-wip
git checkout 593365467b869247ed6ee30c1ba92b553b4d5a3c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
fs/io_uring.c: In function 'io_queue_async_work':
fs/io_uring.c:1456:61: error: parameter 'locked' set but not used [-Werror=unused-but-set-parameter]
1456 | static void io_queue_async_work(struct io_kiocb *req, bool *locked)
| ~~~~~~^~~~~~
fs/io_uring.c: In function '__io_submit_flush_completions':
>> fs/io_uring.c:2335:40: error: variable 'prev' set but not used [-Werror=unused-but-set-variable]
2335 | struct io_wq_work_node *node, *prev;
| ^~~~
cc1: all warnings being treated as errors
vim +/prev +2335 fs/io_uring.c
2331
2332 static void __io_submit_flush_completions(struct io_ring_ctx *ctx)
2333 __must_hold(&ctx->uring_lock)
2334 {
> 2335 struct io_wq_work_node *node, *prev;
2336 struct io_submit_state *state = &ctx->submit_state;
2337 struct req_batch rb;
2338
2339 spin_lock(&ctx->completion_lock);
2340 wq_list_for_each(node, prev, &state->compl_reqs) {
2341 struct io_kiocb *req = container_of(node, struct io_kiocb,
2342 comp_list);
2343
2344 __io_cqring_fill_event(ctx, req->user_data, req->result,
2345 req->compl.cflags);
2346 }
2347 io_commit_cqring(ctx);
2348 spin_unlock(&ctx->completion_lock);
2349 io_cqring_ev_posted(ctx);
2350
2351 io_init_req_batch(&rb);
2352 node = state->compl_reqs.first;
2353 do {
2354 struct io_kiocb *req = container_of(node, struct io_kiocb,
2355 comp_list);
2356
2357 node = req->comp_list.next;
2358 if (req_ref_put_and_test(req))
2359 io_req_free_batch(&rb, req, &ctx->submit_state);
2360 } while (node);
2361
2362 io_req_free_batch_finish(ctx, &rb);
2363 INIT_WQ_LIST(&state->compl_reqs);
2364 }
2365
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week