[android-common:android-4.19-stable 14825/24059] drivers/clk/clk.c:624:24: warning: variable 'ignore' set but not used
by kernel test robot
tree: https://android.googlesource.com/kernel/common android-4.19-stable
head: 45c480b553c90178bf1cc30fd9054c75a31bf599
commit: 3179a1a38d96f565a2229b9244285c6abf62b10a [14825/24059] ANDROID: GKI: clk: Add support for voltage voting
config: i386-randconfig-r036-20210929 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add android-common https://android.googlesource.com/kernel/common
git fetch --no-tags android-common android-4.19-stable
git checkout 3179a1a38d96f565a2229b9244285c6abf62b10a
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/clk/clk.c: In function 'clk_update_vdd':
>> drivers/clk/clk.c:624:24: warning: variable 'ignore' set but not used [-Wunused-but-set-variable]
624 | int level, rc = 0, i, ignore;
| ^~~~~~
drivers/clk/clk.c: At top level:
>> drivers/clk/clk.c:3145:5: warning: no previous prototype for 'clk_set_flags' [-Wmissing-prototypes]
3145 | int clk_set_flags(struct clk *clk, unsigned long flags)
| ^~~~~~~~~~~~~
>> drivers/clk/clk.c:3157:6: warning: no previous prototype for 'clk_debug_print_hw' [-Wmissing-prototypes]
3157 | void clk_debug_print_hw(struct clk_core *clk, struct seq_file *f)
| ^~~~~~~~~~~~~~~~~~
drivers/clk/clk.c:4257: warning: Function parameter or member 'dev' not described in 'devm_clk_unregister'
drivers/clk/clk.c:4455: warning: Function parameter or member 'get_hw' not described in 'of_clk_provider'
vim +/ignore +624 drivers/clk/clk.c
618
619 /*
620 * Update voltage level given the current votes.
621 */
622 static int clk_update_vdd(struct clk_vdd_class *vdd_class)
623 {
> 624 int level, rc = 0, i, ignore;
625 struct regulator **r = vdd_class->regulator;
626 int *uv = vdd_class->vdd_uv;
627 int n_reg = vdd_class->num_regulators;
628 int cur_lvl = vdd_class->cur_level;
629 int max_lvl = vdd_class->num_levels - 1;
630 int cur_base = cur_lvl * n_reg;
631 int new_base;
632
633 /* aggregate votes */
634 for (level = max_lvl; level > 0; level--)
635 if (vdd_class->level_votes[level])
636 break;
637
638 if (level == cur_lvl)
639 return 0;
640
641 max_lvl = max_lvl * n_reg;
642 new_base = level * n_reg;
643
644 for (i = 0; i < vdd_class->num_regulators; i++) {
645 pr_debug("Set Voltage level Min %d, Max %d\n", uv[new_base + i],
646 uv[max_lvl + i]);
647 rc = regulator_set_voltage(r[i], uv[new_base + i], INT_MAX);
648 if (rc)
649 goto set_voltage_fail;
650
651 if (cur_lvl == 0 || cur_lvl == vdd_class->num_levels)
652 rc = regulator_enable(r[i]);
653 else if (level == 0)
654 rc = regulator_disable(r[i]);
655 if (rc)
656 goto enable_disable_fail;
657 }
658
659 if (vdd_class->set_vdd && !vdd_class->num_regulators)
660 rc = vdd_class->set_vdd(vdd_class, level);
661
662 if (!rc)
663 vdd_class->cur_level = level;
664
665 return rc;
666
667 enable_disable_fail:
668 regulator_set_voltage(r[i], uv[cur_base + i], INT_MAX);
669
670 set_voltage_fail:
671 for (i--; i >= 0; i--) {
672 regulator_set_voltage(r[i], uv[cur_base + i], INT_MAX);
673 if (cur_lvl == 0 || cur_lvl == vdd_class->num_levels)
674 regulator_disable(r[i]);
675 else if (level == 0)
676 ignore = regulator_enable(r[i]);
677 }
678
679 return rc;
680 }
681
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
Re: [RFC PATCH v3 2/2] KVM: s390: Extend the USER_SIGP capability
by kernel test robot
Hi Eric,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on kvms390/next]
[also build test ERROR on kvm/queue mst-vhost/linux-next v5.15]
[cannot apply to next-20211112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Eric-Farman/s390x-Improvements-t...
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git next
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/33d624410d4c044eae0849494466c6084...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Eric-Farman/s390x-Improvements-to-SIGP-handling-KVM/20211111-043552
git checkout 33d624410d4c044eae0849494466c608432cd117
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/s390/kvm/kvm-s390.c:49:
arch/s390/kvm/kvm-s390.h: In function 'kvm_s390_vcpu_set_sigp_busy':
>> arch/s390/kvm/kvm-s390.h:93:71: error: '?:' using integer constants in boolean context [-Werror=int-in-bool-context]
93 | return (atomic_cmpxchg(&vcpu->arch.sigp_busy, 0, 1) == 0) ? 0 : -EBUSY;
cc1: all warnings being treated as errors
vim +93 arch/s390/kvm/kvm-s390.h
89
90 static inline bool kvm_s390_vcpu_set_sigp_busy(struct kvm_vcpu *vcpu)
91 {
92 /* Return zero for success, or -EBUSY if another vcpu won */
> 93 return (atomic_cmpxchg(&vcpu->arch.sigp_busy, 0, 1) == 0) ? 0 : -EBUSY;
94 }
95
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
Re: [PATCH] ath11k: Check supported hardware version
by kernel test robot
Hi Seevalamuthu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on kvalo-ath/ath-next]
[also build test ERROR on v5.15 next-20211112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Seevalamuthu-Mariappan/ath11k-Ch...
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1675576a1f451a316314c6ae5b92e5e62...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Seevalamuthu-Mariappan/ath11k-Check-supported-hardware-version/20211112-150408
git checkout 1675576a1f451a316314c6ae5b92e5e6298ed61b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/net/wireless/ath/ath11k/core.c:11:
>> drivers/net/wireless/ath/ath11k/core.h:924:18: error: 'ath11k_hw_version' defined but not used [-Werror=unused-const-variable=]
924 | static const u32 ath11k_hw_version[] = {
| ^~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/ath11k_hw_version +924 drivers/net/wireless/ath/ath11k/core.h
923
> 924 static const u32 ath11k_hw_version[] = {
925 [ATH11K_HW_IPQ8074] = ATH11K_HW_VERSION_HW20,
926 [ATH11K_HW_QCA6390_HW20] = ATH11K_HW_VERSION_HW20,
927 [ATH11K_HW_IPQ6018_HW10] = ATH11K_HW_VERSION_HW10,
928 [ATH11K_HW_QCN9074_HW10] = ATH11K_HW_VERSION_HW10,
929 [ATH11K_HW_WCN6855_HW20] = ATH11K_HW_VERSION_HW20,
930 };
931
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
drivers/soc/sifive/sifive_l2_cache.c:235 sifive_l2_init() warn: 'l2_base' not released on lines: 215.
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: debe436e77c72fcee804fb867f275e6d31aa999c
commit: 507308b8ccc90d37b07bfca8ffe130435d6b354f RISC-V: sifive_l2_cache: Update L2 cache driver to support SiFive FU740
config: riscv-randconfig-m031-20211103 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/soc/sifive/sifive_l2_cache.c:235 sifive_l2_init() warn: 'l2_base' not released on lines: 215.
vim +/l2_base +235 drivers/soc/sifive/sifive_l2_cache.c
bf6df5dd25b744 arch/riscv/mm/sifive_l2_cache.c Paul Walmsley 2019-10-17 195 static int __init sifive_l2_init(void)
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 196 {
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 197 struct device_node *np;
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 198 struct resource res;
507308b8ccc90d drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 199 int i, rc, intr_num;
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 200
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 201 np = of_find_matching_node(NULL, sifive_l2_ids);
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 202 if (!np)
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 203 return -ENODEV;
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 204
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 205 if (of_address_to_resource(np, 0, &res))
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 206 return -ENODEV;
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 207
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 208 l2_base = ioremap(res.start, resource_size(&res));
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 209 if (!l2_base)
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 210 return -ENOMEM;
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 211
507308b8ccc90d drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 212 intr_num = of_property_count_u32_elems(np, "interrupts");
507308b8ccc90d drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 213 if (!intr_num) {
507308b8ccc90d drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 214 pr_err("L2CACHE: no interrupts property\n");
507308b8ccc90d drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 215 return -ENODEV;
l2_base not unmapped.
507308b8ccc90d drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 216 }
507308b8ccc90d drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 217
507308b8ccc90d drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-12-10 218 for (i = 0; i < intr_num; i++) {
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 219 g_irq[i] = irq_of_parse_and_map(np, i);
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 220 rc = request_irq(g_irq[i], l2_int_handler, 0, "l2_ecc", NULL);
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 221 if (rc) {
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 222 pr_err("L2CACHE: Could not request IRQ %d\n", g_irq[i]);
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 223 return rc;
No clean up.
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 224 }
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 225 }
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 226
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 227 l2_config_read();
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 228
4a3a37331248d8 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-02-20 229 l2_cache_ops.get_priv_group = l2_get_priv_group;
4a3a37331248d8 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-02-20 230 riscv_set_cacheinfo_ops(&l2_cache_ops);
4a3a37331248d8 drivers/soc/sifive/sifive_l2_cache.c Yash Shah 2020-02-20 231
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 232 #ifdef CONFIG_DEBUG_FS
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 233 setup_sifive_debug();
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 234 #endif
a967a289f16969 arch/riscv/mm/sifive_l2_cache.c Yash Shah 2019-05-06 @235 return 0;
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
[atishp04:sbi_pmu_v4 5/12] drivers/perf/riscv_pmu_legacy.c:76: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
by kernel test robot
tree: https://github.com/atishp04/linux sbi_pmu_v4
head: 6a25ebd83e4ca355a7771107a6a03bbe82435b67
commit: b7bb90cae101f5876d28d7e169257fec4526bf25 [5/12] RISC-V: Add a simple platform driver for RISC-V legacy perf
config: riscv-randconfig-c004-20211025 (attached as .config)
compiler: riscv32-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/atishp04/linux/commit/b7bb90cae101f5876d28d7e169257fec...
git remote add atishp04 https://github.com/atishp04/linux
git fetch --no-tags atishp04 sbi_pmu_v4
git checkout b7bb90cae101f5876d28d7e169257fec4526bf25
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/perf/riscv_pmu_legacy.c:76: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* This is just a simple implementation to allow legacy implementations
vim +76 drivers/perf/riscv_pmu_legacy.c
74
75 /**
> 76 * This is just a simple implementation to allow legacy implementations
77 * compatible with new RISC-V PMU driver framework.
78 * This driver only allows reading two counters i.e CYCLE & INSTRET.
79 * However, it can not start or stop the counter. Thus, it is not very useful
80 * will be removed in future.
81 */
82 static void pmu_legacy_init(struct riscv_pmu *pmu)
83 {
84 pr_info("Legacy PMU implementation is available\n");
85
86 pmu->num_counters = RISCV_PMU_LEGACY_NUM_CTR;
87 pmu->ctr_start = pmu_legacy_ctr_start;
88 pmu->ctr_stop = NULL;
89 pmu->event_map = pmu_legacy_event_map;
90 pmu->ctr_get_idx = pmu_legacy_ctr_get_idx;
91 pmu->ctr_get_width = NULL;
92 pmu->ctr_clear_idx = NULL;
93 pmu->ctr_read = pmu_legacy_read_ctr;
94
95 perf_pmu_register(&pmu->pmu, "cpu", PERF_TYPE_RAW);
96 }
97
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
powerpc-linux-ld: warning: orphan section `.ftrace.tramp' from `drivers/mfd/rsmu_core.o' being placed in section `.ftrace.tramp'
by kernel test robot
Hi Min,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5833291ab6de9c3e2374336b51c814e515e8f3a5
commit: a1867f85e06edacd82956d3422caa2b9074f4321 mfd: Add Renesas Synchronization Management Unit (SMU) support
date: 4 months ago
config: powerpc-randconfig-c024-20211012 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout a1867f85e06edacd82956d3422caa2b9074f4321
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
powerpc-linux-ld: warning: orphan section `.init.plt' from `drivers/mfd/rsmu_core.o' being placed in section `.init.plt'
>> powerpc-linux-ld: warning: orphan section `.ftrace.tramp' from `drivers/mfd/rsmu_core.o' being placed in section `.ftrace.tramp'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_set_suspend':
(.text+0x424): undefined reference to `fb_set_suspend'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_resume_worker':
drm_fb_helper.c:(.text+0x4b0): undefined reference to `fb_set_suspend'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_unregister_fbi':
(.text+0x818): undefined reference to `unregister_framebuffer'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_fini':
(.text+0x9b8): undefined reference to `fb_dealloc_cmap'
powerpc-linux-ld: (.text+0x9d8): undefined reference to `framebuffer_release'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_sys_read':
(.text+0xbe8): undefined reference to `fb_sys_read'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_alloc_fbi':
(.text+0x34f8): undefined reference to `framebuffer_alloc'
powerpc-linux-ld: (.text+0x3554): undefined reference to `fb_alloc_cmap'
powerpc-linux-ld: (.text+0x3618): undefined reference to `fb_dealloc_cmap'
powerpc-linux-ld: (.text+0x3674): undefined reference to `framebuffer_release'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `__drm_fb_helper_initial_config_and_unlock':
drm_fb_helper.c:(.text+0x37b0): undefined reference to `register_framebuffer'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_set_suspend_unlocked':
(.text+0x4518): undefined reference to `fb_set_suspend'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_generic_probe':
drm_fb_helper.c:(.text+0x58f8): undefined reference to `fb_deferred_io_init'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_sys_write':
(.text+0x644c): undefined reference to `fb_sys_write'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_sys_fillrect':
(.text+0x6534): undefined reference to `sys_fillrect'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_sys_copyarea':
(.text+0x65b4): undefined reference to `sys_copyarea'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_sys_imageblit':
(.text+0x6634): undefined reference to `sys_imageblit'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_cfb_fillrect':
(.text+0x66b4): undefined reference to `cfb_fillrect'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_cfb_copyarea':
(.text+0x6734): undefined reference to `cfb_copyarea'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_cfb_imageblit':
(.text+0x67b4): undefined reference to `cfb_imageblit'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fbdev_fb_imageblit':
drm_fb_helper.c:(.text+0x6c30): undefined reference to `cfb_imageblit'
powerpc-linux-ld: drm_fb_helper.c:(.text+0x6c58): undefined reference to `sys_imageblit'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fbdev_fb_copyarea':
drm_fb_helper.c:(.text+0x6d30): undefined reference to `cfb_copyarea'
powerpc-linux-ld: drm_fb_helper.c:(.text+0x6d58): undefined reference to `sys_copyarea'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fbdev_fb_fillrect':
drm_fb_helper.c:(.text+0x6e30): undefined reference to `cfb_fillrect'
powerpc-linux-ld: drm_fb_helper.c:(.text+0x6e58): undefined reference to `sys_fillrect'
powerpc-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fbdev_cleanup':
drm_fb_helper.c:(.text+0x734c): undefined reference to `fb_deferred_io_cleanup'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
drivers/firmware/arm_scmi/voltage.c:159:42: sparse: sparse: incorrect type in assignment (different base types)
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5833291ab6de9c3e2374336b51c814e515e8f3a5
commit: 2add5cacff3531e54c50b0832128299faa9f0563 firmware: arm_scmi: Add voltage domain management protocol support
date: 12 months ago
config: riscv-randconfig-s032-20211109 (attached as .config)
compiler: riscv32-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 2add5cacff3531e54c50b0832128299faa9f0563
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/firmware/arm_scmi/voltage.c:159:42: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] level_index @@ got unsigned int [usertype] desc_index @@
drivers/firmware/arm_scmi/voltage.c:159:42: sparse: expected restricted __le32 [usertype] level_index
drivers/firmware/arm_scmi/voltage.c:159:42: sparse: got unsigned int [usertype] desc_index
vim +159 drivers/firmware/arm_scmi/voltage.c
111
112 static int scmi_voltage_descriptors_get(const struct scmi_handle *handle,
113 struct voltage_info *vinfo)
114 {
115 int ret, dom;
116 struct scmi_xfer *td, *tl;
117 struct device *dev = handle->dev;
118 struct scmi_msg_resp_domain_attributes *resp_dom;
119 struct scmi_msg_resp_describe_levels *resp_levels;
120
121 ret = scmi_xfer_get_init(handle, VOLTAGE_DOMAIN_ATTRIBUTES,
122 SCMI_PROTOCOL_VOLTAGE, sizeof(__le32),
123 sizeof(*resp_dom), &td);
124 if (ret)
125 return ret;
126 resp_dom = td->rx.buf;
127
128 ret = scmi_xfer_get_init(handle, VOLTAGE_DESCRIBE_LEVELS,
129 SCMI_PROTOCOL_VOLTAGE, sizeof(__le64), 0, &tl);
130 if (ret)
131 goto outd;
132 resp_levels = tl->rx.buf;
133
134 for (dom = 0; dom < vinfo->num_domains; dom++) {
135 u32 desc_index = 0;
136 u16 num_returned = 0, num_remaining = 0;
137 struct scmi_msg_cmd_describe_levels *cmd;
138 struct scmi_voltage_info *v;
139
140 /* Retrieve domain attributes at first ... */
141 put_unaligned_le32(dom, td->tx.buf);
142 ret = scmi_do_xfer(handle, td);
143 /* Skip domain on comms error */
144 if (ret)
145 continue;
146
147 v = vinfo->domains + dom;
148 v->id = dom;
149 v->attributes = le32_to_cpu(resp_dom->attr);
150 strlcpy(v->name, resp_dom->name, SCMI_MAX_STR_SIZE);
151
152 cmd = tl->tx.buf;
153 /* ...then retrieve domain levels descriptions */
154 do {
155 u32 flags;
156 int cnt;
157
158 cmd->domain_id = cpu_to_le32(v->id);
> 159 cmd->level_index = desc_index;
160 ret = scmi_do_xfer(handle, tl);
161 if (ret)
162 break;
163
164 flags = le32_to_cpu(resp_levels->flags);
165 num_returned = NUM_RETURNED_LEVELS(flags);
166 num_remaining = NUM_REMAINING_LEVELS(flags);
167
168 /* Allocate space for num_levels if not already done */
169 if (!v->num_levels) {
170 ret = scmi_init_voltage_levels(dev, v,
171 num_returned,
172 num_remaining,
173 SUPPORTS_SEGMENTED_LEVELS(flags));
174 if (ret)
175 break;
176 }
177
178 if (desc_index + num_returned > v->num_levels) {
179 dev_err(handle->dev,
180 "No. of voltage levels can't exceed %d\n",
181 v->num_levels);
182 ret = -EINVAL;
183 break;
184 }
185
186 for (cnt = 0; cnt < num_returned; cnt++) {
187 s32 val;
188
189 val =
190 (s32)le32_to_cpu(resp_levels->voltage[cnt]);
191 v->levels_uv[desc_index + cnt] = val;
192 if (val < 0)
193 v->negative_volts_allowed = true;
194 }
195
196 desc_index += num_returned;
197
198 scmi_reset_rx_to_maxsz(handle, tl);
199 /* check both to avoid infinite loop due to buggy fw */
200 } while (num_returned && num_remaining);
201
202 if (ret) {
203 v->num_levels = 0;
204 devm_kfree(dev, v->levels_uv);
205 }
206
207 scmi_reset_rx_to_maxsz(handle, td);
208 }
209
210 scmi_xfer_put(handle, tl);
211 outd:
212 scmi_xfer_put(handle, td);
213
214 return ret;
215 }
216
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
Re: [PATCH net-next 1/3] net: add new socket option SO_RESERVE_MEM
by kernel test robot
Hi Wei,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
[also build test ERROR on horms-ipvs/master v5.15]
[cannot apply to net-next/master linus/master next-20211112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Wei-Wang/net-add-new-socket-opti...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git f936bb42aeb94a069bec7c9e04100d199c372956
config: mips-loongson2k_defconfig (attached as .config)
compiler: mips64el-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/e60de1697822b3d6384c6bc620d7048c0...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Wei-Wang/net-add-new-socket-option-SO_RESERVE_MEM/20210929-124516
git checkout e60de1697822b3d6384c6bc620d7048c05fca819
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash net/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
net/core/sock.c: In function 'sock_setsockopt':
>> net/core/sock.c:1417:14: error: 'SO_RESERVE_MEM' undeclared (first use in this function)
1417 | case SO_RESERVE_MEM:
| ^~~~~~~~~~~~~~
net/core/sock.c:1417:14: note: each undeclared identifier is reported only once for each function it appears in
net/core/sock.c: In function 'sock_getsockopt':
net/core/sock.c:1800:14: error: 'SO_RESERVE_MEM' undeclared (first use in this function)
1800 | case SO_RESERVE_MEM:
| ^~~~~~~~~~~~~~
vim +/SO_RESERVE_MEM +1417 net/core/sock.c
1330
1331 case SO_MAX_PACING_RATE:
1332 {
1333 unsigned long ulval = (val == ~0U) ? ~0UL : (unsigned int)val;
1334
1335 if (sizeof(ulval) != sizeof(val) &&
1336 optlen >= sizeof(ulval) &&
1337 copy_from_sockptr(&ulval, optval, sizeof(ulval))) {
1338 ret = -EFAULT;
1339 break;
1340 }
1341 if (ulval != ~0UL)
1342 cmpxchg(&sk->sk_pacing_status,
1343 SK_PACING_NONE,
1344 SK_PACING_NEEDED);
1345 sk->sk_max_pacing_rate = ulval;
1346 sk->sk_pacing_rate = min(sk->sk_pacing_rate, ulval);
1347 break;
1348 }
1349 case SO_INCOMING_CPU:
1350 WRITE_ONCE(sk->sk_incoming_cpu, val);
1351 break;
1352
1353 case SO_CNX_ADVICE:
1354 if (val == 1)
1355 dst_negative_advice(sk);
1356 break;
1357
1358 case SO_ZEROCOPY:
1359 if (sk->sk_family == PF_INET || sk->sk_family == PF_INET6) {
1360 if (!((sk->sk_type == SOCK_STREAM &&
1361 sk->sk_protocol == IPPROTO_TCP) ||
1362 (sk->sk_type == SOCK_DGRAM &&
1363 sk->sk_protocol == IPPROTO_UDP)))
1364 ret = -ENOTSUPP;
1365 } else if (sk->sk_family != PF_RDS) {
1366 ret = -ENOTSUPP;
1367 }
1368 if (!ret) {
1369 if (val < 0 || val > 1)
1370 ret = -EINVAL;
1371 else
1372 sock_valbool_flag(sk, SOCK_ZEROCOPY, valbool);
1373 }
1374 break;
1375
1376 case SO_TXTIME:
1377 if (optlen != sizeof(struct sock_txtime)) {
1378 ret = -EINVAL;
1379 break;
1380 } else if (copy_from_sockptr(&sk_txtime, optval,
1381 sizeof(struct sock_txtime))) {
1382 ret = -EFAULT;
1383 break;
1384 } else if (sk_txtime.flags & ~SOF_TXTIME_FLAGS_MASK) {
1385 ret = -EINVAL;
1386 break;
1387 }
1388 /* CLOCK_MONOTONIC is only used by sch_fq, and this packet
1389 * scheduler has enough safe guards.
1390 */
1391 if (sk_txtime.clockid != CLOCK_MONOTONIC &&
1392 !ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN)) {
1393 ret = -EPERM;
1394 break;
1395 }
1396 sock_valbool_flag(sk, SOCK_TXTIME, true);
1397 sk->sk_clockid = sk_txtime.clockid;
1398 sk->sk_txtime_deadline_mode =
1399 !!(sk_txtime.flags & SOF_TXTIME_DEADLINE_MODE);
1400 sk->sk_txtime_report_errors =
1401 !!(sk_txtime.flags & SOF_TXTIME_REPORT_ERRORS);
1402 break;
1403
1404 case SO_BINDTOIFINDEX:
1405 ret = sock_bindtoindex_locked(sk, val);
1406 break;
1407
1408 case SO_BUF_LOCK:
1409 if (val & ~SOCK_BUF_LOCK_MASK) {
1410 ret = -EINVAL;
1411 break;
1412 }
1413 sk->sk_userlocks = val | (sk->sk_userlocks &
1414 ~SOCK_BUF_LOCK_MASK);
1415 break;
1416
> 1417 case SO_RESERVE_MEM:
1418 {
1419 int delta;
1420
1421 if (val < 0) {
1422 ret = -EINVAL;
1423 break;
1424 }
1425
1426 delta = val - sk->sk_reserved_mem;
1427 if (delta < 0)
1428 sock_release_reserved_memory(sk, -delta);
1429 else
1430 ret = sock_reserve_memory(sk, delta);
1431 break;
1432 }
1433
1434 default:
1435 ret = -ENOPROTOOPT;
1436 break;
1437 }
1438 release_sock(sk);
1439 return ret;
1440 }
1441 EXPORT_SYMBOL(sock_setsockopt);
1442
1443
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
Re: [PATCH] mac80211: fix throughput LED trigger
by kernel test robot
Hi Felix,
I love your patch! Perhaps something to improve:
[auto build test WARNING on jberg-mac80211-next/master]
[also build test WARNING on v5.15 next-20211112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Felix-Fietkau/mac80211-fix-throu...
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: i386-defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/e7c97026e87b3302843d614f414335bef...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Felix-Fietkau/mac80211-fix-throughput-LED-trigger/20211112-185656
git checkout e7c97026e87b3302843d614f414335befbeab31e
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
net/mac80211/tx.c: In function '__ieee80211_tx':
>> net/mac80211/tx.c:1732:9: warning: variable 'fc' set but not used [-Wunused-but-set-variable]
1732 | __le16 fc;
| ^~
vim +/fc +1732 net/mac80211/tx.c
11127e9121d4dd Johannes Berg 2011-11-16 1719
11127e9121d4dd Johannes Berg 2011-11-16 1720 /*
11127e9121d4dd Johannes Berg 2011-11-16 1721 * Returns false if the frame couldn't be transmitted but was queued instead.
11127e9121d4dd Johannes Berg 2011-11-16 1722 */
11127e9121d4dd Johannes Berg 2011-11-16 1723 static bool __ieee80211_tx(struct ieee80211_local *local,
e7c97026e87b33 Felix Fietkau 2021-11-12 1724 struct sk_buff_head *skbs, struct sta_info *sta,
e7c97026e87b33 Felix Fietkau 2021-11-12 1725 bool txpending)
11127e9121d4dd Johannes Berg 2011-11-16 1726 {
11127e9121d4dd Johannes Berg 2011-11-16 1727 struct ieee80211_tx_info *info;
11127e9121d4dd Johannes Berg 2011-11-16 1728 struct ieee80211_sub_if_data *sdata;
11127e9121d4dd Johannes Berg 2011-11-16 1729 struct ieee80211_vif *vif;
11127e9121d4dd Johannes Berg 2011-11-16 1730 struct sk_buff *skb;
958574cbcc3ae3 Colin Ian King 2021-03-28 1731 bool result;
11127e9121d4dd Johannes Berg 2011-11-16 @1732 __le16 fc;
11127e9121d4dd Johannes Berg 2011-11-16 1733
11127e9121d4dd Johannes Berg 2011-11-16 1734 if (WARN_ON(skb_queue_empty(skbs)))
11127e9121d4dd Johannes Berg 2011-11-16 1735 return true;
11127e9121d4dd Johannes Berg 2011-11-16 1736
11127e9121d4dd Johannes Berg 2011-11-16 1737 skb = skb_peek(skbs);
11127e9121d4dd Johannes Berg 2011-11-16 1738 fc = ((struct ieee80211_hdr *)skb->data)->frame_control;
11127e9121d4dd Johannes Berg 2011-11-16 1739 info = IEEE80211_SKB_CB(skb);
5061b0c2b9066d Johannes Berg 2009-07-14 1740 sdata = vif_to_sdata(info->control.vif);
11127e9121d4dd Johannes Berg 2011-11-16 1741 if (sta && !sta->uploaded)
11127e9121d4dd Johannes Berg 2011-11-16 1742 sta = NULL;
11127e9121d4dd Johannes Berg 2011-11-16 1743
5061b0c2b9066d Johannes Berg 2009-07-14 1744 switch (sdata->vif.type) {
5061b0c2b9066d Johannes Berg 2009-07-14 1745 case NL80211_IFTYPE_MONITOR:
d82121845d4433 Aviya Erenfeld 2016-08-29 1746 if (sdata->u.mntr.flags & MONITOR_FLAG_ACTIVE) {
c82b5a74cc7393 Johannes Berg 2013-07-14 1747 vif = &sdata->vif;
c82b5a74cc7393 Johannes Berg 2013-07-14 1748 break;
c82b5a74cc7393 Johannes Berg 2013-07-14 1749 }
4b6f1dd6a6faf4 Johannes Berg 2012-04-03 1750 sdata = rcu_dereference(local->monitor_sdata);
3a25a8c8b75b43 Johannes Berg 2012-04-03 1751 if (sdata) {
4b6f1dd6a6faf4 Johannes Berg 2012-04-03 1752 vif = &sdata->vif;
3a25a8c8b75b43 Johannes Berg 2012-04-03 1753 info->hw_queue =
3a25a8c8b75b43 Johannes Berg 2012-04-03 1754 vif->hw_queue[skb_get_queue_mapping(skb)];
30686bf7f5b3c3 Johannes Berg 2015-06-02 1755 } else if (ieee80211_hw_check(&local->hw, QUEUE_CONTROL)) {
63b4d8b3736b83 Johannes Berg 2015-11-24 1756 ieee80211_purge_tx_queue(&local->hw, skbs);
3a25a8c8b75b43 Johannes Berg 2012-04-03 1757 return true;
3a25a8c8b75b43 Johannes Berg 2012-04-03 1758 } else
11127e9121d4dd Johannes Berg 2011-11-16 1759 vif = NULL;
5061b0c2b9066d Johannes Berg 2009-07-14 1760 break;
5061b0c2b9066d Johannes Berg 2009-07-14 1761 case NL80211_IFTYPE_AP_VLAN:
11127e9121d4dd Johannes Berg 2011-11-16 1762 sdata = container_of(sdata->bss,
11127e9121d4dd Johannes Berg 2011-11-16 1763 struct ieee80211_sub_if_data, u.ap);
fc0561dc6a9c61 Gustavo A. R. Silva 2020-07-07 1764 fallthrough;
5061b0c2b9066d Johannes Berg 2009-07-14 1765 default:
11127e9121d4dd Johannes Berg 2011-11-16 1766 vif = &sdata->vif;
5061b0c2b9066d Johannes Berg 2009-07-14 1767 break;
5061b0c2b9066d Johannes Berg 2009-07-14 1768 }
5061b0c2b9066d Johannes Berg 2009-07-14 1769
4fd0328d2f6314 Johannes Berg 2019-10-01 1770 result = ieee80211_tx_frags(local, vif, sta, skbs, txpending);
21f5fc75deca63 Luis R. Rodriguez 2009-07-24 1771
4db4e0a17fb0e7 Johannes Berg 2011-11-24 1772 WARN_ON_ONCE(!skb_queue_empty(skbs));
252b86c43225d0 Johannes Berg 2011-11-16 1773
11127e9121d4dd Johannes Berg 2011-11-16 1774 return result;
e2ebc74d7e3d71 Johannes Berg 2007-07-27 1775 }
e2ebc74d7e3d71 Johannes Berg 2007-07-27 1776
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week