Re: [PATCH] HID: intel-ish-hid: fix module device-id handling
by kernel test robot
Hi Arnd,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20211110]
[cannot apply to hid/for-next chrome-platform/for-next linus/master jikos-hid/for-next jikos-trivial/for-next v5.15 v5.15-rc7 v5.15-rc6 v5.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/HID-intel-ish-hid-...
base: DEBUG invalid remote for branch next-20211110 73e5c18006f5e1f7d35d1e996609eaff6536ae5e
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/92fe43ebb358c8772e996996a09f920e9...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Arnd-Bergmann/HID-intel-ish-hid-fix-module-device-id-handling/20211111-165958
git checkout 92fe43ebb358c8772e996996a09f920e9d6dc0a6
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/platform/x86/intel/ishtp_eclite.c:680:8: error: initialization of 'const struct ishtp_device_id *' from incompatible pointer type 'const struct ishtp_device_id (*)[2]' [-Werror=incompatible-pointer-types]
680 | .id = &ecl_ishtp_id_table,
| ^
drivers/platform/x86/intel/ishtp_eclite.c:680:8: note: (near initialization for 'ecl_ishtp_cl_driver.id')
cc1: all warnings being treated as errors
vim +680 drivers/platform/x86/intel/ishtp_eclite.c
677
678 static struct ishtp_cl_driver ecl_ishtp_cl_driver = {
679 .name = "ishtp-eclite",
> 680 .id = &ecl_ishtp_id_table,
681 .probe = ecl_ishtp_cl_probe,
682 .remove = ecl_ishtp_cl_remove,
683 .reset = ecl_ishtp_cl_reset,
684 .driver.pm = &ecl_ishtp_pm_ops,
685 };
686
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
drivers/bluetooth/btqca.c:493:24: sparse: sparse: restricted __le32 degrades to integer
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: debe436e77c72fcee804fb867f275e6d31aa999c
commit: 059924fdf6c1c31a7c1aa1915884e23f4313dde2 Bluetooth: btqca: Use NVM files based on SoC ID for WCN3991
date: 11 months ago
config: riscv-randconfig-s031-20211109 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 059924fdf6c1c31a7c1aa1915884e23f4313dde2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=riscv SHELL=/bin/bash block/ drivers/bluetooth/ drivers/hid/ drivers/hwmon/ drivers/i2c/busses/ drivers/message/fusion/ drivers/net/ethernet/ drivers/net/wireless/intel/iwlwifi/ drivers/pci/ drivers/remoteproc/ drivers/rtc/ drivers/staging/rts5208/ drivers/staging/vc04_services/ drivers/tty/serial/ drivers/vdpa/ drivers/video/fbdev/ net/qrtr/ net/sched/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/bluetooth/btqca.c:493:24: sparse: sparse: restricted __le32 degrades to integer
vim +493 drivers/bluetooth/btqca.c
440
441 int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate,
442 enum qca_btsoc_type soc_type, struct qca_btsoc_version ver,
443 const char *firmware_name)
444 {
445 struct qca_fw_config config;
446 int err;
447 u8 rom_ver = 0;
448 u32 soc_ver;
449
450 bt_dev_dbg(hdev, "QCA setup on UART");
451
452 soc_ver = get_soc_ver(ver.soc_id, ver.rom_ver);
453
454 bt_dev_info(hdev, "QCA controller version 0x%08x", soc_ver);
455
456 config.user_baud_rate = baudrate;
457
458 /* Download rampatch file */
459 config.type = TLV_TYPE_PATCH;
460 if (qca_is_wcn399x(soc_type)) {
461 /* Firmware files to download are based on ROM version.
462 * ROM version is derived from last two bytes of soc_ver.
463 */
464 rom_ver = ((soc_ver & 0x00000f00) >> 0x04) |
465 (soc_ver & 0x0000000f);
466 snprintf(config.fwname, sizeof(config.fwname),
467 "qca/crbtfw%02x.tlv", rom_ver);
468 } else if (soc_type == QCA_QCA6390) {
469 rom_ver = ((soc_ver & 0x00000f00) >> 0x04) |
470 (soc_ver & 0x0000000f);
471 snprintf(config.fwname, sizeof(config.fwname),
472 "qca/htbtfw%02x.tlv", rom_ver);
473 } else {
474 snprintf(config.fwname, sizeof(config.fwname),
475 "qca/rampatch_%08x.bin", soc_ver);
476 }
477
478 err = qca_download_firmware(hdev, &config, soc_type);
479 if (err < 0) {
480 bt_dev_err(hdev, "QCA Failed to download patch (%d)", err);
481 return err;
482 }
483
484 /* Give the controller some time to get ready to receive the NVM */
485 msleep(10);
486
487 /* Download NVM configuration */
488 config.type = TLV_TYPE_NVM;
489 if (firmware_name)
490 snprintf(config.fwname, sizeof(config.fwname),
491 "qca/%s", firmware_name);
492 else if (qca_is_wcn399x(soc_type)) {
> 493 if (ver.soc_id == QCA_WCN3991_SOC_ID) {
494 snprintf(config.fwname, sizeof(config.fwname),
495 "qca/crnv%02xu.bin", rom_ver);
496 } else {
497 snprintf(config.fwname, sizeof(config.fwname),
498 "qca/crnv%02x.bin", rom_ver);
499 }
500 }
501 else if (soc_type == QCA_QCA6390)
502 snprintf(config.fwname, sizeof(config.fwname),
503 "qca/htnv%02x.bin", rom_ver);
504 else
505 snprintf(config.fwname, sizeof(config.fwname),
506 "qca/nvm_%08x.bin", soc_ver);
507
508 err = qca_download_firmware(hdev, &config, soc_type);
509 if (err < 0) {
510 bt_dev_err(hdev, "QCA Failed to download NVM (%d)", err);
511 return err;
512 }
513
514 if (soc_type >= QCA_WCN3991) {
515 err = qca_disable_soc_logging(hdev);
516 if (err < 0)
517 return err;
518 }
519
520 /* Perform HCI reset */
521 err = qca_send_reset(hdev);
522 if (err < 0) {
523 bt_dev_err(hdev, "QCA Failed to run HCI_RESET (%d)", err);
524 return err;
525 }
526
527 bt_dev_info(hdev, "QCA setup on UART is completed");
528
529 return 0;
530 }
531 EXPORT_SYMBOL_GPL(qca_uart_setup);
532
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
[toke:xdp-queueing-01 4/9] net/core/filter.c:4153:24: error: implicit declaration of function 'pifo_map_dequeue'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/toke/linux.git xdp-queueing-01
head: 7cdc645073a59261514e56e1a4c6d0dac1b24b32
commit: de44bbfd9cf981baab181c006dc363c5f412d94c [4/9] bpf: Add helpers to dequeue from a PIFO map
config: riscv-buildonly-randconfig-r002-20211111 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 63ef0e17e28827eae53133b3467bdac7d9729318)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/toke/linux.git/commit/?id...
git remote add toke https://git.kernel.org/pub/scm/linux/kernel/git/toke/linux.git
git fetch --no-tags toke xdp-queueing-01
git checkout de44bbfd9cf981baab181c006dc363c5f412d94c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
net/core/filter.c:3992:10: error: implicit declaration of function 'pifo_map_enqueue' [-Werror,-Wimplicit-function-declaration]
err = pifo_map_enqueue(map, xdp, ri->tgt_index);
^
>> net/core/filter.c:4153:24: error: implicit declaration of function 'pifo_map_dequeue' [-Werror,-Wimplicit-function-declaration]
return (unsigned long)pifo_map_dequeue(map, flags);
^
net/core/filter.c:10088:15: error: use of undeclared identifier 'bpf_prog_test_run_dequeue'
.test_run = bpf_prog_test_run_dequeue,
^
3 errors generated.
vim +/pifo_map_dequeue +4153 net/core/filter.c
4149
4150 BPF_CALL_3(bpf_packet_dequeue, struct dequeue_data *, ctx, struct bpf_map *, map,
4151 u64, flags)
4152 {
> 4153 return (unsigned long)pifo_map_dequeue(map, flags);
4154 }
4155
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
[kbuild] [frank-w-bpi-r2-4.14:5.15-bpi-r2-pro 85/99] drivers/gpu/drm/rockchip/rockchip_drm_vop.c:3989 vop_create_crtc() warn: missing error code 'ret'
by Dan Carpenter
tree: https://github.com/frank-w/BPI-R2-4.14 5.15-bpi-r2-pro
head: 88eea49adcf099eca9307fe394b40a0e2c8bde02
commit: 281cc69c12f5b49abc38fc6cd91964446b435691 [85/99] drm: forward port of VOP2 driver
config: x86_64-randconfig-m001-20211103 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/gpu/drm/rockchip/rockchip_drm_vop.c:3989 vop_create_crtc() warn: missing error code 'ret'
vim +/ret +3989 drivers/gpu/drm/rockchip/rockchip_drm_vop.c
2048e3286f347db Mark Yao 2014-08-22 3890 static int vop_create_crtc(struct vop *vop)
2048e3286f347db Mark Yao 2014-08-22 3891 {
2048e3286f347db Mark Yao 2014-08-22 3892 struct device *dev = vop->dev;
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3893 const struct vop_data *vop_data = vop->data;
2048e3286f347db Mark Yao 2014-08-22 3894 struct drm_device *drm_dev = vop->drm_dev;
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3895 struct rockchip_drm_private *private = drm_dev->dev_private;
328b51c0f5a07f3 Douglas Anderson 2016-03-07 3896 struct drm_plane *primary = NULL, *cursor = NULL, *plane, *tmp;
2048e3286f347db Mark Yao 2014-08-22 3897 struct drm_crtc *crtc = &vop->crtc;
2048e3286f347db Mark Yao 2014-08-22 3898 struct device_node *port;
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3899 uint64_t feature = 0;
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3900 int ret = 0;
Better to not initialize "ret" to a throw away value. The compiler
wants to help find bugs.
2048e3286f347db Mark Yao 2014-08-22 3901 int i;
2048e3286f347db Mark Yao 2014-08-22 3902
2048e3286f347db Mark Yao 2014-08-22 3903 /*
2048e3286f347db Mark Yao 2014-08-22 3904 * Create drm_plane for primary and cursor planes first, since we need
2048e3286f347db Mark Yao 2014-08-22 3905 * to pass them to drm_crtc_init_with_planes, which sets the
2048e3286f347db Mark Yao 2014-08-22 3906 * "possible_crtcs" to the newly initialized crtc.
2048e3286f347db Mark Yao 2014-08-22 3907 */
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3908 for (i = 0; i < vop->num_wins; i++) {
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3909 struct vop_win *win = &vop->win[i];
2048e3286f347db Mark Yao 2014-08-22 3910
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3911 if (win->type != DRM_PLANE_TYPE_PRIMARY &&
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3912 win->type != DRM_PLANE_TYPE_CURSOR)
2048e3286f347db Mark Yao 2014-08-22 3913 continue;
2048e3286f347db Mark Yao 2014-08-22 3914
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3915 if (vop_plane_init(vop, win, 0)) {
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3916 DRM_DEV_ERROR(vop->dev, "failed to init plane\n");
2048e3286f347db Mark Yao 2014-08-22 3917 goto err_cleanup_planes;
Preserve the error code from ret = vop_plane_init(); This would have
been detected by the compiler.
2048e3286f347db Mark Yao 2014-08-22 3918 }
2048e3286f347db Mark Yao 2014-08-22 3919
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3920 plane = &win->base;
2048e3286f347db Mark Yao 2014-08-22 3921 if (plane->type == DRM_PLANE_TYPE_PRIMARY)
2048e3286f347db Mark Yao 2014-08-22 3922 primary = plane;
2048e3286f347db Mark Yao 2014-08-22 3923 else if (plane->type == DRM_PLANE_TYPE_CURSOR)
2048e3286f347db Mark Yao 2014-08-22 3924 cursor = plane;
2048e3286f347db Mark Yao 2014-08-22 3925 }
2048e3286f347db Mark Yao 2014-08-22 3926
2048e3286f347db Mark Yao 2014-08-22 3927 ret = drm_crtc_init_with_planes(drm_dev, crtc, primary, cursor,
f98828769c8838f Ville Syrjälä 2015-12-09 3928 &vop_crtc_funcs, NULL);
2048e3286f347db Mark Yao 2014-08-22 3929 if (ret)
328b51c0f5a07f3 Douglas Anderson 2016-03-07 3930 goto err_cleanup_planes;
2048e3286f347db Mark Yao 2014-08-22 3931
2048e3286f347db Mark Yao 2014-08-22 3932 drm_crtc_helper_add(crtc, &vop_crtc_helper_funcs);
2048e3286f347db Mark Yao 2014-08-22 3933
2048e3286f347db Mark Yao 2014-08-22 3934 /*
2048e3286f347db Mark Yao 2014-08-22 3935 * Create drm_planes for overlay windows with possible_crtcs restricted
2048e3286f347db Mark Yao 2014-08-22 3936 * to the newly created crtc.
2048e3286f347db Mark Yao 2014-08-22 3937 */
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3938 for (i = 0; i < vop->num_wins; i++) {
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3939 struct vop_win *win = &vop->win[i];
a3e77e1655961f4 Ville Syrjälä 2018-06-26 3940 unsigned long possible_crtcs = drm_crtc_mask(crtc);
2048e3286f347db Mark Yao 2014-08-22 3941
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3942 if (win->type != DRM_PLANE_TYPE_OVERLAY)
2048e3286f347db Mark Yao 2014-08-22 3943 continue;
2048e3286f347db Mark Yao 2014-08-22 3944
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3945 if (vop_plane_init(vop, win, possible_crtcs)) {
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3946 DRM_DEV_ERROR(vop->dev, "failed to init overlay\n");
2048e3286f347db Mark Yao 2014-08-22 3947 goto err_cleanup_crtc;
Preserve.
2048e3286f347db Mark Yao 2014-08-22 3948 }
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3949 vop_plane_add_properties(vop, &win->base, win);
2048e3286f347db Mark Yao 2014-08-22 3950 }
2048e3286f347db Mark Yao 2014-08-22 3951
2048e3286f347db Mark Yao 2014-08-22 3952 port = of_get_child_by_name(dev->of_node, "port");
2048e3286f347db Mark Yao 2014-08-22 3953 if (!port) {
4bf99144d2b407b Rob Herring 2017-07-18 3954 DRM_DEV_ERROR(vop->dev, "no port node found in %pOF\n",
4bf99144d2b407b Rob Herring 2017-07-18 3955 dev->of_node);
328b51c0f5a07f3 Douglas Anderson 2016-03-07 3956 ret = -ENOENT;
2048e3286f347db Mark Yao 2014-08-22 3957 goto err_cleanup_crtc;
2048e3286f347db Mark Yao 2014-08-22 3958 }
2048e3286f347db Mark Yao 2014-08-22 3959
47a7eb4597775ec Tomasz Figa 2016-09-14 3960 drm_flip_work_init(&vop->fb_unref_work, "fb_unref",
47a7eb4597775ec Tomasz Figa 2016-09-14 3961 vop_fb_unref_worker);
47a7eb4597775ec Tomasz Figa 2016-09-14 3962
1067219b27e29e9 Mark Yao 2015-02-04 3963 init_completion(&vop->dsp_hold_completion);
69c34e41f5d4e8a Yakir Yang 2016-07-24 3964 init_completion(&vop->line_flag_completion);
2048e3286f347db Mark Yao 2014-08-22 3965 crtc->port = port;
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3966 rockchip_register_crtc_funcs(crtc, &private_crtc_funcs);
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3967
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3968 #define VOP_ATTACH_MODE_CONFIG_PROP(prop, v) \
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3969 drm_object_attach_property(&crtc->base, drm_dev->mode_config.prop, v)
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3970
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3971 VOP_ATTACH_MODE_CONFIG_PROP(tv_left_margin_property, 100);
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3972 VOP_ATTACH_MODE_CONFIG_PROP(tv_right_margin_property, 100);
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3973 VOP_ATTACH_MODE_CONFIG_PROP(tv_top_margin_property, 100);
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3974 VOP_ATTACH_MODE_CONFIG_PROP(tv_bottom_margin_property, 100);
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3975
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3976 #undef VOP_ATTACH_MODE_CONFIG_PROP
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3977 drm_object_attach_property(&crtc->base, private->alpha_scale_prop, 0);
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3978 if (vop_data->feature & VOP_FEATURE_AFBDC)
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3979 feature |= BIT(ROCKCHIP_DRM_CRTC_FEATURE_AFBDC);
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3980 drm_object_attach_property(&crtc->base, vop->feature_prop,
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3981 feature);
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3982 if (vop->lut_regs) {
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3983 u16 *r_base, *g_base, *b_base;
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3984 u32 lut_len = vop->lut_len;
2048e3286f347db Mark Yao 2014-08-22 3985
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3986 vop->lut = devm_kmalloc_array(dev, lut_len, sizeof(*vop->lut),
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3987 GFP_KERNEL);
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3988 if (!vop->lut)
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 @3989 goto err_unregister_crtc_funcs;
"ret = -ENOMEM;"
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3990
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3991 if (vop_of_init_display_lut(vop)) {
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3992 for (i = 0; i < lut_len; i++) {
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3993 u32 r = i * lut_len * lut_len;
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3994 u32 g = i * lut_len;
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3995 u32 b = i;
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3996
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3997 vop->lut[i] = r | g | b;
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3998 }
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 3999 }
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4000
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4001 drm_mode_crtc_set_gamma_size(crtc, lut_len);
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4002 drm_crtc_enable_color_mgmt(crtc, 0, false, lut_len);
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4003 r_base = crtc->gamma_store;
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4004 g_base = r_base + crtc->gamma_size;
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4005 b_base = g_base + crtc->gamma_size;
6c836d965bad5e1 Sean Paul 2019-06-11 4006
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4007 for (i = 0; i < lut_len; i++) {
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4008 rockchip_vop_crtc_fb_gamma_get(crtc, &r_base[i],
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4009 &g_base[i], &b_base[i],
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4010 i);
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4011 }
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4012 }
2048e3286f347db Mark Yao 2014-08-22 4013 return 0;
2048e3286f347db Mark Yao 2014-08-22 4014
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4015 err_unregister_crtc_funcs:
281cc69c12f5b49 Benjamin Gaignard 2021-05-17 4016 rockchip_unregister_crtc_funcs(crtc);
2048e3286f347db Mark Yao 2014-08-22 4017 err_cleanup_crtc:
2048e3286f347db Mark Yao 2014-08-22 4018 drm_crtc_cleanup(crtc);
2048e3286f347db Mark Yao 2014-08-22 4019 err_cleanup_planes:
328b51c0f5a07f3 Douglas Anderson 2016-03-07 4020 list_for_each_entry_safe(plane, tmp, &drm_dev->mode_config.plane_list,
328b51c0f5a07f3 Douglas Anderson 2016-03-07 4021 head)
2048e3286f347db Mark Yao 2014-08-22 4022 drm_plane_cleanup(plane);
2048e3286f347db Mark Yao 2014-08-22 4023 return ret;
2048e3286f347db Mark Yao 2014-08-22 4024 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
10 months, 1 week
Re: [RFC PATCH v3 2/2] RDMA/rxe: Add dma-buf support
by kernel test robot
Hi Shunsuke,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on rdma/for-next]
[also build test ERROR on v5.15 next-20211111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Shunsuke-Mie/RDMA-rxe-Add-dma-bu...
base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/132b40bb2550f801c5e94fcde19f28b29...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Shunsuke-Mie/RDMA-rxe-Add-dma-buf-support/20211029-150351
git checkout 132b40bb2550f801c5e94fcde19f28b29b0852e2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/infiniband/sw/rxe/rxe_mr.c: In function 'rxe_map_dmabuf_mr':
>> drivers/infiniband/sw/rxe/rxe_mr.c:256:23: error: variable 'vaddr_end' set but not used [-Werror=unused-but-set-variable]
256 | void *vaddr, *vaddr_end;
| ^~~~~~~~~
cc1: all warnings being treated as errors
vim +/vaddr_end +256 drivers/infiniband/sw/rxe/rxe_mr.c
249
250 static int rxe_map_dmabuf_mr(struct rxe_mr *mr,
251 struct ib_umem_dmabuf *umem_dmabuf)
252 {
253 struct rxe_map_set *set;
254 struct rxe_phys_buf *buf = NULL;
255 struct rxe_map **map;
> 256 void *vaddr, *vaddr_end;
257 int num_buf = 0;
258 int err;
259 size_t remain;
260 struct dma_buf_map dmabuf_map;
261
262 err = dma_buf_vmap(umem_dmabuf->dmabuf, &dmabuf_map);
263 if (err || dmabuf_map.is_iomem)
264 goto err_out;
265
266 set = mr->cur_map_set;
267 set->page_shift = PAGE_SHIFT;
268 set->page_mask = PAGE_SIZE - 1;
269
270 map = set->map;
271 buf = map[0]->buf;
272
273 vaddr = dmabuf_map.vaddr;
274 vaddr_end = vaddr + umem_dmabuf->dmabuf->size;
275 remain = umem_dmabuf->dmabuf->size;
276
277 for (; remain; vaddr += PAGE_SIZE) {
278 if (num_buf >= RXE_BUF_PER_MAP) {
279 map++;
280 buf = map[0]->buf;
281 num_buf = 0;
282 }
283
284 buf->addr = (uintptr_t)vaddr;
285 if (remain >= PAGE_SIZE)
286 buf->size = PAGE_SIZE;
287 else
288 buf->size = remain;
289 remain -= buf->size;
290
291 num_buf++;
292 buf++;
293 }
294
295 return 0;
296
297 err_out:
298 return err;
299 }
300
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week
[toke:xdp-queueing-01 1/9] net/core/filter.c:3992:10: error: implicit declaration of function 'pifo_map_enqueue'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/toke/linux.git xdp-queueing-01
head: 7cdc645073a59261514e56e1a4c6d0dac1b24b32
commit: 181bc9e4a64cc89cae2fe5b0091ed328383ad40c [1/9] Add a PIFO map type for queueing packets
config: riscv-buildonly-randconfig-r002-20211111 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 63ef0e17e28827eae53133b3467bdac7d9729318)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/toke/linux.git/commit/?id...
git remote add toke https://git.kernel.org/pub/scm/linux/kernel/git/toke/linux.git
git fetch --no-tags toke xdp-queueing-01
git checkout 181bc9e4a64cc89cae2fe5b0091ed328383ad40c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> net/core/filter.c:3992:10: error: implicit declaration of function 'pifo_map_enqueue' [-Werror,-Wimplicit-function-declaration]
err = pifo_map_enqueue(map, xdp, ri->tgt_index);
^
1 error generated.
vim +/pifo_map_enqueue +3992 net/core/filter.c
3960
3961 int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp,
3962 struct bpf_prog *xdp_prog)
3963 {
3964 struct bpf_redirect_info *ri = this_cpu_ptr(&bpf_redirect_info);
3965 enum bpf_map_type map_type = ri->map_type;
3966 void *fwd = ri->tgt_value;
3967 u32 map_id = ri->map_id;
3968 struct bpf_map *map;
3969 int err;
3970
3971 ri->map_id = 0; /* Valid map id idr range: [1,INT_MAX[ */
3972 ri->map_type = BPF_MAP_TYPE_UNSPEC;
3973
3974 switch (map_type) {
3975 case BPF_MAP_TYPE_DEVMAP:
3976 fallthrough;
3977 case BPF_MAP_TYPE_DEVMAP_HASH:
3978 map = READ_ONCE(ri->map);
3979 if (unlikely(map)) {
3980 WRITE_ONCE(ri->map, NULL);
3981 err = dev_map_enqueue_multi(xdp, dev, map,
3982 ri->flags & BPF_F_EXCLUDE_INGRESS);
3983 } else {
3984 err = dev_map_enqueue(fwd, xdp, dev);
3985 }
3986 break;
3987 case BPF_MAP_TYPE_PIFO:
3988 map = READ_ONCE(ri->map);
3989 if (unlikely(!map))
3990 err = -EINVAL;
3991 else
> 3992 err = pifo_map_enqueue(map, xdp, ri->tgt_index);
3993 break;
3994 case BPF_MAP_TYPE_CPUMAP:
3995 err = cpu_map_enqueue(fwd, xdp, dev);
3996 break;
3997 case BPF_MAP_TYPE_XSKMAP:
3998 err = __xsk_map_redirect(fwd, xdp);
3999 break;
4000 case BPF_MAP_TYPE_UNSPEC:
4001 if (map_id == INT_MAX) {
4002 fwd = dev_get_by_index_rcu(dev_net(dev), ri->tgt_index);
4003 if (unlikely(!fwd)) {
4004 err = -EINVAL;
4005 break;
4006 }
4007 err = dev_xdp_enqueue(fwd, xdp, dev);
4008 break;
4009 }
4010 fallthrough;
4011 default:
4012 err = -EBADRQC;
4013 }
4014
4015 if (unlikely(err))
4016 goto err;
4017
4018 _trace_xdp_redirect_map(dev, xdp_prog, fwd, map_type, map_id, ri->tgt_index);
4019 return 0;
4020 err:
4021 _trace_xdp_redirect_map_err(dev, xdp_prog, fwd, map_type, map_id, ri->tgt_index, err);
4022 return err;
4023 }
4024 EXPORT_SYMBOL_GPL(xdp_do_redirect);
4025
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months, 1 week