[mcgrof-next:20211118-sysctl-cleanups-set-04-v2 32/36] fs/namei.c:1071:58: error: macro "register_sysctl_init" passed 3 arguments, but takes just 2
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20211118-sysctl-cleanups-set-04-v2
head: 3110d41a56792588bd2f64621080948b0fceb6ab
commit: a016e28cb93980d0d67db8cf558175595b1c3ec4 [32/36] fs: move namei sysctls to its own file
config: nds32-allnoconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/com...
git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
git fetch --no-tags mcgrof-next 20211118-sysctl-cleanups-set-04-v2
git checkout a016e28cb93980d0d67db8cf558175595b1c3ec4
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
fs/namei.c: In function 'init_fs_namei_sysctls':
>> fs/namei.c:1071:58: error: macro "register_sysctl_init" passed 3 arguments, but takes just 2
1071 | register_sysctl_init("fs", namei_sysctls, "namei");
| ^
In file included from include/linux/key.h:17,
from include/linux/cred.h:13,
from include/linux/sched/signal.h:10,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:33,
from fs/namei.c:22:
include/linux/sysctl.h:220: note: macro "register_sysctl_init" defined here
220 | #define register_sysctl_init(path, table) __register_sysctl_init(path, table, #table)
|
>> fs/namei.c:1071:9: error: 'register_sysctl_init' undeclared (first use in this function); did you mean 'register_sysctl_paths'?
1071 | register_sysctl_init("fs", namei_sysctls, "namei");
| ^~~~~~~~~~~~~~~~~~~~
| register_sysctl_paths
fs/namei.c:1071:9: note: each undeclared identifier is reported only once for each function it appears in
At top level:
fs/namei.c:1029:25: warning: 'namei_sysctls' defined but not used [-Wunused-variable]
1029 | static struct ctl_table namei_sysctls[] = {
| ^~~~~~~~~~~~~
vim +/register_sysctl_init +1071 fs/namei.c
1068
1069 static int __init init_fs_namei_sysctls(void)
1070 {
> 1071 register_sysctl_init("fs", namei_sysctls, "namei");
1072 return 0;
1073 }
1074 early_initcall(init_fs_namei_sysctls);
1075
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
drivers/gpu/drm/i915/gvt/gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
by kernel test robot
Hi Zhenyu,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4c388a8e740d3235a194f330c8ef327deef710f6
commit: 145e06b58f8625becc61792a0554726314297a85 drm/i915/gvt: Move mdev attribute groups into kvmgt module
date: 6 months ago
config: x86_64-randconfig-a005-20211118 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c46becf500df2a7fb4b4fce16178a036c344315a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 145e06b58f8625becc61792a0554726314297a85
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/i915/gvt/gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Check if can do 2M page
drivers/gpu/drm/i915/gvt/gtt.c:2209: warning: expecting prototype for intel_vgpu_emulate_gtt_mmio_read(). Prototype was for intel_vgpu_emulate_ggtt_mmio_read() instead
vim +1152 drivers/gpu/drm/i915/gvt/gtt.c
2707e44466881d Zhi Wang 2016-03-28 1150
b901b252b6cf5c Changbin Du 2018-05-15 1151 /**
a752b070a67823 Zhenyu Wang 2018-07-31 @1152 * Check if can do 2M page
a752b070a67823 Zhenyu Wang 2018-07-31 1153 * @vgpu: target vgpu
a752b070a67823 Zhenyu Wang 2018-07-31 1154 * @entry: target pfn's gtt entry
a752b070a67823 Zhenyu Wang 2018-07-31 1155 *
9317f356df83a5 Bhaskar Chowdhury 2021-02-22 1156 * Return 1 if 2MB huge gtt shadowing is possible, 0 if miscondition,
9317f356df83a5 Bhaskar Chowdhury 2021-02-22 1157 * negative if found err.
b901b252b6cf5c Changbin Du 2018-05-15 1158 */
b901b252b6cf5c Changbin Du 2018-05-15 1159 static int is_2MB_gtt_possible(struct intel_vgpu *vgpu,
b901b252b6cf5c Changbin Du 2018-05-15 1160 struct intel_gvt_gtt_entry *entry)
b901b252b6cf5c Changbin Du 2018-05-15 1161 {
b901b252b6cf5c Changbin Du 2018-05-15 1162 struct intel_gvt_gtt_pte_ops *ops = vgpu->gvt->gtt.pte_ops;
b901b252b6cf5c Changbin Du 2018-05-15 1163 unsigned long pfn;
b901b252b6cf5c Changbin Du 2018-05-15 1164
a61ac1e75105a0 Chris Wilson 2020-03-06 1165 if (!HAS_PAGE_SIZES(vgpu->gvt->gt->i915, I915_GTT_PAGE_SIZE_2M))
b901b252b6cf5c Changbin Du 2018-05-15 1166 return 0;
b901b252b6cf5c Changbin Du 2018-05-15 1167
b901b252b6cf5c Changbin Du 2018-05-15 1168 pfn = intel_gvt_hypervisor_gfn_to_mfn(vgpu, ops->get_pfn(entry));
b901b252b6cf5c Changbin Du 2018-05-15 1169 if (pfn == INTEL_GVT_INVALID_ADDR)
b901b252b6cf5c Changbin Du 2018-05-15 1170 return -EINVAL;
b901b252b6cf5c Changbin Du 2018-05-15 1171
b901b252b6cf5c Changbin Du 2018-05-15 1172 return PageTransHuge(pfn_to_page(pfn));
b901b252b6cf5c Changbin Du 2018-05-15 1173 }
b901b252b6cf5c Changbin Du 2018-05-15 1174
:::::: The code at line 1152 was first introduced by commit
:::::: a752b070a67823174565322cc48b2668daf9a8da drm/i915/gvt: Fix function comment doc errors
:::::: TO: Zhenyu Wang <zhenyuw(a)linux.intel.com>
:::::: CC: Zhenyu Wang <zhenyuw(a)linux.intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
[jaegeuk-f2fs-stable:linux-4.14.y 1255/1405] drivers/md/bitmap.c:382:32: warning: passing argument 2 of 'bmap' makes pointer from integer without a cast
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-stable.git linux-4.14.y
head: 98bd8ad7f8c21c53736fbb0589447186459e9ec9
commit: ea4899e2410d1394cc4857298ecf8cc511d5afd4 [1255/1405] fs: Enable bmap() function to properly return errors
config: i386-randconfig-a003-20211115 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-stable.git/c...
git remote add jaegeuk-f2fs-stable https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-stable.git
git fetch --no-tags jaegeuk-f2fs-stable linux-4.14.y
git checkout ea4899e2410d1394cc4857298ecf8cc511d5afd4
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/md/bitmap.c: In function 'read_page':
>> drivers/md/bitmap.c:382:32: warning: passing argument 2 of 'bmap' makes pointer from integer without a cast [-Wint-conversion]
bh->b_blocknr = bmap(inode, block);
^~~~~
In file included from include/linux/genhd.h:68:0,
from include/linux/blkdev.h:11,
from drivers/md/bitmap.c:18:
include/linux/fs.h:2729:12: note: expected 'sector_t * {aka long long unsigned int *}' but argument is of type 'sector_t {aka long long unsigned int}'
extern int bmap(struct inode *inode, sector_t *block);
^~~~
arch/x86/include/asm/bitops.h: Assembler messages:
arch/x86/include/asm/bitops.h:225: Warning: no instruction mnemonic suffix given and no register operands; using default for `bts'
arch/x86/include/asm/bitops.h:271: Warning: no instruction mnemonic suffix given and no register operands; using default for `btr'
vim +/bmap +382 drivers/md/bitmap.c
32a7627cf3a353 NeilBrown 2005-06-21 350
d785a06a0b9d0c NeilBrown 2006-06-26 351 /* read a page from a file.
d785a06a0b9d0c NeilBrown 2006-06-26 352 * We both read the page, and attach buffers to the page to record the
d785a06a0b9d0c NeilBrown 2006-06-26 353 * address of each block (using bmap). These addresses will be used
d785a06a0b9d0c NeilBrown 2006-06-26 354 * to write the block later, completely bypassing the filesystem.
d785a06a0b9d0c NeilBrown 2006-06-26 355 * This usage is similar to how swap files are handled, and allows us
d785a06a0b9d0c NeilBrown 2006-06-26 356 * to write to a file with no concerns of memory allocation failing.
d785a06a0b9d0c NeilBrown 2006-06-26 357 */
27581e5ae01f77 NeilBrown 2012-05-22 358 static int read_page(struct file *file, unsigned long index,
d785a06a0b9d0c NeilBrown 2006-06-26 359 struct bitmap *bitmap,
27581e5ae01f77 NeilBrown 2012-05-22 360 unsigned long count,
27581e5ae01f77 NeilBrown 2012-05-22 361 struct page *page)
32a7627cf3a353 NeilBrown 2005-06-21 362 {
27581e5ae01f77 NeilBrown 2012-05-22 363 int ret = 0;
496ad9aa8ef448 Al Viro 2013-01-23 364 struct inode *inode = file_inode(file);
d785a06a0b9d0c NeilBrown 2006-06-26 365 struct buffer_head *bh;
d785a06a0b9d0c NeilBrown 2006-06-26 366 sector_t block;
32a7627cf3a353 NeilBrown 2005-06-21 367
36a4e1fe0f4541 NeilBrown 2011-10-07 368 pr_debug("read bitmap file (%dB @ %llu)\n", (int)PAGE_SIZE,
2d1f3b5d1b2cd1 NeilBrown 2006-01-06 369 (unsigned long long)index << PAGE_SHIFT);
32a7627cf3a353 NeilBrown 2005-06-21 370
d785a06a0b9d0c NeilBrown 2006-06-26 371 bh = alloc_page_buffers(page, 1<<inode->i_blkbits, 0);
d785a06a0b9d0c NeilBrown 2006-06-26 372 if (!bh) {
27581e5ae01f77 NeilBrown 2012-05-22 373 ret = -ENOMEM;
d785a06a0b9d0c NeilBrown 2006-06-26 374 goto out;
d785a06a0b9d0c NeilBrown 2006-06-26 375 }
d785a06a0b9d0c NeilBrown 2006-06-26 376 attach_page_buffers(page, bh);
d785a06a0b9d0c NeilBrown 2006-06-26 377 block = index << (PAGE_SHIFT - inode->i_blkbits);
d785a06a0b9d0c NeilBrown 2006-06-26 378 while (bh) {
d785a06a0b9d0c NeilBrown 2006-06-26 379 if (count == 0)
d785a06a0b9d0c NeilBrown 2006-06-26 380 bh->b_blocknr = 0;
d785a06a0b9d0c NeilBrown 2006-06-26 381 else {
d785a06a0b9d0c NeilBrown 2006-06-26 @382 bh->b_blocknr = bmap(inode, block);
d785a06a0b9d0c NeilBrown 2006-06-26 383 if (bh->b_blocknr == 0) {
d785a06a0b9d0c NeilBrown 2006-06-26 384 /* Cannot use this file! */
27581e5ae01f77 NeilBrown 2012-05-22 385 ret = -EINVAL;
d785a06a0b9d0c NeilBrown 2006-06-26 386 goto out;
d785a06a0b9d0c NeilBrown 2006-06-26 387 }
d785a06a0b9d0c NeilBrown 2006-06-26 388 bh->b_bdev = inode->i_sb->s_bdev;
d785a06a0b9d0c NeilBrown 2006-06-26 389 if (count < (1<<inode->i_blkbits))
d785a06a0b9d0c NeilBrown 2006-06-26 390 count = 0;
32a7627cf3a353 NeilBrown 2005-06-21 391 else
d785a06a0b9d0c NeilBrown 2006-06-26 392 count -= (1<<inode->i_blkbits);
d785a06a0b9d0c NeilBrown 2006-06-26 393
d785a06a0b9d0c NeilBrown 2006-06-26 394 bh->b_end_io = end_bitmap_write;
d785a06a0b9d0c NeilBrown 2006-06-26 395 bh->b_private = bitmap;
ce25c31bdd3b39 NeilBrown 2006-06-26 396 atomic_inc(&bitmap->pending_writes);
ce25c31bdd3b39 NeilBrown 2006-06-26 397 set_buffer_locked(bh);
ce25c31bdd3b39 NeilBrown 2006-06-26 398 set_buffer_mapped(bh);
2a222ca992c35a Mike Christie 2016-06-05 399 submit_bh(REQ_OP_READ, 0, bh);
d785a06a0b9d0c NeilBrown 2006-06-26 400 }
d785a06a0b9d0c NeilBrown 2006-06-26 401 block++;
d785a06a0b9d0c NeilBrown 2006-06-26 402 bh = bh->b_this_page;
d785a06a0b9d0c NeilBrown 2006-06-26 403 }
d785a06a0b9d0c NeilBrown 2006-06-26 404 page->index = index;
ce25c31bdd3b39 NeilBrown 2006-06-26 405
ce25c31bdd3b39 NeilBrown 2006-06-26 406 wait_event(bitmap->write_wait,
ce25c31bdd3b39 NeilBrown 2006-06-26 407 atomic_read(&bitmap->pending_writes)==0);
b405fe91e50c60 NeilBrown 2012-05-22 408 if (test_bit(BITMAP_WRITE_ERROR, &bitmap->flags))
27581e5ae01f77 NeilBrown 2012-05-22 409 ret = -EIO;
32a7627cf3a353 NeilBrown 2005-06-21 410 out:
27581e5ae01f77 NeilBrown 2012-05-22 411 if (ret)
ec0cc226854a79 NeilBrown 2016-11-02 412 pr_err("md: bitmap read error: (%dB @ %llu): %d\n",
2d1f3b5d1b2cd1 NeilBrown 2006-01-06 413 (int)PAGE_SIZE,
2d1f3b5d1b2cd1 NeilBrown 2006-01-06 414 (unsigned long long)index << PAGE_SHIFT,
27581e5ae01f77 NeilBrown 2012-05-22 415 ret);
27581e5ae01f77 NeilBrown 2012-05-22 416 return ret;
32a7627cf3a353 NeilBrown 2005-06-21 417 }
32a7627cf3a353 NeilBrown 2005-06-21 418
:::::: The code at line 382 was first introduced by commit
:::::: d785a06a0b9d0cd86b3cc1bf8e236e62af7b47ed [PATCH] md/bitmap: change md/bitmap file handling to use bmap to file blocks
:::::: TO: NeilBrown <neilb(a)suse.de>
:::::: CC: Linus Torvalds <torvalds(a)g5.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
drivers/net/wireless/ath/ath11k/mac.c:5408:22: warning: parameter 'changed_flags' set but not used
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 42eb8fdac2fc5d62392dcfcf0253753e821a97b0
commit: 689a5e6fff75229ac7c2af7a9c51dc2d3ca1882b ath11k: monitor mode clean up to use separate APIs
date: 8 weeks ago
config: x86_64-randconfig-a006-20211118 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c46becf500df2a7fb4b4fce16178a036c344315a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 689a5e6fff75229ac7c2af7a9c51dc2d3ca1882b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/ath/ath11k/mac.c:5408:22: warning: parameter 'changed_flags' set but not used [-Wunused-but-set-parameter]
unsigned int changed_flags,
^
1 warning generated.
vim +/changed_flags +5408 drivers/net/wireless/ath/ath11k/mac.c
d5c65159f28953 Kalle Valo 2019-11-23 5396
d5c65159f28953 Kalle Valo 2019-11-23 5397 /* FIXME: Has to be verified. */
d5c65159f28953 Kalle Valo 2019-11-23 5398 #define SUPPORTED_FILTERS \
d5c65159f28953 Kalle Valo 2019-11-23 5399 (FIF_ALLMULTI | \
d5c65159f28953 Kalle Valo 2019-11-23 5400 FIF_CONTROL | \
d5c65159f28953 Kalle Valo 2019-11-23 5401 FIF_PSPOLL | \
d5c65159f28953 Kalle Valo 2019-11-23 5402 FIF_OTHER_BSS | \
d5c65159f28953 Kalle Valo 2019-11-23 5403 FIF_BCN_PRBRESP_PROMISC | \
d5c65159f28953 Kalle Valo 2019-11-23 5404 FIF_PROBE_REQ | \
d5c65159f28953 Kalle Valo 2019-11-23 5405 FIF_FCSFAIL)
d5c65159f28953 Kalle Valo 2019-11-23 5406
d5c65159f28953 Kalle Valo 2019-11-23 5407 static void ath11k_mac_op_configure_filter(struct ieee80211_hw *hw,
d5c65159f28953 Kalle Valo 2019-11-23 @5408 unsigned int changed_flags,
d5c65159f28953 Kalle Valo 2019-11-23 5409 unsigned int *total_flags,
d5c65159f28953 Kalle Valo 2019-11-23 5410 u64 multicast)
d5c65159f28953 Kalle Valo 2019-11-23 5411 {
d5c65159f28953 Kalle Valo 2019-11-23 5412 struct ath11k *ar = hw->priv;
d5c65159f28953 Kalle Valo 2019-11-23 5413
d5c65159f28953 Kalle Valo 2019-11-23 5414 mutex_lock(&ar->conf_mutex);
d5c65159f28953 Kalle Valo 2019-11-23 5415
d5c65159f28953 Kalle Valo 2019-11-23 5416 changed_flags &= SUPPORTED_FILTERS;
d5c65159f28953 Kalle Valo 2019-11-23 5417 *total_flags &= SUPPORTED_FILTERS;
d5c65159f28953 Kalle Valo 2019-11-23 5418 ar->filter_flags = *total_flags;
d5c65159f28953 Kalle Valo 2019-11-23 5419
d5c65159f28953 Kalle Valo 2019-11-23 5420 mutex_unlock(&ar->conf_mutex);
d5c65159f28953 Kalle Valo 2019-11-23 5421 }
d5c65159f28953 Kalle Valo 2019-11-23 5422
:::::: The code at line 5408 was first introduced by commit
:::::: d5c65159f2895379e11ca13f62feabe93278985d ath11k: driver for Qualcomm IEEE 802.11ax devices
:::::: TO: Kalle Valo <kvalo(a)codeaurora.org>
:::::: CC: Kalle Valo <kvalo(a)codeaurora.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
[mcgrof-next:20211118-sysctl-cleanups-set-04-v2 31/36] fs/locks.c:118:58: error: macro "register_sysctl_init" passed 3 arguments, but takes just 2
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20211118-sysctl-cleanups-set-04-v2
head: 3110d41a56792588bd2f64621080948b0fceb6ab
commit: 92edf8c99bc06bc2035ccfcd1c852303bb555db1 [31/36] fs: move locking sysctls where they are used
config: nds32-allnoconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/com...
git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
git fetch --no-tags mcgrof-next 20211118-sysctl-cleanups-set-04-v2
git checkout 92edf8c99bc06bc2035ccfcd1c852303bb555db1
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
fs/locks.c: In function 'init_fs_locks_sysctls':
>> fs/locks.c:118:58: error: macro "register_sysctl_init" passed 3 arguments, but takes just 2
118 | register_sysctl_init("fs", locks_sysctls, "locks");
| ^
In file included from include/linux/key.h:17,
from include/linux/cred.h:13,
from include/linux/sched/signal.h:10,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:33,
from include/linux/fdtable.h:16,
from fs/locks.c:54:
include/linux/sysctl.h:220: note: macro "register_sysctl_init" defined here
220 | #define register_sysctl_init(path, table) __register_sysctl_init(path, table, #table)
|
>> fs/locks.c:118:9: error: 'register_sysctl_init' undeclared (first use in this function); did you mean 'register_sysctl_paths'?
118 | register_sysctl_init("fs", locks_sysctls, "locks");
| ^~~~~~~~~~~~~~~~~~~~
| register_sysctl_paths
fs/locks.c:118:9: note: each undeclared identifier is reported only once for each function it appears in
At top level:
fs/locks.c:96:25: warning: 'locks_sysctls' defined but not used [-Wunused-variable]
96 | static struct ctl_table locks_sysctls[] = {
| ^~~~~~~~~~~~~
vim +/register_sysctl_init +118 fs/locks.c
> 54 #include <linux/fdtable.h>
55 #include <linux/fs.h>
56 #include <linux/init.h>
57 #include <linux/security.h>
58 #include <linux/slab.h>
59 #include <linux/syscalls.h>
60 #include <linux/time.h>
61 #include <linux/rcupdate.h>
62 #include <linux/pid_namespace.h>
63 #include <linux/hashtable.h>
64 #include <linux/percpu.h>
65 #include <linux/sysctl.h>
66
67 #define CREATE_TRACE_POINTS
68 #include <trace/events/filelock.h>
69
70 #include <linux/uaccess.h>
71
72 #define IS_POSIX(fl) (fl->fl_flags & FL_POSIX)
73 #define IS_FLOCK(fl) (fl->fl_flags & FL_FLOCK)
74 #define IS_LEASE(fl) (fl->fl_flags & (FL_LEASE|FL_DELEG|FL_LAYOUT))
75 #define IS_OFDLCK(fl) (fl->fl_flags & FL_OFDLCK)
76 #define IS_REMOTELCK(fl) (fl->fl_pid <= 0)
77
78 static bool lease_breaking(struct file_lock *fl)
79 {
80 return fl->fl_flags & (FL_UNLOCK_PENDING | FL_DOWNGRADE_PENDING);
81 }
82
83 static int target_leasetype(struct file_lock *fl)
84 {
85 if (fl->fl_flags & FL_UNLOCK_PENDING)
86 return F_UNLCK;
87 if (fl->fl_flags & FL_DOWNGRADE_PENDING)
88 return F_RDLCK;
89 return fl->fl_type;
90 }
91
92 static int leases_enable = 1;
93 static int lease_break_time = 45;
94
95 #ifdef CONFIG_SYSCTL
96 static struct ctl_table locks_sysctls[] = {
97 {
98 .procname = "leases-enable",
99 .data = &leases_enable,
100 .maxlen = sizeof(int),
101 .mode = 0644,
102 .proc_handler = proc_dointvec,
103 },
104 #ifdef CONFIG_MMU
105 {
106 .procname = "lease-break-time",
107 .data = &lease_break_time,
108 .maxlen = sizeof(int),
109 .mode = 0644,
110 .proc_handler = proc_dointvec,
111 },
112 #endif /* CONFIG_MMU */
113 {}
114 };
115
116 static int __init init_fs_locks_sysctls(void)
117 {
> 118 register_sysctl_init("fs", locks_sysctls, "locks");
119 return 0;
120 }
121 early_initcall(init_fs_locks_sysctls);
122 #endif /* CONFIG_SYSCTL */
123
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
[mcgrof-next:20211118-sysctl-cleanups-set-04-v2 28/36] fs/dcache.c:192:63: error: macro "register_sysctl_init" passed 3 arguments, but takes just 2
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20211118-sysctl-cleanups-set-04-v2
head: 3110d41a56792588bd2f64621080948b0fceb6ab
commit: 55db5cb7387c09fbdfc731a9ab1573f69d8f1d6d [28/36] fs: move dcache sysctls to its own file
config: nds32-allnoconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/com...
git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
git fetch --no-tags mcgrof-next 20211118-sysctl-cleanups-set-04-v2
git checkout 55db5cb7387c09fbdfc731a9ab1573f69d8f1d6d
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
fs/dcache.c: In function 'init_fs_dcache_sysctls':
>> fs/dcache.c:192:63: error: macro "register_sysctl_init" passed 3 arguments, but takes just 2
192 | register_sysctl_init("fs", fs_dcache_sysctls, "dcache");
| ^
In file included from include/linux/key.h:17,
from include/linux/cred.h:13,
from include/linux/sched/signal.h:10,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:33,
from include/linux/huge_mm.h:8,
from include/linux/mm.h:717,
from fs/dcache.c:20:
include/linux/sysctl.h:216: note: macro "register_sysctl_init" defined here
216 | #define register_sysctl_init(path, table) __register_sysctl_init(path, table, #table)
|
>> fs/dcache.c:192:9: error: 'register_sysctl_init' undeclared (first use in this function); did you mean 'register_sysctl_paths'?
192 | register_sysctl_init("fs", fs_dcache_sysctls, "dcache");
| ^~~~~~~~~~~~~~~~~~~~
| register_sysctl_paths
fs/dcache.c:192:9: note: each undeclared identifier is reported only once for each function it appears in
At top level:
fs/dcache.c:179:25: warning: 'fs_dcache_sysctls' defined but not used [-Wunused-variable]
179 | static struct ctl_table fs_dcache_sysctls[] = {
| ^~~~~~~~~~~~~~~~~
vim +/register_sysctl_init +192 fs/dcache.c
189
190 static int __init init_fs_dcache_sysctls(void)
191 {
> 192 register_sysctl_init("fs", fs_dcache_sysctls, "dcache");
193 return 0;
194 }
195 early_initcall(init_fs_dcache_sysctls);
196 #endif
197
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
[agd5f:drm-next 49/92] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:4457:25: error: implicit declaration of function 'DC_LOG_DP2'; did you mean 'DC_LOG_DML'?
by kernel test robot
tree: https://gitlab.freedesktop.org/agd5f/linux.git drm-next
head: eaae0714f4a82df81a60c6aae74c568e8974a716
commit: 9c0dc981c97dc7a439469dff76bacf6415514496 [49/92] drm/amd/display: Reduce dmesg error to a debug print
config: arc-randconfig-r035-20211118 (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
git fetch --no-tags agd5f drm-next
git checkout 9c0dc981c97dc7a439469dff76bacf6415514496
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/amd/amdgpu/../display/dmub/dmub_srv.h:67,
from drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.h:30,
from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:37:
drivers/gpu/drm/amd/amdgpu/../display/dmub/inc/dmub_cmd.h: In function 'dmub_rb_flush_pending':
drivers/gpu/drm/amd/amdgpu/../display/dmub/inc/dmub_cmd.h:2892:26: warning: variable 'temp' set but not used [-Wunused-but-set-variable]
2892 | uint64_t temp;
| ^~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: In function 'dp_retrieve_lttpr_cap':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:4457:25: error: implicit declaration of function 'DC_LOG_DP2'; did you mean 'DC_LOG_DML'? [-Werror=implicit-function-declaration]
4457 | DC_LOG_DP2("%s: Read LTTPR caps data failed.\n", __func__);
| ^~~~~~~~~~
| DC_LOG_DML
In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:32,
from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/resource.h:28,
from drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:30:
At top level:
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:121:22: warning: 'DP_SINK_DEVICE_STR_ID_2' defined but not used [-Wunused-const-variable=]
121 | static const uint8_t DP_SINK_DEVICE_STR_ID_2[] = {7, 1, 8, 7, 5, 0};
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:120:22: warning: 'DP_SINK_DEVICE_STR_ID_1' defined but not used [-Wunused-const-variable=]
120 | static const uint8_t DP_SINK_DEVICE_STR_ID_1[] = {7, 1, 8, 7, 3, 0};
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +4457 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c
4446
4447 if (link->lttpr_mode == LTTPR_MODE_NON_TRANSPARENT || link->lttpr_mode == LTTPR_MODE_TRANSPARENT) {
4448 /* By reading LTTPR capability, RX assumes that we will enable
4449 * LTTPR extended aux timeout if LTTPR is present.
4450 */
4451 status = core_link_read_dpcd(
4452 link,
4453 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV,
4454 lttpr_dpcd_data,
4455 sizeof(lttpr_dpcd_data));
4456 if (status != DC_OK) {
> 4457 DC_LOG_DP2("%s: Read LTTPR caps data failed.\n", __func__);
4458 return false;
4459 }
4460
4461 link->dpcd_caps.lttpr_caps.revision.raw =
4462 lttpr_dpcd_data[DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV -
4463 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
4464
4465 link->dpcd_caps.lttpr_caps.max_link_rate =
4466 lttpr_dpcd_data[DP_MAX_LINK_RATE_PHY_REPEATER -
4467 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
4468
4469 link->dpcd_caps.lttpr_caps.phy_repeater_cnt =
4470 lttpr_dpcd_data[DP_PHY_REPEATER_CNT -
4471 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
4472
4473 link->dpcd_caps.lttpr_caps.max_lane_count =
4474 lttpr_dpcd_data[DP_MAX_LANE_COUNT_PHY_REPEATER -
4475 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
4476
4477 link->dpcd_caps.lttpr_caps.mode =
4478 lttpr_dpcd_data[DP_PHY_REPEATER_MODE -
4479 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
4480
4481 link->dpcd_caps.lttpr_caps.max_ext_timeout =
4482 lttpr_dpcd_data[DP_PHY_REPEATER_EXTENDED_WAIT_TIMEOUT -
4483 DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV];
4484
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
Re: [PATCH 7/8] mt76: mt7915: add support for tx-overrides
by kernel test robot
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on kvalo-wireless-drivers-next/master]
[also build test ERROR on v5.16-rc1 next-20211118]
[cannot apply to kvalo-wireless-drivers/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/greearb-candelatech-com/mt76-mt7...
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-ne... master
config: microblaze-buildonly-randconfig-r005-20211119 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c742cd1ffffaeff7ab79835466b08fd56...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review greearb-candelatech-com/mt76-mt7915-cache-sgi-in-wcid/20211119-005421
git checkout c742cd1ffffaeff7ab79835466b08fd5616cdce3
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/net/wireless/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/net/wireless/mediatek/mt76/mt7915/mac.c: In function 'mt7915_mac_write_txwi_tm':
>> drivers/net/wireless/mediatek/mt76/mt7915/mac.c:778:37: error: 'struct mt76_phy' has no member named 'test'
778 | if (skb != phy->mt76->test.tx_skb)
| ^~
drivers/net/wireless/mediatek/mt76/mt7915/mac.c:780:32: error: 'struct mt76_phy' has no member named 'test'
780 | td = &phy->mt76->test;
| ^~
In file included from include/linux/byteorder/little_endian.h:5,
from arch/microblaze/include/uapi/asm/byteorder.h:6,
from include/asm-generic/bitops/le.h:7,
from include/asm-generic/bitops.h:36,
from ./arch/microblaze/include/generated/asm/bitops.h:1,
from include/linux/bitops.h:33,
from include/linux/kernel.h:12,
from include/linux/skbuff.h:13,
from include/linux/if_ether.h:19,
from include/linux/etherdevice.h:20,
from drivers/net/wireless/mediatek/mt76/mt7915/mac.c:4:
>> drivers/net/wireless/mediatek/mt76/mt7915/mac.c:909:54: error: 'struct mt7915_phy' has no member named 'test'
909 | phy->test.spe_idx));
| ^~
include/uapi/linux/byteorder/little_endian.h:33:51: note: in definition of macro '__cpu_to_le32'
33 | #define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
| ^
include/linux/compiler_types.h:310:9: note: in expansion of macro '__compiletime_assert'
310 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:322:9: note: in expansion of macro '_compiletime_assert'
322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:49:17: note: in expansion of macro 'BUILD_BUG_ON_MSG'
49 | BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \
| ^~~~~~~~~~~~~~~~
include/linux/bitfield.h:94:17: note: in expansion of macro '__BF_FIELD_CHECK'
94 | __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
| ^~~~~~~~~~~~~~~~
drivers/net/wireless/mediatek/mt76/mt7915/mac.c:908:40: note: in expansion of macro 'FIELD_PREP'
908 | txwi[7] |= cpu_to_le32(FIELD_PREP(MT_TXD7_SPE_IDX,
| ^~~~~~~~~~
>> drivers/net/wireless/mediatek/mt76/mt7915/mac.c:909:54: error: 'struct mt7915_phy' has no member named 'test'
909 | phy->test.spe_idx));
| ^~
include/uapi/linux/byteorder/little_endian.h:33:51: note: in definition of macro '__cpu_to_le32'
33 | #define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
| ^
include/linux/compiler_types.h:310:9: note: in expansion of macro '__compiletime_assert'
310 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:322:9: note: in expansion of macro '_compiletime_assert'
322 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:49:17: note: in expansion of macro 'BUILD_BUG_ON_MSG'
49 | BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \
| ^~~~~~~~~~~~~~~~
include/linux/bitfield.h:94:17: note: in expansion of macro '__BF_FIELD_CHECK'
94 | __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
| ^~~~~~~~~~~~~~~~
drivers/net/wireless/mediatek/mt76/mt7915/mac.c:908:40: note: in expansion of macro 'FIELD_PREP'
908 | txwi[7] |= cpu_to_le32(FIELD_PREP(MT_TXD7_SPE_IDX,
| ^~~~~~~~~~
>> drivers/net/wireless/mediatek/mt76/mt7915/mac.c:909:54: error: 'struct mt7915_phy' has no member named 'test'
909 | phy->test.spe_idx));
| ^~
include/uapi/linux/byteorder/little_endian.h:33:51: note: in definition of macro '__cpu_to_le32'
33 | #define __cpu_to_le32(x) ((__force __le32)(__u32)(x))
| ^
drivers/net/wireless/mediatek/mt76/mt7915/mac.c:908:40: note: in expansion of macro 'FIELD_PREP'
908 | txwi[7] |= cpu_to_le32(FIELD_PREP(MT_TXD7_SPE_IDX,
| ^~~~~~~~~~
At top level:
drivers/net/wireless/mediatek/mt76/mt7915/mac.c:760:1: warning: 'mt7915_mac_write_txwi_tm' defined but not used [-Wunused-function]
760 | mt7915_mac_write_txwi_tm(struct mt7915_phy *phy, struct mt76_wcid *wcid, __le32 *txwi,
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +778 drivers/net/wireless/mediatek/mt76/mt7915/mac.c
5d8a83f0994134 Shayne Chen 2020-10-22 758
aadf09537c575d Shayne Chen 2020-10-22 759 static void
c742cd1ffffaef Ben Greear 2021-11-18 760 mt7915_mac_write_txwi_tm(struct mt7915_phy *phy, struct mt76_wcid *wcid, __le32 *txwi,
c918c74d06457e Shayne Chen 2020-12-04 761 struct sk_buff *skb)
aadf09537c575d Shayne Chen 2020-10-22 762 {
c742cd1ffffaef Ben Greear 2021-11-18 763 struct mt76_testmode_data *td;
cc91747be98f2a Shayne Chen 2021-04-12 764 const struct ieee80211_rate *r;
c742cd1ffffaef Ben Greear 2021-11-18 765 struct mt7915_sta *msta;
c742cd1ffffaef Ben Greear 2021-11-18 766 u8 bw, mode, nss;
c742cd1ffffaef Ben Greear 2021-11-18 767 u8 rate_idx;
aadf09537c575d Shayne Chen 2020-10-22 768 u16 rateval = 0;
aadf09537c575d Shayne Chen 2020-10-22 769 u32 val;
cc91747be98f2a Shayne Chen 2021-04-12 770 bool cck = false;
cc91747be98f2a Shayne Chen 2021-04-12 771 int band;
aadf09537c575d Shayne Chen 2020-10-22 772
c742cd1ffffaef Ben Greear 2021-11-18 773 msta = container_of(wcid, struct mt7915_sta, wcid);
c742cd1ffffaef Ben Greear 2021-11-18 774
c742cd1ffffaef Ben Greear 2021-11-18 775 if (msta->test.txo_active) {
c742cd1ffffaef Ben Greear 2021-11-18 776 td = &msta->test;
c742cd1ffffaef Ben Greear 2021-11-18 777 } else {
c918c74d06457e Shayne Chen 2020-12-04 @778 if (skb != phy->mt76->test.tx_skb)
aadf09537c575d Shayne Chen 2020-10-22 779 return;
c742cd1ffffaef Ben Greear 2021-11-18 780 td = &phy->mt76->test;
c742cd1ffffaef Ben Greear 2021-11-18 781 }
c742cd1ffffaef Ben Greear 2021-11-18 782
c742cd1ffffaef Ben Greear 2021-11-18 783 nss = td->tx_rate_nss;
c742cd1ffffaef Ben Greear 2021-11-18 784 rate_idx = td->tx_rate_idx;
aadf09537c575d Shayne Chen 2020-10-22 785
aadf09537c575d Shayne Chen 2020-10-22 786 switch (td->tx_rate_mode) {
aadf09537c575d Shayne Chen 2020-10-22 787 case MT76_TM_TX_MODE_HT:
aadf09537c575d Shayne Chen 2020-10-22 788 nss = 1 + (rate_idx >> 3);
aadf09537c575d Shayne Chen 2020-10-22 789 mode = MT_PHY_TYPE_HT;
aadf09537c575d Shayne Chen 2020-10-22 790 break;
aadf09537c575d Shayne Chen 2020-10-22 791 case MT76_TM_TX_MODE_VHT:
aadf09537c575d Shayne Chen 2020-10-22 792 mode = MT_PHY_TYPE_VHT;
aadf09537c575d Shayne Chen 2020-10-22 793 break;
aadf09537c575d Shayne Chen 2020-10-22 794 case MT76_TM_TX_MODE_HE_SU:
aadf09537c575d Shayne Chen 2020-10-22 795 mode = MT_PHY_TYPE_HE_SU;
aadf09537c575d Shayne Chen 2020-10-22 796 break;
aadf09537c575d Shayne Chen 2020-10-22 797 case MT76_TM_TX_MODE_HE_EXT_SU:
aadf09537c575d Shayne Chen 2020-10-22 798 mode = MT_PHY_TYPE_HE_EXT_SU;
aadf09537c575d Shayne Chen 2020-10-22 799 break;
aadf09537c575d Shayne Chen 2020-10-22 800 case MT76_TM_TX_MODE_HE_TB:
aadf09537c575d Shayne Chen 2020-10-22 801 mode = MT_PHY_TYPE_HE_TB;
aadf09537c575d Shayne Chen 2020-10-22 802 break;
aadf09537c575d Shayne Chen 2020-10-22 803 case MT76_TM_TX_MODE_HE_MU:
aadf09537c575d Shayne Chen 2020-10-22 804 mode = MT_PHY_TYPE_HE_MU;
aadf09537c575d Shayne Chen 2020-10-22 805 break;
cc91747be98f2a Shayne Chen 2021-04-12 806 case MT76_TM_TX_MODE_CCK:
cc91747be98f2a Shayne Chen 2021-04-12 807 cck = true;
cc91747be98f2a Shayne Chen 2021-04-12 808 fallthrough;
aadf09537c575d Shayne Chen 2020-10-22 809 case MT76_TM_TX_MODE_OFDM:
cc91747be98f2a Shayne Chen 2021-04-12 810 band = phy->mt76->chandef.chan->band;
cc91747be98f2a Shayne Chen 2021-04-12 811 if (band == NL80211_BAND_2GHZ && !cck)
cc91747be98f2a Shayne Chen 2021-04-12 812 rate_idx += 4;
cc91747be98f2a Shayne Chen 2021-04-12 813
cc91747be98f2a Shayne Chen 2021-04-12 814 r = &phy->mt76->hw->wiphy->bands[band]->bitrates[rate_idx];
cc91747be98f2a Shayne Chen 2021-04-12 815 val = cck ? r->hw_value_short : r->hw_value;
cc91747be98f2a Shayne Chen 2021-04-12 816
cc91747be98f2a Shayne Chen 2021-04-12 817 mode = val >> 8;
cc91747be98f2a Shayne Chen 2021-04-12 818 rate_idx = val & 0xff;
cc91747be98f2a Shayne Chen 2021-04-12 819 break;
aadf09537c575d Shayne Chen 2020-10-22 820 default:
aadf09537c575d Shayne Chen 2020-10-22 821 mode = MT_PHY_TYPE_OFDM;
aadf09537c575d Shayne Chen 2020-10-22 822 break;
aadf09537c575d Shayne Chen 2020-10-22 823 }
aadf09537c575d Shayne Chen 2020-10-22 824
c742cd1ffffaef Ben Greear 2021-11-18 825 if (msta->test.txo_active) {
c742cd1ffffaef Ben Greear 2021-11-18 826 bw = td->txbw;
c742cd1ffffaef Ben Greear 2021-11-18 827 } else {
c918c74d06457e Shayne Chen 2020-12-04 828 switch (phy->mt76->chandef.width) {
aadf09537c575d Shayne Chen 2020-10-22 829 case NL80211_CHAN_WIDTH_40:
aadf09537c575d Shayne Chen 2020-10-22 830 bw = 1;
aadf09537c575d Shayne Chen 2020-10-22 831 break;
aadf09537c575d Shayne Chen 2020-10-22 832 case NL80211_CHAN_WIDTH_80:
aadf09537c575d Shayne Chen 2020-10-22 833 bw = 2;
aadf09537c575d Shayne Chen 2020-10-22 834 break;
aadf09537c575d Shayne Chen 2020-10-22 835 case NL80211_CHAN_WIDTH_80P80:
aadf09537c575d Shayne Chen 2020-10-22 836 case NL80211_CHAN_WIDTH_160:
aadf09537c575d Shayne Chen 2020-10-22 837 bw = 3;
aadf09537c575d Shayne Chen 2020-10-22 838 break;
aadf09537c575d Shayne Chen 2020-10-22 839 default:
aadf09537c575d Shayne Chen 2020-10-22 840 bw = 0;
aadf09537c575d Shayne Chen 2020-10-22 841 break;
aadf09537c575d Shayne Chen 2020-10-22 842 }
c742cd1ffffaef Ben Greear 2021-11-18 843 }
aadf09537c575d Shayne Chen 2020-10-22 844
aadf09537c575d Shayne Chen 2020-10-22 845 if (td->tx_rate_stbc && nss == 1) {
aadf09537c575d Shayne Chen 2020-10-22 846 nss++;
aadf09537c575d Shayne Chen 2020-10-22 847 rateval |= MT_TX_RATE_STBC;
aadf09537c575d Shayne Chen 2020-10-22 848 }
aadf09537c575d Shayne Chen 2020-10-22 849
aadf09537c575d Shayne Chen 2020-10-22 850 rateval |= FIELD_PREP(MT_TX_RATE_IDX, rate_idx) |
aadf09537c575d Shayne Chen 2020-10-22 851 FIELD_PREP(MT_TX_RATE_MODE, mode) |
aadf09537c575d Shayne Chen 2020-10-22 852 FIELD_PREP(MT_TX_RATE_NSS, nss - 1);
aadf09537c575d Shayne Chen 2020-10-22 853
c742cd1ffffaef Ben Greear 2021-11-18 854 /* TODO: Support per-skb txpower, p.15 of txpower doc, DW2 29:24. */
aadf09537c575d Shayne Chen 2020-10-22 855 txwi[2] |= cpu_to_le32(MT_TXD2_FIX_RATE);
aadf09537c575d Shayne Chen 2020-10-22 856
c742cd1ffffaef Ben Greear 2021-11-18 857 /* Looks like this sets tx attempt to exactly 1.
c742cd1ffffaef Ben Greear 2021-11-18 858 * TODO: Use td->tx_xmit_count, if in txo mode.
c742cd1ffffaef Ben Greear 2021-11-18 859 */
aadf09537c575d Shayne Chen 2020-10-22 860 le32p_replace_bits(&txwi[3], 1, MT_TXD3_REM_TX_COUNT);
aadf09537c575d Shayne Chen 2020-10-22 861 if (td->tx_rate_mode < MT76_TM_TX_MODE_HT)
aadf09537c575d Shayne Chen 2020-10-22 862 txwi[3] |= cpu_to_le32(MT_TXD3_BA_DISABLE);
aadf09537c575d Shayne Chen 2020-10-22 863
c742cd1ffffaef Ben Greear 2021-11-18 864 /* TODO: Take tx_dynbw into account in txo mode. */
aadf09537c575d Shayne Chen 2020-10-22 865 val = MT_TXD6_FIXED_BW |
aadf09537c575d Shayne Chen 2020-10-22 866 FIELD_PREP(MT_TXD6_BW, bw) |
aadf09537c575d Shayne Chen 2020-10-22 867 FIELD_PREP(MT_TXD6_TX_RATE, rateval) |
aadf09537c575d Shayne Chen 2020-10-22 868 FIELD_PREP(MT_TXD6_SGI, td->tx_rate_sgi);
aadf09537c575d Shayne Chen 2020-10-22 869
aadf09537c575d Shayne Chen 2020-10-22 870 /* for HE_SU/HE_EXT_SU PPDU
aadf09537c575d Shayne Chen 2020-10-22 871 * - 1x, 2x, 4x LTF + 0.8us GI
aadf09537c575d Shayne Chen 2020-10-22 872 * - 2x LTF + 1.6us GI, 4x LTF + 3.2us GI
aadf09537c575d Shayne Chen 2020-10-22 873 * for HE_MU PPDU
aadf09537c575d Shayne Chen 2020-10-22 874 * - 2x, 4x LTF + 0.8us GI
aadf09537c575d Shayne Chen 2020-10-22 875 * - 2x LTF + 1.6us GI, 4x LTF + 3.2us GI
aadf09537c575d Shayne Chen 2020-10-22 876 * for HE_TB PPDU
aadf09537c575d Shayne Chen 2020-10-22 877 * - 1x, 2x LTF + 1.6us GI
aadf09537c575d Shayne Chen 2020-10-22 878 * - 4x LTF + 3.2us GI
aadf09537c575d Shayne Chen 2020-10-22 879 */
aadf09537c575d Shayne Chen 2020-10-22 880 if (mode >= MT_PHY_TYPE_HE_SU)
aadf09537c575d Shayne Chen 2020-10-22 881 val |= FIELD_PREP(MT_TXD6_HELTF, td->tx_ltf);
aadf09537c575d Shayne Chen 2020-10-22 882
cc91747be98f2a Shayne Chen 2021-04-12 883 if (td->tx_rate_ldpc || (bw > 0 && mode >= MT_PHY_TYPE_HE_SU))
aadf09537c575d Shayne Chen 2020-10-22 884 val |= MT_TXD6_LDPC;
aadf09537c575d Shayne Chen 2020-10-22 885
cc91747be98f2a Shayne Chen 2021-04-12 886 txwi[3] &= ~cpu_to_le32(MT_TXD3_SN_VALID);
aadf09537c575d Shayne Chen 2020-10-22 887 txwi[6] |= cpu_to_le32(val);
c742cd1ffffaef Ben Greear 2021-11-18 888
c742cd1ffffaef Ben Greear 2021-11-18 889 if (msta->test.txo_active) {
c742cd1ffffaef Ben Greear 2021-11-18 890 /* see mt7915_tm_set_tx_frames */
c742cd1ffffaef Ben Greear 2021-11-18 891 static const u8 spe_idx_map[] = {0, 0, 1, 0, 3, 2, 4, 0,
c742cd1ffffaef Ben Greear 2021-11-18 892 9, 8, 6, 10, 16, 12, 18, 0};
c742cd1ffffaef Ben Greear 2021-11-18 893 u32 spe_idx;
c742cd1ffffaef Ben Greear 2021-11-18 894
c742cd1ffffaef Ben Greear 2021-11-18 895 if (td->tx_spe_idx) {
c742cd1ffffaef Ben Greear 2021-11-18 896 spe_idx = td->tx_spe_idx;
c742cd1ffffaef Ben Greear 2021-11-18 897 } else {
c742cd1ffffaef Ben Greear 2021-11-18 898 u8 tx_ant = td->tx_antenna_mask;
c742cd1ffffaef Ben Greear 2021-11-18 899
c742cd1ffffaef Ben Greear 2021-11-18 900 if (!tx_ant) {
c742cd1ffffaef Ben Greear 2021-11-18 901 /* use antenna mask that matches our nss */
c742cd1ffffaef Ben Greear 2021-11-18 902 tx_ant = GENMASK(nss - 1, 0);
c742cd1ffffaef Ben Greear 2021-11-18 903 }
c742cd1ffffaef Ben Greear 2021-11-18 904 spe_idx = spe_idx_map[tx_ant];
c742cd1ffffaef Ben Greear 2021-11-18 905 }
c742cd1ffffaef Ben Greear 2021-11-18 906 txwi[7] |= cpu_to_le32(FIELD_PREP(MT_TXD7_SPE_IDX, spe_idx));
c742cd1ffffaef Ben Greear 2021-11-18 907 } else {
aadf09537c575d Shayne Chen 2020-10-22 908 txwi[7] |= cpu_to_le32(FIELD_PREP(MT_TXD7_SPE_IDX,
78fc30a21cf117 Shayne Chen 2020-12-04 @909 phy->test.spe_idx));
c742cd1ffffaef Ben Greear 2021-11-18 910 }
aadf09537c575d Shayne Chen 2020-10-22 911 }
aadf09537c575d Shayne Chen 2020-10-22 912
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months