drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: sparse: incorrect type in initializer (different address spaces)
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 42eb8fdac2fc5d62392dcfcf0253753e821a97b0
commit: e72fcdb26cde72985c418b39f72ecaa222e1f4d5 powerpc/uaccess: Refactor get/put_user() and __get/put_user()
date: 8 months ago
config: powerpc64-randconfig-s032-20211118 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout e72fcdb26cde72985c418b39f72ecaa222e1f4d5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected char [noderef] __user *_pu_addr @@ got char *buf @@
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: expected char [noderef] __user *_pu_addr
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: got char *buf
>> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected char const [noderef] __user *_gu_addr @@ got char const *buf @@
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: expected char const [noderef] __user *_gu_addr
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: got char const *buf
vim +342 drivers/w1/slaves/w1_ds28e04.c
fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21 338
fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21 339 static ssize_t crccheck_show(struct device *dev, struct device_attribute *attr,
fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21 340 char *buf)
fbf7f7b4e2ae40 Markus Franke 2012-05-26 341 {
fbf7f7b4e2ae40 Markus Franke 2012-05-26 @342 if (put_user(w1_enable_crccheck + 0x30, buf))
fbf7f7b4e2ae40 Markus Franke 2012-05-26 343 return -EFAULT;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 344
fbf7f7b4e2ae40 Markus Franke 2012-05-26 345 return sizeof(w1_enable_crccheck);
fbf7f7b4e2ae40 Markus Franke 2012-05-26 346 }
fbf7f7b4e2ae40 Markus Franke 2012-05-26 347
fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21 348 static ssize_t crccheck_store(struct device *dev, struct device_attribute *attr,
fbf7f7b4e2ae40 Markus Franke 2012-05-26 349 const char *buf, size_t count)
fbf7f7b4e2ae40 Markus Franke 2012-05-26 350 {
fbf7f7b4e2ae40 Markus Franke 2012-05-26 351 char val;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 352
fbf7f7b4e2ae40 Markus Franke 2012-05-26 353 if (count != 1 || !buf)
fbf7f7b4e2ae40 Markus Franke 2012-05-26 354 return -EINVAL;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 355
fbf7f7b4e2ae40 Markus Franke 2012-05-26 @356 if (get_user(val, buf))
fbf7f7b4e2ae40 Markus Franke 2012-05-26 357 return -EFAULT;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 358
fbf7f7b4e2ae40 Markus Franke 2012-05-26 359 /* convert to decimal */
fbf7f7b4e2ae40 Markus Franke 2012-05-26 360 val = val - 0x30;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 361 if (val != 0 && val != 1)
fbf7f7b4e2ae40 Markus Franke 2012-05-26 362 return -EINVAL;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 363
fbf7f7b4e2ae40 Markus Franke 2012-05-26 364 /* set the new value */
fbf7f7b4e2ae40 Markus Franke 2012-05-26 365 w1_enable_crccheck = val;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 366
fbf7f7b4e2ae40 Markus Franke 2012-05-26 367 return sizeof(w1_enable_crccheck);
fbf7f7b4e2ae40 Markus Franke 2012-05-26 368 }
fbf7f7b4e2ae40 Markus Franke 2012-05-26 369
:::::: The code at line 342 was first introduced by commit
:::::: fbf7f7b4e2ae40f790828c86d31beff2d49e9ac8 w1: Add 1-wire slave device driver for DS28E04-100
:::::: TO: Markus Franke <franm(a)hrz.tu-chemnitz.de>
:::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
Re: [RFC PATCH 1/4] namespacefs: Introduce 'namespacefs'
by kernel test robot
Hi "Yordan,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linux/master]
[also build test WARNING on hnaz-mm/master linus/master v5.16-rc1 next-20211118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yordan-Karadzhov-VMware/namespac...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 8ab774587903771821b59471cc723bba6d893942
config: m68k-allyesconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/a6c499bca3021a2106f1dfcbddb6c4945...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yordan-Karadzhov-VMware/namespacefs-Proof-of-Concept/20211119-021813
git checkout a6c499bca3021a2106f1dfcbddb6c4945f521bae
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> fs/namespacefs/inode.c:159:1: warning: no previous prototype for 'namespacefs_create_file' [-Wmissing-prototypes]
159 | namespacefs_create_file(const char *name, struct dentry *parent,
| ^~~~~~~~~~~~~~~~~~~~~~~
>> fs/namespacefs/inode.c:168:1: warning: no previous prototype for 'namespacefs_create_dir' [-Wmissing-prototypes]
168 | namespacefs_create_dir(const char *name, struct dentry *parent,
| ^~~~~~~~~~~~~~~~~~~~~~
>> fs/namespacefs/inode.c:179:6: warning: no previous prototype for 'namespacefs_remove_dir' [-Wmissing-prototypes]
179 | void namespacefs_remove_dir(struct dentry *dentry)
| ^~~~~~~~~~~~~~~~~~~~~~
vim +/namespacefs_create_file +159 fs/namespacefs/inode.c
157
158 struct dentry *
> 159 namespacefs_create_file(const char *name, struct dentry *parent,
160 const struct user_namespace *user_ns,
161 const struct file_operations *fops,
162 void *data)
163 {
164 return create(name, parent, user_ns, fops, data);
165 }
166
167 struct dentry *
> 168 namespacefs_create_dir(const char *name, struct dentry *parent,
169 const struct user_namespace *user_ns)
170 {
171 return create(name, parent, user_ns, NULL, NULL);
172 }
173
174 static void remove_one(struct dentry *d)
175 {
176 release_namespacefs();
177 }
178
> 179 void namespacefs_remove_dir(struct dentry *dentry)
180 {
181 if (IS_ERR_OR_NULL(dentry))
182 return;
183
184 if (pin_fs())
185 return;
186
187 simple_recursive_removal(dentry, remove_one);
188 release_namespacefs();
189 }
190
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
Re: [RESEND PATCH net-next v2] net: phylink: Add helpers for c22 registers without MDIO
by kernel test robot
Hi Sean,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Sean-Anderson/net-phylink-Add-he...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git bb8cecf8ba127abca8ccd102207a59c55fdae515
config: hexagon-randconfig-r045-20211118 (attached as .config)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1af77aa70fbd03602e8db3d621fdaf4e8...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sean-Anderson/net-phylink-Add-helpers-for-c22-registers-without-MDIO/20211119-002726
git checkout 1af77aa70fbd03602e8db3d621fdaf4e8a301e98
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=hexagon
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/phy/phylink.c:2952:10: warning: result of comparison of constant -22 with expression of type 'u16' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare]
if (adv != -EINVAL) {
~~~ ^ ~~~~~~~
1 warning generated.
vim +2952 drivers/net/phy/phylink.c
2930
2931 /**
2932 * phylink_mii_c22_pcs_config() - configure clause 22 PCS
2933 * @pcs: a pointer to a &struct mdio_device.
2934 * @mode: link autonegotiation mode
2935 * @interface: the PHY interface mode being configured
2936 * @advertising: the ethtool advertisement mask
2937 *
2938 * Configure a Clause 22 PCS PHY with the appropriate negotiation
2939 * parameters for the @mode, @interface and @advertising parameters.
2940 * Returns negative error number on failure, zero if the advertisement
2941 * has not changed, or positive if there is a change.
2942 */
2943 int phylink_mii_c22_pcs_config(struct mdio_device *pcs, unsigned int mode,
2944 phy_interface_t interface,
2945 const unsigned long *advertising)
2946 {
2947 bool changed = 0;
2948 u16 adv, bmcr;
2949 int ret;
2950
2951 adv = phylink_mii_c22_pcs_encode_advertisement(interface, advertising);
> 2952 if (adv != -EINVAL) {
2953 ret = mdiobus_modify_changed(pcs->bus, pcs->addr,
2954 MII_ADVERTISE, 0xffff, adv);
2955 if (ret < 0)
2956 return ret;
2957 changed = ret;
2958 }
2959
2960 /* Ensure ISOLATE bit is disabled */
2961 if (mode == MLO_AN_INBAND &&
2962 linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, advertising))
2963 bmcr = BMCR_ANENABLE;
2964 else
2965 bmcr = 0;
2966
2967 ret = mdiodev_modify(pcs, MII_BMCR, BMCR_ANENABLE | BMCR_ISOLATE, bmcr);
2968 if (ret < 0)
2969 return ret;
2970
2971 return changed;
2972 }
2973 EXPORT_SYMBOL_GPL(phylink_mii_c22_pcs_config);
2974
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
[xilinx-xlnx:master 117/218] drivers/gpu/drm/xlnx/xlnx_pl_disp.c:115:15: error: implicit declaration of function 'xilinx_xdma_get_fid_err_flag'; did you mean 'xilinx_xdma_get_width_align'?
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx master
head: 0a88ef03d3015782318b4bc94ceb20dca375a01b
commit: c977ad8fb7ec282f8a309e6eb1c12cd271ea2b68 [117/218] drm: xlnx: pl_disp: Add plane properties for fid error detection
config: nios2-randconfig-r004-20211117 (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Xilinx/linux-xlnx/commit/c977ad8fb7ec282f8a309e6eb1c12...
git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xilinx-xlnx master
git checkout c977ad8fb7ec282f8a309e6eb1c12cd271ea2b68
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/xlnx/xlnx_pl_disp.c: In function 'xlnx_pl_disp_complete':
>> drivers/gpu/drm/xlnx/xlnx_pl_disp.c:115:15: error: implicit declaration of function 'xilinx_xdma_get_fid_err_flag'; did you mean 'xilinx_xdma_get_width_align'? [-Werror=implicit-function-declaration]
115 | ret = xilinx_xdma_get_fid_err_flag(xlnx_dma_chan->dma_chan,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| xilinx_xdma_get_width_align
>> drivers/gpu/drm/xlnx/xlnx_pl_disp.c:120:15: error: implicit declaration of function 'xilinx_xdma_get_fid_out'; did you mean 'xilinx_xdma_get_fid'? [-Werror=implicit-function-declaration]
120 | ret = xilinx_xdma_get_fid_out(xlnx_dma_chan->dma_chan,
| ^~~~~~~~~~~~~~~~~~~~~~~
| xilinx_xdma_get_fid
cc1: some warnings being treated as errors
vim +115 drivers/gpu/drm/xlnx/xlnx_pl_disp.c
99
100 /**
101 * xlnx_pl_disp_complete - vblank handler
102 * @param: parameter to vblank handler
103 *
104 * This function handles the vblank interrupt, and sends an event to
105 * CRTC object.
106 */
107 static void xlnx_pl_disp_complete(void *param)
108 {
109 struct xlnx_pl_disp *xlnx_pl_disp = param;
110 struct drm_device *drm = xlnx_pl_disp->drm;
111 struct xlnx_dma_chan *xlnx_dma_chan = xlnx_pl_disp->chan;
112 int ret;
113
114 /* Get fid err flag and fid out val */
> 115 ret = xilinx_xdma_get_fid_err_flag(xlnx_dma_chan->dma_chan,
116 &xlnx_pl_disp->fid_err_val);
117 if (ret)
118 dev_dbg(xlnx_pl_disp->dev, "failed to get fid_err info\n");
119
> 120 ret = xilinx_xdma_get_fid_out(xlnx_dma_chan->dma_chan,
121 &xlnx_pl_disp->fid_out_val);
122 if (ret)
123 dev_dbg(xlnx_pl_disp->dev, "failed to get fid_out info\n");
124
125 drm_handle_vblank(drm, 0);
126 }
127
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
drivers/net/wireless/mediatek/mt76/debugfs.c:77:9: warning: variable 'queued' set but not used
by kernel test robot
Hi Sean,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 42eb8fdac2fc5d62392dcfcf0253753e821a97b0
commit: 48fab5bbef4092d925ab3214773ad12e68807223 mt76: mt7921: introduce mt7921s support
date: 4 weeks ago
config: x86_64-randconfig-a006-20211118 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c46becf500df2a7fb4b4fce16178a036c344315a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 48fab5bbef4092d925ab3214773ad12e68807223
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/mediatek/mt76/debugfs.c:77:9: warning: variable 'queued' set but not used [-Wunused-but-set-variable]
int i, queued;
^
1 warning generated.
vim +/queued +77 drivers/net/wireless/mediatek/mt76/debugfs.c
17f1de56df0512 Felix Fietkau 2017-11-21 73
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 74 static int mt76_rx_queues_read(struct seq_file *s, void *data)
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 75 {
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 76 struct mt76_dev *dev = dev_get_drvdata(s->private);
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 @77 int i, queued;
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 78
2d8be76c16746f Lorenzo Bianconi 2021-09-25 79 seq_puts(s, " queue | hw-queued | head | tail |\n");
f473b42ac516be Felix Fietkau 2020-05-24 80 mt76_for_each_q_rx(dev, i) {
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 81 struct mt76_queue *q = &dev->q_rx[i];
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 82
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 83 queued = mt76_is_usb(dev) ? q->ndesc - q->queued : q->queued;
2d8be76c16746f Lorenzo Bianconi 2021-09-25 84 seq_printf(s, " %9d | %9d | %9d | %9d |\n",
2d8be76c16746f Lorenzo Bianconi 2021-09-25 85 i, q->queued, q->head, q->tail);
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 86 }
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 87
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 88 return 0;
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 89 }
6ea62c50792c6a Lorenzo Bianconi 2020-04-19 90
:::::: The code at line 77 was first introduced by commit
:::::: 6ea62c50792c6ad8b283c02d19f4304c7f3a3ccf mt76: add rx queues info to mt76 debugfs
:::::: TO: Lorenzo Bianconi <lorenzo(a)kernel.org>
:::::: CC: Felix Fietkau <nbd(a)nbd.name>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
Re: [Intel-gfx] [PATCH] drm/i915: Skip remap_io() calls for non-x86 platforms
by kernel test robot
Hi Mullati,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.16-rc1 next-20211118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mullati-Siva/drm-i915-Skip-remap...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/3cc867f614222b682fb1f739ff6db5133...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mullati-Siva/drm-i915-Skip-remap_io-calls-for-non-x86-platforms/20211118-191629
git checkout 3cc867f614222b682fb1f739ff6db5133d9352ad
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from <command-line>:
drivers/gpu/drm/i915/i915_mm.h:12:29: error: 'struct io_mapping' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
12 | struct io_mapping *iomap);
| ^~~~~~~~~~
drivers/gpu/drm/i915/i915_mm.h:10:29: error: 'struct vm_area_struct' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
10 | int remap_io_mapping(struct vm_area_struct *vma,
| ^~~~~~~~~~~~~~
>> drivers/gpu/drm/i915/i915_mm.h:15:42: error: unknown type name 'resource_size_t'
15 | struct scatterlist *sgl, resource_size_t iobase);
| ^~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/resource_size_t +15 drivers/gpu/drm/i915/i915_mm.h
8
9 #if IS_ENABLED(CONFIG_X86)
10 int remap_io_mapping(struct vm_area_struct *vma,
11 unsigned long addr, unsigned long pfn, unsigned long size,
12 struct io_mapping *iomap);
13 int remap_io_sg(struct vm_area_struct *vma,
14 unsigned long addr, unsigned long size,
> 15 struct scatterlist *sgl, resource_size_t iobase);
16 #else
17 static inline int remap_io_mapping(struct vm_area_struct *vma,
18 unsigned long addr, unsigned long pfn, unsigned long size,
19 struct io_mapping *iomap)
20 {
21 return 0;
22 }
23 static inline int remap_io_sg(struct vm_area_struct *vma,
24 unsigned long addr, unsigned long size,
25 struct scatterlist *sgl, resource_size_t iobase)
26 {
27 return 0;
28 }
29 #endif
30
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
[agd5f:drm-next 59/92] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:587:49: warning: converting the enum constant to a boolean
by kernel test robot
tree: https://gitlab.freedesktop.org/agd5f/linux.git drm-next
head: eaae0714f4a82df81a60c6aae74c568e8974a716
commit: f4d596654cc62c4f41efc772d62c6ec31d3e102a [59/92] drm/amd/display: Enable DSC over eDP
config: i386-randconfig-r005-20211118 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c46becf500df2a7fb4b4fce16178a036c344315a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
git fetch --no-tags agd5f drm-next
git checkout f4d596654cc62c4f41efc772d62c6ec31d3e102a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:587:49: warning: converting the enum constant to a boolean [-Wint-in-bool-context]
if (stream->signal == SIGNAL_TYPE_DISPLAY_PORT || SIGNAL_TYPE_EDP) {
^
1 warning generated.
vim +587 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c
531
532 bool dm_helpers_submit_i2c(
533 struct dc_context *ctx,
534 const struct dc_link *link,
535 struct i2c_command *cmd)
536 {
537 struct amdgpu_dm_connector *aconnector = link->priv;
538 struct i2c_msg *msgs;
539 int i = 0;
540 int num = cmd->number_of_payloads;
541 bool result;
542
543 if (!aconnector) {
544 DRM_ERROR("Failed to find connector for link!");
545 return false;
546 }
547
548 msgs = kcalloc(num, sizeof(struct i2c_msg), GFP_KERNEL);
549
550 if (!msgs)
551 return false;
552
553 for (i = 0; i < num; i++) {
554 msgs[i].flags = cmd->payloads[i].write ? 0 : I2C_M_RD;
555 msgs[i].addr = cmd->payloads[i].address;
556 msgs[i].len = cmd->payloads[i].length;
557 msgs[i].buf = cmd->payloads[i].data;
558 }
559
560 result = i2c_transfer(&aconnector->i2c->base, msgs, num) == num;
561
562 kfree(msgs);
563
564 return result;
565 }
566 bool dm_helpers_dp_write_dsc_enable(
567 struct dc_context *ctx,
568 const struct dc_stream_state *stream,
569 bool enable)
570 {
571 uint8_t enable_dsc = enable ? 1 : 0;
572 struct amdgpu_dm_connector *aconnector;
573 uint8_t ret = 0;
574
575 if (!stream)
576 return false;
577
578 if (stream->signal == SIGNAL_TYPE_DISPLAY_PORT_MST) {
579 aconnector = (struct amdgpu_dm_connector *)stream->dm_stream_context;
580
581 if (!aconnector->dsc_aux)
582 return false;
583
584 ret = drm_dp_dpcd_write(aconnector->dsc_aux, DP_DSC_ENABLE, &enable_dsc, 1);
585 }
586
> 587 if (stream->signal == SIGNAL_TYPE_DISPLAY_PORT || SIGNAL_TYPE_EDP) {
588 ret = dm_helpers_dp_write_dpcd(ctx, stream->link, DP_DSC_ENABLE, &enable_dsc, 1);
589 DC_LOG_DC("Send DSC %s to sst display\n", enable_dsc ? "enable" : "disable");
590 }
591
592 return (ret > 0);
593 }
594
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months
fs/gfs2/glock.c:1213: warning: expecting prototype for gfs2_holder_init(). Prototype was for __gfs2_holder_init() instead
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 42eb8fdac2fc5d62392dcfcf0253753e821a97b0
commit: b016d9a84abdd2efaa273814eaeb59e112ecffbd gfs2: Save ip from gfs2_glock_nq_init
date: 4 weeks ago
config: m68k-randconfig-r004-20211109 (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout b016d9a84abdd2efaa273814eaeb59e112ecffbd
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash fs/gfs2/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
fs/gfs2/glock.c:1213: warning: Function parameter or member 'ip' not described in '__gfs2_holder_init'
>> fs/gfs2/glock.c:1213: warning: expecting prototype for gfs2_holder_init(). Prototype was for __gfs2_holder_init() instead
vim +1213 fs/gfs2/glock.c
b3b94faa5fe596 David Teigland 2006-01-16 1201
b3b94faa5fe596 David Teigland 2006-01-16 1202 /**
b3b94faa5fe596 David Teigland 2006-01-16 1203 * gfs2_holder_init - initialize a struct gfs2_holder in the default way
b3b94faa5fe596 David Teigland 2006-01-16 1204 * @gl: the glock
b3b94faa5fe596 David Teigland 2006-01-16 1205 * @state: the state we're requesting
b3b94faa5fe596 David Teigland 2006-01-16 1206 * @flags: the modifier flags
b3b94faa5fe596 David Teigland 2006-01-16 1207 * @gh: the holder structure
b3b94faa5fe596 David Teigland 2006-01-16 1208 *
b3b94faa5fe596 David Teigland 2006-01-16 1209 */
b3b94faa5fe596 David Teigland 2006-01-16 1210
b016d9a84abdd2 Andreas Gruenbacher 2021-09-30 1211 void __gfs2_holder_init(struct gfs2_glock *gl, unsigned int state, u16 flags,
b016d9a84abdd2 Andreas Gruenbacher 2021-09-30 1212 struct gfs2_holder *gh, unsigned long ip)
b3b94faa5fe596 David Teigland 2006-01-16 @1213 {
b3b94faa5fe596 David Teigland 2006-01-16 1214 INIT_LIST_HEAD(&gh->gh_list);
b3b94faa5fe596 David Teigland 2006-01-16 1215 gh->gh_gl = gl;
b016d9a84abdd2 Andreas Gruenbacher 2021-09-30 1216 gh->gh_ip = ip;
b1e058da50f793 Pavel Emelyanov 2008-02-07 1217 gh->gh_owner_pid = get_pid(task_pid(current));
b3b94faa5fe596 David Teigland 2006-01-16 1218 gh->gh_state = state;
b3b94faa5fe596 David Teigland 2006-01-16 1219 gh->gh_flags = flags;
b3b94faa5fe596 David Teigland 2006-01-16 1220 gh->gh_error = 0;
b3b94faa5fe596 David Teigland 2006-01-16 1221 gh->gh_iflags = 0;
b3b94faa5fe596 David Teigland 2006-01-16 1222 gfs2_glock_hold(gl);
b3b94faa5fe596 David Teigland 2006-01-16 1223 }
b3b94faa5fe596 David Teigland 2006-01-16 1224
:::::: The code at line 1213 was first introduced by commit
:::::: b3b94faa5fe5968827ba0640ee9fba4b3e7f736e [GFS2] The core of GFS2
:::::: TO: David Teigland <teigland(a)redhat.com>
:::::: CC: Steven Whitehouse <swhiteho(a)redhat.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10 months