Re: [PATCH v3 06/18] tcp: authopt: Hook into tcp core
by kernel test robot
Hi Leonard,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 1fe5b01262844be03de98afdd56d1d393df04d7e]
url: https://github.com/0day-ci/linux/commits/Leonard-Crestez/tcp-Initial-supp...
base: 1fe5b01262844be03de98afdd56d1d393df04d7e
config: m68k-randconfig-s031-20211209 (https://download.01.org/0day-ci/archive/20211209/202112092027.W9QemnAk-lk...)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/5935c41094c73eec0e3c39119d7bfb22d...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Leonard-Crestez/tcp-Initial-support-for-RFC5925-auth-option/20211208-194125
git checkout 5935c41094c73eec0e3c39119d7bfb22de066c3b
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=m68k SHELL=/bin/bash net/ipv4/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
net/ipv4/tcp_minisocks.c: note: in included file:
>> include/net/tcp_authopt.h:145:40: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct tcp_authopt_info *tw_authopt_info @@ got struct tcp_authopt_info [noderef] __rcu *authopt_info @@
include/net/tcp_authopt.h:145:40: sparse: expected struct tcp_authopt_info *tw_authopt_info
include/net/tcp_authopt.h:145:40: sparse: got struct tcp_authopt_info [noderef] __rcu *authopt_info
vim +145 include/net/tcp_authopt.h
81
82 void tcp_authopt_free(struct sock *sk, struct tcp_authopt_info *info);
83 void tcp_authopt_clear(struct sock *sk);
84 int tcp_set_authopt(struct sock *sk, sockptr_t optval, unsigned int optlen);
85 int tcp_get_authopt_val(struct sock *sk, struct tcp_authopt *key);
86 int tcp_set_authopt_key(struct sock *sk, sockptr_t optval, unsigned int optlen);
87 struct tcp_authopt_key_info *__tcp_authopt_select_key(
88 const struct sock *sk,
89 struct tcp_authopt_info *info,
90 const struct sock *addr_sk,
91 u8 *rnextkeyid);
92 static inline struct tcp_authopt_key_info *tcp_authopt_select_key(
93 const struct sock *sk,
94 const struct sock *addr_sk,
95 struct tcp_authopt_info **info,
96 u8 *rnextkeyid)
97 {
98 if (tcp_authopt_needed) {
99 *info = rcu_dereference(tcp_sk(sk)->authopt_info);
100
101 if (*info)
102 return __tcp_authopt_select_key(sk, *info, addr_sk, rnextkeyid);
103 }
104 return NULL;
105 }
106 int tcp_authopt_hash(
107 char *hash_location,
108 struct tcp_authopt_key_info *key,
109 struct tcp_authopt_info *info,
110 struct sock *sk, struct sk_buff *skb);
111 int __tcp_authopt_openreq(struct sock *newsk, const struct sock *oldsk, struct request_sock *req);
112 static inline int tcp_authopt_openreq(
113 struct sock *newsk,
114 const struct sock *oldsk,
115 struct request_sock *req)
116 {
117 if (!rcu_dereference(tcp_sk(oldsk)->authopt_info))
118 return 0;
119 else
120 return __tcp_authopt_openreq(newsk, oldsk, req);
121 }
122 void __tcp_authopt_finish_connect(struct sock *sk, struct sk_buff *skb,
123 struct tcp_authopt_info *info);
124 static inline void tcp_authopt_finish_connect(struct sock *sk, struct sk_buff *skb)
125 {
126 struct tcp_authopt_info *info;
127
128 if (tcp_authopt_needed) {
129 info = rcu_dereference_protected(tcp_sk(sk)->authopt_info,
130 lockdep_sock_is_held(sk));
131
132 if (info)
133 __tcp_authopt_finish_connect(sk, skb, info);
134 }
135 }
136 static inline void tcp_authopt_time_wait(
137 struct tcp_timewait_sock *tcptw,
138 struct tcp_sock *tp)
139 {
140 if (tcp_authopt_needed) {
141 /* Transfer ownership of authopt_info to the twsk
142 * This requires no other users of the origin sock.
143 */
144 sock_owned_by_me((struct sock *)tp);
> 145 tcptw->tw_authopt_info = tp->authopt_info;
146 tp->authopt_info = NULL;
147 } else {
148 tcptw->tw_authopt_info = NULL;
149 }
150 }
151 /** tcp_authopt_inbound_check - check for valid TCP-AO signature.
152 *
153 * Return negative ERRNO on error, 0 if not present and 1 if present and valid.
154 *
155 * If the AO signature is present and valid then caller skips MD5 check.
156 */
157 int __tcp_authopt_inbound_check(
158 struct sock *sk,
159 struct sk_buff *skb,
160 struct tcp_authopt_info *info,
161 const u8 *opt);
162 static inline int tcp_authopt_inbound_check(struct sock *sk, struct sk_buff *skb, const u8 *opt)
163 {
164 if (tcp_authopt_needed) {
165 struct tcp_authopt_info *info = rcu_dereference(tcp_sk(sk)->authopt_info);
166
167 if (info)
168 return __tcp_authopt_inbound_check(sk, skb, info, opt);
169 }
170 return 0;
171 }
172 static inline int tcp_authopt_inbound_check_req(struct request_sock *req, struct sk_buff *skb,
173 const u8 *opt)
174 {
175 if (tcp_authopt_needed) {
176 struct sock *lsk = req->rsk_listener;
177 struct tcp_authopt_info *info = rcu_dereference(tcp_sk(lsk)->authopt_info);
178
179 if (info)
180 return __tcp_authopt_inbound_check((struct sock *)req, skb, info, opt);
181 }
182 return 0;
183 }
184 #else
185 static inline int tcp_set_authopt(struct sock *sk, sockptr_t optval, unsigned int optlen)
186 {
187 return -ENOPROTOOPT;
188 }
189 static inline int tcp_get_authopt_val(struct sock *sk, struct tcp_authopt *key)
190 {
191 return -ENOPROTOOPT;
192 }
193 static inline void tcp_authopt_free(struct sock *sk, struct tcp_authopt_info *info)
194 {
195 }
196 static inline void tcp_authopt_clear(struct sock *sk)
197 {
198 }
199 static inline int tcp_set_authopt_key(struct sock *sk, sockptr_t optval, unsigned int optlen)
200 {
201 return -ENOPROTOOPT;
202 }
203 static inline int tcp_authopt_hash(
204 char *hash_location,
205 struct tcp_authopt_key_info *key,
206 struct tcp_authopt_key *info,
207 struct sock *sk, struct sk_buff *skb)
208 {
209 return -EINVAL;
210 }
211 static inline int tcp_authopt_openreq(struct sock *newsk,
212 const struct sock *oldsk,
213 struct request_sock *req)
214 {
215 return 0;
216 }
217 static inline void tcp_authopt_finish_connect(struct sock *sk, struct sk_buff *skb)
218 {
219 }
220 static inline void tcp_authopt_time_wait(
221 struct tcp_timewait_sock *tcptw,
222 struct tcp_sock *tp)
223 {
224 }
225 static inline int tcp_authopt_inbound_check(struct sock *sk, struct sk_buff *skb, const u8 *opt)
226 {
227 return 0;
228 }
229 static inline int tcp_authopt_inbound_check_req(struct request_sock *sk, struct sk_buff *skb,
230 const u8 *opt)
231 {
232 return 0;
233 }
234 #endif
235
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 2 weeks
Re: [PATCH 13/73] sata_dwc_460ex: use generic tracepoints
by kernel test robot
Hi Hannes,
I love your patch! Perhaps something to improve:
[auto build test WARNING on rostedt-trace/for-next]
[also build test WARNING on axboe-block/for-next linus/master v5.16-rc4 next-20211208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/libata-rework-lo...
base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: i386-randconfig-a012-20211209 (https://download.01.org/0day-ci/archive/20211209/202112092036.fKbXi4EI-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/b3bb5eac4170da8a3e9c477ad4c1c8f97...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hannes-Reinecke/libata-rework-logging-take-II/20211209-003634
git checkout b3bb5eac4170da8a3e9c477ad4c1c8f97164abc5
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ata/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/ata/sata_dwc_460ex.c:744:5: error: implicit declaration of function 'get_dma_dir_descript' [-Werror,-Wimplicit-function-declaration]
get_dma_dir_descript(qc->dma_dir),
^
>> drivers/ata/sata_dwc_460ex.c:744:5: warning: format specifies type 'char *' but the argument has type 'int' [-Wformat]
get_dma_dir_descript(qc->dma_dir),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:150:67: note: expanded from macro 'dev_info'
dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
_p_func(dev, fmt, ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
1 warning and 1 error generated.
vim +744 drivers/ata/sata_dwc_460ex.c
62936009f35a66 Rupjyoti Sarmah 2010-07-06 724
62936009f35a66 Rupjyoti Sarmah 2010-07-06 725 static void sata_dwc_dma_xfer_complete(struct ata_port *ap, u32 check_status)
62936009f35a66 Rupjyoti Sarmah 2010-07-06 726 {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 727 struct ata_queued_cmd *qc;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 728 struct sata_dwc_device_port *hsdevp = HSDEVP_FROM_AP(ap);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 729 struct sata_dwc_device *hsdev = HSDEV_FROM_AP(ap);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 730 u8 tag = 0;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 731
62936009f35a66 Rupjyoti Sarmah 2010-07-06 732 tag = ap->link.active_tag;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 733 qc = ata_qc_from_tag(ap, tag);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 734 if (!qc) {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 735 dev_err(ap->dev, "failed to get qc");
62936009f35a66 Rupjyoti Sarmah 2010-07-06 736 return;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 737 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 738
62936009f35a66 Rupjyoti Sarmah 2010-07-06 739 #ifdef DEBUG_NCQ
62936009f35a66 Rupjyoti Sarmah 2010-07-06 740 if (tag > 0) {
d578514b271e7c Andy Shevchenko 2015-03-03 741 dev_info(ap->dev,
d578514b271e7c Andy Shevchenko 2015-03-03 742 "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
4e5b6260cc9ba8 Jens Axboe 2018-05-11 743 __func__, qc->hw_tag, qc->tf.command,
84b47e3b16f8a5 Sergei Shtylyov 2011-01-28 @744 get_dma_dir_descript(qc->dma_dir),
84b47e3b16f8a5 Sergei Shtylyov 2011-01-28 745 get_prot_descript(qc->tf.protocol),
ee81d6cc8e8aa6 Mans Rullgard 2016-04-26 746 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a66 Rupjyoti Sarmah 2010-07-06 747 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 748 #endif
62936009f35a66 Rupjyoti Sarmah 2010-07-06 749
62936009f35a66 Rupjyoti Sarmah 2010-07-06 750 if (ata_is_dma(qc->tf.protocol)) {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 751 if (hsdevp->dma_pending[tag] == SATA_DWC_DMA_PENDING_NONE) {
d578514b271e7c Andy Shevchenko 2015-03-03 752 dev_err(ap->dev,
d578514b271e7c Andy Shevchenko 2015-03-03 753 "%s DMA protocol RX and TX DMA not pending dmacr: 0x%08x\n",
d578514b271e7c Andy Shevchenko 2015-03-03 754 __func__,
ee81d6cc8e8aa6 Mans Rullgard 2016-04-26 755 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a66 Rupjyoti Sarmah 2010-07-06 756 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 757
62936009f35a66 Rupjyoti Sarmah 2010-07-06 758 hsdevp->dma_pending[tag] = SATA_DWC_DMA_PENDING_NONE;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 759 sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 760 ap->link.active_tag = ATA_TAG_POISON;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 761 } else {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 762 sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 763 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 764 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 765
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 2 weeks
[hare-scsi-devel:ata-trace.v3 13/73] drivers/ata/sata_dwc_460ex.c:744:26: error: implicit declaration of function 'get_dma_dir_descript'; did you mean 'get_prot_descript'?
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git ata-trace.v3
head: d973dee7af0328b9176e4a1710fb73093c334698
commit: a8252508eadb132c62be4596a50701e1f261e92d [13/73] sata_dwc_460ex: use generic tracepoints
config: arm-buildonly-randconfig-r005-20211207 (https://download.01.org/0day-ci/archive/20211209/202112091014.OAV9O2tr-lk...)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commi...
git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
git fetch --no-tags hare-scsi-devel ata-trace.v3
git checkout a8252508eadb132c62be4596a50701e1f261e92d
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/ata/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from drivers/ata/sata_dwc_460ex.c:28:
drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_dma_xfer_complete':
>> drivers/ata/sata_dwc_460ex.c:744:26: error: implicit declaration of function 'get_dma_dir_descript'; did you mean 'get_prot_descript'? [-Werror=implicit-function-declaration]
744 | get_dma_dir_descript(qc->dma_dir),
| ^~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:37: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/ata/sata_dwc_460ex.c:741:17: note: in expansion of macro 'dev_info'
741 | dev_info(ap->dev,
| ^~~~~~~~
>> drivers/ata/sata_dwc_460ex.c:742:26: warning: format '%s' expects argument of type 'char *', but argument 6 has type 'int' [-Wformat=]
742 | "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:150:58: note: in expansion of macro 'dev_fmt'
150 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/ata/sata_dwc_460ex.c:741:17: note: in expansion of macro 'dev_info'
741 | dev_info(ap->dev,
| ^~~~~~~~
drivers/ata/sata_dwc_460ex.c:742:57: note: format string is defined here
742 | "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
| ~^
| |
| char *
| %d
cc1: some warnings being treated as errors
vim +744 drivers/ata/sata_dwc_460ex.c
62936009f35a665 Rupjyoti Sarmah 2010-07-06 724
62936009f35a665 Rupjyoti Sarmah 2010-07-06 725 static void sata_dwc_dma_xfer_complete(struct ata_port *ap, u32 check_status)
62936009f35a665 Rupjyoti Sarmah 2010-07-06 726 {
62936009f35a665 Rupjyoti Sarmah 2010-07-06 727 struct ata_queued_cmd *qc;
62936009f35a665 Rupjyoti Sarmah 2010-07-06 728 struct sata_dwc_device_port *hsdevp = HSDEVP_FROM_AP(ap);
62936009f35a665 Rupjyoti Sarmah 2010-07-06 729 struct sata_dwc_device *hsdev = HSDEV_FROM_AP(ap);
62936009f35a665 Rupjyoti Sarmah 2010-07-06 730 u8 tag = 0;
62936009f35a665 Rupjyoti Sarmah 2010-07-06 731
62936009f35a665 Rupjyoti Sarmah 2010-07-06 732 tag = ap->link.active_tag;
62936009f35a665 Rupjyoti Sarmah 2010-07-06 733 qc = ata_qc_from_tag(ap, tag);
62936009f35a665 Rupjyoti Sarmah 2010-07-06 734 if (!qc) {
62936009f35a665 Rupjyoti Sarmah 2010-07-06 735 dev_err(ap->dev, "failed to get qc");
62936009f35a665 Rupjyoti Sarmah 2010-07-06 736 return;
62936009f35a665 Rupjyoti Sarmah 2010-07-06 737 }
62936009f35a665 Rupjyoti Sarmah 2010-07-06 738
62936009f35a665 Rupjyoti Sarmah 2010-07-06 739 #ifdef DEBUG_NCQ
62936009f35a665 Rupjyoti Sarmah 2010-07-06 740 if (tag > 0) {
d578514b271e7c8 Andy Shevchenko 2015-03-03 741 dev_info(ap->dev,
d578514b271e7c8 Andy Shevchenko 2015-03-03 @742 "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
4e5b6260cc9ba84 Jens Axboe 2018-05-11 743 __func__, qc->hw_tag, qc->tf.command,
84b47e3b16f8a5b Sergei Shtylyov 2011-01-28 @744 get_dma_dir_descript(qc->dma_dir),
84b47e3b16f8a5b Sergei Shtylyov 2011-01-28 745 get_prot_descript(qc->tf.protocol),
ee81d6cc8e8aa66 Mans Rullgard 2016-04-26 746 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a665 Rupjyoti Sarmah 2010-07-06 747 }
62936009f35a665 Rupjyoti Sarmah 2010-07-06 748 #endif
62936009f35a665 Rupjyoti Sarmah 2010-07-06 749
62936009f35a665 Rupjyoti Sarmah 2010-07-06 750 if (ata_is_dma(qc->tf.protocol)) {
62936009f35a665 Rupjyoti Sarmah 2010-07-06 751 if (hsdevp->dma_pending[tag] == SATA_DWC_DMA_PENDING_NONE) {
d578514b271e7c8 Andy Shevchenko 2015-03-03 752 dev_err(ap->dev,
d578514b271e7c8 Andy Shevchenko 2015-03-03 753 "%s DMA protocol RX and TX DMA not pending dmacr: 0x%08x\n",
d578514b271e7c8 Andy Shevchenko 2015-03-03 754 __func__,
ee81d6cc8e8aa66 Mans Rullgard 2016-04-26 755 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a665 Rupjyoti Sarmah 2010-07-06 756 }
62936009f35a665 Rupjyoti Sarmah 2010-07-06 757
62936009f35a665 Rupjyoti Sarmah 2010-07-06 758 hsdevp->dma_pending[tag] = SATA_DWC_DMA_PENDING_NONE;
62936009f35a665 Rupjyoti Sarmah 2010-07-06 759 sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a665 Rupjyoti Sarmah 2010-07-06 760 ap->link.active_tag = ATA_TAG_POISON;
62936009f35a665 Rupjyoti Sarmah 2010-07-06 761 } else {
62936009f35a665 Rupjyoti Sarmah 2010-07-06 762 sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a665 Rupjyoti Sarmah 2010-07-06 763 }
62936009f35a665 Rupjyoti Sarmah 2010-07-06 764 }
62936009f35a665 Rupjyoti Sarmah 2010-07-06 765
:::::: The code at line 744 was first introduced by commit
:::::: 84b47e3b16f8a5bb416cd55774d679ebbdb19072 sata_dwc_460ex: fix misuse of ata_get_cmd_descript()
:::::: TO: Sergei Shtylyov <sshtylyov(a)ru.mvista.com>
:::::: CC: Jeff Garzik <jgarzik(a)redhat.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 2 weeks
Re: [PATCH] net: bonding: Add support for IPV6 ns/na
by kernel test robot
Hi Sun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.16-rc4 next-20211208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sun-Shouxin/net-bonding-Add-supp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2a987e65025e2b79c6d453b78cb5985ac6e5eb26
config: riscv-randconfig-c006-20211209 (https://download.01.org/0day-ci/archive/20211209/202112091907.6iLel0c9-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/ab724c314fcdcaa60e70c590850b2ce57...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sun-Shouxin/net-bonding-Add-support-for-IPV6-ns-na/20211209-150108
git checkout ab724c314fcdcaa60e70c590850b2ce57430d7fa
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/net/bonding/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/net/bonding/bond_alb.c:1307:26: error: implicit declaration of function 'csum_ipv6_magic' [-Werror,-Wimplicit-function-declaration]
icmp6h->icmp6_cksum = csum_ipv6_magic(&ip6hdr->saddr,
^
drivers/net/bonding/bond_alb.c:1307:26: note: did you mean 'csum_tcpudp_magic'?
include/asm-generic/checksum.h:52:1: note: 'csum_tcpudp_magic' declared here
csum_tcpudp_magic(__be32 saddr, __be32 daddr, __u32 len,
^
1 error generated.
vim +/csum_ipv6_magic +1307 drivers/net/bonding/bond_alb.c
1272
1273 static void alb_change_nd_option(struct sk_buff *skb, void *data)
1274 {
1275 struct nd_msg *msg = (struct nd_msg *)skb_transport_header(skb);
1276 struct nd_opt_hdr *nd_opt = (struct nd_opt_hdr *)msg->opt;
1277 struct net_device *dev = skb->dev;
1278 struct icmp6hdr *icmp6h = icmp6_hdr(skb);
1279 struct ipv6hdr *ip6hdr = ipv6_hdr(skb);
1280 u8 *lladdr = NULL;
1281 u32 ndoptlen = skb_tail_pointer(skb) - (skb_transport_header(skb) +
1282 offsetof(struct nd_msg, opt));
1283
1284 while (ndoptlen) {
1285 int l;
1286
1287 switch (nd_opt->nd_opt_type) {
1288 case ND_OPT_SOURCE_LL_ADDR:
1289 case ND_OPT_TARGET_LL_ADDR:
1290 lladdr = ndisc_opt_addr_data(nd_opt, dev);
1291 break;
1292
1293 default:
1294 break;
1295 }
1296
1297 l = nd_opt->nd_opt_len << 3;
1298
1299 if (ndoptlen < l || l == 0)
1300 return;
1301
1302 if (lladdr) {
1303 memcpy(lladdr, data, dev->addr_len);
1304 lladdr = NULL;
1305 icmp6h->icmp6_cksum = 0;
1306
> 1307 icmp6h->icmp6_cksum = csum_ipv6_magic(&ip6hdr->saddr,
1308 &ip6hdr->daddr,
1309 ntohs(ip6hdr->payload_len),
1310 IPPROTO_ICMPV6,
1311 csum_partial(icmp6h,
1312 ntohs(ip6hdr->payload_len), 0));
1313 lladdr = NULL;
1314 }
1315 ndoptlen -= l;
1316 nd_opt = ((void *)nd_opt) + l;
1317 }
1318 }
1319
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 2 weeks
Re: [PATCH 13/73] sata_dwc_460ex: use generic tracepoints
by kernel test robot
Hi Hannes,
I love your patch! Perhaps something to improve:
[auto build test WARNING on rostedt-trace/for-next]
[also build test WARNING on axboe-block/for-next linus/master v5.16-rc4 next-20211208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/libata-rework-lo...
base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20211209/202112091923.b2cQMxCn-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/b3bb5eac4170da8a3e9c477ad4c1c8f97...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hannes-Reinecke/libata-rework-logging-take-II/20211209-003634
git checkout b3bb5eac4170da8a3e9c477ad4c1c8f97164abc5
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/ata/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from drivers/ata/sata_dwc_460ex.c:28:
drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_dma_xfer_complete':
drivers/ata/sata_dwc_460ex.c:744:5: error: implicit declaration of function 'get_dma_dir_descript'; did you mean 'get_prot_descript'? [-Werror=implicit-function-declaration]
744 | get_dma_dir_descript(qc->dma_dir),
| ^~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/ata/sata_dwc_460ex.c:741:3: note: in expansion of macro 'dev_info'
741 | dev_info(ap->dev,
| ^~~~~~~~
>> drivers/ata/sata_dwc_460ex.c:742:5: warning: format '%s' expects argument of type 'char *', but argument 6 has type 'int' [-Wformat=]
742 | "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:16: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:150:51: note: in expansion of macro 'dev_fmt'
150 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/ata/sata_dwc_460ex.c:741:3: note: in expansion of macro 'dev_info'
741 | dev_info(ap->dev,
| ^~~~~~~~
drivers/ata/sata_dwc_460ex.c:742:36: note: format string is defined here
742 | "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
| ~^
| |
| char *
| %d
cc1: some warnings being treated as errors
vim +742 drivers/ata/sata_dwc_460ex.c
62936009f35a66 Rupjyoti Sarmah 2010-07-06 724
62936009f35a66 Rupjyoti Sarmah 2010-07-06 725 static void sata_dwc_dma_xfer_complete(struct ata_port *ap, u32 check_status)
62936009f35a66 Rupjyoti Sarmah 2010-07-06 726 {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 727 struct ata_queued_cmd *qc;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 728 struct sata_dwc_device_port *hsdevp = HSDEVP_FROM_AP(ap);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 729 struct sata_dwc_device *hsdev = HSDEV_FROM_AP(ap);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 730 u8 tag = 0;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 731
62936009f35a66 Rupjyoti Sarmah 2010-07-06 732 tag = ap->link.active_tag;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 733 qc = ata_qc_from_tag(ap, tag);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 734 if (!qc) {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 735 dev_err(ap->dev, "failed to get qc");
62936009f35a66 Rupjyoti Sarmah 2010-07-06 736 return;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 737 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 738
62936009f35a66 Rupjyoti Sarmah 2010-07-06 739 #ifdef DEBUG_NCQ
62936009f35a66 Rupjyoti Sarmah 2010-07-06 740 if (tag > 0) {
d578514b271e7c Andy Shevchenko 2015-03-03 741 dev_info(ap->dev,
d578514b271e7c Andy Shevchenko 2015-03-03 @742 "%s tag=%u cmd=0x%02x dma dir=%s proto=%s dmacr=0x%08x\n",
4e5b6260cc9ba8 Jens Axboe 2018-05-11 743 __func__, qc->hw_tag, qc->tf.command,
84b47e3b16f8a5 Sergei Shtylyov 2011-01-28 @744 get_dma_dir_descript(qc->dma_dir),
84b47e3b16f8a5 Sergei Shtylyov 2011-01-28 745 get_prot_descript(qc->tf.protocol),
ee81d6cc8e8aa6 Mans Rullgard 2016-04-26 746 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a66 Rupjyoti Sarmah 2010-07-06 747 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 748 #endif
62936009f35a66 Rupjyoti Sarmah 2010-07-06 749
62936009f35a66 Rupjyoti Sarmah 2010-07-06 750 if (ata_is_dma(qc->tf.protocol)) {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 751 if (hsdevp->dma_pending[tag] == SATA_DWC_DMA_PENDING_NONE) {
d578514b271e7c Andy Shevchenko 2015-03-03 752 dev_err(ap->dev,
d578514b271e7c Andy Shevchenko 2015-03-03 753 "%s DMA protocol RX and TX DMA not pending dmacr: 0x%08x\n",
d578514b271e7c Andy Shevchenko 2015-03-03 754 __func__,
ee81d6cc8e8aa6 Mans Rullgard 2016-04-26 755 sata_dwc_readl(&hsdev->sata_dwc_regs->dmacr));
62936009f35a66 Rupjyoti Sarmah 2010-07-06 756 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 757
62936009f35a66 Rupjyoti Sarmah 2010-07-06 758 hsdevp->dma_pending[tag] = SATA_DWC_DMA_PENDING_NONE;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 759 sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 760 ap->link.active_tag = ATA_TAG_POISON;
62936009f35a66 Rupjyoti Sarmah 2010-07-06 761 } else {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 762 sata_dwc_qc_complete(ap, qc, check_status);
62936009f35a66 Rupjyoti Sarmah 2010-07-06 763 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 764 }
62936009f35a66 Rupjyoti Sarmah 2010-07-06 765
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 2 weeks
include/linux/compiler_types.h:328:45: error: call to '__compiletime_assert_202' declared with attribute error: BUILD_BUG failed
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: cd8c917a56f20f48748dd43d9ae3caff51d5b987
commit: 4775bc63f880001ee4fbd6456b12ab04674149e3 clocksource/arm_arch_timer: Add build-time guards for unhandled register accesses
date: 7 weeks ago
config: arm64-randconfig-r003-20211207 (https://download.01.org/0day-ci/archive/20211207/202112071925.61r0Z8V1-lk...)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 4775bc63f880001ee4fbd6456b12ab04674149e3
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from <command-line>:
In function 'arch_timer_reg_read_cp15',
inlined from 'arch_timer_reg_read' at drivers/clocksource/arm_arch_timer.c:166:9,
inlined from 'erratum_set_next_event_tval_generic' at drivers/clocksource/arm_arch_timer.c:414:9:
>> include/linux/compiler_types.h:328:45: error: call to '__compiletime_assert_202' declared with attribute error: BUILD_BUG failed
328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^
include/linux/compiler_types.h:309:25: note: in definition of macro '__compiletime_assert'
309 | prefix ## suffix(); \
| ^~~~~~
include/linux/compiler_types.h:328:9: note: in expansion of macro '_compiletime_assert'
328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:59:21: note: in expansion of macro 'BUILD_BUG_ON_MSG'
59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed")
| ^~~~~~~~~~~~~~~~
arch/arm64/include/asm/arch_timer.h:159:9: note: in expansion of macro 'BUILD_BUG'
159 | BUILD_BUG();
| ^~~~~~~~~
In function 'arch_timer_reg_write_cp15',
inlined from 'arch_timer_reg_write' at drivers/clocksource/arm_arch_timer.c:131:3,
inlined from 'erratum_set_next_event_tval_generic' at drivers/clocksource/arm_arch_timer.c:426:2:
include/linux/compiler_types.h:328:45: error: call to '__compiletime_assert_199' declared with attribute error: BUILD_BUG failed
328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^
include/linux/compiler_types.h:309:25: note: in definition of macro '__compiletime_assert'
309 | prefix ## suffix(); \
| ^~~~~~
include/linux/compiler_types.h:328:9: note: in expansion of macro '_compiletime_assert'
328 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:59:21: note: in expansion of macro 'BUILD_BUG_ON_MSG'
59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed")
| ^~~~~~~~~~~~~~~~
arch/arm64/include/asm/arch_timer.h:130:17: note: in expansion of macro 'BUILD_BUG'
130 | BUILD_BUG();
| ^~~~~~~~~
vim +/__compiletime_assert_202 +328 include/linux/compiler_types.h
eb5c2d4b45e3d2 Will Deacon 2020-07-21 314
eb5c2d4b45e3d2 Will Deacon 2020-07-21 315 #define _compiletime_assert(condition, msg, prefix, suffix) \
eb5c2d4b45e3d2 Will Deacon 2020-07-21 316 __compiletime_assert(condition, msg, prefix, suffix)
eb5c2d4b45e3d2 Will Deacon 2020-07-21 317
eb5c2d4b45e3d2 Will Deacon 2020-07-21 318 /**
eb5c2d4b45e3d2 Will Deacon 2020-07-21 319 * compiletime_assert - break build and emit msg if condition is false
eb5c2d4b45e3d2 Will Deacon 2020-07-21 320 * @condition: a compile-time constant condition to check
eb5c2d4b45e3d2 Will Deacon 2020-07-21 321 * @msg: a message to emit if condition is false
eb5c2d4b45e3d2 Will Deacon 2020-07-21 322 *
eb5c2d4b45e3d2 Will Deacon 2020-07-21 323 * In tradition of POSIX assert, this macro will break the build if the
eb5c2d4b45e3d2 Will Deacon 2020-07-21 324 * supplied condition is *false*, emitting the supplied error message if the
eb5c2d4b45e3d2 Will Deacon 2020-07-21 325 * compiler has support to do so.
eb5c2d4b45e3d2 Will Deacon 2020-07-21 326 */
eb5c2d4b45e3d2 Will Deacon 2020-07-21 327 #define compiletime_assert(condition, msg) \
eb5c2d4b45e3d2 Will Deacon 2020-07-21 @328 _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
eb5c2d4b45e3d2 Will Deacon 2020-07-21 329
:::::: The code at line 328 was first introduced by commit
:::::: eb5c2d4b45e3d2d5d052ea6b8f1463976b1020d5 compiler.h: Move compiletime_assert() macros into compiler_types.h
:::::: TO: Will Deacon <will(a)kernel.org>
:::::: CC: Will Deacon <will(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 2 weeks
drivers/spi/spi-sh-msiof.c:1072:34: warning: unused variable 'sh_msiof_match'
by kernel test robot
Hi Stephen,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2a987e65025e2b79c6d453b78cb5985ac6e5eb26
commit: bbd7ffdbef6888459f301c5889f3b14ada38b913 clk: Allow the common clk framework to be selectable
date: 1 year, 7 months ago
config: hexagon-buildonly-randconfig-r003-20211209 (https://download.01.org/0day-ci/archive/20211209/202112091948.lD9JYOeh-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout bbd7ffdbef6888459f301c5889f3b14ada38b913
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mmc/host/ drivers/spi/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/spi/spi-sh-msiof.c:1072:34: warning: unused variable 'sh_msiof_match' [-Wunused-const-variable]
static const struct of_device_id sh_msiof_match[] = {
^
1 warning generated.
vim +/sh_msiof_match +1072 drivers/spi/spi-sh-msiof.c
50a7e23f536779 Geert Uytterhoeven 2014-02-25 1071
50a7e23f536779 Geert Uytterhoeven 2014-02-25 @1072 static const struct of_device_id sh_msiof_match[] = {
50a7e23f536779 Geert Uytterhoeven 2014-02-25 1073 { .compatible = "renesas,sh-mobile-msiof", .data = &sh_data },
bdacfc7b6216dd Fabrizio Castro 2017-09-25 1074 { .compatible = "renesas,msiof-r8a7743", .data = &rcar_gen2_data },
bdacfc7b6216dd Fabrizio Castro 2017-09-25 1075 { .compatible = "renesas,msiof-r8a7745", .data = &rcar_gen2_data },
61a8dec502b873 Geert Uytterhoeven 2017-07-12 1076 { .compatible = "renesas,msiof-r8a7790", .data = &rcar_gen2_data },
61a8dec502b873 Geert Uytterhoeven 2017-07-12 1077 { .compatible = "renesas,msiof-r8a7791", .data = &rcar_gen2_data },
61a8dec502b873 Geert Uytterhoeven 2017-07-12 1078 { .compatible = "renesas,msiof-r8a7792", .data = &rcar_gen2_data },
61a8dec502b873 Geert Uytterhoeven 2017-07-12 1079 { .compatible = "renesas,msiof-r8a7793", .data = &rcar_gen2_data },
61a8dec502b873 Geert Uytterhoeven 2017-07-12 1080 { .compatible = "renesas,msiof-r8a7794", .data = &rcar_gen2_data },
61a8dec502b873 Geert Uytterhoeven 2017-07-12 1081 { .compatible = "renesas,rcar-gen2-msiof", .data = &rcar_gen2_data },
61a8dec502b873 Geert Uytterhoeven 2017-07-12 1082 { .compatible = "renesas,msiof-r8a7796", .data = &rcar_gen3_data },
61a8dec502b873 Geert Uytterhoeven 2017-07-12 1083 { .compatible = "renesas,rcar-gen3-msiof", .data = &rcar_gen3_data },
264c3e8de4fbda Simon Horman 2016-12-20 1084 { .compatible = "renesas,sh-msiof", .data = &sh_data }, /* Deprecated */
50a7e23f536779 Geert Uytterhoeven 2014-02-25 1085 {},
50a7e23f536779 Geert Uytterhoeven 2014-02-25 1086 };
50a7e23f536779 Geert Uytterhoeven 2014-02-25 1087 MODULE_DEVICE_TABLE(of, sh_msiof_match);
50a7e23f536779 Geert Uytterhoeven 2014-02-25 1088
:::::: The code at line 1072 was first introduced by commit
:::::: 50a7e23f53677918bf521b09ce9bb20fb87cd175 spi: sh-msiof: Move default FIFO sizes to device ID data
:::::: TO: Geert Uytterhoeven <geert+renesas(a)linux-m68k.org>
:::::: CC: Mark Brown <broonie(a)linaro.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 2 weeks
Re: [PATCH 1/3] fs/ntfs3: fix endian conversion in ni_fname_name
by kernel test robot
Hi "Thomas,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1]
url: https://github.com/0day-ci/linux/commits/Thomas-K-hnel/fs-ntfs3-Fixes-for...
base: 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
config: arm64-randconfig-s031-20211207 (https://download.01.org/0day-ci/archive/20211207/202112072356.fmLjngs7-lk...)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/d2fb837ced1828c5a57feac3690d3cc8a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thomas-K-hnel/fs-ntfs3-Fixes-for-big-endian-systems/20211207-184206
git checkout d2fb837ced1828c5a57feac3690d3cc8a36b2fdc
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash fs/ntfs3/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> fs/ntfs3/frecord.c:1615:28: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le16 const [usertype] *s1 @@ got unsigned short const * @@
fs/ntfs3/frecord.c:1615:28: sparse: expected restricted __le16 const [usertype] *s1
fs/ntfs3/frecord.c:1615:28: sparse: got unsigned short const *
vim +1615 fs/ntfs3/frecord.c
1578
1579 /* ni_fname_name
1580 *
1581 * Return: File name attribute by its value.
1582 */
1583 struct ATTR_FILE_NAME *ni_fname_name(struct ntfs_inode *ni,
1584 const struct cpu_str *uni,
1585 const struct MFT_REF *home_dir,
1586 struct mft_inode **mi,
1587 struct ATTR_LIST_ENTRY **le)
1588 {
1589 struct ATTRIB *attr = NULL;
1590 struct ATTR_FILE_NAME *fname;
1591 struct le_str *fns;
1592
1593 *le = NULL;
1594
1595 /* Enumerate all names. */
1596 next:
1597 attr = ni_find_attr(ni, attr, le, ATTR_NAME, NULL, 0, NULL, mi);
1598 if (!attr)
1599 return NULL;
1600
1601 fname = resident_data_ex(attr, SIZEOF_ATTRIBUTE_FILENAME);
1602 if (!fname)
1603 goto next;
1604
1605 if (home_dir && memcmp(home_dir, &fname->home, sizeof(*home_dir)))
1606 goto next;
1607
1608 if (!uni)
1609 goto next;
1610
1611 if (uni->len != fname->name_len)
1612 goto next;
1613
1614 fns = (struct le_str *)&fname->name_len;
> 1615 if (ntfs_cmp_names(uni->name, uni->len, fns->name, fns->len, NULL,
1616 false))
1617 goto next;
1618
1619 return fname;
1620 }
1621
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 2 weeks