[linux-next:master 5464/9897] error: unknown target CPU 'loongson2f'
by kernel test robot
CC: Linux Memory Management List <linux-mm(a)kvack.org>
TO: Nathan Chancellor <nathan(a)kernel.org>
CC: Thomas Bogendoerfer <tsbogend(a)alpha.franken.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: ea586a076e8aa606c59b66d86660590f18354b11
commit: 13ceb48bc19c563e05f407e663aaa4105fdfd408 [5464/9897] MIPS: Loongson2ef: Remove unnecessary {as,cc}-option calls
config: mips-lemote2f_defconfig (https://download.01.org/0day-ci/archive/20220101/202201010356.iTaJlVVL-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 7cd109b92c72855937273a6c8ab19016fbe27d33)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 13ceb48bc19c563e05f407e663aaa4105fdfd408
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips prepare
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
clang-14: warning: argument unused during compilation: '-mno-branch-likely' [-Wunused-command-line-argument]
>> error: unknown target CPU 'loongson2f'
note: valid target CPU values are: mips1, mips2, mips3, mips4, mips5, mips32, mips32r2, mips32r3, mips32r5, mips32r6, mips64, mips64r2, mips64r3, mips64r5, mips64r6, octeon, octeon+, p5600
scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
>> error: unknown target CPU 'loongson2f'
note: valid target CPU values are: mips1, mips2, mips3, mips4, mips5, mips32, mips32r2, mips32r3, mips32r5, mips32r6, mips64, mips64r2, mips64r3, mips64r5, mips64r6, octeon, octeon+, p5600
make[2]: *** [scripts/Makefile.build:121: kernel/bounds.s] Error 1
make[2]: Target 'missing-syscalls' not remade because of errors.
make[1]: *** [arch/mips/Makefile:415: archprepare] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:219: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
4 months, 3 weeks
fs/xfs/xfs_trans.c:559:8: warning: variable 'error' set but not used
by kernel test robot
Hi Dave,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4f3d93c6eaff6b84e43b63e0d7a119c5920e1020
commit: dc3ffbb14060c943469d5e12900db3a60bc3fa64 xfs: gut error handling in xfs_trans_unreserve_and_mod_sb()
date: 1 year, 7 months ago
config: x86_64-randconfig-a015-20211118 (https://download.01.org/0day-ci/archive/20220101/202201010354.K9eHFohw-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout dc3ffbb14060c943469d5e12900db3a60bc3fa64
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/xfs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
fs/xfs/xfs_trans.c: In function 'xfs_trans_unreserve_and_mod_sb':
>> fs/xfs/xfs_trans.c:559:8: warning: variable 'error' set but not used [-Wunused-but-set-variable]
559 | int error;
| ^~~~~
vim +/error +559 fs/xfs/xfs_trans.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 536
^1da177e4c3f41 Linus Torvalds 2005-04-16 537 /*
dc3ffbb14060c9 Dave Chinner 2020-05-20 538 * xfs_trans_unreserve_and_mod_sb() is called to release unused reservations and
dc3ffbb14060c9 Dave Chinner 2020-05-20 539 * apply superblock counter changes to the in-core superblock. The
45c34141126a89 David Chinner 2007-06-18 540 * t_res_fdblocks_delta and t_res_frextents_delta fields are explicitly NOT
45c34141126a89 David Chinner 2007-06-18 541 * applied to the in-core superblock. The idea is that that has already been
45c34141126a89 David Chinner 2007-06-18 542 * done.
^1da177e4c3f41 Linus Torvalds 2005-04-16 543 *
45c34141126a89 David Chinner 2007-06-18 544 * If we are not logging superblock counters, then the inode allocated/free and
45c34141126a89 David Chinner 2007-06-18 545 * used block counts are not updated in the on disk superblock. In this case,
45c34141126a89 David Chinner 2007-06-18 546 * XFS_TRANS_SB_DIRTY will not be set when the transaction is updated but we
45c34141126a89 David Chinner 2007-06-18 547 * still need to update the incore superblock with the changes.
^1da177e4c3f41 Linus Torvalds 2005-04-16 548 */
71e330b593905e Dave Chinner 2010-05-21 549 void
^1da177e4c3f41 Linus Torvalds 2005-04-16 550 xfs_trans_unreserve_and_mod_sb(
0bd5ddedccca44 Dave Chinner 2015-02-23 551 struct xfs_trans *tp)
^1da177e4c3f41 Linus Torvalds 2005-04-16 552 {
0bd5ddedccca44 Dave Chinner 2015-02-23 553 struct xfs_mount *mp = tp->t_mountp;
0d485ada404b36 Dave Chinner 2015-02-23 554 bool rsvd = (tp->t_flags & XFS_TRANS_RESERVE) != 0;
45c34141126a89 David Chinner 2007-06-18 555 int64_t blkdelta = 0;
45c34141126a89 David Chinner 2007-06-18 556 int64_t rtxdelta = 0;
1b0407125f9a5b Christoph Hellwig 2010-09-30 557 int64_t idelta = 0;
1b0407125f9a5b Christoph Hellwig 2010-09-30 558 int64_t ifreedelta = 0;
0bd5ddedccca44 Dave Chinner 2015-02-23 @559 int error;
^1da177e4c3f41 Linus Torvalds 2005-04-16 560
1b0407125f9a5b Christoph Hellwig 2010-09-30 561 /* calculate deltas */
45c34141126a89 David Chinner 2007-06-18 562 if (tp->t_blk_res > 0)
45c34141126a89 David Chinner 2007-06-18 563 blkdelta = tp->t_blk_res;
45c34141126a89 David Chinner 2007-06-18 564 if ((tp->t_fdblocks_delta != 0) &&
45c34141126a89 David Chinner 2007-06-18 565 (xfs_sb_version_haslazysbcount(&mp->m_sb) ||
45c34141126a89 David Chinner 2007-06-18 566 (tp->t_flags & XFS_TRANS_SB_DIRTY)))
45c34141126a89 David Chinner 2007-06-18 567 blkdelta += tp->t_fdblocks_delta;
45c34141126a89 David Chinner 2007-06-18 568
45c34141126a89 David Chinner 2007-06-18 569 if (tp->t_rtx_res > 0)
45c34141126a89 David Chinner 2007-06-18 570 rtxdelta = tp->t_rtx_res;
45c34141126a89 David Chinner 2007-06-18 571 if ((tp->t_frextents_delta != 0) &&
45c34141126a89 David Chinner 2007-06-18 572 (tp->t_flags & XFS_TRANS_SB_DIRTY))
45c34141126a89 David Chinner 2007-06-18 573 rtxdelta += tp->t_frextents_delta;
45c34141126a89 David Chinner 2007-06-18 574
1b0407125f9a5b Christoph Hellwig 2010-09-30 575 if (xfs_sb_version_haslazysbcount(&mp->m_sb) ||
1b0407125f9a5b Christoph Hellwig 2010-09-30 576 (tp->t_flags & XFS_TRANS_SB_DIRTY)) {
1b0407125f9a5b Christoph Hellwig 2010-09-30 577 idelta = tp->t_icount_delta;
1b0407125f9a5b Christoph Hellwig 2010-09-30 578 ifreedelta = tp->t_ifree_delta;
^1da177e4c3f41 Linus Torvalds 2005-04-16 579 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 580
1b0407125f9a5b Christoph Hellwig 2010-09-30 581 /* apply the per-cpu counters */
1b0407125f9a5b Christoph Hellwig 2010-09-30 582 if (blkdelta) {
0d485ada404b36 Dave Chinner 2015-02-23 583 error = xfs_mod_fdblocks(mp, blkdelta, rsvd);
dc3ffbb14060c9 Dave Chinner 2020-05-20 584 ASSERT(!error);
1b0407125f9a5b Christoph Hellwig 2010-09-30 585 }
45c34141126a89 David Chinner 2007-06-18 586
1b0407125f9a5b Christoph Hellwig 2010-09-30 587 if (idelta) {
501ab323875339 Dave Chinner 2015-02-23 588 error = xfs_mod_icount(mp, idelta);
dc3ffbb14060c9 Dave Chinner 2020-05-20 589 ASSERT(!error);
^1da177e4c3f41 Linus Torvalds 2005-04-16 590 }
1b0407125f9a5b Christoph Hellwig 2010-09-30 591
1b0407125f9a5b Christoph Hellwig 2010-09-30 592 if (ifreedelta) {
e88b64ea1f3da6 Dave Chinner 2015-02-23 593 error = xfs_mod_ifree(mp, ifreedelta);
dc3ffbb14060c9 Dave Chinner 2020-05-20 594 ASSERT(!error);
^1da177e4c3f41 Linus Torvalds 2005-04-16 595 }
1b0407125f9a5b Christoph Hellwig 2010-09-30 596
0bd5ddedccca44 Dave Chinner 2015-02-23 597 if (rtxdelta == 0 && !(tp->t_flags & XFS_TRANS_SB_DIRTY))
0bd5ddedccca44 Dave Chinner 2015-02-23 598 return;
0bd5ddedccca44 Dave Chinner 2015-02-23 599
1b0407125f9a5b Christoph Hellwig 2010-09-30 600 /* apply remaining deltas */
0bd5ddedccca44 Dave Chinner 2015-02-23 601 spin_lock(&mp->m_sb_lock);
dc3ffbb14060c9 Dave Chinner 2020-05-20 602 mp->m_sb.sb_frextents += rtxdelta;
dc3ffbb14060c9 Dave Chinner 2020-05-20 603 mp->m_sb.sb_dblocks += tp->t_dblocks_delta;
dc3ffbb14060c9 Dave Chinner 2020-05-20 604 mp->m_sb.sb_agcount += tp->t_agcount_delta;
dc3ffbb14060c9 Dave Chinner 2020-05-20 605 mp->m_sb.sb_imax_pct += tp->t_imaxpct_delta;
dc3ffbb14060c9 Dave Chinner 2020-05-20 606 mp->m_sb.sb_rextsize += tp->t_rextsize_delta;
dc3ffbb14060c9 Dave Chinner 2020-05-20 607 mp->m_sb.sb_rbmblocks += tp->t_rbmblocks_delta;
dc3ffbb14060c9 Dave Chinner 2020-05-20 608 mp->m_sb.sb_rblocks += tp->t_rblocks_delta;
dc3ffbb14060c9 Dave Chinner 2020-05-20 609 mp->m_sb.sb_rextents += tp->t_rextents_delta;
dc3ffbb14060c9 Dave Chinner 2020-05-20 610 mp->m_sb.sb_rextslog += tp->t_rextslog_delta;
0bd5ddedccca44 Dave Chinner 2015-02-23 611 spin_unlock(&mp->m_sb_lock);
1b0407125f9a5b Christoph Hellwig 2010-09-30 612
dc3ffbb14060c9 Dave Chinner 2020-05-20 613 /*
dc3ffbb14060c9 Dave Chinner 2020-05-20 614 * Debug checks outside of the spinlock so they don't lock up the
dc3ffbb14060c9 Dave Chinner 2020-05-20 615 * machine if they fail.
dc3ffbb14060c9 Dave Chinner 2020-05-20 616 */
dc3ffbb14060c9 Dave Chinner 2020-05-20 617 ASSERT(mp->m_sb.sb_imax_pct >= 0);
dc3ffbb14060c9 Dave Chinner 2020-05-20 618 ASSERT(mp->m_sb.sb_rextslog >= 0);
1b0407125f9a5b Christoph Hellwig 2010-09-30 619 return;
^1da177e4c3f41 Linus Torvalds 2005-04-16 620 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 621
:::::: The code at line 559 was first introduced by commit
:::::: 0bd5ddedccca4451ac2390d1155b4ab74b990eff xfs: replace xfs_mod_incore_sb_batched
:::::: TO: Dave Chinner <dchinner(a)redhat.com>
:::::: CC: Dave Chinner <david(a)fromorbit.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
4 months, 3 weeks
[dlemoal-libata:for-5.17-logging 46/79] include/linux/libata.h:1493:23: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' {aka 'long long unsigned int'}
by kernel test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git for-5.17-logging
head: fc730a4198504b83666da816eea7cb582fd9ae01
commit: 65625c4d468ec05a28451701b5808ea6400db5f5 [46/79] sata_fsl: convert VPRINTK() calls to ata_port_dbg()
config: powerpc64-randconfig-r036-20211231 (https://download.01.org/0day-ci/archive/20220101/202201010316.Xs1Xbwjo-lk...)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git/commit...
git remote add dlemoal-libata git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git
git fetch --no-tags dlemoal-libata for-5.17-logging
git checkout 65625c4d468ec05a28451701b5808ea6400db5f5
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/ata/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:559,
from include/linux/kernel.h:20,
from drivers/ata/sata_fsl.c:13:
drivers/ata/sata_fsl.c: In function 'fsl_sata_set_irq_coalescing':
drivers/ata/sata_fsl.c:316:17: error: passing argument 2 of '__dynamic_dev_dbg' from incompatible pointer type [-Werror=incompatible-pointer-types]
316 | dev_dbg(&host->dev, "interrupt coalescing, count = 0x%x, ticks = %x\n",
| ^~~~~~~~~~
| |
| struct device **
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:316:9: note: in expansion of macro 'dev_dbg'
316 | dev_dbg(&host->dev, "interrupt coalescing, count = 0x%x, ticks = %x\n",
| ^~~~~~~
include/linux/dynamic_debug.h:73:73: note: expected 'const struct device *' but argument is of type 'struct device **'
73 | void __dynamic_dev_dbg(struct _ddebug *descriptor, const struct device *dev,
| ~~~~~~~~~~~~~~~~~~~~~^~~
drivers/ata/sata_fsl.c:318:17: error: passing argument 2 of '__dynamic_dev_dbg' from incompatible pointer type [-Werror=incompatible-pointer-types]
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~~~~
| |
| struct device **
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:318:9: note: in expansion of macro 'dev_dbg'
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~
include/linux/dynamic_debug.h:73:73: note: expected 'const struct device *' but argument is of type 'struct device **'
73 | void __dynamic_dev_dbg(struct _ddebug *descriptor, const struct device *dev,
| ~~~~~~~~~~~~~~~~~~~~~^~~
drivers/ata/sata_fsl.c:318:29: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'void *' [-Wformat=]
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/ata/sata_fsl.c:318:9: note: in expansion of macro 'dev_dbg'
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~
drivers/ata/sata_fsl.c:318:65: note: format string is defined here
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ~^
| |
| unsigned int
| %p
In file included from include/linux/kernel.h:20,
from drivers/ata/sata_fsl.c:13:
drivers/ata/sata_fsl.c: In function 'sata_fsl_port_start':
>> include/linux/libata.h:1493:23: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Wformat=]
1493 | pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
| ^~~~~~~~~
include/linux/printk.h:340:21: note: in definition of macro 'pr_fmt'
340 | #define pr_fmt(fmt) fmt
| ^~~
include/linux/dynamic_debug.h:152:9: note: in expansion of macro '__dynamic_func_call'
152 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call'
162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
include/linux/printk.h:574:9: note: in expansion of macro 'dynamic_pr_debug'
574 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
include/linux/libata.h:1493:9: note: in expansion of macro 'pr_debug'
1493 | pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
| ^~~
include/linux/libata.h:1504:9: note: in expansion of macro 'ata_port_printk'
1504 | ata_port_printk(debug, ap, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:734:9: note: in expansion of macro 'ata_port_dbg'
734 | ata_port_dbg(ap, "CHBA = 0x%x, cmdentry_phys = 0x%x\n",
| ^~~~~~~~~~~~
include/linux/libata.h:1493:23: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Wformat=]
1493 | pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
| ^~~~~~~~~
include/linux/printk.h:340:21: note: in definition of macro 'pr_fmt'
340 | #define pr_fmt(fmt) fmt
| ^~~
include/linux/dynamic_debug.h:152:9: note: in expansion of macro '__dynamic_func_call'
152 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call'
162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
include/linux/printk.h:574:9: note: in expansion of macro 'dynamic_pr_debug'
574 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
include/linux/libata.h:1493:9: note: in expansion of macro 'pr_debug'
1493 | pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
| ^~~
include/linux/libata.h:1504:9: note: in expansion of macro 'ata_port_printk'
1504 | ata_port_printk(debug, ap, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:734:9: note: in expansion of macro 'ata_port_dbg'
734 | ata_port_dbg(ap, "CHBA = 0x%x, cmdentry_phys = 0x%x\n",
| ^~~~~~~~~~~~
In file included from include/linux/printk.h:559,
from include/linux/kernel.h:20,
from drivers/ata/sata_fsl.c:13:
drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
drivers/ata/sata_fsl.c:1345:22: error: 'ap' undeclared (first use in this function); did you mean 'up'?
1345 | ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
| ^~
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call'
162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
include/linux/printk.h:574:9: note: in expansion of macro 'dynamic_pr_debug'
574 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
include/linux/libata.h:1493:9: note: in expansion of macro 'pr_debug'
1493 | pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
| ^~~
include/linux/libata.h:1504:9: note: in expansion of macro 'ata_port_printk'
1504 | ata_port_printk(debug, ap, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:1345:9: note: in expansion of macro 'ata_port_dbg'
1345 | ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
| ^~~~~~~~~~~~
drivers/ata/sata_fsl.c:1345:22: note: each undeclared identifier is reported only once for each function it appears in
1345 | ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
| ^~
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call'
162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
include/linux/printk.h:574:9: note: in expansion of macro 'dynamic_pr_debug'
574 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
include/linux/libata.h:1493:9: note: in expansion of macro 'pr_debug'
1493 | pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
| ^~~
include/linux/libata.h:1504:9: note: in expansion of macro 'ata_port_printk'
1504 | ata_port_printk(debug, ap, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:1345:9: note: in expansion of macro 'ata_port_dbg'
1345 | ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
| ^~~~~~~~~~~~
drivers/ata/sata_fsl.c: At top level:
drivers/ata/sata_fsl.c:1383:22: warning: initialized field overwritten [-Woverride-init]
1383 | .can_queue = SATA_FSL_QUEUE_DEPTH,
| ^~~~~~~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:1383:22: note: (near initialization for 'sata_fsl_sht.can_queue')
In file included from include/linux/printk.h:559,
from include/linux/kernel.h:20,
vim +1493 include/linux/libata.h
071f44b1d2c051 Tejun Heo 2008-04-07 1491
c6cf72be22beb4 Hannes Reinecke 2021-12-21 1492 #define ata_port_printk(level, ap, fmt, ...) \
c6cf72be22beb4 Hannes Reinecke 2021-12-21 @1493 pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
a9a79dfec23956 Joe Perches 2011-04-15 1494
:::::: The code at line 1493 was first introduced by commit
:::::: c6cf72be22beb4f0dfeedcf34ffc0926b2df61b5 libata: move ata_{port,link,dev}_dbg to standard pr_XXX() macros
:::::: TO: Hannes Reinecke <hare(a)suse.de>
:::::: CC: Damien Le Moal <damien.lemoal(a)opensource.wdc.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
4 months, 3 weeks
[driver-core:debugfs_cleanup 5/5] drivers/base/firmware_loader/main.c:811:1: error: redefinition of 'request_firmware'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup
head: a04bbe0a2c7e98669e11a47f94e53dd8228bbeba
commit: a04bbe0a2c7e98669e11a47f94e53dd8228bbeba [5/5] firmware: remove old CONFIG_FW_LOADER_MODULE test
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220101/202201010250.AR5OyFBm-lk...)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/co...
git remote add driver-core https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
git fetch --no-tags driver-core debugfs_cleanup
git checkout a04bbe0a2c7e98669e11a47f94e53dd8228bbeba
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/base/firmware_loader/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/base/firmware_loader/main.c:811:1: error: redefinition of 'request_firmware'
811 | request_firmware(const struct firmware **firmware_p, const char *name,
| ^~~~~~~~~~~~~~~~
In file included from drivers/base/firmware_loader/main.c:26:
include/linux/firmware.h:58:19: note: previous definition of 'request_firmware' with type 'int(const struct firmware **, const char *, struct device *)'
58 | static inline int request_firmware(const struct firmware **fw,
| ^~~~~~~~~~~~~~~~
>> drivers/base/firmware_loader/main.c:838:5: error: redefinition of 'firmware_request_nowarn'
838 | int firmware_request_nowarn(const struct firmware **firmware, const char *name,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/firmware_loader/main.c:26:
include/linux/firmware.h:65:19: note: previous definition of 'firmware_request_nowarn' with type 'int(const struct firmware **, const char *, struct device *)'
65 | static inline int firmware_request_nowarn(const struct firmware **fw,
| ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/base/firmware_loader/main.c:863:5: error: redefinition of 'request_firmware_direct'
863 | int request_firmware_direct(const struct firmware **firmware_p,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/firmware_loader/main.c:26:
include/linux/firmware.h:91:19: note: previous definition of 'request_firmware_direct' with type 'int(const struct firmware **, const char *, struct device *)'
91 | static inline int request_firmware_direct(const struct firmware **fw,
| ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/base/firmware_loader/main.c:887:5: error: redefinition of 'firmware_request_platform'
887 | int firmware_request_platform(const struct firmware **firmware,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/firmware_loader/main.c:26:
include/linux/firmware.h:72:19: note: previous definition of 'firmware_request_platform' with type 'int(const struct firmware **, const char *, struct device *)'
72 | static inline int firmware_request_platform(const struct firmware **fw,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/base/firmware_loader/main.c:941:1: error: redefinition of 'request_firmware_into_buf'
941 | request_firmware_into_buf(const struct firmware **firmware_p, const char *name,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/firmware_loader/main.c:26:
include/linux/firmware.h:98:19: note: previous definition of 'request_firmware_into_buf' with type 'int(const struct firmware **, const char *, struct device *, void *, size_t)' {aka 'int(const struct firmware **, const char *, struct device *, void *, unsigned int)'}
98 | static inline int request_firmware_into_buf(const struct firmware **firmware_p,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/base/firmware_loader/main.c:970:1: error: redefinition of 'request_partial_firmware_into_buf'
970 | request_partial_firmware_into_buf(const struct firmware **firmware_p,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/firmware_loader/main.c:26:
include/linux/firmware.h:104:19: note: previous definition of 'request_partial_firmware_into_buf' with type 'int(const struct firmware **, const char *, struct device *, void *, size_t, size_t)' {aka 'int(const struct firmware **, const char *, struct device *, void *, unsigned int, unsigned int)'}
104 | static inline int request_partial_firmware_into_buf
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/base/firmware_loader/main.c:992:6: error: redefinition of 'release_firmware'
992 | void release_firmware(const struct firmware *fw)
| ^~~~~~~~~~~~~~~~
In file included from drivers/base/firmware_loader/main.c:26:
include/linux/firmware.h:87:20: note: previous definition of 'release_firmware' with type 'void(const struct firmware *)'
87 | static inline void release_firmware(const struct firmware *fw)
| ^~~~~~~~~~~~~~~~
>> drivers/base/firmware_loader/main.c:1054:1: error: redefinition of 'request_firmware_nowait'
1054 | request_firmware_nowait(
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/base/firmware_loader/main.c:26:
include/linux/firmware.h:79:19: note: previous definition of 'request_firmware_nowait' with type 'int(struct module *, bool, const char *, struct device *, gfp_t, void *, void (*)(const struct firmware *, void *))' {aka 'int(struct module *, _Bool, const char *, struct device *, unsigned int, void *, void (*)(const struct firmware *, void *))'}
79 | static inline int request_firmware_nowait(
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/request_firmware +811 drivers/base/firmware_loader/main.c
4e0c92d015235d drivers/base/firmware_class.c Takashi Iwai 2013-01-31 789
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 790 /**
c35f9cbb1df8f1 drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 791 * request_firmware() - send firmware request and wait for it
eb8e317998e55d drivers/base/firmware_class.c Randy Dunlap 2005-10-30 792 * @firmware_p: pointer to firmware image
eb8e317998e55d drivers/base/firmware_class.c Randy Dunlap 2005-10-30 793 * @name: name of firmware file
eb8e317998e55d drivers/base/firmware_class.c Randy Dunlap 2005-10-30 794 * @device: device for which firmware is being loaded
eb8e317998e55d drivers/base/firmware_class.c Randy Dunlap 2005-10-30 795 *
eb8e317998e55d drivers/base/firmware_class.c Randy Dunlap 2005-10-30 796 * @firmware_p will be used to return a firmware image by the name
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 797 * of @name for device @device.
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 798 *
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 799 * Should be called from user context where sleeping is allowed.
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 800 *
312c004d36ce6c drivers/base/firmware_class.c Kay Sievers 2005-11-16 801 * @name will be used as $FIRMWARE in the uevent environment and
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 802 * should be distinctive enough not to be confused with any other
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 803 * firmware image for this or any other device.
0cfc1e1e7b5347 drivers/base/firmware_class.c Ming Lei 2012-08-04 804 *
0cfc1e1e7b5347 drivers/base/firmware_class.c Ming Lei 2012-08-04 805 * Caller must hold the reference count of @device.
6a927857d89065 drivers/base/firmware_class.c Ming Lei 2012-11-03 806 *
6a927857d89065 drivers/base/firmware_class.c Ming Lei 2012-11-03 807 * The function can be called safely inside device's suspend and
6a927857d89065 drivers/base/firmware_class.c Ming Lei 2012-11-03 808 * resume callback.
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 809 **/
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 810 int
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 @811 request_firmware(const struct firmware **firmware_p, const char *name,
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 812 struct device *device)
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 813 {
d6c8aa3906d5d0 drivers/base/firmware_class.c Ming Lei 2013-06-06 814 int ret;
d6c8aa3906d5d0 drivers/base/firmware_class.c Ming Lei 2013-06-06 815
d6c8aa3906d5d0 drivers/base/firmware_class.c Ming Lei 2013-06-06 816 /* Need to pin this module until return */
d6c8aa3906d5d0 drivers/base/firmware_class.c Ming Lei 2013-06-06 817 __module_get(THIS_MODULE);
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 818 ret = _request_firmware(firmware_p, name, device, NULL, 0, 0,
3f72271233943c drivers/base/firmware_class.c Luis R. Rodriguez 2017-11-20 819 FW_OPT_UEVENT);
d6c8aa3906d5d0 drivers/base/firmware_class.c Ming Lei 2013-06-06 820 module_put(THIS_MODULE);
d6c8aa3906d5d0 drivers/base/firmware_class.c Ming Lei 2013-06-06 821 return ret;
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 822 }
f494513ff1b3f6 drivers/base/firmware_class.c Daniel Mack 2013-05-23 823 EXPORT_SYMBOL(request_firmware);
6e3eaab02028c4 drivers/base/firmware_class.c Abhay Salunke 2005-09-06 824
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 825 /**
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 826 * firmware_request_nowarn() - request for an optional fw module
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 827 * @firmware: pointer to firmware image
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 828 * @name: name of firmware file
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 829 * @device: device for which firmware is being loaded
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 830 *
2fce60be06ca68 drivers/base/firmware_loader/main.c Wolfram Sang 2020-07-03 831 * This function is similar in behaviour to request_firmware(), except it
2fce60be06ca68 drivers/base/firmware_loader/main.c Wolfram Sang 2020-07-03 832 * doesn't produce warning messages when the file is not found. The sysfs
2fce60be06ca68 drivers/base/firmware_loader/main.c Wolfram Sang 2020-07-03 833 * fallback mechanism is enabled if direct filesystem lookup fails. However,
2fce60be06ca68 drivers/base/firmware_loader/main.c Wolfram Sang 2020-07-03 834 * failures to find the firmware file with it are still suppressed. It is
2fce60be06ca68 drivers/base/firmware_loader/main.c Wolfram Sang 2020-07-03 835 * therefore up to the driver to check for the return value of this call and to
2fce60be06ca68 drivers/base/firmware_loader/main.c Wolfram Sang 2020-07-03 836 * decide when to inform the users of errors.
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 837 **/
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 @838 int firmware_request_nowarn(const struct firmware **firmware, const char *name,
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 839 struct device *device)
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 840 {
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 841 int ret;
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 842
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 843 /* Need to pin this module until return */
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 844 __module_get(THIS_MODULE);
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 845 ret = _request_firmware(firmware, name, device, NULL, 0, 0,
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 846 FW_OPT_UEVENT | FW_OPT_NO_WARN);
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 847 module_put(THIS_MODULE);
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 848 return ret;
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 849 }
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 850 EXPORT_SYMBOL_GPL(firmware_request_nowarn);
7dcc01343e483e drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 851
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 852 /**
c35f9cbb1df8f1 drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 853 * request_firmware_direct() - load firmware directly without usermode helper
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 854 * @firmware_p: pointer to firmware image
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 855 * @name: name of firmware file
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 856 * @device: device for which firmware is being loaded
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 857 *
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 858 * This function works pretty much like request_firmware(), but this doesn't
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 859 * fall back to usermode helper even if the firmware couldn't be loaded
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 860 * directly from fs. Hence it's useful for loading optional firmwares, which
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 861 * aren't always present, without extra long timeouts of udev.
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 862 **/
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 @863 int request_firmware_direct(const struct firmware **firmware_p,
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 864 const char *name, struct device *device)
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 865 {
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 866 int ret;
ea31003ccb2d68 drivers/base/firmware_class.c Andrei Oprea 2015-03-08 867
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 868 __module_get(THIS_MODULE);
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 869 ret = _request_firmware(firmware_p, name, device, NULL, 0, 0,
3f72271233943c drivers/base/firmware_class.c Luis R. Rodriguez 2017-11-20 870 FW_OPT_UEVENT | FW_OPT_NO_WARN |
85db1cde825344 drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 871 FW_OPT_NOFALLBACK_SYSFS);
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 872 module_put(THIS_MODULE);
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 873 return ret;
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 874 }
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 875 EXPORT_SYMBOL_GPL(request_firmware_direct);
bba3a87e982ad5 drivers/base/firmware_class.c Takashi Iwai 2013-12-02 876
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 877 /**
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 878 * firmware_request_platform() - request firmware with platform-fw fallback
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 879 * @firmware: pointer to firmware image
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 880 * @name: name of firmware file
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 881 * @device: device for which firmware is being loaded
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 882 *
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 883 * This function is similar in behaviour to request_firmware, except that if
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 884 * direct filesystem lookup fails, it will fallback to looking for a copy of the
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 885 * requested firmware embedded in the platform's main (e.g. UEFI) firmware.
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 886 **/
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 @887 int firmware_request_platform(const struct firmware **firmware,
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 888 const char *name, struct device *device)
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 889 {
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 890 int ret;
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 891
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 892 /* Need to pin this module until return */
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 893 __module_get(THIS_MODULE);
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 894 ret = _request_firmware(firmware, name, device, NULL, 0, 0,
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 895 FW_OPT_UEVENT | FW_OPT_FALLBACK_PLATFORM);
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 896 module_put(THIS_MODULE);
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 897 return ret;
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 898 }
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 899 EXPORT_SYMBOL_GPL(firmware_request_platform);
e4c2c0ff00ecaf drivers/base/firmware_loader/main.c Hans de Goede 2020-01-15 900
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 901 /**
c35f9cbb1df8f1 drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 902 * firmware_request_cache() - cache firmware for suspend so resume can use it
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 903 * @name: name of firmware file
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 904 * @device: device for which firmware should be cached for
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 905 *
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 906 * There are some devices with an optimization that enables the device to not
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 907 * require loading firmware on system reboot. This optimization may still
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 908 * require the firmware present on resume from suspend. This routine can be
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 909 * used to ensure the firmware is present on resume from suspend in these
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 910 * situations. This helper is not compatible with drivers which use
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 911 * request_firmware_into_buf() or request_firmware_nowait() with no uevent set.
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 912 **/
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 913 int firmware_request_cache(struct device *device, const char *name)
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 914 {
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 915 int ret;
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 916
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 917 mutex_lock(&fw_lock);
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 918 ret = fw_add_devm_name(device, name);
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 919 mutex_unlock(&fw_lock);
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 920
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 921 return ret;
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 922 }
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 923 EXPORT_SYMBOL_GPL(firmware_request_cache);
5d42c96e1cf98b drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-21 924
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 925 /**
c35f9cbb1df8f1 drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 926 * request_firmware_into_buf() - load firmware into a previously allocated buffer
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 927 * @firmware_p: pointer to firmware image
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 928 * @name: name of firmware file
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 929 * @device: device for which firmware is being loaded and DMA region allocated
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 930 * @buf: address of buffer to load firmware into
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 931 * @size: size of buffer
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 932 *
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 933 * This function works pretty much like request_firmware(), but it doesn't
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 934 * allocate a buffer to hold the firmware data. Instead, the firmware
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 935 * is loaded directly into the buffer pointed to by @buf and the @firmware_p
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 936 * data member is pointed at @buf.
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 937 *
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 938 * This function doesn't cache firmware either.
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 939 */
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 940 int
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 @941 request_firmware_into_buf(const struct firmware **firmware_p, const char *name,
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 942 struct device *device, void *buf, size_t size)
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 943 {
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 944 int ret;
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 945
995e8695f65db7 drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-10 946 if (fw_cache_is_setup(device, name))
995e8695f65db7 drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-10 947 return -EOPNOTSUPP;
995e8695f65db7 drivers/base/firmware_loader/main.c Luis R. Rodriguez 2018-03-10 948
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 949 __module_get(THIS_MODULE);
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 950 ret = _request_firmware(firmware_p, name, device, buf, size, 0,
3f72271233943c drivers/base/firmware_class.c Luis R. Rodriguez 2017-11-20 951 FW_OPT_UEVENT | FW_OPT_NOCACHE);
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 952 module_put(THIS_MODULE);
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 953 return ret;
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 954 }
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 955 EXPORT_SYMBOL(request_firmware_into_buf);
a098ecd2fa7db8 drivers/base/firmware_class.c Stephen Boyd 2016-08-02 956
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 957 /**
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 958 * request_partial_firmware_into_buf() - load partial firmware into a previously allocated buffer
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 959 * @firmware_p: pointer to firmware image
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 960 * @name: name of firmware file
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 961 * @device: device for which firmware is being loaded and DMA region allocated
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 962 * @buf: address of buffer to load firmware into
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 963 * @size: size of buffer
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 964 * @offset: offset into file to read
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 965 *
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 966 * This function works pretty much like request_firmware_into_buf except
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 967 * it allows a partial read of the file.
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 968 */
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 969 int
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 @970 request_partial_firmware_into_buf(const struct firmware **firmware_p,
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 971 const char *name, struct device *device,
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 972 void *buf, size_t size, size_t offset)
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 973 {
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 974 int ret;
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 975
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 976 if (fw_cache_is_setup(device, name))
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 977 return -EOPNOTSUPP;
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 978
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 979 __module_get(THIS_MODULE);
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 980 ret = _request_firmware(firmware_p, name, device, buf, size, offset,
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 981 FW_OPT_UEVENT | FW_OPT_NOCACHE |
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 982 FW_OPT_PARTIAL);
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 983 module_put(THIS_MODULE);
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 984 return ret;
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 985 }
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 986 EXPORT_SYMBOL(request_partial_firmware_into_buf);
59cdb23ca2dfef drivers/base/firmware_loader/main.c Scott Branden 2020-10-02 987
^1da177e4c3f41 drivers/base/firmware_class.c Linus Torvalds 2005-04-16 988 /**
c35f9cbb1df8f1 drivers/base/firmware_loader/main.c Andres Rodriguez 2018-05-10 989 * release_firmware() - release the resource associated with a firmware image
eb8e317998e55d drivers/base/firmware_class.c Randy Dunlap 2005-10-30 990 * @fw: firmware resource to release
^1da177e4c3f41 drivers/base/firmware_class.c Linus Torvalds 2005-04-16 991 **/
bcb9bd18e397ea drivers/base/firmware_class.c Dmitry Torokhov 2010-03-13 @992 void release_firmware(const struct firmware *fw)
^1da177e4c3f41 drivers/base/firmware_class.c Linus Torvalds 2005-04-16 993 {
^1da177e4c3f41 drivers/base/firmware_class.c Linus Torvalds 2005-04-16 994 if (fw) {
48d09e97876bed drivers/base/firmware_loader/main.c Luis Chamberlain 2021-10-21 995 if (!firmware_is_builtin(fw))
dd336c554d8926 drivers/base/firmware_class.c David Woodhouse 2010-05-02 996 firmware_free_data(fw);
^1da177e4c3f41 drivers/base/firmware_class.c Linus Torvalds 2005-04-16 997 kfree(fw);
^1da177e4c3f41 drivers/base/firmware_class.c Linus Torvalds 2005-04-16 998 }
^1da177e4c3f41 drivers/base/firmware_class.c Linus Torvalds 2005-04-16 999 }
f494513ff1b3f6 drivers/base/firmware_class.c Daniel Mack 2013-05-23 1000 EXPORT_SYMBOL(release_firmware);
^1da177e4c3f41 drivers/base/firmware_class.c Linus Torvalds 2005-04-16 1001
:::::: The code at line 811 was first introduced by commit
:::::: 6e3eaab02028c4087a92711b20abb9e72cc803a7 [PATCH] modified firmware_class.c to support no hotplug
:::::: TO: Abhay Salunke <Abhay_Salunke(a)dell.com>
:::::: CC: Linus Torvalds <torvalds(a)g5.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
4 months, 3 weeks
Re: [PATCH net-next v3 06/11] net: dsa: realtek: add new mdio interface for drivers
by kernel test robot
Hi Luiz,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Luiz-Angelo-Daros-de-Luca/net-ds...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git af30f8eaa8fe4ff1987280f716309711997bd979
config: hexagon-randconfig-r033-20211231 (https://download.01.org/0day-ci/archive/20220101/202201010143.Ua57feb3-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 7cd109b92c72855937273a6c8ab19016fbe27d33)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/98bde88720c76b12ab9ed2cfc166f6539...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Luiz-Angelo-Daros-de-Luca/net-dsa-realtek-smi-move-to-subdirectory/20211231-133326
git checkout 98bde88720c76b12ab9ed2cfc166f65396e6e5e2
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/net/dsa/realtek/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/dsa/realtek/realtek-mdio.c:41:5: warning: no previous prototype for function 'realtek_mdio_read_reg' [-Wmissing-prototypes]
int realtek_mdio_read_reg(struct realtek_priv *priv, u32 addr, u32 *data)
^
drivers/net/dsa/realtek/realtek-mdio.c:41:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int realtek_mdio_read_reg(struct realtek_priv *priv, u32 addr, u32 *data)
^
static
1 warning generated.
vim +/realtek_mdio_read_reg +41 drivers/net/dsa/realtek/realtek-mdio.c
40
> 41 int realtek_mdio_read_reg(struct realtek_priv *priv, u32 addr, u32 *data)
42 {
43 u32 phy_id = priv->phy_id;
44 struct mii_bus *bus = priv->bus;
45
46 mutex_lock(&bus->mdio_lock);
47
48 bus->write(bus, phy_id, REALTEK_MDIO_CTRL0_REG, REALTEK_MDIO_ADDR_OP);
49 bus->write(bus, phy_id, REALTEK_MDIO_START_REG, REALTEK_MDIO_START_OP);
50 bus->write(bus, phy_id, REALTEK_MDIO_ADDRESS_REG, addr);
51 bus->write(bus, phy_id, REALTEK_MDIO_START_REG, REALTEK_MDIO_START_OP);
52 bus->write(bus, phy_id, REALTEK_MDIO_CTRL1_REG, REALTEK_MDIO_READ_OP);
53 bus->write(bus, phy_id, REALTEK_MDIO_START_REG, REALTEK_MDIO_START_OP);
54 *data = bus->read(bus, phy_id, REALTEK_MDIO_DATA_READ_REG);
55
56 mutex_unlock(&bus->mdio_lock);
57
58 return 0;
59 }
60
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
4 months, 3 weeks
[dlemoal-libata:for-5.17-logging 31/79] drivers/ata/sata_fsl.c:316:17: error: passing argument 2 of '__dynamic_dev_dbg' from incompatible pointer type
by kernel test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git for-5.17-logging
head: fc730a4198504b83666da816eea7cb582fd9ae01
commit: 8bb1beeb144d8284af32b98c9f46f58030b74ac2 [31/79] sata_fsl: move DPRINTK to ata debugging
config: powerpc64-randconfig-r036-20211231 (https://download.01.org/0day-ci/archive/20220101/202201010008.hPfgdpH7-lk...)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git/commit...
git remote add dlemoal-libata git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git
git fetch --no-tags dlemoal-libata for-5.17-logging
git checkout 8bb1beeb144d8284af32b98c9f46f58030b74ac2
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/printk.h:559,
from include/linux/kernel.h:20,
from drivers/ata/sata_fsl.c:13:
drivers/ata/sata_fsl.c: In function 'fsl_sata_set_irq_coalescing':
>> drivers/ata/sata_fsl.c:316:17: error: passing argument 2 of '__dynamic_dev_dbg' from incompatible pointer type [-Werror=incompatible-pointer-types]
316 | dev_dbg(&host->dev, "interrupt coalescing, count = 0x%x, ticks = %x\n",
| ^~~~~~~~~~
| |
| struct device **
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:316:9: note: in expansion of macro 'dev_dbg'
316 | dev_dbg(&host->dev, "interrupt coalescing, count = 0x%x, ticks = %x\n",
| ^~~~~~~
include/linux/dynamic_debug.h:73:73: note: expected 'const struct device *' but argument is of type 'struct device **'
73 | void __dynamic_dev_dbg(struct _ddebug *descriptor, const struct device *dev,
| ~~~~~~~~~~~~~~~~~~~~~^~~
drivers/ata/sata_fsl.c:318:17: error: passing argument 2 of '__dynamic_dev_dbg' from incompatible pointer type [-Werror=incompatible-pointer-types]
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~~~~
| |
| struct device **
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:318:9: note: in expansion of macro 'dev_dbg'
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~
include/linux/dynamic_debug.h:73:73: note: expected 'const struct device *' but argument is of type 'struct device **'
73 | void __dynamic_dev_dbg(struct _ddebug *descriptor, const struct device *dev,
| ~~~~~~~~~~~~~~~~~~~~~^~~
drivers/ata/sata_fsl.c:318:29: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'void *' [-Wformat=]
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/ata/sata_fsl.c:318:9: note: in expansion of macro 'dev_dbg'
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ^~~~~~~
drivers/ata/sata_fsl.c:318:65: note: format string is defined here
318 | dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
| ~^
| |
| unsigned int
| %p
In file included from include/linux/printk.h:559,
from include/linux/kernel.h:20,
from drivers/ata/sata_fsl.c:13:
drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
drivers/ata/sata_fsl.c:1361:22: error: 'ap' undeclared (first use in this function); did you mean 'up'?
1361 | ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
| ^~
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call'
162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
include/linux/printk.h:574:9: note: in expansion of macro 'dynamic_pr_debug'
574 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
include/linux/libata.h:1493:9: note: in expansion of macro 'pr_debug'
1493 | pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
| ^~~
include/linux/libata.h:1504:9: note: in expansion of macro 'ata_port_printk'
1504 | ata_port_printk(debug, ap, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/ata/sata_fsl.c:1361:9: note: in expansion of macro 'ata_port_dbg'
1361 | ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
| ^~~~~~~~~~~~
drivers/ata/sata_fsl.c:1361:22: note: each undeclared identifier is reported only once for each function it appears in
1361 | ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
| ^~
include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call'
162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
include/linux/printk.h:574:9: note: in expansion of macro 'dynamic_pr_debug'
574 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
vim +/__dynamic_dev_dbg +316 drivers/ata/sata_fsl.c
290
291 static void fsl_sata_set_irq_coalescing(struct ata_host *host,
292 unsigned int count, unsigned int ticks)
293 {
294 struct sata_fsl_host_priv *host_priv = host->private_data;
295 void __iomem *hcr_base = host_priv->hcr_base;
296 unsigned long flags;
297
298 if (count > ICC_MAX_INT_COUNT_THRESHOLD)
299 count = ICC_MAX_INT_COUNT_THRESHOLD;
300 else if (count < ICC_MIN_INT_COUNT_THRESHOLD)
301 count = ICC_MIN_INT_COUNT_THRESHOLD;
302
303 if (ticks > ICC_MAX_INT_TICKS_THRESHOLD)
304 ticks = ICC_MAX_INT_TICKS_THRESHOLD;
305 else if ((ICC_MIN_INT_TICKS_THRESHOLD == ticks) &&
306 (count > ICC_MIN_INT_COUNT_THRESHOLD))
307 ticks = ICC_SAFE_INT_TICKS;
308
309 spin_lock_irqsave(&host->lock, flags);
310 iowrite32((count << 24 | ticks), hcr_base + ICC);
311
312 intr_coalescing_count = count;
313 intr_coalescing_ticks = ticks;
314 spin_unlock_irqrestore(&host->lock, flags);
315
> 316 dev_dbg(&host->dev, "interrupt coalescing, count = 0x%x, ticks = %x\n",
317 intr_coalescing_count, intr_coalescing_ticks);
318 dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
319 hcr_base, ioread32(hcr_base + ICC));
320 }
321
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
4 months, 3 weeks
[PATCH] RISC-V: fix semicolon.cocci warnings
by kernel test robot
From: kernel test robot <lkp(a)intel.com>
arch/riscv/kernel/smp.c:130:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Anup Patel <anup.patel(a)wdc.com>
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/avpatel/linux.git riscv_kvm_aia_v1
head: 6fa93cde61f5f84422bd3f97b9db6e2406a344dd
commit: dea7752f30104c9bb3c2c67ce2c56e5a5eb3c290 [17/42] RISC-V: Treat IPIs as normal Linux IRQs
:::::: branch date: 6 hours ago
:::::: commit date: 3 days ago
smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/riscv/kernel/smp.c
+++ b/arch/riscv/kernel/smp.c
@@ -127,7 +127,7 @@ static irqreturn_t handle_IPI(int irq, v
default:
pr_warn("CPU%d: unhandled IPI%d\n", smp_processor_id(), ipi);
break;
- };
+ }
return IRQ_HANDLED;
}
4 months, 3 weeks