[PATCH] spi: fix for_each_child.cocci warnings
by kernel test robot
From: kernel test robot <lkp(a)intel.com>
drivers/spi/spi-zynqmp-gqspi.c:1360:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1365.
drivers/spi/spi-zynqmp-gqspi.c:1372:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1377.
Semantic patch information:
False positives can be due to function calls within the for_each
loop that may encapsulate an of_node_put.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
Fixes: 5d37ab2cf69a ("spi: Update ZynqMP and Versal QSPI controller driver")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra(a)xilinx.com>
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.10
head: 87ec9a2d98a7a7dfc98b57348a0ec310fd170e4b
commit: 5d37ab2cf69a5d4367f49fca798d78e4be66a43b [724/1981] spi: Update ZynqMP and Versal QSPI controller driver
:::::: branch date: 4 days ago
:::::: commit date: 7 months ago
Please take the patch only if it's a positive warning. Thanks!
spi-zynqmp-gqspi.c | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -1362,6 +1362,7 @@ static int zynqmp_qspi_probe(struct plat
&rx_bus_width);
if (!ret) {
xqspi->rx_bus_width = rx_bus_width;
+ of_node_put(nc);
break;
}
}
@@ -1374,6 +1375,7 @@ static int zynqmp_qspi_probe(struct plat
&tx_bus_width);
if (!ret) {
xqspi->tx_bus_width = tx_bus_width;
+ of_node_put(nc);
break;
}
}
9 months
[xilinx-xlnx:xlnx_rebase_v5.4 217/1768] drivers/media/i2c/adv7511-v4l2.c:427:2: error: void function 'adv7511_set_rgb_quantization_mode' should not return a value
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head: abafefebd1f1e040eef74e4ab571ea08bf745641
commit: 9836a252284b997aacd6b86766514a0bb84b4f43 [217/1768] drivers: media: Customized adv7511 for Xylon LogiCVC (deprecated)
config: x86_64-randconfig-r013-20211214 (https://download.01.org/0day-ci/archive/20211218/202112180608.FPnIZOag-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Xilinx/linux-xlnx/commit/9836a252284b997aacd6b86766514...
git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xilinx-xlnx xlnx_rebase_v5.4
git checkout 9836a252284b997aacd6b86766514a0bb84b4f43
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/media/i2c/ drivers/mtd/spi-nor/ drivers/spi/ drivers/usb/host/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
>> drivers/media/i2c/adv7511-v4l2.c:427:2: error: void function 'adv7511_set_rgb_quantization_mode' should not return a value [-Wreturn-type]
return 0;
^ ~
>> drivers/media/i2c/adv7511-v4l2.c:2251:21: warning: no previous prototype for function 'adv7511_subdev' [-Wmissing-prototypes]
struct v4l2_subdev *adv7511_subdev(struct v4l2_subdev *sd)
^
drivers/media/i2c/adv7511-v4l2.c:2251:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct v4l2_subdev *adv7511_subdev(struct v4l2_subdev *sd)
^
static
1 warning and 1 error generated.
vim +/adv7511_set_rgb_quantization_mode +427 drivers/media/i2c/adv7511-v4l2.c
421
422 static void adv7511_set_rgb_quantization_mode(struct v4l2_subdev *sd, struct v4l2_ctrl *ctrl)
423 {
424 struct adv7511_state *state = get_adv7511_state(sd);
425
426 #ifdef XYLON_LOGICVC_INTG
> 427 return 0;
428 #endif
429
430 /* Only makes sense for RGB formats */
431 if (state->fmt_code != MEDIA_BUS_FMT_RGB888_1X24) {
432 /* so just keep quantization */
433 adv7511_csc_rgb_full2limit(sd, false);
434 return;
435 }
436
437 switch (ctrl->val) {
438 case V4L2_DV_RGB_RANGE_AUTO:
439 /* automatic */
440 if (state->dv_timings.bt.flags & V4L2_DV_FL_IS_CE_VIDEO) {
441 /* CE format, RGB limited range (16-235) */
442 adv7511_csc_rgb_full2limit(sd, true);
443 } else {
444 /* not CE format, RGB full range (0-255) */
445 adv7511_csc_rgb_full2limit(sd, false);
446 }
447 break;
448 case V4L2_DV_RGB_RANGE_LIMITED:
449 /* RGB limited range (16-235) */
450 adv7511_csc_rgb_full2limit(sd, true);
451 break;
452 case V4L2_DV_RGB_RANGE_FULL:
453 /* RGB full range (0-255) */
454 adv7511_csc_rgb_full2limit(sd, false);
455 break;
456 }
457 }
458
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
[xilinx-xlnx:xlnx_rebase_v5.10 103/1981] drivers/pinctrl/pinctrl-zynqmp.c:106:25: warning: implicit conversion from 'enum zynqmp_pin_config_param' to 'enum pin_config_param'
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.10
head: 87ec9a2d98a7a7dfc98b57348a0ec310fd170e4b
commit: 17ad884f47d49a926ff8a49ea12002b1be229f45 [103/1981] pinctrl: zynqmp: Maintain backward compatibility with previous version
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20211218/202112180614.0pyqdUgJ-lk...)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Xilinx/linux-xlnx/commit/17ad884f47d49a926ff8a49ea1200...
git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xilinx-xlnx xlnx_rebase_v5.10
git checkout 17ad884f47d49a926ff8a49ea12002b1be229f45
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/kvm/ drivers/crypto/caam/ drivers/edac/ drivers/irqchip/ drivers/net/ethernet/ti/ drivers/pinctrl/ drivers/remoteproc/ drivers/usb/dwc3/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/pinctrl/pinctrl-zynqmp.c:106:25: warning: implicit conversion from 'enum zynqmp_pin_config_param' to 'enum pin_config_param' [-Wenum-conversion]
106 | {"io-standard", PIN_CONFIG_IOSTANDARD, IO_STANDARD_LVCMOS18},
| ^~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:107:26: warning: implicit conversion from 'enum zynqmp_pin_config_param' to 'enum pin_config_param' [-Wenum-conversion]
107 | {"schmitt-cmos", PIN_CONFIG_SCHMITTCMOS, PIN_INPUT_TYPE_SCHMITT},
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/pinctrl/pinctrl-zynqmp.c:20:
drivers/pinctrl/pinctrl-zynqmp.c:113:19: warning: implicit conversion from 'enum zynqmp_pin_config_param' to 'enum pin_config_param' [-Wenum-conversion]
113 | PCONFDUMP(PIN_CONFIG_IOSTANDARD, "IO-standard", NULL, true),
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/pinctrl/pinconf-generic.h:168:18: note: in definition of macro 'PCONFDUMP'
168 | .param = a, .display = b, .format = c, .has_arg = d \
| ^
drivers/pinctrl/pinctrl-zynqmp.c:114:19: warning: implicit conversion from 'enum zynqmp_pin_config_param' to 'enum pin_config_param' [-Wenum-conversion]
114 | PCONFDUMP(PIN_CONFIG_SCHMITTCMOS, "schmitt-cmos", NULL, true),
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/pinctrl/pinconf-generic.h:168:18: note: in definition of macro 'PCONFDUMP'
168 | .param = a, .display = b, .format = c, .has_arg = d \
| ^
vim +106 drivers/pinctrl/pinctrl-zynqmp.c
104
105 static const struct pinconf_generic_params zynqmp_dt_params[] = {
> 106 {"io-standard", PIN_CONFIG_IOSTANDARD, IO_STANDARD_LVCMOS18},
107 {"schmitt-cmos", PIN_CONFIG_SCHMITTCMOS, PIN_INPUT_TYPE_SCHMITT},
108 };
109
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
[ti:ti-rt-linux-5.10.y 6386/9635] drivers/gpu/drm/omapdrm/dss/dispc.c:928:38: warning: unused variable 'coefs_rgb2yuv_bt601_lim'
by kernel test robot
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.10.y
head: 3772fcad17273ce669d79cdb635eabeb2ad799ee
commit: 5a7a1e8de7d07253f79407210a0ed9d5ab8e4b7f [6386/9635] drm/omap: Enable COLOR_ENCODING and COLOR_RANGE properties for planes
config: arm-randconfig-r021-20211217 (https://download.01.org/0day-ci/archive/20211218/202112180643.ME8Mlacw-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9043c3d65b11b442226015acfbf8167684586cfa)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
git fetch --no-tags ti ti-rt-linux-5.10.y
git checkout 5a7a1e8de7d07253f79407210a0ed9d5ab8e4b7f
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/clocksource/ drivers/gpu/drm/omapdrm/dss/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/omapdrm/dss/dispc.c:928:38: warning: unused variable 'coefs_rgb2yuv_bt601_lim' [-Wunused-const-variable]
static const struct csc_coef_rgb2yuv coefs_rgb2yuv_bt601_lim = {
^
>> drivers/gpu/drm/omapdrm/dss/dispc.c:944:38: warning: unused variable 'coefs_rgb2yuv_bt701_lim' [-Wunused-const-variable]
static const struct csc_coef_rgb2yuv coefs_rgb2yuv_bt701_lim = {
^
2 warnings generated.
vim +/coefs_rgb2yuv_bt601_lim +928 drivers/gpu/drm/omapdrm/dss/dispc.c
926
927 /* RGB -> YUV, ITU-R BT.601, limited range */
> 928 static const struct csc_coef_rgb2yuv coefs_rgb2yuv_bt601_lim = {
929 66, 129, 25, /* yr, yg, yb | 0.257 0.504 0.098|*/
930 -38, -74, 112, /* cbr, cbg, cbb |-0.148 -0.291 0.439|*/
931 112, -94, -18, /* crr, crg, crb | 0.439 -0.368 -0.071|*/
932 false, /* limited range */
933 };
934
935 /* RGB -> YUV, ITU-R BT.601, full range */
936 static const struct csc_coef_rgb2yuv coefs_rgb2yuv_bt601_full = {
937 77, 150, 29, /* yr, yg, yb | 0.299 0.587 0.114|*/
938 -43, -85, 128, /* cbr, cbg, cbb |-0.173 -0.339 0.511|*/
939 128, -107, -21, /* crr, crg, crb | 0.511 -0.428 -0.083|*/
940 true, /* full range */
941 };
942
943 /* RGB -> YUV, ITU-R BT.709, limited range */
> 944 static const struct csc_coef_rgb2yuv coefs_rgb2yuv_bt701_lim = {
945 47, 157, 16, /* yr, yg, yb | 0.1826 0.6142 0.0620|*/
946 -26, -87, 112, /* cbr, cbg, cbb |-0.1006 -0.3386 0.4392|*/
947 112, -102, -10, /* crr, crg, crb | 0.4392 -0.3989 -0.0403|*/
948 false, /* limited range */
949 };
950
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
Re: [Patch v2 5/9] soc: tegra: cbb: Add CBB1.0 driver for Tegra194
by kernel test robot
Hi Sumit,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on tegra-drm/drm/tegra/for-next v5.16-rc5 next-20211217]
[cannot apply to tegra/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sumit-Gupta/CBB-driver-for-Tegra...
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20211218/202112180528.6oINgaDF-lk...)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4289c950622627160bdc937ad22a311db...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sumit-Gupta/CBB-driver-for-Tegra194-Tegra234-Tegra-Grace/20211217-200840
git checkout 4289c950622627160bdc937ad22a311db38f4ca8
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/soc/tegra/cbb/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/soc/tegra/cbb/tegra-cbb.c: In function 'print_cbb_err':
>> drivers/soc/tegra/cbb/tegra-cbb.c:31:17: warning: function 'print_cbb_err' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
31 | seq_vprintf(file, fmt, args);
| ^~~~~~~~~~~
vim +31 drivers/soc/tegra/cbb/tegra-cbb.c
22
23 void print_cbb_err(struct seq_file *file, const char *fmt, ...)
24 {
25 va_list args;
26 struct va_format vaf;
27
28 va_start(args, fmt);
29
30 if (file) {
> 31 seq_vprintf(file, fmt, args);
32 } else {
33 vaf.fmt = fmt;
34 vaf.va = &args;
35 pr_crit("%pV", &vaf);
36 }
37
38 va_end(args);
39 }
40
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
Re: [PATCH nf-next,v2 5/5] netfilter: nf_tables: make counter support built-in
by kernel test robot
Hi Pablo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on nf/master]
[also build test WARNING on nf-next/master horms-ipvs/master v5.16-rc5 next-20211217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-nf_t...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: x86_64-randconfig-a001-20211217 (https://download.01.org/0day-ci/archive/20211218/202112180458.kdTRRudP-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9043c3d65b11b442226015acfbf8167684586cfa)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/390ad4295aa6445c311abd677b653a510...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Pablo-Neira-Ayuso/netfilter-nf_tables-remove-rcu-read-size-lock/20211217-194033
git checkout 390ad4295aa6445c311abd677b653a510f621131
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/netfilter/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> net/netfilter/nft_counter.c:195:6: warning: no previous prototype for function 'nft_counter_eval' [-Wmissing-prototypes]
void nft_counter_eval(const struct nft_expr *expr, struct nft_regs *regs,
^
net/netfilter/nft_counter.c:195:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void nft_counter_eval(const struct nft_expr *expr, struct nft_regs *regs,
^
static
>> net/netfilter/nft_counter.c:277:6: warning: no previous prototype for function 'nft_counter_init_seqcount' [-Wmissing-prototypes]
void nft_counter_init_seqcount(void)
^
net/netfilter/nft_counter.c:277:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void nft_counter_init_seqcount(void)
^
static
2 warnings generated.
vim +/nft_counter_eval +195 net/netfilter/nft_counter.c
194
> 195 void nft_counter_eval(const struct nft_expr *expr, struct nft_regs *regs,
196 const struct nft_pktinfo *pkt)
197 {
198 struct nft_counter_percpu_priv *priv = nft_expr_priv(expr);
199
200 nft_counter_do_eval(priv, regs, pkt);
201 }
202
203 static int nft_counter_dump(struct sk_buff *skb, const struct nft_expr *expr)
204 {
205 struct nft_counter_percpu_priv *priv = nft_expr_priv(expr);
206
207 return nft_counter_do_dump(skb, priv, false);
208 }
209
210 static int nft_counter_init(const struct nft_ctx *ctx,
211 const struct nft_expr *expr,
212 const struct nlattr * const tb[])
213 {
214 struct nft_counter_percpu_priv *priv = nft_expr_priv(expr);
215
216 return nft_counter_do_init(tb, priv);
217 }
218
219 static void nft_counter_destroy(const struct nft_ctx *ctx,
220 const struct nft_expr *expr)
221 {
222 struct nft_counter_percpu_priv *priv = nft_expr_priv(expr);
223
224 nft_counter_do_destroy(priv);
225 }
226
227 static int nft_counter_clone(struct nft_expr *dst, const struct nft_expr *src)
228 {
229 struct nft_counter_percpu_priv *priv = nft_expr_priv(src);
230 struct nft_counter_percpu_priv *priv_clone = nft_expr_priv(dst);
231 struct nft_counter __percpu *cpu_stats;
232 struct nft_counter *this_cpu;
233 struct nft_counter total;
234
235 nft_counter_fetch(priv, &total);
236
237 cpu_stats = alloc_percpu_gfp(struct nft_counter, GFP_ATOMIC);
238 if (cpu_stats == NULL)
239 return -ENOMEM;
240
241 preempt_disable();
242 this_cpu = this_cpu_ptr(cpu_stats);
243 this_cpu->packets = total.packets;
244 this_cpu->bytes = total.bytes;
245 preempt_enable();
246
247 priv_clone->counter = cpu_stats;
248 return 0;
249 }
250
251 static int nft_counter_offload(struct nft_offload_ctx *ctx,
252 struct nft_flow_rule *flow,
253 const struct nft_expr *expr)
254 {
255 /* No specific offload action is needed, but report success. */
256 return 0;
257 }
258
259 static void nft_counter_offload_stats(struct nft_expr *expr,
260 const struct flow_stats *stats)
261 {
262 struct nft_counter_percpu_priv *priv = nft_expr_priv(expr);
263 struct nft_counter *this_cpu;
264 seqcount_t *myseq;
265
266 preempt_disable();
267 this_cpu = this_cpu_ptr(priv->counter);
268 myseq = this_cpu_ptr(&nft_counter_seq);
269
270 write_seqcount_begin(myseq);
271 this_cpu->packets += stats->pkts;
272 this_cpu->bytes += stats->bytes;
273 write_seqcount_end(myseq);
274 preempt_enable();
275 }
276
> 277 void nft_counter_init_seqcount(void)
278 {
279 int cpu;
280
281 for_each_possible_cpu(cpu)
282 seqcount_init(per_cpu_ptr(&nft_counter_seq, cpu));
283 }
284
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
[ti:ti-rt-linux-5.10.y 1799/9635] drivers/pci/controller/dwc/pci-keystone.c:299:6: warning: no previous prototype for function 'ks_pcie_irq_eoi'
by kernel test robot
Hi Kishon,
FYI, the error/warning still remains.
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.10.y
head: 3772fcad17273ce669d79cdb635eabeb2ad799ee
commit: f765f578153d8bfc7a035b1fce2c09d2c41bd980 [1799/9635] PCI: keystone: Convert to using hierarchy domain for legacy interrupts
config: arm-randconfig-r021-20211217 (https://download.01.org/0day-ci/archive/20211218/202112180423.WXxLYKbT-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9043c3d65b11b442226015acfbf8167684586cfa)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
git fetch --no-tags ti ti-rt-linux-5.10.y
git checkout f765f578153d8bfc7a035b1fce2c09d2c41bd980
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/clocksource/ drivers/gpu/drm/omapdrm/dss/ drivers/pci/controller/dwc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/pci/controller/dwc/pci-keystone.c:299:6: warning: no previous prototype for function 'ks_pcie_irq_eoi' [-Wmissing-prototypes]
void ks_pcie_irq_eoi(struct irq_data *data)
^
drivers/pci/controller/dwc/pci-keystone.c:299:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void ks_pcie_irq_eoi(struct irq_data *data)
^
static
>> drivers/pci/controller/dwc/pci-keystone.c:308:6: warning: no previous prototype for function 'ks_pcie_irq_enable' [-Wmissing-prototypes]
void ks_pcie_irq_enable(struct irq_data *data)
^
drivers/pci/controller/dwc/pci-keystone.c:308:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void ks_pcie_irq_enable(struct irq_data *data)
^
static
>> drivers/pci/controller/dwc/pci-keystone.c:317:6: warning: no previous prototype for function 'ks_pcie_irq_disable' [-Wmissing-prototypes]
void ks_pcie_irq_disable(struct irq_data *data)
^
drivers/pci/controller/dwc/pci-keystone.c:317:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void ks_pcie_irq_disable(struct irq_data *data)
^
static
3 warnings generated.
vim +/ks_pcie_irq_eoi +299 drivers/pci/controller/dwc/pci-keystone.c
298
> 299 void ks_pcie_irq_eoi(struct irq_data *data)
300 {
301 struct keystone_pcie *ks_pcie = irq_data_get_irq_chip_data(data);
302 irq_hw_number_t hwirq = data->hwirq;
303
304 ks_pcie_app_writel(ks_pcie, IRQ_EOI, hwirq);
305 irq_chip_eoi_parent(data);
306 }
307
> 308 void ks_pcie_irq_enable(struct irq_data *data)
309 {
310 struct keystone_pcie *ks_pcie = irq_data_get_irq_chip_data(data);
311 irq_hw_number_t hwirq = data->hwirq;
312
313 ks_pcie_app_writel(ks_pcie, IRQ_ENABLE_SET(hwirq), INTx_EN);
314 irq_chip_enable_parent(data);
315 }
316
> 317 void ks_pcie_irq_disable(struct irq_data *data)
318 {
319 struct keystone_pcie *ks_pcie = irq_data_get_irq_chip_data(data);
320 irq_hw_number_t hwirq = data->hwirq;
321
322 ks_pcie_app_writel(ks_pcie, IRQ_ENABLE_CLR(hwirq), INTx_EN);
323 irq_chip_disable_parent(data);
324 }
325
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
Re: [PATCH nf-next,v2 5/5] netfilter: nf_tables: make counter support built-in
by kernel test robot
Hi Pablo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on nf/master]
[also build test WARNING on nf-next/master horms-ipvs/master v5.16-rc5 next-20211217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-nf_t...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20211218/202112180342.ufUrUKkP-lk...)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/390ad4295aa6445c311abd677b653a510...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Pablo-Neira-Ayuso/netfilter-nf_tables-remove-rcu-read-size-lock/20211217-194033
git checkout 390ad4295aa6445c311abd677b653a510f621131
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash net/netfilter/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> net/netfilter/nft_counter.c:195:6: warning: no previous prototype for 'nft_counter_eval' [-Wmissing-prototypes]
195 | void nft_counter_eval(const struct nft_expr *expr, struct nft_regs *regs,
| ^~~~~~~~~~~~~~~~
>> net/netfilter/nft_counter.c:277:6: warning: no previous prototype for 'nft_counter_init_seqcount' [-Wmissing-prototypes]
277 | void nft_counter_init_seqcount(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/nft_counter_eval +195 net/netfilter/nft_counter.c
194
> 195 void nft_counter_eval(const struct nft_expr *expr, struct nft_regs *regs,
196 const struct nft_pktinfo *pkt)
197 {
198 struct nft_counter_percpu_priv *priv = nft_expr_priv(expr);
199
200 nft_counter_do_eval(priv, regs, pkt);
201 }
202
203 static int nft_counter_dump(struct sk_buff *skb, const struct nft_expr *expr)
204 {
205 struct nft_counter_percpu_priv *priv = nft_expr_priv(expr);
206
207 return nft_counter_do_dump(skb, priv, false);
208 }
209
210 static int nft_counter_init(const struct nft_ctx *ctx,
211 const struct nft_expr *expr,
212 const struct nlattr * const tb[])
213 {
214 struct nft_counter_percpu_priv *priv = nft_expr_priv(expr);
215
216 return nft_counter_do_init(tb, priv);
217 }
218
219 static void nft_counter_destroy(const struct nft_ctx *ctx,
220 const struct nft_expr *expr)
221 {
222 struct nft_counter_percpu_priv *priv = nft_expr_priv(expr);
223
224 nft_counter_do_destroy(priv);
225 }
226
227 static int nft_counter_clone(struct nft_expr *dst, const struct nft_expr *src)
228 {
229 struct nft_counter_percpu_priv *priv = nft_expr_priv(src);
230 struct nft_counter_percpu_priv *priv_clone = nft_expr_priv(dst);
231 struct nft_counter __percpu *cpu_stats;
232 struct nft_counter *this_cpu;
233 struct nft_counter total;
234
235 nft_counter_fetch(priv, &total);
236
237 cpu_stats = alloc_percpu_gfp(struct nft_counter, GFP_ATOMIC);
238 if (cpu_stats == NULL)
239 return -ENOMEM;
240
241 preempt_disable();
242 this_cpu = this_cpu_ptr(cpu_stats);
243 this_cpu->packets = total.packets;
244 this_cpu->bytes = total.bytes;
245 preempt_enable();
246
247 priv_clone->counter = cpu_stats;
248 return 0;
249 }
250
251 static int nft_counter_offload(struct nft_offload_ctx *ctx,
252 struct nft_flow_rule *flow,
253 const struct nft_expr *expr)
254 {
255 /* No specific offload action is needed, but report success. */
256 return 0;
257 }
258
259 static void nft_counter_offload_stats(struct nft_expr *expr,
260 const struct flow_stats *stats)
261 {
262 struct nft_counter_percpu_priv *priv = nft_expr_priv(expr);
263 struct nft_counter *this_cpu;
264 seqcount_t *myseq;
265
266 preempt_disable();
267 this_cpu = this_cpu_ptr(priv->counter);
268 myseq = this_cpu_ptr(&nft_counter_seq);
269
270 write_seqcount_begin(myseq);
271 this_cpu->packets += stats->pkts;
272 this_cpu->bytes += stats->bytes;
273 write_seqcount_end(myseq);
274 preempt_enable();
275 }
276
> 277 void nft_counter_init_seqcount(void)
278 {
279 int cpu;
280
281 for_each_possible_cpu(cpu)
282 seqcount_init(per_cpu_ptr(&nft_counter_seq, cpu));
283 }
284
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months