[RFC PATCH xilinx-xlnx] usb: dwc3: of-simple: fix duplicated inclusion
by kernel test robot
Generated by: scripts/checkincludes.pl
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
dwc3-of-simple.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index 5ba8fd87b5569..d88706b7bdddf 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -13,7 +13,6 @@
#include <linux/module.h>
#include <linux/kernel.h>
-#include <linux/slab.h>
#include <linux/platform_device.h>
#include <linux/dma-mapping.h>
#include <linux/clk.h>
9 months
[xilinx-xlnx:xlnx_rebase_v5.10 730/1981] drivers/mtd/spi-nor/micron-st.c:61:3-19: duplicated argument to & or | (fwd)
by Julia Lawall
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_LOCK on line 61 has the same constant
twice.
---------- Forwarded message ----------
Date: Sat, 18 Dec 2021 00:49:57 +0800
From: kernel test robot <lkp(a)intel.com>
To: kbuild(a)lists.01.org
Cc: lkp(a)intel.com, Julia Lawall <julia.lawall(a)lip6.fr>
Subject: [xilinx-xlnx:xlnx_rebase_v5.10 730/1981]
drivers/mtd/spi-nor/micron-st.c:61:3-19: duplicated argument to & or |
CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Amit Kumar Mahapatra <amit.kumar-mahapatra(a)xilinx.com>
CC: Michal Simek <monstr(a)monstr.eu>
CC: P L Sai Krishna <lakshmis(a)xilinx.com>
CC: Anurag Kumar Vulisha <anuragku(a)xilinx.com>
CC: Naga Sureshkumar Relli <naga.sureshkumar.relli(a)xilinx.com>
CC: Tejas Prajapati Rameshchandra <tejaspra(a)xilinx.com>
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.10
head: 87ec9a2d98a7a7dfc98b57348a0ec310fd170e4b
commit: 69da6b404536626df93a8b4b5b4e48884cba87ca [730/1981] mtd: spi-nor: Update flags for serial NOR flash devices
:::::: branch date: 3 days ago
:::::: commit date: 7 months ago
config: microblaze-randconfig-c004-20211216 (https://download.01.org/0day-ci/archive/20211218/202112180053.vQI0Y0PV-lk...)
compiler: microblaze-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Julia Lawall <julia.lawall(a)lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/mtd/spi-nor/micron-st.c:61:3-19: duplicated argument to & or |
vim +61 drivers/mtd/spi-nor/micron-st.c
15f5c7e54e658a Boris Brezillon 2020-03-13 19
15f5c7e54e658a Boris Brezillon 2020-03-13 20 static const struct flash_info st_parts[] = {
15f5c7e54e658a Boris Brezillon 2020-03-13 21 { "n25q016a", INFO(0x20bb15, 0, 64 * 1024, 32,
15f5c7e54e658a Boris Brezillon 2020-03-13 22 SECT_4K | SPI_NOR_QUAD_READ) },
15f5c7e54e658a Boris Brezillon 2020-03-13 23 { "n25q032", INFO(0x20ba16, 0, 64 * 1024, 64,
15f5c7e54e658a Boris Brezillon 2020-03-13 24 SPI_NOR_QUAD_READ) },
15f5c7e54e658a Boris Brezillon 2020-03-13 25 { "n25q032a", INFO(0x20bb16, 0, 64 * 1024, 64,
15f5c7e54e658a Boris Brezillon 2020-03-13 26 SPI_NOR_QUAD_READ) },
15f5c7e54e658a Boris Brezillon 2020-03-13 27 { "n25q064", INFO(0x20ba17, 0, 64 * 1024, 128,
15f5c7e54e658a Boris Brezillon 2020-03-13 28 SECT_4K | SPI_NOR_QUAD_READ) },
15f5c7e54e658a Boris Brezillon 2020-03-13 29 { "n25q064a", INFO(0x20bb17, 0, 64 * 1024, 128,
15f5c7e54e658a Boris Brezillon 2020-03-13 30 SECT_4K | SPI_NOR_QUAD_READ) },
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 31 { "n25q128a11", INFO(0x20bb18, 0, 64 * 1024, 256, SECT_4K |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 32 SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK) },
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 33 { "n25q128a13", INFO(0x20ba18, 0, 64 * 1024, 256, SECT_4K |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 34 SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK) },
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 35 { "n25q256a", INFO(0x20ba19, 0, 64 * 1024, 512, SECT_4K |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 36 SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_FSR |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 37 SPI_NOR_HAS_LOCK) },
15f5c7e54e658a Boris Brezillon 2020-03-13 38 { "n25q256a", INFO(0x20ba19, 0, 64 * 1024, 512, SECT_4K |
15f5c7e54e658a Boris Brezillon 2020-03-13 39 USE_FSR | SPI_NOR_DUAL_READ |
15f5c7e54e658a Boris Brezillon 2020-03-13 40 SPI_NOR_QUAD_READ) },
15f5c7e54e658a Boris Brezillon 2020-03-13 41 { "mt25qu256a", INFO6(0x20bb19, 0x104400, 64 * 1024, 512,
15f5c7e54e658a Boris Brezillon 2020-03-13 42 SECT_4K | USE_FSR | SPI_NOR_DUAL_READ |
15f5c7e54e658a Boris Brezillon 2020-03-13 43 SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
15f5c7e54e658a Boris Brezillon 2020-03-13 44 { "n25q256ax1", INFO(0x20bb19, 0, 64 * 1024, 512,
15f5c7e54e658a Boris Brezillon 2020-03-13 45 SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
15f5c7e54e658a Boris Brezillon 2020-03-13 46 { "mt25ql512a", INFO6(0x20ba20, 0x104400, 64 * 1024, 1024,
15f5c7e54e658a Boris Brezillon 2020-03-13 47 SECT_4K | USE_FSR | SPI_NOR_DUAL_READ |
15f5c7e54e658a Boris Brezillon 2020-03-13 48 SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 49 { "n25q512ax3", INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 50 USE_FSR | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK) },
15f5c7e54e658a Boris Brezillon 2020-03-13 51 { "mt25qu512a", INFO6(0x20bb20, 0x104400, 64 * 1024, 1024,
15f5c7e54e658a Boris Brezillon 2020-03-13 52 SECT_4K | USE_FSR | SPI_NOR_DUAL_READ |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 53 SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 54 SPI_NOR_HAS_LOCK) },
15f5c7e54e658a Boris Brezillon 2020-03-13 55 { "n25q512a", INFO(0x20bb20, 0, 64 * 1024, 1024,
f3f2b7eb2f1c58 Jungseung Lee 2020-03-18 56 SECT_4K | USE_FSR | SPI_NOR_QUAD_READ |
f3f2b7eb2f1c58 Jungseung Lee 2020-03-18 57 SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB |
f3f2b7eb2f1c58 Jungseung Lee 2020-03-18 58 SPI_NOR_4BIT_BP | SPI_NOR_BP3_SR_BIT6) },
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 59 { "n25q00", INFO(0x20ba21, 0, 64 * 1024, 2048, SECT_4K |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 60 USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 @61 SPI_NOR_HAS_LOCK | SPI_NOR_HAS_LOCK) },
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 62 { "n25q00a", INFO(0x20bb21, 0, 64 * 1024, 2048, SECT_4K |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 63 USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 64 SPI_NOR_HAS_LOCK) },
15f5c7e54e658a Boris Brezillon 2020-03-13 65 { "mt25ql02g", INFO(0x20ba22, 0, 64 * 1024, 4096,
15f5c7e54e658a Boris Brezillon 2020-03-13 66 SECT_4K | USE_FSR | SPI_NOR_QUAD_READ |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 67 NO_CHIP_ERASE | SPI_NOR_HAS_LOCK) },
15f5c7e54e658a Boris Brezillon 2020-03-13 68 { "mt25qu02g", INFO(0x20bb22, 0, 64 * 1024, 4096,
1371a80cac33d5 David Clear 2020-07-20 69 SECT_4K | USE_FSR | SPI_NOR_DUAL_READ |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 70 SPI_NOR_QUAD_READ | NO_CHIP_ERASE |
69da6b40453662 Amit Kumar Mahapatra 2020-01-19 71 SPI_NOR_HAS_LOCK) },
15f5c7e54e658a Boris Brezillon 2020-03-13 72
15f5c7e54e658a Boris Brezillon 2020-03-13 73 { "m25p05", INFO(0x202010, 0, 32 * 1024, 2, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 74 { "m25p10", INFO(0x202011, 0, 32 * 1024, 4, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 75 { "m25p20", INFO(0x202012, 0, 64 * 1024, 4, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 76 { "m25p40", INFO(0x202013, 0, 64 * 1024, 8, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 77 { "m25p80", INFO(0x202014, 0, 64 * 1024, 16, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 78 { "m25p16", INFO(0x202015, 0, 64 * 1024, 32, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 79 { "m25p32", INFO(0x202016, 0, 64 * 1024, 64, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 80 { "m25p64", INFO(0x202017, 0, 64 * 1024, 128, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 81 { "m25p128", INFO(0x202018, 0, 256 * 1024, 64, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 82
15f5c7e54e658a Boris Brezillon 2020-03-13 83 { "m25p05-nonjedec", INFO(0, 0, 32 * 1024, 2, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 84 { "m25p10-nonjedec", INFO(0, 0, 32 * 1024, 4, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 85 { "m25p20-nonjedec", INFO(0, 0, 64 * 1024, 4, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 86 { "m25p40-nonjedec", INFO(0, 0, 64 * 1024, 8, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 87 { "m25p80-nonjedec", INFO(0, 0, 64 * 1024, 16, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 88 { "m25p16-nonjedec", INFO(0, 0, 64 * 1024, 32, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 89 { "m25p32-nonjedec", INFO(0, 0, 64 * 1024, 64, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 90 { "m25p64-nonjedec", INFO(0, 0, 64 * 1024, 128, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 91 { "m25p128-nonjedec", INFO(0, 0, 256 * 1024, 64, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 92
15f5c7e54e658a Boris Brezillon 2020-03-13 93 { "m45pe10", INFO(0x204011, 0, 64 * 1024, 2, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 94 { "m45pe80", INFO(0x204014, 0, 64 * 1024, 16, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 95 { "m45pe16", INFO(0x204015, 0, 64 * 1024, 32, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 96
15f5c7e54e658a Boris Brezillon 2020-03-13 97 { "m25pe20", INFO(0x208012, 0, 64 * 1024, 4, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 98 { "m25pe80", INFO(0x208014, 0, 64 * 1024, 16, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 99 { "m25pe16", INFO(0x208015, 0, 64 * 1024, 32, SECT_4K) },
15f5c7e54e658a Boris Brezillon 2020-03-13 100
15f5c7e54e658a Boris Brezillon 2020-03-13 101 { "m25px16", INFO(0x207115, 0, 64 * 1024, 32, SECT_4K) },
15f5c7e54e658a Boris Brezillon 2020-03-13 102 { "m25px32", INFO(0x207116, 0, 64 * 1024, 64, SECT_4K) },
15f5c7e54e658a Boris Brezillon 2020-03-13 103 { "m25px32-s0", INFO(0x207316, 0, 64 * 1024, 64, SECT_4K) },
15f5c7e54e658a Boris Brezillon 2020-03-13 104 { "m25px32-s1", INFO(0x206316, 0, 64 * 1024, 64, SECT_4K) },
15f5c7e54e658a Boris Brezillon 2020-03-13 105 { "m25px64", INFO(0x207117, 0, 64 * 1024, 128, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 106 { "m25px80", INFO(0x207114, 0, 64 * 1024, 16, 0) },
15f5c7e54e658a Boris Brezillon 2020-03-13 107 };
15f5c7e54e658a Boris Brezillon 2020-03-13 108
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
[xilinx-xlnx:xlnx_rebase_v5.4 1277/1768] drivers/gpio/gpio-xilinx.c:694:39: sparse: sparse: incorrect type in argument 1 (different base types)
by kernel test robot
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head: abafefebd1f1e040eef74e4ab571ea08bf745641
commit: af0c19b6f15388c554317280433100fd9f3d7d0a [1277/1768] gpio: xilinx: Use xilinx tested gpio driver
config: i386-randconfig-s002-20211216 (https://download.01.org/0day-ci/archive/20211218/202112180150.eRkJwheM-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/Xilinx/linux-xlnx/commit/af0c19b6f15388c55431728043310...
git remote add xilinx-xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xilinx-xlnx xlnx_rebase_v5.4
git checkout af0c19b6f15388c554317280433100fd9f3d7d0a
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpio/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/gpio/gpio-xilinx.c:694:39: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __be32 const [usertype] *p @@ got unsigned int const [usertype] *[assigned] tree_info @@
drivers/gpio/gpio-xilinx.c:694:39: sparse: expected restricted __be32 const [usertype] *p
drivers/gpio/gpio-xilinx.c:694:39: sparse: got unsigned int const [usertype] *[assigned] tree_info
vim +694 drivers/gpio/gpio-xilinx.c
586
587 /**
588 * xgpio_of_probe - Probe method for the GPIO device.
589 * @pdev: platform device instance
590 *
591 * This function probes the GPIO device in the device tree. It initializes the
592 * driver data structure.
593 *
594 * Return:
595 * It returns 0, if the driver is bound to the GPIO device, or
596 * a negative value if there is an error.
597 */
598 static int xgpio_of_probe(struct platform_device *pdev)
599 {
600 struct device_node *np = pdev->dev.of_node;
601 struct xgpio_instance *chip, *chip_dual;
602 int status = 0;
603 const u32 *tree_info;
604 u32 ngpio;
605 u32 cells = 2;
606
607 chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);
608 if (!chip)
609 return -ENOMEM;
610
611 /* Update GPIO state shadow register with default value */
612 of_property_read_u32(np, "xlnx,dout-default", &chip->gpio_state);
613
614 /* By default, all pins are inputs */
615 chip->gpio_dir = 0xFFFFFFFF;
616
617 /* Update GPIO direction shadow register with default value */
618 of_property_read_u32(np, "xlnx,tri-default", &chip->gpio_dir);
619
620 chip->no_init = of_property_read_bool(np, "xlnx,no-init");
621
622 /* Update cells with gpio-cells value */
623 of_property_read_u32(np, "#gpio-cells", &cells);
624
625 /*
626 * Check device node and parent device node for device width
627 * and assume default width of 32
628 */
629 if (of_property_read_u32(np, "xlnx,gpio-width", &ngpio))
630 ngpio = 32;
631 chip->mmchip.gc.ngpio = (u16)ngpio;
632
633 spin_lock_init(&chip->gpio_lock);
634
635 chip->mmchip.gc.parent = &pdev->dev;
636 chip->mmchip.gc.owner = THIS_MODULE;
637 chip->mmchip.gc.of_xlate = xgpio_xlate;
638 chip->mmchip.gc.of_gpio_n_cells = cells;
639 chip->mmchip.gc.direction_input = xgpio_dir_in;
640 chip->mmchip.gc.direction_output = xgpio_dir_out;
641 chip->mmchip.gc.get = xgpio_get;
642 chip->mmchip.gc.set = xgpio_set;
643 chip->mmchip.gc.request = xgpio_request;
644 chip->mmchip.gc.free = xgpio_free;
645 chip->mmchip.gc.set_multiple = xgpio_set_multiple;
646
647 chip->mmchip.save_regs = xgpio_save_regs;
648
649 platform_set_drvdata(pdev, chip);
650
651 chip->clk = devm_clk_get(&pdev->dev, "s_axi_aclk");
652 if (IS_ERR(chip->clk)) {
653 if (PTR_ERR(chip->clk) != -ENOENT) {
654 if (PTR_ERR(chip->clk) != -EPROBE_DEFER)
655 dev_err(&pdev->dev, "Input clock not found\n");
656 return PTR_ERR(chip->clk);
657 }
658
659 /*
660 * Clock framework support is optional, continue on
661 * anyways if we don't find a matching clock.
662 */
663 chip->clk = NULL;
664 }
665
666 status = clk_prepare_enable(chip->clk);
667 if (status < 0) {
668 dev_err(&pdev->dev, "Failed to prepare clk\n");
669 return status;
670 }
671
672 pm_runtime_set_active(&pdev->dev);
673 pm_runtime_enable(&pdev->dev);
674
675 /* Call the OF gpio helper to setup and register the GPIO device */
676 status = of_mm_gpiochip_add(np, &chip->mmchip);
677 if (status) {
678 pr_err("%pOF: error in probe function with status %d\n",
679 np, status);
680 goto err_unprepare_clk;
681 }
682
683 status = xgpio_irq_setup(np, chip);
684 if (status) {
685 pr_err("%s: GPIO IRQ initialization failed %d\n",
686 np->full_name, status);
687 goto err_pm_put;
688 }
689
690 pr_info("XGpio: %s: registered, base is %d\n", np->full_name,
691 chip->mmchip.gc.base);
692
693 tree_info = of_get_property(np, "xlnx,is-dual", NULL);
> 694 if (tree_info && be32_to_cpup(tree_info)) {
695 chip_dual = devm_kzalloc(&pdev->dev, sizeof(*chip_dual),
696 GFP_KERNEL);
697 if (!chip_dual)
698 goto err_pm_put;
699
700 /* Add dual channel offset */
701 chip_dual->offset = XGPIO_CHANNEL_OFFSET;
702
703 /* Update GPIO state shadow register with default value */
704 of_property_read_u32(np, "xlnx,dout-default-2",
705 &chip_dual->gpio_state);
706
707 /* By default, all pins are inputs */
708 chip_dual->gpio_dir = 0xFFFFFFFF;
709
710 /* Update GPIO direction shadow register with default value */
711 of_property_read_u32(np, "xlnx,tri-default-2",
712 &chip_dual->gpio_dir);
713
714 /*
715 * Check device node and parent device node for device width
716 * and assume default width of 32
717 */
718 if (of_property_read_u32(np, "xlnx,gpio2-width", &ngpio))
719 ngpio = 32;
720 chip_dual->mmchip.gc.ngpio = (u16)ngpio;
721
722 spin_lock_init(&chip_dual->gpio_lock);
723
724 chip_dual->mmchip.gc.parent = &pdev->dev;
725 chip_dual->mmchip.gc.owner = THIS_MODULE;
726 chip_dual->mmchip.gc.of_xlate = xgpio_xlate;
727 chip_dual->mmchip.gc.of_gpio_n_cells = cells;
728 chip_dual->mmchip.gc.direction_input = xgpio_dir_in;
729 chip_dual->mmchip.gc.direction_output = xgpio_dir_out;
730 chip_dual->mmchip.gc.get = xgpio_get;
731 chip_dual->mmchip.gc.set = xgpio_set;
732 chip_dual->mmchip.gc.request = xgpio_request;
733 chip_dual->mmchip.gc.free = xgpio_free;
734 chip_dual->mmchip.gc.set_multiple = xgpio_set_multiple;
735
736 chip_dual->mmchip.save_regs = xgpio_save_regs;
737
738 chip->mmchip_dual = &chip_dual->mmchip;
739
740 status = xgpio_irq_setup(np, chip_dual);
741 if (status) {
742 pr_err("%s: GPIO IRQ initialization failed %d\n",
743 np->full_name, status);
744 goto err_pm_put;
745 }
746
747 /* Call the OF gpio helper to setup and register the GPIO dev */
748 status = of_mm_gpiochip_add(np, &chip_dual->mmchip);
749 if (status) {
750 pr_err("%s: error in probe function with status %d\n",
751 np->full_name, status);
752 goto err_pm_put;
753 }
754 pr_info("XGpio: %s: dual channel registered, base is %d\n",
755 np->full_name, chip_dual->mmchip.gc.base);
756 }
757
758 pm_runtime_put(&pdev->dev);
759 return 0;
760
761 err_pm_put:
762 pm_runtime_put(&pdev->dev);
763 err_unprepare_clk:
764 pm_runtime_disable(&pdev->dev);
765 clk_disable_unprepare(chip->clk);
766 return status;
767 }
768
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
Re: [PATCH v7 6/7] kallsyms: add /proc/kallmodsyms
by kernel test robot
Hi Nick,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.16-rc5]
[cannot apply to masahiroy/kconfig jeyu/modules-next next-20211217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nick-Alcock/kbuild-bring-back-tr...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 136057256686de39cc3a07c2e39ef6bc43003ff6
config: arm-randconfig-r032-20211216 (https://download.01.org/0day-ci/archive/20211218/202112180057.UZKXPkGe-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dd245bab9fbb364faa1581e4f92ba3119a872fba)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/4487902c03d7f7e83c68807ab24d62c46...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nick-Alcock/kbuild-bring-back-tristate-conf/20211217-051935
git checkout 4487902c03d7f7e83c68807ab24d62c467338795
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
kernel/kallsyms.c:665:12: warning: no previous prototype for function 'arch_get_kallsym' [-Wmissing-prototypes]
int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
^
kernel/kallsyms.c:665:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
^
static
kernel/kallsyms.c:1074:30: warning: unused variable 'kallsyms_proc_ops' [-Wunused-const-variable]
static const struct proc_ops kallsyms_proc_ops = {
^
>> kernel/kallsyms.c:1082:30: warning: unused variable 'kallmodsyms_proc_ops' [-Wunused-const-variable]
static const struct proc_ops kallmodsyms_proc_ops = {
^
3 warnings generated.
vim +/kallmodsyms_proc_ops +1082 kernel/kallsyms.c
1080
1081 #ifdef CONFIG_KALLMODSYMS
> 1082 static const struct proc_ops kallmodsyms_proc_ops = {
1083 .proc_open = kallmodsyms_open,
1084 .proc_read = seq_read,
1085 .proc_lseek = seq_lseek,
1086 .proc_release = seq_release_private,
1087 };
1088 #endif
1089
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
Re: [PATCH v2] ath11k: add support of firmware logging for WCN6855
by kernel test robot
Hi Cheng,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kvalo-ath/ath-next]
[also build test WARNING on next-20211217]
[cannot apply to v5.16-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Cheng-Wang/ath11k-add-support-of...
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
config: mips-randconfig-r023-20211216 (https://download.01.org/0day-ci/archive/20211218/202112180012.UCXm8ASb-lk...)
compiler: mips64el-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3c8528cf3263af58b974c4fdc3a2d3d0e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Cheng-Wang/ath11k-add-support-of-firmware-logging-for-WCN6855/20211217-192713
git checkout 3c8528cf3263af58b974c4fdc3a2d3d0ea32bc3c
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash drivers/net/wireless/ath/ath11k/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/ath/ath11k/qmi.c:2542:5: warning: no previous prototype for 'ath11k_qmi_wlanfw_wlan_ini_send' [-Wmissing-prototypes]
2542 | int ath11k_qmi_wlanfw_wlan_ini_send(struct ath11k_base *ab, bool enable)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/ath11k_qmi_wlanfw_wlan_ini_send +2542 drivers/net/wireless/ath/ath11k/qmi.c
2541
> 2542 int ath11k_qmi_wlanfw_wlan_ini_send(struct ath11k_base *ab, bool enable)
2543 {
2544 int ret;
2545 struct qmi_txn txn;
2546 struct qmi_wlanfw_wlan_ini_req_msg_v01 req = {};
2547 struct qmi_wlanfw_wlan_ini_resp_msg_v01 resp = {};
2548
2549 req.enablefwlog_valid = true;
2550 req.enablefwlog = enable ? 1 : 0;
2551
2552 ret = qmi_txn_init(&ab->qmi.handle, &txn,
2553 qmi_wlanfw_wlan_ini_resp_msg_v01_ei, &resp);
2554 if (ret < 0)
2555 goto out;
2556
2557 ret = qmi_send_request(&ab->qmi.handle, NULL, &txn,
2558 QMI_WLANFW_WLAN_INI_REQ_V01,
2559 QMI_WLANFW_WLAN_INI_REQ_MSG_V01_MAX_LEN,
2560 qmi_wlanfw_wlan_ini_req_msg_v01_ei, &req);
2561 if (ret < 0) {
2562 ath11k_warn(ab, "qmi failed to send wlan ini request, err = %d\n",
2563 ret);
2564 qmi_txn_cancel(&txn);
2565 goto out;
2566 }
2567
2568 ret = qmi_txn_wait(&txn, msecs_to_jiffies(ATH11K_QMI_WLANFW_TIMEOUT_MS));
2569 if (ret < 0) {
2570 ath11k_warn(ab, "qmi failed wlan ini request, err = %d\n", ret);
2571 goto out;
2572 }
2573
2574 if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
2575 ath11k_warn(ab, "qmi wlan ini request failed, result: %d, err: %d\n",
2576 resp.resp.result, resp.resp.error);
2577 ret = -EINVAL;
2578 }
2579
2580 out:
2581 return ret;
2582 }
2583
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
[RFC PATCH] securityfs: securityfs_dir_inode_operations can be static
by kernel test robot
security/inode.c:43:31: warning: symbol 'securityfs_dir_inode_operations' was not declared. Should it be static?
security/inode.c:48:31: warning: symbol 'securityfs_file_inode_operations' was not declared. Should it be static?
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/security/inode.c b/security/inode.c
index a0d9f086e3d54..ff720c6bedb0a 100644
--- a/security/inode.c
+++ b/security/inode.c
@@ -40,12 +40,12 @@ static int securityfs_permission(struct user_namespace *mnt_userns,
return err;
}
-const struct inode_operations securityfs_dir_inode_operations = {
+static const struct inode_operations securityfs_dir_inode_operations = {
.permission = securityfs_permission,
.lookup = simple_lookup,
};
-const struct inode_operations securityfs_file_inode_operations = {
+static const struct inode_operations securityfs_file_inode_operations = {
.permission = securityfs_permission,
};
9 months