Re: [PATCH bpf-next v4 3/3] bpf: remove the cgroup -> bpf header dependecy
by kernel test robot
Hi Jakub,
I love your patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/bpf-remove-the-cg...
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20211216/202112160753.yRz2i2rn-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/4dc3a2bcf4720df1766ff9dc2bcbf14b3...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jakub-Kicinski/bpf-remove-the-cgroup-bpf-header-dependecy/20211216-021426
git checkout 4dc3a2bcf4720df1766ff9dc2bcbf14b3f221a31
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:88,
from init/main.c:21:
>> include/linux/perf_event.h:1499:48: warning: 'struct bpf_prog' declared inside parameter list will not be visible outside of this definition or declaration
1499 | static inline void perf_event_bpf_event(struct bpf_prog *prog,
| ^~~~~~~~
init/main.c:768:20: warning: no previous prototype for 'arch_post_acpi_subsys_init' [-Wmissing-prototypes]
768 | void __init __weak arch_post_acpi_subsys_init(void) { }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
init/main.c:780:20: warning: no previous prototype for 'mem_encrypt_init' [-Wmissing-prototypes]
780 | void __init __weak mem_encrypt_init(void) { }
| ^~~~~~~~~~~~~~~~
init/main.c:782:20: warning: no previous prototype for 'poking_init' [-Wmissing-prototypes]
782 | void __init __weak poking_init(void) { }
| ^~~~~~~~~~~
--
In file included from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:88,
from init/noinitramfs.c:11:
>> include/linux/perf_event.h:1499:48: warning: 'struct bpf_prog' declared inside parameter list will not be visible outside of this definition or declaration
1499 | static inline void perf_event_bpf_event(struct bpf_prog *prog,
| ^~~~~~~~
--
In file included from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:88,
from arch/um/kernel/syscall.c:11:
>> include/linux/perf_event.h:1499:48: warning: 'struct bpf_prog' declared inside parameter list will not be visible outside of this definition or declaration
1499 | static inline void perf_event_bpf_event(struct bpf_prog *prog,
| ^~~~~~~~
arch/um/kernel/syscall.c:17:6: warning: no previous prototype for 'old_mmap' [-Wmissing-prototypes]
17 | long old_mmap(unsigned long addr, unsigned long len,
| ^~~~~~~~
--
In file included from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:88,
from arch/x86/um/tls_32.c:8:
>> include/linux/perf_event.h:1499:48: warning: 'struct bpf_prog' declared inside parameter list will not be visible outside of this definition or declaration
1499 | static inline void perf_event_bpf_event(struct bpf_prog *prog,
| ^~~~~~~~
arch/x86/um/tls_32.c:23:5: warning: no previous prototype for 'do_set_thread_area' [-Wmissing-prototypes]
23 | int do_set_thread_area(struct user_desc *info)
| ^~~~~~~~~~~~~~~~~~
arch/x86/um/tls_32.c:39:5: warning: no previous prototype for 'do_get_thread_area' [-Wmissing-prototypes]
39 | int do_get_thread_area(struct user_desc *info)
| ^~~~~~~~~~~~~~~~~~
arch/x86/um/tls_32.c:187:5: warning: no previous prototype for 'arch_switch_tls' [-Wmissing-prototypes]
187 | int arch_switch_tls(struct task_struct *to)
| ^~~~~~~~~~~~~~~
--
In file included from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:88,
from kernel/fork.c:54:
>> include/linux/perf_event.h:1499:48: warning: 'struct bpf_prog' declared inside parameter list will not be visible outside of this definition or declaration
1499 | static inline void perf_event_bpf_event(struct bpf_prog *prog,
| ^~~~~~~~
kernel/fork.c:161:13: warning: no previous prototype for 'arch_release_task_struct' [-Wmissing-prototypes]
161 | void __weak arch_release_task_struct(struct task_struct *tsk)
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/fork.c:763:20: warning: no previous prototype for 'arch_task_cache_init' [-Wmissing-prototypes]
763 | void __init __weak arch_task_cache_init(void) { }
| ^~~~~~~~~~~~~~~~~~~~
kernel/fork.c:858:12: warning: no previous prototype for 'arch_dup_task_struct' [-Wmissing-prototypes]
858 | int __weak arch_dup_task_struct(struct task_struct *dst,
| ^~~~~~~~~~~~~~~~~~~~
--
In file included from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:88,
from kernel/exit.c:42:
>> include/linux/perf_event.h:1499:48: warning: 'struct bpf_prog' declared inside parameter list will not be visible outside of this definition or declaration
1499 | static inline void perf_event_bpf_event(struct bpf_prog *prog,
| ^~~~~~~~
kernel/exit.c:1817:13: warning: no previous prototype for 'abort' [-Wmissing-prototypes]
1817 | __weak void abort(void)
| ^~~~~
--
In file included from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:88,
from fs/pipe.c:24:
>> include/linux/perf_event.h:1499:48: warning: 'struct bpf_prog' declared inside parameter list will not be visible outside of this definition or declaration
1499 | static inline void perf_event_bpf_event(struct bpf_prog *prog,
| ^~~~~~~~
fs/pipe.c:755:15: warning: no previous prototype for 'account_pipe_buffers' [-Wmissing-prototypes]
755 | unsigned long account_pipe_buffers(struct user_struct *user,
| ^~~~~~~~~~~~~~~~~~~~
fs/pipe.c:761:6: warning: no previous prototype for 'too_many_pipe_buffers_soft' [-Wmissing-prototypes]
761 | bool too_many_pipe_buffers_soft(unsigned long user_bufs)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
fs/pipe.c:768:6: warning: no previous prototype for 'too_many_pipe_buffers_hard' [-Wmissing-prototypes]
768 | bool too_many_pipe_buffers_hard(unsigned long user_bufs)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
fs/pipe.c:775:6: warning: no previous prototype for 'pipe_is_unprivileged_user' [-Wmissing-prototypes]
775 | bool pipe_is_unprivileged_user(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
fs/pipe.c:1245:5: warning: no previous prototype for 'pipe_resize_ring' [-Wmissing-prototypes]
1245 | int pipe_resize_ring(struct pipe_inode_info *pipe, unsigned int nr_slots)
| ^~~~~~~~~~~~~~~~
--
In file included from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:88,
from fs/d_path.c:2:
>> include/linux/perf_event.h:1499:48: warning: 'struct bpf_prog' declared inside parameter list will not be visible outside of this definition or declaration
1499 | static inline void perf_event_bpf_event(struct bpf_prog *prog,
| ^~~~~~~~
fs/d_path.c:318:7: warning: no previous prototype for 'simple_dname' [-Wmissing-prototypes]
318 | char *simple_dname(struct dentry *dentry, char *buffer, int buflen)
| ^~~~~~~~~~~~
--
In file included from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:88,
from fs/io_uring.c:45:
>> include/linux/perf_event.h:1499:48: warning: 'struct bpf_prog' declared inside parameter list will not be visible outside of this definition or declaration
1499 | static inline void perf_event_bpf_event(struct bpf_prog *prog,
| ^~~~~~~~
fs/io_uring.c: In function '__io_submit_flush_completions':
fs/io_uring.c:2403:33: warning: variable 'prev' set but not used [-Wunused-but-set-variable]
2403 | struct io_wq_work_node *node, *prev;
| ^~~~
--
In file included from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:88,
from kernel/time/timer.c:35:
>> include/linux/perf_event.h:1499:48: warning: 'struct bpf_prog' declared inside parameter list will not be visible outside of this definition or declaration
1499 | static inline void perf_event_bpf_event(struct bpf_prog *prog,
| ^~~~~~~~
kernel/time/timer.c:254:5: warning: no previous prototype for 'timer_migration_handler' [-Wmissing-prototypes]
254 | int timer_migration_handler(struct ctl_table *table, int write,
| ^~~~~~~~~~~~~~~~~~~~~~~
--
In file included from include/linux/trace_events.h:10,
from include/trace/syscall.h:7,
from include/linux/syscalls.h:88,
from kernel/time/hrtimer.c:30:
>> include/linux/perf_event.h:1499:48: warning: 'struct bpf_prog' declared inside parameter list will not be visible outside of this definition or declaration
1499 | static inline void perf_event_bpf_event(struct bpf_prog *prog,
| ^~~~~~~~
kernel/time/hrtimer.c:120:21: warning: initialized field overwritten [-Woverride-init]
120 | [CLOCK_REALTIME] = HRTIMER_BASE_REALTIME,
| ^~~~~~~~~~~~~~~~~~~~~
kernel/time/hrtimer.c:120:21: note: (near initialization for 'hrtimer_clock_to_base_table[0]')
kernel/time/hrtimer.c:121:22: warning: initialized field overwritten [-Woverride-init]
121 | [CLOCK_MONOTONIC] = HRTIMER_BASE_MONOTONIC,
| ^~~~~~~~~~~~~~~~~~~~~~
kernel/time/hrtimer.c:121:22: note: (near initialization for 'hrtimer_clock_to_base_table[1]')
kernel/time/hrtimer.c:122:21: warning: initialized field overwritten [-Woverride-init]
122 | [CLOCK_BOOTTIME] = HRTIMER_BASE_BOOTTIME,
| ^~~~~~~~~~~~~~~~~~~~~
kernel/time/hrtimer.c:122:21: note: (near initialization for 'hrtimer_clock_to_base_table[7]')
kernel/time/hrtimer.c:123:17: warning: initialized field overwritten [-Woverride-init]
123 | [CLOCK_TAI] = HRTIMER_BASE_TAI,
| ^~~~~~~~~~~~~~~~
kernel/time/hrtimer.c:123:17: note: (near initialization for 'hrtimer_clock_to_base_table[11]')
kernel/time/hrtimer.c: In function '__run_hrtimer':
kernel/time/hrtimer.c:1648:7: warning: variable 'expires_in_hardirq' set but not used [-Wunused-but-set-variable]
1648 | bool expires_in_hardirq;
| ^~~~~~~~~~~~~~~~~~
..
vim +1499 include/linux/perf_event.h
76193a94522f1d include/linux/perf_event.h Song Liu 2019-01-17 1495
76193a94522f1d include/linux/perf_event.h Song Liu 2019-01-17 1496 typedef int (perf_ksymbol_get_name_f)(char *name, int name_len, void *data);
76193a94522f1d include/linux/perf_event.h Song Liu 2019-01-17 1497 static inline void perf_event_ksymbol(u16 ksym_type, u64 addr, u32 len,
76193a94522f1d include/linux/perf_event.h Song Liu 2019-01-17 1498 bool unregister, const char *sym) { }
6ee52e2a3fe4ea include/linux/perf_event.h Song Liu 2019-01-17 @1499 static inline void perf_event_bpf_event(struct bpf_prog *prog,
6ee52e2a3fe4ea include/linux/perf_event.h Song Liu 2019-01-17 1500 enum perf_bpf_event_type type,
6ee52e2a3fe4ea include/linux/perf_event.h Song Liu 2019-01-17 1501 u16 flags) { }
e041e328c4b41e include/linux/perf_event.h Peter Zijlstra 2014-05-21 1502 static inline void perf_event_exec(void) { }
82b897782d10fc include/linux/perf_event.h Adrian Hunter 2014-05-28 1503 static inline void perf_event_comm(struct task_struct *tsk, bool exec) { }
e422267322cd31 include/linux/perf_event.h Hari Bathini 2017-03-08 1504 static inline void perf_event_namespaces(struct task_struct *tsk) { }
cdd6c482c9ff9c include/linux/perf_event.h Ingo Molnar 2009-09-21 1505 static inline void perf_event_fork(struct task_struct *tsk) { }
e17d43b93e544f include/linux/perf_event.h Adrian Hunter 2020-05-12 1506 static inline void perf_event_text_poke(const void *addr,
e17d43b93e544f include/linux/perf_event.h Adrian Hunter 2020-05-12 1507 const void *old_bytes,
e17d43b93e544f include/linux/perf_event.h Adrian Hunter 2020-05-12 1508 size_t old_len,
e17d43b93e544f include/linux/perf_event.h Adrian Hunter 2020-05-12 1509 const void *new_bytes,
e17d43b93e544f include/linux/perf_event.h Adrian Hunter 2020-05-12 1510 size_t new_len) { }
cdd6c482c9ff9c include/linux/perf_event.h Ingo Molnar 2009-09-21 1511 static inline void perf_event_init(void) { }
4ed7c92d68a538 include/linux/perf_event.h Peter Zijlstra 2009-11-23 1512 static inline int perf_swevent_get_recursion_context(void) { return -1; }
4ed7c92d68a538 include/linux/perf_event.h Peter Zijlstra 2009-11-23 1513 static inline void perf_swevent_put_recursion_context(int rctx) { }
ab573844e3058e include/linux/perf_event.h Jiri Olsa 2013-05-01 1514 static inline u64 perf_swevent_set_period(struct perf_event *event) { return 0; }
44234adcdce38f include/linux/perf_event.h Frederic Weisbecker 2009-12-09 1515 static inline void perf_event_enable(struct perf_event *event) { }
44234adcdce38f include/linux/perf_event.h Frederic Weisbecker 2009-12-09 1516 static inline void perf_event_disable(struct perf_event *event) { }
500ad2d8b01390 include/linux/perf_event.h K.Prasad 2012-08-02 1517 static inline int __perf_event_disable(void *info) { return -1; }
e9d2b064149ff7 include/linux/perf_event.h Peter Zijlstra 2010-09-17 1518 static inline void perf_event_task_tick(void) { }
ffe8690c85b842 include/linux/perf_event.h Kaixu Xia 2015-08-06 1519 static inline int perf_event_release_kernel(struct perf_event *event) { return 0; }
3ca270fc9edb25 include/linux/perf_event.h Like Xu 2019-10-27 1520 static inline int perf_event_period(struct perf_event *event, u64 value)
3ca270fc9edb25 include/linux/perf_event.h Like Xu 2019-10-27 1521 {
3ca270fc9edb25 include/linux/perf_event.h Like Xu 2019-10-27 1522 return -EINVAL;
3ca270fc9edb25 include/linux/perf_event.h Like Xu 2019-10-27 1523 }
52ba4b0b99770e include/linux/perf_event.h Like Xu 2019-10-27 1524 static inline u64 perf_event_pause(struct perf_event *event, bool reset)
52ba4b0b99770e include/linux/perf_event.h Like Xu 2019-10-27 1525 {
52ba4b0b99770e include/linux/perf_event.h Like Xu 2019-10-27 1526 return 0;
52ba4b0b99770e include/linux/perf_event.h Like Xu 2019-10-27 1527 }
0793a61d4df8da include/linux/perf_counter.h Thomas Gleixner 2008-12-04 1528 #endif
0793a61d4df8da include/linux/perf_counter.h Thomas Gleixner 2008-12-04 1529
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:393:28: sparse: sparse: incorrect type in argument 1 (different base types)
by kernel test robot
Hi Krzysztof,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5472f14a37421d1bca3dddf33cabd3bd6dbefbbc
commit: 5445a0c0d3366358e7ac44efa108b6fd359873e3 memory: pl353-smc: fix compile test on !ARM_AMBA
date: 1 year, 1 month ago
config: arm-randconfig-s032-20211215 (https://download.01.org/0day-ci/archive/20211216/202112160656.JFn67Wnh-lk...)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 5445a0c0d3366358e7ac44efa108b6fd359873e3
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
arch/arm/boot/compressed/decompress.c: note: in included file (through arch/arm/boot/compressed/../../../../lib/decompress_unxz.c):
include/linux/decompress/mm.h:31:30: sparse: sparse: symbol 'malloc_ptr' was not declared. Should it be static?
include/linux/decompress/mm.h:32:20: sparse: sparse: symbol 'malloc_count' was not declared. Should it be static?
arch/arm/boot/compressed/decompress.c: note: in included file (through arch/arm/boot/compressed/../../../../lib/decompress_unxz.c):
arch/arm/boot/compressed/decompress.c: note: in included file (through arch/arm/boot/compressed/../../../../lib/decompress_unxz.c):
>> arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:393:28: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le32 const [usertype] *p @@ got unsigned int const [usertype] * @@
arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:393:28: sparse: expected restricted __le32 const [usertype] *p
arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:393:28: sparse: got unsigned int const [usertype] *
arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:427:48: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le32 const [usertype] *p @@ got unsigned int const [usertype] * @@
arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:427:48: sparse: expected restricted __le32 const [usertype] *p
arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:427:48: sparse: got unsigned int const [usertype] *
arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:435:37: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le32 const [usertype] *p @@ got unsigned int const [usertype] * @@
arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:435:37: sparse: expected restricted __le32 const [usertype] *p
arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:435:37: sparse: got unsigned int const [usertype] *
arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:459:28: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le32 const [usertype] *p @@ got unsigned int const [usertype] * @@
arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:459:28: sparse: expected restricted __le32 const [usertype] *p
arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c:459:28: sparse: got unsigned int const [usertype] *
vim +393 arch/arm/boot/compressed/../../../../lib/xz/xz_dec_stream.c
24fa0402a9b6a53 Lasse Collin 2011-01-12 385
24fa0402a9b6a53 Lasse Collin 2011-01-12 386 /* Decode the Stream Header field (the first 12 bytes of the .xz Stream). */
24fa0402a9b6a53 Lasse Collin 2011-01-12 387 static enum xz_ret dec_stream_header(struct xz_dec *s)
24fa0402a9b6a53 Lasse Collin 2011-01-12 388 {
24fa0402a9b6a53 Lasse Collin 2011-01-12 389 if (!memeq(s->temp.buf, HEADER_MAGIC, HEADER_MAGIC_SIZE))
24fa0402a9b6a53 Lasse Collin 2011-01-12 390 return XZ_FORMAT_ERROR;
24fa0402a9b6a53 Lasse Collin 2011-01-12 391
24fa0402a9b6a53 Lasse Collin 2011-01-12 392 if (xz_crc32(s->temp.buf + HEADER_MAGIC_SIZE, 2, 0)
24fa0402a9b6a53 Lasse Collin 2011-01-12 @393 != get_le32(s->temp.buf + HEADER_MAGIC_SIZE + 2))
24fa0402a9b6a53 Lasse Collin 2011-01-12 394 return XZ_DATA_ERROR;
24fa0402a9b6a53 Lasse Collin 2011-01-12 395
24fa0402a9b6a53 Lasse Collin 2011-01-12 396 if (s->temp.buf[HEADER_MAGIC_SIZE] != 0)
24fa0402a9b6a53 Lasse Collin 2011-01-12 397 return XZ_OPTIONS_ERROR;
24fa0402a9b6a53 Lasse Collin 2011-01-12 398
24fa0402a9b6a53 Lasse Collin 2011-01-12 399 /*
24fa0402a9b6a53 Lasse Collin 2011-01-12 400 * Of integrity checks, we support only none (Check ID = 0) and
24fa0402a9b6a53 Lasse Collin 2011-01-12 401 * CRC32 (Check ID = 1). However, if XZ_DEC_ANY_CHECK is defined,
24fa0402a9b6a53 Lasse Collin 2011-01-12 402 * we will accept other check types too, but then the check won't
24fa0402a9b6a53 Lasse Collin 2011-01-12 403 * be verified and a warning (XZ_UNSUPPORTED_CHECK) will be given.
24fa0402a9b6a53 Lasse Collin 2011-01-12 404 */
24fa0402a9b6a53 Lasse Collin 2011-01-12 405 s->check_type = s->temp.buf[HEADER_MAGIC_SIZE + 1];
24fa0402a9b6a53 Lasse Collin 2011-01-12 406
:::::: The code at line 393 was first introduced by commit
:::::: 24fa0402a9b6a537e87e38341e78b7da86486846 decompressors: add XZ decompressor module
:::::: TO: Lasse Collin <lasse.collin(a)tukaani.org>
:::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH v5 07/11] powerpc/mm: Use generic_get_unmapped_area() and call it from arch_get_unmapped_area()
by kernel test robot
Hi Christophe,
I love your patch! Perhaps something to improve:
[auto build test WARNING on powerpc/next]
[also build test WARNING on next-20211214]
[cannot apply to hnaz-mm/master arm64/for-next/core linus/master v5.16-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/Convert-powerpc...
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-randconfig-m031-20211214 (https://download.01.org/0day-ci/archive/20211216/202112160557.ANnYN1ZQ-lk...)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6b1717476e74918c79cc7d76b009a9e04...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christophe-Leroy/Convert-powerpc-to-default-topdown-mmap-layout/20211215-144700
git checkout 6b1717476e74918c79cc7d76b009a9e0424a4414
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from arch/powerpc/include/asm/processor.h:71,
from arch/powerpc/include/asm/thread_info.h:40,
from include/linux/thread_info.h:60,
from include/asm-generic/preempt.h:5,
from ./arch/powerpc/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:55,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:6,
from include/linux/slab.h:15,
from mm/mmap.c:13:
mm/mmap.c: In function 'generic_get_unmapped_area':
>> arch/powerpc/include/asm/task_size_64.h:84:32: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
84 | ((flags) & MAP_FIXED) && ((addr) + (len) > DEFAULT_MAP_WINDOW) ? TASK_SIZE : \
| ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/mmap.c:2142:40: note: in expansion of macro 'arch_get_mmap_end'
2142 | const unsigned long mmap_end = arch_get_mmap_end(addr, len, flags);
| ^~~~~~~~~~~~~~~~~
mm/mmap.c: In function 'generic_get_unmapped_area_topdown':
>> arch/powerpc/include/asm/task_size_64.h:84:32: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
84 | ((flags) & MAP_FIXED) && ((addr) + (len) > DEFAULT_MAP_WINDOW) ? TASK_SIZE : \
| ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/mmap.c:2190:40: note: in expansion of macro 'arch_get_mmap_end'
2190 | const unsigned long mmap_end = arch_get_mmap_end(addr, len, flags);
| ^~~~~~~~~~~~~~~~~
vim +84 arch/powerpc/include/asm/task_size_64.h
78
79 #define arch_get_mmap_base(addr, base) \
80 (((addr) > DEFAULT_MAP_WINDOW) ? (base) + TASK_SIZE - DEFAULT_MAP_WINDOW : (base))
81
82 #define arch_get_mmap_end(addr, len, flags) \
83 (((addr) > DEFAULT_MAP_WINDOW) || \
> 84 ((flags) & MAP_FIXED) && ((addr) + (len) > DEFAULT_MAP_WINDOW) ? TASK_SIZE : \
85 DEFAULT_MAP_WINDOW)
86
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
[jirislaby:devel 21/33] drivers/tty/mxser.c:826:22: error: 'port' undeclared; did you mean 'uport'?
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git devel
head: d61595c5423534810c1a3c0d4a88dd2fd81d750c
commit: 5726d981962bcf45daa931de98923a2aab063487 [21/33] mxser: switch to uart_driver
config: arc-randconfig-r043-20211214 (https://download.01.org/0day-ci/archive/20211216/202112160529.SiB1wC6L-lk...)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commi...
git remote add jirislaby https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git
git fetch --no-tags jirislaby devel
git checkout 5726d981962bcf45daa931de98923a2aab063487
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/tty/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/tty_port.h:5,
from include/linux/tty.h:12,
from drivers/tty/mxser.c:24:
drivers/tty/mxser.c: In function 'mxser_startup':
>> drivers/tty/mxser.c:826:22: error: 'port' undeclared (first use in this function); did you mean 'uport'?
826 | kfifo_reset(&port->xmit_fifo);
| ^~~~
include/linux/kfifo.h:211:17: note: in definition of macro 'kfifo_reset'
211 | typeof((fifo) + 1) __tmp = (fifo); \
| ^~~~
drivers/tty/mxser.c:826:22: note: each undeclared identifier is reported only once for each function it appears in
826 | kfifo_reset(&port->xmit_fifo);
| ^~~~
include/linux/kfifo.h:211:17: note: in definition of macro 'kfifo_reset'
211 | typeof((fifo) + 1) __tmp = (fifo); \
| ^~~~
>> include/linux/kfifo.h:212:14: error: invalid type argument of '->' (have 'int')
212 | __tmp->kfifo.in = __tmp->kfifo.out = 0; \
| ^~
drivers/tty/mxser.c:826:9: note: in expansion of macro 'kfifo_reset'
826 | kfifo_reset(&port->xmit_fifo);
| ^~~~~~~~~~~
include/linux/kfifo.h:212:32: error: invalid type argument of '->' (have 'int')
212 | __tmp->kfifo.in = __tmp->kfifo.out = 0; \
| ^~
drivers/tty/mxser.c:826:9: note: in expansion of macro 'kfifo_reset'
826 | kfifo_reset(&port->xmit_fifo);
| ^~~~~~~~~~~
At top level:
drivers/tty/mxser.c:1744:30: warning: 'mxser_ops' defined but not used [-Wunused-const-variable=]
1744 | static const struct uart_ops mxser_ops = {
| ^~~~~~~~~
vim +826 drivers/tty/mxser.c
ee7e5e66f2d4fa drivers/tty/mxser.c Jiri Slaby 2021-09-22 763
5726d981962bcf drivers/tty/mxser.c Jiri Slaby 2021-12-01 764 static int mxser_startup(struct uart_port *uport)
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 765 {
5726d981962bcf drivers/tty/mxser.c Jiri Slaby 2021-12-01 766 struct mxser_port *info = to_mport(uport);
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 767 unsigned long flags;
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 768
22d394f9712b7c drivers/tty/mxser.c Jiri Slaby 2021-12-10 769 spin_lock_irqsave(&uport->lock, flags);
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 770
e13da5a8a148c0 drivers/tty/mxser.c Jiri Slaby 2021-12-10 771 if (!uport->type) {
22d394f9712b7c drivers/tty/mxser.c Jiri Slaby 2021-12-10 772 spin_unlock_irqrestore(&uport->lock, flags);
5726d981962bcf drivers/tty/mxser.c Jiri Slaby 2021-12-01 773 return -EINVAL;
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 774 }
94c7e3efe3b70b drivers/tty/mxser.c Jiri Slaby 2021-12-15 775
5726d981962bcf drivers/tty/mxser.c Jiri Slaby 2021-12-01 776 BUG_ON("we use kfifo");
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 777
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 778 /*
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 779 * Clear the FIFO buffers and disable them
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 780 * (they will be reenabled in mxser_change_speed())
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 781 */
ee7e5e66f2d4fa drivers/tty/mxser.c Jiri Slaby 2021-09-22 782 mxser_disable_and_clear_FIFO(info);
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 783
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 784 /*
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 785 * At this point there's no way the LSR could still be 0xFF;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 786 * if it is, then bail out, because there's likely no UART
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 787 * here.
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 788 */
ea78327711f406 drivers/tty/mxser.c Jiri Slaby 2021-12-10 789 if (inb(uport->iobase + UART_LSR) == 0xff) {
22d394f9712b7c drivers/tty/mxser.c Jiri Slaby 2021-12-10 790 spin_unlock_irqrestore(&uport->lock, flags);
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 791 return -ENODEV;
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 792 }
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 793
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 794 /*
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 795 * Clear the interrupt registers.
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 796 */
ea78327711f406 drivers/tty/mxser.c Jiri Slaby 2021-12-10 797 (void) inb(uport->iobase + UART_LSR);
ea78327711f406 drivers/tty/mxser.c Jiri Slaby 2021-12-10 798 (void) inb(uport->iobase + UART_RX);
ea78327711f406 drivers/tty/mxser.c Jiri Slaby 2021-12-10 799 (void) inb(uport->iobase + UART_IIR);
ea78327711f406 drivers/tty/mxser.c Jiri Slaby 2021-12-10 800 (void) inb(uport->iobase + UART_MSR);
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 801
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 802 /*
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 803 * Now, initialize the UART
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 804 */
ea78327711f406 drivers/tty/mxser.c Jiri Slaby 2021-12-10 805 outb(UART_LCR_WLEN8, uport->iobase + UART_LCR); /* reset DLAB */
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 806 info->MCR = UART_MCR_DTR | UART_MCR_RTS;
ea78327711f406 drivers/tty/mxser.c Jiri Slaby 2021-12-10 807 outb(info->MCR, uport->iobase + UART_MCR);
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 808
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 809 /*
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 810 * Finally, enable interrupts
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 811 */
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 812 info->IER = UART_IER_MSI | UART_IER_RLSI | UART_IER_RDI;
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 813
292955a7c011e2 drivers/tty/mxser.c Jiri Slaby 2021-06-18 814 if (info->board->must_hwid)
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 815 info->IER |= MOXA_MUST_IER_EGDAI;
ea78327711f406 drivers/tty/mxser.c Jiri Slaby 2021-12-10 816 outb(info->IER, uport->iobase + UART_IER); /* enable interrupts */
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 817
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 818 /*
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 819 * And clear the interrupt registers again for luck.
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 820 */
ea78327711f406 drivers/tty/mxser.c Jiri Slaby 2021-12-10 821 (void) inb(uport->iobase + UART_LSR);
ea78327711f406 drivers/tty/mxser.c Jiri Slaby 2021-12-10 822 (void) inb(uport->iobase + UART_RX);
ea78327711f406 drivers/tty/mxser.c Jiri Slaby 2021-12-10 823 (void) inb(uport->iobase + UART_IIR);
ea78327711f406 drivers/tty/mxser.c Jiri Slaby 2021-12-10 824 (void) inb(uport->iobase + UART_MSR);
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 825
94c7e3efe3b70b drivers/tty/mxser.c Jiri Slaby 2021-12-15 @826 kfifo_reset(&port->xmit_fifo);
22d394f9712b7c drivers/tty/mxser.c Jiri Slaby 2021-12-10 827 spin_unlock_irqrestore(&uport->lock, flags);
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 828
1c45607ad3eb73 drivers/char/mxser.c Jiri Slaby 2008-02-07 829 return 0;
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 830 }
^1da177e4c3f41 drivers/char/mxser.c Linus Torvalds 2005-04-16 831
:::::: The code at line 826 was first introduced by commit
:::::: 94c7e3efe3b70b291054ac2344013c35b314ffe6 mxser: switch from xmit_buf to kfifo
:::::: TO: Jiri Slaby <jslaby(a)suse.cz>
:::::: CC: Jiri Slaby <jslaby(a)suse.cz>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH v4 2/4] mtd: rawnand: rzn1: Add new NAND controller driver
by kernel test robot
Hi Miquel,
I love your patch! Yet something to improve:
[auto build test ERROR on mtd/nand/next]
[also build test ERROR on geert-renesas-devel/next mtd/mtd/next mtd/mtd/fixes linus/master v5.16-rc5 next-20211214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Miquel-Raynal/Renesas-RZ-N1-NAND...
base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20211216/202112160417.TvfPZeKJ-lk...)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4899a382aebedd2033aba1a8c662767c8...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Miquel-Raynal/Renesas-RZ-N1-NAND-controller-support/20211215-234825
git checkout 4899a382aebedd2033aba1a8c662767c86c8d74d
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/mtd/nand/raw/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/mtd/nand/raw/rzn1-nand-controller.c:14:
>> drivers/mtd/nand/raw/rzn1-nand-controller.c:1408:25: error: 'nandc_id_table' undeclared here (not in a function); did you mean 'rzn1_nandc_id_table'?
1408 | MODULE_DEVICE_TABLE(of, nandc_id_table);
| ^~~~~~~~~~~~~~
include/linux/module.h:244:15: note: in definition of macro 'MODULE_DEVICE_TABLE'
244 | extern typeof(name) __mod_##type##__##name##_device_table \
| ^~~~
>> include/linux/module.h:244:21: error: '__mod_of__nandc_id_table_device_table' aliased to undefined symbol 'nandc_id_table'
244 | extern typeof(name) __mod_##type##__##name##_device_table \
| ^~~~~~
drivers/mtd/nand/raw/rzn1-nand-controller.c:1408:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
1408 | MODULE_DEVICE_TABLE(of, nandc_id_table);
| ^~~~~~~~~~~~~~~~~~~
vim +1408 drivers/mtd/nand/raw/rzn1-nand-controller.c
1403
1404 static const struct of_device_id rzn1_nandc_id_table[] = {
1405 { .compatible = "renesas,rzn1-nand-controller" },
1406 {} /* sentinel */
1407 };
> 1408 MODULE_DEVICE_TABLE(of, nandc_id_table);
1409
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH] drm/tilcdc: add const to of_device_id
by kernel test robot
Hi Xiang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on v5.16-rc5 next-20211214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Xiang-wangx/drm-tilcdc-add-const...
base: git://anongit.freedesktop.org/drm/drm drm-next
config: arm-randconfig-c002-20211214 (https://download.01.org/0day-ci/archive/20211216/202112160411.sNrSELAY-lk...)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/5698eadb76d94a4fc5298f5bea88b8393...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xiang-wangx/drm-tilcdc-add-const-to-of_device_id/20211216-002326
git checkout 5698eadb76d94a4fc5298f5bea88b839399ddef0
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/drm/tilcdc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/tilcdc/tilcdc_drv.c:590:34: error: conflicting types for 'tilcdc_of_match'; have 'const struct of_device_id[]'
590 | static const struct of_device_id tilcdc_of_match[] = {
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/tilcdc/tilcdc_drv.c:63:28: note: previous declaration of 'tilcdc_of_match' with type 'struct of_device_id[]'
63 | static struct of_device_id tilcdc_of_match[];
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/tilcdc/tilcdc_drv.c:63:28: error: array 'tilcdc_of_match' assumed to have one element [-Werror]
>> drivers/gpu/drm/tilcdc/tilcdc_drv.c:63:28: error: 'tilcdc_of_match' defined but not used [-Werror=unused-variable]
cc1: all warnings being treated as errors
vim +590 drivers/gpu/drm/tilcdc/tilcdc_drv.c
589
> 590 static const struct of_device_id tilcdc_of_match[] = {
591 { .compatible = "ti,am33xx-tilcdc", },
592 { .compatible = "ti,da850-tilcdc", },
593 { },
594 };
595 MODULE_DEVICE_TABLE(of, tilcdc_of_match);
596
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
[jirislaby:devel 22/33] drivers/acpi/acpi_dbg.c:263:6: warning: comparison of distinct pointer types ('typeof (len) *' (aka 'int *') and 'typeof ((CIRC_SPACE_TO_END((crc)->head, (crc)->tail, ((1UL) << 12)))) *' (aka 'unsigned int *'))
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git devel
head: d61595c5423534810c1a3c0d4a88dd2fd81d750c
commit: 4671e2ec5eadf881696fad611235561e94c6be9c [22/33] circ_buf: switch macros to inlines
config: i386-randconfig-a011-20211214 (https://download.01.org/0day-ci/archive/20211216/202112160440.3ZOATMun-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dd245bab9fbb364faa1581e4f92ba3119a872fba)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commi...
git remote add jirislaby https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git
git fetch --no-tags jirislaby devel
git checkout 4671e2ec5eadf881696fad611235561e94c6be9c
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/acpi/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/acpi/acpi_dbg.c:263:6: warning: comparison of distinct pointer types ('typeof (len) *' (aka 'int *') and 'typeof ((CIRC_SPACE_TO_END((crc)->head, (crc)->tail, ((1UL) << 12)))) *' (aka 'unsigned int *')) [-Wcompare-distinct-pointer-types]
n = min(len, circ_space_to_end(crc));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:45:19: note: expanded from macro 'min'
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~~~~~~~
include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~~~~~~~
include/linux/minmax.h:20:28: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
>> drivers/acpi/acpi_dbg.c:585:6: warning: comparison of distinct pointer types ('typeof (len) *' (aka 'int *') and 'typeof ((CIRC_CNT_TO_END((crc)->head, (crc)->tail, ((1UL) << 12)))) *' (aka 'unsigned int *')) [-Wcompare-distinct-pointer-types]
n = min(len, circ_count_to_end(crc));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:45:19: note: expanded from macro 'min'
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~~~~~~~
include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~~~~~~~
include/linux/minmax.h:20:28: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
drivers/acpi/acpi_dbg.c:655:6: warning: comparison of distinct pointer types ('typeof (len) *' (aka 'int *') and 'typeof ((CIRC_SPACE_TO_END((crc)->head, (crc)->tail, ((1UL) << 12)))) *' (aka 'unsigned int *')) [-Wcompare-distinct-pointer-types]
n = min(len, circ_space_to_end(crc));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:45:19: note: expanded from macro 'min'
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~~~~~~~
include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~~~~~~~
include/linux/minmax.h:20:28: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
3 warnings generated.
vim +263 drivers/acpi/acpi_dbg.c
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 249
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 250 static int acpi_aml_write_kern(const char *buf, int len)
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 251 {
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 252 int ret;
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 253 struct circ_buf *crc = &acpi_aml_io.out_crc;
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 254 int n;
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 255 char *p;
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 256
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 257 ret = acpi_aml_lock_write(crc, ACPI_AML_OUT_KERN);
287980e49ffc0f Arnd Bergmann 2016-05-27 258 if (ret < 0)
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 259 return ret;
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 260 /* sync tail before inserting logs */
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 261 smp_mb();
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 262 p = &crc->buf[crc->head];
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 @263 n = min(len, circ_space_to_end(crc));
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 264 memcpy(p, buf, n);
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 265 /* sync head after inserting logs */
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 266 smp_wmb();
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 267 crc->head = (crc->head + n) & (ACPI_AML_BUF_SIZE - 1);
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 268 acpi_aml_unlock_fifo(ACPI_AML_OUT_KERN, true);
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 269 return n;
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 270 }
8cfb0cdf07e2c2 Lv Zheng 2015-12-03 271
:::::: The code at line 263 was first introduced by commit
:::::: 8cfb0cdf07e2c260c4d1a102bfec35183907834f ACPI / debugger: Add IO interface to access debugger functionalities
:::::: TO: Lv Zheng <lv.zheng(a)intel.com>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
[linux-next:master 6371/6993] kernel/rcu/tree_nocb.h:1262 rcu_spawn_cpu_nocb_kthread() warn: inconsistent indenting
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 0bafb8f3ebc84525d0ae0fcea22d12151b99312f
commit: fd1d05c6c00a3a6cbbb7156c1a99396df33f75b6 [6371/6993] rcu/nocb: Handle concurrent nocb kthreads creation
config: x86_64-randconfig-m001-20211214 (https://download.01.org/0day-ci/archive/20211215/202112151130.18unyr6u-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
smatch warnings:
kernel/rcu/tree_nocb.h:1262 rcu_spawn_cpu_nocb_kthread() warn: inconsistent indenting
vim +1262 kernel/rcu/tree_nocb.h
1231
1232 /*
1233 * If the specified CPU is a no-CBs CPU that does not already have its
1234 * rcuo CB kthread, spawn it. Additionally, if the rcuo GP kthread
1235 * for this CPU's group has not yet been created, spawn it as well.
1236 */
1237 static void rcu_spawn_cpu_nocb_kthread(int cpu)
1238 {
1239 struct rcu_data *rdp = per_cpu_ptr(&rcu_data, cpu);
1240 struct rcu_data *rdp_gp;
1241 struct task_struct *t;
1242
1243 if (!rcu_scheduler_fully_active || !rcu_nocb_is_setup)
1244 return;
1245
1246 /* If there already is an rcuo kthread, then nothing to do. */
1247 if (rdp->nocb_cb_kthread)
1248 return;
1249
1250 /* If we didn't spawn the GP kthread first, reorganize! */
1251 rdp_gp = rdp->nocb_gp_rdp;
1252 mutex_lock(&rdp_gp->nocb_gp_kthread_mutex);
1253 if (!rdp_gp->nocb_gp_kthread) {
1254 t = kthread_run(rcu_nocb_gp_kthread, rdp_gp,
1255 "rcuog/%d", rdp_gp->cpu);
1256 if (WARN_ONCE(IS_ERR(t), "%s: Could not start rcuo GP kthread, OOM is now expected behavior\n", __func__)) {
1257 mutex_unlock(&rdp_gp->nocb_gp_kthread_mutex);
1258 return;
1259 }
1260 WRITE_ONCE(rdp_gp->nocb_gp_kthread, t);
1261 }
> 1262 mutex_unlock(&rdp_gp->nocb_gp_kthread_mutex);
1263
1264 /* Spawn the kthread for this CPU. */
1265 t = kthread_run(rcu_nocb_cb_kthread, rdp,
1266 "rcuo%c/%d", rcu_state.abbr, cpu);
1267 if (WARN_ONCE(IS_ERR(t), "%s: Could not start rcuo CB kthread, OOM is now expected behavior\n", __func__))
1268 return;
1269 WRITE_ONCE(rdp->nocb_cb_kthread, t);
1270 WRITE_ONCE(rdp->nocb_gp_kthread, rdp_gp->nocb_gp_kthread);
1271 }
1272
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Hello kbuild-all, for attn.
by Sullivan Ahmed
Hello, I have an Interesting business deal / offer for our mutual
benefit. I shall await your response for details.
9 months, 1 week