Re: [PATCH 7/7] drm/i915: Use struct vma_resource instead of struct vma_snapshot
by kernel test robot
Hi "Thomas,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[also build test ERROR on next-20211214]
[cannot apply to drm-exynos/exynos-drm-next drm/drm-next drm-intel/for-linux-next tegra-drm/drm/tegra/for-next airlied/drm-next v5.16-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/drm-i915-Asynch...
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-randconfig-r002-20211214 (https://download.01.org/0day-ci/archive/20211215/202112152305.rfWVQjLs-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/ede025870be746e37b5bcde123cdf741a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thomas-Hellstr-m/drm-i915-Asynchronous-vma-unbinding/20211215-183859
git checkout ede025870be746e37b5bcde123cdf741aa685fab
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/i915_request.h:43,
from drivers/gpu/drm/i915/i915_active.h:13,
from drivers/gpu/drm/i915/gem/i915_gem_object_types.h:16,
from drivers/gpu/drm/i915/display/intel_frontbuffer.h:30,
from drivers/gpu/drm/i915/i915_vma.c:28:
drivers/gpu/drm/i915/i915_vma_resource.h:176:15: error: 'struct intel_memory_region' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
176 | struct intel_memory_region *mr,
| ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_vma.c: In function 'i915_vma_resource_init_from_vma':
>> drivers/gpu/drm/i915/i915_vma.c:394:48: error: passing argument 8 of 'i915_vma_resource_init' from incompatible pointer type [-Werror=incompatible-pointer-types]
394 | i915_gem_object_is_lmem(obj), obj->mm.region,
| ~~~~~~~^~~~~~~
| |
| struct intel_memory_region *
In file included from drivers/gpu/drm/i915/i915_request.h:43,
from drivers/gpu/drm/i915/i915_active.h:13,
from drivers/gpu/drm/i915/gem/i915_gem_object_types.h:16,
from drivers/gpu/drm/i915/display/intel_frontbuffer.h:30,
from drivers/gpu/drm/i915/i915_vma.c:28:
drivers/gpu/drm/i915/i915_vma_resource.h:176:36: note: expected 'struct intel_memory_region *' but argument is of type 'struct intel_memory_region *'
176 | struct intel_memory_region *mr,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
cc1: all warnings being treated as errors
vim +/i915_vma_resource_init +394 drivers/gpu/drm/i915/i915_vma.c
385
386 I915_SELFTEST_EXPORT void
387 i915_vma_resource_init_from_vma(struct i915_vma_resource *vma_res,
388 struct i915_vma *vma)
389 {
390 struct drm_i915_gem_object *obj = vma->obj;
391
392 i915_vma_resource_init(vma_res, vma->vm, vma->pages, &vma->page_sizes,
393 obj->mm.rsgt, i915_gem_object_is_readonly(obj),
> 394 i915_gem_object_is_lmem(obj), obj->mm.region,
395 vma->ops, vma->private, vma->node.start,
396 vma->node.size, vma->size);
397 }
398
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
[asahilinux:touchpad/wip 80/82] drivers/hid/hid-appleft.c:68: warning: expecting prototype for struct magicmouse_sc. Prototype was for struct appleft_sc instead
by kernel test robot
tree: https://github.com/AsahiLinux/linux touchpad/wip
head: a2281d64fdbcbab0dae68c6ea75bd5b548332e06
commit: 23cee793a43b082dfa9c9a58a0fb9604c5825d7a [80/82] WIP: HID: Add hid-appleft for Apple Macbook Trackpads
config: nds32-allyesconfig (https://download.01.org/0day-ci/archive/20211215/202112152315.IFJ9Vy6H-lk...)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/AsahiLinux/linux/commit/23cee793a43b082dfa9c9a58a0fb96...
git remote add asahilinux https://github.com/AsahiLinux/linux
git fetch --no-tags asahilinux touchpad/wip
git checkout 23cee793a43b082dfa9c9a58a0fb9604c5825d7a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash drivers/hid/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/hid/hid-appleft.c:68: warning: expecting prototype for struct magicmouse_sc. Prototype was for struct appleft_sc instead
drivers/hid/hid-appleft.c:105: warning: Function parameter or member 'unknown_or_origin1' not described in 'tp_finger'
drivers/hid/hid-appleft.c:105: warning: Function parameter or member 'unknown_or_origin2' not described in 'tp_finger'
>> drivers/hid/hid-appleft.c:127: warning: expecting prototype for struct trackpad. Prototype was for struct tp_header instead
vim +68 drivers/hid/hid-appleft.c
43
44 /**
45 * struct magicmouse_sc - Tracks Magic Mouse-specific data.
46 * @input: Input device through which we report events.
47 * @quirks: Currently unused.
48 * @ntouches: Number of touches in most recent touch report.
49 * @scroll_accel: Number of consecutive scroll motions.
50 * @scroll_jiffies: Time of last scroll motion.
51 * @touches: Most recent data for a touch, indexed by tracking ID.
52 * @tracking_ids: Mapping of current touch input data to @touches.
53 */
54 struct appleft_sc {
55 struct input_dev *input;
56 unsigned long quirks;
57
58 int ntouches;
59
60 struct input_mt_pos pos[MAX_CONTACTS];
61 int slots[MAX_CONTACTS];
62 u8 map_contacs[MAX_CONTACTS];
63
64 struct hid_device *hdev;
65 struct delayed_work work;
66
67 int x_min, y_min, x_max, y_max;
> 68 };
69
70 /**
71 * struct tp_finger - single trackpad finger structure, le16-aligned
72 *
73 * @origin: zero when switching track finger
74 * @abs_x: absolute x coordinate
75 * @abs_y: absolute y coordinate
76 * @rel_x: relative x coordinate
77 * @rel_y: relative y coordinate
78 * @tool_major: tool area, major axis
79 * @tool_minor: tool area, minor axis
80 * @orientation: 16384 when point, else 15 bit angle
81 * @touch_major: touch area, major axis
82 * @touch_minor: touch area, minor axis
83 * @unused: zeros
84 * @pressure: pressure on forcetouch touchpad
85 * @multi: one finger: varies, more fingers: constant
86 * @crc16: on last finger: crc over the whole message struct
87 * (i.e. message header + this struct) minus the last
88 * @crc16 field; unknown on all other fingers.
89 */
90 struct tp_finger {
91 __le16 unknown_or_origin1;
92 __le16 unknown_or_origin2;
93 __le16 abs_x;
94 __le16 abs_y;
95 __le16 rel_x;
96 __le16 rel_y;
97 __le16 tool_major;
98 __le16 tool_minor;
99 __le16 orientation;
100 __le16 touch_major;
101 __le16 touch_minor;
102 __le16 unused[2];
103 __le16 pressure;
104 __le16 multi;
105 } __attribute__((packed, aligned(2)));
106
107 /**
108 * struct trackpad report
109 *
110 * @report_id: reportid
111 * @buttons: HID Usage Buttons 3 1-bit reports
112 * @num_fingers: the number of fingers being reported in @fingers
113 * @clicked: same as @buttons
114 */
115 struct tp_header {
116 // HID mouse report
117 u8 report_id;
118 u8 buttons;
119 u8 rel_x;
120 u8 rel_y;
121 u8 padding[4];
122 // HID vendor part, up to 1751 bytes
123 u8 unknown[22];
124 u8 num_fingers;
125 u8 clicked;
126 u8 unknown3[14];
> 127 };
128
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
[asahilinux:touchpad/wip 79/82] drivers/hid/spi-hid/spi-hid-apple.c:177:22: warning: no previous prototype for 'spihid_get_data'
by kernel test robot
tree: https://github.com/AsahiLinux/linux touchpad/wip
head: a2281d64fdbcbab0dae68c6ea75bd5b548332e06
commit: 49c089b290128ddba454c0341a9906337e24751e [79/82] WIP: hid: transport: spi: add apple SPI transport
config: nds32-allyesconfig (https://download.01.org/0day-ci/archive/20211215/202112152218.CbejumOS-lk...)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/AsahiLinux/linux/commit/49c089b290128ddba454c0341a9906...
git remote add asahilinux https://github.com/AsahiLinux/linux
git fetch --no-tags asahilinux touchpad/wip
git checkout 49c089b290128ddba454c0341a9906337e24751e
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash drivers/hid/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/hid/spi-hid/spi-hid-apple.c:177:22: warning: no previous prototype for 'spihid_get_data' [-Wmissing-prototypes]
177 | struct spihid_apple *spihid_get_data(struct spihid_input_dev *idev)
| ^~~~~~~~~~~~~~~
>> drivers/hid/spi-hid/spi-hid-apple.c:189:5: warning: no previous prototype for 'apple_ll_start' [-Wmissing-prototypes]
189 | int apple_ll_start(struct hid_device *hdev)
| ^~~~~~~~~~~~~~
>> drivers/hid/spi-hid/spi-hid-apple.c:195:6: warning: no previous prototype for 'apple_ll_stop' [-Wmissing-prototypes]
195 | void apple_ll_stop(struct hid_device *hdev)
| ^~~~~~~~~~~~~
>> drivers/hid/spi-hid/spi-hid-apple.c:202:5: warning: no previous prototype for 'apple_ll_open' [-Wmissing-prototypes]
202 | int apple_ll_open(struct hid_device *hdev)
| ^~~~~~~~~~~~~
>> drivers/hid/spi-hid/spi-hid-apple.c:218:6: warning: no previous prototype for 'apple_ll_close' [-Wmissing-prototypes]
218 | void apple_ll_close(struct hid_device *hdev)
| ^~~~~~~~~~~~~~
>> drivers/hid/spi-hid/spi-hid-apple.c:225:5: warning: no previous prototype for 'apple_ll_parse' [-Wmissing-prototypes]
225 | int apple_ll_parse(struct hid_device *hdev)
| ^~~~~~~~~~~~~~
>> drivers/hid/spi-hid/spi-hid-apple.c:233:5: warning: no previous prototype for 'apple_ll_raw_request' [-Wmissing-prototypes]
233 | int apple_ll_raw_request(struct hid_device *hdev, unsigned char reportnum,
| ^~~~~~~~~~~~~~~~~~~~
>> drivers/hid/spi-hid/spi-hid-apple.c:257:5: warning: no previous prototype for 'apple_ll_output_report' [-Wmissing-prototypes]
257 | int apple_ll_output_report(struct hid_device *hdev, __u8 *buf, size_t len)
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/hid/spi-hid/spi-hid-apple.c: In function 'spi_hid_apple_probe':
drivers/hid/spi-hid/spi-hid-apple.c:735:15: error: implicit declaration of function 'devm_request_threaded_irq'; did you mean 'devm_request_region'? [-Werror=implicit-function-declaration]
735 | err = devm_request_threaded_irq(dev, spihid->irq, NULL,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| devm_request_region
drivers/hid/spi-hid/spi-hid-apple.c:736:60: error: 'IRQF_ONESHOT' undeclared (first use in this function); did you mean 'SA_ONESHOT'?
736 | spi_hid_apple_irq, IRQF_ONESHOT,
| ^~~~~~~~~~~~
| SA_ONESHOT
drivers/hid/spi-hid/spi-hid-apple.c:736:60: note: each undeclared identifier is reported only once for each function it appears in
drivers/hid/spi-hid/spi-hid-apple.c: In function 'spi_hid_apple_remove':
drivers/hid/spi-hid/spi-hid-apple.c:794:9: error: implicit declaration of function 'disable_irq'; did you mean 'disable_fpu'? [-Werror=implicit-function-declaration]
794 | disable_irq(spihid->irq);
| ^~~~~~~~~~~
| disable_fpu
cc1: some warnings being treated as errors
vim +/spihid_get_data +177 drivers/hid/spi-hid/spi-hid-apple.c
176
> 177 struct spihid_apple *spihid_get_data(struct spihid_input_dev *idev)
178 {
179 switch (idev->id) {
180 case SPI_HID_DEVICE_ID_KBD:
181 return container_of(idev, struct spihid_apple, kbd);
182 case SPI_HID_DEVICE_ID_TP:
183 return container_of(idev, struct spihid_apple, tp);
184 default:
185 return NULL;
186 }
187 }
188
> 189 int apple_ll_start(struct hid_device *hdev)
190 {
191 /* no-op SPI transport is already setup */
192 return 0;
193 };
194
> 195 void apple_ll_stop(struct hid_device *hdev)
196 {
197 /* no-op, devices will be desstroyed on driver destruction */
198 struct spihid_input_dev *idev = hdev->driver_data;
199 printk(KERN_DEBUG "spihid_apple %s - dev:%hhu", __func__, idev->id);
200 }
201
> 202 int apple_ll_open(struct hid_device *hdev)
203 {
204 struct spihid_apple *spihid;
205 struct spihid_input_dev *idev = hdev->driver_data;
206 printk(KERN_DEBUG "spihid_apple %s - dev:%hhu", __func__, idev->id);
207
208 if (idev->hid_desc_len == 0) {
209 spihid = spihid_get_data(idev);
210 dev_warn(&spihid->spidev->dev,
211 "HID descriptor missing for dev %u", idev->id);
212 } else
213 idev->ready = true;
214
215 return 0;
216 }
217
> 218 void apple_ll_close(struct hid_device *hdev)
219 {
220 struct spihid_input_dev *idev = hdev->driver_data;
221 printk(KERN_DEBUG "spihid_apple %s - dev:%hhu", __func__, idev->id);
222 idev->ready = false;
223 }
224
> 225 int apple_ll_parse(struct hid_device *hdev)
226 {
227 struct spihid_input_dev *idev = hdev->driver_data;
228 printk(KERN_DEBUG "spihid_apple %s idev->id:%hhu", __func__, idev->id);
229
230 return hid_parse_report(hdev, idev->hid_desc, idev->hid_desc_len);
231 }
232
> 233 int apple_ll_raw_request(struct hid_device *hdev, unsigned char reportnum,
234 __u8 *buf, size_t len, unsigned char rtype,
235 int reqtype)
236 {
237 struct spihid_input_dev *idev = hdev->driver_data;
238 struct spihid_apple *spihid = spihid_get_data(idev);
239
240 dev_dbg(&spihid->spidev->dev, "%s reqtype:%d size:%zu", __func__,
241 reqtype, len);
242
243 switch (reqtype) {
244 case HID_REQ_GET_REPORT:
245 return 0;
246 // return i2c_hid_get_raw_report(hid, reportnum, buf, len, rtype);
247 case HID_REQ_SET_REPORT:
248 if (buf[0] != reportnum)
249 return -EINVAL;
250 return 0;
251 // return i2c_hid_output_raw_report(hid, buf, len, rtype, true);
252 default:
253 return -EIO;
254 }
255 }
256
> 257 int apple_ll_output_report(struct hid_device *hdev, __u8 *buf, size_t len)
258 {
259 struct spihid_input_dev *idev = hdev->driver_data;
260 struct spihid_apple *spihid = spihid_get_data(idev);
261 if (!spihid)
262 return -1;
263
264 dev_dbg(&spihid->spidev->dev, "%s", __func__);
265
266 return 0;
267 }
268
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
[jirislaby:devel 8/33] drivers/tty/tty_port.c:228:2: warning: 'xmit_buf' is deprecated
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git devel
head: d61595c5423534810c1a3c0d4a88dd2fd81d750c
commit: 8825023d7d2eb9e5dc298ad1996a0c753b2c4580 [8/33] tty: add kfifo to tty_port
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20211215/202112152217.TA9FNAE3-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git/commi...
git remote add jirislaby https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git
git fetch --no-tags jirislaby devel
git checkout 8825023d7d2eb9e5dc298ad1996a0c753b2c4580
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash drivers/tty/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/tty/tty_port.c: In function 'tty_port_alloc_xmit_buf':
>> drivers/tty/tty_port.c:228:2: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
228 | if (port->xmit_buf == NULL)
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:18: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:229:3: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
229 | port->xmit_buf = (unsigned char *)get_zeroed_page(GFP_KERNEL);
| ^~~~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:18: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:231:2: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
231 | if (port->xmit_buf == NULL)
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:18: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c: In function 'tty_port_free_xmit_buf':
drivers/tty/tty_port.c:240:2: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
240 | if (port->xmit_buf != NULL) {
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:18: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:241:3: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
241 | free_page((unsigned long)port->xmit_buf);
| ^~~~~~~~~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:18: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:242:3: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
242 | port->xmit_buf = NULL;
| ^~~~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:18: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c: In function 'tty_port_destructor':
drivers/tty/tty_port.c:270:2: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
270 | if (port->xmit_buf)
| ^~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:18: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
drivers/tty/tty_port.c:271:3: warning: 'xmit_buf' is deprecated [-Wdeprecated-declarations]
271 | free_page((unsigned long)port->xmit_buf);
| ^~~~~~~~~
In file included from include/linux/tty.h:12,
from drivers/tty/tty_port.c:8:
include/linux/tty_port.h:115:18: note: declared here
115 | unsigned char *xmit_buf __attribute__((deprecated));
| ^~~~~~~~
vim +/xmit_buf +228 drivers/tty/tty_port.c
8cde11b2baa1d0 drivers/tty/tty_port.c Johan Hovold 2017-05-18 223
9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 224 int tty_port_alloc_xmit_buf(struct tty_port *port)
9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 225 {
9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 226 /* We may sleep in get_zeroed_page() */
44e4909e453eaa drivers/char/tty_port.c Alan Cox 2009-11-30 227 mutex_lock(&port->buf_mutex);
9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 @228 if (port->xmit_buf == NULL)
9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 229 port->xmit_buf = (unsigned char *)get_zeroed_page(GFP_KERNEL);
44e4909e453eaa drivers/char/tty_port.c Alan Cox 2009-11-30 230 mutex_unlock(&port->buf_mutex);
9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 231 if (port->xmit_buf == NULL)
9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 232 return -ENOMEM;
9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 233 return 0;
9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 234 }
9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 235 EXPORT_SYMBOL(tty_port_alloc_xmit_buf);
9e48565d217a8a drivers/char/tty_port.c Alan Cox 2008-10-13 236
:::::: The code at line 228 was first introduced by commit
:::::: 9e48565d217a8a96cc7577308ad41e9e4b806a62 tty: Split tty_port into its own file
:::::: TO: Alan Cox <alan(a)redhat.com>
:::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH 05/43] asm: x86: instrument usercopy in get_user() and __put_user_size()
by kernel test robot
Hi Alexander,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/x86/mm]
[also build test WARNING on linus/master v5.16-rc5]
[cannot apply to tip/x86/core hnaz-mm/master next-20211214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alexander-Potapenko/Add-KernelMe...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 35fa745286ac44ee26ed100c2bd2553368ad193b
config: i386-randconfig-s001-20211214 (https://download.01.org/0day-ci/archive/20211215/202112152249.3T44bfDH-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/3209eff1f0c7f4de1f9685c4692c7ad79...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alexander-Potapenko/Add-KernelMemorySanitizer-infrastructure/20211215-003033
git checkout 3209eff1f0c7f4de1f9685c4692c7ad79e8f225b
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/w1/slaves/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user *ptr @@ got char *buf @@
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: expected void const volatile [noderef] __user *ptr
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: got char *buf
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void [noderef] __user *__ptr_pu @@ got char *buf @@
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: expected void [noderef] __user *__ptr_pu
drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: got char *buf
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user *ptr @@ got char const *buf @@
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: expected void const volatile [noderef] __user *ptr
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: got char const *buf
>> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const [noderef] __user *from @@ got char const *buf @@
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: expected void const [noderef] __user *from
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: got char const *buf
>> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const [noderef] __user *from @@ got char const *buf @@
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: expected void const [noderef] __user *from
drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: got char const *buf
vim +356 drivers/w1/slaves/w1_ds28e04.c
fbf7f7b4e2ae40 Markus Franke 2012-05-26 347
fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21 348 static ssize_t crccheck_store(struct device *dev, struct device_attribute *attr,
fbf7f7b4e2ae40 Markus Franke 2012-05-26 349 const char *buf, size_t count)
fbf7f7b4e2ae40 Markus Franke 2012-05-26 350 {
fbf7f7b4e2ae40 Markus Franke 2012-05-26 351 char val;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 352
fbf7f7b4e2ae40 Markus Franke 2012-05-26 353 if (count != 1 || !buf)
fbf7f7b4e2ae40 Markus Franke 2012-05-26 354 return -EINVAL;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 355
fbf7f7b4e2ae40 Markus Franke 2012-05-26 @356 if (get_user(val, buf))
fbf7f7b4e2ae40 Markus Franke 2012-05-26 357 return -EFAULT;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 358
fbf7f7b4e2ae40 Markus Franke 2012-05-26 359 /* convert to decimal */
fbf7f7b4e2ae40 Markus Franke 2012-05-26 360 val = val - 0x30;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 361 if (val != 0 && val != 1)
fbf7f7b4e2ae40 Markus Franke 2012-05-26 362 return -EINVAL;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 363
fbf7f7b4e2ae40 Markus Franke 2012-05-26 364 /* set the new value */
fbf7f7b4e2ae40 Markus Franke 2012-05-26 365 w1_enable_crccheck = val;
fbf7f7b4e2ae40 Markus Franke 2012-05-26 366
fbf7f7b4e2ae40 Markus Franke 2012-05-26 367 return sizeof(w1_enable_crccheck);
fbf7f7b4e2ae40 Markus Franke 2012-05-26 368 }
fbf7f7b4e2ae40 Markus Franke 2012-05-26 369
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH 06/43] asm-generic: instrument usercopy in cacheflush.h
by kernel test robot
Hi Alexander,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/x86/mm]
[also build test WARNING on linus/master v5.16-rc5]
[cannot apply to tip/x86/core hnaz-mm/master next-20211214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alexander-Potapenko/Add-KernelMe...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 35fa745286ac44ee26ed100c2bd2553368ad193b
config: h8300-randconfig-s032-20211214 (https://download.01.org/0day-ci/archive/20211215/202112152204.YealkDtu-lk...)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/a9bc41d306e2e13721a1569145cbfe732...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alexander-Potapenko/Add-KernelMemorySanitizer-infrastructure/20211215-003033
git checkout a9bc41d306e2e13721a1569145cbfe7323a60aca
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=h8300 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
mm/nommu.c:52:5: sparse: sparse: symbol 'heap_stack_gap' was not declared. Should it be static?
>> mm/nommu.c:1674:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *to @@ got void * @@
mm/nommu.c:1674:25: sparse: expected void [noderef] __user *to
mm/nommu.c:1674:25: sparse: got void *
>> mm/nommu.c:1677:25: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const [noderef] __user *from @@ got void * @@
mm/nommu.c:1677:25: sparse: expected void const [noderef] __user *from
mm/nommu.c:1677:25: sparse: got void *
>> mm/nommu.c:1677:25: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const [noderef] __user *from @@ got void * @@
mm/nommu.c:1677:25: sparse: expected void const [noderef] __user *from
mm/nommu.c:1677:25: sparse: got void *
mm/nommu.c:519:9: sparse: sparse: context imbalance in '__put_nommu_region' - wrong count at exit
mm/nommu.c:540:13: sparse: sparse: context imbalance in 'put_nommu_region' - unexpected unlock
vim +1674 mm/nommu.c
f1820361f83d55 Kirill A. Shutemov 2014-04-07 1655
d3f5ffcacd1528 John Hubbard 2020-12-14 1656 int __access_remote_vm(struct mm_struct *mm, unsigned long addr, void *buf,
d3f5ffcacd1528 John Hubbard 2020-12-14 1657 int len, unsigned int gup_flags)
0ec76a110f432e David Howells 2006-09-27 1658 {
0ec76a110f432e David Howells 2006-09-27 1659 struct vm_area_struct *vma;
442486ec109678 Lorenzo Stoakes 2016-10-13 1660 int write = gup_flags & FOLL_WRITE;
0ec76a110f432e David Howells 2006-09-27 1661
d8ed45c5dcd455 Michel Lespinasse 2020-06-08 1662 if (mmap_read_lock_killable(mm))
1e426fe28261b0 Konstantin Khlebnikov 2019-07-11 1663 return 0;
0ec76a110f432e David Howells 2006-09-27 1664
0ec76a110f432e David Howells 2006-09-27 1665 /* the access must start within one of the target process's mappings */
0159b141d8b1f9 David Howells 2006-09-27 1666 vma = find_vma(mm, addr);
0159b141d8b1f9 David Howells 2006-09-27 1667 if (vma) {
0ec76a110f432e David Howells 2006-09-27 1668 /* don't overrun this mapping */
0ec76a110f432e David Howells 2006-09-27 1669 if (addr + len >= vma->vm_end)
0ec76a110f432e David Howells 2006-09-27 1670 len = vma->vm_end - addr;
0ec76a110f432e David Howells 2006-09-27 1671
0ec76a110f432e David Howells 2006-09-27 1672 /* only read or write mappings where it is permitted */
d00c7b993712e4 David Howells 2006-09-27 1673 if (write && vma->vm_flags & VM_MAYWRITE)
7959722b951cff Jie Zhang 2010-01-06 @1674 copy_to_user_page(vma, NULL, addr,
7959722b951cff Jie Zhang 2010-01-06 1675 (void *) addr, buf, len);
d00c7b993712e4 David Howells 2006-09-27 1676 else if (!write && vma->vm_flags & VM_MAYREAD)
7959722b951cff Jie Zhang 2010-01-06 @1677 copy_from_user_page(vma, NULL, addr,
7959722b951cff Jie Zhang 2010-01-06 1678 buf, (void *) addr, len);
0ec76a110f432e David Howells 2006-09-27 1679 else
0ec76a110f432e David Howells 2006-09-27 1680 len = 0;
0ec76a110f432e David Howells 2006-09-27 1681 } else {
0ec76a110f432e David Howells 2006-09-27 1682 len = 0;
0ec76a110f432e David Howells 2006-09-27 1683 }
0ec76a110f432e David Howells 2006-09-27 1684
d8ed45c5dcd455 Michel Lespinasse 2020-06-08 1685 mmap_read_unlock(mm);
f55f199b7d76a0 Mike Frysinger 2011-03-29 1686
f55f199b7d76a0 Mike Frysinger 2011-03-29 1687 return len;
f55f199b7d76a0 Mike Frysinger 2011-03-29 1688 }
f55f199b7d76a0 Mike Frysinger 2011-03-29 1689
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH] sfc_ef100: potential dereference of null pointer
by kernel test robot
Hi Jiasheng,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.16-rc5 next-20211214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jiasheng-Jiang/sfc_ef100-potenti...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 5472f14a37421d1bca3dddf33cabd3bd6dbefbbc
config: microblaze-allyesconfig (https://download.01.org/0day-ci/archive/20211215/202112152115.lNKRy4uk-lk...)
compiler: microblaze-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/fc56ac03164889a206ee1b65187a8be7a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jiasheng-Jiang/sfc_ef100-potential-dereference-of-null-pointer/20211215-174422
git checkout fc56ac03164889a206ee1b65187a8be7aa7b0f04
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/net/ethernet/sfc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/sfc/ef100_nic.c: In function 'ef100_update_stats':
>> drivers/net/ethernet/sfc/ef100_nic.c:608:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
608 | struct ef100_nic_data *nic_data = efx->nic_data;
| ^~~~~~
vim +608 drivers/net/ethernet/sfc/ef100_nic.c
b593b6f1b492170 Edward Cree 2020-08-03 599
b593b6f1b492170 Edward Cree 2020-08-03 600 static size_t ef100_update_stats(struct efx_nic *efx,
b593b6f1b492170 Edward Cree 2020-08-03 601 u64 *full_stats,
b593b6f1b492170 Edward Cree 2020-08-03 602 struct rtnl_link_stats64 *core_stats)
b593b6f1b492170 Edward Cree 2020-08-03 603 {
b593b6f1b492170 Edward Cree 2020-08-03 604 __le64 *mc_stats = kmalloc(array_size(efx->num_mac_stats, sizeof(__le64)), GFP_ATOMIC);
fc56ac03164889a Jiasheng Jiang 2021-12-15 605 if (!mc_stats)
fc56ac03164889a Jiasheng Jiang 2021-12-15 606 return 0;
fc56ac03164889a Jiasheng Jiang 2021-12-15 607
b593b6f1b492170 Edward Cree 2020-08-03 @608 struct ef100_nic_data *nic_data = efx->nic_data;
b593b6f1b492170 Edward Cree 2020-08-03 609 DECLARE_BITMAP(mask, EF100_STAT_COUNT) = {};
b593b6f1b492170 Edward Cree 2020-08-03 610 u64 *stats = nic_data->stats;
b593b6f1b492170 Edward Cree 2020-08-03 611
b593b6f1b492170 Edward Cree 2020-08-03 612 ef100_common_stat_mask(mask);
b593b6f1b492170 Edward Cree 2020-08-03 613 ef100_ethtool_stat_mask(mask);
b593b6f1b492170 Edward Cree 2020-08-03 614
b593b6f1b492170 Edward Cree 2020-08-03 615 efx_nic_copy_stats(efx, mc_stats);
b593b6f1b492170 Edward Cree 2020-08-03 616 efx_nic_update_stats(ef100_stat_desc, EF100_STAT_COUNT, mask,
b593b6f1b492170 Edward Cree 2020-08-03 617 stats, mc_stats, false);
b593b6f1b492170 Edward Cree 2020-08-03 618
b593b6f1b492170 Edward Cree 2020-08-03 619 kfree(mc_stats);
b593b6f1b492170 Edward Cree 2020-08-03 620
b593b6f1b492170 Edward Cree 2020-08-03 621 return ef100_update_stats_common(efx, full_stats, core_stats);
b593b6f1b492170 Edward Cree 2020-08-03 622 }
b593b6f1b492170 Edward Cree 2020-08-03 623
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week