Re: [PATCH net-next 1/4] fib: remove suppress indirection
by kernel test robot
Hi Florian,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Florian-Westphal/fib-remove-supp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 97884b07122aabb2d6891ce17f54e0e8e94d0bc5
config: hexagon-randconfig-r041-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140528.DqSB8cFq-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/585507534b121a41b45edaec79fe6c3d9...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Florian-Westphal/fib-remove-suppress-indirection-merge-nl-policies/20211213-233429
git checkout 585507534b121a41b45edaec79fe6c3d94a50b5f
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/core/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
>> net/core/fib_rules.c:300:31: error: implicit declaration of function 'fib_info_nhc' [-Werror,-Wimplicit-function-declaration]
struct fib_nh_common *nhc = fib_info_nhc(result->fi, 0);
^
net/core/fib_rules.c:300:31: note: did you mean 'fib_info_put'?
include/net/ip_fib.h:574:20: note: 'fib_info_put' declared here
static inline void fib_info_put(struct fib_info *fi)
^
>> net/core/fib_rules.c:300:25: warning: incompatible integer to pointer conversion initializing 'struct fib_nh_common *' with an expression of type 'int' [-Wint-conversion]
struct fib_nh_common *nhc = fib_info_nhc(result->fi, 0);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> net/core/fib_rules.c:330:27: error: incomplete definition of type 'struct fib6_result'
struct rt6_info *rt = res->rt6;
~~~^
include/net/ipv6_stubs.h:17:8: note: forward declaration of 'struct fib6_result'
struct fib6_result;
^
>> net/core/fib_rules.c:336:8: error: incomplete definition of type 'struct rt6_info'
if (rt->rt6i_idev)
~~^
include/net/netns/ipv6.h:70:9: note: forward declaration of 'struct rt6_info'
struct rt6_info *ip6_null_entry;
^
net/core/fib_rules.c:337:11: error: incomplete definition of type 'struct rt6_info'
dev = rt->rt6i_idev->dev;
~~^
include/net/netns/ipv6.h:70:9: note: forward declaration of 'struct rt6_info'
struct rt6_info *ip6_null_entry;
^
net/core/fib_rules.c:342:8: error: incomplete definition of type 'struct rt6_info'
if (rt->rt6i_dst.plen <= rule->suppress_prefixlen)
~~^
include/net/netns/ipv6.h:70:9: note: forward declaration of 'struct rt6_info'
struct rt6_info *ip6_null_entry;
^
>> net/core/fib_rules.c:354:2: error: implicit declaration of function 'ip6_rt_put_flags' [-Werror,-Wimplicit-function-declaration]
ip6_rt_put_flags(rt, flags);
^
1 warning and 6 errors generated.
vim +/fib_info_nhc +300 net/core/fib_rules.c
291
292 static bool fib4_rule_suppress(struct fib_rule *rule,
293 int flags,
294 struct fib_lookup_arg *arg)
295 {
296 struct fib_result *result = (struct fib_result *)arg->result;
297 struct net_device *dev = NULL;
298
299 if (result->fi) {
> 300 struct fib_nh_common *nhc = fib_info_nhc(result->fi, 0);
301
302 dev = nhc->nhc_dev;
303 }
304
305 /* do not accept result if the route does
306 * not meet the required prefix length
307 */
308 if (result->prefixlen <= rule->suppress_prefixlen)
309 goto suppress_route;
310
311 /* do not accept result if the route uses a device
312 * belonging to a forbidden interface group
313 */
314 if (rule->suppress_ifgroup != -1 && dev && dev->group == rule->suppress_ifgroup)
315 goto suppress_route;
316
317 return false;
318
319 suppress_route:
320 if (!(arg->flags & FIB_LOOKUP_NOREF))
321 fib_info_put(result->fi);
322 return true;
323 }
324
325 static bool fib6_rule_suppress(struct fib_rule *rule,
326 int flags,
327 struct fib_lookup_arg *arg)
328 {
329 struct fib6_result *res = arg->result;
> 330 struct rt6_info *rt = res->rt6;
331 struct net_device *dev = NULL;
332
333 if (!rt)
334 return false;
335
> 336 if (rt->rt6i_idev)
337 dev = rt->rt6i_idev->dev;
338
339 /* do not accept result if the route does
340 * not meet the required prefix length
341 */
342 if (rt->rt6i_dst.plen <= rule->suppress_prefixlen)
343 goto suppress_route;
344
345 /* do not accept result if the route uses a device
346 * belonging to a forbidden interface group
347 */
348 if (rule->suppress_ifgroup != -1 && dev && dev->group == rule->suppress_ifgroup)
349 goto suppress_route;
350
351 return false;
352
353 suppress_route:
> 354 ip6_rt_put_flags(rt, flags);
355 return true;
356 }
357
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH net-next 1/4] fib: remove suppress indirection
by kernel test robot
Hi Florian,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Florian-Westphal/fib-remove-supp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 97884b07122aabb2d6891ce17f54e0e8e94d0bc5
config: i386-randconfig-a015-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140516.lS6zCrEh-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/585507534b121a41b45edaec79fe6c3d9...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Florian-Westphal/fib-remove-suppress-indirection-merge-nl-policies/20211213-233429
git checkout 585507534b121a41b45edaec79fe6c3d94a50b5f
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/core/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
net/core/fib_rules.c: In function 'fib4_rule_suppress':
net/core/fib_rules.c:300:31: error: implicit declaration of function 'fib_info_nhc'; did you mean 'fib_info_put'? [-Werror=implicit-function-declaration]
300 | struct fib_nh_common *nhc = fib_info_nhc(result->fi, 0);
| ^~~~~~~~~~~~
| fib_info_put
>> net/core/fib_rules.c:300:31: warning: initialization of 'struct fib_nh_common *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
net/core/fib_rules.c: In function 'fib6_rule_suppress':
net/core/fib_rules.c:330:27: error: dereferencing pointer to incomplete type 'struct fib6_result'
330 | struct rt6_info *rt = res->rt6;
| ^~
net/core/fib_rules.c:336:8: error: dereferencing pointer to incomplete type 'struct rt6_info'
336 | if (rt->rt6i_idev)
| ^~
net/core/fib_rules.c:354:2: error: implicit declaration of function 'ip6_rt_put_flags' [-Werror=implicit-function-declaration]
354 | ip6_rt_put_flags(rt, flags);
| ^~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +300 net/core/fib_rules.c
291
292 static bool fib4_rule_suppress(struct fib_rule *rule,
293 int flags,
294 struct fib_lookup_arg *arg)
295 {
296 struct fib_result *result = (struct fib_result *)arg->result;
297 struct net_device *dev = NULL;
298
299 if (result->fi) {
> 300 struct fib_nh_common *nhc = fib_info_nhc(result->fi, 0);
301
302 dev = nhc->nhc_dev;
303 }
304
305 /* do not accept result if the route does
306 * not meet the required prefix length
307 */
308 if (result->prefixlen <= rule->suppress_prefixlen)
309 goto suppress_route;
310
311 /* do not accept result if the route uses a device
312 * belonging to a forbidden interface group
313 */
314 if (rule->suppress_ifgroup != -1 && dev && dev->group == rule->suppress_ifgroup)
315 goto suppress_route;
316
317 return false;
318
319 suppress_route:
320 if (!(arg->flags & FIB_LOOKUP_NOREF))
321 fib_info_put(result->fi);
322 return true;
323 }
324
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH net-next 1/4] fib: remove suppress indirection
by kernel test robot
Hi Florian,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Florian-Westphal/fib-remove-supp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 97884b07122aabb2d6891ce17f54e0e8e94d0bc5
config: i386-randconfig-a001-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140418.ghGEE99T-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/585507534b121a41b45edaec79fe6c3d9...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Florian-Westphal/fib-remove-suppress-indirection-merge-nl-policies/20211213-233429
git checkout 585507534b121a41b45edaec79fe6c3d94a50b5f
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash net/core/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
net/core/fib_rules.c:300:31: error: implicit declaration of function 'fib_info_nhc' [-Werror,-Wimplicit-function-declaration]
struct fib_nh_common *nhc = fib_info_nhc(result->fi, 0);
^
net/core/fib_rules.c:300:31: note: did you mean 'fib_info_put'?
include/net/ip_fib.h:574:20: note: 'fib_info_put' declared here
static inline void fib_info_put(struct fib_info *fi)
^
>> net/core/fib_rules.c:300:25: warning: incompatible integer to pointer conversion initializing 'struct fib_nh_common *' with an expression of type 'int' [-Wint-conversion]
struct fib_nh_common *nhc = fib_info_nhc(result->fi, 0);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/core/fib_rules.c:330:27: error: incomplete definition of type 'struct fib6_result'
struct rt6_info *rt = res->rt6;
~~~^
include/net/ipv6_stubs.h:17:8: note: forward declaration of 'struct fib6_result'
struct fib6_result;
^
net/core/fib_rules.c:336:8: error: incomplete definition of type 'struct rt6_info'
if (rt->rt6i_idev)
~~^
include/net/netns/ipv6.h:70:9: note: forward declaration of 'struct rt6_info'
struct rt6_info *ip6_null_entry;
^
net/core/fib_rules.c:337:11: error: incomplete definition of type 'struct rt6_info'
dev = rt->rt6i_idev->dev;
~~^
include/net/netns/ipv6.h:70:9: note: forward declaration of 'struct rt6_info'
struct rt6_info *ip6_null_entry;
^
net/core/fib_rules.c:342:8: error: incomplete definition of type 'struct rt6_info'
if (rt->rt6i_dst.plen <= rule->suppress_prefixlen)
~~^
include/net/netns/ipv6.h:70:9: note: forward declaration of 'struct rt6_info'
struct rt6_info *ip6_null_entry;
^
net/core/fib_rules.c:354:2: error: implicit declaration of function 'ip6_rt_put_flags' [-Werror,-Wimplicit-function-declaration]
ip6_rt_put_flags(rt, flags);
^
1 warning and 6 errors generated.
vim +300 net/core/fib_rules.c
291
292 static bool fib4_rule_suppress(struct fib_rule *rule,
293 int flags,
294 struct fib_lookup_arg *arg)
295 {
296 struct fib_result *result = (struct fib_result *)arg->result;
297 struct net_device *dev = NULL;
298
299 if (result->fi) {
> 300 struct fib_nh_common *nhc = fib_info_nhc(result->fi, 0);
301
302 dev = nhc->nhc_dev;
303 }
304
305 /* do not accept result if the route does
306 * not meet the required prefix length
307 */
308 if (result->prefixlen <= rule->suppress_prefixlen)
309 goto suppress_route;
310
311 /* do not accept result if the route uses a device
312 * belonging to a forbidden interface group
313 */
314 if (rule->suppress_ifgroup != -1 && dev && dev->group == rule->suppress_ifgroup)
315 goto suppress_route;
316
317 return false;
318
319 suppress_route:
320 if (!(arg->flags & FIB_LOOKUP_NOREF))
321 fib_info_put(result->fi);
322 return true;
323 }
324
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH v1 2/2] pinctrl: Propagate firmware node from a parent device
by kernel test robot
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on linusw-pinctrl/devel]
[cannot apply to geert-renesas-drivers/renesas-pinctrl v5.16-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/pinctrl-Get-rid-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: hexagon-randconfig-r045-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140342.nuGxXwso-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/09301bc05d31cbebbea459be85ce973a0...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Andy-Shevchenko/pinctrl-Get-rid-of-duplicate-of_node-assignment-in-the-drivers/20211214-004129
git checkout 09301bc05d31cbebbea459be85ce973a065379d1
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/pinctrl/cirrus/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
>> drivers/pinctrl/cirrus/pinctrl-madera-core.c:1007:30: error: implicit declaration of function 'dev_fwnode' [-Werror,-Wimplicit-function-declaration]
device_set_node(&pdev->dev, dev_fwnode(pdev->dev.parent));
^
drivers/pinctrl/cirrus/pinctrl-madera-core.c:1007:30: note: did you mean 'dev_of_node'?
include/linux/device.h:783:35: note: 'dev_of_node' declared here
static inline struct device_node *dev_of_node(struct device *dev)
^
>> drivers/pinctrl/cirrus/pinctrl-madera-core.c:1007:30: warning: incompatible integer to pointer conversion passing 'int' to parameter of type 'struct fwnode_handle *' [-Wint-conversion]
device_set_node(&pdev->dev, dev_fwnode(pdev->dev.parent));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/device.h:854:64: note: passing argument to parameter 'fwnode' here
void device_set_node(struct device *dev, struct fwnode_handle *fwnode);
^
1 warning and 1 error generated.
vim +/dev_fwnode +1007 drivers/pinctrl/cirrus/pinctrl-madera-core.c
994
995 static int madera_pin_probe(struct platform_device *pdev)
996 {
997 struct madera *madera = dev_get_drvdata(pdev->dev.parent);
998 const struct madera_pdata *pdata = &madera->pdata;
999 struct madera_pin_private *priv;
1000 int ret;
1001
1002 BUILD_BUG_ON(ARRAY_SIZE(madera_pin_single_group_names) !=
1003 ARRAY_SIZE(madera_pin_single_group_pins));
1004
1005 dev_dbg(&pdev->dev, "%s\n", __func__);
1006
> 1007 device_set_node(&pdev->dev, dev_fwnode(pdev->dev.parent));
1008
1009 priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
1010 if (!priv)
1011 return -ENOMEM;
1012
1013 priv->dev = &pdev->dev;
1014 priv->madera = madera;
1015
1016 switch (madera->type) {
1017 case CS47L15:
1018 if (IS_ENABLED(CONFIG_PINCTRL_CS47L15))
1019 priv->chip = &cs47l15_pin_chip;
1020 break;
1021 case CS47L35:
1022 if (IS_ENABLED(CONFIG_PINCTRL_CS47L35))
1023 priv->chip = &cs47l35_pin_chip;
1024 break;
1025 case CS47L85:
1026 case WM1840:
1027 if (IS_ENABLED(CONFIG_PINCTRL_CS47L85))
1028 priv->chip = &cs47l85_pin_chip;
1029 break;
1030 case CS47L90:
1031 case CS47L91:
1032 if (IS_ENABLED(CONFIG_PINCTRL_CS47L90))
1033 priv->chip = &cs47l90_pin_chip;
1034 break;
1035 case CS42L92:
1036 case CS47L92:
1037 case CS47L93:
1038 if (IS_ENABLED(CONFIG_PINCTRL_CS47L92))
1039 priv->chip = &cs47l92_pin_chip;
1040 break;
1041 default:
1042 break;
1043 }
1044
1045 if (!priv->chip)
1046 return -ENODEV;
1047
1048 madera_pin_desc.npins = priv->chip->n_pins;
1049
1050 ret = devm_pinctrl_register_and_init(&pdev->dev,
1051 &madera_pin_desc,
1052 priv,
1053 &priv->pctl);
1054 if (ret) {
1055 dev_err(priv->dev, "Failed pinctrl register (%d)\n", ret);
1056 return ret;
1057 }
1058
1059 /* if the configuration is provided through pdata, apply it */
1060 if (pdata->gpio_configs) {
1061 ret = pinctrl_register_mappings(pdata->gpio_configs,
1062 pdata->n_gpio_configs);
1063 if (ret) {
1064 dev_err(priv->dev,
1065 "Failed to register pdata mappings (%d)\n",
1066 ret);
1067 return ret;
1068 }
1069 }
1070
1071 ret = pinctrl_enable(priv->pctl);
1072 if (ret) {
1073 dev_err(priv->dev, "Failed to enable pinctrl (%d)\n", ret);
1074 return ret;
1075 }
1076
1077 platform_set_drvdata(pdev, priv);
1078
1079 dev_dbg(priv->dev, "pinctrl probed ok\n");
1080
1081 return 0;
1082 }
1083
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
[paulmck-rcu:dev.2021.12.07a 56/57] kernel/rcu/tree.c:4312:45: warning: variable 'flags' is uninitialized when used here
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2021.12.07a
head: 89ddc546d3ad541bc89ec553c92036c98aef57a6
commit: 342f2d0f88f3c2d7ab2ae206be5846579319e3bf [56/57] rcu: Kill rnp->ofl_seq and use only rcu_state.ofl_lock for exclusion
config: hexagon-randconfig-r041-20211210 (https://download.01.org/0day-ci/archive/20211210/202112101543.wHvqhgYk-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 097a1cb1d5ebb3a0ec4bcaed8ba3ff6a8e33c00a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/com...
git remote add paulmck-rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
git fetch --no-tags paulmck-rcu dev.2021.12.07a
git checkout 342f2d0f88f3c2d7ab2ae206be5846579319e3bf
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> kernel/rcu/tree.c:4312:45: warning: variable 'flags' is uninitialized when used here [-Wuninitialized]
rcu_report_qs_rnp(mask, rnp, rnp->gp_seq, flags);
^~~~~
kernel/rcu/tree.c:4280:21: note: initialize the variable 'flags' to silence this warning
unsigned long flags, seq_flags;
^
= 0
1 warning generated.
vim +/flags +4312 kernel/rcu/tree.c
4df8374254ea929 Thomas Gleixner 2016-07-13 4266
7ec99de36f40261 Paul E. McKenney 2016-06-30 4267 /*
7ec99de36f40261 Paul E. McKenney 2016-06-30 4268 * Mark the specified CPU as being online so that subsequent grace periods
7ec99de36f40261 Paul E. McKenney 2016-06-30 4269 * (both expedited and normal) will wait on it. Note that this means that
7ec99de36f40261 Paul E. McKenney 2016-06-30 4270 * incoming CPUs are not allowed to use RCU read-side critical sections
7ec99de36f40261 Paul E. McKenney 2016-06-30 4271 * until this function is called. Failing to observe this restriction
7ec99de36f40261 Paul E. McKenney 2016-06-30 4272 * will result in lockdep splats.
deb34f364398083 Paul E. McKenney 2017-03-23 4273 *
deb34f364398083 Paul E. McKenney 2017-03-23 4274 * Note that this function is special in that it is invoked directly
deb34f364398083 Paul E. McKenney 2017-03-23 4275 * from the incoming CPU rather than from the cpuhp_step mechanism.
deb34f364398083 Paul E. McKenney 2017-03-23 4276 * This is because this function must be invoked at a precise location.
7ec99de36f40261 Paul E. McKenney 2016-06-30 4277 */
7ec99de36f40261 Paul E. McKenney 2016-06-30 4278 void rcu_cpu_starting(unsigned int cpu)
7ec99de36f40261 Paul E. McKenney 2016-06-30 4279 {
342f2d0f88f3c2d David Woodhouse 2021-12-09 4280 unsigned long flags, seq_flags;
7ec99de36f40261 Paul E. McKenney 2016-06-30 4281 unsigned long mask;
7ec99de36f40261 Paul E. McKenney 2016-06-30 4282 struct rcu_data *rdp;
7ec99de36f40261 Paul E. McKenney 2016-06-30 4283 struct rcu_node *rnp;
abfce0414814149 Wei Yang 2020-04-19 4284 bool newcpu;
7ec99de36f40261 Paul E. McKenney 2016-06-30 4285
c0f97f20e5d97a1 Paul E. McKenney 2020-07-24 4286 rdp = per_cpu_ptr(&rcu_data, cpu);
c0f97f20e5d97a1 Paul E. McKenney 2020-07-24 4287 if (rdp->cpu_started)
f64c6013a202931 Peter Zijlstra 2018-05-22 4288 return;
c0f97f20e5d97a1 Paul E. McKenney 2020-07-24 4289 rdp->cpu_started = true;
f64c6013a202931 Peter Zijlstra 2018-05-22 4290
7ec99de36f40261 Paul E. McKenney 2016-06-30 4291 rnp = rdp->mynode;
7ec99de36f40261 Paul E. McKenney 2016-06-30 4292 mask = rdp->grpmask;
342f2d0f88f3c2d David Woodhouse 2021-12-09 4293 local_irq_save(seq_flags);
342f2d0f88f3c2d David Woodhouse 2021-12-09 4294 arch_spin_lock(&rcu_state.ofl_lock);
2caebefb00f03b5 Paul E. McKenney 2021-07-28 4295 rcu_dynticks_eqs_online();
4d60b475f858ebd Paul E. McKenney 2020-10-13 4296 smp_mb(); // Pair with rcu_gp_cleanup()'s ->ofl_seq barrier().
342f2d0f88f3c2d David Woodhouse 2021-12-09 4297 raw_spin_lock_rcu_node(rnp);
105abf82b0a6266 Paul E. McKenney 2020-01-03 4298 WRITE_ONCE(rnp->qsmaskinitnext, rnp->qsmaskinitnext | mask);
abfce0414814149 Wei Yang 2020-04-19 4299 newcpu = !(rnp->expmaskinitnext & mask);
7ec99de36f40261 Paul E. McKenney 2016-06-30 4300 rnp->expmaskinitnext |= mask;
313517fc44fb2d8 Paul E. McKenney 2017-06-08 4301 /* Allow lockless access for expedited grace periods. */
abfce0414814149 Wei Yang 2020-04-19 4302 smp_store_release(&rcu_state.ncpus, rcu_state.ncpus + newcpu); /* ^^^ */
2f08469563550d1 Paul E. McKenney 2020-02-10 4303 ASSERT_EXCLUSIVE_WRITER(rcu_state.ncpus);
e05121ba5b81e2f Paul E. McKenney 2018-05-07 4304 rcu_gpnum_ovf(rnp, rdp); /* Offline-induced counter wrap? */
eb7a6653887b540 Paul E. McKenney 2018-07-05 4305 rdp->rcu_onl_gp_seq = READ_ONCE(rcu_state.gp_seq);
eb7a6653887b540 Paul E. McKenney 2018-07-05 4306 rdp->rcu_onl_gp_flags = READ_ONCE(rcu_state.gp_flags);
9f866dac94292f9 Joel Fernandes (Google 2020-09-29 4307)
9f866dac94292f9 Joel Fernandes (Google 2020-09-29 4308) /* An incoming CPU should never be blocking a grace period. */
9f866dac94292f9 Joel Fernandes (Google 2020-09-29 4309) if (WARN_ON_ONCE(rnp->qsmask & mask)) { /* RCU waiting on incoming CPU? */
516e5ae0c940162 Joel Fernandes (Google 2019-09-05 4310) rcu_disable_urgency_upon_qs(rdp);
99990da1b3c00f6 Paul E. McKenney 2018-05-03 4311 /* Report QS -after- changing ->qsmaskinitnext! */
b50912d0b5e03f1 Paul E. McKenney 2018-07-03 @4312 rcu_report_qs_rnp(mask, rnp, rnp->gp_seq, flags);
99990da1b3c00f6 Paul E. McKenney 2018-05-03 4313 } else {
7ec99de36f40261 Paul E. McKenney 2016-06-30 4314 raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
7ec99de36f40261 Paul E. McKenney 2016-06-30 4315 }
342f2d0f88f3c2d David Woodhouse 2021-12-09 4316 arch_spin_unlock(&rcu_state.ofl_lock);
342f2d0f88f3c2d David Woodhouse 2021-12-09 4317 local_irq_restore(seq_flags);
313517fc44fb2d8 Paul E. McKenney 2017-06-08 4318 smp_mb(); /* Ensure RCU read-side usage follows above initialization. */
7ec99de36f40261 Paul E. McKenney 2016-06-30 4319 }
7ec99de36f40261 Paul E. McKenney 2016-06-30 4320
:::::: The code at line 4312 was first introduced by commit
:::::: b50912d0b5e03f11004fec1e2b50244de9e2fa41 rcu: Remove rsp parameter from rcu_report_qs_rnp()
:::::: TO: Paul E. McKenney <paulmck(a)linux.vnet.ibm.com>
:::::: CC: Paul E. McKenney <paulmck(a)linux.vnet.ibm.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
[chenxing:msc313_mainlining 47/76] drivers/pinctrl/mstar/pinctrl-msc313.c:1339:4: warning: unannotated fall-through between switch labels
by kernel test robot
tree: git://github.com/linux-chenxing/linux.git msc313_mainlining
head: 3b75af2a2f0d6aea3abc4cf56690ae7a6fd2dac6
commit: 0d8434e20c2d30bac37d042462ba57649e33a786 [47/76] pinctrl header names
config: arm-randconfig-r012-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140343.VO0Mdyih-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/linux-chenxing/linux/commit/0d8434e20c2d30bac37d042462...
git remote add chenxing git://github.com/linux-chenxing/linux.git
git fetch --no-tags chenxing msc313_mainlining
git checkout 0d8434e20c2d30bac37d042462ba57649e33a786
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/pinctrl/mstar/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/pinctrl/mstar/pinctrl-msc313.c:1339:4: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
default:
^
drivers/pinctrl/mstar/pinctrl-msc313.c:1339:4: note: insert 'break;' to avoid fall-through
default:
^
break;
>> drivers/pinctrl/mstar/pinctrl-msc313.c:201:27: warning: unused variable 'sd_drivestrengths' [-Wunused-const-variable]
static const unsigned int sd_drivestrengths[] = {4, 8};
^
>> drivers/pinctrl/mstar/pinctrl-msc313.c:215:27: warning: unused variable 'spi0_drivestrengths' [-Wunused-const-variable]
static const unsigned int spi0_drivestrengths[] = {4, 8, 12, 16};
^
>> drivers/pinctrl/mstar/pinctrl-msc313.c:225:27: warning: unused variable 'i2c_drivestrengths' [-Wunused-const-variable]
static const unsigned int i2c_drivestrengths[] = {4, 8};
^
>> drivers/pinctrl/mstar/pinctrl-msc313.c:233:27: warning: unused variable 'sr_drivestrengths' [-Wunused-const-variable]
static const unsigned int sr_drivestrengths[] = {4, 8};
^
5 warnings generated.
vim +1339 drivers/pinctrl/mstar/pinctrl-msc313.c
4e180cab5755b5 Daniel Palmer 2020-12-07 1318
4e180cab5755b5 Daniel Palmer 2020-12-07 1319 static int mstar_set_config(struct msc313_pinctrl *pinctrl, int pin, unsigned long config)
4e180cab5755b5 Daniel Palmer 2020-12-07 1320 {
4e180cab5755b5 Daniel Palmer 2020-12-07 1321 enum pin_config_param param = pinconf_to_config_param(config);
4e180cab5755b5 Daniel Palmer 2020-12-07 1322 u32 arg = pinconf_to_config_argument(config);
4e180cab5755b5 Daniel Palmer 2020-12-07 1323 int i;
4e180cab5755b5 Daniel Palmer 2020-12-07 1324 unsigned int mask;
4e180cab5755b5 Daniel Palmer 2020-12-07 1325 const struct msc313_pinctrl_pinconf *confpin;
4e180cab5755b5 Daniel Palmer 2020-12-07 1326
4e180cab5755b5 Daniel Palmer 2020-12-07 1327 dev_dbg(pinctrl->dev, "setting %d:%u on pin %d\n", (int)config, (unsigned int)arg, pin);
4e180cab5755b5 Daniel Palmer 2020-12-07 1328 for (i = 0; i < pinctrl->info->npinconfs; i++) {
4e180cab5755b5 Daniel Palmer 2020-12-07 1329 if (pinctrl->info->pinconfs[i].pin == pin) {
4e180cab5755b5 Daniel Palmer 2020-12-07 1330 confpin = &pinctrl->info->pinconfs[i];
4e180cab5755b5 Daniel Palmer 2020-12-07 1331 switch (param) {
4e180cab5755b5 Daniel Palmer 2020-12-07 1332 case PIN_CONFIG_BIAS_PULL_UP:
4e180cab5755b5 Daniel Palmer 2020-12-07 1333 if (confpin->pull_en_reg != -1) {
4e180cab5755b5 Daniel Palmer 2020-12-07 1334 dev_dbg(pinctrl->dev, "setting pull up %d on pin %d\n", (int) arg, pin);
4e180cab5755b5 Daniel Palmer 2020-12-07 1335 mask = 1 << confpin->pull_en_bit;
4e180cab5755b5 Daniel Palmer 2020-12-07 1336 regmap_update_bits(pinctrl->regmap, confpin->pull_en_reg, mask, arg ? mask : 0);
4e180cab5755b5 Daniel Palmer 2020-12-07 1337 } else
4e180cab5755b5 Daniel Palmer 2020-12-07 1338 dev_info(pinctrl->dev, "pullup reg/bit isn't known for pin %d\n", pin);
4e180cab5755b5 Daniel Palmer 2020-12-07 @1339 default:
4e180cab5755b5 Daniel Palmer 2020-12-07 1340 break;
4e180cab5755b5 Daniel Palmer 2020-12-07 1341 }
4e180cab5755b5 Daniel Palmer 2020-12-07 1342 return 0;
4e180cab5755b5 Daniel Palmer 2020-12-07 1343 }
4e180cab5755b5 Daniel Palmer 2020-12-07 1344 }
4e180cab5755b5 Daniel Palmer 2020-12-07 1345 return 0;
4e180cab5755b5 Daniel Palmer 2020-12-07 1346 }
4e180cab5755b5 Daniel Palmer 2020-12-07 1347
:::::: The code at line 1339 was first introduced by commit
:::::: 4e180cab5755b5116ca4fb151ce6068ff5442e70 pinctrl: mstar: msc313 pinctrl driver
:::::: TO: Daniel Palmer <daniel(a)0x0f.com>
:::::: CC: Daniel Palmer <daniel(a)0x0f.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH v2 2/4] coresight: etm4x: Don't use virtual contextID for non-root PID namespace
by kernel test robot
Hi Leo,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.16-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Leo-Yan/coresight-etm-Correct-PI...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2585cf9dfaaddf00b069673f27bb3f8530e2039c
config: arm64-randconfig-r034-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140333.58pdbVRp-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/3b7eceb25155c98432dea4821c4fc571b...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Leo-Yan/coresight-etm-Correct-PID-tracing-for-non-root-namespace/20211213-201632
git checkout 3b7eceb25155c98432dea4821c4fc571b44d72e3
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/hwtracing/coresight/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/hwtracing/coresight/coresight-etm4x-sysfs.c:2118:7: error: implicit declaration of function 'task_is_in_init_pid_ns' [-Werror,-Wimplicit-function-declaration]
if (!task_is_in_init_pid_ns(current))
^
drivers/hwtracing/coresight/coresight-etm4x-sysfs.c:2139:7: error: implicit declaration of function 'task_is_in_init_pid_ns' [-Werror,-Wimplicit-function-declaration]
if (!task_is_in_init_pid_ns(current))
^
drivers/hwtracing/coresight/coresight-etm4x-sysfs.c:2169:7: error: implicit declaration of function 'task_is_in_init_pid_ns' [-Werror,-Wimplicit-function-declaration]
if (!task_is_in_init_pid_ns(current))
^
drivers/hwtracing/coresight/coresight-etm4x-sysfs.c:2193:7: error: implicit declaration of function 'task_is_in_init_pid_ns' [-Werror,-Wimplicit-function-declaration]
if (!task_is_in_init_pid_ns(current))
^
4 errors generated.
vim +/task_is_in_init_pid_ns +2118 drivers/hwtracing/coresight/coresight-etm4x-sysfs.c
2105
2106 static ssize_t vmid_val_show(struct device *dev,
2107 struct device_attribute *attr,
2108 char *buf)
2109 {
2110 unsigned long val;
2111 struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent);
2112 struct etmv4_config *config = &drvdata->config;
2113
2114 /*
2115 * Don't use virtual contextID tracing if coming from a PID namespace.
2116 * See comment in ctxid_pid_store().
2117 */
> 2118 if (!task_is_in_init_pid_ns(current))
2119 return -EINVAL;
2120
2121 spin_lock(&drvdata->spinlock);
2122 val = (unsigned long)config->vmid_val[config->vmid_idx];
2123 spin_unlock(&drvdata->spinlock);
2124 return scnprintf(buf, PAGE_SIZE, "%#lx\n", val);
2125 }
2126
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH v1 2/2] pinctrl: Propagate firmware node from a parent device
by kernel test robot
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on linusw-pinctrl/devel]
[cannot apply to geert-renesas-drivers/renesas-pinctrl v5.16-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/pinctrl-Get-rid-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: ia64-randconfig-r032-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140202.rfjJQkD9-lk...)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/09301bc05d31cbebbea459be85ce973a0...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Andy-Shevchenko/pinctrl-Get-rid-of-duplicate-of_node-assignment-in-the-drivers/20211214-004129
git checkout 09301bc05d31cbebbea459be85ce973a065379d1
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/pinctrl/cirrus/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
drivers/pinctrl/cirrus/pinctrl-madera-core.c: In function 'madera_pin_probe':
>> drivers/pinctrl/cirrus/pinctrl-madera-core.c:1007:37: error: implicit declaration of function 'dev_fwnode'; did you mean 'dev_of_node'? [-Werror=implicit-function-declaration]
1007 | device_set_node(&pdev->dev, dev_fwnode(pdev->dev.parent));
| ^~~~~~~~~~
| dev_of_node
>> drivers/pinctrl/cirrus/pinctrl-madera-core.c:1007:37: warning: passing argument 2 of 'device_set_node' makes pointer from integer without a cast [-Wint-conversion]
1007 | device_set_node(&pdev->dev, dev_fwnode(pdev->dev.parent));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int
In file included from include/linux/platform_device.h:13,
from drivers/pinctrl/cirrus/pinctrl-madera-core.c:10:
include/linux/device.h:854:64: note: expected 'struct fwnode_handle *' but argument is of type 'int'
854 | void device_set_node(struct device *dev, struct fwnode_handle *fwnode);
| ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
cc1: some warnings being treated as errors
vim +1007 drivers/pinctrl/cirrus/pinctrl-madera-core.c
994
995 static int madera_pin_probe(struct platform_device *pdev)
996 {
997 struct madera *madera = dev_get_drvdata(pdev->dev.parent);
998 const struct madera_pdata *pdata = &madera->pdata;
999 struct madera_pin_private *priv;
1000 int ret;
1001
1002 BUILD_BUG_ON(ARRAY_SIZE(madera_pin_single_group_names) !=
1003 ARRAY_SIZE(madera_pin_single_group_pins));
1004
1005 dev_dbg(&pdev->dev, "%s\n", __func__);
1006
> 1007 device_set_node(&pdev->dev, dev_fwnode(pdev->dev.parent));
1008
1009 priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
1010 if (!priv)
1011 return -ENOMEM;
1012
1013 priv->dev = &pdev->dev;
1014 priv->madera = madera;
1015
1016 switch (madera->type) {
1017 case CS47L15:
1018 if (IS_ENABLED(CONFIG_PINCTRL_CS47L15))
1019 priv->chip = &cs47l15_pin_chip;
1020 break;
1021 case CS47L35:
1022 if (IS_ENABLED(CONFIG_PINCTRL_CS47L35))
1023 priv->chip = &cs47l35_pin_chip;
1024 break;
1025 case CS47L85:
1026 case WM1840:
1027 if (IS_ENABLED(CONFIG_PINCTRL_CS47L85))
1028 priv->chip = &cs47l85_pin_chip;
1029 break;
1030 case CS47L90:
1031 case CS47L91:
1032 if (IS_ENABLED(CONFIG_PINCTRL_CS47L90))
1033 priv->chip = &cs47l90_pin_chip;
1034 break;
1035 case CS42L92:
1036 case CS47L92:
1037 case CS47L93:
1038 if (IS_ENABLED(CONFIG_PINCTRL_CS47L92))
1039 priv->chip = &cs47l92_pin_chip;
1040 break;
1041 default:
1042 break;
1043 }
1044
1045 if (!priv->chip)
1046 return -ENODEV;
1047
1048 madera_pin_desc.npins = priv->chip->n_pins;
1049
1050 ret = devm_pinctrl_register_and_init(&pdev->dev,
1051 &madera_pin_desc,
1052 priv,
1053 &priv->pctl);
1054 if (ret) {
1055 dev_err(priv->dev, "Failed pinctrl register (%d)\n", ret);
1056 return ret;
1057 }
1058
1059 /* if the configuration is provided through pdata, apply it */
1060 if (pdata->gpio_configs) {
1061 ret = pinctrl_register_mappings(pdata->gpio_configs,
1062 pdata->n_gpio_configs);
1063 if (ret) {
1064 dev_err(priv->dev,
1065 "Failed to register pdata mappings (%d)\n",
1066 ret);
1067 return ret;
1068 }
1069 }
1070
1071 ret = pinctrl_enable(priv->pctl);
1072 if (ret) {
1073 dev_err(priv->dev, "Failed to enable pinctrl (%d)\n", ret);
1074 return ret;
1075 }
1076
1077 platform_set_drvdata(pdev, priv);
1078
1079 dev_dbg(priv->dev, "pinctrl probed ok\n");
1080
1081 return 0;
1082 }
1083
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH v21] tty: Fix the keyboard led light display problem
by kernel test robot
Hi lianzhi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on linux/master linus/master v5.16-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/lianzhi-chang/tty-Fix-the-keyboa...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: mips-randconfig-r022-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140304.qPpjdgPQ-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/8cc658e5dd82e5d70fa3ac9dace8fe62e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review lianzhi-chang/tty-Fix-the-keyboard-led-light-display-problem/20211213-204404
git checkout 8cc658e5dd82e5d70fa3ac9dace8fe62eaed325f
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/tty/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/tty/sysrq.c:31:
include/linux/kbd_kern.h:35:27: error: character <U+FF1B> not allowed in an identifier
unsigned char kbdledctl:1； /* Whether to allow to control the led of the keyboard */
^~
include/linux/kbd_kern.h:35:27: error: invalid suffix '；' on integer constant
In file included from drivers/tty/sysrq.c:51:
In file included from include/linux/syscalls.h:88:
In file included from include/trace/syscall.h:7:
In file included from include/linux/trace_events.h:6:
In file included from include/linux/ring_buffer.h:7:
>> include/linux/poll.h:142:27: warning: division by zero is undefined [-Wdivision-by-zero]
M(RDNORM) | M(RDBAND) | M(WRNORM) | M(WRBAND) |
^~~~~~~~~
include/linux/poll.h:140:32: note: expanded from macro 'M'
#define M(X) (__force __poll_t)__MAP(val, POLL##X, (__force __u16)EPOLL##X)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/poll.h:126:51: note: expanded from macro '__MAP'
(from < to ? (v & from) * (to/from) : (v & from) / (from/to))
^ ~~~~~~~~~
include/linux/poll.h:142:39: warning: division by zero is undefined [-Wdivision-by-zero]
M(RDNORM) | M(RDBAND) | M(WRNORM) | M(WRBAND) |
^~~~~~~~~
include/linux/poll.h:140:32: note: expanded from macro 'M'
#define M(X) (__force __poll_t)__MAP(val, POLL##X, (__force __u16)EPOLL##X)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/poll.h:126:51: note: expanded from macro '__MAP'
(from < to ? (v & from) * (to/from) : (v & from) / (from/to))
^ ~~~~~~~~~
2 warnings and 2 errors generated.
vim +142 include/linux/poll.h
7a163b2195cda0 Al Viro 2018-02-01 137
7a163b2195cda0 Al Viro 2018-02-01 138 static inline __poll_t demangle_poll(u16 val)
7a163b2195cda0 Al Viro 2018-02-01 139 {
7a163b2195cda0 Al Viro 2018-02-01 140 #define M(X) (__force __poll_t)__MAP(val, POLL##X, (__force __u16)EPOLL##X)
7a163b2195cda0 Al Viro 2018-02-01 141 return M(IN) | M(OUT) | M(PRI) | M(ERR) | M(NVAL) |
7a163b2195cda0 Al Viro 2018-02-01 @142 M(RDNORM) | M(RDBAND) | M(WRNORM) | M(WRBAND) |
7a163b2195cda0 Al Viro 2018-02-01 143 M(HUP) | M(RDHUP) | M(MSG);
7a163b2195cda0 Al Viro 2018-02-01 144 #undef M
7a163b2195cda0 Al Viro 2018-02-01 145 }
7a163b2195cda0 Al Viro 2018-02-01 146 #undef __MAP
7a163b2195cda0 Al Viro 2018-02-01 147
7a163b2195cda0 Al Viro 2018-02-01 148
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH] virtio_mmio: pm: Add notification handlers for restore and freeze
by kernel test robot
Hi Mikhail,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.16-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mikhail-Golubev/virtio_mmio-pm-A...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 136057256686de39cc3a07c2e39ef6bc43003ff6
config: m68k-randconfig-r033-20211213 (https://download.01.org/0day-ci/archive/20211214/202112140201.xeCfVzym-lk...)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/86cd610f19003c4d848c13e5e00e38e9b...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mikhail-Golubev/virtio_mmio-pm-Add-notification-handlers-for-restore-and-freeze/20211214-001636
git checkout 86cd610f19003c4d848c13e5e00e38e9bc41f54e
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/virtio/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/virtio/virtio_mmio.c: In function 'virtio_mmio_freeze':
>> drivers/virtio/virtio_mmio.c:770:16: error: implicit declaration of function 'virtio_device_freeze'; did you mean 'virtio_device_ready'? [-Werror=implicit-function-declaration]
770 | return virtio_device_freeze(&vm_dev->vdev);
| ^~~~~~~~~~~~~~~~~~~~
| virtio_device_ready
drivers/virtio/virtio_mmio.c: In function 'virtio_mmio_restore':
>> drivers/virtio/virtio_mmio.c:778:16: error: implicit declaration of function 'virtio_device_restore'; did you mean 'virtio_mmio_restore'? [-Werror=implicit-function-declaration]
778 | return virtio_device_restore(&vm_dev->vdev);
| ^~~~~~~~~~~~~~~~~~~~~
| virtio_mmio_restore
cc1: some warnings being treated as errors
vim +770 drivers/virtio/virtio_mmio.c
764
765 static int __maybe_unused virtio_mmio_freeze(struct device *dev)
766 {
767 struct platform_device *pdev = to_platform_device(dev);
768 struct virtio_mmio_device *vm_dev = platform_get_drvdata(pdev);
769
> 770 return virtio_device_freeze(&vm_dev->vdev);
771 }
772
773 static int __maybe_unused virtio_mmio_restore(struct device *dev)
774 {
775 struct platform_device *pdev = to_platform_device(dev);
776 struct virtio_mmio_device *vm_dev = platform_get_drvdata(pdev);
777
> 778 return virtio_device_restore(&vm_dev->vdev);
779 }
780
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week