Re: [PATCH v4 1/3] powerpc/book3s64/radix/tlb: tlbie primitives for process-scoped invalidations from guests
by kernel test robot
Hi Bharata,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on kvm/linux-next]
[also build test ERROR on v5.11]
[cannot apply to powerpc/next next-20210212]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Bharata-B-Rao/Support-for-H_RPT_...
base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: powerpc64-randconfig-r005-20210215 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://github.com/0day-ci/linux/commit/2a2c1320dc2bc67ec962721c39e7639cc...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bharata-B-Rao/Support-for-H_RPT_INVALIDATE-in-PowerPC-KVM/20210215-143815
git checkout 2a2c1320dc2bc67ec962721c39e7639cc1abfa9d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> arch/powerpc/mm/book3s64/radix_tlb.c:399:20: error: unused function '_tlbie_pid_lpid' [-Werror,-Wunused-function]
static inline void _tlbie_pid_lpid(unsigned long pid, unsigned long lpid,
^
>> arch/powerpc/mm/book3s64/radix_tlb.c:643:20: error: unused function '_tlbie_va_range_lpid' [-Werror,-Wunused-function]
static inline void _tlbie_va_range_lpid(unsigned long start, unsigned long end,
^
2 errors generated.
vim +/_tlbie_pid_lpid +399 arch/powerpc/mm/book3s64/radix_tlb.c
398
> 399 static inline void _tlbie_pid_lpid(unsigned long pid, unsigned long lpid,
400 unsigned long ric)
401 {
402 asm volatile("ptesync" : : : "memory");
403
404 /*
405 * Workaround the fact that the "ric" argument to __tlbie_pid
406 * must be a compile-time contraint to match the "i" constraint
407 * in the asm statement.
408 */
409 switch (ric) {
410 case RIC_FLUSH_TLB:
411 __tlbie_pid_lpid(pid, lpid, RIC_FLUSH_TLB);
412 fixup_tlbie_pid_lpid(pid, lpid);
413 break;
414 case RIC_FLUSH_PWC:
415 __tlbie_pid_lpid(pid, lpid, RIC_FLUSH_PWC);
416 break;
417 case RIC_FLUSH_ALL:
418 default:
419 __tlbie_pid_lpid(pid, lpid, RIC_FLUSH_ALL);
420 fixup_tlbie_pid_lpid(pid, lpid);
421 }
422 asm volatile("eieio; tlbsync; ptesync" : : : "memory");
423 }
424 struct tlbiel_pid {
425 unsigned long pid;
426 unsigned long ric;
427 };
428
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH net-next 09/12] net: dsa: tag_ocelot: create separate tagger for Seville
by Dan Carpenter
Hi Vladimir,
url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/PTP-for-DSA-tag_...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3c5a2fd042d0bfac71a2dfb99515723d318df47b
config: i386-randconfig-m031-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
net/dsa/tag_ocelot.c:59 ocelot_xmit() warn: should '(((1))) << (dp->index)' be a 64 bit type?
net/dsa/tag_ocelot.c:71 seville_xmit() warn: should '(((1))) << (dp->index)' be a 64 bit type?
vim +59 net/dsa/tag_ocelot.c
9d88a16c0fc930 Vladimir Oltean 2021-02-13 52 static struct sk_buff *ocelot_xmit(struct sk_buff *skb,
9d88a16c0fc930 Vladimir Oltean 2021-02-13 53 struct net_device *netdev)
9d88a16c0fc930 Vladimir Oltean 2021-02-13 54 {
9d88a16c0fc930 Vladimir Oltean 2021-02-13 55 struct dsa_port *dp = dsa_slave_to_port(netdev);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 56 void *injection;
9d88a16c0fc930 Vladimir Oltean 2021-02-13 57
9d88a16c0fc930 Vladimir Oltean 2021-02-13 58 ocelot_xmit_common(skb, netdev, cpu_to_be32(0x8880000a), &injection);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 @59 ocelot_ifh_set_dest(injection, BIT(dp->index));
db->index is less than db->num_ports which 32 or less but sometimes it
comes from the device tree so who knows. The ocelot_ifh_set_dest()
function takes a u64 though and that suggests that BIT() should be
changed to BIT_ULL().
9d88a16c0fc930 Vladimir Oltean 2021-02-13 60
9d88a16c0fc930 Vladimir Oltean 2021-02-13 61 return skb;
9d88a16c0fc930 Vladimir Oltean 2021-02-13 62 }
9d88a16c0fc930 Vladimir Oltean 2021-02-13 63
9d88a16c0fc930 Vladimir Oltean 2021-02-13 64 static struct sk_buff *seville_xmit(struct sk_buff *skb,
9d88a16c0fc930 Vladimir Oltean 2021-02-13 65 struct net_device *netdev)
9d88a16c0fc930 Vladimir Oltean 2021-02-13 66 {
9d88a16c0fc930 Vladimir Oltean 2021-02-13 67 struct dsa_port *dp = dsa_slave_to_port(netdev);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 68 void *injection;
9d88a16c0fc930 Vladimir Oltean 2021-02-13 69
9d88a16c0fc930 Vladimir Oltean 2021-02-13 70 ocelot_xmit_common(skb, netdev, cpu_to_be32(0x88800005), &injection);
9d88a16c0fc930 Vladimir Oltean 2021-02-13 @71 seville_ifh_set_dest(injection, BIT(dp->index));
Same.
9d88a16c0fc930 Vladimir Oltean 2021-02-13 72
8dce89aa5f3274 Vladimir Oltean 2019-11-14 73 return skb;
8dce89aa5f3274 Vladimir Oltean 2019-11-14 74 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[fuse:fs_fuse_split 5/5] fs/fuse/virtio_fs.c:1458 virtio_fs_get_tree() error: uninitialized symbol 'fc'.
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git fs_fuse_split
head: 674d5faded4c40245ea02240e731aa82c7ab4c9e
commit: 674d5faded4c40245ea02240e731aa82c7ab4c9e [5/5] fuse: alloc initial fuse_conn and fuse_mount
config: i386-randconfig-m021-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
fs/fuse/virtio_fs.c:1458 virtio_fs_get_tree() error: uninitialized symbol 'fc'.
Old smatch warnings:
fs/fuse/virtio_fs.c:1444 virtio_fs_get_tree() error: double free of 'fm'
vim +/fc +1458 fs/fuse/virtio_fs.c
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1405 static int virtio_fs_get_tree(struct fs_context *fsc)
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1406 {
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1407 struct virtio_fs *fs;
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1408 struct super_block *sb;
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1409 struct fuse_conn *fc;
fcee216beb9c15 Max Reitz 2020-05-06 1410 struct fuse_mount *fm;
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1411 int err;
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1412
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1413 /* This gets a reference on virtio_fs object. This ptr gets installed
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1414 * in fc->iq->priv. Once fuse_conn is going away, it calls ->put()
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1415 * to drop the reference to this object.
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1416 */
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1417 fs = virtio_fs_find_instance(fsc->source);
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1418 if (!fs) {
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1419 pr_info("virtio-fs: tag <%s> not found\n", fsc->source);
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1420 return -EINVAL;
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1421 }
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1422
833c5a42e28bee Miklos Szeredi 2020-11-11 1423 err = -ENOMEM;
674d5faded4c40 Miklos Szeredi 2021-02-11 1424 fm = fuse_conn_new(get_user_ns(current_user_ns()), &virtio_fs_fiq_ops, fs, NULL, NULL);
833c5a42e28bee Miklos Szeredi 2020-11-11 1425 if (!fm)
833c5a42e28bee Miklos Szeredi 2020-11-11 1426 goto out_err;
"fc" not initialized on this path.
674d5faded4c40 Miklos Szeredi 2021-02-11 1427 fc = fm->fc;
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1428 fc->delete_stale = true;
bf109c64040f5b Max Reitz 2020-04-21 1429 fc->auto_submounts = true;
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1430
fcee216beb9c15 Max Reitz 2020-05-06 1431 fsc->s_fs_info = fm;
b19d3d00d662cf Miklos Szeredi 2020-11-11 1432 sb = sget_fc(fsc, virtio_fs_test_super, set_anon_super_fc);
514b5e3ff45e6c Miklos Szeredi 2020-11-11 1433 if (fsc->s_fs_info) {
514b5e3ff45e6c Miklos Szeredi 2020-11-11 1434 fuse_conn_put(fc);
514b5e3ff45e6c Miklos Szeredi 2020-11-11 1435 kfree(fm);
The error handling in this function is very confusing...
514b5e3ff45e6c Miklos Szeredi 2020-11-11 1436 }
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1437 if (IS_ERR(sb))
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1438 return PTR_ERR(sb);
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1439
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1440 if (!sb->s_root) {
1dd539577c42b6 Vivek Goyal 2020-08-19 1441 err = virtio_fs_fill_super(sb, fsc);
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1442 if (err) {
514b5e3ff45e6c Miklos Szeredi 2020-11-11 1443 fuse_conn_put(fc);
514b5e3ff45e6c Miklos Szeredi 2020-11-11 1444 kfree(fm);
Smatch doesn't complain about a double free so presumably the earlier
kfree(fm) is done IFF sb is an error pointer.
66ab33bf6d4341 Miklos Szeredi 2020-11-11 1445 sb->s_fs_info = NULL;
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1446 deactivate_locked_super(sb);
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1447 return err;
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1448 }
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1449
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1450 sb->s_flags |= SB_ACTIVE;
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1451 }
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1452
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1453 WARN_ON(fsc->root);
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1454 fsc->root = dget(sb->s_root);
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1455 return 0;
833c5a42e28bee Miklos Szeredi 2020-11-11 1456
833c5a42e28bee Miklos Szeredi 2020-11-11 1457 out_err:
833c5a42e28bee Miklos Szeredi 2020-11-11 @1458 kfree(fc);
833c5a42e28bee Miklos Szeredi 2020-11-11 1459 mutex_lock(&virtio_fs_mutex);
833c5a42e28bee Miklos Szeredi 2020-11-11 1460 virtio_fs_put(fs);
833c5a42e28bee Miklos Szeredi 2020-11-11 1461 mutex_unlock(&virtio_fs_mutex);
833c5a42e28bee Miklos Szeredi 2020-11-11 1462 return err;
a62a8ef9d97da2 Stefan Hajnoczi 2018-06-12 1463 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[rdma-rdma:wip/jgg-for-next 198/203] drivers/infiniband/ulp/rtrs/rtrs-srv.c:1805 rtrs_rdma_connect() warn: passing zero to 'PTR_ERR'
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git wip/jgg-for-next
head: c88b31c46cefe50f524a1ad3deaf1599bc9ee2e6
commit: f0751419d3a15fb06d9b7d9435312472c3cb122d [198/203] RDMA/rtrs: Only allow addition of path to an already established session
config: ia64-randconfig-m031-20210209 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/infiniband/ulp/rtrs/rtrs-srv.c:1805 rtrs_rdma_connect() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +1805 drivers/infiniband/ulp/rtrs/rtrs-srv.c
9cb837480424e7 Jack Wang 2020-05-11 1760 static int rtrs_rdma_connect(struct rdma_cm_id *cm_id,
9cb837480424e7 Jack Wang 2020-05-11 1761 const struct rtrs_msg_conn_req *msg,
9cb837480424e7 Jack Wang 2020-05-11 1762 size_t len)
9cb837480424e7 Jack Wang 2020-05-11 1763 {
9cb837480424e7 Jack Wang 2020-05-11 1764 struct rtrs_srv_ctx *ctx = cm_id->context;
9cb837480424e7 Jack Wang 2020-05-11 1765 struct rtrs_srv_sess *sess;
9cb837480424e7 Jack Wang 2020-05-11 1766 struct rtrs_srv *srv;
9cb837480424e7 Jack Wang 2020-05-11 1767
9cb837480424e7 Jack Wang 2020-05-11 1768 u16 version, con_num, cid;
9cb837480424e7 Jack Wang 2020-05-11 1769 u16 recon_cnt;
9cb837480424e7 Jack Wang 2020-05-11 1770 int err;
9cb837480424e7 Jack Wang 2020-05-11 1771
9cb837480424e7 Jack Wang 2020-05-11 1772 if (len < sizeof(*msg)) {
9cb837480424e7 Jack Wang 2020-05-11 1773 pr_err("Invalid RTRS connection request\n");
9cb837480424e7 Jack Wang 2020-05-11 1774 goto reject_w_econnreset;
9cb837480424e7 Jack Wang 2020-05-11 1775 }
9cb837480424e7 Jack Wang 2020-05-11 1776 if (le16_to_cpu(msg->magic) != RTRS_MAGIC) {
9cb837480424e7 Jack Wang 2020-05-11 1777 pr_err("Invalid RTRS magic\n");
9cb837480424e7 Jack Wang 2020-05-11 1778 goto reject_w_econnreset;
9cb837480424e7 Jack Wang 2020-05-11 1779 }
9cb837480424e7 Jack Wang 2020-05-11 1780 version = le16_to_cpu(msg->version);
9cb837480424e7 Jack Wang 2020-05-11 1781 if (version >> 8 != RTRS_PROTO_VER_MAJOR) {
9cb837480424e7 Jack Wang 2020-05-11 1782 pr_err("Unsupported major RTRS version: %d, expected %d\n",
9cb837480424e7 Jack Wang 2020-05-11 1783 version >> 8, RTRS_PROTO_VER_MAJOR);
9cb837480424e7 Jack Wang 2020-05-11 1784 goto reject_w_econnreset;
9cb837480424e7 Jack Wang 2020-05-11 1785 }
9cb837480424e7 Jack Wang 2020-05-11 1786 con_num = le16_to_cpu(msg->cid_num);
9cb837480424e7 Jack Wang 2020-05-11 1787 if (con_num > 4096) {
9cb837480424e7 Jack Wang 2020-05-11 1788 /* Sanity check */
9cb837480424e7 Jack Wang 2020-05-11 1789 pr_err("Too many connections requested: %d\n", con_num);
9cb837480424e7 Jack Wang 2020-05-11 1790 goto reject_w_econnreset;
9cb837480424e7 Jack Wang 2020-05-11 1791 }
9cb837480424e7 Jack Wang 2020-05-11 1792 cid = le16_to_cpu(msg->cid);
9cb837480424e7 Jack Wang 2020-05-11 1793 if (cid >= con_num) {
9cb837480424e7 Jack Wang 2020-05-11 1794 /* Sanity check */
9cb837480424e7 Jack Wang 2020-05-11 1795 pr_err("Incorrect cid: %d >= %d\n", cid, con_num);
9cb837480424e7 Jack Wang 2020-05-11 1796 goto reject_w_econnreset;
9cb837480424e7 Jack Wang 2020-05-11 1797 }
9cb837480424e7 Jack Wang 2020-05-11 1798 recon_cnt = le16_to_cpu(msg->recon_cnt);
f0751419d3a15f Md Haris Iqbal 2021-02-12 1799 srv = get_or_create_srv(ctx, &msg->paths_uuid, msg->first_conn);
d715ff8acbd587 Guoqing Jiang 2020-10-23 1800 /*
d715ff8acbd587 Guoqing Jiang 2020-10-23 1801 * "refcount == 0" happens if a previous thread calls get_or_create_srv
d715ff8acbd587 Guoqing Jiang 2020-10-23 1802 * allocate srv, but chunks of srv are not allocated yet.
d715ff8acbd587 Guoqing Jiang 2020-10-23 1803 */
f0751419d3a15f Md Haris Iqbal 2021-02-12 1804 if (IS_ERR(srv) || refcount_read(&srv->refcount) == 0) {
f0751419d3a15f Md Haris Iqbal 2021-02-12 @1805 err = PTR_ERR(srv);
It's not 100% clear to me that an error code is required when
refcount_read() is zero. Maybe "err = 0;" is okay in that situation?
9cb837480424e7 Jack Wang 2020-05-11 1806 goto reject_w_err;
9cb837480424e7 Jack Wang 2020-05-11 1807 }
9cb837480424e7 Jack Wang 2020-05-11 1808 mutex_lock(&srv->paths_mutex);
9cb837480424e7 Jack Wang 2020-05-11 1809 sess = __find_sess(srv, &msg->sess_uuid);
9cb837480424e7 Jack Wang 2020-05-11 1810 if (sess) {
9cb837480424e7 Jack Wang 2020-05-11 1811 struct rtrs_sess *s = &sess->s;
9cb837480424e7 Jack Wang 2020-05-11 1812
9cb837480424e7 Jack Wang 2020-05-11 1813 /* Session already holds a reference */
9cb837480424e7 Jack Wang 2020-05-11 1814 put_srv(srv);
9cb837480424e7 Jack Wang 2020-05-11 1815
9cb837480424e7 Jack Wang 2020-05-11 1816 if (sess->state != RTRS_SRV_CONNECTING) {
9cb837480424e7 Jack Wang 2020-05-11 1817 rtrs_err(s, "Session in wrong state: %s\n",
9cb837480424e7 Jack Wang 2020-05-11 1818 rtrs_srv_state_str(sess->state));
9cb837480424e7 Jack Wang 2020-05-11 1819 mutex_unlock(&srv->paths_mutex);
9cb837480424e7 Jack Wang 2020-05-11 1820 goto reject_w_econnreset;
9cb837480424e7 Jack Wang 2020-05-11 1821 }
9cb837480424e7 Jack Wang 2020-05-11 1822 /*
9cb837480424e7 Jack Wang 2020-05-11 1823 * Sanity checks
9cb837480424e7 Jack Wang 2020-05-11 1824 */
e172037be757dc Md Haris Iqbal 2020-05-22 1825 if (con_num != s->con_num || cid >= s->con_num) {
9cb837480424e7 Jack Wang 2020-05-11 1826 rtrs_err(s, "Incorrect request: %d, %d\n",
9cb837480424e7 Jack Wang 2020-05-11 1827 cid, con_num);
9cb837480424e7 Jack Wang 2020-05-11 1828 mutex_unlock(&srv->paths_mutex);
9cb837480424e7 Jack Wang 2020-05-11 1829 goto reject_w_econnreset;
9cb837480424e7 Jack Wang 2020-05-11 1830 }
e172037be757dc Md Haris Iqbal 2020-05-22 1831 if (s->con[cid]) {
9cb837480424e7 Jack Wang 2020-05-11 1832 rtrs_err(s, "Connection already exists: %d\n",
9cb837480424e7 Jack Wang 2020-05-11 1833 cid);
9cb837480424e7 Jack Wang 2020-05-11 1834 mutex_unlock(&srv->paths_mutex);
9cb837480424e7 Jack Wang 2020-05-11 1835 goto reject_w_econnreset;
9cb837480424e7 Jack Wang 2020-05-11 1836 }
9cb837480424e7 Jack Wang 2020-05-11 1837 } else {
9cb837480424e7 Jack Wang 2020-05-11 1838 sess = __alloc_sess(srv, cm_id, con_num, recon_cnt,
9cb837480424e7 Jack Wang 2020-05-11 1839 &msg->sess_uuid);
9cb837480424e7 Jack Wang 2020-05-11 1840 if (IS_ERR(sess)) {
9cb837480424e7 Jack Wang 2020-05-11 1841 mutex_unlock(&srv->paths_mutex);
9cb837480424e7 Jack Wang 2020-05-11 1842 put_srv(srv);
9cb837480424e7 Jack Wang 2020-05-11 1843 err = PTR_ERR(sess);
9cb837480424e7 Jack Wang 2020-05-11 1844 goto reject_w_err;
9cb837480424e7 Jack Wang 2020-05-11 1845 }
9cb837480424e7 Jack Wang 2020-05-11 1846 }
9cb837480424e7 Jack Wang 2020-05-11 1847 err = create_con(sess, cm_id, cid);
9cb837480424e7 Jack Wang 2020-05-11 1848 if (err) {
9cb837480424e7 Jack Wang 2020-05-11 1849 (void)rtrs_rdma_do_reject(cm_id, err);
9cb837480424e7 Jack Wang 2020-05-11 1850 /*
9cb837480424e7 Jack Wang 2020-05-11 1851 * Since session has other connections we follow normal way
9cb837480424e7 Jack Wang 2020-05-11 1852 * through workqueue, but still return an error to tell cma.c
9cb837480424e7 Jack Wang 2020-05-11 1853 * to call rdma_destroy_id() for current connection.
9cb837480424e7 Jack Wang 2020-05-11 1854 */
9cb837480424e7 Jack Wang 2020-05-11 1855 goto close_and_return_err;
9cb837480424e7 Jack Wang 2020-05-11 1856 }
9cb837480424e7 Jack Wang 2020-05-11 1857 err = rtrs_rdma_do_accept(sess, cm_id);
9cb837480424e7 Jack Wang 2020-05-11 1858 if (err) {
9cb837480424e7 Jack Wang 2020-05-11 1859 (void)rtrs_rdma_do_reject(cm_id, err);
9cb837480424e7 Jack Wang 2020-05-11 1860 /*
9cb837480424e7 Jack Wang 2020-05-11 1861 * Since current connection was successfully added to the
9cb837480424e7 Jack Wang 2020-05-11 1862 * session we follow normal way through workqueue to close the
9cb837480424e7 Jack Wang 2020-05-11 1863 * session, thus return 0 to tell cma.c we call
9cb837480424e7 Jack Wang 2020-05-11 1864 * rdma_destroy_id() ourselves.
9cb837480424e7 Jack Wang 2020-05-11 1865 */
9cb837480424e7 Jack Wang 2020-05-11 1866 err = 0;
9cb837480424e7 Jack Wang 2020-05-11 1867 goto close_and_return_err;
9cb837480424e7 Jack Wang 2020-05-11 1868 }
9cb837480424e7 Jack Wang 2020-05-11 1869 mutex_unlock(&srv->paths_mutex);
9cb837480424e7 Jack Wang 2020-05-11 1870
9cb837480424e7 Jack Wang 2020-05-11 1871 return 0;
9cb837480424e7 Jack Wang 2020-05-11 1872
9cb837480424e7 Jack Wang 2020-05-11 1873 reject_w_err:
9cb837480424e7 Jack Wang 2020-05-11 1874 return rtrs_rdma_do_reject(cm_id, err);
9cb837480424e7 Jack Wang 2020-05-11 1875
9cb837480424e7 Jack Wang 2020-05-11 1876 reject_w_econnreset:
9cb837480424e7 Jack Wang 2020-05-11 1877 return rtrs_rdma_do_reject(cm_id, -ECONNRESET);
9cb837480424e7 Jack Wang 2020-05-11 1878
9cb837480424e7 Jack Wang 2020-05-11 1879 close_and_return_err:
9cb837480424e7 Jack Wang 2020-05-11 1880 mutex_unlock(&srv->paths_mutex);
99f0c380797335 Jack Wang 2020-12-17 1881 close_sess(sess);
9cb837480424e7 Jack Wang 2020-05-11 1882
9cb837480424e7 Jack Wang 2020-05-11 1883 return err;
9cb837480424e7 Jack Wang 2020-05-11 1884 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[mptcp:export 1339/1352] net/mptcp/options.c:687 mptcp_established_options_rm_addr() error: uninitialized symbol 'align'.
by Dan Carpenter
tree: https://github.com/multipath-tcp/mptcp_net-next.git export
head: d15532665bd1e4a0e210110b275658ba4fcb5b87
commit: 7619397044315f5289200ea122ce4aac316d30da [1339/1352] mptcp: add rm_list in mptcp_out_options
config: i386-randconfig-m021-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
net/mptcp/options.c:687 mptcp_established_options_rm_addr() error: uninitialized symbol 'align'.
vim +/align +687 net/mptcp/options.c
5cb104ae55e9db Geliang Tang 2020-09-24 668 static bool mptcp_established_options_rm_addr(struct sock *sk,
5cb104ae55e9db Geliang Tang 2020-09-24 669 unsigned int *size,
5cb104ae55e9db Geliang Tang 2020-09-24 670 unsigned int remaining,
5cb104ae55e9db Geliang Tang 2020-09-24 671 struct mptcp_out_options *opts)
5cb104ae55e9db Geliang Tang 2020-09-24 672 {
5cb104ae55e9db Geliang Tang 2020-09-24 673 struct mptcp_subflow_context *subflow = mptcp_subflow_ctx(sk);
5cb104ae55e9db Geliang Tang 2020-09-24 674 struct mptcp_sock *msk = mptcp_sk(subflow->conn);
7619397044315f Geliang Tang 2021-02-12 675 struct mptcp_rm_list rm_list;
7619397044315f Geliang Tang 2021-02-12 676 u8 i, align;
5cb104ae55e9db Geliang Tang 2020-09-24 677
5cb104ae55e9db Geliang Tang 2020-09-24 678 if (!mptcp_pm_should_rm_signal(msk) ||
7619397044315f Geliang Tang 2021-02-12 679 !(mptcp_pm_rm_addr_signal(msk, remaining, &rm_list)))
5cb104ae55e9db Geliang Tang 2020-09-24 680 return false;
5cb104ae55e9db Geliang Tang 2020-09-24 681
7619397044315f Geliang Tang 2021-02-12 682 if (rm_list.nr > 1)
7619397044315f Geliang Tang 2021-02-12 683 align = 5;
7619397044315f Geliang Tang 2021-02-12 684 if (rm_list.nr > 5)
7619397044315f Geliang Tang 2021-02-12 685 align = 9;
Can rm_list.nr be zero?
Smatch will hopefully know the answer if you have the cross function DB
built, but hopefully eventually we will turn these warnings on for GCC
again.
7619397044315f Geliang Tang 2021-02-12 686
7619397044315f Geliang Tang 2021-02-12 @687 if (remaining < TCPOLEN_MPTCP_RM_ADDR_BASE + align)
5cb104ae55e9db Geliang Tang 2020-09-24 688 return false;
5cb104ae55e9db Geliang Tang 2020-09-24 689
7619397044315f Geliang Tang 2021-02-12 690 *size = TCPOLEN_MPTCP_RM_ADDR_BASE + align;
5cb104ae55e9db Geliang Tang 2020-09-24 691 opts->suboptions |= OPTION_MPTCP_RM_ADDR;
7619397044315f Geliang Tang 2021-02-12 692 opts->rm_list = rm_list;
5cb104ae55e9db Geliang Tang 2020-09-24 693
7619397044315f Geliang Tang 2021-02-12 694 for (i = 0; i < opts->rm_list.nr; i++)
7619397044315f Geliang Tang 2021-02-12 695 pr_debug("rm_list_ids[%d]=%d", i, opts->rm_list.ids[i]);
5cb104ae55e9db Geliang Tang 2020-09-24 696
5cb104ae55e9db Geliang Tang 2020-09-24 697 return true;
5cb104ae55e9db Geliang Tang 2020-09-24 698 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[block:dio-mem-align 1/3] fs/direct-io.c:1177 do_blockdev_direct_IO() warn: variable dereferenced before check 'bdev' (see line 1132)
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git dio-mem-align
head: 3d6ef82805958611e8ffa0a901c014b6f066c3e6
commit: 446db6bc49cd5c4a77daffbbcbe0cf69ff7a62e0 [1/3] fs: relax memory alignment restriction for O_DIRECT
config: x86_64-randconfig-m001-20210211 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
fs/direct-io.c:1177 do_blockdev_direct_IO() warn: variable dereferenced before check 'bdev' (see line 1132)
vim +/bdev +1177 fs/direct-io.c
65dd2aa90aa17a Andi Kleen 2012-01-12 1125 static inline ssize_t
17f8c842d24ac0 Omar Sandoval 2015-03-16 1126 do_blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
17f8c842d24ac0 Omar Sandoval 2015-03-16 1127 struct block_device *bdev, struct iov_iter *iter,
c8b8e32d700fe9 Christoph Hellwig 2016-04-07 1128 get_block_t get_block, dio_iodone_t end_io,
facd07b07d2a79 Josef Bacik 2010-05-23 1129 dio_submit_t submit_io, int flags)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1130 {
6aa7de059173a9 Mark Rutland 2017-10-23 1131 unsigned i_blkbits = READ_ONCE(inode->i_blkbits);
446db6bc49cd5c Jens Axboe 2021-02-11 @1132 struct request_queue *q = bdev_get_queue(bdev);
^^^^
Dereferenced inside the function (I didn't double check. #trustTheMachine)
ab73857e354ab9 Linus Torvalds 2012-11-29 1133 unsigned blkbits = i_blkbits;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1134 unsigned blocksize_mask = (1 << blkbits) - 1;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1135 ssize_t retval = -EINVAL;
1c0ff0f1bdeb18 Nikolay Borisov 2018-04-05 1136 const size_t count = iov_iter_count(iter);
c8b8e32d700fe9 Christoph Hellwig 2016-04-07 1137 loff_t offset = iocb->ki_pos;
1c0ff0f1bdeb18 Nikolay Borisov 2018-04-05 1138 const loff_t end = offset + count;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1139 struct dio *dio;
eb28be2b4c0a06 Andi Kleen 2011-08-01 1140 struct dio_submit sdio = { 0, };
847cc6371ba820 Andi Kleen 2011-08-01 1141 struct buffer_head map_bh = { 0, };
647d1e4c523576 Fengguang Wu 2012-08-09 1142 struct blk_plug plug;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1143
65dd2aa90aa17a Andi Kleen 2012-01-12 1144 /*
65dd2aa90aa17a Andi Kleen 2012-01-12 1145 * Avoid references to bdev if not absolutely needed to give
65dd2aa90aa17a Andi Kleen 2012-01-12 1146 * the early prefetch in the caller enough time.
65dd2aa90aa17a Andi Kleen 2012-01-12 1147 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 1148
f9b5570d7fdedf Christoph Hellwig 2011-06-24 1149 /* watch out for a 0 len io from a tricksy fs */
1c0ff0f1bdeb18 Nikolay Borisov 2018-04-05 1150 if (iov_iter_rw(iter) == READ && !count)
f9b5570d7fdedf Christoph Hellwig 2011-06-24 1151 return 0;
f9b5570d7fdedf Christoph Hellwig 2011-06-24 1152
6e8267f532a171 Andi Kleen 2011-08-01 1153 dio = kmem_cache_alloc(dio_cache, GFP_KERNEL);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1154 if (!dio)
46d716025a228d Gabriel Krisman Bertazi 2020-10-08 1155 return -ENOMEM;
23aee091d804ef Jeff Moyer 2009-12-15 1156 /*
23aee091d804ef Jeff Moyer 2009-12-15 1157 * Believe it or not, zeroing out the page array caused a .5%
23aee091d804ef Jeff Moyer 2009-12-15 1158 * performance regression in a database benchmark. So, we take
23aee091d804ef Jeff Moyer 2009-12-15 1159 * care to only zero out what's needed.
23aee091d804ef Jeff Moyer 2009-12-15 1160 */
23aee091d804ef Jeff Moyer 2009-12-15 1161 memset(dio, 0, offsetof(struct dio, pages));
^1da177e4c3f41 Linus Torvalds 2005-04-16 1162
5fe878ae7f82fb Christoph Hellwig 2009-12-15 1163 dio->flags = flags;
0a9164cb7ff32d Gabriel Krisman Bertazi 2020-10-08 1164 if (dio->flags & DIO_LOCKING && iov_iter_rw(iter) == READ) {
5fe878ae7f82fb Christoph Hellwig 2009-12-15 1165 /* will be released by direct_io_worker */
5955102c9984fa Al Viro 2016-01-22 1166 inode_lock(inode);
df2d6f26586f12 Christoph Hellwig 2011-06-24 1167 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1168
74cedf9b6c603f Jan Kara 2015-11-30 1169 /* Once we sampled i_size check for reads beyond EOF */
74cedf9b6c603f Jan Kara 2015-11-30 1170 dio->i_size = i_size_read(inode);
74cedf9b6c603f Jan Kara 2015-11-30 1171 if (iov_iter_rw(iter) == READ && offset >= dio->i_size) {
2d4594acbf6d8f Al Viro 2015-12-08 1172 retval = 0;
46d716025a228d Gabriel Krisman Bertazi 2020-10-08 1173 goto fail_dio;
74cedf9b6c603f Jan Kara 2015-11-30 1174 }
74cedf9b6c603f Jan Kara 2015-11-30 1175
446db6bc49cd5c Jens Axboe 2021-02-11 1176 if (offset & blocksize_mask) {
41b21af388f94b Gabriel Krisman Bertazi 2020-10-08 @1177 if (bdev)
^^^^
Hopefully this check can be removed? We would have crashed by this
point.
41b21af388f94b Gabriel Krisman Bertazi 2020-10-08 1178 blkbits = blksize_bits(bdev_logical_block_size(bdev));
41b21af388f94b Gabriel Krisman Bertazi 2020-10-08 1179 blocksize_mask = (1 << blkbits) - 1;
446db6bc49cd5c Jens Axboe 2021-02-11 1180 if (offset & blocksize_mask)
41b21af388f94b Gabriel Krisman Bertazi 2020-10-08 1181 goto fail_dio;
41b21af388f94b Gabriel Krisman Bertazi 2020-10-08 1182 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH v5 13/19] remoteproc: Properly deal with the resource table
by Dan Carpenter
Hi Mathieu,
url: https://github.com/0day-ci/linux/commits/Mathieu-Poirier/remoteproc-Add-s...
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: ia64-randconfig-m031-20210209 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/remoteproc/remoteproc_core.c:2080 rproc_detach() error: double free of 'rproc->cached_table'
vim +2080 drivers/remoteproc/remoteproc_core.c
eab58da78fe46f Mathieu Poirier 2021-02-11 2069 /* clean up all acquired resources */
eab58da78fe46f Mathieu Poirier 2021-02-11 2070 rproc_resource_cleanup(rproc);
eab58da78fe46f Mathieu Poirier 2021-02-11 2071
eab58da78fe46f Mathieu Poirier 2021-02-11 2072 /* release HW resources if needed */
eab58da78fe46f Mathieu Poirier 2021-02-11 2073 rproc_unprepare_device(rproc);
eab58da78fe46f Mathieu Poirier 2021-02-11 2074
eab58da78fe46f Mathieu Poirier 2021-02-11 2075 rproc_disable_iommu(rproc);
eab58da78fe46f Mathieu Poirier 2021-02-11 2076
66e2fed7a4bb20 Mathieu Poirier 2021-02-11 2077 /* Free the copy of the resource table */
66e2fed7a4bb20 Mathieu Poirier 2021-02-11 2078 kfree(rproc->cached_table);
^^^^^^^^^^^^^^^^^^^^^^^^^^
eab58da78fe46f Mathieu Poirier 2021-02-11 2079 /* Follow the same sequence as in rproc_shutdown() */
eab58da78fe46f Mathieu Poirier 2021-02-11 @2080 kfree(rproc->cached_table);
^^^^^^^^^^^^^^^^^^^^^^^^^^
Double free.
eab58da78fe46f Mathieu Poirier 2021-02-11 2081 rproc->cached_table = NULL;
66e2fed7a4bb20 Mathieu Poirier 2021-02-11 2082 rproc->clean_table = NULL;
eab58da78fe46f Mathieu Poirier 2021-02-11 2083 rproc->table_ptr = NULL;
66e2fed7a4bb20 Mathieu Poirier 2021-02-11 2084
eab58da78fe46f Mathieu Poirier 2021-02-11 2085 out:
eab58da78fe46f Mathieu Poirier 2021-02-11 2086 mutex_unlock(&rproc->lock);
eab58da78fe46f Mathieu Poirier 2021-02-11 2087 return ret;
eab58da78fe46f Mathieu Poirier 2021-02-11 2088 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [net-next] tcp: Sanitize CMSG flags and reserved args in tcp_zerocopy_receive.
by Dan Carpenter
Hi Arjun,
url: https://github.com/0day-ci/linux/commits/Arjun-Roy/tcp-Sanitize-CMSG-flag...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git e4b62cf7559f2ef9a022de235e5a09a8d7ded520
config: x86_64-randconfig-m001-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
net/ipv4/tcp.c:4158 do_tcp_getsockopt() warn: check for integer overflow 'len'
vim +/len +4158 net/ipv4/tcp.c
3fdadf7d27e3fb Dmitry Mishin 2006-03-20 3896 static int do_tcp_getsockopt(struct sock *sk, int level,
3fdadf7d27e3fb Dmitry Mishin 2006-03-20 3897 int optname, char __user *optval, int __user *optlen)
^1da177e4c3f41 Linus Torvalds 2005-04-16 3898 {
295f7324ff8d9e Arnaldo Carvalho de Melo 2005-08-09 3899 struct inet_connection_sock *icsk = inet_csk(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 3900 struct tcp_sock *tp = tcp_sk(sk);
6fa251663069e0 Nikolay Borisov 2016-02-03 3901 struct net *net = sock_net(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 3902 int val, len;
"len" is int.
[ snip ]
05255b823a6173 Eric Dumazet 2018-04-27 4146 #ifdef CONFIG_MMU
05255b823a6173 Eric Dumazet 2018-04-27 4147 case TCP_ZEROCOPY_RECEIVE: {
7eeba1706eba6d Arjun Roy 2021-01-20 4148 struct scm_timestamping_internal tss;
e0fecb289ad3fd Arjun Roy 2020-12-10 4149 struct tcp_zerocopy_receive zc = {};
05255b823a6173 Eric Dumazet 2018-04-27 4150 int err;
05255b823a6173 Eric Dumazet 2018-04-27 4151
05255b823a6173 Eric Dumazet 2018-04-27 4152 if (get_user(len, optlen))
05255b823a6173 Eric Dumazet 2018-04-27 4153 return -EFAULT;
c8856c05145490 Arjun Roy 2020-02-14 4154 if (len < offsetofend(struct tcp_zerocopy_receive, length))
05255b823a6173 Eric Dumazet 2018-04-27 4155 return -EINVAL;
The problem is that negative values of "len" are type promoted to high
positive values. So the fix is to write this as:
if (len < 0 || len < offsetofend(struct tcp_zerocopy_receive, length))
return -EINVAL;
110912bdf28392 Arjun Roy 2021-02-11 4156 if (unlikely(len > sizeof(zc))) {
110912bdf28392 Arjun Roy 2021-02-11 4157 err = check_zeroed_user(optval + sizeof(zc),
110912bdf28392 Arjun Roy 2021-02-11 @4158 len - sizeof(zc));
^^^^^^^^^^^^^^^^
Potentially "len - a negative value".
110912bdf28392 Arjun Roy 2021-02-11 4159 if (err < 1)
110912bdf28392 Arjun Roy 2021-02-11 4160 return err == 0 ? -EINVAL : err;
c8856c05145490 Arjun Roy 2020-02-14 4161 len = sizeof(zc);
0b7f41f68710cc Arjun Roy 2020-02-25 4162 if (put_user(len, optlen))
0b7f41f68710cc Arjun Roy 2020-02-25 4163 return -EFAULT;
0b7f41f68710cc Arjun Roy 2020-02-25 4164 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[frank-w-bpi-r2-4.14:5.11-mt76test 19/19] scripts/Makefile.clean:15: drivers/net/wireless/mediatek/mt76_test/Makefile: No such file or directory
by kernel test robot
Hi Frank,
First bad commit (maybe != root cause):
tree: https://github.com/frank-w/BPI-R2-4.14 5.11-mt76test
head: 5d6e12bac94e425c29b890e7aa9e027a2edf9142
commit: 5d6e12bac94e425c29b890e7aa9e027a2edf9142 [19/19] mt76: add openwrt-version with additional patches
config: x86_64-randconfig-a003-20210215 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/frank-w/BPI-R2-4.14/commit/5d6e12bac94e425c29b890e7aa9...
git remote add frank-w-bpi-r2-4.14 https://github.com/frank-w/BPI-R2-4.14
git fetch --no-tags frank-w-bpi-r2-4.14 5.11-mt76test
git checkout 5d6e12bac94e425c29b890e7aa9e027a2edf9142
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> scripts/Makefile.clean:15: drivers/net/wireless/mediatek/mt76_test/Makefile: No such file or directory
>> make[6]: *** No rule to make target 'drivers/net/wireless/mediatek/mt76_test/Makefile'.
make[6]: Failed to remake makefile 'drivers/net/wireless/mediatek/mt76_test/Makefile'.
make[5]: *** [scripts/Makefile.clean:71: drivers/net/wireless/mediatek/mt76_test] Error 2
make[5]: Target '__clean' not remade because of errors.
make[4]: *** [scripts/Makefile.clean:71: drivers/net/wireless/mediatek] Error 2
make[4]: Target '__clean' not remade because of errors.
make[3]: *** [scripts/Makefile.clean:71: drivers/net/wireless] Error 2
make[3]: Target '__clean' not remade because of errors.
make[2]: *** [scripts/Makefile.clean:71: drivers/net] Error 2
make[2]: Target '__clean' not remade because of errors.
make[1]: *** [Makefile:1812: _clean_drivers] Error 2
make[1]: Target 'distclean' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'distclean' not remade because of errors.
vim +15 scripts/Makefile.clean
2315c6e4227815 Sam Ravnborg 2005-07-25 12
2a691470345a00 Sam Ravnborg 2005-07-25 13 # The filename Kbuild has precedence over Makefile
db8c1a7b2ca25f Sam Ravnborg 2005-07-27 14 kbuild-dir := $(if $(filter /%,$(src)),$(src),$(srctree)/$(src))
db8c1a7b2ca25f Sam Ravnborg 2005-07-27 @15 include $(if $(wildcard $(kbuild-dir)/Kbuild), $(kbuild-dir)/Kbuild, $(kbuild-dir)/Makefile)
^1da177e4c3f41 Linus Torvalds 2005-04-16 16
:::::: The code at line 15 was first introduced by commit
:::::: db8c1a7b2ca25f37b1429c00e82d6568f86caec1 kbuild: fix building external modules
:::::: TO: Sam Ravnborg <sam(a)mars.(none)>
:::::: CC: Sam Ravnborg <sam(a)mars.(none)>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months