[linux-stable-rc:linux-4.4.y 9473/9999] arch/powerpc/kernel/exceptions-64s.S:839: Error: attempt to move .org backwards
by kernel test robot
Hi Nicholas,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
head: 3cb069b52684a615947ba8af15e7c0866b9bb061
commit: 7b9f9ce1a7a0cb5e0e7077c960d08e6039388a9d [9473/9999] powerpc/64s: Add support for a store forwarding barrier at kernel entry/exit
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.5.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gi...
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-4.4.y
git checkout 7b9f9ce1a7a0cb5e0e7077c960d08e6039388a9d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
arch/powerpc/kernel/exceptions-64s.S:1599: Warning: invalid register expression
arch/powerpc/kernel/exceptions-64s.S:1640: Warning: invalid register expression
>> arch/powerpc/kernel/exceptions-64s.S:839: Error: attempt to move .org backwards
arch/powerpc/kernel/exceptions-64s.S:840: Error: attempt to move .org backwards
arch/powerpc/kernel/exceptions-64s.S:864: Error: attempt to move .org backwards
arch/powerpc/kernel/exceptions-64s.S:865: Error: attempt to move .org backwards
vim +839 arch/powerpc/kernel/exceptions-64s.S
0ebc4cdaa3fd7c Benjamin Herrenschmidt 2009-06-02 823
c1fb6816fb1b78 Michael Neuling 2012-11-02 824 /*
c1fb6816fb1b78 Michael Neuling 2012-11-02 825 * Relocation-on interrupts: A subset of the interrupts can be delivered
c1fb6816fb1b78 Michael Neuling 2012-11-02 826 * with IR=1/DR=1, if AIL==2 and MSR.HV won't be changed by delivering
c1fb6816fb1b78 Michael Neuling 2012-11-02 827 * it. Addresses are the same as the original interrupt addresses, but
c1fb6816fb1b78 Michael Neuling 2012-11-02 828 * offset by 0xc000000000004000.
c1fb6816fb1b78 Michael Neuling 2012-11-02 829 * It's impossible to receive interrupts below 0x300 via this mechanism.
c1fb6816fb1b78 Michael Neuling 2012-11-02 830 * KVM: None of these traps are from the guest ; anything that escalated
c1fb6816fb1b78 Michael Neuling 2012-11-02 831 * to HV=1 from HV=0 is delivered via real mode handlers.
c1fb6816fb1b78 Michael Neuling 2012-11-02 832 */
c1fb6816fb1b78 Michael Neuling 2012-11-02 833
c1fb6816fb1b78 Michael Neuling 2012-11-02 834 /*
c1fb6816fb1b78 Michael Neuling 2012-11-02 835 * This uses the standard macro, since the original 0x300 vector
c1fb6816fb1b78 Michael Neuling 2012-11-02 836 * only has extra guff for STAB-based processors -- which never
c1fb6816fb1b78 Michael Neuling 2012-11-02 837 * come here.
c1fb6816fb1b78 Michael Neuling 2012-11-02 838 */
c1fb6816fb1b78 Michael Neuling 2012-11-02 @839 STD_RELON_EXCEPTION_PSERIES(0x4300, 0x300, data_access)
c1fb6816fb1b78 Michael Neuling 2012-11-02 840 . = 0x4380
c1fb6816fb1b78 Michael Neuling 2012-11-02 841 .globl data_access_slb_relon_pSeries
c1fb6816fb1b78 Michael Neuling 2012-11-02 842 data_access_slb_relon_pSeries:
c1fb6816fb1b78 Michael Neuling 2012-11-02 843 SET_SCRATCH0(r13)
1707dd161349e6 Paul Mackerras 2013-02-04 844 EXCEPTION_PROLOG_0(PACA_EXSLB)
c1fb6816fb1b78 Michael Neuling 2012-11-02 845 EXCEPTION_PROLOG_1(PACA_EXSLB, NOTEST, 0x380)
c1fb6816fb1b78 Michael Neuling 2012-11-02 846 std r3,PACA_EXSLB+EX_R3(r13)
c1fb6816fb1b78 Michael Neuling 2012-11-02 847 mfspr r3,SPRN_DAR
c1fb6816fb1b78 Michael Neuling 2012-11-02 848 mfspr r12,SPRN_SRR1
c1fb6816fb1b78 Michael Neuling 2012-11-02 849 #ifndef CONFIG_RELOCATABLE
b1576fec7f4dd4 Anton Blanchard 2014-02-04 850 b slb_miss_realmode
c1fb6816fb1b78 Michael Neuling 2012-11-02 851 #else
c1fb6816fb1b78 Michael Neuling 2012-11-02 852 /*
ad0289e4acf2bd Anton Blanchard 2014-02-04 853 * We can't just use a direct branch to slb_miss_realmode
c1fb6816fb1b78 Michael Neuling 2012-11-02 854 * because the distance from here to there depends on where
c1fb6816fb1b78 Michael Neuling 2012-11-02 855 * the kernel ends up being put.
c1fb6816fb1b78 Michael Neuling 2012-11-02 856 */
c1fb6816fb1b78 Michael Neuling 2012-11-02 857 mfctr r11
c1fb6816fb1b78 Michael Neuling 2012-11-02 858 ld r10,PACAKBASE(r13)
ad0289e4acf2bd Anton Blanchard 2014-02-04 859 LOAD_HANDLER(r10, slb_miss_realmode)
c1fb6816fb1b78 Michael Neuling 2012-11-02 860 mtctr r10
c1fb6816fb1b78 Michael Neuling 2012-11-02 861 bctr
c1fb6816fb1b78 Michael Neuling 2012-11-02 862 #endif
c1fb6816fb1b78 Michael Neuling 2012-11-02 863
c1fb6816fb1b78 Michael Neuling 2012-11-02 864 STD_RELON_EXCEPTION_PSERIES(0x4400, 0x400, instruction_access)
c1fb6816fb1b78 Michael Neuling 2012-11-02 865 . = 0x4480
c1fb6816fb1b78 Michael Neuling 2012-11-02 866 .globl instruction_access_slb_relon_pSeries
c1fb6816fb1b78 Michael Neuling 2012-11-02 867 instruction_access_slb_relon_pSeries:
c1fb6816fb1b78 Michael Neuling 2012-11-02 868 SET_SCRATCH0(r13)
1707dd161349e6 Paul Mackerras 2013-02-04 869 EXCEPTION_PROLOG_0(PACA_EXSLB)
c1fb6816fb1b78 Michael Neuling 2012-11-02 870 EXCEPTION_PROLOG_1(PACA_EXSLB, NOTEST, 0x480)
c1fb6816fb1b78 Michael Neuling 2012-11-02 871 std r3,PACA_EXSLB+EX_R3(r13)
c1fb6816fb1b78 Michael Neuling 2012-11-02 872 mfspr r3,SPRN_SRR0 /* SRR0 is faulting address */
c1fb6816fb1b78 Michael Neuling 2012-11-02 873 mfspr r12,SPRN_SRR1
c1fb6816fb1b78 Michael Neuling 2012-11-02 874 #ifndef CONFIG_RELOCATABLE
b1576fec7f4dd4 Anton Blanchard 2014-02-04 875 b slb_miss_realmode
c1fb6816fb1b78 Michael Neuling 2012-11-02 876 #else
c1fb6816fb1b78 Michael Neuling 2012-11-02 877 mfctr r11
c1fb6816fb1b78 Michael Neuling 2012-11-02 878 ld r10,PACAKBASE(r13)
ad0289e4acf2bd Anton Blanchard 2014-02-04 879 LOAD_HANDLER(r10, slb_miss_realmode)
c1fb6816fb1b78 Michael Neuling 2012-11-02 880 mtctr r10
c1fb6816fb1b78 Michael Neuling 2012-11-02 881 bctr
c1fb6816fb1b78 Michael Neuling 2012-11-02 882 #endif
c1fb6816fb1b78 Michael Neuling 2012-11-02 883
c1fb6816fb1b78 Michael Neuling 2012-11-02 884 . = 0x4500
c1fb6816fb1b78 Michael Neuling 2012-11-02 885 .globl hardware_interrupt_relon_pSeries;
c1fb6816fb1b78 Michael Neuling 2012-11-02 886 .globl hardware_interrupt_relon_hv;
c1fb6816fb1b78 Michael Neuling 2012-11-02 887 hardware_interrupt_relon_pSeries:
c1fb6816fb1b78 Michael Neuling 2012-11-02 888 hardware_interrupt_relon_hv:
c1fb6816fb1b78 Michael Neuling 2012-11-02 889 BEGIN_FTR_SECTION
c1fb6816fb1b78 Michael Neuling 2012-11-02 890 _MASKABLE_RELON_EXCEPTION_PSERIES(0x502, hardware_interrupt, EXC_HV, SOFTEN_TEST_HV)
c1fb6816fb1b78 Michael Neuling 2012-11-02 891 FTR_SECTION_ELSE
c1fb6816fb1b78 Michael Neuling 2012-11-02 892 _MASKABLE_RELON_EXCEPTION_PSERIES(0x500, hardware_interrupt, EXC_STD, SOFTEN_TEST_PR)
3e96ca7f007ddb Michael Neuling 2013-04-25 893 ALT_FTR_SECTION_END_IFSET(CPU_FTR_HVMODE)
c1fb6816fb1b78 Michael Neuling 2012-11-02 894 STD_RELON_EXCEPTION_PSERIES(0x4600, 0x600, alignment)
c1fb6816fb1b78 Michael Neuling 2012-11-02 895 STD_RELON_EXCEPTION_PSERIES(0x4700, 0x700, program_check)
c1fb6816fb1b78 Michael Neuling 2012-11-02 896 STD_RELON_EXCEPTION_PSERIES(0x4800, 0x800, fp_unavailable)
c1fb6816fb1b78 Michael Neuling 2012-11-02 897 MASKABLE_RELON_EXCEPTION_PSERIES(0x4900, 0x900, decrementer)
c1fb6816fb1b78 Michael Neuling 2012-11-02 898 STD_RELON_EXCEPTION_HV(0x4980, 0x982, hdecrementer)
1dbdafec5d63a1 Ian Munsie 2012-11-14 899 MASKABLE_RELON_EXCEPTION_PSERIES(0x4a00, 0xa00, doorbell_super)
c1fb6816fb1b78 Michael Neuling 2012-11-02 900 STD_RELON_EXCEPTION_PSERIES(0x4b00, 0xb00, trap_0b)
c1fb6816fb1b78 Michael Neuling 2012-11-02 901
c1fb6816fb1b78 Michael Neuling 2012-11-02 902 . = 0x4c00
c1fb6816fb1b78 Michael Neuling 2012-11-02 903 .globl system_call_relon_pSeries
c1fb6816fb1b78 Michael Neuling 2012-11-02 904 system_call_relon_pSeries:
c1fb6816fb1b78 Michael Neuling 2012-11-02 905 HMT_MEDIUM
c1fb6816fb1b78 Michael Neuling 2012-11-02 906 SYSCALL_PSERIES_1
c1fb6816fb1b78 Michael Neuling 2012-11-02 907 SYSCALL_PSERIES_2_DIRECT
c1fb6816fb1b78 Michael Neuling 2012-11-02 908 SYSCALL_PSERIES_3
c1fb6816fb1b78 Michael Neuling 2012-11-02 909
c1fb6816fb1b78 Michael Neuling 2012-11-02 910 STD_RELON_EXCEPTION_PSERIES(0x4d00, 0xd00, single_step)
c1fb6816fb1b78 Michael Neuling 2012-11-02 911
c1fb6816fb1b78 Michael Neuling 2012-11-02 912 . = 0x4e00
1d567cb4bd42d5 Michael Ellerman 2013-06-25 913 b . /* Can't happen, see v2.07 Book III-S section 6.5 */
c1fb6816fb1b78 Michael Neuling 2012-11-02 914
c1fb6816fb1b78 Michael Neuling 2012-11-02 915 . = 0x4e20
1d567cb4bd42d5 Michael Ellerman 2013-06-25 916 b . /* Can't happen, see v2.07 Book III-S section 6.5 */
c1fb6816fb1b78 Michael Neuling 2012-11-02 917
c1fb6816fb1b78 Michael Neuling 2012-11-02 918 . = 0x4e40
d671ddd6654daf Michael Ellerman 2013-08-15 919 emulation_assist_relon_trampoline:
1707dd161349e6 Paul Mackerras 2013-02-04 920 SET_SCRATCH0(r13)
1707dd161349e6 Paul Mackerras 2013-02-04 921 EXCEPTION_PROLOG_0(PACA_EXGEN)
c1fb6816fb1b78 Michael Neuling 2012-11-02 922 b emulation_assist_relon_hv
c1fb6816fb1b78 Michael Neuling 2012-11-02 923
c1fb6816fb1b78 Michael Neuling 2012-11-02 924 . = 0x4e60
1d567cb4bd42d5 Michael Ellerman 2013-06-25 925 b . /* Can't happen, see v2.07 Book III-S section 6.5 */
c1fb6816fb1b78 Michael Neuling 2012-11-02 926
655bb3f4e89225 Ian Munsie 2012-11-14 927 . = 0x4e80
d671ddd6654daf Michael Ellerman 2013-08-15 928 h_doorbell_relon_trampoline:
1707dd161349e6 Paul Mackerras 2013-02-04 929 SET_SCRATCH0(r13)
1707dd161349e6 Paul Mackerras 2013-02-04 930 EXCEPTION_PROLOG_0(PACA_EXGEN)
655bb3f4e89225 Ian Munsie 2012-11-14 931 b h_doorbell_relon_hv
c1fb6816fb1b78 Michael Neuling 2012-11-02 932
c1fb6816fb1b78 Michael Neuling 2012-11-02 933 . = 0x4f00
fa111f1f764783 Michael Ellerman 2013-08-15 934 performance_monitor_relon_pseries_trampoline:
1707dd161349e6 Paul Mackerras 2013-02-04 935 SET_SCRATCH0(r13)
1707dd161349e6 Paul Mackerras 2013-02-04 936 EXCEPTION_PROLOG_0(PACA_EXGEN)
c1fb6816fb1b78 Michael Neuling 2012-11-02 937 b performance_monitor_relon_pSeries
c1fb6816fb1b78 Michael Neuling 2012-11-02 938
c1fb6816fb1b78 Michael Neuling 2012-11-02 939 . = 0x4f20
fa111f1f764783 Michael Ellerman 2013-08-15 940 altivec_unavailable_relon_pseries_trampoline:
1707dd161349e6 Paul Mackerras 2013-02-04 941 SET_SCRATCH0(r13)
1707dd161349e6 Paul Mackerras 2013-02-04 942 EXCEPTION_PROLOG_0(PACA_EXGEN)
c1fb6816fb1b78 Michael Neuling 2012-11-02 943 b altivec_unavailable_relon_pSeries
c1fb6816fb1b78 Michael Neuling 2012-11-02 944
c1fb6816fb1b78 Michael Neuling 2012-11-02 945 . = 0x4f40
fa111f1f764783 Michael Ellerman 2013-08-15 946 vsx_unavailable_relon_pseries_trampoline:
1707dd161349e6 Paul Mackerras 2013-02-04 947 SET_SCRATCH0(r13)
1707dd161349e6 Paul Mackerras 2013-02-04 948 EXCEPTION_PROLOG_0(PACA_EXGEN)
c1fb6816fb1b78 Michael Neuling 2012-11-02 949 b vsx_unavailable_relon_pSeries
c1fb6816fb1b78 Michael Neuling 2012-11-02 950
d0c0c9a13f6821 Michael Neuling 2013-02-13 951 . = 0x4f60
fa111f1f764783 Michael Ellerman 2013-08-15 952 facility_unavailable_relon_trampoline:
d0c0c9a13f6821 Michael Neuling 2013-02-13 953 SET_SCRATCH0(r13)
d0c0c9a13f6821 Michael Neuling 2013-02-13 954 EXCEPTION_PROLOG_0(PACA_EXGEN)
021424a1fce335 Michael Ellerman 2013-06-25 955 b facility_unavailable_relon_pSeries
d0c0c9a13f6821 Michael Neuling 2013-02-13 956
b14b6260efeee6 Michael Ellerman 2013-06-25 957 . = 0x4f80
fa111f1f764783 Michael Ellerman 2013-08-15 958 hv_facility_unavailable_relon_trampoline:
b14b6260efeee6 Michael Ellerman 2013-06-25 959 SET_SCRATCH0(r13)
b14b6260efeee6 Michael Ellerman 2013-06-25 960 EXCEPTION_PROLOG_0(PACA_EXGEN)
88f094120bd2f0 Michael Neuling 2013-08-09 961 b hv_facility_unavailable_relon_hv
b14b6260efeee6 Michael Ellerman 2013-06-25 962
c1fb6816fb1b78 Michael Neuling 2012-11-02 963 STD_RELON_EXCEPTION_PSERIES(0x5300, 0x1300, instruction_breakpoint)
c1fb6816fb1b78 Michael Neuling 2012-11-02 964 #ifdef CONFIG_PPC_DENORMALISATION
c1fb6816fb1b78 Michael Neuling 2012-11-02 965 . = 0x5500
c1fb6816fb1b78 Michael Neuling 2012-11-02 966 b denorm_exception_hv
c1fb6816fb1b78 Michael Neuling 2012-11-02 967 #endif
c1fb6816fb1b78 Michael Neuling 2012-11-02 968 STD_RELON_EXCEPTION_PSERIES(0x5700, 0x1700, altivec_assist)
c1fb6816fb1b78 Michael Neuling 2012-11-02 969
0ebc4cdaa3fd7c Benjamin Herrenschmidt 2009-06-02 970 .align 7
0ebc4cdaa3fd7c Benjamin Herrenschmidt 2009-06-02 971 system_call_entry:
0ebc4cdaa3fd7c Benjamin Herrenschmidt 2009-06-02 972 b system_call_common
0ebc4cdaa3fd7c Benjamin Herrenschmidt 2009-06-02 973
fe1952fc0afb9a Benjamin Herrenschmidt 2012-03-01 974 ppc64_runlatch_on_trampoline:
b1576fec7f4dd4 Anton Blanchard 2014-02-04 975 b __ppc64_runlatch_on
fe1952fc0afb9a Benjamin Herrenschmidt 2012-03-01 976
:::::: The code at line 839 was first introduced by commit
:::::: c1fb6816fb1b78dd94b673b0fdaa9a7a16e97bd1 powerpc: Add relocation on exception vector handlers
:::::: TO: Michael Neuling <mikey(a)neuling.org>
:::::: CC: Benjamin Herrenschmidt <benh(a)kernel.crashing.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH 2/2] NFSv4 account for selinux security context when deciding to share superblock
by kernel test robot
Hi Olga,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on nfs/linux-next]
[also build test ERROR on pcmoore-selinux/next linus/master security/next-testing v5.11-rc7 next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/Add-new-hook-t...
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ff69e0bcc99716695e11ed2741b2e01d6...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Olga-Kornievskaia/Add-new-hook-to-compare-new-mount-to-an-existing-mount/20210213-052321
git checkout ff69e0bcc99716695e11ed2741b2e01d6014f960
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
fs/nfs/super.c: In function 'nfs_compare_super':
>> fs/nfs/super.c:1179:5: error: implicit declaration of function 'security_sb_do_mnt_opts_match'; did you mean 'security_sb_set_mnt_opts'? [-Werror=implicit-function-declaration]
1179 | !security_sb_do_mnt_opts_match(sb, fc->security))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| security_sb_set_mnt_opts
cc1: some warnings being treated as errors
vim +1179 fs/nfs/super.c
1164
1165 static int nfs_compare_super(struct super_block *sb, struct fs_context *fc)
1166 {
1167 struct nfs_server *server = fc->s_fs_info, *old = NFS_SB(sb);
1168
1169 if (!nfs_compare_super_address(old, server))
1170 return 0;
1171 /* Note: NFS_MOUNT_UNSHARED == NFS4_MOUNT_UNSHARED */
1172 if (old->flags & NFS_MOUNT_UNSHARED)
1173 return 0;
1174 if (memcmp(&old->fsid, &server->fsid, sizeof(old->fsid)) != 0)
1175 return 0;
1176 if (!nfs_compare_userns(old, server))
1177 return 0;
1178 if ((old->has_sec_mnt_opts || fc->security) &&
> 1179 !security_sb_do_mnt_opts_match(sb, fc->security))
1180 return 0;
1181 return nfs_compare_mount_options(sb, server, fc);
1182 }
1183
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH 2/2] NFSv4 account for selinux security context when deciding to share superblock
by kernel test robot
Hi Olga,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on nfs/linux-next]
[also build test ERROR on pcmoore-selinux/next linus/master security/next-testing v5.11-rc7 next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/Add-new-hook-t...
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: x86_64-randconfig-r011-20210212 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/ff69e0bcc99716695e11ed2741b2e01d6...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Olga-Kornievskaia/Add-new-hook-to-compare-new-mount-to-an-existing-mount/20210213-052321
git checkout ff69e0bcc99716695e11ed2741b2e01d6014f960
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> fs/nfs/super.c:1179:5: error: implicit declaration of function 'security_sb_do_mnt_opts_match' [-Werror,-Wimplicit-function-declaration]
!security_sb_do_mnt_opts_match(sb, fc->security))
^
fs/nfs/super.c:1179:5: note: did you mean 'security_sb_set_mnt_opts'?
include/linux/security.h:673:19: note: 'security_sb_set_mnt_opts' declared here
static inline int security_sb_set_mnt_opts(struct super_block *sb,
^
1 error generated.
vim +/security_sb_do_mnt_opts_match +1179 fs/nfs/super.c
1164
1165 static int nfs_compare_super(struct super_block *sb, struct fs_context *fc)
1166 {
1167 struct nfs_server *server = fc->s_fs_info, *old = NFS_SB(sb);
1168
1169 if (!nfs_compare_super_address(old, server))
1170 return 0;
1171 /* Note: NFS_MOUNT_UNSHARED == NFS4_MOUNT_UNSHARED */
1172 if (old->flags & NFS_MOUNT_UNSHARED)
1173 return 0;
1174 if (memcmp(&old->fsid, &server->fsid, sizeof(old->fsid)) != 0)
1175 return 0;
1176 if (!nfs_compare_userns(old, server))
1177 return 0;
1178 if ((old->has_sec_mnt_opts || fc->security) &&
> 1179 !security_sb_do_mnt_opts_match(sb, fc->security))
1180 return 0;
1181 return nfs_compare_mount_options(sb, server, fc);
1182 }
1183
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[linux-next:master 6077/10581] drivers/iommu/intel/dmar.c:1311:3: error: implicit declaration of function 'trace_qi_submit'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 671176b0016c80b3943cb5387312c886aba3308d
commit: f2dd871799ba5d80f95f9bdbc0e60d390e1bcd22 [6077/10581] iommu/vt-d: Add qi_submit trace event
config: x86_64-randconfig-a005-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout f2dd871799ba5d80f95f9bdbc0e60d390e1bcd22
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the linux-next/master HEAD 671176b0016c80b3943cb5387312c886aba3308d builds fine.
It may have been fixed somewhere.
All errors (new ones prefixed by >>):
drivers/iommu/intel/dmar.c: In function 'qi_submit_sync':
>> drivers/iommu/intel/dmar.c:1311:3: error: implicit declaration of function 'trace_qi_submit' [-Werror=implicit-function-declaration]
1311 | trace_qi_submit(iommu, desc[i].qw0, desc[i].qw1,
| ^~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/trace_qi_submit +1311 drivers/iommu/intel/dmar.c
1267
1268 /*
1269 * Function to submit invalidation descriptors of all types to the queued
1270 * invalidation interface(QI). Multiple descriptors can be submitted at a
1271 * time, a wait descriptor will be appended to each submission to ensure
1272 * hardware has completed the invalidation before return. Wait descriptors
1273 * can be part of the submission but it will not be polled for completion.
1274 */
1275 int qi_submit_sync(struct intel_iommu *iommu, struct qi_desc *desc,
1276 unsigned int count, unsigned long options)
1277 {
1278 struct q_inval *qi = iommu->qi;
1279 struct qi_desc wait_desc;
1280 int wait_index, index;
1281 unsigned long flags;
1282 int offset, shift;
1283 int rc, i;
1284
1285 if (!qi)
1286 return 0;
1287
1288 restart:
1289 rc = 0;
1290
1291 raw_spin_lock_irqsave(&qi->q_lock, flags);
1292 /*
1293 * Check if we have enough empty slots in the queue to submit,
1294 * the calculation is based on:
1295 * # of desc + 1 wait desc + 1 space between head and tail
1296 */
1297 while (qi->free_cnt < count + 2) {
1298 raw_spin_unlock_irqrestore(&qi->q_lock, flags);
1299 cpu_relax();
1300 raw_spin_lock_irqsave(&qi->q_lock, flags);
1301 }
1302
1303 index = qi->free_head;
1304 wait_index = (index + count) % QI_LENGTH;
1305 shift = qi_shift(iommu);
1306
1307 for (i = 0; i < count; i++) {
1308 offset = ((index + i) % QI_LENGTH) << shift;
1309 memcpy(qi->desc + offset, &desc[i], 1 << shift);
1310 qi->desc_status[(index + i) % QI_LENGTH] = QI_IN_USE;
> 1311 trace_qi_submit(iommu, desc[i].qw0, desc[i].qw1,
1312 desc[i].qw2, desc[i].qw3);
1313 }
1314 qi->desc_status[wait_index] = QI_IN_USE;
1315
1316 wait_desc.qw0 = QI_IWD_STATUS_DATA(QI_DONE) |
1317 QI_IWD_STATUS_WRITE | QI_IWD_TYPE;
1318 if (options & QI_OPT_WAIT_DRAIN)
1319 wait_desc.qw0 |= QI_IWD_PRQ_DRAIN;
1320 wait_desc.qw1 = virt_to_phys(&qi->desc_status[wait_index]);
1321 wait_desc.qw2 = 0;
1322 wait_desc.qw3 = 0;
1323
1324 offset = wait_index << shift;
1325 memcpy(qi->desc + offset, &wait_desc, 1 << shift);
1326
1327 qi->free_head = (qi->free_head + count + 1) % QI_LENGTH;
1328 qi->free_cnt -= count + 1;
1329
1330 /*
1331 * update the HW tail register indicating the presence of
1332 * new descriptors.
1333 */
1334 writel(qi->free_head << shift, iommu->reg + DMAR_IQT_REG);
1335
1336 while (qi->desc_status[wait_index] != QI_DONE) {
1337 /*
1338 * We will leave the interrupts disabled, to prevent interrupt
1339 * context to queue another cmd while a cmd is already submitted
1340 * and waiting for completion on this cpu. This is to avoid
1341 * a deadlock where the interrupt context can wait indefinitely
1342 * for free slots in the queue.
1343 */
1344 rc = qi_check_fault(iommu, index, wait_index);
1345 if (rc)
1346 break;
1347
1348 raw_spin_unlock(&qi->q_lock);
1349 cpu_relax();
1350 raw_spin_lock(&qi->q_lock);
1351 }
1352
1353 for (i = 0; i < count; i++)
1354 qi->desc_status[(index + i) % QI_LENGTH] = QI_DONE;
1355
1356 reclaim_free_desc(qi);
1357 raw_spin_unlock_irqrestore(&qi->q_lock, flags);
1358
1359 if (rc == -EAGAIN)
1360 goto restart;
1361
1362 return rc;
1363 }
1364
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[arnd-playground:generic-uaccess 4/5] lib/strncpy_from_user.c:123:13: error: implicit declaration of function 'user_addr_max'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git generic-uaccess
head: 7731bf9d8dc1468d45db173cbe49cbe19c39a4a7
commit: 04e17803c96bb95527da87c2cfbac2f7cb6d697f [4/5] asm-generic: uaccess: use generic uaccess on m68k, h8300 and riscv
config: h8300-allyesconfig (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/commi...
git remote add arnd-playground https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git
git fetch --no-tags arnd-playground generic-uaccess
git checkout 04e17803c96bb95527da87c2cfbac2f7cb6d697f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
lib/strncpy_from_user.c: In function 'strncpy_from_user':
>> lib/strncpy_from_user.c:123:13: error: implicit declaration of function 'user_addr_max' [-Werror=implicit-function-declaration]
123 | max_addr = user_addr_max();
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
lib/strnlen_user.c: In function 'strnlen_user':
>> lib/strnlen_user.c:99:13: error: implicit declaration of function 'user_addr_max' [-Werror=implicit-function-declaration]
99 | max_addr = user_addr_max();
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/user_addr_max +123 lib/strncpy_from_user.c
2922585b93294d David S. Miller 2012-05-24 94
2922585b93294d David S. Miller 2012-05-24 95 /**
2922585b93294d David S. Miller 2012-05-24 96 * strncpy_from_user: - Copy a NUL terminated string from userspace.
2922585b93294d David S. Miller 2012-05-24 97 * @dst: Destination address, in kernel space. This buffer must be at
2922585b93294d David S. Miller 2012-05-24 98 * least @count bytes long.
2922585b93294d David S. Miller 2012-05-24 99 * @src: Source address, in user space.
2922585b93294d David S. Miller 2012-05-24 100 * @count: Maximum number of bytes to copy, including the trailing NUL.
2922585b93294d David S. Miller 2012-05-24 101 *
2922585b93294d David S. Miller 2012-05-24 102 * Copies a NUL-terminated string from userspace to kernel space.
2922585b93294d David S. Miller 2012-05-24 103 *
2922585b93294d David S. Miller 2012-05-24 104 * On success, returns the length of the string (not including the trailing
2922585b93294d David S. Miller 2012-05-24 105 * NUL).
2922585b93294d David S. Miller 2012-05-24 106 *
2922585b93294d David S. Miller 2012-05-24 107 * If access to userspace fails, returns -EFAULT (some data may have been
2922585b93294d David S. Miller 2012-05-24 108 * copied).
2922585b93294d David S. Miller 2012-05-24 109 *
2922585b93294d David S. Miller 2012-05-24 110 * If @count is smaller than the length of the string, copies @count bytes
2922585b93294d David S. Miller 2012-05-24 111 * and returns @count.
2922585b93294d David S. Miller 2012-05-24 112 */
2922585b93294d David S. Miller 2012-05-24 113 long strncpy_from_user(char *dst, const char __user *src, long count)
2922585b93294d David S. Miller 2012-05-24 114 {
2922585b93294d David S. Miller 2012-05-24 115 unsigned long max_addr, src_addr;
2922585b93294d David S. Miller 2012-05-24 116
07887358993d48 KP Singh 2020-06-04 117 might_fault();
4d0e9df5e43dba Albert van der Linde 2020-10-15 118 if (should_fail_usercopy())
4d0e9df5e43dba Albert van der Linde 2020-10-15 119 return -EFAULT;
2922585b93294d David S. Miller 2012-05-24 120 if (unlikely(count <= 0))
2922585b93294d David S. Miller 2012-05-24 121 return 0;
2922585b93294d David S. Miller 2012-05-24 122
2922585b93294d David S. Miller 2012-05-24 @123 max_addr = user_addr_max();
:::::: The code at line 123 was first introduced by commit
:::::: 2922585b93294d47172a765115e0dbc1bfe1be19 lib: Sparc's strncpy_from_user is generic enough, move under lib/
:::::: TO: David S. Miller <davem(a)davemloft.net>
:::::: CC: David S. Miller <davem(a)davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[arnd-playground:generic-uaccess 4/5] reboot.c:undefined reference to `strncpy_from_user'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git generic-uaccess
head: 7731bf9d8dc1468d45db173cbe49cbe19c39a4a7
commit: 04e17803c96bb95527da87c2cfbac2f7cb6d697f [4/5] asm-generic: uaccess: use generic uaccess on m68k, h8300 and riscv
config: c6x-evmc6474_defconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/commi...
git remote add arnd-playground https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git
git fetch --no-tags arnd-playground generic-uaccess
git checkout 04e17803c96bb95527da87c2cfbac2f7cb6d697f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
c6x-elf-ld: warning: section `.far' type changed to PROGBITS
c6x-elf-ld: warning: section `.far' type changed to PROGBITS
c6x-elf-ld: kernel/reboot.o: in function `__do_sys_reboot':
>> reboot.c:(.text+0x9ec): undefined reference to `strncpy_from_user'
c6x-elf-ld: kernel/module.o: in function `__se_sys_delete_module':
>> module.c:(.text+0x2e98): undefined reference to `strncpy_from_user'
c6x-elf-ld: fs/binfmt_elf_fdpic.o: in function `create_elf_fdpic_tables':
>> binfmt_elf_fdpic.c:(.text+0xca0): undefined reference to `strnlen_user'
>> c6x-elf-ld: binfmt_elf_fdpic.c:(.text+0xd24): undefined reference to `strnlen_user'
c6x-elf-ld: kernel/sys.o: in function `__do_sys_prctl':
>> sys.c:(.text+0x3820): undefined reference to `strncpy_from_user'
c6x-elf-ld: mm/maccess.o: in function `strncpy_from_user_nofault':
>> maccess.c:(.text+0x47c): undefined reference to `strncpy_from_user'
c6x-elf-ld: mm/maccess.o: in function `strnlen_user_nofault':
>> maccess.c:(.text+0x520): undefined reference to `strnlen_user'
c6x-elf-ld: mm/util.o: in function `strndup_user':
>> util.c:(.text+0x79c): undefined reference to `strnlen_user'
c6x-elf-ld: fs/exec.o: in function `copy_strings':
>> exec.c:(.text+0xa58): undefined reference to `strnlen_user'
c6x-elf-ld: fs/namei.o: in function `getname_flags':
>> namei.c:(.text+0x51a0): undefined reference to `strncpy_from_user'
>> c6x-elf-ld: namei.c:(.text+0x522c): undefined reference to `strncpy_from_user'
c6x-elf-ld: fs/xattr.o: in function `getxattr':
>> xattr.c:(.text+0x858): undefined reference to `strncpy_from_user'
c6x-elf-ld: fs/xattr.o: in function `removexattr':
xattr.c:(.text+0xeac): undefined reference to `strncpy_from_user'
c6x-elf-ld: fs/xattr.o: in function `setxattr':
xattr.c:(.text+0x14dc): undefined reference to `strncpy_from_user'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
drivers/scsi/fnic/vnic_dev.c:332:32: sparse: sparse: incorrect type in argument 1 (different address spaces)
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: dcc0b49040c70ad827a7f3d58a21b01fdb14e749
commit: 8f28ca6bd8211214faf717677bbffe375c2a6072 iomap: constify ioreadX() iomem argument (as in generic implementation)
date: 6 months ago
config: i386-randconfig-s002-20210213 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-215-g0fb77bb6-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 8f28ca6bd8211214faf717677bbffe375c2a6072
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
"sparse warnings: (new ones prefixed by >>)"
>> drivers/scsi/fnic/vnic_dev.c:332:32: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem * @@ got unsigned int * @@
drivers/scsi/fnic/vnic_dev.c:332:32: sparse: expected void const [noderef] __iomem *
drivers/scsi/fnic/vnic_dev.c:332:32: sparse: got unsigned int *
drivers/scsi/fnic/vnic_dev.c:333:37: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem * @@ got unsigned int * @@
drivers/scsi/fnic/vnic_dev.c:333:37: sparse: expected void const [noderef] __iomem *
drivers/scsi/fnic/vnic_dev.c:333:37: sparse: got unsigned int *
drivers/scsi/fnic/vnic_dev.c:373:36: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void [noderef] __iomem * @@ got unsigned int * @@
drivers/scsi/fnic/vnic_dev.c:373:36: sparse: expected void [noderef] __iomem *
drivers/scsi/fnic/vnic_dev.c:373:36: sparse: got unsigned int *
drivers/scsi/fnic/vnic_dev.c:469:32: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct vnic_wq_ctrl *wq_ctrl @@ got struct vnic_wq_ctrl [noderef] __iomem *ctrl @@
drivers/scsi/fnic/vnic_dev.c:469:32: sparse: expected struct vnic_wq_ctrl *wq_ctrl
drivers/scsi/fnic/vnic_dev.c:469:32: sparse: got struct vnic_wq_ctrl [noderef] __iomem *ctrl
drivers/scsi/fnic/vnic_dev.c:943:11: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *p @@ got void [noderef] __iomem * @@
drivers/scsi/fnic/vnic_dev.c:943:11: sparse: expected void *p
drivers/scsi/fnic/vnic_dev.c:943:11: sparse: got void [noderef] __iomem *
vim +332 drivers/scsi/fnic/vnic_dev.c
5df6d737dd4b0f Abhijeet Joglekar 2009-04-17 318
363f4d937501ba Jason Yan 2020-04-15 319 static int vnic_dev_cmd2(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd,
0a2fdd2215e1fa Satish Kharat 2019-01-18 320 int wait)
0a2fdd2215e1fa Satish Kharat 2019-01-18 321 {
0a2fdd2215e1fa Satish Kharat 2019-01-18 322 struct devcmd2_controller *dc2c = vdev->devcmd2;
0a2fdd2215e1fa Satish Kharat 2019-01-18 323 struct devcmd2_result *result;
0a2fdd2215e1fa Satish Kharat 2019-01-18 324 u8 color;
0a2fdd2215e1fa Satish Kharat 2019-01-18 325 unsigned int i;
0a2fdd2215e1fa Satish Kharat 2019-01-18 326 int delay;
0a2fdd2215e1fa Satish Kharat 2019-01-18 327 int err;
0a2fdd2215e1fa Satish Kharat 2019-01-18 328 u32 fetch_index;
0a2fdd2215e1fa Satish Kharat 2019-01-18 329 u32 posted;
0a2fdd2215e1fa Satish Kharat 2019-01-18 330 u32 new_posted;
0a2fdd2215e1fa Satish Kharat 2019-01-18 331
0a2fdd2215e1fa Satish Kharat 2019-01-18 @332 posted = ioread32(&dc2c->wq_ctrl->posted_index);
0a2fdd2215e1fa Satish Kharat 2019-01-18 333 fetch_index = ioread32(&dc2c->wq_ctrl->fetch_index);
0a2fdd2215e1fa Satish Kharat 2019-01-18 334
0a2fdd2215e1fa Satish Kharat 2019-01-18 335 if (posted == 0xFFFFFFFF || fetch_index == 0xFFFFFFFF) {
0a2fdd2215e1fa Satish Kharat 2019-01-18 336 /* Hardware surprise removal: return error */
0a2fdd2215e1fa Satish Kharat 2019-01-18 337 pr_err("%s: devcmd2 invalid posted or fetch index on cmd %d\n",
0a2fdd2215e1fa Satish Kharat 2019-01-18 338 pci_name(vdev->pdev), _CMD_N(cmd));
0a2fdd2215e1fa Satish Kharat 2019-01-18 339 pr_err("%s: fetch index: %u, posted index: %u\n",
0a2fdd2215e1fa Satish Kharat 2019-01-18 340 pci_name(vdev->pdev), fetch_index, posted);
0a2fdd2215e1fa Satish Kharat 2019-01-18 341
0a2fdd2215e1fa Satish Kharat 2019-01-18 342 return -ENODEV;
0a2fdd2215e1fa Satish Kharat 2019-01-18 343
0a2fdd2215e1fa Satish Kharat 2019-01-18 344 }
0a2fdd2215e1fa Satish Kharat 2019-01-18 345
0a2fdd2215e1fa Satish Kharat 2019-01-18 346 new_posted = (posted + 1) % DEVCMD2_RING_SIZE;
0a2fdd2215e1fa Satish Kharat 2019-01-18 347
0a2fdd2215e1fa Satish Kharat 2019-01-18 348 if (new_posted == fetch_index) {
0a2fdd2215e1fa Satish Kharat 2019-01-18 349 pr_err("%s: devcmd2 wq full while issuing cmd %d\n",
0a2fdd2215e1fa Satish Kharat 2019-01-18 350 pci_name(vdev->pdev), _CMD_N(cmd));
0a2fdd2215e1fa Satish Kharat 2019-01-18 351 pr_err("%s: fetch index: %u, posted index: %u\n",
0a2fdd2215e1fa Satish Kharat 2019-01-18 352 pci_name(vdev->pdev), fetch_index, posted);
0a2fdd2215e1fa Satish Kharat 2019-01-18 353 return -EBUSY;
0a2fdd2215e1fa Satish Kharat 2019-01-18 354
0a2fdd2215e1fa Satish Kharat 2019-01-18 355 }
0a2fdd2215e1fa Satish Kharat 2019-01-18 356 dc2c->cmd_ring[posted].cmd = cmd;
0a2fdd2215e1fa Satish Kharat 2019-01-18 357 dc2c->cmd_ring[posted].flags = 0;
0a2fdd2215e1fa Satish Kharat 2019-01-18 358
0a2fdd2215e1fa Satish Kharat 2019-01-18 359 if ((_CMD_FLAGS(cmd) & _CMD_FLAGS_NOWAIT))
0a2fdd2215e1fa Satish Kharat 2019-01-18 360 dc2c->cmd_ring[posted].flags |= DEVCMD2_FNORESULT;
0a2fdd2215e1fa Satish Kharat 2019-01-18 361 if (_CMD_DIR(cmd) & _CMD_DIR_WRITE) {
0a2fdd2215e1fa Satish Kharat 2019-01-18 362 for (i = 0; i < VNIC_DEVCMD_NARGS; i++)
0a2fdd2215e1fa Satish Kharat 2019-01-18 363 dc2c->cmd_ring[posted].args[i] = vdev->args[i];
0a2fdd2215e1fa Satish Kharat 2019-01-18 364
0a2fdd2215e1fa Satish Kharat 2019-01-18 365 }
0a2fdd2215e1fa Satish Kharat 2019-01-18 366
0a2fdd2215e1fa Satish Kharat 2019-01-18 367 /* Adding write memory barrier prevents compiler and/or CPU
0a2fdd2215e1fa Satish Kharat 2019-01-18 368 * reordering, thus avoiding descriptor posting before
0a2fdd2215e1fa Satish Kharat 2019-01-18 369 * descriptor is initialized. Otherwise, hardware can read
0a2fdd2215e1fa Satish Kharat 2019-01-18 370 * stale descriptor fields.
0a2fdd2215e1fa Satish Kharat 2019-01-18 371 */
0a2fdd2215e1fa Satish Kharat 2019-01-18 372 wmb();
0a2fdd2215e1fa Satish Kharat 2019-01-18 373 iowrite32(new_posted, &dc2c->wq_ctrl->posted_index);
0a2fdd2215e1fa Satish Kharat 2019-01-18 374
0a2fdd2215e1fa Satish Kharat 2019-01-18 375 if (dc2c->cmd_ring[posted].flags & DEVCMD2_FNORESULT)
0a2fdd2215e1fa Satish Kharat 2019-01-18 376 return 0;
0a2fdd2215e1fa Satish Kharat 2019-01-18 377
0a2fdd2215e1fa Satish Kharat 2019-01-18 378 result = dc2c->result + dc2c->next_result;
0a2fdd2215e1fa Satish Kharat 2019-01-18 379 color = dc2c->color;
0a2fdd2215e1fa Satish Kharat 2019-01-18 380
0a2fdd2215e1fa Satish Kharat 2019-01-18 381 dc2c->next_result++;
0a2fdd2215e1fa Satish Kharat 2019-01-18 382 if (dc2c->next_result == dc2c->result_size) {
0a2fdd2215e1fa Satish Kharat 2019-01-18 383 dc2c->next_result = 0;
0a2fdd2215e1fa Satish Kharat 2019-01-18 384 dc2c->color = dc2c->color ? 0 : 1;
0a2fdd2215e1fa Satish Kharat 2019-01-18 385 }
0a2fdd2215e1fa Satish Kharat 2019-01-18 386
0a2fdd2215e1fa Satish Kharat 2019-01-18 387 for (delay = 0; delay < wait; delay++) {
0a2fdd2215e1fa Satish Kharat 2019-01-18 388 udelay(100);
0a2fdd2215e1fa Satish Kharat 2019-01-18 389 if (result->color == color) {
0a2fdd2215e1fa Satish Kharat 2019-01-18 390 if (result->error) {
0a2fdd2215e1fa Satish Kharat 2019-01-18 391 err = -(int) result->error;
0a2fdd2215e1fa Satish Kharat 2019-01-18 392 if (err != ERR_ECMDUNKNOWN ||
0a2fdd2215e1fa Satish Kharat 2019-01-18 393 cmd != CMD_CAPABILITY)
0a2fdd2215e1fa Satish Kharat 2019-01-18 394 pr_err("%s:Error %d devcmd %d\n",
0a2fdd2215e1fa Satish Kharat 2019-01-18 395 pci_name(vdev->pdev),
0a2fdd2215e1fa Satish Kharat 2019-01-18 396 err, _CMD_N(cmd));
0a2fdd2215e1fa Satish Kharat 2019-01-18 397 return err;
0a2fdd2215e1fa Satish Kharat 2019-01-18 398 }
0a2fdd2215e1fa Satish Kharat 2019-01-18 399 if (_CMD_DIR(cmd) & _CMD_DIR_READ) {
0a2fdd2215e1fa Satish Kharat 2019-01-18 400 rmb(); /*prevent reorder while reding result*/
0a2fdd2215e1fa Satish Kharat 2019-01-18 401 for (i = 0; i < VNIC_DEVCMD_NARGS; i++)
0a2fdd2215e1fa Satish Kharat 2019-01-18 402 vdev->args[i] = result->results[i];
0a2fdd2215e1fa Satish Kharat 2019-01-18 403 }
0a2fdd2215e1fa Satish Kharat 2019-01-18 404 return 0;
0a2fdd2215e1fa Satish Kharat 2019-01-18 405 }
0a2fdd2215e1fa Satish Kharat 2019-01-18 406 }
0a2fdd2215e1fa Satish Kharat 2019-01-18 407
0a2fdd2215e1fa Satish Kharat 2019-01-18 408 pr_err("%s:Timed out devcmd %d\n", pci_name(vdev->pdev), _CMD_N(cmd));
0a2fdd2215e1fa Satish Kharat 2019-01-18 409
0a2fdd2215e1fa Satish Kharat 2019-01-18 410 return -ETIMEDOUT;
0a2fdd2215e1fa Satish Kharat 2019-01-18 411 }
0a2fdd2215e1fa Satish Kharat 2019-01-18 412
:::::: The code at line 332 was first introduced by commit
:::::: 0a2fdd2215e1fa3b417792bd6e9cb719822cbfb6 scsi: fnic: Adding devcmd2 init and posting interfaces
:::::: TO: Satish Kharat <satishkh(a)cisco.com>
:::::: CC: Martin K. Petersen <martin.petersen(a)oracle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH] Fix space prohibited issue in fbtft-bus.c
by kernel test robot
Hi Alaa,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.11-rc7 next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alaa-Emad/Fix-space-prohibited-i...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git a2ea4e1d9091cd8bc69f1c42c15bedc38618f04c
config: microblaze-randconfig-r021-20210212 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c8ebfad6d337cc402230562da12297149...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alaa-Emad/Fix-space-prohibited-issue-in-fbtft-bus-c/20210212-230034
git checkout c8ebfad6d337cc402230562da12297149f4c2879
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/staging/fbtft/fbtft-bus.c:65:53: error: macro "define_fbtft_write_reg" requires 4 arguments, but only 3 given
65 | define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
| ^
drivers/staging/fbtft/fbtft-bus.c:14: note: macro "define_fbtft_write_reg" defined here
14 | #define define_fbtft_write_reg(func, buffer_type, data_type, modifier) \
|
>> drivers/staging/fbtft/fbtft-bus.c:65:23: error: expected ';' before 'void'
65 | define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
| ^
| ;
drivers/staging/fbtft/fbtft-bus.c:67:57: error: macro "define_fbtft_write_reg" requires 4 arguments, but only 3 given
67 | define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
| ^
drivers/staging/fbtft/fbtft-bus.c:14: note: macro "define_fbtft_write_reg" defined here
14 | #define define_fbtft_write_reg(func, buffer_type, data_type, modifier) \
|
drivers/staging/fbtft/fbtft-bus.c:67:23: error: expected ';' before 'void'
67 | define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
| ^
| ;
68 |
69 | void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
| ~~~~
vim +/define_fbtft_write_reg +65 drivers/staging/fbtft/fbtft-bus.c
64
> 65 define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
66 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
67 define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
68
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months