[linux-next:master 5178/10581] net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 671176b0016c80b3943cb5387312c886aba3308d
commit: 83ace77f51175023c3757e2d08a92565f9b1c7f3 [5178/10581] netfilter: ctnetlink: remove get_ct indirection
config: powerpc64-randconfig-r025-20210212 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 83ace77f51175023c3757e2d08a92565f9b1c7f3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here [-Wuninitialized]
if (ct && nfnl_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0)
^~~~~~
net/netfilter/nfnetlink_queue.c:391:2: note: variable 'ctinfo' is declared here
enum ip_conntrack_info ctinfo;
^
1 warning generated.
vim +/ctinfo +601 net/netfilter/nfnetlink_queue.c
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 456
08c0cad69f32ad net/netfilter/nfnetlink_queue_core.c Valentina Giusti 2013-12-20 457 if (queue->flags & NFQA_CFG_F_UID_GID) {
08c0cad69f32ad net/netfilter/nfnetlink_queue_core.c Valentina Giusti 2013-12-20 458 size += (nla_total_size(sizeof(u_int32_t)) /* uid */
08c0cad69f32ad net/netfilter/nfnetlink_queue_core.c Valentina Giusti 2013-12-20 459 + nla_total_size(sizeof(u_int32_t))); /* gid */
08c0cad69f32ad net/netfilter/nfnetlink_queue_core.c Valentina Giusti 2013-12-20 460 }
08c0cad69f32ad net/netfilter/nfnetlink_queue_core.c Valentina Giusti 2013-12-20 461
ef493bd930ae48 net/netfilter/nfnetlink_queue_core.c Roman Kubiak 2015-06-12 462 if ((queue->flags & NFQA_CFG_F_SECCTX) && entskb->sk) {
ef493bd930ae48 net/netfilter/nfnetlink_queue_core.c Roman Kubiak 2015-06-12 463 seclen = nfqnl_get_sk_secctx(entskb, &secdata);
ef493bd930ae48 net/netfilter/nfnetlink_queue_core.c Roman Kubiak 2015-06-12 464 if (seclen)
ef493bd930ae48 net/netfilter/nfnetlink_queue_core.c Roman Kubiak 2015-06-12 465 size += nla_total_size(seclen);
ef493bd930ae48 net/netfilter/nfnetlink_queue_core.c Roman Kubiak 2015-06-12 466 }
ef493bd930ae48 net/netfilter/nfnetlink_queue_core.c Roman Kubiak 2015-06-12 467
c5b0db3263b925 net/netfilter/nfnetlink_queue.c Florian Westphal 2016-02-18 468 skb = alloc_skb(size, GFP_ATOMIC);
36d5fe6a000790 net/netfilter/nfnetlink_queue_core.c Zoltan Kiss 2014-03-26 469 if (!skb) {
36d5fe6a000790 net/netfilter/nfnetlink_queue_core.c Zoltan Kiss 2014-03-26 470 skb_tx_error(entskb);
77c1c03c5b8ef2 net/netfilter/nfnetlink_queue.c Liping Zhang 2017-03-28 471 goto nlmsg_failure;
36d5fe6a000790 net/netfilter/nfnetlink_queue_core.c Zoltan Kiss 2014-03-26 472 }
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 473
3da07c0c2b5a13 net/netfilter/nfnetlink_queue_core.c David S. Miller 2012-06-26 474 nlh = nlmsg_put(skb, 0, 0,
dedb67c4b4e5fa net/netfilter/nfnetlink_queue.c Pablo Neira Ayuso 2017-03-28 475 nfnl_msg_type(NFNL_SUBSYS_QUEUE, NFQNL_MSG_PACKET),
3da07c0c2b5a13 net/netfilter/nfnetlink_queue_core.c David S. Miller 2012-06-26 476 sizeof(struct nfgenmsg), 0);
3da07c0c2b5a13 net/netfilter/nfnetlink_queue_core.c David S. Miller 2012-06-26 477 if (!nlh) {
36d5fe6a000790 net/netfilter/nfnetlink_queue_core.c Zoltan Kiss 2014-03-26 478 skb_tx_error(entskb);
3da07c0c2b5a13 net/netfilter/nfnetlink_queue_core.c David S. Miller 2012-06-26 479 kfree_skb(skb);
77c1c03c5b8ef2 net/netfilter/nfnetlink_queue.c Liping Zhang 2017-03-28 480 goto nlmsg_failure;
3da07c0c2b5a13 net/netfilter/nfnetlink_queue_core.c David S. Miller 2012-06-26 481 }
3da07c0c2b5a13 net/netfilter/nfnetlink_queue_core.c David S. Miller 2012-06-26 482 nfmsg = nlmsg_data(nlh);
1d1de89b9a4746 net/netfilter/nfnetlink_queue_core.c David S. Miller 2015-04-03 483 nfmsg->nfgen_family = entry->state.pf;
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 484 nfmsg->version = NFNETLINK_V0;
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 485 nfmsg->res_id = htons(queue->queue_num);
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 486
5863702a3421b0 net/netfilter/nfnetlink_queue.c Eric Dumazet 2011-07-19 487 nla = __nla_reserve(skb, NFQA_PACKET_HDR, sizeof(*pmsg));
5863702a3421b0 net/netfilter/nfnetlink_queue.c Eric Dumazet 2011-07-19 488 pmsg = nla_data(nla);
5863702a3421b0 net/netfilter/nfnetlink_queue.c Eric Dumazet 2011-07-19 489 pmsg->hw_protocol = entskb->protocol;
1d1de89b9a4746 net/netfilter/nfnetlink_queue_core.c David S. Miller 2015-04-03 490 pmsg->hook = entry->state.hook;
5863702a3421b0 net/netfilter/nfnetlink_queue.c Eric Dumazet 2011-07-19 491 *packet_id_ptr = &pmsg->packet_id;
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 492
1d1de89b9a4746 net/netfilter/nfnetlink_queue_core.c David S. Miller 2015-04-03 493 indev = entry->state.in;
3e4ead4fe5d0d9 net/netfilter/nfnetlink_queue.c Jesper Juhl 2006-01-05 494 if (indev) {
1109a90c01177e net/netfilter/nfnetlink_queue_core.c Pablo Neira Ayuso 2014-10-01 495 #if !IS_ENABLED(CONFIG_BRIDGE_NETFILTER)
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 496 if (nla_put_be32(skb, NFQA_IFINDEX_INDEV, htonl(indev->ifindex)))
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 497 goto nla_put_failure;
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 498 #else
1d1de89b9a4746 net/netfilter/nfnetlink_queue_core.c David S. Miller 2015-04-03 499 if (entry->state.pf == PF_BRIDGE) {
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 500 /* Case 1: indev is physical input device, we need to
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 501 * look for bridge group (when called from
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 502 * netfilter_bridge) */
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 503 if (nla_put_be32(skb, NFQA_IFINDEX_PHYSINDEV,
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 504 htonl(indev->ifindex)) ||
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 505 /* this is the bridge group "brX" */
f350a0a8737441 net/netfilter/nfnetlink_queue.c Jiri Pirko 2010-06-15 506 /* rcu_read_lock()ed by __nf_queue */
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 507 nla_put_be32(skb, NFQA_IFINDEX_INDEV,
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 508 htonl(br_port_get_rcu(indev)->br->dev->ifindex)))
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 509 goto nla_put_failure;
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 510 } else {
c737b7c4510026 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2015-04-02 511 int physinif;
c737b7c4510026 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2015-04-02 512
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 513 /* Case 2: indev is bridge group, we need to look for
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 514 * physical device (when called from ipv4) */
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 515 if (nla_put_be32(skb, NFQA_IFINDEX_INDEV,
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 516 htonl(indev->ifindex)))
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 517 goto nla_put_failure;
c737b7c4510026 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2015-04-02 518
c737b7c4510026 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2015-04-02 519 physinif = nf_bridge_get_physinif(entskb);
c737b7c4510026 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2015-04-02 520 if (physinif &&
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 521 nla_put_be32(skb, NFQA_IFINDEX_PHYSINDEV,
c737b7c4510026 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2015-04-02 522 htonl(physinif)))
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 523 goto nla_put_failure;
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 524 }
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 525 #endif
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 526 }
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 527
3e4ead4fe5d0d9 net/netfilter/nfnetlink_queue.c Jesper Juhl 2006-01-05 528 if (outdev) {
1109a90c01177e net/netfilter/nfnetlink_queue_core.c Pablo Neira Ayuso 2014-10-01 529 #if !IS_ENABLED(CONFIG_BRIDGE_NETFILTER)
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 530 if (nla_put_be32(skb, NFQA_IFINDEX_OUTDEV, htonl(outdev->ifindex)))
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 531 goto nla_put_failure;
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 532 #else
1d1de89b9a4746 net/netfilter/nfnetlink_queue_core.c David S. Miller 2015-04-03 533 if (entry->state.pf == PF_BRIDGE) {
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 534 /* Case 1: outdev is physical output device, we need to
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 535 * look for bridge group (when called from
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 536 * netfilter_bridge) */
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 537 if (nla_put_be32(skb, NFQA_IFINDEX_PHYSOUTDEV,
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 538 htonl(outdev->ifindex)) ||
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 539 /* this is the bridge group "brX" */
f350a0a8737441 net/netfilter/nfnetlink_queue.c Jiri Pirko 2010-06-15 540 /* rcu_read_lock()ed by __nf_queue */
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 541 nla_put_be32(skb, NFQA_IFINDEX_OUTDEV,
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 542 htonl(br_port_get_rcu(outdev)->br->dev->ifindex)))
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 543 goto nla_put_failure;
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 544 } else {
c737b7c4510026 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2015-04-02 545 int physoutif;
c737b7c4510026 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2015-04-02 546
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 547 /* Case 2: outdev is bridge group, we need to look for
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 548 * physical output device (when called from ipv4) */
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 549 if (nla_put_be32(skb, NFQA_IFINDEX_OUTDEV,
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 550 htonl(outdev->ifindex)))
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 551 goto nla_put_failure;
c737b7c4510026 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2015-04-02 552
c737b7c4510026 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2015-04-02 553 physoutif = nf_bridge_get_physoutif(entskb);
c737b7c4510026 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2015-04-02 554 if (physoutif &&
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 555 nla_put_be32(skb, NFQA_IFINDEX_PHYSOUTDEV,
c737b7c4510026 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2015-04-02 556 htonl(physoutif)))
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 557 goto nla_put_failure;
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 558 }
fbcd923c3e0c8e net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 559 #endif
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 560 }
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 561
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 562 if (entskb->mark &&
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 563 nla_put_be32(skb, NFQA_MARK, htonl(entskb->mark)))
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 564 goto nla_put_failure;
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 565
2c38de4c1f8da7 net/netfilter/nfnetlink_queue.c Nicolas Cavallari 2011-06-16 566 if (indev && entskb->dev &&
2c38de4c1f8da7 net/netfilter/nfnetlink_queue.c Nicolas Cavallari 2011-06-16 567 entskb->mac_header != entskb->network_header) {
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 568 struct nfqnl_msg_packet_hw phw;
e4d091d7bf787c net/netfilter/nfnetlink_queue_core.c Dan Carpenter 2013-08-01 569 int len;
e4d091d7bf787c net/netfilter/nfnetlink_queue_core.c Dan Carpenter 2013-08-01 570
e4d091d7bf787c net/netfilter/nfnetlink_queue_core.c Dan Carpenter 2013-08-01 571 memset(&phw, 0, sizeof(phw));
e4d091d7bf787c net/netfilter/nfnetlink_queue_core.c Dan Carpenter 2013-08-01 572 len = dev_parse_header(entskb, phw.hw_addr);
b95cce3576813a net/netfilter/nfnetlink_queue.c Stephen Hemminger 2007-09-26 573 if (len) {
98a4a86128d717 net/netfilter/nfnetlink_queue.c Al Viro 2006-11-08 574 phw.hw_addrlen = htons(len);
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 575 if (nla_put(skb, NFQA_HWADDR, sizeof(phw), &phw))
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 576 goto nla_put_failure;
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 577 }
b95cce3576813a net/netfilter/nfnetlink_queue.c Stephen Hemminger 2007-09-26 578 }
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 579
15824ab29f364a net/netfilter/nfnetlink_queue.c Stephane Bryant 2016-03-26 580 if (nfqnl_put_bridge(entry, skb) < 0)
15824ab29f364a net/netfilter/nfnetlink_queue.c Stephane Bryant 2016-03-26 581 goto nla_put_failure;
15824ab29f364a net/netfilter/nfnetlink_queue.c Stephane Bryant 2016-03-26 582
916f6efae62305 net/netfilter/nfnetlink_queue.c Florian Westphal 2019-04-17 583 if (entry->state.hook <= NF_INET_FORWARD && entskb->tstamp) {
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 584 struct nfqnl_msg_packet_timestamp ts;
a7f1884554b81b net/netfilter/nfnetlink_queue.c Florian Westphal 2016-05-12 585 struct timespec64 kts = ktime_to_timespec64(entskb->tstamp);
b28b1e826f818c net/netfilter/nfnetlink_queue.c Pablo Neira Ayuso 2015-10-04 586
b28b1e826f818c net/netfilter/nfnetlink_queue.c Pablo Neira Ayuso 2015-10-04 587 ts.sec = cpu_to_be64(kts.tv_sec);
b28b1e826f818c net/netfilter/nfnetlink_queue.c Pablo Neira Ayuso 2015-10-04 588 ts.usec = cpu_to_be64(kts.tv_nsec / NSEC_PER_USEC);
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 589
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 590 if (nla_put(skb, NFQA_TIMESTAMP, sizeof(ts), &ts))
a447189e073bf6 net/netfilter/nfnetlink_queue.c David S. Miller 2012-03-29 591 goto nla_put_failure;
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 592 }
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 593
08c0cad69f32ad net/netfilter/nfnetlink_queue_core.c Valentina Giusti 2013-12-20 594 if ((queue->flags & NFQA_CFG_F_UID_GID) && entskb->sk &&
08c0cad69f32ad net/netfilter/nfnetlink_queue_core.c Valentina Giusti 2013-12-20 595 nfqnl_put_sk_uidgid(skb, entskb->sk) < 0)
08c0cad69f32ad net/netfilter/nfnetlink_queue_core.c Valentina Giusti 2013-12-20 596 goto nla_put_failure;
08c0cad69f32ad net/netfilter/nfnetlink_queue_core.c Valentina Giusti 2013-12-20 597
ef493bd930ae48 net/netfilter/nfnetlink_queue_core.c Roman Kubiak 2015-06-12 598 if (seclen && nla_put(skb, NFQA_SECCTX, seclen, secdata))
ef493bd930ae48 net/netfilter/nfnetlink_queue_core.c Roman Kubiak 2015-06-12 599 goto nla_put_failure;
ef493bd930ae48 net/netfilter/nfnetlink_queue_core.c Roman Kubiak 2015-06-12 600
a4b4766c3cebb4 net/netfilter/nfnetlink_queue.c Ken-ichirou MATSUZAWA 2015-10-05 @601 if (ct && nfnl_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0)
ae08ce0021087a net/netfilter/nfnetlink_queue_core.c Eric Dumazet 2013-03-17 602 goto nla_put_failure;
ae08ce0021087a net/netfilter/nfnetlink_queue_core.c Eric Dumazet 2013-03-17 603
7f87712c015251 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2013-06-04 604 if (cap_len > data_len &&
7f87712c015251 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2013-06-04 605 nla_put_be32(skb, NFQA_CAP_LEN, htonl(cap_len)))
ae08ce0021087a net/netfilter/nfnetlink_queue_core.c Eric Dumazet 2013-03-17 606 goto nla_put_failure;
ae08ce0021087a net/netfilter/nfnetlink_queue_core.c Eric Dumazet 2013-03-17 607
496e4ae7dc944f net/netfilter/nfnetlink_queue_core.c Florian Westphal 2013-06-29 608 if (nfqnl_put_packet_info(skb, entskb, csum_verify))
7237190df8c412 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2013-04-19 609 goto nla_put_failure;
7237190df8c412 net/netfilter/nfnetlink_queue_core.c Florian Westphal 2013-04-19 610
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 611 if (data_len) {
df6fb868d61186 net/netfilter/nfnetlink_queue.c Patrick McHardy 2007-09-28 612 struct nlattr *nla;
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 613
ae08ce0021087a net/netfilter/nfnetlink_queue_core.c Eric Dumazet 2013-03-17 614 if (skb_tailroom(skb) < sizeof(*nla) + hlen)
ae08ce0021087a net/netfilter/nfnetlink_queue_core.c Eric Dumazet 2013-03-17 615 goto nla_put_failure;
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 616
4df864c1d9afb4 net/netfilter/nfnetlink_queue.c Johannes Berg 2017-06-16 617 nla = skb_put(skb, sizeof(*nla));
df6fb868d61186 net/netfilter/nfnetlink_queue.c Patrick McHardy 2007-09-28 618 nla->nla_type = NFQA_PAYLOAD;
ae08ce0021087a net/netfilter/nfnetlink_queue_core.c Eric Dumazet 2013-03-17 619 nla->nla_len = nla_attr_size(data_len);
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 620
36d5fe6a000790 net/netfilter/nfnetlink_queue_core.c Zoltan Kiss 2014-03-26 621 if (skb_zerocopy(skb, entskb, data_len, hlen))
36d5fe6a000790 net/netfilter/nfnetlink_queue_core.c Zoltan Kiss 2014-03-26 622 goto nla_put_failure;
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 623 }
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 624
ae08ce0021087a net/netfilter/nfnetlink_queue_core.c Eric Dumazet 2013-03-17 625 nlh->nlmsg_len = skb->len;
77c1c03c5b8ef2 net/netfilter/nfnetlink_queue.c Liping Zhang 2017-03-28 626 if (seclen)
77c1c03c5b8ef2 net/netfilter/nfnetlink_queue.c Liping Zhang 2017-03-28 627 security_release_secctx(secdata, seclen);
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 628 return skb;
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 629
df6fb868d61186 net/netfilter/nfnetlink_queue.c Patrick McHardy 2007-09-28 630 nla_put_failure:
36d5fe6a000790 net/netfilter/nfnetlink_queue_core.c Zoltan Kiss 2014-03-26 631 skb_tx_error(entskb);
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 632 kfree_skb(skb);
e87cc4728f0e2f net/netfilter/nfnetlink_queue.c Joe Perches 2012-05-13 633 net_err_ratelimited("nf_queue: error creating packet message\n");
77c1c03c5b8ef2 net/netfilter/nfnetlink_queue.c Liping Zhang 2017-03-28 634 nlmsg_failure:
77c1c03c5b8ef2 net/netfilter/nfnetlink_queue.c Liping Zhang 2017-03-28 635 if (seclen)
77c1c03c5b8ef2 net/netfilter/nfnetlink_queue.c Liping Zhang 2017-03-28 636 security_release_secctx(secdata, seclen);
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 637 return NULL;
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 638 }
7af4cc3fa158ff net/netfilter/nfnetlink_queue.c Harald Welte 2005-08-09 639
:::::: The code at line 601 was first introduced by commit
:::::: a4b4766c3cebb4018167e06b863d8e95b7274757 netfilter: nfnetlink_queue: rename related to nfqueue attaching conntrack info
:::::: TO: Ken-ichirou MATSUZAWA <chamaken(a)gmail.com>
:::::: CC: Pablo Neira Ayuso <pablo(a)netfilter.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH v3 1/3] misc/pvpanic: split-up generic and platform dependent code
by kernel test robot
Hi Mihai,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linux/master]
[also build test WARNING on soc/for-next linus/master v5.11-rc7]
[cannot apply to char-misc/char-misc-testing next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mihai-Carabas/misc-pvpanic-split...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2ab38c17aac10bf55ab3efde4c4db3893d8691d2
config: x86_64-randconfig-r012-20210209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/e69d90da4864766e3dc173d0940c05c4e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mihai-Carabas/misc-pvpanic-split-up-generic-and-platform-dependent-code/20210213-043307
git checkout e69d90da4864766e3dc173d0940c05c4ec59278b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/misc/pvpanic/pvpanic.c:47:6: warning: no previous prototype for function 'pvpanic_probe' [-Wmissing-prototypes]
void pvpanic_probe(void __iomem *pbase)
^
drivers/misc/pvpanic/pvpanic.c:47:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void pvpanic_probe(void __iomem *pbase)
^
static
>> drivers/misc/pvpanic/pvpanic.c:55:6: warning: no previous prototype for function 'pvpanic_remove' [-Wmissing-prototypes]
void pvpanic_remove(void)
^
drivers/misc/pvpanic/pvpanic.c:55:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void pvpanic_remove(void)
^
static
2 warnings generated.
vim +/pvpanic_probe +47 drivers/misc/pvpanic/pvpanic.c
46
> 47 void pvpanic_probe(void __iomem *pbase)
48 {
49 base = pbase;
50 atomic_notifier_chain_register(&panic_notifier_list,
51 &pvpanic_panic_nb);
52 }
53 EXPORT_SYMBOL_GPL(pvpanic_probe);
54
> 55 void pvpanic_remove(void)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[linux-next:master 4773/10581] arch/arm/mach-prima2/pm.c:17:10: fatal error: linux/rtc/sirfsoc_rtciobrg.h: No such file or directory
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 671176b0016c80b3943cb5387312c886aba3308d
commit: 9d0735519f99948c5b5c22426b682ced7f7af9be [4773/10581] rtc: remove sirfsoc driver
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 9d0735519f99948c5b5c22426b682ced7f7af9be
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the linux-next/master HEAD 671176b0016c80b3943cb5387312c886aba3308d builds fine.
It may have been fixed somewhere.
All errors (new ones prefixed by >>):
>> arch/arm/mach-prima2/pm.c:17:10: fatal error: linux/rtc/sirfsoc_rtciobrg.h: No such file or directory
17 | #include <linux/rtc/sirfsoc_rtciobrg.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
--
>> drivers/input/misc/sirfsoc-onkey.c:14:10: fatal error: linux/rtc/sirfsoc_rtciobrg.h: No such file or directory
14 | #include <linux/rtc/sirfsoc_rtciobrg.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
vim +17 arch/arm/mach-prima2/pm.c
2558bd99cb1426 Rongjun Ying 2011-09-21 @17 #include <linux/rtc/sirfsoc_rtciobrg.h>
f81309067ff2d8 Russell King 2015-06-01 18 #include <asm/outercache.h>
2558bd99cb1426 Rongjun Ying 2011-09-21 19 #include <asm/suspend.h>
2558bd99cb1426 Rongjun Ying 2011-09-21 20 #include <asm/hardware/cache-l2x0.h>
2558bd99cb1426 Rongjun Ying 2011-09-21 21
:::::: The code at line 17 was first introduced by commit
:::::: 2558bd99cb1426a05ac8f1c78dc9c75a83ceb4bb ARM: CSR: PM: add sleep entry for SiRFprimaII
:::::: TO: Rongjun Ying <rongjun.ying(a)csr.com>
:::::: CC: Barry Song <21cnbao(a)gmail.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH] vfio/type1: Use follow_pte()
by kernel test robot
Hi Alex,
I love your patch! Yet something to improve:
[auto build test ERROR on vfio/next]
[also build test ERROR on v5.11-rc7 next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alex-Williamson/vfio-type1-Use-f...
base: https://github.com/awilliam/linux-vfio.git next
config: i386-randconfig-a002-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/d1aea3bcf226e5225e706acb7df2f4c68...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alex-Williamson/vfio-type1-Use-follow_pte/20210213-030541
git checkout d1aea3bcf226e5225e706acb7df2f4c68ea8858a
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/mm.h:33,
from include/linux/scatterlist.h:8,
from include/linux/iommu.h:10,
from drivers/vfio/vfio_iommu_type1.c:27:
drivers/vfio/vfio_iommu_type1.c: In function 'follow_fault_pfn':
>> include/linux/pgtable.h:81:24: error: implicit declaration of function 'kunmap_atomic'; did you mean 'iommu_map_atomic'? [-Werror=implicit-function-declaration]
81 | #define pte_unmap(pte) kunmap_atomic((pte))
| ^~~~~~~~~~~~~
include/linux/mm.h:2231:2: note: in expansion of macro 'pte_unmap'
2231 | pte_unmap(pte); \
| ^~~~~~~~~
drivers/vfio/vfio_iommu_type1.c:494:2: note: in expansion of macro 'pte_unmap_unlock'
494 | pte_unmap_unlock(ptep, ptl);
| ^~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +81 include/linux/pgtable.h
974b9b2c68f3d3 Mike Rapoport 2020-06-08 76
974b9b2c68f3d3 Mike Rapoport 2020-06-08 77 #if defined(CONFIG_HIGHPTE)
974b9b2c68f3d3 Mike Rapoport 2020-06-08 78 #define pte_offset_map(dir, address) \
974b9b2c68f3d3 Mike Rapoport 2020-06-08 79 ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \
974b9b2c68f3d3 Mike Rapoport 2020-06-08 80 pte_index((address)))
974b9b2c68f3d3 Mike Rapoport 2020-06-08 @81 #define pte_unmap(pte) kunmap_atomic((pte))
974b9b2c68f3d3 Mike Rapoport 2020-06-08 82 #else
974b9b2c68f3d3 Mike Rapoport 2020-06-08 83 #define pte_offset_map(dir, address) pte_offset_kernel((dir), (address))
974b9b2c68f3d3 Mike Rapoport 2020-06-08 84 #define pte_unmap(pte) ((void)(pte)) /* NOP */
974b9b2c68f3d3 Mike Rapoport 2020-06-08 85 #endif
974b9b2c68f3d3 Mike Rapoport 2020-06-08 86
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514
by kernel test robot
Hi Bjarni,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
url: https://github.com/0day-ci/linux/commits/Bjarni-Jonasson/net-phy-mscc-add...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 308daa19e2d0321ff8b037ea192c48358f9324f5
config: x86_64-randconfig-a014-20210209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/fd70d86ef38269af43b612e70cc5edbf0...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bjarni-Jonasson/net-phy-mscc-adding-LCPLL-reset-to-VSC8514/20210212-221024
git checkout fd70d86ef38269af43b612e70cc5edbf06b58db1
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:420:2: error: redefinition of enumerator 'FC_BUFFER'
FC_BUFFER = 0x04,
^
drivers/net/phy/mscc/mscc_macsec.h:64:2: note: previous definition is here
FC_BUFFER = 0x04,
^
In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:421:2: error: redefinition of enumerator 'HOST_MAC'
HOST_MAC = 0x05,
^
drivers/net/phy/mscc/mscc_macsec.h:65:2: note: previous definition is here
HOST_MAC = 0x05,
^
In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:422:2: error: redefinition of enumerator 'LINE_MAC'
LINE_MAC = 0x06,
^
drivers/net/phy/mscc/mscc_macsec.h:66:2: note: previous definition is here
LINE_MAC = 0x06,
^
In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:430:2: error: redefinition of enumerator 'PROC_0'
PROC_0 = 0x0E,
^
drivers/net/phy/mscc/mscc_macsec.h:67:2: note: previous definition is here
PROC_0 = 0x0e,
^
In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:431:2: error: redefinition of enumerator 'PROC_2'
PROC_2 = 0x0F,
^
drivers/net/phy/mscc/mscc_macsec.h:68:2: note: previous definition is here
PROC_2 = 0x0f,
^
In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:432:2: error: redefinition of enumerator 'MACSEC_INGR'
MACSEC_INGR = 0x38,
^
drivers/net/phy/mscc/mscc_macsec.h:69:2: note: previous definition is here
MACSEC_INGR = 0x38,
^
In file included from drivers/net/phy/mscc/mscc_main.c:21:
>> drivers/net/phy/mscc/mscc.h:433:2: error: redefinition of enumerator 'MACSEC_EGR'
MACSEC_EGR = 0x3C,
^
drivers/net/phy/mscc/mscc_macsec.h:70:2: note: previous definition is here
MACSEC_EGR = 0x3c,
^
7 errors generated.
vim +/FC_BUFFER +420 drivers/net/phy/mscc/mscc.h
418
419 enum csr_target {
> 420 FC_BUFFER = 0x04,
> 421 HOST_MAC = 0x05,
> 422 LINE_MAC = 0x06,
423 MACRO_CTRL = 0x07,
424 ANA0_INGR = 0x08,
425 ANA0_EGR = 0x09,
426 ANA1_INGR = 0x0A,
427 ANA1_EGR = 0x0B,
428 ANA2_INGR = 0x0C,
429 ANA2_EGR = 0x0D,
> 430 PROC_0 = 0x0E,
> 431 PROC_2 = 0x0F,
> 432 MACSEC_INGR = 0x38,
> 433 MACSEC_EGR = 0x3C,
434 SPI_IO = 0x40,
435 };
436
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
s390-linux-ld: ll_temac_main.c:undefined reference to `devm_platform_ioremap_resource'
by kernel test robot
Hi Zhang,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: dcc0b49040c70ad827a7f3d58a21b01fdb14e749
commit: cc6596fc7295e9dcd78156ed42f9f8e1221f7530 net: ll_temac: Fix potential NULL dereference in temac_probe()
date: 9 weeks ago
config: s390-randconfig-p001-20210212 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout cc6596fc7295e9dcd78156ed42f9f8e1221f7530
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
s390-linux-ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory':
coherent.c:(.text+0x468): undefined reference to `memremap'
s390-linux-ld: coherent.c:(.text+0x540): undefined reference to `memunmap'
s390-linux-ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory':
coherent.c:(.text+0x6a6): undefined reference to `memunmap'
s390-linux-ld: drivers/irqchip/irq-al-fic.o: in function `al_fic_init_dt':
irq-al-fic.c:(.init.text+0x4e): undefined reference to `of_iomap'
s390-linux-ld: irq-al-fic.c:(.init.text+0x2f2): undefined reference to `iounmap'
s390-linux-ld: drivers/tty/ipwireless/main.o: in function `ipwireless_detach':
main.c:(.text+0xa4): undefined reference to `iounmap'
s390-linux-ld: main.c:(.text+0xf0): undefined reference to `iounmap'
s390-linux-ld: drivers/tty/ipwireless/main.o: in function `ipwireless_probe':
main.c:(.text+0x2cc): undefined reference to `ioremap'
s390-linux-ld: main.c:(.text+0x388): undefined reference to `ioremap'
s390-linux-ld: main.c:(.text+0x3dc): undefined reference to `iounmap'
s390-linux-ld: main.c:(.text+0x420): undefined reference to `iounmap'
s390-linux-ld: drivers/tty/ipwireless/main.o: in function `ipwireless_attach':
main.c:(.text+0x6e2): undefined reference to `iounmap'
s390-linux-ld: main.c:(.text+0x728): undefined reference to `iounmap'
s390-linux-ld: drivers/char/xillybus/xillybus_of.o: in function `xilly_drv_probe':
xillybus_of.c:(.text+0x14e): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: drivers/net/arcnet/com90xx.o: in function `com90xx_exit':
com90xx.c:(.exit.text+0x62): undefined reference to `iounmap'
s390-linux-ld: drivers/net/arcnet/com90xx.o: in function `check_mirror':
com90xx.c:(.init.text+0x60): undefined reference to `ioremap'
s390-linux-ld: com90xx.c:(.init.text+0x86): undefined reference to `iounmap'
s390-linux-ld: drivers/net/arcnet/com90xx.o: in function `com90xx_probe':
com90xx.c:(.init.text+0x798): undefined reference to `ioremap'
s390-linux-ld: com90xx.c:(.init.text+0x936): undefined reference to `iounmap'
s390-linux-ld: com90xx.c:(.init.text+0xdcc): undefined reference to `iounmap'
s390-linux-ld: com90xx.c:(.init.text+0xec8): undefined reference to `iounmap'
s390-linux-ld: com90xx.c:(.init.text+0xffc): undefined reference to `ioremap'
s390-linux-ld: com90xx.c:(.init.text+0x10d6): undefined reference to `iounmap'
s390-linux-ld: com90xx.c:(.init.text+0x12b6): undefined reference to `iounmap'
s390-linux-ld: drivers/net/arcnet/arc-rimi.o: in function `arc_rimi_exit':
arc-rimi.c:(.exit.text+0x3e): undefined reference to `iounmap'
s390-linux-ld: drivers/net/arcnet/arc-rimi.o: in function `arc_rimi_init':
arc-rimi.c:(.init.text+0x264): undefined reference to `ioremap'
s390-linux-ld: arc-rimi.c:(.init.text+0x2ec): undefined reference to `iounmap'
s390-linux-ld: arc-rimi.c:(.init.text+0x46c): undefined reference to `iounmap'
s390-linux-ld: arc-rimi.c:(.init.text+0x4fc): undefined reference to `ioremap'
s390-linux-ld: arc-rimi.c:(.init.text+0x5d6): undefined reference to `iounmap'
s390-linux-ld: drivers/net/arcnet/arc-rimi.o: in function `check_mirror':
arc-rimi.c:(.text.unlikely+0x60): undefined reference to `ioremap'
s390-linux-ld: arc-rimi.c:(.text.unlikely+0x86): undefined reference to `iounmap'
s390-linux-ld: drivers/net/ethernet/altera/altera_tse_main.o: in function `request_and_map':
altera_tse_main.c:(.text+0x69a): undefined reference to `devm_ioremap'
s390-linux-ld: drivers/net/ethernet/xilinx/ll_temac_main.o: in function `temac_probe':
ll_temac_main.c:(.text+0x18cc): undefined reference to `devm_platform_ioremap_resource_byname'
s390-linux-ld: ll_temac_main.c:(.text+0x1a4c): undefined reference to `devm_of_iomap'
>> s390-linux-ld: ll_temac_main.c:(.text+0x1b3a): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: drivers/net/ethernet/xilinx/ll_temac_mdio.o: in function `temac_mdio_setup':
ll_temac_mdio.c:(.text+0x292): undefined reference to `of_address_to_resource'
s390-linux-ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function `axienet_probe':
xilinx_axienet_main.c:(.text+0x1604): undefined reference to `devm_ioremap_resource'
s390-linux-ld: xilinx_axienet_main.c:(.text+0x1818): undefined reference to `of_address_to_resource'
s390-linux-ld: xilinx_axienet_main.c:(.text+0x1850): undefined reference to `devm_ioremap_resource'
s390-linux-ld: xilinx_axienet_main.c:(.text+0x18ba): undefined reference to `devm_ioremap_resource'
s390-linux-ld: drivers/pcmcia/cistpl.o: in function `set_cis_map':
cistpl.c:(.text+0x3ae): undefined reference to `ioremap'
s390-linux-ld: cistpl.c:(.text+0x3e8): undefined reference to `iounmap'
s390-linux-ld: cistpl.c:(.text+0x416): undefined reference to `iounmap'
s390-linux-ld: cistpl.c:(.text+0x428): undefined reference to `ioremap'
s390-linux-ld: drivers/pcmcia/cistpl.o: in function `release_cis_mem':
cistpl.c:(.text+0xefa): undefined reference to `iounmap'
s390-linux-ld: drivers/input/serio/apbps2.o: in function `apbps2_of_probe':
apbps2.c:(.text+0x29e): undefined reference to `devm_ioremap_resource'
s390-linux-ld: drivers/input/touchscreen/imx6ul_tsc.o: in function `imx6ul_tsc_probe':
imx6ul_tsc.c:(.text+0x25e): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: imx6ul_tsc.c:(.text+0x29a): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_init':
timer-of.c:(.init.text+0x4e): undefined reference to `of_iomap'
s390-linux-ld: timer-of.c:(.init.text+0x33a): undefined reference to `iounmap'
s390-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_cleanup':
timer-of.c:(.init.text+0x426): undefined reference to `iounmap'
s390-linux-ld: drivers/clocksource/timer-microchip-pit64b.o: in function `mchp_pit64b_dt_init_timer':
timer-microchip-pit64b.c:(.init.text+0xa0): undefined reference to `of_iomap'
s390-linux-ld: timer-microchip-pit64b.c:(.init.text+0x526): undefined reference to `iounmap'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH] powerpc/pseries: Don't enforce MSI affinity with kdump
by kernel test robot
Hi Greg,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on linus/master v5.11-rc7 next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Greg-Kurz/powerpc-pseries-Don-t-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1e5f7523fcfc57ab9437b8c7b29a974b6...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Greg-Kurz/powerpc-pseries-Don-t-enforce-MSI-affinity-with-kdump/20210213-004658
git checkout 1e5f7523fcfc57ab9437b8c7b29a974b62bde79d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/powerpc/platforms/pseries/msi.c: In function 'rtas_setup_msi_irqs':
>> arch/powerpc/platforms/pseries/msi.c:478:7: error: implicit declaration of function 'is_kdump_kernel' [-Werror=implicit-function-declaration]
478 | if (is_kdump_kernel())
| ^~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/is_kdump_kernel +478 arch/powerpc/platforms/pseries/msi.c
369
370 static int rtas_setup_msi_irqs(struct pci_dev *pdev, int nvec_in, int type)
371 {
372 struct pci_dn *pdn;
373 int hwirq, virq, i, quota, rc;
374 struct msi_desc *entry;
375 struct msi_msg msg;
376 int nvec = nvec_in;
377 int use_32bit_msi_hack = 0;
378
379 if (type == PCI_CAP_ID_MSIX)
380 rc = check_req_msix(pdev, nvec);
381 else
382 rc = check_req_msi(pdev, nvec);
383
384 if (rc)
385 return rc;
386
387 quota = msi_quota_for_device(pdev, nvec);
388
389 if (quota && quota < nvec)
390 return quota;
391
392 if (type == PCI_CAP_ID_MSIX && check_msix_entries(pdev))
393 return -EINVAL;
394
395 /*
396 * Firmware currently refuse any non power of two allocation
397 * so we round up if the quota will allow it.
398 */
399 if (type == PCI_CAP_ID_MSIX) {
400 int m = roundup_pow_of_two(nvec);
401 quota = msi_quota_for_device(pdev, m);
402
403 if (quota >= m)
404 nvec = m;
405 }
406
407 pdn = pci_get_pdn(pdev);
408
409 /*
410 * Try the new more explicit firmware interface, if that fails fall
411 * back to the old interface. The old interface is known to never
412 * return MSI-Xs.
413 */
414 again:
415 if (type == PCI_CAP_ID_MSI) {
416 if (pdev->no_64bit_msi) {
417 rc = rtas_change_msi(pdn, RTAS_CHANGE_32MSI_FN, nvec);
418 if (rc < 0) {
419 /*
420 * We only want to run the 32 bit MSI hack below if
421 * the max bus speed is Gen2 speed
422 */
423 if (pdev->bus->max_bus_speed != PCIE_SPEED_5_0GT)
424 return rc;
425
426 use_32bit_msi_hack = 1;
427 }
428 } else
429 rc = -1;
430
431 if (rc < 0)
432 rc = rtas_change_msi(pdn, RTAS_CHANGE_MSI_FN, nvec);
433
434 if (rc < 0) {
435 pr_debug("rtas_msi: trying the old firmware call.\n");
436 rc = rtas_change_msi(pdn, RTAS_CHANGE_FN, nvec);
437 }
438
439 if (use_32bit_msi_hack && rc > 0)
440 rtas_hack_32bit_msi_gen2(pdev);
441 } else
442 rc = rtas_change_msi(pdn, RTAS_CHANGE_MSIX_FN, nvec);
443
444 if (rc != nvec) {
445 if (nvec != nvec_in) {
446 nvec = nvec_in;
447 goto again;
448 }
449 pr_debug("rtas_msi: rtas_change_msi() failed\n");
450 return rc;
451 }
452
453 i = 0;
454 for_each_pci_msi_entry(entry, pdev) {
455 hwirq = rtas_query_irq_number(pdn, i++);
456 if (hwirq < 0) {
457 pr_debug("rtas_msi: error (%d) getting hwirq\n", rc);
458 return hwirq;
459 }
460
461 /*
462 * Depending on the number of online CPUs in the original
463 * kernel, it is likely for CPU #0 to be offline in a kdump
464 * kernel. The associated IRQs in the affinity mappings
465 * provided by irq_create_affinity_masks() are thus not
466 * started by irq_startup(), as per-design for managed IRQs.
467 * This can be a problem with multi-queue block devices driven
468 * by blk-mq : such a non-started IRQ is very likely paired
469 * with the single queue enforced by blk-mq during kdump (see
470 * blk_mq_alloc_tag_set()). This causes the device to remain
471 * silent and likely hangs the guest at some point.
472 *
473 * We don't really care for fine-grained affinity when doing
474 * kdump actually : simply ignore the pre-computed affinity
475 * masks in this case and let the default mask with all CPUs
476 * be used when creating the IRQ mappings.
477 */
> 478 if (is_kdump_kernel())
479 virq = irq_create_mapping(NULL, hwirq);
480 else
481 virq = irq_create_mapping_affinity(NULL, hwirq,
482 entry->affinity);
483
484 if (!virq) {
485 pr_debug("rtas_msi: Failed mapping hwirq %d\n", hwirq);
486 return -ENOSPC;
487 }
488
489 dev_dbg(&pdev->dev, "rtas_msi: allocated virq %d\n", virq);
490 irq_set_msi_desc(virq, entry);
491
492 /* Read config space back so we can restore after reset */
493 __pci_read_msi_msg(entry, &msg);
494 entry->msg = msg;
495 }
496
497 return 0;
498 }
499
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
drivers/accessibility/speakup/serialio.c:48:19: warning: variable 'quot' set but not used
by kernel test robot
Hi Samuel,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: dcc0b49040c70ad827a7f3d58a21b01fdb14e749
commit: 2067fd92d75b6d9085a43caf050bca5d88c491b8 staging/speakup: Move out of staging
date: 7 months ago
config: parisc-randconfig-r025-20210212 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 2067fd92d75b6d9085a43caf050bca5d88c491b8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/accessibility/speakup/serialio.c: In function 'spk_serial_init':
>> drivers/accessibility/speakup/serialio.c:48:19: warning: variable 'quot' set but not used [-Wunused-but-set-variable]
48 | int baud = 9600, quot = 0;
| ^~~~
drivers/accessibility/speakup/serialio.c: In function 'spk_serial_tiocmset':
drivers/accessibility/speakup/serialio.c:165:6: warning: unused variable 'old' [-Wunused-variable]
165 | int old = inb(speakup_info.port_tts + UART_MCR);
| ^~~
vim +/quot +48 drivers/accessibility/speakup/serialio.c
1e441594e509c3 drivers/staging/speakup/serialio.c Okash Khawaja 2017-03-14 45
3ee0017e03cd79 drivers/staging/speakup/serialio.c Jiri Slaby 2012-03-05 46 const struct old_serial_port *spk_serial_init(int index)
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 47 {
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 @48 int baud = 9600, quot = 0;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 49 unsigned int cval = 0;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 50 int cflag = CREAD | HUPCL | CLOCAL | B9600 | CS8;
327b882d3bcc1f drivers/staging/speakup/serialio.c Samuel Thibault 2016-01-15 51 const struct old_serial_port *ser;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 52 int err;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 53
327b882d3bcc1f drivers/staging/speakup/serialio.c Samuel Thibault 2016-01-15 54 if (index >= ARRAY_SIZE(rs_table)) {
327b882d3bcc1f drivers/staging/speakup/serialio.c Samuel Thibault 2016-01-15 55 pr_info("no port info for ttyS%d\n", index);
327b882d3bcc1f drivers/staging/speakup/serialio.c Samuel Thibault 2016-01-15 56 return NULL;
327b882d3bcc1f drivers/staging/speakup/serialio.c Samuel Thibault 2016-01-15 57 }
327b882d3bcc1f drivers/staging/speakup/serialio.c Samuel Thibault 2016-01-15 58 ser = rs_table + index;
327b882d3bcc1f drivers/staging/speakup/serialio.c Samuel Thibault 2016-01-15 59
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 60 /* Divisor, bytesize and parity */
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 61 quot = ser->baud_base / baud;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 62 cval = cflag & (CSIZE | CSTOPB);
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 63 #if defined(__powerpc__) || defined(__alpha__)
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 64 cval >>= 8;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 65 #else /* !__powerpc__ && !__alpha__ */
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 66 cval >>= 4;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 67 #endif /* !__powerpc__ && !__alpha__ */
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 68 if (cflag & PARENB)
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 69 cval |= UART_LCR_PARITY;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 70 if (!(cflag & PARODD))
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 71 cval |= UART_LCR_EPAR;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 72 if (synth_request_region(ser->port, 8)) {
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 73 /* try to take it back. */
3a046c19158e89 drivers/staging/speakup/serialio.c Keerthimai Janarthanan 2014-03-18 74 pr_info("Ports not available, trying to steal them\n");
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 75 __release_region(&ioport_resource, ser->port, 8);
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 76 err = synth_request_region(ser->port, 8);
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 77 if (err) {
3ee0017e03cd79 drivers/staging/speakup/serialio.c Jiri Slaby 2012-03-05 78 pr_warn("Unable to allocate port at %x, errno %i",
baf9ac9ff8864c drivers/staging/speakup/serialio.c William Hubbs 2010-10-15 79 ser->port, err);
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 80 return NULL;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 81 }
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 82 }
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 83
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 84 /* Disable UART interrupts, set DTR and RTS high
13d825edd4441d drivers/staging/speakup/serialio.c Aleksei Fedotov 2015-08-14 85 * and set speed.
13d825edd4441d drivers/staging/speakup/serialio.c Aleksei Fedotov 2015-08-14 86 */
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 87 outb(cval | UART_LCR_DLAB, ser->port + UART_LCR); /* set DLAB */
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 88 outb(quot & 0xff, ser->port + UART_DLL); /* LS of divisor */
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 89 outb(quot >> 8, ser->port + UART_DLM); /* MS of divisor */
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 90 outb(cval, ser->port + UART_LCR); /* reset DLAB */
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 91
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 92 /* Turn off Interrupts */
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 93 outb(0, ser->port + UART_IER);
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 94 outb(UART_MCR_DTR | UART_MCR_RTS, ser->port + UART_MCR);
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 95
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 96 /* If we read 0xff from the LSR, there is no UART here. */
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 97 if (inb(ser->port + UART_LSR) == 0xff) {
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 98 synth_release_region(ser->port, 8);
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 99 serstate = NULL;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 100 return NULL;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 101 }
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 102
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 103 mdelay(1);
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 104 speakup_info.port_tts = ser->port;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 105 serstate = ser;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 106
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 107 start_serial_interrupt(ser->irq);
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 108
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 109 return ser;
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 110 }
c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs 2010-10-07 111
:::::: The code at line 48 was first introduced by commit
:::::: c6e3fd22cd538365bfeb82997d5b89562e077d42 Staging: add speakup to the staging directory
:::::: TO: William Hubbs <w.d.hubbs(a)gmail.com>
:::::: CC: Greg Kroah-Hartman <gregkh(a)suse.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months