Re: [PATCH v5 4/6] dm: new ioctl DM_DEV_REMAP_CMD
by kernel test robot
Hi Sergei,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on lwn/docs-next]
[also build test ERROR on linus/master v5.11-rc7 next-20210125]
[cannot apply to dm/for-next block/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sergei-Shtepa/block-layer-interp...
base: git://git.lwn.net/linux-2.6 docs-next
config: x86_64-rhel-8.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/2dbb264e739c9f95b90e4ea2a0cdb5d87...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sergei-Shtepa/block-layer-interposer/20210209-223704
git checkout 2dbb264e739c9f95b90e4ea2a0cdb5d874628746
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the linux-review/Sergei-Shtepa/block-layer-interposer/20210209-223704 HEAD a0be3a113742b603fe383ca9a97978f9815a8283 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/md/dm.c: In function 'open_table_device':
>> drivers/md/dm.c:1108:12: error: 'struct dm_dev' has no member named 'non_exclusive'
1108 | td->dm_dev.non_exclusive = non_exclusive;
| ^
drivers/md/dm.c: In function 'dm_get_table_device':
>> drivers/md/dm.c:1157:12: error: too few arguments to function 'open_table_device'
1157 | if ((r = open_table_device(td, dev, md))) {
| ^~~~~~~~~~~~~~~~~
drivers/md/dm.c:1079:12: note: declared here
1079 | static int open_table_device(struct table_device *td, dev_t dev,
| ^~~~~~~~~~~~~~~~~
vim +1108 drivers/md/dm.c
1075
1076 /*
1077 * Open a table device so we can use it as a map destination.
1078 */
1079 static int open_table_device(struct table_device *td, dev_t dev,
1080 struct mapped_device *md, bool non_exclusive)
1081 {
1082 struct block_device *bdev;
1083 int ret;
1084
1085 BUG_ON(td->dm_dev.bdev);
1086
1087 if (non_exclusive)
1088 bdev = blkdev_get_by_dev(dev, td->dm_dev.mode, NULL);
1089 else
1090 bdev = blkdev_get_by_dev(dev, td->dm_dev.mode | FMODE_EXCL, _dm_claim_ptr);
1091
1092 if (IS_ERR(bdev)) {
1093 ret = PTR_ERR(bdev);
1094 if (ret != -EBUSY)
1095 return ret;
1096 }
1097
1098 if (!non_exclusive) {
1099 ret = bd_link_disk_holder(bdev, dm_disk(md));
1100 if (ret) {
1101 blkdev_put(bdev, td->dm_dev.mode);
1102 return ret;
1103 }
1104 }
1105
1106 td->dm_dev.bdev = bdev;
1107 td->dm_dev.dax_dev = dax_get_by_host(bdev->bd_disk->disk_name);
> 1108 td->dm_dev.non_exclusive = non_exclusive;
1109 return 0;
1110 }
1111
1112 /*
1113 * Close a table device that we've been using.
1114 */
1115 static void close_table_device(struct table_device *td, struct mapped_device *md)
1116 {
1117 if (!td->dm_dev.bdev)
1118 return;
1119
1120 bd_unlink_disk_holder(td->dm_dev.bdev, dm_disk(md));
1121 blkdev_put(td->dm_dev.bdev, td->dm_dev.mode | FMODE_EXCL);
1122 put_dax(td->dm_dev.dax_dev);
1123 td->dm_dev.bdev = NULL;
1124 td->dm_dev.dax_dev = NULL;
1125 }
1126
1127 static struct table_device *find_table_device(struct list_head *l, dev_t dev,
1128 fmode_t mode)
1129 {
1130 struct table_device *td;
1131
1132 list_for_each_entry(td, l, list)
1133 if (td->dm_dev.bdev->bd_dev == dev && td->dm_dev.mode == mode)
1134 return td;
1135
1136 return NULL;
1137 }
1138
1139 int dm_get_table_device(struct mapped_device *md, dev_t dev, fmode_t mode,
1140 struct dm_dev **result)
1141 {
1142 int r;
1143 struct table_device *td;
1144
1145 mutex_lock(&md->table_devices_lock);
1146 td = find_table_device(&md->table_devices, dev, mode);
1147 if (!td) {
1148 td = kmalloc_node(sizeof(*td), GFP_KERNEL, md->numa_node_id);
1149 if (!td) {
1150 mutex_unlock(&md->table_devices_lock);
1151 return -ENOMEM;
1152 }
1153
1154 td->dm_dev.mode = mode;
1155 td->dm_dev.bdev = NULL;
1156
> 1157 if ((r = open_table_device(td, dev, md))) {
1158 mutex_unlock(&md->table_devices_lock);
1159 kfree(td);
1160 return r;
1161 }
1162
1163 format_dev_t(td->dm_dev.name, dev);
1164
1165 refcount_set(&td->count, 1);
1166 list_add(&td->list, &md->table_devices);
1167 } else {
1168 refcount_inc(&td->count);
1169 }
1170 mutex_unlock(&md->table_devices_lock);
1171
1172 *result = &td->dm_dev;
1173 return 0;
1174 }
1175 EXPORT_SYMBOL_GPL(dm_get_table_device);
1176
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[kbuild] [dhowells-fs:keys-intercept 20/21] kernel/pid_namespace.c:120 create_pid_namespace() warn: passing zero to 'ERR_PTR'
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git keys-intercept
head: c851eb7ccfe5790cf61e58980a4020a7515fdac0
commit: eff294a56406acb033f57450097c21dd5177de6d [20/21] Add namespace tags that can be used for matching without pinning a ns
config: i386-randconfig-m021-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
kernel/pid_namespace.c:120 create_pid_namespace() warn: passing zero to 'ERR_PTR'
vim +/ERR_PTR +120 kernel/pid_namespace.c
49f4d8b93ccf94 Eric W. Biederman 2012-08-02 70 static struct pid_namespace *create_pid_namespace(struct user_namespace *user_ns,
49f4d8b93ccf94 Eric W. Biederman 2012-08-02 71 struct pid_namespace *parent_pid_ns)
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 72 {
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 73 struct pid_namespace *ns;
ed469a63c37a99 Alexey Dobriyan 2009-06-17 74 unsigned int level = parent_pid_ns->level + 1;
f333c700c6100b Eric W. Biederman 2016-08-08 75 struct ucounts *ucounts;
f2302505775fd1 Andrew Vagin 2012-10-25 76 int err;
f2302505775fd1 Andrew Vagin 2012-10-25 77
a2b426267c5677 Eric W. Biederman 2017-04-29 78 err = -EINVAL;
a2b426267c5677 Eric W. Biederman 2017-04-29 79 if (!in_userns(parent_pid_ns->user_ns, user_ns))
a2b426267c5677 Eric W. Biederman 2017-04-29 80 goto out;
a2b426267c5677 Eric W. Biederman 2017-04-29 81
df75e7748bae1c Eric W. Biederman 2016-09-22 82 err = -ENOSPC;
f333c700c6100b Eric W. Biederman 2016-08-08 83 if (level > MAX_PID_NS_LEVEL)
f333c700c6100b Eric W. Biederman 2016-08-08 84 goto out;
f333c700c6100b Eric W. Biederman 2016-08-08 85 ucounts = inc_pid_namespaces(user_ns);
f333c700c6100b Eric W. Biederman 2016-08-08 86 if (!ucounts)
f2302505775fd1 Andrew Vagin 2012-10-25 87 goto out;
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 88
f2302505775fd1 Andrew Vagin 2012-10-25 89 err = -ENOMEM;
84406c153a5bfa Pavel Emelyanov 2008-07-25 90 ns = kmem_cache_zalloc(pid_ns_cachep, GFP_KERNEL);
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 91 if (ns == NULL)
f333c700c6100b Eric W. Biederman 2016-08-08 92 goto out_dec;
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 93
95846ecf9dac50 Gargi Sharma 2017-11-17 94 idr_init(&ns->idr);
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 95
eff294a56406ac David Howells 2021-02-04 96 err = init_ns_common(&ns->ns, false);
98f842e675f96f Eric W. Biederman 2011-06-15 97 if (err)
eff294a56406ac David Howells 2021-02-04 98 goto out_free;
33c429405a2c8d Al Viro 2014-11-01 99 ns->ns.ops = &pidns_operations;
98f842e675f96f Eric W. Biederman 2011-06-15 100
eff294a56406ac David Howells 2021-02-04 101 ns->pid_cachep = create_pid_cachep(level);
eff294a56406ac David Howells 2021-02-04 102 if (ns->pid_cachep == NULL)
eff294a56406ac David Howells 2021-02-04 103 goto out_free;
"err" not set on this path.
eff294a56406ac David Howells 2021-02-04 104
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 105 ns->level = level;
ed469a63c37a99 Alexey Dobriyan 2009-06-17 106 ns->parent = get_pid_ns(parent_pid_ns);
49f4d8b93ccf94 Eric W. Biederman 2012-08-02 107 ns->user_ns = get_user_ns(user_ns);
f333c700c6100b Eric W. Biederman 2016-08-08 108 ns->ucounts = ucounts;
e8cfbc245e2488 Gargi Sharma 2017-11-17 109 ns->pid_allocated = PIDNS_ADDING;
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 110
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 111 return ns;
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 112
eff294a56406ac David Howells 2021-02-04 113 out_free:
95846ecf9dac50 Gargi Sharma 2017-11-17 114 idr_destroy(&ns->idr);
eff294a56406ac David Howells 2021-02-04 115 destroy_ns_common(&ns->ns);
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 116 kmem_cache_free(pid_ns_cachep, ns);
f333c700c6100b Eric W. Biederman 2016-08-08 117 out_dec:
f333c700c6100b Eric W. Biederman 2016-08-08 118 dec_pid_namespaces(ucounts);
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 119 out:
4308eebbeb2026 Eric W. Biederman 2011-03-23 @120 return ERR_PTR(err);
74bd59bb39eb08 Pavel Emelyanov 2008-02-08 121 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
1 year, 7 months
Re: [PATCH v2 6/7] ASoC: codec: lpass-tx-macro: add support for lpass tx macro
by kernel test robot
Hi Srinivas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on v5.11-rc7 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Srinivas-Kandagatla/ASoC-codecs-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: ia64-randconfig-r013-20210209 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4d44cfba08462d518a10d9d335287b19c...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Srinivas-Kandagatla/ASoC-codecs-add-support-for-LPASS-Codec-TX-and-RX-macros/20210209-084643
git checkout 4d44cfba08462d518a10d9d335287b19c2cbff02
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
sound/soc/codecs/lpass-tx-macro.c: In function 'tx_macro_tx_hpf_corner_freq_callback':
>> sound/soc/codecs/lpass-tx-macro.c:656:15: warning: variable 'adc_n' set but not used [-Wunused-but-set-variable]
656 | u16 adc_reg, adc_n;
| ^~~~~
vim +/adc_n +656 sound/soc/codecs/lpass-tx-macro.c
647
648 static void tx_macro_tx_hpf_corner_freq_callback(struct work_struct *work)
649 {
650 struct delayed_work *hpf_delayed_work;
651 struct hpf_work *hpf_work;
652 struct tx_macro *tx;
653 struct snd_soc_component *component;
654 u16 dec_cfg_reg, hpf_gate_reg;
655 u8 hpf_cut_off_freq;
> 656 u16 adc_reg, adc_n;
657
658 hpf_delayed_work = to_delayed_work(work);
659 hpf_work = container_of(hpf_delayed_work, struct hpf_work, dwork);
660 tx = hpf_work->tx;
661 component = tx->component;
662 hpf_cut_off_freq = hpf_work->hpf_cut_off_freq;
663
664 dec_cfg_reg = CDC_TXn_TX_PATH_CFG0(hpf_work->decimator);
665 hpf_gate_reg = CDC_TXn_TX_PATH_SEC2(hpf_work->decimator);
666
667 if (is_amic_enabled(component, hpf_work->decimator)) {
668 adc_reg = CDC_TX_INP_MUX_ADC_MUXn_CFG0(hpf_work->decimator);
669 adc_n = snd_soc_component_read(component, adc_reg) &
670 CDC_TX_MACRO_SWR_MIC_MUX_SEL_MASK;
671 /* analog mic clear TX hold */
672 snd_soc_component_write_field(component,
673 dec_cfg_reg,
674 CDC_TXn_HPF_CUT_FREQ_MASK,
675 hpf_cut_off_freq);
676 snd_soc_component_update_bits(component, hpf_gate_reg,
677 CDC_TXn_HPF_F_CHANGE_MASK |
678 CDC_TXn_HPF_ZERO_GATE_MASK,
679 0x02);
680 snd_soc_component_update_bits(component, hpf_gate_reg,
681 CDC_TXn_HPF_F_CHANGE_MASK |
682 CDC_TXn_HPF_ZERO_GATE_MASK,
683 0x01);
684 } else {
685 snd_soc_component_write_field(component, dec_cfg_reg,
686 CDC_TXn_HPF_CUT_FREQ_MASK,
687 hpf_cut_off_freq);
688 snd_soc_component_write_field(component, hpf_gate_reg,
689 CDC_TXn_HPF_F_CHANGE_MASK, 0x1);
690 /* Minimum 1 clk cycle delay is required as per HW spec */
691 usleep_range(1000, 1010);
692 snd_soc_component_write_field(component, hpf_gate_reg,
693 CDC_TXn_HPF_F_CHANGE_MASK, 0x0);
694 }
695 }
696
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[pci:pci/error 2/8] drivers/pci/controller/../pci.h:348:20: warning: equality comparison result unused
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/error
head: 5692817fc88f347328e35cd7b19bd04f4400652e
commit: 8fae7d8809b8151488969d6cfad2f6dd2c69d311 [2/8] PCI/ERR: Simplify pci_dev_set_io_state()
config: arm64-randconfig-r025-20210209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?i...
git remote add pci https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
git fetch --no-tags pci pci/error
git checkout 8fae7d8809b8151488969d6cfad2f6dd2c69d311
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/pci/controller/pci-ftpci100.c:31:
>> drivers/pci/controller/../pci.h:348:20: warning: equality comparison result unused [-Wunused-comparison]
dev->error_state == pci_channel_io_perm_failure;
~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/controller/../pci.h:348:20: note: use '=' to turn this equality comparison into an assignment
dev->error_state == pci_channel_io_perm_failure;
^~
=
1 warning generated.
--
In file included from drivers/pci/pcie/aspm.c:21:
>> drivers/pci/pcie/../pci.h:348:20: warning: equality comparison result unused [-Wunused-comparison]
dev->error_state == pci_channel_io_perm_failure;
~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/pcie/../pci.h:348:20: note: use '=' to turn this equality comparison into an assignment
dev->error_state == pci_channel_io_perm_failure;
^~
=
1 warning generated.
--
In file included from drivers/pci/controller/dwc/pcie-designware.c:16:
>> drivers/pci/controller/dwc/../../pci.h:348:20: warning: equality comparison result unused [-Wunused-comparison]
dev->error_state == pci_channel_io_perm_failure;
~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/controller/dwc/../../pci.h:348:20: note: use '=' to turn this equality comparison into an assignment
dev->error_state == pci_channel_io_perm_failure;
^~
=
1 warning generated.
vim +348 drivers/pci/controller/../pci.h
330
331 /**
332 * pci_dev_set_io_state - Set the new error state if possible.
333 *
334 * @dev - pci device to set new error_state
335 * @new - the state we want dev to be in
336 *
337 * Must be called with device_lock held.
338 *
339 * Returns true if state has been changed to the requested state.
340 */
341 static inline bool pci_dev_set_io_state(struct pci_dev *dev,
342 pci_channel_state_t new)
343 {
344 device_lock_assert(&dev->dev);
345
346 /* Can always put a device in perm_failure state */
347 if (new == pci_channel_io_perm_failure) {
> 348 dev->error_state == pci_channel_io_perm_failure;
349 return true;
350 }
351
352 /* If already in perm_failure, can't set to normal or frozen */
353 if (dev->error_state == pci_channel_io_perm_failure)
354 return false;
355
356 /* Can always change normal to frozen or vice versa */
357 dev->error_state = new;
358 return true;
359 }
360
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [linux-next:master 5983/6048] h8300-linux-ld: section .data VMA overlaps section __kcrctab VMA
by Rong Chen
On 2/10/21 2:21 AM, Paul Moore wrote:
> On Tue, Feb 9, 2021 at 1:09 PM kernel test robot <lkp(a)intel.com> wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head: 59fa6a163ffabc1bf25c5e0e33899e268a96d3cc
>> commit: 77d8143a5290b38e3331f61f55c0b682699884bc [5983/6048] Merge remote-tracking branch 'selinux/next'
>> config: h8300-randconfig-r005-20210209 (attached as .config)
>> compiler: h8300-linux-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
>> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>> git fetch --no-tags linux-next master
>> git checkout 77d8143a5290b38e3331f61f55c0b682699884bc
>> # save the attached .config to linux build tree
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp(a)intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>> h8300-linux-ld: section .init.text LMA [0000000000430360,00000000004479a1] overlaps section .data LMA [000000000041868c,00000000004489eb]
>>>> h8300-linux-ld: section .data VMA [0000000000400000,000000000043035f] overlaps section __kcrctab VMA [00000000003fdd74,000000000040007b]
>>>> h8300-linux-ld: section __kcrctab_gpl VMA [000000000040007c,00000000004025a7] overlaps section .data VMA [0000000000400000,000000000043035f]
>> h8300-linux-ld: arch/h8300/kernel/entry.o: in function `resume_kernel':
>> (.text+0x29a): undefined reference to `TI_PRE_COUNT'
> This really doesn't look like something caused by SELinux ...
>
Hi Paul,
Thanks for the feedback, we'll take a look.
Best Regards,
Rong Chen
1 year, 7 months
[chao-linux:simple_copy 5/5] fs/f2fs/node.c:1526:6: warning: variable 'ret' set but not used
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git simple_copy
head: d6f32b90156624ae9dc06ef5873334a48e9b9806
commit: d6f32b90156624ae9dc06ef5873334a48e9b9806 [5/5] f2fs: use BLK_COPY ioctl for gc.
config: xtensa-randconfig-r004-20210209 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/commit/?id...
git remote add chao-linux https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git
git fetch --no-tags chao-linux simple_copy
git checkout d6f32b90156624ae9dc06ef5873334a48e9b9806
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
fs/f2fs/node.c: In function '__write_node_page':
>> fs/f2fs/node.c:1526:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
1526 | int ret = 0;
| ^~~
vim +/ret +1526 fs/f2fs/node.c
1505
1506 static int __write_node_page(struct page *page, bool atomic, bool *submitted,
1507 struct writeback_control *wbc, bool do_balance,
1508 enum iostat_type io_type, unsigned int *seq_id, int do_copy)
1509 {
1510 struct f2fs_sb_info *sbi = F2FS_P_SB(page);
1511 nid_t nid;
1512 struct node_info ni;
1513 struct f2fs_io_info fio = {
1514 .sbi = sbi,
1515 .ino = ino_of_node(page),
1516 .type = NODE,
1517 .op = REQ_OP_WRITE,
1518 .op_flags = wbc_to_write_flags(wbc),
1519 .page = page,
1520 .encrypted_page = NULL,
1521 .submitted = false,
1522 .io_type = io_type,
1523 .io_wbc = wbc,
1524 };
1525 unsigned int seq;
> 1526 int ret = 0;
1527
1528 trace_f2fs_writepage(page, NODE);
1529
1530 if (unlikely(f2fs_cp_error(sbi))) {
1531 if (is_sbi_flag_set(sbi, SBI_IS_CLOSE)) {
1532 ClearPageUptodate(page);
1533 dec_page_count(sbi, F2FS_DIRTY_NODES);
1534 unlock_page(page);
1535 return 0;
1536 }
1537 goto redirty_out;
1538 }
1539
1540 if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING)))
1541 goto redirty_out;
1542
1543 if (!is_sbi_flag_set(sbi, SBI_CP_DISABLED) &&
1544 wbc->sync_mode == WB_SYNC_NONE &&
1545 IS_DNODE(page) && is_cold_node(page))
1546 goto redirty_out;
1547
1548 /* get old block addr of this node page */
1549 nid = nid_of_node(page);
1550 f2fs_bug_on(sbi, page->index != nid);
1551
1552 if (f2fs_get_node_info(sbi, nid, &ni))
1553 goto redirty_out;
1554
1555 if (wbc->for_reclaim) {
1556 if (!down_read_trylock(&sbi->node_write))
1557 goto redirty_out;
1558 } else {
1559 down_read(&sbi->node_write);
1560 }
1561
1562 /* This page is already truncated */
1563 if (unlikely(ni.blk_addr == NULL_ADDR)) {
1564 ClearPageUptodate(page);
1565 dec_page_count(sbi, F2FS_DIRTY_NODES);
1566 up_read(&sbi->node_write);
1567 unlock_page(page);
1568 return 0;
1569 }
1570
1571 if (__is_valid_data_blkaddr(ni.blk_addr) &&
1572 !f2fs_is_valid_blkaddr(sbi, ni.blk_addr,
1573 DATA_GENERIC_ENHANCE)) {
1574 up_read(&sbi->node_write);
1575 goto redirty_out;
1576 }
1577
1578 if (atomic && !test_opt(sbi, NOBARRIER))
1579 fio.op_flags |= REQ_PREFLUSH | REQ_FUA;
1580
1581 /* should add to global list before clearing PAGECACHE status */
1582 if (f2fs_in_warm_node_list(sbi, page)) {
1583 seq = f2fs_add_fsync_node_entry(sbi, page);
1584 if (seq_id)
1585 *seq_id = seq;
1586 }
1587
1588 set_page_writeback(page);
1589 ClearPageError(page);
1590
1591 fio.old_blkaddr = ni.blk_addr;
1592 ret = f2fs_do_write_node_page(nid, &fio, do_copy);
1593 set_node_addr(sbi, &ni, fio.new_blkaddr, is_fsync_dnode(page));
1594 dec_page_count(sbi, F2FS_DIRTY_NODES);
1595 up_read(&sbi->node_write);
1596
1597 if (wbc->for_reclaim) {
1598 f2fs_submit_merged_write_cond(sbi, NULL, page, 0, NODE);
1599 submitted = NULL;
1600 }
1601
1602 unlock_page(page);
1603
1604 if (unlikely(f2fs_cp_error(sbi))) {
1605 f2fs_submit_merged_write(sbi, NODE);
1606 submitted = NULL;
1607 }
1608 if (submitted)
1609 *submitted = fio.submitted;
1610
1611 if (do_copy) {
1612 if (f2fs_in_warm_node_list(sbi, page))
1613 f2fs_del_fsync_node_entry(sbi, page);
1614 clear_cold_data(page);
1615 }
1616
1617 if (do_balance)
1618 f2fs_balance_fs(sbi, false);
1619 return 0;
1620
1621 redirty_out:
1622 redirty_page_for_writepage(wbc, page);
1623 return AOP_WRITEPAGE_ACTIVATE;
1624 }
1625
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[chunkuang.hu:mediatek-cmdq3 18/21] ERROR: modpost: "mtk_mutex_prepare" undefined!
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git mediatek-cmdq3
head: f437ef81a7d0ae27bc340382cdfe96228307d5bf
commit: 975dacd7c4d260adda0348a9f0227e50c16390a0 [18/21] soc / drm: mediatek: Move mtk mutex driver to soc folder
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/co...
git remote add chunkuang.hu https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git
git fetch --no-tags chunkuang.hu mediatek-cmdq3
git checkout 975dacd7c4d260adda0348a9f0227e50c16390a0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> ERROR: modpost: "mtk_mutex_prepare" [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>> ERROR: modpost: "mtk_mutex_get" [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>> ERROR: modpost: "mtk_mutex_enable" [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>> ERROR: modpost: "mtk_mutex_acquire" [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>> ERROR: modpost: "mtk_mutex_unprepare" [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>> ERROR: modpost: "mtk_mutex_release" [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>> ERROR: modpost: "mtk_mutex_put" [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>> ERROR: modpost: "mtk_mutex_disable" [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>> ERROR: modpost: "mtk_mutex_remove_comp" [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
>> ERROR: modpost: "mtk_mutex_add_comp" [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined!
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[pci:pci/error 2/8] arch/powerpc/platforms/powernv/../../../../drivers/pci/pci.h:348:20: error: statement with no effect
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/error
head: 5692817fc88f347328e35cd7b19bd04f4400652e
commit: 8fae7d8809b8151488969d6cfad2f6dd2c69d311 [2/8] PCI/ERR: Simplify pci_dev_set_io_state()
config: powerpc-pseries_defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?i...
git remote add pci https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
git fetch --no-tags pci pci/error
git checkout 8fae7d8809b8151488969d6cfad2f6dd2c69d311
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/powerpc/platforms/powernv/pci-ioda.c:44:
arch/powerpc/platforms/powernv/../../../../drivers/pci/pci.h: In function 'pci_dev_set_io_state':
>> arch/powerpc/platforms/powernv/../../../../drivers/pci/pci.h:348:20: error: statement with no effect [-Werror=unused-value]
348 | dev->error_state == pci_channel_io_perm_failure;
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from arch/powerpc/platforms/pseries/setup.c:76:
arch/powerpc/platforms/pseries/../../../../drivers/pci/pci.h: In function 'pci_dev_set_io_state':
>> arch/powerpc/platforms/pseries/../../../../drivers/pci/pci.h:348:20: error: statement with no effect [-Werror=unused-value]
348 | dev->error_state == pci_channel_io_perm_failure;
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +348 arch/powerpc/platforms/powernv/../../../../drivers/pci/pci.h
330
331 /**
332 * pci_dev_set_io_state - Set the new error state if possible.
333 *
334 * @dev - pci device to set new error_state
335 * @new - the state we want dev to be in
336 *
337 * Must be called with device_lock held.
338 *
339 * Returns true if state has been changed to the requested state.
340 */
341 static inline bool pci_dev_set_io_state(struct pci_dev *dev,
342 pci_channel_state_t new)
343 {
344 device_lock_assert(&dev->dev);
345
346 /* Can always put a device in perm_failure state */
347 if (new == pci_channel_io_perm_failure) {
> 348 dev->error_state == pci_channel_io_perm_failure;
349 return true;
350 }
351
352 /* If already in perm_failure, can't set to normal or frozen */
353 if (dev->error_state == pci_channel_io_perm_failure)
354 return false;
355
356 /* Can always change normal to frozen or vice versa */
357 dev->error_state = new;
358 return true;
359 }
360
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months