Re: [PATCHSET 0/2] PF_IO_WORKER signal tweaks
by kernel test robot
Hi Jens,
I love your patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on tip/sched/core linus/master v5.12-rc3 next-20210319]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jens-Axboe/PF_IO_WORKER-signal-t...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a74e6a014c9d4d4161061f770c9b4f98372ac778
config: riscv-randconfig-r024-20210321 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 436c6c9c20cc522c92a923440a5fc509c342a7db)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/05c70f370b93f3bf555e63293d43a82aa...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jens-Axboe/PF_IO_WORKER-signal-tweaks/20210320-234247
git checkout 05c70f370b93f3bf555e63293d43a82aab2fcdf3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
In file included from drivers/ata/ahci.c:21:
In file included from include/linux/pci.h:1456:
In file included from include/linux/dmapool.h:14:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:707:
In file included from include/linux/huge_mm.h:8:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
>> include/linux/sched/signal.h:673:33: error: expected ';' after return statement
return p1->signal == p2->signal
^
;
drivers/ata/ahci.c:104:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
AHCI_SHT("ahci"),
^~~~~~~~~~~~~~~~
drivers/ata/ahci.h:387:16: note: expanded from macro 'AHCI_SHT'
.can_queue = AHCI_MAX_CMDS, \
^~~~~~~~~~~~~
drivers/ata/ahci.c:104:2: note: previous initialization is here
AHCI_SHT("ahci"),
^~~~~~~~~~~~~~~~
drivers/ata/ahci.h:386:2: note: expanded from macro 'AHCI_SHT'
ATA_NCQ_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1418:2: note: expanded from macro 'ATA_NCQ_SHT'
__ATA_BASE_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1400:16: note: expanded from macro '__ATA_BASE_SHT'
.can_queue = ATA_DEF_QUEUE, \
^~~~~~~~~~~~~
drivers/ata/ahci.c:104:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
AHCI_SHT("ahci"),
^~~~~~~~~~~~~~~~
drivers/ata/ahci.h:391:17: note: expanded from macro 'AHCI_SHT'
.sdev_attrs = ahci_sdev_attrs
^~~~~~~~~~~~~~~
drivers/ata/ahci.c:104:2: note: previous initialization is here
AHCI_SHT("ahci"),
^~~~~~~~~~~~~~~~
drivers/ata/ahci.h:386:2: note: expanded from macro 'AHCI_SHT'
ATA_NCQ_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1419:17: note: expanded from macro 'ATA_NCQ_SHT'
.sdev_attrs = ata_ncq_sdev_attrs, \
^~~~~~~~~~~~~~~~~~
2 warnings and 1 error generated.
--
In file included from drivers/ata/ahci_xgene.c:19:
In file included from include/linux/phy/phy.h:17:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:17:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
>> include/linux/sched/signal.h:673:33: error: expected ';' after return statement
return p1->signal == p2->signal
^
;
drivers/ata/ahci_xgene.c:718:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
AHCI_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:387:16: note: expanded from macro 'AHCI_SHT'
.can_queue = AHCI_MAX_CMDS, \
^~~~~~~~~~~~~
drivers/ata/ahci_xgene.c:718:2: note: previous initialization is here
AHCI_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:386:2: note: expanded from macro 'AHCI_SHT'
ATA_NCQ_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1418:2: note: expanded from macro 'ATA_NCQ_SHT'
__ATA_BASE_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1400:16: note: expanded from macro '__ATA_BASE_SHT'
.can_queue = ATA_DEF_QUEUE, \
^~~~~~~~~~~~~
drivers/ata/ahci_xgene.c:718:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
AHCI_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:391:17: note: expanded from macro 'AHCI_SHT'
.sdev_attrs = ahci_sdev_attrs
^~~~~~~~~~~~~~~
drivers/ata/ahci_xgene.c:718:2: note: previous initialization is here
AHCI_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:386:2: note: expanded from macro 'AHCI_SHT'
ATA_NCQ_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1419:17: note: expanded from macro 'ATA_NCQ_SHT'
.sdev_attrs = ata_ncq_sdev_attrs, \
^~~~~~~~~~~~~~~~~~
2 warnings and 1 error generated.
--
In file included from drivers/ata/libata-core.c:30:
In file included from include/linux/pci.h:1456:
In file included from include/linux/dmapool.h:14:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:707:
In file included from include/linux/huge_mm.h:8:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
>> include/linux/sched/signal.h:673:33: error: expected ';' after return statement
return p1->signal == p2->signal
^
;
1 error generated.
--
In file included from drivers/ata/acard-ahci.c:22:
In file included from include/linux/pci.h:1456:
In file included from include/linux/dmapool.h:14:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:707:
In file included from include/linux/huge_mm.h:8:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
>> include/linux/sched/signal.h:673:33: error: expected ';' after return statement
return p1->signal == p2->signal
^
;
drivers/ata/acard-ahci.c:70:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
AHCI_SHT("acard-ahci"),
^~~~~~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:387:16: note: expanded from macro 'AHCI_SHT'
.can_queue = AHCI_MAX_CMDS, \
^~~~~~~~~~~~~
drivers/ata/acard-ahci.c:70:2: note: previous initialization is here
AHCI_SHT("acard-ahci"),
^~~~~~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:386:2: note: expanded from macro 'AHCI_SHT'
ATA_NCQ_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1418:2: note: expanded from macro 'ATA_NCQ_SHT'
__ATA_BASE_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1400:16: note: expanded from macro '__ATA_BASE_SHT'
.can_queue = ATA_DEF_QUEUE, \
^~~~~~~~~~~~~
drivers/ata/acard-ahci.c:70:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
AHCI_SHT("acard-ahci"),
^~~~~~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:391:17: note: expanded from macro 'AHCI_SHT'
.sdev_attrs = ahci_sdev_attrs
^~~~~~~~~~~~~~~
drivers/ata/acard-ahci.c:70:2: note: previous initialization is here
AHCI_SHT("acard-ahci"),
^~~~~~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:386:2: note: expanded from macro 'AHCI_SHT'
ATA_NCQ_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1419:17: note: expanded from macro 'ATA_NCQ_SHT'
.sdev_attrs = ata_ncq_sdev_attrs, \
^~~~~~~~~~~~~~~~~~
2 warnings and 1 error generated.
--
In file included from drivers/ata/ahci_platform.c:17:
In file included from include/linux/libata.h:16:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:707:
In file included from include/linux/huge_mm.h:8:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
>> include/linux/sched/signal.h:673:33: error: expected ';' after return statement
return p1->signal == p2->signal
^
;
drivers/ata/ahci_platform.c:40:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
AHCI_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:387:16: note: expanded from macro 'AHCI_SHT'
.can_queue = AHCI_MAX_CMDS, \
^~~~~~~~~~~~~
drivers/ata/ahci_platform.c:40:2: note: previous initialization is here
AHCI_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:386:2: note: expanded from macro 'AHCI_SHT'
ATA_NCQ_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1418:2: note: expanded from macro 'ATA_NCQ_SHT'
__ATA_BASE_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1400:16: note: expanded from macro '__ATA_BASE_SHT'
.can_queue = ATA_DEF_QUEUE, \
^~~~~~~~~~~~~
drivers/ata/ahci_platform.c:40:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
AHCI_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:391:17: note: expanded from macro 'AHCI_SHT'
.sdev_attrs = ahci_sdev_attrs
^~~~~~~~~~~~~~~
drivers/ata/ahci_platform.c:40:2: note: previous initialization is here
AHCI_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:386:2: note: expanded from macro 'AHCI_SHT'
ATA_NCQ_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1419:17: note: expanded from macro 'ATA_NCQ_SHT'
.sdev_attrs = ata_ncq_sdev_attrs, \
^~~~~~~~~~~~~~~~~~
2 warnings and 1 error generated.
--
In file included from drivers/ata/libahci_platform.c:19:
In file included from include/linux/libata.h:16:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:707:
In file included from include/linux/huge_mm.h:8:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
>> include/linux/sched/signal.h:673:33: error: expected ';' after return statement
return p1->signal == p2->signal
^
;
>> drivers/ata/libahci_platform.c:644:42: warning: shift count >= width of type [-Wshift-count-overflow]
rc = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64));
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
1 warning and 1 error generated.
--
In file included from drivers/ata/sata_sil24.c:13:
In file included from include/linux/pci.h:1456:
In file included from include/linux/dmapool.h:14:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:707:
In file included from include/linux/huge_mm.h:8:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
>> include/linux/sched/signal.h:673:33: error: expected ';' after return statement
return p1->signal == p2->signal
^
;
drivers/ata/sata_sil24.c:378:16: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
.can_queue = SIL24_MAX_CMDS,
^~~~~~~~~~~~~~
drivers/ata/sata_sil24.c:377:2: note: previous initialization is here
ATA_NCQ_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1418:2: note: expanded from macro 'ATA_NCQ_SHT'
__ATA_BASE_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1400:16: note: expanded from macro '__ATA_BASE_SHT'
.can_queue = ATA_DEF_QUEUE, \
^~~~~~~~~~~~~
drivers/ata/sata_sil24.c:381:22: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
.tag_alloc_policy = BLK_TAG_ALLOC_FIFO,
^~~~~~~~~~~~~~~~~~
include/linux/blkdev.h:298:28: note: expanded from macro 'BLK_TAG_ALLOC_FIFO'
#define BLK_TAG_ALLOC_FIFO 0 /* allocate starting from 0 */
^
drivers/ata/sata_sil24.c:377:2: note: previous initialization is here
ATA_NCQ_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1418:2: note: expanded from macro 'ATA_NCQ_SHT'
__ATA_BASE_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1401:22: note: expanded from macro '__ATA_BASE_SHT'
.tag_alloc_policy = BLK_TAG_ALLOC_RR, \
^~~~~~~~~~~~~~~~
include/linux/blkdev.h:299:26: note: expanded from macro 'BLK_TAG_ALLOC_RR'
#define BLK_TAG_ALLOC_RR 1 /* allocate starting from last allocated tag */
^
>> drivers/ata/sata_sil24.c:1306:45: warning: shift count >= width of type [-Wshift-count-overflow]
rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
3 warnings and 1 error generated.
--
In file included from drivers/ata/ahci_ceva.c:11:
In file included from include/linux/libata.h:16:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:707:
In file included from include/linux/huge_mm.h:8:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
>> include/linux/sched/signal.h:673:33: error: expected ';' after return statement
return p1->signal == p2->signal
^
;
drivers/ata/ahci_ceva.c:187:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
AHCI_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:387:16: note: expanded from macro 'AHCI_SHT'
.can_queue = AHCI_MAX_CMDS, \
^~~~~~~~~~~~~
drivers/ata/ahci_ceva.c:187:2: note: previous initialization is here
AHCI_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:386:2: note: expanded from macro 'AHCI_SHT'
ATA_NCQ_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1418:2: note: expanded from macro 'ATA_NCQ_SHT'
__ATA_BASE_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1400:16: note: expanded from macro '__ATA_BASE_SHT'
.can_queue = ATA_DEF_QUEUE, \
^~~~~~~~~~~~~
drivers/ata/ahci_ceva.c:187:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
AHCI_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:391:17: note: expanded from macro 'AHCI_SHT'
.sdev_attrs = ahci_sdev_attrs
^~~~~~~~~~~~~~~
drivers/ata/ahci_ceva.c:187:2: note: previous initialization is here
AHCI_SHT(DRV_NAME),
^~~~~~~~~~~~~~~~~~
drivers/ata/ahci.h:386:2: note: expanded from macro 'AHCI_SHT'
ATA_NCQ_SHT(drv_name), \
^~~~~~~~~~~~~~~~~~~~~
include/linux/libata.h:1419:17: note: expanded from macro 'ATA_NCQ_SHT'
.sdev_attrs = ata_ncq_sdev_attrs, \
^~~~~~~~~~~~~~~~~~
2 warnings and 1 error generated.
..
vim +673 include/linux/sched/signal.h
669
670 static inline
671 bool same_thread_group_account(struct task_struct *p1, struct task_struct *p2)
672 {
> 673 return p1->signal == p2->signal
674 }
675
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
[sashal-linux-stable:queue-5.4 114/120] sound/pci/hda/patch_conexant.c:141:29: error: variable has incomplete type 'enum led_brightness'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-5.4
head: 4bd8020d6c753ab56df4d7bd75833fd880e1995a
commit: 98cf79c0d309e209ea168933479fef4be29ed58c [114/120] ALSA: hda/conexant: Use the new vmaster mute LED helper
config: x86_64-randconfig-a002-20210320 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 436c6c9c20cc522c92a923440a5fc509c342a7db)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable queue-5.4
git checkout 98cf79c0d309e209ea168933479fef4be29ed58c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
>> sound/pci/hda/patch_conexant.c:140:44: warning: declaration of 'struct led_classdev' will not be visible outside of this function [-Wvisibility]
static int cx_auto_vmaster_mute_led(struct led_classdev *led_cdev,
^
>> sound/pci/hda/patch_conexant.c:141:14: warning: declaration of 'enum led_brightness' will not be visible outside of this function [-Wvisibility]
enum led_brightness brightness)
^
>> sound/pci/hda/patch_conexant.c:141:29: error: variable has incomplete type 'enum led_brightness'
enum led_brightness brightness)
^
sound/pci/hda/patch_conexant.c:141:14: note: forward declaration of 'enum led_brightness'
enum led_brightness brightness)
^
>> sound/pci/hda/patch_conexant.c:143:53: error: incomplete definition of type 'struct led_classdev'
struct hda_codec *codec = dev_to_hda_codec(led_cdev->dev->parent);
~~~~~~~~^
include/sound/hda_codec.h:289:45: note: expanded from macro 'dev_to_hda_codec'
#define dev_to_hda_codec(_dev) container_of(_dev, struct hda_codec, core.dev)
^~~~
include/linux/kernel.h:993:26: note: expanded from macro 'container_of'
void *__mptr = (void *)(ptr); \
^~~
sound/pci/hda/patch_conexant.c:140:44: note: forward declaration of 'struct led_classdev'
static int cx_auto_vmaster_mute_led(struct led_classdev *led_cdev,
^
>> sound/pci/hda/patch_conexant.c:143:53: error: incomplete definition of type 'struct led_classdev'
struct hda_codec *codec = dev_to_hda_codec(led_cdev->dev->parent);
~~~~~~~~^
include/sound/hda_codec.h:289:45: note: expanded from macro 'dev_to_hda_codec'
#define dev_to_hda_codec(_dev) container_of(_dev, struct hda_codec, core.dev)
^~~~
include/linux/kernel.h:994:34: note: expanded from macro 'container_of'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^~~
include/linux/compiler_types.h:220:63: note: expanded from macro '__same_type'
#define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
^
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
include/linux/compiler.h:417:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler.h:405:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler.h:397:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
sound/pci/hda/patch_conexant.c:140:44: note: forward declaration of 'struct led_classdev'
static int cx_auto_vmaster_mute_led(struct led_classdev *led_cdev,
^
>> sound/pci/hda/patch_conexant.c:143:53: error: incomplete definition of type 'struct led_classdev'
struct hda_codec *codec = dev_to_hda_codec(led_cdev->dev->parent);
~~~~~~~~^
include/sound/hda_codec.h:289:45: note: expanded from macro 'dev_to_hda_codec'
#define dev_to_hda_codec(_dev) container_of(_dev, struct hda_codec, core.dev)
^~~~
include/linux/kernel.h:995:20: note: expanded from macro 'container_of'
!__same_type(*(ptr), void), \
^~~
include/linux/compiler_types.h:220:63: note: expanded from macro '__same_type'
#define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
^
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
include/linux/compiler.h:417:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler.h:405:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler.h:397:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
sound/pci/hda/patch_conexant.c:140:44: note: forward declaration of 'struct led_classdev'
static int cx_auto_vmaster_mute_led(struct led_classdev *led_cdev,
^
>> sound/pci/hda/patch_conexant.c:571:3: error: implicit declaration of function 'snd_hda_gen_add_mute_led_cdev' [-Werror,-Wimplicit-function-declaration]
snd_hda_gen_add_mute_led_cdev(codec, cx_auto_vmaster_mute_led);
^
sound/pci/hda/patch_conexant.c:571:3: note: did you mean 'snd_hda_gen_add_micmute_led'?
sound/pci/hda/hda_generic.h:357:5: note: 'snd_hda_gen_add_micmute_led' declared here
int snd_hda_gen_add_micmute_led(struct hda_codec *codec,
^
sound/pci/hda/patch_conexant.c:669:3: error: implicit declaration of function 'snd_hda_gen_add_mute_led_cdev' [-Werror,-Wimplicit-function-declaration]
snd_hda_gen_add_mute_led_cdev(codec, cxt_gpio_mute_update);
^
sound/pci/hda/patch_conexant.c:674:3: error: implicit declaration of function 'snd_hda_gen_add_micmute_led_cdev' [-Werror,-Wimplicit-function-declaration]
snd_hda_gen_add_micmute_led_cdev(codec, cxt_gpio_micmute_update);
^
sound/pci/hda/patch_conexant.c:674:3: note: did you mean 'snd_hda_gen_add_mute_led_cdev'?
sound/pci/hda/patch_conexant.c:571:3: note: 'snd_hda_gen_add_mute_led_cdev' declared here
snd_hda_gen_add_mute_led_cdev(codec, cx_auto_vmaster_mute_led);
^
2 warnings and 7 errors generated.
vim +141 sound/pci/hda/patch_conexant.c
138
139 /* turn on/off EAPD according to Master switch (inversely!) for mute LED */
> 140 static int cx_auto_vmaster_mute_led(struct led_classdev *led_cdev,
> 141 enum led_brightness brightness)
142 {
> 143 struct hda_codec *codec = dev_to_hda_codec(led_cdev->dev->parent);
144 struct conexant_spec *spec = codec->spec;
145
146 snd_hda_codec_write(codec, spec->mute_led_eapd, 0,
147 AC_VERB_SET_EAPD_BTLENABLE,
148 brightness ? 0x02 : 0x00);
149 return 0;
150 }
151
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
[arnd-playground:pci-probe-rework-20210320 21/24] arch/powerpc/kernel/pci-common.c:1666:6: error: no previous prototype for 'pci_scan_host_bridge'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git pci-probe-rework-20210320
head: 7339be76e8b2bf033b46af22922fd3ab88c122d2
commit: 3b0acc0ac3c7dc0ecb99215c7eb87a41a4acd79f [21/24] powerpc: rework PCI host allocation
config: powerpc-mgcoge_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/commi...
git remote add arnd-playground https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git
git fetch --no-tags arnd-playground pci-probe-rework-20210320
git checkout 3b0acc0ac3c7dc0ecb99215c7eb87a41a4acd79f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> arch/powerpc/kernel/pci-common.c:1666:6: error: no previous prototype for 'pci_scan_host_bridge' [-Werror=missing-prototypes]
1666 | void pci_scan_host_bridge(struct pci_host_bridge *bridge)
| ^~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/pci_scan_host_bridge +1666 arch/powerpc/kernel/pci-common.c
1661
1662 /**
1663 * pci_scan_host_bridge - Given a pci_controller, setup and scan the PCI bus
1664 * @bridge: Pointer to the PCI host controller instance structure
1665 */
> 1666 void pci_scan_host_bridge(struct pci_host_bridge *bridge)
1667 {
1668 struct pci_controller *hose = pci_host_bridge_priv(bridge);
1669 struct device_node *node = hose->dn;
1670 int mode;
1671 int error;
1672
1673 pr_debug("PCI: Scanning PHB %pOF\n", node);
1674
1675 /* Get some IO space for the new PHB */
1676 pcibios_setup_phb_io_space(hose);
1677
1678 /* Wire up PHB bus resources */
1679 pcibios_setup_phb_resources(hose);
1680
1681 bridge->sysdata = hose;
1682 bridge->busnr = hose->first_busno;
1683 bridge->custom_bus_scan = 1;
1684
1685 hose->busn.start = hose->first_busno;
1686 hose->busn.end = hose->last_busno;
1687 hose->busn.flags = IORESOURCE_BUS;
1688 pci_add_resource(&bridge->windows, &hose->busn);
1689
1690 mode = PCI_PROBE_NORMAL;
1691 if (node && hose->controller_ops.probe_mode)
1692 mode = hose->controller_ops.probe_mode(bridge->bus);
1693 /* Get probe mode and perform scan */
1694 pr_debug(" probe mode: %d\n", mode);
1695 if (mode == PCI_PROBE_DEVTREE)
1696 bridge->custom_bus_scan = 1;
1697
1698 /* Create an empty bus for the toplevel */
1699 error = pci_scan_root_bus_bridge(bridge);
1700 if (error) {
1701 pr_err("Failed to create bus for PCI domain %04x: %d\n",
1702 hose->global_number, error);
1703 pci_free_host_bridge(bridge);
1704 return;
1705 }
1706
1707 if (mode == PCI_PROBE_DEVTREE)
1708 of_scan_bus(node, bridge->bus);
1709
1710 /* Platform gets a chance to do some global fixups before
1711 * we proceed to resource allocation
1712 */
1713 if (ppc_md.pcibios_fixup_phb)
1714 ppc_md.pcibios_fixup_phb(hose);
1715
1716 /* Configure PCI Express settings */
1717 if (bridge->bus && !pci_has_flag(PCI_PROBE_ONLY)) {
1718 struct pci_bus *child;
1719 list_for_each_entry(child, &bridge->bus->children, node)
1720 pcie_bus_configure_settings(child);
1721 }
1722 }
1723 EXPORT_SYMBOL_GPL(pcibios_scan_host_bridge);
1724
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
arch/csky/kernel/perf_event.c:90:10: warning: no previous prototype for 'csky_pmu_read_cc'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1c273e10bc0cc7efb933e0ca10e260cdfc9f0b8c
commit: 0d3b051adbb72ed81956447d0d1e54d5943ee6f5 csky: Add VDSO with GENERIC_GETTIMEOFDAY, GENERIC_TIME_VSYSCALL, HAVE_GENERIC_VDSO
date: 3 weeks ago
config: csky-randconfig-r025-20210321 (attached as .config)
compiler: csky-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 0d3b051adbb72ed81956447d0d1e54d5943ee6f5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=csky
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/csky/kernel/perf_event.c:90:10: warning: no previous prototype for 'csky_pmu_read_cc' [-Wmissing-prototypes]
90 | uint64_t csky_pmu_read_cc(void)
| ^~~~~~~~~~~~~~~~
arch/csky/kernel/perf_event.c:878:6: warning: no previous prototype for 'csky_pmu_event_set_period' [-Wmissing-prototypes]
878 | int csky_pmu_event_set_period(struct perf_event *event)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/csky/kernel/perf_event.c:1198:5: warning: no previous prototype for 'init_hw_perf_events' [-Wmissing-prototypes]
1198 | int init_hw_perf_events(void)
| ^~~~~~~~~~~~~~~~~~~
arch/csky/kernel/perf_event.c:1293:5: warning: no previous prototype for 'csky_pmu_device_probe' [-Wmissing-prototypes]
1293 | int csky_pmu_device_probe(struct platform_device *pdev,
| ^~~~~~~~~~~~~~~~~~~~~
vim +/csky_pmu_read_cc +90 arch/csky/kernel/perf_event.c
88
89 /* cycle counter */
> 90 uint64_t csky_pmu_read_cc(void)
91 {
92 uint32_t lo, hi, tmp;
93 uint64_t result;
94
95 do {
96 tmp = cprgr("<0, 0x3>");
97 lo = cprgr("<0, 0x2>");
98 hi = cprgr("<0, 0x3>");
99 } while (hi != tmp);
100
101 result = (uint64_t) (hi) << 32;
102 result |= lo;
103
104 return result;
105 }
106
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
[sashal-linux-stable:queue-5.4 113/120] sound/pci/hda/patch_conexant.c:670:3: error: implicit declaration of function 'snd_hda_gen_add_micmute_led_cdev'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-5.4
head: 4bd8020d6c753ab56df4d7bd75833fd880e1995a
commit: aa457bfe463f543c83a701352c00ac8d31b9e8cb [113/120] ALSA: hda/conexant: Convert to cdev-variant of mic-mute LED controls
config: x86_64-randconfig-a002-20210320 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 436c6c9c20cc522c92a923440a5fc509c342a7db)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable queue-5.4
git checkout aa457bfe463f543c83a701352c00ac8d31b9e8cb
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> sound/pci/hda/patch_conexant.c:670:3: error: implicit declaration of function 'snd_hda_gen_add_micmute_led_cdev' [-Werror,-Wimplicit-function-declaration]
snd_hda_gen_add_micmute_led_cdev(codec, cxt_gpio_micmute_update);
^
sound/pci/hda/patch_conexant.c:670:3: note: did you mean 'snd_hda_gen_add_micmute_led'?
sound/pci/hda/hda_generic.h:357:5: note: 'snd_hda_gen_add_micmute_led' declared here
int snd_hda_gen_add_micmute_led(struct hda_codec *codec,
^
1 error generated.
vim +/snd_hda_gen_add_micmute_led_cdev +670 sound/pci/hda/patch_conexant.c
652
653
654 static void cxt_fixup_mute_led_gpio(struct hda_codec *codec,
655 const struct hda_fixup *fix, int action)
656 {
657 struct conexant_spec *spec = codec->spec;
658 static const struct hda_verb gpio_init[] = {
659 { 0x01, AC_VERB_SET_GPIO_MASK, 0x03 },
660 { 0x01, AC_VERB_SET_GPIO_DIRECTION, 0x03 },
661 {}
662 };
663
664 if (action == HDA_FIXUP_ACT_PRE_PROBE) {
665 spec->gen.vmaster_mute.hook = cxt_fixup_gpio_mute_hook;
666 spec->gpio_led = 0;
667 spec->mute_led_polarity = 0;
668 spec->gpio_mute_led_mask = 0x01;
669 spec->gpio_mic_led_mask = 0x02;
> 670 snd_hda_gen_add_micmute_led_cdev(codec, cxt_gpio_micmute_update);
671 }
672 snd_hda_add_verbs(codec, gpio_init);
673 if (spec->gpio_led)
674 snd_hda_codec_write(codec, 0x01, 0, AC_VERB_SET_GPIO_DATA,
675 spec->gpio_led);
676 }
677
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
Re: [PATCHSET 0/2] PF_IO_WORKER signal tweaks
by kernel test robot
Hi Jens,
I love your patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on tip/sched/core linus/master v5.12-rc3 next-20210319]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jens-Axboe/PF_IO_WORKER-signal-t...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a74e6a014c9d4d4161061f770c9b4f98372ac778
config: openrisc-randconfig-r026-20210321 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/05c70f370b93f3bf555e63293d43a82aa...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jens-Axboe/PF_IO_WORKER-signal-tweaks/20210320-234247
git checkout 05c70f370b93f3bf555e63293d43a82aab2fcdf3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/ptrace.h:7,
from arch/openrisc/kernel/asm-offsets.c:28:
include/linux/sched/signal.h: In function 'same_thread_group_account':
>> include/linux/sched/signal.h:673:33: error: expected ';' before '}' token
673 | return p1->signal == p2->signal
| ^
| ;
674 | }
| ~
--
In file included from include/linux/ptrace.h:7,
from arch/openrisc/kernel/asm-offsets.c:28:
include/linux/sched/signal.h: In function 'same_thread_group_account':
>> include/linux/sched/signal.h:673:33: error: expected ';' before '}' token
673 | return p1->signal == p2->signal
| ^
| ;
674 | }
| ~
make[2]: *** [scripts/Makefile.build:116: arch/openrisc/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1233: prepare0] Error 2
make[1]: Target 'modules_prepare' not remade because of errors.
make: *** [Makefile:215: __sub-make] Error 2
make: Target 'modules_prepare' not remade because of errors.
--
In file included from include/linux/ptrace.h:7,
from arch/openrisc/kernel/asm-offsets.c:28:
include/linux/sched/signal.h: In function 'same_thread_group_account':
>> include/linux/sched/signal.h:673:33: error: expected ';' before '}' token
673 | return p1->signal == p2->signal
| ^
| ;
674 | }
| ~
make[2]: *** [scripts/Makefile.build:116: arch/openrisc/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1233: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:215: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +673 include/linux/sched/signal.h
669
670 static inline
671 bool same_thread_group_account(struct task_struct *p1, struct task_struct *p2)
672 {
> 673 return p1->signal == p2->signal
674 }
675
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
Re: [PATCHSET 0/2] PF_IO_WORKER signal tweaks
by kernel test robot
Hi Jens,
I love your patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on tip/sched/core linus/master v5.12-rc3 next-20210319]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jens-Axboe/PF_IO_WORKER-signal-t...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a74e6a014c9d4d4161061f770c9b4f98372ac778
config: s390-randconfig-r014-20210321 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 436c6c9c20cc522c92a923440a5fc509c342a7db)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# https://github.com/0day-ci/linux/commit/05c70f370b93f3bf555e63293d43a82aa...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jens-Axboe/PF_IO_WORKER-signal-tweaks/20210320-234247
git checkout 05c70f370b93f3bf555e63293d43a82aab2fcdf3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:15:
In file included from include/linux/mm.h:707:
In file included from include/linux/huge_mm.h:8:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
>> include/linux/sched/signal.h:673:33: error: expected ';' after return statement
return p1->signal == p2->signal
^
;
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:33:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/diag.h:12:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:80:
include/asm-generic/io.h:464:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __raw_readb(PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:477:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:36:59: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^
include/uapi/linux/swab.h:105:32: note: expanded from macro '__swab16'
(__builtin_constant_p((__u16)(x)) ? \
^
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:33:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/diag.h:12:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:80:
include/asm-generic/io.h:477:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:36:59: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^
include/uapi/linux/swab.h:106:21: note: expanded from macro '__swab16'
___constant_swab16(x) : \
^
include/uapi/linux/swab.h:15:12: note: expanded from macro '___constant_swab16'
(((__u16)(x) & (__u16)0x00ffU) << 8) | \
^
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:33:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/diag.h:12:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:80:
include/asm-generic/io.h:477:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:36:59: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^
include/uapi/linux/swab.h:106:21: note: expanded from macro '__swab16'
___constant_swab16(x) : \
^
include/uapi/linux/swab.h:16:12: note: expanded from macro '___constant_swab16'
(((__u16)(x) & (__u16)0xff00U) >> 8)))
^
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:33:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/diag.h:12:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:80:
include/asm-generic/io.h:477:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:36:59: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^
include/uapi/linux/swab.h:107:12: note: expanded from macro '__swab16'
__fswab16(x))
^
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:33:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/diag.h:12:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
--
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:15:
In file included from include/linux/mm.h:707:
In file included from include/linux/huge_mm.h:8:
In file included from include/linux/fs.h:33:
In file included from include/linux/percpu-rwsem.h:7:
In file included from include/linux/rcuwait.h:6:
>> include/linux/sched/signal.h:673:33: error: expected ';' after return statement
return p1->signal == p2->signal
^
;
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:33:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/diag.h:12:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:80:
include/asm-generic/io.h:464:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __raw_readb(PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:477:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:36:59: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^
include/uapi/linux/swab.h:105:32: note: expanded from macro '__swab16'
(__builtin_constant_p((__u16)(x)) ? \
^
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:33:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/diag.h:12:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:80:
include/asm-generic/io.h:477:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:36:59: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^
include/uapi/linux/swab.h:106:21: note: expanded from macro '__swab16'
___constant_swab16(x) : \
^
include/uapi/linux/swab.h:15:12: note: expanded from macro '___constant_swab16'
(((__u16)(x) & (__u16)0x00ffU) << 8) | \
^
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:33:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/diag.h:12:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:80:
include/asm-generic/io.h:477:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:36:59: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^
include/uapi/linux/swab.h:106:21: note: expanded from macro '__swab16'
___constant_swab16(x) : \
^
include/uapi/linux/swab.h:16:12: note: expanded from macro '___constant_swab16'
(((__u16)(x) & (__u16)0xff00U) >> 8)))
^
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:33:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/diag.h:12:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:10:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:80:
include/asm-generic/io.h:477:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:36:59: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^
include/uapi/linux/swab.h:107:12: note: expanded from macro '__swab16'
__fswab16(x))
^
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:33:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/diag.h:12:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
vim +673 include/linux/sched/signal.h
669
670 static inline
671 bool same_thread_group_account(struct task_struct *p1, struct task_struct *p2)
672 {
> 673 return p1->signal == p2->signal
674 }
675
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
[linux-next:master 4836/5787] net/tipc/socket.c:1443 __tipc_sendmsg() warn: inconsistent indenting
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: f00397ee41c79b6155b9b44abd0055b2c0621349
commit: 908148bc5046e3503f2758d1d94c43766958d5be [4836/5787] tipc: refactor tipc_sendmsg() and tipc_lookup_anycast()
config: x86_64-randconfig-m001-20210320 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
New smatch warnings:
net/tipc/socket.c:1443 __tipc_sendmsg() warn: inconsistent indenting
Old smatch warnings:
net/tipc/socket.c:1463 __tipc_sendmsg() warn: inconsistent indenting
vim +1443 net/tipc/socket.c
1421
1422 static int __tipc_sendmsg(struct socket *sock, struct msghdr *m, size_t dlen)
1423 {
1424 struct sock *sk = sock->sk;
1425 struct net *net = sock_net(sk);
1426 struct tipc_sock *tsk = tipc_sk(sk);
1427 struct tipc_uaddr *ua = (struct tipc_uaddr *)m->msg_name;
1428 long timeout = sock_sndtimeo(sk, m->msg_flags & MSG_DONTWAIT);
1429 struct list_head *clinks = &tsk->cong_links;
1430 bool syn = !tipc_sk_type_connectionless(sk);
1431 struct tipc_group *grp = tsk->group;
1432 struct tipc_msg *hdr = &tsk->phdr;
1433 struct tipc_socket_addr skaddr;
1434 struct sk_buff_head pkts;
1435 int atype, mtu, rc;
1436
1437 if (unlikely(dlen > TIPC_MAX_USER_MSG_SIZE))
1438 return -EMSGSIZE;
1439
1440 if (ua) {
1441 if (!tipc_uaddr_valid(ua, m->msg_namelen))
1442 return -EINVAL;
> 1443 atype = ua->addrtype;
1444 }
1445
1446 /* If socket belongs to a communication group follow other paths */
1447 if (grp) {
1448 if (!ua)
1449 return tipc_send_group_bcast(sock, m, dlen, timeout);
1450 if (atype == TIPC_SERVICE_ADDR)
1451 return tipc_send_group_anycast(sock, m, dlen, timeout);
1452 if (atype == TIPC_SOCKET_ADDR)
1453 return tipc_send_group_unicast(sock, m, dlen, timeout);
1454 if (atype == TIPC_SERVICE_RANGE)
1455 return tipc_send_group_mcast(sock, m, dlen, timeout);
1456 return -EINVAL;
1457 }
1458
1459 if (!ua) {
1460 ua = (struct tipc_uaddr *)&tsk->peer;
1461 if (!syn && ua->family != AF_TIPC)
1462 return -EDESTADDRREQ;
1463 atype = ua->addrtype;
1464 }
1465
1466 if (unlikely(syn)) {
1467 if (sk->sk_state == TIPC_LISTEN)
1468 return -EPIPE;
1469 if (sk->sk_state != TIPC_OPEN)
1470 return -EISCONN;
1471 if (tsk->published)
1472 return -EOPNOTSUPP;
1473 if (atype == TIPC_SERVICE_ADDR) {
1474 tsk->conn_type = ua->sa.type;
1475 tsk->conn_instance = ua->sa.instance;
1476 }
1477 msg_set_syn(hdr, 1);
1478 }
1479
1480 /* Determine destination */
1481 if (atype == TIPC_SERVICE_RANGE) {
1482 return tipc_sendmcast(sock, &ua->sr, m, dlen, timeout);
1483 } else if (atype == TIPC_SERVICE_ADDR) {
1484 skaddr.node = ua->lookup_node;
1485 ua->scope = tipc_node2scope(skaddr.node);
1486 if (!tipc_nametbl_lookup_anycast(net, ua, &skaddr))
1487 return -EHOSTUNREACH;
1488 } else if (atype == TIPC_SOCKET_ADDR) {
1489 skaddr = ua->sk;
1490 } else {
1491 return -EINVAL;
1492 }
1493
1494 /* Block or return if destination link is congested */
1495 rc = tipc_wait_for_cond(sock, &timeout,
1496 !tipc_dest_find(clinks, skaddr.node, 0));
1497 if (unlikely(rc))
1498 return rc;
1499
1500 /* Finally build message header */
1501 msg_set_destnode(hdr, skaddr.node);
1502 msg_set_destport(hdr, skaddr.ref);
1503 if (atype == TIPC_SERVICE_ADDR) {
1504 msg_set_type(hdr, TIPC_NAMED_MSG);
1505 msg_set_hdr_sz(hdr, NAMED_H_SIZE);
1506 msg_set_nametype(hdr, ua->sa.type);
1507 msg_set_nameinst(hdr, ua->sa.instance);
1508 msg_set_lookup_scope(hdr, ua->scope);
1509 } else { /* TIPC_SOCKET_ADDR */
1510 msg_set_type(hdr, TIPC_DIRECT_MSG);
1511 msg_set_lookup_scope(hdr, 0);
1512 msg_set_hdr_sz(hdr, BASIC_H_SIZE);
1513 }
1514
1515 /* Add message body */
1516 __skb_queue_head_init(&pkts);
1517 mtu = tipc_node_get_mtu(net, skaddr.node, tsk->portid, true);
1518 rc = tipc_msg_build(hdr, m, 0, dlen, mtu, &pkts);
1519 if (unlikely(rc != dlen))
1520 return rc;
1521 if (unlikely(syn && !tipc_msg_skb_clone(&pkts, &sk->sk_write_queue))) {
1522 __skb_queue_purge(&pkts);
1523 return -ENOMEM;
1524 }
1525
1526 /* Send message */
1527 trace_tipc_sk_sendmsg(sk, skb_peek(&pkts), TIPC_DUMP_SK_SNDQ, " ");
1528 rc = tipc_node_xmit(net, &pkts, skaddr.node, tsk->portid);
1529 if (unlikely(rc == -ELINKCONG)) {
1530 tipc_dest_push(clinks, skaddr.node, 0);
1531 tsk->cong_link_cnt++;
1532 rc = 0;
1533 }
1534
1535 if (unlikely(syn && !rc))
1536 tipc_set_sk_state(sk, TIPC_CONNECTING);
1537
1538 return rc ? rc : dlen;
1539 }
1540
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months