Re: [PATCH] audit: log nftables configuration change events once per table
by kernel test robot
Hi Richard,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pcmoore-audit/next]
[also build test ERROR on nf/master nf-next/master linux/master linus/master v5.12-rc3 next-20210318]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Richard-Guy-Briggs/audit-log-nft...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
config: sparc64-randconfig-p002-20210318 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6c3d6ac0f39a29e8474b0ff59609e3c31...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Richard-Guy-Briggs/audit-log-nftables-configuration-change-events-once-per-table/20210318-234408
git checkout 6c3d6ac0f39a29e8474b0ff59609e3c3168339c0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/sparc/kernel/ptrace_64.c:25:
>> include/linux/audit.h:121:17: error: 'nft2audit_op' defined but not used [-Werror=unused-const-variable=]
121 | static const u8 nft2audit_op[] = { // enum nf_tables_msg_types
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for FRAME_POINTER
Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS || MCOUNT
Selected by
- LOCKDEP && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && !MIPS && !PPC && !ARM && !S390 && !MICROBLAZE && !ARC && !X86
vim +/nft2audit_op +121 include/linux/audit.h
120
> 121 static const u8 nft2audit_op[] = { // enum nf_tables_msg_types
122 /* NFT_MSG_NEWTABLE */ AUDIT_NFT_OP_TABLE_REGISTER,
123 /* NFT_MSG_GETTABLE */ AUDIT_NFT_OP_INVALID,
124 /* NFT_MSG_DELTABLE */ AUDIT_NFT_OP_TABLE_UNREGISTER,
125 /* NFT_MSG_NEWCHAIN */ AUDIT_NFT_OP_CHAIN_REGISTER,
126 /* NFT_MSG_GETCHAIN */ AUDIT_NFT_OP_INVALID,
127 /* NFT_MSG_DELCHAIN */ AUDIT_NFT_OP_CHAIN_UNREGISTER,
128 /* NFT_MSG_NEWRULE */ AUDIT_NFT_OP_RULE_REGISTER,
129 /* NFT_MSG_GETRULE */ AUDIT_NFT_OP_INVALID,
130 /* NFT_MSG_DELRULE */ AUDIT_NFT_OP_RULE_UNREGISTER,
131 /* NFT_MSG_NEWSET */ AUDIT_NFT_OP_SET_REGISTER,
132 /* NFT_MSG_GETSET */ AUDIT_NFT_OP_INVALID,
133 /* NFT_MSG_DELSET */ AUDIT_NFT_OP_SET_UNREGISTER,
134 /* NFT_MSG_NEWSETELEM */ AUDIT_NFT_OP_SETELEM_REGISTER,
135 /* NFT_MSG_GETSETELEM */ AUDIT_NFT_OP_INVALID,
136 /* NFT_MSG_DELSETELEM */ AUDIT_NFT_OP_SETELEM_UNREGISTER,
137 /* NFT_MSG_NEWGEN */ AUDIT_NFT_OP_GEN_REGISTER,
138 /* NFT_MSG_GETGEN */ AUDIT_NFT_OP_INVALID,
139 /* NFT_MSG_TRACE */ AUDIT_NFT_OP_INVALID,
140 /* NFT_MSG_NEWOBJ */ AUDIT_NFT_OP_OBJ_REGISTER,
141 /* NFT_MSG_GETOBJ */ AUDIT_NFT_OP_INVALID,
142 /* NFT_MSG_DELOBJ */ AUDIT_NFT_OP_OBJ_UNREGISTER,
143 /* NFT_MSG_GETOBJ_RESET */ AUDIT_NFT_OP_OBJ_RESET,
144 /* NFT_MSG_NEWFLOWTABLE */ AUDIT_NFT_OP_FLOWTABLE_REGISTER,
145 /* NFT_MSG_GETFLOWTABLE */ AUDIT_NFT_OP_INVALID,
146 /* NFT_MSG_DELFLOWTABLE */ AUDIT_NFT_OP_FLOWTABLE_UNREGISTER,
147 /* NFT_MSG_MAX */ AUDIT_NFT_OP_INVALID,
148 };
149
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
[ti:ti-rt-linux-5.4.y 10/10] kernel/rcu/srcutree.c:739:30: warning: unused variable 'sp_llock'
by kernel test robot
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.4.y
head: 39a31e930c9ef3b4f39306c49cbaa9c58c94e353
commit: 39a31e930c9ef3b4f39306c49cbaa9c58c94e353 [10/10] Merged TI feature ti_linux_base_rt into ti-rt-linux-5.4.y
config: arm64-randconfig-r034-20210318 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6db3ab2903f42712f44000afb5aa467efbd25f35)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
git fetch --no-tags ti ti-rt-linux-5.4.y
git checkout 39a31e930c9ef3b4f39306c49cbaa9c58c94e353
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> kernel/rcu/srcutree.c:739:30: warning: unused variable 'sp_llock' [-Wunused-const-variable]
static DEFINE_LOCAL_IRQ_LOCK(sp_llock);
^
1 warning generated.
vim +/sp_llock +739 kernel/rcu/srcutree.c
dad81a2026841b Paul E. McKenney 2017-03-25 738
8a5f2a03d28c15 Sebastian Andrzej Siewior 2017-10-12 @739 static DEFINE_LOCAL_IRQ_LOCK(sp_llock);
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 740 /*
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 741 * If SRCU is likely idle, return true, otherwise return false.
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 742 *
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 743 * Note that it is OK for several current from-idle requests for a new
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 744 * grace period from idle to specify expediting because they will all end
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 745 * up requesting the same grace period anyhow. So no loss.
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 746 *
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 747 * Note also that if any CPU (including the current one) is still invoking
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 748 * callbacks, this function will nevertheless say "idle". This is not
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 749 * ideal, but the overhead of checking all CPUs' callback lists is even
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 750 * less ideal, especially on large systems. Furthermore, the wakeup
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 751 * can happen before the callback is fully removed, so we have no choice
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 752 * but to accept this type of error.
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 753 *
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 754 * This function is also subject to counter-wrap errors, but let's face
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 755 * it, if this function was preempted for enough time for the counters
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 756 * to wrap, it really doesn't matter whether or not we expedite the grace
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 757 * period. The extra overhead of a needlessly expedited grace period is
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 758 * negligible when amoritized over that time period, and the extra latency
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 759 * of a needlessly non-expedited grace period is similarly negligible.
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 760 */
aacb5d91ab1bfb Paul E. McKenney 2018-10-28 761 static bool srcu_might_be_idle(struct srcu_struct *ssp)
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 762 {
22607d66bbc3e8 Paul E. McKenney 2017-04-25 763 unsigned long curseq;
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 764 unsigned long flags;
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 765 struct srcu_data *sdp;
22607d66bbc3e8 Paul E. McKenney 2017-04-25 766 unsigned long t;
c71706a5ffff80 Paul E. McKenney 2019-11-04 767 unsigned long tlast;
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 768
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 769 /* If the local srcu_data structure has callbacks, not idle. */
8a5f2a03d28c15 Sebastian Andrzej Siewior 2017-10-12 770 local_lock_irqsave(sp_llock, flags);
aacb5d91ab1bfb Paul E. McKenney 2018-10-28 771 sdp = this_cpu_ptr(ssp->sda);
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 772 if (rcu_segcblist_pend_cbs(&sdp->srcu_cblist)) {
8a5f2a03d28c15 Sebastian Andrzej Siewior 2017-10-12 773 local_unlock_irqrestore(sp_llock, flags);
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 774 return false; /* Callbacks already present, so not idle. */
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 775 }
8a5f2a03d28c15 Sebastian Andrzej Siewior 2017-10-12 776 local_unlock_irqrestore(sp_llock, flags);
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 777
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 778 /*
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 779 * No local callbacks, so probabalistically probe global state.
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 780 * Exact information would require acquiring locks, which would
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 781 * kill scalability, hence the probabalistic nature of the probe.
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 782 */
22607d66bbc3e8 Paul E. McKenney 2017-04-25 783
22607d66bbc3e8 Paul E. McKenney 2017-04-25 784 /* First, see if enough time has passed since the last GP. */
22607d66bbc3e8 Paul E. McKenney 2017-04-25 785 t = ktime_get_mono_fast_ns();
c71706a5ffff80 Paul E. McKenney 2019-11-04 786 tlast = READ_ONCE(ssp->srcu_last_gp_end);
22607d66bbc3e8 Paul E. McKenney 2017-04-25 787 if (exp_holdoff == 0 ||
c71706a5ffff80 Paul E. McKenney 2019-11-04 788 time_in_range_open(t, tlast, tlast + exp_holdoff))
22607d66bbc3e8 Paul E. McKenney 2017-04-25 789 return false; /* Too soon after last GP. */
22607d66bbc3e8 Paul E. McKenney 2017-04-25 790
22607d66bbc3e8 Paul E. McKenney 2017-04-25 791 /* Next, check for probable idleness. */
aacb5d91ab1bfb Paul E. McKenney 2018-10-28 792 curseq = rcu_seq_current(&ssp->srcu_gp_seq);
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 793 smp_mb(); /* Order ->srcu_gp_seq with ->srcu_gp_seq_needed. */
aacb5d91ab1bfb Paul E. McKenney 2018-10-28 794 if (ULONG_CMP_LT(curseq, READ_ONCE(ssp->srcu_gp_seq_needed)))
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 795 return false; /* Grace period in progress, so not idle. */
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 796 smp_mb(); /* Order ->srcu_gp_seq with prior access. */
aacb5d91ab1bfb Paul E. McKenney 2018-10-28 797 if (curseq != rcu_seq_current(&ssp->srcu_gp_seq))
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 798 return false; /* GP # changed, so not idle. */
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 799 return true; /* With reasonable probability, idle! */
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 800 }
2da4b2a7fd8de5 Paul E. McKenney 2017-04-25 801
:::::: The code at line 739 was first introduced by commit
:::::: 8a5f2a03d28c1523e49a5c501b74ccc567d321f7 srcu: replace local_irqsave() with a locallock
:::::: TO: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de>
:::::: CC: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
Re: [PATCH 1/3] drm/ttm: move swapout logic around v2
by kernel test robot
Hi "Christian,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[also build test ERROR on next-20210318]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next linus/master v5.12-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christian-K-nig/drm-ttm-move-swa...
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-randconfig-a005-20210318 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6db3ab2903f42712f44000afb5aa467efbd25f35)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/a454d56ea061b53d24a62a700743e4508...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christian-K-nig/drm-ttm-move-swapout-logic-around-v2/20210318-204848
git checkout a454d56ea061b53d24a62a700743e4508dd6c9b1
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/ttm/ttm_device.c:109:5: error: conflicting types for 'ttm_global_swapout'
int ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags)
^
include/drm/ttm/ttm_device.h:300:6: note: previous declaration is here
long ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags);
^
1 error generated.
vim +/ttm_global_swapout +109 drivers/gpu/drm/ttm/ttm_device.c
104
105 /**
106 * A buffer object shrink method that tries to swap out the first
107 * buffer object on the global::swap_lru list.
108 */
> 109 int ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags)
110 {
111 struct ttm_global *glob = &ttm_glob;
112 struct ttm_buffer_object *bo;
113 unsigned i;
114 int ret;
115
116 spin_lock(&glob->lru_lock);
117 for (i = 0; i < TTM_MAX_BO_PRIORITY; ++i) {
118 list_for_each_entry(bo, &glob->swap_lru[i], swap) {
119 uint32_t num_pages = bo->ttm->num_pages;
120
121 ret = ttm_bo_swapout(bo, ctx, gfp_flags);
122 /* ttm_bo_swapout has dropped the lru_lock */
123 if (!ret)
124 return num_pages;
125 if (ret != -EBUSY)
126 return ret;
127 }
128 }
129 spin_unlock(&glob->lru_lock);
130 return 0;
131 }
132 EXPORT_SYMBOL(ttm_global_swapout);
133
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
[agd5f:drm-next 491/518] drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:190:43: warning: unused variable 'dmub_trace_irq_info_funcs'
by kernel test robot
tree: https://gitlab.freedesktop.org/agd5f/linux.git drm-next
head: c37eed39d0ba85a057baa9fafbf9f7cc1f888c1e
commit: 9bc6885a7abf90d4bfde44b6c9ba214a23b325dc [491/518] drm/amd/display: Support vertical interrupt 0 for all dcn ASIC
config: x86_64-randconfig-a003-20210318 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6db3ab2903f42712f44000afb5aa467efbd25f35)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
git fetch --no-tags agd5f drm-next
git checkout 9bc6885a7abf90d4bfde44b6c9ba214a23b325dc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:43:20: warning: no previous prototype for function 'to_dal_irq_source_dcn21' [-Wmissing-prototypes]
enum dc_irq_source to_dal_irq_source_dcn21(
^
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:43:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
enum dc_irq_source to_dal_irq_source_dcn21(
^
static
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:389:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
vupdate_no_lock_int_entry(0),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:266:39: note: expanded from macro 'vupdate_no_lock_int_entry'
[DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\
^~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:383:2: note: previous initialization is here
vupdate_int_entry(0),
^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:255:39: note: expanded from macro 'vupdate_int_entry'
[DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\
^~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:390:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
vupdate_no_lock_int_entry(1),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:266:39: note: expanded from macro 'vupdate_no_lock_int_entry'
[DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\
^~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:384:2: note: previous initialization is here
vupdate_int_entry(1),
^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:255:39: note: expanded from macro 'vupdate_int_entry'
[DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\
^~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:391:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
vupdate_no_lock_int_entry(2),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:266:39: note: expanded from macro 'vupdate_no_lock_int_entry'
[DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\
^~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:385:2: note: previous initialization is here
vupdate_int_entry(2),
^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:255:39: note: expanded from macro 'vupdate_int_entry'
[DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\
^~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:392:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
vupdate_no_lock_int_entry(3),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:266:39: note: expanded from macro 'vupdate_no_lock_int_entry'
[DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\
^~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:386:2: note: previous initialization is here
vupdate_int_entry(3),
^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:255:39: note: expanded from macro 'vupdate_int_entry'
[DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\
^~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:393:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
vupdate_no_lock_int_entry(4),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:266:39: note: expanded from macro 'vupdate_no_lock_int_entry'
[DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\
^~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:387:2: note: previous initialization is here
vupdate_int_entry(4),
^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:255:39: note: expanded from macro 'vupdate_int_entry'
[DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\
^~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:394:2: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
vupdate_no_lock_int_entry(5),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:266:39: note: expanded from macro 'vupdate_no_lock_int_entry'
[DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\
^~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:388:2: note: previous initialization is here
vupdate_int_entry(5),
^~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:255:39: note: expanded from macro 'vupdate_int_entry'
[DC_IRQ_SOURCE_VUPDATE1 + reg_num] = {\
^~
>> drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c:190:43: warning: unused variable 'dmub_trace_irq_info_funcs' [-Wunused-const-variable]
static const struct irq_source_info_funcs dmub_trace_irq_info_funcs = {
^
8 warnings generated.
--
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50:20: warning: no previous prototype for function 'to_dal_irq_source_dcn30' [-Wmissing-prototypes]
enum dc_irq_source to_dal_irq_source_dcn30(
^
drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
enum dc_irq_source to_dal_irq_source_dcn30(
^
static
>> drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:196:43: warning: unused variable 'dmub_trace_irq_info_funcs' [-Wunused-const-variable]
static const struct irq_source_info_funcs dmub_trace_irq_info_funcs = {
^
2 warnings generated.
vim +/dmub_trace_irq_info_funcs +190 drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn21/irq_service_dcn21.c
189
> 190 static const struct irq_source_info_funcs dmub_trace_irq_info_funcs = {
191 .set = NULL,
192 .ack = NULL
193 };
194
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
[hch-xfs:xfs-inode-shrink.4 1/18] fs/xfs/scrub/ialloc.c:215:22: warning: variable 'dip' set but not used
by kernel test robot
tree: git://git.infradead.org/users/hch/xfs xfs-inode-shrink.4
head: ecab85085f418fe9e1f8461583b4eed1d85252a1
commit: aa97e672498c840ddf82c5edb5648c4f34d7fa9c [1/18] xfs: split xfs_imap_to_bp
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add hch-xfs git://git.infradead.org/users/hch/xfs
git fetch --no-tags hch-xfs xfs-inode-shrink.4
git checkout aa97e672498c840ddf82c5edb5648c4f34d7fa9c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
fs/xfs/scrub/ialloc.c: In function 'xchk_iallocbt_check_cluster':
>> fs/xfs/scrub/ialloc.c:215:22: warning: variable 'dip' set but not used [-Wunused-but-set-variable]
215 | struct xfs_dinode *dip;
| ^~~
vim +/dip +215 fs/xfs/scrub/ialloc.c
3daa664191375d Darrick J. Wong 2017-10-17 199
b9454fe056bda3 Darrick J. Wong 2019-02-01 200 /*
b9454fe056bda3 Darrick J. Wong 2019-02-01 201 * Check that the holemask and freemask of a hypothetical inode cluster match
b9454fe056bda3 Darrick J. Wong 2019-02-01 202 * what's actually on disk. If sparse inodes are enabled, the cluster does
b9454fe056bda3 Darrick J. Wong 2019-02-01 203 * not actually have to map to inodes if the corresponding holemask bit is set.
b9454fe056bda3 Darrick J. Wong 2019-02-01 204 *
b9454fe056bda3 Darrick J. Wong 2019-02-01 205 * @cluster_base is the first inode in the cluster within the @irec.
b9454fe056bda3 Darrick J. Wong 2019-02-01 206 */
3daa664191375d Darrick J. Wong 2017-10-17 207 STATIC int
a1954242facb01 Darrick J. Wong 2019-02-01 208 xchk_iallocbt_check_cluster(
c517b3aa02cff1 Darrick J. Wong 2018-07-19 209 struct xchk_btree *bs,
a1954242facb01 Darrick J. Wong 2019-02-01 210 struct xfs_inobt_rec_incore *irec,
b9454fe056bda3 Darrick J. Wong 2019-02-01 211 unsigned int cluster_base)
3daa664191375d Darrick J. Wong 2017-10-17 212 {
3daa664191375d Darrick J. Wong 2017-10-17 213 struct xfs_imap imap;
3daa664191375d Darrick J. Wong 2017-10-17 214 struct xfs_mount *mp = bs->cur->bc_mp;
3daa664191375d Darrick J. Wong 2017-10-17 @215 struct xfs_dinode *dip;
b9454fe056bda3 Darrick J. Wong 2019-02-01 216 struct xfs_buf *cluster_bp;
a1954242facb01 Darrick J. Wong 2019-02-01 217 unsigned int nr_inodes;
576af732280760 Dave Chinner 2020-03-10 218 xfs_agnumber_t agno = bs->cur->bc_ag.agno;
3daa664191375d Darrick J. Wong 2017-10-17 219 xfs_agblock_t agbno;
b9454fe056bda3 Darrick J. Wong 2019-02-01 220 unsigned int cluster_index;
b9454fe056bda3 Darrick J. Wong 2019-02-01 221 uint16_t cluster_mask = 0;
3daa664191375d Darrick J. Wong 2017-10-17 222 uint16_t ir_holemask;
3daa664191375d Darrick J. Wong 2017-10-17 223 int error = 0;
3daa664191375d Darrick J. Wong 2017-10-17 224
435dcf0787fde2 Darrick J. Wong 2019-02-01 225 nr_inodes = min_t(unsigned int, XFS_INODES_PER_CHUNK,
ef325959993edd Darrick J. Wong 2019-06-05 226 M_IGEO(mp)->inodes_per_cluster);
3daa664191375d Darrick J. Wong 2017-10-17 227
b9454fe056bda3 Darrick J. Wong 2019-02-01 228 /* Map this inode cluster */
b9454fe056bda3 Darrick J. Wong 2019-02-01 229 agbno = XFS_AGINO_TO_AGBNO(mp, irec->ir_startino + cluster_base);
3daa664191375d Darrick J. Wong 2017-10-17 230
b9454fe056bda3 Darrick J. Wong 2019-02-01 231 /* Compute a bitmask for this cluster that can be used for holemask. */
b9454fe056bda3 Darrick J. Wong 2019-02-01 232 for (cluster_index = 0;
b9454fe056bda3 Darrick J. Wong 2019-02-01 233 cluster_index < nr_inodes;
b9454fe056bda3 Darrick J. Wong 2019-02-01 234 cluster_index += XFS_INODES_PER_HOLEMASK_BIT)
b9454fe056bda3 Darrick J. Wong 2019-02-01 235 cluster_mask |= XFS_INOBT_MASK((cluster_base + cluster_index) /
3daa664191375d Darrick J. Wong 2017-10-17 236 XFS_INODES_PER_HOLEMASK_BIT);
3daa664191375d Darrick J. Wong 2017-10-17 237
f9e63342b85833 Darrick J. Wong 2019-02-01 238 /*
f9e63342b85833 Darrick J. Wong 2019-02-01 239 * Map the first inode of this cluster to a buffer and offset.
f9e63342b85833 Darrick J. Wong 2019-02-01 240 * Be careful about inobt records that don't align with the start of
f9e63342b85833 Darrick J. Wong 2019-02-01 241 * the inode buffer when block sizes are large enough to hold multiple
f9e63342b85833 Darrick J. Wong 2019-02-01 242 * inode chunks. When this happens, cluster_base will be zero but
f9e63342b85833 Darrick J. Wong 2019-02-01 243 * ir_startino can be large enough to make im_boffset nonzero.
f9e63342b85833 Darrick J. Wong 2019-02-01 244 */
b9454fe056bda3 Darrick J. Wong 2019-02-01 245 ir_holemask = (irec->ir_holemask & cluster_mask);
b9454fe056bda3 Darrick J. Wong 2019-02-01 246 imap.im_blkno = XFS_AGB_TO_DADDR(mp, agno, agbno);
ef325959993edd Darrick J. Wong 2019-06-05 247 imap.im_len = XFS_FSB_TO_BB(mp, M_IGEO(mp)->blocks_per_cluster);
025197ebb08a77 Darrick J. Wong 2019-06-03 248 imap.im_boffset = XFS_INO_TO_OFFSET(mp, irec->ir_startino) <<
025197ebb08a77 Darrick J. Wong 2019-06-03 249 mp->m_sb.sb_inodelog;
f9e63342b85833 Darrick J. Wong 2019-02-01 250
f9e63342b85833 Darrick J. Wong 2019-02-01 251 if (imap.im_boffset != 0 && cluster_base != 0) {
f9e63342b85833 Darrick J. Wong 2019-02-01 252 ASSERT(imap.im_boffset == 0 || cluster_base == 0);
f9e63342b85833 Darrick J. Wong 2019-02-01 253 xchk_btree_set_corrupt(bs->sc, bs->cur, 0);
f9e63342b85833 Darrick J. Wong 2019-02-01 254 return 0;
f9e63342b85833 Darrick J. Wong 2019-02-01 255 }
b9454fe056bda3 Darrick J. Wong 2019-02-01 256
b9454fe056bda3 Darrick J. Wong 2019-02-01 257 trace_xchk_iallocbt_check_cluster(mp, agno, irec->ir_startino,
b9454fe056bda3 Darrick J. Wong 2019-02-01 258 imap.im_blkno, imap.im_len, cluster_base, nr_inodes,
b9454fe056bda3 Darrick J. Wong 2019-02-01 259 cluster_mask, ir_holemask,
b9454fe056bda3 Darrick J. Wong 2019-02-01 260 XFS_INO_TO_OFFSET(mp, irec->ir_startino +
b9454fe056bda3 Darrick J. Wong 2019-02-01 261 cluster_base));
b9454fe056bda3 Darrick J. Wong 2019-02-01 262
3daa664191375d Darrick J. Wong 2017-10-17 263 /* The whole cluster must be a hole or not a hole. */
b9454fe056bda3 Darrick J. Wong 2019-02-01 264 if (ir_holemask != cluster_mask && ir_holemask != 0) {
c517b3aa02cff1 Darrick J. Wong 2018-07-19 265 xchk_btree_set_corrupt(bs->sc, bs->cur, 0);
a1954242facb01 Darrick J. Wong 2019-02-01 266 return 0;
3daa664191375d Darrick J. Wong 2017-10-17 267 }
3daa664191375d Darrick J. Wong 2017-10-17 268
3daa664191375d Darrick J. Wong 2017-10-17 269 /* If any part of this is a hole, skip it. */
d852657ccfc0e4 Darrick J. Wong 2018-01-16 270 if (ir_holemask) {
c517b3aa02cff1 Darrick J. Wong 2018-07-19 271 xchk_xref_is_not_owned_by(bs->sc, agbno,
ef325959993edd Darrick J. Wong 2019-06-05 272 M_IGEO(mp)->blocks_per_cluster,
7280fedaf3a0f9 Darrick J. Wong 2018-12-12 273 &XFS_RMAP_OINFO_INODES);
a1954242facb01 Darrick J. Wong 2019-02-01 274 return 0;
d852657ccfc0e4 Darrick J. Wong 2018-01-16 275 }
d852657ccfc0e4 Darrick J. Wong 2018-01-16 276
ef325959993edd Darrick J. Wong 2019-06-05 277 xchk_xref_is_owned_by(bs->sc, agbno, M_IGEO(mp)->blocks_per_cluster,
7280fedaf3a0f9 Darrick J. Wong 2018-12-12 278 &XFS_RMAP_OINFO_INODES);
3daa664191375d Darrick J. Wong 2017-10-17 279
3daa664191375d Darrick J. Wong 2017-10-17 280 /* Grab the inode cluster buffer. */
aa97e672498c84 Christoph Hellwig 2020-07-09 281 error = xfs_imap_to_bp(mp, bs->cur->bc_tp, &imap, &cluster_bp);
aa97e672498c84 Christoph Hellwig 2020-07-09 282 if (!error)
aa97e672498c84 Christoph Hellwig 2020-07-09 283 dip = xfs_buf_offset(cluster_bp, imap.im_boffset);
a1954242facb01 Darrick J. Wong 2019-02-01 284 if (!xchk_btree_xref_process_error(bs->sc, bs->cur, 0, &error))
b9454fe056bda3 Darrick J. Wong 2019-02-01 285 return error;
3daa664191375d Darrick J. Wong 2017-10-17 286
b9454fe056bda3 Darrick J. Wong 2019-02-01 287 /* Check free status of each inode within this cluster. */
b9454fe056bda3 Darrick J. Wong 2019-02-01 288 for (cluster_index = 0; cluster_index < nr_inodes; cluster_index++) {
f9e63342b85833 Darrick J. Wong 2019-02-01 289 struct xfs_dinode *dip;
f9e63342b85833 Darrick J. Wong 2019-02-01 290
f9e63342b85833 Darrick J. Wong 2019-02-01 291 if (imap.im_boffset >= BBTOB(cluster_bp->b_length)) {
f9e63342b85833 Darrick J. Wong 2019-02-01 292 xchk_btree_set_corrupt(bs->sc, bs->cur, 0);
f9e63342b85833 Darrick J. Wong 2019-02-01 293 break;
f9e63342b85833 Darrick J. Wong 2019-02-01 294 }
f9e63342b85833 Darrick J. Wong 2019-02-01 295
f9e63342b85833 Darrick J. Wong 2019-02-01 296 dip = xfs_buf_offset(cluster_bp, imap.im_boffset);
b9454fe056bda3 Darrick J. Wong 2019-02-01 297 error = xchk_iallocbt_check_cluster_ifree(bs, irec,
f9e63342b85833 Darrick J. Wong 2019-02-01 298 cluster_base + cluster_index, dip);
a1954242facb01 Darrick J. Wong 2019-02-01 299 if (error)
a1954242facb01 Darrick J. Wong 2019-02-01 300 break;
f9e63342b85833 Darrick J. Wong 2019-02-01 301 imap.im_boffset += mp->m_sb.sb_inodesize;
a1954242facb01 Darrick J. Wong 2019-02-01 302 }
a1954242facb01 Darrick J. Wong 2019-02-01 303
b9454fe056bda3 Darrick J. Wong 2019-02-01 304 xfs_trans_brelse(bs->cur->bc_tp, cluster_bp);
3daa664191375d Darrick J. Wong 2017-10-17 305 return error;
3daa664191375d Darrick J. Wong 2017-10-17 306 }
3daa664191375d Darrick J. Wong 2017-10-17 307
:::::: The code at line 215 was first introduced by commit
:::::: 3daa664191375db6a4a0cced75183aa3ca96cbda xfs: scrub inode btrees
:::::: TO: Darrick J. Wong <darrick.wong(a)oracle.com>
:::::: CC: Darrick J. Wong <darrick.wong(a)oracle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
Re: [PATCH v2 4/6] phy: qcom-qmp: add support for sm8250-usb3-dp phy
by kernel test robot
Hi Dmitry,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v5.12-rc3]
[cannot apply to phy/next next-20210318]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Dmitry-Baryshkov/phy-qcom-qmp-pr...
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: riscv-randconfig-r036-20210318 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6db3ab2903f42712f44000afb5aa467efbd25f35)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/52b4e61cfaf3c2d80a609f377af0fb1c9...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dmitry-Baryshkov/phy-qcom-qmp-provide-DP-phy-support-for-sm8250/20210318-221352
git checkout 52b4e61cfaf3c2d80a609f377af0fb1c9186984c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/phy/qualcomm/phy-qcom-qmp.c:1923:38: warning: unused variable 'qmp_v4_usb3_rx_tbl' [-Wunused-const-variable]
static const struct qmp_phy_init_tbl qmp_v4_usb3_rx_tbl[] = {
^
1 warning generated.
vim +/qmp_v4_usb3_rx_tbl +1923 drivers/phy/qualcomm/phy-qcom-qmp.c
1922
> 1923 static const struct qmp_phy_init_tbl qmp_v4_usb3_rx_tbl[] = {
1924 QMP_PHY_INIT_CFG(QSERDES_V4_RX_UCDR_FASTLOCK_FO_GAIN, 0x0b),
1925 QMP_PHY_INIT_CFG(QSERDES_V4_RX_RX_EQU_ADAPTOR_CNTRL2, 0x0f),
1926 QMP_PHY_INIT_CFG(QSERDES_V4_RX_RX_EQU_ADAPTOR_CNTRL3, 0x4e),
1927 QMP_PHY_INIT_CFG(QSERDES_V4_RX_RX_EQU_ADAPTOR_CNTRL4, 0x18),
1928 QMP_PHY_INIT_CFG(QSERDES_V4_RX_RX_EQ_OFFSET_ADAPTOR_CNTRL1, 0x77),
1929 QMP_PHY_INIT_CFG(QSERDES_V4_RX_RX_OFFSET_ADAPTOR_CNTRL2, 0x80),
1930 QMP_PHY_INIT_CFG(QSERDES_V4_RX_SIGDET_CNTRL, 0x03),
1931 QMP_PHY_INIT_CFG(QSERDES_V4_RX_SIGDET_DEGLITCH_CNTRL, 0x16),
1932 QMP_PHY_INIT_CFG(QSERDES_V4_RX_UCDR_SO_SATURATION_AND_ENABLE, 0x75),
1933 };
1934
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
[freescale-fslc:5.4-2.3.x-imx 8473/17762] drivers/usb/chipidea/ci.h:476:47: error: dereferencing pointer to incomplete type 'struct ci_hdrc_platform_data'
by kernel test robot
Hi Peter,
FYI, the error/warning still remains.
tree: https://github.com/Freescale/linux-fslc 5.4-2.3.x-imx
head: eddae7f28ad6141e734634c3acb6c6b16df76244
commit: d74f8108dce77b0fb2496cfe92461de9766e060e [8473/17762] MLK-23677-4 usb: chipidea: add tracepoint support for udc
config: m68k-randconfig-r002-20210318 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Freescale/linux-fslc/commit/d74f8108dce77b0fb2496cfe92...
git remote add freescale-fslc https://github.com/Freescale/linux-fslc
git fetch --no-tags freescale-fslc 5.4-2.3.x-imx
git checkout d74f8108dce77b0fb2496cfe92461de9766e060e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/usb/chipidea/trace.h:18,
from drivers/usb/chipidea/trace.c:11:
drivers/usb/chipidea/ci.h: In function 'ci_otg_is_fsm_mode':
>> drivers/usb/chipidea/ci.h:476:47: error: dereferencing pointer to incomplete type 'struct ci_hdrc_platform_data'
476 | struct usb_otg_caps *otg_caps = &ci->platdata->ci_otg_caps;
| ^~
--
In file included from drivers/usb/chipidea/trace.h:18,
from drivers/usb/chipidea/trace.c:11:
drivers/usb/chipidea/ci.h: In function 'ci_otg_is_fsm_mode':
>> drivers/usb/chipidea/ci.h:476:47: error: dereferencing pointer to incomplete type 'struct ci_hdrc_platform_data'
476 | struct usb_otg_caps *otg_caps = &ci->platdata->ci_otg_caps;
| ^~
In file included from drivers/usb/chipidea/trace.h:91,
from drivers/usb/chipidea/trace.c:11:
include/trace/define_trace.h: At top level:
include/trace/define_trace.h:95:42: fatal error: ./trace.h: No such file or directory
95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
| ^
compilation terminated.
vim +476 drivers/usb/chipidea/ci.h
e443b333629f82 Alexander Shishkin 2012-05-11 466
57677be5ef8387 Li Jun 2014-04-23 467 /**
57677be5ef8387 Li Jun 2014-04-23 468 * ci_otg_is_fsm_mode: runtime check if otg controller
57677be5ef8387 Li Jun 2014-04-23 469 * is in otg fsm mode.
19353881b4afc9 Peter Chen 2014-09-22 470 *
19353881b4afc9 Peter Chen 2014-09-22 471 * @ci: chipidea device
57677be5ef8387 Li Jun 2014-04-23 472 */
57677be5ef8387 Li Jun 2014-04-23 473 static inline bool ci_otg_is_fsm_mode(struct ci_hdrc *ci)
57677be5ef8387 Li Jun 2014-04-23 474 {
57677be5ef8387 Li Jun 2014-04-23 475 #ifdef CONFIG_USB_OTG_FSM
b0930d4cafb487 Li Jun 2015-07-09 @476 struct usb_otg_caps *otg_caps = &ci->platdata->ci_otg_caps;
b0930d4cafb487 Li Jun 2015-07-09 477
57677be5ef8387 Li Jun 2014-04-23 478 return ci->is_otg && ci->roles[CI_ROLE_HOST] &&
b0930d4cafb487 Li Jun 2015-07-09 479 ci->roles[CI_ROLE_GADGET] && (otg_caps->srp_support ||
b0930d4cafb487 Li Jun 2015-07-09 480 otg_caps->hnp_support || otg_caps->adp_support);
57677be5ef8387 Li Jun 2014-04-23 481 #else
57677be5ef8387 Li Jun 2014-04-23 482 return false;
57677be5ef8387 Li Jun 2014-04-23 483 #endif
57677be5ef8387 Li Jun 2014-04-23 484 }
57677be5ef8387 Li Jun 2014-04-23 485
:::::: The code at line 476 was first introduced by commit
:::::: b0930d4cafb487a663ac6780a0369d1a0f461bc2 usb: chipidea: update ci_otg_is_fsm_mode conditions
:::::: TO: Li Jun <jun.li(a)freescale.com>
:::::: CC: Felipe Balbi <balbi(a)ti.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
Re: [PATCH 1/3] drm/ttm: move swapout logic around v2
by kernel test robot
Hi "Christian,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[also build test ERROR on next-20210318]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.12-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christian-K-nig/drm-ttm-move-swa...
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-randconfig-m021-20210318 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/a454d56ea061b53d24a62a700743e4508...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christian-K-nig/drm-ttm-move-swapout-logic-around-v2/20210318-204848
git checkout a454d56ea061b53d24a62a700743e4508dd6c9b1
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/ttm/ttm_device.c:109:5: error: conflicting types for 'ttm_global_swapout'
109 | int ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags)
| ^~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/ttm/ttm_device.c:32:
include/drm/ttm/ttm_device.h:300:6: note: previous declaration of 'ttm_global_swapout' was here
300 | long ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags);
| ^~~~~~~~~~~~~~~~~~
In file included from include/linux/linkage.h:7,
from include/linux/kernel.h:7,
from include/asm-generic/bug.h:20,
from arch/x86/include/asm/bug.h:93,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/mm.h:9,
from drivers/gpu/drm/ttm/ttm_device.c:30:
drivers/gpu/drm/ttm/ttm_device.c:132:15: error: conflicting types for 'ttm_global_swapout'
132 | EXPORT_SYMBOL(ttm_global_swapout);
| ^~~~~~~~~~~~~~~~~~
include/linux/export.h:98:21: note: in definition of macro '___EXPORT_SYMBOL'
98 | extern typeof(sym) sym; \
| ^~~
include/linux/export.h:155:34: note: in expansion of macro '__EXPORT_SYMBOL'
155 | #define _EXPORT_SYMBOL(sym, sec) __EXPORT_SYMBOL(sym, sec, "")
| ^~~~~~~~~~~~~~~
include/linux/export.h:158:29: note: in expansion of macro '_EXPORT_SYMBOL'
158 | #define EXPORT_SYMBOL(sym) _EXPORT_SYMBOL(sym, "")
| ^~~~~~~~~~~~~~
drivers/gpu/drm/ttm/ttm_device.c:132:1: note: in expansion of macro 'EXPORT_SYMBOL'
132 | EXPORT_SYMBOL(ttm_global_swapout);
| ^~~~~~~~~~~~~
In file included from drivers/gpu/drm/ttm/ttm_device.c:32:
include/drm/ttm/ttm_device.h:300:6: note: previous declaration of 'ttm_global_swapout' was here
300 | long ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags);
| ^~~~~~~~~~~~~~~~~~
vim +/ttm_global_swapout +109 drivers/gpu/drm/ttm/ttm_device.c
104
105 /**
106 * A buffer object shrink method that tries to swap out the first
107 * buffer object on the global::swap_lru list.
108 */
> 109 int ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags)
110 {
111 struct ttm_global *glob = &ttm_glob;
112 struct ttm_buffer_object *bo;
113 unsigned i;
114 int ret;
115
116 spin_lock(&glob->lru_lock);
117 for (i = 0; i < TTM_MAX_BO_PRIORITY; ++i) {
118 list_for_each_entry(bo, &glob->swap_lru[i], swap) {
119 uint32_t num_pages = bo->ttm->num_pages;
120
121 ret = ttm_bo_swapout(bo, ctx, gfp_flags);
122 /* ttm_bo_swapout has dropped the lru_lock */
123 if (!ret)
124 return num_pages;
125 if (ret != -EBUSY)
126 return ret;
127 }
128 }
129 spin_unlock(&glob->lru_lock);
130 return 0;
131 }
132 EXPORT_SYMBOL(ttm_global_swapout);
133
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months
Re: [PATCH v6 3/3] mtd: rawnand: Add support for secure regions in NAND memory
by kernel test robot
Hi Manivannan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mtd/mtd/next]
[also build test WARNING on mtd/mtd/fixes mtd/nand/next v5.12-rc3 next-20210318]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Manivannan-Sadhasivam/Add-suppor...
base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
config: arm-randconfig-r023-20210318 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6db3ab2903f42712f44000afb5aa467efbd25f35)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/045edb4991f99260412ca8ecbcbf1f41f...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Manivannan-Sadhasivam/Add-support-for-secure-regions-in-NAND/20210318-204636
git checkout 045edb4991f99260412ca8ecbcbf1f41fcd30941
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/mtd/nand/raw/nand_base.c:4255:52: warning: variable 'len' is uninitialized when used here [-Wuninitialized]
ret = nand_check_secure_region(chip, instr->addr, len);
^~~
drivers/mtd/nand/raw/nand_base.c:4245:12: note: initialize the variable 'len' to silence this warning
loff_t len;
^
= 0
1 warning generated.
vim +/len +4255 drivers/mtd/nand/raw/nand_base.c
4232
4233 /**
4234 * nand_erase_nand - [INTERN] erase block(s)
4235 * @chip: NAND chip object
4236 * @instr: erase instruction
4237 * @allowbbt: allow erasing the bbt area
4238 *
4239 * Erase one ore more blocks.
4240 */
4241 int nand_erase_nand(struct nand_chip *chip, struct erase_info *instr,
4242 int allowbbt)
4243 {
4244 int page, pages_per_block, ret, chipnr;
4245 loff_t len;
4246
4247 pr_debug("%s: start = 0x%012llx, len = %llu\n",
4248 __func__, (unsigned long long)instr->addr,
4249 (unsigned long long)instr->len);
4250
4251 if (check_offs_len(chip, instr->addr, instr->len))
4252 return -EINVAL;
4253
4254 /* Check if the region is secured */
> 4255 ret = nand_check_secure_region(chip, instr->addr, len);
4256 if (ret)
4257 return ret;
4258
4259 /* Grab the lock and see if the device is available */
4260 ret = nand_get_device(chip);
4261 if (ret)
4262 return ret;
4263
4264 /* Shift to get first page */
4265 page = (int)(instr->addr >> chip->page_shift);
4266 chipnr = (int)(instr->addr >> chip->chip_shift);
4267
4268 /* Calculate pages in each block */
4269 pages_per_block = 1 << (chip->phys_erase_shift - chip->page_shift);
4270
4271 /* Select the NAND device */
4272 nand_select_target(chip, chipnr);
4273
4274 /* Check, if it is write protected */
4275 if (nand_check_wp(chip)) {
4276 pr_debug("%s: device is write protected!\n",
4277 __func__);
4278 ret = -EIO;
4279 goto erase_exit;
4280 }
4281
4282 /* Loop through the pages */
4283 len = instr->len;
4284
4285 while (len) {
4286 /* Check if we have a bad block, we do not erase bad blocks! */
4287 if (nand_block_checkbad(chip, ((loff_t) page) <<
4288 chip->page_shift, allowbbt)) {
4289 pr_warn("%s: attempt to erase a bad block at page 0x%08x\n",
4290 __func__, page);
4291 ret = -EIO;
4292 goto erase_exit;
4293 }
4294
4295 /*
4296 * Invalidate the page cache, if we erase the block which
4297 * contains the current cached page.
4298 */
4299 if (page <= chip->pagecache.page && chip->pagecache.page <
4300 (page + pages_per_block))
4301 chip->pagecache.page = -1;
4302
4303 ret = nand_erase_op(chip, (page & chip->pagemask) >>
4304 (chip->phys_erase_shift - chip->page_shift));
4305 if (ret) {
4306 pr_debug("%s: failed erase, page 0x%08x\n",
4307 __func__, page);
4308 instr->fail_addr =
4309 ((loff_t)page << chip->page_shift);
4310 goto erase_exit;
4311 }
4312
4313 /* Increment page address and decrement length */
4314 len -= (1ULL << chip->phys_erase_shift);
4315 page += pages_per_block;
4316
4317 /* Check, if we cross a chip boundary */
4318 if (len && !(page & chip->pagemask)) {
4319 chipnr++;
4320 nand_deselect_target(chip);
4321 nand_select_target(chip, chipnr);
4322 }
4323 }
4324
4325 ret = 0;
4326 erase_exit:
4327
4328 /* Deselect and wake up anyone waiting on the device */
4329 nand_deselect_target(chip);
4330 nand_release_device(chip);
4331
4332 /* Return more or less happy */
4333 return ret;
4334 }
4335
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 6 months