Re: [PATCH 04/15] wireless: align some HE capabilities with the spec
by kernel test robot
Hi Luca,
I love your patch! Yet something to improve:
[auto build test ERROR on mac80211-next/master]
[also build test ERROR on mac80211/master wireless-drivers-next/master wireless-drivers/master v5.12-rc6 next-20210409]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Luca-Coelho/cfg80211-mac80211-pa...
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: x86_64-randconfig-a006-20210409 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project dd453a1389b6a7e6d9214b449d3c54981b1a89b6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/13582e33bee8630eb3f2d4299b14e989b...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Luca-Coelho/cfg80211-mac80211-patches-from-our-internal-tree-2021-04-09/20210409-181210
git checkout 13582e33bee8630eb3f2d4299b14e989bc06d297
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/net/wireless/ath/ath11k/mac.c:3810:6: error: use of undeclared identifier 'IEEE80211_HE_MAC_CAP5_SUBCHAN_SELECVITE_TRANSMISSION'
m = IEEE80211_HE_MAC_CAP5_SUBCHAN_SELECVITE_TRANSMISSION |
^
>> drivers/net/wireless/ath/ath11k/mac.c:3820:6: error: use of undeclared identifier 'IEEE80211_HE_PHY_CAP3_RX_HE_MU_PPDU_FROM_NON_AP_STA'
m = IEEE80211_HE_PHY_CAP3_RX_HE_MU_PPDU_FROM_NON_AP_STA |
^
>> drivers/net/wireless/ath/ath11k/mac.c:3832:6: error: use of undeclared identifier 'IEEE80211_HE_PHY_CAP6_TRIG_MU_BEAMFORMER_FB'
IEEE80211_HE_PHY_CAP6_TRIG_MU_BEAMFORMER_FB |
^
>> drivers/net/wireless/ath/ath11k/mac.c:3837:6: error: use of undeclared identifier 'IEEE80211_HE_PHY_CAP7_SRP_BASED_SR'
m = IEEE80211_HE_PHY_CAP7_SRP_BASED_SR |
^
>> drivers/net/wireless/ath/ath11k/mac.c:3838:6: error: use of undeclared identifier 'IEEE80211_HE_PHY_CAP7_POWER_BOOST_FACTOR_AR'
IEEE80211_HE_PHY_CAP7_POWER_BOOST_FACTOR_AR |
^
5 errors generated.
vim +/IEEE80211_HE_MAC_CAP5_SUBCHAN_SELECVITE_TRANSMISSION +3810 drivers/net/wireless/ath/ath11k/mac.c
9f056ed8ee01ad John Crispin 2019-11-25 3786
13591a1c3899cf Sven Eckelmann 2019-12-10 3787 static void
13591a1c3899cf Sven Eckelmann 2019-12-10 3788 ath11k_mac_filter_he_cap_mesh(struct ieee80211_he_cap_elem *he_cap_elem)
13591a1c3899cf Sven Eckelmann 2019-12-10 3789 {
13591a1c3899cf Sven Eckelmann 2019-12-10 3790 u8 m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3791
13591a1c3899cf Sven Eckelmann 2019-12-10 3792 m = IEEE80211_HE_MAC_CAP0_TWT_RES |
13591a1c3899cf Sven Eckelmann 2019-12-10 3793 IEEE80211_HE_MAC_CAP0_TWT_REQ;
13591a1c3899cf Sven Eckelmann 2019-12-10 3794 he_cap_elem->mac_cap_info[0] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3795
13591a1c3899cf Sven Eckelmann 2019-12-10 3796 m = IEEE80211_HE_MAC_CAP2_TRS |
13591a1c3899cf Sven Eckelmann 2019-12-10 3797 IEEE80211_HE_MAC_CAP2_BCAST_TWT |
13591a1c3899cf Sven Eckelmann 2019-12-10 3798 IEEE80211_HE_MAC_CAP2_MU_CASCADING;
13591a1c3899cf Sven Eckelmann 2019-12-10 3799 he_cap_elem->mac_cap_info[2] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3800
13591a1c3899cf Sven Eckelmann 2019-12-10 3801 m = IEEE80211_HE_MAC_CAP3_FLEX_TWT_SCHED |
13591a1c3899cf Sven Eckelmann 2019-12-10 3802 IEEE80211_HE_MAC_CAP2_BCAST_TWT |
13591a1c3899cf Sven Eckelmann 2019-12-10 3803 IEEE80211_HE_MAC_CAP2_MU_CASCADING;
13591a1c3899cf Sven Eckelmann 2019-12-10 3804 he_cap_elem->mac_cap_info[3] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3805
13591a1c3899cf Sven Eckelmann 2019-12-10 3806 m = IEEE80211_HE_MAC_CAP4_BSRP_BQRP_A_MPDU_AGG |
13591a1c3899cf Sven Eckelmann 2019-12-10 3807 IEEE80211_HE_MAC_CAP4_BQR;
13591a1c3899cf Sven Eckelmann 2019-12-10 3808 he_cap_elem->mac_cap_info[4] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3809
13591a1c3899cf Sven Eckelmann 2019-12-10 @3810 m = IEEE80211_HE_MAC_CAP5_SUBCHAN_SELECVITE_TRANSMISSION |
13591a1c3899cf Sven Eckelmann 2019-12-10 3811 IEEE80211_HE_MAC_CAP5_UL_2x996_TONE_RU |
13591a1c3899cf Sven Eckelmann 2019-12-10 3812 IEEE80211_HE_MAC_CAP5_PUNCTURED_SOUNDING |
13591a1c3899cf Sven Eckelmann 2019-12-10 3813 IEEE80211_HE_MAC_CAP5_HT_VHT_TRIG_FRAME_RX;
13591a1c3899cf Sven Eckelmann 2019-12-10 3814 he_cap_elem->mac_cap_info[5] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3815
13591a1c3899cf Sven Eckelmann 2019-12-10 3816 m = IEEE80211_HE_PHY_CAP2_UL_MU_FULL_MU_MIMO |
13591a1c3899cf Sven Eckelmann 2019-12-10 3817 IEEE80211_HE_PHY_CAP2_UL_MU_PARTIAL_MU_MIMO;
13591a1c3899cf Sven Eckelmann 2019-12-10 3818 he_cap_elem->phy_cap_info[2] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3819
13591a1c3899cf Sven Eckelmann 2019-12-10 @3820 m = IEEE80211_HE_PHY_CAP3_RX_HE_MU_PPDU_FROM_NON_AP_STA |
13591a1c3899cf Sven Eckelmann 2019-12-10 3821 IEEE80211_HE_PHY_CAP3_DCM_MAX_CONST_TX_MASK |
13591a1c3899cf Sven Eckelmann 2019-12-10 3822 IEEE80211_HE_PHY_CAP3_DCM_MAX_CONST_RX_MASK;
13591a1c3899cf Sven Eckelmann 2019-12-10 3823 he_cap_elem->phy_cap_info[3] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3824
13591a1c3899cf Sven Eckelmann 2019-12-10 3825 m = IEEE80211_HE_PHY_CAP4_MU_BEAMFORMER;
13591a1c3899cf Sven Eckelmann 2019-12-10 3826 he_cap_elem->phy_cap_info[4] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3827
13591a1c3899cf Sven Eckelmann 2019-12-10 3828 m = IEEE80211_HE_PHY_CAP5_NG16_MU_FEEDBACK;
13591a1c3899cf Sven Eckelmann 2019-12-10 3829 he_cap_elem->phy_cap_info[5] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3830
13591a1c3899cf Sven Eckelmann 2019-12-10 3831 m = IEEE80211_HE_PHY_CAP6_CODEBOOK_SIZE_75_MU |
13591a1c3899cf Sven Eckelmann 2019-12-10 @3832 IEEE80211_HE_PHY_CAP6_TRIG_MU_BEAMFORMER_FB |
13591a1c3899cf Sven Eckelmann 2019-12-10 3833 IEEE80211_HE_PHY_CAP6_TRIG_CQI_FB |
13591a1c3899cf Sven Eckelmann 2019-12-10 3834 IEEE80211_HE_PHY_CAP6_PARTIAL_BANDWIDTH_DL_MUMIMO;
13591a1c3899cf Sven Eckelmann 2019-12-10 3835 he_cap_elem->phy_cap_info[6] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3836
13591a1c3899cf Sven Eckelmann 2019-12-10 @3837 m = IEEE80211_HE_PHY_CAP7_SRP_BASED_SR |
13591a1c3899cf Sven Eckelmann 2019-12-10 @3838 IEEE80211_HE_PHY_CAP7_POWER_BOOST_FACTOR_AR |
13591a1c3899cf Sven Eckelmann 2019-12-10 3839 IEEE80211_HE_PHY_CAP7_STBC_TX_ABOVE_80MHZ |
13591a1c3899cf Sven Eckelmann 2019-12-10 3840 IEEE80211_HE_PHY_CAP7_STBC_RX_ABOVE_80MHZ;
13591a1c3899cf Sven Eckelmann 2019-12-10 3841 he_cap_elem->phy_cap_info[7] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3842
13591a1c3899cf Sven Eckelmann 2019-12-10 3843 m = IEEE80211_HE_PHY_CAP8_HE_ER_SU_PPDU_4XLTF_AND_08_US_GI |
13591a1c3899cf Sven Eckelmann 2019-12-10 3844 IEEE80211_HE_PHY_CAP8_20MHZ_IN_40MHZ_HE_PPDU_IN_2G |
13591a1c3899cf Sven Eckelmann 2019-12-10 3845 IEEE80211_HE_PHY_CAP8_20MHZ_IN_160MHZ_HE_PPDU |
13591a1c3899cf Sven Eckelmann 2019-12-10 3846 IEEE80211_HE_PHY_CAP8_80MHZ_IN_160MHZ_HE_PPDU;
13591a1c3899cf Sven Eckelmann 2019-12-10 3847 he_cap_elem->phy_cap_info[8] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3848
13591a1c3899cf Sven Eckelmann 2019-12-10 3849 m = IEEE80211_HE_PHY_CAP9_LONGER_THAN_16_SIGB_OFDM_SYM |
13591a1c3899cf Sven Eckelmann 2019-12-10 3850 IEEE80211_HE_PHY_CAP9_NON_TRIGGERED_CQI_FEEDBACK |
13591a1c3899cf Sven Eckelmann 2019-12-10 3851 IEEE80211_HE_PHY_CAP9_RX_1024_QAM_LESS_THAN_242_TONE_RU |
13591a1c3899cf Sven Eckelmann 2019-12-10 3852 IEEE80211_HE_PHY_CAP9_TX_1024_QAM_LESS_THAN_242_TONE_RU |
13591a1c3899cf Sven Eckelmann 2019-12-10 3853 IEEE80211_HE_PHY_CAP9_RX_FULL_BW_SU_USING_MU_WITH_COMP_SIGB |
13591a1c3899cf Sven Eckelmann 2019-12-10 3854 IEEE80211_HE_PHY_CAP9_RX_FULL_BW_SU_USING_MU_WITH_NON_COMP_SIGB;
13591a1c3899cf Sven Eckelmann 2019-12-10 3855 he_cap_elem->phy_cap_info[9] &= ~m;
13591a1c3899cf Sven Eckelmann 2019-12-10 3856 }
13591a1c3899cf Sven Eckelmann 2019-12-10 3857
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[intel-linux-intel-lts:4.19/android_r 18601/22631] drivers/usb/host/xhci-dbgtty.c:497:6: warning: no previous prototype for 'xhci_dbc_tty_unregister_device'
by kernel test robot
tree: https://github.com/intel/linux-intel-lts.git 4.19/android_r
head: 072f407465e8e25a3c2c22590e1ab72ccf335151
commit: 77896075c455635a9e8c59ade5e30b75711cc099 [18601/22631] usb: xhci: dbc: DbC TTY driver to use new interface
config: ia64-randconfig-r034-20210409 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel/linux-intel-lts/commit/77896075c455635a9e8c59ade...
git remote add intel-linux-intel-lts https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-linux-intel-lts 4.19/android_r
git checkout 77896075c455635a9e8c59ade5e30b75711cc099
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from arch/ia64/include/asm/pgtable.h:154,
from include/linux/memremap.h:7,
from include/linux/mm.h:27,
from arch/ia64/include/asm/uaccess.h:38,
from include/linux/uaccess.h:14,
from arch/ia64/include/asm/sections.h:11,
from include/linux/interrupt.h:20,
from include/linux/usb.h:16,
from drivers/usb/host/xhci.h:15,
from drivers/usb/host/xhci-dbgtty.c:14:
arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
arch/ia64/include/asm/mmu_context.h:137:41: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
137 | unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
| ^~~~~~~
In file included from include/linux/kernel.h:10,
from include/linux/list.h:9,
from include/linux/module.h:9,
from drivers/usb/host/xhci-dbgtty.c:10:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/ia64/include/asm/page.h:118:36: error: 'max_mapnr' undeclared (first use in this function); did you mean 'set_max_mapnr'?
118 | # define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
| ^~~~~~~~~
include/linux/compiler.h:77:42: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
arch/ia64/include/asm/page.h:96:32: note: in expansion of macro 'pfn_valid'
96 | #define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT)
| ^~~~~~~~~
include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
arch/ia64/include/asm/page.h:118:36: note: each undeclared identifier is reported only once for each function it appears in
118 | # define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
| ^~~~~~~~~
include/linux/compiler.h:77:42: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
arch/ia64/include/asm/page.h:96:32: note: in expansion of macro 'pfn_valid'
96 | #define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT)
| ^~~~~~~~~
include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
drivers/usb/host/xhci-dbgtty.c: At top level:
>> drivers/usb/host/xhci-dbgtty.c:497:6: warning: no previous prototype for 'xhci_dbc_tty_unregister_device' [-Wmissing-prototypes]
497 | void xhci_dbc_tty_unregister_device(struct xhci_hcd *xhci)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for NUMA
Depends on !IA64_HP_SIM && !FLATMEM
Selected by
- IA64_SGI_UV && <choice>
vim +/xhci_dbc_tty_unregister_device +497 drivers/usb/host/xhci-dbgtty.c
dfba2174dc421e Lu Baolu 2017-12-08 496
dfba2174dc421e Lu Baolu 2017-12-08 @497 void xhci_dbc_tty_unregister_device(struct xhci_hcd *xhci)
dfba2174dc421e Lu Baolu 2017-12-08 498 {
dfba2174dc421e Lu Baolu 2017-12-08 499 struct xhci_dbc *dbc = xhci->dbc;
dfba2174dc421e Lu Baolu 2017-12-08 500 struct dbc_port *port = &dbc->port;
77896075c45563 Prabhat Chand Pandey 2019-01-30 501 struct tty_driver *dbc_tty_driver =
77896075c45563 Prabhat Chand Pandey 2019-01-30 502 (struct tty_driver *) dbc->func_priv;
dfba2174dc421e Lu Baolu 2017-12-08 503
dfba2174dc421e Lu Baolu 2017-12-08 504 tty_unregister_device(dbc_tty_driver, 0);
dfba2174dc421e Lu Baolu 2017-12-08 505 xhci_dbc_tty_exit_port(port);
dfba2174dc421e Lu Baolu 2017-12-08 506 port->registered = false;
dfba2174dc421e Lu Baolu 2017-12-08 507
dfba2174dc421e Lu Baolu 2017-12-08 508 kfifo_free(&port->write_fifo);
dfba2174dc421e Lu Baolu 2017-12-08 509 xhci_dbc_free_requests(get_out_ep(xhci), &port->read_pool);
dfba2174dc421e Lu Baolu 2017-12-08 510 xhci_dbc_free_requests(get_out_ep(xhci), &port->read_queue);
dfba2174dc421e Lu Baolu 2017-12-08 511 xhci_dbc_free_requests(get_in_ep(xhci), &port->write_pool);
dfba2174dc421e Lu Baolu 2017-12-08 512 }
77896075c45563 Prabhat Chand Pandey 2019-01-30 513
:::::: The code at line 497 was first introduced by commit
:::::: dfba2174dc421ecad8dc50741054a305cd3ba681 usb: xhci: Add DbC support in xHCI driver
:::::: TO: Lu Baolu <baolu.lu(a)linux.intel.com>
:::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[intel-linux-intel-lts:4.19/android_r 18600/22631] drivers/usb/host/xhci-dbgcap.c:191:6: warning: no previous prototype for 'xhci_dbc_flush_requests'
by kernel test robot
Hi Prabhat,
FYI, the error/warning still remains.
tree: https://github.com/intel/linux-intel-lts.git 4.19/android_r
head: 072f407465e8e25a3c2c22590e1ab72ccf335151
commit: b88d999a5b9ae9022e12e1a5810b12b21cb77996 [18600/22631] usb: xhci: dbc: make DbC modular, introducing dbc_function structure
config: ia64-randconfig-r034-20210409 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel/linux-intel-lts/commit/b88d999a5b9ae9022e12e1a58...
git remote add intel-linux-intel-lts https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-linux-intel-lts 4.19/android_r
git checkout b88d999a5b9ae9022e12e1a5810b12b21cb77996
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from arch/ia64/include/asm/pgtable.h:154,
from include/linux/memremap.h:7,
from include/linux/mm.h:27,
from include/linux/scatterlist.h:8,
from include/linux/dma-mapping.h:11,
from drivers/usb/host/xhci-dbgcap.c:9:
arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
arch/ia64/include/asm/mmu_context.h:137:41: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
137 | unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
| ^~~~~~~
In file included from include/linux/string.h:6,
from include/linux/dma-mapping.h:6,
from drivers/usb/host/xhci-dbgcap.c:9:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/ia64/include/asm/page.h:118:36: error: 'max_mapnr' undeclared (first use in this function); did you mean 'set_max_mapnr'?
118 | # define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
| ^~~~~~~~~
include/linux/compiler.h:77:42: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
arch/ia64/include/asm/page.h:96:32: note: in expansion of macro 'pfn_valid'
96 | #define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT)
| ^~~~~~~~~
include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
arch/ia64/include/asm/page.h:118:36: note: each undeclared identifier is reported only once for each function it appears in
118 | # define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
| ^~~~~~~~~
include/linux/compiler.h:77:42: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
arch/ia64/include/asm/page.h:96:32: note: in expansion of macro 'pfn_valid'
96 | #define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT)
| ^~~~~~~~~
include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/ia64/include/asm/page.h:118:36: error: 'max_mapnr' undeclared (first use in this function); did you mean 'set_max_mapnr'?
118 | # define pfn_valid(pfn) (((pfn) < max_mapnr) && ia64_pfn_valid(pfn))
| ^~~~~~~~~
include/linux/compiler.h:77:42: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/dma-mapping.h:329:2: note: in expansion of macro 'BUG_ON'
329 | BUG_ON(pfn_valid(PHYS_PFN(phys_addr)));
| ^~~~~~
include/linux/dma-mapping.h:329:9: note: in expansion of macro 'pfn_valid'
329 | BUG_ON(pfn_valid(PHYS_PFN(phys_addr)));
| ^~~~~~~~~
drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_populate_strings':
drivers/usb/host/xhci-dbgcap.c:50:36: warning: taking address of packed member of 'struct usb_string_descriptor' may result in an unaligned pointer value [-Waddress-of-packed-member]
50 | UTF16_LITTLE_ENDIAN, (wchar_t *)s_desc->wData,
| ^~~~~~
drivers/usb/host/xhci-dbgcap.c:61:36: warning: taking address of packed member of 'struct usb_string_descriptor' may result in an unaligned pointer value [-Waddress-of-packed-member]
61 | UTF16_LITTLE_ENDIAN, (wchar_t *)s_desc->wData,
| ^~~~~~
drivers/usb/host/xhci-dbgcap.c:73:36: warning: taking address of packed member of 'struct usb_string_descriptor' may result in an unaligned pointer value [-Waddress-of-packed-member]
73 | UTF16_LITTLE_ENDIAN, (wchar_t *)s_desc->wData,
| ^~~~~~
drivers/usb/host/xhci-dbgcap.c: At top level:
>> drivers/usb/host/xhci-dbgcap.c:191:6: warning: no previous prototype for 'xhci_dbc_flush_requests' [-Wmissing-prototypes]
191 | void xhci_dbc_flush_requests(struct xhci_dbc *dbc)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_handle_events':
>> drivers/usb/host/xhci-dbgcap.c:794:8: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
794 | int ret;
| ^~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for NUMA
Depends on !IA64_HP_SIM && !FLATMEM
Selected by
- IA64_SGI_UV && <choice>
vim +/xhci_dbc_flush_requests +191 drivers/usb/host/xhci-dbgcap.c
189
190
> 191 void xhci_dbc_flush_requests(struct xhci_dbc *dbc)
192 {
193 xhci_dbc_flush_endpoint_requests(&dbc->eps[BULK_OUT]);
194 xhci_dbc_flush_endpoint_requests(&dbc->eps[BULK_IN]);
195 }
196 EXPORT_SYMBOL_GPL(xhci_dbc_flush_requests);
197
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [RFC] net: core: devlink: add port_params_ops for devlink port parameters altering
by kernel test robot
Hi Oleksandr,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net/master]
[also build test WARNING on net-next/master ipvs/master linus/master v5.12-rc6 next-20210409]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Oleksandr-Mazur/net-core-devlink...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 864db232dc7036aa2de19749c3d5be0143b24f8f
config: i386-randconfig-s031-20210409 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-279-g6d5d9b42-dirty
# https://github.com/0day-ci/linux/commit/7e224a25c3c6be88530f86f7f5dd9e668...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Oleksandr-Mazur/net-core-devlink-add-port_params_ops-for-devlink-port-parameters-altering/20210410-002443
git checkout 7e224a25c3c6be88530f86f7f5dd9e668d3b5620
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/netdevsim/dev.c:923:28: sparse: sparse: incorrect type in initializer (different modifiers) @@ expected struct devlink_port_param_ops *port_param_ops @@ got struct devlink_port_param_ops const * @@
drivers/net/netdevsim/dev.c:923:28: sparse: expected struct devlink_port_param_ops *port_param_ops
drivers/net/netdevsim/dev.c:923:28: sparse: got struct devlink_port_param_ops const *
vim +923 drivers/net/netdevsim/dev.c
909
910 static const struct devlink_ops nsim_dev_devlink_ops = {
911 .supported_flash_update_params = DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT |
912 DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK,
913 .reload_actions = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT),
914 .reload_down = nsim_dev_reload_down,
915 .reload_up = nsim_dev_reload_up,
916 .info_get = nsim_dev_info_get,
917 .flash_update = nsim_dev_flash_update,
918 .trap_init = nsim_dev_devlink_trap_init,
919 .trap_action_set = nsim_dev_devlink_trap_action_set,
920 .trap_group_set = nsim_dev_devlink_trap_group_set,
921 .trap_policer_set = nsim_dev_devlink_trap_policer_set,
922 .trap_policer_counter_get = nsim_dev_devlink_trap_policer_counter_get,
> 923 .port_param_ops = &nsim_dev_port_param_ops,
924 };
925
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH net-next 2/3] net: use skb_for_each_frag() helper where possible
by kernel test robot
Hi Matteo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Matteo-Croce/introduce-skb_for_e...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4438669eb703d1a7416c2b19a8a15b0400b36738
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/9a46b324d3f1ca289db31c0011a6bbfd5...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Matteo-Croce/introduce-skb_for_each_frag/20210410-020828
git checkout 9a46b324d3f1ca289db31c0011a6bbfd5ae06918
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c: In function 'netxen_map_tx_skb':
>> drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c:1975:9: warning: variable 'nr_frags' set but not used [-Wunused-but-set-variable]
1975 | int i, nr_frags;
| ^~~~~~~~
--
drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c: In function 'qlcnic_map_tx_skb':
>> drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:584:9: warning: variable 'nr_frags' set but not used [-Wunused-but-set-variable]
584 | int i, nr_frags;
| ^~~~~~~~
vim +/nr_frags +1975 drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
cd1f8160e015cd drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2008-07-21 1968
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1969 static int
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1970 netxen_map_tx_skb(struct pci_dev *pdev,
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1971 struct sk_buff *skb, struct netxen_cmd_buffer *pbuf)
6f70340698333f drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-01-14 1972 {
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1973 struct netxen_skb_frag *nf;
d7840976e39156 drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Matthew Wilcox (Oracle 2019-07-22 1974) skb_frag_t *frag;
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 @1975 int i, nr_frags;
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1976 dma_addr_t map;
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1977
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1978 nr_frags = skb_shinfo(skb)->nr_frags;
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1979 nf = &pbuf->frag_array[0];
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1980
297af515d75f5c drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Christophe JAILLET 2021-01-13 1981 map = dma_map_single(&pdev->dev, skb->data, skb_headlen(skb),
297af515d75f5c drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Christophe JAILLET 2021-01-13 1982 DMA_TO_DEVICE);
297af515d75f5c drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Christophe JAILLET 2021-01-13 1983 if (dma_mapping_error(&pdev->dev, map))
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1984 goto out_err;
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1985
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1986 nf->dma = map;
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1987 nf->length = skb_headlen(skb);
6f70340698333f drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-01-14 1988
9a46b324d3f1ca drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Matteo Croce 2021-04-09 1989 skb_for_each_frag(skb, i) {
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1990 frag = &skb_shinfo(skb)->frags[i];
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1991 nf = &pbuf->frag_array[i+1];
6f70340698333f drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-01-14 1992
9e903e085262ff drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Eric Dumazet 2011-10-18 1993 map = skb_frag_dma_map(&pdev->dev, frag, 0, skb_frag_size(frag),
5d6bcdfe38ce88 drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Ian Campbell 2011-10-06 1994 DMA_TO_DEVICE);
5d6bcdfe38ce88 drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Ian Campbell 2011-10-06 1995 if (dma_mapping_error(&pdev->dev, map))
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1996 goto unwind;
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1997
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 1998 nf->dma = map;
9e903e085262ff drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Eric Dumazet 2011-10-18 1999 nf->length = skb_frag_size(frag);
6f70340698333f drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-01-14 2000 }
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 2001
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 2002 return 0;
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 2003
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 2004 unwind:
cf503e8f458cec drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-09-03 2005 while (--i >= 0) {
cf503e8f458cec drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-09-03 2006 nf = &pbuf->frag_array[i+1];
297af515d75f5c drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Christophe JAILLET 2021-01-13 2007 dma_unmap_page(&pdev->dev, nf->dma, nf->length, DMA_TO_DEVICE);
a05948f296ce10 drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Eric Dumazet 2013-01-22 2008 nf->dma = 0ULL;
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 2009 }
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 2010
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 2011 nf = &pbuf->frag_array[0];
297af515d75f5c drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Christophe JAILLET 2021-01-13 2012 dma_unmap_single(&pdev->dev, nf->dma, skb_headlen(skb), DMA_TO_DEVICE);
a05948f296ce10 drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c Eric Dumazet 2013-01-22 2013 nf->dma = 0ULL;
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 2014
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 2015 out_err:
ce644ed4db3ee1 drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-08-23 2016 return -ENOMEM;
6f70340698333f drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-01-14 2017 }
6f70340698333f drivers/net/netxen/netxen_nic_main.c Dhananjay Phadke 2009-01-14 2018
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[ext4:dev 9/17] fs/ext4/fast_commit.c:1738:5: warning: format specifies type 'int' but the argument has type 'unsigned long'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
head: 21175ca434c5d49509b73cf473618b01b0b85437
commit: d556435156b7970b8ce61b355df558a5168927cc [9/17] jbd2: avoid -Wempty-body warnings
config: riscv-randconfig-r005-20210409 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project dd453a1389b6a7e6d9214b449d3c54981b1a89b6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?id...
git remote add ext4 https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git
git fetch --no-tags ext4 dev
git checkout d556435156b7970b8ce61b355df558a5168927cc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> fs/ext4/fast_commit.c:1738:5: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
map.m_flags & EXT4_MAP_UNWRITTEN,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/jbd2.h:64:51: note: expanded from macro 'jbd_debug'
#define jbd_debug(n, fmt, a...) no_printk(fmt, ##a)
~~~ ^
include/linux/printk.h:140:17: note: expanded from macro 'no_printk'
printk(fmt, ##__VA_ARGS__); \
~~~ ^~~~~~~~~~~
1 warning generated.
--
>> fs/jbd2/recovery.c:256:54: warning: more '%' conversions than data arguments [-Wformat-insufficient-args]
jbd_debug(3, "Processing fast commit blk with seq %d");
~^
include/linux/jbd2.h:64:44: note: expanded from macro 'jbd_debug'
#define jbd_debug(n, fmt, a...) no_printk(fmt, ##a)
^~~
include/linux/printk.h:140:10: note: expanded from macro 'no_printk'
printk(fmt, ##__VA_ARGS__); \
^~~
1 warning generated.
vim +1738 fs/ext4/fast_commit.c
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1631
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1632 /* Replay add range tag */
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1633 static int ext4_fc_replay_add_range(struct super_block *sb,
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1634 struct ext4_fc_tl *tl)
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1635 {
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1636 struct ext4_fc_add_range *fc_add_ex;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1637 struct ext4_extent newex, *ex;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1638 struct inode *inode;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1639 ext4_lblk_t start, cur;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1640 int remaining, len;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1641 ext4_fsblk_t start_pblk;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1642 struct ext4_map_blocks map;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1643 struct ext4_ext_path *path = NULL;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1644 int ret;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1645
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1646 fc_add_ex = (struct ext4_fc_add_range *)ext4_fc_tag_val(tl);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1647 ex = (struct ext4_extent *)&fc_add_ex->fc_ex;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1648
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1649 trace_ext4_fc_replay(sb, EXT4_FC_TAG_ADD_RANGE,
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1650 le32_to_cpu(fc_add_ex->fc_ino), le32_to_cpu(ex->ee_block),
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1651 ext4_ext_get_actual_len(ex));
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1652
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1653 inode = ext4_iget(sb, le32_to_cpu(fc_add_ex->fc_ino),
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1654 EXT4_IGET_NORMAL);
23dd561ad9eae0 Yi Li 2020-12-30 1655 if (IS_ERR(inode)) {
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1656 jbd_debug(1, "Inode not found.");
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1657 return 0;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1658 }
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1659
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1660 ret = ext4_fc_record_modified_inode(sb, inode->i_ino);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1661
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1662 start = le32_to_cpu(ex->ee_block);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1663 start_pblk = ext4_ext_pblock(ex);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1664 len = ext4_ext_get_actual_len(ex);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1665
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1666 cur = start;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1667 remaining = len;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1668 jbd_debug(1, "ADD_RANGE, lblk %d, pblk %lld, len %d, unwritten %d, inode %ld\n",
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1669 start, start_pblk, len, ext4_ext_is_unwritten(ex),
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1670 inode->i_ino);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1671
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1672 while (remaining > 0) {
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1673 map.m_lblk = cur;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1674 map.m_len = remaining;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1675 map.m_pblk = 0;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1676 ret = ext4_map_blocks(NULL, inode, &map, 0);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1677
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1678 if (ret < 0) {
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1679 iput(inode);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1680 return 0;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1681 }
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1682
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1683 if (ret == 0) {
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1684 /* Range is not mapped */
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1685 path = ext4_find_extent(inode, cur, NULL, 0);
8c9be1e58a8dc0 Harshad Shirwadkar 2020-10-27 1686 if (IS_ERR(path)) {
8c9be1e58a8dc0 Harshad Shirwadkar 2020-10-27 1687 iput(inode);
8c9be1e58a8dc0 Harshad Shirwadkar 2020-10-27 1688 return 0;
8c9be1e58a8dc0 Harshad Shirwadkar 2020-10-27 1689 }
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1690 memset(&newex, 0, sizeof(newex));
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1691 newex.ee_block = cpu_to_le32(cur);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1692 ext4_ext_store_pblock(
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1693 &newex, start_pblk + cur - start);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1694 newex.ee_len = cpu_to_le16(map.m_len);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1695 if (ext4_ext_is_unwritten(ex))
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1696 ext4_ext_mark_unwritten(&newex);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1697 down_write(&EXT4_I(inode)->i_data_sem);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1698 ret = ext4_ext_insert_extent(
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1699 NULL, inode, &path, &newex, 0);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1700 up_write((&EXT4_I(inode)->i_data_sem));
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1701 ext4_ext_drop_refs(path);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1702 kfree(path);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1703 if (ret) {
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1704 iput(inode);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1705 return 0;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1706 }
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1707 goto next;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1708 }
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1709
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1710 if (start_pblk + cur - start != map.m_pblk) {
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1711 /*
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1712 * Logical to physical mapping changed. This can happen
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1713 * if this range was removed and then reallocated to
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1714 * map to new physical blocks during a fast commit.
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1715 */
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1716 ret = ext4_ext_replay_update_ex(inode, cur, map.m_len,
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1717 ext4_ext_is_unwritten(ex),
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1718 start_pblk + cur - start);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1719 if (ret) {
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1720 iput(inode);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1721 return 0;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1722 }
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1723 /*
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1724 * Mark the old blocks as free since they aren't used
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1725 * anymore. We maintain an array of all the modified
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1726 * inodes. In case these blocks are still used at either
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1727 * a different logical range in the same inode or in
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1728 * some different inode, we will mark them as allocated
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1729 * at the end of the FC replay using our array of
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1730 * modified inodes.
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1731 */
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1732 ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1733 goto next;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1734 }
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1735
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1736 /* Range is mapped and needs a state change */
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1737 jbd_debug(1, "Converting from %d to %d %lld",
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 @1738 map.m_flags & EXT4_MAP_UNWRITTEN,
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1739 ext4_ext_is_unwritten(ex), map.m_pblk);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1740 ret = ext4_ext_replay_update_ex(inode, cur, map.m_len,
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1741 ext4_ext_is_unwritten(ex), map.m_pblk);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1742 if (ret) {
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1743 iput(inode);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1744 return 0;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1745 }
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1746 /*
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1747 * We may have split the extent tree while toggling the state.
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1748 * Try to shrink the extent tree now.
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1749 */
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1750 ext4_ext_replay_shrink_inode(inode, start + len);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1751 next:
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1752 cur += map.m_len;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1753 remaining -= map.m_len;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1754 }
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1755 ext4_ext_replay_shrink_inode(inode, i_size_read(inode) >>
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1756 sb->s_blocksize_bits);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1757 iput(inode);
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1758 return 0;
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1759 }
8016e29f4362e2 Harshad Shirwadkar 2020-10-15 1760
:::::: The code at line 1738 was first introduced by commit
:::::: 8016e29f4362e285f0f7e38fadc61a5b7bdfdfa2 ext4: fast commit recovery path
:::::: TO: Harshad Shirwadkar <harshadshirwadkar(a)gmail.com>
:::::: CC: Theodore Ts'o <tytso(a)mit.edu>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [RFC] net: core: devlink: add port_params_ops for devlink port parameters altering
by kernel test robot
Hi Oleksandr,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on net/master]
[also build test ERROR on net-next/master ipvs/master linus/master v5.12-rc6 next-20210409]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Oleksandr-Mazur/net-core-devlink...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 864db232dc7036aa2de19749c3d5be0143b24f8f
config: arm64-randconfig-r033-20210409 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project dd453a1389b6a7e6d9214b449d3c54981b1a89b6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/7e224a25c3c6be88530f86f7f5dd9e668...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Oleksandr-Mazur/net-core-devlink-add-port_params_ops-for-devlink-port-parameters-altering/20210410-002443
git checkout 7e224a25c3c6be88530f86f7f5dd9e668d3b5620
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/net/netdevsim/dev.c:923:20: error: initializing 'struct devlink_port_param_ops *' with an expression of type 'const struct devlink_port_param_ops *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
.port_param_ops = &nsim_dev_port_param_ops,
^~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
vim +923 drivers/net/netdevsim/dev.c
909
910 static const struct devlink_ops nsim_dev_devlink_ops = {
911 .supported_flash_update_params = DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT |
912 DEVLINK_SUPPORT_FLASH_UPDATE_OVERWRITE_MASK,
913 .reload_actions = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT),
914 .reload_down = nsim_dev_reload_down,
915 .reload_up = nsim_dev_reload_up,
916 .info_get = nsim_dev_info_get,
917 .flash_update = nsim_dev_flash_update,
918 .trap_init = nsim_dev_devlink_trap_init,
919 .trap_action_set = nsim_dev_devlink_trap_action_set,
920 .trap_group_set = nsim_dev_devlink_trap_group_set,
921 .trap_policer_set = nsim_dev_devlink_trap_policer_set,
922 .trap_policer_counter_get = nsim_dev_devlink_trap_policer_counter_get,
> 923 .port_param_ops = &nsim_dev_port_param_ops,
924 };
925
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months