[jens.wiklander:testing/tuxbuild 2/9] drivers/tee/tee_shm_pool.c:17:20: sparse: sparse: incompatible types in comparison expression (different type sizes):
by kernel test robot
tree: https://git.linaro.org/people/jens.wiklander/linux-tee.git testing/tuxbuild
head: 64b34f1f528483a323edea85a568a5edd5c5995f
commit: 563d58a2fc7eb34648cd7b57e30b15dfc03677e5 [2/9] tee: simplify shm pool handling
config: sparc64-randconfig-s032-20210416 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-280-g2cd6d34e-dirty
git remote add jens.wiklander https://git.linaro.org/people/jens.wiklander/linux-tee.git
git fetch --no-tags jens.wiklander testing/tuxbuild
git checkout 563d58a2fc7eb34648cd7b57e30b15dfc03677e5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/tee/tee_shm_pool.c:17:20: sparse: sparse: incompatible types in comparison expression (different type sizes):
>> drivers/tee/tee_shm_pool.c:17:20: sparse: unsigned long *
>> drivers/tee/tee_shm_pool.c:17:20: sparse: unsigned int *
vim +17 drivers/tee/tee_shm_pool.c
11
12 static int pool_op_gen_alloc(struct tee_shm_pool_mgr *poolm,
13 struct tee_shm *shm, size_t size, size_t align)
14 {
15 unsigned long va;
16 struct gen_pool *genpool = poolm->private_data;
> 17 size_t a = max(align, 1U << genpool->min_alloc_order);
18 struct genpool_data_align data = { .align = a };
19 size_t s = roundup(size, a);
20
21 va = gen_pool_alloc_algo(genpool, s, gen_pool_first_fit_align, &data);
22 if (!va)
23 return -ENOMEM;
24
25 memset((void *)va, 0, s);
26 shm->kaddr = (void *)va;
27 shm->paddr = gen_pool_virt_to_phys(genpool, va);
28 shm->size = s;
29 /*
30 * This is from a static shared memory pool so no need to register
31 * each chunk, and no need to unregister later either.
32 */
33 shm->flags &= ~TEE_SHM_REGISTER;
34 return 0;
35 }
36
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH v4] mm: slub: move sysfs slab alloc/free interfaces to debugfs
by kernel test robot
Hi Faiyaz,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.12-rc7]
[cannot apply to hnaz-linux-mm/master next-20210416]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Faiyaz-Mohammed/mm-slub-move-sys...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7e25f40eab52c57ff6772d27d2aef3640a3237d7
config: mips-randconfig-r001-20210416 (attached as .config)
compiler: mips64el-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8adf70f166344443e2f4e689e30c5d20f...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Faiyaz-Mohammed/mm-slub-move-sysfs-slab-alloc-free-interfaces-to-debugfs/20210416-222940
git checkout 8adf70f166344443e2f4e689e30c5d20f16b234e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
mm/slab_common.c: In function 'slab_caches_to_rcu_destroy_workfn':
>> mm/slab_common.c:441:3: error: implicit declaration of function 'debugfs_slab_release' [-Werror=implicit-function-declaration]
441 | debugfs_slab_release(s);
| ^~~~~~~~~~~~~~~~~~~~
At top level:
mm/slab_common.c:1124:30: warning: 'slabinfo_proc_ops' defined but not used [-Wunused-const-variable=]
1124 | static const struct proc_ops slabinfo_proc_ops = {
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/debugfs_slab_release +441 mm/slab_common.c
409
410 static void slab_caches_to_rcu_destroy_workfn(struct work_struct *work)
411 {
412 LIST_HEAD(to_destroy);
413 struct kmem_cache *s, *s2;
414
415 /*
416 * On destruction, SLAB_TYPESAFE_BY_RCU kmem_caches are put on the
417 * @slab_caches_to_rcu_destroy list. The slab pages are freed
418 * through RCU and the associated kmem_cache are dereferenced
419 * while freeing the pages, so the kmem_caches should be freed only
420 * after the pending RCU operations are finished. As rcu_barrier()
421 * is a pretty slow operation, we batch all pending destructions
422 * asynchronously.
423 */
424 mutex_lock(&slab_mutex);
425 list_splice_init(&slab_caches_to_rcu_destroy, &to_destroy);
426 mutex_unlock(&slab_mutex);
427
428 if (list_empty(&to_destroy))
429 return;
430
431 rcu_barrier();
432
433 list_for_each_entry_safe(s, s2, &to_destroy, list) {
434 kfence_shutdown_cache(s);
435 #ifdef SLAB_SUPPORTS_SYSFS
436 sysfs_slab_release(s);
437 #else
438 slab_kmem_cache_release(s);
439 #endif
440 #ifdef CONFIG_DEBUG_FS
> 441 debugfs_slab_release(s);
442 #endif
443 }
444 }
445
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[sashal-linux-stable:queue-5.4 24/25] drivers/scsi/qla2xxx/qla_init.c:156:12: error: static declaration of 'qla24xx_async_abort_cmd' follows non-static declaration
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-5.4
head: e53f5c1fde5c006e28ef2ee0ac0afa3a940b51be
commit: 2a2346e9fb9df53fb793af8ded6e727f0677601d [24/25] scsi: qla2xxx: Add a shadow variable to hold disc_state history of fcport
config: x86_64-randconfig-a002-20210416 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6a18cc23efad410db48a3ccfc233d215de7d4cb9)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable queue-5.4
git checkout 2a2346e9fb9df53fb793af8ded6e727f0677601d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/scsi/qla2xxx/qla_init.c:156:12: error: static declaration of 'qla24xx_async_abort_cmd' follows non-static declaration
static int qla24xx_async_abort_cmd(srb_t *cmd_sp, bool wait)
^
drivers/scsi/qla2xxx/qla_gbl.h:83:12: note: previous declaration is here
extern int qla24xx_async_abort_cmd(srb_t *, bool);
^
1 error generated.
vim +/qla24xx_async_abort_cmd +156 drivers/scsi/qla2xxx/qla_init.c
1956eee58872e6 Bart Van Assche 2019-04-17 155
1956eee58872e6 Bart Van Assche 2019-04-17 @156 static int qla24xx_async_abort_cmd(srb_t *cmd_sp, bool wait)
1956eee58872e6 Bart Van Assche 2019-04-17 157 {
1956eee58872e6 Bart Van Assche 2019-04-17 158 scsi_qla_host_t *vha = cmd_sp->vha;
1956eee58872e6 Bart Van Assche 2019-04-17 159 struct srb_iocb *abt_iocb;
1956eee58872e6 Bart Van Assche 2019-04-17 160 srb_t *sp;
1956eee58872e6 Bart Van Assche 2019-04-17 161 int rval = QLA_FUNCTION_FAILED;
1956eee58872e6 Bart Van Assche 2019-04-17 162
1956eee58872e6 Bart Van Assche 2019-04-17 163 sp = qla2xxx_get_qpair_sp(cmd_sp->vha, cmd_sp->qpair, cmd_sp->fcport,
1956eee58872e6 Bart Van Assche 2019-04-17 164 GFP_ATOMIC);
1956eee58872e6 Bart Van Assche 2019-04-17 165 if (!sp)
fe6b52c9adbcce Bart Van Assche 2019-08-08 166 return rval;
1956eee58872e6 Bart Van Assche 2019-04-17 167
1956eee58872e6 Bart Van Assche 2019-04-17 168 abt_iocb = &sp->u.iocb_cmd;
1956eee58872e6 Bart Van Assche 2019-04-17 169 sp->type = SRB_ABT_CMD;
1956eee58872e6 Bart Van Assche 2019-04-17 170 sp->name = "abort";
1956eee58872e6 Bart Van Assche 2019-04-17 171 sp->qpair = cmd_sp->qpair;
b7abcc7df5e131 Quinn Tran 2019-11-05 172 sp->cmd_sp = cmd_sp;
1956eee58872e6 Bart Van Assche 2019-04-17 173 if (wait)
1956eee58872e6 Bart Van Assche 2019-04-17 174 sp->flags = SRB_WAKEUP_ON_COMP;
1956eee58872e6 Bart Van Assche 2019-04-17 175
1956eee58872e6 Bart Van Assche 2019-04-17 176 abt_iocb->timeout = qla24xx_abort_iocb_timeout;
1956eee58872e6 Bart Van Assche 2019-04-17 177 init_completion(&abt_iocb->u.abt.comp);
1956eee58872e6 Bart Van Assche 2019-04-17 178 /* FW can send 2 x ABTS's timeout/20s */
1956eee58872e6 Bart Van Assche 2019-04-17 179 qla2x00_init_timer(sp, 42);
1956eee58872e6 Bart Van Assche 2019-04-17 180
1956eee58872e6 Bart Van Assche 2019-04-17 181 abt_iocb->u.abt.cmd_hndl = cmd_sp->handle;
1956eee58872e6 Bart Van Assche 2019-04-17 182 abt_iocb->u.abt.req_que_no = cpu_to_le16(cmd_sp->qpair->req->id);
1956eee58872e6 Bart Van Assche 2019-04-17 183
1956eee58872e6 Bart Van Assche 2019-04-17 184 sp->done = qla24xx_abort_sp_done;
1956eee58872e6 Bart Van Assche 2019-04-17 185
1956eee58872e6 Bart Van Assche 2019-04-17 186 ql_dbg(ql_dbg_async, vha, 0x507c,
1956eee58872e6 Bart Van Assche 2019-04-17 187 "Abort command issued - hdl=%x, type=%x\n", cmd_sp->handle,
1956eee58872e6 Bart Van Assche 2019-04-17 188 cmd_sp->type);
1956eee58872e6 Bart Van Assche 2019-04-17 189
1956eee58872e6 Bart Van Assche 2019-04-17 190 rval = qla2x00_start_sp(sp);
fe6b52c9adbcce Bart Van Assche 2019-08-08 191 if (rval != QLA_SUCCESS) {
fe6b52c9adbcce Bart Van Assche 2019-08-08 192 sp->free(sp);
fe6b52c9adbcce Bart Van Assche 2019-08-08 193 return rval;
fe6b52c9adbcce Bart Van Assche 2019-08-08 194 }
1956eee58872e6 Bart Van Assche 2019-04-17 195
1956eee58872e6 Bart Van Assche 2019-04-17 196 if (wait) {
1956eee58872e6 Bart Van Assche 2019-04-17 197 wait_for_completion(&abt_iocb->u.abt.comp);
1956eee58872e6 Bart Van Assche 2019-04-17 198 rval = abt_iocb->u.abt.comp_status == CS_COMPLETE ?
1956eee58872e6 Bart Van Assche 2019-04-17 199 QLA_SUCCESS : QLA_FUNCTION_FAILED;
fe6b52c9adbcce Bart Van Assche 2019-08-08 200 sp->free(sp);
1956eee58872e6 Bart Van Assche 2019-04-17 201 }
1956eee58872e6 Bart Van Assche 2019-04-17 202
1956eee58872e6 Bart Van Assche 2019-04-17 203 return rval;
1956eee58872e6 Bart Van Assche 2019-04-17 204 }
1956eee58872e6 Bart Van Assche 2019-04-17 205
:::::: The code at line 156 was first introduced by commit
:::::: 1956eee58872e622cfe03f060a5d8a20d24afe47 scsi: qla2xxx: Make qla24xx_async_abort_cmd() static
:::::: TO: Bart Van Assche <bvanassche(a)acm.org>
:::::: CC: Martin K. Petersen <martin.petersen(a)oracle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH v4] mm: slub: move sysfs slab alloc/free interfaces to debugfs
by kernel test robot
Hi Faiyaz,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.12-rc7]
[cannot apply to hnaz-linux-mm/master next-20210416]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Faiyaz-Mohammed/mm-slub-move-sys...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7e25f40eab52c57ff6772d27d2aef3640a3237d7
config: alpha-randconfig-s031-20210416 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-280-g2cd6d34e-dirty
# https://github.com/0day-ci/linux/commit/8adf70f166344443e2f4e689e30c5d20f...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Faiyaz-Mohammed/mm-slub-move-sysfs-slab-alloc-free-interfaces-to-debugfs/20210416-222940
git checkout 8adf70f166344443e2f4e689e30c5d20f16b234e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
mm/slub.c: In function 'debugfs_slab_add':
>> mm/slub.c:5896:14: warning: variable 'name' set but not used [-Wunused-but-set-variable]
5896 | const char *name;
| ^~~~
mm/slub.c: At top level:
mm/slub.c:4628: error: unterminated #ifdef
4628 | #ifdef CONFIG_SLUB_DEBUG
|
vim +/name +5896 mm/slub.c
5893
5894 static void debugfs_slab_add(struct kmem_cache *s)
5895 {
> 5896 const char *name;
5897 int unmergeable = slab_unmergeable(s);
5898
5899 if (unlikely(!slab_debugfs_root))
5900 return;
5901
5902 if (!unmergeable && disable_higher_order_debug &&
5903 (slub_debug & DEBUG_METADATA_FLAGS))
5904 unmergeable = 1;
5905
5906 if (unmergeable) {
5907 /*
5908 * Slabcache can never be merged so we can use the name proper.
5909 * This is typically the case for debug situations. In that
5910 * case we can catch duplicate names easily.
5911 */
5912 debugfs_remove(s->slab_cache_dentry);
5913 name = s->name;
5914 } else {
5915 /*
5916 * Create a unique name for the slab as a target
5917 * for the symlinks.
5918 */
5919 name = create_unique_id(s);
5920 }
5921
5922 s->slab_cache_dentry = debugfs_create_dir(s->name, slab_debugfs_root);
5923 if (!IS_ERR(s->slab_cache_dentry)) {
5924 debugfs_create_file("alloc_trace", 0400,
5925 s->slab_cache_dentry, s, &slab_debug_fops);
5926
5927 debugfs_create_file("free_trace", 0400,
5928 s->slab_cache_dentry, s, &slab_debug_fops);
5929 }
5930
5931 if (!unmergeable) {
5932 /* Setup first alias */
5933 debugfs_slab_alias(s, s->name);
5934 }
5935 }
5936
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH] ASoC: ak4458: check reset control status
by kernel test robot
Hi Shengjiu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on asoc/for-next]
[also build test ERROR on v5.12-rc7 next-20210416]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Shengjiu-Wang/ASoC-ak4458-check-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: riscv-randconfig-r006-20210416 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6a18cc23efad410db48a3ccfc233d215de7d4cb9)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/48f467759d71681e2d3c35253a6eed08e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Shengjiu-Wang/ASoC-ak4458-check-reset-control-status/20210416-200151
git checkout 48f467759d71681e2d3c35253a6eed08e686bd16
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> sound/soc/codecs/ak4458.c:422:2: error: use of undeclared identifier 'ret'
ret = ak4458_rstn_control(component, 0);
^
sound/soc/codecs/ak4458.c:423:6: error: use of undeclared identifier 'ret'
if (ret)
^
sound/soc/codecs/ak4458.c:424:10: error: use of undeclared identifier 'ret'
return ret;
^
sound/soc/codecs/ak4458.c:426:2: error: use of undeclared identifier 'ret'
ret = ak4458_rstn_control(component, 1);
^
sound/soc/codecs/ak4458.c:427:6: error: use of undeclared identifier 'ret'
if (ret)
^
sound/soc/codecs/ak4458.c:428:10: error: use of undeclared identifier 'ret'
return ret;
^
6 errors generated.
vim +/ret +422 sound/soc/codecs/ak4458.c
328
329 static int ak4458_hw_params(struct snd_pcm_substream *substream,
330 struct snd_pcm_hw_params *params,
331 struct snd_soc_dai *dai)
332 {
333 struct snd_soc_component *component = dai->component;
334 struct ak4458_priv *ak4458 = snd_soc_component_get_drvdata(component);
335 int pcm_width = max(params_physical_width(params), ak4458->slot_width);
336 u8 format, dsdsel0, dsdsel1;
337 int nfs1, dsd_bclk;
338
339 nfs1 = params_rate(params);
340 ak4458->fs = nfs1;
341
342 /* calculate bit clock */
343 switch (params_format(params)) {
344 case SNDRV_PCM_FORMAT_DSD_U8:
345 case SNDRV_PCM_FORMAT_DSD_U16_LE:
346 case SNDRV_PCM_FORMAT_DSD_U16_BE:
347 case SNDRV_PCM_FORMAT_DSD_U32_LE:
348 case SNDRV_PCM_FORMAT_DSD_U32_BE:
349 dsd_bclk = nfs1 * params_physical_width(params);
350 switch (dsd_bclk) {
351 case 2822400:
352 dsdsel0 = 0;
353 dsdsel1 = 0;
354 break;
355 case 5644800:
356 dsdsel0 = 1;
357 dsdsel1 = 0;
358 break;
359 case 11289600:
360 dsdsel0 = 0;
361 dsdsel1 = 1;
362 break;
363 case 22579200:
364 if (ak4458->drvdata->type == AK4497) {
365 dsdsel0 = 1;
366 dsdsel1 = 1;
367 } else {
368 dev_err(dai->dev, "DSD512 not supported.\n");
369 return -EINVAL;
370 }
371 break;
372 default:
373 dev_err(dai->dev, "Unsupported dsd bclk.\n");
374 return -EINVAL;
375 }
376
377 snd_soc_component_update_bits(component, AK4458_06_DSD1,
378 AK4458_DSDSEL_MASK, dsdsel0);
379 snd_soc_component_update_bits(component, AK4458_09_DSD2,
380 AK4458_DSDSEL_MASK, dsdsel1);
381 break;
382 }
383
384 /* Master Clock Frequency Auto Setting Mode Enable */
385 snd_soc_component_update_bits(component, AK4458_00_CONTROL1, 0x80, 0x80);
386
387 switch (pcm_width) {
388 case 16:
389 if (ak4458->fmt == SND_SOC_DAIFMT_I2S)
390 format = AK4458_DIF_24BIT_I2S;
391 else
392 format = AK4458_DIF_16BIT_LSB;
393 break;
394 case 32:
395 switch (ak4458->fmt) {
396 case SND_SOC_DAIFMT_I2S:
397 format = AK4458_DIF_32BIT_I2S;
398 break;
399 case SND_SOC_DAIFMT_LEFT_J:
400 format = AK4458_DIF_32BIT_MSB;
401 break;
402 case SND_SOC_DAIFMT_RIGHT_J:
403 format = AK4458_DIF_32BIT_LSB;
404 break;
405 case SND_SOC_DAIFMT_DSP_B:
406 format = AK4458_DIF_32BIT_MSB;
407 break;
408 case SND_SOC_DAIFMT_PDM:
409 format = AK4458_DIF_32BIT_MSB;
410 break;
411 default:
412 return -EINVAL;
413 }
414 break;
415 default:
416 return -EINVAL;
417 }
418
419 snd_soc_component_update_bits(component, AK4458_00_CONTROL1,
420 AK4458_DIF_MASK, format);
421
> 422 ret = ak4458_rstn_control(component, 0);
423 if (ret)
424 return ret;
425
426 ret = ak4458_rstn_control(component, 1);
427 if (ret)
428 return ret;
429
430 return 0;
431 }
432
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH] drm: Fix fbcon blank on QEMU graphics drivers
by kernel test robot
Hi Takashi,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.12-rc7 next-20210416]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Takashi-Iwai/drm-Fix-fbcon-blank...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: mips-randconfig-r001-20210416 (attached as .config)
compiler: mips64el-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4b1a07505589e5f12ae52f249fa93b400...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Takashi-Iwai/drm-Fix-fbcon-blank-on-QEMU-graphics-drivers/20210416-205539
git checkout 4b1a07505589e5f12ae52f249fa93b400e35e602
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/qxl/qxl_drv.c: In function 'qxl_pci_probe':
>> drivers/gpu/drm/qxl/qxl_drv.c:123:10: error: 'struct qxl_device' has no member named 'fb_helper'
123 | if (qdev->fb_helper)
| ^~
drivers/gpu/drm/qxl/qxl_drv.c:124:7: error: 'struct qxl_device' has no member named 'fb_helper'
124 | qdev->fb_helper->no_dpms_blank = true;
| ^~
vim +123 drivers/gpu/drm/qxl/qxl_drv.c
71
72 static int
73 qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
74 {
75 struct qxl_device *qdev;
76 int ret;
77
78 if (pdev->revision < 4) {
79 DRM_ERROR("qxl too old, doesn't support client_monitors_config,"
80 " use xf86-video-qxl in user mode");
81 return -EINVAL; /* TODO: ENODEV ? */
82 }
83
84 qdev = devm_drm_dev_alloc(&pdev->dev, &qxl_driver,
85 struct qxl_device, ddev);
86 if (IS_ERR(qdev)) {
87 pr_err("Unable to init drm dev");
88 return -ENOMEM;
89 }
90
91 ret = pci_enable_device(pdev);
92 if (ret)
93 return ret;
94
95 ret = drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, "qxl");
96 if (ret)
97 goto disable_pci;
98
99 if (is_vga(pdev) && pdev->revision < 5) {
100 ret = vga_get_interruptible(pdev, VGA_RSRC_LEGACY_IO);
101 if (ret) {
102 DRM_ERROR("can't get legacy vga ioports\n");
103 goto disable_pci;
104 }
105 }
106
107 ret = qxl_device_init(qdev, pdev);
108 if (ret)
109 goto put_vga;
110
111 ret = qxl_modeset_init(qdev);
112 if (ret)
113 goto unload;
114
115 drm_kms_helper_poll_init(&qdev->ddev);
116
117 /* Complete initialization. */
118 ret = drm_dev_register(&qdev->ddev, ent->driver_data);
119 if (ret)
120 goto modeset_cleanup;
121
122 drm_fbdev_generic_setup(&qdev->ddev, 32);
> 123 if (qdev->fb_helper)
124 qdev->fb_helper->no_dpms_blank = true;
125
126 return 0;
127
128 modeset_cleanup:
129 qxl_modeset_fini(qdev);
130 unload:
131 qxl_device_fini(qdev);
132 put_vga:
133 if (is_vga(pdev) && pdev->revision < 5)
134 vga_put(pdev, VGA_RSRC_LEGACY_IO);
135 disable_pci:
136 pci_disable_device(pdev);
137
138 return ret;
139 }
140
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH] drm: Fix fbcon blank on QEMU graphics drivers
by kernel test robot
Hi Takashi,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.12-rc7 next-20210416]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Takashi-Iwai/drm-Fix-fbcon-blank...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-a003-20210416 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6a18cc23efad410db48a3ccfc233d215de7d4cb9)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/4b1a07505589e5f12ae52f249fa93b400...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Takashi-Iwai/drm-Fix-fbcon-blank-on-QEMU-graphics-drivers/20210416-205539
git checkout 4b1a07505589e5f12ae52f249fa93b400e35e602
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/qxl/qxl_drv.c:123:12: error: no member named 'fb_helper' in 'struct qxl_device'
if (qdev->fb_helper)
~~~~ ^
drivers/gpu/drm/qxl/qxl_drv.c:124:9: error: no member named 'fb_helper' in 'struct qxl_device'
qdev->fb_helper->no_dpms_blank = true;
~~~~ ^
2 errors generated.
vim +123 drivers/gpu/drm/qxl/qxl_drv.c
71
72 static int
73 qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
74 {
75 struct qxl_device *qdev;
76 int ret;
77
78 if (pdev->revision < 4) {
79 DRM_ERROR("qxl too old, doesn't support client_monitors_config,"
80 " use xf86-video-qxl in user mode");
81 return -EINVAL; /* TODO: ENODEV ? */
82 }
83
84 qdev = devm_drm_dev_alloc(&pdev->dev, &qxl_driver,
85 struct qxl_device, ddev);
86 if (IS_ERR(qdev)) {
87 pr_err("Unable to init drm dev");
88 return -ENOMEM;
89 }
90
91 ret = pci_enable_device(pdev);
92 if (ret)
93 return ret;
94
95 ret = drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, "qxl");
96 if (ret)
97 goto disable_pci;
98
99 if (is_vga(pdev) && pdev->revision < 5) {
100 ret = vga_get_interruptible(pdev, VGA_RSRC_LEGACY_IO);
101 if (ret) {
102 DRM_ERROR("can't get legacy vga ioports\n");
103 goto disable_pci;
104 }
105 }
106
107 ret = qxl_device_init(qdev, pdev);
108 if (ret)
109 goto put_vga;
110
111 ret = qxl_modeset_init(qdev);
112 if (ret)
113 goto unload;
114
115 drm_kms_helper_poll_init(&qdev->ddev);
116
117 /* Complete initialization. */
118 ret = drm_dev_register(&qdev->ddev, ent->driver_data);
119 if (ret)
120 goto modeset_cleanup;
121
122 drm_fbdev_generic_setup(&qdev->ddev, 32);
> 123 if (qdev->fb_helper)
124 qdev->fb_helper->no_dpms_blank = true;
125
126 return 0;
127
128 modeset_cleanup:
129 qxl_modeset_fini(qdev);
130 unload:
131 qxl_device_fini(qdev);
132 put_vga:
133 if (is_vga(pdev) && pdev->revision < 5)
134 vga_put(pdev, VGA_RSRC_LEGACY_IO);
135 disable_pci:
136 pci_disable_device(pdev);
137
138 return ret;
139 }
140
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months