[sashal-linux-stable:queue-5.4 24/25] drivers/scsi/qla2xxx/qla_init.c:156:12: error: static declaration of 'qla24xx_async_abort_cmd' follows non-static declaration
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-5.4
head: e53f5c1fde5c006e28ef2ee0ac0afa3a940b51be
commit: 2a2346e9fb9df53fb793af8ded6e727f0677601d [24/25] scsi: qla2xxx: Add a shadow variable to hold disc_state history of fcport
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable queue-5.4
git checkout 2a2346e9fb9df53fb793af8ded6e727f0677601d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/scsi/qla2xxx/qla_init.c:156:12: error: static declaration of 'qla24xx_async_abort_cmd' follows non-static declaration
156 | static int qla24xx_async_abort_cmd(srb_t *cmd_sp, bool wait)
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/scsi/qla2xxx/qla_def.h:4861,
from drivers/scsi/qla2xxx/qla_init.c:7:
drivers/scsi/qla2xxx/qla_gbl.h:83:12: note: previous declaration of 'qla24xx_async_abort_cmd' was here
83 | extern int qla24xx_async_abort_cmd(srb_t *, bool);
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/qla24xx_async_abort_cmd +156 drivers/scsi/qla2xxx/qla_init.c
1956eee58872e6 Bart Van Assche 2019-04-17 155
1956eee58872e6 Bart Van Assche 2019-04-17 @156 static int qla24xx_async_abort_cmd(srb_t *cmd_sp, bool wait)
1956eee58872e6 Bart Van Assche 2019-04-17 157 {
1956eee58872e6 Bart Van Assche 2019-04-17 158 scsi_qla_host_t *vha = cmd_sp->vha;
1956eee58872e6 Bart Van Assche 2019-04-17 159 struct srb_iocb *abt_iocb;
1956eee58872e6 Bart Van Assche 2019-04-17 160 srb_t *sp;
1956eee58872e6 Bart Van Assche 2019-04-17 161 int rval = QLA_FUNCTION_FAILED;
1956eee58872e6 Bart Van Assche 2019-04-17 162
1956eee58872e6 Bart Van Assche 2019-04-17 163 sp = qla2xxx_get_qpair_sp(cmd_sp->vha, cmd_sp->qpair, cmd_sp->fcport,
1956eee58872e6 Bart Van Assche 2019-04-17 164 GFP_ATOMIC);
1956eee58872e6 Bart Van Assche 2019-04-17 165 if (!sp)
fe6b52c9adbcce Bart Van Assche 2019-08-08 166 return rval;
1956eee58872e6 Bart Van Assche 2019-04-17 167
1956eee58872e6 Bart Van Assche 2019-04-17 168 abt_iocb = &sp->u.iocb_cmd;
1956eee58872e6 Bart Van Assche 2019-04-17 169 sp->type = SRB_ABT_CMD;
1956eee58872e6 Bart Van Assche 2019-04-17 170 sp->name = "abort";
1956eee58872e6 Bart Van Assche 2019-04-17 171 sp->qpair = cmd_sp->qpair;
b7abcc7df5e131 Quinn Tran 2019-11-05 172 sp->cmd_sp = cmd_sp;
1956eee58872e6 Bart Van Assche 2019-04-17 173 if (wait)
1956eee58872e6 Bart Van Assche 2019-04-17 174 sp->flags = SRB_WAKEUP_ON_COMP;
1956eee58872e6 Bart Van Assche 2019-04-17 175
1956eee58872e6 Bart Van Assche 2019-04-17 176 abt_iocb->timeout = qla24xx_abort_iocb_timeout;
1956eee58872e6 Bart Van Assche 2019-04-17 177 init_completion(&abt_iocb->u.abt.comp);
1956eee58872e6 Bart Van Assche 2019-04-17 178 /* FW can send 2 x ABTS's timeout/20s */
1956eee58872e6 Bart Van Assche 2019-04-17 179 qla2x00_init_timer(sp, 42);
1956eee58872e6 Bart Van Assche 2019-04-17 180
1956eee58872e6 Bart Van Assche 2019-04-17 181 abt_iocb->u.abt.cmd_hndl = cmd_sp->handle;
1956eee58872e6 Bart Van Assche 2019-04-17 182 abt_iocb->u.abt.req_que_no = cpu_to_le16(cmd_sp->qpair->req->id);
1956eee58872e6 Bart Van Assche 2019-04-17 183
1956eee58872e6 Bart Van Assche 2019-04-17 184 sp->done = qla24xx_abort_sp_done;
1956eee58872e6 Bart Van Assche 2019-04-17 185
1956eee58872e6 Bart Van Assche 2019-04-17 186 ql_dbg(ql_dbg_async, vha, 0x507c,
1956eee58872e6 Bart Van Assche 2019-04-17 187 "Abort command issued - hdl=%x, type=%x\n", cmd_sp->handle,
1956eee58872e6 Bart Van Assche 2019-04-17 188 cmd_sp->type);
1956eee58872e6 Bart Van Assche 2019-04-17 189
1956eee58872e6 Bart Van Assche 2019-04-17 190 rval = qla2x00_start_sp(sp);
fe6b52c9adbcce Bart Van Assche 2019-08-08 191 if (rval != QLA_SUCCESS) {
fe6b52c9adbcce Bart Van Assche 2019-08-08 192 sp->free(sp);
fe6b52c9adbcce Bart Van Assche 2019-08-08 193 return rval;
fe6b52c9adbcce Bart Van Assche 2019-08-08 194 }
1956eee58872e6 Bart Van Assche 2019-04-17 195
1956eee58872e6 Bart Van Assche 2019-04-17 196 if (wait) {
1956eee58872e6 Bart Van Assche 2019-04-17 197 wait_for_completion(&abt_iocb->u.abt.comp);
1956eee58872e6 Bart Van Assche 2019-04-17 198 rval = abt_iocb->u.abt.comp_status == CS_COMPLETE ?
1956eee58872e6 Bart Van Assche 2019-04-17 199 QLA_SUCCESS : QLA_FUNCTION_FAILED;
fe6b52c9adbcce Bart Van Assche 2019-08-08 200 sp->free(sp);
1956eee58872e6 Bart Van Assche 2019-04-17 201 }
1956eee58872e6 Bart Van Assche 2019-04-17 202
1956eee58872e6 Bart Van Assche 2019-04-17 203 return rval;
1956eee58872e6 Bart Van Assche 2019-04-17 204 }
1956eee58872e6 Bart Van Assche 2019-04-17 205
:::::: The code at line 156 was first introduced by commit
:::::: 1956eee58872e622cfe03f060a5d8a20d24afe47 scsi: qla2xxx: Make qla24xx_async_abort_cmd() static
:::::: TO: Bart Van Assche <bvanassche(a)acm.org>
:::::: CC: Martin K. Petersen <martin.petersen(a)oracle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH v2] powerpc/kexec_file: use current CPU info while setting up FDT
by kernel test robot
Hi Sourabh,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on powerpc/next]
[also build test WARNING on linus/master v5.12-rc7 next-20210416]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sourabh-Jain/powerpc-kexec_file-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c4f40243a6928fb16798b2b98c5371815...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sourabh-Jain/powerpc-kexec_file-use-current-CPU-info-while-setting-up-FDT/20210416-204821
git checkout c4f40243a6928fb16798b2b98c5371815b49e4cc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/powerpc/kexec/file_load_64.c:972:5: warning: no previous prototype for 'add_node_prop' [-Wmissing-prototypes]
972 | int add_node_prop(void *fdt, int node_offset, const struct device_node *np)
| ^~~~~~~~~~~~~
>> arch/powerpc/kexec/file_load_64.c:1003:5: warning: no previous prototype for 'update_cpus_node' [-Wmissing-prototypes]
1003 | int update_cpus_node(void *fdt)
| ^~~~~~~~~~~~~~~~
vim +/add_node_prop +972 arch/powerpc/kexec/file_load_64.c
962
963 /**
964 * add_node_prop - Read property from device node structure and add
965 * them to fdt.
966 * @fdt: Flattened device tree of the kernel
967 * @node_offset: offset of the node to add a property at
968 * np: device node pointer
969 *
970 * Returns 0 on success, negative errno on error.
971 */
> 972 int add_node_prop(void *fdt, int node_offset, const struct device_node *np)
973 {
974 int ret = 0;
975 struct property *pp;
976 unsigned long flags;
977
978 if (!np)
979 return -EINVAL;
980
981 raw_spin_lock_irqsave(&devtree_lock, flags);
982 for (pp = np->properties; pp; pp = pp->next) {
983 ret = fdt_setprop(fdt, node_offset, pp->name,
984 pp->value, pp->length);
985 if (ret < 0) {
986 pr_err("Unable to add %s property: %s\n",
987 pp->name, fdt_strerror(ret));
988 goto out;
989 }
990 }
991 out:
992 raw_spin_unlock_irqrestore(&devtree_lock, flags);
993 return ret;
994 }
995
996 /**
997 * update_cpus_node - Update cpus node of flattened device-tree using of_root
998 * device node.
999 * @fdt: Flattened device tree of the kernel.
1000 *
1001 * Returns 0 on success, negative errno on error.
1002 */
> 1003 int update_cpus_node(void *fdt)
1004 {
1005 struct device_node *cpus_node, *dn;
1006 int cpus_offset, cpus_subnode_off, ret = 0;
1007
1008 cpus_offset = fdt_path_offset(fdt, "/cpus");
1009 if (cpus_offset == -FDT_ERR_NOTFOUND || cpus_offset > 0) {
1010 if (cpus_offset > 0) {
1011 ret = fdt_del_node(fdt, cpus_offset);
1012 if (ret < 0) {
1013 pr_err("Error deleting /cpus node: %s\n",
1014 fdt_strerror(ret));
1015 return -EINVAL;
1016 }
1017 }
1018
1019 /* Add cpus node to fdt */
1020 cpus_offset = fdt_add_subnode(fdt, fdt_path_offset(fdt, "/"),
1021 "cpus");
1022 if (cpus_offset < 0) {
1023 pr_err("Error creating /cpus node: %s\n",
1024 fdt_strerror(cpus_offset));
1025 return -EINVAL;
1026 }
1027
1028 /* Add cpus node properties */
1029 cpus_node = of_find_node_by_path("/cpus");
1030 ret = add_node_prop(fdt, cpus_offset, cpus_node);
1031 if (ret < 0)
1032 return ret;
1033
1034 /* Loop through all subnodes of cpus and add them to fdt */
1035 for_each_node_by_type(dn, "cpu") {
1036 cpus_subnode_off = fdt_add_subnode(fdt,
1037 cpus_offset,
1038 dn->full_name);
1039 if (cpus_subnode_off < 0) {
1040 pr_err("Unable to add %s subnode: %s\n",
1041 dn->full_name, fdt_strerror(cpus_subnode_off));
1042 return cpus_subnode_off;
1043 }
1044 ret = add_node_prop(fdt, cpus_subnode_off, dn);
1045 if (ret < 0)
1046 return ret;
1047 }
1048 } else if (cpus_offset < 0) {
1049 pr_err("Malformed device tree: error reading /cpus node: %s\n",
1050 fdt_strerror(cpus_offset));
1051 }
1052
1053 return ret;
1054 }
1055
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH v3 09/17] scsi: qedi: fix race during abort timeouts
by kernel test robot
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on next-20210415]
[cannot apply to mkp-scsi/for-next rdma/for-next v5.12-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mike-Christie/libicsi-and-qedi-T...
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: alpha-randconfig-r016-20210416 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/9d4a83c1316e3dad2bd5687563584509a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mike-Christie/libicsi-and-qedi-TMF-fixes/20210416-100636
git checkout 9d4a83c1316e3dad2bd5687563584509a3d6557c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/scsi/qedi/qedi_fw.c: In function 'qedi_process_cmd_cleanup_resp':
>> drivers/scsi/qedi/qedi_fw.c:741:6: warning: variable 'rtid' set but not used [-Wunused-but-set-variable]
741 | u32 rtid = 0;
| ^~~~
vim +/rtid +741 drivers/scsi/qedi/qedi_fw.c
ace7f46ba5fde7 Manish Rangankar 2016-12-01 729
ace7f46ba5fde7 Manish Rangankar 2016-12-01 730 static void qedi_process_cmd_cleanup_resp(struct qedi_ctx *qedi,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 731 struct iscsi_cqe_solicited *cqe,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 732 struct iscsi_task *task,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 733 struct iscsi_conn *conn)
ace7f46ba5fde7 Manish Rangankar 2016-12-01 734 {
ace7f46ba5fde7 Manish Rangankar 2016-12-01 735 struct qedi_work_map *work, *work_tmp;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 736 u32 proto_itt = cqe->itid;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 737 u32 ptmp_itt = 0;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 738 itt_t protoitt = 0;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 739 int found = 0;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 740 struct qedi_cmd *qedi_cmd = NULL;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 @741 u32 rtid = 0;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 742 u32 iscsi_cid;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 743 struct qedi_conn *qedi_conn;
8712f467d4a560 Christos Gkekas 2017-10-14 744 struct qedi_cmd *dbg_cmd;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 745 struct iscsi_task *mtask;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 746 struct iscsi_tm *tmf_hdr = NULL;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 747
ace7f46ba5fde7 Manish Rangankar 2016-12-01 748 iscsi_cid = cqe->conn_id;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 749 qedi_conn = qedi->cid_que.conn_cid_tbl[iscsi_cid];
967823d6c3980a Manish Rangankar 2018-02-26 750 if (!qedi_conn) {
967823d6c3980a Manish Rangankar 2018-02-26 751 QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_INFO,
967823d6c3980a Manish Rangankar 2018-02-26 752 "icid not found 0x%x\n", cqe->conn_id);
967823d6c3980a Manish Rangankar 2018-02-26 753 return;
967823d6c3980a Manish Rangankar 2018-02-26 754 }
ace7f46ba5fde7 Manish Rangankar 2016-12-01 755
ace7f46ba5fde7 Manish Rangankar 2016-12-01 756 /* Based on this itt get the corresponding qedi_cmd */
ace7f46ba5fde7 Manish Rangankar 2016-12-01 757 spin_lock_bh(&qedi_conn->tmf_work_lock);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 758 list_for_each_entry_safe(work, work_tmp, &qedi_conn->tmf_work_list,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 759 list) {
ace7f46ba5fde7 Manish Rangankar 2016-12-01 760 if (work->rtid == proto_itt) {
ace7f46ba5fde7 Manish Rangankar 2016-12-01 761 /* We found the command */
ace7f46ba5fde7 Manish Rangankar 2016-12-01 762 qedi_cmd = work->qedi_cmd;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 763 if (!qedi_cmd->list_tmf_work) {
ace7f46ba5fde7 Manish Rangankar 2016-12-01 764 QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_SCSI_TM,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 765 "TMF work not found, cqe->tid=0x%x, cid=0x%x\n",
ace7f46ba5fde7 Manish Rangankar 2016-12-01 766 proto_itt, qedi_conn->iscsi_conn_id);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 767 WARN_ON(1);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 768 }
ace7f46ba5fde7 Manish Rangankar 2016-12-01 769 found = 1;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 770 mtask = qedi_cmd->task;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 771 tmf_hdr = (struct iscsi_tm *)mtask->hdr;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 772 rtid = work->rtid;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 773
ace7f46ba5fde7 Manish Rangankar 2016-12-01 774 list_del_init(&work->list);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 775 kfree(work);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 776 qedi_cmd->list_tmf_work = NULL;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 777 }
ace7f46ba5fde7 Manish Rangankar 2016-12-01 778 }
ace7f46ba5fde7 Manish Rangankar 2016-12-01 779 spin_unlock_bh(&qedi_conn->tmf_work_lock);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 780
ace7f46ba5fde7 Manish Rangankar 2016-12-01 781 if (found) {
ace7f46ba5fde7 Manish Rangankar 2016-12-01 782 QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_SCSI_TM,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 783 "TMF work, cqe->tid=0x%x, tmf flags=0x%x, cid=0x%x\n",
ace7f46ba5fde7 Manish Rangankar 2016-12-01 784 proto_itt, tmf_hdr->flags, qedi_conn->iscsi_conn_id);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 785
ace7f46ba5fde7 Manish Rangankar 2016-12-01 786 if ((tmf_hdr->flags & ISCSI_FLAG_TM_FUNC_MASK) ==
ace7f46ba5fde7 Manish Rangankar 2016-12-01 787 ISCSI_TM_FUNC_ABORT_TASK) {
ace7f46ba5fde7 Manish Rangankar 2016-12-01 788 spin_lock_bh(&conn->session->back_lock);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 789
ace7f46ba5fde7 Manish Rangankar 2016-12-01 790 protoitt = build_itt(get_itt(tmf_hdr->rtt),
ace7f46ba5fde7 Manish Rangankar 2016-12-01 791 conn->session->age);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 792 task = iscsi_itt_to_task(conn, protoitt);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 793
ace7f46ba5fde7 Manish Rangankar 2016-12-01 794 spin_unlock_bh(&conn->session->back_lock);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 795
ace7f46ba5fde7 Manish Rangankar 2016-12-01 796 if (!task) {
ace7f46ba5fde7 Manish Rangankar 2016-12-01 797 QEDI_NOTICE(&qedi->dbg_ctx,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 798 "IO task completed, tmf rtt=0x%x, cid=0x%x\n",
ace7f46ba5fde7 Manish Rangankar 2016-12-01 799 get_itt(tmf_hdr->rtt),
ace7f46ba5fde7 Manish Rangankar 2016-12-01 800 qedi_conn->iscsi_conn_id);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 801 return;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 802 }
ace7f46ba5fde7 Manish Rangankar 2016-12-01 803
ace7f46ba5fde7 Manish Rangankar 2016-12-01 804 dbg_cmd = task->dd_data;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 805
ace7f46ba5fde7 Manish Rangankar 2016-12-01 806 QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_SCSI_TM,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 807 "Abort tmf rtt=0x%x, i/o itt=0x%x, i/o tid=0x%x, cid=0x%x\n",
ace7f46ba5fde7 Manish Rangankar 2016-12-01 808 get_itt(tmf_hdr->rtt), get_itt(task->itt),
ace7f46ba5fde7 Manish Rangankar 2016-12-01 809 dbg_cmd->task_id, qedi_conn->iscsi_conn_id);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 810
ace7f46ba5fde7 Manish Rangankar 2016-12-01 811 if (qedi_cmd->state == CLEANUP_WAIT_FAILED)
ace7f46ba5fde7 Manish Rangankar 2016-12-01 812 qedi_cmd->state = CLEANUP_RECV;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 813
ace7f46ba5fde7 Manish Rangankar 2016-12-01 814 spin_lock(&qedi_conn->list_lock);
28b35d17f9f857 Nilesh Javali 2020-09-08 815 if (likely(dbg_cmd->io_cmd_in_list)) {
28b35d17f9f857 Nilesh Javali 2020-09-08 816 dbg_cmd->io_cmd_in_list = false;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 817 list_del_init(&dbg_cmd->io_cmd);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 818 qedi_conn->active_cmd_count--;
28b35d17f9f857 Nilesh Javali 2020-09-08 819 }
ace7f46ba5fde7 Manish Rangankar 2016-12-01 820 spin_unlock(&qedi_conn->list_lock);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 821 qedi_cmd->state = CLEANUP_RECV;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 822 wake_up_interruptible(&qedi_conn->wait_queue);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 823 }
ace7f46ba5fde7 Manish Rangankar 2016-12-01 824 } else if (qedi_conn->cmd_cleanup_req > 0) {
ace7f46ba5fde7 Manish Rangankar 2016-12-01 825 spin_lock_bh(&conn->session->back_lock);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 826 qedi_get_proto_itt(qedi, cqe->itid, &ptmp_itt);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 827 protoitt = build_itt(ptmp_itt, conn->session->age);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 828 task = iscsi_itt_to_task(conn, protoitt);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 829 QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_SCSI_TM,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 830 "cleanup io itid=0x%x, protoitt=0x%x, cmd_cleanup_cmpl=%d, cid=0x%x\n",
ace7f46ba5fde7 Manish Rangankar 2016-12-01 831 cqe->itid, protoitt, qedi_conn->cmd_cleanup_cmpl,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 832 qedi_conn->iscsi_conn_id);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 833
ace7f46ba5fde7 Manish Rangankar 2016-12-01 834 spin_unlock_bh(&conn->session->back_lock);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 835 if (!task) {
ace7f46ba5fde7 Manish Rangankar 2016-12-01 836 QEDI_NOTICE(&qedi->dbg_ctx,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 837 "task is null, itid=0x%x, cid=0x%x\n",
ace7f46ba5fde7 Manish Rangankar 2016-12-01 838 cqe->itid, qedi_conn->iscsi_conn_id);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 839 return;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 840 }
ace7f46ba5fde7 Manish Rangankar 2016-12-01 841 qedi_conn->cmd_cleanup_cmpl++;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 842 wake_up(&qedi_conn->wait_queue);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 843
ace7f46ba5fde7 Manish Rangankar 2016-12-01 844 QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_TID,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 845 "Freeing tid=0x%x for cid=0x%x\n",
ace7f46ba5fde7 Manish Rangankar 2016-12-01 846 cqe->itid, qedi_conn->iscsi_conn_id);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 847
ace7f46ba5fde7 Manish Rangankar 2016-12-01 848 } else {
ace7f46ba5fde7 Manish Rangankar 2016-12-01 849 qedi_get_proto_itt(qedi, cqe->itid, &ptmp_itt);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 850 protoitt = build_itt(ptmp_itt, conn->session->age);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 851 task = iscsi_itt_to_task(conn, protoitt);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 852 QEDI_ERR(&qedi->dbg_ctx,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 853 "Delayed or untracked cleanup response, itt=0x%x, tid=0x%x, cid=0x%x, task=%p\n",
ace7f46ba5fde7 Manish Rangankar 2016-12-01 854 protoitt, cqe->itid, qedi_conn->iscsi_conn_id, task);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 855 }
ace7f46ba5fde7 Manish Rangankar 2016-12-01 856 }
ace7f46ba5fde7 Manish Rangankar 2016-12-01 857
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[kbuild] drivers/gpu/drm/msm/adreno/a3xx_gpu.c:600 a3xx_gpu_init() error: passing non negative 1 to ERR_PTR
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2d743660786ec51f5c1fefd5782bbdee7b227db0
commit: 5785dd7a8ef0de8049f40a1a109de6a1bf17b479 drm/msm: Fix duplicate gpu node in icc summary
config: arm64-randconfig-m031-20210407 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/gpu/drm/msm/adreno/a3xx_gpu.c:600 a3xx_gpu_init() error: passing non negative 1 to ERR_PTR
drivers/gpu/drm/msm/adreno/a4xx_gpu.c:727 a4xx_gpu_init() error: passing non negative 1 to ERR_PTR
vim +600 drivers/gpu/drm/msm/adreno/a3xx_gpu.c
7198e6b03155f6 Rob Clark 2013-07-19 515 struct msm_gpu *a3xx_gpu_init(struct drm_device *dev)
7198e6b03155f6 Rob Clark 2013-07-19 516 {
7198e6b03155f6 Rob Clark 2013-07-19 517 struct a3xx_gpu *a3xx_gpu = NULL;
55459968176f13 Rob Clark 2013-12-05 518 struct adreno_gpu *adreno_gpu;
7198e6b03155f6 Rob Clark 2013-07-19 519 struct msm_gpu *gpu;
060530f1ea6740 Rob Clark 2014-03-03 520 struct msm_drm_private *priv = dev->dev_private;
060530f1ea6740 Rob Clark 2014-03-03 521 struct platform_device *pdev = priv->gpu_pdev;
5785dd7a8ef0de Akhil P Oommen 2020-10-28 522 struct icc_path *ocmem_icc_path;
5785dd7a8ef0de Akhil P Oommen 2020-10-28 523 struct icc_path *icc_path;
7198e6b03155f6 Rob Clark 2013-07-19 524 int ret;
7198e6b03155f6 Rob Clark 2013-07-19 525
7198e6b03155f6 Rob Clark 2013-07-19 526 if (!pdev) {
6a41da17e87dee Mamta Shukla 2018-10-20 527 DRM_DEV_ERROR(dev->dev, "no a3xx device\n");
7198e6b03155f6 Rob Clark 2013-07-19 528 ret = -ENXIO;
7198e6b03155f6 Rob Clark 2013-07-19 529 goto fail;
7198e6b03155f6 Rob Clark 2013-07-19 530 }
7198e6b03155f6 Rob Clark 2013-07-19 531
7198e6b03155f6 Rob Clark 2013-07-19 532 a3xx_gpu = kzalloc(sizeof(*a3xx_gpu), GFP_KERNEL);
7198e6b03155f6 Rob Clark 2013-07-19 533 if (!a3xx_gpu) {
7198e6b03155f6 Rob Clark 2013-07-19 534 ret = -ENOMEM;
7198e6b03155f6 Rob Clark 2013-07-19 535 goto fail;
7198e6b03155f6 Rob Clark 2013-07-19 536 }
7198e6b03155f6 Rob Clark 2013-07-19 537
55459968176f13 Rob Clark 2013-12-05 538 adreno_gpu = &a3xx_gpu->base;
55459968176f13 Rob Clark 2013-12-05 539 gpu = &adreno_gpu->base;
7198e6b03155f6 Rob Clark 2013-07-19 540
70c70f091b1ffd Rob Clark 2014-05-30 541 gpu->perfcntrs = perfcntrs;
70c70f091b1ffd Rob Clark 2014-05-30 542 gpu->num_perfcntrs = ARRAY_SIZE(perfcntrs);
70c70f091b1ffd Rob Clark 2014-05-30 543
3bcefb0497f9fc Rob Clark 2014-09-05 544 adreno_gpu->registers = a3xx_registers;
3bcefb0497f9fc Rob Clark 2014-09-05 545
f97decac5f4c2d Jordan Crouse 2017-10-20 546 ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs, 1);
7198e6b03155f6 Rob Clark 2013-07-19 547 if (ret)
7198e6b03155f6 Rob Clark 2013-07-19 548 goto fail;
7198e6b03155f6 Rob Clark 2013-07-19 549
55459968176f13 Rob Clark 2013-12-05 550 /* if needed, allocate gmem: */
55459968176f13 Rob Clark 2013-12-05 551 if (adreno_is_a330(adreno_gpu)) {
26c0b26dcd005d Brian Masney 2019-08-23 552 ret = adreno_gpu_ocmem_init(&adreno_gpu->base.pdev->dev,
26c0b26dcd005d Brian Masney 2019-08-23 553 adreno_gpu, &a3xx_gpu->ocmem);
26c0b26dcd005d Brian Masney 2019-08-23 554 if (ret)
26c0b26dcd005d Brian Masney 2019-08-23 555 goto fail;
55459968176f13 Rob Clark 2013-12-05 556 }
55459968176f13 Rob Clark 2013-12-05 557
667ce33e57d0de Rob Clark 2016-09-28 558 if (!gpu->aspace) {
871d812aa43e63 Rob Clark 2013-11-16 559 /* TODO we think it is possible to configure the GPU to
871d812aa43e63 Rob Clark 2013-11-16 560 * restrict access to VRAM carveout. But the required
871d812aa43e63 Rob Clark 2013-11-16 561 * registers are unknown. For now just bail out and
871d812aa43e63 Rob Clark 2013-11-16 562 * limp along with just modesetting. If it turns out
871d812aa43e63 Rob Clark 2013-11-16 563 * to not be possible to restrict access, then we must
871d812aa43e63 Rob Clark 2013-11-16 564 * implement a cmdstream validator.
871d812aa43e63 Rob Clark 2013-11-16 565 */
6a41da17e87dee Mamta Shukla 2018-10-20 566 DRM_DEV_ERROR(dev->dev, "No memory protection without IOMMU\n");
871d812aa43e63 Rob Clark 2013-11-16 567 ret = -ENXIO;
871d812aa43e63 Rob Clark 2013-11-16 568 goto fail;
871d812aa43e63 Rob Clark 2013-11-16 569 }
871d812aa43e63 Rob Clark 2013-11-16 570
5785dd7a8ef0de Akhil P Oommen 2020-10-28 571 icc_path = devm_of_icc_get(&pdev->dev, "gfx-mem");
5785dd7a8ef0de Akhil P Oommen 2020-10-28 572 ret = IS_ERR(icc_path);
5785dd7a8ef0de Akhil P Oommen 2020-10-28 573 if (ret)
5785dd7a8ef0de Akhil P Oommen 2020-10-28 574 goto fail;
IS_ERR() returns/true false so this will lead to an Oops in the caller.
icc_path = devm_of_icc_get(&pdev->dev, "gfx-mem");
if (IS_ERR(icc_path)) {
ret = PTR_ERR(icc_path);
goto fail;
}
5785dd7a8ef0de Akhil P Oommen 2020-10-28 575
5785dd7a8ef0de Akhil P Oommen 2020-10-28 576 ocmem_icc_path = devm_of_icc_get(&pdev->dev, "ocmem");
5785dd7a8ef0de Akhil P Oommen 2020-10-28 577 ret = IS_ERR(ocmem_icc_path);
5785dd7a8ef0de Akhil P Oommen 2020-10-28 578 if (ret) {
5785dd7a8ef0de Akhil P Oommen 2020-10-28 579 /* allow -ENODATA, ocmem icc is optional */
5785dd7a8ef0de Akhil P Oommen 2020-10-28 580 if (ret != -ENODATA)
5785dd7a8ef0de Akhil P Oommen 2020-10-28 581 goto fail;
Same. ret is true/false so it can't be equal to -ENODATA, plus the
caller will Oops.
Btw, this patch removed the assignments:
gpu->icc_path = of_icc_get(dev, "gfx-mem");
gpu->ocmem_icc_path = of_icc_get(dev, "ocmem");
So I think "gpu->icc_path" and "gpu->ocmem_icc_path" are always
NULL/unused and they should be removed.
5785dd7a8ef0de Akhil P Oommen 2020-10-28 582 ocmem_icc_path = NULL;
5785dd7a8ef0de Akhil P Oommen 2020-10-28 583 }
5785dd7a8ef0de Akhil P Oommen 2020-10-28 584
5785dd7a8ef0de Akhil P Oommen 2020-10-28 585
d163ba0b65f2e4 Brian Masney 2019-11-21 586 /*
d163ba0b65f2e4 Brian Masney 2019-11-21 587 * Set the ICC path to maximum speed for now by multiplying the fastest
d163ba0b65f2e4 Brian Masney 2019-11-21 588 * frequency by the bus width (8). We'll want to scale this later on to
d163ba0b65f2e4 Brian Masney 2019-11-21 589 * improve battery life.
d163ba0b65f2e4 Brian Masney 2019-11-21 590 */
5785dd7a8ef0de Akhil P Oommen 2020-10-28 591 icc_set_bw(icc_path, 0, Bps_to_icc(gpu->fast_rate) * 8);
5785dd7a8ef0de Akhil P Oommen 2020-10-28 592 icc_set_bw(ocmem_icc_path, 0, Bps_to_icc(gpu->fast_rate) * 8);
d163ba0b65f2e4 Brian Masney 2019-11-21 593
871d812aa43e63 Rob Clark 2013-11-16 594 return gpu;
7198e6b03155f6 Rob Clark 2013-07-19 595
7198e6b03155f6 Rob Clark 2013-07-19 596 fail:
7198e6b03155f6 Rob Clark 2013-07-19 597 if (a3xx_gpu)
7198e6b03155f6 Rob Clark 2013-07-19 598 a3xx_destroy(&a3xx_gpu->base.base);
7198e6b03155f6 Rob Clark 2013-07-19 599
7198e6b03155f6 Rob Clark 2013-07-19 @600 return ERR_PTR(ret);
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
1 year, 5 months
[jonhunter:tegra/for-next 12/12] sound/soc/generic/audio-graph-card.c:545:5: warning: stack frame size of 1568 bytes in function 'audio_graph_parse_of'
by kernel test robot
tree: https://github.com/jonhunter/linux tegra/for-next
head: f126d514b77294bbc3e4fa49b095266e0154ff9e
commit: f126d514b77294bbc3e4fa49b095266e0154ff9e [12/12] ASoC: simple-card-utils: Increase maximum number of links to 128
config: riscv-randconfig-r031-20210416 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6a18cc23efad410db48a3ccfc233d215de7d4cb9)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/jonhunter/linux/commit/f126d514b77294bbc3e4fa49b095266...
git remote add jonhunter https://github.com/jonhunter/linux
git fetch --no-tags jonhunter tegra/for-next
git checkout f126d514b77294bbc3e4fa49b095266e0154ff9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> sound/soc/generic/audio-graph-card.c:545:5: warning: stack frame size of 1568 bytes in function 'audio_graph_parse_of' [-Wframe-larger-than=]
int audio_graph_parse_of(struct asoc_simple_priv *priv, struct device *dev)
^
1 warning generated.
vim +/audio_graph_parse_of +545 sound/soc/generic/audio-graph-card.c
e9cbcf23a28b41 Kuninori Morimoto 2021-03-26 541
6d485e2dac3a0c Thierry Reding 2021-04-16 542 static int graph_get_dais_count(struct asoc_simple_priv *priv,
e32b100bc6ecbc Sameer Pujar 2020-11-02 543 struct link_info *li);
e32b100bc6ecbc Sameer Pujar 2020-11-02 544
6e4ea8aace0247 Sameer Pujar 2021-02-07 @545 int audio_graph_parse_of(struct asoc_simple_priv *priv, struct device *dev)
fce9b90c1ab7e9 Kuninori Morimoto 2018-12-20 546 {
e59289cda8dec0 Kuninori Morimoto 2019-03-20 547 struct snd_soc_card *card = simple_priv_to_card(priv);
fce9b90c1ab7e9 Kuninori Morimoto 2018-12-20 548 struct link_info li;
fce9b90c1ab7e9 Kuninori Morimoto 2018-12-20 549 int ret;
fce9b90c1ab7e9 Kuninori Morimoto 2018-12-20 550
e32b100bc6ecbc Sameer Pujar 2020-11-02 551 card->owner = THIS_MODULE;
e32b100bc6ecbc Sameer Pujar 2020-11-02 552 card->dev = dev;
e32b100bc6ecbc Sameer Pujar 2020-11-02 553
e32b100bc6ecbc Sameer Pujar 2020-11-02 554 memset(&li, 0, sizeof(li));
6d485e2dac3a0c Thierry Reding 2021-04-16 555 ret = graph_get_dais_count(priv, &li);
6d485e2dac3a0c Thierry Reding 2021-04-16 556 if (ret < 0)
6d485e2dac3a0c Thierry Reding 2021-04-16 557 return ret;
6d485e2dac3a0c Thierry Reding 2021-04-16 558
f899006d558546 Kuninori Morimoto 2021-04-12 559 if (!li.link)
e32b100bc6ecbc Sameer Pujar 2020-11-02 560 return -EINVAL;
e32b100bc6ecbc Sameer Pujar 2020-11-02 561
e32b100bc6ecbc Sameer Pujar 2020-11-02 562 ret = asoc_simple_init_priv(priv, &li);
e32b100bc6ecbc Sameer Pujar 2020-11-02 563 if (ret < 0)
e32b100bc6ecbc Sameer Pujar 2020-11-02 564 return ret;
e32b100bc6ecbc Sameer Pujar 2020-11-02 565
e32b100bc6ecbc Sameer Pujar 2020-11-02 566 priv->pa_gpio = devm_gpiod_get_optional(dev, "pa", GPIOD_OUT_LOW);
e32b100bc6ecbc Sameer Pujar 2020-11-02 567 if (IS_ERR(priv->pa_gpio)) {
e32b100bc6ecbc Sameer Pujar 2020-11-02 568 ret = PTR_ERR(priv->pa_gpio);
e32b100bc6ecbc Sameer Pujar 2020-11-02 569 dev_err(dev, "failed to get amplifier gpio: %d\n", ret);
e32b100bc6ecbc Sameer Pujar 2020-11-02 570 return ret;
e32b100bc6ecbc Sameer Pujar 2020-11-02 571 }
e32b100bc6ecbc Sameer Pujar 2020-11-02 572
ad11e59f52d6fc Kuninori Morimoto 2019-03-20 573 ret = asoc_simple_parse_widgets(card, NULL);
fce9b90c1ab7e9 Kuninori Morimoto 2018-12-20 574 if (ret < 0)
fce9b90c1ab7e9 Kuninori Morimoto 2018-12-20 575 return ret;
fce9b90c1ab7e9 Kuninori Morimoto 2018-12-20 576
ad11e59f52d6fc Kuninori Morimoto 2019-03-20 577 ret = asoc_simple_parse_routing(card, NULL);
fce9b90c1ab7e9 Kuninori Morimoto 2018-12-20 578 if (ret < 0)
fce9b90c1ab7e9 Kuninori Morimoto 2018-12-20 579 return ret;
fce9b90c1ab7e9 Kuninori Morimoto 2018-12-20 580
fce9b90c1ab7e9 Kuninori Morimoto 2018-12-20 581 memset(&li, 0, sizeof(li));
97fe6ca4146583 Kuninori Morimoto 2018-12-20 582 ret = graph_for_each_link(priv, &li,
97fe6ca4146583 Kuninori Morimoto 2018-12-20 583 graph_dai_link_of,
97fe6ca4146583 Kuninori Morimoto 2018-12-20 584 graph_dai_link_of_dpcm);
fce9b90c1ab7e9 Kuninori Morimoto 2018-12-20 585 if (ret < 0)
e32b100bc6ecbc Sameer Pujar 2020-11-02 586 goto err;
2692c1c63c29ca Kuninori Morimoto 2017-04-20 587
e32b100bc6ecbc Sameer Pujar 2020-11-02 588 ret = asoc_simple_parse_card_name(card, NULL);
e32b100bc6ecbc Sameer Pujar 2020-11-02 589 if (ret < 0)
e32b100bc6ecbc Sameer Pujar 2020-11-02 590 goto err;
e32b100bc6ecbc Sameer Pujar 2020-11-02 591
e32b100bc6ecbc Sameer Pujar 2020-11-02 592 snd_soc_card_set_drvdata(card, priv);
e32b100bc6ecbc Sameer Pujar 2020-11-02 593
e32b100bc6ecbc Sameer Pujar 2020-11-02 594 asoc_simple_debug_info(priv);
e32b100bc6ecbc Sameer Pujar 2020-11-02 595
e32b100bc6ecbc Sameer Pujar 2020-11-02 596 ret = devm_snd_soc_register_card(dev, card);
e32b100bc6ecbc Sameer Pujar 2020-11-02 597 if (ret < 0)
e32b100bc6ecbc Sameer Pujar 2020-11-02 598 goto err;
e32b100bc6ecbc Sameer Pujar 2020-11-02 599
e32b100bc6ecbc Sameer Pujar 2020-11-02 600 return 0;
e32b100bc6ecbc Sameer Pujar 2020-11-02 601
e32b100bc6ecbc Sameer Pujar 2020-11-02 602 err:
e32b100bc6ecbc Sameer Pujar 2020-11-02 603 asoc_simple_clean_reference(card);
e32b100bc6ecbc Sameer Pujar 2020-11-02 604
e32b100bc6ecbc Sameer Pujar 2020-11-02 605 if (ret != -EPROBE_DEFER)
e32b100bc6ecbc Sameer Pujar 2020-11-02 606 dev_err(dev, "parse error %d\n", ret);
e32b100bc6ecbc Sameer Pujar 2020-11-02 607
e32b100bc6ecbc Sameer Pujar 2020-11-02 608 return ret;
2692c1c63c29ca Kuninori Morimoto 2017-04-20 609 }
6e4ea8aace0247 Sameer Pujar 2021-02-07 610 EXPORT_SYMBOL_GPL(audio_graph_parse_of);
2692c1c63c29ca Kuninori Morimoto 2017-04-20 611
:::::: The code at line 545 was first introduced by commit
:::::: 6e4ea8aace02479186b3fdaab48d7acfe06d8715 ASoC: audio-graph: Rename functions needed for export
:::::: TO: Sameer Pujar <spujar(a)nvidia.com>
:::::: CC: Mark Brown <broonie(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH] ASoC: ak4458: check reset control status
by kernel test robot
Hi Shengjiu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on asoc/for-next]
[also build test ERROR on v5.12-rc7 next-20210415]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Shengjiu-Wang/ASoC-ak4458-check-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: x86_64-randconfig-s021-20210416 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-280-g2cd6d34e-dirty
# https://github.com/0day-ci/linux/commit/48f467759d71681e2d3c35253a6eed08e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Shengjiu-Wang/ASoC-ak4458-check-reset-control-status/20210416-200151
git checkout 48f467759d71681e2d3c35253a6eed08e686bd16
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
sound/soc/codecs/ak4458.c: In function 'ak4458_hw_params':
>> sound/soc/codecs/ak4458.c:422:2: error: 'ret' undeclared (first use in this function); did you mean 'net'?
422 | ret = ak4458_rstn_control(component, 0);
| ^~~
| net
sound/soc/codecs/ak4458.c:422:2: note: each undeclared identifier is reported only once for each function it appears in
vim +422 sound/soc/codecs/ak4458.c
328
329 static int ak4458_hw_params(struct snd_pcm_substream *substream,
330 struct snd_pcm_hw_params *params,
331 struct snd_soc_dai *dai)
332 {
333 struct snd_soc_component *component = dai->component;
334 struct ak4458_priv *ak4458 = snd_soc_component_get_drvdata(component);
335 int pcm_width = max(params_physical_width(params), ak4458->slot_width);
336 u8 format, dsdsel0, dsdsel1;
337 int nfs1, dsd_bclk;
338
339 nfs1 = params_rate(params);
340 ak4458->fs = nfs1;
341
342 /* calculate bit clock */
343 switch (params_format(params)) {
344 case SNDRV_PCM_FORMAT_DSD_U8:
345 case SNDRV_PCM_FORMAT_DSD_U16_LE:
346 case SNDRV_PCM_FORMAT_DSD_U16_BE:
347 case SNDRV_PCM_FORMAT_DSD_U32_LE:
348 case SNDRV_PCM_FORMAT_DSD_U32_BE:
349 dsd_bclk = nfs1 * params_physical_width(params);
350 switch (dsd_bclk) {
351 case 2822400:
352 dsdsel0 = 0;
353 dsdsel1 = 0;
354 break;
355 case 5644800:
356 dsdsel0 = 1;
357 dsdsel1 = 0;
358 break;
359 case 11289600:
360 dsdsel0 = 0;
361 dsdsel1 = 1;
362 break;
363 case 22579200:
364 if (ak4458->drvdata->type == AK4497) {
365 dsdsel0 = 1;
366 dsdsel1 = 1;
367 } else {
368 dev_err(dai->dev, "DSD512 not supported.\n");
369 return -EINVAL;
370 }
371 break;
372 default:
373 dev_err(dai->dev, "Unsupported dsd bclk.\n");
374 return -EINVAL;
375 }
376
377 snd_soc_component_update_bits(component, AK4458_06_DSD1,
378 AK4458_DSDSEL_MASK, dsdsel0);
379 snd_soc_component_update_bits(component, AK4458_09_DSD2,
380 AK4458_DSDSEL_MASK, dsdsel1);
381 break;
382 }
383
384 /* Master Clock Frequency Auto Setting Mode Enable */
385 snd_soc_component_update_bits(component, AK4458_00_CONTROL1, 0x80, 0x80);
386
387 switch (pcm_width) {
388 case 16:
389 if (ak4458->fmt == SND_SOC_DAIFMT_I2S)
390 format = AK4458_DIF_24BIT_I2S;
391 else
392 format = AK4458_DIF_16BIT_LSB;
393 break;
394 case 32:
395 switch (ak4458->fmt) {
396 case SND_SOC_DAIFMT_I2S:
397 format = AK4458_DIF_32BIT_I2S;
398 break;
399 case SND_SOC_DAIFMT_LEFT_J:
400 format = AK4458_DIF_32BIT_MSB;
401 break;
402 case SND_SOC_DAIFMT_RIGHT_J:
403 format = AK4458_DIF_32BIT_LSB;
404 break;
405 case SND_SOC_DAIFMT_DSP_B:
406 format = AK4458_DIF_32BIT_MSB;
407 break;
408 case SND_SOC_DAIFMT_PDM:
409 format = AK4458_DIF_32BIT_MSB;
410 break;
411 default:
412 return -EINVAL;
413 }
414 break;
415 default:
416 return -EINVAL;
417 }
418
419 snd_soc_component_update_bits(component, AK4458_00_CONTROL1,
420 AK4458_DIF_MASK, format);
421
> 422 ret = ak4458_rstn_control(component, 0);
423 if (ret)
424 return ret;
425
426 ret = ak4458_rstn_control(component, 1);
427 if (ret)
428 return ret;
429
430 return 0;
431 }
432
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[linux-next:master 11519/13394] drivers/net/ethernet/renesas/ravb_main.c:2086:6: warning: variable 'priv' is used uninitialized whenever 'if' condition is true
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 18250b538735142307082e4e99e3ae5c12d44013
commit: 8ef7adc6beb2ef0bce83513dc9e4505e7b21e8c2 [11519/13394] net: ethernet: ravb: Enable optional refclk
config: riscv-randconfig-r031-20210416 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6a18cc23efad410db48a3ccfc233d215de7d4cb9)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 8ef7adc6beb2ef0bce83513dc9e4505e7b21e8c2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/renesas/ravb_main.c:2086:6: warning: variable 'priv' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (irq < 0) {
^~~~~~~
drivers/net/ethernet/renesas/ravb_main.c:2254:24: note: uninitialized use occurs here
clk_disable_unprepare(priv->refclk);
^~~~
drivers/net/ethernet/renesas/ravb_main.c:2086:2: note: remove the 'if' if its condition is always false
if (irq < 0) {
^~~~~~~~~~~~~~
drivers/net/ethernet/renesas/ravb_main.c:2046:27: note: initialize the variable 'priv' to silence this warning
struct ravb_private *priv;
^
= NULL
1 warning generated.
vim +2086 drivers/net/ethernet/renesas/ravb_main.c
61fccb2d6274f7 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2017-01-27 2042
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2043 static int ravb_probe(struct platform_device *pdev)
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2044 {
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2045 struct device_node *np = pdev->dev.of_node;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2046 struct ravb_private *priv;
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2047 enum ravb_chip_id chip_id;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2048 struct net_device *ndev;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2049 int error, irq, q;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2050 struct resource *res;
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2051 int i;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2052
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2053 if (!np) {
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2054 dev_err(&pdev->dev,
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2055 "this driver is required to be instantiated from device tree\n");
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2056 return -EINVAL;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2057 }
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2058
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2059 /* Get base address */
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2060 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2061 if (!res) {
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2062 dev_err(&pdev->dev, "invalid resource\n");
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2063 return -EINVAL;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2064 }
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2065
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2066 ndev = alloc_etherdev_mqs(sizeof(struct ravb_private),
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2067 NUM_TX_QUEUE, NUM_RX_QUEUE);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2068 if (!ndev)
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2069 return -ENOMEM;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2070
4d86d381862714 drivers/net/ethernet/renesas/ravb_main.c Simon Horman 2017-10-04 2071 ndev->features = NETIF_F_RXCSUM;
4d86d381862714 drivers/net/ethernet/renesas/ravb_main.c Simon Horman 2017-10-04 2072 ndev->hw_features = NETIF_F_RXCSUM;
4d86d381862714 drivers/net/ethernet/renesas/ravb_main.c Simon Horman 2017-10-04 2073
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2074 pm_runtime_enable(&pdev->dev);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2075 pm_runtime_get_sync(&pdev->dev);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2076
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2077 /* The Ether-specific entries in the device structure. */
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2078 ndev->base_addr = res->start;
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2079
e866863066a4e6 drivers/net/ethernet/renesas/ravb_main.c Wolfram Sang 2016-03-01 2080 chip_id = (enum ravb_chip_id)of_device_get_match_data(&pdev->dev);
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2081
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2082 if (chip_id == RCAR_GEN3)
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2083 irq = platform_get_irq_byname(pdev, "ch22");
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2084 else
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2085 irq = platform_get_irq(pdev, 0);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 @2086 if (irq < 0) {
f375339e497582 drivers/net/ethernet/renesas/ravb_main.c Sergei Shtylyov 2015-08-28 2087 error = irq;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2088 goto out_release;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2089 }
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2090 ndev->irq = irq;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2091
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2092 SET_NETDEV_DEV(ndev, &pdev->dev);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2093
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2094 priv = netdev_priv(ndev);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2095 priv->ndev = ndev;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2096 priv->pdev = pdev;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2097 priv->num_tx_ring[RAVB_BE] = BE_TX_RING_SIZE;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2098 priv->num_rx_ring[RAVB_BE] = BE_RX_RING_SIZE;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2099 priv->num_tx_ring[RAVB_NC] = NC_TX_RING_SIZE;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2100 priv->num_rx_ring[RAVB_NC] = NC_RX_RING_SIZE;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2101 priv->addr = devm_ioremap_resource(&pdev->dev, res);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2102 if (IS_ERR(priv->addr)) {
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2103 error = PTR_ERR(priv->addr);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2104 goto out_release;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2105 }
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2106
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2107 spin_lock_init(&priv->lock);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2108 INIT_WORK(&priv->work, ravb_tx_timeout_work);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2109
0c65b2b90d13c1 drivers/net/ethernet/renesas/ravb_main.c Andrew Lunn 2019-11-04 2110 error = of_get_phy_mode(np, &priv->phy_interface);
0c65b2b90d13c1 drivers/net/ethernet/renesas/ravb_main.c Andrew Lunn 2019-11-04 2111 if (error && error != -ENODEV)
0c65b2b90d13c1 drivers/net/ethernet/renesas/ravb_main.c Andrew Lunn 2019-11-04 2112 goto out_release;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2113
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2114 priv->no_avb_link = of_property_read_bool(np, "renesas,no-ether-link");
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2115 priv->avb_link_active_low =
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2116 of_property_read_bool(np, "renesas,ether-link-active-low");
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2117
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2118 if (chip_id == RCAR_GEN3) {
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2119 irq = platform_get_irq_byname(pdev, "ch24");
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2120 if (irq < 0) {
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2121 error = irq;
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2122 goto out_release;
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2123 }
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2124 priv->emac_irq = irq;
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2125 for (i = 0; i < NUM_RX_QUEUE; i++) {
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2126 irq = platform_get_irq_byname(pdev, ravb_rx_irqs[i]);
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2127 if (irq < 0) {
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2128 error = irq;
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2129 goto out_release;
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2130 }
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2131 priv->rx_irqs[i] = irq;
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2132 }
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2133 for (i = 0; i < NUM_TX_QUEUE; i++) {
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2134 irq = platform_get_irq_byname(pdev, ravb_tx_irqs[i]);
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2135 if (irq < 0) {
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2136 error = irq;
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2137 goto out_release;
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2138 }
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2139 priv->tx_irqs[i] = irq;
f51bdc236b6c58 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2016-04-03 2140 }
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2141 }
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2142
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2143 priv->chip_id = chip_id;
22d4df8ff3a3cc drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2144
3e3d647715d401 drivers/net/ethernet/renesas/ravb_main.c Niklas Söderlund 2017-08-01 2145 priv->clk = devm_clk_get(&pdev->dev, NULL);
ab104615e01c2c drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2017-10-12 2146 if (IS_ERR(priv->clk)) {
ab104615e01c2c drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2017-10-12 2147 error = PTR_ERR(priv->clk);
ab104615e01c2c drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2017-10-12 2148 goto out_release;
ab104615e01c2c drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2017-10-12 2149 }
3e3d647715d401 drivers/net/ethernet/renesas/ravb_main.c Niklas Söderlund 2017-08-01 2150
8ef7adc6beb2ef drivers/net/ethernet/renesas/ravb_main.c Adam Ford 2021-04-12 2151 priv->refclk = devm_clk_get_optional(&pdev->dev, "refclk");
8ef7adc6beb2ef drivers/net/ethernet/renesas/ravb_main.c Adam Ford 2021-04-12 2152 if (IS_ERR(priv->refclk)) {
8ef7adc6beb2ef drivers/net/ethernet/renesas/ravb_main.c Adam Ford 2021-04-12 2153 error = PTR_ERR(priv->refclk);
8ef7adc6beb2ef drivers/net/ethernet/renesas/ravb_main.c Adam Ford 2021-04-12 2154 goto out_release;
8ef7adc6beb2ef drivers/net/ethernet/renesas/ravb_main.c Adam Ford 2021-04-12 2155 }
8ef7adc6beb2ef drivers/net/ethernet/renesas/ravb_main.c Adam Ford 2021-04-12 2156 clk_prepare_enable(priv->refclk);
8ef7adc6beb2ef drivers/net/ethernet/renesas/ravb_main.c Adam Ford 2021-04-12 2157
75efa06f457bbe drivers/net/ethernet/renesas/ravb_main.c Niklas Söderlund 2018-02-16 2158 ndev->max_mtu = 2048 - (ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN);
75efa06f457bbe drivers/net/ethernet/renesas/ravb_main.c Niklas Söderlund 2018-02-16 2159 ndev->min_mtu = ETH_MIN_MTU;
75efa06f457bbe drivers/net/ethernet/renesas/ravb_main.c Niklas Söderlund 2018-02-16 2160
f543305da9b5a5 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2018-09-19 2161 priv->num_tx_desc = chip_id == RCAR_GEN2 ?
f543305da9b5a5 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2018-09-19 2162 NUM_TX_DESC_GEN2 : NUM_TX_DESC_GEN3;
f543305da9b5a5 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2018-09-19 2163
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2164 /* Set function */
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2165 ndev->netdev_ops = &ravb_netdev_ops;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2166 ndev->ethtool_ops = &ravb_ethtool_ops;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2167
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2168 /* Set AVB config mode */
0184165b2f42c4 drivers/net/ethernet/renesas/ravb_main.c Niklas Söderlund 2016-08-03 2169 ravb_set_config_mode(ndev);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2170
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2171 /* Set GTI value */
b3d39a8805c510 drivers/net/ethernet/renesas/ravb_main.c Simon Horman 2015-11-20 2172 error = ravb_set_gti(ndev);
b3d39a8805c510 drivers/net/ethernet/renesas/ravb_main.c Simon Horman 2015-11-20 2173 if (error)
b3d39a8805c510 drivers/net/ethernet/renesas/ravb_main.c Simon Horman 2015-11-20 2174 goto out_release;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2175
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2176 /* Request GTI loading */
568b3ce7a8efdc drivers/net/ethernet/renesas/ravb_main.c Sergei Shtylyov 2016-02-10 2177 ravb_modify(ndev, GCCR, GCCR_LTI, GCCR_LTI);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2178
ce19a9eb53be2f drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2020-10-01 2179 if (priv->chip_id != RCAR_GEN2) {
a6f51f2efa742d drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2020-10-01 2180 ravb_parse_delay_mode(np, ndev);
61fccb2d6274f7 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2017-01-27 2181 ravb_set_delay_mode(ndev);
ce19a9eb53be2f drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2020-10-01 2182 }
61fccb2d6274f7 drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2017-01-27 2183
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2184 /* Allocate descriptor base address table */
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2185 priv->desc_bat_size = sizeof(struct ravb_desc) * DBAT_ENTRY_NUM;
e2dbb33ad9545d drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2186 priv->desc_bat = dma_alloc_coherent(ndev->dev.parent, priv->desc_bat_size,
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2187 &priv->desc_bat_dma, GFP_KERNEL);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2188 if (!priv->desc_bat) {
c451113291c193 drivers/net/ethernet/renesas/ravb_main.c Simon Horman 2015-11-02 2189 dev_err(&pdev->dev,
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2190 "Cannot allocate desc base address table (size %d bytes)\n",
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2191 priv->desc_bat_size);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2192 error = -ENOMEM;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2193 goto out_release;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2194 }
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2195 for (q = RAVB_BE; q < DBAT_ENTRY_NUM; q++)
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2196 priv->desc_bat[q].die_dt = DT_EOS;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2197 ravb_write(ndev, priv->desc_bat_dma, DBAT);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2198
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2199 /* Initialise HW timestamp list */
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2200 INIT_LIST_HEAD(&priv->ts_skb_list);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2201
f5d7837f96e53a drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-12-02 2202 /* Initialise PTP Clock driver */
f5d7837f96e53a drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-12-02 2203 if (chip_id != RCAR_GEN2)
f5d7837f96e53a drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-12-02 2204 ravb_ptp_init(ndev, pdev);
f5d7837f96e53a drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-12-02 2205
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2206 /* Debug message level */
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2207 priv->msg_enable = RAVB_DEF_MSG_ENABLE;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2208
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2209 /* Read and set MAC address */
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2210 ravb_read_mac_address(ndev, of_get_mac_address(np));
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2211 if (!is_valid_ether_addr(ndev->dev_addr)) {
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2212 dev_warn(&pdev->dev,
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2213 "no valid MAC address supplied, using a random one\n");
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2214 eth_hw_addr_random(ndev);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2215 }
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2216
77972b55fb9d35 drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2020-09-22 2217 /* MDIO bus init */
77972b55fb9d35 drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2020-09-22 2218 error = ravb_mdio_init(priv);
77972b55fb9d35 drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2020-09-22 2219 if (error) {
77972b55fb9d35 drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2020-09-22 2220 dev_err(&pdev->dev, "failed to initialize MDIO\n");
77972b55fb9d35 drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2020-09-22 2221 goto out_dma_free;
77972b55fb9d35 drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2020-09-22 2222 }
77972b55fb9d35 drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2020-09-22 2223
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2224 netif_napi_add(ndev, &priv->napi[RAVB_BE], ravb_poll, 64);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2225 netif_napi_add(ndev, &priv->napi[RAVB_NC], ravb_poll, 64);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2226
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2227 /* Network device register */
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2228 error = register_netdev(ndev);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2229 if (error)
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2230 goto out_napi_del;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2231
3e3d647715d401 drivers/net/ethernet/renesas/ravb_main.c Niklas Söderlund 2017-08-01 2232 device_set_wakeup_capable(&pdev->dev, 1);
3e3d647715d401 drivers/net/ethernet/renesas/ravb_main.c Niklas Söderlund 2017-08-01 2233
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2234 /* Print device information */
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2235 netdev_info(ndev, "Base address at %#x, %pM, IRQ %d.\n",
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2236 (u32)ndev->base_addr, ndev->dev_addr, ndev->irq);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2237
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2238 platform_set_drvdata(pdev, ndev);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2239
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2240 return 0;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2241
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2242 out_napi_del:
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2243 netif_napi_del(&priv->napi[RAVB_NC]);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2244 netif_napi_del(&priv->napi[RAVB_BE]);
77972b55fb9d35 drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2020-09-22 2245 ravb_mdio_release(priv);
77972b55fb9d35 drivers/net/ethernet/renesas/ravb_main.c Geert Uytterhoeven 2020-09-22 2246 out_dma_free:
e2dbb33ad9545d drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-09-30 2247 dma_free_coherent(ndev->dev.parent, priv->desc_bat_size, priv->desc_bat,
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2248 priv->desc_bat_dma);
f5d7837f96e53a drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-12-02 2249
f5d7837f96e53a drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-12-02 2250 /* Stop PTP Clock driver */
f5d7837f96e53a drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-12-02 2251 if (chip_id != RCAR_GEN2)
f5d7837f96e53a drivers/net/ethernet/renesas/ravb_main.c Kazuya Mizuguchi 2015-12-02 2252 ravb_ptp_stop(ndev);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2253 out_release:
8ef7adc6beb2ef drivers/net/ethernet/renesas/ravb_main.c Adam Ford 2021-04-12 2254 clk_disable_unprepare(priv->refclk);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2255 free_netdev(ndev);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2256
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2257 pm_runtime_put(&pdev->dev);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2258 pm_runtime_disable(&pdev->dev);
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2259 return error;
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2260 }
c156633f135326 drivers/net/ethernet/renesas/ravb.c Sergei Shtylyov 2015-06-11 2261
:::::: The code at line 2086 was first introduced by commit
:::::: c156633f1353264634135dea86ffcae74f2122fc Renesas Ethernet AVB driver proper
:::::: TO: Sergei Shtylyov <sergei.shtylyov(a)cogentembedded.com>
:::::: CC: David S. Miller <davem(a)davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[chrome-os:chromeos-5.4 56/237] drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_req_lat_if.c:1107:4: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int')
by kernel test robot
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head: 62f6761889a59411f5673ba61d7ae465372ca9c6
commit: bc0b0ae994e6bb17b12bfd882c2eb837eb29c078 [56/237] CHROMIUM: media: mtk-vcodec: Add vp9 slice api driver for mt8192
config: arm-randconfig-r024-20210416 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6a18cc23efad410db48a3ccfc233d215de7d4cb9)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel
git fetch --no-tags chrome-os chromeos-5.4
git checkout bc0b0ae994e6bb17b12bfd882c2eb837eb29c078
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_req_lat_if.c:1107:4: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
bs->size, offset);
^~~~~~~~
drivers/media/platform/mtk-vcodec/vdec/../mtk_vcodec_util.h:38:60: note: expanded from macro 'mtk_vcodec_err'
((struct mtk_vcodec_ctx *)h->ctx)->id, __func__, ##args)
^~~~
include/linux/printk.h:299:33: note: expanded from macro 'pr_err'
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
1 warning generated.
vim +1107 drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_req_lat_if.c
1059
1060 /*
1061 * parse tiles according to `6.4 Decode tiles syntax`
1062 * in "vp9-bitstream-specification"
1063 *
1064 * frame contains uncompress header, compressed header and several tiles.
1065 * this function parses tiles' position and size, stores them to tile buffer
1066 * for decoding.
1067 */
1068 static int vdec_vp9_slice_setup_tile_buffer(
1069 struct vdec_vp9_slice_instance *instance,
1070 struct vdec_vp9_slice_vsi * vsi,
1071 struct mtk_vcodec_mem *bs)
1072 {
1073 struct vdec_vp9_slice_uncompressed_header *uh;
1074 unsigned int rows_log2;
1075 unsigned int cols_log2;
1076 unsigned int rows;
1077 unsigned int cols;
1078 unsigned int mi_row;
1079 unsigned int mi_col;
1080 unsigned int offset;
1081 unsigned int pa;
1082 unsigned int size;
1083 struct vdec_vp9_slice_tiles *tiles;
1084 unsigned char *pos;
1085 unsigned char *end;
1086 unsigned char *va;
1087 unsigned int *tb;
1088 int i;
1089 int j;
1090
1091 uh = &vsi->frame.uh;
1092 rows_log2 = uh->tile_rows_log2;
1093 cols_log2 = uh->tile_cols_log2;
1094 rows = 1 << rows_log2;
1095 cols = 1 << cols_log2;
1096
1097 if (rows > 4 || cols > 64) {
1098 mtk_vcodec_err(instance, "tile_rows %u tile_cols %u\n",
1099 rows, cols);
1100 return -EINVAL;
1101 }
1102
1103 offset = uh->uncompressed_header_size +
1104 uh->header_size_in_bytes;
1105 if (bs->size <= offset) {
1106 mtk_vcodec_err(instance, "bs size %lu tile offset %u\n",
> 1107 bs->size, offset);
1108 return -EINVAL;
1109 }
1110
1111 tiles = &vsi->frame.tiles;
1112 /* setup tile buffer */
1113
1114 va = (unsigned char *)bs->va;
1115 pos = va + offset;
1116 end = va + bs->size;
1117 /* truncated */
1118 pa = (unsigned int)bs->dma_addr + offset;
1119 tb = instance->tile.va;
1120 for (i = 0; i < rows; i++) {
1121 for (j = 0; j < cols; j++) {
1122 if (i == rows - 1 &&
1123 j == cols - 1) {
1124 size = (unsigned int)(end - pos);
1125 } else {
1126 if (end - pos < 4) {
1127 mtk_vcodec_err(instance,
1128 "tile %px %px\n", end, pos);
1129 return -EINVAL;
1130 }
1131 size = (pos[0] << 24) | (pos[1] << 16) |
1132 (pos[2] << 8) | pos[3];
1133 pos += 4;
1134 pa += 4;
1135 offset += 4;
1136 if (end - pos < size) {
1137 mtk_vcodec_err(instance,
1138 "tile %px %px %u\n",
1139 end, pos, size);
1140 return -EINVAL;
1141 }
1142 }
1143 tiles->size[i][j] = size;
1144 if (tiles->mi_rows[i]) {
1145 *tb++ = (size << 3) + ((offset << 3) & 0x7f);
1146 *tb++ = pa &~0xf;
1147 *tb++ = (pa << 3) & 0x7f;
1148 mi_row = (tiles->mi_rows[i] - 1) & 0x1ff;
1149 mi_col = (tiles->mi_cols[j] - 1) & 0x3f;
1150 *tb++ = (mi_row << 6) + mi_col;
1151 }
1152 pos += size;
1153 pa += size;
1154 offset += size;
1155 }
1156 }
1157
1158 return 0;
1159 }
1160
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months