[bvanassche:scsi-for-next 35/41] drivers/scsi/cxlflash/superpipe.c:373:10: error: invalid operands to binary & (have 'union scsi_status' and 'int')
by kernel test robot
tree: https://github.com/bvanassche/linux scsi-for-next
head: d8044d773ae9d9e70f9c61f98296c6c8391447ad
commit: 4e1b57cbdabcd444b21d5c463cfa1d4579dc1fb0 [35/41] Change the return type of scsi_execute() into union scsi_status
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/bvanassche/linux/commit/4e1b57cbdabcd444b21d5c463cfa1d...
git remote add bvanassche https://github.com/bvanassche/linux
git fetch --no-tags bvanassche scsi-for-next
git checkout 4e1b57cbdabcd444b21d5c463cfa1d4579dc1fb0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from arch/powerpc/include/asm/io.h:27,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from arch/powerpc/include/asm/hardirq.h:6,
from include/linux/hardirq.h:10,
from include/linux/interrupt.h:11,
from drivers/scsi/cxlflash/superpipe.c:13:
drivers/scsi/cxlflash/superpipe.c: In function 'read_cap16':
>> drivers/scsi/cxlflash/superpipe.c:366:16: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'union scsi_status' [-Wformat=]
366 | dev_err(dev, "%s: Failed state result=%08x\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
| ^~~
drivers/scsi/cxlflash/superpipe.c:366:3: note: in expansion of macro 'dev_err'
366 | dev_err(dev, "%s: Failed state result=%08x\n",
| ^~~~~~~
drivers/scsi/cxlflash/superpipe.c:366:44: note: format string is defined here
366 | dev_err(dev, "%s: Failed state result=%08x\n",
| ~~~^
| |
| unsigned int
>> drivers/scsi/cxlflash/superpipe.c:373:10: error: invalid operands to binary & (have 'union scsi_status' and 'int')
373 | result &= ~(0xFF<<24); /* DRIVER_SENSE is not an error */
| ^~
drivers/scsi/cxlflash/superpipe.c:374:14: error: invalid operands to binary & (have 'union scsi_status' and 'int')
374 | if (result & SAM_STAT_CHECK_CONDITION) {
| ^
drivers/scsi/cxlflash/superpipe.c:379:12: error: invalid operands to binary & (have 'union scsi_status' and 'int')
379 | result &= ~SAM_STAT_CHECK_CONDITION;
| ^~
>> drivers/scsi/cxlflash/superpipe.c:401:6: error: used union type value where scalar is required
401 | if (result) {
| ^~~~~~
In file included from include/linux/device.h:15,
from arch/powerpc/include/asm/io.h:27,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from arch/powerpc/include/asm/hardirq.h:6,
from include/linux/hardirq.h:10,
from include/linux/interrupt.h:11,
from drivers/scsi/cxlflash/superpipe.c:13:
drivers/scsi/cxlflash/superpipe.c:402:16: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'union scsi_status' [-Wformat=]
402 | dev_err(dev, "%s: command failed, result=%08x\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
| ^~~
drivers/scsi/cxlflash/superpipe.c:402:3: note: in expansion of macro 'dev_err'
402 | dev_err(dev, "%s: command failed, result=%08x\n",
| ^~~~~~~
drivers/scsi/cxlflash/superpipe.c:402:47: note: format string is defined here
402 | dev_err(dev, "%s: command failed, result=%08x\n",
| ~~~^
| |
| unsigned int
--
In file included from include/linux/device.h:15,
from arch/powerpc/include/asm/io.h:27,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from arch/powerpc/include/asm/hardirq.h:6,
from include/linux/hardirq.h:10,
from include/linux/interrupt.h:11,
from drivers/scsi/cxlflash/vlun.c:11:
drivers/scsi/cxlflash/vlun.c: In function 'write_same16':
>> drivers/scsi/cxlflash/vlun.c:459:17: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'union scsi_status' [-Wformat=]
459 | dev_err(dev, "%s: Failed state result=%08x\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
| ^~~
drivers/scsi/cxlflash/vlun.c:459:4: note: in expansion of macro 'dev_err'
459 | dev_err(dev, "%s: Failed state result=%08x\n",
| ^~~~~~~
drivers/scsi/cxlflash/vlun.c:459:45: note: format string is defined here
459 | dev_err(dev, "%s: Failed state result=%08x\n",
| ~~~^
| |
| unsigned int
>> drivers/scsi/cxlflash/vlun.c:465:7: error: used union type value where scalar is required
465 | if (result) {
| ^~~~~~
In file included from include/linux/device.h:15,
from arch/powerpc/include/asm/io.h:27,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from arch/powerpc/include/asm/hardirq.h:6,
from include/linux/hardirq.h:10,
from include/linux/interrupt.h:11,
from drivers/scsi/cxlflash/vlun.c:11:
drivers/scsi/cxlflash/vlun.c:466:29: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'union scsi_status' [-Wformat=]
466 | dev_err_ratelimited(dev, "%s: command failed for "
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
| ^~~
include/linux/dev_printk.h:176:3: note: in expansion of macro 'dev_err'
176 | dev_level(dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~
include/linux/dev_printk.h:186:2: note: in expansion of macro 'dev_level_ratelimited'
186 | dev_level_ratelimited(dev_err, dev, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~
drivers/scsi/cxlflash/vlun.c:466:4: note: in expansion of macro 'dev_err_ratelimited'
466 | dev_err_ratelimited(dev, "%s: command failed for "
| ^~~~~~~~~~~~~~~~~~~
drivers/scsi/cxlflash/vlun.c:467:33: note: format string is defined here
467 | "offset=%lld result=%08x\n",
| ~~~^
| |
| unsigned int
vim +373 drivers/scsi/cxlflash/superpipe.c
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 304
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 305 /**
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 306 * read_cap16() - issues a SCSI READ_CAP16 command
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 307 * @sdev: SCSI device associated with LUN.
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 308 * @lli: LUN destined for capacity request.
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 309 *
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 310 * The READ_CAP16 can take quite a while to complete. Should an EEH occur while
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 311 * in scsi_execute(), the EEH handler will attempt to recover. As part of the
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 312 * recovery, the handler drains all currently running ioctls, waiting until they
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 313 * have completed before proceeding with a reset. As this routine is used on the
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 314 * ioctl path, this can create a condition where the EEH handler becomes stuck,
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 315 * infinitely waiting for this ioctl thread. To avoid this behavior, temporarily
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 316 * unmark this thread as an ioctl thread by releasing the ioctl read semaphore.
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 317 * This will allow the EEH handler to proceed with a recovery while this thread
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 318 * is still running. Once the scsi_execute() returns, reacquire the ioctl read
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 319 * semaphore and check the adapter state in case it changed while inside of
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 320 * scsi_execute(). The state check will wait if the adapter is still being
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 321 * recovered or return a failure if the recovery failed. In the event that the
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 322 * adapter reset failed, simply return the failure as the ioctl would be unable
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 323 * to continue.
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 324 *
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 325 * Note that the above puts a requirement on this routine to only be called on
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 326 * an ioctl thread.
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 327 *
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 328 * Return: 0 on success, -errno on failure
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 329 */
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 330 static int read_cap16(struct scsi_device *sdev, struct llun_info *lli)
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 331 {
fb67d44dfbdf85d Matthew R. Ochs 2017-01-11 332 struct cxlflash_cfg *cfg = shost_priv(sdev->host);
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 333 struct device *dev = &cfg->dev->dev;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 334 struct glun_info *gli = lli->parent;
76aaf87b4cdc7f7 Christoph Hellwig 2017-02-23 335 struct scsi_sense_hdr sshdr;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 336 u8 *cmd_buf = NULL;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 337 u8 *scsi_cmd = NULL;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 338 int rc = 0;
4e1b57cbdabcd44 Bart Van Assche 2021-04-09 339 union scsi_status result = { };
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 340 int retry_cnt = 0;
471a5a60aaf13b2 Manoj Kumar 2015-10-21 341 u32 to = CMD_TIMEOUT * HZ;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 342
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 343 retry:
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 344 cmd_buf = kzalloc(CMD_BUFSIZE, GFP_KERNEL);
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 345 scsi_cmd = kzalloc(MAX_COMMAND_SIZE, GFP_KERNEL);
1fd89e4ddcec0c8 Kees Cook 2018-07-31 346 if (unlikely(!cmd_buf || !scsi_cmd)) {
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 347 rc = -ENOMEM;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 348 goto out;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 349 }
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 350
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 351 scsi_cmd[0] = SERVICE_ACTION_IN_16; /* read cap(16) */
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 352 scsi_cmd[1] = SAI_READ_CAPACITY_16; /* service action */
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 353 put_unaligned_be32(CMD_BUFSIZE, &scsi_cmd[10]);
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 354
fb67d44dfbdf85d Matthew R. Ochs 2017-01-11 355 dev_dbg(dev, "%s: %ssending cmd(%02x)\n", __func__,
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 356 retry_cnt ? "re" : "", scsi_cmd[0]);
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 357
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 358 /* Drop the ioctl read semahpore across lengthy call */
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 359 up_read(&cfg->ioctl_rwsem);
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 360 result = scsi_execute(sdev, scsi_cmd, DMA_FROM_DEVICE, cmd_buf,
1fd89e4ddcec0c8 Kees Cook 2018-07-31 361 CMD_BUFSIZE, NULL, &sshdr, to, CMD_RETRIES,
76aaf87b4cdc7f7 Christoph Hellwig 2017-02-23 362 0, 0, NULL);
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 363 down_read(&cfg->ioctl_rwsem);
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 364 rc = check_state(cfg);
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 365 if (rc) {
fb67d44dfbdf85d Matthew R. Ochs 2017-01-11 @366 dev_err(dev, "%s: Failed state result=%08x\n",
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 367 __func__, result);
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 368 rc = -ENODEV;
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 369 goto out;
aacb4ff69eea4ac Matthew R. Ochs 2015-10-21 370 }
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 371
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 372 if (driver_byte(result) == DRIVER_SENSE) {
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 @373 result &= ~(0xFF<<24); /* DRIVER_SENSE is not an error */
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 374 if (result & SAM_STAT_CHECK_CONDITION) {
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 375 switch (sshdr.sense_key) {
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 376 case NO_SENSE:
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 377 case RECOVERED_ERROR:
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 378 case NOT_READY:
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 379 result &= ~SAM_STAT_CHECK_CONDITION;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 380 break;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 381 case UNIT_ATTENTION:
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 382 switch (sshdr.asc) {
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 383 case 0x29: /* Power on Reset or Device Reset */
df561f6688fef77 Gustavo A. R. Silva 2020-08-23 384 fallthrough;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 385 case 0x2A: /* Device capacity changed */
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 386 case 0x3F: /* Report LUNs changed */
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 387 /* Retry the command once more */
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 388 if (retry_cnt++ < 1) {
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 389 kfree(cmd_buf);
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 390 kfree(scsi_cmd);
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 391 goto retry;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 392 }
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 393 }
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 394 break;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 395 default:
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 396 break;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 397 }
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 398 }
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 399 }
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 400
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 @401 if (result) {
fb67d44dfbdf85d Matthew R. Ochs 2017-01-11 402 dev_err(dev, "%s: command failed, result=%08x\n",
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 403 __func__, result);
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 404 rc = -EIO;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 405 goto out;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 406 }
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 407
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 408 /*
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 409 * Read cap was successful, grab values from the buffer;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 410 * note that we don't need to worry about unaligned access
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 411 * as the buffer is allocated on an aligned boundary.
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 412 */
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 413 mutex_lock(&gli->mutex);
1786f4a09331986 Matthew R. Ochs 2015-10-21 414 gli->max_lba = be64_to_cpu(*((__be64 *)&cmd_buf[0]));
1786f4a09331986 Matthew R. Ochs 2015-10-21 415 gli->blk_len = be32_to_cpu(*((__be32 *)&cmd_buf[8]));
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 416 mutex_unlock(&gli->mutex);
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 417
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 418 out:
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 419 kfree(cmd_buf);
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 420 kfree(scsi_cmd);
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 421
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 422 dev_dbg(dev, "%s: maxlba=%lld blklen=%d rc=%d\n",
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 423 __func__, gli->max_lba, gli->blk_len, rc);
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 424 return rc;
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 425 }
65be2c79acc3aa0 Matthew R. Ochs 2015-08-13 426
:::::: The code at line 373 was first introduced by commit
:::::: 65be2c79acc3aa0f9c0e8d4871f5a451d854465a cxlflash: Superpipe support
:::::: TO: Matthew R. Ochs <mrochs(a)linux.vnet.ibm.com>
:::::: CC: James Bottomley <JBottomley(a)Odin.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[chrome-os:chromeos-5.10 46/62] drivers/gpu/drm/i915/gt/intel_breadcrumbs.c:456:16: error: unused variable 'flags'
by kernel test robot
Hi Sean,
FYI, the error/warning still remains.
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.10
head: 03729897b7fbbb957d194d359b6deb9902652957
commit: 2aafbed9832f90f66592f9055153c2e3cfcfddce [46/62] CHROMIUM: drm/i915: Fix spinlock recursion in intel_breadcrumbs
config: i386-randconfig-r034-20210414 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel
git fetch --no-tags chrome-os chromeos-5.10
git checkout 2aafbed9832f90f66592f9055153c2e3cfcfddce
# save the attached .config to linux build tree
make W=1 W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/gt/intel_breadcrumbs.c: In function 'i915_request_cancel_breadcrumb':
>> drivers/gpu/drm/i915/gt/intel_breadcrumbs.c:456:16: error: unused variable 'flags' [-Werror=unused-variable]
456 | unsigned long flags;
| ^~~~~
cc1: all warnings being treated as errors
vim +/flags +456 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
c81d46138da658 drivers/gpu/drm/i915/intel_breadcrumbs.c Chris Wilson 2016-07-01 451
52c0fdb25c7c91 drivers/gpu/drm/i915/intel_breadcrumbs.c Chris Wilson 2019-01-29 452 void i915_request_cancel_breadcrumb(struct i915_request *rq)
9eb143bbec7dfd drivers/gpu/drm/i915/intel_breadcrumbs.c Chris Wilson 2017-02-23 453 {
e8e67d1c9d9215 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-11-26 454 struct intel_breadcrumbs *b = READ_ONCE(rq->engine)->breadcrumbs;
9f3ccd40acf4a3 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2019-12-20 455 struct intel_context *ce = rq->context;
71e8f381dfef38 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-12-24 @456 unsigned long flags;
2bfdf302465a5e drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-11-26 457 bool release;
2bfdf302465a5e drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-11-26 458
2545b18b98348d drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2021-01-19 459 spin_lock(&ce->signal_lock);
2545b18b98348d drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2021-01-19 460 if (!test_and_clear_bit(I915_FENCE_FLAG_SIGNAL, &rq->fence.flags)) {
2545b18b98348d drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2021-01-19 461 spin_unlock(&ce->signal_lock);
2bfdf302465a5e drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-11-26 462 return;
2545b18b98348d drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2021-01-19 463 }
c81d46138da658 drivers/gpu/drm/i915/intel_breadcrumbs.c Chris Wilson 2016-07-01 464
2bfdf302465a5e drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-11-26 465 list_del_rcu(&rq->signal_link);
e8e67d1c9d9215 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-11-26 466 release = remove_signaling_context(b, ce);
2aafbed9832f90 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Sean Paul 2021-04-09 467 spin_unlock(&ce->signal_lock);
2bfdf302465a5e drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-11-26 468 if (release)
2bfdf302465a5e drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-11-26 469 intel_context_put(ce);
c81d46138da658 drivers/gpu/drm/i915/intel_breadcrumbs.c Chris Wilson 2016-07-01 470
e8e67d1c9d9215 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-11-26 471 if (__i915_request_is_complete(rq))
e8e67d1c9d9215 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-11-26 472 irq_signal_request(rq, b);
e8e67d1c9d9215 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-11-26 473
e23005604b2f81 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c Chris Wilson 2020-08-01 474 i915_request_put(rq);
688e6c7258164d drivers/gpu/drm/i915/intel_breadcrumbs.c Chris Wilson 2016-07-01 475 }
ad07dfcddf1394 drivers/gpu/drm/i915/intel_breadcrumbs.c Chris Wilson 2016-10-07 476
:::::: The code at line 456 was first introduced by commit
:::::: 71e8f381dfef3815cb7698f561d319606716b5f7 FROMGIT: drm/i915/gt: Remove virtual breadcrumb before transfer
:::::: TO: Chris Wilson <chris(a)chris-wilson.co.uk>
:::::: CC: Azhar Shaikh <azhar.shaikh(a)intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:306:26: sparse: sparse: incorrect type in argument 1 (different address spaces)
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: eebe426d32e1a10ac7c35f8ffab5f818c32a2454
commit: 8f28ca6bd8211214faf717677bbffe375c2a6072 iomap: constify ioreadX() iomem argument (as in generic implementation)
date: 8 months ago
config: alpha-randconfig-s032-20210414 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-280-g2cd6d34e-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 8f28ca6bd8211214faf717677bbffe375c2a6072
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2135:41: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *reg @@ got unsigned int [noderef] __iomem * @@
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2135:41: sparse: expected void *reg
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2135:41: sparse: got unsigned int [noderef] __iomem *
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:33: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned short [usertype] uid_hi @@ got restricted __be16 [usertype] @@
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:33: sparse: expected unsigned short [usertype] uid_hi
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:33: sparse: got restricted __be16 [usertype]
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:45: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned int [usertype] uid_lo @@ got restricted __be32 [usertype] @@
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:45: sparse: expected unsigned int [usertype] uid_lo
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:45: sparse: got restricted __be32 [usertype]
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:56: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected unsigned short [usertype] seqid @@ got restricted __be16 [usertype] @@
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:56: sparse: expected unsigned short [usertype] seqid
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:157:56: sparse: got restricted __be16 [usertype]
>> drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:306:26: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __iomem * @@ got void *reg @@
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:306:26: sparse: expected void const [noderef] __iomem *
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:306:26: sparse: got void *reg
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:336:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *reg @@ got unsigned int [noderef] __iomem * @@
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:336:33: sparse: expected void *reg
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:336:33: sparse: got unsigned int [noderef] __iomem *
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:343:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *reg @@ got unsigned int [noderef] __iomem * @@
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:343:33: sparse: expected void *reg
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:343:33: sparse: got unsigned int [noderef] __iomem *
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:356:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *reg @@ got unsigned int [noderef] __iomem * @@
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:356:33: sparse: expected void *reg
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:356:33: sparse: got unsigned int [noderef] __iomem *
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:397:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *reg @@ got unsigned int [noderef] __iomem * @@
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:397:33: sparse: expected void *reg
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:397:33: sparse: got unsigned int [noderef] __iomem *
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:466:41: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *reg @@ got unsigned int [noderef] __iomem * @@
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:466:41: sparse: expected void *reg
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:466:41: sparse: got unsigned int [noderef] __iomem *
vim +306 drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 294
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 295 /**
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 296 * pch_gbe_wait_clr_bit - Wait to clear a bit
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 297 * @reg: Pointer of register
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 298 * @busy: Busy bit
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 299 */
191cc687740834 drivers/net/pch_gbe/pch_gbe_main.c stephen hemminger 2010-10-15 300 static void pch_gbe_wait_clr_bit(void *reg, u32 bit)
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 301 {
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 302 u32 tmp;
453ca931f51516 drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c Andy Shevchenko 2013-06-28 303
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 304 /* wait busy */
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 305 tmp = 1000;
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 @306 while ((ioread32(reg) & bit) && --tmp)
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 307 cpu_relax();
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 308 if (!tmp)
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 309 pr_err("Error: busy bit is not cleared\n");
77555ee7228234 drivers/net/pch_gbe/pch_gbe_main.c Masayuki Ohtake 2010-09-21 310 }
124d770a6459be drivers/net/pch_gbe/pch_gbe_main.c Toshiharu Okada 2011-09-01 311
:::::: The code at line 306 was first introduced by commit
:::::: 77555ee7228234257957fd54daa0b69178906320 net: Add Gigabit Ethernet driver of Topcliff PCH
:::::: TO: Masayuki Ohtake <masa-korg(a)dsn.okisemi.com>
:::::: CC: David S. Miller <davem(a)davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH 05/13] scsi: qedi: fix abort vs cmd re-use race
by kernel test robot
Hi Mike,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next rdma/for-next v5.12-rc7 next-20210413]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mike-Christie/scsi-libicsi-and-q...
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: x86_64-randconfig-m001-20210414 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
smatch warnings:
drivers/scsi/qedi/qedi_iscsi.c:1401 qedi_cleanup_task() warn: always true condition '(cmd->task_id != -1) => (0-u16max != (-1))'
vim +1401 drivers/scsi/qedi/qedi_iscsi.c
1386
1387 static void qedi_cleanup_task(struct iscsi_task *task)
1388 {
1389 struct qedi_cmd *cmd;
1390
1391 if (task->state == ISCSI_TASK_PENDING) {
1392 QEDI_INFO(NULL, QEDI_LOG_IO, "Returning ref_cnt=%d\n",
1393 refcount_read(&task->refcount));
1394 return;
1395 }
1396
1397 if (task->sc)
1398 qedi_iscsi_unmap_sg_list(task->dd_data);
1399
1400 cmd = task->dd_data;
> 1401 if (cmd->task_id != -1)
1402 qedi_clear_task_idx(iscsi_host_priv(task->conn->session->host),
1403 cmd->task_id);
1404
1405 cmd->task_id = -1;
1406 cmd->scsi_cmd = NULL;
1407 }
1408
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[lee-mfd:ib-mfd-clk-gpio-regulator-rtc-5.13 10/16] drivers/regulator/rohm-regulator.c:44:10: error: implicit declaration of function 'regulator_desc_list_voltage_linear'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-clk-gpio-regulator-rtc-5.13
head: 5a8a64d9a38b9d3794f9f5e153fc0358b858cc24
commit: 9cf37cec4b7d2cb972ba1682dd5c8f39a5761129 [10/16] regulator: rohm-regulator: linear voltage support
config: arm64-randconfig-r006-20210414 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?id=9c...
git remote add lee-mfd https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
git fetch --no-tags lee-mfd ib-mfd-clk-gpio-regulator-rtc-5.13
git checkout 9cf37cec4b7d2cb972ba1682dd5c8f39a5761129
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/regulator/rohm-regulator.c:44:10: error: implicit declaration of function 'regulator_desc_list_voltage_linear' [-Werror,-Wimplicit-function-declaration]
ret = regulator_desc_list_voltage_linear(desc, i);
^
drivers/regulator/rohm-regulator.c:44:10: note: did you mean 'regulator_list_voltage_linear'?
include/linux/regulator/driver.h:498:5: note: 'regulator_list_voltage_linear' declared here
int regulator_list_voltage_linear(struct regulator_dev *rdev,
^
1 error generated.
vim +/regulator_desc_list_voltage_linear +44 drivers/regulator/rohm-regulator.c
10
11 static int set_dvs_level(const struct regulator_desc *desc,
12 struct device_node *np, struct regmap *regmap,
13 char *prop, unsigned int reg, unsigned int mask,
14 unsigned int omask, unsigned int oreg)
15 {
16 int ret, i;
17 uint32_t uv;
18
19 ret = of_property_read_u32(np, prop, &uv);
20 if (ret) {
21 if (ret != -EINVAL)
22 return ret;
23 return 0;
24 }
25 /* If voltage is set to 0 => disable */
26 if (uv == 0) {
27 if (omask)
28 return regmap_update_bits(regmap, oreg, omask, 0);
29 }
30 /* Some setups don't allow setting own voltage but do allow enabling */
31 if (!mask) {
32 if (omask)
33 return regmap_update_bits(regmap, oreg, omask, omask);
34
35 return -EINVAL;
36 }
37 for (i = 0; i < desc->n_voltages; i++) {
38 /* NOTE to next hacker - Does not support pickable ranges */
39 if (desc->linear_range_selectors)
40 return -EINVAL;
41 if (desc->n_linear_ranges)
42 ret = regulator_desc_list_voltage_linear_range(desc, i);
43 else
> 44 ret = regulator_desc_list_voltage_linear(desc, i);
45 if (ret < 0)
46 continue;
47 if (ret == uv) {
48 i <<= ffs(desc->vsel_mask) - 1;
49 ret = regmap_update_bits(regmap, reg, mask, i);
50 if (omask && !ret)
51 ret = regmap_update_bits(regmap, oreg, omask,
52 omask);
53 break;
54 }
55 }
56 return ret;
57 }
58
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
fs/nfs/super.c:90:40: warning: unused variable 'nfs_ssc_clnt_ops_tbl'
by kernel test robot
Hi Dai,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 50987beca096a7ed4f453a6da245fd6a2fadedeb
commit: 02591f9febd5f69bb4c266a4abf899c4cf21964f NFSv4_2: SSC helper should use its own config.
date: 3 months ago
config: arm-randconfig-r016-20210414 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 02591f9febd5f69bb4c266a4abf899c4cf21964f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> fs/nfs/super.c:90:40: warning: unused variable 'nfs_ssc_clnt_ops_tbl' [-Wunused-const-variable]
static const struct nfs_ssc_client_ops nfs_ssc_clnt_ops_tbl = {
^
1 warning generated.
--
>> fs/nfs/nfs4file.c:410:41: warning: unused variable 'nfs4_ssc_clnt_ops_tbl' [-Wunused-const-variable]
static const struct nfs4_ssc_client_ops nfs4_ssc_clnt_ops_tbl = {
^
1 warning generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
Depends on ARCH_SUSPEND_POSSIBLE
Selected by
- ARM_QCOM_SPM_CPUIDLE && CPU_IDLE && (ARM || ARM64) && (ARCH_QCOM || COMPILE_TEST && !ARM64
vim +/nfs_ssc_clnt_ops_tbl +90 fs/nfs/super.c
f7b422b17ee5ee David Howells 2006-06-09 88
02591f9febd5f6 Dai Ngo 2021-01-28 89 #ifdef CONFIG_NFS_V4_2
0cfcd405e758ba Dai Ngo 2020-10-18 @90 static const struct nfs_ssc_client_ops nfs_ssc_clnt_ops_tbl = {
0cfcd405e758ba Dai Ngo 2020-10-18 91 .sco_sb_deactive = nfs_sb_deactive,
0cfcd405e758ba Dai Ngo 2020-10-18 92 };
02591f9febd5f6 Dai Ngo 2021-01-28 93 #endif
0cfcd405e758ba Dai Ngo 2020-10-18 94
:::::: The code at line 90 was first introduced by commit
:::::: 0cfcd405e758ba1d277e58436fb32f06888c3e41 NFSv4.2: Fix NFS4ERR_STALE error when doing inter server copy
:::::: TO: Dai Ngo <dai.ngo(a)oracle.com>
:::::: CC: J. Bruce Fields <bfields(a)redhat.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH V3 2/2] perf/x86: Reset the dirty counter to prevent the leak for an RDPMC task
by kernel test robot
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/perf/core]
[also build test WARNING on tip/master linux/master linus/master v5.12-rc7 next-20210413]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/kan-liang-linux-intel-com/perf-x...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git cface0326a6c2ae5c8f47bd466f07624b3e348a7
config: i386-tinyconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/83f02393e1b5a2723294d8697f4fd5473...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review kan-liang-linux-intel-com/perf-x86-Move-cpuc-running-into-P4-specific-code/20210414-030649
git checkout 83f02393e1b5a2723294d8697f4fd5473d70602c
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/events/core.c:2309:6: warning: no previous prototype for 'x86_pmu_clear_dirty_counters' [-Wmissing-prototypes]
2309 | void x86_pmu_clear_dirty_counters(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/x86_pmu_clear_dirty_counters +2309 arch/x86/events/core.c
2308
> 2309 void x86_pmu_clear_dirty_counters(void)
2310 {
2311 struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
2312 int i;
2313
2314 if (bitmap_empty(cpuc->dirty, X86_PMC_IDX_MAX))
2315 return;
2316
2317 /* Don't need to clear the assigned counter. */
2318 for (i = 0; i < cpuc->n_events; i++)
2319 __clear_bit(cpuc->assign[i], cpuc->dirty);
2320
2321 for_each_set_bit(i, cpuc->dirty, X86_PMC_IDX_MAX) {
2322 /* Metrics and fake events don't have corresponding HW counters. */
2323 if (is_metric_idx(i) || (i == INTEL_PMC_IDX_FIXED_VLBR))
2324 continue;
2325 else if (i >= INTEL_PMC_IDX_FIXED)
2326 wrmsrl(MSR_ARCH_PERFMON_FIXED_CTR0 + (i - INTEL_PMC_IDX_FIXED), 0);
2327 else
2328 wrmsrl(x86_pmu_event_addr(i), 0);
2329 }
2330
2331 bitmap_zero(cpuc->dirty, X86_PMC_IDX_MAX);
2332 }
2333
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[lee-mfd:ib-mfd-clk-gpio-regulator-rtc-5.13 13/16] include/linux/export.h:19:30: warning: the address of 'bd7181x_ramp_table' will always evaluate as 'true'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-clk-gpio-regulator-rtc-5.13
head: 5a8a64d9a38b9d3794f9f5e153fc0358b858cc24
commit: 1aad39001e851cd7ee2d811eb5fd4b044979d9d5 [13/16] regulator: Support ROHM BD71815 regulators
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?id=1a...
git remote add lee-mfd https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
git fetch --no-tags lee-mfd ib-mfd-clk-gpio-regulator-rtc-5.13
git checkout 1aad39001e851cd7ee2d811eb5fd4b044979d9d5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/regulator/bd71815-regulator.c:404:20: error: 'regulator_set_ramp_delay_regmap' undeclared here (not in a function); did you mean 'regulator_set_pull_down_regmap'?
404 | .set_ramp_delay = regulator_set_ramp_delay_regmap,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| regulator_set_pull_down_regmap
drivers/regulator/bd71815-regulator.c:474:5: error: 'struct regulator_desc' has no member named 'ramp_reg'; did you mean 'ramp_delay'?
474 | .ramp_reg = (ereg), \
| ^~~~~~~~
drivers/regulator/bd71815-regulator.c:526:2: note: in expansion of macro 'BD71815_BUCK12_REG'
526 | BD71815_BUCK12_REG(buck1, BD71815_BUCK1, BD71815_REG_BUCK1_VOLT_H,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:475:5: error: 'struct regulator_desc' has no member named 'ramp_mask'
475 | .ramp_mask = BD71815_BUCK_RAMPRATE_MASK, \
| ^~~~~~~~~
drivers/regulator/bd71815-regulator.c:526:2: note: in expansion of macro 'BD71815_BUCK12_REG'
526 | BD71815_BUCK12_REG(buck1, BD71815_BUCK1, BD71815_REG_BUCK1_VOLT_H,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:476:5: error: 'struct regulator_desc' has no member named 'ramp_delay_table'; did you mean 'ramp_delay'?
476 | .ramp_delay_table = bd7181x_ramp_table, \
| ^~~~~~~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:526:2: note: in expansion of macro 'BD71815_BUCK12_REG'
526 | BD71815_BUCK12_REG(buck1, BD71815_BUCK1, BD71815_REG_BUCK1_VOLT_H,
| ^~~~~~~~~~~~~~~~~~
In file included from include/linux/linkage.h:7,
from include/linux/kernel.h:7,
from drivers/regulator/bd71815-regulator.c:11:
>> include/linux/export.h:19:30: warning: the address of 'bd7181x_ramp_table' will always evaluate as 'true' [-Waddress]
19 | #define THIS_MODULE ((struct module *)0)
| ^~~~~~
drivers/regulator/bd71815-regulator.c:467:13: note: in expansion of macro 'THIS_MODULE'
467 | .owner = THIS_MODULE, \
| ^~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:526:2: note: in expansion of macro 'BD71815_BUCK12_REG'
526 | BD71815_BUCK12_REG(buck1, BD71815_BUCK1, BD71815_REG_BUCK1_VOLT_H,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:477:5: error: 'struct regulator_desc' has no member named 'n_ramp_values'
477 | .n_ramp_values = ARRAY_SIZE(bd7181x_ramp_table),\
| ^~~~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:526:2: note: in expansion of macro 'BD71815_BUCK12_REG'
526 | BD71815_BUCK12_REG(buck1, BD71815_BUCK1, BD71815_REG_BUCK1_VOLT_H,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:474:5: error: 'struct regulator_desc' has no member named 'ramp_reg'; did you mean 'ramp_delay'?
474 | .ramp_reg = (ereg), \
| ^~~~~~~~
drivers/regulator/bd71815-regulator.c:529:2: note: in expansion of macro 'BD71815_BUCK12_REG'
529 | BD71815_BUCK12_REG(buck2, BD71815_BUCK2, BD71815_REG_BUCK2_VOLT_H,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:475:5: error: 'struct regulator_desc' has no member named 'ramp_mask'
475 | .ramp_mask = BD71815_BUCK_RAMPRATE_MASK, \
| ^~~~~~~~~
drivers/regulator/bd71815-regulator.c:529:2: note: in expansion of macro 'BD71815_BUCK12_REG'
529 | BD71815_BUCK12_REG(buck2, BD71815_BUCK2, BD71815_REG_BUCK2_VOLT_H,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:476:5: error: 'struct regulator_desc' has no member named 'ramp_delay_table'; did you mean 'ramp_delay'?
476 | .ramp_delay_table = bd7181x_ramp_table, \
| ^~~~~~~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:529:2: note: in expansion of macro 'BD71815_BUCK12_REG'
529 | BD71815_BUCK12_REG(buck2, BD71815_BUCK2, BD71815_REG_BUCK2_VOLT_H,
| ^~~~~~~~~~~~~~~~~~
In file included from include/linux/linkage.h:7,
from include/linux/kernel.h:7,
from drivers/regulator/bd71815-regulator.c:11:
>> include/linux/export.h:19:30: warning: the address of 'bd7181x_ramp_table' will always evaluate as 'true' [-Waddress]
19 | #define THIS_MODULE ((struct module *)0)
| ^~~~~~
drivers/regulator/bd71815-regulator.c:467:13: note: in expansion of macro 'THIS_MODULE'
467 | .owner = THIS_MODULE, \
| ^~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:529:2: note: in expansion of macro 'BD71815_BUCK12_REG'
529 | BD71815_BUCK12_REG(buck2, BD71815_BUCK2, BD71815_REG_BUCK2_VOLT_H,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:477:5: error: 'struct regulator_desc' has no member named 'n_ramp_values'
477 | .n_ramp_values = ARRAY_SIZE(bd7181x_ramp_table),\
| ^~~~~~~~~~~~~
drivers/regulator/bd71815-regulator.c:529:2: note: in expansion of macro 'BD71815_BUCK12_REG'
529 | BD71815_BUCK12_REG(buck2, BD71815_BUCK2, BD71815_REG_BUCK2_VOLT_H,
| ^~~~~~~~~~~~~~~~~~
vim +19 include/linux/export.h
b67067f1176df6 Nicholas Piggin 2016-08-24 4
f50169324df4ad Paul Gortmaker 2011-05-23 5 /*
f50169324df4ad Paul Gortmaker 2011-05-23 6 * Export symbols from the kernel to modules. Forked from module.h
f50169324df4ad Paul Gortmaker 2011-05-23 7 * to reduce the amount of pointless cruft we feed to gcc when only
f50169324df4ad Paul Gortmaker 2011-05-23 8 * exporting a simple symbol or two.
f50169324df4ad Paul Gortmaker 2011-05-23 9 *
b92021b09df70c Rusty Russell 2013-03-15 10 * Try not to add #includes here. It slows compilation and makes kernel
b92021b09df70c Rusty Russell 2013-03-15 11 * hackers place grumpy comments in header files.
f50169324df4ad Paul Gortmaker 2011-05-23 12 */
f50169324df4ad Paul Gortmaker 2011-05-23 13
b92021b09df70c Rusty Russell 2013-03-15 14 #ifndef __ASSEMBLY__
f50169324df4ad Paul Gortmaker 2011-05-23 15 #ifdef MODULE
f50169324df4ad Paul Gortmaker 2011-05-23 16 extern struct module __this_module;
f50169324df4ad Paul Gortmaker 2011-05-23 17 #define THIS_MODULE (&__this_module)
f50169324df4ad Paul Gortmaker 2011-05-23 18 #else
f50169324df4ad Paul Gortmaker 2011-05-23 @19 #define THIS_MODULE ((struct module *)0)
f50169324df4ad Paul Gortmaker 2011-05-23 20 #endif
f50169324df4ad Paul Gortmaker 2011-05-23 21
:::::: The code at line 19 was first introduced by commit
:::::: f50169324df4ad942e544386d136216c8617636a module.h: split out the EXPORT_SYMBOL into export.h
:::::: TO: Paul Gortmaker <paul.gortmaker(a)windriver.com>
:::::: CC: Paul Gortmaker <paul.gortmaker(a)windriver.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[lee-mfd:ib-mfd-clk-gpio-regulator-rtc-5.13 12/16] drivers/regulator/bd718x7-regulator.c:351:20: error: 'regulator_set_ramp_delay_regmap' undeclared here (not in a function); did you mean 'regulator_set_pull_down_regmap'?
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-clk-gpio-regulator-rtc-5.13
head: 5a8a64d9a38b9d3794f9f5e153fc0358b858cc24
commit: 18f3c62586f7b4e1f038f570acda61a25c97c4ee [12/16] regulator: bd718x7, bd71828: Use ramp-delay helper
config: i386-randconfig-s002-20210414 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-280-g2cd6d34e-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?id=18...
git remote add lee-mfd https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
git fetch --no-tags lee-mfd ib-mfd-clk-gpio-regulator-rtc-5.13
git checkout 18f3c62586f7b4e1f038f570acda61a25c97c4ee
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
>> drivers/regulator/bd718x7-regulator.c:351:20: error: 'regulator_set_ramp_delay_regmap' undeclared here (not in a function); did you mean 'regulator_set_pull_down_regmap'?
351 | .set_ramp_delay = regulator_set_ramp_delay_regmap,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| regulator_set_pull_down_regmap
>> drivers/regulator/bd718x7-regulator.c:618:5: error: 'struct regulator_desc' has no member named 'ramp_delay_table'; did you mean 'ramp_delay'?
618 | .ramp_delay_table = bd718xx_ramp_delay,
| ^~~~~~~~~~~~~~~~
| ramp_delay
>> drivers/regulator/bd718x7-regulator.c:618:24: warning: initialization of 'unsigned int' from 'const unsigned int *' makes integer from pointer without a cast [-Wint-conversion]
618 | .ramp_delay_table = bd718xx_ramp_delay,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:618:24: note: (near initialization for 'bd71847_regulators[0].desc.min_uV')
>> drivers/regulator/bd718x7-regulator.c:619:5: error: 'struct regulator_desc' has no member named 'n_ramp_values'
619 | .n_ramp_values = ARRAY_SIZE(bd718xx_ramp_delay),
| ^~~~~~~~~~~~~
>> drivers/regulator/bd718x7-regulator.c:620:5: error: 'struct regulator_desc' has no member named 'ramp_reg'; did you mean 'ramp_delay'?
620 | .ramp_reg = BD718XX_REG_BUCK1_CTRL,
| ^~~~~~~~
| ramp_delay
>> drivers/regulator/bd718x7-regulator.c:621:5: error: 'struct regulator_desc' has no member named 'ramp_mask'
621 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~
drivers/regulator/bd718x7-regulator.c:655:5: error: 'struct regulator_desc' has no member named 'ramp_delay_table'; did you mean 'ramp_delay'?
655 | .ramp_delay_table = bd718xx_ramp_delay,
| ^~~~~~~~~~~~~~~~
| ramp_delay
drivers/regulator/bd718x7-regulator.c:655:24: warning: initialization of 'unsigned int' from 'const unsigned int *' makes integer from pointer without a cast [-Wint-conversion]
655 | .ramp_delay_table = bd718xx_ramp_delay,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:655:24: note: (near initialization for 'bd71847_regulators[1].desc.off_on_delay')
drivers/regulator/bd718x7-regulator.c:656:5: error: 'struct regulator_desc' has no member named 'n_ramp_values'
656 | .n_ramp_values = ARRAY_SIZE(bd718xx_ramp_delay),
| ^~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:657:5: error: 'struct regulator_desc' has no member named 'ramp_reg'; did you mean 'ramp_delay'?
657 | .ramp_reg = BD718XX_REG_BUCK2_CTRL,
| ^~~~~~~~
| ramp_delay
>> drivers/regulator/bd718x7-regulator.c:657:16: warning: initialization of 'unsigned int (*)(unsigned int)' from 'int' makes pointer from integer without a cast [-Wint-conversion]
657 | .ramp_reg = BD718XX_REG_BUCK2_CTRL,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:657:16: note: (near initialization for 'bd71847_regulators[1].desc.of_map_mode')
drivers/regulator/bd718x7-regulator.c:658:5: error: 'struct regulator_desc' has no member named 'ramp_mask'
658 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~
In file included from drivers/regulator/bd718x7-regulator.c:9:
>> include/linux/mfd/rohm-bd718x7.h:122:28: warning: excess elements in struct initializer
122 | #define BUCK_RAMPRATE_MASK 0xC0
| ^~~~
drivers/regulator/bd718x7-regulator.c:658:17: note: in expansion of macro 'BUCK_RAMPRATE_MASK'
658 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~~~~~~~~~~
include/linux/mfd/rohm-bd718x7.h:122:28: note: (near initialization for 'bd71847_regulators[1].desc')
122 | #define BUCK_RAMPRATE_MASK 0xC0
| ^~~~
drivers/regulator/bd718x7-regulator.c:658:17: note: in expansion of macro 'BUCK_RAMPRATE_MASK'
658 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:966:5: error: 'struct regulator_desc' has no member named 'ramp_delay_table'; did you mean 'ramp_delay'?
966 | .ramp_delay_table = bd718xx_ramp_delay,
| ^~~~~~~~~~~~~~~~
| ramp_delay
drivers/regulator/bd718x7-regulator.c:966:24: warning: initialization of 'unsigned int' from 'const unsigned int *' makes integer from pointer without a cast [-Wint-conversion]
966 | .ramp_delay_table = bd718xx_ramp_delay,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:966:24: note: (near initialization for 'bd71837_regulators[0].desc.off_on_delay')
drivers/regulator/bd718x7-regulator.c:967:5: error: 'struct regulator_desc' has no member named 'n_ramp_values'
967 | .n_ramp_values = ARRAY_SIZE(bd718xx_ramp_delay),
| ^~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:968:5: error: 'struct regulator_desc' has no member named 'ramp_reg'; did you mean 'ramp_delay'?
968 | .ramp_reg = BD718XX_REG_BUCK1_CTRL,
| ^~~~~~~~
| ramp_delay
drivers/regulator/bd718x7-regulator.c:968:16: warning: initialization of 'unsigned int (*)(unsigned int)' from 'int' makes pointer from integer without a cast [-Wint-conversion]
968 | .ramp_reg = BD718XX_REG_BUCK1_CTRL,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:968:16: note: (near initialization for 'bd71837_regulators[0].desc.of_map_mode')
drivers/regulator/bd718x7-regulator.c:969:5: error: 'struct regulator_desc' has no member named 'ramp_mask'
969 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~
In file included from drivers/regulator/bd718x7-regulator.c:9:
>> include/linux/mfd/rohm-bd718x7.h:122:28: warning: excess elements in struct initializer
122 | #define BUCK_RAMPRATE_MASK 0xC0
| ^~~~
drivers/regulator/bd718x7-regulator.c:969:17: note: in expansion of macro 'BUCK_RAMPRATE_MASK'
969 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~~~~~~~~~~
include/linux/mfd/rohm-bd718x7.h:122:28: note: (near initialization for 'bd71837_regulators[0].desc')
122 | #define BUCK_RAMPRATE_MASK 0xC0
| ^~~~
drivers/regulator/bd718x7-regulator.c:969:17: note: in expansion of macro 'BUCK_RAMPRATE_MASK'
969 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:1004:5: error: 'struct regulator_desc' has no member named 'ramp_delay_table'; did you mean 'ramp_delay'?
1004 | .ramp_delay_table = bd718xx_ramp_delay,
| ^~~~~~~~~~~~~~~~
| ramp_delay
drivers/regulator/bd718x7-regulator.c:1004:24: warning: initialization of 'unsigned int' from 'const unsigned int *' makes integer from pointer without a cast [-Wint-conversion]
1004 | .ramp_delay_table = bd718xx_ramp_delay,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:1004:24: note: (near initialization for 'bd71837_regulators[1].desc.off_on_delay')
drivers/regulator/bd718x7-regulator.c:1005:5: error: 'struct regulator_desc' has no member named 'n_ramp_values'
1005 | .n_ramp_values = ARRAY_SIZE(bd718xx_ramp_delay),
| ^~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:1006:5: error: 'struct regulator_desc' has no member named 'ramp_reg'; did you mean 'ramp_delay'?
1006 | .ramp_reg = BD718XX_REG_BUCK2_CTRL,
| ^~~~~~~~
| ramp_delay
drivers/regulator/bd718x7-regulator.c:1006:16: warning: initialization of 'unsigned int (*)(unsigned int)' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1006 | .ramp_reg = BD718XX_REG_BUCK2_CTRL,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:1006:16: note: (near initialization for 'bd71837_regulators[1].desc.of_map_mode')
drivers/regulator/bd718x7-regulator.c:1007:5: error: 'struct regulator_desc' has no member named 'ramp_mask'
1007 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~
In file included from drivers/regulator/bd718x7-regulator.c:9:
>> include/linux/mfd/rohm-bd718x7.h:122:28: warning: excess elements in struct initializer
122 | #define BUCK_RAMPRATE_MASK 0xC0
| ^~~~
drivers/regulator/bd718x7-regulator.c:1007:17: note: in expansion of macro 'BUCK_RAMPRATE_MASK'
1007 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~~~~~~~~~~
include/linux/mfd/rohm-bd718x7.h:122:28: note: (near initialization for 'bd71837_regulators[1].desc')
122 | #define BUCK_RAMPRATE_MASK 0xC0
| ^~~~
drivers/regulator/bd718x7-regulator.c:1007:17: note: in expansion of macro 'BUCK_RAMPRATE_MASK'
1007 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:1039:5: error: 'struct regulator_desc' has no member named 'ramp_delay_table'; did you mean 'ramp_delay'?
1039 | .ramp_delay_table = bd718xx_ramp_delay,
| ^~~~~~~~~~~~~~~~
| ramp_delay
drivers/regulator/bd718x7-regulator.c:1039:24: warning: initialization of 'unsigned int' from 'const unsigned int *' makes integer from pointer without a cast [-Wint-conversion]
1039 | .ramp_delay_table = bd718xx_ramp_delay,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:1039:24: note: (near initialization for 'bd71837_regulators[2].desc.off_on_delay')
drivers/regulator/bd718x7-regulator.c:1040:5: error: 'struct regulator_desc' has no member named 'n_ramp_values'
1040 | .n_ramp_values = ARRAY_SIZE(bd718xx_ramp_delay),
| ^~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:1041:5: error: 'struct regulator_desc' has no member named 'ramp_reg'; did you mean 'ramp_delay'?
1041 | .ramp_reg = BD71837_REG_BUCK3_CTRL,
| ^~~~~~~~
| ramp_delay
drivers/regulator/bd718x7-regulator.c:1041:16: warning: initialization of 'unsigned int (*)(unsigned int)' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1041 | .ramp_reg = BD71837_REG_BUCK3_CTRL,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:1041:16: note: (near initialization for 'bd71837_regulators[2].desc.of_map_mode')
drivers/regulator/bd718x7-regulator.c:1042:5: error: 'struct regulator_desc' has no member named 'ramp_mask'
1042 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~
In file included from drivers/regulator/bd718x7-regulator.c:9:
>> include/linux/mfd/rohm-bd718x7.h:122:28: warning: excess elements in struct initializer
122 | #define BUCK_RAMPRATE_MASK 0xC0
| ^~~~
drivers/regulator/bd718x7-regulator.c:1042:17: note: in expansion of macro 'BUCK_RAMPRATE_MASK'
1042 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~~~~~~~~~~
include/linux/mfd/rohm-bd718x7.h:122:28: note: (near initialization for 'bd71837_regulators[2].desc')
122 | #define BUCK_RAMPRATE_MASK 0xC0
| ^~~~
drivers/regulator/bd718x7-regulator.c:1042:17: note: in expansion of macro 'BUCK_RAMPRATE_MASK'
1042 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:1072:5: error: 'struct regulator_desc' has no member named 'ramp_delay_table'; did you mean 'ramp_delay'?
1072 | .ramp_delay_table = bd718xx_ramp_delay,
| ^~~~~~~~~~~~~~~~
| ramp_delay
drivers/regulator/bd718x7-regulator.c:1072:24: warning: initialization of 'unsigned int' from 'const unsigned int *' makes integer from pointer without a cast [-Wint-conversion]
1072 | .ramp_delay_table = bd718xx_ramp_delay,
| ^~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:1072:24: note: (near initialization for 'bd71837_regulators[3].desc.off_on_delay')
drivers/regulator/bd718x7-regulator.c:1073:5: error: 'struct regulator_desc' has no member named 'n_ramp_values'
1073 | .n_ramp_values = ARRAY_SIZE(bd718xx_ramp_delay),
| ^~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:1074:5: error: 'struct regulator_desc' has no member named 'ramp_reg'; did you mean 'ramp_delay'?
1074 | .ramp_reg = BD71837_REG_BUCK4_CTRL,
| ^~~~~~~~
| ramp_delay
drivers/regulator/bd718x7-regulator.c:1074:16: warning: initialization of 'unsigned int (*)(unsigned int)' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1074 | .ramp_reg = BD71837_REG_BUCK4_CTRL,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/regulator/bd718x7-regulator.c:1074:16: note: (near initialization for 'bd71837_regulators[3].desc.of_map_mode')
drivers/regulator/bd718x7-regulator.c:1075:5: error: 'struct regulator_desc' has no member named 'ramp_mask'
1075 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~
In file included from drivers/regulator/bd718x7-regulator.c:9:
>> include/linux/mfd/rohm-bd718x7.h:122:28: warning: excess elements in struct initializer
122 | #define BUCK_RAMPRATE_MASK 0xC0
| ^~~~
drivers/regulator/bd718x7-regulator.c:1075:17: note: in expansion of macro 'BUCK_RAMPRATE_MASK'
1075 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~~~~~~~~~~
include/linux/mfd/rohm-bd718x7.h:122:28: note: (near initialization for 'bd71837_regulators[3].desc')
122 | #define BUCK_RAMPRATE_MASK 0xC0
| ^~~~
drivers/regulator/bd718x7-regulator.c:1075:17: note: in expansion of macro 'BUCK_RAMPRATE_MASK'
1075 | .ramp_mask = BUCK_RAMPRATE_MASK,
| ^~~~~~~~~~~~~~~~~~
vim +351 drivers/regulator/bd718x7-regulator.c
284
285 BD718XX_OPS(bd718xx_pickable_range_buck_ops,
286 regulator_list_voltage_pickable_linear_range, NULL,
287 regulator_set_voltage_sel_pickable_regmap,
288 regulator_get_voltage_sel_pickable_regmap,
289 regulator_set_voltage_time_sel, NULL);
290
291 BD718XX_OPS(bd718xx_ldo_regulator_ops, regulator_list_voltage_linear_range,
292 NULL, bd718xx_set_voltage_sel_restricted,
293 regulator_get_voltage_sel_regmap, NULL, NULL);
294
295 BD718XX_OPS(bd718xx_ldo_regulator_nolinear_ops, regulator_list_voltage_table,
296 NULL, bd718xx_set_voltage_sel_restricted,
297 regulator_get_voltage_sel_regmap, NULL, NULL);
298
299 BD718XX_OPS(bd718xx_buck_regulator_ops, regulator_list_voltage_linear_range,
300 NULL, regulator_set_voltage_sel_regmap,
301 regulator_get_voltage_sel_regmap, regulator_set_voltage_time_sel,
302 NULL);
303
304 BD718XX_OPS(bd718xx_buck_regulator_nolinear_ops, regulator_list_voltage_table,
305 regulator_map_voltage_ascend, regulator_set_voltage_sel_regmap,
306 regulator_get_voltage_sel_regmap, regulator_set_voltage_time_sel,
307 NULL);
308
309 /*
310 * OPS for BD71837
311 */
312 BD718XX_OPS(bd71837_pickable_range_ldo_ops,
313 regulator_list_voltage_pickable_linear_range, NULL,
314 bd71837_set_voltage_sel_pickable_restricted,
315 regulator_get_voltage_sel_pickable_regmap, NULL, NULL);
316
317 BD718XX_OPS(bd71837_pickable_range_buck_ops,
318 regulator_list_voltage_pickable_linear_range, NULL,
319 bd71837_set_voltage_sel_pickable_restricted,
320 regulator_get_voltage_sel_pickable_regmap,
321 regulator_set_voltage_time_sel, NULL);
322
323 BD718XX_OPS(bd71837_ldo_regulator_ops, regulator_list_voltage_linear_range,
324 NULL, bd71837_set_voltage_sel_restricted,
325 regulator_get_voltage_sel_regmap, NULL, NULL);
326
327 BD718XX_OPS(bd71837_ldo_regulator_nolinear_ops, regulator_list_voltage_table,
328 NULL, bd71837_set_voltage_sel_restricted,
329 regulator_get_voltage_sel_regmap, NULL, NULL);
330
331 BD718XX_OPS(bd71837_buck_regulator_ops, regulator_list_voltage_linear_range,
332 NULL, bd71837_set_voltage_sel_restricted,
333 regulator_get_voltage_sel_regmap, regulator_set_voltage_time_sel,
334 NULL);
335
336 BD718XX_OPS(bd71837_buck_regulator_nolinear_ops, regulator_list_voltage_table,
337 regulator_map_voltage_ascend, bd718xx_set_voltage_sel_restricted,
338 regulator_get_voltage_sel_regmap, regulator_set_voltage_time_sel,
339 NULL);
340 /*
341 * BD71837 bucks 3 and 4 support defining their enable/disable state also
342 * when buck enable state is under HW state machine control. In that case the
343 * bit [2] in CTRL register is used to indicate if regulator should be ON.
344 */
345 static const struct regulator_ops bd71837_buck34_ops_hwctrl = {
346 .is_enabled = bd71837_get_buck34_enable_hwctrl,
347 .list_voltage = regulator_list_voltage_linear_range,
348 .set_voltage_sel = regulator_set_voltage_sel_regmap,
349 .get_voltage_sel = regulator_get_voltage_sel_regmap,
350 .set_voltage_time_sel = regulator_set_voltage_time_sel,
> 351 .set_ramp_delay = regulator_set_ramp_delay_regmap,
352 };
353
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months