[thierryreding:for-5.13/work 38/47] drivers/memory/tegra/tegra186.c:125:24: error: no member named 'ids' in 'struct iommu_fwspec'
by kernel test robot
tree: https://github.com/thierryreding/linux for-5.13/work
head: b2ea517f55a84b7036d299279e4fc672fd91c156
commit: 95f8d102ec805060169853c20fa75db5b429421d [38/47] memory: tegra: Implement SID override programming
config: arm64-randconfig-r022-20210413 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/thierryreding/linux/commit/95f8d102ec805060169853c20fa...
git remote add thierryreding https://github.com/thierryreding/linux
git fetch --no-tags thierryreding for-5.13/work
git checkout 95f8d102ec805060169853c20fa75db5b429421d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers/memory/tegra/tegra186.c:125:24: error: no member named 'ids' in 'struct iommu_fwspec'
u32 sid = fwspec->ids[0] & MC_SID_STREAMID_OVERRIDE_MASK;
~~~~~~ ^
1 error generated.
vim +125 drivers/memory/tegra/tegra186.c
111
112 static int tegra186_mc_probe_device(struct tegra_mc *mc, struct device *dev)
113 {
114 struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
115 struct of_phandle_args args;
116 unsigned int i, index = 0;
117
118 while (!of_parse_phandle_with_args(dev->of_node, "interconnects", "#interconnect-cells",
119 index, &args)) {
120 if (args.np == mc->dev->of_node && args.args_count != 0) {
121 for (i = 0; i < mc->soc->num_clients; i++) {
122 const struct tegra_mc_client *client = &mc->soc->clients[i];
123
124 if (client->id == args.args[0]) {
> 125 u32 sid = fwspec->ids[0] & MC_SID_STREAMID_OVERRIDE_MASK;
126
127 tegra186_mc_client_sid_override(mc, client, sid);
128 }
129 }
130 }
131
132 index++;
133 }
134
135 return 0;
136 }
137
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH net-next 7/7] net: korina: Make driver COMPILE_TESTable
by kernel test robot
Hi Thomas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Thomas-Bogendoerfer/net-Korina-i...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8ef7adc6beb2ef0bce83513dc9e4505e7b21e8c2
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c92cee3d78d891046f2668b2d82c37589...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thomas-Bogendoerfer/net-Korina-improvements/20210414-045102
git checkout c92cee3d78d891046f2668b2d82c375899d387a4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/korina.c: In function 'korina_rx':
>> drivers/net/ethernet/korina.c:675:10: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551613' to '4294967293' [-Woverflow]
675 | writel(~DMA_STAT_DONE, &lp->rx_dma_regs->dmas);
drivers/net/ethernet/korina.c:681:10: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551591' to '4294967271' [-Woverflow]
681 | writel(~(DMA_STAT_HALT | DMA_STAT_ERR),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +675 drivers/net/ethernet/korina.c
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 586
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 587 static int korina_rx(struct net_device *dev, int limit)
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 588 {
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 589 struct korina_private *lp = netdev_priv(dev);
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 590 struct dma_desc *rd = &lp->rd_ring[lp->rx_next_done];
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 591 struct sk_buff *skb, *skb_new;
4cf83b664fc14f drivers/net/korina.c Phil Sutter 2009-01-14 592 u32 devcs, pkt_len, dmas;
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 593 dma_addr_t ca;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 594 int count;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 595
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 596 for (count = 0; count < limit; count++) {
4cf83b664fc14f drivers/net/korina.c Phil Sutter 2009-01-14 597 skb = lp->rx_skb[lp->rx_next_done];
4cf83b664fc14f drivers/net/korina.c Phil Sutter 2009-01-14 598 skb_new = NULL;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 599
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 600 devcs = rd->devcs;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 601
4cf83b664fc14f drivers/net/korina.c Phil Sutter 2009-01-14 602 if ((KORINA_RBSIZE - (u32)DMA_COUNT(rd->control)) == 0)
4cf83b664fc14f drivers/net/korina.c Phil Sutter 2009-01-14 603 break;
4cf83b664fc14f drivers/net/korina.c Phil Sutter 2009-01-14 604
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 605 ca = rd->ca;
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 606
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 607 /* check that this is a whole packet
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 608 * WARNING: DMA_FD bit incorrectly set
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 609 * in Rc32434 (errata ref #077) */
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 610 if (!(devcs & ETH_RX_LD))
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 611 goto next;
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 612
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 613 if (!(devcs & ETH_RX_ROK)) {
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 614 /* Update statistics counters */
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 615 dev->stats.rx_errors++;
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 616 dev->stats.rx_dropped++;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 617 if (devcs & ETH_RX_CRC)
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 618 dev->stats.rx_crc_errors++;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 619 if (devcs & ETH_RX_LE)
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 620 dev->stats.rx_length_errors++;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 621 if (devcs & ETH_RX_OVR)
b1011b375be106 drivers/net/korina.c Phil Sutter 2010-05-29 622 dev->stats.rx_fifo_errors++;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 623 if (devcs & ETH_RX_CV)
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 624 dev->stats.rx_frame_errors++;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 625 if (devcs & ETH_RX_CES)
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 626 dev->stats.rx_frame_errors++;
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 627
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 628 goto next;
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 629 }
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 630
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 631 /* Malloc up new buffer. */
89d71a66c40d62 drivers/net/korina.c Eric Dumazet 2009-10-13 632 skb_new = netdev_alloc_skb_ip_align(dev, KORINA_RBSIZE);
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 633 if (!skb_new)
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 634 break;
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 635
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 636 ca = dma_map_single(lp->dmadev, skb_new->data, KORINA_RBSIZE,
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 637 DMA_FROM_DEVICE);
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 638 if (dma_mapping_error(lp->dmadev, ca)) {
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 639 dev_kfree_skb_any(skb_new);
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 640 break;
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 641 }
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 642
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 643 pkt_len = RCVPKT_LENGTH(devcs);
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 644 dma_unmap_single(lp->dmadev, rd->ca, pkt_len, DMA_FROM_DEVICE);
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 645
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 646 /* Do not count the CRC */
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 647 skb_put(skb, pkt_len - 4);
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 648 skb->protocol = eth_type_trans(skb, dev);
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 649
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 650 /* Pass the packet to upper layers */
247c78f2bed0c4 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 651 napi_gro_receive(&lp->napi, skb);
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 652 dev->stats.rx_packets++;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 653 dev->stats.rx_bytes += pkt_len;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 654
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 655 /* Update the mcast stats */
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 656 if (devcs & ETH_RX_MP)
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 657 dev->stats.multicast++;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 658
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 659 lp->rx_skb[lp->rx_next_done] = skb_new;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 660
364a97f5d1ae31 drivers/net/ethernet/korina.c Roman Yeryomin 2017-09-17 661 next:
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 662 rd->devcs = 0;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 663
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 664 /* Restore descriptor's curr_addr */
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 665 rd->ca = ca;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 666
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 667 rd->control = DMA_COUNT(KORINA_RBSIZE) |
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 668 DMA_DESC_COD | DMA_DESC_IOD;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 669 lp->rd_ring[(lp->rx_next_done - 1) &
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 670 KORINA_RDS_MASK].control &=
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 671 ~DMA_DESC_COD;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 672
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 673 lp->rx_next_done = (lp->rx_next_done + 1) & KORINA_RDS_MASK;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 674 rd = &lp->rd_ring[lp->rx_next_done];
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 @675 writel(~DMA_STAT_DONE, &lp->rx_dma_regs->dmas);
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 676 }
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 677
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 678 dmas = readl(&lp->rx_dma_regs->dmas);
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 679
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 680 if (dmas & DMA_STAT_HALT) {
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 681 writel(~(DMA_STAT_HALT | DMA_STAT_ERR),
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 682 &lp->rx_dma_regs->dmas);
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 683
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 684 lp->dma_halt_cnt++;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 685 rd->devcs = 0;
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 686 writel(korina_rx_dma(lp, rd - lp->rd_ring),
69e8eeb0eae052 drivers/net/ethernet/korina.c Thomas Bogendoerfer 2021-04-13 687 &lp->rx_dma_regs->dmandptr);
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 688 }
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 689
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 690 return count;
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 691 }
ef11291bcd5f96 drivers/net/korina.c Florian Fainelli 2008-03-19 692
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [RESEND PATCH 1/2] delayacct: refactor the code to simplify the implementation
by kernel test robot
Hi brookxu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.12-rc7 next-20210413]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/brookxu/delayacct-refactor-the-c...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 89698becf06d341a700913c3d89ce2a914af69a2
config: x86_64-randconfig-a014-20210413 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/37860ad48e2e1c1b332172849833ebb49...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review brookxu/delayacct-refactor-the-code-to-simplify-the-implementation/20210413-093934
git checkout 37860ad48e2e1c1b332172849833ebb49802d0a8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> kernel/cgroup/cgroup-v1.c:730:8: error: implicit declaration of function 'delayacct_is_task_waiting_on_io' [-Werror,-Wimplicit-function-declaration]
if (delayacct_is_task_waiting_on_io(tsk))
^
1 error generated.
vim +/delayacct_is_task_waiting_on_io +730 kernel/cgroup/cgroup-v1.c
0a268dbd7932c7 Tejun Heo 2016-12-27 676
0a268dbd7932c7 Tejun Heo 2016-12-27 677 /**
0a268dbd7932c7 Tejun Heo 2016-12-27 678 * cgroupstats_build - build and fill cgroupstats
0a268dbd7932c7 Tejun Heo 2016-12-27 679 * @stats: cgroupstats to fill information into
0a268dbd7932c7 Tejun Heo 2016-12-27 680 * @dentry: A dentry entry belonging to the cgroup for which stats have
0a268dbd7932c7 Tejun Heo 2016-12-27 681 * been requested.
0a268dbd7932c7 Tejun Heo 2016-12-27 682 *
0a268dbd7932c7 Tejun Heo 2016-12-27 683 * Build and fill cgroupstats so that taskstats can export it to user
0a268dbd7932c7 Tejun Heo 2016-12-27 684 * space.
0a268dbd7932c7 Tejun Heo 2016-12-27 685 */
0a268dbd7932c7 Tejun Heo 2016-12-27 686 int cgroupstats_build(struct cgroupstats *stats, struct dentry *dentry)
0a268dbd7932c7 Tejun Heo 2016-12-27 687 {
0a268dbd7932c7 Tejun Heo 2016-12-27 688 struct kernfs_node *kn = kernfs_node_from_dentry(dentry);
0a268dbd7932c7 Tejun Heo 2016-12-27 689 struct cgroup *cgrp;
0a268dbd7932c7 Tejun Heo 2016-12-27 690 struct css_task_iter it;
0a268dbd7932c7 Tejun Heo 2016-12-27 691 struct task_struct *tsk;
0a268dbd7932c7 Tejun Heo 2016-12-27 692
0a268dbd7932c7 Tejun Heo 2016-12-27 693 /* it should be kernfs_node belonging to cgroupfs and is a directory */
0a268dbd7932c7 Tejun Heo 2016-12-27 694 if (dentry->d_sb->s_type != &cgroup_fs_type || !kn ||
0a268dbd7932c7 Tejun Heo 2016-12-27 695 kernfs_type(kn) != KERNFS_DIR)
0a268dbd7932c7 Tejun Heo 2016-12-27 696 return -EINVAL;
0a268dbd7932c7 Tejun Heo 2016-12-27 697
0a268dbd7932c7 Tejun Heo 2016-12-27 698 mutex_lock(&cgroup_mutex);
0a268dbd7932c7 Tejun Heo 2016-12-27 699
0a268dbd7932c7 Tejun Heo 2016-12-27 700 /*
0a268dbd7932c7 Tejun Heo 2016-12-27 701 * We aren't being called from kernfs and there's no guarantee on
0a268dbd7932c7 Tejun Heo 2016-12-27 702 * @kn->priv's validity. For this and css_tryget_online_from_dir(),
0a268dbd7932c7 Tejun Heo 2016-12-27 703 * @kn->priv is RCU safe. Let's do the RCU dancing.
0a268dbd7932c7 Tejun Heo 2016-12-27 704 */
0a268dbd7932c7 Tejun Heo 2016-12-27 705 rcu_read_lock();
e0aed7c74f0bf6 Tejun Heo 2016-12-27 706 cgrp = rcu_dereference(*(void __rcu __force **)&kn->priv);
0a268dbd7932c7 Tejun Heo 2016-12-27 707 if (!cgrp || cgroup_is_dead(cgrp)) {
0a268dbd7932c7 Tejun Heo 2016-12-27 708 rcu_read_unlock();
0a268dbd7932c7 Tejun Heo 2016-12-27 709 mutex_unlock(&cgroup_mutex);
0a268dbd7932c7 Tejun Heo 2016-12-27 710 return -ENOENT;
0a268dbd7932c7 Tejun Heo 2016-12-27 711 }
0a268dbd7932c7 Tejun Heo 2016-12-27 712 rcu_read_unlock();
0a268dbd7932c7 Tejun Heo 2016-12-27 713
bc2fb7ed089ffd Tejun Heo 2017-05-15 714 css_task_iter_start(&cgrp->self, 0, &it);
0a268dbd7932c7 Tejun Heo 2016-12-27 715 while ((tsk = css_task_iter_next(&it))) {
0a268dbd7932c7 Tejun Heo 2016-12-27 716 switch (tsk->state) {
0a268dbd7932c7 Tejun Heo 2016-12-27 717 case TASK_RUNNING:
0a268dbd7932c7 Tejun Heo 2016-12-27 718 stats->nr_running++;
0a268dbd7932c7 Tejun Heo 2016-12-27 719 break;
0a268dbd7932c7 Tejun Heo 2016-12-27 720 case TASK_INTERRUPTIBLE:
0a268dbd7932c7 Tejun Heo 2016-12-27 721 stats->nr_sleeping++;
0a268dbd7932c7 Tejun Heo 2016-12-27 722 break;
0a268dbd7932c7 Tejun Heo 2016-12-27 723 case TASK_UNINTERRUPTIBLE:
0a268dbd7932c7 Tejun Heo 2016-12-27 724 stats->nr_uninterruptible++;
0a268dbd7932c7 Tejun Heo 2016-12-27 725 break;
0a268dbd7932c7 Tejun Heo 2016-12-27 726 case TASK_STOPPED:
0a268dbd7932c7 Tejun Heo 2016-12-27 727 stats->nr_stopped++;
0a268dbd7932c7 Tejun Heo 2016-12-27 728 break;
0a268dbd7932c7 Tejun Heo 2016-12-27 729 default:
0a268dbd7932c7 Tejun Heo 2016-12-27 @730 if (delayacct_is_task_waiting_on_io(tsk))
0a268dbd7932c7 Tejun Heo 2016-12-27 731 stats->nr_io_wait++;
0a268dbd7932c7 Tejun Heo 2016-12-27 732 break;
0a268dbd7932c7 Tejun Heo 2016-12-27 733 }
0a268dbd7932c7 Tejun Heo 2016-12-27 734 }
0a268dbd7932c7 Tejun Heo 2016-12-27 735 css_task_iter_end(&it);
0a268dbd7932c7 Tejun Heo 2016-12-27 736
0a268dbd7932c7 Tejun Heo 2016-12-27 737 mutex_unlock(&cgroup_mutex);
0a268dbd7932c7 Tejun Heo 2016-12-27 738 return 0;
0a268dbd7932c7 Tejun Heo 2016-12-27 739 }
0a268dbd7932c7 Tejun Heo 2016-12-27 740
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[mchinth: sep_socwatch_linux_5_9 19/41] drivers/platform/x86/socwatch/sw_output_buffer.c:398:6: warning: no previous prototype for function 'reset_output_buffers'
by kernel test robot
tree: https://github.com/mchinth/linux sep_socwatch_linux_5_9
head: 7296486889985b9d9895a39f551764a4b0425bea
commit: e65547c5a9bb37e907edecece4da7cb12dadea96 [19/41] platform/x86: Use $(srctree) instead of $(src) to adapt to kbuild regression
config: x86_64-randconfig-r016-20210413 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/mchinth/linux/commit/e65547c5a9bb37e907edecece4da7cb12...
git remote add mchinth https://github.com/mchinth/linux
git fetch --no-tags mchinth sep_socwatch_linux_5_9
git checkout e65547c5a9bb37e907edecece4da7cb12dadea96
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/platform/x86/socwatch/sw_output_buffer.c:398:6: warning: no previous prototype for function 'reset_output_buffers' [-Wmissing-prototypes]
void reset_output_buffers(void)
^
drivers/platform/x86/socwatch/sw_output_buffer.c:398:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void reset_output_buffers(void)
^
static
1 warning generated.
--
>> drivers/platform/x86/socwatch/sw_collector.c:86:1: warning: no previous prototype for function 'sw_copy_driver_interface_info_i' [-Wmissing-prototypes]
sw_copy_driver_interface_info_i(const struct sw_driver_interface_info *info)
^
drivers/platform/x86/socwatch/sw_collector.c:85:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct sw_driver_interface_info *
^
static
>> drivers/platform/x86/socwatch/sw_collector.c:116:5: warning: no previous prototype for function 'sw_init_driver_interface_info_i' [-Wmissing-prototypes]
int sw_init_driver_interface_info_i(struct sw_driver_interface_info *info)
^
drivers/platform/x86/socwatch/sw_collector.c:116:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int sw_init_driver_interface_info_i(struct sw_driver_interface_info *info)
^
static
>> drivers/platform/x86/socwatch/sw_collector.c:138:5: warning: no previous prototype for function 'sw_init_ops_i' [-Wmissing-prototypes]
int sw_init_ops_i(const struct sw_hw_ops **ops,
^
drivers/platform/x86/socwatch/sw_collector.c:138:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int sw_init_ops_i(const struct sw_hw_ops **ops,
^
static
>> drivers/platform/x86/socwatch/sw_collector.c:157:8: warning: no previous prototype for function 'sw_get_payload_size_i' [-Wmissing-prototypes]
size_t sw_get_payload_size_i(const struct sw_driver_interface_info *info)
^
drivers/platform/x86/socwatch/sw_collector.c:157:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
size_t sw_get_payload_size_i(const struct sw_driver_interface_info *info)
^
static
>> drivers/platform/x86/socwatch/sw_collector.c:175:1: warning: no previous prototype for function 'sw_alloc_collector_msg_i' [-Wmissing-prototypes]
sw_alloc_collector_msg_i(const struct sw_driver_interface_info *info,
^
drivers/platform/x86/socwatch/sw_collector.c:174:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
sw_driver_msg_t *
^
static
>> drivers/platform/x86/socwatch/sw_collector.c:211:26: warning: no previous prototype for function 'sw_alloc_ops_i' [-Wmissing-prototypes]
const struct sw_hw_ops **sw_alloc_ops_i(pw_u16_t num_io_descriptors)
^
drivers/platform/x86/socwatch/sw_collector.c:211:7: note: declare 'static' if the function is not intended to be used outside of this translation unit
const struct sw_hw_ops **sw_alloc_ops_i(pw_u16_t num_io_descriptors)
^
static
>> drivers/platform/x86/socwatch/sw_collector.c:323:6: warning: no previous prototype for function 'sw_free_driver_interface_info_i' [-Wmissing-prototypes]
void sw_free_driver_interface_info_i(struct sw_driver_interface_info *info)
^
drivers/platform/x86/socwatch/sw_collector.c:323:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void sw_free_driver_interface_info_i(struct sw_driver_interface_info *info)
^
static
>> drivers/platform/x86/socwatch/sw_collector.c:329:6: warning: no previous prototype for function 'sw_free_ops_i' [-Wmissing-prototypes]
void sw_free_ops_i(const struct sw_hw_ops **ops)
^
drivers/platform/x86/socwatch/sw_collector.c:329:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void sw_free_ops_i(const struct sw_hw_ops **ops)
^
static
>> drivers/platform/x86/socwatch/sw_collector.c:335:5: warning: no previous prototype for function 'sw_reset_driver_interface_info_i' [-Wmissing-prototypes]
int sw_reset_driver_interface_info_i(struct sw_driver_interface_info *info)
^
drivers/platform/x86/socwatch/sw_collector.c:335:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int sw_reset_driver_interface_info_i(struct sw_driver_interface_info *info)
^
static
>> drivers/platform/x86/socwatch/sw_collector.c:453:6: warning: no previous prototype for function 'sw_free_collector_msg_i' [-Wmissing-prototypes]
void sw_free_collector_msg_i(sw_driver_msg_t *msg)
^
drivers/platform/x86/socwatch/sw_collector.c:453:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void sw_free_collector_msg_i(sw_driver_msg_t *msg)
^
static
>> drivers/platform/x86/socwatch/sw_collector.c:459:6: warning: no previous prototype for function 'sw_handle_per_cpu_msg_i' [-Wmissing-prototypes]
void sw_handle_per_cpu_msg_i(void *info, enum sw_wakeup_action action)
^
drivers/platform/x86/socwatch/sw_collector.c:459:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void sw_handle_per_cpu_msg_i(void *info, enum sw_wakeup_action action)
^
static
11 warnings generated.
--
drivers/platform/x86/socwatch/sw_telem.c:239:32: error: implicit declaration of function 'ioremap_nocache' [-Werror,-Wimplicit-function-declaration]
s_punitInterfaceAddr = (u64 *)ioremap_nocache(
^
drivers/platform/x86/socwatch/sw_telem.c:239:32: note: did you mean 'ioremap_cache'?
arch/x86/include/asm/io.h:185:22: note: 'ioremap_cache' declared here
extern void __iomem *ioremap_cache(resource_size_t offset, unsigned long size);
^
drivers/platform/x86/socwatch/sw_telem.c:239:25: warning: cast to 'u64 *' (aka 'unsigned long long *') from smaller integer type 'int' [-Wint-to-pointer-cast]
s_punitInterfaceAddr = (u64 *)ioremap_nocache(
^~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/x86/socwatch/sw_telem.c:242:20: warning: cast to 'u64 *' (aka 'unsigned long long *') from smaller integer type 'int' [-Wint-to-pointer-cast]
s_punitDataAddr = (u64 *)ioremap_nocache(
^~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/x86/socwatch/sw_telem.c:245:50: warning: cast to 'u64 *' (aka 'unsigned long long *') from smaller integer type 'int' [-Wint-to-pointer-cast]
s_telemEventInfo[TELEM_PUNIT].ssram_virt_addr = (u64 *)ioremap_nocache(
^~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/x86/socwatch/sw_telem.c:280:27: error: implicit declaration of function 'ioremap_nocache' [-Werror,-Wimplicit-function-declaration]
s_pmcIPCCmdAddr = (u64 *)ioremap_nocache(
^
drivers/platform/x86/socwatch/sw_telem.c:280:20: warning: cast to 'u64 *' (aka 'unsigned long long *') from smaller integer type 'int' [-Wint-to-pointer-cast]
s_pmcIPCCmdAddr = (u64 *)ioremap_nocache(
^~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/x86/socwatch/sw_telem.c:283:20: warning: cast to 'u64 *' (aka 'unsigned long long *') from smaller integer type 'int' [-Wint-to-pointer-cast]
s_pmcIPCStsAddr = (u64 *)ioremap_nocache(
^~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/x86/socwatch/sw_telem.c:286:21: warning: cast to 'u64 *' (aka 'unsigned long long *') from smaller integer type 'int' [-Wint-to-pointer-cast]
s_pmcIPCWBufAddr = (u64 *)ioremap_nocache(
^~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/x86/socwatch/sw_telem.c:289:21: warning: cast to 'u64 *' (aka 'unsigned long long *') from smaller integer type 'int' [-Wint-to-pointer-cast]
s_pmcIPCRBufAddr = (u64 *)ioremap_nocache(
^~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/x86/socwatch/sw_telem.c:292:48: warning: cast to 'u64 *' (aka 'unsigned long long *') from smaller integer type 'int' [-Wint-to-pointer-cast]
s_telemEventInfo[TELEM_PMC].ssram_virt_addr = (u64 *)ioremap_nocache(
^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/platform/x86/socwatch/sw_telem.c:671:5: warning: no previous prototype for function 'read_telem' [-Wmissing-prototypes]
int read_telem(u64 *dst, enum telemetry_unit unit, bool should_retry)
^
drivers/platform/x86/socwatch/sw_telem.c:671:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int read_telem(u64 *dst, enum telemetry_unit unit, bool should_retry)
^
static
9 warnings and 2 errors generated.
vim +/reset_output_buffers +398 drivers/platform/x86/socwatch/sw_output_buffer.c
688e338c753b33c Faycal Benmlih 2019-04-23 397
688e338c753b33c Faycal Benmlih 2019-04-23 @398 void reset_output_buffers(void)
688e338c753b33c Faycal Benmlih 2019-04-23 399 {
688e338c753b33c Faycal Benmlih 2019-04-23 400 buffer.read_index = buffer.write_index = 0;
688e338c753b33c Faycal Benmlih 2019-04-23 401 }
688e338c753b33c Faycal Benmlih 2019-04-23 402
:::::: The code at line 398 was first introduced by commit
:::::: 688e338c753b33c023de3b774f7347effbf537a4 Platform/x86: Update SoCWatch driver code to 2.10
:::::: TO: Faycal Benmlih <faycal.benmlih(a)intel.com>
:::::: CC: Faycal Benmlih <faycal.benmlih(a)intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[peterz-queue:sched/core-sched 27/29] kernel/sched/core.c:5696:12: error: dereferencing pointer to incomplete type 'struct task_group'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core-sched
head: a2f7c8bee1740fc80a75734268b065c96d68d29b
commit: 520bf37d416584c0aca5a190d922d4db145e5d91 [27/29] sched: Cgroup core-scheduling interface
config: i386-randconfig-r003-20210413 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?...
git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
git fetch --no-tags peterz-queue sched/core-sched
git checkout 520bf37d416584c0aca5a190d922d4db145e5d91
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
kernel/sched/core.c:3166:6: warning: no previous prototype for 'sched_set_stop_task' [-Wmissing-prototypes]
3166 | void sched_set_stop_task(int cpu, struct task_struct *stop)
| ^~~~~~~~~~~~~~~~~~~
kernel/sched/core.c: In function 'sched_core_cgroup_online':
>> kernel/sched/core.c:5696:12: error: dereferencing pointer to incomplete type 'struct task_group'
5696 | if (parent->core_parent) {
| ^~
At top level:
kernel/sched/core.c:5712:22: warning: 'sched_core_cgroup_cookie' defined but not used [-Wunused-function]
5712 | static unsigned long sched_core_cgroup_cookie(struct task_group *tg)
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/core.c:5707:13: warning: 'sched_core_cgroup_free' defined but not used [-Wunused-function]
5707 | static void sched_core_cgroup_free(struct task_group *tg)
| ^~~~~~~~~~~~~~~~~~~~~~
kernel/sched/core.c:5692:13: warning: 'sched_core_cgroup_online' defined but not used [-Wunused-function]
5692 | static void sched_core_cgroup_online(struct task_group *parent, struct task_group *tg)
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +5696 kernel/sched/core.c
5691
5692 static void sched_core_cgroup_online(struct task_group *parent, struct task_group *tg)
5693 {
5694 lockdep_assert_held(&cgroup_mutex);
5695
> 5696 if (parent->core_parent) {
5697 WARN_ON_ONCE(parent->core_cookie);
5698 WARN_ON_ONCE(!parent->core_parent->core_cookie);
5699 tg->core_parent = parent->core_parent;
5700
5701 } else if (parent->core_cookie) {
5702 WARN_ON_ONCE(parent->core_parent);
5703 tg->core_parent = parent;
5704 }
5705 }
5706
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
Re: [PATCH V3 2/2] perf/x86: Reset the dirty counter to prevent the leak for an RDPMC task
by kernel test robot
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/perf/core]
[also build test WARNING on tip/master linux/master linus/master v5.12-rc7 next-20210413]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/kan-liang-linux-intel-com/perf-x...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git cface0326a6c2ae5c8f47bd466f07624b3e348a7
config: x86_64-randconfig-a014-20210413 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/83f02393e1b5a2723294d8697f4fd5473...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review kan-liang-linux-intel-com/perf-x86-Move-cpuc-running-into-P4-specific-code/20210414-030649
git checkout 83f02393e1b5a2723294d8697f4fd5473d70602c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/x86/events/core.c:2309:6: warning: no previous prototype for function 'x86_pmu_clear_dirty_counters' [-Wmissing-prototypes]
void x86_pmu_clear_dirty_counters(void)
^
arch/x86/events/core.c:2309:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void x86_pmu_clear_dirty_counters(void)
^
static
1 warning generated.
vim +/x86_pmu_clear_dirty_counters +2309 arch/x86/events/core.c
2308
> 2309 void x86_pmu_clear_dirty_counters(void)
2310 {
2311 struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
2312 int i;
2313
2314 if (bitmap_empty(cpuc->dirty, X86_PMC_IDX_MAX))
2315 return;
2316
2317 /* Don't need to clear the assigned counter. */
2318 for (i = 0; i < cpuc->n_events; i++)
2319 __clear_bit(cpuc->assign[i], cpuc->dirty);
2320
2321 for_each_set_bit(i, cpuc->dirty, X86_PMC_IDX_MAX) {
2322 /* Metrics and fake events don't have corresponding HW counters. */
2323 if (is_metric_idx(i) || (i == INTEL_PMC_IDX_FIXED_VLBR))
2324 continue;
2325 else if (i >= INTEL_PMC_IDX_FIXED)
2326 wrmsrl(MSR_ARCH_PERFMON_FIXED_CTR0 + (i - INTEL_PMC_IDX_FIXED), 0);
2327 else
2328 wrmsrl(x86_pmu_event_addr(i), 0);
2329 }
2330
2331 bitmap_zero(cpuc->dirty, X86_PMC_IDX_MAX);
2332 }
2333
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months
[mchinth:sep_socwatch_linux_5_9 1/1] drivers/platform/x86/socperf/socperfdrv.c:1332:18: sparse: sparse: cast removes address space '__user' of expression
by kernel test robot
Hi Manisha,
First bad commit (maybe != root cause):
tree: https://github.com/mchinth/linux sep_socwatch_linux_5_9
head: c859e634bf058e7963fccc4c1219c1365e925ad4
commit: c859e634bf058e7963fccc4c1219c1365e925ad4 [1/1] platform/x86: Update SEP driver for 5.9 pull
config: x86_64-randconfig-s022-20210413 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-280-g2cd6d34e-dirty
# https://github.com/mchinth/linux/commit/c859e634bf058e7963fccc4c1219c1365...
git remote add mchinth https://github.com/mchinth/linux
git fetch --no-tags mchinth sep_socwatch_linux_5_9
git checkout c859e634bf058e7963fccc4c1219c1365e925ad4
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/platform/x86/socperf/socperfdrv.c:203:13: sparse: sparse: function 'SOCPERF_Read_Data3' with external linkage has definition
drivers/platform/x86/socperf/socperfdrv.c:885:1: sparse: sparse: function 'SOCPERF_Switch_Group3' with external linkage has definition
drivers/platform/x86/socperf/socperfdrv.c:101:22: sparse: sparse: symbol 'socperf_drv_version' was not declared. Should it be static?
drivers/platform/x86/socperf/socperfdrv.c:102:5: sparse: sparse: symbol 'read_unc_ctr_info' was not declared. Should it be static?
drivers/platform/x86/socperf/socperfdrv.c:103:10: sparse: sparse: symbol 'dispatch_uncore' was not declared. Should it be static?
drivers/platform/x86/socperf/socperfdrv.c:104:12: sparse: sparse: symbol 'socperf_drv_cfg' was not declared. Should it be static?
drivers/platform/x86/socperf/socperfdrv.c:105:14: sparse: sparse: symbol 'socperf_global_ec' was not declared. Should it be static?
drivers/platform/x86/socperf/socperfdrv.c:106:14: sparse: sparse: symbol 'socperf_abnormal_terminate' was not declared. Should it be static?
drivers/platform/x86/socperf/socperfdrv.c:107:11: sparse: sparse: symbol 'socperf_control' was not declared. Should it be static?
drivers/platform/x86/socperf/socperfdrv.c:111:8: sparse: sparse: symbol 'socperf_pcb_size' was not declared. Should it be static?
drivers/platform/x86/socperf/socperfdrv.c:984:28: sparse: sparse: Using plain integer as NULL pointer
drivers/platform/x86/socperf/socperfdrv.c:1070:6: sparse: sparse: symbol 'lwpmudrv_Stop_Mem' was not declared. Should it be static?
drivers/platform/x86/socperf/socperfdrv.c:1155:15: sparse: sparse: symbol 'socperf_Service_IOCTL' was not declared. Should it be static?
drivers/platform/x86/socperf/socperfdrv.c:1274:6: sparse: sparse: symbol 'socperf_Device_Control' was not declared. Should it be static?
>> drivers/platform/x86/socperf/socperfdrv.c:1332:18: sparse: sparse: cast removes address space '__user' of expression
drivers/platform/x86/socperf/socperfdrv.c:1334:18: sparse: sparse: cast removes address space '__user' of expression
drivers/platform/x86/socperf/socperfdrv.c:1307:6: sparse: sparse: symbol 'socperf_Device_Control_Compat' was not declared. Should it be static?
drivers/platform/x86/socperf/socperfdrv.c:1358:5: sparse: sparse: symbol 'SOCPERF_Abnormal_Terminate' was not declared. Should it be static?
vim +/__user +1332 drivers/platform/x86/socperf/socperfdrv.c
f57492d07625dd Manisha Chinthapally 2019-05-01 1305
f57492d07625dd Manisha Chinthapally 2019-05-01 1306 #if defined(CONFIG_COMPAT) && defined(DRV_EM64T)
f57492d07625dd Manisha Chinthapally 2019-05-01 1307 long socperf_Device_Control_Compat(struct file *filp, unsigned int cmd,
f57492d07625dd Manisha Chinthapally 2019-05-01 1308 unsigned long arg)
f57492d07625dd Manisha Chinthapally 2019-05-01 1309 {
f57492d07625dd Manisha Chinthapally 2019-05-01 1310 int status = OS_SUCCESS;
f57492d07625dd Manisha Chinthapally 2019-05-01 1311 IOCTL_COMPAT_ARGS_NODE local_args_compat;
f57492d07625dd Manisha Chinthapally 2019-05-01 1312 IOCTL_ARGS_NODE local_args;
f57492d07625dd Manisha Chinthapally 2019-05-01 1313
f57492d07625dd Manisha Chinthapally 2019-05-01 1314 memset(&local_args_compat, 0, sizeof(IOCTL_COMPAT_ARGS_NODE));
f57492d07625dd Manisha Chinthapally 2019-05-01 1315 SOCPERF_PRINT_DEBUG("Compat: type: %d, subcommand: %d\n",
f57492d07625dd Manisha Chinthapally 2019-05-01 1316 _IOC_TYPE(cmd), _IOC_NR(cmd));
f57492d07625dd Manisha Chinthapally 2019-05-01 1317
f57492d07625dd Manisha Chinthapally 2019-05-01 1318 if (_IOC_TYPE(cmd) != LWPMU_IOC_MAGIC) {
f57492d07625dd Manisha Chinthapally 2019-05-01 1319 SOCPERF_PRINT_ERROR("Unknown IOCTL magic:%d\n", _IOC_TYPE(cmd));
f57492d07625dd Manisha Chinthapally 2019-05-01 1320 return OS_ILLEGAL_IOCTL;
f57492d07625dd Manisha Chinthapally 2019-05-01 1321 }
f57492d07625dd Manisha Chinthapally 2019-05-01 1322
f57492d07625dd Manisha Chinthapally 2019-05-01 1323 MUTEX_LOCK(ioctl_lock);
f57492d07625dd Manisha Chinthapally 2019-05-01 1324 if (arg) {
f57492d07625dd Manisha Chinthapally 2019-05-01 1325 status = copy_from_user(&local_args_compat,
f57492d07625dd Manisha Chinthapally 2019-05-01 1326 (void __user *)arg,
f57492d07625dd Manisha Chinthapally 2019-05-01 1327 sizeof(IOCTL_COMPAT_ARGS_NODE));
f57492d07625dd Manisha Chinthapally 2019-05-01 1328 }
f57492d07625dd Manisha Chinthapally 2019-05-01 1329 local_args.len_drv_to_usr = local_args_compat.len_drv_to_usr;
f57492d07625dd Manisha Chinthapally 2019-05-01 1330 local_args.len_usr_to_drv = local_args_compat.len_usr_to_drv;
f57492d07625dd Manisha Chinthapally 2019-05-01 1331 local_args.buf_drv_to_usr =
f57492d07625dd Manisha Chinthapally 2019-05-01 @1332 (char *)compat_ptr(local_args_compat.buf_drv_to_usr);
f57492d07625dd Manisha Chinthapally 2019-05-01 1333 local_args.buf_usr_to_drv =
f57492d07625dd Manisha Chinthapally 2019-05-01 1334 (char *)compat_ptr(local_args_compat.buf_usr_to_drv);
f57492d07625dd Manisha Chinthapally 2019-05-01 1335
f57492d07625dd Manisha Chinthapally 2019-05-01 1336 status = socperf_Service_IOCTL(filp, _IOC_NR(cmd), local_args);
f57492d07625dd Manisha Chinthapally 2019-05-01 1337 MUTEX_UNLOCK(ioctl_lock);
f57492d07625dd Manisha Chinthapally 2019-05-01 1338
f57492d07625dd Manisha Chinthapally 2019-05-01 1339 return status;
f57492d07625dd Manisha Chinthapally 2019-05-01 1340 }
f57492d07625dd Manisha Chinthapally 2019-05-01 1341 #endif
f57492d07625dd Manisha Chinthapally 2019-05-01 1342
:::::: The code at line 1332 was first introduced by commit
:::::: f57492d07625dddac7920eccdb5be08c55ee16fa platform/x86: SOCPERF3 support for sep & socwatch
:::::: TO: Manisha Chinthapally <manisha.chinthapally(a)intel.com>
:::::: CC: Faycal Benmlih <faycal.benmlih(a)intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 5 months